1 2006-12-30 Marek Safar <marek.safar@gmail.com>
3 * cs-parser.jay: Better syntax errors handling.
5 2006-11-21 Marek Safar <marek.safar@gmail.com>
7 * cs-parser.jay: Tiny change to work with mcs tokenizer.
9 * cs-tokenizer.cs: Remove after unification with mcs.
11 2006-10-28 Marek Safar <marek.safar@gmail.com>
14 * generic.cs (ConstructedType.AsAccessible): Check accessibility of type
17 2006-10-26 Marek Safar <marek.safar@gmail.com>
20 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous methods.
22 2006-10-25 Brian Crowell <brian@fluggo.com>
25 * generic.cs (CheckConstraints): Allow generic parameters with
26 inheritance constraints to satisfy reference type constraints.
28 2006-10-09 Martin Baulig <martin@ximian.com>
31 (NullCoalescingOperator.DoResolve): Fix #78964; added gtest-294.cs.
33 2006-09-25 Martin Baulig <martin@ximian.com>
35 * class.cs: Remove after unification with mcs source.
37 2006-09-24 Raja R Harinath <harinath@gmail.com>
39 * convert.cs: Remove after unification with mcs source.
41 2006-09-24 Marek Safar <marek.safar@seznam.cz>
43 * class.cs (MemberBase.VerifyClsCompliance): When method has type
44 parameters verify them as well.
46 * generic.cs (Constraints.VerifyClsCompliance): Verify CLS-Compliance of
47 the type parameter constraints.
48 (Generics.VerifyClsCompliance): Ditto.
50 2006-09-24 Marek Safar <marek.safar@seznam.cz>
52 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
53 for anonymous block with out argument.
55 2006-09-24 Marek Safar <marek.safar@seznam.cz>
57 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
58 not used private events only.
60 2006-09-23 Marek Safar <marek.safar@seznam.cz>
62 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
64 * cs-parser.jay: Parse correctly cast of default (T).
66 * generic.cs (DefaultValueExpression.DoResolve): Check for void type.
67 Store original type via EmptyConstantCast.
69 2006-09-22 Martin Baulig <martin@ximian.com>
71 * delegate.cs: Removed; this file is now shared with mcs.
73 * attribute.cs: Removed; this file is now shared with mcs.
75 2006-09-22 Martin Baulig <martin@ximian.com>
77 * ecore.cs: Removed; this file is now shared with mcs.
79 2006-09-21 Marek Safar <marek.safar@seznam.cz>
81 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
83 * ecore.cs (NullCast): Derives from NullConstant.
85 * generic.cs (DefaultValueExpression): Fixed to cope with the constant
88 2006-09-21 Martin Baulig <martin@ximian.com>
90 * decl.cs: Removed; this file is now shared with mcs.
92 2006-09-21 Raja R Harinath <rharinath@novell.com>
94 * rootcontext.cs: Remove after unification with mcs source.
96 * report.cs: Remove after unification with mcs source.
97 * generic.cs (AddTypeParameter, LookupTypeParameter): Move to
99 (InitGenerics, CleanUpGenerics): Remove.
101 * support.cs: Remove after unification with mcs source.
103 2006-09-20 Raja R Harinath <rharinath@novell.com>
105 * codegen.cs: Remove after unification with mcs source.
107 2006-09-19 Martin Baulig <martin@ximian.com>
109 * expression.cs: Removed; this file is now shared with mcs.
111 2006-09-19 Martin Baulig <martin@ximian.com>
114 (TypeManager.IsEqual): Moved into ../mcs/typemanager.cs.
115 (TypeManager.DropGenericTypeArguments): Likewise.
116 (TypeManager.DropGenericMethodArguments): Likewise.
117 (TypeManager.GetTypeArguments): Likewise.
118 (TypeManager.HasGenericArguments): Likewise.
120 2006-09-19 Martin Baulig <martin@ximian.com>
122 * ecore.cs (PropertyExpr.InstanceResolve): Fix the CS1540 check.
124 2006-09-19 Martin Baulig <martin@ximian.com>
126 * typemanager.cs: Removed; this file is now shared with mcs.
128 2006-09-16 Raja R Harinath <rharinath@novell.com>
130 * Makefile (LOCAL_MCS_FLAGS): Use instead of PROFILE_MCS_FLAGS.
131 * AssemblyInfo.cs, driver.cs: Remove after unification with mcs source.
133 2006-09-16 Marek Safar <marek.safar@seznam.cz>
136 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
137 only if parent type is class.
138 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
141 2006-09-15 Marek Safar <marek.safar@seznam.cz>
144 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
146 * typemanager.cs(CSharpName): Converts NullType to null.
148 2006-09-15 Martin Baulig <martin@ximian.com>
150 * pending.cs: Removed; this file is now shared with mcs.
152 2006-09-15 Martin Baulig <martin@ximian.com>
154 * statement.cs: Removed; this file is now shared with mcs.
156 2006-09-15 Martin Baulig <martin@ximian.com>
158 * rootcontext.cs (RootContext.BrokenCircularDeps): Removed.
160 * driver.cs: Removed the `--broken-cycles' argument.
162 2006-09-15 Martin Baulig <martin@ximian.com>
164 * namespace.cs: Removed; this file is now shared with mcs.
166 2006-09-15 Martin Baulig <martin@ximian.com>
168 * decl.cs (MemberName): Minor code cleanups.
170 2006-09-15 Martin Baulig <martin@ximian.com>
172 * parameter.cs: Removed; this file is now shared with mcs.
174 2006-09-15 Martin Baulig <martin@ximian.com>
176 * enum.cs: Removed; this file is now shared with mcs.
178 2006-09-15 Martin Baulig <martin@ximian.com>
180 * Makefile: Define `GMCS_SOURCE'.
182 * flowanalysis.cs: Removed; this file is now shared with mcs.
184 2006-09-15 Martin Baulig <martin@ximian.com>
186 Removed modifiers.cs, literal.cs, location.cs, roottypes.cs,
187 assign.cs, const.cs, cfold.cs, constant.cs, symbolwriter.cs and
188 doc.cs - they are now shared with mcs.
190 * gmcs.exe.sources: Include these files from ../mcs/.
192 2006-09-15 Martin Baulig <martin@ximian.com>
194 * old-code.cs, gen-il.cs, gen-treedump.cs: Removed old stuff.
195 * g1.cs, sample-hello.cs, sample-stack.il: Likewise.
197 2006-09-14 Marek Safar <marek.safar@seznam.cz>
199 * assign.cs, ecore.cs, expression.cs: Share error message text.
200 * class.cs (FieldMember.Define): Check for variable of static type.
201 * decl.cs (check_type_parameter): Report correct type name.
202 * driver.cs (LoadAssembly): Uses error output for errors.
203 * generic.cs (Constraints.Resolve): Add check for constraint accessibility
204 (TypeArguments.Resolve): Static class cannot be used as an argument.
205 * statement.cs (ResolveMeta): Constants cannot be generic types.
207 2006-09-12 Martin Baulig <martin@ximian.com>
209 * generic.cs (TypeManager.IsIList): Moved into convert.cs.
211 * convert.cs (Convert.Array_To_IList): Moved here and correctly
212 implement it; fixes #79345.
214 2006-09-08 Marek Safar <marek.safar@seznam.cz>
216 * decl.cs (DeclSpace.SetParameterInfo): Check for nonexistent type
218 * expression.cs (TypeOf.GetAttributableValue): Check for open generic
220 * generic.cs: Improved error messages.
221 * typemanager.cs (RemoveGenericArity): Made public.
223 2006-09-08 Martin Baulig <martin@ximian.com>
225 * typemanager.cs (TypeManager.interlocked_type): New public field.
226 (TypeManager.int_interlocked_compare-exchange): New public field.
227 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
228 enumerator types here and call InitGenericCoreTypes().
229 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
230 after calling InitEnumUnderlyingTypes().
233 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
234 `classes_second_stage'.
236 2006-09-07 Marek Safar <marek.safar@seznam.cz>
238 * class.cs, generic.cs (GenericMethod.Define): Check for type parameter
240 * statement.cs (Block.Variables): Made public.
242 2006-09-07 Martin Baulig <martin@ximian.com>
245 (MainDriver): Revert r62663 from Marek; see #70506 for details.
247 2006-09-01 Martin Baulig <martin@ximian.com>
250 (TypeManager.IsIList): Also handle base classes and interfaces.
252 2006-09-01 Raja R Harinath <rharinath@novell.com>
255 * expression.cs (Invocation.MoreSpecific): Check for reference
258 2006-08-29 Miguel de Icaza <miguel@novell.com>
260 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
262 2006-08-17 Miguel de Icaza <miguel@novell.com>
264 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
265 #52019 and #79064, the use of the \uXXXX sequence in source code
266 to represent unicode characters.
268 2006-08-15 Marek Safar <marek.safar@seznam.cz>
270 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
272 * class.cs, ecore.cs, statement.cs: Merged to one error message.
274 2006-08-14 Raja R Harinath <rharinath@novell.com>
277 * cs-tokenizer.cs (parse_less_than): Allow '*' to appear in a type
278 parameter too. This only avoids a parse error -- the semantic
279 error is caught elsewhere.
281 2006-08-13 Miguel de Icaza <miguel@novell.com>
283 * assign.cs: Catch attempts to assign to a method groups in += and
286 2006-08-13 Marek Safar <marek.safar@seznam.cz>
289 * cs-parser.jay: Don't destroy current array type by typeof of array's.
291 2006-08-12 Marek Safar <marek.safar@seznam.cz>
293 * cs-parser.jay: Check whether a constraint clause has already been
294 specified for type parameter.
295 * generic.cs (Constraints): Exposed location.
297 2006-08-12 Marek Safar <marek.safar@seznam.cz>
299 * class.cs (Method.Define): Issue a warning when generic method looks like
301 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
303 * report.cs: New warning number.
305 2006-08-09 Marek Safar <marek.safar@seznam.cz>
307 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
309 * decl.cs (MemberCache.FindMembers): When container is interface we need to
310 search all base interfaces as a member can be ambiguous.
311 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
312 Constructor member type filter.
313 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
314 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
315 reporting for returned memberinfos.
316 * report.cs: Updated.
317 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
318 version to work on all runtimes.
319 (TypeManager.RealMemberLookup): Removed members filtering.
321 2006-08-08 Raja R Harinath <rharinath@novell.com>
323 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
324 (PropertyExpr.EmitAssign): Likewise.
325 * expression.cs (Indirection.EmitAssign): Likewise.
326 (LocalVariableReference.EmitAssign): Likewise.
327 (ParameterReference.EmitAssign): Likewise.
328 (Invocation.EmitArguments): Likewise.
329 (ArrayAccess.EmitAssign): Likewise.
330 (IndexerAccess.EmitAssign): Likewise.
331 (This.EmitAssign): Likewise.
332 (ConditionalLogicalOperator.Emit): Likewise.
335 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
336 instead of ArrayList. If the hashtable has a LocalBuilder, don't
337 leave it in after returning it.
338 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
340 2006-08-06 Marek Safar <marek.safar@seznam.cz>
342 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
345 2006-08-05 Marek Safar <marek.safar@seznam.cz>
347 * class.cs (TypeContainer.AddPartial): Add check for partial declarations
348 with different type names.
349 (TypeContainer.UpdateTypeParameterConstraints): Updated an error message.
351 2006-08-03 Raja R Harinath <rharinath@novell.com>
353 Fix cs0146-3.cs and cs0146-4.cs.
354 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
355 enclosing types don't depend on the current type.
357 2006-08-02 Raja R Harinath <rharinath@novell.com>
360 * class.cs (TypeContainer.DoDefineMembers): Use
361 FindBaseMemberWithSameName on Parent, since we're interested in
362 whether we hide inherited members or not.
363 (FindBaseMemberWithSameName): Make slightly more robust.
366 * codegen.cs (IResolveContext.GenericDeclContainer): New.
367 (EmitContext): Implement new interface requirement.
368 * namespace.cs (UsingEntry, LocalAliasEntry): Likewise.
369 * decl.cs (MemberCore): Likewise.
370 (DeclSpace.GenericDeclContainer): Rename from DeclContainer.
371 * ecore.cs (SimpleName.ResolveAsTypeTerminal): Use
372 ec.GenericDeclContainer to check for generic parameters.
373 (SimpleName.DoSimpleNameResolve): Likewise.
374 * generic.cs (TypeParameter.DeclContainer): Remove override.
376 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
377 declspaces for doppelgangers too.
378 (UsingEntry): Implement IResolveContext.
379 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
380 'this' as the resolve context.
381 (LocalAliasEntry): Likewise.
383 Implement parts of #77403
384 * roottypes.cs (RootDeclSpace): New. Used to represent the
385 toplevel declaration space. Each namespace declaration introduces
386 a "partial" root declaretion space.
387 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
388 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
389 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
390 from 'current_namespace.SlaveDeclSpace'.
391 (namespace_declaration): Likewise.
392 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
393 check. It can't happen now.
394 * decl.cs (DeclSpace.LookupType): Likewise.
395 * driver.cs (MainDriver): Sanity check.
397 2006-08-01 Raja R Harinath <rharinath@novell.com>
399 * decl.cs (DeclSpace.FindNestedType): Remove.
400 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
401 LookupTypeContainer to get the container of the nested type.
402 * class.cs (TypeContainer.FindNestedType): Make non-override.
404 2006-07-31 Raja R Harinath <rharinath@novell.com>
406 * decl.cs (DeclSpace.PartialContainer): Move field from ...
407 * class.cs (TypeContainer.PartialContainer): ... here.
408 (TypeContainer.AddBasesForPart): New helper.
409 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
411 * cs-parser.jay (current_class): Convert to DeclSpace.
412 (struct_declaration, interface_declaration, class_declaration):
413 Use AddBasesForPart instead of .Bases directly.
414 * const.cs, iterators.cs: Update to changes.
416 2006-07-28 Raja R Harinath <rharinath@novell.com>
418 * class.cs (TypeContainer.AddMemberType): Rename from
420 (TypeContainer.AddMember): Rename from AddToMemberContainer.
421 (AddTypeContainer): New. Combine AddClassOrStruct and
423 (AddPartial): Update. Add 'is_partial' argument.
424 * roottypes.cs: Update to changes.
425 * cs-parser.jay (push_current_class): New helper for handling
426 current_container and current_class.
427 (struct_declaration, interface_declaration, class_declaration):
430 2006-07-26 Raja R Harinath <rharinath@novell.com>
432 * roottypes.cs: Rename from tree.cs.
434 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
435 * tree.cs (Tree, ITreeDump): Remove types.
436 * rootcontext.cs (tree, Tree): Remove fields.
437 (root, ToplevelTypes): New.
438 * *.cs: Update to rename.
440 * tree.cs (Tree.RecordDecl): Remove.
441 (RootTypes.AddToTypeContainer): Record the toplevel type in its
443 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
445 2006-07-23 Raja R Harinath <harinath@gmail.com>
447 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
448 DoFlowAnalysis and OmitStructFlowAnalysis here.
449 (ec.With): Rename from WithUnsafe and generalize.
450 (ec.WithCheckState): Remove. All users can be handled by 'With'.
451 (ec.WithFlowAnalyis): New.
452 * ecore.cs, expression.cs, statement.cs: Update.
454 2006-07-22 Raja R Harinath <harinath@gmail.com>
456 * statement.cs (Block.ResolveMeta): Simplify slightly.
458 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
459 multiple boolean fields. Convert InUnsafe, constant_check_state,
460 check_state to flags.
461 (CheckState, ConstantCheckState): Update.
462 (InUnsafe): New read-only property.
463 (FlagsHandle): Rename from CheckStateHandle and convert to handle
465 (WithUnsafe): New helper similar to WithCheckState.
466 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
467 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
469 2006-07-21 Raja R Harinath <rharinath@novell.com>
471 Make comparisons use the same IL irrespective of whether they're
472 in a 'checked' or 'unchecked' context: one of the issues in #78899
473 * codegen.cs (EmitContext.CheckState): Make read-only property.
474 (EmitContext.ConstantCheckState): Likewise.
475 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
476 helper that implement a save/restore stack for CheckState
477 values. This is the only way to change check-state.
478 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
479 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
480 (CheckedExpr.EmitBranchable): New forwarding method.
481 (UnCheckedExpr): Likewise.
482 * statement.cs (Block.ResolveMeta): Use WithCheckState.
483 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
484 (Checked.Resolve, checked.DoEmit): Likewise.
486 2006-07-21 Martin Baulig <martin@ximian.com>
488 * generic.cs (TypeManager.InferType): When inferring an array
489 type, also allow IList<T> and ICollection<T>. Fixes #78900.
491 2006-07-21 Martin Baulig <martin@ximian.com>
493 * generic.cs (TypeManager.IsIEnumerable): Renamed into IsIList()
494 and allow IList`1 and all its base interfaces.
496 * convert.cs (Convert.ImplicitReferenceConversion): Allow
497 converting from an array-type of T to IList<T>.
499 2006-07-21 Martin Baulig <martin@ximian.com>
501 * ecore.cs (SimpleName.DoSimpleNameResolve): Added CS0307 check.
503 2006-07-20 Miguel de Icaza <miguel@novell.com>
505 * anonymous.cs: Cache the resolved anonymous delegate, and return
506 this so that the ResolveTopBlock is only triggered once, not
509 Currently we trigger ResolvetopBlock twice due to a first pass of
510 argument check compatibility, and a second pass that does the
513 2006-07-15 Marek Safar <marek.safar@seznam.cz>
515 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
517 * rootcontext.cs (Reset): Add helper_classes.
519 2006-07-15 Marek Safar <marek.safar@seznam.cz>
522 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
525 2006-07-13 Miguel de Icaza <miguel@novell.com>
527 * statement.cs (Lock): Handle expressions of type
528 TypeManager.null_type specially. Fixes #78770
530 2006-07-08 Marek Safar <marek.safar@seznam.cz>
532 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
535 2006-07-08 Marek Safar <marek.safar@seznam.cz>
537 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
538 for accessors as well.
539 * ecore.cs (EventExpr): Add AccessorTable.
541 2006-07-03 Martin Baulig <martin@ximian.com>
543 * ecore.cs (UnboxCast.Emit): Also use `Unbox_Any' for generic
544 instances of value types.
546 * convert.cs (Convert.ExplicitConversion): Correctly handle
547 object->nullable conversions.
549 2006-07-01 Marek Safar <marek.safar@seznam.cz>
552 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
553 for CS0122 where appropriate.
554 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
556 (Filter): Assembly can be null in the case of top level attributes.
558 2006-06-28 Raja R Harinath <rharinath@novell.com>
561 * generic.cs (TypeManager.InferParamsTypeArguments): If there are
562 no arguments, return 'false': nothing can be inferred.
564 2006-06-25 Marek Safar <marek.safar@seznam.cz>
568 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
569 is done at global level.
571 2006-06-24 Marek Safar <marek.safar@seznam.cz>
573 A fix for #77002, Implemented TypeForwarder support.
575 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
576 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Add TypeForwarder
578 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
579 * typemanager.cs (): Add type_forwarder_attr_type.
581 2006-06-24 Marek Safar <marek.safar@seznam.cz>
583 * report.cs: Add CS0469 warning.
585 2006-06-22 Martin Baulig <martin@ximian.com>
588 (TypeContainer.GetNormalBases): Also use ResolveAsBaseTerminal()
589 for interfaces; fixes #78686, which is a modification of #78380
590 with interfaces instead of classes.
592 2006-06-21 Martin Baulig <martin@ximian.com>
594 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
595 the `try'-block, so we also report CS0016 etc. there.
597 2006-06-21 Martin Baulig <martin@ximian.com>
599 * ecore.cs (FieldExpr.EmitAssign, FieldExpr.AddressOf): Correctly
600 handle SetAssigned() and SetMemberIsUsed() for generic types;
603 2006-06-21 Martin Baulig <martin@ximian.com>
606 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
608 2006-06-21 Martin Baulig <martin@ximian.com>
610 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
611 also report CS1686 for parameters.
613 2006-06-21 Martin Baulig <martin@ximian.com>
615 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
616 instead of an error if the value is not implicitly convertible to
617 the switch types; fixes #77964.
619 2006-06-21 Raja R Harinath <rharinath@novell.com>
622 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
623 FieldBuilder is null.
626 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
627 'left' and 'right' before error-checking.
629 2006-06-19 Martin Baulig <martin@ximian.com>
632 (Convert.ImplicitConversionStandard): Cleanup and correctly
633 implement nullable conversions.
634 (Convert.ImplicitStandardConversionExists): Likewise.
635 (Convert.ExplicitConversion): Likewise.
637 2006-06-19 Martin Baulig <martin@ximian.com>
640 (Nullable.Wrap.Create, Nullable.Unwrap.Create): New public static
641 methods; make the ctors protected.
643 2006-06-19 Martin Baulig <martin@ximian.com>
645 Fixed #78380; added gtest-273.cs.
648 (Expression.ResolveAsBaseTerminal): Move the constraint checking
649 into ResolveAsTypeTerminal().
652 (ConstraintChecker.HasDefaultConstructor): Use the non-cache based
653 TypeManager.FindMembers() to check for the default ctor.
655 2006-06-18 Marek Safar <marek.safar@seznam.cz>
657 * generic.cs: Fixed NullableInfo accessibility.
659 2006-06-16 Martin Baulig <martin@ximian.com>
662 (Constraints.InflatedConstraints.inflate): Correctly inflate
663 generic types; fixes #78400.
665 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
667 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
669 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
670 (FieldExpr.DoResolve): likewise.
671 (PropertyExpr.InstanceResolve): likewise.
672 (EventExpr.InstanceResolve): likewise.
674 2006-06-15 Martin Baulig <martin@ximian.com>
677 (SwitchLabel.ResolveAndReduce): Added `bool allow_nullable'
678 argument; always allow a `null' label if true.
679 (Switch.SwitchGoverningType): Take an `Expression expr' argument.
680 (Switch.TableSwitchEmit, Switch.SimpleSwitchEmit): Check whether
681 we have a `null' label and mark the new `null_target' label;
682 default to the `default' label.
683 (Switch.Resolve): Add support for nullable types. Fixes #78630.
685 2006-06-15 Martin Baulig <martin@ximian.com>
687 * class.cs (Operator.Define): Allow an implicit/explicit operator
688 to convert to/from a nullable value of the enclosing type.
690 * generic.cs (TypeManager.IsNullableTypeOf): New public method.
691 (Nullable.Unwrap, Nullable.Wrap): Make these classes public.
694 (Convert.ImplicitStandardConversionExists): Add support for lifted
695 implicit/explicit conversions.
696 (Convert.ImplicitConversionStandard): Likewise.
698 2006-06-13 Martin Baulig <martin@ximian.com>
700 * ecore.cs (SimpleName.DoSimpleNameResolve): Check whether we have
701 type arguments and create a ConstructedType if necessary. Fixes #78400.
703 2006-06-04 Marek Safar <marek.safar@seznam.cz>
705 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
706 attribute applicable tests for attribute argument.
708 2006-06-02 Raja R Harinath <rharinath@novell.com>
711 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
712 (Binary.OverloadResolve_PredefinedIntegral): New.
713 (Binary.OverloadResolve_PredefinedFloating): New.
714 (Binary.OverloadResolve_PredefinedString): New.
715 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
716 Follow the standard more closely, and treat numeric promotions in
717 terms of overload resolution.
718 (Binary.CheckShiftArguments): Simplify.
720 2006-06-01 Raja R Harinath <rharinath@novell.com>
722 * flowanalysis.cs (MyBitVector): Simplify representation.
723 (MyBitVector.Clone): Avoid allocating BitArray.
724 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
725 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
726 (*): Update. Change all references to MyBitVector.And and
727 MyBitVector.Or to &= and |=.
729 2006-05-31 Raja R Harinath <rharinath@novell.com>
731 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
732 Use bne.un instead of ceq+brfalse.
735 * typemanager.cs (IsUnmanagedType): Disallow generic types and
738 2006-05-29 Raja R Harinath <rharinath@novell.com>
741 * cs-parser.jay (formal_parameter_list): Extend the pattern below
742 to param arguments too.
744 2006-05-26 Miguel de Icaza <miguel@novell.com>
746 * cs-parser.jay: Catch another parsing form for arglist being
747 followed by other arguments. Fixes #78313.
749 2006-05-25 Raja R Harinath <rharinath@novell.com>
752 * expression.cs (Binary.DoResolve): Use Nullable.LiftedBinaryOperator
753 also when one of the operands is a null literal.
754 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality): Rewrite
755 to improve clarity, and generate slightly better code.
757 2006-05-24 Raja R Harinath <rharinath@novell.com>
759 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
760 checking of out parameters to ...
761 (FlowBranchingToplevel.Merge): ... here.
762 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
763 set, propagate the origin upward, and only complain if there was
765 (FlowBranchingException.AddContinueOrigin): Likewise.
766 (FlowBranchingException.AddReturnOrigin): Likewise.
767 (FlowBranchingException.AddGotoOrigin): Likewise.
769 2006-05-23 Raja R Harinath <rharinath@novell.com>
771 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
772 unreachable, skip it.
773 (FlowBranchingException.Merge): Always propagate jumps, even if
774 the finally block renders subsequent code unreachable.
776 2006-05-18 Raja R Harinath <rharinath@novell.com>
779 * statement.cs (Goto.Resolve): Move responsibility for resolving
780 'goto' to FlowBranching.AddGotoOrigin.
781 (Goto.SetResolvedTarget): New. Callback to set the
782 LabeledStatement that's the target of the goto.
783 (Goto.DoEmit): Use Leave instead of Br when crossing an
784 unwind-protect boundary.
785 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
786 LookupLabel and adjust to new semantics.
787 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
788 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
789 Goto.SetResolvedTarget to update target.
790 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
791 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
792 AddBreakOrigin & co. Delay propagation until ...
793 (FlowBranchingException.Merge): ... this.
795 * statement.cs (Block.Resolve): Always depend on flow-branching to
796 determine unreachability. Kill workaround that originally emitted
797 only one statement after an "unreachable" label (see infloop in
800 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
801 This is still "wrong", but anything better would probably need a
802 multi-pass algorithm.
803 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
804 usage vector. Force current usage vector to be reachable, to
805 optimistically signify backward jumps.
806 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
808 (FlowBranchingLabeled.Merge): New. If no backward jump was
809 detected, return the original salted-away usage vector instead,
810 updated with appropriate changes. Print unreachable warning if
812 * statement.cs (Block.Resolve): Don't print unreachable warning on
815 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
817 * driver.cs: Pass filename without path to AssemblyBuilder's
818 AddResourceFile. Fixes bug #78407.
820 2006-05-17 Raja R Harinath <rharinath@novell.com>
822 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
823 * flowanalysis.cs (FlowBranchingLabeled): ... here.
824 (FlowBranching.MergeChild): Overwrite
825 reachability information from Labeled branchings too.
827 2006-05-16 Raja R Harinath <rharinath@novell.com>
829 * statement.cs (Goto.Resolve): Merge jump origins here ...
830 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
832 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
833 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
834 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
835 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
837 * statement.cs (Goto.Resolve): ... not here.
838 (Goto.Emit): Remove CS1632 check.
840 2006-05-14 Marek Safar <marek.safar@seznam.cz>
842 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
845 2006-05-11 Raja R Harinath <rharinath@novell.com>
847 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
848 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
849 (FlowBranchingException.Label): Likewise.
851 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
853 (MyBitVector.Or): Use it to avoid losing information (Count).
854 (FlowBranching.MergeOrigins): Likewise.
856 * flowanalysis.cs (UsageVector.IsDirty): Remove.
857 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
858 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
859 (UsageVector.ToString): Simplify.
860 (UsageVector.MergeSiblings): Move here from ...
861 (FlowBranching.Merge): ... here.
862 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
865 2006-05-10 Raja R Harinath <rharinath@novell.com>
867 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
868 null bitvector is treated as all-true.
870 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
871 (MyBitVector): Rationalize invariants. 'vector != null' implies
872 that we have our own copy of the bitvector. Otherwise,
873 'InheritsFrom == null' implies all inherited bits are true.
875 2006-05-09 Marek Safar <marek.safar@seznam.cz>
877 * statement.cs (LocalInfo): Add IsConstant.
878 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
879 local variable for constants.
881 2006-05-09 Raja R Harinath <rharinath@novell.com>
883 * flowanalysis.cs (MyBitVector.Empty): New.
884 (MyBitVector): Don't allow InheritedFrom to be null.
885 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
886 (UsageVector, FlowBranching): Update to changes.
888 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
889 recursion. The 'Parent == null' condition isn't sufficient for
891 (FlowBranching.AddBreakOrigin): Likewise.
892 (FlowBranching.AddContinueOrigin): Likewise.
893 (FlowBranching.AddReturnOrigin): Likewise.
894 (FlowBranching.StealFinallyClauses): Likewise.
895 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
896 (FlowBranching.CheckOutParameters): Likewise.
897 (FlowBranchingToplevel): Terminate all the above recursions here.
898 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
899 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
901 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
903 (FlowBranchingToplevel): New. Empty for now.
904 (FlowBranching.MergeTopBlock): Update.
905 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
906 branching for the anonymous delegate.
907 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
909 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
910 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
911 information at the start of the merge. Reorganize.
913 2006-05-07 Marek Safar <marek.safar@seznam.cz>
915 * class.cs (MethodData.Define): Method cannot implement interface accessor.
917 2006-05-07 Marek Safar <marek.safar@seznam.cz>
919 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
920 to newly introduced ctor.
922 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
923 message to one place.
924 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
927 2006-05-07 Marek Safar <marek.safar@seznam.cz>
929 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
931 * ecore.cs (Expression.ResolveAsConstant): Updated.
933 * statement.cs (ResolveMeta): Updated.
935 2006-05-06 Marek Safar <marek.safar@seznam.cz>
937 * cs-parser.jay: __arglist cannot be used in initializer.
939 2006-05-06 Marek Safar <marek.safar@seznam.cz>
942 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
945 2006-05-05 Raja R Harinath <rharinath@novell.com>
947 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
948 (LabeledStatement): Add 'name' parameter.
949 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
950 (Block.AddLabel): Update to changes.
951 * cs-parser.jay (labeled_statement): Likewise.
953 * flowanalysis.cs (BranchingType.Labeled): New.
954 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
955 (FlowBranchingLabeled): New. Does nothing for now, but will
956 eventually handle 'goto' flows.
957 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
958 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
959 that's terminated ...
960 (Block.Resolve): ... here.
962 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
963 (UsageVector.MergeFinallyOrigins): Likewise.
964 (FlowBranching.InTryOrCatch): Likewise.
965 (FlowBranching.AddFinallyVector): Likewise.
966 (FlowBranchingException): Update to changes.
969 * statement.cs (Return.Resolve): Move error checking to ...
970 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
971 (FlowBranchingException): Handle return origins like break and
973 (FlowBranching.UsageVector.CheckOutParameters): Remove.
975 2006-05-04 Marek Safar <marek.safar@seznam.cz>
978 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
981 2006-05-04 Marek Safar <marek.safar@seznam.cz>
984 * class.cs (MethodData.Define): Do public accessor check only when method
985 implements an interface.
987 2006-05-04 Raja R Harinath <rharinath@novell.com>
989 Remove special handling of 'break'
990 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
991 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
992 (UsageVector.Break): Remove.
993 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
995 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
997 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
998 UsageVector.Breaks (). Don't set NeedsReturnLabel.
1000 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1003 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
1004 be the interface member.
1006 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1009 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
1010 for emitting small (int) values.
1012 2006-05-03 Raja R Harinath <rharinath@novell.com>
1015 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
1016 control-flow passes through the 'finally' after merging-in all the
1017 control-flows from 'try' and the 'catch' clauses.
1019 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
1020 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
1021 always true at the only non-recursive entry point.
1022 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
1023 FlowBranchingBreakable.
1024 (FlowBranchingLoop): Remove.
1025 * statement.cs (Return.DoResolve): Update to changes.
1028 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
1029 (FlowBranching.CreateBranching): Handle it: create a
1030 FlowBranchingContinuable.
1031 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
1032 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
1033 except that it handles the 'continue' command.
1034 (FlowBranching.UsageVector.MergeOrigins): Rename from
1036 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
1037 except that it overrides AddContinueOrigin.
1038 (FlowBranchingException): Override AddContinueOrigin, similar to
1040 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
1041 Create a new branching around the embedded statement.
1042 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
1043 control flow after the embedded statement.
1044 (Continue.Resolve): Move all error checking to AddContinueOrigin.
1046 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
1047 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
1048 FlowBranchingBreakable.
1049 (FlowBranchingSwitch): Remove.
1052 * statement.cs (Break.Resolve): Simplify. Move responsibility for
1053 error reporting to ...
1054 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
1055 Rename from 'AddBreakVector'. Add new location argument. Return
1056 a bool indicating whether the 'break' crosses an unwind-protect.
1057 (FlowBranchingException.AddBreakOrigin): Add.
1058 (FlowBranchingException.Merge): Propagate 'break's to surrounding
1059 flowbranching after updating with the effects of the 'finally'
1061 (FlowBranchingBreakable): New common base class for
1062 FlowBranchingLoop and FlowBranchingSwitch.
1064 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
1066 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
1068 2006-05-02 Raja R Harinath <rharinath@novell.com>
1070 * statement.cs (Do.Resolve): If the loop is infinite, set the
1072 (While.Resolve, For.Resolve): Set a barrier after the embedded
1073 statement. There's no direct control flow that goes from the end
1074 of the embedded statement to the end of the loop.
1075 * flowanalysis.cs (FlowBranching.Infinite): Remove.
1076 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
1077 above ensure that the reachability is correctly computed.
1079 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
1080 (UsageVector.MergeBreakOrigins): If the current path is
1081 unreachable, treat it as if all parameters/locals are initialized.
1082 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
1083 infinite loops before merging-in break origins.
1085 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
1086 (Reachability.Reachable): Split part into ...
1087 (Reachability.Unreachable): ... this. Simplify.
1088 (Reachability.IsUnreachable): Use 'Unreachable' instead.
1090 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
1091 (Reachability.SetThrowsSometimes): Likewise.
1092 (FlowBranchingBlock.MergeTopBlock): Don't compare against
1093 TriState.Always, use corresponding property.
1094 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
1095 (Block.Resolve): Likewise. Remove some redundant checks.
1097 2006-05-02 Raja R Harinath <harinath@gmail.com>
1099 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
1100 (Reachability.Meet): Don't bother checking AlwaysThrows --
1101 barrier is always set.
1102 (FlowBranchingBlock.Merge): Likewise.
1104 2006-05-01 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
1106 * attribute.cs: fixed_buffer_cache is declared only if NET_2_0 is
1107 defined, so it's references should also compile only for NET_2_0
1108 (as occurs in mcs version)
1110 2006-05-01 Raja R Harinath <harinath@gmail.com>
1112 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
1113 checks for unreachable.
1115 2006-05-01 Marek Safar <marek.safar@seznam.cz>
1118 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
1120 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
1121 whether field is really assigned.
1123 2006-04-30 Raja R Harinath <harinath@gmail.com>
1125 * flowanalysis.cs (Reachability): Make 4-argument constructor
1127 (Reachability.Meet): Rename from 'And'. Remove static variant.
1128 (Reachability.Always): Rename from the highly misleading
1129 'Reachability.Never'.
1130 (FlowBranching.Merge): Update to changes. Mark an impossible
1131 situation with a 'throw'.
1132 (*): Update to changes.
1134 2006-04-29 Raja R Harinath <harinath@gmail.com>
1136 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
1138 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
1139 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
1140 (*): Update to changes.
1141 * statement.cs: Update to changes.
1143 2006-04-28 Marek Safar <marek.safar@seznam.cz>
1146 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
1148 2006-04-28 Raja R Harinath <harinath@gmail.com>
1150 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
1153 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
1154 argument to two arguments: an usage-vector and a bool. Move call
1155 to FlowBranching.Merge () ...
1156 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
1158 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
1159 handling of loop and switch reachability to ...
1160 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
1162 2006-04-27 Raja R Harinath <harinath@gmail.com>
1164 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
1165 handling to FlowBranchingLoop.InLoop.
1166 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
1168 2006-04-26 Marek Safar <marek.safar@seznam.cz>
1171 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
1172 anonymous method is allowed from AnonymousContainer here.
1174 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
1176 2006-04-24 Raja R Harinath <rharinath@novell.com>
1179 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
1181 2006-04-23 Marek Safar <marek.safar@seznam.cz>
1184 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
1185 (DoubleConstant.Reduce): Ditto.
1187 2006-04-23 Raja R Harinath <rharinath@novell.com>
1189 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
1190 Remove 'lvalue_right_side' argument. Move parts to ...
1191 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
1192 (LocalVariable.DoResolveLValue): ... these.
1194 2006-04-21 Raja R Harinath <rharinath@novell.com>
1197 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
1198 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
1199 (LocalVariableReference.DoResolveBase): Use it to implement new
1201 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
1202 (Argument.Resolve): Simplify. Move CS1510 check ...
1203 * ecore.cs (Expression.ResolveLValue): ... here.
1204 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
1205 (PropertyExpr.DoResolveLValue): Likewise.
1206 (FieldExpr.Report_AssignToReadonly): Likewise.
1207 (FieldExpr.DoResolve): Add 'out_access' argument. Use
1208 LValueMemberAccess or LValueMemberOutAccess on instance depending
1210 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
1211 DoResolve as appropriate.
1213 2006-04-20 Raja R Harinath <rharinath@novell.com>
1216 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
1217 implicit conversions on 'out' and 'ref' arguments.
1219 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
1220 improve clarity. Remove dead code.
1223 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
1224 (Catch.Resolve): Resolve VarBlock if it exists.
1226 2006-04-19 Miguel de Icaza <miguel@novell.com>
1228 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
1229 twice, this was some residual code, the enumerator was emitted
1230 properly in the two branche of if later.
1234 Thanks to Martin for finding the source of the problem
1236 2006-04-19 Raja R Harinath <rharinath@novell.com>
1238 * expression.cs (Cast.ResolveLValue): Remove. The result of a
1239 cast is never an lvalue.
1240 (Cast.DoResolve, Cast.ResolveRest): Combine.
1241 (Argument.Emit): Simplify slightly. Move 'Expr is
1242 IMemoryLocation' check ...
1243 (Argument.Resolve): ... here.
1244 (Argument.Error_LValueRequired): Remove. Inline into only user.
1246 Simplifications. Fix cs0191-2.cs
1247 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
1248 CS1649 and CS1651 to ...
1249 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
1250 the actual selection of the error code and message to a lookup
1251 table. Add a dummy return value to simplify callsites.
1252 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
1253 readonly fields of other instances of the same type. Move CS0197
1255 * expression.cs (Argument.Resolve): ... here. Simplify code.
1256 Ensure that ec.InRefOutArgumentResolving is only set during LValue
1257 resolution of an out or ref argument. The code simplification
1258 above uses this invariant.
1260 2006-04-18 Raja R Harinath <rharinath@novell.com>
1262 Possibly fix #77752. Fix cs1690-[4-7].cs.
1263 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
1264 CheckMarshallByRefAccess. Drop parameter.
1265 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
1267 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
1269 * report.cs (AllWarnings): Add CS1690.
1270 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
1272 (LocalVariableReference.DoResolveBase): Update.
1274 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1276 * class.cs (MethodOrOperator): Moved common parts from method class.
1277 detect obsolete attributes.
1278 (Method.Define): Simplified as it reuses code from base.
1279 (Constructor.ValidAttributeTargets): Fixed issue found during
1281 (Destructor.ValidAttributeTargets): Fixed issue found during
1283 (Operator): Finished refactoring set off by #78020. Operator class is now
1284 ordinary method class.
1286 * anonymous.cs: Updated.
1288 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1290 * class.cs (Constructor.Emit): Don't emit the attributes twice.
1292 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1294 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
1295 detect obsolete attributes.
1296 (Method.CreateEmitContext): Moved to MethodOrOperator.
1298 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1301 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
1302 customized exception to make crash detection easier.
1303 (MethodOrOperator): Started to work on new base class for methods and
1305 (Method): Derives from MethodOrOperator.
1306 (Constructor.Emit): Emits its own attributes.
1307 (AbstractPropertyEventMethod.Emit): Ditto.
1308 (Operator): Derives from MethodOrOperator, will refactor fully in extra
1310 (Operator.Emit): It's temporary more tricky than should be.
1312 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
1314 * report.cs (InternalErrorException): Add ctor with inner exception.
1316 2006-04-08 Marek Safar <marek.safar@seznam.cz>
1319 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
1322 2006-04-07 Marek Safar <marek.safar@seznam.cz>
1325 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
1328 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1330 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
1331 attribute is present and Guid not.
1332 (Interface.ApplyAttributeBuilder): Ditto.
1334 * attribute.cs: Add error message.
1336 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1340 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
1341 sources (it's composite) so hold them in extra array as they are used in
1342 Emit phase only. It worked in the previous versions by mistake.
1343 (Attribute.Emit): Emit attribute for more owners when exist.
1345 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
1346 it has now different behaviour.
1348 2006-04-04 Marek Safar <marek.safar@seznam.cz>
1350 * constant.cs (Constant.IsDefaultInitializer): New method.
1352 * class.cs: Updated.
1354 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
1355 re-initialize default values. It saves KBs almost for every assembly.
1356 Thanks Zoltan for the idea.
1357 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
1358 (ArrayCreation.DoResolve): Resolve only once.
1359 (ArrayCreation.Emit): Emit static initializer only when it is faster.
1360 (ArrayCreation.GetAttributableValue): Cope with optimized values.
1362 2006-04-03 Zoltan Varga <vargaz@gmail.com>
1364 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
1367 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1369 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
1370 in an embedded statement too.
1372 2006-04-01 Raja R Harinath <rharinath@novell.com>
1375 * typemanager.cs (IsNestedChildOf): Drop generic arguments before
1379 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
1382 * report.cs (SymbolRelatedToPreviousError): Drop generic type
1383 arguments before checking whether a type is reflected or not.
1386 * expression.cs (Invocation.IsApplicable): Ensure a generic method
1387 definition doesn't take part in overload resolution.
1388 (Invocation.IsParamsMethodApplicable): Likewise.
1389 (Invocation.OverloadResolve): When replacing a reflected override
1390 method with its base definition, ensure that type arguments are
1393 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1397 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
1400 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
1402 2006-03-31 Marek Safar <marek.safar@seznam.cz>
1404 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
1407 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
1408 LocalTemporary change.
1410 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
1412 (ClassOrStruct.DefineFieldInitializers): Implemented static field
1413 initializers optimization.
1414 (ClassOrStruct.TypeAttr): Moved from modifiers.
1415 (Constructor.CheckBase): Don't crash when static ctor has parameters.
1416 (FieldBase.ResolveInitializer): Resolves initializer.
1417 (FieldBase.HasDefaultInitializer): New property.
1419 * cs-parser.jay: Removed message.
1421 * expression.cs (CompilerGeneratedThis): New specialization.
1423 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
1425 2006-03-28 Marek Safar <marek.safar@seznam.cz>
1427 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
1429 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1431 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
1432 be now EnumConstants only.
1434 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1436 * attribute.cs, driver.cs: Reset more caches.
1438 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1440 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
1442 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1444 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
1445 for easier reuse. Updated all overrides.
1446 (IntegralConstant): New base class for all integral constants.
1447 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
1448 of the constant range, report custom error.
1449 (UIntConstant.Reduce): Fixed uint conversion.
1451 * ecore.cs, literal.cs: Reduce updates.
1453 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1457 * class.cs (Constructor.Define): Removed extra if for default ctors.
1458 A patch from Atsushi Enomoto.
1460 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1462 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
1463 GetAttributableValue.
1465 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
1468 * convert.cs (ImplicitConversionRequired): Error message moved to
1471 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
1472 automatic implicit conversion of an output value.
1473 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
1475 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
1477 (TypeOf.GetAttributableValue): Add extra handling for object type.
1479 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
1480 special error message.
1482 2006-03-25 Marek Safar <marek.safar@seznam.cz>
1484 * class.cs (Constructor.Emit): Don't crash when struct ctor is
1486 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
1487 compatible with MS runtime.
1489 2006-03-23 Marek Safar <marek.safar@seznam.cz>
1491 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
1492 attribute arguments here.
1494 * class.cs (Indexer.Define): The check was moved to attribute class.
1496 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1498 * expression.cs (StringConcat.Append): Reverted back to no warning state.
1500 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1502 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
1504 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
1507 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
1509 * doc-bootstrap.cs : fix build.
1511 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1513 * expression.cs (StringConcat.Append): Issue a warning when empty string
1516 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1518 * assign.cs (CompoundAssign.ResolveSource): Removed.
1520 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
1523 * class.cs (TypeContainer.FindMethods): Removed.
1524 (TypeContainer.CheckMemberUsage): Made static.
1526 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
1528 * constant.cs (CheckRange): Removed unused type argument.
1529 (CheckUnsigned): Removed unused type argument.
1531 * cs-parser.jay: Updated after MemberAccess clean up.
1532 Uses Length for empty string test.
1534 * cs-tokenizer.cs: Uses Length for empty string test.
1535 (IsCastToken): Made static.
1536 (is_hex): Made static.
1537 (real_type_suffix): Made static.
1539 * decl.cs (SetupCache): Made static.
1540 (OnGenerateDocComment): Removed unused ds argument.
1542 * delegate.cs (VerifyDelegate): Removed unused argument.
1544 * doc.cs: Uses Length for empty string test.
1546 * driver.cs: Uses Length for empty string test.
1548 * enum.cs (IsValidEnumType): Made static
1550 * expression.cs (EnumLiftUp): Removed unused argument.
1551 (ResolveMethodGroup): Ditto.
1552 (BetterConversion): Ditto.
1553 (GetVarargsTypes): Ditto.
1554 (UpdateIndices): Ditto.
1555 (ValidateInitializers): Ditto.
1556 (MemberAccess.ctor): Ditto.
1557 (GetIndexersForType): Ditto.
1559 * flowanalysis.cs: (MergeFinally): Removed unused argument.
1561 * iterators.cs: Updated after MemberAccess clean up.
1563 * location.cs: Uses Length for empty string test.
1565 * namespace.cs: Uses Length for empty string test.
1567 * report.cs (CheckWarningCode): Made static.
1569 * statement.cs (LabeledStatement): Removed unused argument.
1571 * typemanager.cs (FilterNone): Removed.
1573 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1575 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
1578 * class.cs: Updated.
1580 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1582 * cs-parser.jay.cs: __arglist is not allowed for delegates.
1584 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1588 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
1590 (AnonymousMethod.ImplicitStandardConversionExists): New method.
1591 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
1592 Add more error reporting; Fixed issue with params.
1594 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
1596 * cs-parser.jay: AnonymousMethod requires host container.
1598 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
1600 2006-03-18 Raja R Harinath <harinath@gmail.com>
1602 * class.cs: Change 'TypeContainer ds' constructor argument to
1603 'DeclSpace parent'. Some classes were missed below due to
1604 different naming convention.
1606 * class.cs (MemberCore.Parent): Delete. This makes the
1607 ParentContainer changes below enforceable by the compiler.
1609 Treat pointers to enclosing declaration space as 'DeclSpace', not
1611 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
1612 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
1614 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
1616 (Block.AddThisVariable): Likewise.
1617 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
1618 (AbstractPropertyEventMethod.Emit): Likewise.
1619 (AbstractPropertyEventMethod.EmitMethod): Likewise.
1620 (GetMethod.Define, SetMethod.Define): Likewise.
1621 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
1622 (DelegateMethod.EmitMethod): Likewise.
1624 Fix regression test-partial-13.cs.
1625 Rationalize use of PartialContainer. Ensure that the partial
1626 class semantics can be tied to type-correctness, i.e., any
1627 violation will cause a compile error.
1628 * class.cs, const.cs: Access all fields that belong to class
1629 TypeContainer via ParentContainer. Arguments of EmitContexts and
1630 Resolve()-like functions still use 'Parent'.
1632 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
1633 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
1634 (PropertyMethod.CheckModifiers): Remove unused argument.
1635 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
1638 2006-03-28 Raja R Harinath <rharinath@novell.com>
1640 * decl.cs (DeclSpace.LookupGeneric): Update to changes.
1642 2006-03-17 Raja R Harinath <harinath@gmail.com>
1644 Make semantics of PartialContainer simpler.
1645 * decl.cs (DeclSpace.IsPartial): Remove.
1646 * class.cs (TypeContainer.IsPartial): Likewise.
1647 (TypeContainer..ctor): Set PartialContainer to point to self.
1648 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
1649 (TypeContainer.FindNestedType): Likewise.
1650 (MemberCore.ParentContainer): Simplify. Remove deprecation.
1652 2006-03-17 Marek Safar <marek.safar@seznam.cz>
1654 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
1656 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1658 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
1661 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1663 * class.cs (Operator.Define): An error for base conversion was not
1666 2006-03-13 Marek Safar <marek.safar@seznam.cz>
1668 A fix for #77593, #77574.
1670 * class.cs (MethodCore.CheckBase): Another if for operator.
1672 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1676 * expression.cs (VerifyArgumentsCompat): Reverted to double error
1677 reporting, it's more tricky than I thought.
1679 2006-03-09 Marek Safar <marek.safar@seznam.cz>
1681 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
1684 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
1685 (DelegateCreation.ImplicitStandardConversionExists): New method for just
1688 * ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
1691 2006-03-04 Marek Safar <marek.safar@seznam.cz>
1695 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
1696 (Event.Define): ditto
1697 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
1699 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
1700 Removed redundant code and set NewSlot for Invoke method too.
1702 * parameter.cs (Parameters.ctor): Add custom, type ctor.
1703 (Parameters.MergeGenerated): New method. Use this method when you merge
1704 compiler generated argument with user arguments.
1706 2006-03-03 Marek Safar <marek.safar@seznam.cz>
1708 * attribute.cs (ResolveAsTypeTerminal): Removed.
1710 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
1711 specialization for predefined types; 30% speed up.
1712 Finally placed obsolete check to right place.
1713 (Expression.ResolveType): Removed.
1715 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
1716 Updated after ResolveType was removed.
1718 * expression.cs (Cast.ctor): Check void cast.
1719 (Binary.ResolveAsTypeTerminal): Is never type.
1720 (Conditional.ResolveAsTypeTerminal): Is never type.
1722 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
1724 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1726 * rootcontext.cs (ResolveCore): Removed System.INullableValue.
1728 2006-03-23 Martin Baulig <martin@ximian.com>
1730 * expression.cs (Is.DoResolve, As.DoResolve): Perform a dynamic
1731 type check if either of the types is an open generic type.
1733 2006-03-23 Martin Baulig <martin@ximian.com>
1736 (Convert.ExplicitTypeParameterConversion): New method; implement
1737 explicit type parameter conversions.
1739 2006-03-23 Martin Baulig <martin@ximian.com>
1741 * convert.cs (Convert.ImplicitTypeParameterConversion): Do not
1742 blindly allow all conversions if we do not have any constraints.
1744 2006-02-27 Marek Safar <marek.safar@seznam.cz>
1746 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
1747 these two separated members to simplify the code.
1748 (Attribute.Resolve): Refactored to use new fields and methods.
1749 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
1750 implemented obsolete attribute checking.
1751 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
1752 implemented obsolete checking again. It look line never ending quest ;-)
1753 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
1755 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
1757 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
1759 *class.cs (Property.Define): Add RegisterProperty call.
1761 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
1762 argument groups (only 2).
1764 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
1765 encoding expression to arguments.
1766 (Expression.ExprClassToResolveFlags): Just turned to property.
1768 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
1769 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
1770 optimized as well as implemented support for zero-length attributes.
1772 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
1773 Add caching of PropertyInfo's.
1775 2006-02-25 Marek Safar <marek.safar@seznam.cz>
1777 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
1778 error multiple times.
1780 2006-02-25 Marek Safar <marek.safar@seznam.cz>
1782 New partial class implementation.
1783 A fix for #77027, #77029, #77403
1785 * attribute.cs (Attributable): Made attributes protected.
1787 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
1788 the replacements of ClassPart and PartialContainer.
1789 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
1790 (TypeContainer.AddInterface): Ditto.
1791 (TypeContainer.AddPartial): The main method for partial classes. It checks
1792 for errors and merges ModFlags and attributes. At the end class is added to
1794 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
1796 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
1797 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
1798 from the rest of partial classes.
1799 (TypeContainer.GetClassBases): Simplified.
1800 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
1802 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
1803 (TypeContainer.HasExplicitLayout): Uses Flags now.
1804 (PartialContainer): Removed.
1805 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
1806 (StaticClass): Was merged with Class.
1807 (Class.GetClassBases): class and static class bases are verified here.
1808 (Class.TypeAttr): Added static attributes when class is static.
1809 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
1810 (MemberBase): In some cases we need to call parent container for partial
1811 class. It should be eliminated but it's not easy now.
1813 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
1815 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
1816 partial classed to accumulate class comments.
1817 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
1819 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
1821 * driver.cs (MainDriver): Tree.GetDecl was removed.
1823 * modifiers.cs (Modifiers): Add partial modifier.
1825 * tree.cs (Tree.decl): Removed.
1826 (RootTypes): Started to use this class more often for root types
1829 2006-03-23 Raja R Harinath <rharinath@novell.com>
1831 * generic.cs (TypeParameter.UpdateConstraints): Update
1832 'constraints' if null.
1834 2006-02-22 Marek Safar <marek.safar@seznam.cz>
1838 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
1839 external interface does not have an attribute.
1841 2006-02-22 Marek Safar <marek.safar@seznam.cz>
1843 Another prerequisites for new partial classs implementation.
1845 * attribute.cs (Attribute.Equal): Implemented.
1846 (Attribute.Emit): Changed as attributes can be applied more than twice.
1847 (Attributes.Emit): Check for duplicate attributes here.
1849 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
1850 as a parameter, clean-up.
1852 2006-02-11 Marek Safar <marek.safar@seznam.cz>
1856 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
1857 contains obsolete attribute check which can in some cases look for base
1858 type of current class which is not initialized yet.
1859 (TypeContainer.BaseType): Replacement of ptype.
1861 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
1863 2006-02-11 Marek Safar <marek.safar@seznam.cz>
1865 First of prerequisites for new partial classs implemention.
1867 * attribute.cs (Attributable): Extended by ResolveContext;
1868 Attributes finally have correct context for resolving in all cases.
1869 (AttachTo): Attribute owner is assigned here.
1871 * codegen.cs (IResolveContext): Introduce new interface to hold
1872 all information needed in resolving phase.
1873 (EmitContext): Implements IResolveContext; more clean-up needed here.
1875 * decl.cs (MemberCore): Implemented IResolveContext.
1877 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
1878 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
1879 parameter.cs, statement.cs, tree.cs, typemanager.cs:
1880 Refactored to use new IResolveContext instead of EmitContext; cleanup
1882 2006-03-22 Raja R Harinath <rharinath@novell.com>
1884 Support ParameterDefaultValueAttribute in gmcs. Also applied to
1885 mcs to keep code differences small.
1886 * attribute.cs (Attribute.GetParameterDefaultValue): New.
1887 * typemanager.cs (parameter_default_value_attribute_type): New.
1888 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
1891 2006-03-22 Martin Baulig <martin@ximian.com>
1894 (Nullable.NullableLiteral): Derive from `NullLiteral'.
1897 (Convert.TypeParameter_to_Null): Create a `Nullable.NullableLiteral'
1898 instead of the normal `NullLiteral'.
1900 2006-03-21 Martin Baulig <martin@ximian.com>
1903 * generic.cs (TypeManager.InferType): If `pt' is a generic
1904 parameter, don't check whether `pt == at'.
1906 2006-03-20 Raja R Harinath <rharinath@novell.com>
1909 * generic.cs (Constraints.Resolve): Change argument to IResolveContext.
1910 (TypeParameter.Resolve): Update to change.
1911 (ConstraintChecker.CheckConstraints): Resolve type-argument
1912 constraints before use.
1914 2006-03-16 Martin Baulig <martin@ximian.com>
1917 (ConstraintChecker.HasDefaultConstructor): If we're a TypeBuilder
1918 and don't have any instance constructors, also lookup in the base class.
1919 (TypeManager.IsNullableValueType): New public method.
1921 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Clear the
1922 `BindingFlags.DeclaredOnly' flag and set `used_cache'.
1923 (TypeManager.TryGetBaseDefinition): Use DropGenericMethodArguments().
1925 * expression.cs (Unary.DoResolve): Use TypeManager.IsNullableValueType()
1926 instead of just TypeManager.IsNullableType() to determine whether
1927 a lifted operator exists.
1928 (UnaryMutator.DoResolve): Likewise.
1929 (Conditional.DoResolve): Likewise.
1930 (Binary.DoResolve): A lifted operator only exists if both operands
1931 are valuetypes and at least one of them is a nullable type.
1933 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
1935 * iterator.cs : yield break is allowed in try statement which has
1936 catch clauses. Fixed bug #77767.
1938 2006-03-12 Martin Baulig <martin@ximian.com>
1940 * typemanager.cs (TypeManager.ArrayContainsMethod): Use a new
1941 private IsSignatureEqual() to compare types; see the comment in
1942 that method; fixes #77674.
1944 2006-03-10 Raja R Harinath <rharinath@novell.com>
1946 * ecore.cs (Expression.ResolveAsTypeStep): Remove 1-argument wrapper.
1947 (Expression.ResolveAsTypeTerminal): Likewise.
1948 * class.cs, decl.cs, delegate.cs, ecore.cs: Update to changes.
1949 * expression.cs, generic.cs, iterators.cs: Likewise.
1950 * parameter.cs, statement.cs, typemanager.cs: Likewise.
1952 2006-03-09 Martin Baulig <martin@ximian.com>
1954 * generic.cs (ConstraintChecker.HasDefaultConstructor): Call
1955 TypeManager.DropGenericTypeArguments() on the `atype'; fixes #77548.
1957 2006-03-09 Martin Baulig <martin@ximian.com>
1959 * ecore.cs (FieldExpr.AddressOf): Don't emit the instance if the
1960 `prepared' flag is set.
1962 * generic.cs (LiftedBinaryOperator): Don't allow `||' or `&&' anymore.
1963 (LiftedBinaryOperator, LiftedUnaryMutator): Fix a few nullable
1964 issues; see gtest-254.cs.
1966 2006-03-07 Martin Baulig <martin@ximian.com>
1968 * generic.cs (TypeManager.InferType): Allow infering
1969 `IEnumerable<T>' with an array of T; see gtest-251.cs.
1971 2006-03-06 Martin Baulig <martin@ximian.com>
1974 (TypeManager.InferType): Fix gtest-250.cs.
1977 (TypeManager.IsSubclassOf): Also check the base class.
1980 (Invocation.IsAncestralType): Use TypeManager.IsSubclassOf();
1983 2006-03-01 Raja R Harinath <rharinath@novell.com>
1986 * expression.cs (ParameterReference.DoResolveBase): Change return
1988 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
1992 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
1995 * typemanager.cs (GetFullNameSignature): Don't nullref on
1996 protected accessors.
1998 2006-02-16 Martin Baulig <martin@ximian.com>
2001 (TypeManager.GetGenericFieldDefinition): New public method; use it
2002 instead of the `FieldInfo.Mono_GetGenericFieldDefinition()' icall.
2004 2006-02-14 Martin Baulig <martin@ximian.com>
2006 * *.cs: Use `Type.IsGenericType' instead of `Type.IsGenericInstance'.
2008 2006-02-14 Martin Baulig <martin@ximian.com>
2011 (TypeManager.DropGenericMethodArguments): New public method; don't
2012 use GetGenericMethodDefinition() on something which is not a
2015 2006-02-14 Martin Baulig <martin@ximian.com>
2018 (ConstraintChecker.CheckConstraints): If a type parameter has the
2019 `struct' constraint, the type must be a non-nullable valuetype.
2021 2006-02-10 Martin Baulig <martin@ximian.com>
2024 (TypeManager.IsOverride): Make this work for instantiated methods
2025 in a generic class; fixes #77509.
2026 (TypeManager.ExpandInterfaces): Use TypeManager.GetInterfaces()
2027 rather than calling it directly; fixes #77488.
2029 2006-02-08 Martin Baulig <martin@ximian.com>
2031 * generic.cs (ConstraintChecker.CheckConstraints): Move the error
2032 reporting into CheckConstraint() so we can use the correctly
2035 2006-02-08 Martin Baulig <martin@ximian.com>
2037 * expression.cs (BaseAccess): Add support for generic methods.
2039 * ecore.cs (MethodGroupExpr.ResolveGeneric): Propagate `IsBase' to
2040 the new MethodGroupExpr.
2042 2006-02-07 Martin Baulig <martin@ximian.com>
2044 * generic.cs (ConstraintChecker.CheckConstraints): Interfaces are
2045 also reference types; fixes #77483.
2047 2006-02-07 Martin Baulig <martin@ximian.com>
2050 (TypeManager.IsGenericMethod): We now return whether something is
2051 an instantiated generic method (and not a generic method def).
2052 (TypeManager.IsGenericMethodDefinition): New public method.
2055 (TypeManager.CSharpSignature): Only include type arguments for
2056 "real" generic methods, not for any instantiated method.
2057 (TypeManager.GetMethodName): Likewise, but also allow generic
2058 method definitions here.
2060 2006-02-06 Miguel de Icaza <miguel@novell.com>
2062 * codegen.cs (EmitScopeInitFromBlock): check here the
2063 capture_context, there is no need to make two calls to the
2066 * anonymous.cs: Add some debugging messages that might help me
2067 track other instances of this problem in the future (the
2068 regression of test 467).
2070 * cs-parser.jay: track the variable block, as we need to initalize
2071 any captured variables declared in this block for the "catch"
2072 portion of the "Try" statement.
2074 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
2075 scope initialization for captured variables.
2077 Also, move the emit for the variables after the block location has
2080 2006-02-06 Marek Safar <marek.safar@seznam.cz>
2082 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
2084 2006-02-06 Martin Baulig <martin@ximian.com>
2086 * class.cs (TypeContainer.DefineType): If we're a struct, pass
2087 `TypeManager.value_type' as parent type to
2088 ModuleBuilder.DefineType(). Fixes #77358.
2090 2006-02-02 Miguel de Icaza <miguel@novell.com>
2092 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
2093 commit yesterday, the initialization for the roots is necessary.
2094 What is not necessary is the scope activation.
2096 2006-02-02 Raja R Harinath <rharinath@novell.com>
2098 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
2099 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
2101 (Argument.Resolve): Remove CS0206 checks.
2103 2006-02-01 Miguel de Icaza <miguel@novell.com>
2105 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
2106 scopes for all the roots, the scopes will now be emitted when the
2107 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
2109 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
2110 code. This reduces a lot of existing cruft.
2112 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
2113 that the ScopeInfo is generated as we enter the scope, not at the
2114 time of use, which is what we used to do before.
2116 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
2117 every time a Block is about to be emitted if we have a
2120 2006-02-01 Raja R Harinath <rharinath@novell.com>
2122 * codegen.cs (AssemblyClass.Emit): Emit RuntimeCompatibility
2123 attribute for mscorlib too.
2125 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
2127 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
2129 * typemanager.cs (cons_param_array_attribute): Make private.
2130 (Reset): Set it to null.
2131 (InitCoreHelpers): Don't initialize it.
2132 (ConsParamArrayAttribute): New. Initialize it as needed.
2133 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
2135 2006-01-31 Miguel de Icaza <miguel@novell.com>
2137 * expression.cs: There might be errors reported during the
2138 selection of applicable methods. If there are errors, do not
2139 continue execution as it will lead the compiler to crash.
2141 2006-01-30 Miguel de Icaza <miguel@novell.com>
2143 * expression.cs: Member access is not allowed on anonymous
2144 methods. Fixes #77402.
2146 2006-01-30 Raja R Harinath <rharinath@novell.com>
2149 * cs-parser.jay (VariableDeclaration): Don't set
2150 current_array_type to null.
2151 (field_declaration, event_declaration, declaration_statement):
2152 Set it to null here.
2154 2006-01-29 Raja R Harinath <harinath@gmail.com>
2157 * generic.cs (TypeManager.IsEqual): Handle pass-by-ref types.
2159 2006-01-28 Raja R Harinath <harinath@gmail.com>
2161 * typemanager.cs (GenericParameterPosition): New.
2164 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
2166 * doc.cs : To process "include" elements, first we should create
2167 another list than XmlNodeList, because it could result in node
2168 removal, which could result in that the XmlNodeList gives up
2171 2006-01-25 Miguel de Icaza <miguel@novell.com>
2173 * expression.cs: Introduce an error report that we were not
2174 catching before. Gonzalo ran into it.
2176 2006-01-23 Miguel de Icaza <miguel@novell.com>
2178 A fix for bug: #76957
2180 * iterators.cs (MoveNextMethod.CreateMethodHost): call
2181 ComputeMethodHost before creating the method, this is a new
2184 * anonymous.cs (AnonymousContainer): Now we track all the scopes
2185 that this method references (RegisterScope). The actual scope
2186 where the method is hosted is computed with the ComputeMethodHost
2187 before we create the method.
2189 Moved the Deepest routine here.
2191 (AnonymousContainer.ComputeMethodHost): New routine used to
2192 compute the proper ScopeInfo that will host the anonymous method.
2194 (ScopeInfo): Deal with multiple roots. The problem was that we
2195 did not have a unique root where all ScopeInfos could be hanged
2196 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
2199 Remove AdjustMethodScope which is now computed at the end. Remove
2200 LinkScope which did a partial link, instead link all ScopeInfos
2201 before code generation from the new "LinkScopes" routine.
2203 Simplify all the Add* routines as they no longer need to maintain
2204 the tree, they just need to record that they are using variables
2207 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
2208 routines to produce the forest of ScopeInfo trees.
2210 * class.cs (TypeContainer.AppendMethod): This is just like
2211 AddMethod, but ensures that an interface implementation method
2212 (IEnumerable.XXX) is not inserted at the beginning of the queue of
2213 methods, but at the end.
2215 We use this functionality to ensure that the generated MoveNext
2216 method in the iterator class is resolved/emitted before the
2217 enumerator methods created.
2219 This is required because the MoveNext method computes the right
2220 ScopeInfo for the method. And the other methods will eventually
2221 need to resolve and fetch information computed from the anonymous
2225 2006-01-23 Raja R Harinath <rharinath@novell.com>
2227 Improve implementation of section 14.4.2.2 (Better function member).
2228 * expression.cs (Invocation.MoreSpecific): Compare all type
2229 arguments before deciding if one type is more specific than
2230 another. Handle array types too. Return the more specific type.
2231 (Invocation.BetterFunction): Add more tie-breaking rules from
2232 section 14.4.2.2. Perform "more specific" check after
2233 other tie-breaking rules. Compare all parameter types before
2234 choosing the "more specific" method.
2236 2006-01-21 Raja R Harinath <harinath@gmail.com>
2237 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2240 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
2242 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
2243 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
2245 2006-01-18 Martin Baulig <martin@ximian.com>
2247 * class.cs (TypeContainer.AddToMemberContainer): Use
2248 `symbol.MemberName.MethodName' instead of just `symbol.Name';
2251 2006-01-18 Martin Baulig <martin@ximian.com>
2253 Fix #76417: a generic class may now have methods which may unify
2254 for some type parameter substitutions.
2256 * class.cs (Method.IsDuplicateImplementation): Don't report CS0408
2257 for methods which may unify anymore.
2259 * expression.cs (Invocation.MoreSpecific): New private static
2260 method; checks whether one method is more specific than another
2261 according to 14.4.2.2 of the spec.
2262 (Invocation.BetterFunction): Implement the tie-breaking rules from
2263 14.4.2.2 of the spec: if two methods unify for some type parameter
2264 substitution, we need to pick the more specific one.
2266 2006-01-18 Raja R Harinath <rharinath@novell.com>
2268 Fix #76656, cs0231-2.cs.
2269 * cs-parser.jay (formal_parameter_list): Make error case catch
2271 (parenthesized_expression_0): Add CS1026 check.
2272 (invocation_expression): Remove unused { $$ = lexer.Location }.
2274 2006-01-17 Raja R Harinath <rharinath@novell.com>
2277 * cs-parser.jay (statement_expression): Don't list out the
2278 individual statement-expressions. Convert syntax error into
2281 2006-01-16 Raja R Harinath <rharinath@novell.com>
2284 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
2285 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
2286 CheckIntermediateModification.
2287 (FieldExpr.DoResolve): Add new two-argument version that
2288 allows us to resolve the InstanceExpression as an lvalue.
2289 The one-argument variant is now just a wrapper.
2290 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
2291 Resolve the lhs as an lvalue if the it has a value type.
2292 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
2293 from Assign.DoResolve.
2294 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
2295 resolved as an lvalue.
2296 (PropertyExpr.DoResolve): Update.
2297 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
2298 has a value type. Move CS1612 check here from
2299 CheckIntermediateModification.
2300 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
2301 * expression.cs (EmptyExpression.OutAccess): New. Used as the
2302 'right_side' of a ResolveLValue on an 'out' argument.
2303 (EmptyExpression.LValueMemberAccess): New. Used as the
2304 'right_side' of a propagated ResolveLValue on a value type.
2305 (LocalVariableReference.DoResolveBase): Recognize
2306 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
2308 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
2309 EmptyExpression.Null.
2311 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
2313 * typemanager.cs : added IsGenericParameter(). In gmcs it returns
2314 Type.IsGenericParameter(). Fixed bug #77183.
2315 * doc.cs : it is now identical to doc.cs in mcs.
2317 2006-01-16 Martin Baulig <martin@ximian.com>
2319 * generic.cs (ConstraintChecker.CheckConstraint): Fix #77167.
2321 2006-01-16 Martin Baulig <martin@ximian.com>
2323 * typemanager.cs (TypeManager.CSharpSignature): Make this work for
2324 ctors; fixes #77250.
2326 2006-01-12 Miguel de Icaza <miguel@novell.com>
2328 This fixes the problem where we used ldfld instead of ldflda to
2329 load the "THIS" pointer on captured parameters, when THIS is a
2330 value type. See bug #77205.
2332 * iterators.cs (CapturedThisReference.Emit): Pass false to
2333 EmitThis (we do not need the address).
2335 * codegen.cs (EmitThis): it needs to know whether we need the
2336 address of `this' or not. This is used by value types.
2338 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
2339 every other call passes false.
2341 2006-01-12 Raja R Harinath <rharinath@novell.com>
2344 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
2346 * expression.cs (Invocation.OverloadResolve): Update.
2347 (Invocation.DoResolve): Avoid double resolution of invocation.
2349 2006-01-11 Raja R Harinath <rharinath@novell.com>
2352 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
2353 unary negation of floating point types as 0-expr; negation cannot
2354 overflow in floating point types.
2357 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
2358 on operands of 'void' type.
2361 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
2362 and ExclusiveOr for boolean constants too.
2364 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
2366 * expression.cs: Fix Console.WriteLine ((this = x).foo);
2368 2006-01-12 Miguel de Icaza <miguel@novell.com>
2370 * cs-tokenizer.cs (Position): New class used to save and restore
2371 the position state in the tokenizer. Before this patch the save
2372 and restore was not complete enough so the line and columns would
2373 start to drift and the debugger and stack traces will get the
2376 2006-01-10 Martin Baulig <martin@ximian.com>
2379 (TypeParameter.InflateConstraints): New public method.
2381 * iterators.cs (Iterator.DefineNestedTypes): Also inflate the
2382 constraints; fixes #77042.
2384 2006-01-10 Martin Baulig <martin@ximian.com>
2386 * anonymous.cs (ScopeInfo.EmitScopeType): Use the `CurrentType'
2387 instead of the `TypeBuilder' for this "<>THIS" variable; fixes
2390 2006-01-09 Raja R Harinath <rharinath@novell.com>
2393 * expression.cs (Invocation.OverloadResolve): Replace reflected
2394 override methods with their base virtual methods, rather than
2396 * typemanager.cs (TypeManager.GetOverride): New.
2398 2005-12-21 Miguel de Icaza <miguel@novell.com>
2400 * driver.cs: Report the case of no source files and no -out:
2403 2005-12-20 Raja R Harinath <rharinath@novell.com>
2406 * expression.cs (ComposedCast.GetSignatureForError): Define.
2408 2006-01-05 Jb Evain <jbevain@gmail.com>
2410 * class.cs (Property.Define, Indexer.Define): do not tag the
2411 properties as SpecialName | RTSpecialName.
2413 2006-01-04 Miguel de Icaza <miguel@novell.com>
2415 * class.cs (MethodCore.IsDuplicateImplementation): This method was
2416 doing a low-level comparission of parameter types. It was lacking
2417 a check for __argslist.
2419 2005-12-30 Miguel de Icaza <miguel@novell.com>
2421 * expression.cs (ParameterReference.DoResolveBase): Allow
2422 reference parameters if they are local to this block.
2424 This allows the ref and out parameters of a delegate to be used in
2425 an anonymous method, for example:
2427 delegate void set (out int x);
2429 set s = delegate (out int x){
2433 This is used by functionality introduced late in the C# language.
2435 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
2436 method that take ref and out parameters.
2438 Fixes #77119 which was a late change in the spec.
2440 2005-12-23 Miguel de Icaza <miguel@novell.com>
2442 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
2443 parent if its the same scope. Fixes #77060.
2445 2005-12-22 Marek Safar <marek.safar@seznam.cz>
2447 * expression.cs (ComposedCast.DoResolveAsTypeStep): Fixed wrong merge.
2449 2005-12-21 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2451 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute): Generate
2452 errors 1726 for strong named assemblies with InternalsVisibleToAttribute
2453 that doesn't contain the full public key. This is a update of the
2454 friend assemblies in .Net 2.0 release.
2456 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2460 * namespace.cs (NamespaceEntry): Add extern_aliases as a
2461 ListDictionary, to contain the ExternAliasEntry entries (in
2462 addition to the NamespaceEntry.aliases hashtable). This field is
2463 shared between the original entry and its doppelganger (bodyless
2465 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
2466 extern_aliases field.
2467 (NamespaceEntry.Lookup): Move the IsImplicit check after the
2468 lookup in extern_aliases.
2470 2005-12-16 Raja R Harinath <rharinath@novell.com>
2473 * class.cs (TypeContainer.Mark_HasEquals): New.
2474 (TypeContainer.Mark_HasGetHashCode): New.
2475 (ClassPart): Override them.
2476 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
2478 * generic.cs (GenericMethod.DefineMembers): Update to changes.
2479 (TypeParameter.TypeParameter): Change type of 'parent' argument to
2483 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
2484 'parent' argument to the base constructor.
2486 Remove all mention of TypeContainer from decl.cs.
2487 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
2488 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
2489 (DeclSpace.DeclSpace): Likewise.
2490 (DeclSpace.DefineMembers): Remove unused argument.
2491 * cs-parser.jay (pop_current_class): Update to changes. Simplify
2492 debugging check -- we don't care if the debug code throws an
2493 InvalidCastException instead of an InternalErrorException.
2494 * class.cs (TypeContainer.DefineMembers): Update to changes.
2495 (TypeContainer.DoDefineMembers): Likewise.
2496 (TypeContainer.GetMethods): Likewise.
2497 (PropertyMember.Define): Likewise.
2498 (MemberBase.Parent): New property that forwards to
2499 MemberCore.Parent, but ensures that we get a TypeContainer.
2500 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
2501 (RootContext.PopulateTypes): Likewise. Remove special case code
2502 for !RootContext.StdLib: DefineMembers is idempotent.
2504 2005-12-13 Marek Safar <marek.safar@seznam.cz>
2506 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
2508 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
2510 * doc.cs : The search for referenced namespace was insufficient to
2511 get global one as it used to do. Fixed bug #76965.
2513 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
2515 * doc.cs : check name in cref in the last phase that whether it is
2518 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2520 * cs-tokenizer.cs : reverted the latest change: it somehow broke
2523 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2525 * doc.cs : so it turned out that we cannot skip override check for
2526 interface members. Fixed bug #76954.
2528 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2530 * cs-tokenizer.cs : fixed bug #75984:
2531 - #warning and #error should not be handled when the source line
2533 - #line is not checked strictly when the source line is disabled.
2534 - #define and #undef is on the other hand checked strictly at any
2537 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
2539 * cs-tokenizer.cs : missing Location (actually, filename) in one of
2542 2005-12-15 Raja R Harinath <rharinath@novell.com>
2544 * generic.cs (TypeManager.IsGeneric): Remove unused method.
2546 * typemanager.cs (TypeManager.GetFullName): Rewrite to handle
2549 2005-12-14 Martin Baulig <martin@ximian.com>
2551 * typemanager.cs (TypeManager.GetFullName): Make this public;
2552 `Type.Fullname' now never returns null.
2554 * class.cs (Method.Define): Use TypeManager.GetFullName() for
2555 explicit interface implementations; we're now using the same
2556 naming convention than csc does.
2558 2005-12-14 Miguel de Icaza <miguel@novell.com>
2560 * convert.cs (ExplicitConversionCore): Check the return value from
2561 ExplicitConversionCore which can return null on failure. Fixes #76914
2563 2005-12-09 Raja R Harinath <rharinath@novell.com>
2565 * anonymous.cs (AnonymousMethod.Compatible): Use IsGenericType
2566 instead of IsGenericInstance.
2567 * generic.cs (TypeManager.IsEqual): Likewise. Delete redundant
2568 code that's now covered by the more general test.
2569 * typemanager.cs (TypeManager.IsPrivateAccessible): Likewise.
2571 * generic.cs (DropGenericTypeArguments): New. Captures the common
2572 pattern: if (t.IsGenericInstance) t = t.GetGenericTypeDefinition ();
2573 * attribute.cs, class.cs, decl.cs, ecore.cs: Use it.
2574 * generic.cs, report.cs, typemanager.cs: Likewise.
2576 2005-12-08 Martin Baulig <martin@ximian.com>
2578 * generic.cs (TypeArguments.Resolve): Added CS1547 check.
2580 * typemanager.cs (TypeManager.CSharpSignature): Include type
2581 arguments in the signature of a generic method.
2583 2005-12-07 Martin Baulig <martin@ximian.com>
2585 Add support for custom attributes on type parameters.
2587 * cs-parser.jay (type_arguments): Added `opt_attributes'.
2589 * generic.cs (TypeParameterName): New public class; we use this
2590 instead of a `string' to store the name of a type parameter, so we
2591 can also have `Attributes'.
2592 (TypeArguments.GetDeclarations): Return a `TypeParameterName[]'
2593 array instead of a `string[]' array.
2594 (TypeParameter.ctor): We now also take an `Attributes' argument.
2595 (TypeParameter.EmitAttributes): New public method; emit our
2596 `OptAttributes' here.
2597 (GenericMethod.EmitAttributes): New public method; emit the custom
2598 attributes on all our type parameters.
2600 * class.cs (TypeContainer.EmitType): Call EmitAttributes() on all
2601 our type parameters.
2602 (MethodData.Define): If we're a generic method, call
2603 EmitAttributes() on it.
2605 2005-12-07 Martin Baulig <martin@ximian.com>
2608 (ConstraintChecker): New public abstract class; move the
2609 constraint checking here from `ConstructedType' and also do
2610 constraint checking for generic methods here.
2612 * expression.cs (Invocation.OverloadResolve): Use
2613 ConstraintChecker.CheckConstraints() if we resolved to a generic
2616 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2618 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
2620 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
2622 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
2623 (FieldBase.Initializer): Initializer is now optional.
2624 (EventField.Define): Only event field can have initializer.
2626 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
2628 * const.cs (Const): Reuse initializer.
2630 * cs-parser.jay: Updated after FieldBase changes.
2631 Added current_array_type to simplify array initializers.
2633 * ecore.cs (NullCast.IsDefaultValue): Implemented.
2635 * expression.cs, iterators.cs: Updated.
2637 * namespace.cs (NamespaceEntry): Made UsingFound private.
2639 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2641 * parameterCollection.cs: Obsolete, removed.
2642 * parser.cs: Obsolete, removed.
2644 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2647 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
2649 * enum.cs (Enum.Define): Set obsolete context here.
2651 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2654 - FindDocumentedMember() now expects 1) paramList as null
2655 when "we don't have to check the number of parameters" and
2656 2) Type.EmptyTypes when "there is no arguments".
2657 - Introduced FoundMember struct to hold the exact type which was
2658 used to find the documented member (the above change broke
2659 test-xml-044; it might be better just to use DeclaringType than
2660 what MS does, like this change does, but it depends on usage.)
2662 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2664 * doc.cs : documented member might be from DeclaringType for nested
2665 types. Fixed bug #76782.
2667 2005-12-03 Ben Maurer <bmaurer@ximian.com>
2669 * anonymous.cs: Have the param code handle leaving copies on the
2670 stack etc. Allows anonymous params to take part in the assignment
2671 code (++, +=, etc). Fixes bug #76550
2673 * expression.cs: Handle the prepare_for_load/leave_copy by passing
2674 it down to the anon code.
2676 * iterators.cs: Use dummy var here
2678 * codegen.cs: Handle new vars
2680 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2683 * class.cs (MethodData.Define): Set proper Obsolete context.
2685 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
2687 (FieldExpr.DoResolve): Ditto.
2689 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2692 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
2693 parent is not obsolete.
2695 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
2697 * doc.cs : (FindDocumentedMember) find parameterless members first
2698 and get CS0419 in the early stage. Fixed first case of bug #76727.
2700 2005-11-30 Marek Safar <marek.safar@seznam.cz>
2703 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
2704 no error was reported.
2706 *expression.cs (Binary.DoResolve): left can be null.
2708 2005-12-06 Raja R Harinath <rharinath@novell.com>
2710 * class.cs (MethodCore.CheckGenericOverride): Delete unused
2711 abstract method and all overrides.
2712 * support.cs (ParameterData.GenericConstraints): Delete.
2713 (ReflectionParameters.type_params): Delete.
2714 (ReflectionParameters.ReflectionParameters): Make private.
2715 (ReflectionParameters.GetConstaints): New factory method.
2716 * generic.cs (TypeParameterDefineType): Use it.
2717 (TypeManager.GetTypeParameterConstraints): Likewise.
2719 2005-11-22 Marek Safar <marek.safar@seznam.cz>
2722 * class.cs (MethodData.Emit): Parameters should be labeled first.
2724 2005-11-21 Marek Safar <marek.safar@seznam.cz>
2727 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
2729 2005-11-18 Marek Safar <marek.safar@seznam.cz>
2731 * attribute.cs (AreParametersCompliant): Moved to Parameter.
2733 * class.cs (MethodCore): Parameter clean up.
2734 (IMethodData): Added ParameterInfo.
2735 (MethodData): Parameter clean up.
2736 (Indexer.Define): Parameter clean up.
2748 * typemanager.cs: Parameter clean up.
2750 * delegate.cs (Define): Get rid of duplicated code.
2752 * expression.cs (ParameterReference): Removed useless parameters
2754 (Invocation): Ditto.
2756 * parameter.cs (ParamsParameter): New class, params specialization.
2757 (ArglistParameter): Attemp to separate arglist.
2758 (Parameter): Refactored to be reusable and faster.
2759 (Parameter.Modifier): Made understandable.
2760 (Parameters): Changed to be used as a class for `this' assembly
2761 parameters. Refactored to use new specialized classes.
2763 * support.cs (ParameterData): Added Types property.
2764 (InternalParameters): Deleted.
2766 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2768 * doc.cs : the previous patch does not actually fix the bug.
2769 PropertyInfo override check is now implemented and really fixed it.
2770 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
2772 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2774 * doc.cs : apply "override filter" also to properties.
2777 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2779 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
2780 no need to check overrides. For classes, omit those results from
2781 interfaces since they must exist in the class. Fixed bug #76726.
2783 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2785 * typemanager.cs : (GetFullNameSignature) differentiate indexers
2786 with different parameters. Fixed the second problem in #76685.
2788 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2790 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
2791 get expected 'protected' access in CheckValidFamilyAccess()).
2794 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2796 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
2797 Fixed bug #76705. CS1569 was incorrectly commented out.
2799 2005-11-23 Martin Baulig <martin@ximian.com>
2801 * generic.cs (Constraints.Define): Removed.
2802 (TypeParameter.DefineConstraints): Removed.
2803 (TypeParameter.DefineType): Call SetGenericParameterAttributes()
2804 on the GenericTypeParameterBuilder here.
2806 2005-11-23 Martin Baulig <martin@ximian.com>
2808 * typemanager.cs (TypeManager.GetProperty): Make this public.
2810 * generic.cs (Nullable.NullableInfo.ctor): Use
2811 TypeManager.GetProperty() rather than using reflection directly.
2813 2005-11-17 Martin Baulig <martin@ximian.com>
2815 * expression.cs (Indexers.GetIndexersForType): Added support for
2816 generic parameters; fixes #76587.
2818 2005-11-17 Martin Baulig <martin@ximian.com>
2821 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
2822 inherit the scope from our parent. Fixes #76653.
2824 2005-11-15 Martin Baulig <martin@ximian.com>
2826 * anonymous.cs (ScopeInfo.ScopeType): New public field; use this
2827 instead of `ScopeTypeBuilder' to refer to the "current" type.
2828 (AnonymousMethod.CreateScopeType): Correctly create the helper
2829 class if we're inside a generic type definition.
2831 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
2833 * doc.cs : use Invocation.IsOverride() to do real override check.
2834 * expression.cs : made Invocation.IsOverride() internal.
2836 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
2838 * doc.cs : use TypeManager.FindMembers() instead of (possible)
2839 TypeBuilder.FindMembers() and filter overriden base members out.
2842 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2844 * doc.cs : ref/out parameters are represented as '@' (instead of
2845 '&' in type FullName). Fixed bug #76630 (additionally crefs).
2847 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2849 * doc.cs : when there was no '.' in cref to methods in doc comment,
2850 then parameters were missing in the output. Fixed bug #76691.
2852 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2854 * driver.cs : don't output docs when there is an error.
2857 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2860 Now it should detect indexers. Fixed primary concern in bug #76685.
2861 Fixed CS0419 message to not show the identical member signature in
2864 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2866 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
2867 instead of Type.FindMembers() since it does not handle events.
2870 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
2872 * codegen.cs: Fixed typo (speficied -> specified).
2874 2005-11-11 Marek Safar <marek.safar@seznam.cz>
2877 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
2879 2005-11-11 Marek Safar <marek.safar@seznam.cz>
2881 * attribute.cs: Changed error message.
2883 * cs-tokenizer.cs: One more check.
2885 2005-11-10 Marek Safar <marek.safar@seznam.cz>
2887 * statement.cs (Block.Resolve): Ignore empty statement.
2889 2005-11-10 Marek Safar <marek.safar@seznam.cz>
2891 * report.cs: Made error/warning methods more strict to avoid
2894 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
2895 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
2896 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
2897 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
2899 2005-11-11 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2901 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute):
2902 Use the more explicit AssemblyName.FullName instead of
2903 AssemblyName.Name to report errors.
2905 2005-11-11 Marek Safar <marek.safar@seznam.cz>
2907 * attribute.cs, class.cs, cs-tokenizer.cs, parameter.cs: Sync
2910 2005-11-10 Marek Safar <marek.safar@seznam.cz>
2920 * report.cs: Fixed error reporting and typos.
2922 * generic.cs (TypeParameter.GetSignatureForError): New method.
2923 (ConstructedType.GetSignatureForError): Instead of DeclarationName.
2925 * typemanager.cs (GetFullName): Refactored.
2927 2005-11-08 Marek Safar <marek.safar@seznam.cz>
2929 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
2930 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
2932 * class.cs (TypeContainer.IsComImport): New property.
2933 (Constructor.Define): Create proper ctor for ComImport types.
2935 * expression.cs (New.CheckComImport): Fixed.
2937 2005-11-07 Miguel de Icaza <miguel@novell.com>
2939 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
2940 that a parameter has been captured does not mean that we do not
2941 have to do the rest of the processing. This fixes the second part
2942 of #76592. If there was another anonymous method capturing
2943 values in the past, the Scope would never be set for the second
2944 method that captured the same parameter.
2946 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
2947 properly manipulate the stack. Second part of fix for #76592.
2949 * expression.cs (New): Add support for invoking "new" on
2950 interfaces that have been flagged with the ComImport attribute and
2951 the CoClass. Fixes #76637
2953 * statement.cs (Try.DoEmit): When a variable is captured, do not
2954 try to emit the vi.LocalBuilder variable as it has been captured.
2955 Create a temporary variable and store the results on the
2956 FieldBuilder. Fixes #76642
2958 2005-11-07 Marek Safar <marek.safar@seznam.cz>
2960 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
2962 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
2964 * expression.cs (Binary.DoResolve): Added && optimalization.
2966 * typemanager.cs (AddUserType): Removed useless argument.
2968 2005-11-04 Marek Safar <marek.safar@seznam.cz>
2970 * statement.cs (Block.variables): Uses ListDictionary.
2972 2005-11-03 Marek Safar <marek.safar@seznam.cz>
2975 * class.cs (PartialContainer.EmitType): Customized to emit
2976 security attributes.
2977 (ClassPart.ApplyAttributeBuilder): Transform security attribute
2978 for partial classes.
2980 2005-11-03 Marek Safar <marek.safar@seznam.cz>
2983 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
2984 access has to be fixed.
2986 * typemanager.cs (IsUnmanagedType): Wrong common field type.
2988 2005-11-01 Marek Safar <marek.safar@seznam.cz>
2991 * ecore.cs (NullCast.Reduce): Implemented.
2993 * expression.cs (ArrayCreation.CheckIndices): Correcly check
2996 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
2998 (Foreach.Resolve): Catch null properly.
3000 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3002 * cs-tokenizer.cs: Warning text fix.
3004 * driver.cs: AllWarningNumbers exposed on public interface.
3006 * report.cs (): Reviewed warning numbers.
3007 (IsValidWarning): Use binary search.
3009 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3011 * driver.cs: Implemeted resource visibility.
3012 (Resources): New class for code sharing between /res: and
3015 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3017 decl.cs (CurrentTypeParameters): Fixed to be public.
3019 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3021 generic.cs, rootcontext.cs: Removed NewConstraintAttribute.
3023 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3025 gmcs.exe.sources: Use CryptoConvert.cs from corlib.
3027 2005-11-05 Kornél Pál <kornelpal@hotmail.com>
3029 * gmcs.exe.config: Updated runtime version to v2.0.50727 (2.0 RTM).
3031 2005-11-04 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3033 Add friend assembly access support.
3034 * typemanager.cs: assembly_internals_vis_attrs
3035 cache for friend assembly access.
3036 (TypeManager.IsFriendAssembly): New method for
3037 checking friend assembly access.
3038 (TypeManager.Error_FriendAccessNameNotMatching): New
3040 (TypeManager.CompareKeyTokens): Likewise.
3041 (TypeManager.Filter): Handle friend accessible
3044 * namespace.cs (RootNamespace.GetTypeInAssembly): Return
3045 friend accessible types.
3047 * ecore.cs (Expression.IsAccessorAccessible): Handle
3048 friend accessible properties.
3050 * decl.cs (DeclSpace.CheckAccessLevel): Handle friend
3053 2005-10-28 Marek Safar <marek.safar@seznam.cz>
3056 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
3059 * convert (Convert.ImplicitReferenceConversion): NullCast holds
3062 * ecore.cs (NullCast): Child is contant only.
3064 * literal.cs (NullLiteral.Reduce): null can be converted to any
3067 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
3069 * driver.cs: Use Encoding.Default as default code page instead
3072 2005-10-27 Raja R Harinath <rharinath@novell.com>
3075 * expression.cs (Invocation.Error_InvalidArguments): Handle
3076 __arglist parameters.
3077 (Invocation.VerifyArgumentsCompat): Likewise.
3078 * support.cs (ReflectionParameters.GetSignatureForError): Print
3079 __arglist parameters.
3080 (InternalParamters.GetSignatureForError): Likewise.
3081 * parameter.cs (Parameters.GetSignatureForError): Likewise.
3083 2005-10-26 Marek Safar <marek.safar@seznam.cz>
3085 * attribute.cs (GetPropertyValue): Made public.
3087 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
3089 Add new property WrapNonExceptionThrows to handle 2.0 assembly
3091 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
3094 * driver.cs: Reflect method name change.
3096 * statement.cs (Try.Resolve): Warn when try has both general
3099 * typemanager.cs: runtime_compatibility_attr_type new predefined
3102 2005-10-26 Raja R Harinath <harinath@gmail.com>
3105 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
3106 treat it as an empty parameter list.
3108 2005-10-26 Raja R Harinath <rharinath@novell.com>
3111 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
3112 ResolveAsTypeStep silent.
3113 * statement.cs (Block.AddConstant): Mark block as used.
3114 (Block.ResolveMeta): Avoid piling on error messages
3115 if a constant initializer resolution fails.
3117 2005-10-25 Raja R Harinath <rharinath@novell.com>
3119 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
3121 (NamespaceEntry.VerifyAllUsing): New.
3122 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
3123 behaviour. Delegates actual resolution of alias to ...
3124 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
3125 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
3127 * driver.cs (Driver.MainDriver): Update.
3129 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
3130 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
3132 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
3134 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
3135 RootNamespace.DefineNamespacesForAll.
3137 2005-10-24 Raja R Harinath <harinath@gmail.com>
3139 * typemanager.cs (assemblies, external_aliases, modules)
3140 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
3141 (ComputeNamespaces, GetRootNamespace): Remove extra staging
3142 overhead. Move resposibility ...
3143 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
3144 * driver.cs, attribute.cs, codegen.cs: Update to changes.
3146 2005-10-23 Raja R Harinath <harinath@gmail.com>
3148 * namespace.cs (RootNamespace.all_namespaces): Renamed from
3149 cached_namespaces. Improve usage.
3150 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
3151 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
3152 Move from GlobalRootNamespace and simplify.
3153 (RootNamespace.Global): Make instance variable.
3154 (RootNamespace.RootNamespace): Add "alias name" parameter.
3155 (GlobalRootNamespace): Simplify drastically.
3156 (Namespace.Lookup): Don't use GetNamespace.
3157 * typemanager.cs (GetRootNamespace): Rename from
3158 ComputeNamespaceForAlias.
3159 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
3161 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3163 * anonymous.cs (AnonymousContainer): Don't crash when container
3166 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3168 * expression.cs (Binary.DoResolve): Warn when comparing same
3171 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3174 * expression.cs (Binary.DoResolve): It looks like there are no
3175 convetsion rules in enum context.
3177 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3179 Add support for extern alias qualifiers.
3180 * typemanager.cs: Move some LookupTypeReflection code
3181 to namespace.cs, to have cleaner code. Added some methods
3182 to help us keep track of the extern aliased references.
3183 * driver.cs: Add suport for extern alias assemblies on command
3184 line and check for their warnings/errors. Also keep track of the
3185 extern aliased assemblies.
3186 * namespace.cs: Move the global functionality of Namespace
3187 to GlobalRootNamespace/RootNamespace. Now the global namespace
3188 is GlobalRootNamespace.Globa. Also the code moved from
3189 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
3190 Finally added LocalAliasEntry (AliasEntry before) and
3191 ExternAliasEntry, to handle alias statements.
3192 * cs-parser.jay: Add support in the grammar for extern alias
3194 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
3195 Update callings to Namespace (now in GlobalRootNamespace).
3197 2005-10-25 Martin Baulig <martin@ximian.com>
3199 * convert.cs (ImplicitTypeParameterConversion): Make base
3200 interfaces actually work; fixes #76557.
3202 2005-10-25 Martin Baulig <martin@ximian.com>
3205 (GenericMethod.Define): Call TypeParameter.DefineConstraints() on
3206 all the type parameters; fixes #76551.
3208 2005-10-25 Martin Baulig <martin@ximian.com>
3213 (GenericMethod.ctor): Added `Expression return_type' and
3214 `Parameters parameters' arguments.
3215 (GenericMethod.DefineType): Call ResolveAsTypeTerminal() on the
3216 parameter and return types to check their constraints if they're
3219 * codegen.cs (EmitContext.ResolvingGenericMethod): New public
3222 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
3223 constraints of a generic type if `ec.ResolvingGenericMethod'.
3225 * class.cs (MethodCore.DoDefineParameters): Set
3226 `ec.ResolvingGenericMethod' if we're a generic method.
3227 (MemberBase.MemberType): Likewise.
3229 2005-10-25 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3231 * typemanager.cs (TypeManager): Added
3232 TypeManager.internals_visible_attr_type to cache
3233 S.R.CompilerServices.InternalsVisibleToAttribute.
3235 * codegen.cs (AssemblyClass): Added checks for
3236 InternalsVisibleToAttribute in new method
3237 CheckInternalsVisibleAttribute () and also cache the
3238 AssemblyName in AssemblyClass.Name.
3240 2005-10-24 Martin Baulig <martin@ximian.com>
3243 (TypeManager.ExpandInterfaces): Added overloaded version which
3244 just takes a `Type[]' array.
3247 (Constraints.Resolve): Don't expand the interfaces here; ie. we
3248 just use the interfaces which were explicitly specified and not
3249 the interfaces they inherit. Fixes #76482.
3250 (TypeParameter.FindMembers): Expand the interfaces here.
3252 2005-10-21 Martin Baulig <martin@ximian.com>
3255 (Constraints.Resolve): Also resolve the actual types here.
3256 (Constraints.ResolveTypes): Just check the constraints here.
3257 Fixes #76363; see gtest-218.cs.
3259 2005-10-21 Martin Baulig <martin@ximian.com>
3262 (Convert.ImplicitTypeParameterConversion): Use a `ClassCast'
3263 instead of a `BoxedCast'; fixes gtest-217.cs.
3265 2005-10-20 Atsushi Enomoto <atsushi@ximian.com>
3267 * generic.cs : (ConstructedType.CheckConstraints) warn CS0310 when
3268 1) "new()" is specified as generic parameter constraint and 2) the
3269 type is TypeBuilder and 3) the type is abstract even if it has a
3270 default .ctor(). Now errors/gcs0310-3.cs is correctly rejected.
3272 2005-10-20 Martin Baulig <martin@ximian.com>
3275 (GenericConstraints.TypeParameter): New public property.
3276 (TypeParameter.ctor): Also take a `DeclSpace' argument.
3277 (TypeParameter.DeclSpace): New public property.
3278 (TypeParameter.DefineType): Inflate the constraints if our
3279 `DeclSpace' is an `Iterator'.
3281 2005-10-19 Atsushi Enomoto <atsushi@ximian.com>
3283 * class.cs, decl.cs : (MemberCache.FindMemberToOverride) added
3284 GenericMethod argument to compare methods' generic type arguments.
3287 2005-10-19 Martin Baulig <martin@ximian.com>
3289 * class.cs (TypeContainer.DefineType): Only use ResolveAsTypeStep(),
3290 not ResolveType() when resolving the base type, so we're not
3291 checking the constraints here.
3292 (TypeContainer.ResolveType): Call ResolveType() on our base_type
3295 2005-10-19 Martin Baulig <martin@ximian.com>
3297 * generic.cs (ConstructedType.CheckConstraints): Committing
3298 untested fix for #76441.
3300 2005-10-18 Raja R Harinath <rharinath@novell.com>
3303 * class.cs (TypeContainer.DefineType): Move updating of
3304 topological sort earlier in the code.
3305 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
3307 2005-10-18 Marek Safar <marek.safar@seznam.cz>
3310 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
3312 * constant.cs (Constant.TryReduce): Moved from Cast class.
3313 (Reduce): Made little bit more OO and fixed missing conversions.
3315 * ecore.cs (Reduce): Implemented.
3316 (Binary.EnumLiftUp): New method to upgrade values to enum values.
3318 * literal.cs (Reduce): Implemented.
3320 * class.cs: Reverted Miguel's wrong commit.
3322 2005-10-14 Miguel de Icaza <miguel@novell.com>
3324 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
3326 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
3328 * cs-parser.jay, expression.cs : CS0214 was missing error location
3329 for constants. Fixed bug #76404.
3331 2005-10-10 Raja R Harinath <rharinath@novell.com>
3333 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
3335 (PropertyExpr.EmitCall): Likewise.
3336 * expression.cs (Invocation.EmitArguments): Handle case where
3338 (Invocation.EmitCall): Avoid allocating temporary variable if
3339 there are no arguments.
3341 2005-10-11 Marek Safar <marek.safar@seznam.cz>
3344 * convert.cs (ExplicitConversionCore): Fixed object->enum
3347 2005-10-07 Raja R Harinath <rharinath@novell.com>
3350 * convert.cs (ImplicitConversionStandard): Move conversion of
3351 void* to arbitrary pointer types ...
3352 (ExplicitConversionStandard): .. here.
3353 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
3354 error to always print typenames.
3356 2005-10-07 Raja R Harinath <rharinath@novell.com>
3358 * convert.cs (GetConversionOperator): Rename from
3359 GetConversionOperators. Move operator selection code from ...
3360 (UserDefinedConversion): ... here.
3362 2005-10-06 Marek Safar <marek.safar@seznam.cz>
3364 * convert.cs (ExplicitConversionCore): Removed duplicate enum
3367 2005-10-05 Marek Safar <marek.safar@seznam.cz>
3369 * assign.cs (Assign.DoResolve): Error method changed.
3371 * cfold.cs (DoConstantNumericPromotions): Error method changed.
3373 * const.cs (ResolveValue): Reset in_transit immediately.
3375 * constant.cs: Error method changed.
3377 * convert.cs: Removed useless location parameter.
3378 (ExplicitNumericConversion): Don't do double enum check.
3379 (ExplicitConversionCore): Renamed from ExplicitConversion.
3380 (ExplicitUnsafe): Extracted from ExplicitConversion.
3381 (ExplicitConversion): Uses for error reporting.
3383 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
3385 (ResolveBoolean): Uses common error method.
3386 (CastToDecimal): Get rid of ec.
3387 (CastFromDecimal): Optimized.
3388 (ConvCast): Get rid of ec.
3390 * enum.cs (ResolveValue): Reset in_transit immediately.
3391 (Emit): Return after first error.
3393 * expression.cs: Convert changes.
3395 * literal.cs: Error method changed.
3397 * statement.cs: Error method changed.
3399 2005-10-06 Raja R Harinath <rharinath@novell.com>
3401 Fix gtest-131.cs and gtest-211.cs.
3402 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
3403 Only emit code for a label if it is used. Unreachable code can
3404 violate ECMA evaluation stack invariants.
3406 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3408 * anonymous.cs: Implemented ExprClassName.
3410 * assign.cs (Assign.DoResolve): Don't chrash when type is not
3413 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
3416 * class.cs (StaticClass.DefineContainerMembers): Report protected
3419 * codegen.cs: if(ed) PRODUCTION.
3421 * convert.cs (Error_CannotImplicitConversion): Better error
3424 * cs-parser.jay: More error checks.
3426 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
3428 * driver.cs (CSCParseOption): Enabled wrong option check.
3430 * ecore.cs (Expression.ExprClassName): Turned to property.
3431 (MemberExpr.CheckIntermediateModification): For checking boxed
3432 value types modification.
3434 * statement.cs (Fixed.Resolve): Expression type must be
3435 convertible to fixed type.
3436 (CollectionForeach.GetEnumeratorFilter,TryType):
3437 Small refactoring for easier error checking.
3439 2005-09-26 Marek Safar <marek.safar@seznam.cz>
3441 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
3444 * class.cs (GeneratedBaseInitializer): New class for customization
3445 compiler generated initializers.
3446 (MemberBase.DoDefine): Check Obsolete attribute here.
3447 (FieldMember.DoDefine): Ditto.
3449 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
3452 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
3453 (MemberCore.GetObsoleteAttribute): Removed argument.
3454 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
3455 (MemberCore.CheckObsoleteType): New helper.
3459 * statement.cs: Updates after MemberCore changes.
3461 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
3462 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
3464 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
3465 obsolete attribute for compiler construct.
3466 (As.DoResolve): Cache result.
3468 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
3470 2005-10-01 Miguel de Icaza <miguel@novell.com>
3472 * expression.cs (Probe): instead of having a "Type probe_type"
3473 keep the extra information as a TypeExpr probe_type_expr since the
3474 "As" operator needs to perform some type checks.
3476 * (As.DoResolve): If the type is a type parameter, ensure that it
3477 is constrained by a class.
3479 2005-09-22 Miguel de Icaza <miguel@novell.com>
3481 * statement.cs (Lock): Use the TemporaryVariable class instead of
3482 manually using local variables as those do not work when variables
3485 * ecore.cs: Moved the TemporaryVariable class from being a nested
3486 class inside Foreach to be a public class that can be employed in
3489 2005-09-19 Marek Safar <marek.safar@seznam.cz>
3491 * cs-parser.jay: interface_accessors replaced by
3492 accessor_declarations.
3494 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
3497 * statement.cs (GotoCase.Resolve): Convert null constant to
3499 (SwitchLabel.ResolveAndReduce): Ditto.
3500 (SwitchLabel.NullStringCase): Custom null stamp.
3501 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
3503 typemanager.cs (CSharpSignature): Don't skip first argument
3506 2005-09-16 Marek Safar <marek.safar@seznam.cz>
3508 * cfold.cs, constant.cs, convert.cs, ecore.cs,
3509 expression.cs, iterators.cs, literal.cs: Store constants and
3512 * class.cs (MemberBase.ShortName): Pass location.
3514 * cs-parser.jay: Some location fixes.
3516 * ecore.cs (Expression.Location): Made virtual.
3518 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3521 * const.cs (Const.ResolveValue): Check for assigning non-null
3522 value to reference type.
3524 2005-09-26 Raja R Harinath <rharinath@novell.com>
3527 * expression.cs (This.VerifyFixed): In a value type T, the type of
3528 'this' is T&, iow, 'this' is either an out or ref parameter. In a
3529 value type R, 'this' is treated as a value parameter.
3531 2005-09-05 Miguel de Icaza <miguel@novell.com>
3533 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3534 if the underlying types are the same, otherwise we need to produce
3535 code that will do the proper cast.
3537 This was exposed by Marek's constant rewrite which produced
3538 invalid code for the call site:
3541 void Method (X v) {}
3545 This fixes test-49.cs
3547 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3549 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
3550 Type/Object should be allowed as well. Fixed bug #75968.
3552 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3554 * expression.cs : (Binary.DoResolve): when one is enum constant and
3555 another is constant 0, then return enum one *as enum type*.
3558 2005-10-04 Martin Baulig <martin@ximian.com>
3560 * ecore.cs (PropertyExpr.ResolveAccessors): Cosmetic fix; make the
3561 `SetMemberIsUsed()' work for generics, too.
3563 2005-10-04 Martin Baulig <martin@ximian.com>
3565 * expression.cs (DelegateInvocation.EmitStatement): Make this work
3566 for corlib. Fixes #75691.
3568 2005-09-28 Marek Safar <marek.safar@seznam.cz>
3571 * driver.cs: Fix compilation files with full root path.
3573 2005-09-25 Miguel de Icaza <miguel@novell.com>
3575 * report.cs (SymbolRelatedToPreviousError): Format the output so
3576 it does not use an open parenthesis that is never closed.
3578 * driver.cs: Follow coding guidelines
3580 2005-09-18 Miguel de Icaza <miguel@novell.com>
3582 * driver.cs: Set InEmacs based on the environment variable EMACS.
3584 * location.cs (InEmacs): in this mode, do not report column
3585 location as it confuses Emacs.
3587 2005-10-03 Raja R Harinath <rharinath@novell.com>
3589 * support.cs (SeekableStreamReader.Position): Don't error out when
3590 the requested position is just beyond the end of the current
3593 2005-09-28 Raja R Harinath <rharinath@novell.com>
3595 * support.cs (SeekableStreamReader): Simplify drastically. Don't
3596 try to keep in sync with the byte count of the underlying Stream.
3597 However, this limits us to a window size of 2048 characters: i.e.,
3598 the maximum lookahead of our lexer/parser can be 2048 characters.
3600 2005-09-22 Martin Baulig <martin@ximian.com>
3602 * driver.cs: Removed a debugging FIXME.
3604 2005-09-21 Raja R Harinath <rharinath@novell.com>
3606 * cs-parser.jay (type_arguments): Add CS1644 check.
3607 * decl.cs (DeclSpace.AddToContainer): Restore CS0694 check.
3609 2005-09-15 Raja R Harinath <rharinath@novell.com>
3611 * Makefile (PROGRAM): Make profile specific.
3612 (gmcs.exe) [PROFILE=net_2_0]: Add utility rule to copy gmcs.exe to
3613 the current directory.
3616 * expression.cs (Invocation.EmitCall): Remove optimization on
3617 this_call since it doesn't handle 'this' being a value type.
3619 2005-09-05 Geoff Norton <gnorton@customerdna.com>
3621 * driver.cs: Ensure file handles are closed after parsing
3623 2005-09-05 Miguel de Icaza <miguel@novell.com>
3625 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3626 if the underlying types are the same, otherwise we need to produce
3627 code that will do the proper cast.
3629 This was exposed by Marek's constant rewrite which produced
3630 invalid code for the call site:
3633 void Method (X v) {}
3637 This fixes test-49.cs
3639 2005-09-05 Martin Baulig <martin@ximian.com>
3641 * expression.cs (As.DoResolve): Use `probe_type.IsValueType'
3642 instead of `TypeManager.IsValueType (probe_type)'; fixes #75668.
3644 * cs-parser.jay (delegate_declaration): Small fix for #75852.
3646 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3648 * typemanager.cs: (IsUnmanagedType) : generic parameter is not allowed
3649 to be a pointer type due to the spec 25.2, so check if declaring
3650 type is generic type definition. Fixed bug #75772.
3652 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3655 * generic.cs : (TypeManager.IsEqual(Type,Type)): it should work when
3656 both types are not defined by methods.
3657 * expression.cs : (Invocation.IsApplicable): it should work when
3658 the argument type is equal to the parameter type, not only when
3659 ImplicitConversionExists() returns true.
3661 2005-09-02 Raja R Harinath <rharinath@novell.com>
3663 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
3667 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
3668 flow-branching for LocalVariableReferences in case we were invoked
3669 from a MemberAccess.
3670 * expression.cs (LocalVariableReference.VerifyAssigned): New.
3672 (LocalVariableReference.DoResolveBase): ... this.
3673 (MemberAccess.Resolve): Do the check that was disabled during
3676 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3679 (PartialContainer.Create): check abstract/sealed/static strictly
3680 but abstract/sealed can exist only at one side. Fixed bug #75883.
3682 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
3685 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
3686 specified, don't default to UnmanagedType.I4.
3688 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3690 * expression.cs : conditional operator should check possibly
3691 incorrect assign expression. Fixed bug #75946.
3693 2005-08-30 Raja R Harinath <rharinath@novell.com>
3696 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
3697 (ScopeInfo.EmitScopeType): Use it to construct field names from
3698 names of captured locals.
3701 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
3702 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
3703 Pass 'target_type' to BoxedCast. Don't default to 'object'.
3704 (ExplicitConversion): Remove enum cases already handled by
3705 implicit conversion. Move implicit conversion check to the beginning.
3706 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
3707 * expression.cs (ArrayCreation.EmitDynamicInitializers):
3708 Don't treat System.Enum as a struct.
3710 2005-08-30 Jb Evain <jbevain@gmail.com>
3712 * attribute.cs: handles as expression in parameters.
3714 2005-08-30 Raja R Harinath <rharinath@novell.com>
3717 * class.cs (TypeContainer.VerifyClsName): Don't use a
3718 PartialContainer when verifying CLS compliance.
3719 (AbstractPropertyEventMethod): Set Parent here, ...
3720 (PropertyMethod): ... not here.
3722 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
3724 * attribute.cs : escaped attribute name should not be allowed to be
3725 resolved (e.g. @class as classAttribute). Fixed bug #75930.
3727 2005-08-29 Raja R Harinath <rharinath@novell.com>
3730 * convert.cs (ImplicitStandardConversionExists): Allow zero also
3731 when converting a long constant to unsigned long.
3732 * expression.cs (Invocation.OverloadResolve): Add sanity check to
3733 detect where IsApplicable and VerifyArgumentsCompat disagree.
3735 2005-08-29 Raja R Harinath <rharinath@novell.com>
3736 and Carlos Alberto Cortez <carlos@unixmexico.org>
3739 * class.cs (TypeContainer.CanElideInitializer): New helper.
3740 (TypeContainer.EmitFieldInitializers): Use it to determine if we
3741 can safely emitting the initializer of a field.
3743 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3745 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
3746 allowed inside a switch (without loop). Fixed bug #75433.
3748 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
3750 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
3751 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
3753 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3755 * driver.cs : kinda reverting the default encoding changes (not exact
3756 revert since I noticed that "codepage:reset" might not work fine).
3758 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3760 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
3761 Location. Now getter and setter store location correctly.
3762 (errors/cs0111-12.cs now reports the expected location.)
3764 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3766 * driver.cs : Use default encoding on the environment.
3767 Removed (now that) extra parameter for SeekableStreamReader.
3768 * support.cs : (SeekableStreamReader) third .ctor() argument for
3769 StreamReader is not required (always true). preamble size could
3770 be acquired in simpler and safe way.
3772 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
3774 * cs-parser.jay: report CS0642 at warning level 3
3775 and report CS0642 for an if else statement also
3776 fixes bug #74745. Patch by John Luke (and a bit
3778 Removed extra CS0642 warning check for "while",
3780 * statement.cs: In Block.Resolve(), CS0642 check
3781 is reimplemented to check a sequence of an empty
3782 statement and a block.
3784 Both fix bug #66777.
3786 2005-08-24 Marek Safar <marek.safar@seznam.cz>
3788 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
3789 detection until I fix it.
3791 * cs-tokenizer.cs: Changed error message.
3793 * cs-parser.jay: Fixed 2 error locations.
3795 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
3796 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
3799 * enum.cs (GetSignatureForError): Fixed.
3801 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
3805 * typemanager.cs (RegisterProperty): Removed.
3807 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
3809 2005-08-24 Raja R Harinath <rharinath@novell.com>
3812 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
3813 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
3815 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3817 * expression.cs : tiny fix is required for not warning positive ulong.
3820 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3822 * expression.cs : add CS0652 check for constant and integral
3823 expression. Fixed bug #53974.
3825 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3827 * expression.cs : in DoNumericPromotions(), check if there is implicit
3828 conversion overload for string (to check CS0034). Fixed bug #52492.
3830 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3832 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
3834 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3836 * ecore.cs : report location when it is *not* Null.
3838 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3844 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
3845 correctly. Fixed bug #75721.
3847 2005-08-23 Raja R Harinath <rharinath@novell.com>
3849 * support.cs (SeekableStreamReader.Position): Avoid an expensive
3850 loop that performs 'min (pos, char_count)'.
3853 * expression.cs (Unary.ResolveOperator): Don't discard implicit
3854 converted value in Operator.OnesComplement.
3856 2005-08-22 Ben Maurer <bmaurer@ximian.com>
3858 * anonymous.cs: If the anon method is pulled into a helper class,
3859 it needs to be `internal' not `private'. Fixes runtime behavior on
3862 2005-08-17 Marek Safar <marek.safar@seznam.cz>
3865 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
3868 2005-08-16 Marek Safar <marek.safar@seznam.cz>
3870 The big constants rewrite
3871 Fix #75746, #75685 and more
3872 As a side effect saved 1MB for MWF ;-)
3874 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
3875 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
3876 enum based for corlib compilation.
3878 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
3881 * class.cs (FixedField.Define): Use ResolveAsConstant.
3883 * const.cs (IConstant): Interface constants and enums.
3884 (Const.ResolveValue): New method for constant resolvning.
3885 (ExternalConstant): Constants from imported assemblies.
3887 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
3888 conversion; like enums.
3889 (Constant.ToType): Converts this constant to different type.
3890 (Constant.Increment): Adds 1.
3892 * convert.cs (ImplicitConversionRequired): Simplified.
3894 * cs-parser.jay: Create EnumMember directly.
3896 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
3898 * doc.cs (GenerateEnumDocComment): Removed.
3900 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
3901 (ConvertIntLiteral): Removed.
3902 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
3904 * enum.cs (EnumMember): Implement IConstant.
3905 (Enum.IsValidEnumConstant): Removed.
3906 (Enum.GetNextDefaultValue): Removed.
3907 (Enum.FindMembers): Updated.
3908 (Enum.GenerateDocComment): Iterate enum members.
3910 * expression.cs (Cast.TryReduce): Handle enums correctly.
3911 (New.Constantify): Made public.
3912 (MemberAccess.DoResolve): Removed contant specific if(s).
3914 * literal.cs (NullLiteral): Implement new abstract methods.
3916 * statement.cs (GotoCase.Resolve): Use new constant methods.
3917 (SwitchLabel.ResolveAndReduce): Use new constant methods.
3919 * typemanager.cs (LookupEnum): Removed.
3920 (IsEnumType): Fixed to work with corlib.
3921 (RegisterConstant): Removed.
3922 (LookupConstant): Removed.
3923 (GetConstant): Changed to work with IConstant.
3925 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
3927 * location.cs : Fixed overflown (>255) column number.
3929 2005-08-03 Raja R Harinath <rharinath@novell.com>
3931 First cut of the qualified-alias-member feature.
3932 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
3934 * cs-parser.jay (DOUBLE_COLON): New token.
3935 (namespace_or_type_name): Add rule for recognizing
3936 qualified-alias-members.
3937 (primary_expression): Likewise.
3938 (element_access): Allow QualifiedAliasMember as a possible
3939 type-bearing expression.
3940 (local_variable_type, local_variable_pointer_type): Likewise.
3941 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
3942 aliases in the current and enclosing namespace declarations.
3943 (NamespaceEntry.UsingAlias): Add CS0440 warning.
3944 * decl.cs (MemberName.is_double_colon): New.
3945 (MemberName.MemberName): Add new constructor for alias-member.
3946 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
3947 * expression.cs (QualifiedAliasMember): New expression type.
3949 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3951 * location.cs : it borked when no argument was specified.
3953 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3955 * location.cs : tiny ToString() format fix.
3957 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3959 * statement.cs : oops, it was missing.
3961 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3963 A set of fixes for precise line/column location.
3966 "token" field now holds a file/line "delta", a line number offset
3967 from the segment, and a column number. See also:
3968 http://lists.ximian.com/pipermail/mono-devel-list/2004-
3969 December/009508.html
3970 Removed static IsNull. Use instance IsNull property instead.
3972 For some tokens it stores Location. For Identifier it stores
3973 LocatedToken which is a pair of string name and location.
3974 Column numbers are adjusted only at getChar().
3976 Use Location.ToString() for reporting (it now contains column).
3978 Largely modified to use LocatedToken instead of
3979 string (IDENTIFIER), and to acquire Location from some tokens.
3980 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
3981 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
3983 Now MemberName holds Location. DeclSpace.ctor() receives Location
3984 as a parameter. Removed extra parameters to all derived classes.
3985 Replaced Location.IsNull() with instance property.
3986 * assign.cs, expression.cs :
3987 Added .ctor() overload that omits Location.
3989 Added "nameEscaped" flag that indicates the identifier was escaped
3990 in the source file. This fixes bug #57047.
3992 2005-09-02 Martin Baulig <martin@ximian.com>
3994 * class.cs: Make CS3005 a warning, not an error.
3996 2005-08-02 Marek Safar <marek.safar@seznam.cz>
3998 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
3999 New method, looking for lo-case imported cls type.
4001 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
4004 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
4006 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
4008 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
4010 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
4012 Optimized to save 3.5 MB for SWF compilation.
4014 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4016 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
4017 (PartialContainer.Create): Moved logic AddToContainer.
4018 (PartialContainer.MarkForDuplicationCheck): Shares name.
4020 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
4023 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
4025 (Namespace.GetSignatureForError): New method.
4027 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
4028 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
4030 2005-08-01 Raja R Harinath <rharinath@novell.com>
4033 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
4034 member lookup rather than qualifier_type, since qualifier_type can
4037 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4039 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
4042 2005-07-31 Miguel de Icaza <miguel@novell.com>
4044 * statement.cs: Copy the local exception into the exception
4045 captured local. Fixes 75674
4047 2005-07-31 Raja R Harinath <harinath@gmail.com>
4050 * expression.cs (Invocation.OverloadResolve): Don't report error
4051 CS1501 if error CS1502 has been reported.
4052 (New.DoResolve): Delegate CS1501 reporting to
4053 Invocation.OverloadResolve.
4056 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
4057 invariant-meaning-in-block property in an enclosing block if
4060 2005-07-29 Marek Safar <marek.safar@seznam.cz>
4062 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
4063 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
4064 (Switch.CheckSwitch): Just save 50kb for SWF.
4066 2005-07-27 Martin Baulig <martin@ximian.com>
4068 * anonymous.cs (CaptureContext.AddField): Added
4069 `AnonymousContainer am' argument; compute its toplevel scope if
4070 it's not already computed. Fixes #75649.
4072 2005-07-26 Raja R Harinath <rharinath@novell.com>
4075 * class.cs (Constructor.Emit): Reset block to null if the block
4078 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4080 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
4082 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4084 * class.cs (MethodData.Define): Check whether accessor implementing
4085 interface is public.
4087 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
4089 2005-07-22 Marek Safar <marek.safar@seznam.cz>
4092 * namespace.cs (LookupType): Moved same type check to...
4094 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
4097 2005-07-21 Raja R Harinath <rharinath@novell.com>
4099 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
4100 already found a typebuilder.
4101 * class.cs (MethodCore.IsDuplicateImplementation): Compare
4102 MemberNames, not strings.
4104 * const.cs (Error_ExpressionMustBeConst):
4105 Rename from Error_EpressionMustBeConst.
4106 * const.cs, class.cs, statement.cd: Update.
4108 2005-07-21 Marek Safar <marek.safar@seznam.cz>
4112 * const.cs (Const.LookupConstantValue): Report missing contant expression
4114 (Error_EpressionMustBeConstant): Only one error method.
4116 * class.cs, statement.c: Updated.
4118 2005-07-20 Raja R Harinath <rharinath@novell.com>
4120 * statement.cs (Block.Flags): Add back HasVarargs.
4121 (Block.flags): Make protected.
4122 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
4124 * typemanager.cs (types, typecontainers, user_types): Remove.
4125 (UserTypes, TypeContainers): Likewise.
4126 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
4127 (CleanUp, Reset): Update.
4128 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
4129 (GetNestedType): Use Type.GetNestedType.
4130 (CoreLookupType): Take two arguments, the namespace and the
4131 basename of the type. Update to use the Namespace.Lookup
4133 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
4134 (RealMemberLookup): Use IsNestedChildOf instead of playing with
4135 string concatenation and substring matches.
4136 * class.cs, enum.cs, delegate.cs: Update to changes.
4138 2005-07-20 Marek Safar <marek.safar@seznam.cz>
4140 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
4141 Expression and made virtual.
4143 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
4144 (ImplicitStandardConversionExists): Fixed `byte' typo ?
4146 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
4148 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
4151 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
4154 2005-07-18 Marek Safar <marek.safar@seznam.cz>
4157 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
4158 AssemblyCultureAttribute is not used on executable.
4161 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
4163 2005-07-16 Raja R Harinath <rharinath@novell.com>
4166 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
4167 New. Reports CS0252/CS0253.
4168 Mostly taken from preliminary patch by Duncak Mak.
4169 (Binary.DoResolveOperator): Store results of operator lookup.
4170 Use them to detect if we need to warn about unintended reference
4173 2005-07-15 Raja R Harinath <rharinath@novell.com>
4176 * namespace.cs (Namespace.Lookup): Add back location parameter.
4177 (Namespace.LookupType): Add CS0436 report. Add location parameter.
4178 * delegate.cs, ecore.cs, expression.cs: Update to changes.
4180 * codegen.cs (EmitContext.DeclSpace): Make readonly.
4181 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
4182 (Namespace.LookupType): ... this.
4183 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
4185 * typemanager.cs (LookupTypeReflection): Remove buggy code that
4186 purported to handle pointers.
4187 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
4190 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4192 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4195 2005-07-15 Raja R Harinath <rharinath@novell.com>
4197 * namespace.cs (Namespace.Lookup): Drop location parameter.
4198 (NamespaceEntry.LookupAlias): Remove. Merge into ...
4199 (NamespaceEntry.Lookup): ... this.
4200 (NamespaceEntry.Error_AmbiguousTypeReference):
4201 Move here from DeclSpace.
4202 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
4204 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
4205 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
4206 Move to NamespaceEntry.
4207 * delegate.cs, expression.cs: Update to changes.
4209 2005-08-31 Martin Baulig <martin@ximian.com>
4211 Committing a patch from Atsushi Enomoto for #75850.
4213 * statement.cs (Foreach.CollectionForeach.GetEnumeratorFilter):
4214 Prefer a generic enumerator over a non-generic one.
4216 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4218 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4219 * gmcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4221 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4223 * driver.cs : reverting default encoding change as well as mcs.
4225 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4227 * driver.cs, support.cs : merged r48826.
4229 > could you integrate your mcs changes to gmcs otherwise
4230 > gmcs cannot compile some files.
4232 2005-08-20 Martin Baulig <martin@ximian.com>
4234 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
4235 scope if we don't already have it.
4237 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
4238 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
4241 2005-07-31 Miguel de Icaza <miguel@novell.com>
4243 * statement.cs: Copy the local exception into the exception
4244 captured local. Fixes 75674
4246 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4248 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4251 2005-08-12 Martin Baulig <martin@ximian.com>
4253 * expression.cs (MemberAccess.ResolveNamespaceOrType): Only search
4254 for nested types here to avoid hitting the cache too early.
4256 2005-08-09 Miguel de Icaza <miguel@novell.com>
4258 * enum.cs: On the new compiler CLS error 3005 is now a warning not
4261 2005-08-03 Martin Baulig <martin@ximian.com>
4263 Make iterators in generic methods work; see gtest-191.cs.
4266 (Constraints.Resolve): Protect against being called twice.
4269 (TypeContainer.GetClassBases): Make this `protected virtual'.
4271 * iterator.cs (Iterator.ctor): Added `GenericMethod' argument.
4272 (Iterator.GetClassBases): Override this and compute the base
4274 (Iterator.DefineNestedTypes): If we're a generic method, all our
4275 method type parameters become class type parameters on the proxy
4279 (ToplevelBlock.Parameters): Make this a property, not a field.
4280 (ToplevelBlock.ResolveMeta): Update the `parameters' from the `ip'.
4282 2005-08-03 Martin Baulig <martin@ximian.com>
4284 * typemanager.cs (TypeManager.IsSubclassOf): Use
4285 `TypeManager.IsEqual' instead of `Type.Equals'; fixes gtest-190.cs.
4286 (TypeManager.GetFullName_recursed): Improved.
4288 2005-07-27 Carlos Alberto Cortez <calberto.cortez@gmail.com>
4291 * ecore.cs (Expression.IsAccessorAccessible): Change the check for
4292 Private accessor case, using TypeManager.IsPrivateAccessible instead of
4293 invocation_type == mi.DeclaringType, since the first one also checks
4294 other condition used by generic instances.
4296 2005-07-27 Martin Baulig <martin@ximian.com>
4298 * anonymous.cs (CaptureContext.AddField): Added
4299 `AnonymousContainer am' argument; compute its toplevel scope if
4300 it's not already computed. Fixes #75649.
4302 2005-07-14 Marek Safar <marek.safar@seznam.cz>
4304 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
4305 CheckAttributeType and refactored.
4306 (Attribute.ResolvePossibleAttributeType): Changed to reuse
4307 ResolveAsTypeTerminal error handling.
4308 (ResolveAsTypeTerminal): Introduced because of global attributes extra
4310 (GetSignatureForError): Print errors in same way.
4313 * codegen.cs: Reflect attribute GetSignatureForError change.
4316 * expression.cs: Add silent parameter to ResolveAsTypeStep.
4318 * namespace.cs (UsingEntry): Refactored to make fields private.
4321 statement.cs: Error_UnexpectedKind has extra parameter.
4323 2005-07-14 Raja R Harinath <rharinath@novell.com>
4325 * ecore.cs (IAlias): Remove.
4326 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
4327 that implement the interface.
4328 * namespace.cs (Namespace): Likewise.
4329 (Namespace.declspaces): Renamed from 'defined_names'.
4330 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
4331 DeclSpace instead of an IAlias.
4332 * tree.cs (Tree.AddDecl): Update.
4334 2005-07-12 Raja R Harinath <rharinath@novell.com>
4336 * statement.cs (Block.Flags); Remove HasVarargs.
4337 (Block.HasVarargs): Move to ToplevelBlock.
4338 (Block.ThisVariable, Block.AddThisVariable): Likewise.
4339 (Block.Variables): Make protected. Initialize variable hashtable
4341 (Block.AddVariable): Update.
4342 (Block.Resolve): Update to changes.
4343 (ToplevelBlock.HasVarargs): New boolean.
4344 (ToplevelBlock.ThisVariable): Move here from Block.
4345 (ToplevelBlock.AddThisVariable): Likewise.
4346 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
4347 * expression.cs (This.ResolveBase): Update to changes.
4348 (ArglistAccess.DoResolve): Likewise.
4350 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4353 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
4355 * class.cs (TypeContainer.VerifyMembers): Distinguish between
4356 not used and not used & assigned.
4357 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
4359 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4362 * expression.cs (Is.DoResolve): null is never provided type.
4364 2005-07-08 Marek Safar <marek.safar@seznam.cz>
4367 * cs-parser.jay: Less strict event error rule to catch more errors.
4369 2005-07-11 Martin Baulig <martin@ximian.com>
4371 * generic.cs (ConstructedType.CheckConstraints): Improve the check
4372 for the constructor constraint: we do not only have to check
4373 whether the class has a public constructor, but also ensure that
4374 it's parameterless. Fixes #75492.
4376 2005-07-11 Martin Baulig <martin@ximian.com>
4378 * expression.cs (Binary.ResolveOperator): Only allow `==' and `!='
4379 between type parameters if they either have the reference type
4380 constraint or the class constraint.
4382 2005-07-10 Kamil Skalski <nazgul@nemerle.org>
4384 * generic.cs: Use MakeGenericType instead of BindGenericParameters.
4386 2005-07-07 Marek Safar <marek.safar@seznam.cz>
4389 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
4390 (ExtractSecurityPermissionSet): Cope with self referencing security
4391 attributes properly.
4393 * driver.cs (SetOutputFile): Made public property OutputFile.
4395 2005-07-07 Raja R Harinath <rharinath@novell.com>
4398 * class.cs (TypeContainer.first_nonstatic_field): Rename from
4399 has_nonstatic_fields. Make into a FieldBase pointer.
4400 (TypeContainer.AddField): Add CS0282 check.
4401 (TypeContainer.EmitType): Update.
4403 2005-07-06 Miguel de Icaza <miguel@novell.com>
4405 * cs-tokenizer.cs (consume_identifier): Do not create strings to
4406 compare if they start with __.
4408 2005-07-06 Raja R Harinath <rharinath@novell.com>
4410 * statement.cs (Switch.SwitchGoverningType): Only look at
4411 UserCasts that don't need implicit standard conversions to one of
4412 the allowed switch types (Fixes test-322.cs).
4413 (LocalInfo.Resolve): Re-enable sanity-test.
4415 2005-07-06 Marek Safar <marek.safar@seznam.cz>
4417 * cs-tokenizer.cs (consume_identifier): Detect double undescores
4419 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
4421 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
4423 2005-07-06 Raja R Harinath <rharinath@novell.com>
4426 * ecore.cs (SimpleName.GetSignatureForError): Add.
4427 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
4428 (MemberAccess.GetSignatureForError): Add.
4430 2005-07-05 Marek Safar <marek.safar@seznam.cz>
4432 The big error and warning messages review.
4462 * typemanager.cs: Updated.
4464 * class.cs: (MethodCore.SetYields): Moved here to share.
4465 (PropertyMethod.Define): Moved iterator setup here.
4467 * iterators.cs: Add orig_method to have full access to parent
4470 2005-07-05 Raja R Harinath <rharinath@novell.com>
4472 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
4473 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
4474 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
4475 variable of struct type.
4476 * expression.cs (Unary.ResolveOperator): Update to change.
4477 (Indirection.VerifyFixed): Likewise.
4478 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
4479 (ParameterReference.VerifyFixed): Value parameters are fixed.
4480 (This.VerifyFixed): Treat 'this' as a value parameter.
4481 * statement.cs (LocalInfo.IsFixed): Remove.
4483 2005-07-01 Martin Baulig <martin@ximian.com>
4485 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4486 `ec.EmitThis ()' to get the correct scope.
4488 2005-07-01 Martin Baulig <martin@ximian.com>
4490 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
4491 instance is a ParameterReference; fixes #75299.
4493 2005-06-30 Raja R Harinath <rharinath@novell.com>
4496 * expression.cs (Indexers.map): Remove.
4497 (Indexers.Append): Filter out inaccessible setters and getters.
4498 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
4501 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
4503 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
4504 (FieldExpr.Emit, PropertyExpr.Emit): Update.
4505 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
4506 * expression.cs (Invocation.EmitCall): Add CS0120 check.
4508 2005-06-30 Marek Safar <marek.safar@seznam.cz>
4511 * class.cs (FieldBase.GetInitializerExpression): One more field
4514 2005-06-28 Miguel de Icaza <miguel@novell.com>
4516 * pending.cs: Do not define a proxy if the base method is virtual,
4517 it will be picked up by the runtime (bug 75270).
4519 2005-07-08 Martin Baulig <martin@ximian.com>
4521 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
4522 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
4524 2005-07-07 Martin Baulig <martin@ximian.com>
4526 * generic.cs (ConstructedType.CheckConstraint): Use
4527 ResolveAsTypeStep(), not ResolveAsTypeTerminal() so we're not
4528 called recursively; fixes #75329.
4530 2005-07-06 Martin Baulig <martin@ximian.com>
4532 * generic.cs (TypeManager.InferTypeArguments): Added support for
4533 anonymous methods; fixes #75461.
4535 2005-07-01 Martin Baulig <martin@ximian.com>
4537 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4538 `ec.EmitThis ()' to get the correct scope.
4540 2005-07-01 Martin Baulig <martin@ximian.com>
4542 * ecore.cs (FieldExpr.DoResolve): Only capture the field if it's
4543 instance is `This'; fixes #75299.
4545 2005-06-30 Martin Baulig <martin@ximian.com>
4547 * class.cs (Indexer): Implement IIteratorContainer; added support
4548 for iterators in indexers.
4551 (EmitContext.CurrentIterator): Make this a property, not a field.
4553 * anonymous.cs (AnonymousContainer.Iterator): New public property.
4555 2005-06-28 Miguel de Icaza <miguel@novell.com>
4557 * pending.cs: Do not define a proxy if the base method is virtual,
4558 it will be picked up by the runtime (bug 75270).
4560 2005-06-28 Martin Baulig <martin@ximian.com>
4562 * cs-parser.jay (interface_method_declaration): Avoid a
4563 reduce/reduce conflict by moving some of the code into a separate
4564 `interface_method_declaration_body' rule; fixes #75368.
4566 2005-06-28 Martin Baulig <martin@ximian.com>
4568 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Move the
4569 array check after the check for TypeBuilder's.
4571 2005-06-21 Raja R Harinath <rharinath@novell.com>
4573 * convert.cs (FindMostEncompassedType): Add two trivial special
4574 cases (number_of_types == 0 || number_of_types == 1).
4575 (FindMostEncompasingType): Likewise.
4577 2005-06-17 Raja R Harinath <rharinath@novell.com>
4579 Some cleanups preparing for the fix of #75283.
4580 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
4582 (EventExpr.InstanceResolve): Likewise.
4583 (EventExpr.DoResolve): Remove redundant checks.
4585 2005-06-08 Miguel de Icaza <miguel@novell.com>
4587 * class.cs: Small fix.
4589 2005-06-08 Raja R Harinath <rharinath@novell.com>
4592 * class.cs (GetPartialBases): Fix return value check of
4595 2005-06-07 Raja R Harinath <rharinath@novell.com>
4597 Ensure that partial classes are registered in their enclosing
4598 namespace. Initial part of fix of #75160.
4599 * tree.cs (Tree.RecordDecl): Add new namespace argument.
4600 Register declspace with namespace here, not in
4601 DeclSpace.RecordDecl.
4602 * cs-parser.jay: Pass namespace to RecordDecl.
4603 * class.cs (PartialContainer.Create): Likewise.
4604 (ClassPart.DefineType): New sanity-check. Throws an exception if
4606 * decl.cs (Declspace.RecordDecl): Remove.
4607 * namespace.cs (NamespaceEntry.DefineName): Remove.
4609 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4611 * rootcontext.cs: Reset TargetExt as well.
4613 2005-06-03 Raja R Harinath <rharinath@novell.com>
4615 * ecore.cs (Expression.Resolve): Emit CS0654 error when
4618 2005-06-02 Raja R Harinath <rharinath@novell.com>
4620 Fix #75080, cs0119.cs.
4621 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
4623 (Expression.Resolve): ... this. Use it. Remove bogus code
4624 allowing ExprClass.Type and ExprClass.Namespace for
4625 ResolveFlags.VariableOrValue.
4626 (Expression.Resolve) [1-argument variant]: Change default resolve
4627 flags based on language version.
4628 (Expression.Error_UnexpectedKind): Use a simple string array
4629 rather than an ArrayList.
4630 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
4632 (TypeOfVoid.DoResolve): Likewise.
4633 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
4634 flags argument -- it always has the same value.
4636 2005-05-31 Raja R Harinath <rharinath@novell.com>
4639 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
4640 Use it in the error message.
4641 * assign.cs, expression.cs, statement.cs: Update.
4643 2005-05-30 Raja R Harinath <rharinath@novell.com>
4646 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
4647 the "almostMatchedMember" case too.
4648 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
4649 that failed the accessibility checks to 'almost_match'.
4651 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
4653 * attribute.cs: Use internal MethodBuilder methods to set
4654 ExactSpelling and SetLastError on PInvoke methods, instead
4655 of passing them via charset. Fixes #75060.
4657 2005-05-27 Raja R Harinath <rharinath@novell.com>
4659 * parameter.cs (Parameter): Remove TODO comment.
4660 (Parameter.DefineParameter): Remove Location parameter.
4661 (Parameters.LabelParameters): Likewise.
4662 * class.cs (Constructor.Emit): Update to change.
4663 (MethodData.Emit): Likewise.
4664 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
4665 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
4667 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
4670 Removed Parameters.Location and added Parameter.Location instead.
4671 Removed Location parameter from Emit() and GetSignature().
4678 Modified all related calls.
4680 2005-06-21 Martin Baulig <martin@ximian.com>
4682 * generic.cs (NullCoalescingOperator.Emit): Make this work if the
4683 left-hand side is not a nullable type; fixes #75328.
4685 2005-06-21 Martin Baulig <martin@ximian.com>
4688 (TypeManager.CSharpName): Use GetFullName() instead of `t.FullName'.
4689 (TypeManager.GetFullNameSignature): Likewise.
4691 * convert.cs (Convert.Error_CannotImplicitConversion): Compare
4692 `source.FullName' and `target.FullName' to check whether there are
4693 two conflicting definitions.
4695 2005-06-21 Martin Baulig <martin@ximian.com>
4697 * convert.cs (Convert.ImplicitTypeParameterConversion): Always use
4698 a BoxedCast - also for reference types - to be compatible with csc.
4700 2005-06-21 Martin Baulig <martin@ximian.com>
4702 * expression.cs (MemberAccess.DoResolve): Add support for nested
4703 types in a generic instance; fixes #75320.
4705 2005-06-20 Martin Baulig <martin@ximian.com>
4707 * generic.cs (TypeManager.InferType): Also walk the class
4708 hierarchy for generic instances; fixes #75261.
4710 2005-06-17 Martin Baulig <martin@ximian.com>
4712 * typemanager.cs (TypeManager.IsBuiltinType): Use TypeToCoreType()
4713 to make things work for corlib.
4715 2005-06-15 Martin Baulig <martin@ximian.com>
4717 * attribute.cs (Attribute.CheckSecurityActionValidity): Remove the
4718 obsolete `SecurityAction' values.
4720 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4722 * rootcontext.cs: Reset TargetExt as well.
4724 2005-06-09 Martin Baulig <martin@ximian.com>
4726 * delegate.cs (Delegate.VerifyMethod): Added
4727 `MethodGroupExpr old_mg' argument; inherit its
4728 `HasTypeParameters'; fix #75085.
4730 2005-06-09 Martin Baulig <martin@ximian.com>
4732 * expression.cs (Invocation.OverloadResolve): Correctly handle
4733 generic methods for the SetMemberIsUsed(); fix #75064.
4735 2005-06-09 Martin Baulig <martin@ximian.com>
4737 * statement.cs (Throw.Resolve): Use TypeManager.IsSubclassOf();
4740 2005-06-08 Martin Baulig <martin@ximian.com>
4742 * cs-parser.jay (nullable_type_or_conditional): If we put the
4743 nullable back and our `type' is a `ComposedCast', remove the
4744 nullable from it. Fixes #75156.
4746 * expression.cs (ComposedCast.RemoveNullable): New public method.
4748 2005-06-08 Martin Baulig <martin@ximian.com>
4750 The big Iterators rewrite :-)
4752 * iterators.cs: Rewrite this to use the anonymous methods framework.
4754 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
4755 before the TypeContainers; see 2test-21.cs.
4758 (TypeContainer.DefineType): Don't create a new EmitContext if we
4759 already have one (this only happens if we're an Iterator).
4760 (TypeContainer.Define): Also call Define() on all our iterators.
4761 (Method.CreateEmitContext): Added support for iterators.
4764 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
4765 (AnonymousContainer.CreateMethodHost): Moved here from
4766 AnonymousMethod and made abstract.
4767 (AnonymousContainer.CreateScopeType): New abstract method.
4768 (AnonymousContainer.IsIterator): New public property.
4769 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
4770 get the ScopeTypeBuilder rather than manually defining it here.
4771 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
4774 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
4775 before RootContext.DefineTypes().
4777 * codegen.cs (EmitContext.RemapToProxy): Removed.
4778 (EmitContext.CurrentAnonymousMethod): Changed type from
4779 AnonymousMethod -> AnonymousContainer.
4780 (EmitContext.ResolveTopBlock): Protect from being called twice.
4781 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
4782 (EmitContext.EmitThis): Removed the iterators hacks; use the
4783 anonymous methods framework for that.
4786 (ToplevelBlock.Container): Make this a property, not a field.
4787 (ToplevelBlock.ReParent): New public method; move the
4788 ToplevelBlock into a new container.
4789 (Foreach.TemporaryVariable): Simplify.
4791 2005-06-05 Martin Baulig <martin@ximian.com>
4793 * statement.cs (LocalInfo.CompilerGenerated): New flag.
4794 (Block.AddTemporaryVariable): New public method; creates a new
4795 `LocalInfo' for a temporary variable.
4796 (Block.EmitMeta): Create the LocalBuilders for all the temporary
4798 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
4799 non-iterator variables.
4801 2005-06-05 Martin Baulig <martin@ximian.com>
4803 * statement.cs (Foreach.TemporaryVariable): Create the
4804 LocalBuilder in the Emit phase and not in Resolve since in some
4805 situations, we don't have an ILGenerator during Resolve; see
4806 2test-19.cs for an example.
4808 2005-06-04 Martin Baulig <martin@ximian.com>
4810 The big Foreach rewrite - Part II.
4812 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
4813 with `PropertyInfo ienumerator_getcurrent'.
4815 * codegen.cs (VariableStorage): Removed.
4818 (Foreach): Derive from Statement, not ExceptionStatement.
4819 (Foreach.CollectionForeach): New nested class. Moved all the code
4820 dealing with collection foreach here.
4821 (Foreach.ForeachHelperMethods): Removed.
4822 (Foreach.TemporaryVariable): Implement IMemoryLocation.
4824 2005-05-23 Martin Baulig <martin@ximian.com>
4826 * statement.cs (Try.DoResolve): Don't create a `finally' if we
4827 don't need to. Fix #75014.
4829 2005-05-26 Raja R Harinath <rharinath@novell.com>
4831 Improve user-defined conversion handling.
4832 * convert.cs (GetConversionOperators): Rewrite. Return only the
4833 applicable operators.
4834 (AddConversionOperators): New. Helper for GetConversionOperators.
4835 (FindMostEncompassedType, FindMostEncompassingType): Verify that
4836 there is only one most encompassed/encompassing type.
4837 (FindMostSpecificSource, FindMostSpecificTarget): Remove
4838 "applicable operator" handling.
4839 (UserConversion): Move cache here from GetConversionOperators.
4840 Directly cache the chosen operator, rather than the whole
4842 (ExplicitNumericConversion): Fix buggy implementation of Decimal
4843 case. Allow conversion of decimal to sbyte and byte too.
4844 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
4845 New static methods. Used to avoid allocating EmptyExpressions in
4848 2005-05-24 Duncan Mak <duncan@novell.com>
4850 * ecore.cs (CastFromDecimal): New class for casting a decimal to
4851 another class, used in Convert.ExplicitNumericConversion.
4852 (CastToDecimal): New class, similar to above, but casts to
4853 System.Decimal, used in Convert.ImplicitNumericConversion and also
4854 in explicit convesion from double/float to decimal.
4856 * convert.cs (ImplicitNumericConversion): Handle implicit
4857 conversions to System.Decimal.
4858 (ExplicitNumericConversion): handle explicit conversions to
4863 2005-05-20 Miguel de Icaza <miguel@novell.com>
4865 * typemanager.cs: Do not throw an exception in the TypeBuilder
4866 case, we take care of it on the TypeCode.
4868 2005-05-17 Marek Safar <marek.safar@seznam.cz>
4870 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
4873 * cs-parser.jay: Catch more lexical errors.
4875 * report.cs: Add one more Error method.
4878 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
4880 2005-05-20 Martin Baulig <martin@ximian.com>
4882 * class.cs (TypeContainer.CircularDepException): Removed.
4883 (TypeContainer.DefineType): Removed the `InTransit' stuff.
4884 (TypeContainer.CheckRecursiveDefinition): Check for circular class
4885 (CS0146) and interface (CS0529) dependencies here.
4887 2005-05-20 Martin Baulig <martin@ximian.com>
4889 * expression.cs (New.DoResolve): Move the CS0712 check above the
4890 CS0144 check; otherwise it can never be reached.
4892 2005-05-20 Martin Baulig <martin@ximian.com>
4894 * cs-parser.jay: Fix CS0080 check; add CS0231 and CS0257 from MCS.
4896 2005-05-20 Martin Baulig <martin@ximian.com>
4898 * class.cs (TypeContainer.DefineType): Fix CS0698 check.
4900 * typemanager.cs (TypeManager.IsAttributeType): New public method.
4902 2005-05-19 Martin Baulig <martin@ximian.com>
4905 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
4906 to disable error reporting.
4908 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
4909 here since we don't want to report an error; see the new test-336.cs.
4911 2005-05-19 Raja R Harinath <rharinath@novell.com>
4913 * statement.cs (ToplevelBlock.GetParameterReference)
4914 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
4915 Move here from class Block.
4916 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
4917 * expression.cs (ParameterReference.DoResolveBase): Likewise.
4919 2005-05-18 Martin Baulig <martin@ximian.com>
4924 (FlowBranching.Reachability): Add non-static public And() and Or()
4926 (FlowBranchingSwitch): New class; do the `break_origins' thing
4927 like in FlowBranchingLoop.
4928 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
4929 reachability, not just locals and parameters.
4930 (FlowBranching.MergeChild): Remove some of the hacks for loop and
4931 switch; MergeBreakOrigins() now takes care of that.
4933 2005-05-18 Martin Baulig <martin@ximian.com>
4935 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
4936 a loop and may leave it, reset the barrier; fixes #74974.
4938 2005-05-16 Raja R Harinath <rharinath@novell.com>
4940 Fix test-382.cs. Emit values of decimal constants.
4941 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
4943 (TypeContainer.AddField): ... this.
4944 (TypeContainer.EmitFieldInitializers): Allow the list of fields
4945 with initializers to include 'Const's.
4946 (ClassPart.RegisterFieldForInitialization): Forward to
4948 * const.cs (Const.Const): Pass initializer to base class.
4949 (Const.Define): In case of decimal constants, register them for
4950 initialization in a static constructor.
4952 2005-05-14 Martin Baulig <martin@ximian.com>
4954 * statement.cs (Block.Resolve): Correctly handle unreachable code;
4955 do not call ResolveUnreachable() on unreachable statements in
4956 here, see the comment in the source code.
4958 2005-05-13 Raja R Harinath <rharinath@novell.com>
4961 * expression.cs (BinaryResolveOperator): If one of the operands of
4962 an equality comparison is 'null' and the other is a pointer type,
4963 convert the null to a NullPointer.
4964 * convert.cs (ImplicitReferenceConversion): If the expression is a
4965 NullLiteral and the target type is a pointer type, return a
4966 NullPointer instead.
4967 (ImplicitConversionStandard): Likewise.
4969 2005-05-13 Marek Safar <marek.safar@seznam.cz>
4971 * cs-parser.jay: Set readonly context based on special constructs.
4973 * expression.cs (LocalVariableReference.DoResolveBase): Improved
4974 readonly variable error handling.
4976 * rootcontext.cs (EmitCode): Don't verify members when error
4979 * statement.cs (LocalInfo): Add reaodnly context information.
4980 (SetReadOnlyContext, GetReadOnlyContext): New methods.
4982 2005-05-17 Martin Baulig <martin@ximian.com>
4984 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
4987 2005-05-13 Martin Baulig <martin@ximian.com>
4989 * statement.cs (Block.Resolve, ResolveUnreachable): Correctly
4990 handle unreachable blocks.
4992 2005-05-13 Martin Baulig <martin@ximian.com>
4995 (ConstructorInitializer.GetOverloadedConstructor): Don't crash.
4996 (MethodCore.CheckCore): Use TypeManager.IsEqual(); fix #74904 and
4999 2005-05-13 Martin Baulig <martin@ximian.com>
5001 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
5002 instance variable, not a local. Fix #74873.
5003 (Block.ResolveUnreachable): Set it to true here.
5005 2005-05-12 Martin Baulig <martin@ximian.com>
5007 * cs-parser.jay (property_declaration): Pass the `current_class',
5008 not the `current_container' to Property's .ctor. Fixes #74912.
5010 2005-05-11 Martin Baulig <martin@ximian.com>
5012 * typemanager.cs (Closure): Copy this from MCS and merge all the
5013 GMCS-specific changes into it.
5015 2005-05-12 Raja R Harinath <harinath@gmail.com>
5018 * typemanager.cs (unmanaged_enclosing_types): New.
5019 (IsUnmanagedType): Avoid infloops by using
5020 'unmanaged_enclosing_types' to talk with recursive invocations.
5022 2005-05-11 Duncan Mak <duncan@novell.com>
5024 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
5025 continuing to process for 'arg'.
5026 (handle_preprocessing_directive): Check the argument of the #endif
5027 directive and report error CS1025 if there are any trailing
5030 According to the C# spec, having even whitespace after the #endif
5031 directive is illegal; however, because we call arg.TrimEnd ()
5032 beforehand, we have the same behavior as csc, allowing whitespace
5033 after the directive.
5037 2005-05-11 Marek Safar <marek.safar@seznam.cz>
5041 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
5042 (Constructor.GetObsoleteAttribute): Implemented correctly.
5044 2005-05-10 Martin Baulig <martin@ximian.com>
5046 * generic.cs (Constraints.Resolve): Report CS0246 if we cannot
5047 resolve the type; fixes #74864.
5048 (DefaultValueExpression): Create the LocalTemporary in Emit(), not
5049 in DoResolve(); fixes #74862.
5051 2005-05-10 Martin Baulig <martin@ximian.com>
5053 * support.cs (ReflectionParameters.ParameterModifier): Use
5054 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
5055 and `ParameterAttributes.In'. Fixes #74884.
5057 2005-05-10 Martin Baulig <martin@ximian.com>
5059 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Don't use
5060 the cache if we're just looking for `MemberTypes.NestedType' in a
5063 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
5064 constraints if we're still resolving the type tree.
5065 (Expression.MemberLookup): If we're resolving the type tree, only
5066 look for `MemberTypes.NestedType' since we're only interested in
5069 * class.cs (TypeContainer.DefineType): Don't resolve the type
5070 parameters here; do this later in ResolveType() after the type
5071 tree has been resolved.
5072 (TypeContainer.ResolveType): New public method; this is called
5073 after the type tree is resolved and before the types are being
5074 populated. We resolve the generic constraints here.
5075 (TypeContainer.DoDefineMember): Check the constraints on our base
5076 class and interfaces.
5078 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Make this protected;
5079 set the `ResolvingTypeTree' flag on the EmitContext.
5081 * codegen.cs (EmitContext.ResolvingTypeTree): New public field.
5083 2005-05-10 Marek Safar <marek.safar@seznam.cz>
5085 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
5087 * expression.cs (Argument.GetParameterModifier): Turned to property.
5088 (Invocation.Error_InvalidArguments): Add more descriptive errors.
5090 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
5093 2005-05-09 Raja R Harinath <rharinath@novell.com>
5096 * decl.cs (MemberCache.AddMethods): Register override methods,
5097 rather than non-override methods.
5098 * typemanager.cs (RegisterOverride): New.
5099 (IsOverride): Update.
5101 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5103 * typemanager.cs (TypeManager): Moved InitGenerics to Reset method.
5105 2005-05-06 Martin Baulig <martin@ximian.com>
5108 (Attributable.IsClsComplianceRequired): Fix typo in the method name.
5109 (AttributeTester.AnalyzeTypeCompliance): Add generics support.
5111 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5115 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
5116 recursive declaration.
5118 * statement.cs (Block.ResolveMeta): Report any error in resolving.
5120 2005-05-06 Marek Safar <marek.safar@seznam.cz>
5122 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
5124 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
5126 2005-05-05 Raja R Harinath <rharinath@novell.com>
5129 * decl.cs (DeclSpace.FamilyAccessible):
5130 Use TypeManager.IsNestedFamilyAccessible.
5132 Fix reopened #64812.
5133 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
5136 2005-05-04 Raja R Harinath <rharinath@novell.com>
5137 Abin Thomas <projectmonokochi@rediffmail.com>
5138 Anoob V E <projectmonokochi@rediffmail.com>
5139 Harilal P R <projectmonokochi@rediffmail.com>
5142 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
5143 allow access to all static members.
5145 2005-05-04 Martin Baulig <martin@ximian.com>
5147 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
5149 2005-05-04 Martin Baulig <martin@ximian.com>
5153 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
5154 section at the end; make things work if `default' is not the last
5157 2005-05-04 Martin Baulig <martin@ximian.com>
5161 * statement.cs (Switch): Replaced the `got_default' field with a
5162 `default_section' one.
5163 (Switch.CheckSwitch): Set `default_section' here.
5164 (Switch.Resolve): If we're a constant switch and the constant is
5165 not found, use the default section.
5167 2005-05-03 Martin Baulig <martin@ximian.com>
5169 * expression.cs (ArrayAccess.EmitGetLength): New public method.
5171 * statement.cs (Foreach.ArrayForeach): New nested class.
5172 (Foreach.TemporaryVariable): New nested class.
5173 (Foreach.EmitArrayForeach): Removed; this is now in the new
5176 2005-05-03 Raja R Harinath <rharinath@novell.com>
5178 * pending.cs (BaseImplements): Move the #74773 fix here. This is
5180 (VerifyPendingMethods): Revert change below.
5182 * typemanager.cs (IsOverride, RegisterNonOverride): New.
5183 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
5184 that used to trigger warning -28. Remove warning -28.
5185 * expression.cs (Invocation.OverloadResolve): Use
5186 TypeManager.IsOverride to distinguish override methods.
5189 * pending.cs (VerifyPendingMethods): If a base type implements the
5190 requested interface, don't bother checking individual methods of
5191 the base type. As a side-effect, this prevents the creation of
5192 unnecessary proxies.
5194 2005-05-02 Martin Baulig <martin@ximian.com>
5198 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
5199 Also `And' the locals if the old vector is null.
5200 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
5201 null; in this case we basically reset all the variables.
5203 2005-05-02 Martin Baulig <martin@ximian.com>
5207 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
5208 Added `FlowBranching branching' argument; always `and' the
5209 variables instead of `or'ing them unless we're an infinite loop.
5211 * statement.cs (While.Resolve): Create a new sibling unless we're
5214 2005-05-02 Martin Baulig <martin@ximian.com>
5218 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
5219 arguments; use it instead of creating a new TopLevelBlock.
5220 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
5221 our ConstructorInitializer.
5224 (TopLevelBlock.TopLevelBranching): New public property.
5225 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
5226 and create our `TopLevelBranching'.
5228 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
5229 anonymous method host, use `block.TopLevelBranching' rather than
5230 creating a new branching.
5232 2005-04-20 Miguel de Icaza <miguel@novell.com>
5234 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
5235 a ScopeInfo, if any of the current children is a child of the new
5236 entry, move those children there.
5238 2005-04-30 Martin Baulig <martin@ximian.com>
5240 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
5241 at the beginning of a SwitchSection. Fix #73335.
5243 2005-04-27 Marek Safar <marek.safar@seznam.cz>
5246 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
5248 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
5249 (FieldExpr.DoResolve): Obsolete members are ignored for field
5252 2005-04-26 Marek Safar <marek.safar@seznam.cz>
5254 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
5255 of arrays detection.
5257 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
5259 (Field.VerifyClsCompliance): Volatile fields are not compliant.
5261 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
5264 2005-04-25 Ben Maurer <bmaurer@ximian.com>
5266 * cs-parser.jay: Use the prefered version of -unsafe in error
5269 2005-04-22 Marek Safar <marek.safar@seznam.cz>
5271 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
5274 2005-04-20 John Luke <john.luke@gmail.com>
5276 * driver.cs: fix typo in error message, --outout to --output
5278 2005-04-30 Martin Baulig <martin@ximian.com>
5280 * attribute.cs (Attribute.CheckSecurityActionValidity): Correctly
5281 handle the .NET 2.x security attributes.
5283 2005-04-30 Martin Baulig <martin@ximian.com>
5286 (TypeManager.ExpandInterfaces): Don't add things twice.
5289 (TypeContainer.VerifyClsCompliance): Allow generic instances.
5291 2005-04-29 Martin Baulig <martin@ximian.com>
5293 * generic.cs (Constraints.ResolveTypes): Expand interfaces.
5295 * anonymous.cs: Added support for anonymous generic methods.
5297 2005-04-29 Martin Baulig <martin@ximian.com>
5299 * typemanager.cs (TypeManager.GetInterfaces): Correctly handle
5302 2005-04-29 Martin Baulig <martin@ximian.com>
5304 * generic.cs (TypeManager.HasConstructorConstraint): Removed.
5306 * expression.cs (New.DoResolve): Fix the CS0304 check.
5308 2005-04-29 Martin Baulig <martin@ximian.com>
5310 * typemanager.cs (TypeManager.GetFullName): Updated to the new
5313 * class.cs (MethodCore.IsDuplicateImplementation): If we're an
5314 explicit interface implementation, compare the interface types.
5315 (MethodData.Define): Use the new naming scheme from the latest
5317 (MemberBase.DoDefineBase): Resolve `InterfaceType' here.
5319 * decl.cs (MemberName.GetMemberName): Removed.
5320 (MemberName.MethodName, FullName): New properties.
5322 2005-04-25 Raja R Harinath <rharinath@novell.com>
5324 * gmcs.exe.config: Update v2.0.40607 -> v2.0.50215.
5326 2005-04-22 Martin Baulig <martin@ximian.com>
5328 * generic.cs (GenericMethod): Create the EmitContext in the
5329 `Define()'; in `Define(MethodBuilder)', create the type parameters
5330 before calling `Define()'. Fixes #73933.
5332 2005-04-22 Martin Baulig <martin@ximian.com>
5335 (Constraints.Resolve): Make things work wrt. the new type lookup system.
5336 (ConstructedType.ResolveAsTypeTerminal): Don't override this.
5338 * ecore.cs (Expression.ResolveAsTypeTerminal): If `te' is a
5339 ConstructedType, check its constraints.
5341 2005-04-20 Marek Safar <marek.safar@seznam.cz>
5343 * codegen.cs (InRefOutArgumentResolving): New field.
5345 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
5346 fields outside contructor.
5348 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
5350 2005-04-19 Miguel de Icaza <miguel@novell.com>
5352 * anonymous.cs (CaptureContext.EmitParameterInstance): The
5353 parameter code was not completed ever, so it was not as up-to-date
5354 as local variables. Must finish it.
5356 The bug fix was to compare the Toplevel of the block, not the
5357 current block. Thanks for Ben for pointing this out.
5359 2005-04-19 Raja R Harinath <rharinath@novell.com>
5361 * decl.cs (AddMethods): Use the declaring type of the problem
5362 method to determine if we want to squash a warning.
5364 2005-04-19 Marek Safar <marek.safar@seznam.cz>
5366 * attribute.cs: Removed debug output.
5368 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
5370 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
5373 2005-04-18 Raja R Harinath <rharinath@novell.com>
5376 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
5377 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
5378 all null comparisons against reference types.
5380 2005-04-18 Marek Safar <marek.safar@seznam.cz>
5383 * class.cs (TypeContainer.CircularDepException) New nested
5385 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
5386 (TypeContainer.DefineType): Removed error, reset InTransit before
5388 (Class.DefineType): Throw exception when is in Transit.
5389 Catch exception and report error.
5390 (Struct.DefineType): Throw exception when is in Transit.
5391 Catch exception and report error.
5392 (Interface.DefineType): Throw exception when is in Transit.
5393 Catch exception and report error.
5395 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
5396 handle nested exception handlers.
5398 * flowanalysis.cs (InTryWithCatch): New method, search for try with
5401 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
5402 InFinally and InCatch storage.
5404 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
5405 (Catch.Resolve): Set and Restore ec.InCatch.
5406 (Try.Resolve): Set and Restore ec.InFinally.
5407 (Try.HasCatch): True when try has catch.
5409 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
5411 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
5412 for the same event member, so exclude such cases from warning 419.
5415 2005-04-16 Miguel de Icaza <miguel@novell.com>
5417 * expression.cs (Binary.ResolveOperator): Apply patch from John
5418 Luke to fix bug 59864: operators &, | and ^ on enumerations
5419 require that the same enum type on both sides.
5421 * driver.cs: Add warnings to old flag usage, this is to assist
5422 people who produce Makefiles and hope that the Makefiles will be
5425 * class.cs (TypeContainer.EmitType): Moved the definition of the
5426 special $PRIVATE$ field from the resolve phase to the Emit phase.
5427 During resolve we do not know if we are a struct with
5428 HasExplicitLayout, we know this only after the attributes for the
5431 Set the FieldOffset to zero on the dummy field that we create for
5432 the class. Fixes 74590.
5434 2005-04-16 Raja R Harinath <rharinath@novell.com>
5437 * ecore.cs (PropertyExpr.resolved): New.
5438 (DoResolve): Use it to handle a case of double resolution here.
5439 Handle a case of identical-name-and-type-name.
5440 * expression.cs (ArrayCreation.CheckIndices): Avoid double
5441 resolution by storing the results of expression resolution back
5442 into the "probes" array.
5444 2005-04-15 Raja R Harinath <rharinath@novell.com>
5446 Fix cs0208-7.cs and cs0208-8.cs.
5447 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
5448 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
5449 error reporting to point out the reason a struct is not unmanaged.
5451 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5453 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
5454 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
5456 2005-04-13 Raja R Harinath <rharinath@novell.com>
5459 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
5460 IdenticalNameAndTypeName here.
5461 (EventExpr.InstanceResolve): Likewise.
5463 2005-04-13 Marek Safar <marek.safar@seznam.cz>
5465 C# 2.0 DefaultCharSetAttribute implementation
5467 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
5468 which allows us to set GlobalNamespace for every resolve.
5469 (Attribute.ResolveArguments): Cut from Resolve.
5470 (Attribute.GetCharSetValue): Returns CharSet named argument.
5471 (Attribute.DefinePInvokeMethod): Gets default charset from
5473 (GlobalAttribute.ResolveAsTypeStep): Override.
5474 (GlobalAttribute.ResolveArguments): Override.
5476 * class.cs (TypeAttr): Is protected.
5478 * codegen.cs (ModuleClass.DefaultCharSet): New member.
5479 (ModuleClass.DefaultCharSetType): New memeber.
5480 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
5482 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
5483 charset from module.
5485 * delegate.cs (TypeAttr): Override.
5486 (Delegate.DefineType): Use this TypeAttr.
5488 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
5489 at very early stage (before types are defined) to resolve model
5490 module attributes. It will probably not work with corlib but it
5493 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
5494 charset from module.
5496 * typemanager.cs (default_charset_type): New type.
5498 2005-04-13 Raja R Harinath <rharinath@novell.com>
5500 * decl.cs (MemberCache.AddMethods): Don't warn if
5501 System.Object.Finalize has buggy MethodAttributes.
5503 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
5506 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5508 * doc.cs : detect ambiguous reference to overloaded members.
5509 Fixed bug #71603. MS 1.1 csc does not detect it.
5511 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5513 * doc.cs : delegates must not be referenced with parameters.
5516 2005-04-12 Miguel de Icaza <miguel@novell.com>
5518 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
5520 2005-04-10 Miguel de Icaza <miguel@novell.com>
5522 * driver.cs (MainDriver): Stop processing if the CLS stage found
5525 (CompilerCallableEntryPoint.InvokeCompiler): Always
5526 reset after execution; Take a TextWriter argument for the
5529 * report.cs: Use the error stream instead of hardcoding stderr.
5531 2005-04-09 Miguel de Icaza <miguel@novell.com>
5533 * class.cs: Reduce code paths to test, too small of an
5534 optimization to make it worth the extra testing. Always perform
5537 2005-04-08 Raja R Harinath <rharinath@novell.com>
5540 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
5541 operators that had errors reported on them.
5543 2005-04-08 Marek Safar <marek.safar@seznam.cz>
5545 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
5547 (Attribute.Resolve): Add named argument type checking.
5549 * class.cs (FixedField.Define): Use IsPrimitiveType
5551 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
5553 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
5554 unsafe parameter types.
5556 * statement.cs (Using.ResolveExpression): Add better error description.
5558 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
5560 2005-04-08 Raja R Harinath <rharinath@novell.com>
5563 * attribute.cs (Attribute.GetAttributeUsage): Resolve
5564 AttributeUsageAttribute in the emitcontext of the attribute class,
5565 not in the emitcontext of the attributable entity it was attached to.
5566 * cs-parser.jay: Use 'current_class', not 'current_container',
5567 when creating a GlobalAttribute.
5569 2005-04-08 Alp Toker <alp@atoker.com>
5571 * pending.cs: The fix to #58413 failed to compile methods implementing
5572 interfaces with/without params modifiers and vice versa, even though
5573 params modifiers aren't part of the signature. Make the modifier check
5574 less strict as in csc.
5576 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
5577 Anoob V E <projectmonokochi@rediffmail.com>
5578 Harilal P R <projectmonokochi@rediffmail.com>
5581 * pending.cs (TypeAndMethods.mods): New. Store the parameter
5582 modifiers of pending methods.
5583 (PendingImplementation.PendingImplementation): Initialize it.
5584 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
5585 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
5586 with ParameterData. Add check for modifiers.
5587 * class.cs (MethodData.Define): Update to changes.
5589 2005-04-07 Raja R Harinath <rharinath@novell.com>
5591 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
5593 2005-04-07 Marek Safar <marek.safar@seznam.cz>
5595 * class.cs (PropertyMethod.Define): Check private accessor in abstract
5598 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
5601 * typemanager.cs: Registered RequiredAttributeAttribute.
5603 2005-04-06 Marek Safar <marek.safar@seznam.cz>
5605 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
5606 Warning CS0169 is back at level 3.
5607 (IMethodData.SetMemberIsUsed): New method.
5609 * decl.cs (IsUsed): New value; moved from FieldBase.Status
5610 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
5612 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
5614 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
5616 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
5619 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
5622 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
5623 to avoid the problems with nested types.
5625 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
5626 Anoob V.E <projectmonokochi@rediffmail.com>
5627 Harilal P.R <projectmonokochi@rediffmail.com>
5628 Raja R Harinath <rharinath@novell.com>
5631 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
5633 * typemanager (GetConstructor): Make public.
5635 2005-04-05 John Luke <john.luke@gmail.com>
5636 Raja R Harinath <rharinath@novell.com>
5639 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
5640 struct too. Return false quicker in a few cases.
5641 (VerifyUnManaged): Use it.
5643 2005-04-05 Raja R Harinath <rharinath@novell.com>
5646 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
5647 not 'unreachable_seen'.
5649 2005-04-04 Marek Safar <marek.safar@seznam.cz>
5651 * attribute.cs (Attribute.GetValue): Removed unused.
5653 * codegen.cs (CodeGen.TrimExt): Removed unused.
5655 * cs-parser.jay (output): Removed unused.
5657 * cs-tokenizer.cs (hex_digits): Removed unused.
5659 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
5661 * expression.cs (Indirection.LoadExprValue): Removed unused.
5662 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
5664 * iterators.cs (Iterator.param_types): Removed unused.
5666 * statement.cs (Goto.block): Removed unused.
5667 (ToplevelBlock.did): Removed unused.
5668 (Switch.ResolveConstantSwitch): Removed unused.
5670 2005-04-01 Ben Maurer <bmaurer@ximian.com>
5672 * rootcontext.cs: Allow mcs to bootstrap with the compilation
5675 2005-04-19 Martin Baulig <martin@ximian.com>
5677 Merged r42462 from MCS and made it work for GMCS.
5679 * class.cs (MethodCore.ds): Moved this field to `MemberBase'.
5681 * generic.cs (GenericMethod.Define): Removed `return_type' argument.
5683 2005-04-01 Raja R Harinath <rharinath@novell.com>
5685 Fix #74232 and cs0208-3.cs.
5686 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
5687 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
5688 unmanaged type. Don't use FieldBuilders when 't' is a
5689 TypeBuilder. Use ModFlags and MemberType fields.
5690 * class.cs (MemberBase.member_type): Rename from MemberType.
5691 (MemberBase.MemberType): New property. Determines member_type on
5693 (MemberBase.DoDefine): Don't initialize MemberType here.
5694 (FieldMember.Define): Likewise.
5696 2005-04-01 Marek Safar <marek.safar@seznam.cz>
5699 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
5700 Attributes are emitted there.
5702 2005-04-01 Raja R Harinath <rharinath@novell.com>
5704 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
5705 keyword in 'partial enum' too.
5706 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
5708 Report from Kamil Skalski <nazgul@omega.pl>.
5711 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
5712 have partial containers too.
5714 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
5715 in block' checks to Block.CheckInvariantMeaningInBlock.
5716 * statement.cs (Block.GetKnownVariableInfo): Make private.
5717 (Block.IsVariableUsedInChildBlock): Remove.
5718 (Block.IsVariableUsedInBlock): Likewise.
5719 (Block.CheckInvariantMeaningInBlock): New. Show location of
5720 conflicting declaration.
5721 (Block.AddVariable): Make error messages less long-winded and more
5722 specific. Show location of conflicting declaration.
5723 * parameter.cs (Parameters.Location): New readonly property.
5725 2005-03-31 Raja R Harinath <rharinath@novell.com>
5727 Clean up semantics of invoking ResolveMemberAccess.
5728 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
5729 can have an instance, ensure that we pass in a non-TypeExpression
5730 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
5731 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
5732 argument. Update to changes and simplify.
5733 (FieldExpr.Emitinstance): Remove CS0120 check.
5734 (PropertyExpr.EmitInstance): Likewise.
5735 * expression.cs (Argument.Resolve): Likewise.
5736 (Invocation.DoResolve): Update to changes in semantics of
5739 2005-03-31 Marek Safar <marek.safar@seznam.cz>
5742 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
5745 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
5747 2005-03-31 Raja R Harinath <rharinath@novell.com>
5749 Fix difference in behaviour with commandline invocation.
5750 * driver.cs (Driver.Reset): New.
5751 (CompilerCallableEntryPoint): Call it.
5753 * statement.cs (If.Resolve): Avoid spurious "uninitialized
5754 variable" warnings if the boolean expression failed to resolve.
5756 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
5758 * attribute.cs: Fix the union of several permissions when some of them
5759 are unrestricted (so the result isn't an unrestricted permission set).
5762 2005-03-30 Raja R Harinath <rharinath@novell.com>
5764 * ecore.cs (MemberExpr): New class. Convert from interface
5766 (MemberExpr.ResolveMemberAccess): Refactor and move here from
5767 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
5769 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
5770 (MethodGroupExpr.IsExplicitImpl): Remove.
5771 (Expression.GetFieldFromEvent): Remove.
5772 (SimpleName.MemberStaticCheck): Remove.
5773 (SimpleName.DoSimpleNameResolve): Update to changes.
5774 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
5775 (MemberAccess.IdenticalNameAndTypeName): Remove.
5776 (MemberAccess.error176): Move to MemberExpr.
5777 (MemberAccess.DoResolve): Update to changes.
5778 (BaseAccess.DoResolve): Likewise.
5780 2005-03-30 Marek Safar <marek.safar@seznam.cz>
5782 C# 2.0 Conditional attribute class implementation
5784 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
5785 Analyzes class whether it has attribute which has ConditionalAttribute
5786 and its condition is not defined.
5788 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
5789 (Class.IsExcluded): New method. Search for at least one defined
5790 condition in ConditionalAttribute of attribute class.
5792 2005-03-30 Raja R Harinath <rharinath@novell.com>
5794 * ecore.cs (PropertyExpr): Derive from Expression, not
5795 ExpressionStatement.
5796 (PropertyExpr.EmitStatement): Remove.
5798 2005-03-29 Raja R Harinath <rharinath@novell.com>
5801 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
5802 internal field "value__" of an enum be private. The examples for
5803 "value__" that I found on MSDN all used FieldAttributes.Private.
5805 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
5806 Don't mention IL method attribute names.
5808 Fix #47991. Remove a TODO.
5809 * statement.cs (Block.Toplevel): Make into a field.
5810 (Block.Parameters): Move into ToplevelBlock.
5811 (Block.known_variables): Rename from child_variable_names.
5812 (Block.Block): Remove variants that take Parameters. Initialize
5813 'Toplevel' with the immediately surrounding toplevel block.
5814 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
5815 LocalInfo parameter.
5816 (Block.GetKnownVariableInfo): New.
5817 (Block.IsVariableNameUsedInChildBlock): Update.
5818 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
5819 the block, even though it may not be in scope.
5820 (Block.AddVariable): Remove Parameters parameter. Use
5821 Toplevel.Parameters instead.
5822 (Block.AddConstant): Remove Parameters parameter.
5823 (Block.GetParameterReference): Update to use Toplevel.Parameters.
5824 (Block.IsParamaterReference): Likewise.
5825 (Block.IsLocalParameter): Likewise. Simplify a lot.
5826 (ToplevelBlock.Parameters): New. Moved from Block.
5827 (ToplevelBlock.ToplevelBlock): Update to changes. Always
5828 initialize Parameters to a non-null value.
5829 * cs-parser.jay: Update to changes.
5830 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
5831 simple names that mean different things in the same block. Use
5832 Block.IsVariableNameUsedInBlock.
5834 2005-03-28 Raja R Harinath <rharinath@novell.com>
5836 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
5838 2005-03-26 Raja R Harinath <harinath@acm.org>
5841 * assign.cs (Assign.DoResolve): When the RHS of an assignment
5842 fails to resolve, ensure that the LHS is still resolved as an
5845 2005-03-25 Raja R Harinath <harinath@acm.org>
5847 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
5849 (Enum.current_ec): Remove.
5850 (Enum.LookupEnumValue): Remove EmitContext argument.
5851 Just uses the one created during DefineType.
5852 (Enum.FindMembers): Update.
5853 * expression.cs (MemberAccess.DoResolve): Update.
5855 2005-03-22 Marek Safar <marek.safar@seznam.cz>
5857 * assign.cs (Assign.DoResolve): Check for CS1717 when
5858 source and target are same (uses Equals).
5860 * expression.cs (LocalVariableReference, ParameterReference,
5861 This): Implemented Equals, GetHashCode.
5863 * statement.cs (Block.GetParameterReference): Removed useless
5866 2005-03-22 Raja R Harinath <rharinath@novell.com>
5869 * statement.cs (Block.AddVariable): Ensure that we skip implicit
5870 blocks before deciding whether the error is cs0136 or cs0128.
5872 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
5873 (using_alias_directive, using_namespace_directive): Pass
5874 MemberName, not an expression to Namespace.UsingAlias and
5876 (MakeName): Use the MemberName of the namespace.
5877 * namespace.cs (Namespace.MemberName): New.
5878 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
5879 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
5881 * decl.cs (MemberName.Name): Make readonly.
5882 (MemberName.FromDotted): New "constructor".
5883 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
5884 (MemberCore.Name): Compute from MemberName on demand.
5885 (MemberCore.SetMemberName): Provide a way to change the
5887 (MemberCore.AddToContainer): Don't take a fullname parameter.
5888 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
5889 fully qualified name of the container to the member name.
5890 (TypeContainer.AddToTypeContainer): Use a fully qualified name
5891 only if the type is a member of the root container.
5892 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
5893 MemberName.Left rather than searching for an embedded ".".
5894 (PartialContainer.CreatePart): Update to changes in RootContext.
5895 (MemberBase.ShortName): Turn into a property. Use
5896 MemberCore.SetMemberName.
5897 (MemberBase.ExplicitInterfaceName): Remove.
5898 (MemberBase.UpdateMemberName): Remove.
5899 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
5900 (PropertyBase.SetMemberName): New override.
5901 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
5902 (Tree.GetDecl): New.
5903 (Tree.AllDecls): Rename from Decls.
5904 * attribute.cs, enum.cs, report.cs: Update to changes.
5905 * driver.cs (MainDriver): Use MemberName.FromDotted on
5906 RootContext.MainClass.
5908 2005-03-21 Marek Safar <marek.safar@seznam.cz>
5910 * class.cs (FixedField.Define): Check for CS1664 and more sanity
5913 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
5915 2005-03-18 Marek Safar <marek.safar@seznam.cz>
5917 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
5918 property accessor modifiers.
5920 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
5921 fixed buffer attribute (CS1716).
5922 (PropertyMethod.HasCustomAccessModifier): When property accessor
5923 has custom modifier.
5925 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
5927 (PropertyExpr.DoResolveLValue): Add CS0272.
5929 2005-03-17 Miguel de Icaza <miguel@novell.com>
5931 * convert.cs: When converting to a pointer, use the proper Conv.U
5932 or Conv.I depending on the source data type.
5934 * cs-tokenizer.cs: Make the size for large decimal constants,
5937 2005-03-17 Martin Baulig <martin@ximian.com>
5939 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
5940 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
5942 2005-03-17 Martin Baulig <martin@ximian.com>
5944 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
5945 to bool so we can return an error condition.
5946 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
5949 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
5951 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
5954 2005-03-16 Raja R Harinath <rharinath@novell.com>
5956 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
5957 Refactor to avoid traversing the list of assemblies, and to avoid
5958 string concatenation.
5959 * typemanager.cs (guid_attr_type): Remove.
5960 (negative_hits, pointers, references): Remove hashes.
5962 (GetConstructedType): New. Uses type_hash to handle constructed
5963 types (arrays, references, pointers).
5964 (GetReferenceType, GetPointerType): Use it.
5965 (GetNestedType): New. Uses type_hash to handle nested types of
5967 (LookupType, LookupTypeDirect): Remove.
5968 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
5969 'types' hash and LookupTypeReflection directly.
5970 (params_string, params_object): Use GetConstructedType.
5971 * namespace.cs (Namespace.cached_types): New. Cache of reflected
5973 (Namespace.Lookup): Use cached_types.
5974 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
5975 provided by old TypeManager.LookupType.
5976 * rootcontext.cs (MakeFQN): Remove.
5977 * decl.cs (DeclSpace.MakeFQN): Likewise.
5978 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
5979 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
5980 TypeManager.GetConstructedType.
5981 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
5983 2005-04-16 Zoltan Varga <vargaz@freemail.hu>
5985 * cs-parser.jay: Fix build.
5987 2005-03-15 Marek Safar <marek.safar@seznam.cz>
5989 * class.cs (TypeContainer.CircularDepException) New nested
5990 (MethodCore.CheckBase): Report CS1715 for properties and indexers.
5992 * cs-parser.jay: Reports CS1527 for any namespace element.
5994 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
5997 * expression.cs (ParameterReference.IsAssigned): Changed error to
5999 (Error_WrongNumArguments): Moved CS0245 detection here.
6001 * statement.cs (Return.Resolve): Add CS1622 report.
6003 2005-03-11 Marek Safar <marek.safar@seznam.cz>
6005 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
6007 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
6009 * attribute.cs expression.cs: Get rid of some allocations.
6011 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
6013 * doc.cs : just eliminate the latest change.
6015 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6017 * doc.cs : commented out the latest change. It breaks xml-030.cs
6019 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6021 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
6022 fail. So invoke CreateType() in FindDocumentedType().
6024 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6026 * cs-tokenizer.cs : added IsKeyword().
6027 * doc.cs : Detect keyword incorrectly used as identifier.
6028 Allow identifiers prefixed by @.
6030 2005-03-10 Marek Safar <marek.safar@seznam.cz>
6032 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
6033 It caused exception in namespace resolving (again!).
6035 * class.cs (Class.ctor): Removed exit.
6036 (PropertyMethod.ctor): ditto.
6038 * codegen.cs (Codegen.Reset): Reset static data.
6039 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
6041 * cs-tokenizer.cs (Cleanup): Removed.
6043 * driver.cs (GetSystemDir): Rewrote to one line command.
6044 It caused problem with unloaded dynamic modules.
6045 (UnixParseOption): Removed Exit.
6046 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
6047 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
6048 Now can be mcs used as library.
6050 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
6053 * location.cs (Reset): Reset static data.
6055 * namespace.cs (Reset): Reset static data.
6057 * report.cs (Report.Reset): Reset static data.
6059 * rootcontext.cs (RootContext.Reset): Reset static data.
6061 * tree.cs (RootTypes.ctor): Use Location.Null
6063 * typemanager.cs (TypeManager.Reset): Reset static data.
6064 (CoreLookupType): Removed Exit.
6065 (TypeHandle.Reset): Reset static data.
6067 2005-03-10 Raja R Harinath <rharinath@novell.com>
6070 * typemanager.cs (ComputeNamespaces): Import namespaces from
6071 referenced modules too.
6073 2005-03-09 Raja R Harinath <rharinath@novell.com>
6075 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
6078 2005-03-09 Raja R Harinath <rharinath@novell.com>
6080 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
6081 enclosing DeclSpace. This ensures that a name-lookup populates
6082 more caches and there are fewer 'TypeExpression's. Carve out
6083 nested type lookup into ...
6084 (LookupNestedTypeInHierarchy): ... this.
6086 2005-04-15 Martin Baulig <martin@ximian.com>
6088 Merged r41590 from MCS and make it work in the generics land.
6090 * generic.cs (TypeParameter.UpdateConstraints): Removed the
6093 * class.cs (PartialContainer.UpdateConstraints): Removed.
6094 (PartialContainer.CheckConstraints): Removed.
6095 (PartialContainer.SetParameterInfo): Store the constraints here.
6096 (PartialContainer.DefineTypeParameters): New public method;
6097 resolve the type parameter's constraints here. Note that the
6098 PartialContainer doesn't have an EmitContext anymore, so we must
6099 do this in the ClassPart.
6101 2005-03-09 Raja R Harinath <rharinath@novell.com>
6103 Clean up a few partial-class semantics.
6104 Fixes test-357.cs and cs1618-2.cs.
6105 * cs-parser.jay (struct_declaration): Use 'current_class' as
6106 parent of newly-created struct. Remove call to Register ().
6107 Use 'pop_current_class' to complete handing the current struct.
6108 (interface_declaration): Likewise.
6109 (class_declaration): Likewise.
6110 (enum_declaration): Use 'current_class' as parent of newly created
6112 (delegate_declaration): Likewise.
6113 (pop_current_class): New function. This is used to handle closing
6114 up the 'current_class' and 'current_container', and pointing them
6115 to the enclosing class/container.
6116 (CSharpParser): Initialize 'current_class' too.
6117 * decl.cs (MemberCore): Add check for invariant: a partial
6118 container is not a parsed entity, and thus does not enclose any
6120 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
6121 (DeclSpace.BaseTypeExpr): Use it.
6122 (DeclSpace.LookupType): Add check for invariant.
6123 * class.cs (TypeContainer): Add check for invariant: a nested
6124 class should have the same NamespaceEntry as its enclosing class.
6125 (TypeContainer.EmitFieldInitializers): Make virtual.
6126 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
6128 (TypeContainer.Register): Remove.
6129 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
6130 null. Use TypeResolveEmitContext for resolving base types and
6131 interfaces. Move initialization of Parts.TypeBuilder here from
6133 (TypeContainer.DefineNestedTypes): ... here.
6134 (PartialContainer): Take a Namespace not a NamespaceEntry.
6135 (PartialContainer.Create): Don't use Register. Call the
6136 appropriate Add... function directly.
6137 (ClassPart): Take both the PartialContainer and the enclosing
6138 class as constructor arguments.
6139 (ClassPart.EmitFieldInitializers): Override.
6140 (ClassPart.PartFindNestedTypes): Remove.
6141 (FieldBase.GetInitializerExpression): Resolve the initializer
6142 expression in the emit context of the enclosing class.
6143 * tree.cs (RootTypes): Remove Register ().
6145 2005-03-08 Marek Safar <marek.safar@seznam.cz>
6147 * cs-parser.jay: Removed CS0134.
6149 * driver.cs: Removed CS1901.
6151 * expression.cs (SizeOf.DoResolve): Don't report CS0233
6152 for predefined types.
6154 2005-03-07 Duncan Mak <duncan@novell.com>
6156 * codegen.cs (Save): Catch UnauthorizedAccessException as
6157 well. Fixes bug #73454.
6159 2005-03-07 Marek Safar <marek.safar@seznam.cz>
6161 * cs-tokenizer.cs (xtoken): Add CS1035.
6163 * class.cs (MethodData.Define): Add CS0683.
6164 (FieldMember.ctor): Add CS0681.
6166 2005-03-07 Raja R Harinath <rharinath@novell.com>
6168 * ecore.cs (SimpleName.DoResolve): Rename from
6169 SimpleName.DoResolveAllowStatic.
6170 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
6171 Pass 'intermediate' flag to MemberStaticCheck.
6172 (SimpleName.MemberStaticCheck): Skip "static check" only in case
6173 of "intermediate" lookups via MemberAccess.
6174 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
6175 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
6177 2005-03-07 Raja R Harinath <rharinath@novell.com>
6180 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
6181 slipped in because of variable names that are identical to a
6182 builtin type's BCL equivalent ('string String;', 'int Int32;').
6183 (PropertyExpr.EmitInstance): Likewise.
6185 2005-03-04 Marek Safar <marek.safar@seznam.cz>
6187 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
6189 * report.cs (warning_ignore_table): Made public.
6191 2005-03-04 Raja R Harinath <rharinath@novell.com>
6194 * class.cs (MethodData.Emit): Pass 'container' to
6195 container.GetObsoleteAttribute instead of 'container.Parent'.
6197 2005-03-03 Marek Safar <marek.safar@seznam.cz>
6199 * cs-parser.jay: Add 1534 error test.
6201 * iterators.cs (Yield.CheckContext): Add error 1629.
6202 (Iterator.ctor): Save unsafe modifier.
6203 (MoveNextMethod.DoEmit): Restore unsafe context.
6205 * namespace.cs (UsingAlias): Better error message.
6207 2005-03-03 Dan Winship <danw@novell.com>
6209 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
6210 the warning message [#73219]
6212 2005-03-03 Raja R Harinath <rharinath@novell.com>
6214 Fix compile with MCS 1.0.0.0.
6215 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
6216 w_restore to not depend on string constant folding.
6218 2005-03-03 Raja R Harinath <rharinath@novell.com>
6220 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
6221 CS0246 check to users who passed 'silent = false'.
6222 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
6224 (SimpleName.SimpleNameResolve): Update.
6225 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
6226 (MemberAccess.IdenticalNameAndTypeName): Update.
6227 * doc.cs (FindDocumentedTypeNonArray): Update.
6229 2005-03-03 Raja R Harinath <rharinath@novell.com>
6231 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
6232 * parameters.cs (ComputeAndDefineParameters): Remove.
6233 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
6234 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
6235 Use GetParameterInfo.
6237 2005-03-02 Marek Safar <marek.safar@seznam.cz>
6239 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
6241 2005-03-02 Raja R Harinath <rharinath@novell.com>
6243 Unify DeclSpace.LookupType and DeclSpace.FindType.
6244 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
6245 is in charge of defining nested types on demand.
6246 (DeclSpace.LookupType): Use it when the current_type is a
6247 TypeBuilder. Use LookupTypeDirect for reflected types.
6248 (DeclSpace.FindType): Remove.
6249 (DeclSpace.LookupInterfaceOrClass): Likewise.
6250 (DeclSpace.DefineTypeAndParents): Likewise.
6251 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
6252 DeclSpace.LookupType.
6253 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
6254 * typemanager.cs (LookupType): Simplify.
6255 (AddUserType): Remove type from negative_hits.
6256 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
6257 * class.cs (TypeContainer.FindMembers): Move handling of nested
6259 (TypeContainer.FindMembers_NestedTypes): ... here.
6260 (TypeContainer.FindNestedType): Implement override.
6261 (ClassPart.FindNestedType): Delegate to PartialContainer.
6262 (ClassPart.PartFindNestedType): Looks up the nested types of the
6265 2005-04-14 Martin Baulig <martin@ximian.com>
6267 * generic.cs (ConstructedType): Moved all the type lookup and
6268 nested class logic into SimpleName.
6269 (ConstructedType.ResolveConstructedType): Our underlying type is
6270 already fully resolved; all the type lookup stuff is in
6273 * ecore.cs (SimpleName.ResolveAsTypeStep): Resolve nested
6274 constructed types here instead of in ConstructedType.
6276 * decl.cs (MemberName.GetTypeExpression): Always create a
6277 SimpleName, not a ConstructedType.
6278 (DeclSpace.ResolveNestedType): Removed; this is now in SimpleName.
6280 2005-03-02 Martin Baulig <martin@ximian.com>
6282 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6283 static constructor in static classes.
6285 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
6287 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
6288 sizeParamIndex is not specified.
6290 2005-03-01 Marek Safar <marek.safar@seznam.cz>
6293 * report.cs (WarningMessage.IsEnabled): Missing null check.
6295 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6297 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
6298 in the fields and not in the properties.
6300 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
6302 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
6305 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6307 * attribute.cs: Small refactoring (improved robustness).
6308 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
6309 (ValidateGuid): Removed.
6310 (Resolve): Removed referenced to above mentioned.
6311 (GetAttributeUsage): Made private and changed to work without
6313 (GetIndexerAttributeValue): Don't crash.
6314 (GetConditionalAttributeValue): Ditto.
6315 (GetClsCompliantAttributeValue): Ditto.
6316 (ExtractSecurityPermissionSet): All attributes exceptions are
6318 (GetPropertyValue): New helper.
6319 (GetMethodImplOptions): New method.
6320 (DefinePInvokeMethod): Reuse common code. Implemented handling of
6321 some missing properties.
6323 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
6324 (Method.ApplyAttributeBuilder): Updated.
6326 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
6329 2005-02-28 Raja R Harinath <rharinath@novell.com>
6332 * report.cs (Report.SymbolRelatedToPreviousError): Handle
6333 non-simple types (array, pointer, reference).
6335 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6337 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
6339 * class.cs (MethodCore.IsDuplicateImplementation): Special error
6341 (Method.CheckBase): Catch wrong destructor here.
6342 (MethodData.Define): Add errors 550, 668.
6344 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
6346 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
6348 * pending.cs (VerifyPendingMethods): Add error 551.
6350 * typemanager.cs (CSharpName): Next error report helper.
6352 2005-02-25 Marek Safar <marek.safar@seznam.cz>
6354 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
6355 attributes. Removed useless attribute double check.
6356 It saves almost 2MBs for corlib.
6358 2005-02-25 Raja R Harinath <rharinath@novell.com>
6361 * statement.cs (ExpressionStatement.Resolve): Make robust to being
6362 called twice in case of error.
6364 2005-02-23 Chris Toshok <toshok@ximian.com>
6366 Fix compiler portions of #72827.
6367 * statement.cs (Block.Emit): call Begin/EndScope on the
6368 EmitContext instead of the ILGenerator.
6370 * codegen.cs (EmitContext.BeginScope): new method, call
6371 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
6373 (EmitContext.BeginScope): same, but EndScope and CloseScope
6375 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
6376 offset and call the superclass's OpenScope(int) with it.
6377 (SymbolWriter.CloseScope): get the current il
6378 offset and call superclass's CloseScope(int) with it.
6380 2005-02-23 Marek Safar <marek.safar@seznam.cz>
6382 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
6383 CS1677 for out and ref as well.
6385 * class.cs (Method.Define): Add error CS1599 detection.
6387 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
6389 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
6391 * delegate.cs (Delegate.Define): Add error CS1599 detection.
6393 * support.cs.cs (ModifierDesc): New helper method.
6395 2005-02-23 Raja R Harinath <rharinath@novell.com>
6396 Abin Thomas <projectmonokochi@rediffmail.com>
6397 Anoob V E <projectmonokochi@rediffmail.com>
6398 Harilal P R <projectmonokochi@rediffmail.com>
6401 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
6402 MemberLookup (used for error reporting) actually returns a result.
6403 Fix error report number (122, not 112).
6405 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
6406 Anoob V E <projectmonokochi@rediffmail.com>
6407 Harilal P R <projectmonokochi@rediffmail.com>
6410 * pending.cs (PendingImplementation.GetAbstractMethods):
6411 Find NonPublic members too.
6413 2005-02-22 Marek Safar <marek.safar@seznam.cz>
6415 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
6418 * class.cs (MethodCore.CheckMethodAgainstBase):
6419 Add error 239 report.
6421 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6423 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6425 * class.cs (Operator.Define): Add error 217 report.
6427 2005-02-21 Raja R Harinath <rharinath@novell.com>
6430 * expression.cs (Invocation.IsApplicable): Make public.
6431 (Invocation.IsParamsMethodApplicable): Likewise.
6432 * delegate.cs (Delegate.VerifyApplicability): Don't use
6433 Invocation.VerifyArgumentCompat for parameter applicability
6434 testing. Use Invocation.IsApplicable and
6435 Invocation.IsParamsMethodApplicable.
6437 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6439 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6441 * class.cs (Operator.Define): Add error 217 report.
6443 2005-02-21 Raja R Harinath <rharinath@novell.com>
6445 * namespace.cs (UsingEntry.Resolve): Undo change below.
6447 2005-02-21 Raja R Harinath <rharinath@novell.com>
6450 * ecore.cs (Expression.MemberLookupFailed): Add argument to
6451 disable the error message when the extended MemberLookup also
6453 (Expression.MemberLookupFinal): Update.
6454 (SimpleName.DoSimpleNameResolve): Update.
6455 * expression.cs (MemberAccess.ResolveNamespaceOrType):
6456 Don't use MemberLookupFinal.
6457 (New.DoResolve): Update.
6458 (BaseAccess.CommonResolve): Update.
6460 2005-02-21 Raja R Harinath <rharinath@novell.com>
6463 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
6464 occured previously, don't resolve again.
6466 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6469 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
6470 argument. Call ResolveAttributeUsage for unresolved.
6471 when types doesn't match ctor arguments.
6473 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
6474 for nested attribute classes.
6475 (Class.attribute_usage): Removed.
6476 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
6477 for attribute class.
6479 * ecore.cs (IsAttribute): Removed.
6481 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
6483 * rootcontext.cs (RegisterAttribute): Removed, attributes are
6485 (attribute_types): Removed.
6486 (EmitCode): Global attributes are emited as the latest.
6488 2005-02-18 Marek Safar <marek.safar@seznam.cz>
6490 * class.cs (EmitFieldInitializers): Don't emit field initializer
6491 for default values when optimilization is on.
6493 * constant.cs (Constant.IsDefaultValue): New property.
6495 * driver.cs: Add /optimize handling.
6499 * literal.cs: Implement new IsDefaultValue property.
6501 * rootcontext.cs (Optimize): New field, holds /optimize option.
6503 2005-02-18 Raja R Harinath <rharinath@novell.com>
6505 Fix crasher in re-opened #72347.
6506 * namespace.cs (Namespace.Lookup): Return null if
6507 DeclSpace.DefineType returns null.
6510 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
6512 2005-02-18 Raja R Harinath <rharinath@novell.com>
6514 Fix remainder of #63202. Change semantics of DoResolveLValue: it
6515 now returns null if it cannot resolve to an lvalue.
6516 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
6517 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
6518 returned null. Remove check for SimpleName.
6519 (EventExpr.DoResolveLValue): New.
6520 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
6521 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
6523 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
6525 (Unary.ResolveOperator): Move CS0211 check ...
6526 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
6528 (Unary.DoResolveLValue): Simplify.
6529 (AddressOf.DoResolveLValue): New.
6530 (ArrayAccess.DoResolveLValue): New.
6532 2005-02-16 Marek Safar <marek.safar@seznam.cz>
6534 * attribute.cs (Attribute.Resolve): Add arguments casting for
6535 when types doesn't match ctor arguments.
6537 2005-02-16 Raja R Harinath <rharinath@novell.com>
6539 Fix parts of #63202.
6540 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
6541 lookup of operator in base type. Ensure that all checks happen
6542 when the operator resolves to an "op_..." method.
6544 2005-02-15 Raja R Harinath <rharinath@novell.com>
6547 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
6548 'ignore_cs0104' parameter. Pass it to ...
6549 (NamespaceEntry.Lookup): ... this.
6550 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
6551 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
6552 (TypeLookupExpression.DoResolveAsTypeStep): Update.
6553 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
6554 Update. Request that cs0104 errors be ignored.
6555 (ComposedCast.ResolveAsTypeStep): Update.
6557 2005-02-14 Raja R Harinath <rharinath@novell.com>
6560 * expression.cs (Invocation.BetterFunction): Remove support for
6561 comparing virtual functions and their overrides.
6562 (Invocation.IsOverride): New.
6563 (Invocation.OverloadResolve): Don't consider 'override' functions
6564 during candidate selection. Store them in a lookaside list.
6565 If the selected method is a 'virtual' function, use the list to
6566 find any overrides that are closer to the LHS type.
6568 2005-02-14 Marek Safar <marek.safar@seznam.cz>
6570 * expression.cs (New.DoResolve): Add complex core type reduction.
6571 (New.Constantify): Converts complex core type syntax like 'new int ()'
6574 2005-02-14 Raja R Harinath <rharinath@novell.com>
6576 * decl.cs (EntryType.EntryType): New constructor to create an
6577 updated copy of a cache entry.
6578 (MemberCache.AddMethods): Use it.
6579 (MemberCache.ClearDeclaredOnly): Remove.
6580 (MemberCache.MemberCache): Update.
6582 2005-02-11 Miguel de Icaza <miguel@novell.com>
6584 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
6585 variable. This one is represents the actual low-level declaration
6586 of the method, as opposed to the semantic level `IsStatic'.
6588 An anonymous method which is hosted into a static method might be
6589 actually an instance method. IsStatic would reflect the
6590 container, while MethodIsStatic represents the actual code
6593 * expression.cs (ParameterReference): Use the new MethodIsStatic
6594 instead of IsStatic.
6596 * anonymous.cs (AnonymousMethod.Compatible): Pass the
6597 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
6598 set on the current EmitContext.
6600 * expression.cs (Cast): Overload DoResolveLValue so we can pass
6601 resolve our casted expression as an LValue. This triggers the
6602 proper LValue processing that is later required by Assign.
6606 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
6608 2005-02-11 Marek Safar <marek.safar@seznam.cz>
6610 C# 2.0 Fixed buffer implementation
6612 * anonymous.cs: Update after RegisterHelperClass renaming.
6614 * attribute.cs (AttributeTester.fixed_buffer_cache):
6615 Cache of external fixed buffers.
6616 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
6617 implementation if field is fixed buffer else null.
6620 (TypeContainer.AddField): Accept FieldMember instead of Field.
6621 (FieldBase.IsFieldClsCompliant): Extracted code from
6622 VerifyClsCompliance descendant customization.
6623 (FixedField): New class handles fixed buffer fields.
6624 (FixedFieldExternal): Keeps information about imported fixed
6626 (IFixedField): Make access to internal or external fixed buffer
6629 * cs-parser.jay: Add fixed buffer parsing.
6631 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
6634 * expression.cs (Indirection): Extended implementation to accept
6636 (PointerArithmetic.Emit): Get element from fixed buffer as well.
6637 (ElementAccess.MakePointerAccess): Get type as parameter.
6638 (DoResolve): Add fixed buffer field expression conversion.
6639 (DoResolveLValue): Ditto.
6640 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
6641 (ArrayPtr): Derives from FixedBufferPtr.
6642 (ArrayPtr.Emit): Add extra emit for array elements.
6644 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
6646 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
6647 for compiler generated types.
6648 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
6650 * statement.cs (Fixed): Refactored to be easier add fixed buffer
6651 and consume less memory.
6652 (Fixed.Resolve): Add fixed buffer case.
6654 * typemanager.cs (compiler_generated_attr_ctor,
6655 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
6656 (HasElementType): Add our own implementation to work on every
6659 2005-02-11 Miguel de Icaza <miguel@novell.com>
6661 * anonymous.cs (CaptureContext): Track whether `this' has been
6664 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
6665 only captured `this' if it was implicitly done (instance
6666 methods/variables were used).
6668 * codegen.cs (EmitContext.CaptureThis): New method to flag that
6669 `this' must be captured.
6671 2005-01-30 Miguel de Icaza <miguel@novell.com>
6673 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
6674 is null it means that there has been no need to capture anything,
6675 so we just create a sibling.
6677 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
6679 Just a partial fix. The other half is fairly elusive.
6681 2005-02-10 Raja R Harinath <rharinath@novell.com>
6683 Fix #52586, cs0121-4.cs.
6684 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
6685 and return a hashtable.
6686 (MemberCache.ClearDeclaredOnly): New.
6687 (MemberCache.MemberCache): Update to change. Make a deep copy of
6688 the method_hash of a base type too.
6689 (MemberCache.AddMethods): Adapt to having a deep copy of the base
6690 type methods. Overwrite entries with the same MethodHandle so
6691 that the ReflectedType is correct. The process leaves in base
6692 virtual functions and their overrides as distinct entries.
6693 (CacheEntry): Now a class instead of a struct. It shouldn't alter
6694 matters since it was boxed in a ArrayList before.
6695 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
6697 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
6698 case of a virtual function and its override (choose the overload
6700 (Invocation.OverloadResolve): Avoid 'override' members during
6701 'applicable_type' calculation.
6703 2005-03-28 Raja R Harinath <rharinath@novell.com>
6705 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
6706 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
6707 GetTypeHandle. It is possible for a reflected type to derive from
6708 a TypeBuilder (e.g., int[] derives from the TypeBuilder
6709 System.Array during mscorlib compilation).
6710 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
6711 contain a method_hash, don't create one either. Don't create a
6712 deep copy of the base cache's method_hash.
6713 (MemberCache.SetupCache): Rename back from DeepCopy.
6714 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
6715 already initialized. If we see an override function, add its
6716 underlying base virtual function to the member_hash too.
6718 2005-02-09 Raja R Harinath <rharinath@novell.com>
6720 Combine two near-redundant caches.
6721 * typemanager.cs (method_params): Rename from method_internal_params.
6722 (TypeManager.GetParameterData): New. Replace
6723 Invocation.GetParameterData.
6724 (TypeManager.LookupParametersByBuilder): Remove.
6725 * expression.cs (Invocation.method_parameter_cache): Remove.
6726 (Invocation.GetParameterData): Remove.
6728 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
6731 2005-02-08 Raja R Harinath <rharinath@novell.com>
6734 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
6735 TypeManager.multicast_delegate_type is null, resolve it by looking
6736 up "System.MulticastDelegate".
6737 * rootcontext.cs (RootContext.ResolveCore): Simplify.
6739 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
6740 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
6741 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
6744 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
6745 (LabeledStatement.AddReference): New. Set 'referenced'.
6746 (Goto.Resolve): Use it.
6748 2005-02-05 John Luke <john.luke@gmail.com>
6750 * driver.cs: remove duplicate -doc line in Usage ()
6752 2005-02-04 Raja R Harinath <rharinath@novell.com>
6754 * location.cs (Location.AddFile): Fix CS2002 error report.
6756 2005-02-02 Martin Baulig <martin@ximian.com>
6758 * delegate.cs (Delegate.DefineType): Report an internal error if
6759 TypeManager.multicast_delegate_type is null. See bug #72015 for
6762 2005-02-02 Raja R Harinath <rharinath@novell.com>
6764 Fix a crasher in a variant of #31984.
6765 * const.cs (Constant.CheckBase): New override that defers the
6766 new-or-override check in case the base type hasn't been populated
6768 (Constant.Define): Ensure the new-or-override check is performed.
6770 2005-02-01 Duncan Mak <duncan@ximian.com>
6772 * const.cs (LookupConstantValue): Check that `ce' is not null
6773 before calling GetValue ().
6775 2005-02-01 Raja R Harinath <rharinath@novell.com>
6777 Fix test-334.cs (#69519).
6778 * cs-parser.jay (using_alias_directive): Pass in an expression to
6779 NamespaceEntry.UsingAlias.
6780 (using_namespace_directive): Pass in an expression to
6781 NamespaceEntry.Using.
6782 (namespace_name): Don't flatten to a string.
6783 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
6784 (NamespaceEntry.AliasEntry.Resolve): Lookup using
6786 (NamespaceEntry.UsingEntry): Likewise.
6787 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
6789 (NamespaceEntry.LookupForUsing): Remove.
6790 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
6792 (NamespaceEntry.Lookup): Remove support for dotted names.
6794 2005-02-01 Raja R Harinath <rharinath@novell.com>
6796 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
6798 (NamespaceEntry.ImplicitParent): Compute on demand.
6799 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
6800 parallels the current.
6801 (NamespaceEntry.LookupForUsing): Use it.
6802 (NamespaceEntry.Lookup): If the current namespace-entry is
6803 implicit, don't search aliases and using tables.
6805 2005-02-01 Raja R Harinath <rharinath@novell.com>
6808 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
6810 (TypeContainer.BaseCache): Compute on demand.
6811 (TypeContainer.FindMembers): Define constants and types if they're
6812 not already created.
6813 (FieldMember.Define): Move resetting of ec.InUnsafe before error
6815 * const.cs (Constant.Define): Make idempotent.
6817 2005-01-29 Miguel de Icaza <miguel@novell.com>
6819 * pending.cs: Produce better code (no nops produced by using Ldarg
6822 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
6823 i - 1' it should be arg + 1.
6827 2005-01-28 Raja R Harinath <rharinath@novell.com>
6829 * attribute.cs (Attribute.CheckAttributeType): Make private
6831 (Attribute.ResolveType): Make virtual.
6832 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
6833 handling of RootContext.Tree.Types.
6835 2005-01-27 Raja R Harinath <rharinath@novell.com>
6837 Update attribute-handling to use the SimpleName/MemberAccess
6839 * cs-parser.jay (attribute): Pass in an expression to the
6840 constructors of Attribute and GlobalAttribute.
6841 * attribute.cs (Attribute): Take an expression for the name.
6842 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
6843 passed in attribute name expression.
6844 (Attribute.CheckAttributeType): Use it.
6845 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
6846 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
6847 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
6848 argument to prevent error messages if the lookup fails.
6850 2005-01-27 Marek Safar <marek.safar@seznam.cz>
6852 * expression.cs (Indirection): Implemented IVariable interface
6853 to support indirection in AddressOf operator.
6854 (PointerArithmetic.Emit): Add optimalization for case where
6855 result can be precomputed.
6857 2005-01-26 Martin Baulig <martin@ximian.com>
6859 * class.cs (TypeContainer.AttributeTargets): Return the correct
6860 AttributeTargets depending on our `Kind' instead of throwing an
6861 exception; fixes #71632.
6863 2005-01-26 Marek Safar <marek.safar@seznam.cz>
6866 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
6869 2005-03-17 Martin Baulig <martin@ximian.com>
6871 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
6872 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
6874 2005-03-17 Martin Baulig <martin@ximian.com>
6876 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
6877 to bool so we can return an error condition.
6878 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
6881 2005-03-17 Martin Baulig <martin@ximian.com>
6883 * generic.cs (TypeMananager.IsIEnumerable): New public method.
6885 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
6886 converting from an array-type of T to `IEnumerable<T>'.
6888 2005-03-16 Martin Baulig <martin@ximian.com>
6890 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
6891 (Nullable.LiftedUnaryMutator): New public class.
6893 * expression.cs (UnaryMutator.DoResolve): Added support for
6896 2005-03-14 Martin Baulig <martin@ximian.com>
6898 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
6900 2005-03-14 Martin Baulig <martin@ximian.com>
6902 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
6903 the comparision operators `<', `>', `<=' and `>='.
6905 2005-03-13 Martin Baulig <martin@ximian.com>
6908 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
6909 avoid confusion with the `NullLiteral'.
6910 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
6912 2005-03-13 Martin Baulig <martin@ximian.com>
6914 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
6915 comparing arbitrary types with the null literal.
6917 2005-03-13 Martin Baulig <martin@ximian.com>
6919 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
6920 boolean operators '&&', '||', '&' and '|'.
6921 (Nullable.OperatorTrueOrFalse): New public class.
6923 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
6924 instead of a `StaticCallExpr'; added support for nullables.
6926 2005-03-10 Martin Baulig <martin@ximian.com>
6929 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
6930 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
6932 2005-03-07 Martin Baulig <martin@ximian.com>
6934 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
6935 it work if `expr' is not an IMemoryLocation.
6936 (Nullable.Lifted): Implement IMemoryLocation.
6937 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
6940 2005-03-05 Martin Baulig <martin@ximian.com>
6942 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
6943 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
6944 (Nullable): Added support for lifted unary and binary operators.
6946 * expression.cs (Unary.DoResolve): Added support for nullable types.
6947 (Binary.DoResolve): Likewise.
6948 (Conditional.DoResolve): Likewise.
6950 2005-03-02 Martin Baulig <martin@ximian.com>
6952 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
6954 * class.cs (ClassPart.SetParameterInfo): Override this.
6955 (PartialContainer.SetParameterInfo): Override this.
6956 (TypeContainer.CheckConstraints): New protected method.
6957 (PartialContainer.CheckConstraints): Override this and check
6958 whether the same contraints were specified in all parts of a
6959 partial generic type definition.
6960 (PartialContainer.UpdateConstraints): New public method.
6962 * generic.cs (TypeParameter.UpdateConstraints): New public method.
6964 2005-03-02 Martin Baulig <martin@ximian.com>
6966 Committing a patch from Carlos Alberto Cortez to fix #72887.
6968 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
6969 casts from `T []' to `int []'.
6971 2005-03-02 Martin Baulig <martin@ximian.com>
6973 * generic.cs (TypeManager.IsEqual): Make this symmetric.
6975 * expression.cs (Binary.ResolveOperator): When resolving a
6976 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
6977 `=='. Fixes #71866. See gen-127.cs.
6979 2005-03-02 Martin Baulig <martin@ximian.com>
6981 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6982 static constructor in static classes.
6984 2005-03-02 Martin Baulig <martin@ximian.com>
6987 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
6988 (Nullable.LiftedConversion): Added support for user-defined
6991 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
6993 * cs-parser.jay: Use ComposedCast everywhere instead of
6994 NullableType, so we don't need to check for NullableType
6996 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
6997 case where we'll be resolved into a `parenthesized_expression_0'
7001 (Convert.UserDefinedConversion): Added nullable conversions.
7003 2005-02-28 Martin Baulig <martin@ximian.com>
7005 * generic.cs (TypeManager.IsNullableType): New static method.
7006 (Nullable): New abstract class.
7007 (Nullable.NullLiteral): New public class.
7008 (Nullable.LiftedConversion): New public class.
7010 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
7011 `builtin_types opt_nullable'.
7014 (Convert.ImplicitConversionStandard): Added nullable conversions.
7015 (Convert.ExplicitConversionStandard): Likewise.
7016 (Convert.ExplicitConversion): Likewise.
7018 2005-02-26 Martin Baulig <martin@ximian.com>
7020 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
7021 begin with a "?", for instance "?[]". Don't do a type lookup if
7024 2005-02-25 Martin Baulig <martin@ximian.com>
7026 The first part of Nullable Types :-)
7028 * generic.cs (NullableType): New public class.
7029 (NullCoalescingOperator): New public class.
7030 (TypeArguments.Resolve): Add a CS0306 check.
7032 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
7033 (opt_nullable): New rule.
7034 (type): Added `opt_nullable' to `namespace_or_type_name',
7035 `builtin_types' and `pointer_type'.
7036 (array_type): Added `opt_nullable'.
7037 (opt_rank_specifier_or_nullable): New rule; this is the
7038 combination of `opt_rank_specifier' and `opt_nullable'.
7039 (opt_error): New rule; catch errors here.
7040 (nullable_type_or_conditional): New rule; we use this to check for
7041 nullable and still detect the conditional operator.
7042 (local_variable_type): Use `opt_rank_specifier_or_nullable'
7043 instead `opt_rank_specifier'.
7045 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
7048 2005-02-24 Martin Baulig <martin@ximian.com>
7050 * README, README.Changes: Removed; they're old and obsolete.
7052 2005-02-22 Martin Baulig <martin@ximian.com>
7054 * generic.cs (TypeParameter.Resolve): If resolving the constraints
7055 returned an error, set `constraints' to null to avoid a crash
7057 (TypeParameter.ResolveType): Likewise.
7059 2005-02-22 Martin Baulig <martin@ximian.com>
7062 (Constraints.ResolveTypes): Protect against being called twice.
7063 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
7064 (TypeParameter.ResolveType): New public method; calls
7065 constraints.ResolveTypes().
7066 (TypeParameter.DefineType): Moved constraints.ResolveType() out
7067 into the new ResolveType().
7068 (GenericMethod.Define): Call ResolveType() on all our
7071 2005-02-21 Martin Baulig <martin@ximian.com>
7074 (TypeManager.generic_nullable_type): New static public field.
7075 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
7078 (RootContext.ResolveCore): Resolve "System.Nullable`1".
7080 2005-02-15 Martin Baulig <martin@ximian.com>
7082 * generic.cs (ConstructedType.Constraints): Correctly check
7083 constraints if the argument type is a type parameter; fixes
7086 2005-02-02 Martin Baulig <martin@ximian.com>
7088 * delegate.cs (Delegate.DefineType): Report an internal error if
7089 TypeManager.multicast_delegate_type is null. See bug #72015 for
7092 2005-01-29 Miguel de Icaza <miguel@novell.com>
7094 * pending.cs: Produce better code (no nops produced by using Ldarg
7097 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7098 i - 1' it should be arg + 1.
7102 2005-01-26 Martin Baulig <martin@ximian.com>
7104 * cs-parser.jay (indexer_declarator): Don't report an error if we
7105 have type parameters since we can be an explicit interface
7106 implementation; fixes #71449.
7108 2005-01-26 Martin Baulig <martin@ximian.com>
7110 * class.cs (TypeContainer.AttributeTargets): Return the correct
7111 AttributeTargets depending on our `Kind' instead of throwing an
7112 exception; fixes #71632.
7114 2005-01-26 Martin Baulig <martin@ximian.com>
7116 * delegate.cs (Delegate.DefineType): Correctly define our type
7117 parameters. Fixes #71483.
7119 2005-01-25 Raja R Harinath <rharinath@novell.com>
7122 * expression.cs (MemberAccess.DoResolve): Don't complain with
7123 cs0572 when the LHS of a member access has identical name and type
7126 2005-01-25 Marek Safar <marek.safar@seznam.cz>
7129 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
7131 Create custom PermissionSet only for PermissionSetAttribute.
7133 2005-01-24 Marek Safar <marek.safar@seznam.cz>
7136 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
7137 delegates in static class.
7139 2005-01-24 Martin Baulig <martin@ximian.com>
7141 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7142 merging an implicit block, just use its reachability.
7144 * statement.cs (Block.Resolve): Make the unreachable code check
7145 work wrt. implicit blocks; see test-337 from #63842.
7147 2005-01-21 Alp Toker <alp@atoker.com>
7149 * cs-parser.jay: destructor_declaration's container is PartialContainer
7150 not Class when partial types are used, so use Kind prop instead of
7153 2005-01-22 Miguel de Icaza <miguel@ximian.com>
7155 * cs-parser.jay: Improve error reporting when an interface
7158 2005-01-20 Dick Porter <dick@ximian.com>
7160 * support.cs: SeekableStreamReader fix from Sandor Dobos
7161 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
7162 chars are read. Fixes bug 70369.
7164 2005-01-20 Raja R Harinath <rharinath@novell.com>
7166 * cs-parser.jay (catch_clause): Simplify current_block handling
7169 2005-01-17 Miguel de Icaza <miguel@ximian.com>
7171 * convert.cs (ImplicitStandardConversionExists): Synchronize the
7172 code with ImplicitStandardConversion to handle the implicit
7173 conversion of method groups into valid delegate invocations.
7175 The problem is that in parameter handling we were using this code
7176 path. Fixes bug #64698
7178 2005-01-19 Raja R Harinath <rharinath@novell.com>
7180 * cs-parser.jay: Fix several infelicities.
7181 - Avoid assigning to the parser value stack. Code like
7182 '$3 = null' is unclean. Synthesize a value for the code block
7184 - Avoid using oob_stack for storing location information. Use ...
7185 (_mark_): ... this. New (empty) rule. Saves the current location
7187 (foreach_statement): Avoid using oob_stack for current_block
7188 handling. Use technique used in for_statement and
7189 using_statement. Synthesize a value for the code block to store
7190 additional intermediate information.
7192 2005-01-13 Miguel de Icaza <miguel@ximian.com>
7194 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
7195 of a different type is only allowed to private fields of a
7196 containing type, not on fields of a base class.
7198 See test-174.cs and error cs0122-9.cs
7200 2005-01-13 Raja R Harinath <rharinath@novell.com>
7202 Fix test-335.cs (bug #58126).
7203 * cs-parser.jay (argument): Split out non-expression parts of the
7204 rule into 'non_simple_argument'.
7205 (invocation_expression): Support parenthesized invocations with
7206 multiple arguments, and with single non-simple arguments.
7208 2005-01-13 Raja R Harinath <rharinath@novell.com>
7210 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
7213 2005-01-12 Raja R Harinath <rharinath@novell.com>
7215 Fix cs0038-1.cs, cs1640-6.cs.
7216 * ecore.cs (Expression.Resolve): Remove special-case for
7217 SimpleName in error-handling.
7218 (Expression.almostMatchedMembers): Relax access permission to
7220 (Expression.MemberLookupFailed): Handle duplicates in
7221 almostMatchedMembers list.
7222 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
7223 * expression.cs (New.DoResolve): Report CS1540 for more cases.
7224 * typemanager.cs (GetFullNameSignature): Use the MethodBase
7225 overload if the passed in MemberInfo is a MethodBase.
7227 2005-01-25 Martin Baulig <martin@ximian.com>
7230 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
7232 2005-01-12 Marek Safar <marek.safar@seznam.cz>
7235 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
7236 for non-CAS & merge permission sets properly.
7238 2005-01-11 Raja R Harinath <rharinath@novell.com>
7240 Improve standard-compliance of simple name and member access
7241 resolution. Fixes bugs #52697, #57200, #67520, #69519.
7242 * ecore.cs (FullNamedExpression): New abstract base class
7243 for Namespaces and TypeExpressions.
7244 (ResolveFlags.SimpleName): Remove.
7245 (SimpleName): Remove support for dotted names.
7246 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
7247 DeclSpace.FindType and DeclSpace.LookupType.
7248 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
7249 (Expression.ExprClassName): Make member function.
7250 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
7251 a namespace. Remove creation of dotted "SimpleName"s.
7252 (MemberAccess.DoResolve): Likewise.
7253 * decl.cs (DeclSpace.Cache): Make private.
7254 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
7255 (DeclSpace.FindType): Update.
7256 (DeclSpace.LookupType): Move here from RootContext. Return a
7257 FullNamedExpression.
7258 * namespace.cs (Namespace): Derive from FullNamedExpression
7259 so that it can be part of expression resolution.
7260 (Namespace.Lookup): Return an FullNamedExpression.
7261 (NamespaceEntry.LookupAlias): Lookup aliases only in current
7263 * rootcontext.cs (NamespaceLookup): Remove.
7264 (LookupType): Move to DeclSpace.
7265 * attribute.cs (CheckAttributeType): Update.
7266 * doc.cs (FindDocumentedType): Remove allowAlias argument.
7267 (FindDocumentedTypeNonArray): Likewise.
7269 2005-01-11 Raja R Harinath <rharinath@novell.com>
7271 Fix cs0509.cs, cs1632.cs.
7272 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
7273 is the same as IsInterface.
7274 (TypeContainer.GetClassBases): Likewise.
7275 * statement.cs (LabeledStatement.ig): New field.
7276 (LabeledStatement.LabelTarget): Save ILGenerator which created the
7278 (LabeledStatement.DoEmit): Check that the label was created with
7279 the same ILGenerator.
7281 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7284 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
7285 accessors to its properties.
7287 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
7288 from accessors to property.
7290 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7293 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
7296 2005-01-08 Miguel de Icaza <miguel@ximian.com>
7298 * attribute.cs: Check for null and empty strings.
7300 I have lost another battle to Paolo.
7302 2005-01-07 Marek Safar <marek.safar@seznam.cz>
7305 * class.cs (PropertyMethod): Set Parent field in ctors.
7306 (SetMethod.InternalParameters): Add unsafe switch hack.
7307 Override MarkForDuplicationCheck where it is appropriate.
7309 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
7310 It says whether container allows members with the same name.
7312 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
7313 Removed is_method parameter.
7315 2005-01-06 Duncan Mak <duncan@ximian.com>
7317 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
7318 because the previous change led to incorrect reporting of CS1032
7319 ("Cannot define/undefine preprocessor symbols after first token in
7320 file"). Instead of using `tokens_seen' as the only flag that
7321 triggers CS1040, introduce `comments_seen'. This new flag is used
7322 to signify having seen comments on the current line, so it is
7323 unset after a newline.
7325 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7327 * doc.cs : When searching for a type, find nested type too.
7328 This fixes bug #71040.
7330 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7333 - Warn missing member comment on those classes which also does not
7334 have doc comments. Fixed bug #71041.
7335 - Don't warn missing doc comment on default constructor.
7338 2005-01-06 Duncan Mak <duncan@ximian.com>
7340 * cs-tokenizer.cs (xtoken): After handling traditional C-style
7341 comments, set `tokens_seen' to true. This allows us to detect
7342 misplaced preprocessor directives (i.e. not at the beginning of
7343 the a line, nor after whitespaces). In that case, report error
7344 CS1040. This fixes bug #56460.
7346 * cs-parser.jay (interface_member_declaration): Add checks for
7347 IsExplicitImpl, and report CS0541 error if an interface member is
7348 defined as an explicit interface declaration.
7350 2005-01-06 Marek Safar <marek.safar@seznam.cz>
7353 * class.cs (PropertyMethod): Set Parent field in ctors.
7354 (SetMethod.InternalParameters): Add unsafe switch hack.
7356 * decl.cs (MemberCore.Parent): Cannot be readonly.
7358 2005-01-06 Raja R Harinath <rharinath@novell.com>
7360 * decl.cs (DeclSpace.ResolveType): Remove.
7361 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
7362 Merge in code from ...
7363 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
7364 * class.cs, enum.cs: Update to changes.
7366 2005-01-06 Miguel de Icaza <miguel@ximian.com>
7368 * anonymous.cs: Ensure that we init the scope of our parent if it
7369 has not been initialized yet.
7371 2004-12-30 Duncan Mak <duncan@ximian.com>
7373 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
7374 if field.FieldBuilder is null. Fixes #70758.
7376 * convert.cs: Fixed some typos and updated some of the comments.
7377 (ImplicitStandardConversionExists):
7378 (TryImplicitIntConversion): If `target_type' is an interface and
7379 the type of `ic' implements this interface, return true or a new
7380 BoxedCast instead of null. This fixes #70468.
7382 2004-12-29 Duncan Mak <duncan@ximian.com>
7384 * expression.cs (Argument.Emit): Check that Expr is
7385 IMemoryLocation before casting to it, and report CS1510 otherwise.
7389 2004-12-21 Ben Maurer <bmaurer@ximian.com>
7391 * statement.cs (Block.ThisVariable): remove the recursion here, to
7392 make the --profile more sane.
7394 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
7396 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
7397 assembly, by JB Evain.
7399 2004-12-17 Raja R Harinath <rharinath@novell.com>
7401 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
7402 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
7403 "parent" refers to enclosing type/class. "base" refers to superclass.
7405 2004-12-17 Raja R Harinath <rharinath@novell.com>
7407 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7408 Ensure that we only have GlobalAttributes.
7409 * attribute.cs (Attribute.Emit): Make non-virtual.
7410 (GlobalAttribute.Emit): Remove.
7411 (Attribute.Resolve): Make virtual.
7412 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
7413 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
7414 the argument. Don't create one.
7415 (Attribute.GetObsoleteAttribute): Likewise.
7416 (Attribute.GetClsCompliantAttributeValue): Likewise.
7417 * class.cs, decl.cs: Update to changes.
7419 2004-12-17 Marek Safar <marek.safar@seznam.cz>
7421 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
7423 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
7425 * statement.cs (Foreach.Resolve): Add error 186 report.
7427 2004-12-16 Marek Safar <marek.safar@seznam.cz>
7429 * expression.cs (Conditional.DoResolve): Add warning 429.
7431 * statement.cs (If.Resolve): Add warning 665.
7433 2004-12-16 Raja R Harinath <rharinath@novell.com>
7435 New invariant: RootContext.Tree.Types.NamespaceEntry == null
7436 except when in the parser, and in GlobalAttribute.
7437 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
7438 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
7439 RootContext.Tree.Types.NamespaceEntry once work is done.
7440 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
7441 and resets RootContext.Tree.Types.NamespaceEntry.
7443 2004-12-15 Marek Safar <marek.safar@seznam.cz>
7445 * cs-parser.jay: Don't create a block for every variable.
7447 2004-12-14 Miguel de Icaza <miguel@ximian.com>
7449 * location.cs: Provide extra information.
7451 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
7452 variables from the captured environment, it is the ldarg_0.
7454 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7456 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
7459 * class.cs: Changed warning level for 169 to avoid developer
7460 displeasure from warning flooding. It will be changed back when they
7461 fix most of current BCL warnings.
7463 * RootContext.cs: Pushed default WarningLevel to 3.
7465 * statement.cs: Removed unused variable.
7467 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7469 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
7470 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
7471 Add error 502 report.
7472 (StaticClass.DefineType): Add error 441 report.
7473 (Class.AllowedModifiersProp): New virtual property as temporary
7474 extension to AllowedModifiers.
7475 (Class.DefineType): Add error 418 report. Moved ModFlags check here
7476 to share implementation with StaticClass and don't call virtual
7479 * driver.cs (MainDriver): Add error 1558 test.
7481 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
7482 report. Moved error 36 test here.
7484 * statement.cs (Throw.Resolve): Add error 724 report.
7486 * typemanager.cs: Add out_attribute_type core type.
7488 2004-12-13 Marek Safar <marek.safar@seznam.cz>
7490 * class.cs (TypeContainer.VerifyClsCompliance): Add error
7492 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
7494 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
7497 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
7499 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
7500 Add error 3023 report.
7501 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
7503 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
7506 2004-12-12 John Luke <john.luke@gmail.com>
7508 * driver.cs (AddArgs): take -- into account when
7509 adding arguments, fixes bug 65710
7511 2004-12-12 Martin Baulig <martin@ximian.com>
7513 * expression.cs (Unary.TryReduceNegative): Added support for
7514 SByteConstant and ByteConstant.
7515 (Unary.Reduce): Check error values from TryReduceNegative().
7517 2004-12-10 Marek Safar <marek.safar@seznam.cz>
7519 * attributes.cs (Attribute.Resolve): Avoid multiple error report
7520 and report exception as error 182.
7522 2004-12-10 Raja R Harinath <rharinath@novell.com>
7524 * driver.cs (Main): Fix message when there are warnings.
7526 2004-12-09 Miguel de Icaza <miguel@ximian.com>
7528 * delegate.cs: Fixed my fix from yesterday, sorry about that.
7530 2004-12-09 Marek Safar <marek.safar@seznam.cz>
7532 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
7533 Reduced number of warnings.
7535 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
7537 2004-12-08 Miguel de Icaza <miguel@ximian.com>
7539 * driver.cs: Removed message.
7541 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
7543 2004-12-08 <vargaz@freemail.hu>
7545 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
7547 2004-12-08 Martin Baulig <martin@ximian.com>
7549 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7550 instead of a CS3002 for properties and indexer.
7552 2004-12-08 Martin Baulig <martin@ximian.com>
7554 * decl.cs (MemberName.ToString): Make this work again.
7556 2004-12-08 Marek Safar <marek.safar@seznam.cz>
7558 * attribute.cs (Resolve): Add error 591 detection.
7560 * class.cs (FieldMember.Define): Add error 1547 detection.
7561 (Indexer.Define): Add error 620 detection.
7562 (Operator.Define): Add error 590 detection.
7564 * ecore.cs: Missing argument for error 79.
7566 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
7569 2004-12-07 Marek Safar <marek.safar@seznam.cz>
7572 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
7575 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7577 * cs-parser.jay : handle doc comments on implicit/explicit operators.
7578 Some operator comments were suppressed.
7579 * doc.cs : Implicit/explicit operator name in doc comments are like
7580 "op_Explicit(type)~returnType", so added suffix handling.
7582 2005-01-21 Alp Toker <alp@atoker.com>
7584 * cs-parser.jay: destructor_declaration's container is PartialContainer
7585 not Class when partial types are used, so use Kind prop instead of 'is'.
7587 2004-12-12 Martin Baulig <martin@ximian.com>
7589 * expression.cs (Unary.TryReduceNegative): Added support for
7590 SByteConstant and ByteConstant.
7591 (Unary.Reduce): Check error values from TryReduceNegative().
7593 2004-12-11 Martin Baulig <martin@ximian.com>
7595 * support.cs (ReflectionParameters.ParameterName): If we have a
7596 `gpd', call `ParameterName' on it.
7598 * parameter.cs (Parameter.GetParameterAttributes): New static method.
7600 * pending.cs (PendingImplementation.DefineProxy): Call
7601 DefineParameter() for all of the MethodBuilder's arguments.
7603 2004-12-09 Martin Baulig <martin@ximian.com>
7605 * doc.cs (DocUtil): Make this a static class.
7607 2004-12-09 Martin Baulig <martin@ximian.com>
7609 * expression.cs (Invocation.InferType): Moved the type inference
7610 implementation into TypeManager.
7612 * generics.cs (TypeManager): Moved the type inference
7613 implementation here.
7615 2004-12-09 Martin Baulig <martin@ximian.com>
7617 * typemanager.cs (TypeManager): Make this a partial class.
7620 (TypeManager): Move the generics part of `TypeManager' here.
7622 2004-12-08 Martin Baulig <martin@ximian.com>
7624 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7625 instead of a CS3002 for properties and indexer. Added CS3024
7626 check for generic interfaces.
7628 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
7629 instances are not CLS-compliant.
7631 2004-12-08 Martin Baulig <martin@ximian.com>
7634 (void_pointer_expression): New rule for `void*', `void**' etc.
7635 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
7637 2004-12-08 Martin Baulig <martin@ximian.com>
7639 * expression.cs (Invocation.InferType): Removed the hack for
7640 MethodCore.MayUnify().
7642 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
7645 * class.cs (MethodCore.MayUnify): Use
7646 TypeManager.MayBecomeEqualGenericTypes().
7648 2004-12-08 Martin Baulig <martin@ximian.com>
7650 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
7651 parameter, box it. Fixes #69233.
7653 2004-12-08 Martin Baulig <martin@ximian.com>
7655 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
7656 have the ctor constraint. Fixes #68326.
7658 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7660 * cs-parser.jay : interface comment was not consumed because of
7661 extra opt_semicolon before doc handling.
7663 2004-12-03 Raja R Harinath <rharinath@novell.com>
7665 Fix test-327.cs, test-328.cs, and put in early infrastructure
7666 for eventually fixing #52697.
7667 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
7668 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
7670 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
7671 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
7672 (VerifyUsing, error246): Update.
7673 * rootcontext.cs (RootContext.NamespaceLookup): Just use
7674 'NamespaceEntry.LookupNamespaceOrType'.
7676 2004-12-07 Martin Baulig <martin@ximian.com>
7678 * driver.cs: Call it "BETA SOFTWARE" :-)
7680 2004-12-06 Raja R Harinath <rharinath@novell.com>
7682 Fix crash on cs0657-17.cs.
7683 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7684 Use RootContext.Tree.Types, not 'new RootTypes ()'.
7685 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
7686 the case where the NamespaceEntry gets overwritten.
7688 2004-12-06 Marek Safar <marek.safar@seznam.cz>
7690 Fixed #69195, #56821
7691 * ecore.cs (ResolveBoolean): Tiny refactoring.
7693 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
7694 of right expression resolving when left is false constant and
7695 operator is LogicalAnd OR true constant and operator is LogicalOr.
7697 * statement.cs (ResolveUnreachable): Always reports warning.
7699 2004-12-05 Miguel de Icaza <miguel@ximian.com>
7701 * class.cs: Distinguish between 1721 and 1722 (just a little help
7702 for the programmer).
7704 2004-12-03 Miguel de Icaza <miguel@ximian.com>
7706 * delegate.cs: Only allow this on new versions of the language.
7708 2004-12-02 Duncan Mak <duncan@ximian.com>
7710 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
7712 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
7713 here as a static method. Take an additional bool out parameter
7714 `must_do_cs1540_check' for signaling to InstanceResolve.
7715 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
7716 member field from PropertyExpr class and made it an argument of
7718 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
7719 check for MarshalByRefObject, and report CS0122 instead of CS1540.
7720 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
7721 and `remove_accessor' as well as InstanceResolve: report CS0122
7726 2004-12-07 Martin Baulig <martin@ximian.com>
7728 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
7729 and CS0692 where appropriate.
7731 2004-12-06 Martin Baulig <martin@ximian.com>
7733 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
7734 IsDuplicateImplementation() and improved it.
7736 * expression.cs (Invocation.InferTypeArguments): Added
7737 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
7738 and removed the "ref" modifier from `infered_types'.
7740 * decl.cs (MemberName.ToString): Removed the exception.
7742 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
7744 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
7745 comments are allowed.
7747 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7749 * delegate.cs: Add checks for subtypes in paramaters and return values
7750 in VerifyMethod () to add support for Covariance/Contravariance
7753 2004-12-02 Miguel de Icaza <miguel@ximian.com>
7755 * report.cs: Remove extra closing parenthesis.
7757 * convert.cs (Error_CannotImplicitConversion): If the name of the
7758 types are the same, provide some extra information.
7760 2004-12-02 Marek Safar <marek.safar@seznam.cz>
7763 * attribute.cs (Resolve): Improved implementation of params
7764 attribute arguments.
7766 * support.cs (ParameterData): Add HasParams to be faster.
7768 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
7770 all things are for /doc support:
7772 * doc.cs: new file that supports XML documentation generation.
7773 * mcs.exe.sources: added doc.cs.
7775 Handle /doc command line option.
7776 Report error 2006 instead of 5 for missing file name for /doc.
7777 Generate XML documentation when required, after type resolution.
7779 Added support for picking up documentation (/// and /** ... */),
7780 including a new XmlCommentState enumeration.
7782 Added lines to fill Documentation element for field, constant,
7783 property, indexer, method, constructor, destructor, operator, event
7784 and class, struct, interface, delegate, enum.
7785 Added lines to warn incorrect comment.
7787 Added Documentation field (passed only when /doc was specified).
7789 Added DocComment, DocCommentHeader, GenerateDocComment() and
7790 OnGenerateDocComment() and some supporting private members for
7791 /doc feature to MemberCore.
7793 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
7795 Added overriden DocCommentHeader.
7797 Added overriden DocCommentHeader and GenerateDocComment().
7799 2004-12-01 Miguel de Icaza <miguel@ximian.com>
7801 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
7802 unwrapping the enumeration values, chain to
7803 DoConstantNumericPromotions again, so we can promote things to the
7804 fundamental types (takes care of enums that are bytes, sbytes).
7808 2004-12-01 Raja R Harinath <rharinath@novell.com>
7810 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
7811 Fix long-standing bug in type-lookup. Use FindType instead of
7812 LookupType when ec.ResolvingTypeTree.
7813 (Attribute.ResolveType, Attribute.Resolve)
7814 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
7816 (Attributes.Search): Remove internal version. Update.
7817 (Attributes.SearchMulti): Update.
7818 (Attributes.GetClsCompliantAttribute): Remove.
7819 (Attributes.GetIndexerNameAttribute): Remove.
7820 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
7821 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
7822 * class.cs (Indexer.Define): Likewise.
7824 2004-12-01 Marek Safar <marek.safar@seznam.cz>
7827 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
7828 MarshallByReference members access.
7830 * expression.cs: Use CheckMarshallByRefAccess;
7831 Better error CS0197 message.
7833 * report.cs: Print whole related error message.
7835 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7837 * class (GetClassBases): Better error 60 report.
7838 (EventProperty): Disabled warning 67 detection.
7840 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7843 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
7845 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
7848 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7851 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
7853 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
7855 2004-11-26 Miguel de Icaza <miguel@ximian.com>
7857 * attribute.cs (Attribute.Resolve): Refine error reporting and
7858 report a cs0117 if the identifier does not exist, to distinguish
7859 from 0617 which is a miss-use of the actual identifier.
7861 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
7862 between cs0070 and cs0079.
7864 * class.cs (MemberBase.DoDefine): When reporting a wrong
7865 accessibility level, we use MethodCore to compare instead of
7866 Method (this was a regression in some refactoring effort).
7868 So now we correctly report cs0056 again.
7870 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
7871 testing the target_type (which was known to be object_type) and
7872 not the source type (which is anonymous_method).
7874 Fixed reporting of error cs1660.
7876 * expression.cs (UserCast.Source): Expose the underlying cast.
7878 * statement.cs (Switch.SwitchGoverningType): Sort the list of
7879 allowed types to find a match to int32 first (most common).
7881 In addition, it ignores any ImplicitUserConversions that did an
7882 internal implicit conversion (as the switch statement allows only
7883 one integral conversion to exist).
7885 * class.cs (PartialContainer.Create): rename `name' to
7886 `member_name' for clarity. Then replace the string calls with a
7887 call to MemberName.GetPartialName, as now using
7888 MemberName.ToString is an error (this is due to the side effects
7889 it had, that were fixed in the past).
7891 This will restore the error reporting on a number of partial class
7892 errors that were missusing this (and getting an exception as a
7893 results, which is now just a plain textual warning, because
7894 yyparse debug output would crash otherwise).
7896 2004-11-26 Raja R Harinath <rharinath@novell.com>
7898 * Makefile (PROGRAM_INSTALL_DIR): Remove.
7900 2004-11-25 Ben Maurer <bmaurer@ximian.com>
7902 * rootcontext.cs (LookupType): Make sure to cache lookups that
7903 don't give us a negative result. This saves about 5% of corlib
7906 2004-11-25 Miguel de Icaza <miguel@ximian.com>
7908 * report.cs (AbstractMessage.Print): messages are sent to stderr
7910 * class.cs (TypeContainer.GetClassBases): It is an error to have a
7911 non-interface in the list of interfaces (at this point, either
7912 parent was properly set, or a base class is being listed in the
7913 interfaces section).
7915 This flags error 1722, and resolves the crash from bug 69259.
7917 2004-11-25 Ben Maurer <bmaurer@ximian.com>
7919 * statement.cs (Using.EmitExpressionFinally): make this work right
7920 for valuetypes. Fixes 69926.
7922 2004-11-25 Miguel de Icaza <miguel@ximian.com>
7924 * const.cs (Const.ChangeType): Cope with the "0 literal can be
7925 converted to an enum" here, before we try to change the underlying
7926 type. This code exists, but it is a different code path than the
7927 one used while encoding constants.
7929 (ImplicitReferenceConversionExists): In addition, resynchronized
7930 the code here, so it matches the same code in
7931 ImplicitReferenceConversionExists for the `from any class-type S
7932 to any interface-type T'.
7934 2004-11-25 Marek Safar <marek.safar@seznam.cz>
7936 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
7938 2004-11-24 Miguel de Icaza <miguel@ximian.com>
7940 * cs-parser.jay: Use verbosity accordingly.
7942 2004-11-24 Marek Safar <marek.safar@seznam.cz>
7944 * expression.cs (Unary.ResolveOperator): Do not report warning;
7945 AddressOf reads from variable.
7947 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
7949 2004-11-24 Marek Safar <marek.safar@seznam.cz>
7953 * attribute.cs (Attributable): Removed CheckTargets.
7954 (Attributes.Emit): Explicit attribute targets are tested here.
7956 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
7957 not enabled for interfaces.
7959 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
7960 (GetAssemblyName): Ouch next bug there.
7962 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7964 * expression.cs: Error 275 added.
7966 2004-11-23 Marek Safar <marek.safar@seznam.cz>
7968 Fix bug #69177 (Implemented decimal constant support)
7970 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
7971 (BinaryFold): Add DecimalConstant.
7973 * const.cs (Define): Decimal constant
7975 (ChangeType): Add decimal type handling.
7976 (LookupConstantValue): Don't set value for decimal type but
7977 emit DecimalConstantAttribute. Needed for constant optimization.
7979 * constant.cs (ToDecimal): New method.
7980 (ConvertToDecimal): New method.
7981 (IntConstant): Implemented ConvertToDecimal.
7982 (DecimalConstant.Emit): Emit optimized version for decimals in
7985 * expression.cs (ResolveOperator): Changed order of constant
7986 reduction to work correctly with native types which have
7987 overloaded operators.
7988 (ResolveMemberAccess): Extract constant value from attribute
7991 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
7993 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
7994 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
7995 (ChangeType): Decimal is special.
7996 (TypeToCoreType): Add decimal type.
7998 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8000 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
8003 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8005 * class.cs (EventField.ApplyAttributeBuilder): Fix error
8008 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8010 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
8012 * pending.cs (PendingImplementation): Grab only interfaces.
8014 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8016 * statement.cs (ForeachHelperMethods): Add location member and
8017 error 202 detection.
8019 2004-11-18 Marek Safar <marek.safar@seznam.cz>
8021 * expression.cs (DoResolveBase): Fixed wrong warning for out
8024 2004-12-04 Martin Baulig <martin@ximian.com>
8026 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
8027 to check whether the conversion is ok.
8029 * typemanager.cs (TypeManager.GetTypeArguments): Just return
8030 `Type.EmptyTypes' if we're not a generic TypeContainer.
8032 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8034 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
8035 old bug: when converting from the null literal to a pointer,
8036 return an EmptyCast, not the NullLiteral.
8038 This fixes #69921, the recent null_type changes probably made this
8041 2004-12-03 Martin Baulig <martin@ximian.com>
8043 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8044 method as our child, call AnonymousMethod.Compatible() on it.
8046 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8048 * class.cs (FieldBase): Use an unused bit field from the field to
8049 encode the `has_offset' property from the FieldMember. This saves
8050 a couple of Ks on bootstrap compilation.
8052 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8053 method as our child, return the AnonymousMethod resolved
8056 * expression.cs (New.DoResolve): Allow return values from
8057 NewDelegate to also include AnonymousMethods.
8061 2004-11-29 Raja R Harinath <rharinath@novell.com>
8063 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
8065 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
8066 System.Runtime.InteropServices._Exception, since it's a base
8067 interface of the core type System.Exception in the net_2_0 profile.
8069 2004-11-27 Martin Baulig <martin@ximian.com>
8071 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
8073 2004-11-26 Raja R Harinath <rharinath@novell.com>
8075 * Makefile: Convert to use executable.make.
8076 * gmcs.exe.sources: New.
8078 2004-11-25 Martin Baulig <martin@ximian.com>
8080 * expression.cs (Invocation.InferType): Added support for byref types.
8082 2004-11-25 Martin Baulig <martin@ximian.com>
8084 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
8085 in TypeManager.TypeToCoreType().
8087 2004-11-25 Martin Baulig <martin@ximian.com>
8089 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
8090 "Dispose" method from the `current_type'.
8091 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
8092 DoDefineMembers() instead of using the MethodBuilder; this is
8093 required for generic iterators.
8095 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
8097 2004-11-24 Martin Baulig <martin@ximian.com>
8099 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
8101 2004-11-20 Martin Baulig <martin@ximian.com>
8103 * expression.cs (Invocation.InferType): Correctly infer generic
8104 instances; see gen-103.cs.
8105 (Invocation.InferTypeArguments): If a generic method doesn't have
8106 any unbound type parameters, we don't need to infer anything.
8108 2004-11-19 Raja R Harinath <rharinath@novell.com>
8110 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
8112 2004-11-17 Raja R Harinath <rharinath@novell.com>
8114 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
8115 (TypeHandle.GetMemberCache): New.
8116 (TypeHandle.TypeHandle): Update.
8117 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
8118 (TypeManager.LookupParentInterfacesCache):
8119 Rename from LookupInterfaceCache. Optimize slightly.
8120 (TypeManager.MemberLookup_FindMembers): Update.
8121 * decl.cs (MemberCache.MemberCache): Set Container to null in the
8123 (AddCacheContents): Rename from AddHashtable.
8124 * class.cs (TypeContainer.parent_container): Remove.
8125 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
8126 (TypeContainer.DoDefineMembers): Don't initialize it.
8127 Update to name changes.
8129 2004-11-17 Miguel de Icaza <miguel@ximian.com>
8131 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
8132 that factors the code to check access modifiers on override.
8134 (PropertyBase): Use the code here.
8136 Patch from Lluis S'anchez, fixes bug #69361.
8138 2004-11-15 Miguel de Icaza <miguel@ximian.com>
8140 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
8141 routine that is used to report the use of a captured variable
8142 whose address has been taken.
8144 There are two checks: one when variables are being captured and
8145 the other check is when the address of a variable is taken.
8147 (because an anonymous methods might be resolved before *or* after
8148 the address has been taken) and
8150 * expression.cs (Conditional.DoResolve): Remove the special
8151 casing that Martin added to trueExpr and falseExpr being both
8152 NullLiteral. We get the right behavior now just by introducing
8153 the null_type into the compiler.
8155 * convert.cs (ExplicitConversion): Change the code to use
8156 null_type instead of testing `expr is NullLiteral'.
8157 (ImplicitConversionStandard): use null_type too.
8158 (ImplicitReferenceConversionExists): use null_type too.
8159 (ImplicitReferenceConversion): use null_type too.
8161 * literal.cs: The type of `NullLiteral' is now null_type instead
8163 (Resolve): Set the type here.
8165 * typemanager.cs: Introduce null_type.
8167 2004-11-18 Martin Baulig <martin@ximian.com>
8170 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
8172 2004-11-18 Martin Baulig <martin@ximian.com>
8174 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
8176 2004-11-18 Martin Baulig <martin@ximian.com>
8178 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
8179 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
8180 call ResolveConstructedType() on it to resolve it without checking
8182 (Constraints.ResolveTypes): Check them here.
8183 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
8184 but don't check constraints.
8185 (ConstructedType.ResolveAsTypeTerminal): Override this and also
8186 check constraints here.
8187 (ConstructedType.ResolveConstructedType): New public method. This
8188 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
8189 resolve ourselves without checking constraints.
8191 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
8193 2004-11-18 Martin Baulig <martin@ximian.com>
8196 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
8198 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
8200 2004-11-18 Martin Baulig <martin@ximian.com>
8202 * ecore.cs (TypeExpr.ResolveType): Removed.
8203 (Expression.ResolveAsTypeTerminal): We always return a fully
8204 resolved `TypeExpr', so we can just access its `Type'.
8206 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
8208 2004-11-17 Martin Baulig <martin@ximian.com>
8210 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
8211 sure we don't return any unresolved TypeExpr's.
8212 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
8214 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
8216 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
8217 unresolved `ConstructedType's.
8219 2004-11-17 Martin Baulig <martin@ximian.com>
8221 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
8223 2004-11-17 Martin Baulig <martin@ximian.com>
8226 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
8228 * decl.cs (DeclSpace.ResolveType): Removed.
8229 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
8231 2004-11-17 Martin Baulig <martin@ximian.com>
8233 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
8234 direction, like FindMembers() does. Fixes #69546, testcase is in
8237 2004-11-16 Martin Baulig <martin@ximian.com>
8239 This is based on a patch from Marek Safar, see bug #69082.
8240 Fixes bugs #63705 and #67130.
8242 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
8243 method; create a MemberCache for an interface type and cache the
8246 * decl.cs (IMemberContainer.ParentContainer): Removed.
8247 (IMemberContainer.ParentCache): New property.
8248 (MemberCache.SetupCacheForInterface): Removed.
8249 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
8250 to create a cache for an interface's "parent".
8252 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
8255 2004-11-14 Ben Maurer <bmaurer@ximian.com>
8257 * statement.cs: Avoid adding bools to a hashtable.
8259 2004-11-15 Martin Baulig <martin@ximian.com>
8261 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
8263 2004-11-11 Martin Baulig <martin@ximian.com>
8265 * typemanager.cs (TypeManager.GetMethodName): New method.
8267 * class.cs (MethodData.Define): Include the generic arity in the
8268 name of an explicit interface; also add it to the method name.
8270 * pending.cs (PendingImplementation.InterfaceMethod): The method
8271 name now includes the generic arity.
8273 2004-11-07 Miguel de Icaza <miguel@ximian.com>
8275 * expression.cs (Invocation.OverloadResolve): Flag error if we are
8276 calling an unsafe method from a safe location.
8278 2004-11-06 Marek Safar <marek.safar@seznam.cz>
8281 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
8283 2004-11-06 Miguel de Icaza <miguel@ximian.com>
8285 * namespace.cs (VerifyUsing): use GetPartialName instead of
8288 2004-11-05 Miguel de Icaza <miguel@ximian.com>
8290 * statement.cs (Return.Resolve): Fix regression in typo: if
8291 `in_exc', we have to request a NeedReturnLabel, this was a typo
8292 introduced in the anonymous method check-in. Fixes #69131.
8294 * Indexers were using the ShortName when defining themselves,
8295 causing a regression in the compiler bootstrap when applying the
8296 patch from 2004-11-02 (first part), now they use their full name
8297 and the bug is gone.
8299 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
8301 * driver.cs: Strip the path from the names of embedded resources. Fixes
8304 2004-11-04 Raja R Harinath <rharinath@novell.com>
8306 Fix error message regression: cs0104-2.cs.
8307 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
8308 (AliasEntry.Resolve): Update.
8309 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
8311 (RootContext.LookupType): Update.
8313 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
8315 * cs-parser.jay: Add support for handling accessor modifiers
8316 * class: Add support port accessor modifiers and error checking,
8317 define PropertyMethod.Define as virtual (not abstract anymore)
8318 * ecore.cs: Add checking for proeprties access with access modifiers
8319 * iterators.cs: Modify Accessor constructor call based in the modified
8321 2004-11-02 Ben Maurer <bmaurer@ximian.com>
8323 * expression.cs (StringConcat): Handle being called twice,
8324 as when we have a concat in a field init with more than two
8327 2004-11-02 Miguel de Icaza <miguel@ximian.com>
8329 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
8330 special case explicit implementations, we should always produce
8331 the .property or .event declaration.
8333 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
8334 since it will not return correct data if people use this
8335 unresolved in the presence of using statements (see test-313).
8337 * class.cs (MethodData.Define): If we are an explicit interface
8338 implementation, set the method name to the full name of the
8339 interface plus the name of the method.
8341 Notice that using the method.MethodName.GetFullName() does not
8342 work, as it will only contain the name as declared on the source
8343 file (it can be a shorthand in the presence of using statements)
8344 and not the fully qualifed type name, for example:
8348 class D : ICloneable {
8349 object ICloneable.Clone () {
8353 Would produce a method called `ICloneable.Clone' instead of
8354 `System.ICloneable.Clone'.
8356 * namespace.cs (Alias.Resolve): Use GetPartialName.
8358 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8360 * cs-parser.jay: Add error 1055 report.
8362 2004-11-01 Miguel de Icaza <miguel@ximian.com>
8364 * assign.cs (Assign.DoResolve): Only do the transform of
8365 assignment into a New if the types are compatible, if not, fall
8366 through and let the implicit code deal with the errors and with
8367 the necessary conversions.
8369 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8371 * cs-parser.jay: Add error 1031 report.
8373 * cs-tokenizer.cs: Add location for error 1038.
8375 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8377 * cs-parser.jay: Add error 1016 report.
8379 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8381 * cs-parser.jay: Add errors 1575,1611 report.
8383 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8385 * cs-parser.jay: Add error 1001 report.
8387 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8390 * attribute.cs (GetMarshal): Add method argument for
8391 caller identification.
8393 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
8394 agument for GetMarshal and RuntimeMissingSupport.
8396 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8398 * attribute.cs (ExtractSecurityPermissionSet): Removed
8399 TypeManager.code_access_permission_type.
8401 * typemanager.cs: Removed TypeManager.code_access_permission_type.
8403 2004-10-27 Miguel de Icaza <miguel@ximian.com>
8405 * expression.cs (LocalVariableReference.DoResolveLValue): Check
8406 for obsolete use of a variable here. Fixes regression on errors
8407 cs0619-25 and cs0619-26.
8409 2004-10-27 Marek Safar <marek.safar@seznam.cz>
8411 Fix #62358, implemented security attribute encoding.
8413 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
8414 Tests permitted SecurityAction for assembly or other types.
8415 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
8416 data from SecurityPermissionAttribute to PermisionSet class.
8418 * class.cs (ApplyAttributeBuilder): Added special handling
8419 for System.Security.Permissions.SecurityAttribute based types.
8421 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
8422 special handling for System.Security.Permissions.SecurityAttribute
8425 * enum.cs (ApplyAttributeBuilder): Added special handling
8426 for System.Security.Permissions.SecurityAttribute based types.
8428 * parameter.cs (ApplyAttributeBuilder): Added special handling
8429 for System.Security.Permissions.SecurityAttribute based types.
8431 * rootcontext.cs: Next 2 core types.
8433 * typemanager.cs (TypeManager.security_permission_attr_type):
8434 Built in type for the SecurityPermission Attribute.
8435 (code_access_permission_type): Build in type.
8437 2004-10-17 Miguel de Icaza <miguel@ximian.com>
8439 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
8440 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
8441 all of this information into
8442 EmitContext.EmitCapturedVariableInstance.
8444 * codegen.cs (EmitCapturedVariableInstance): move here the
8445 funcionality of emitting an ldarg.0 in the presence of a
8446 remapping. This centralizes the instance emit code.
8448 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
8449 then emit a load of this: it means that we have reached the
8450 topmost ScopeInfo: the one that contains the pointer to the
8451 instance of the class hosting the anonymous method.
8453 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
8454 captures to the topmost CaptureContext.
8456 2004-10-12 Miguel de Icaza <miguel@ximian.com>
8458 * expression.cs (LocalVariableReference): Move the knowledge about
8459 the iterators into codegen's EmitCapturedVariableInstance.
8461 2004-10-11 Miguel de Icaza <miguel@ximian.com>
8463 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
8464 all code paths return a value from an anonymous method (it is the
8465 same as the 161 error, but for anonymous methods).
8467 2004-10-08 Miguel de Icaza <miguel@ximian.com>
8469 The introduction of anonymous methods in the compiler changed
8470 various ways of doing things in the compiler. The most
8471 significant one is the hard split between the resolution phase
8472 and the emission phases of the compiler.
8474 For instance, routines that referenced local variables no
8475 longer can safely create temporary variables during the
8476 resolution phase: they must do so from the emission phase,
8477 since the variable might have been "captured", hence access to
8478 it can not be done with the local-variable operations from the runtime.
8482 (Block.Flags): New flag `IsTopLevel' to indicate that this block
8483 is a toplevel block.
8485 (ToplevelBlock): A new kind of Block, these are the blocks that
8486 are created by the parser for all toplevel method bodies. These
8487 include methods, accessors and anonymous methods.
8489 These contain some extra information not found in regular blocks:
8490 A pointer to an optional CaptureContext (for tracking captured
8491 local variables and parameters). A pointer to the parent
8494 (Return.Resolve): Catch missmatches when returning a value from an
8495 anonymous method (error 1662).
8496 Invoke NeedReturnLabel from the Resolve phase instead of the emit
8499 (Break.Resolve): ditto.
8501 (SwitchLabel): instead of defining the labels during the
8502 resolution phase, we now turned the public ILLabel and ILLabelCode
8503 labels into methods called GetILLabelCode() and GetILLabel() that
8504 only define the label during the Emit phase.
8506 (GotoCase): Track the SwitchLabel instead of the computed label
8507 (its contained therein). Emit the code by using
8508 SwitchLabel.GetILLabelCode ().
8510 (LocalInfo.Flags.Captured): A new flag has been introduce to track
8511 whether the Local has been captured or not.
8513 (LocalInfo.IsCaptured): New property, used to tell whether the
8514 local has been captured.
8516 * anonymous.cs: Vastly updated to contain the anonymous method
8519 The main classes here are: CaptureContext which tracks any
8520 captured information for a toplevel block and ScopeInfo used to
8521 track the activation frames for various local variables.
8523 Each toplevel block has an optional capture context associated
8524 with it. When a method contains an anonymous method both the
8525 toplevel method and the anonymous method will create a capture
8526 context. When variables or parameters are captured, they are
8527 recorded on the CaptureContext that owns them, for example:
8531 MyDelegate d = delegate {
8536 Here `a' will be recorded as captured on the toplevel
8537 CapturedContext, the inner captured context will not have anything
8538 (it will only have data if local variables or parameters from it
8539 are captured in a nested anonymous method.
8541 The ScopeInfo is used to track the activation frames for local
8542 variables, for example:
8544 for (int i = 0; i < 10; i++)
8545 for (int j = 0; j < 10; j++){
8546 MyDelegate d = delegate {
8551 At runtime this captures a single captured variable `i', but it
8552 captures 10 different versions of the variable `j'. The variable
8553 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
8554 recorded on a child.
8556 The toplevel ScopeInfo will also track information like the `this'
8557 pointer if instance variables were referenced (this is necessary
8558 as the anonymous method lives inside a nested class in the host
8559 type of the method).
8561 (AnonymousMethod): Expanded to track the Toplevel, implement
8562 `AnonymousMethod.Compatible' to tell whether an anonymous method
8563 can be converted to a target delegate type.
8565 The routine now also produces the anonymous method content
8567 (AnonymousDelegate): A helper class that derives from
8568 DelegateCreation, this is used to generate the code necessary to
8569 produce the delegate for the anonymous method that was created.
8571 * assign.cs: API adjustments for new changes in
8572 Convert.ImplicitStandardConversionExists.
8574 * class.cs: Adjustments to cope with the fact that now toplevel
8575 blocks are of type `ToplevelBlock'.
8577 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
8578 insteda of standard blocks.
8580 Flag errors if params arguments are passed to anonymous methods.
8582 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
8583 `CurrentAnonymousMethod' which points to the current Anonymous
8584 Method. The variable points to the AnonymousMethod class that
8585 holds the code being compiled. It is set in the new EmitContext
8586 created for the anonymous method.
8588 (EmitContext.Phase): Introduce a variable and an enumeration to
8589 assist in enforcing some rules about when and where we are allowed
8590 to invoke certain methods (EmitContext.NeedsReturnLabel is the
8591 only one that enfonces this right now).
8593 (EmitContext.HaveCaptureInfo): new helper method that returns
8594 whether we have a CapturedContext initialized.
8596 (EmitContext.CaptureVariable): New method used to register that a
8597 LocalInfo must be flagged for capturing.
8599 (EmitContext.CapturedParameter): New method used to register that a
8600 parameters must be flagged for capturing.
8602 (EmitContext.CapturedField): New method used to register that a
8603 field must be flagged for capturing.
8605 (EmitContext.HaveCapturedVariables,
8606 EmitContext.HaveCapturedFields): Return whether there are captured
8607 variables or fields.
8609 (EmitContext.EmitMethodHostInstance): This is used to emit the
8610 instance for the anonymous method. The instance might be null
8611 (static methods), this (for anonymous methods that capture nothing
8612 and happen to live side-by-side with the current method body) or a
8613 more complicated expression if the method has a CaptureContext.
8615 (EmitContext.EmitTopBlock): Routine that drives the emission of
8616 code: it will first resolve the top block, then emit any metadata
8617 and then emit the code. The split is done so that we can extract
8618 any anonymous methods and flag any captured variables/parameters.
8620 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
8621 during this phase, the ILGenerator should not be used as labels
8622 and local variables declared here might not be accessible to any
8623 code that is part of an anonymous method.
8625 Exceptions to this include the temporary variables that are
8626 created by some statements internally for holding temporary
8629 (EmitContext.EmitMeta): New routine, in charge of emitting all the
8632 (EmitContext.TemporaryReturn): This method is typically called
8633 from the Emit phase, and its the only place where we allow the
8634 ReturnLabel to be defined other than the EmitMeta. The reason is
8635 that otherwise we would have to duplicate a lot of logic in the
8636 Resolve phases of various methods that today is on the Emit
8639 (EmitContext.NeedReturnLabel): This no longer creates the label,
8640 as the ILGenerator is not valid during the resolve phase.
8642 (EmitContext.EmitThis): Extended the knowledge in this class to
8643 work in anonymous methods in addition to iterators.
8645 (EmitContext.EmitCapturedVariableInstance): This emits whatever
8646 code is necessary on the stack to access the instance to a local
8647 variable (the variable will be accessed as a field).
8649 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
8650 EmitContext.EmitAddressOfParameter): Routines to support
8651 parameters (not completed at this point).
8653 Removals: Removed RemapLocal and RemapLocalLValue. We probably
8654 will also remove the parameters.
8656 * convert.cs (Convert): Define a `ConstantEC' which points to a
8657 null. This is just to prefity some code that uses
8658 ImplicitStandardConversion code and do not have an EmitContext
8661 The idea is to flag explicitly that at that point in time, it is
8662 known that the conversion will not trigger the delegate checking
8663 code in implicit conversions (which requires a valid
8666 Everywhere: pass new EmitContext parameter since
8667 ImplicitStandardConversionExists now requires it to check for
8668 anonymous method conversions.
8670 (Convert.ImplicitStandardConversionExists): If the type of an
8671 expression is the anonymous_method_type, and the type is a
8672 delegate, we invoke the AnonymousMethod.Compatible method to check
8673 whether an implicit conversion is possible.
8675 (Convert.ImplicitConversionStandard): Only do implicit method
8676 group conversions if the language level is not ISO_1.
8678 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
8679 MethodInfo for the Invoke method. used by Delegate and
8682 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
8683 method conversions if the target type is a delegate.
8685 Removed extra debugging nops.
8687 (LocalVariableReference): Turn the `local_info' into a public
8690 Add `prepared' field, the same hack used for FieldExprs to cope
8691 with composed assignments, as Local variables do not necessarily
8692 operate purely on the stack as they used to: they can be captured
8695 Add `temp' for a temporary result, like fields.
8697 Refactor DoResolve and DoResolveLValue into DoResolveBase.
8699 It now copes with Local variables that are captured and emits the
8700 proper instance variable to load it from a field in the captured
8703 (ParameterReference.DoResolveBase): During the resolve phase,
8704 capture parameters if we are in an anonymous method.
8706 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
8707 anonymous method, use the EmitContext helper routines to emit the
8708 parameter reference.
8710 * iterators.cs: Set RemapToProxy to true/false during the
8713 * parameters.cs (GetParameterByName): New helper method.
8715 * typemanager.cs (anonymous_method_type) a new type that
8716 represents an anonyous method. This is always an internal type,
8717 used as a fencepost to test against the anonymous-methodness of an
8720 2004-10-20 Marek Safar <marek.safar@seznam.cz>
8722 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
8724 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
8726 2004-11-10 Martin Baulig <martin@ximian.com>
8728 * expression.cs (Invocation.BetterFunction): If two methods have
8729 equal parameter types, but only one of them is generic, the
8730 non-generic one wins.
8731 (New.DoResolve): Don't set `is_struct' to false if we're a generic
8732 instance; just use `Type.IsValueType' to determine whether
8733 something is a struct or not.
8734 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
8735 so we can be called multiple times.
8737 2004-11-10 Martin Baulig <martin@ximian.com>
8739 * generic.cs (TypeParameter.DefineConstraints): New public method.
8740 (TypeParameter.CheckAccessLevel): Override this and return true.
8741 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
8742 override ResolveType() anymore.
8743 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
8745 2004-11-10 Martin Baulig <martin@ximian.com>
8747 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
8748 call DeclSpace.ResolveNestedType() on it.
8750 2004-11-10 Martin Baulig <martin@ximian.com>
8752 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
8753 non-null, call ParameterModifier() on it.
8755 2004-11-10 Martin Baulig <martin@ximian.com>
8758 (Iterators): Added `current_type' and `this_type' fields.
8759 (Iterators.DefineIterator): Create a new EmitContext and store it
8760 in `ec'; compute `this_type'.
8762 2004-11-10 Martin Baulig <martin@ximian.com>
8765 (TypeManager.IsPrivateAccessible): New public method.
8766 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
8768 2004-11-10 Martin Baulig <martin@ximian.com>
8770 * class.cs (TypeContainer.DefineType): Call
8771 TypeBuilder.DefineGenericParameters() before resolving the type
8773 (MethodData.parent_method): New protected field.
8774 (MethodData..ctor): Added `MethodInfo parent_method' argument.
8775 (MethodData.Define): Compute `parent_method'.
8778 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
8779 (MemberCore.GetClsCompliantAttributeValue): Likewise.
8780 (DeclSpace.ec): New protected field; store the EmitContext here.
8781 (DeclSpace.EmitContext): New public property.
8782 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
8783 (DeclSpace.ResolveNestedType): New public method.
8784 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
8785 (DeclSpace.NestedAccessible): Added `Type tb' argument.
8786 (DeclSpace.FamilyAccessible): Likewise.
8787 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
8788 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
8791 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
8794 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
8795 (Enum.Emit): Don't create a new EmitContext.
8797 2004-10-18 Martin Baulig <martin@ximian.com>
8799 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
8800 `Type' directly, but call ResolveType() on it.
8801 (Catch.Resolve): Likewise.
8802 (Foreach.Resolve): Likewise.
8804 2004-10-18 Martin Baulig <martin@ximian.com>
8806 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
8807 `Type' directly, but call ResolveType() on it.
8808 (Probe.DoResolve): Likewise.
8809 (ArrayCreation.LookupType): Likewise.
8810 (TypeOf.DoResolve): Likewise.
8811 (SizeOf.DoResolve): Likewise.
8813 2004-10-18 Raja R Harinath <rharinath@novell.com>
8815 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
8818 2004-10-17 John Luke <john.luke@gmail.com>
8820 * class.cs (Operator.GetSignatureForError): use CSharpName
8822 * parameter.cs (Parameter.GetSignatureForError): Returns
8823 correct name even if was not defined.
8825 2004-10-13 Raja R Harinath <rharinath@novell.com>
8828 * class.cs (TypeContainer.EmitContext): New property.
8829 (DefineNestedTypes): Create an emitcontext for each part.
8830 (MethodCore.DoDefineParameters): Use container's emitcontext.
8831 Pass type array to InternalParameters.
8832 (MemberBase.DoDefine): Use container's emitcontext.
8833 (FieldMember.Define): Likewise.
8834 (Event.Define): Likewise.
8835 (SetMethod.GetParameterInfo): Change argument to EmitContext.
8836 Pass type array to InternalParameters.
8837 (SetIndexerMethod.GetParameterInfo): Likewise.
8838 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
8839 * delegate.cs (Define): Pass emitcontext to
8840 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
8841 array to InternalParameters.
8842 * expression.cs (ParameterReference.DoResolveBase): Pass
8843 emitcontext to GetParameterInfo.
8844 (ComposedCast.DoResolveAsTypeStep): Remove check on
8845 ec.ResolvingTypeTree.
8846 * parameter.cs (Parameter.Resolve): Change argument to
8847 EmitContext. Use ResolveAsTypeTerminal.
8848 (Parameter.GetSignature): Change argument to EmitContext.
8849 (Parameters.ComputeSignature): Likewise.
8850 (Parameters.ComputeParameterTypes): Likewise.
8851 (Parameters.GetParameterInfo): Likewise.
8852 (Parameters.ComputeAndDefineParameterTypes): Likewise.
8853 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
8854 * support.cs (InternalParameters..ctor): Remove variant that takes
8856 * typemanager.cs (system_intptr_expr): New.
8857 (InitExpressionTypes): Initialize it.
8859 2004-10-12 Chris Toshok <toshok@ximian.com>
8861 * cs-parser.jay: fix location for try_statement and catch_clause.
8863 2004-10-18 Martin Baulig <martin@ximian.com>
8865 * class.cs (FieldMember.Define): Don't access the TypeExpr's
8866 `Type' directly, but call ResolveType() on it.
8867 (MemberBase.DoDefine): Likewise.
8869 * expression.cs (New.DoResolve): Don't access the TypeExpr's
8870 `Type' directly, but call ResolveType() on it.
8871 (ComposedCast.DoResolveAsTypeStep): Likewise.
8873 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
8874 `Type' directly, but call ResolveType() on it.
8876 2004-10-17 John Luke <john.luke@gmail.com>
8878 * class.cs (Operator.GetSignatureForError): use CSharpName
8880 * parameter.cs (Parameter.GetSignatureForError): Returns
8881 correct name even if was not defined.
8883 2004-10-13 Raja R Harinath <rharinath@novell.com>
8886 * class.cs (TypeContainer.EmitContext): New property.
8887 (DefineNestedTypes): Create an emitcontext for each part.
8888 (MethodCore.DoDefineParameters): Use container's emitcontext.
8889 Pass type array to InternalParameters.
8890 (MemberBase.DoDefine): Use container's emitcontext.
8891 (FieldMember.Define): Likewise.
8892 (Event.Define): Likewise.
8893 (SetMethod.GetParameterInfo): Change argument to EmitContext.
8894 Pass type array to InternalParameters.
8895 (SetIndexerMethod.GetParameterInfo): Likewise.
8896 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
8897 * delegate.cs (Define): Pass emitcontext to
8898 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
8899 array to InternalParameters.
8900 * expression.cs (ParameterReference.DoResolveBase): Pass
8901 emitcontext to GetParameterInfo.
8902 (ComposedCast.DoResolveAsTypeStep): Remove check on
8903 ec.ResolvingTypeTree.
8904 * parameter.cs (Parameter.Resolve): Change argument to
8905 EmitContext. Use ResolveAsTypeTerminal.
8906 (Parameter.GetSignature): Change argument to EmitContext.
8907 (Parameters.ComputeSignature): Likewise.
8908 (Parameters.ComputeParameterTypes): Likewise.
8909 (Parameters.GetParameterInfo): Likewise.
8910 (Parameters.ComputeAndDefineParameterTypes): Likewise.
8911 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
8912 * support.cs (InternalParameters..ctor): Remove variant that takes
8914 * typemanager.cs (system_intptr_expr): New.
8915 (InitExpressionTypes): Initialize it.
8917 2004-10-12 Chris Toshok <toshok@ximian.com>
8919 * cs-parser.jay: fix location for try_statement and catch_clause.
8921 2004-10-07 Raja R Harinath <rharinath@novell.com>
8923 More DeclSpace.ResolveType avoidance.
8924 * decl.cs (MemberCore.InUnsafe): New property.
8925 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
8926 with newly created EmitContext.
8927 (FieldMember.Define): Likewise.
8928 * delegate.cs (Delegate.Define): Likewise.
8929 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
8930 only if normal name-lookup fails.
8931 (TypeExpr.DoResolve): Enable error-checking.
8932 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
8933 (SizeOf.DoResolve): Likewise.
8934 (ComposedCast.DoResolveAsTypeStep): Likewise.
8935 (StackAlloc.DoResolve): Likewise.
8936 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
8937 (Block.Unsafe): New property.
8938 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
8939 (Unsafe): Set 'unsafe' flag of contained block.
8940 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
8941 (Fixed.Resolve): Likewise.
8942 (Catch.Resolve): Likewise.
8943 (Using.ResolveLocalVariableDecls): Likewise.
8944 (Foreach.Resolve): Likewise.
8946 2004-10-05 John Luke <john.luke@gmail.com>
8948 * cs-parser.jay: add location to error CS0175
8950 2004-10-04 Miguel de Icaza <miguel@ximian.com>
8952 * ecore.cs (Expression.Constantity): Add support for turning null
8955 * const.cs (Const.Define): Allow constants to be reference types
8956 as long as the value is Null.
8958 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
8960 * namespace.cs (NamespaceEntry.Using): No matter which warning
8961 level is set, check if this namespace name has already been added.
8963 2004-10-03 Ben Maurer <bmaurer@ximian.com>
8965 * expression.cs: reftype [!=]= null should always use br[true,false].
8968 2004-10-03 Marek Safar <marek.safar@seznam.cz>
8971 * attribute.cs: Enum conversion moved to
8972 GetAttributeArgumentExpression to be applied to the all
8975 2004-10-01 Raja R Harinath <rharinath@novell.com>
8977 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
8978 * class.c (TypeContainer.DefineType): Flag error if
8979 base types aren't accessible due to access permissions.
8980 * decl.cs (DeclSpace.ResolveType): Move logic to
8981 Expression.ResolveAsTypeTerminal.
8982 (DeclSpace.ResolveTypeExpr): Thin layer over
8983 Expression.ResolveAsTypeTerminal.
8984 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
8985 Refactor code into NestedAccess. Use it.
8986 (DeclSpace.NestedAccess): New.
8987 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
8988 argument to silence errors. Check access permissions.
8989 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
8990 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
8991 (Cast.DoResolve): Likewise.
8992 (New.DoResolve): Likewise.
8993 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
8994 (TypeOf.DoResolve): Likewise.
8996 * expression.cs (Invocation.BetterConversion): Return the Type of
8997 the better conversion. Implement section 14.4.2.3 more faithfully.
8998 (Invocation.BetterFunction): Make boolean. Make correspondence to
8999 section 14.4.2.2 explicit.
9000 (Invocation.OverloadResolve): Update.
9001 (Invocation): Remove is_base field.
9002 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
9003 (Invocation.Emit): Likewise.
9005 2004-09-24 Marek Safar <marek.safar@seznam.cz>
9007 * cs-parser.jay: Reverted 642 warning fix.
9009 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9012 * decl.cs (FindMemberWithSameName): Indexer can have more than
9015 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9017 * expression.cs (LocalVariableReference.DoResolveLValue):
9018 Do not report warning 219 for out values.
9019 (EmptyExpression.Null): New member to avoid extra allocations.
9021 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9023 * cs-parser.jay: Fix wrong warning 642 report.
9025 * cs-tokenizer.cs (CheckNextToken): New helper;
9026 Inspect next character if is same as expected.
9028 2004-09-23 Martin Baulig <martin@ximian.com>
9030 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9031 (Convert.ImplicitReferenceConversionExists): Likewise.
9033 2004-11-09 Raja R Harinath <rharinath@novell.com>
9035 * Makefile (DISTFILES): Comment out a few missing files.
9037 2004-10-29 Raja R Harinath <rharinath@novell.com>
9039 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
9040 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
9041 (gmcs.exe): Invoke bootstrap-libs.
9042 (clean-local): Clean the net_2_0_bootstrap profile too.
9043 (PROGRAM_INSTALL_DIR): New.
9044 (install-local): Use it.
9046 2004-10-13 Martin Baulig <martin@ximian.com>
9048 * generic.cs (TypeManager.InflatedConstraints): New nested class.
9049 (TypeParameter.DefineType): If we're a method type parameter and
9050 that method is overriding something, "inflate" its constraints.
9052 2004-10-12 Martin Baulig <martin@ximian.com>
9054 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
9055 and have type arguments, create and resolve a ConstructedType.
9057 2004-10-12 Martin Baulig <martin@ximian.com>
9059 * decl.cs (MemberCache.FindMemberToOverride): Use
9060 TypeManager.IsEqual() to compare the parameters and Type.Equals()
9061 to compare the invocationType.
9063 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
9064 When comparing two type parameters, only do the signature-only
9065 comparision for method type parameters.
9067 2004-10-11 Martin Baulig <martin@ximian.com>
9069 * report.cs: Don't make --fatal abort on warnings, we have
9070 -warnaserror for that.
9072 2004-10-11 Martin Baulig <martin@ximian.com>
9075 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
9076 (TypeManager.IsEqual): Call ourself recursively instead of using
9079 2004-10-11 Martin Baulig <martin@ximian.com>
9081 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
9082 on our own type parameters, not on the ones we inherit from a containing
9085 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
9088 * generic.cs (TypeParameter.Define): We may only be called once.
9090 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
9091 instead of TypeManager.IsEqual().
9093 2004-09-28 Martin Baulig <martin@ximian.com>
9096 (GenericConstraints.EffectiveBaseClass): New public property.
9097 (TypeParameter.GenericConstraints): New public property.
9098 (ConstructedType.CheckConstraints): Improved.
9100 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
9101 (Convert.TypeParameterConversion): New private method; use this in
9102 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
9103 for all conversions related to type parameters.
9105 2004-09-24 Martin Baulig <martin@ximian.com>
9107 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
9108 type parameter conversions for type parameters which are known to
9111 2004-09-24 Martin Baulig <martin@ximian.com>
9113 * generic.cs (GenericConstraints): Added `IsReferenceType' and
9114 `IsValueType' properties.
9116 * support.cs (ReflectionConstraints): Use
9117 Type.GetGenericParameterConstraints() instead of the old hack.
9119 2004-09-24 Martin Baulig <martin@ximian.com>
9121 * generic.cs (GenericConstraints): Moved here and made it an
9124 * support.cs (GenericConstraints): Moved to generic.cs.
9126 2004-09-24 Martin Baulig <martin@ximian.com>
9129 (ReflectionConstraints): Un-nested this class and made it public.
9132 (TypeManager.GetTypeParameterConstraints): New public method.
9133 (TypeManager.HasConstructorConstraint): Use the attributes.
9135 2004-09-24 Martin Baulig <martin@ximian.com>
9137 * support.cs (GenericConstraints): Replaced `HasConstructor',
9138 `IsReferenceType' and `IsValueType' with `Attributes'.
9139 (ReflectionParameters.ReflectionConstraints): Removed the Create()
9140 method and made the .ctor public.
9142 * generic.cs (Constraints.Attributes): New public property.
9143 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
9144 `IsReferenceType' -> `HasReferenceTypeConstraint' and
9145 `IsValueType' -> `HasValueTypeConstraint'.
9147 2004-09-23 Martin Baulig <martin@ximian.com>
9149 * generic.cs (Constraints): Reflect latest runtime changes.
9151 2004-09-23 Martin Baulig <martin@ximian.com>
9153 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9154 (Convert.ImplicitReferenceConversionExists): Likewise.
9156 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9158 * class.cs (Operator.Define): Add error 448 and 559 report.
9160 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9162 * class.cs (MemberBase.IsTypePermitted): New protected
9163 method for checking error CS0610.
9165 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9167 * class.cs (TypeContainer.HasExplicitLayout): New property
9168 Returns whether container has StructLayout attribute set Explicit.
9169 (FieldMember): New abstract class for consts and fields.
9170 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
9171 (Field): Reuse FieldMember.
9173 * const.cs (Const): Reuse FieldMember.
9175 * rootcontext.cs: EmitConstants call moved to class.
9177 2004-09-22 Martin Baulig <martin@ximian.com>
9179 Marek and me just fixed one of our oldest bugs: #28562 :-)
9181 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
9183 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
9184 we're an EnumConstant, just return that.
9185 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
9186 an EnumConstant. In this case, we need to use GetValueAsEnumType()
9187 to get the value which'll actually be written into the attribute.
9188 However, we have to use GetValue() to access the attribute's value
9191 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9193 * constant.cs (Constant.IsNegative): New abstract property
9196 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
9197 (StackAlloc.DoResolve): Reused IsNegative.
9199 2004-09-22 Martin Baulig <martin@ximian.com>
9201 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
9202 public method; like LookupTypeContainer, but also works for
9205 * report.cs (Report.SymbolRelatedToPreviousError): Use
9206 TypeManager.LookupGenericTypeContainer().
9208 2004-09-22 Martin Baulig <martin@ximian.com>
9210 Thanks to Peter Sestoft for this bug report.
9212 * expression.cs (Conditional): If both the `trueExpr' and the
9213 `falseExpr' is a NullLiteral, return a NullLiteral.
9215 2004-09-22 Martin Baulig <martin@ximian.com>
9217 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
9218 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
9219 for the "get_Current" call.
9221 2004-09-21 Martin Baulig <martin@ximian.com>
9223 * convert.cs (Convert.ImplicitReferenceConversion): When
9224 converting to an interface type, first check whether we're
9225 converting from a reference type.
9227 2004-09-14 Martin Baulig <martin@ximian.com>
9229 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
9231 2004-09-14 Marek Safar <marek.safar@seznam.cz>
9234 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
9235 called and is obsolete then this member suppress message
9236 when call is inside next [Obsolete] method or type.
9238 * expression.cs: Use TestObsoleteMethodUsage member.
9240 2004-09-14 Martin Baulig <martin@ximian.com>
9242 * genericparser.cs: Removed.
9244 2004-09-13 Marek Safar <marek.safar@seznam.cz>
9246 * class.cs (MethodCore.CheckBase): Fix bug #65757.
9248 2004-09-12 Marek Safar <marek.safar@seznam.cz>
9250 * attribute.cs (Attribute.Resolve): Add error 653 report.
9252 * class.cs (Class.ApplyAttributeBuilder): Add error 641
9254 (Method.ApplyAttributeBuilder): Add error 685 report.
9255 (Operator.Define): Add error 564 report.
9257 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
9259 * expression.cs (Invocation.DoResolve): Add error
9262 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
9265 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9267 * class.cs (ConstructorInitializer.Resolve):
9268 Wrong error number (515->516).
9270 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9272 * class.cs (Indexer.Define): Add error 631 report.
9274 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9276 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
9278 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9280 * expression.cs (Probe.DoResolve): Add error CS0241 report.
9282 2004-09-10 Marek Safar <marek.safar@seznam.cz>
9284 * cs-parser.jay: Added error CS0241 report.
9286 2004-09-10 Raja R Harinath <rharinath@novell.com>
9288 * cs-parser.jay (fixed_statement): Introduce a scope for the
9289 declaration in the 'fixed' statement.
9291 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9293 * cs-parser.jay: Added CS0230 error report.
9295 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9297 * cs-parser.jay: Added errors CS0231 and CS0257 report.
9299 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9301 * expression.cs (Argument.Resolve): Added error CS0192 and
9304 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9306 C# 2.0 #pragma warning feature
9308 * cs-tokenizer.cs (PreProcessPragma): New method;
9309 Handles #pragma directive.
9311 * report.cs (WarningRegions): New class; Support
9312 class for #pragma warning directive. It tests whether
9313 warning is enabled for a given line.
9315 2004-09-08 Miguel de Icaza <miguel@ximian.com>
9317 * const.cs: Add more descriptive error report, tahnks to
9320 2004-09-08 Marek Safar <marek.safar@seznam.cz>
9322 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
9324 2004-09-07 Miguel de Icaza <miguel@ximian.com>
9326 * expression.cs: Apply patch from Ben: Remove dead code from
9327 ArrayCreation, and remove the TurnintoConstant call in const.cs,
9328 as that code just threw an exception anwyays.
9330 * const.cs: Remove the call to the turnintoconstant, for details
9333 * literal.cs: The type of the null-literal is the null type; So
9334 we use a placeholder type (literal.cs:System.Null, defined here)
9337 * expression.cs (Conditional.DoResolve): Remove some old code that
9338 is no longer needed, conversions have been fixed.
9340 (ArrayCreationExpression.DoResolve): Return false if we fail to
9341 resolve the inner expression.
9343 2004-09-07 Raja R Harinath <rharinath@novell.com>
9346 * cs-parser.jay (delegate_declaration): Record a delegate
9347 declaration as a type declaration.
9348 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
9350 2004-09-06 Miguel de Icaza <miguel@ximian.com>
9352 * parameter.cs: Do not crash if the type can not be resolved.
9354 * expression.cs: Report errors with unsafe pointers, fixes #64896
9356 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
9358 * expression.cs: Pointer arith always needs to do a conv.i
9359 if the operand is a long. fix 65320
9361 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9363 Fixed cs0619-37.cs, cs0619-38.cs
9365 * enum.cs (GetObsoleteAttribute): Removed.
9367 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
9368 on Enum member is double staged. The first is tested member
9371 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9373 Fixed #56986, #63631, #65231
9375 * class.cs: (TypeContainer.AddToMemberContainer): New method,
9376 adds member to name container.
9377 (TypeContainer.AddToTypeContainer): New method, adds type to
9379 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
9380 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
9381 AddOperator): Simplified by reusing AddToMemberContainer.
9382 (TypeContainer.UserDefinedStaticConstructor): Changed to property
9384 (Method.CheckForDuplications): Fixed implementation to test all
9386 (MemberBase): Detection whether member is explicit interface
9387 implementation is now in constructor.
9388 (MemberBase.UpdateMemberName): Handles IndexerName.
9389 (Accessor): Changed to keep also location information.
9390 (AbstractPropertyEventMethod): Is derived from MemberCore.
9391 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
9392 will be emited or not.
9393 (PropertyBase.AreAccessorsDuplicateImplementation):
9394 Tests whether accessors are not in collision with some method.
9395 (Operator): Is derived from MethodCore to simplify common
9398 * decl.cs (Flags.TestMethodDuplication): Test for duplication
9400 (DeclSpace.AddToContainer): Adds the member to defined_names
9401 table. It tests for duplications and enclosing name conflicts.
9403 * enum.cs (EnumMember): Clean up to reuse the base structures
9405 2004-09-03 Martin Baulig <martin@ximian.com>
9407 Merged latest changes into gmcs. Please keep this comment in
9408 here, it makes it easier for me to see what changed in MCS since
9409 the last time I merged.
9411 2004-09-03 Martin Baulig <martin@ximian.com>
9413 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9414 into TypeContainer, to make partial classes work again.
9416 2004-09-03 Martin Baulig <martin@ximian.com>
9418 * rootcontext.cs (RootContext.V2): Removed.
9420 2004-03-23 Martin Baulig <martin@ximian.com>
9422 * expression.cs (Invocation.OverloadResolve): Added `bool
9423 may_fail' argument and use it instead of the Location.IsNull() hack.
9425 2004-09-09 Martin Baulig <martin@ximian.com>
9427 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
9429 2004-09-09 Martin Baulig <martin@ximian.com>
9431 * generic.cs (TypeParameter.DefineType): Added support for
9432 explicit interface methods.
9434 2004-09-09 Martin Baulig <martin@ximian.com>
9436 * README.Changes: New document. Started to list important changes
9437 between MCS and GMCS here.
9439 2004-09-08 Martin Baulig <martin@ximian.com>
9442 (TypeContainer.CheckRecursiveDefinition): New protected method.
9443 (TypeContainer.DefineType): Move the CS0146 check into
9444 CheckRecursiveDefinition().
9446 2004-09-06 Martin Baulig <martin@ximian.com>
9448 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
9449 types for the constructor constraint.
9451 2004-09-03 Martin Baulig <martin@ximian.com>
9453 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9454 into TypeContainer, to make partial classes work again.
9456 2004-09-03 Martin Baulig <martin@ximian.com>
9458 * rootcontext.cs (RootContext.V2): Removed.
9460 2004-03-23 Martin Baulig <martin@ximian.com>
9462 * expression.cs (Invocation.OverloadResolve): Added `bool
9463 may_fail' argument and use it instead of the Location.IsNull() hack.
9465 2004-09-03 Martin Baulig <martin@ximian.com>
9467 Merged latest changes into gmcs. Please keep this comment in
9468 here, it makes it easier for me to see what changed in MCS since
9469 the last time I merged.
9471 2004-09-03 Raja R Harinath <rharinath@novell.com>
9474 * expression.cs (BetterConversion): Don't allow either conversion
9475 to be null. Remove redundant implicit conversion test when 'q ==
9476 null' -- when this function is invoked, we already know that the
9477 implicit conversion exists.
9478 (BetterFunction): Assume that 'best' is non-null. Remove
9479 redundant reimplementation of IsApplicable when 'best' is null.
9480 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
9481 number of arguments.
9482 (IsAncestralType): Extract from OverloadResolve.
9483 (OverloadResolve): Make robust to the MethodGroupExpr being
9484 unsorted. Implement all the logic of Section 14.5.5.1, and
9485 support overloading of methods from multiple applicable types.
9486 Clean up logic somewhat. Don't pass null methods to BetterFunction.
9488 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
9489 (RealError, Warning): Append type of report to related symbol.
9491 2004-09-03 Marek Safar <marek.safar@seznam.cz>
9493 * enum.cs: Fixed CLS-Compliance checks for enum members.
9494 Error tests cs3008-8.cs, cs3014-8.cs
9496 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9498 Fixed bug #62342, #63102
9499 * class.cs: ImplementIndexer uses member.IsExplicitImpl
9500 like ImplementMethod.
9502 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9504 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9507 2004-09-02 Martin Baulig <martin@ximian.com>
9509 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9510 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9513 2004-09-01 Marek Safar <marek.safar@seznam.cz>
9515 C# 2.0 Static classes implemented
9517 * class.cs (TypeContainer): instance_constructors,
9518 initialized_fields, initialized_static_fields,
9519 default_constructor, base_inteface_types are protected to be
9520 accessible from StaticClass.
9521 (TypeContainer.DefineDefaultConstructor): New virtual method
9522 for custom default constructor generating
9523 (StaticClass): New class to handle "Static classes" feature.
9525 * cs-parser.jay: Handle static keyword on class like instance
9528 * driver.cs: Added "/langversion" command line switch with two
9529 options (iso-1, default).
9531 2004-08-31 Marek Safar <marek.safar@seznam.cz>
9533 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
9535 2004-08-31 Miguel de Icaza <miguel@ximian.com>
9537 * delegate.cs: Style.
9539 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
9541 * delegate.cs: Add seperate instance expr field for miguel.
9543 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9545 * PointerArithmetic (Resolve): make sure we are not doing
9546 pointer arith on void*. Also, make sure we are resolved
9547 by not setting eclass until resolve.
9549 All callers: Make sure that PointerArithmetic gets resolved.
9551 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9553 * ArrayCreation (LookupType): If the type does not resolve
9554 to an array, give an error.
9556 2004-08-27 Marek Safar <marek.safar@seznam.cz>
9558 * statement.cs (Try.Resolve): Fixed bug #64222
9560 2004-08-27 Martin Baulig <martin@ximian.com>
9563 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9566 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9568 * ecore.cs (Constantify): Get underlying type via
9569 System.Enum.GetUnderlyingType to avoid StackOverflow on the
9570 Windows in special cases.
9572 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9574 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
9575 for obtaining also private methods.
9576 (GetRemoveMethod): Used GetRemoveMethod (true)
9577 for obtaining also private methods.
9579 2004-09-02 Martin Baulig <martin@ximian.com>
9581 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9582 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9585 2004-08-27 Martin Baulig <martin@ximian.com>
9588 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9591 2004-08-25 Martin Baulig <martin@ximian.com>
9593 * support.cs (ReflectionParameters..ctor): If this is a generic
9594 method, retrieve and store its type parameters.
9595 (InternalParameters..ctor): Added `TypeParameter[]' argument.
9596 (ReflectionParameters.GenericConstraints): The argument specifies
9597 the type parameter, not the method parameter.
9598 (InternalParameters.GenericConstraints): Likewise.
9600 * generic.cs (TypeParameter.DefineType): Correctly handle
9601 constraints wrt. generic methods in interfaces and their
9604 2004-08-24 Martin Baulig <martin@ximian.com>
9606 * generic.cs (TypeParameter.IsSubclassOf): New public method.
9607 (Constraints.IsSubclassOf): New internal method.
9609 * typemanager.cs (TypeManager.FindMembers): Added special support
9610 for GenericTypeParameterBuilder's.
9611 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
9614 2004-08-24 Martin Baulig <martin@ximian.com>
9617 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
9618 this for accessibility checks.
9619 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
9620 IsNestedFamilyAccessible.
9621 (TypeManager.IsSubclassOf): New method, do what the name actually
9624 2004-08-24 Martin Baulig <martin@ximian.com>
9626 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
9627 as a SimpleName, include the generic arity.
9629 2004-08-24 Martin Baulig <martin@ximian.com>
9631 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
9632 MethodAttributes.HideBySig for operators.
9634 2004-08-23 Martin Baulig <martin@ximian.com>
9636 Back to the old error reporting system :-)
9638 * report.cs (Message): Removed.
9639 (Report.MessageData, ErrorData, WarningData): Removed.
9640 (Report.Error, Warning): Back to the old system.
9642 2004-08-23 Martin Baulig <martin@ximian.com>
9644 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
9646 * class.cs (TypeContainer.ParentContainer): New public virtual
9647 method; replaces the explicit interface implementation.
9648 (ClassPart.ParentContainer): Override.
9650 2004-08-23 Martin Baulig <martin@ximian.com>
9652 * statement.cs (Switch): Added support for constant switches; see
9653 #59428 or test-285.cs.
9655 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9658 * statement.cs (GetEnumeratorFilter): Removed useless
9659 logic because C# specs is strict. GetEnumerator must be
9662 2004-08-22 Martin Baulig <martin@ximian.com>
9664 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9665 a switch and may break, reset the barrier. Fixes #59867.
9667 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9669 CLS-Compliance speed up (~5% for corlib)
9671 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
9672 New method. Tests container for CLS-Compliant names
9674 * class.cs (TypeContainer.VerifyClsName): New method.
9675 Checks whether container name is CLS Compliant.
9676 (Constructor): Implements IMethodData.
9678 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
9679 low-case table for CLS Compliance test.
9680 (MemberCache.VerifyClsParameterConflict): New method.
9681 Checks method parameters for CS3006 error.
9683 * enum.cs (EnumMember): Is derived from MemberCore.
9684 (Enum.VerifyClsName): Optimized for better performance.
9686 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9688 * report.cs: Renamed Error_T to Error and changed all
9691 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9693 * class.cs (TypeContainer.IndexerArrayList): New inner class
9694 container for indexers.
9695 (TypeContainer.DefaultIndexerName): New constant for default
9696 indexer name. Replaced all "Item" with this constant.
9697 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
9699 * typemanager.cs (TypeManager.default_member_ctor): Cache here
9700 DefaultMemberAttribute constructor.
9702 2004-08-05 Martin Baulig <martin@ximian.com>
9704 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9707 2004-08-05 Marek Safar <marek.safar@seznam.cz>
9709 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
9710 multi platforms problem.
9712 * compiler.csproj: Included shared files.
9714 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9716 Fix bug 60333, 55971 in the more general way
9717 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9718 Added arg_type argument for constant conversion.
9719 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
9721 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9724 * class.cs (TypeContainer ): New inner classes MethodArrayList,
9725 OperatorArrayList, MethodCoreArrayList for typecontainer
9726 containers. Changed class member types to these new types.
9727 (MethodArrayList.DefineMembers): Added test for CS0659.
9729 2004-08-04 Miguel de Icaza <miguel@ximian.com>
9731 * cfold.cs: Synchronize the folding with the code in expression.cs
9732 Binary.DoNumericPromotions for uint operands.
9734 * attribute.cs: Revert patch from Raja, it introduced a regression
9735 while building Blam-1.2.1 (hard to isolate a test case).
9737 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9741 (TypeContainer.Define): Renamed to DefineContainerMembers because of
9743 (MethodCore.parent_method): New member. The method we're overriding
9744 if this is an override method.
9745 (MethodCore.CheckBase): Moved from Method class and made common.
9746 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
9748 (MethodCore.CheckForDuplications): New abstract method. For custom
9749 member duplication search in a container
9750 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
9751 method and its return type.
9752 (Event.conflict_symbol): New member. Symbol with same name in the
9756 (MemberCache.FindMemberWithSameName): New method. The method
9757 is looking for conflict with inherited symbols.
9759 2004-08-04 Martin Baulig <martin@ximian.com>
9761 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
9763 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
9765 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9767 * report.cs (Message): New enum for better error, warning reference in
9769 (MessageData): New inner abstract class. It generally handles printing of
9770 error and warning messages.
9771 Removed unused Error, Warning, Message methods.
9773 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9775 Fix for cs0592-8.cs test
9777 (Attributable.ValidAttributeTargets): Made public.
9778 (Attribute.ExplicitTarget): New member for explicit target value.
9779 (Attribute.CheckTargets): Now we translate explicit attribute
9780 target to Target here.
9782 2004-08-03 Ben Maurer <bmaurer@ximian.com>
9784 * ecore.cs (MethodGroupExpr): new IsBase property.
9786 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
9788 * delegate.cs (DelegateCreation): store a MethodGroupExpr
9789 rather than an instance expr.
9791 (DelegateCreation.Emit): Use the method group rather than
9792 the instance expression. Also, if you have base.Foo as the
9793 method for a delegate, make sure to emit ldftn, not ldftnvirt.
9795 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
9797 (NewDelegate.DoResolve): Only check for the existance of Invoke
9798 if the method is going to be needed. Use MethodGroupExpr.
9800 (NewDelegate.Emit): Remove, DelegateCreation implements this.
9802 * expression.cs: For pointer arith., make sure to use
9803 the size of the type, not the size of the pointer to
9806 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9809 * class.cs (Class): Added error CS0502 test.
9811 2004-08-03 John Luke <jluke@cfl.rr.com>
9812 Raja R Harinath <rharinath@novell.com>
9815 * attribute.cs (Attribute.complained_before): New flag.
9816 (Attribute.ResolveType, Attribute.Resolve),
9817 (Attribute.DefinePInvokeMethod): Set it.
9818 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
9820 2004-08-03 Martin Baulig <martin@ximian.com>
9822 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
9823 use a user-defined operator; we still need to do numeric
9824 promotions in case one argument is a builtin type and the other
9825 one has an implicit conversion to that type. Fixes #62322.
9827 2004-08-18 Martin Baulig <martin@ximian.com>
9829 * class.cs (Method.Define): Use the correct method name when
9830 creating the MethodBuilder for a generic method.
9832 2004-08-17 Martin Baulig <martin@ximian.com>
9834 * generic.cs (Constraints): Support type parameter constraints.
9836 2004-08-16 Martin Baulig <martin@ximian.com>
9838 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
9839 (Token.GENERIC_DIMENSION): New token; this is returned if we
9840 encounter an unbound generic type in a typeof() expression.
9842 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
9843 this token is only generated while parsing a typeof() expression.
9844 (typeof_expression): Removed the old unbound_type hack.
9846 * generic.cs (TypeArguments.IsUnbound): New public property.
9848 * decl.cs (MemberName): Added support for unbound types.
9850 2004-08-14 Martin Baulig <martin@ximian.com>
9853 (TypeManager.IsEqualGenericInstance): New static method.
9854 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
9855 just used to check accessibility, so follow the rules of 26.1.6.
9857 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
9858 ConstructedType instead of a TypeExpression if we have type arguments.
9860 * cs-parser.jay (typeof_expression): Support unbound generic types.
9862 * ecore.cs (UnboundTypeExpression): New public class.
9864 2004-08-12 Martin Baulig <martin@ximian.com>
9866 * typemanager.cs (TypeManager.IsNestedChildOf): Use
9867 TypeManager.IsEqual() rather than `=='.
9869 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
9870 generic instances as well.
9872 2004-08-12 Martin Baulig <martin@ximian.com>
9874 * expression.cs (Invocation.InferType): We can only infer method
9875 type parameters. Fixes #62647.
9877 2004-08-11 Martin Baulig <martin@ximian.com>
9879 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
9880 before resolving the base classes.
9882 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9884 * Makefile: install .mdb file too.
9886 2004-08-05 Martin Baulig <martin@ximian.com>
9888 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
9889 initializer, the current type is just the TypeBuilder, not the
9890 instantiated generic type.
9891 (FieldExpr.IsFieldInitializer): New public property.
9893 2004-08-04 Martin Baulig <martin@ximian.com>
9895 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
9897 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
9899 2004-08-03 Martin Baulig <martin@ximian.com>
9901 * class.cs (MethodData.Define): If we're an explicit
9902 implementation, remove the generic arity from the type name.
9904 2004-08-03 Martin Baulig <martin@ximian.com>
9906 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
9907 use a user-defined operator; we still need to do numeric
9908 promotions in case one argument is a builtin type and the other
9909 one has an implicit conversion to that type. Fixes #62322.
9911 2004-08-02 Martin Baulig <martin@ximian.com>
9913 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
9915 (TypeContainer.GetClassBases): Return the unexpanded list of
9916 interfaces; we expand them later.
9917 (TypeContainer.DefineType): After creating the TypeBuilder, call
9918 TypeManager.ExpandInterfaces() to get an expanded and resolved
9921 * ecore.cs (TypeExpr.GetInterfaces): Removed
9923 * generics.cs (Constraints.InterfaceConstraints): Remove.
9924 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
9925 register the interface constraints.
9928 (TypeManager.AddUserType): Removed the `ifaces' argument.
9929 (TypeManager.AddTypeParameter): Likewise.
9930 (TypeManager.AddUserInterface): Removed, was unused.
9931 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
9932 `TypeExpr[]' array for the interfaces.
9933 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
9934 has been defined, returns a list of the resolved interfaces types.
9935 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
9936 (TypeManager.GetExplicitInterfaces): Likewise.
9938 2004-08-02 Martin Baulig <martin@ximian.com>
9940 * expression.cs (Invocation.EmitCall): If we're invoking a method
9941 on a type parameter, use the new `Constrained' prefix opcode.
9943 2004-08-02 Martin Baulig <martin@ximian.com>
9945 * statement.cs (LocalInfo.Flags): Added `IsThis'.
9946 (LocalInfo.IsThis): New public property.
9947 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
9949 2004-08-01 Martin Baulig <martin@ximian.com>
9951 * class.cs (TypeContainer.GetClassBases): Don't set the default
9952 here since we may get called from GetPartialBases().
9953 (TypeContainer.DefineType): If GetClassBases() didn't return a
9954 parent, use the default one.
9956 2004-07-30 Martin Baulig <martin@ximian.com>
9958 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
9960 * class.cs (SourceMethod): New public class, derive from the
9961 symbol writer's ISourceMethod.
9962 (Method): Use the new symbol writer API.
9964 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
9965 as argument and use the new symbol writer.
9968 (SourceFile): Implement the symbol writer's ISourceFile.
9969 (Location.SymbolDocument): Removed.
9970 (Location.SourceFile): New public property.
9972 * symbolwriter.cs: Use the new symbol writer API.
9974 2004-07-30 Raja R Harinath <rharinath@novell.com>
9976 * Makefile (install-local): Remove. Functionality moved to
9979 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
9981 * Makefile: Install mcs.exe.config file together with mcs.exe.
9982 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
9983 correct runtime version.
9985 2004-07-25 Martin Baulig <martin@ximian.com>
9988 (TypeContainer.RegisterOrder): Removed, this was unused.
9989 (TypeContainer, interface_order): Removed.
9990 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
9991 TypeContainer as argument since we can also be called with a
9992 `PartialContainer' for a partial class/struct/interface.
9993 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
9994 of checking whether we're an `Interface' - we could be a
9996 (PartialContainer.Register): Override; call
9997 AddClass()/AddStruct()/AddInterface() on our parent.
9999 * cs-parser.jay (interface_member_declaration): Add things to the
10000 `current_container', not the `current_class'.
10002 * rootcontext.cs (RegisterOrder): The overloaded version which
10003 takes an `Interface' was unused, removed.
10005 * typemanager.cs (TypeManager.LookupInterface): Return a
10006 `TypeContainer', not an `Interface'.
10007 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
10008 contain a `PartialContainer' for an interface, so check it's
10009 `Kind' to figure out what it is.
10011 2004-07-25 Martin Baulig <martin@ximian.com>
10013 * class.cs (Class.DefaultTypeAttributes): New public constant.
10014 (Struct.DefaultTypeAttributes): Likewise.
10015 (Interface.DefaultTypeAttributes): Likewise.
10016 (PartialContainer.TypeAttr): Override this and add the
10017 DefaultTypeAttributes.
10019 2004-07-25 Martin Baulig <martin@ximian.com>
10021 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
10022 we can just use the `Parent' field instead.
10024 2004-07-25 Martin Baulig <martin@ximian.com>
10026 * class.cs (TypeContainer.Emit): Renamed to EmitType().
10028 2004-07-25 Martin Baulig <martin@ximian.com>
10030 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
10031 our parts before defining any methods.
10032 (TypeContainer.VerifyImplements): Make this virtual.
10033 (ClassPart.VerifyImplements): Override and call VerifyImplements()
10034 on our PartialContainer.
10036 2004-07-25 Martin Baulig <martin@ximian.com>
10038 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
10040 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
10041 argument, we can just use the `Parent' field instead.
10044 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
10045 (MemberBase.DoDefine): Likewise.
10047 2004-07-24 Martin Baulig <martin@ximian.com>
10049 * decl.cs (MemberCore.Parent): New public field.
10050 (DeclSpace.Parent): Moved to MemberCore.
10052 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
10053 (MemberBase.ctor): Added TypeContainer argument, pass it to our
10055 (FieldBase, Field, Operator): Likewise.
10056 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
10057 (EventField, Event): Likewise.
10059 2004-07-23 Martin Baulig <martin@ximian.com>
10061 * class.cs (PartialContainer): New public class.
10062 (ClassPart): New public class.
10063 (TypeContainer): Added support for partial classes.
10064 (TypeContainer.GetClassBases): Splitted some of the functionality
10065 out into GetNormalBases() and GetPartialBases().
10067 * cs-tokenizer.cs (Token.PARTIAL): New token.
10068 (Tokenizer.consume_identifier): Added some hacks to recognize
10069 `partial', but only if it's immediately followed by `class',
10070 `struct' or `interface'.
10072 * cs-parser.jay: Added support for partial clases.
10074 2004-07-23 Martin Baulig <martin@ximian.com>
10076 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
10077 a `DeclSpace' and also made it readonly.
10078 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
10079 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
10080 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
10082 * cs-parser.jay: Pass the `current_class', not the
10083 `current_container' (at the moment, this is still the same thing)
10084 to a new Method, Property, Event, Indexer or Constructor.
10086 2004-07-23 Martin Baulig <martin@ximian.com>
10088 * cs-parser.jay (CSharpParser): Added a new `current_class' field
10089 and removed the `current_interface' one.
10090 (struct_declaration, class_declaration, interface_declaration):
10091 Set `current_class' to the newly created class/struct/interface;
10092 set their `Bases' and call Register() before parsing their body.
10094 2004-07-23 Martin Baulig <martin@ximian.com>
10096 * class.cs (Kind): New public enum.
10097 (TypeContainer): Made this class abstract.
10098 (TypeContainer.Kind): New public readonly field.
10099 (TypeContainer.CheckDef): New public method; moved here from
10101 (TypeContainer.Register): New public abstract method.
10102 (TypeContainer.GetPendingImplementations): New public abstract
10104 (TypeContainer.GetClassBases): Removed the `is_class' and
10105 `is_iface' parameters.
10106 (TypeContainer.DefineNestedTypes): Formerly known as
10108 (ClassOrStruct): Made this class abstract.
10110 * tree.cs (RootTypes): New public type.
10112 2004-07-20 Martin Baulig <martin@ximian.com>
10114 * tree.cs (Tree.RecordNamespace): Removed.
10115 (Tree.Namespaces): Removed.
10117 * rootcontext.cs (RootContext.IsNamespace): Removed.
10119 * cs-parser.jay (namespace_declaration): Just create a new
10120 NamespaceEntry here.
10122 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
10124 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
10125 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
10126 entry to make sure it runs in the correct runtime version.
10128 2004-07-18 Martin Baulig <martin@ximian.com>
10130 * generic.cs (ConstructedType.CheckConstraints): Improved
10131 constraints checking.
10133 2004-07-18 Martin Baulig <martin@ximian.com>
10135 * expression.cs (Invocation.BetterMethod): Call
10136 TypeManager.TypeToCoreType() on all types and removed my previous
10137 hack; we're already doig the right thing here.
10139 2004-07-17 Martin Baulig <martin@ximian.com>
10141 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
10143 2004-07-16 Martin Baulig <martin@ximian.com>
10145 * iterators.cs: Added generics support.
10147 2004-07-16 Martin Baulig <martin@ximian.com>
10149 * iterators.cs: Rewrote this. We're now using one single Proxy
10150 class for both the IEnumerable and the IEnumerator interface and
10151 `Iterator' derives from Class so we can use the high-level API.
10153 * class.cs (TypeContainer.AddIterator): New method.
10154 (TypeContainer.DoDefineType): New protected virtual method, which
10155 is called from DefineType().
10156 (TypeContainer.DoDefineMembers): Call DefineType() and
10157 DefineMembers() on all our iterators.
10158 (TypeContainer.Emit): Call Emit() on all our iterators.
10159 (TypeContainer.CloseType): Call CloseType() on all our iterators.
10161 * codegen.cs (EmitContext.CurrentIterator): New public field.
10163 2004-07-15 Martin Baulig <martin@ximian.com>
10166 (TypeManager.not_supported_exception_type): New type.
10168 2004-07-14 Martin Baulig <martin@ximian.com>
10171 (TypeManager.generic_ienumerable_type): New type.
10172 (TypeManager.generic_ienumerator_type): New type.
10175 (RootContext.interfaces_first_stage): Added
10176 "System.Collections.Generic.IEnumerator`1" and
10177 "System.Collections.Generic.IEnumerable`1".
10179 2004-07-14 Martin Baulig <martin@ximian.com>
10181 * iterators.cs: Use real error numbers.
10183 2004-07-14 Martin Baulig <martin@ximian.com>
10185 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
10186 requires this to be a System.Collection.IEnumerable and not a
10187 class implementing that interface.
10188 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
10190 2004-07-13 Marek Safar <marek.safar@seznam.cz>
10192 * class.cs: Fixed previous fix, it broke some error tests.
10194 2004-07-12 Martin Baulig <martin@ximian.com>
10196 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
10199 2004-07-14 Martin Baulig <martin@ximian.com>
10201 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
10202 an exclamation mark (!) for the generic arity to reflect the
10203 latest spec changes; ie. use "System.Collections.Generic.IList`1".
10205 2004-07-13 Martin Baulig <martin@ximian.com>
10207 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
10208 specifiers being part of a type argument.
10210 2004-07-13 Martin Baulig <martin@ximian.com>
10212 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
10213 name for generic types.
10215 2004-07-13 Martin Baulig <martin@ximian.com>
10217 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
10220 2004-07-09 Miguel de Icaza <miguel@ximian.com>
10222 * assign.cs (LocalTemporary): Add new argument: is_address,If
10223 `is_address' is true, then the value that we store is the address
10224 to the real value, and not the value itself.
10226 * ecore.cs (PropertyExpr): use the new local temporary
10227 stuff to allow us to handle X.Y += z (where X is a struct)
10229 2004-07-08 Martin Baulig <martin@ximian.com>
10231 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
10232 not always return, just like we're doing in Using.Resolve().
10234 2004-07-07 Miguel de Icaza <miguel@ximian.com>
10236 * cs-parser.jay (fixed_statement): flag this as Pinned.
10238 2004-07-06 Miguel de Icaza <miguel@ximian.com>
10240 * typemanager.cs (TypeManager): Removed MakePinned method, this
10241 mechanism is replaced with the .NET 2.x compatible mechanism of
10242 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
10244 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
10245 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
10246 `IsFixed' property which has a different meaning.
10248 2004-07-02 Raja R Harinath <rharinath@novell.com>
10250 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
10251 visible from inside a nested class, not just the names of the
10252 immediately enclosing class.
10253 Fix for bug #60730.
10255 2004-06-24 Raja R Harinath <rharinath@novell.com>
10257 * expression.cs (BetterConversion): Remove buggy special-case
10258 handling of "implicit constant expression conversions". At this
10259 point, we already know that the conversion is possible -- we're
10260 only checking to see which is better.
10262 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10264 * cs-parser.jay: Added error CS0210 test.
10266 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10268 * cs-parser.jay: Added error CS0134 test.
10270 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10273 * cs-parser.jay: Added error CS0145 test.
10275 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10277 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
10279 2004-06-23 Ben Maurer <bmaurer@ximian.com>
10281 * expression.cs (StackAlloc.Resolve): The argument may not
10282 be a constant; deal with this case.
10284 2004-06-23 Marek Safar <marek.safar@seznam.cz>
10286 * attribute.cs (IndexerName_GetIndexerName): Renamed to
10287 GetIndexerAttributeValue.
10288 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
10290 * class.cs (Indexer.Define): Added error tests for CS0415,
10293 2004-06-23 Miguel de Icaza <miguel@ximian.com>
10295 * attribute.cs (Attribute.Resolve): Keep field code in sync with
10298 2004-06-23 Martin Baulig <martin@ximian.com>
10300 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
10301 neither return nor throw, reset the barrier as well. Fixes #60457.
10303 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
10305 * class.cs : EventAttributes is now set to None by default.
10306 This fixes bug #60459.
10308 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10311 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10312 Don't throw exception but return null (it's sufficient now).
10314 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10316 * typemanager.cs (GetArgumentTypes): Faster implementation.
10318 2004-06-18 Martin Baulig <martin@ximian.com>
10320 * attribute.cs (Attribute.Resolve): Check whether we're an
10321 EmptyCast which a Constant child. Fixes #60333.
10323 2004-06-17 Ben Maurer <bmaurer@ximian.com>
10325 * statement.cs (EmitCollectionForeach): Account for the fact that
10326 not all valuetypes are in areas which we can take the address of.
10327 For these variables, we store to a temporary variable. Also, make
10328 sure that we dont emit a `callvirt' on a valuetype method.
10330 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10332 * expression.cs (StackAlloc.DoReSolve): Added test for
10333 negative parameter (CS0247).
10335 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10338 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
10340 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10343 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
10346 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10348 Fix bug #58254 & cs1555.cs, cs1556.cs
10349 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
10351 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10353 * cs-parser.jay: Added error CS1669 test for indexers.
10355 2004-06-18 Martin Baulig <martin@ximian.com>
10357 * generics.cs (GenericMethod.ctor): Don't take an Attributes
10358 argument. Fixes #60441.
10360 2004-06-16 Ben Maurer <bmaurer@ximian.com>
10361 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
10362 The name needs to have the actual name of the method in order
10363 for other tests (such as the one in OverloadResolve for Invoke
10364 on a delegate) to work. As well, it does not really help
10365 error reporting because the method group had multiple methods.
10366 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
10367 Make profiling work.
10369 2004-06-13 Martin Baulig <martin@ximian.com>
10371 * cs-parser.jay: Don't allow generic attributes.
10373 2004-06-13 Martin Baulig <martin@ximian.com>
10375 * class.cs (MemberBase.DoDefineBase): New protected method.
10376 (MemberBase.DoDefine): Compute the `flags' in the new
10377 DoDefineBase() which must be called first.
10378 (Method.Define): Call DoDefineBase() first so we have the flags
10379 when defining the generic method.
10381 * cs-parser.jay (interface_method_declaration): Support generic methods.
10383 2004-06-13 Martin Baulig <martin@ximian.com>
10385 * decl.cs (TypeName): Removed.
10386 (MemberName): Removed TypeName and MemberNow; now we just have
10389 * cs-parser.jay: Don't distinguish between type arguments and type
10390 parameters in the grammar and simplified the rules a bit. The
10391 reduce/reduce conflicts are now gone (except the one we inherited
10394 2004-06-11 Martin Baulig <martin@ximian.com>
10396 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
10397 call this twice: for params and varargs methods.
10399 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10402 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
10404 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10406 * attribute.cs (Attribute.GetValidTargets): Made public.
10409 (AbstractPropertyEventMethod): New class for better code sharing.
10410 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
10412 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
10414 2004-06-09 Martin Baulig <martin@ximian.com>
10416 * cs-parser.jay: Removed a reduce/reduce conflict.
10418 2004-06-03 Martin Baulig <martin@ximian.com>
10420 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
10421 GetSimpleName() and return a SimpleName.
10423 * ecore.cs (SimpleName.Arguments): New public field.
10424 (SimpleName): Added overloaded ctor which takes an additional
10425 TypeArguments argument.
10426 (SimpleName.SimpleNameResolve): Added support for generic methods.
10427 (MethodGroupExpr.ResolveGeneric): New public method. The code was
10428 formerly in MemberAccess.DoResolve(), but we also need it in
10429 SimpleNameResolve().
10431 * expression.cs (MemberAccess.DoResolve): Use the new
10432 MethodGroupExpr.ResolveGeneric().
10434 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10436 * decl.cs: If possible, use lookuptypedirect here. We can only do
10437 this if there is no `.' after the namespace. Avoids using
10438 LookupType, which does lots of slow processing.
10439 (FindNestedType) New method, does what it says :-).
10440 * namespace.cs: use LookupTypeDirect.
10441 * rootcontext.cs: use membercache, if possible.
10442 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10444 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10447 According to the spec,
10449 In a member access of the form E.I, if E is a single identifier,
10450 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10451 field, property, localvariable, or parameter with the same type as
10452 the meaning of E as a type-name (§3.8), then both possible
10453 meanings of E are permitted.
10455 We did not check that E as a simple-name had the same type as E as
10458 This trivial check gives us 5-7% on bootstrap time.
10460 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10462 * expression.cs (Invocation.OverloadResolve): Avoid the
10463 use of hashtables and boxing here by allocating on demand.
10465 2004-05-30 Martin Baulig <martin@ximian.com>
10467 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10468 we're doing a silent lookup. Don't try to lookup nested types in
10469 TypeManager.object_type (thanks to Ben Maurer).
10471 2004-05-30 Martin Baulig <martin@ximian.com>
10473 Committing a patch from Ben Maurer.
10475 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10477 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10479 * convert.cs: add a trivial cache for overload operator resolution.
10481 2004-05-31 Marek Safar <marek.safar@seznam.cz>
10484 (AttributeTester.GetObsoleteAttribute): Returns instance of
10485 ObsoleteAttribute when type is obsolete.
10488 (TypeContainer.VerifyObsoleteAttribute): Override.
10489 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
10490 (MethodCode.VerifyObsoleteAttribute): Override.
10491 (MemberBase.VerifyObsoleteAttribute): Override.
10494 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
10495 and report proper error.
10498 (Delegate.VerifyObsoleteAttribute): Override.
10501 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
10502 and report proper error.
10503 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
10506 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
10510 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
10511 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
10512 Added test for ObsoleteAttribute.
10515 (Catch): Derived from Statement.
10517 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10519 * decl.cs: If possible, use lookuptypedirect here. We can only do
10520 this if there is no `.' after the namespace. Avoids using
10521 LookupType, which does lots of slow processing.
10522 (FindNestedType) New method, does what it says :-).
10523 * namespace.cs: use LookupTypeDirect.
10524 * rootcontext.cs: use membercache, if possible.
10525 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10527 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10530 According to the spec,
10532 In a member access of the form E.I, if E is a single identifier,
10533 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10534 field, property, localvariable, or parameter with the same type as
10535 the meaning of E as a type-name (§3.8), then both possible
10536 meanings of E are permitted.
10538 We did not check that E as a simple-name had the same type as E as
10541 This trivial check gives us 5-7% on bootstrap time.
10543 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10545 Fixed bug #59071 & cs0160.cs
10546 * statement.cs (Try.Resolve): Check here whether order of catch
10547 clauses matches their dependencies.
10549 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10552 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
10555 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10557 * expression.cs (Invocation.OverloadResolve): Avoid the
10558 use of hashtables and boxing here by allocating on demand.
10560 2004-05-30 Martin Baulig <martin@ximian.com>
10562 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10563 we're doing a silent lookup. Don't try to lookup nested types in
10564 TypeManager.object_type (thanks to Ben Maurer).
10566 2004-05-30 Martin Baulig <martin@ximian.com>
10568 Committing a patch from Ben Maurer.
10570 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10572 2004-05-29 Martin Baulig <martin@ximian.com>
10574 * class.cs (IMethodData.ShouldIgnore): New method.
10576 * typemanager.cs (TypeManager.MethodFlags): Don't take a
10577 `Location' argument, we don't need it anywhere. Use
10578 `IMethodData.ShouldIgnore ()' instead of
10579 `MethodData.GetMethodFlags ()'.
10580 (TypeManager.AddMethod): Removed.
10581 (TypeManager.AddMethod2): Renamed to AddMethod.
10583 2004-05-29 Martin Baulig <martin@ximian.com>
10585 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
10587 * convert.cs (Convert.ImplicitReferenceConversion): If we're
10588 converting from a class type S to an interface type and we already
10589 have an object on the stack, don't box it again. Fixes #52578.
10591 2004-05-29 Martin Baulig <martin@ximian.com>
10593 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10594 Added support for `params' parameters. Fixes #59267.
10596 2004-05-29 Martin Baulig <martin@ximian.com>
10598 * literal.cs (NullPointer): Provide a private .ctor which sets
10599 `type' to TypeManager.object_type. Fixes #59048.
10601 2004-05-29 Martin Baulig <martin@ximian.com>
10603 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
10604 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
10606 * ecore.cs (EventExpr.instance_expr): Make the field private.
10608 2004-05-26 Marek Safar <marek.safar@seznam.cz>
10610 Fixed bug #50080 & cs0214-2.cs
10611 * expression.cs (Cast.DoResolve): Check unsafe context here.
10613 * statement.cs (Resolve.DoResolve): Likewise.
10615 2004-05-26 Martin Baulig <martin@ximian.com>
10617 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
10619 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
10620 (RootContext.LookupType): Pass down the `silent' flag.
10622 2004-05-25 Martin Baulig <martin@ximian.com>
10625 (MethodGroupExpr.IdenticalTypeName): New public property.
10626 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
10627 expression actually refers to a type.
10629 2004-05-25 Martin Baulig <martin@ximian.com>
10631 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
10632 for #56176 and made it actually work.
10634 2004-05-25 Martin Baulig <martin@ximian.com>
10636 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
10637 (FieldExpr, PropertyExpr): Override and implement
10638 CacheTemporaries. Fixes #52279.
10640 2004-05-25 Miguel de Icaza <miguel@ximian.com>
10642 * location.cs: In the new compiler listing a file twice is a
10643 warning, not an error.
10645 2004-05-24 Martin Baulig <martin@ximian.com>
10647 * enum.cs (Enum.DefineType): For the `BaseType' to be a
10648 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
10650 2004-05-24 Martin Baulig <martin@ximian.com>
10652 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
10653 walking the `using' list. Fixes #53921.
10655 2004-05-24 Martin Baulig <martin@ximian.com>
10657 * const.cs (Const.LookupConstantValue): Added support for
10658 EmptyCast's; fixes #55251.
10660 2004-05-24 Martin Baulig <martin@ximian.com>
10662 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
10663 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
10664 which does the CS0135 check. The reason is that we first need to
10665 check whether the variable actually exists.
10667 2004-05-24 Martin Baulig <martin@ximian.com>
10669 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
10670 than RootContext.LookupType() to find the explicit interface
10671 type. Fixes #58584.
10673 2004-05-24 Raja R Harinath <rharinath@novell.com>
10675 * Makefile: Simplify. Use executable.make.
10676 * mcs.exe.sources: New file. List of sources of mcs.exe.
10678 2004-05-24 Anders Carlsson <andersca@gnome.org>
10682 Use the invariant culture when doing String.Compare for CLS case
10685 2004-05-23 Martin Baulig <martin@ximian.com>
10687 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
10688 don't have any dots. Fixes #52622, added cs0246-8.cs.
10690 * namespace.cs (NamespaceEntry.Lookup): Likewise.
10692 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10694 * class.cs (MemberBase.Define): Reuse MemberType member for
10695 resolved type. Other methods can use it too.
10697 2004-05-23 Martin Baulig <martin@ximian.com>
10699 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
10700 the variable also exists in the current block (otherwise, we need
10701 to report a CS0103). Fixes #58670.
10703 2004-05-23 Martin Baulig <martin@ximian.com>
10705 * flowanalysis.cs (Reachability.Reachable): Compute this
10706 on-the-fly rather than storing it as a field.
10708 2004-05-23 Martin Baulig <martin@ximian.com>
10710 * flowanalysis.cs (Reachability.And): Manually compute the
10711 resulting `barrier' from the reachability.
10713 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10716 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
10717 instance of ObsoleteAttribute when symbol is obsolete.
10720 (IMethodData): Extended interface for ObsoleteAttribute support.
10722 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10724 * attribute.cs: Fix bug #55970
10726 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10730 (GetObsoleteAttribute): New method. Creates the instance of
10732 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
10733 ObsoleteAttribute when member is obsolete.
10734 (AttributeTester.Report_ObsoleteMessage): Common method for
10735 Obsolete error/warning reporting.
10738 (TypeContainer.base_classs_type): New member for storing parent type.
10741 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
10742 for this MemberCore.
10744 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10746 * attribute.cs, const.cs: Fix bug #58590
10748 2004-05-21 Martin Baulig <martin@ximian.com>
10750 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
10751 out parameters if the end of the method is unreachable. Fixes
10754 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10756 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
10757 Hari was right, why extra method.
10759 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10761 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
10763 2004-05-20 Martin Baulig <martin@ximian.com>
10765 * delegate.cs: Convert this file to Unix mode - like the original
10768 2004-05-20 Martin Baulig <martin@ximian.com>
10770 * attribute.cs: Convert this file to Unix mode - like the original
10773 2004-05-19 Marek Safar <marek.safar@seznam.cz>
10775 Fix bug #58688 (MCS does not report error when the same attribute
10778 * attribute.cs (Attribute.Emit): Distinction between null and default.
10780 2004-05-19 Raja R Harinath <rharinath@novell.com>
10782 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
10783 of a top-level attribute without an attribute target.
10784 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
10786 (Attribute.Conditional_GetConditionName),
10787 (Attribute.Obsolete_GetObsoleteMessage): Update.
10788 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
10789 part of ScanForIndexerName.
10790 (Attribute.CanIgnoreInvalidAttribute): New function.
10791 (Attribute.ScanForIndexerName): Move to ...
10792 (Attributes.ScanForIndexerName): ... here.
10793 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
10794 (Attributes.Search): New internal variant that can choose not to
10795 complain if types aren't resolved. The original signature now
10797 (Attributes.GetClsCompliantAttribute): Use internal variant, with
10798 complaints suppressed.
10799 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
10800 only if it not useful.
10801 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
10802 top-level for attributes that are shared between the assembly
10803 and a top-level class.
10804 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
10805 * class.cs: Update to reflect changes.
10806 (DefineIndexers): Fuse loops.
10807 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
10808 a couple more variants of attribute names.
10810 2004-05-18 Marek Safar <marek.safar@seznam.cz>
10812 Fix bug #52585 (Implemented explicit attribute declaration)
10815 (Attributable.ValidAttributeTargets): New abstract method. It gets
10816 list of valid attribute targets for explicit target declaration.
10817 (Attribute.Target): It holds target itself.
10818 (AttributeSection): Removed.
10819 (Attribute.CheckTargets): New method. It checks whether attribute
10820 target is valid for the current element.
10823 (EventProperty): New class. For events that are declared like
10824 property (with add and remove accessors).
10825 (EventField): New class. For events that are declared like field.
10828 * cs-parser.jay: Implemented explicit attribute target declaration.
10830 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
10831 Override ValidAttributeTargets.
10834 (ReturnParameter): Class for applying custom attributes on
10836 (ParameterAtribute): New class. Class for applying custom
10837 attributes on the parameter type.
10839 2004-05-17 Miguel de Icaza <miguel@ximian.com>
10841 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
10844 (Method): Allow UNSAFE here.
10846 * modifiers.cs: Support unsafe reporting.
10848 2004-05-17 Marek Safar <marek.safar@seznam.cz>
10850 * decl.cs: Fix bug #58478.
10852 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10854 * statement.cs: When checking for unreachable code on an EmptyStatement,
10855 set the location. Fixes bug #58488.
10857 2004-05-13 Miguel de Icaza <miguel@ximian.com>
10859 * driver.cs: Add -pkg handling.
10861 From Gonzalo: UseShelLExecute=false
10863 2004-05-12 Marek Safar <marek.safar@seznam.cz>
10866 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
10868 (Attribute.IsClsCompliaceRequired): Moved to base for better
10870 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
10871 when attribute is AttributeUsageAttribute.
10872 (Attribute.GetValidTargets): Simplified.
10873 (Attribute.GetAttributeUsage): New method returns AttributeUsage
10874 attribute for this type.
10875 (Attribute.ApplyAttributes): Method renamed to Emit and make
10877 (GlobalAttributeSection): New class for special handling of global
10878 attributes (assembly, module).
10879 (AttributeSection.Emit): New method.
10881 * class.cs: Implemented Attributable abstract methods.
10882 (MethodCore.LabelParameters): Moved to Parameter class.
10883 (Accessor): Is back simple class.
10884 (PropertyMethod): Implemented Attributable abstract class.
10885 (DelegateMethod): Implemented Attributable abstract class.
10886 (Event): New constructor for disctintion between normal Event
10887 and Event with accessors.
10889 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
10891 * codegen.cs, const.cs, decl.cs, delegate.cs:
10892 (CommonAssemblyModulClass): Implemented Attributable abstract class
10895 * enum.cs: Implement IAttributeSupport interface.
10896 (EnumMember): New class for emum members. Implemented Attributable
10900 (ParameterBase): Is abstract.
10901 (ReturnParameter): New class for easier [return:] attribute handling.
10903 * typemanager.cs: Removed builder_to_attr.
10905 2004-05-11 Raja R Harinath <rharinath@novell.com>
10908 * attribute.cs (Attribute.GetPositionalValue): New function.
10909 * class.cs (TypeContainer.VerifyMembers): New function.
10910 (TypeContainer.Emit): Use it.
10911 (ClassOrStruct): New base class for Class and Struct.
10912 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
10913 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
10915 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
10916 then each non-static field should have a FieldOffset attribute.
10917 Otherwise, none of the fields should have a FieldOffset attribute.
10918 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
10919 and FieldOffset attributes.
10920 * typemanager.cs (TypeManager.struct_layout_attribute_type)
10921 (TypeManager.field_offset_attribute_type): New core types.
10922 (TypeManager.InitCoreTypes): Initialize them.
10924 2004-05-11 Michal Moskal <malekith@pld-linux.org>
10926 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
10927 Return correct type.
10930 2004-05-09 Miguel de Icaza <miguel@ximian.com>
10932 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
10933 be implicitly converted to ulong.
10935 * expression.cs: The logic for allowing operator &, | and ^ worked
10936 was wrong, it worked before because we did not report an error in
10937 an else branch. Fixes 57895.
10939 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
10940 allow volatile fields to be reference types.
10942 2004-05-07 Miguel de Icaza <miguel@ximian.com>
10944 * driver.cs: Add support for /debug-
10946 2004-05-07 Raja R Harinath <rharinath@novell.com>
10948 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
10949 Add a 'complain' parameter to silence errors.
10950 (Attribute.Resolve): Update to changes. Put in sanity check to catch
10951 silently overlooked type-resolutions.
10952 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
10953 to reflect changes.
10954 (Attributes.Search): New function.
10955 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
10956 (Attributes.GetAttributeFullName): Remove hack.
10957 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
10958 Update to reflect changes.
10959 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10960 Use Attributes.Search instead of nested loops.
10962 2004-05-07 Marek Safar <marek.safar@seznam.cz>
10965 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
10966 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
10967 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
10969 * report.cs: (Report.Warning): Renamed to Warning_T because of
10970 parameter collision.
10972 2004-05-05 Raja R Harinath <rharinath@novell.com>
10974 * expression.cs (MemberAccess.ResolveMemberAccess):
10975 Exit with non-zero status after Report.Error.
10976 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
10978 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
10980 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
10982 * support.cs: Don't hang when the file is empty.
10984 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
10986 * support.cs: In SeekableStreamReader, compute the preamble size of the
10987 underlying stream. Position changes should take into account that initial
10990 2004-05-03 Todd Berman <tberman@sevenl.net>
10992 * driver.cs: remove unused GetSysVersion function.
10994 2004-05-03 Todd Berman <tberman@sevenl.net>
10996 * driver.cs: Remove the hack from saturday, as well as the hack
10997 from jackson (LoadAssemblyFromGac), also adds the CWD to the
10998 link_paths to get that bit proper.
11000 2004-05-01 Todd Berman <tberman@sevenl.net>
11002 * driver.cs: Try a LoadFrom before a Load, this checks the current
11003 path. This is currently a bug in mono that is be fixed, however, this
11004 provides a workaround for now. This will be removed when the bug
11007 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
11009 * CryptoConvert.cs: Updated to latest version. Fix issue with
11010 incomplete key pairs (#57941).
11012 2004-05-01 Todd Berman <tberman@sevenl.net>
11014 * driver.cs: Remove '.' from path_chars, now System.* loads properly
11017 2004-04-30 Jackson Harper <jackson@ximian.com>
11019 * codegen.cs: Open keys readonly.
11021 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11023 * typemanager.cs: don't report cyclic struct layout when a struct
11024 contains 2 or more fields of the same type. Failed for Pango.AttrShape
11025 which has 2 Pango.Rectangle fields.
11027 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
11029 * expression.cs: Handle IntPtr comparisons with IL code
11030 rather than a method call.
11032 2004-04-29 Martin Baulig <martin@ximian.com>
11034 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
11035 the list of PropertyInfo's in class hierarchy and find the
11036 accessor. Fixes #56013.
11038 2004-04-29 Martin Baulig <martin@ximian.com>
11040 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
11042 2004-04-29 Martin Baulig <martin@ximian.com>
11044 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11046 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
11048 2004-04-29 Martin Baulig <martin@ximian.com>
11050 * class.cs (ConstructorInitializer.Resolve): Check whether the
11051 parent .ctor is accessible. Fixes #52146.
11053 2004-04-29 Martin Baulig <martin@ximian.com>
11055 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11057 * statement.cs (Using.EmitLocalVariableDecls): Use
11058 TypeManager.idisposable_type, not typeof (IDisposable).
11059 (Foreach.EmitCollectionForeach): Added support for valuetypes.
11061 2004-04-29 Martin Baulig <martin@ximian.com>
11063 * class.cs (Event.Define): Don't emit the field and don't set
11064 RTSpecialName and SpecialName for events on interfaces. Fixes
11067 2004-04-29 Raja R Harinath <rharinath@novell.com>
11069 Refactor Attribute.ApplyAttributes.
11070 * attribute.cs (Attributable): New base class for objects that can
11071 have Attributes applied on them.
11072 (Attribute): Make AttributeUsage fields public.
11073 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
11074 (Attribute.IsInternalCall): New property.
11075 (Attribute.UsageAttr): Convert to a public read-only property.
11076 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
11077 (Attribute.ResolveType, Attribute.Resolve)
11078 (Attribute.ScanForIndexerName): Update to reflect changes.
11079 (Attribute.CheckAttributeTarget): Re-format.
11080 (Attribute.ApplyAttributes): Refactor, to various
11081 Attributable.ApplyAttributeBuilder methods.
11082 * decl.cs (MemberCore): Make Attributable.
11083 * class.cs (Accessor): Make Attributable.
11084 (MethodData.ApplyAttributes): Use proper attribute types, not
11086 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
11087 (TypeContainer.ApplyAttributeBuilder)
11088 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
11089 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
11090 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
11091 (Operator.ApplyAttributeBuilder): New factored-out methods.
11092 * const.cs (Const.ApplyAttributeBuilder): Likewise.
11093 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
11094 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
11095 * parameter.cs (ParameterBase): New Attributable base class
11096 that can also represent Return types.
11097 (Parameter): Update to the changes.
11099 2004-04-29 Jackson Harper <jackson@ximian.com>
11101 * driver.cs: Prefer the corlib system version when looking for
11102 assemblies in the GAC. This is still a hack, but its a better hack
11105 2004-04-29 Marek Safar <marek.safar@seznam.cz>
11107 * decl.cs, enum.cs: Improved error 3005 reporting.
11109 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
11110 (related_symbols): New private member for list of symbols
11111 related to reported error/warning.
11113 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
11115 2004-04-29 Martin Baulig <martin@ximian.com>
11117 * ecore.cs (Expression.Constantify): If we're an enum and
11118 TypeManager.TypeToCoreType() doesn't give us another type, use
11119 t.UnderlyingSystemType. Fixes #56178.
11121 2004-04-29 Martin Baulig <martin@ximian.com>
11123 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
11124 interfaces and for each interface, only add members directly
11125 declared in that interface. Fixes #53255.
11127 2004-04-28 Martin Baulig <martin@ximian.com>
11129 * expression.cs (ConditionalLogicalOperator): Use a temporary
11130 variable for `left' to avoid that we evaluate it more than once;
11133 2004-04-28 Martin Baulig <martin@ximian.com>
11135 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
11138 2004-04-28 Martin Baulig <martin@ximian.com>
11140 * statement.cs (LocalInfo.Resolve): Check whether the type is not
11143 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
11144 whether the type is not void (CS1547).
11146 2004-04-28 Martin Baulig <martin@ximian.com>
11148 * expression.cs (Unary.DoResolveLValue): Override this and report
11149 CS0131 for anything but Operator.Indirection.
11151 2004-04-28 Martin Baulig <martin@ximian.com>
11153 Committing a patch from Ben Maurer; see bug #50820.
11155 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11158 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11161 2004-04-28 Martin Baulig <martin@ximian.com>
11163 Committing a patch from Ben Maurer; see bug #50820.
11165 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11168 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11171 2004-04-28 Martin Baulig <martin@ximian.com>
11173 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
11174 (Block.AddLabel): Call DoLookupLabel() to only search in the
11177 2004-04-28 Martin Baulig <martin@ximian.com>
11179 * cfold.cs (ConstantFold.BinaryFold): Added special support for
11180 comparing StringConstants and NullLiterals in Equality and Inequality.
11182 2004-04-28 Jackson Harper <jackson@ximian.com>
11184 * driver.cs: Attempt to load referenced assemblies from the
11185 GAC. This is the quick and dirty version of this method that
11186 doesnt take into account versions and just takes the first
11187 canidate found. Will be good enough for now as we will not have more
11188 then one version installed into the GAC until I update this method.
11190 2004-04-28 Martin Baulig <martin@ximian.com>
11192 * typemanager.cs (TypeManager.CheckStructCycles): New public
11193 static method to check for cycles in the struct layout.
11195 * rootcontext.cs (RootContext.PopulateTypes): Call
11196 TypeManager.CheckStructCycles() for each TypeContainer.
11197 [Note: We only need to visit each type once.]
11199 2004-04-28 Martin Baulig <martin@ximian.com>
11201 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
11203 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
11204 success and added `out object value'. Use a `bool resolved' field
11205 to check whether we've already been called rather than
11206 `ConstantValue != null' since this breaks for NullLiterals.
11208 2004-04-28 Raja R Harinath <rharinath@novell.com>
11210 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
11211 setting of this flag, since the 'set' method may be non-public.
11213 2004-04-28 Raja R Harinath <rharinath@novell.com>
11215 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
11216 check on current_vector.Block.
11218 2004-04-27 Martin Baulig <martin@ximian.com>
11220 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
11221 a field initializer. Fixes #56459.
11223 2004-04-27 Martin Baulig <martin@ximian.com>
11225 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
11226 we're not attempting to use an indexer. Fixes #52154.
11228 2004-04-27 Martin Baulig <martin@ximian.com>
11230 * statement.cs (Return): Don't create a return label if we don't
11231 need it; reverts my change from January 20th. Thanks to Ben
11234 2004-04-27 Martin Baulig <martin@ximian.com>
11236 According to the spec, `goto' can only leave a nested scope, but
11239 * statement.cs (Block.LookupLabel): Only lookup in the current
11240 block, don't recurse into parent or child blocks.
11241 (Block.AddLabel): Check in parent and child blocks, report
11242 CS0140/CS0158 if we find a duplicate.
11243 (Block): Removed this indexer for label lookups.
11244 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
11245 this already does the error reporting for us.
11248 (FlowBranching.UsageVector.Block): New public variable; may be null.
11249 (FlowBranching.CreateSibling): Added `Block' argument.
11250 (FlowBranching.LookupLabel): New public virtual method. Lookup a
11251 label for the target of a `goto' and check whether we're not
11252 leaving a `finally'.
11254 2004-04-27 Martin Baulig <martin@ximian.com>
11256 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11257 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
11260 2004-04-27 Martin Baulig <martin@ximian.com>
11262 * statement.cs (Block.AddLabel): Also check for implicit blocks
11263 and added a CS0158 check.
11265 2004-04-27 Martin Baulig <martin@ximian.com>
11267 * flowanalysis.cs (FlowBranchingLoop): New class.
11268 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
11269 UsageVector's instead of an ArrayList.
11270 (FlowBranching.Label): Likewise.
11271 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
11272 (FlowBranching.AddBreakVector): New method.
11274 2004-04-27 Miguel de Icaza <miguel@ximian.com>
11276 * attribute.cs: Small regression fix: only convert the type if we
11277 the type is different, fixes System.Drawing build.
11279 2004-04-27 Martin Baulig <martin@ximian.com>
11281 * attribute.cs (Attribute.Resolve): If we have a constant value
11282 for a named field or property, implicity convert it to the correct
11285 2004-04-27 Raja R Harinath <rharinath@novell.com>
11287 * statement.cs (Block.Block): Implicit blocks share
11288 'child_variable_names' fields with parent blocks.
11289 (Block.AddChildVariableNames): Remove.
11290 (Block.AddVariable): Mark variable as "used by a child block" in
11291 every surrounding block.
11292 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
11293 been used in a child block, complain about violation of "Invariant
11294 meaning in blocks" rule.
11295 * cs-parser.jay (declare_local_variables): Don't use
11296 AddChildVariableNames.
11297 (foreach_statement): Don't create an implicit block: 'foreach'
11298 introduces a scope.
11300 2004-04-23 Miguel de Icaza <miguel@ximian.com>
11302 * convert.cs (ImplicitNumericConversion): 0 is also positive when
11303 converting from 0L to ulong. Fixes 57522.
11305 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11307 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
11308 derived class hides via 'new' keyword field from base class (test-242.cs).
11309 TODO: Handle this in the more general way.
11311 * class.cs (CheckBase): Ditto.
11313 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11315 * decl.cs (caching_flags): New member for storing cached values
11317 (MemberCore.Flags): New enum where bit flags for caching_flags
11319 (MemberCore.cls_compliance): Moved to caching_flags.
11320 (DeclSpace.Created): Moved to caching_flags.
11322 * class.cs: Use caching_flags instead of DeclSpace.Created
11324 2004-04-21 Miguel de Icaza <miguel@ximian.com>
11326 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
11327 if we are only a derived class, not a nested class.
11329 * typemanager.cs: Same as above, but do this at the MemberLookup
11330 level (used by field and methods, properties are handled in
11331 PropertyExpr). Allow for the qualified access if we are a nested
11334 2004-04-21 Marek Safar <marek.safar@seznam.cz>
11336 * class.cs: Refactoring.
11337 (IMethodData): New inteface; Holds links to parent members
11338 to avoid member duplication (reduced memory allocation).
11339 (Method): Implemented IMethodData interface.
11340 (PropertyBase): New inner classes for get/set methods.
11341 (PropertyBase.PropertyMethod): Implemented IMethodData interface
11342 (Event): New inner classes for add/remove methods.
11343 (Event.DelegateMethod): Implemented IMethodData interface.
11345 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
11346 EmitContext (related to class.cs refactoring).
11348 2004-04-21 Raja R Harinath <rharinath@novell.com>
11350 * delegate.cs (Delegate.VerifyApplicability): If the number of
11351 arguments are the same as the number of parameters, first try to
11352 verify applicability ignoring any 'params' modifier on the last
11356 2004-04-08 Martin Baulig <martin@ximian.com>
11358 Merged latest changes into gmcs. Please keep this comment in
11359 here, it makes it easier for me to see what changed in MCS since
11360 the last time I merged.
11362 2004-04-16 Raja R Harinath <rharinath@novell.com>
11364 * class.cs (TypeContainer.AddIndexer): Use
11365 'ExplicitInterfaceName' to determine if interface name was
11366 explicitly specified. 'InterfaceType' is not initialized at this time.
11367 (TypeContainer.DefineIndexers): Remove use of temporary list. The
11368 Indexers array is already in the required order. Initialize
11369 'IndexerName' only if there are normal indexers.
11370 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
11371 (TypeContainer.Emit): Emit DefaultMember attribute only if
11372 IndexerName is initialized.
11375 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
11377 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
11380 2004-04-15 Raja R Harinath <rharinath@novell.com>
11382 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
11386 * attribute.cs (Attribute.Resolve): Check for duplicate named
11390 2004-04-15 Miguel de Icaza <miguel@ximian.com>
11392 * iterators.cs (MarkYield): track whether we are in an exception,
11393 and generate code accordingly. Use a temporary value to store the
11394 result for our state.
11396 I had ignored a bit the interaction of try/catch with iterators
11397 since their behavior was not entirely obvious, but now it is
11398 possible to verify that our behavior is the same as MS .NET 2.0
11402 2004-04-14 Miguel de Icaza <miguel@ximian.com>
11404 * iterators.cs: Avoid creating temporaries if there is no work to
11407 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
11408 Enumerations, use TypeManager.EnumToUnderlying and call
11411 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
11414 (This.Emit): Use EmitContext.EmitThis to emit our
11417 (This.EmitAssign): Ditto.
11419 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
11420 codepaths, we will move all the functionality into
11423 (FieldExpr.EmitAssign): Ditto.
11425 This fixes several hidden bugs that I uncovered while doing a code
11426 review of this today.
11428 * codegen.cs (EmitThis): reworked so the semantics are more clear
11429 and also support value types "this" instances.
11431 * iterators.cs: Changed so that for iterators in value types, we
11432 do not pass the value type as a parameter.
11434 Initialization of the enumerator helpers is now done in the caller
11435 instead of passing the parameters to the constructors and having
11436 the constructor set the fields.
11438 The fields have now `assembly' visibility instead of private.
11440 2004-04-11 Miguel de Icaza <miguel@ximian.com>
11442 * expression.cs (Argument.Resolve): Check if fields passed as ref
11443 or out are contained in a MarshalByRefObject.
11445 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
11446 another compiler type.
11448 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
11450 * class.cs (Indexer.Define): use the new name checking method.
11451 Also, return false on an error.
11452 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
11453 (is_identifier_[start/part]_character): make static.
11455 2004-04-10 Miguel de Icaza <miguel@ximian.com>
11457 * expression.cs (Binary.ResolveOperator): Do no append strings
11458 twice: since we can be invoked more than once (array evaluation)
11459 on the same concatenation, take care of this here. Based on a fix
11460 from Ben (bug #56454)
11462 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11464 * codegen.cs: Fix another case where CS1548 must be reported (when
11465 delay-sign isn't specified and no private is available #56564). Fix
11466 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11467 error when MCS is used on the MS runtime and we need to delay-sign
11468 (which seems unsupported by AssemblyBuilder - see #56621).
11470 2004-04-08 Marek Safar <marek.safar@seznam.cz>
11472 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
11473 (TypeManager.ComputeNamespaces): Faster implementation for
11476 * compiler.csproj: Updated AssemblyName to mcs.
11478 2004-05-11 Jackson Harper <jackson@ximian.com>
11480 * Makefile: Preserve MONO_PATH
11482 2004-05-11 Jackson Harper <jackson@ximian.com>
11484 * Makefile: Use mono and mcs to build gmcs
11486 2004-05-03 Miguel de Icaza <miguel@ximian.com>
11488 * codegen.cs: Add patch from Robert Shade
11489 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
11492 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
11494 * CryptoConvert.cs: Updated to latest version. Fix issue with
11495 incomplete key pairs (#57941).
11497 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11499 * codegen.cs: Fix another case where CS1548 must be reported (when
11500 delay-sign isn't specified and no private is available #56564). Fix
11501 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11502 error when MCS is used on the MS runtime and we need to delay-sign
11503 (which seems unsupported by AssemblyBuilder - see #56621).
11505 2004-04-29 Jackson Harper <jackson@ximian.com>
11507 * Makefile: Set MONO_PATH to use the bootstrap corlib
11508 * driver.cs: Check the GAC for referenced assemblies.
11510 2004-04-29 Martin Baulig <martin@ximian.com>
11512 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
11514 2004-04-07 Martin Baulig <martin@ximian.com>
11516 * expression.cs (Binary.ResolveOperator): Added special case for
11517 Equality/Inequality between a type parameter and a null literal.
11519 2004-04-07 Martin Baulig <martin@ximian.com>
11521 * convert.cs: Check null literal -> type parameter conversions.
11523 2004-04-07 Martin Baulig <martin@ximian.com>
11525 * generic.cs (ConstructedType.CheckConstraints): Enforce the
11526 `class' and `struct' constraints.
11528 2004-04-07 Martin Baulig <martin@ximian.com>
11530 * generic.cs (SpecialConstraint): New public enum.
11531 (Constraints.Resolve): Added support for the `class' and `struct'
11534 * cs-parser.jay (type_parameter_constraint): Added support for the
11535 `class' and `struct' constraints.
11537 2004-04-07 Martin Baulig <martin@ximian.com>
11539 * support.cs (GenericConstraints): Replaced `Types' by
11540 `ClassConstraint' and `InterfaceConstraints'; added
11541 `HasClassConstraint'.
11543 2004-04-07 Martin Baulig <martin@ximian.com>
11546 (Constraints.InterfaceConstraints): New public property.
11547 (Constraints.Types): Make this property public
11548 (TypeParameter): Implement IMemberContainer.
11549 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
11550 instead of a TypeBuilder/MethodBuilder; pass the interface
11551 constraints to TypeManager.AddTypeParameter().
11552 (TypeParameter.DefineType): Just take an EmitContext and no
11553 TypeBuilder/MethodBuilder. Use the new public API.
11555 * typemanager.cs (TypeManager.AddTypeParameter): Added
11556 `TypeExpr[]' argument; add the interfaces to the
11557 `builder_to_ifaces' hash.
11558 (TypeManager.LookupMemberContainer): For
11559 GenericTypeParameterBuilders, get the TypeParameter from the
11560 `builder_to_type_param'.
11561 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
11562 the TypeParameter and call FindMembers on it.
11564 2004-04-07 Martin Baulig <martin@ximian.com>
11567 (MethodCore.GenericMethod): Moved this field here from Method.
11568 (MethodCore.IsDuplicateImplementation): Take the number of type
11569 parameters into account if we're a generic method.
11571 * expression.cs (Invocation.InferTypeArguments): Don't return true
11572 if `arguments' is null; we still need to check whether we actually
11573 don't need to infer anything in this case.
11574 (MemberAccess): Merged the functionality from GenericMemberAccess
11577 * generic.cs (GenericMemberAccess): Removed.
11579 2004-04-05 Martin Baulig <martin@ximian.com>
11581 * decl.cs (MemberCore): For generic classes, interfaces and
11582 structs, `Name' now includes the number of type parameters
11583 ("Stack!1.Node!1").
11584 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
11585 encode the number of type arguments in the type name.
11587 * expression.cs (Expression.MemberLookup): Removed the
11588 `num_type_args' argument; we now encode the number of type
11589 arguments in the type name.
11591 * ecore.cs (SimpleName): Encode the number of type arguments in
11592 the type name itself.
11594 * generic.cs (ConstructedType): Likewise.
11596 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
11597 `MemberName'; we now include the number of type parameters in the
11600 * typemanager.cs (TypeManager.CheckGeneric): Removed.
11601 (TypeManager.MemberLookup): Removed the
11602 `num_type_args' argument; we now encode the number of type
11603 arguments in the type name.
11605 2004-04-03 Martin Baulig <martin@ximian.com>
11607 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
11608 (MemberCore.MemberName): Moved here from MemberBase.
11609 (DeclSpace.SetParameterInfo): Just take the constraints as an
11610 ArrayList; we already have the type parameters in our
11611 `MemberName'; also do the CS0080 reporting here.
11613 * cs-parser.jay (struct_declaration): Use `member_name' instead of
11614 `IDENTIFIER opt_type_parameter_list'; when constructing our
11615 `MemberName', it'll already include our type parameters.
11616 (class_declaration, interface_declaration): Likewise.
11617 (delegate_declaration): Likewise.
11618 (MakeName): Take a MemberName and return a MemberName.
11619 The following two changes are required to avoid shift/reduce conflicts:
11620 (member_name): Don't include a TypeName anymore; ie. this is now
11621 just 'IDENTIFIER opt_type_parameter_list'.
11622 (property_declaration, event_declaration): Use a
11623 `namespace_or_type_name' instead of a `member_name'.
11625 2004-04-03 Martin Baulig <martin@ximian.com>
11627 * decl.cs (MemberName): Renamed to `TypeName' and created a new
11628 `MemberName' class.
11629 (TypeName): Formerly known as MemberName.
11631 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
11632 instead of a `MemberName'.
11634 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
11635 (member_name): New rule; create a MemberName.
11637 2004-04-02 Martin Baulig <martin@ximian.com>
11639 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
11640 (CS0305 and CS0308).
11642 2004-04-02 Martin Baulig <martin@ximian.com>
11644 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
11645 support for nested types.
11647 2004-04-02 Martin Baulig <martin@ximian.com>
11649 * ecore.cs (IAlias): New public interface.
11650 (TypeExpr, TypeExpression): Implement IAlias.
11651 (TypeAliasExpression): New public class.
11653 * namespace.cs (Namespace): Implement IAlias.
11654 (Namespace.Lookup): Return an IAlias instead on an object.
11655 (Namespace.DefineName): Take an IAlias instead of an object.
11656 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
11658 (NamespaceEntry.UsingAlias): Take a Membername instead of an
11660 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
11662 (NamespaceEntry.Lookup): Likewise.
11664 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
11667 * decl.cs (DeclSpace): Implement IAlias.
11668 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
11670 * generic.cs (ConstructedType): Improved error checking.
11672 2004-04-02 Martin Baulig <martin@ximian.com>
11674 * convert.cs: Added type parameter conversions.
11677 (UnboxCast.Emit): Emit an `unbox.any' for type params.
11678 (ClassCast.Emit): If the source type is a type parameter, box it.
11679 If the target type is a type parameter, emit an `unbox.any'
11680 instead of a `classcast'.1
11682 2004-04-01 Martin Baulig <martin@ximian.com>
11684 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
11686 2004-04-01 Martin Baulig <martin@ximian.com>
11688 * generic.cs (ConstructedType.CheckConstraints): Use
11689 Convert.ImplicitStandardConversionExists(); user-defined implicit
11690 conversions are not allowed according to the spec.
11692 2004-03-30 Martin Baulig <martin@ximian.com>
11694 * expression.cs (New): Added support for type parameters.
11697 (TypeManager.activator_type): New public static field.
11698 (TypeManager.activator_create_instance): Likewise.
11700 2004-03-30 Martin Baulig <martin@ximian.com>
11702 * typemanager.cs (TypeManager.HasConstructorConstraint): New
11705 2004-03-30 Martin Baulig <martin@ximian.com>
11707 * generic.cs (ConstructedType.CheckConstraints): Actually follow
11708 the spec here: the argument type must be convertible to the
11711 2004-03-30 Martin Baulig <martin@ximian.com>
11714 (TypeParameter.Define, TypeParameter.DefineMethod): Call
11715 TypeManager.AddTypeParameter().
11716 (ConstructedType.CheckConstraints): Re-enable this and actually
11717 check whether we have a constructor constraint.
11720 (TypeManager.builder_to_type_param): New static field.
11721 (TypeManager.AddTypeParameter): New static method.
11722 (TypeManager.LookupTypeParameter): New public method.
11724 2004-03-30 Martin Baulig <martin@ximian.com>
11726 * generic.cs (TypeParameter.DefineType): Return a boolean and use
11727 the new API to actually define the constructor constraint.
11730 (TypeManager.new_constraint_attr_type): New static field.
11731 (TypeManager.InitCoreTypes): Initialize it.
11733 2004-03-30 Martin Baulig <martin@ximian.com>
11735 * generic.cs (Constraints): Completed error checking, use correct
11738 2004-03-29 Martin Baulig <martin@ximian.com>
11740 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
11742 * expression.cs (Invocation.InferTypeArguments): Added overloaded
11743 public version which takes a `ParameterData pd' instead of an
11746 2004-03-29 Martin Baulig <martin@ximian.com>
11748 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
11751 2004-03-29 Martin Baulig <martin@ximian.com>
11753 * expression.cs (Argument.ResolveMethodGroup): If we're a
11754 ConstructedType, call GetMemberAccess() on it.
11756 2004-03-29 Martin Baulig <martin@ximian.com>
11758 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
11759 (MethodCore.CheckGenericOverride): When overriding a generic
11760 method, check whether the constraints match.
11762 * support.cs (GenericConstraints): New public interface.
11763 (ParameterData.GenericConstraints): New public method.
11765 * parameter.cs (Parameter.Resolve): Check whether we're a generic
11766 method parameter and compute our constraints if appropriate.
11767 (Parameter.GenericConstraints): New public property.
11769 * generic.cs (Constraints): Implement GenericConstraints.
11771 2004-03-29 Martin Baulig <martin@ximian.com>
11773 * decl.cs (MemberCache.FindMemberToOverride): Use
11774 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
11776 2004-03-29 Martin Baulig <martin@ximian.com>
11778 * generic.cs (GenericMethod.Define): Resolve our type parameters.
11780 2004-03-29 Martin Baulig <martin@ximian.com>
11782 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
11783 not allowed on non-generic declarations").
11785 2004-03-29 Martin Baulig <martin@ximian.com>
11787 * expression.cs (Invocation.InferTypeArguments): Added overloaded
11788 public version of this method.
11790 * class.cs (MethodCore.IsDuplicateImplementation): Use
11791 Invocation.InferTypeArguments() to check this.
11793 2004-03-29 Martin Baulig <martin@ximian.com>
11795 * convert.cs: Use TypeManager.IsDelegateType() instead of
11796 comparing types correctly.
11798 2004-03-29 Martin Baulig <martin@ximian.com>
11800 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
11801 types directly to make it work for generic instances.
11803 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
11805 2004-03-29 Martin Baulig <martin@ximian.com>
11807 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
11808 support for arrays.
11810 2004-03-24 Martin Baulig <martin@ximian.com>
11812 * decl.cs (DeclSpace.FindType): Also use
11813 TypeManager.CheckGeneric() for types from the using clauses.
11815 2004-03-23 Martin Baulig <martin@ximian.com>
11817 * expression.cs (Invocation.OverloadResolve): Added `bool
11818 may_fail' argument and use it instead of the Location.IsNull() hack.
11820 2004-03-23 Martin Baulig <martin@ximian.com>
11822 * expression.cs (Invocation.InferType): Use correct type inference
11825 2004-03-23 Martin Baulig <martin@ximian.com>
11827 * ecore.cs (MethodGroupExpr.Name): Use
11828 TypeManager.CSharpSignature() instead of just the name.
11830 * expression.cs (Invocation.OverloadResolve): Provide better error
11832 (Invocation.DoResolve): OverloadResolve() never returns null
11833 without reporting an error, so removed the error -6 reporting here.
11835 2004-03-23 Martin Baulig <martin@ximian.com>
11837 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
11840 * cs-parser.jay (delegate_declaration): Support generic delegates.
11842 * delegate.cs: Support generic delegates.
11844 2004-03-22 Martin Baulig <martin@ximian.com>
11846 * expression.cs (Invocation.InferParamsTypeArguments): New static
11847 method; does type inference for params arguments.
11849 2004-03-21 Martin Baulig <martin@ximian.com>
11851 * typemanager.cs (TypeManager.IsGenericMethod): New public static
11852 method; checks whether a method is a generic method.
11854 * expression.cs (Invocation.InferTypeArguments): New static method;
11855 infer type arguments for generic method invocation.
11857 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
11858 property; we set this to true if we're resolving a generic method
11859 invocation and the user specified type arguments, ie. we're not
11860 doing type inference.
11862 2004-03-20 Martin Baulig <martin@ximian.com>
11864 * class.cs (MethodData.DeclaringType): New public property.
11865 (MethodData.Define): Set DeclaringType here.
11866 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
11867 instead of OperatorMethodBuilder.DeclaringType.
11869 2004-03-20 Martin Baulig <martin@ximian.com>
11871 * cs-tokenizer.cs (xtoken): Return a special
11872 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
11874 * cs-parser.jay (default_value_expression): Switch to the new
11877 2004-03-19 Martin Baulig <martin@ximian.com>
11879 * decl.cs (MemberName): New class. We use this to "construct"
11880 namespace_or_type_name's.
11882 * generics.cs (TypeArguments.GetDeclarations): New public method;
11883 returns the type arguments as a string[] and reports a CS0081 if
11884 one of them is not an identifier.
11886 * class.cs (MemberBase): The .ctor now takes the name as a
11887 MemberName instead of a string.
11888 (MemberBase.ExplicitInterfaceName): Changed type from string to
11890 (MemberBase.DoDefine): If we're an explicit implementation, the
11891 InterfaceType may be a generic instance.
11893 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
11894 (namespace_name): Call MemberName.GetName () to transform the
11895 MemberName into a string and ensure we don't have any type
11897 (type_name): Call MemberName.GetTypeExpression() to transfrom the
11898 MemberName into an expression.
11899 (method_header): Use namespace_or_type_name instead of member_name.
11901 2004-04-07 Miguel de Icaza <miguel@ximian.com>
11903 * rootcontext.cs: Add new types to the boot resolution.
11905 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
11906 MulticastDelegate is not allowed.
11908 * typemanager.cs: Add new types to lookup: System.TypedReference
11911 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
11912 check for TypedReference or ArgIterator, they are not allowed.
11914 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
11915 makes us properly catch 1510 in some conditions (see bug 56016 for
11918 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
11920 * CryptoConvert.cs: update from corlib version
11923 2004-04-05 Miguel de Icaza <miguel@ximian.com>
11925 * class.cs (Indexer.Define): Check indexername declaration
11927 2004-04-05 Marek Safar <marek.safar@seznam.cz>
11929 * attribute.cs (IsClsCompliant): Fixed problem with handling
11930 all three states (compliant, not-compliant, undetected).
11932 2004-03-30 Marek Safar <marek.safar@seznam.cz>
11934 * attribute.cs (Attribute): Location is now public.
11935 (Resolve): Store resolved arguments (pos_values) in attribute class.
11936 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
11937 (GetClsCompliantAttributeValue): New method that gets
11938 CLSCompliantAttribute value.
11939 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
11940 if exists else null.
11941 (AttributeTester): New class for CLS-Compliant verification routines.
11943 * class.cs (Emit): Add CLS-Compliant verification.
11944 (Method.GetSignatureForError): Implemented.
11945 (Constructor.GetSignatureForError): Implemented
11946 (Constructor.HasCompliantArgs): Returns if constructor has
11947 CLS-Compliant arguments.
11948 (Constructor.Emit): Override.
11949 (Construcor.IsIdentifierClsCompliant): New method; For constructors
11950 is needed to test only parameters.
11951 (FieldBase.GetSignatureForError): Implemented.
11952 (TypeContainer): New member for storing base interfaces.
11953 (TypeContainer.FindMembers): Search in base interfaces too.
11955 * codegen.cs (GetClsComplianceAttribute): New method that gets
11956 assembly or module CLSCompliantAttribute value.
11957 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
11959 (ModuleClass.Emit): Add error 3012 test.
11961 * const.cs (Emit): Override and call base for CLS-Compliant tests.
11963 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
11964 state for all decl types.
11965 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
11966 if CLS-Compliant tests are required.
11967 (IsClsCompliaceRequired): New method. Analyze whether code
11968 must be CLS-Compliant.
11969 (IsExposedFromAssembly): New method. Returns true when MemberCore
11970 is exposed from assembly.
11971 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
11972 value or gets cached value.
11973 (HasClsCompliantAttribute): New method. Returns true if MemberCore
11974 is explicitly marked with CLSCompliantAttribute.
11975 (IsIdentifierClsCompliant): New abstract method. This method is
11976 used to testing error 3005.
11977 (IsIdentifierAndParamClsCompliant): New method. Common helper method
11978 for identifier and parameters CLS-Compliant testing.
11979 (VerifyClsCompliance): New method. The main virtual method for
11980 CLS-Compliant verifications.
11981 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
11982 null. I don't know why is null (too many public members !).
11983 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
11984 and get value of first CLSCompliantAttribute that found.
11986 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
11987 (VerifyClsCompliance): Override and add extra tests.
11989 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
11990 clscheck- disable CLS-Compliant verification event if assembly is has
11991 CLSCompliantAttribute(true).
11993 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
11994 ApllyAttribute is now called in emit section as in the other cases.
11995 Possible future Emit integration.
11996 (IsIdentifierClsCompliant): New override.
11997 (VerifyClsCompliance): New override.
11998 (GetEnumeratorName): Returns full enum name.
12000 * parameter.cs (GetSignatureForError): Implemented.
12002 * report.cs (WarningData): New struct for Warning message information.
12003 (LocationOfPreviousError): New method.
12004 (Warning): New method. Reports warning based on the warning table.
12005 (Error_T): New method. Reports error based on the error table.
12007 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
12008 verifications are done here.
12010 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
12012 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
12013 CLSCompliantAttribute.
12014 (all_imported_types): New member holds all imported types from other
12016 (LoadAllImportedTypes): New method fills static table with exported types
12017 from all referenced assemblies.
12018 (Modules): New property returns all assembly modules.
12020 2004-03-30 Miguel de Icaza <miguel@ximian.com>
12022 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
12023 throwing a parser error.
12025 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
12026 which removes the hardcoded get_/set_ prefixes for properties, as
12027 IL allows for the properties to be named something else.
12031 * expression.cs: Do not override operand before we know if it is
12032 non-null. Fix 56207
12034 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12036 * typemanager.cs: support for pinned variables.
12038 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12040 * decl.cs, typemanager.cs: Avoid using an arraylist
12041 as a buffer if there is only one result set.
12043 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12045 * expression.cs: Make sure you cant call a static method
12046 with an instance expression, bug #56174.
12048 2004-03-29 Miguel de Icaza <miguel@ximian.com>
12050 * class.cs (IsDuplicateImplementation): Improve error reporting to
12051 flag 663 (method only differs in parameter modifier).
12053 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
12054 in preprocessor directives.
12056 * location.cs (LookupFile): Allow for the empty path.
12058 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
12059 better approach for some of that patch, but its failing with the
12060 CharSet enumeration. For now try/catch will do.
12062 * typemanager.cs: Do not crash if a struct does not have fields.
12065 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12067 * expression.cs: cs0213, cant fix a fixed expression.
12070 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12072 * cs-parser.jay: detect invalid embeded statements gracefully.
12075 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12077 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
12080 the invocation type may not be a subclass of the tye of the item/
12081 The type of the item must be a subclass of the invocation item.
12086 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
12088 * attribute.cs: Added methods to get a string and a bool from an
12089 attribute. Required to information from AssemblyKeyFileAttribute,
12090 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
12091 * codegen.cs: Modified AssemblyName creation to include support for
12092 strongnames. Catch additional exceptions to report them as CS1548.
12093 * compiler.csproj: Updated include CryptoConvert.cs.
12094 * compiler.csproj.user: Removed file - user specific configuration.
12095 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
12096 Mono.Security assembly. The original class is maintained and tested in
12097 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
12098 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
12099 like CSC 8.0 (C# v2) supports.
12100 * Makefile: Added CryptoConvert.cs to mcs sources.
12101 * rootcontext.cs: Added new options for strongnames.
12103 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
12105 * driver.cs: For --expect-error, report error code `2'
12106 if the program compiled with no errors, error code `1' if
12107 it compiled with an error other than the one expected.
12109 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
12111 * compiler.csproj: Updated for Visual Studio .NET 2003.
12112 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
12113 * compiler.sln: Updated for Visual Studio .NET 2003.
12115 2004-03-24 Ravi Pratap M <ravi@ximian.com>
12117 * expression.cs: Fix bug #47234. We basically need to apply the
12118 rule that we prefer the conversion of null to a reference type
12119 when faced with a conversion to 'object' (csc behaviour).
12121 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12123 * statement.cs: Shorter form for foreach, eliminates
12124 a local variable. r=Martin.
12126 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12128 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
12129 checks if we can use brtrue/brfalse to test for 0.
12130 * expression.cs: use the above in the test for using brtrue/brfalse.
12131 cleanup code a bit.
12133 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12135 * expression.cs: Rewrite string concat stuff. Benefits:
12137 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
12138 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
12139 rather than a concat chain.
12141 * typemanager.cs: Add lookups for more concat overloads.
12143 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12145 * expression.cs: Emit shorter il code for array init.
12162 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
12164 * statement.cs: Before, two switch blocks would be merged if the
12165 total size of the blocks (end_item - begin_item + 1) was less than
12166 two times the combined sizes of the blocks.
12168 Now, it will only merge if after the merge at least half of the
12173 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
12175 * class.cs : csc build fix for GetMethods(). See bug #52503.
12177 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
12179 * expression.cs: Make sure fp comparisons work with NaN.
12180 This fixes bug #54303. Mig approved this patch a long
12181 time ago, but we were not able to test b/c the runtime
12184 2004-03-19 Miguel de Icaza <miguel@ximian.com>
12186 * ecore.cs (TypExpr.GetHashCode): implement this overload.
12188 2004-03-19 Martin Baulig <martin@ximian.com>
12190 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
12191 two overloads may unify for some type parameter substitutions and
12192 report a CS0408 if appropriate.
12194 2004-03-19 Martin Baulig <martin@ximian.com>
12196 * class.cs (MemberCore.IsDuplicateImplementation): Report the
12197 error here and not in our caller.
12199 2004-03-19 Martin Baulig <martin@ximian.com>
12201 * interface.cs: Completely killed this file.
12202 (Interface): We're now a TypeContainer and live in class.cs.
12204 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
12205 argument; we're now also called for interfaces.
12206 (TypeContainer.DefineMembers): Allow this method being called
12208 (TypeContainer.GetMethods): New public method; formerly known as
12209 Interface.GetMethod(). This is used by PendingImplementation.
12210 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
12211 it's now private and non-static.
12212 (Interface): Moved this here; it's now implemented similar to
12214 (Method, Property, Event, Indexer): Added `bool is_interface'
12215 argument to their .ctor's.
12216 (MemberBase.IsInterface): New public field.
12218 * cs-parser.jay: Create normal Method, Property, Event, Indexer
12219 instances instead of InterfaceMethod, InterfaceProperty, etc.
12220 (opt_interface_base): Removed; we now use `opt_class_base' instead.
12221 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
12223 2004-03-19 Martin Baulig <martin@ximian.com>
12225 * class.cs (MethodCore.IsDuplicateImplementation): New private
12226 method which does the CS0111 checking.
12227 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
12228 Use IsDuplicateImplementation().
12230 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
12232 * decl.cs (FindMemberToOverride): New method to find the correct
12233 method or property to override in the base class.
12235 - Make Method/Property use the above method to find the
12236 version in the base class.
12237 - Remove the InheritableMemberSignatureCompare as it is now
12240 This patch makes large code bases much faster to compile, as it is
12241 O(n) rather than O(n^2) to do this validation.
12243 Also, it fixes bug 52458 which is that nested classes are not
12244 taken into account when finding the base class member.
12246 Reviewed/Approved by Martin.
12248 2004-03-17 Martin Baulig <martin@ximian.com>
12250 * expression.cs (MemberAccess.DoResolve): Take the parent's number
12251 of type arguments into account; use the `real_num_type_args'
12252 approach like in DoResolveAsTypeStep().
12254 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
12257 2004-03-17 Marek Safar <marek.safar@seznam.cz>
12259 * interface.cs: In all interface classes removed redundant
12260 member initialization.
12262 2004-03-16 Martin Baulig <martin@ximian.com>
12264 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12266 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12268 * decl.cs (DefineTypeAndParents): New helper method to define a
12269 type's containers before the type itself is defined; This is a
12270 bug exposed by the recent changes to Windows.Forms when an
12271 implemented interface was defined inside a class that had not been
12274 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
12276 (Check): Loop correctly to report errors modifiers
12277 (UNSAFE was not in the loop, since it was the same as TOP).
12279 * interface.cs: Every interface member now takes a ModFlags,
12280 instead of a "is_new" bool, which we set on the base MemberCore.
12282 Every place where we called "UnsafeOk" in the interface, now we
12283 call the proper member (InterfaceMethod.UnsafeOK) instead to get
12284 the unsafe settings from the member declaration instead of the
12285 container interface.
12287 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
12289 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12290 `set_indexer_name' to the pending bits (one per type).
12292 We fixed a bug today that was picking the wrong method to
12293 override, since for properties the existing InterfaceMethod code
12294 basically ignored the method name. Now we make sure that the
12295 method name is one of the valid indexer names.
12297 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
12299 * support.cs (SeekableStreamReader): Keep track of stream byte
12300 positions and don't mix them with character offsets to the buffer.
12302 Patch from Gustavo Giráldez
12304 2004-03-15 Marek Safar <marek.safar@seznam.cz>
12306 * interface.cs (InterfaceSetGetBase): Removed double member
12307 initialization, base class does it as well.
12309 2004-03-13 Martin Baulig <martin@ximian.com>
12311 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
12312 when compiling corlib.
12314 2004-03-13 Miguel de Icaza <miguel@ximian.com>
12316 * convert.cs (ExplicitConversion): We were reporting an error on
12317 certain conversions (object_type source to a value type, when the
12318 expression was `null') before we had a chance to pass it through
12319 the user defined conversions.
12321 * driver.cs: Replace / and \ in resource specifications to dots.
12324 * class.cs: Add check for duplicate operators. Fixes 52477
12326 2004-03-11 Miguel de Icaza <miguel@ximian.com>
12328 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
12329 that are in the middle of the statements, not only at the end.
12332 * class.cs (TypeContainer.AddField): No longer set the
12333 `HaveStaticConstructor' flag, now we call it
12334 `UserDefineStaticConstructor' to diferentiate the slightly
12335 semantic difference.
12337 The situation is that we were not adding BeforeFieldInit (from
12338 Modifiers.TypeAttr) to classes that could have it.
12339 BeforeFieldInit should be set to classes that have no static
12344 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
12346 And most importantly Zoltan's comment:
12348 http://bugzilla.ximian.com/show_bug.cgi?id=44229
12350 "I think beforefieldinit means 'it's ok to initialize the type sometime
12351 before its static fields are used', i.e. initialization does not need
12352 to be triggered by the first access to the type. Setting this flag
12353 helps the JIT to compile better code, since it can run the static
12354 constructor at JIT time, and does not need to generate code to call it
12355 (possibly lots of times) at runtime. Unfortunately, mcs does not set
12356 this flag for lots of classes like String.
12358 csc sets this flag if the type does not have an explicit static
12359 constructor. The reasoning seems to be that if there are only static
12360 initalizers for a type, and no static constructor, then the programmer
12361 does not care when this initialization happens, so beforefieldinit
12364 This bug prevents the AOT compiler from being usable, since it
12365 generates so many calls to mono_runtime_class_init that the AOT code
12366 is much slower than the JITted code. The JITted code is faster,
12367 because it does not generate these calls if the vtable is type is
12368 already initialized, which is true in the majority of cases. But the
12369 AOT compiler can't do this."
12371 2004-03-10 Miguel de Icaza <miguel@ximian.com>
12373 * class.cs (MethodData.Emit): Refactor the code so symbolic
12374 information is generated for destructors; For some reasons we
12375 were taking a code path that did not generate symbolic information
12378 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
12380 * class.cs: Create a Constructor.CheckBase method that
12381 takes care of all validation type code. The method
12382 contains some code that was moved from Define.
12384 It also includes new code that checks for duplicate ctors.
12385 This fixes bug #55148.
12387 2004-03-09 Joshua Tauberer <tauberer@for.net>
12389 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
12390 a { ... }-style array creation invokes EmitStaticInitializers
12391 which is not good for reference-type arrays. String, decimal
12392 and now null constants (NullCast) are not counted toward
12393 static initializers.
12395 2004-03-05 Martin Baulig <martin@ximian.com>
12397 * location.cs (SourceFile.HasLineDirective): New public field;
12398 specifies whether the file contains or is referenced by a "#line"
12400 (Location.DefineSymbolDocuments): Ignore source files which
12401 either contain or are referenced by a "#line" directive.
12403 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
12405 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
12406 direct access to our parent, so check the method inline there.
12408 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
12410 * expression.cs (Invocation.EmitCall): Miguel's last commit
12411 caused a regression. If you had:
12416 In Foo the implict this would be null.
12418 2004-02-27 Miguel de Icaza <miguel@ximian.com>
12420 * expression.cs (Invocation.EmitCall): If the method is not
12421 virtual, do not emit a CallVirt to it, use Call.
12423 * typemanager.cs (GetFullNameSignature): Improve the method to
12424 cope with ".ctor" and replace it with the type name.
12426 * class.cs (ConstructorInitializer.Resolve): Now the method takes
12427 as an argument the ConstructorBuilder where it is being defined,
12428 to catch the recursive constructor invocations.
12430 2004-03-16 Martin Baulig <martin@ximian.com>
12432 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
12433 ConstructedType, call ResolveType() on it to get the type rather
12434 than just using `expr.Type'.
12436 2004-03-16 Martin Baulig <martin@ximian.com>
12438 * generics.cs (ConstructedType.GetMemberAccess): Take the
12439 EmitContext instead on the TypeExpr and use
12440 ec.TypeContainer.CurrentType/ec.ContainerType.
12442 2004-03-16 Martin Baulig <martin@ximian.com>
12444 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
12445 parameters before aliases.
12447 2004-03-16 Martin Baulig <martin@ximian.com>
12449 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
12450 New oublic function; checks whether two generic instances may become
12451 equal under some instantiations (26.3.1).
12453 * class.cs (TypeContainer.Define): Call
12454 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
12457 2004-03-16 Martin Baulig <martin@ximian.com>
12459 * class.cs (TypeContainer.GetClassBases): Moved
12460 Error_TypeParameterAsBase() here and also check whether the base
12461 class is not an attribute.
12463 2004-03-16 Martin Baulig <martin@ximian.com>
12465 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12467 2004-03-16 Martin Baulig <martin@ximian.com>
12469 * class.cs (Error_TypeParameterAsBase): Use correct error number
12472 2004-03-16 Martin Baulig <martin@ximian.com>
12474 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
12477 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
12480 2004-03-15 Martin Baulig <martin@ximian.com>
12482 * typemanager.cs (TypeManager.GetFullName): New public method.
12483 (TypeManager.MemberLookup): Added `int_num_type_arguments'
12484 argument; only return members with the correct number of type
12486 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
12487 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
12488 whether the number of type arguments matches.
12490 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
12491 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
12493 * expression.cs (MemberAccess): Added public `NumTypeArguments'
12494 field; it's set by the protected .ctor when we're actually a
12495 GenericMemberAccess.
12496 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
12497 arguments and pass it to MemberLookupFinal ().
12499 * ecore.cs (Expression.MemberLookup): Added `int
12500 num_type_arguments' argument; only return members with the correct
12501 number of type arguments.
12502 (Expression.MemberLookupFailed): Check whether the MemberLookup
12503 failed because we did not have the correct number of type
12504 arguments; report CS0305 in this case.
12506 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
12507 `e.ResolveAsTypeTerminal()' already did so.
12509 2004-03-15 Martin Baulig <martin@ximian.com>
12511 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
12512 we're a ConstructedType; in this case, the caller must report an
12513 error (for instance CS0131).
12515 * generic.cs (TypeArguments): Added Location argument to the .ctor.
12516 (TypeArguments.Resolve): Actually report errors here.
12518 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12520 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12521 `set_indexer_name' to the pending bits (one per type).
12523 We fixed a bug today that was picking the wrong method to
12524 override, since for properties the existing InterfaceMethod code
12525 basically ignored the method name. Now we make sure that the
12526 method name is one of the valid indexer names.
12528 2004-03-15 Martin Baulig <martin@ximian.com>
12530 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
12531 for generic instances.
12533 2004-03-13 Martin Baulig <martin@ximian.com>
12535 * class.cs (TypeContainer.DefineType): Call
12536 TypeManager.AddUserType() immediately after creating the
12537 TypeBuilder; pass all type parameters when creating the
12540 * decl.cs (DeclSpace.FindNestedType): New public method.
12541 (DeclSpace.FindType): Added `int num_type_args' argument; only
12542 return types with the correct number of type parameters.
12543 (DeclSpace.CountTypeParams): New public property.
12545 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
12546 the number of type parameters; defaults to zero.
12548 * generic.cs (TypeArguments.Count): New public property.
12549 (ConstructedType.DoResolveAsTypeStep): First call
12550 ds.FindNestedType() to find out whether we're nested in the
12551 current generic type; in this case, we inherit all type parameters
12552 from the current class.
12554 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
12555 num_type_args' argument.
12556 (RootContext.LookupType): Added overloaded version which takes the
12557 number of type arguments; only return types with the correct
12558 number of type arguments.
12560 * typemanager.cs (TypeManager.CheckGeneric): New public function;
12561 checks whether `Type t' has `int num_type_args'.
12563 2004-03-13 Martin Baulig <martin@ximian.com>
12565 * generic.cs (GenericMethod.DefineType): New method; calls
12566 DefineType() on all the type parameters.
12568 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
12569 (MethodData.Define): If we're a generic method, call
12570 GenericMethod.DefineType() to define the type parameters.
12572 2004-03-10 Martin Baulig <martin@ximian.com>
12574 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
12575 instead of IsAssignableFrom.
12577 2004-03-10 Martin Baulig <martin@ximian.com>
12579 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
12581 * support.cs (ParameterData.HasArrayParameter): New property.
12582 (ReflectionParameters.ctor): Take a MethodBase instead of a
12583 ParameterInfo[]. If we have any type parameters, get the generic
12584 method definition and ask it whether we have variable arguments.
12586 2004-02-26 Miguel de Icaza <miguel@ximian.com>
12588 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
12589 routines to check if a type is an enumerable/enumerator allow
12590 classes that implement the IEnumerable or IEnumerator interfaces.
12592 * class.cs (Property, Operator): Implement IIteratorContainer, and
12593 implement SetYields.
12595 (Property.Define): Do the block swapping for get_methods in the
12596 context of iterators. We need to check if Properties also
12597 include indexers or not.
12599 (Operator): Assign the Block before invoking the
12600 OperatorMethod.Define, so we can trigger the Iterator code
12603 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
12604 Property and Operator classes are not created when we parse the
12605 declarator but until we have the block completed, so we use a
12606 singleton SimpleIteratorContainer.Simple to flag whether the
12607 SetYields has been invoked.
12609 We propagate this setting then to the Property or the Operator to
12610 allow the `yield' to function.
12612 2004-02-25 Marek Safar <marek.safar@seznam.cz>
12614 * codegen.cs: Implemented attribute support for modules.
12615 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
12616 Assembly/Module functionality.
12618 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
12619 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
12620 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
12622 2004-02-16 Marek Safar <marek.safar@seznam.cz>
12624 * interface.cs (FindMembers): The operation is performed on all base
12625 interfaces and not only on the first. It is required for future CLS Compliance patch.
12627 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
12629 * statement.cs, codegen.cs:
12630 This patch deals with patterns such as:
12632 public class List : IEnumerable {
12634 public MyEnumerator GetEnumerator () {
12635 return new MyEnumerator(this);
12638 IEnumerator IEnumerable.GetEnumerator () {
12642 public struct MyEnumerator : IEnumerator {
12647 Before, there were a few things we did wrong:
12648 1) we would emit callvirt on a struct, which is illegal
12649 2) we emited ldarg when we needed to emit ldarga
12650 3) we would mistakenly call the interface methods on an enumerator
12651 type that derived from IEnumerator and was in another assembly. For example:
12653 public class MyEnumerator : IEnumerator
12655 Would have the interface methods called, even if there were public impls of the
12656 method. In a struct, this lead to invalid IL code.
12658 2004-02-11 Marek Safar <marek.safar@seznam.cz>
12660 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
12663 * delegate.cs (Define): Fixed crash when delegate type is undefined.
12665 2004-02-11 Miguel de Icaza <miguel@ximian.com>
12667 * cs-parser.jay: Fix small regression: we were not testing V2
12668 compiler features correctly.
12670 * interface.cs: If the emit context is null, then create one
12672 2004-02-09 Marek Safar <marek.safar@seznam.cz>
12674 * decl.cs (GetSignatureForError): New virtual method to get full name
12675 for error messages.
12677 * attribute.cs (IAttributeSupport): New interface for attribute setting.
12678 Now it is possible to rewrite ApplyAttributes method to be less if/else.
12680 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
12681 Duplicated members and code in these classes has been removed.
12682 Better encapsulation in these classes.
12684 2004-02-07 Miguel de Icaza <miguel@ximian.com>
12686 * assign.cs (Assign.DoResolve): When dealing with compound
12687 assignments, there is a new rule in ECMA C# 2.4 (might have been
12688 there before, but it is documented here) that states that in:
12692 If b is of type int, and the `op' is a shift-operator, then the
12693 above is evaluated as:
12697 * expression.cs (Binary.ResolveOperator): Instead of testing for
12698 int/uint/long/ulong, try to implicitly convert to any of those
12699 types and use that in pointer arithmetic.
12701 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
12702 method to print information for from the type, not from the
12703 null-method we were given.
12705 2004-02-01 Duncan Mak <duncan@ximian.com>
12707 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
12708 parsing for cmd, fixes bug #53694.
12710 2004-02-04 Marek Safar <marek.safar@seznam.cz>
12712 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
12713 in the member name duplication tests. Property and operator name duplication
12714 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
12716 2004-02-03 Marek Safar <marek.safar@seznam.cz>
12718 * interface.cs (PopulateMethod): Fixed crash when interface method
12719 returns not existing type (error test cs0246-3.cs).
12721 2004-02-02 Ravi Pratap M <ravi@ximian.com>
12723 * cs-parser.jay (interface_accessors): Re-write actions to also
12724 store attributes attached to get and set methods. Fix spelling
12727 (inteface_property_declaration): Modify accordingly.
12729 (InterfaceAccessorInfo): New helper class to store information to pass
12730 around between rules that use interface_accessors.
12732 * interface.cs (Emit): Apply attributes on the get and set
12733 accessors of properties and indexers too.
12735 * attribute.cs (ApplyAttributes): Modify accordingly to use the
12736 right MethodBuilder when applying attributes to the get and set accessors.
12738 2004-01-31 Miguel de Icaza <miguel@ximian.com>
12740 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
12742 2004-01-26 Miguel de Icaza <miguel@ximian.com>
12744 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
12746 2004-01-25 Miguel de Icaza <miguel@ximian.com>
12748 * cs-parser.jay: Remove YIELD token, instead use the new grammar
12749 changes that treat `yield' specially when present before `break'
12750 or `return' tokens.
12752 * cs-tokenizer.cs: yield is no longer a keyword.
12754 2004-01-23 Marek Safar <marek.safar@seznam.cz>
12756 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
12757 setting for default constructors.
12758 For default constructors are almost every time set wrong Modifier. The
12759 generated IL code has been alright. But inside mcs this values was
12760 wrong and this was reason why several of my CLS Compliance tests
12763 2004-02-27 Martin Baulig <martin@ximian.com>
12765 * generics.cs (ConstructedType.ResolveType): Make the nested type
12766 stuff actually work.
12768 2004-02-25 Martin Baulig <martin@ximian.com>
12770 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
12771 property; returns the type parameters just from the current type,
12772 ie. with the ones from outer classes.
12773 (DeclSpace.LookupGeneric): First search in the current class, then
12775 (DeclSpace.initialize_type_params): When hiding a type parameter
12776 from an outer class, put it into the `type_param_list' anyways.
12778 * expression.cs (MemberAccess.expr): Made this field protected.
12780 * class.cs (TypeContainer.Define): The `CurrentType' just contains
12781 the type parameters from the current class.
12783 * generic.cs (ConstructedType.ResolveType): Support nested generic
12784 types by taking the type parameters which we inherit from outer
12785 classes into account.
12786 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
12787 support for nested generic types.
12789 2004-02-23 Martin Baulig <martin@ximian.com>
12791 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
12792 field and check whether we're nested inside a generic type.
12793 (DeclSpace.ResolveType): If we're resolving to a generic type
12794 definition, create a ConstructedType and return its resolved type.
12795 (DeclSpace.initialize_type_params): New private method;
12796 initializes the `type_param_list' field from the type parameters
12797 from this and all enclosing classes.
12798 (DeclSpace.TypeParameters): Call initialize_type_params() unless
12799 we're already initialized.
12801 2004-02-23 Martin Baulig <martin@ximian.com>
12803 * class.cs (Method.Define): Create the generic method before
12804 calling DoDefine().
12805 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
12806 the TypeContainer one); we use this for generic methods.
12808 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
12809 parent's TypeBuilder.
12811 2004-02-18 Martin Baulig <martin@ximian.com>
12813 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
12814 to check for equality.
12816 2004-02-05 Martin Baulig <martin@ximian.com>
12818 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
12819 `ec.TypeContainer.CurrentType', use it instead of
12820 `ec.ContainerType' to check whether we're in the type's ctor.
12822 2004-01-29 Martin Baulig <martin@ximian.com>
12824 * expression.cs (Invocation.DoResolve): If we're a
12825 `ConstructedType', then we're actually a generic method, so
12826 rewrite the expr as a GenericMemberAccess.
12828 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
12829 here; manually parse it into a string.
12831 2004-01-28 Martin Baulig <martin@ximian.com>
12833 * typemanager.cs (TypeManager.IsEqual): New static method.
12834 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
12835 check for equality instead of using `=='.
12837 2004-01-26 Martin Baulig <martin@ximian.com>
12839 * decl.cs (DeclSpace.CurrentType): New public field.
12841 * expression.cs (This.ResolveBase): If we have an
12842 `ec.TypeContainer.CurrentType', use it instead of
12843 `ec.ContainerType'.
12845 * class.cs (TypeContainer.DefineType): If we're a generic type,
12846 create the `CurrentType' (unresolved).
12847 (TypeContainer.GenericType): New private field.
12848 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
12849 it and store it in `GenericType' before creating the MemberCache.
12850 (TypeContainer.GetMembers): If we have a `GenericType', call
12851 TypeManager.FindMembers() on it.
12853 * interface.cs (Interface.GenericType): New private field.
12854 (Interface.DefineType): If we're a generic type, create the
12855 `CurrentType' (unresolved).
12856 (Interface.DefineMembers): If we have a `CurrentType', resolve it
12857 and store it in `GenericType' before creating the MemberCache.
12858 (Interface.GetMembers): If we have a `GenericType', call
12859 TypeManager.FindMembers() on it.
12861 2004-01-22 Martin Baulig <martin@ximian.com>
12863 * cs-parser.jay (namespace_or_type_name): Return an Expression,
12864 not a QualifiedIdentifier. This is what `type_name_expression'
12865 was previously doing.
12866 (type_name_expression): Removed; the code is now in
12867 `namespace_or_type_name'.
12868 (qualified_identifier): Removed, use `namespace_or_type_name'
12870 (QualifiedIdentifier): Removed this class.
12872 2004-01-22 Martin Baulig <martin@ximian.com>
12874 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
12875 not a string as alias name.
12877 2004-01-21 Miguel de Icaza <miguel@ximian.com>
12879 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
12880 #52730 bug, and instead compute correctly the need to use a
12881 temporary variable when requesting an address based on the
12882 static/instace modified of the field and the constructor.
12884 2004-01-21 Martin Baulig <martin@ximian.com>
12886 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
12887 class and namespace before looking up aliases. Fixes #52517.
12889 2004-01-21 Martin Baulig <martin@ximian.com>
12891 * flowanalysis.cs (UsageVector.Merge): Allow variables being
12892 assinged in a 'try'; fixes exception4.cs.
12894 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12895 * class.cs : Implemented parameter-less constructor for TypeContainer
12897 * decl.cs: Attributes are now stored here. New property OptAttributes
12899 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
12901 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
12903 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12905 * typemanager.cs (CSharpSignature): Now reports also inner class name.
12906 (CSharpSignature): New method for indexer and property signature.
12908 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12910 * pending.cs (IsVirtualFilter): Faster implementation.
12912 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12914 * typemanager.cs: Avoid inclusion of same assembly more than once.
12916 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12918 * cs-parser.jay: Fixed problem where the last assembly attribute
12919 has been applied also to following declaration (class, struct, etc.)
12921 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12923 * class.cs: Added error CS0538, CS0539 reporting.
12924 Fixed crash on Microsoft runtime when field type is void.
12926 * cs-parser.jay: Added error CS0537 reporting.
12928 * pending.cs: Added error CS0535 reporting.
12929 Improved error report for errors CS0536, CS0534.
12931 2004-01-20 Miguel de Icaza <miguel@ximian.com>
12933 Merge a few bits from the Anonymous Method MCS tree.
12935 * statement.cs (ToplevelBlock): New class for toplevel methods,
12936 will hold anonymous methods, lifted variables.
12938 * cs-parser.jay: Create toplevel blocks for delegates and for
12939 regular blocks of code.
12941 2004-01-20 Martin Baulig <martin@ximian.com>
12943 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
12944 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
12945 and `NeedExplicitReturn'; added `IsLastStatement'.
12946 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
12947 have a `ReturnLabel' or we're not unreachable.
12949 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
12950 child's reachability; don't just override ours with it. Fixes
12951 #58058 (lluis's example).
12952 (FlowBranching): Added public InTryOrCatch(), InCatch(),
12953 InFinally(), InLoop(), InSwitch() and
12954 BreakCrossesTryCatchBoundary() methods.
12956 * statement.cs (Return): Do all error checking in Resolve().
12957 Unless we are the last statement in a top-level block, always
12958 create a return label and jump to it.
12959 (Break, Continue): Do all error checking in Resolve(); also make
12960 sure we aren't leaving a `finally'.
12961 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
12962 statement in a top-level block.
12963 (Block.Flags): Added `IsDestructor'.
12964 (Block.IsDestructor): New public property.
12966 2004-01-20 Martin Baulig <martin@ximian.com>
12968 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
12970 2004-01-20 Martin Baulig <martin@ximian.com>
12972 * statement.cs (Statement.ResolveUnreachable): New public method.
12973 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
12974 (Block.Resolve): Resolve unreachable statements.
12976 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
12978 * expression.cs: We need to fix the case where we do
12979 not have a temp variable here.
12981 * assign.cs: Only expression compound assignments need
12982 temporary variables.
12984 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
12986 * flowanalysis.cs: Reduce memory allocation in a few ways:
12987 - A block with no variables should not allocate a bit
12989 - A method with no out parameters does not need any tracking
12990 for assignment of the parameters, so we need not allocate
12993 public readonly Type[] VariableTypes;
12994 public readonly string[] VariableNames;
12995 Are redundant. The data is already stored in the variable
12996 map, so we need not allocate another array for it.
12997 - We need to add alot of checks for if (params | locals) == null
12998 due to the first two changes.
13000 2004-01-18 Miguel de Icaza <miguel@ximian.com>
13002 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
13003 implement IMemoryLocation, we store a copy on a local variable and
13004 take the address of it. Patch from Benjamin Jemlich
13006 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
13007 to use a special "type_name_expression" rule which reduces the
13008 number of "QualifiedIdentifier" classes created, and instead
13009 directly creates MemberAccess expressions.
13011 2004-01-17 Miguel de Icaza <miguel@ximian.com>
13013 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
13014 that fixes #52853. Null literal assignment to ValueType
13016 * class.cs (MethodData.Emit): Instead of checking the name of the
13017 method to determine if its a destructor, create a new derived
13018 class from Method called Destructor, and test for that.
13020 * cs-parser.jay: Create a Destructor object instead of a Method.
13022 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
13026 2004-01-16 Miguel de Icaza <miguel@ximian.com>
13028 * expression.cs (Binary.ResolveOperator): Perform an implicit
13029 conversion from MethodGroups to their delegate types on the
13030 Addition operation.
13032 * delegate.cs: Introduce a new class DelegateCreation that is the
13033 base class for `NewDelegate' and `ImplicitDelegateCreation',
13034 factor some code in here.
13036 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
13037 conversion from MethodGroups to compatible delegate types.
13039 * ecore.cs (Expression.Resolve): Do not flag error 654
13040 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
13041 we allow conversions from MethodGroups to delegate types now.
13043 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
13044 assignments in v2 either.
13046 2004-01-10 Miguel de Icaza <miguel@ximian.com>
13048 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
13049 static read-only fields in ctors.
13051 Applied patch from Benjamin Jemlich
13053 * expression.cs (UnaryMutator): Avoid leaking local variables.
13055 2004-01-09 Miguel de Icaza <miguel@ximian.com>
13057 * cs-tokenizer.cs (IsCastToken): Allow the various native types
13058 here to return true, as they can be used like this:
13060 (XXX) int.MEMBER ()
13062 Fixed 49836 and all the other dups
13064 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
13066 * driver.cs: Implement /win32res and /win32icon.
13068 2004-01-08 Miguel de Icaza <miguel@ximian.com>
13070 * cs-parser.jay: Add a rule to improve error handling for the
13071 common mistake of placing modifiers after the type.
13073 2004-01-07 Miguel de Icaza <miguel@ximian.com>
13075 * cs-parser.jay (interface_event_declaration): Catch
13076 initialization of events on interfaces, and report cs0068
13078 * cs-parser.jay (interface_event_declaration): Catch
13079 initialization of events.
13081 * ecore.cs: Better report missing constructors.
13083 * expression.cs (Binary.ResolveOperator): My previous bug fix had
13084 the error reporting done in the wrong place. Fix.
13086 * expression.cs (Binary.ResolveOperator): Catch the
13087 operator + (E x, E y) error earlier, and later allow for implicit
13088 conversions in operator +/- (E e, U x) from U to the underlying
13091 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
13092 52596, if the container class is abstract, the default constructor
13093 is protected otherwise its public (before, we were always public).
13095 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
13098 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
13099 Jemlich that fixes bug #52597, MCS was generating invalid code for
13100 idisposable structs. Thanks to Ben for following up with this
13103 2004-01-06 Miguel de Icaza <miguel@ximian.com>
13105 * driver.cs: Allow assemblies without code to be generated, fixes
13108 2004-01-07 Nick Drochak <ndrochak@gol.com>
13110 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
13112 2004-01-05 Miguel de Icaza <miguel@ximian.com>
13114 * cs-parser.jay: Add rules to improve error reporting if fields or
13115 methods are declared at the namespace level (error 116)
13117 * Add rules to catch event add/remove
13119 2004-01-04 David Sheldon <dave-mono@earth.li>
13121 * expression.cs: Added matching ")" to error message for
13124 2004-01-03 Todd Berman <tberman@gentoo.org>
13126 * ecore.cs, attribute.cs:
13127 Applying fix from #52429.
13129 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13131 * ecore.cs, expression.cs, statement.cs:
13132 Total rewrite of how we handle branching. We
13133 now handle complex boolean expressions with fewer
13134 jumps. As well if (x == 0) no longer emits a ceq.
13136 if (x is Foo) is much faster now, because we generate
13139 Overall, we get a pretty big improvement on our benchmark
13140 tests. The code we generate is smaller and more readable.
13142 I did a full two-stage bootstrap. The patch was reviewed
13143 by Martin and Miguel.
13145 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13147 * cs-parser.jay: Make primary_expression not take a QI.
13148 we dont need this because the member_access rule covers
13149 us here. So we replace the rule with just IDENTIFIER.
13151 This has two good effects. First, we remove a s/r conflict.
13152 Second, we allocate many fewer QualifiedIdentifier objects.
13154 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13156 * attribute.cs: Handle MarshalAs attributes as pseudo, and
13157 set the correct information via SRE. This prevents
13158 hanging on the MS runtime. Fixes #29374.
13160 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13162 * convert.cs: correctly handle conversions to value types
13163 from Enum and ValueType as unboxing conversions.
13165 Fixes bug #52569. Patch by Benjamin Jemlich.
13167 2004-01-02 Ravi Pratap <ravi@ximian.com>
13169 * expression.cs (BetterConversion): Prefer int -> uint
13170 over int -> ulong (csc's behaviour). This fixed bug #52046.
13172 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
13174 * decl.cs (MemberCache.FindMembers): now returns a
13177 * typemanager.cs: In general, go with with ^^.
13178 (CopyNewMethods): take an IList.
13179 (RealMemberLookup): Only allocate an arraylist
13180 if we copy from two sets of methods.
13182 This change basically does two things:
13183 1) Fewer array lists allocated due to CopyNewMethods.
13184 2) the explicit cast in MemberList costed ALOT.
13186 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
13188 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
13189 a hashtable to avoid needless string allocations when an identifier is
13190 used more than once (the common case).
13192 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13194 * pending.cs: MS's TypeBuilder.GetInterfaces ()
13195 is broken, it will not return anything. So, we
13196 have to use the information we have in mcs to
13199 * typemanager.cs: Add a cache for GetInterfaces,
13200 since this will now be used more often (due to ^^)
13202 (GetExplicitInterfaces) New method that gets the
13203 declared, not effective, interfaces on a type
13204 builder (eg, if you have interface IFoo, interface
13205 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
13208 This patch makes MCS able to bootstrap itself on
13211 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13213 * expression.cs: Remove the Nop's that Miguel put
13216 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13218 * report.cs, codegen.cs: Give the real stack trace to
13219 the error when an exception is thrown.
13221 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13223 * decl.cs: only allocate hashtables for ifaces if
13226 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13228 * expression.cs: fix the error from cs0121-2.cs
13229 (a parent interface has two child interfaces that
13230 have a function with the same name and 0 params
13231 and the function is called through the parent).
13233 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
13235 * class.cs, rootcontext.cs, typmanager.cs: do not
13238 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
13240 * codegen.cs: remove stack for the ec flow branching.
13241 It is already a linked list, so no need.
13243 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
13245 * Makefile: Allow custom profiler here.
13247 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13249 * typemanager.cs (LookupType):
13250 - Use a static char [], because split takes
13251 a param array for args, so it was allocating
13253 - Do not store true in a hashtable, it boxes.
13255 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13257 * flowanalysis.cs: bytify common enums.
13259 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13261 * modifiers.cs: Add a new set of flags for the
13262 flags allowed on explicit interface impls.
13263 * cs-parser.jay: catch the use of modifiers in
13264 interfaces correctly.
13265 * class.cs: catch private void IFoo.Blah ().
13267 All related to bug #50572.
13269 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13271 * decl.cs: Rewrite the consistant accessability checking.
13272 Accessability is not linear, it must be implemented in
13273 a tableish way. Fixes #49704.
13275 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13277 * expression.cs: Handle negation in a checked context.
13278 We must use subtraction from zero. Fixes #38674.
13280 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13282 * class.cs: Ignore static void main in DLLs.
13283 * rootcontext.cs: Handle the target type here,
13284 since we are have to access it from class.cs
13285 * driver.cs: account for the above.
13287 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13289 * report.cs: Give line numbers and files if available.
13291 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
13293 * driver.cs: Implement /addmodule.
13295 * typemanager.cs: Change 'modules' field so it now contains Modules not
13298 2003-12-20 Martin Baulig <martin@ximian.com>
13300 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
13301 (FieldBase.IsAssigned): Removed this field.
13302 (FieldBase.SetAssigned): New public method.
13303 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
13305 2003-12-20 Martin Baulig <martin@ximian.com>
13307 * expression.cs (LocalVariableReference.DoResolve): Don't set
13308 `vi.Used' if we're called from DoResolveLValue().
13310 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
13311 returns the usage vector it just merged into the current one -
13312 pass this one to UsageWarning().
13313 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
13314 of the `EmitContext', don't call this recursively on our children.
13316 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
13318 * driver.cs: Implement /target:module.
13320 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
13322 * support.cs (CharArrayHashtable): New helper class.
13324 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
13325 char arrays, not strings, so we can avoid creating a string in
13326 consume_identifier if the identifier is a keyword.
13328 2003-12-16 Martin Baulig <martin@ximian.com>
13330 * statement.cs (LocalInfo.Assigned): Removed this property.
13331 (LocalInfo.Flags): Removed `Assigned'.
13332 (LocalInfo.IsAssigned): New public method; takes the EmitContext
13333 and uses flow analysis.
13334 (Block.UsageWarning): Made this method private.
13335 (Block.Resolve): Call UsageWarning() if appropriate.
13337 * expression.cs (LocalVariableReference.DoResolve): Always set
13338 LocalInfo.Used here.
13340 2003-12-13 Martin Baulig <martin@ximian.com>
13342 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
13343 any value here; we're now using flow analysis to figure out
13344 whether a statement/block returns a value.
13346 2003-12-13 Martin Baulig <martin@ximian.com>
13348 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
13350 (FlowBranching.MergeFinally): Don't call
13351 `branching.CheckOutParameters()' here, this is called in
13353 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
13354 when adding the `finally' vector.
13356 2003-12-13 Martin Baulig <martin@ximian.com>
13359 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
13360 actually work and also fix #48962.
13362 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
13364 * decl.cs: Do not check System.Object for nested types,
13365 since we know it does not have any. Big bang for buck:
13368 Run 1: 8.35 seconds
13369 Run 2: 8.32 seconds
13370 corlib: 17.99 seconds
13372 Run 1: 8.17 seconds
13373 Run 2: 8.17 seconds
13374 corlib: 17.39 seconds
13376 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
13378 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
13379 time we are returning 0 members, so we save alot here.
13381 2003-12-11 Martin Baulig <martin@ximian.com>
13383 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
13384 `MergeChild()', also just take the `FlowBranching' as argument;
13385 call Merge() on it and return the result.
13386 (FlowBranching.Merge): We don't need to do anything if we just
13389 2003-12-11 Martin Baulig <martin@ximian.com>
13391 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
13392 them in an `ArrayList' to reduce memory usage. Thanks to Ben
13393 Maurer for this idea.
13395 2003-12-11 Martin Baulig <martin@ximian.com>
13397 * flowanalysis.cs (MergeResult): This class is now gone; we now
13398 use the `UsageVector' for this. The reason for this is that if a
13399 branching just has one sibling, we don't need to "merge" them at
13400 all - that's the next step to do.
13401 (FlowBranching.Merge): We now return a `UsageVector' instead of a
13404 2003-12-11 Martin Baulig <martin@ximian.com>
13406 Reworked flow analyis and made it more precise and bug-free. The
13407 most important change is that we're now using a special `Reachability'
13408 class instead of having "magic" meanings of `FlowReturns'. I'll
13409 do some more cleanups and optimizations and also add some more
13410 documentation this week.
13412 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
13413 largely reworked this class.
13414 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
13415 the new `Reachability' class instead of having "magic" values here.
13416 (FlowBranching): We're now using an instance of `Reachability'
13417 instead of having separate `Returns', `Breaks' etc. fields.
13419 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
13420 based on flow analysis; ignore the return value of block.Emit ().
13422 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
13424 * driver.cs typemanager.cs: Find the mono extensions to corlib even
13425 if they are private.
13427 2003-12-09 Martin Baulig <martin@ximian.com>
13429 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
13430 call them directly on the UsageVector.
13432 2003-12-09 Martin Baulig <martin@ximian.com>
13434 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
13435 Changed return type from `FlowReturns' to `Reachability'.
13437 2003-12-09 Martin Baulig <martin@ximian.com>
13439 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
13440 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
13441 `Reachable' fields with a single `Reachability' one.
13443 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13445 * class.cs (FindMembers): Remove foreach's.
13450 Run 1: 8.74 seconds
13451 Run 2: 8.71 seconds
13454 Run 1: 8.64 seconds
13455 Run 2: 8.58 seconds
13458 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13463 This patch does a few things:
13464 1. EmptyStatement is now a singleton, so it is never reallocated.
13465 2. All blah is EmptyStatement constructs have been changed to
13466 blah == EmptyStatement.Value, which is much faster and valid
13467 now that EmptyStatement is a singleton.
13468 3. When resolving a block, rather than allocating a new array for
13469 the non-empty statements, empty statements are replaced with
13470 EmptyStatement.Value
13471 4. Some recursive functions have been made non-recursive.
13472 Mainly the performance impact is from (3), however (1) and (2) are needed for
13473 this to work. (4) does not make a big difference in normal situations, however
13474 it makes the profile look saner.
13479 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13480 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13481 Total memory allocated: 56397 KB
13484 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
13485 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
13486 Total memory allocated: 55666 KB
13488 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13490 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
13491 than the hashtable in a hashtable version
13493 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
13494 we always end up concating a string. This results in a huge perf
13495 loss, because many strings have to be tracked by the GC. In this
13496 patch, we first use a hashtable that works with two keys, so that
13497 the strings do not need to be concat'ed.
13501 Run 1: 8.74 seconds
13502 Run 2: 8.71 seconds
13505 Run 1: 8.65 seconds
13506 Run 2: 8.56 seconds
13508 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13510 * Makefile: Add a new target `do-time' that does a quick and simple
13511 profile, leaving easy to parse output.
13513 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
13515 * codegen.cs (Init): Create the dynamic assembly with
13516 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
13518 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
13520 * support.cs: Make the PtrHashtable use only one
13521 instance of its comparer.
13523 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
13525 * typemanager.cs: Fix lookup of GetNamespaces.
13527 2003-11-29 Miguel de Icaza <miguel@ximian.com>
13529 * expression.cs: Removed redundant line.
13531 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
13532 ArrayLists, use for loops with bounds.
13534 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
13537 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
13538 arraylists, use for loop with bounds.
13540 The above three changes give us a 0.071 second performance
13541 improvement out of 3.294 seconds down to 3.223. On my machine
13542 the above changes reduced the memory usage by 1,387 KB during
13543 compiler bootstrap.
13545 * cs-parser.jay (QualifiedIdentifier): New class used to represent
13546 QualifiedIdentifiers. Before we created a new string through
13547 concatenation, and mostly later on, the result would be
13548 manipulated by DecomposeQI through string manipulation.
13550 This reduced the compiler memory usage for bootstrapping from
13551 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
13552 compile times in 0.05 seconds.
13554 2003-11-28 Dick Porter <dick@ximian.com>
13556 * support.cs: Do string compares with the Invariant culture.
13564 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
13565 the comparison is done with the Invariant culture.
13567 2003-11-27 Miguel de Icaza <miguel@ximian.com>
13569 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
13570 GetEnumerator method.
13572 (ProbeCollectionType): Iterate starting at the most specific type
13573 upwards looking for a GetEnumerator
13575 * expression.cs: Shift count can be up to 31 for int/uint and 63
13578 2003-11-26 Miguel de Icaza <miguel@ximian.com>
13580 * statement.cs (Block.LookupLabel): Also look for the label on the
13581 children blocks. Use a hash table to keep track of visited
13584 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
13585 we actually did transform the other operand, otherwise fall back
13586 to the common codepath that casts to long.
13588 * cs-tokenizer.cs: Use the same code pattern as the int case.
13589 Maybe I should do the parsing myself, and avoid depending on the
13590 Parse routines to get this done.
13592 2003-11-25 Miguel de Icaza <miguel@ximian.com>
13594 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13595 which fixes bug 51347. This time test it.
13597 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
13598 attributes for example can not tell the difference between these.
13599 The difference was only a syntax feature of the language.
13601 * attribute.cs: Apply attributes to delegates.
13603 * delegate.cs: Call the apply attributes method.
13605 2003-11-24 Miguel de Icaza <miguel@ximian.com>
13607 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
13608 comparing 0 vs Byte.MinValue, not the value
13610 (ImplicitConversionRequired): When reporting a conversion error,
13611 use error 31 to print out the constant error instead of the
13614 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13615 which fixes bug 51347.
13617 2003-11-22 Miguel de Icaza <miguel@ximian.com>
13619 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
13620 which fixes the -warnaserror command line option.
13622 2003-11-21 Miguel de Icaza <miguel@ximian.com>
13624 * cfold.cs (DoNumericPromotions): During constant folding of
13625 additions on UIntConstant, special case intconstants with
13626 IntConstants like we do on the expression binary operator.
13628 2003-11-12 Miguel de Icaza <miguel@ximian.com>
13630 * convert.cs (ImplicitReferenceConversion): We were missing a case
13631 (System.Enum are not value types or class types, so we need to
13632 classify them separatedly).
13634 * driver.cs: We do not support error 2007.
13636 2003-11-12 Jackson Harper <jackson@ximian.com>
13638 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
13639 system directory. Also use the full file name so users can
13640 libraries names mscorlib-o-tron.dll in a non system dir.
13642 2004-01-04 David Sheldon <dave-mono@earth.li>
13644 * expression.cs: Added matching ")" to error message for CS0077.
13646 2003-12-19 Martin Baulig <martin@ximian.com>
13648 * typemanager.cs (TypeManager.IsEqualGenericType): New public
13649 static method; see documentation in the method.
13650 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
13652 * convert.cs (Convert.ImplicitReferenceConversion,
13653 Convert.ImplicitReferenceConversionExists): Add support for
13654 generic type declarations; see gen-36.cs.
13656 2003-12-19 Martin Baulig <martin@ximian.com>
13658 * pending.cs (Pending.InterfaceMethod): Use
13659 `Type.IsAssignableFrom()' instead of `=='.
13661 2003-12-18 Martin Baulig <martin@ximian.com>
13663 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
13666 * convert.cs (Convert.ImplicitStandardConversionExists): Use
13667 `expr_type.Equals (target_type)' instead of `=='.
13669 2003-12-08 Martin Baulig <martin@ximian.com>
13671 * generics.cs (Constraints.Types): Removed.
13672 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
13674 (Constraints.ResolveTypes): New public method; resolves the
13675 TypeExpr's to Type's.
13676 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
13677 longer takes the constraints.
13678 (TypeParameter.DefineMethod): Likewise.
13679 (TypeParameter.DefineType): New public method. Calls
13680 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
13683 2003-12-08 Martin Baulig <martin@ximian.com>
13685 * convert.cs (Convert.ImplicitConversionStandard): Use
13686 `expr_type.Equals (target_type)' instead of `=='.
13688 2003-12-08 Martin Baulig <martin@ximian.com>
13690 * typemanager.cs (TypeManager.GetReferenceType): Call
13691 `Type.MakeByRefType ()'.
13693 2003-12-08 Martin Baulig <martin@ximian.com>
13695 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
13696 just has some special meaning in some situations. For instance,
13697 it is allowed to use `where' as the name of a variable etc.
13699 2003-12-04 Martin Baulig <martin@ximian.com>
13701 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13702 `Type.MakeArrayType()' for array types.
13704 2003-11-18 Miguel de Icaza <miguel@ximian.com>
13706 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
13709 (SizeOf.DoResolve): assign the `type_queried' field. This gets
13712 2003-11-16 Martin Baulig <martin@ximian.com>
13714 * codegen.cs (EmitContext.IsGeneric): Removed.
13716 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
13717 ResolveGeneric() on the DeclSpace.
13719 2003-11-16 Martin Baulig <martin@ximian.com>
13721 * generic.cs (TypeArguments.Resolve):
13722 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
13723 `ResolveType()' on it to get the Type.
13725 2003-11-15 Martin Baulig <martin@ximian.com>
13727 * generic.cs (ConstructedType.GetInterfaces): Override this.
13729 2003-11-14 Martin Baulig <martin@ximian.com>
13731 * interface.cs (Interface.DefineType): Define all type parameters
13732 before adding the interfaces we inherit.
13734 2003-11-11 Martin Baulig <martin@ximian.com>
13736 * generic.cs (ConstructedType.ResolveType): Always call
13737 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
13739 2003-11-10 Martin Baulig <martin@ximian.com>
13741 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
13742 (TypeManager.InitCoreTypes): Initialize them here, but instead of
13743 calling `ResolveType()' on them, directly assign their `Type'.
13745 2003-11-08 Martin Baulig <martin@ximian.com>
13747 * generic.cs (ConstructedType): Override `IsClass' etc.
13749 2003-11-08 Martin Baulig <martin@ximian.com>
13751 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
13752 return value and the `out parent' parameter.
13753 (TypeContainer.DefineType): Moved the CS0644 check into
13754 GetClassBases(). Don't pass the interface types to the
13755 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
13756 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
13758 * ecore.cs (TypeExpr.IsAttribute): New property.
13759 (TypeExpr.GetInterfaces): New method.
13761 * interface.cs (Interface.GetInterfaceTypeByName): Return a
13762 TypeExpr instead of a Type.
13763 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
13764 (Interface.DefineType): Don't pass the interface types to the
13765 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
13766 them later and then call `TypeBulider.AddInterfaceImplementation()'.
13768 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
13769 instead of a `Type[]'.
13770 (TypeManager.RegisterBuilder): Likewise.
13771 (TypeManager.AddUserInterface): Likewise.
13772 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
13773 `Type[]' and also return a `TypeExpr[]'.
13774 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
13776 2003-11-08 Martin Baulig <martin@ximian.com>
13778 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
13781 2003-11-08 Martin Baulig <martin@ximian.com>
13783 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
13784 TypeManager.ResolveExpressionTypes().
13786 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
13787 instead of an Expression.
13788 (TypeExpr): This is now an abstract base class for `TypeExpression'.
13789 (TypeExpression): New public class; formerly known as `TypeExpr'.
13791 * expression.cs (ComposedCast): Derive from TypeExpr.
13793 * typemanager.cs (TypeManager.system_*_expr): These are now
13794 TypExpr's instead of Expression's.
13795 (TypeManager.ResolveExpressionTypes): New public static function;
13796 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
13799 2003-11-06 Miguel de Icaza <miguel@ximian.com>
13801 * expression.cs (New.DoResolve): Do not dereference value that
13802 might be a null return.
13804 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
13805 sure that the constant value has the right type. Fixes an
13806 unreported bug, similar to 50425.
13808 * const.cs (Const.LookupConstantValue): Call
13809 ImplicitStandardConversionExists before doing a conversion to
13810 avoid havng the TypeManager.ChangeType do conversions.
13812 Reduced the number of casts used
13814 (Const.ChangeType): New routine to enable reuse of the constant
13815 type changing code from statement.
13817 * typemanager.cs (ChangeType): Move common initialization to
13818 static global variables.
13822 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
13823 every value type to go through, even if it was void. Fix that.
13825 * cs-tokenizer.cs: Use is_identifier_start_character on the start
13826 character of the define, and the is_identifier_part_character for
13827 the rest of the string.
13829 2003-11-05 Miguel de Icaza <miguel@ximian.com>
13831 * expression.cs (UnaryMutator.EmitCode): When I updated
13832 LocalVariableReference.DoResolve, I overdid it, and dropped an
13833 optimization done on local variable references.
13835 2003-11-04 Miguel de Icaza <miguel@ximian.com>
13837 * ecore.cs: Convert the return from Ldlen into an int.
13839 2003-10-20 Miguel de Icaza <miguel@ximian.com>
13841 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
13842 the accessibility, this is a special case for toplevel non-public
13843 classes (internal for instance).
13845 2003-10-20 Nick Drochak <ndrochak@gol.com>
13847 * ecore.cs: Fix typo and build. Needed another right paren.
13849 2003-10-19 Miguel de Icaza <miguel@ximian.com>
13851 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
13852 `internal' case regular and protected, but not allowing protected
13853 to be evaluated later. Bug 49840
13855 2003-10-15 Miguel de Icaza <miguel@ximian.com>
13857 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
13858 to kb.Nlast, and not the kb.nFirst to isolate the switch
13861 Extract the underlying type, so enumerations of long/ulong are
13862 treated like long/ulong.
13864 2003-10-14 Miguel de Icaza <miguel@ximian.com>
13866 * expression.cs (New): Overload the meaning of RequestedType to
13867 track the possible creation of the NewDelegate type, since
13868 DoResolve is invoked more than once for new constructors on field
13871 See bugs: #48800 and #37014
13873 * cs-parser.jay (declare_local_constants): Take an arraylist
13874 instead of a single constant.
13876 (local_constant_declaration): It should take a
13877 constant_declarators, not a constant_declarator. Fixes 49487
13879 * convert.cs: Fix error report.
13881 2003-10-13 Jackson Harper <jackson@ximian.com>
13883 * typemanager.cs (TypeToCoreType): Add float and double this fixes
13886 2003-11-03 Martin Baulig <martin@ximian.com>
13888 * expression.cs (ArrayAccess.GetStoreOpcode): Added
13889 `out bool has_type_arg'; if set, we need to pass the type to
13891 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
13892 Stelem_Any/Ldelem_Any for generic parameters.
13894 2003-11-02 Martin Baulig <martin@ximian.com>
13896 * expression.cs (Invocation.EmitCall): Use
13897 `TypeManager.IsValueType()' to check whether it's a value type.
13898 Don't set `struct_call' when calling a method on a type parameter.
13900 2003-11-02 Martin Baulig <martin@ximian.com>
13902 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
13903 and removed the TypeBuilder argument.
13905 * typemanager.cs (TypeManager.IsValueType): Return
13906 `t.IsGenericParameter || t.IsValueType'.
13908 2003-10-25 Martin Baulig <martin@ximian.com>
13910 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
13911 call ConstructedType.Resolve() on it.
13913 * generic.cs (ConstructedType.Resolve): Set `type' on success.
13915 2003-10-25 Martin Baulig <martin@ximian.com>
13917 * class.cs (TypeContainer.GetClassBases): Changed
13918 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
13919 CS8214 reporting here.
13920 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
13921 instead of a `Type' for our parent. In case of a recursive
13922 declaration (see tests/gen-23.cs for an example), our parent is a
13923 ConstructedType and it doesn't have its type set. So, first
13924 create our own TypeBuilder, then call constructed.Resolve() to get
13925 the parent's type and finally TypeBuilder.SetParent() it.
13927 * ecore.cs (TypeExpr.Name): New public virtual property.
13930 (ConstructedType): We're now a TypeExpr and not just an Expression.
13931 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
13932 arguments here; this is done later.
13933 (ConstructedType.Resolve): New public method to resolve the type
13934 arguments and bind them.
13936 2003-10-21 Martin Baulig <martin@ximian.com>
13938 * convert.cs: Use `TypeManager.IsValueType' instead of
13939 'type.IsValueType' everywhere.
13941 * typemanager.cs (TypeManager.IsValueType): Return true for type
13942 parameters. The reason for this is that we need to box a type
13943 parameter when converting it to a reference type.
13945 * cs-parser.jay: Added support for default value expressions.
13947 * generics.cs (DefaultValueExpression): New public class.
13949 2003-10-17 Martin Baulig <martin@ximian.com>
13951 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
13952 TypeContainer so we can also use this for Interfaces.
13953 (TypeParameter.Resolve): Likewise.
13955 * interface.cs (Interface.DefineType): Added support for generic
13958 * cs-parser.jay: Added support for generic structs and interfaces.
13960 2003-10-17 Martin Baulig <martin@ximian.com>
13962 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
13963 call generic methods :-)
13965 2003-10-16 Martin Baulig <martin@ximian.com>
13967 * cs-parser.jay (namespace_or_type_name): Only create a
13968 GenericMemberAccess if we actually have type arguments.
13970 2003-10-13 Martin Baulig <martin@ximian.com>
13972 * class.cs (Method.Define): If we're a generic method, call
13973 TypeBuilder.DefineGenericMethod () before resolving
13975 (MethodData): Added .ctor which takes an additional MethodBuilder
13976 argument; this is used for generic methods.
13977 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
13978 we already have a MethodBuilder.
13980 2003-10-10 Martin Baulig <martin@ximian.com>
13982 * class.cs (Method): Added .ctor which takes a `GenericMethod'
13983 instead of a `DeclSpace'. This is used for generic methods.
13985 * cs-parser.jay (method_header): Added support for generic
13986 methods; create a `GenericMethod' instance and pass it to the
13987 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
13988 parameters and locals.
13990 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
13991 since we already have the location. Check whether we're a generic
13992 type declaration or a generic method and create the correct type
13995 * generic.cs (TypeParameter.DefineMethod): New public method.
13996 (GenericMethod): New public class; derives from DeclSpace and is
13997 used for generic methods.
13999 2003-10-09 Martin Baulig <martin@ximian.com>
14001 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
14003 (MethodCore.DoDefineParameters): Removed the TypeContainer
14004 argument; use the DeclSpace which was passed to the .ctor instead.
14005 (MethodCore.CheckParameter): Take a DeclSpace instead of a
14006 TypeContainer; we only need a DeclSpace here.
14008 2003-10-09 Martin Baulig <martin@ximian.com>
14010 * class.cs (MethodData): Added additional `DeclSpace ds' argument
14012 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
14013 EmitContext's .ctor.
14015 2003-10-09 Martin Baulig <martin@ximian.com>
14017 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
14018 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
14019 AsAccessible(), moved them as well.
14021 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
14023 2003-10-07 Miguel de Icaza <miguel@ximian.com>
14025 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
14026 generation for >=, as spotted by Paolo, bug 48679.
14027 Patch from David Waite.
14029 * cs-tokenizer.cs: Add handling for #pragma.
14031 * cs-parser.jay: Allow for both yield and yield return in the
14032 syntax. The anti-cobolization of C# fight will go on!
14034 * class.cs (TypeBuilder.DefineType): Catch error condition here
14035 (Parent.DefineType erroring out and returning null).
14037 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
14038 coping with enumerations variables, we were mistakenly processing
14039 them as a regular value type instead of built-in types. Fixes the
14042 * typemanager.cs (IsBuiltinOrEnum): New method.
14044 2003-09-30 Miguel de Icaza <miguel@ximian.com>
14046 * cs-parser.jay: Upgrade: yield now needs the return clause.
14048 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
14050 * cs-parser.jay : Renamed yyName to yyNames related to jay.
14052 2003-09-29 Martin Baulig <martin@ximian.com>
14054 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
14055 inflated generic methods.
14057 * generics.cs (ConstructedType): Distinguish between open and
14058 closed constructed types; correctly resolve the arguments.
14060 2003-09-22 Martin Baulig <martin@ximian.com>
14062 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
14063 all type arguments meet their constraints.
14065 2003-09-19 Martin Baulig <martin@ximian.com>
14067 * decl.cs (MemberCache.SetupCacheForInterface): Take a
14068 `MemberCache parent' argument. Normally, an interface doesn't
14069 have a parent type except System.Object, but we use this in gmcs
14070 for generic type parameters.
14072 2003-09-18 Martin Baulig <martin@ximian.com>
14074 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
14075 on `type.IsInterface'; don't check whether the type has a parent
14076 to determine whether it's an interface.
14078 2003-09-17 Martin Baulig <martin@ximian.com>
14080 * generic.cs (ConstructedType.ToString): Always use `name' as the
14083 2003-09-15 Martin Baulig <martin@ximian.com>
14085 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
14087 * generic.cs (Constraints.Resolve): New public method; this is
14088 called to resolve the constraint types and to check whether all
14089 the constraints are correct.
14090 (Constraints.Types): New public property.
14091 (TypeParameter.Resolve): New public method; resolves all the
14092 type's constraints.
14094 * class.cs (TypeContainer.DefineType): Call
14095 TypeParameter.Resolve() before actually defining the type.
14097 2003-09-15 Martin Baulig <martin@ximian.com>
14099 * class.cs (TypeContainer.DefineType): Added an error flag to
14100 avoid reporting duplicate CS0146's ("class definition is
14103 * driver.cs (Driver.MainDriver): Abort if
14104 RootContext.ResolveTree() reported any errors.
14106 2003-09-07 Martin Baulig <martin@ximian.com>
14108 * report.cs (Error, Warning): Added overloaded versions which take
14109 a `params object[] args' and call String.Format().
14111 2003-09-07 Martin Baulig <martin@ximian.com>
14113 * decl.cs (DeclSpace..ctor): Don't call
14114 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
14115 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
14116 (DeclSpace.RecordDecl): New method.
14118 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
14120 2003-09-02 Ravi Pratap <ravi@ximian.com>
14122 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
14123 value attributes to be applied to ParameterBuilders.
14125 * class.cs (MethodCore.LabelParameters): Make static and more
14126 generic so that it can be used from other places - like interface
14127 methods, for instance.
14129 * interface.cs (Interface.Emit): Call LabelParameters before
14130 emitting attributes on the InterfaceMethod.
14132 2003-09-07 Martin Baulig <martin@ximian.com>
14134 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
14135 if the number of type parameters doesn't match.
14137 2003-09-04 Martin Baulig <martin@ximian.com>
14139 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
14140 for arrays of generic type params (ie. `!0[]').
14142 2003-09-04 Martin Baulig <martin@ximian.com>
14144 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
14147 2003-09-04 Martin Baulig <martin@ximian.com>
14149 * decl.cs (DeclSpace.LookupGeneric): New method.
14150 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
14153 * generic.cs (TypeParameterExpr): Take a TypeParameter as
14154 argument, not just a string.
14155 (TypeParameter.Define): New public method; this is called to
14156 actually define the generic parameter; after this, you can use the
14157 new `Type' property to get the type.
14159 2003-09-04 Martin Baulig <martin@ximian.com>
14161 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
14162 is now an ArrayList; initialize the result of the `TypeParameters'
14164 (DeclSpace.GetGenericData): Removed.
14165 (DeclSpace.LookupGeneric): Temporarily removed; we need to
14166 implement this in a different way.
14167 (DeclSpace.GetTypeParameters): Removed; there's now a
14168 `TypeParameters' property.
14169 (DeclSpace.TypeParameters): New public property.
14171 * generic.cs (Constraints): Make this class public.
14172 (TypeParameter): New public class.
14174 2003-09-04 Martin Baulig <martin@ximian.com>
14176 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
14177 generic parameters.
14179 * class.cs (TypeContainer.DefineType): Call
14180 TypeBuilder.DefineGenericParameter () on all generic parameters if
14181 this is a generic type.
14183 2003-08-28 Martin Baulig <martin@ximian.com>
14185 * sample-stack.il: Compile this with ilasm: "ilasm /dll
14188 * sample-hello.cs: Compile this with gmcs: "gmcs
14189 /r:sample-stack.dll sample-hello.cs".
14191 2003-08-28 Martin Baulig <martin@ximian.com>
14193 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
14194 the parameters to the generic type.
14196 2003-08-28 Martin Baulig <martin@ximian.com>
14198 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
14200 2003-08-28 Martin Baulig <martin@ximian.com>
14202 * cs-parser.jay (opt_type_argument_list): Use
14203 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
14204 (primary_expression): Replace `qualified_identifier' with `type_name'.
14205 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
14207 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
14208 parser to check whether it is syntactically a type parameter list;
14209 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
14212 2003-08-26 Martin Baulig <martin@ximian.com>
14214 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
14215 resolving aliases; fixes #47927.
14217 2003-08-26 Martin Baulig <martin@ximian.com>
14219 * statement.cs (Using.DoResolve): This is internally emitting a
14220 try/finally clause, so we need to set ec.NeedExplicitReturn if we
14221 do not always return. Fixes #47681.
14223 2003-08-26 Martin Baulig <martin@ximian.com>
14225 * decl.cs (MemberCore): Moved WarningNotHiding(),
14226 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
14228 (AdditionResult): Make this nested in DeclSpace.
14229 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
14230 argument; call NamespaceEntry.Define() unless we're nested in a
14233 * namespace.cs (Namespace.DefineName): New public function. This
14234 is called from DeclSpace's .ctor to add
14235 (Namespace.Lookup): Include DeclSpaces in the lookup.
14237 * class.cs (Operator): Derive from MemberBase, not MemberCore.
14239 * const.cs (Const): Derive from MemberBase, not MemberCore.
14241 2003-08-25 Martin Baulig <martin@ximian.com>
14243 * convert.cs (Convert.ExplicitReferenceConversion): When
14244 converting from an interface type to a class, unbox if the target
14245 type is a struct type. Fixes #47822.
14247 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14249 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
14252 2003-08-22 Martin Baulig <martin@ximian.com>
14254 * class.cs (TypeManager.DefineType): When defining a nested type,
14255 call DefineType() on our parent; fixes #47801.
14257 2003-08-22 Martin Baulig <martin@ximian.com>
14259 * class.cs (MethodData.Define): While checking if a method is an
14260 interface implementation, improve the test a bit more to fix #47654.
14262 2003-08-22 Martin Baulig <martin@ximian.com>
14264 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
14265 correctly; fixes #47722.
14267 2003-08-22 Martin Baulig <martin@ximian.com>
14269 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
14270 LocalVariableReference, ensure it's not read-only. Fixes #47536.
14272 * statement.cs (Fixed.DoResolve): Make all variables read-only.
14274 2003-08-22 Martin Baulig <martin@ximian.com>
14276 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
14277 can only be assigned in static constructors. Fixes #47161.
14279 2003-08-22 Martin Baulig <martin@ximian.com>
14281 Rewrote and improved the flow analysis code.
14283 * flowbranching.cs (FlowBranching): Make this class abstract.
14284 (FlowBranching.CreateBranching): New static function to create a
14285 new flow branching.
14286 (FlowBranchingBlock, FlowBranchingException): New classes.
14287 (FlowBranching.UsageVector.Type): New public readonly field.
14288 (FlowBranching.UsageVector.Breaks): Removed the setter.
14289 (FlowBranching.UsageVector.Returns): Removed the setter.
14290 (FlowBranching.UsageVector): Added Break(), Return(),
14291 NeverReachable() and Throw() methods to modify the reachability.
14292 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
14293 done by FlowBranching.Merge().
14294 (FlowBranching.UsageVector.MergeChild): New method; merges the
14295 merge result into the current vector.
14296 (FlowBranching.Merge): New abstract method to merge a branching.
14298 2003-08-12 Martin Baulig <martin@ximian.com>
14300 * expression.cs (Indirection.CacheTemporaries): Create the
14301 LocalTemporary with the pointer type, not its element type.
14303 2003-08-10 Miguel de Icaza <miguel@ximian.com>
14305 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
14306 token was a keyword or not.
14308 Add `error' options where an IDENTIFIER was expected; Provide
14309 CheckToken and CheckIdentifierToken convenience error reporting
14312 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
14314 * decl.cs: Rename `NamespaceEntry Namespace' public field into
14315 NameSpaceEntry NameSpaceEntry.
14317 (LookupInterfaceOrClass): Avoid creating a full qualified name
14318 from namespace and name: avoid doing lookups when we know the
14319 namespace is non-existant. Use new Tree.LookupByNamespace which
14320 looks up DeclSpaces based on their namespace, name pair.
14322 * driver.cs: Provide a new `parser verbose' to display the
14323 exception thrown during parsing. This is turned off by default
14324 now, so the output of a failure from mcs is more graceful.
14326 * namespace.cs: Track all the namespaces defined in a hashtable
14329 (IsNamespace): New method
14331 2003-08-09 Miguel de Icaza <miguel@ximian.com>
14333 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
14334 we know that we need to concatenate (full typename can never be
14339 * statement.cs: Use a bitfield; Do not initialize to null things
14340 which are done by the constructor by default.
14342 * cs-parser.jay: bug fix, parameter was 4, not 3.
14344 * expression.cs: Just use the property;
14346 * statement.cs: No need for GetVariableInfo method.
14348 2003-08-08 Martin Baulig <martin@ximian.com>
14350 * flowanalysis.cs (FlowReturns): This is now nested in the
14351 `FlowBranching' class.
14352 (MyBitVector): Moved this here from statement.cs.
14353 (FlowBranching.SiblingType): New enum type.
14354 (FlowBranching.CreateSibling): Added `SiblingType' argument.
14356 2003-08-07 Martin Baulig <martin@ximian.com>
14358 * flowanalysis.cs (FlowBranchingType): This is now nested in the
14359 `FlowBranching' class and called `BranchingType'.
14361 2003-08-07 Martin Baulig <martin@ximian.com>
14363 * flowanalysis.cs: Moved all the control flow analysis code into
14366 2003-08-07 Martin Baulig <martin@ximian.com>
14368 * assign.cs (Assign.DoResolve): `target' must either be an
14369 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
14372 2003-08-07 Miguel de Icaza <miguel@ximian.com>
14374 * expression.cs (BinaryMethod): This kind of expression is created by the
14375 Binary class if it determines that the operator has to be handled
14378 (BinaryDelegate): This kind of expression is created if we are
14379 dealing with a + or - operator on delegates.
14381 (Binary): remove method, argumetns, and DelegateOperator: when
14382 dealing with methods,
14384 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
14386 * statement.cs (Block): use bitfields for the three extra booleans
14387 we had in use. Remove unused topblock parameter.
14389 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
14391 * assign.cs: Drop extra unneeded tests.
14393 2003-08-06 Miguel de Icaza <miguel@ximian.com>
14395 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
14397 * statement.cs (Foreach): Use VariableStorage instead of
14400 * codegen.cs (VariableStorage): New class used by clients that
14401 require a variable stored: locals or fields for variables that
14402 need to live across yield.
14404 Maybe provide a convenience api for EmitThis+EmitLoad?
14406 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
14409 2003-08-05 Miguel de Icaza <miguel@ximian.com>
14411 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
14412 RemapParameterLValue): New methods that are used to turn a
14413 precomputed FieldInfo into an expression like this:
14417 The idea is to use this instead of making LocalVariableReference
14418 have more than one meaning.
14420 * cs-parser.jay: Add error production to BASE.
14422 * ecore.cs: Deal with TypeManager.GetField returning null, which
14423 is now a valid return value.
14425 (FieldExprNoAddress): New expression for Fields whose address can
14428 * expression.cs (LocalVariableReference): During the resolve
14429 phases, create new expressions if we are in a remapping context.
14430 Remove code that dealt with remapping here.
14432 (ParameterReference): same.
14434 (ProxyInstance): New expression, like the `This' expression, but
14435 it is born fully resolved. We know what we are doing, so remove
14436 the errors that are targeted to user-provided uses of `this'.
14438 * statement.cs (Foreach): our variable is now stored as an
14439 Expression; During resolution, follow the protocol, dont just
14440 assume it will return this.
14442 2003-08-06 Martin Baulig <martin@ximian.com>
14444 * support.cs (SeekableStreamReader.cs): New public class.
14446 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
14447 SeekableStreamReader instead of the normal StreamReader.
14449 2003-08-04 Martin Baulig <martin@ximian.com>
14451 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
14452 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
14453 deambiguate casts and delegate invocations.
14454 (parenthesized_expression): Use the new tokens to ensure this is
14455 not a cast of method invocation.
14457 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
14458 when reading a `)' and Deambiguate_CloseParens () was previously
14461 * expression.cs (ParenthesizedExpression): New class. This is
14462 just used for the CS0075 test.
14463 (Binary.DoResolve): Check for CS0075.
14465 2003-07-29 Ravi Pratap <ravi@ximian.com>
14467 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
14468 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
14469 reference comparison.
14471 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
14472 examine the ReturnType for equality - this is necessary in the
14473 cases of implicit and explicit operators whose signature also
14474 includes the return type.
14476 2003-07-26 Miguel de Icaza <miguel@ximian.com>
14478 * namespace.cs: Cache the result of the namespace computation,
14479 instead of computing it every time.
14481 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14483 * decl.cs: Use a global arraylist that we reuse over invocations
14484 to avoid excesive memory consumption. Reduces memory usage on an
14485 mcs compile by one meg (45 average).
14487 * typemanager.cs (LookupTypeReflection): In .NET pointers are
14488 private, work around that.
14490 2003-07-23 Miguel de Icaza <miguel@ximian.com>
14492 * literal.cs (IntLiteral): Define Zero and One static literals.
14494 * cs-parser.jay (integer_literal): use static literals to reduce
14495 memory usage for the most used literals (0, 1 and -1). 211kb
14496 reduced in memory usage.
14498 Replace all calls to `new ArrayList' with `new
14499 ArrayList(4)' which is a good average number for most allocations,
14500 and also requires only 16 bytes of memory for its buffer by
14503 This reduced MCS memory usage in seven megabytes for the RSS after
14506 2003-07-28 Ravi Pratap <ravi@ximian.com>
14508 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
14509 handle params methods the correct way by forming only one
14510 applicable set with params and normal methods in them. Earlier we
14511 were looking at params methods only if we found no normal methods
14512 which was not the correct thing to do.
14514 (Invocation.BetterFunction): Take separate arguments indicating
14515 when candidate and the best method are params methods in their
14518 This fixes bugs #43367 and #46199.
14520 * attribute.cs: Documentation updates.
14522 (CheckAttribute): Rename to CheckAttributeTarget.
14523 (GetValidPlaces): Rename to GetValidTargets.
14525 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
14526 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
14530 2003-07-28 Miguel de Icaza <miguel@ximian.com>
14532 * codegen.cs: Compute IsGeneric correctly.
14534 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
14537 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
14538 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
14539 regressions, and I was chasing more bugs than I required.
14541 * interface.cs: Use expressions for base type names (like classes
14542 and structs have been doing for a while now), and resolve that.
14543 This patch should probably go into head as well.
14545 This makes it one less user of FindType.
14547 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14549 This compiler can not self host currently. Need to fix that.
14551 * Makefile: compile to `gmcs.exe'
14553 * driver.cs: Turn on v2 by default on gmcs.
14555 * generic.cs (ConstructedType): Does no longer take a container
14556 type argument; That will be taken care of later.
14558 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
14559 Use SimpleName to resolve for now, so we can continue the work on
14560 the parser, until we get Type.GetType that understands generics.
14562 (ConstructedType.ToString): Implement
14564 (TypeArguments.Resolve): Resolve the child expressions as types.
14566 * cs-parser.jay: Rename interface_constraints to
14567 type_parameter_constraints
14569 (namespace_or_type_name): Only use constructed types for the basic
14570 construction, we will deal with identifier<...> later.
14572 (type/type_name): No longer call DecomposeQI, as
14573 namespace_or_type_name is always decoded now.
14575 2003-07-22 Ravi Pratap <ravi@ximian.com>
14577 * expression.cs (Invocation.OverloadResolve): Follow the spec more
14578 closely: we eliminate methods in base types when we have an
14579 applicable method in a top-level type.
14581 Please see section 14.5.5.1 for an exact description of what goes
14584 This fixes bug #45127 and a host of other related to corlib compilation.
14586 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
14587 array is the method corresponding to the top-level type (this is
14588 because of the changes made to icall.c) so we change this
14591 (MethodGroupExpr.Name): This too.
14593 * typemanager.cs (GetElementType): New method which does the right
14594 thing when compiling corlib.
14596 * everywhere: Make use of the above in the relevant places.
14598 2003-07-22 Martin Baulig <martin@ximian.com>
14600 * cs-parser.jay (invocation_expression): Moved
14601 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
14602 `cast_expression', but create a InvocationOrCast which later
14603 resolves to either an Invocation or a Cast.
14605 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
14606 method; call this before EmitStatement() to make sure that this
14607 expression can be used as a statement.
14609 * expression.cs (InvocationOrCast): New class; resolves to either
14610 an Invocation or a Cast.
14612 * statement.cs (StatementExpression): Call ResolveStatement() on
14613 the ExpressionStatement before emitting it.
14615 2003-07-21 Martin Baulig <martin@ximian.com>
14617 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
14618 `ref' and `out' attributes match; fixes #46220.
14619 (MemberAccess.ResolveMemberAccess): You can't reference a type
14620 through an expression; fixes #33180.
14621 (Indexers.GetIndexersForType): Don't return the indexers from
14622 interfaces the class implements; fixes #46502.
14624 2003-07-21 Martin Baulig <martin@ximian.com>
14626 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
14627 CS0661 checks; fixes bug #30442.
14629 2003-07-21 Martin Baulig <martin@ximian.com>
14631 * decl.cs (AdditionResult): Added `Error'.
14633 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
14635 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
14636 cs0031.cs actually work.
14638 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14640 * cs-parser.jay (namespace_name): do not use
14641 namespace_or_type_name, use qualified_identifier, because
14642 namespace_or_type_name will soon return a composed expression
14643 instead of a string.
14645 (namespace_or_type_name): Instead of returning a string, now this
14646 production returns an expression.
14648 * codegen.cs (EmitContext): Setup IsGeneric property based on
14649 whether our DeclSpace is generic, our the method is generic.
14651 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
14652 the method is generic.
14654 * cs-parser.jay (type_arguments, opt_type_argument_list,
14655 type_parameters, type_parameter_list, opt_type_parameter_list,
14656 type_parameter,, opt_type_parameter_constraints_clauses,
14657 type_parameter_constraints_clauses,
14658 type_parameter_constraint_clause, type_parameter_constraint,
14659 interface_constraints): Add new production
14661 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
14662 DeclSpace is generic or not.
14664 (DeclSpace.SetParameterInfo): New routine, used to set the
14665 parameter info for a type.
14667 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
14668 returns a GenericTypeExpr
14670 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
14671 generic, lookup the generic argument.
14673 * attribute.cs: Do not allow TypeParameterExpressions in
14676 * class.cs: Do not allow the Main method to be defined in a
14679 * expression.cs (SizeOf): Do not allow generic types to be used as
14680 arguments to sizeof.
14682 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
14683 it: whether a type is generic or not. Only works for types we are
14684 currently building for now.
14686 2003-07-20 Martin Baulig <martin@ximian.com>
14688 * namespace.cs: Fixed that bug which caused a crash when compiling
14689 the debugger's GUI.
14691 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14693 * typemanager.cs (LookupTypeReflection): Never expose types which
14694 are NotPublic, NestedPrivate, NestedAssembly, or
14695 NestedFamANDAssem. We used to return these, and later do a check
14696 that would report a meaningful error, but the problem is that we
14697 would not get the real match, if there was a name override.
14699 2003-07-18 Miguel de Icaza <miguel@ximian.com>
14701 * namespace.cs (Namespace, Name): Do not compute the namespace
14702 name dynamically, compute it in the constructor. This reduced
14703 memory usage by 1697 KB.
14705 * driver.cs: Use --pause to pause at the end.
14707 2003-07-17 Peter Williams <peter@newton.cx>
14709 * Makefile: Change the name of the test target so that it doesn't
14710 conflict with the recursive test target.
14712 2003-07-17 Miguel de Icaza <miguel@ximian.com>
14714 * expression.cs (LocalVariableReference.Emit, EmitAssign,
14715 AddressOf): Do not use EmitThis, that was wrong, use the actual
14718 2003-07-15 Miguel de Icaza <miguel@ximian.com>
14720 * class.cs (MethodData.Define): While checking if a method is an
14721 interface implementation, improve the test: If we are not public
14722 (use new test here: use the computed MethodAttributes directly,
14723 instead of the parsed modifier flags) check if the `implementing'
14724 method comes from an interface or not.
14726 * pending.cs (VerifyPendingMethods): Slightly better error
14729 * makefile: add test target that does the mcs bootstrap.
14731 2003-07-16 Ravi Pratap <ravi@ximian.com>
14733 * interface.cs (Define): Do nothing here since there are no
14734 members to populate etc. Move the attribute emission out of here
14735 since this was just totally the wrong place to put it. Attribute
14736 application happens during the 'Emit' phase, not in the 'Define'
14739 (Emit): Add this method and move the attribute emission here
14741 * rootcontext.cs (EmitCode): Call the Emit method on interface
14744 2003-07-14 Ravi Pratap M <ravi@ximian.com>
14746 * expression.cs (OverloadResolve): Report error only if Location
14747 is not 'Null' which means that there was a probe going on.
14749 2003-07-14 Martin Baulig <martin@ximian.com>
14751 * expression.cs (ConditionalLogicalOperator): New public class to
14752 implement user defined conditional logical operators.
14753 This is section 14.11.2 in the spec and bug #40505.
14755 2003-07-14 Martin Baulig <martin@ximian.com>
14757 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
14759 2003-07-14 Martin Baulig <martin@ximian.com>
14761 * codegen.cs (EmitContext.InFixedInitializer): New public field.
14763 * ecore.cs (IVariable.VerifyFixed): New interface method.
14765 * expression.cs (Unary.ResolveOperator): When resolving the `&'
14766 operator, check whether the variable is actually fixed. Fixes bug
14767 #36055. Set a variable definitely assigned when taking its
14768 address as required by the spec.
14770 * statement.cs (LocalInfo.IsFixed): New field.
14771 (LocalInfo.MakePinned): Set `IsFixed' to true.
14773 2003-07-14 Ravi Pratap M <ravi@ximian.com>
14775 * attribute.cs (Attribute.Resolve): While doing a Member lookup
14776 for .ctors, ensure that we only ask for members declared in the
14777 attribute type (BindingFlags.DeclaredOnly).
14781 * expression.cs (Error_WrongNumArguments): Report error 1501
14782 correctly the way CSC does.
14784 2003-07-13 Martin Baulig <martin@ximian.com>
14786 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
14787 lookup on the fully qualified name, to make things like "X.X" work
14788 where "X.X" is a fully qualified type name, but we also have a
14789 namespace "X" in the using list. Fixes #41975.
14791 2003-07-13 Martin Baulig <martin@ximian.com>
14793 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
14794 function. If we're a CompoundAssign, we need to create an embedded
14795 CompoundAssign, not an embedded Assign.
14796 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
14799 2003-07-13 Martin Baulig <martin@ximian.com>
14801 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
14802 work to fix bug #46088.
14804 2003-07-13 Ravi Pratap <ravi@ximian.com>
14806 * class.cs (Operator.Emit): Do not emit attributes here - it is
14807 taken care of by the Method class that we delegate too. This takes
14808 care of bug #45876.
14810 2003-07-10 Martin Baulig <martin@ximian.com>
14812 * expression.cs (TypeOfVoid): New class.
14813 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
14815 2003-07-10 Martin Baulig <martin@ximian.com>
14817 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
14820 2003-07-10 Martin Baulig <martin@ximian.com>
14822 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
14823 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
14825 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
14827 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
14829 2003-07-10 Martin Baulig <martin@ximian.com>
14831 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
14832 of decimal. Fixes #42850.
14834 NOTE: I also fixed the created byte blob, but this doesn't work on
14835 the MS runtime and csc never produces any byte blobs for decimal
14838 2003-07-10 Martin Baulig <martin@ximian.com>
14840 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
14841 structs; fixes #32068.
14842 (Block.AddChildVariableNames): Fixed #44302.
14844 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14846 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
14848 2003-07-07 Miguel de Icaza <miguel@ximian.com>
14850 * attribute.cs: And this test is onger needed.
14852 2003-07-08 Martin Baulig <martin@ximian.com>
14854 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
14855 inaccessible types. Fixes #36313.
14857 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
14859 * namespace.cs (NamespaceEntry): Create implicit entries for all
14860 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
14861 implicit entries for N1.N2 and N1.
14863 2003-07-08 Martin Baulig <martin@ximian.com>
14865 Rewrote the handling of namespaces to fix a lot of the issues
14866 wrt. `using' aliases etc.
14868 * namespace.cs (Namespace): Splitted this class into a
14869 per-assembly `Namespace' and a per-file `NamespaceEntry'.
14871 * typemanager.cs (TypeManager.IsNamespace): Removed.
14872 (TypeManager.ComputeNamespaces): Only compute namespaces from
14873 loaded assemblies here, not the namespaces from the assembly we're
14874 currently compiling.
14876 2003-07-08 Martin Baulig <martin@ximian.com>
14878 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
14880 2003-07-07 Miguel de Icaza <miguel@ximian.com>
14882 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
14885 I thought about the memory savings here, but LookupTypeReflection
14886 is used under already very constrained scenarios. Compiling
14887 corlib or mcs only exposes one hit, so it would not really reduce
14888 any memory consumption.
14890 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14892 * typemanager.cs: fixes bug #45889 by only adding public types from
14893 other assemblies to the list of known types.
14895 2003-07-07 Miguel de Icaza <miguel@ximian.com>
14897 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
14898 on the type we resolved.
14900 2003-07-05 Martin Baulig <martin@ximian.com>
14902 * pending.cs (PendingImplementation.ParentImplements): Don't
14903 create the proxy if the parent is abstract.
14905 * class.cs (TypeContainer.DefineIndexers): Process explicit
14906 interface implementations first. Fixes #37714.
14908 2003-07-04 Miguel de Icaza <miguel@ximian.com>
14910 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
14911 defined recursively; but since we modify the input parameters
14912 (left is set to `this' temporarily), we reset this value if the
14913 left_is_explicit is false, which gives the original semantics to
14916 * literal.cs (NullPointer): new class used to represent a null
14917 literal in a pointer context.
14919 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
14920 type is a pointer, use a NullPointer object instead of a
14921 NullLiteral. Closes 43687
14923 (ExplicitConversion): Convert pointer values using
14924 the conv opcode to the proper type.
14926 * ecore.cs (New): change ValueTypeVariable property into a method,
14927 that returns whether the valuetype is suitable for being used.
14929 * expression.cs (Binary.DoNumericPromotions): Only return if we
14930 the int constant was a valid uint, and we can return both left and
14931 right as uints. If not, we continue processing, to trigger the
14932 type conversion. This fixes 39018.
14934 * statement.cs (Block.EmitMeta): During constant resolution, set
14935 the CurrentBlock property on the emitcontext, so that we resolve
14936 constants propertly.
14938 2003-07-02 Martin Baulig <martin@ximian.com>
14940 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
14941 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
14943 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
14944 than emitting it here.
14946 * statement.cs: Fixed some more flow analysis bugs.
14948 2003-07-02 Martin Baulig <martin@ximian.com>
14950 * class.cs (MethodData.Define): When implementing interface
14951 methods, set Final unless we're Virtual.
14953 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
14954 check work for interface methods.
14956 2003-07-01 Martin Baulig <martin@ximian.com>
14958 * ecore.cs (EmitContext.This): Replaced this property with a
14959 GetThis() method which takes a Location argument. This ensures
14960 that we get the correct error location for a CS0188.
14962 2003-07-01 Miguel de Icaza <miguel@ximian.com>
14964 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
14965 ImplicitStandardConversion.
14967 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
14969 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
14971 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
14974 2003-06-30 Miguel de Icaza <miguel@ximian.com>
14976 * class.cs (Constructor.Define): Turn off initlocals for unsafe
14979 (MethodData.Define): Turn off initlocals for unsafe methods.
14981 2003-06-29 Miguel de Icaza <miguel@ximian.com>
14983 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
14984 complete; Fixes #37521.
14986 * delegate.cs: Use Modifiers.TypeAttr to compute the
14987 TypeAttributes, instead of rolling our own. This makes the flags
14988 correct for the delegates.
14990 2003-06-28 Miguel de Icaza <miguel@ximian.com>
14992 * class.cs (Constructor.Define): Set the private flag for static
14993 constructors as well.
14995 * cs-parser.jay (statement_expression): Set the return value to
14996 null, to avoid a crash when we catch an error.
14998 2003-06-24 Miguel de Icaza <miguel@ximian.com>
15000 * cs-parser.jay: Applied patch from Jackson that adds support for
15001 extern and unsafe modifiers to destructor declarations.
15003 * expression.cs: Report error 21 if the user is trying to index a
15006 * driver.cs: Add an error message, suggested by the bug report.
15008 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
15009 if we do not have a ": this ()" constructor initializer. Fixes 45149
15011 2003-06-14 Miguel de Icaza <miguel@ximian.com>
15013 * namespace.cs: Add some information to reduce FAQs.
15015 2003-06-13 Miguel de Icaza <miguel@ximian.com>
15017 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
15018 underlying enumeration types. Fixes #43915.
15020 * expression.cs: Treat ushort/short as legal values to be used in
15021 bitwise operations.
15023 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
15025 * delegate.cs: transfer custom attributes for paramenters from
15026 the delegate declaration to Invoke and BeginInvoke.
15028 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
15030 * attribute.cs: handle custom marshalers and emit marshal info
15033 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
15035 * makefile.gnu: Added anonymous.cs to the compiler sources.
15037 2003-05-28 Miguel de Icaza <miguel@ximian.com>
15039 * iterators.cs: Change the name of the proxy class to include two
15042 * cs-parser.jay: Update grammar to include anonymous methods.
15044 * anonymous.cs: new file.
15046 2003-05-27 Miguel de Icaza <miguel@ximian.com>
15048 * class.cs (Field.Define): Add missing test for pointers and
15051 2003-05-27 Ravi Pratap <ravi@ximian.com>
15053 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
15054 we use the stobj opcode.
15056 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
15057 since it wasn't the correct fix.
15059 It still is puzzling that we are required to use stobj for IntPtr
15060 which seems to be a ValueType.
15062 2003-05-26 Miguel de Icaza <miguel@ximian.com>
15064 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
15065 during regular simple name resolution. Now, the trick is that
15066 instead of returning for processing the simplename, we do a
15067 TypeManager.LookupType (ie, a rooted lookup as opposed to a
15068 contextual lookup type). If a match is found, return that, if
15069 not, return for further composition.
15071 This fixes long-standing 30485.
15073 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15074 using the address to initialize an object, do an Stobj instead of
15075 using the regular Stelem.
15077 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
15078 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
15079 Because if we are a BaseIndexerAccess that value will be true.
15082 * statement.cs (GotoCase.Resolve): Return after reporting an
15083 error, do not attempt to continue.
15085 * expression.cs (PointerArithmetic.Emit): If our operand is a
15086 long, convert our constants to match the operand before
15087 multiplying. Convert to I type before adding. Fixes 43670.
15089 2003-05-14 Ravi Pratap <ravi@ximian.com>
15091 * enum.cs (ImplicitConversionExists) : Rename to
15092 ImplicitEnumConversionExists to remove ambiguity.
15094 * ecore.cs (NullCast): New type of cast expression class which
15095 basically is very similar to EmptyCast with the difference being
15096 it still is a constant since it is used only to cast a null to
15098 (eg. (string) null)
15100 * convert.cs (ImplicitReferenceConversion): When casting a null
15101 literal, we return a NullCast.
15103 * literal.cs (NullLiteralTyped): Remove - I don't see why this
15104 should be around anymore.
15106 The renaming (reported was slightly wrong). Corrections:
15108 ConvertImplicitStandard -> ImplicitConversionStandard
15109 ConvertExplicitStandard -> ExplicitConversionStandard
15111 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
15112 before passing them in !
15114 * convert.cs (ImplicitConversionStandard): When comparing for
15115 equal expr and target types, ensure that expr is not a
15118 In general, we must not be checking (expr_type ==
15119 target_type) in the top level conversion methods
15120 (ImplicitConversion, ExplicitConversion etc). This checking is
15121 done in the methods that they delegate to.
15123 2003-05-20 Miguel de Icaza <miguel@ximian.com>
15125 * convert.cs: Move Error_CannotConvertType,
15126 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
15127 ImplicitNumericConversion, ImplicitConversionExists,
15128 ImplicitUserConversionExists, StandardConversionExists,
15129 FindMostEncompassedType, FindMostSpecificSource,
15130 FindMostSpecificTarget, ImplicitUserConversion,
15131 ExplicitUserConversion, GetConversionOperators,
15132 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
15133 TryImplicitIntConversion, Error_CannotConvertImplicit,
15134 ConvertImplicitRequired, ConvertNumericExplicit,
15135 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
15136 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
15139 Perform the following renames:
15141 StandardConversionExists -> ImplicitStandardConversionExists
15142 ConvertImplicit -> ImplicitConversion
15143 ConvertImplicitStandard -> ImplicitStandardConversion
15144 TryImplicitIntConversion -> ImplicitIntConversion
15145 ConvertImplicitRequired -> ImplicitConversionRequired
15146 ConvertNumericExplicit -> ExplicitNumericConversion
15147 ConvertReferenceExplicit -> ExplicitReferenceConversion
15148 ConvertExplicit -> ExplicitConversion
15149 ConvertExplicitStandard -> ExplicitStandardConversion
15151 2003-05-19 Martin Baulig <martin@ximian.com>
15153 * statement.cs (TypeInfo.StructInfo): Made this type protected.
15154 (TypeInfo): Added support for structs having structs as fields.
15156 * ecore.cs (FieldExpr): Implement IVariable.
15157 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
15158 VariableInfo for the field.
15160 2003-05-18 Martin Baulig <martin@ximian.com>
15162 * expression.cs (This.DoResolve): Report a CS0027 if we're
15163 emitting a field initializer.
15165 2003-05-18 Martin Baulig <martin@ximian.com>
15167 * expression.cs (This.ResolveBase): New public function.
15168 (This.DoResolve): Check for CS0188.
15170 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
15173 * ecore.cs (MethodGroupExpr.DoResolve): Set the
15174 `instance_expression' to null if we don't have any non-static
15177 2003-05-18 Martin Baulig <martin@ximian.com>
15179 Reworked the way how local variables and parameters are handled by
15180 the flow analysis code.
15182 * statement.cs (TypeInfo, VariableMap): New public classes.
15183 (VariableInfo): New public class. This is now responsible for
15184 checking whether a variable has been assigned. It is used for
15185 parameters and local variables.
15186 (Block.EmitMeta): Take the InternalParameters as argument; compute
15187 the layout of the flow vectors here.
15188 (Block.LocalMap, Block.ParameterMap): New public properties.
15189 (FlowBranching): The .ctor doesn't get the InternalParameters
15190 anymore since Block.EmitMeta() now computes the layout of the flow
15192 (MyStructInfo): This class is now known as `StructInfo' and nested
15193 in `TypeInfo'; we don't access this directly anymore.
15195 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
15196 property and removed IsAssigned(), IsFieldAssigned(),
15197 SetAssigned() and SetFieldAssigned(); we now call them on the
15198 VariableInfo so we don't need to duplicate this code everywhere.
15200 * expression.cs (ParameterReference): Added `Block block' argument
15202 (LocalVariableReference, ParameterReference, This): The new
15203 VariableInfo class is now responsible for all the definite
15206 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
15207 IsParameterAssigned, SetParameterAssigned): Removed.
15209 2003-05-18 Martin Baulig <martin@ximian.com>
15211 * typemanager.cs (InitCoreTypes): Try calling
15212 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
15213 the 3-args-version. Corlib now also needs our `void_type'.
15214 (GetMethod): Added overloaded version which takes an optional
15215 `bool report_errors' to allow lookups of optional methods.
15217 2003-05-12 Martin Baulig <martin@ximian.com>
15219 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
15220 only used for locals and not for parameters.
15222 2003-05-12 Miguel de Icaza <miguel@ximian.com>
15224 * support.cs (InternalParameters.ParameterType): Return the
15225 ExternalType of the parameter.
15227 * parameter.cs (Parameter.ExternalType): drop the two arguments,
15230 2003-05-11 Miguel de Icaza <miguel@ximian.com>
15232 * class.cs (MethodData.Define): Do not set the `newslot' on
15233 interface members, if they are also flagged as "override".
15235 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
15236 better code for ++i and i++. This only works for static fields
15237 and local variables.
15239 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
15240 want to pull the DeclSpace out of the builder_to_declspace instead
15241 of the TypeBuilder (like in TypeContainer.FindMembers).
15243 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
15244 instead of LookupTypeContainer. Fixes the crash on .NET for
15245 looking up interface members.
15247 * const.cs: Create our own emit context during the Definition
15248 stage, so that constants are evaluated in the proper context, when
15249 a recursive definition happens.
15251 2003-05-11 Martin Baulig <martin@ximian.com>
15253 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
15254 new block for a switch section.
15255 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
15256 the adding/lookup in the switch block. Fixes #39828.
15258 2003-05-09 Miguel de Icaza <miguel@ximian.com>
15260 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
15261 functionality: I needed to convert the data after I had performed
15262 the add/sub operation into the operands type size.
15264 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
15265 pass the type for the box operation, otherwise the resulting
15266 object would have been of type object.
15268 (BoxedCast): Add constructor to specify the type to box as.
15270 2003-05-07 Miguel de Icaza <miguel@ximian.com>
15272 * iterators.cs: I was reusing the `count' variable inadvertently,
15273 take steps to not allow this to happen.
15275 2003-05-06 Miguel de Icaza <miguel@ximian.com>
15277 * attribute.cs (Attribute.Resolve): Params attributes are encoded
15278 by creating an array at the point where the params starts and
15279 putting all those arguments there, then adjusting the size of the
15282 2003-05-05 Miguel de Icaza <miguel@ximian.com>
15284 * expression.cs (New.AddressOf): Implement interface
15285 IMemoryLocation. This is used when the `new' operator is used in
15286 the context of an invocation to a method on a value type.
15288 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
15291 * namespace.cs: Also check the using aliases here.
15293 * driver.cs: Move the test for using validity after the types have
15294 been entered, so we do a single pass that also includes the using
15297 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
15298 in the regular case. CreateSiblingForFinally is doing extra
15301 * attribute.cs (GetAttributeArgumentExpression): Store the result
15302 on an out value, and use the return value to indicate failure
15303 instead of using null (which is a valid return for Constant.GetValue).
15305 * statement.cs: Perform the analysis flow for the increment
15306 portion after the statement, because this will be the real flow of
15307 execution. Fixes #42385
15309 * codegen.cs (EmitContext.EmitArgument,
15310 EmitContext.EmitStoreArgument): New helper functions when the
15311 RemapToProxy flag is set.
15313 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
15316 Add support for remapping parameters.
15318 * iterators.cs: Propagate parameter values; Store parameter
15319 values in the proxy classes.
15321 2003-05-04 Miguel de Icaza <miguel@ximian.com>
15323 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
15324 need a proxy reference; I do not know what I was thinking
15326 * cs-parser.jay (constructor_initializer): catch another error,
15327 and display nice message.
15329 (field_declaration): catch void field declaration
15330 to flag a better error.
15332 * class.cs (MemberBase.CheckBase): Report an error instead of a
15333 warning if a new protected member is declared in a struct.
15334 (Field.Define): catch the error of readonly/volatile.
15336 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
15338 (FieldExpr.AddressOf): ditto. Catch error where the address of a
15339 volatile variable is taken
15341 2003-05-02 Miguel de Icaza <miguel@ximian.com>
15343 * statement.cs (Fixed.Resolve): Report an error if we are not in
15346 2003-05-01 Miguel de Icaza <miguel@ximian.com>
15348 * typemanager.cs: reuse the code that handles type clashes for
15349 delegates and enumerations.
15351 * class.cs (Report28): Always report.
15353 * expression.cs (EncodeAsAttribute): Allow nulls here.
15355 2003-04-28 Miguel de Icaza <miguel@ximian.com>
15357 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
15358 the functionality for testing whether an expression is valid for
15359 an attribute here. Also handle the case of arrays of elements
15362 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
15363 encoding a linear array into an array of objects that are suitable
15364 to be passed to an CustomAttributeBuilder.
15366 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
15368 * ecore.cs: (FieldExpr): Handle field remapping here.
15370 * iteratators.cs: Pass the instance variable (if the method is an
15371 instance method) to the constructors, so we can access the field
15372 variables on the class.
15374 TODO: Test this with structs. I think the THIS variable on
15375 structs might have to be a pointer, and not a refenrece
15377 2003-04-27 Miguel de Icaza <miguel@ximian.com>
15379 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
15380 local variables to fields in a proxy class.
15382 * iterators.cs (PopulateProxy): Rename our internal fields to
15384 Create a <THIS> field if we are an instance method, so we can
15385 reference our parent container variables.
15386 (MapVariable): Called back from the EmitContext code to enter a
15387 new variable to field mapping into the proxy class (we just create
15391 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
15392 for using the remapped locals to fields.
15394 I placed the code here, because that gives the same semantics to
15395 local variables, and only changes the Emit code.
15397 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
15398 statements inside iterators.
15399 (VariableInfo): Add a FieldBuilder for the cases when we are
15400 remapping local variables to fields in a proxy class
15402 * ecore.cs (SimpleNameResolve): Avoid testing two times for
15403 current_block != null.
15405 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
15406 not cope with strings, as it has been moved to the
15407 TableSwitchEmit. Fixed bug in switch generation.
15409 * expression.cs (New.DoResolve): Provide more context for the user
15410 when reporting an error.
15412 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
15415 * expression.cs (MemberAccess.DoResolve): When we get a type back,
15416 check the permissions for it. Note than in a type-resolution
15417 context the check was already present in DeclSpace.ResolveType,
15418 but was missing from the MemberAccess.
15420 (ArrayCreation.CheckIndices): warn if the user has
15421 more nested levels of expressions, but there are no more
15422 dimensions specified. Avoids crash on bug 41906.
15424 2003-04-26 Miguel de Icaza <miguel@ximian.com>
15426 * statement.cs (Block): replace Implicit bool, for a generic
15428 New flag: `Unchecked'. This is used during the EmitMeta phase
15429 (which is out-of-line with the regular Resolve/Emit process for a
15430 statement, as this is done ahead of time, but still gets a chance
15431 to call constant resolve).
15433 (Block.Flags): new enum for adding a new flag.
15435 (Block.EmitMeta): track the state of unchecked.
15437 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
15438 to enable constant resolution to work there as well.
15440 2003-04-22 Miguel de Icaza <miguel@ximian.com>
15442 * typemanager.cs (ienumerable_type): Also look up
15443 System.Collections.IEnumerable.
15445 2003-04-21 Miguel de Icaza <miguel@ximian.com>
15447 TODO: Test more than one conditional per method.
15449 * class.cs (Indexer.Define): Report the location where the user is
15450 referencing the unsupported feature.
15452 (MethodData): Overload the use of `conditionals' to
15453 minimize the creation of needless ArrayLists. This saves roughly
15454 212kb on my machine.
15456 (Method): Implement the new IIteratorContainer interface.
15457 (Method.SetYields): Implement the method by setting the ModFlags
15458 to contain METHOD_YIELDS.
15460 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
15461 which just got set to null.
15463 * iterators.cs: New file.
15465 (Yield, YieldBreak): New statements.
15467 * statement.cs (Return.Resolve): Flag an error if we are used in
15468 an iterator method.
15470 * codegen.cs (InIterator): New flag set if the code is being
15471 compiled in an iterator method.
15473 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
15474 internal modifier, and we just use it to avoid adding extra
15475 fields, as this is seldom used.
15477 * cs-parser.jay: Add yield_statement (yield and yield break).
15479 * driver.cs: New flag -v2 to turn on version 2 features.
15481 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
15482 hashtable when v2 is enabled.
15484 2003-04-20 Miguel de Icaza <miguel@ximian.com>
15486 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
15487 there is already a namespace defined with this name.
15489 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
15490 people upgraded their corlibs.
15492 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
15493 always use fully qualified types, no need to use the compiler
15496 (TypeManager.IsNamespace): Use binarysearch.
15498 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
15499 AddDelegate): I did not quite use the new IsValid API properly: I
15500 have to pass the short-name and the fullname. I was passing only
15501 the basename instead of the fullname sometimes.
15503 (TypeContainer.DefineType): call NamespaceClash.
15505 * interface.cs (Interface.DefineType): use NamespaceClash before
15508 * delegate.cs (Delegate.DefineType): use NamespaceClash before
15511 * enum.cs: (Enum.DefineType): use NamespaceClash before
15514 * typemanager.cs (: 3-line patch that gives us some tasty 11%
15515 speed increase. First, use the negative_hits cache when we get a
15516 negative. Second, add the type with its full original name
15517 instead of the new . and + encoded name (reflection uses + to
15518 separate type from a nested type). Use LookupTypeReflection
15519 directly which bypasses the type->name hashtable (that we already
15520 know does not contain the type.
15522 * decl.cs (DeclSpace.ResolveTypeExpr): track the
15523 location/container type.
15525 * driver.cs: When passing utf8, use directly the UTF8Encoding.
15527 2003-04-19 Miguel de Icaza <miguel@ximian.com>
15529 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
15531 * delegate.cs (NewDelegate.Resolve): Test whether an instance
15532 method is being referenced in the method group from a static
15533 context, and report error 120 if so.
15535 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
15538 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
15539 is created, we create the A namespace).
15541 * cs-parser.jay: A namespace also introduces a DeclarationFound.
15544 2003-04-18 Miguel de Icaza <miguel@ximian.com>
15546 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
15547 invocation to ModuleBuilder.GetType with the same values will
15548 return a new type instance, so we need to cache its return
15551 * expression.cs (Binary.ResolveOperator): Only allow the compare
15552 operators on enums if they are of the same type.
15554 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
15555 types of ValueType on their own case. Before we were giving them
15556 the same treatment as objects.
15558 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
15559 fullname. Short name is used to compare against container name.
15560 Fullname is used to check against defined namespace names.
15562 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
15563 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
15565 (Method.CheckBase): Call parent.
15566 (MemberBase.CheckBase): Check for protected members on sealed
15568 (PropertyBase.CheckBase): Call parent.
15569 (Field.Define): Call parent.
15571 * report.cs: Negative error codes are now mapped to 8000 - code,
15572 so that the display is render more nicely.
15574 * typemanager.cs: Do not use try/catch, instead report a regular
15577 (GetPointerType, GetReferenceType): These methods provide
15578 mechanisms to obtain the T* and T& from a T. We had the code
15579 previously scattered around the code base, and it also used
15580 TypeManager.LookupType that would go through plenty of caches.
15581 This one goes directly to the type source.
15583 In some places we did the Type.GetType followed by
15584 ModuleBuilder.GetType, but not in others, so this unifies the
15585 processing as well.
15587 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
15588 statements now that we have namespace information.
15590 * typemanager.cs (IsNamespace): New method, returns whether the
15591 string presented is a namespace or not.
15593 (ComputeNamespaces): New public entry point, computes the list of
15594 available namespaces, using the GetNamespaces API call in Mono, or
15595 the slower version in MS.NET.
15597 Now before we start the semantic analysis phase, we have a
15598 complete list of namespaces including everything that the user has
15601 Deleted old code to cache namespaces in .nsc files.
15603 2003-04-17 Miguel de Icaza <miguel@ximian.com>
15605 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
15606 class/struct location definition Location for the implicit
15607 constructor location.
15609 (Operator.Define): Use the location of the operator for the
15610 implicit Method definition.
15612 (Constructor.Emit): use the constructor location for the implicit
15613 base initializer constructor.
15615 * ecore.cs: Remove ITypeExpression. This interface is now gone,
15616 and the Expression class now contains two new methods:
15618 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
15619 isolate type lookup from the rest of the resolution process.
15621 Since we use Expressions to hold type definitions due to the way
15622 we parse the input we have historically overloaded Resolve to
15623 perform the Type lookups if a special flag is passed. Now this is
15624 eliminated and two methods take their place.
15626 The differences in the two methods between xStep and xTerminal is
15627 that xStep is involved in our current lookup system that uses
15628 SimpleNames to compose a name, while xTerminal is used just to
15629 catch the case where the simplename lookup failed.
15631 2003-04-16 Miguel de Icaza <miguel@ximian.com>
15633 * expression.cs (ResolveMemberAccess): Remove redundant code.
15634 TypeExpr expressions are always born fully resolved.
15636 * interface.cs (PopulateMethod): Do not lookup the types twice.
15637 We were doing it once during SemanticAnalysis and once during
15640 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
15641 in local variable type definitions, were being returned as a
15642 SimpleName (we decomposed everything into a string), that is
15643 because primary_expression was being used instead of a type in the
15644 grammar (reduce/reduce conflicts).
15646 The part that was wrong is that we converted the expression into a
15647 string (an oversimplification in one hand, compounded with primary
15648 expressions doing string concatenation).
15654 Would return "A.B.C[]" as a SimpleName. This stopped things like
15655 using clauses from working on this particular context. And a type
15656 was being matched directly against "A.B.C[]".
15658 We now use the correct approach, and allow for ComposedCast to be
15659 part of the unary expression. So the "A.B.C []" become a composed
15660 cast of "A.B.C" (as a nested group of MemberAccess with a
15661 SimpleName at the end) plus the rank composition "[]".
15665 2003-04-10 Miguel de Icaza <miguel@ximian.com>
15667 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
15668 for the access level checking.
15670 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
15671 `TypeContainer container', because I kept getting confused when I
15672 was debugging this code.
15674 * expression.cs (Indexers): Instead of tracking getters/setters,
15675 we now track them in parallel. We create one arraylist less, but
15676 most importantly it is possible now for the LValue code to find a
15677 matching get for a set.
15679 (IndexerAccess.DoResolveLValue): Update the code.
15680 GetIndexersForType has been modified already to extract all the
15681 indexers from a type. The code assumed it did not.
15683 Also make the code set the correct return type for the indexer.
15684 This was fixed a long time ago for properties, but was missing for
15685 indexers. It used to be void_type.
15687 (Binary.Emit): Test first for doubles instead of
15688 floats, as they are more common.
15690 (Binary.EmitBranchable): Use the .un version of the branch opcodes
15691 when dealing with floats and the <=, >= operators. This fixes bug
15694 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
15695 to load the array value by emitting a load on the foreach variable
15696 type. This was incorrect.
15698 We now emit the code to load an element using the the array
15699 variable type, and then we emit the conversion operator.
15703 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
15705 * attribute.cs: Avoid allocation of ArrayLists in the common case.
15707 2003-04-09 Miguel de Icaza <miguel@ximian.com>
15709 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
15710 test for protection before we test for signatures.
15712 (MethodSignature.ToString): implement.
15714 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
15715 to the case where we reduced into a LongConstant.
15717 * decl.cs (CheckAccessLevel): If the type is an array, we can not
15718 depend on whether the information is acurrate, because the
15719 Microsoft runtime will always claim that the array type is public,
15720 regardless of the real state.
15722 If the type is a pointer, another problem happens: the type is
15723 reported as non-public in Microsoft.
15725 In both cases we have to call CheckAccessLevel recursively with
15726 the underlying type as the argument to be tested.
15728 2003-04-08 Miguel de Icaza <miguel@ximian.com>
15730 * assign.cs (Assign.Emit): If we are dealing with a compound
15731 assignment expression, we should use the code path that stores the
15732 intermediate result in a temporary value. This fixes #40903.
15734 *expression.cs (Indirection.ToString): Provide ToString method for
15737 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
15739 * class.cs: Null out fields holding references to Block objects so
15740 they can be garbage collected.
15742 * expression.cs (OverloadResolve): Remove unused local.
15744 2003-04-07 Martin Baulig <martin@ximian.com>
15746 * codegen.cs (EmitContext.CurrentFile): New public field.
15747 (EmitContext.Mark): Use the CurrentFile to check whether the
15748 location is in the correct file.
15749 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
15751 2003-04-07 Martin Baulig <martin@ximian.com>
15753 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
15755 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
15756 location. [FIXME: The location argument which gets passed to this
15757 method is sometimes wrong!]
15759 2003-04-07 Nick Drochak <ndrochak@gol.com>
15761 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
15763 2003-04-07 Miguel de Icaza <miguel@ximian.com>
15765 * expression.cs (Indirection.EmitAssign): We were using the
15766 temporary, but returning immediately instead of continuing the
15769 2003-04-06 Martin Baulig <martin@ximian.com>
15771 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
15772 if it's a nested child, but also deriving from the outer class.
15775 * typemanager.cs (IsNestedChildOf): Make this work if it's a
15776 nested child, but also deriving from the outer class. See
15778 (FilterWithClosure): We may access private members of the outer
15779 class if we're a nested child and deriving from the outer class.
15780 (RealMemberLookup): Only set `closure_private_ok' if the
15781 `original_bf' contained BindingFlags.NonPublic.
15783 2003-04-05 Martin Baulig <martin@ximian.com>
15785 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
15786 probe if its a type parameter, and if so, flag an error.
15788 * decl.cs: Move here the SetParameterInfo code from class.cs.
15789 Handle IsGeneric here.
15791 Handle a variety of errors in the parameter info definition.
15793 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
15794 type parameters here.
15796 * cs-parser.jay (class_declaration): report errors for parameters
15799 2003-01-21 Miguel de Icaza <miguel@ximian.com>
15801 * generic.cs: New file, contains support code for generics.
15803 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
15804 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
15806 Update parser for the above removals.
15808 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
15809 now taken care of in the parser.
15811 2003-04-02 Miguel de Icaza <miguel@ximian.com>
15813 * class.cs (Event.Define): Do not allow abstract events to have
15816 2003-04-01 Miguel de Icaza <miguel@ximian.com>
15818 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
15819 block in event declarations.
15821 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
15822 value type, get its address.
15824 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
15825 leaving a class on the stack instead of a boolean value (int
15826 0/1). Change the code so we compare against null, and then the
15827 result against zero.
15829 * class.cs (TypeContainer.GetClassBases): We were checking for the
15830 parent class being sealed too late.
15832 * expression.cs (Binary.Emit): For <= and >= when dealing with
15833 floating point values, use cgt.un and clt.un instead of cgt and
15836 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
15838 * statement.cs: Apply the same optimization as MS: skip the
15839 GetEnumerator returning an IEnumerator, and use the one returning a
15840 CharEnumerator instead. This allows us to avoid the try-finally block
15843 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
15845 * cs-parser.jay: Attributes cannot be applied to
15846 namespaces. Fixes #40473
15848 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15851 (Add*): check if the name is valid using the full name for constants,
15852 fields, properties and events.
15854 2003-03-28 Miguel de Icaza <miguel@ximian.com>
15856 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
15857 char constants to be part of the enumeration.
15859 * expression.cs (Conditional.DoResolve): Add support for operator
15860 true. Implements the missing functionality from 14.12
15862 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
15863 operator true/false as required by the spec.
15865 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
15866 implicit conversion to boolean.
15868 * statement.cs (Statement.ResolveBoolean): A boolean expression is
15869 also one where the type implements `operator true'.
15871 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
15872 get an expression that will invoke operator true based on an
15875 (GetConversionOperators): Removed the hack that called op_True
15878 (Expression.ResolveBoolean): Move this from Statement.
15880 2003-03-17 Miguel de Icaza <miguel@ximian.com>
15882 * ecore.cs (FieldExpr): do not allow initialization of initonly
15883 fields on derived classes
15885 2003-03-13 Martin Baulig <martin@ximian.com>
15887 * statement.cs (Block.Emit): Call ig.BeginScope() and
15888 ig.EndScope() when compiling with debugging info; call
15889 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
15891 2003-03-08 Miguel de Icaza <miguel@ximian.com>
15893 * expression.cs (Indexers): Do not construct immediately, allow
15894 for new members to be appended as we go. Fixes 38143
15896 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15898 * expression.cs: save/restore context when resolving an unchecked
15901 2003-03-05 Miguel de Icaza <miguel@ximian.com>
15903 * cfold.cs: Catch division by zero in modulus operator during
15906 2003-03-03 Miguel de Icaza <miguel@ximian.com>
15908 * interface.cs (Interface.DefineMembers): Avoid defining members
15911 2003-02-27 Miguel de Icaza <miguel@ximian.com>
15913 * driver.cs: handle the +/- options for -noconfig
15915 * statement.cs (Unckeched.Resolve): Also track the state of
15916 unchecked in the Resolve phase.
15918 2003-02-27 Martin Baulig <martin@ximian.com>
15920 * ecore.cs (Expression.MemberLookup): Don't create a
15921 MethodGroupExpr for something which is not a method. Fixes #38291.
15923 2003-02-25 Miguel de Icaza <miguel@ximian.com>
15925 * class.cs (MemberBase.CheckParameters): Also check that the type
15926 is unmanaged if it is a pointer.
15928 * expression.cs (SizeOf.Resolve): Add location information.
15930 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
15931 a managed type is declared.
15933 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
15934 parameter modifiers as well. Fixes bug 38606
15936 * class.cs: Very sad. Am backing out the speed up changes
15937 introduced by the ArrayList -> Array in the TypeContainer, as they
15938 were not actually that much faster, and introduced a bug (no error
15939 reports on duplicated methods).
15941 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
15942 source first, this will guarantee that we have a valid expression
15943 before calling in lower levels functions that will require a
15944 resolved object. Then use this original_source in the
15945 target.ResolveLValue instead of the original source that was
15948 Another change. Use target.Resolve instead of LValueResolve.
15949 Although we are resolving for LValues, we will let the Assign code
15950 take care of that (it will be called again from Resolve). This
15951 basically allows code like this:
15953 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
15954 class Y { void A (X x) { x [0] += o; }
15956 The problem was that the indexer was trying to resolve for
15957 set_Item (idx, object o) and never finding one. The real set_Item
15958 was set_Item (idx, X). By delaying the process we get the right
15963 2003-02-23 Martin Baulig <martin@ximian.com>
15965 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
15966 while calling DoEmit ().
15968 * codegen.cs (EmitContext.Mark): Don't mark locations in other
15969 source files; if you use the #line directive inside a method, the
15970 compiler stops emitting line numbers for the debugger until it
15971 reaches the end of the method or another #line directive which
15972 restores the original file.
15974 2003-02-23 Martin Baulig <martin@ximian.com>
15976 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
15978 2003-02-23 Martin Baulig <martin@ximian.com>
15980 * statement.cs (Block.AddChildVariableNames): We need to call this
15981 recursively, not just for our immediate children.
15983 2003-02-23 Martin Baulig <martin@ximian.com>
15985 * class.cs (Event.Define): Always make the field private, like csc does.
15987 * typemanager.cs (TypeManager.RealMemberLookup): Make events
15988 actually work, fixes bug #37521.
15990 2003-02-23 Miguel de Icaza <miguel@ximian.com>
15992 * delegate.cs: When creating the various temporary "Parameters"
15993 classes, make sure that we call the ComputeAndDefineParameterTypes
15994 on those new parameters (just like we do with the formal ones), to
15995 allow them to be resolved in the context of the DeclSpace.
15997 This fixes the bug that Dick observed in Bugzilla #38530.
15999 2003-02-22 Miguel de Icaza <miguel@ximian.com>
16001 * expression.cs (ResolveMemberAccess): When resolving a constant,
16002 do not attempt to pull a constant if the value was not able to
16003 generate a valid constant.
16005 * const.cs (LookupConstantValue): Do not report more errors than required.
16007 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16009 * expression.cs: fixes bug #38328.
16011 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16013 * class.cs: Changed all the various members that can be part of a
16014 class from being an ArrayList to be an Array of the right type.
16015 During the DefineType type_list, interface_list, delegate_list and
16016 enum_list are turned into types, interfaces, delegates and enums
16019 And during the member population, indexer_list, event_list,
16020 constant_list, field_list, instance_constructor_list, method_list,
16021 operator_list and property_list are turned into their real arrays.
16023 Although we could probably perform this operation earlier, for
16024 good error reporting we need to keep the lists and remove the
16025 lists for longer than required.
16027 This optimization was triggered by Paolo profiling the compiler
16028 speed on the output of `gen-sample-program.pl' perl script.
16030 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
16031 not crash in methods like MemberLookupFailed that use this field.
16033 This problem arises when the compiler fails to resolve a type
16034 during interface type definition for example.
16036 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16038 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
16039 inherit from System.Object, so we have to stop at null, not only
16040 when reaching System.Object.
16042 2003-02-17 Miguel de Icaza <miguel@ximian.com>
16044 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
16045 DeclaredOnly because the parent indexer might have had a different
16046 name, but did not loop until the top of the hierarchy was reached.
16048 The problem this one fixes is 35492: when a class implemented an
16049 indexer from an interface, we were getting the interface method
16050 (which was abstract) and we were flagging an error (can not invoke
16053 This also keeps bug 33089 functioning, and test-148 functioning.
16055 * typemanager.cs (IsSpecialMethod): The correct way of figuring
16056 out if a method is special is to see if it is declared in a
16057 property or event, or whether it is one of the predefined operator
16058 names. This should fix correctly #36804.
16060 2003-02-15 Miguel de Icaza <miguel@ximian.com>
16062 The goal here is to remove the dependency on EmptyCast.Peel ().
16063 Killing it completely.
16065 The problem is that currently in a number of places where
16066 constants are expected, we have to "probe" for an EmptyCast, and
16067 Peel, which is not the correct thing to do, as this will be
16068 repetitive and will likely lead to errors.
16070 The idea is to remove any EmptyCasts that are used in casts that
16071 can be reduced to constants, so we only have to cope with
16074 This bug hunt was triggered by Bug 37363 and the desire to remove
16075 the duplicate pattern where we were "peeling" emptycasts to check
16076 whether they were constants. Now constants will always be
16079 * ecore.cs: Use an enumconstant here instead of wrapping with
16082 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
16083 throwing me off. By handling this we can get rid of a few hacks.
16085 * statement.cs (Switch): Removed Peel() code.
16087 2003-02-14 Miguel de Icaza <miguel@ximian.com>
16089 * class.cs: Location information for error 508
16091 * expression.cs (New.DoResolve): Add a guard against double
16092 resolution of an expression.
16094 The New DoResolve might be called twice when initializing field
16095 expressions (see EmitFieldInitializers, the call to
16096 GetInitializerExpression will perform a resolve on the expression,
16097 and later the assign will trigger another resolution
16099 This leads to bugs (#37014)
16101 * delegate.cs: The signature for EndInvoke should contain any ref
16102 or out parameters as well. We were not doing this in the past.
16104 * class.cs (Field.Define): Do not overwrite the type definition
16105 inside the `volatile' group. Turns out that volatile enumerations
16106 were changing the type here to perform a validity test, which
16109 2003-02-12 Miguel de Icaza <miguel@ximian.com>
16111 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
16112 and structs, we do not want to load the instance variable
16114 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
16115 enum_type has to be handled like an object reference (implicit
16116 conversions exists from this to object), but the regular IsClass
16117 and IsValueType tests will never return true for this one.
16119 Also we use TypeManager.IsValueType instead of type.IsValueType,
16120 just for consistency with the rest of the code (this is only
16121 needed if we ever use the construct exposed by test-180.cs inside
16122 corlib, which we dont today).
16124 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
16126 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
16129 2003-02-09 Martin Baulig <martin@ximian.com>
16131 * namespace.cs (Namespace..ctor): Added SourceFile argument.
16132 (Namespace.DefineNamespaces): New static public method; this is
16133 called when we're compiling with debugging to add all namespaces
16134 to the symbol file.
16136 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
16137 pass it to the Namespace's .ctor.
16139 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
16140 and MethodBase arguments; pass the namespace ID to the symwriter;
16141 pass the MethodBase instead of the token to the symwriter.
16142 (SymbolWriter.DefineNamespace): New method to add a namespace to
16145 2003-02-09 Martin Baulig <martin@ximian.com>
16147 * symbolwriter.cs: New file. This is a wrapper around
16148 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
16149 methods here in near future.
16151 2003-02-09 Martin Baulig <martin@ximian.com>
16153 * codegen.cs (EmitContext.Mark): Just pass the arguments to
16154 ILGenerator.MarkSequencePoint() which are actually used by the
16157 2003-02-09 Martin Baulig <martin@ximian.com>
16159 * location.cs (SourceFile): New public sealed class. This
16160 contains the name and an index which is used in the location's token.
16161 (Location): Reserve an appropriate number of bits in the token for
16162 the source file instead of walking over that list, this gives us a
16163 really huge performance improvement when compiling with debugging.
16165 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
16166 `SourceFile' argument instead of a string.
16167 (Driver.ProcessFile): Add all the files via Location.AddFile(),
16168 but don't parse/tokenize here, we need to generate the list of all
16169 source files before we do that.
16170 (Driver.ProcessFiles): New static function. Parses/tokenizes all
16173 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
16174 instead of a string.
16176 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
16179 2003-02-09 Martin Baulig <martin@ximian.com>
16181 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
16182 filename on `#line default'.
16184 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
16186 * statement.cs: don't clear the pinned var when the fixed statement
16187 returns from the method (fixes bug#37752).
16189 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
16191 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
16194 2003-02-07 Martin Baulig <martin@ximian.com>
16196 * driver.cs: Removed the `--debug-args' command line argument.
16198 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
16199 automatically by the AsssemblyBuilder.
16200 (CodeGen.InitializeSymbolWriter): We don't need to call any
16201 initialization function on the symbol writer anymore. This method
16202 doesn't take any arguments.
16204 2003-02-03 Miguel de Icaza <miguel@ximian.com>
16206 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
16207 from referenced assemblies as well.
16209 2003-02-02 Martin Baulig <martin@ximian.com>
16211 * class.cs (MethodData.Emit): Generate debugging info for external methods.
16213 2003-02-02 Martin Baulig <martin@ximian.com>
16215 * class.cs (Constructor.Emit): Open the symbol writer before
16216 emitting the constructor initializer.
16217 (ConstructorInitializer.Emit): Call ec.Mark() to allow
16218 single-stepping through constructor initializers.
16220 2003-01-30 Miguel de Icaza <miguel@ximian.com>
16222 * class.cs: Handle error 549: do not allow virtual methods in
16225 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
16227 * decl.cs: Check access levels when resolving types
16229 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
16231 * statement.cs: Add parameters and locals set in catch blocks that might
16232 return to set vector
16234 2003-01-29 Miguel de Icaza <miguel@ximian.com>
16236 * class.cs (Operator): Set the SpecialName flags for operators.
16238 * expression.cs (Invocation.DoResolve): Only block calls to
16239 accessors and operators on SpecialName methods.
16241 (Cast.TryReduce): Handle conversions from char constants.
16244 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
16246 * statement.cs: small memory and time optimization in FlowBranching.
16248 2003-01-28 Pedro Mart <yoros@wanadoo.es>
16250 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
16251 problem that the last fix but in the other sid (Set).
16253 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
16254 access when there is no indexer in the hierarchy.
16256 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
16258 * class.cs: Combine some if statements.
16260 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16262 * driver.cs: fixed bug #37187.
16264 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
16266 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
16267 any indexer, it's needed to build a list with all the indexers in the
16268 hierarchy (AllGetters), else we have problems. Fixes #35653.
16270 2003-01-23 Miguel de Icaza <miguel@ximian.com>
16272 * class.cs (MethodData.Define): It is wrong for an interface
16273 implementation to be static in both cases: explicit and implicit.
16274 We were only handling this in one case.
16276 Improve the if situation there to not have negations.
16278 * class.cs (Field.Define): Turns out that we do not need to check
16279 the unsafe bit on field definition, only on usage. Remove the test.
16281 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16283 * driver.cs: use assembly.Location instead of Codebase (the latest
16284 patch made mcs fail when using MS assemblies).
16286 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
16288 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
16289 get the path to *corlib.dll.
16291 2003-01-21 Nick Drochak <ndrochak@gol.com>
16295 * typemanager.cs: Remove compiler warnings
16297 2003-01-20 Duncan Mak <duncan@ximian.com>
16299 * AssemblyInfo.cs: Bump the version number to 0.19.
16301 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16303 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
16305 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
16307 * class.cs (Constructor::Emit): Emit debugging info for constructors.
16309 2003-01-17 Miguel de Icaza <miguel@ximian.com>
16311 * cs-parser.jay: Small fix: we were not comparing the constructor
16312 name correctly. Thanks to Zoltan for the initial pointer.
16314 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
16316 * cs-tokenizer.cs: Set file name when specified with #line
16318 2003-01-15 Miguel de Icaza <miguel@ximian.com>
16320 * cs-parser.jay: Only perform the constructor checks here if we
16321 are named like the class; This will help provider a better
16322 error. The constructor path is taken when a type definition is
16323 not found, but most likely the user forgot to add the type, so
16324 report that rather than the constructor error.
16326 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
16328 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
16331 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16333 * cs-parser.jay: Add cleanup call.
16335 2003-01-13 Duncan Mak <duncan@ximian.com>
16337 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
16338 consistent with other methods.
16340 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16342 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
16344 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
16346 * attribute.cs: only set GuidAttr to true when we have a
16349 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16353 * typemanager.cs: fixes to allow mcs compile corlib with the new
16354 Type.IsSubclassOf fix.
16356 2003-01-08 Miguel de Icaza <miguel@ximian.com>
16358 * expression.cs (LocalVariableReference.DoResolve): Classify a
16359 constant as a value, not as a variable. Also, set the type for
16362 * cs-parser.jay (fixed_statement): take a type instead of a
16363 pointer_type, so we can produce a better error message later.
16365 * statement.cs (Fixed.Resolve): Flag types that are not pointers
16368 (For.DoEmit): Make inifinite loops have a
16369 non-conditional branch back.
16371 (Fixed.DoEmit): First populate the pinned variables, then emit the
16372 statement, then clear the variables. Before I was emitting the
16373 code once for each fixed piece.
16376 2003-01-08 Martin Baulig <martin@ximian.com>
16378 * statement.cs (FlowBranching.MergeChild): A break in a
16379 SWITCH_SECTION does not leave a loop. Fixes #36155.
16381 2003-01-08 Martin Baulig <martin@ximian.com>
16383 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
16384 lives in the same number space than `param_map'. Fixes #36154.
16386 2003-01-07 Miguel de Icaza <miguel@ximian.com>
16388 * cs-parser.jay (constructor_declaration): Set the
16389 Constructor.ModFlags before probing for it. This makes the
16390 compiler report 514, 515 and 132 (the code was there, but got
16393 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
16394 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
16395 (GotoCase.Resolve): Set `Returns' to ALWAYS.
16397 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
16399 * enum.cs: create the enum static fields using the enum type.
16401 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
16403 * class.cs: don't try to create the ParamBuilder for the return
16404 type if it's not needed (and handle it breaking for the ms runtime
16407 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
16409 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
16411 2002-12-29 Miguel de Icaza <miguel@ximian.com>
16413 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
16414 the command. This showed up while compiling the JANET source
16415 code, which used \r as its only newline separator.
16417 2002-12-28 Miguel de Icaza <miguel@ximian.com>
16419 * class.cs (Method.Define): If we are an operator (because it
16420 reuses our code), then set the SpecialName and HideBySig. #36128
16422 2002-12-22 Miguel de Icaza <miguel@ximian.com>
16424 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
16425 exception, report error 120 `object reference required'.
16427 * driver.cs: Add --pause option, used during to measure the size
16428 of the process as it goes with --timestamp.
16430 * expression.cs (Invocation.DoResolve): Do not allow methods with
16431 SpecialName to be invoked.
16433 2002-12-21 Miguel de Icaza <miguel@ximian.com>
16435 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
16436 number before adding it.
16438 2002-12-21 Ravi Pratap <ravi@ximian.com>
16440 * ecore.cs (StandardImplicitConversion): When in an unsafe
16441 context, we allow conversion between void * to any other pointer
16442 type. This fixes bug #35973.
16444 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
16446 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
16447 is not thrown when extensionless outputs are used
16449 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16451 * rootcontext.cs: fixed compilation of corlib.
16453 2002-12-19 Miguel de Icaza <miguel@ximian.com>
16455 * attribute.cs (Attributes.Contains): Add new method.
16457 * class.cs (MethodCore.LabelParameters): if the parameter is an
16458 `out' parameter, check that no attribute `[In]' has been passed.
16460 * enum.cs: Handle the `value__' name in an enumeration.
16462 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
16464 * decl.cs: Added special case to allow overrides on "protected
16467 2002-12-18 Ravi Pratap <ravi@ximian.com>
16469 * attribute.cs (Attributes.AddAttributeSection): Rename to this
16470 since it makes much more sense.
16472 (Attributes.ctor): Don't require a Location parameter.
16474 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
16476 * attribute.cs (ApplyAttributes): Remove extra Location parameters
16477 since we already have that information per attribute.
16479 * everywhere : make appropriate changes.
16481 * class.cs (LabelParameters): Write the code which actually
16482 applies attributes to the return type. We can't do this on the MS
16483 .NET runtime so we flag a warning in the case an exception is
16486 2002-12-18 Miguel de Icaza <miguel@ximian.com>
16488 * const.cs: Handle implicit null conversions here too.
16490 2002-12-17 Ravi Pratap <ravi@ximian.com>
16492 * class.cs (MethodCore.LabelParameters): Remove the extra
16493 Type [] parameter since it is completely unnecessary. Instead
16494 pass in the method's attributes so that we can extract
16495 the "return" attribute.
16497 2002-12-17 Miguel de Icaza <miguel@ximian.com>
16499 * cs-parser.jay (parse): Use Report.Error to flag errors instead
16500 of ignoring it and letting the compile continue.
16502 * typemanager.cs (ChangeType): use an extra argument to return an
16503 error condition instead of throwing an exception.
16505 2002-12-15 Miguel de Icaza <miguel@ximian.com>
16507 * expression.cs (Unary.TryReduce): mimic the code for the regular
16508 code path. Perform an implicit cast in the cases where we can
16509 implicitly convert to one of the integral types, and then reduce
16510 based on that constant. This fixes bug #35483.
16512 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16514 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
16516 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16518 * namespace.cs: fixed bug #35489.
16520 2002-12-12 Miguel de Icaza <miguel@ximian.com>
16522 * class.cs: Remove some dead code.
16524 * cs-parser.jay: Estimate the number of methods needed
16525 (RootContext.MethodCount);
16527 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
16528 numbers instead of StringBuilders.
16530 * support.cs (PtrHashtable): Add constructor with initial size;
16531 We can now reduce reallocations of the method table.
16533 2002-12-10 Ravi Pratap <ravi@ximian.com>
16535 * attribute.cs (ApplyAttributes): Keep track of the emitted
16536 attributes on a per-target basis. This fixes bug #35413.
16538 2002-12-10 Miguel de Icaza <miguel@ximian.com>
16540 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
16541 default to the Windows 1252 encoding.
16543 (UnixParseOption): Support version, thanks to Alp for the missing
16546 * AssemblyInfo.cs: Add nice assembly information.
16548 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
16551 * cs-parser.jay: Allow a trailing comma before the close bracked
16552 in the attribute_section production.
16554 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
16555 address of the instance was being taken, I will take this out,
16556 because we take the address of the object immediately here.
16558 2002-12-09 Ravi Pratap <ravi@ximian.com>
16560 * typemanager.cs (AreMultipleAllowed): Take care of the most
16561 obvious case where attribute type is not in the current assembly -
16564 2002-12-08 Miguel de Icaza <miguel@ximian.com>
16566 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
16567 definitions, instead of doing that afterwards.
16569 Also we use a nice little hack, depending on the constructor, we
16570 know if we are a "composed" name or a simple name. Hence, we
16571 avoid the IndexOf test, and we avoid
16573 * codegen.cs: Add code to assist in a bug reporter to track down
16574 the source of a compiler crash.
16576 2002-12-07 Ravi Pratap <ravi@ximian.com>
16578 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
16579 types have been emitted for a given element and flag an error
16580 if something which does not have AllowMultiple set is used more
16583 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
16584 attribute types and their corresponding AllowMultiple properties
16586 (AreMultipleAllowed): Check the property for a given type.
16588 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
16589 property in the case we have a TypeContainer.
16591 (Attributes.AddAttribute): Detect duplicates and just skip on
16592 adding them. This trivial fix catches a pretty gross error in our
16593 attribute emission - global attributes were being emitted twice!
16595 Bugzilla bug #33187 is now fixed.
16597 2002-12-06 Miguel de Icaza <miguel@ximian.com>
16599 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
16600 instead of pp_and).
16602 * expression.cs (Binary.ResolveOperator): I can only use the
16603 Concat (string, string, string) and Concat (string, string,
16604 string, string) if the child is actually a concatenation of
16607 2002-12-04 Miguel de Icaza <miguel@ximian.com>
16609 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
16610 context where we need a 2-character lookahead.
16612 * pending.cs (PendingImplementation): Rework so we can keep track
16613 of interface types all the time, and flag those which were
16614 implemented by parents as optional.
16616 2002-12-03 Miguel de Icaza <miguel@ximian.com>
16618 * expression.cs (Binary.ResolveOperator): Use
16619 String.Concat(string,string,string) or
16620 String.Concat(string,string,string,string) when possible.
16622 * typemanager: More helper methods.
16625 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
16627 * pending.cs: remove the bogus return from GetMissingInterfaces()
16628 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
16630 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16632 * namespace.cs: avoid duplicated 'using xxx' being added to
16633 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
16634 when we get more than one 'using' statement for the same namespace.
16635 Report a CS0105 warning for it.
16637 2002-11-30 Miguel de Icaza <miguel@ximian.com>
16639 * cs-tokenizer.cs (consume_identifier): use read directly, instead
16640 of calling getChar/putback, uses internal knowledge of it.
16642 (xtoken): Reorder tokenizer so most common patterns are checked
16643 first. This reduces the compilation time in another 5% (from 8.11s
16644 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
16646 The parsing time is 22% of the compilation in mcs, and from that
16647 64% is spent on the tokenization process.
16649 I tried using a binary search for keywords, but this is slower
16650 than the hashtable. Another option would be to do a couple of
16653 * Not use a StringBuilder, instead use an array of chars,
16654 with a set value. Notice that this way we could catch
16655 the 645 error without having to do it *afterwards*.
16657 * We could write a hand-parser to avoid the hashtable
16658 compares altogether.
16660 The identifier consumption process takes 37% of the tokenization
16661 time. Another 15% is spent on is_number. 56% of the time spent
16662 on is_number is spent on Int64.Parse:
16664 * We could probably choose based on the string length to
16665 use Int32.Parse or Int64.Parse and avoid all the 64-bit
16668 Another 3% is spend on wrapping `xtoken' in the `token' function.
16670 Handle 0xa0 as whitespace (#34752)
16672 2002-11-26 Miguel de Icaza <miguel@ximian.com>
16674 * typemanager.cs (IsCLRType): New routine to tell whether a type
16675 is one of the builtin types.
16677 Maybe it needs to use TypeCodes to be faster. Maybe we could use
16678 typecode in more places instead of doing pointer comparissions.
16679 We could leverage some knowledge about the way the typecodes are
16682 New code to cache namespaces in assemblies, it is currently not
16683 invoked, to be used soon.
16685 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
16687 * expression.cs (Binary.ResolveOperator): specially handle
16688 strings, and do not perform user-defined operator overloading for
16691 2002-11-24 Miguel de Icaza <miguel@ximian.com>
16693 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
16694 internalcall as it is a pretty simple operation; Avoid whenever
16695 possible to call Char.IsLetter.
16697 (consume_identifier): Cut by half the number of
16698 hashtable calls by merging the is_keyword and GetKeyword behavior.
16700 Do not short-circuit, because if we do, we
16701 report errors (ie, #if false && true would produce an invalid
16705 2002-11-24 Martin Baulig <martin@ximian.com>
16707 * expression.cs (Cast.TryReduce): If we're in checked syntax,
16708 check constant ranges and report a CS0221. Fixes #33186.
16710 2002-11-24 Martin Baulig <martin@ximian.com>
16712 * cs-parser.jay: Make this work for uninitialized variable
16713 declarations in the `for' initializer. Fixes #32416.
16715 2002-11-24 Martin Baulig <martin@ximian.com>
16717 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
16718 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
16720 2002-11-24 Martin Baulig <martin@ximian.com>
16722 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
16723 argument; if true, we also check for user-defined conversions.
16724 This is only needed if both arguments are of a user-defined type.
16725 Fixes #30443, added test-175.cs.
16726 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
16728 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
16730 2002-11-24 Martin Baulig <martin@ximian.com>
16732 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
16733 function to get the store opcode.
16734 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
16735 only emit the Ldelema if the store opcode is Stobj. You must run
16736 both test-34 and test-167 to test this. Fixes #34529.
16738 2002-11-23 Martin Baulig <martin@ximian.com>
16740 * ecore.cs (Expression.MemberLookup): Added additional
16741 `qualifier_type' argument which is used when we're being called
16742 from MemberAccess.DoResolve() and null if we're called from a
16744 (Expression.MemberLookupFailed): New method to report errors; this
16745 does the CS1540 check and reports the correct error message.
16747 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
16748 argument for the CS1540 check and redone the way how we're dealing
16749 with private members. See the comment in the source code for details.
16750 (FilterWithClosure): Reverted this back to revision 1.197; renamed
16751 `closure_start_type' to `closure_qualifier_type' and check whether
16752 it's not null. It was not this filter being broken, it was just
16753 being called with the wrong arguments.
16755 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
16756 and pass it the correct `qualifier_type'; this also does the error
16759 2002-11-22 Miguel de Icaza <miguel@ximian.com>
16761 * expression.cs (Invocation.EmitParams): If the we are dealing
16762 with a non-built-in value type, load its address as well.
16764 (ArrayCreation): Use a a pretty constant instead
16765 of the hardcoded value 2. Use 6 instead of 2 for the number of
16766 static initializers.
16768 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
16769 because they are not really value types, just glorified integers.
16771 * driver.cs: Do not append .exe, the CSC compiler does not do it.
16773 * ecore.cs: Remove redundant code for enumerations, make them use
16774 the same code path as everything else, fixes the casting issue
16775 with enumerations in Windows.Forms.
16777 * attribute.cs: Do only cast to string if it is a string, the
16778 validation happens later.
16780 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
16781 people upgrade their corlibs.
16783 * ecore.cs: Oops, enumerations were not following the entire code path
16785 2002-11-21 Miguel de Icaza <miguel@ximian.com>
16787 * typemanager.cs (FilterWithClosure): Commented out the test for
16788 1540 in typemanager.cs, as it has problems when accessing
16789 protected methods from a parent class (see test-174.cs).
16791 * attribute.cs (Attribute.ValidateGuid): new method.
16792 (Attribute.Resolve): Use above.
16794 2002-11-19 Miguel de Icaza <miguel@ximian.com>
16796 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
16798 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
16799 handling for enumerations, as we only needed the TypeContainer
16800 functionality to begin with (this is required for the fix below to
16801 work for enums that reference constants in a container class for
16804 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
16806 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
16807 a valid TypeBuilder to perform lookups on.o
16809 * class.cs (InheritableMemberSignatureCompare): Use true in the
16810 call to GetGetMethod and GetSetMethod, because we are comparing
16811 the signature, and we need to get the methods *even* if they are
16814 (PropertyBase.CheckBase): ditto.
16816 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
16817 GotoCase.Resolve): Use Peel on EmpytCasts.
16819 * ecore.cs (EmptyCast): drop child, add Peel method.
16821 2002-11-17 Martin Baulig <martin@ximian.com>
16823 * ecore.cs (EmptyCast.Child): New public property.
16825 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
16826 label resolved to an EmptyCast. Fixes #34162.
16827 (GotoCase.Resolve): Likewise.
16828 (Block.EmitMeta): Likewise.
16830 2002-11-17 Martin Baulig <martin@ximian.com>
16832 * expression.cs (Invocation.BetterConversion): Prefer int over
16833 uint; short over ushort; long over ulong for integer literals.
16834 Use ImplicitConversionExists instead of StandardConversionExists
16835 since we also need to check for user-defined implicit conversions.
16836 Fixes #34165. Added test-173.cs.
16838 2002-11-16 Martin Baulig <martin@ximian.com>
16840 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
16841 with the `true' and `false' literals. Fixes #33151.
16843 2002-11-16 Martin Baulig <martin@ximian.com>
16845 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
16846 October 22nd; don't do the cs1540 check for static members.
16848 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
16849 now using our own filter here and doing the cs1540 check again.
16851 2002-11-16 Martin Baulig <martin@ximian.com>
16853 * support.cs (InternalParameters): Don't crash if we don't have
16854 any fixed parameters. Fixes #33532.
16856 2002-11-16 Martin Baulig <martin@ximian.com>
16858 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
16859 when looking up static methods to make this work on Windows.
16862 2002-11-16 Martin Baulig <martin@ximian.com>
16864 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
16865 a setter rather than using PropertyInfo.CanWrite.
16867 2002-11-15 Nick Drochak <ndrochak@gol.com>
16869 * class.cs: Allow acces to block member by subclasses. Fixes build
16872 2002-11-14 Martin Baulig <martin@ximian.com>
16874 * class.cs (Constructor.Emit): Added the extern/block check.
16877 2002-11-14 Martin Baulig <martin@ximian.com>
16879 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
16880 iteration while looking for indexers, this is needed because the
16881 indexer may have a different name in our base classes. Fixed the
16882 error reporting (no indexers at all, not get accessor, no
16883 overloaded match). Fixes bug #33089.
16884 (IndexerAccess.DoResolveLValue): Likewise.
16886 2002-11-14 Martin Baulig <martin@ximian.com>
16888 * class.cs (PropertyBase.CheckBase): Make this work for multiple
16889 indexers. Fixes the first part of bug #33089.
16890 (MethodSignature.InheritableMemberSignatureCompare): Added support
16893 2002-11-13 Ravi Pratap <ravi@ximian.com>
16895 * attribute.cs (Attribute.Resolve): Catch the
16896 NullReferenceException and report it since it isn't supposed to
16899 2002-11-12 Miguel de Icaza <miguel@ximian.com>
16901 * expression.cs (Binary.EmitBranchable): Also handle the cases for
16902 LogicalOr and LogicalAnd that can benefit from recursively
16903 handling EmitBranchable. The code now should be nice for Paolo.
16905 2002-11-08 Miguel de Icaza <miguel@ximian.com>
16907 * typemanager.cs (LookupType): Added a negative-hit hashtable for
16908 the Type lookups, as we perform quite a number of lookups on
16909 non-Types. This can be removed once we can deterministically tell
16910 whether we have a type or a namespace in advance.
16912 But this might require special hacks from our corlib.
16916 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
16917 and double which avoids a conversion from an integer to a double.
16919 * expression.cs: tiny optimization, avoid calling IsConstant,
16920 because it effectively performs the lookup twice.
16922 2002-11-06 Miguel de Icaza <miguel@ximian.com>
16924 But a bogus return here to keep the semantics of the old code
16925 until the Mono runtime is fixed.
16927 * pending.cs (GetMissingInterfaces): New method used to remove all
16928 the interfaces that are already implemented by our parent
16929 classes from the list of pending methods.
16931 * interface.cs: Add checks for calls after ResolveTypeExpr.
16933 2002-11-05 Miguel de Icaza <miguel@ximian.com>
16935 * class.cs (Class.Emit): Report warning 67: event not used if the
16936 warning level is beyond 3.
16938 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
16939 being a NullLiteral.
16941 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
16944 * class.cs (TypeContainer.GetClassBases): Cover a missing code
16945 path that might fail if a type can not be resolved.
16947 * expression.cs (Binary.Emit): Emit unsigned versions of the
16950 * driver.cs: use error 5.
16952 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
16954 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
16956 2002-11-01 Miguel de Icaza <miguel@ximian.com>
16958 * cs-parser.jay (switch_section): A beautiful patch from Martin
16959 Baulig that fixed 33094.
16961 2002-10-31 Miguel de Icaza <miguel@ximian.com>
16963 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
16964 Check whether the base is abstract and report an error if so.
16966 * expression.cs (IndexerAccess.DoResolveLValue,
16967 IndexerAccess.DoResolve): ditto.
16969 (Invocation.DoResolve): ditto.
16971 (Invocation.FullMethodDesc): Improve the report string.
16973 * statement.cs (Block): Eliminate IsVariableDefined as it is
16974 basically just a wrapper for GetVariableInfo.
16976 * ecore.cs (SimpleName): Use new
16978 * support.cs (ReflectionParamter.ParameterType): We unwrap the
16979 type, as we return the actual parameter ref/unref state on a
16982 2002-10-30 Miguel de Icaza <miguel@ximian.com>
16984 * support.cs: Return proper flags REF/OUT fixing the previous
16987 * expression.cs: Reverted last patch, that was wrong. Is_ref is
16988 not used to mean `ref' but `ref or out' in ParameterReference
16990 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
16991 full type signature instead of calling TypeManger.CSharpName
16994 * support.cs (InternalParameters.ParameterDesc): Do not compare
16995 directly to the modflags, because REF/OUT will actually be bitsets
16998 * delegate.cs (VerifyMethod): Check also the modifiers.
17000 * cs-tokenizer.cs: Fix bug where floating point values with an
17001 exponent where a sign was missing was ignored.
17003 * driver.cs: Allow multiple assemblies to be specified in a single
17006 2002-10-28 Miguel de Icaza <miguel@ximian.com>
17008 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
17009 because identifiers after a parenthesis would end up in this kind
17010 of production, and we needed to desamiguate it for having casts
17013 (UserDefinedType *) xxx
17015 2002-10-24 Miguel de Icaza <miguel@ximian.com>
17017 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
17018 we should set on the Bindingflags.NonPublic, but not turn on
17019 private_ok. private_ok controls whether a Private member is
17020 returned (this is chekced on the filter routine), while the
17021 BindingFlags.NonPublic just controls whether private/protected
17022 will be allowed. This fixes the problem part of the problem of
17023 private properties being allowed to be used in derived classes.
17025 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
17026 so we can call the children DoResolveLValue method (this will
17027 properly signal errors on lvalue assignments to base properties)
17029 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
17030 getter are null, and we have a property info, we know that this
17031 happened because the lookup failed, so we report an error 122 for
17032 protection level violation.
17034 We also silently return if setter and getter are null in the
17035 resolve functions, this condition only happens if we have flagged
17036 the error before. This is the other half of the problem.
17038 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
17039 not have accessibility information, that is why we were returning
17040 true in the filter function in typemanager.cs.
17042 To properly report 122 (property is inaccessible because of its
17043 protection level) correctly, we report this error in ResolveAccess
17044 by failing if both the setter and the getter are lacking (ie, the
17047 DoResolve and DoLResolve have been modified to check for both
17048 setter/getter being null and returning silently, the reason being
17049 that I did not want to put the knowledge about this error in upper
17052 int old = Report.Errors;
17053 x = new PropertyExpr (...);
17054 if (old != Report.Errors)
17059 So the property expr is returned, but it is invalid, so the error
17060 will be flagged during the resolve process.
17062 * class.cs: Remove InheritablePropertySignatureCompare from the
17063 class, as we no longer depend on the property signature to compute
17064 whether it is possible to implement a method or not.
17066 The reason is that calling PropertyInfo.GetGetMethod will return
17067 null (in .NET, in Mono it works, and we should change this), in
17068 cases where the Get Method does not exist in that particular
17073 class X { public virtual int A { get { return 1; } } }
17075 class Z : Y { public override int A { get { return 2; } } }
17077 Would fail in Z because the parent (Y) would not have the property
17078 defined. So we avoid this completely now (because the alternative
17079 fix was ugly and slow), and we now depend exclusively on the
17082 (PropertyBase.CheckBase): Use a method-base mechanism to find our
17083 reference method, instead of using the property.
17085 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
17086 routines are gone now.
17088 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
17089 names, they were incorrectly named.
17091 * cs-tokenizer.cs: Return are more gentle token on failure.
17093 * pending.cs (PendingImplementation.InterfaceMethod): This routine
17094 had an out-of-sync index variable, which caused it to remove from
17095 the list of pending methods the wrong method sometimes.
17097 2002-10-22 Miguel de Icaza <miguel@ximian.com>
17099 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
17100 CanWrite, because those refer to this particular instance of the
17101 property, and do not take into account the fact that we can
17102 override single members of a property.
17104 Constructor requires an EmitContext. The resolution process does
17105 not happen here, but we need to compute the accessors before,
17106 because the resolution does not always happen for properties.
17108 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
17109 subclass, before we did not update this flag, but we did update
17112 (GetAccessors): Drop this routine, as it did not work in the
17113 presence of partially overwritten set/get methods.
17115 Notice that this broke the cs1540 detection, but that will require
17118 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17122 * driver.cs: issue a warning instead of an error if we don't support
17123 debugging for the platform. Also ignore a couple of errors that may
17124 arise when trying to write the symbols. Undo my previous patch.
17126 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17128 * driver.cs: ignore /debug switch except for Unix platforms.
17130 2002-10-23 Nick Drochak <ndrochak@gol.com>
17132 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
17134 2002-10-21 Miguel de Icaza <miguel@ximian.com>
17136 * driver.cs: Do not make mcs-debug conditional, so we do not break
17137 builds that use it.
17139 * statement.cs (UsageVector.MergeChildren): I would like Martin to
17140 review this patch. But basically after all the children variables
17141 have been merged, the value of "Breaks" was not being set to
17142 new_breaks for Switch blocks. I think that it should be set after
17143 it has executed. Currently I set this to the value of new_breaks,
17144 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
17145 conservative, but I do not understand this code very well.
17147 I did not break anything in the build, so that is good ;-)
17149 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
17151 2002-10-20 Mark Crichton <crichton@gimp.org>
17153 * cfold.cs: Fixed compile blocker. Really fixed it this time.
17155 2002-10-20 Nick Drochak <ndrochak@gol.com>
17157 * cfold.cs: Fixed compile blocker.
17159 2002-10-20 Miguel de Icaza <miguel@ximian.com>
17161 * driver.cs: I was chekcing the key, not the file.
17163 2002-10-19 Ravi Pratap <ravi@ximian.com>
17165 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
17166 message that we were generating - we just need to silently return
17169 2002-10-19 Miguel de Icaza <miguel@ximian.com>
17171 * class.cs (Event.Define): Change my previous commit, as this
17172 breaks the debugger. This is a temporary hack, as it seems like
17173 the compiler is generating events incorrectly to begin with.
17175 * expression.cs (Binary.ResolveOperator): Added support for
17176 "U operator - (E x, E y)"
17178 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
17181 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
17182 init-only variables, but this path did not take into account that
17183 there might be also instance readonly variables. Correct this
17186 This fixes bug 32253
17188 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
17191 * driver.cs: Change the extension for modules to `netmodule'
17193 * cs-parser.jay: Improved slightly the location tracking for
17194 the debugger symbols.
17196 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
17197 modifiers that were specified instead of the hardcoded value
17198 (FamAndAssem). This was basically ignoring the static modifier,
17199 and others. Fixes 32429.
17201 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
17202 fixed a bug in the process (32476)
17204 * expression.cs (ArrayAccess.EmitAssign): Patch from
17205 hwang_rob@yahoo.ca that fixes bug 31834.3
17207 2002-10-18 Miguel de Icaza <miguel@ximian.com>
17209 * driver.cs: Make the module extension .netmodule.
17211 2002-10-16 Miguel de Icaza <miguel@ximian.com>
17213 * driver.cs: Report an error if the resource file is not found
17214 instead of crashing.
17216 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
17217 false, like Emit does.
17219 2002-10-16 Nick Drochak <ndrochak@gol.com>
17221 * typemanager.cs: Remove unused private member. Also reported mcs
17222 bug to report this as a warning like csc.
17224 2002-10-15 Martin Baulig <martin@gnome.org>
17226 * statement.cs (Statement.Emit): Made this a virtual method; emits
17227 the line number info and calls DoEmit().
17228 (Statement.DoEmit): New protected abstract method, formerly knows
17229 as Statement.Emit().
17231 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
17233 2002-10-11 Miguel de Icaza <miguel@ximian.com>
17235 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
17236 have fixed a remaining problem: not every AddXXXX was adding a
17237 fully qualified name.
17239 Now everyone registers a fully qualified name in the DeclSpace as
17240 being defined instead of the partial name.
17242 Downsides: we are slower than we need to be due to the excess
17243 copies and the names being registered this way.
17245 The reason for this is that we currently depend (on the corlib
17246 bootstrap for instance) that types are fully qualified, because
17247 we dump all the types in the namespace, and we should really have
17248 types inserted into the proper namespace, so we can only store the
17249 basenames in the defined_names array.
17251 2002-10-10 Martin Baulig <martin@gnome.org>
17253 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
17254 from bug #31834, see the bug report for a testcase which is
17257 2002-10-10 Martin Baulig <martin@gnome.org>
17259 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
17260 flow analysis code for this.
17262 * statement.cs (Do, While, For): Tell the flow analysis code about
17264 (FlowBranching.UsageVector): Added support for infinite loops.
17265 (Block.Resolve): Moved the dead code elimination here and use flow
17268 2002-10-09 Miguel de Icaza <miguel@ximian.com>
17270 * class.cs (Field.Define): Catch cycles on struct type
17273 * typemanager.cs (IsUnmanagedtype): Do not recursively check
17274 fields if the fields are static. We only need to check instance
17277 * expression.cs (As.DoResolve): Test for reference type.
17279 * statement.cs (Using.ResolveExpression): Use
17280 ConvertImplicitRequired, not ConvertImplicit which reports an
17282 (Using.ResolveLocalVariableDecls): ditto.
17284 * expression.cs (Binary.ResolveOperator): Report errors in a few
17285 places where we had to.
17287 * typemanager.cs (IsUnmanagedtype): Finish implementation.
17289 2002-10-08 Miguel de Icaza <miguel@ximian.com>
17291 * expression.cs: Use StoreFromPtr instead of extracting the type
17292 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
17294 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
17295 an enumeration value to a System.Enum, but System.Enum is not a
17296 value type, but an class type, so we need to box.
17298 (Expression.ConvertExplicit): One codepath could return
17299 errors but not flag them. Fix this. Fixes #31853
17301 * parameter.cs (Resolve): Do not allow void as a parameter type.
17303 2002-10-06 Martin Baulig <martin@gnome.org>
17305 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
17306 if it's a class type and not a struct. Fixes #31815.
17308 2002-10-06 Martin Baulig <martin@gnome.org>
17310 * statement.cs: Reworked the flow analysis code a bit to make it
17311 usable for dead code elimination.
17313 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17315 * cs-parser.jay: allow empty source files. Fixes bug #31781.
17317 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17319 * expression.cs (ComposedCast.DoResolveType): A quick workaround
17320 to fix the test 165, will investigate deeper.
17322 2002-10-04 Martin Baulig <martin@gnome.org>
17324 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
17325 finally blocks actually work.
17326 (Try.Resolve): We don't need to create a sibling for `finally' if
17327 there is no finally block.
17329 2002-10-04 Martin Baulig <martin@gnome.org>
17331 * class.cs (Constructor.Define): The default accessibility for a
17332 non-default constructor is private, not public.
17334 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17336 * class.cs (Constructor): Make AllowedModifiers public, add
17339 * cs-parser.jay: Perform the modifiers test here, as the
17340 constructor for the Constructor class usually receives a zero
17341 because of the way we create it (first we create, later we
17342 customize, and we were never checking the modifiers).
17344 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
17345 is a version of LookupTypeReflection that includes the type-name
17346 cache. This can be used as a fast path for functions that know
17347 the fully qualified name and are only calling into *.GetType() to
17348 obtain a composed type.
17350 This is also used by TypeManager.LookupType during its type
17353 (LookupType): We now also track the real type name, as sometimes
17354 we can get a quey for the real type name from things like
17355 ComposedCast. This fixes bug 31422.
17357 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
17358 complete type fullname, it does not have to go through the type
17359 resolution system to obtain the composed version of the type (for
17360 obtaining arrays or pointers).
17362 (Conditional.Emit): Use the EmitBoolExpression to
17363 generate nicer code, as requested by Paolo.
17365 (ArrayCreation.CheckIndices): Use the patch from
17366 hwang_rob@yahoo.ca to validate the array initializers.
17368 2002-10-03 Miguel de Icaza <miguel@ximian.com>
17370 * class.cs (ConstructorInitializer.Emit): simplify code by using
17371 Invocation.EmitCall, and at the same time, fix the bugs in calling
17372 parent constructors that took variable arguments.
17374 * ecore.cs (Expression.ConvertNumericExplicit,
17375 Expression.ImplicitNumericConversion): Remove the code that
17376 manually wrapped decimal (InternalTypeConstructor call is now gone
17379 * expression.cs (Cast.TryReduce): Also handle decimal types when
17380 trying to perform a constant fold on the type.
17382 * typemanager.cs (IsUnmanagedtype): Partially implemented.
17384 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
17385 that only turned off an error report, and did nothing else.
17387 2002-10-02 Miguel de Icaza <miguel@ximian.com>
17389 * driver.cs: Handle and ignore /fullpaths
17391 2002-10-01 Miguel de Icaza <miguel@ximian.com>
17393 * expression.cs (Binary.ResolveOperator): Catch the case where
17394 DoNumericPromotions returns true,
17396 (Binary.DoNumericPromotions): Simplify the code, and the tests.
17398 2002-09-27 Miguel de Icaza <miguel@ximian.com>
17400 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
17403 2002-09-26 Miguel de Icaza <miguel@ximian.com>
17405 * ecore.cs (ConvertNumericExplicit): It is not enough that the
17406 conversion exists, but it is also required that the conversion be
17407 performed. This manifested in "(Type64Enum) 2".
17409 * class.cs (TypeManager.AddMethod): The fix is not to change
17410 AddEnum, because that one was using a fully qualified name (every
17411 DeclSpace derivative does), but to change the AddMethod routine
17412 that was using an un-namespaced name. This now correctly reports
17413 the duplicated name.
17415 Revert patch until I can properly fix it. The issue
17416 is that we have a shared Type space across all namespaces
17417 currently, which is wrong.
17419 Options include making the Namespace a DeclSpace, and merge
17420 current_namespace/current_container in the parser.
17422 2002-09-25 Miguel de Icaza <miguel@ximian.com>
17424 * cs-parser.jay: Improve error reporting when we get a different
17425 kind of expression in local_variable_type and
17426 local_variable_pointer_type.
17428 Propagate this to avoid missleading errors being reported.
17430 * ecore.cs (ImplicitReferenceConversion): treat
17431 TypeManager.value_type as a target just like object_type. As
17436 Is valid, and needs to result in the int 1 being boxed before it
17437 is assigned to the value type v.
17439 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
17440 to validate the enumeration name.
17442 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
17443 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
17444 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
17446 * ecore.cs (TryImplicitIntConversion): When doing an
17447 implicit-enumeration-conversion, check if the type is 64-bits and
17448 perform a conversion before passing to EnumConstant.
17450 2002-09-23 Miguel de Icaza <miguel@ximian.com>
17452 * decl.cs (Error_AmbiguousTypeReference); New routine used to
17453 report ambiguous type references. Unlike the MS version, we
17454 report what the ambiguity is. Innovation at work ;-)
17456 (DeclSpace.FindType): Require a location argument to
17457 display when we display an ambiguous error.
17459 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
17461 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
17463 * expression.cs (EmitDynamicInitializers): Apply patch from
17464 hwang_rob@yahoo.ca that fixes the order in which we emit our
17467 2002-09-21 Martin Baulig <martin@gnome.org>
17469 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
17470 delegate takes no arguments.
17472 2002-09-20 Miguel de Icaza <miguel@ximian.com>
17474 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
17477 * expression.cs: Extract the underlying type.
17479 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
17481 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
17483 2002-09-19 Miguel de Icaza <miguel@ximian.com>
17485 * class.cs (TypeContainer.DefineType): We can not use the nice
17486 PackingSize with the size set to 1 DefineType method, because it
17487 will not allow us to define the interfaces that the struct
17490 This completes the fixing of bug 27287
17492 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
17493 means also structs. This fixes part of the problem.
17494 (Expresion.ImplicitReferenceConversionExists): ditto.
17496 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
17497 error if there were no errors reported during the type lookup
17498 process, to avoid duplicates or redundant errors. Without this
17499 you would get an ambiguous errors plus a type not found. We have
17500 beaten the user enough with the first error.
17502 (DeclSparce.FindType): Emit a warning if we have an ambiguous
17505 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
17506 during the resolution process, stop the lookup, this avoids
17507 repeated error reports (same error twice).
17509 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
17511 * typemanager.cs (LookupType): Redo the type lookup code to match
17512 the needs of System.Reflection.
17514 The issue is that System.Reflection requires references to nested
17515 types to begin with a "+" sign instead of a dot. So toplevel
17516 types look like: "NameSpace.TopLevelClass", and nested ones look
17517 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
17520 2002-09-19 Martin Baulig <martin@gnome.org>
17522 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
17523 says that a method always returns or always throws an exception,
17524 don't report the CS0161.
17526 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
17527 set `Returns = new_returns'.
17529 2002-09-19 Martin Baulig <martin@gnome.org>
17531 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
17532 to an enum constant, check for a CS0176.
17534 2002-09-18 Miguel de Icaza <miguel@ximian.com>
17536 * class.cs (TypeContainer.CheckPairedOperators): Now we check
17537 for operators that must be in pairs and report errors.
17539 * ecore.cs (SimpleName.DoResolveType): During the initial type
17540 resolution process, when we define types recursively, we must
17541 check first for types in our current scope before we perform
17542 lookups in the enclosing scopes.
17544 * expression.cs (MakeByteBlob): Handle Decimal blobs.
17546 (Invocation.VerifyArgumentsCompat): Call
17547 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
17548 I thought we were supposed to always call this, but there are a
17549 few places in the code where we dont do it.
17551 2002-09-17 Miguel de Icaza <miguel@ximian.com>
17553 * driver.cs: Add support in -linkres and -resource to specify the
17554 name of the identifier.
17556 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17558 * ecore.cs (StandardConversionExists): Sync with the conversion
17559 code: allow anything-* to void* conversions.
17561 (FindMostSpecificSource): Use an Expression argument
17562 instead of a Type, because we might be handed over a Literal which
17563 gets a few more implicit conversions that plain types do not. So
17564 this information was being lost.
17566 Also, we drop the temporary type-holder expression when not
17569 2002-09-17 Martin Baulig <martin@gnome.org>
17571 * class.cs (PropertyBase.CheckBase): Don't check the base class if
17572 this is an explicit interface implementation.
17574 2002-09-17 Martin Baulig <martin@gnome.org>
17576 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
17577 different `IndexerName' attributes.
17579 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
17580 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
17581 virtual CommonResolve().
17583 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17585 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
17586 and convert that to the UnderlyingType.
17588 * statement.cs (Foreach.Resolve): Indexers are just like variables
17589 or PropertyAccesses.
17591 * cs-tokenizer.cs (consume_string): Track line numbers and columns
17592 inside quoted strings, we were not doing this before.
17594 2002-09-16 Martin Baulig <martin@gnome.org>
17596 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
17597 resolve it. This is needed for the definite assignment check of the
17598 instance expression, fixes bug #29846.
17599 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
17601 2002-09-16 Nick Drochak <ndrochak@gol.com>
17603 * parameter.cs: Fix compile error. Cannot reference static member
17604 from an instance object. Is this an mcs bug?
17606 2002-09-14 Martin Baulig <martin@gnome.org>
17608 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
17609 multiple times. Fixes bug #30295, added test-166.cs.
17611 2002-09-14 Martin Baulig <martin@gnome.org>
17613 * statement.cs (Block.Emit): Don't emit unreachable code.
17614 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
17615 `break' statements.
17616 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
17618 2002-09-14 Martin Baulig <martin@gnome.org>
17620 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
17623 2002-09-14 Martin Baulig <martin@gnome.org>
17625 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
17626 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
17627 be false on the ms runtime.
17629 2002-09-13 Martin Baulig <martin@gnome.org>
17631 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
17632 the CS0038 error message.
17634 2002-09-12 Miguel de Icaza <miguel@ximian.com>
17636 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
17637 constant inside, return it.
17639 2002-09-12 Martin Baulig <martin@gnome.org>
17641 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
17642 implicit conversion can be done between enum types.
17644 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
17645 check whether an implicit conversion to the current enum's UnderlyingType
17646 exists and report an error if not.
17648 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
17649 without debugging support.
17651 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
17652 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
17654 2002-09-12 Martin Baulig <martin@gnome.org>
17656 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
17658 * ecore.cs (IMemberExpr.DeclaringType): New property.
17659 (SimpleName.SimpleNameResolve): Check whether we're accessing a
17660 nonstatic member of an outer type (CS0038).
17662 2002-09-11 Miguel de Icaza <miguel@ximian.com>
17664 * driver.cs: Activate the using-error detector at warning level
17665 4 (at least for MS-compatible APIs).
17667 * namespace.cs (VerifyUsing): Small buglett fix.
17669 * pending.cs (PendingImplementation): pass the container pointer.
17671 * interface.cs (GetMethods): Allow for recursive definition. Long
17672 term, I would like to move every type to support recursive
17673 definitions, not the current ordering mechanism that we have right
17676 The situation is this: Attributes are handled before interfaces,
17677 so we can apply attributes to interfaces. But some attributes
17678 implement interfaces, we will now handle the simple cases
17679 (recursive definitions will just get an error).
17681 * parameter.cs: Only invalidate types at the end if we fail to
17684 2002-09-09 Martin Baulig <martin@gnome.org>
17686 * ecore.cs (PropertyExpr.Emit): Also check for
17687 TypeManager.system_int_array_get_length so this'll also work when
17688 compiling corlib. Fixes #30003.
17690 2002-09-09 Martin Baulig <martin@gnome.org>
17692 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
17693 and throw an exception if we can't get the type's size. Fixed #30040,
17696 2002-09-09 Martin Baulig <martin@gnome.org>
17698 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
17700 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
17701 context. Fixes bug #30027.
17703 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
17704 virtual functions. Fixes bug #30043, added test-164.cs.
17706 2002-09-08 Ravi Pratap <ravi@ximian.com>
17708 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
17710 2002-09-08 Nick Drochak <ndrochak@gol.com>
17712 * driver.cs: Use an object to get the windows codepage since it's not a
17715 2002-09-08 Miguel de Icaza <miguel@ximian.com>
17717 * statement.cs (For.Emit): for infinite loops (test == null)
17718 return whether there is a break inside, not always "true".
17720 * namespace.cs (UsingEntry): New struct to hold the name of the
17721 using definition, the location where it is defined, and whether it
17722 has been used in a successful type lookup.
17724 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
17729 2002-09-06 Ravi Pratap <ravi@ximian.com>
17731 * attribute.cs : Fix incorrect code which relied on catching
17732 a NullReferenceException to detect a null being passed in
17733 where an object was expected.
17735 2002-09-06 Miguel de Icaza <miguel@ximian.com>
17737 * statement.cs (Try): flag the catch variable as assigned
17739 * expression.cs (Cast): Simplified by using ResolveType instead of
17740 manually resolving.
17742 * statement.cs (Catch): Fix bug by using ResolveType.
17744 2002-09-06 Ravi Pratap <ravi@ximian.com>
17746 * expression.cs (BetterConversion): Special case for when we have
17747 a NullLiteral as the argument and we have to choose between string
17748 and object types - we choose string the way csc does.
17750 * attribute.cs (Attribute.Resolve): Catch the
17751 NullReferenceException and report error #182 since the Mono
17752 runtime no more has the bug and having this exception raised means
17753 we tried to select a constructor which takes an object and is
17756 2002-09-05 Ravi Pratap <ravi@ximian.com>
17758 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
17759 message (1502, 1503) when we can't locate a method after overload
17760 resolution. This is much more informative and closes the bug
17763 * interface.cs (PopulateMethod): Return if there are no argument
17764 types. Fixes a NullReferenceException bug.
17766 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
17767 expressions too. Previously we were checking only in one place for
17768 positional arguments leaving out named arguments.
17770 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
17771 type to the enum type is not allowed. Remove code corresponding to
17774 (ConvertNumericExplicit): Allow explicit conversions from
17775 the underlying type to enum type. This precisely follows the spec
17776 and closes a bug filed by Gonzalo.
17778 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17781 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
17783 2002-09-03 Miguel de Icaza <miguel@ximian.com>
17785 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
17786 it was important that we stored the right value after the
17787 reduction in `converted'.
17789 2002-09-04 Martin Baulig <martin@gnome.org>
17791 * location.cs (Location.SymbolDocument): Use full pathnames for the
17794 2002-08-30 Miguel de Icaza <miguel@ximian.com>
17796 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
17797 of the expression resolve mechanism, because that will catch the
17798 SimpleName error failures.
17800 (Conditional): If we can not resolve the
17801 expression, return, do not crash.
17803 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17806 (location): display token name instead of its number.
17808 2002-08-28 Martin Baulig <martin@gnome.org>
17810 * expression.cs (Binary.ResolveOperator): Don't silently return
17811 but return an error if an operator cannot be applied between two
17814 2002-08-28 Martin Baulig <martin@gnome.org>
17816 * class.cs (Constructor.Define): Set the permission attributes
17817 correctly instead of making all constructors public.
17819 2002-08-28 Martin Baulig <martin@gnome.org>
17821 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
17822 for private members before reporting a CS0103; if we find anything,
17825 2002-08-28 Martin Baulig <martin@gnome.org>
17827 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
17828 to check whether `closure_start_type == closure_invocation_type',
17829 we also need to check whether `m.DeclaringType == closure_invocation_type'
17830 before bypassing the permission checks. We might be accessing
17831 protected/private members from the base class.
17832 (TypeManager.RealMemberLookup): Only set private_ok if private
17833 members were requested via BindingFlags.NonPublic.
17835 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
17837 * expression.cs (MemberAccess.ResolveMemberAccess): Set
17838 MethodGroupExpr.IsExplicitImpl if appropriate.
17839 (Invocation.DoResolve): Don't report the CS0120 for explicit
17840 interface implementations.
17842 2002-08-27 Martin Baulig <martin@gnome.org>
17844 * expression.cs (Invocation.DoResolve): If this is a static
17845 method and we don't have an InstanceExpression, we must report
17848 2002-08-25 Martin Baulig <martin@gnome.org>
17850 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
17851 `==' between a valuetype and an object.
17853 2002-08-25 Miguel de Icaza <miguel@ximian.com>
17855 * ecore.cs (TypeExpr): Provide a ToString method.
17857 2002-08-24 Martin Baulig <martin@gnome.org>
17859 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
17860 now called proggie.dbg and it's a binary file.
17862 2002-08-23 Martin Baulig <martin@gnome.org>
17864 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
17866 2002-08-23 Martin Baulig <martin@gnome.org>
17868 * struct.cs (MyStructInfo.ctor): Make this work with empty
17869 structs; it's not allowed to use foreach() on null.
17871 2002-08-23 Martin Baulig <martin@gnome.org>
17873 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
17874 writer the full pathname of the generated assembly.
17876 2002-08-23 Martin Baulig <martin@gnome.org>
17878 * statements.cs (FlowBranching.UsageVector.MergeChildren):
17879 A `finally' block never returns or breaks; improved handling of
17882 2002-08-23 Martin Baulig <martin@gnome.org>
17884 * statement.cs (Throw.Resolve): Allow `throw null'.
17886 2002-08-23 Martin Baulig <martin@gnome.org>
17888 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
17889 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
17890 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
17891 MemberLookup would return a wrong event if this is an explicit
17892 interface implementation and the class has an event with the same
17895 2002-08-23 Martin Baulig <martin@gnome.org>
17897 * statement.cs (Block.AddChildVariableNames): New public method.
17898 (Block.AddChildVariableName): Likewise.
17899 (Block.IsVariableNameUsedInChildBlock): Likewise.
17900 (Block.AddVariable): Check whether a variable name has already
17901 been used in a child block.
17903 * cs-parser.jay (declare_local_variables): Mark all variable names
17904 from the current block as being used in a child block in the
17907 2002-08-23 Martin Baulig <martin@gnome.org>
17909 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
17910 find the symbol writer.
17912 * driver.cs: csc also allows the arguments to /define being
17913 separated by commas, not only by semicolons.
17915 2002-08-23 Martin Baulig <martin@gnome.org>
17917 * interface.cs (Interface.GetMembers): Added static check for events.
17919 2002-08-15 Martin Baulig <martin@gnome.org>
17921 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
17922 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
17924 * ecore.cs (Expression.MemberLookup): Added documentation and explained
17925 why the MethodData.EmitDestructor() change was necessary.
17927 2002-08-20 Martin Baulig <martin@gnome.org>
17929 * class.cs (TypeContainer.FindMembers): Added static check for events.
17931 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
17933 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
17934 use Type.GetEvents(), not Type.FindMembers().
17936 2002-08-20 Martin Baulig <martin@gnome.org>
17938 * decl.cs (MemberCache): Added a special method cache which will
17939 be used for method-only searched. This ensures that a method
17940 search will return a MethodInfo with the correct ReflectedType for
17943 2002-08-20 Martin Baulig <martin@gnome.org>
17945 * decl.cs (DeclSpace.FindMembers): Made this public.
17947 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17949 * delegate.cs: fixed build on windows.
17950 [FIXME: Filed as bug #29150: MCS must report these errors.]
17952 2002-08-19 Ravi Pratap <ravi@ximian.com>
17954 * ecore.cs (StandardConversionExists): Return a false
17955 if we are trying to convert the void type to anything else
17956 since that is not allowed.
17958 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
17959 we flag error 70 in the event an event is trying to be accessed
17960 directly from outside the declaring type.
17962 2002-08-20 Martin Baulig <martin@gnome.org>
17964 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
17965 MemberCache from typemanager.cs to decl.cs.
17967 2002-08-19 Martin Baulig <martin@gnome.org>
17969 * class.cs (TypeContainer): Implement IMemberContainer.
17970 (TypeContainer.DefineMembers): Create the MemberCache.
17971 (TypeContainer.FindMembers): Do better BindingFlags checking; only
17972 return public members if BindingFlags.Public was given, check
17973 whether members are static.
17975 2002-08-16 Martin Baulig <martin@gnome.org>
17977 * decl.cs (DeclSpace.Define): Splitted this in Define and
17978 DefineMembers. DefineMembers is called first and initializes the
17981 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
17982 DefineMembers() on all our DeclSpaces.
17984 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
17985 but call DefineMembers() on all nested interfaces. We call their
17986 Define() in our new Define() function.
17988 * interface.cs (Interface): Implement IMemberContainer.
17989 (Interface.Define): Moved all code except the attribute stuf to
17991 (Interface.DefineMembers): Initialize the member cache.
17993 * typemanager.cs (IMemberFinder): Removed this interface, we don't
17994 need this anymore since we can use MemberCache.FindMembers directly.
17996 2002-08-19 Martin Baulig <martin@gnome.org>
17998 * typemanager.cs (MemberCache): When creating the cache for an
17999 interface type, add all inherited members.
18000 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
18001 to `out bool used_cache' and documented it.
18002 (TypeManager.MemberLookup): If we already used the cache in the first
18003 iteration, we don't need to do the interfaces check.
18005 2002-08-19 Martin Baulig <martin@gnome.org>
18007 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
18008 here from IMemberFinder and don't implement this interface anymore.
18009 (DeclSpace.MemberCache): Moved here from IMemberFinder.
18011 * typemanager.cs (IMemberFinder): This interface is now only used by
18012 classes which actually support the member cache.
18013 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
18014 since we only put DeclSpaces into this Hashtable.
18015 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
18016 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
18018 2002-08-16 Martin Baulig <martin@gnome.org>
18020 * typemanager.cs (ICachingMemberFinder): Removed.
18021 (IMemberFinder.MemberCache): New property.
18022 (TypeManager.FindMembers): Merged this with RealFindMembers().
18023 This function will never be called from TypeManager.MemberLookup()
18024 so we can't use the cache here, just the IMemberFinder.
18025 (TypeManager.MemberLookup_FindMembers): Check whether the
18026 IMemberFinder has a MemberCache and call the cache's FindMembers
18028 (MemberCache): Rewrote larger parts of this yet another time and
18029 cleaned it up a bit.
18031 2002-08-15 Miguel de Icaza <miguel@ximian.com>
18033 * driver.cs (LoadArgs): Support quoting.
18035 (Usage): Show the CSC-like command line arguments.
18037 Improved a few error messages.
18039 2002-08-15 Martin Baulig <martin@gnome.org>
18041 * typemanager.cs (IMemberContainer.Type): New property.
18042 (IMemberContainer.IsInterface): New property.
18044 The following changes are conditional to BROKEN_RUNTIME, which is
18045 defined at the top of the file.
18047 * typemanager.cs (MemberCache.MemberCache): Don't add the base
18048 class'es members, but add all members from TypeHandle.ObjectType
18049 if we're an interface.
18050 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
18051 is the current type.
18052 (MemberCache.CacheEntry.Container): Removed this field.
18053 (TypeHandle.GetMembers): Include inherited members.
18055 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18057 * typemanager.cs: fixed compilation and added a comment on a field that
18060 2002-08-15 Martin Baulig <martin@gnome.org>
18062 * class.cs (ConstructorInitializer.Resolve): In the
18063 Expression.MemberLookup call, use the queried_type as
18066 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
18067 declared' attribute, it's always true.
18068 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
18069 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
18070 temporary wrapper for FindMembers which tells MemberLookup whether
18071 members from the base classes are included in the return value.
18072 This will go away soon.
18073 (TypeManager.MemberLookup): Use this temporary hack here; once the
18074 new MemberCache is completed, we don't need to do the DeclaredOnly
18075 looping here anymore since the MemberCache will take care of this.
18076 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
18077 (MemberCache): When creating the MemberCache for a class, get
18078 members from the current class and all its base classes.
18079 (MemberCache.CacheEntry.Container): New field. This is a
18080 temporary hack until the Mono runtime is fixed to distinguish
18081 between ReflectedType and DeclaringType. It allows us to use MCS
18082 with both the MS runtime and the unfixed Mono runtime without
18083 problems and without accecting performance.
18084 (MemberCache.SearchMembers): The DeclaredOnly looping from
18085 TypeManager.MemberLookup is now done here.
18087 2002-08-14 Martin Baulig <martin@gnome.org>
18089 * statement.cs (MyStructInfo.MyStructInfo): Don't call
18090 Type.GetFields on dynamic types but get the fields from the
18091 corresponding TypeContainer.
18092 (MyStructInfo.GetStructInfo): Added check for enum types.
18094 * typemanager.cs (MemberList.IsSynchronized): Implemented.
18095 (MemberList.SyncRoot): Implemented.
18096 (TypeManager.FilterWithClosure): No need to check permissions if
18097 closure_start_type == closure_invocation_type, don't crash if
18098 closure_invocation_type is null.
18100 2002-08-13 Martin Baulig <martin@gnome.org>
18102 Rewrote TypeContainer.FindMembers to use a member cache. This
18103 gives us a speed increase of about 35% for the self-hosting MCS
18104 build and of about 15-20% for the class libs (both on GNU/Linux).
18106 * report.cs (Timer): New class to get enhanced profiling. This
18107 whole class is "TIMER" conditional since it remarkably slows down
18110 * class.cs (MemberList): New class. This is an IList wrapper
18111 which we're now using instead of passing MemberInfo[]'s around to
18112 avoid copying this array unnecessarily.
18113 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
18114 (ICachingMemberFinder, IMemberContainer): New interface.
18115 (TypeManager.FilterWithClosure): If `criteria' is null, the name
18116 has already been checked, otherwise use it for the name comparision.
18117 (TypeManager.FindMembers): Renamed to RealMemberFinder and
18118 provided wrapper which tries to use ICachingMemberFinder.FindMembers
18119 if possible. Returns a MemberList, not a MemberInfo [].
18120 (TypeHandle): New class, implements IMemberContainer. We create
18121 one instance of this class per type, it contains a MemberCache
18122 which is used to do the member lookups.
18123 (MemberCache): New class. Each instance of this class contains
18124 all members of a type and a name-based hash table.
18125 (MemberCache.FindMembers): This is our new member lookup
18126 function. First, it looks up all members of the requested name in
18127 the hash table. Then, it walks this list and sorts out all
18128 applicable members and returns them.
18130 2002-08-13 Martin Baulig <martin@gnome.org>
18132 In addition to a nice code cleanup, this gives us a performance
18133 increase of about 1.4% on GNU/Linux - not much, but it's already
18134 half a second for the self-hosting MCS compilation.
18136 * typemanager.cs (IMemberFinder): New interface. It is used by
18137 TypeManager.FindMembers to call FindMembers on a TypeContainer,
18138 Enum, Delegate or Interface.
18139 (TypeManager.finder_to_member_finder): New PtrHashtable.
18140 (TypeManager.finder_to_container): Removed.
18141 (TypeManager.finder_to_delegate): Removed.
18142 (TypeManager.finder_to_interface): Removed.
18143 (TypeManager.finder_to_enum): Removed.
18145 * interface.cs (Interface): Implement IMemberFinder.
18147 * delegate.cs (Delegate): Implement IMemberFinder.
18149 * enum.cs (Enum): Implement IMemberFinder.
18151 * class.cs (TypeContainer): Implement IMemberFinder.
18153 2002-08-12 Martin Baulig <martin@gnome.org>
18155 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
18157 2002-08-12 Martin Baulig <martin@gnome.org>
18159 * ecore.cs (ITypeExpression): New interface for expressions which
18161 (TypeExpression): Renamed to TypeLookupExpression.
18162 (Expression.DoResolve): If we're doing a types-only lookup, the
18163 expression must implement the ITypeExpression interface and we
18164 call DoResolveType() on it.
18165 (SimpleName): Implement the new ITypeExpression interface.
18166 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
18167 hack, the situation that we're only looking up types can't happen
18168 anymore when this method is called. Moved the type lookup code to
18169 DoResolveType() and call it.
18170 (SimpleName.DoResolveType): This ITypeExpression interface method
18171 is now doing the types-only lookup.
18172 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
18173 (ResolveFlags): Added MaskExprClass.
18175 * expression.cs (MemberAccess): Implement the ITypeExpression
18177 (MemberAccess.DoResolve): Added support for a types-only lookup
18178 when we're called via ITypeExpression.DoResolveType().
18179 (ComposedCast): Implement the ITypeExpression interface.
18181 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
18182 Expression.Resolve() with ResolveFlags.Type instead.
18184 2002-08-12 Martin Baulig <martin@gnome.org>
18186 * interface.cs (Interface.Define): Apply attributes.
18188 * attribute.cs (Attribute.ApplyAttributes): Added support for
18189 interface attributes.
18191 2002-08-11 Martin Baulig <martin@gnome.org>
18193 * statement.cs (Block.Emit): Only check the "this" variable if we
18194 do not always throw an exception.
18196 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
18197 whether the property has a set accessor.
18199 2002-08-11 Martin Baulig <martin@gnome.org>
18201 Added control flow analysis support for structs.
18203 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
18204 with control flow analysis turned off.
18205 (IVariable): New interface.
18206 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
18207 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
18208 (FieldExpr.DoResolve): Resolve the instance expression with flow
18209 analysis turned off and do the definite assignment check after the
18210 resolving when we know what the expression will resolve to.
18212 * expression.cs (LocalVariableReference, ParameterReference):
18213 Implement the new IVariable interface, only call the flow analysis
18214 code if ec.DoFlowAnalysis is true.
18215 (This): Added constructor which takes a Block argument. Implement
18216 the new IVariable interface.
18217 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
18218 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
18219 This does the definite assignment checks for struct members.
18221 * class.cs (Constructor.Emit): If this is a non-static `struct'
18222 constructor which doesn't have any initializer, call
18223 Block.AddThisVariable() to tell the flow analysis code that all
18224 struct elements must be initialized before control returns from
18227 * statement.cs (MyStructInfo): New public class.
18228 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
18229 argument to this indexer. If non-zero, check an individual struct
18230 member, not the whole struct.
18231 (FlowBranching.CheckOutParameters): Check struct members.
18232 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
18233 overloaded versions of these methods which take an additional
18234 `int field_idx' argument to check struct members.
18235 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
18236 overloaded versions of these methods which take an additional
18237 `string field_name' argument to check struct member.s
18238 (VariableInfo): Implement the IVariable interface.
18239 (VariableInfo.StructInfo): New public property. Returns the
18240 MyStructInfo instance of the variable if it's a struct or null.
18241 (Block.AddThisVariable): New public method. This is called from
18242 Constructor.Emit() for non-static `struct' constructor which do
18243 not have any initializer. It creates a special variable for the
18244 "this" instance variable which will be checked by the flow
18245 analysis code to ensure that all of the struct's fields are
18246 initialized before control returns from the constructor.
18247 (UsageVector): Added support for struct members. If a
18248 variable/parameter is a struct with N members, we reserve a slot
18249 in the usage vector for each member. A struct is considered fully
18250 initialized if either the struct itself (slot 0) or all its
18251 members are initialized.
18253 2002-08-08 Martin Baulig <martin@gnome.org>
18255 * driver.cs (Driver.MainDriver): Only report an error CS5001
18256 if there were no compilation errors.
18258 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
18259 `UnsafeContext' property to determine whether the parent is in
18260 unsafe context rather than checking the parent's ModFlags:
18261 classes nested in an unsafe class are unsafe as well.
18263 2002-08-08 Martin Baulig <martin@gnome.org>
18265 * statement.cs (UsageVector.MergeChildren): Distinguish between
18266 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
18267 we return. Added test17() and test18() to test-154.cs.
18269 2002-08-08 Martin Baulig <martin@gnome.org>
18271 * typemanager.cs (TypeManager.FilterWithClosure): If we have
18272 Family access, make sure the invoking type isn't a subclass of the
18273 queried type (that'd be a CS1540).
18275 * ecore.cs (Expression.MemberLookup): Added overloaded version of
18276 this method which takes an additional `Type invocation_type'.
18278 * expression.cs (BaseAccess.DoResolve): Use the base type as
18279 invocation and query type.
18280 (MemberAccess.DoResolve): If the lookup failed and we're about to
18281 report a CS0122, try a lookup with the ec.ContainerType - if this
18282 succeeds, we must report a CS1540.
18284 2002-08-08 Martin Baulig <martin@gnome.org>
18286 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
18287 (MethodGroupExpr): Implement the IMemberExpr interface.
18289 * expression (MemberAccess.ResolveMemberAccess): No need to have
18290 any special code for MethodGroupExprs anymore, they're now
18293 2002-08-08 Martin Baulig <martin@gnome.org>
18295 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
18296 Family, FamANDAssem and FamORAssem permissions.
18297 (TypeManager.IsSubclassOrNestedChildOf): New public method.
18299 2002-08-08 Martin Baulig <martin@gnome.org>
18301 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
18302 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
18305 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
18307 * driver.cs: implemented /resource option to embed managed resources.
18309 2002-08-07 Martin Baulig <martin@gnome.org>
18311 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
18312 (FieldBase.HasFieldInitializer): New public property.
18313 (FieldBase.GetInitializerExpression): New public method. Resolves and
18314 returns the field initializer and makes sure it is only resolved once.
18315 (TypeContainer.EmitFieldInitializers): Call
18316 FieldBase.GetInitializerExpression to get the initializer, this ensures
18317 that it isn't resolved multiple times.
18319 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
18320 the resolving process (SimpleName/MemberLookup) that we're currently
18321 emitting a field initializer (which must not access any instance members,
18322 this is an error CS0236).
18324 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
18325 argument, if the `IsFieldInitializer' flag is set, we must report and
18326 error CS0236 and not an error CS0120.
18328 2002-08-07 Martin Baulig <martin@gnome.org>
18330 * ecore.cs (IMemberExpr): New public interface.
18331 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
18332 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
18333 if the expression is an IMemberExpr.
18335 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
18336 to be null, implicitly default to `this' if we're non-static in
18337 this case. Simplified the code a lot by using the new IMemberExpr
18338 interface. Also fixed bug #28176 here.
18340 2002-08-06 Martin Baulig <martin@gnome.org>
18342 * cs-parser.jay (SimpleLookup): Removed. We need to create
18343 ParameterReferences during semantic analysis so that we can do a
18344 type-only search when resolving Cast, TypeOf and SizeOf.
18345 (block): Pass the `current_local_parameters' to the Block's
18348 * class.cs (ConstructorInitializer): Added `Parameters parameters'
18349 argument to the constructor.
18350 (ConstructorInitializer.Resolve): Create a temporary implicit
18351 block with the parameters.
18353 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
18354 references here if we aren't doing a type-only search.
18356 * statement.cs (Block): Added constructor which takes a
18357 `Parameters parameters' argument.
18358 (Block.Parameters): New public property.
18360 * support.cs (InternalParameters.Parameters): Renamed `parameters'
18361 to `Parameters' and made it public readonly.
18363 2002-08-06 Martin Baulig <martin@gnome.org>
18365 * ecore.cs (Expression.Warning): Made this public as well.
18367 * report.cs (Report.Debug): Print the contents of collections.
18369 2002-08-06 Martin Baulig <martin@gnome.org>
18371 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
18372 used to tell Resolve() which kinds of expressions it may return.
18373 (Expression.Resolve): Added overloaded version of this method which
18374 takes a `ResolveFlags flags' argument. This can be used to tell
18375 Resolve() which kinds of expressions it may return. Reports a
18377 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
18378 ResolveFlags.SimpleName.
18379 (Expression.Error118): Added overloaded version of this method which
18380 takes a `ResolveFlags flags' argument. It uses the flags to determine
18381 which kinds of expressions are allowed.
18383 * expression.cs (Argument.ResolveMethodGroup): New public method.
18384 Resolves an argument, but allows a MethodGroup to be returned.
18385 This is used when invoking a delegate.
18387 * TODO: Updated a bit.
18389 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18391 Fixed compilation with csc.
18393 * ecore.cs: Expression.Error made public. Is this correct? Should
18394 Warning be made public too?
18396 * expression.cs: use ea.Location instead of ea.loc.
18397 [FIXME: Filed as bug #28607: MCS must report these errors.]
18399 2002-08-06 Martin Baulig <martin@gnome.org>
18401 * ecore.cs (Expression.loc): Moved the location here instead of
18402 duplicating it in all derived classes.
18403 (Expression.Location): New public property.
18404 (Expression.Error, Expression.Warning): Made them non-static and
18405 removed the location argument.
18406 (Expression.Warning): Added overloaded version which takes an
18407 `int level' argument.
18408 (Expression.Error118): Make this non-static and removed the
18409 expression and location arguments.
18410 (TypeExpr): Added location argument to the constructor.
18412 * expression.cs (StaticCallExpr): Added location argument to
18414 (Indirection, PointerArithmetic): Likewise.
18415 (CheckedExpr, UnCheckedExpr): Likewise.
18416 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
18417 (StringPtr): Likewise.
18420 2002-08-05 Martin Baulig <martin@gnome.org>
18422 * expression.cs (BaseAccess.DoResolve): Actually report errors.
18424 * assign.cs (Assign.DoResolve): Check whether the source
18425 expression is a value or variable.
18427 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
18428 while resolving the corresponding blocks.
18430 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
18431 an error, don't silently return null.
18433 * statement.cs (Block.AddVariable): Do the error reporting here
18434 and distinguish between CS0128 and CS0136.
18435 (Block.DoResolve): Report all unused labels (warning CS0164).
18436 (LabeledStatement): Pass the location to the constructor.
18437 (LabeledStatement.HasBeenReferenced): New property.
18438 (LabeledStatement.Resolve): Set it to true here.
18440 * statement.cs (Return.Emit): Return success even after reporting
18441 a type mismatch error (CS0126 or CS0127), this is what csc does and
18442 it avoids confusing the users with any consecutive errors.
18444 2002-08-05 Martin Baulig <martin@gnome.org>
18446 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
18448 * const.cs (Const.LookupConstantValue): Catch circular definitions.
18450 * expression.cs (MemberAccess.DoResolve): Silently return if an
18451 error has already been reported.
18453 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
18454 error has already been reported.
18456 2002-08-05 Martin Baulig <martin@gnome.org>
18458 * statement.cs (UsageVector): Only initialize the `parameters'
18459 vector if we actually have any "out" parameters.
18461 2002-08-05 Martin Baulig <martin@gnome.org>
18463 * expression.cs (Binary.ResolveOperator): When combining delegates,
18464 they must have the same type.
18466 2002-08-05 Martin Baulig <martin@gnome.org>
18468 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
18469 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
18470 work with the ms runtime and we also don't need it: if we're a
18471 PropertyBuilder and not in the `indexer_arguments' hash, then we
18472 are a property and not an indexer.
18474 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
18475 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
18476 since the latter one doesn't work with the ms runtime.
18478 2002-08-03 Martin Baulig <martin@gnome.org>
18480 Fixed bugs #27998 and #22735.
18482 * class.cs (Method.IsOperator): New public field.
18483 (Method.CheckBase): Report CS0111 if there's already a method
18484 with the same parameters in the current class. Report CS0508 when
18485 attempting to change the return type of an inherited method.
18486 (MethodData.Emit): Report CS0179 if a method doesn't have a body
18487 and it's not marked abstract or extern.
18488 (PropertyBase): New abstract base class for Property and Indexer.
18489 (PropertyBase.CheckBase): Moved here from Property and made it work
18491 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
18492 the same so we can reuse it there.
18493 (Property, Indexer): Derive from PropertyBase.
18494 (MethodSignature.inheritable_property_signature_filter): New delegate
18495 to find properties and indexers.
18497 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
18498 argument and improved error reporting.
18500 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
18501 EmptyReadOnlyParameters and made it a property.
18503 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
18504 version of this method which takes a `PropertyInfo indexer'.
18505 (TypeManager.RegisterIndexer): New method.
18507 * class.cs: Added myself as author of this file :-)
18509 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18511 * class.cs: fixed compilation on windoze.
18513 2002-08-03 Martin Baulig <martin@gnome.org>
18515 * interface.cs (Interface.GetInterfaceBases): Check whether all
18516 base interfaces are at least as accessible than the current one.
18518 * class.cs (TypeContainer.GetClassBases): Check whether base types
18519 are at least as accessible than the current type.
18520 (TypeContainer.AsAccessible): Implemented and made non-static.
18521 (MemberBase.CheckParameters): Report errors if the accessibility
18524 * delegate.cs (Delegate.Delegate): The default visibility is
18525 internal for top-level types and private for nested types.
18526 (Delegate.Define): Report errors if the accessibility checks fail.
18528 * enum.cs (Enum.Enum): The default visibility is internal for
18529 top-level types and private for nested types.
18530 (Enum.DefineType): Compute the correct visibility.
18532 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
18533 function which takes a `bool is_toplevel' instead of a TypeContainer.
18535 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
18538 2002-08-02 Martin Baulig <martin@gnome.org>
18540 * expression.cs (LocalVariableReferenc): Added constructor which
18541 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
18542 (LocalVariableReference.IsReadOnly): New property.
18543 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
18544 variable is readonly, use our own readonly flag to do this; you can
18545 use the new constructor to get a writable reference to a read-only
18548 * cs-parser.jay (foreach_statement, using_statement): Get a writable
18549 reference to the local variable.
18551 2002-08-01 Miguel de Icaza <miguel@ximian.com>
18553 * rootcontext.cs (ResolveCore): Also include System.Exception
18555 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
18556 we reach an EmptyStatement.
18558 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
18561 * expression.cs (Binary.ResolveOperator): Check error result in
18564 use brtrue/brfalse directly and avoid compares to null.
18566 2002-08-02 Martin Baulig <martin@gnome.org>
18568 * class.cs (TypeContainer.Define): Define all nested interfaces here.
18569 Fixes bug #28407, added test-155.cs.
18571 2002-08-01 Martin Baulig <martin@gnome.org>
18573 * class.cs (Event.EmitDefaultMethod): Make this work with static
18574 events. Fixes #28311, added verify-3.cs.
18576 2002-08-01 Martin Baulig <martin@gnome.org>
18578 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
18579 `is_disposable' fields.
18580 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
18581 `hm.is_disposable' if we're using the collection pattern.
18582 (Foreach.EmitCollectionForeach): Use the correct type for the
18583 enumerator's local variable, only emit the try/finally block if
18584 necessary (fixes #27713).
18586 2002-08-01 Martin Baulig <martin@gnome.org>
18588 * ecore.cs (Expression.report118): Renamed to Error118 and made
18591 * statement.cs (Throw.Resolve): Check whether the expression is of
18592 the correct type (CS0118) and whether the type derives from
18593 System.Exception (CS0155).
18594 (Catch.Resolve): New method. Do the type lookup here and check
18595 whether it derives from System.Exception (CS0155).
18596 (Catch.CatchType, Catch.IsGeneral): New public properties.
18598 * typemanager.cs (TypeManager.exception_type): Added.
18600 2002-07-31 Miguel de Icaza <miguel@ximian.com>
18602 * driver.cs: Updated About function.
18604 2002-07-31 Martin Baulig <martin@gnome.org>
18606 Implemented Control Flow Analysis.
18608 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
18609 (EmitContext.CurrentBranching): Added.
18610 (EmitContext.StartFlowBranching): Added.
18611 (EmitContext.EndFlowBranching): Added.
18612 (EmitContext.KillFlowBranching): Added.
18613 (EmitContext.IsVariableAssigned): Added.
18614 (EmitContext.SetVariableAssigned): Added.
18615 (EmitContext.IsParameterAssigned): Added.
18616 (EmitContext.SetParameterAssigned): Added.
18617 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
18618 Added control flow analysis stuff here.
18620 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
18621 resolve the expression as lvalue.
18622 (LocalVariableReference.DoResolve): Check whether the variable has
18623 already been assigned.
18624 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
18625 the parameter as assigned here.
18626 (ParameterReference.DoResolve): Check whether the parameter has already
18628 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
18629 expression as lvalue.
18631 * statement.cs (FlowBranching): New class for the flow analysis code.
18632 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
18633 (LabeledStatement.IsDefined): New public property.
18634 (LabeledStatement.AddUsageVector): New public method to tell flow
18635 analyis that the label may be reached via a forward jump.
18636 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
18638 (VariableInfo.Number): New public field. This is used by flow analysis
18639 to number all locals of a block.
18640 (Block.CountVariables): New public property. This is the number of
18641 local variables in this block (including the locals from all parent
18643 (Block.EmitMeta): Number all the variables.
18645 * statement.cs: Added flow analysis support to all classes.
18647 2002-07-31 Martin Baulig <martin@gnome.org>
18649 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
18650 To get debugging messages, compile mcs with /define:MCS_DEBUG and
18651 then use this argument.
18653 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
18655 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
18656 use this to specify /define options.
18658 2002-07-29 Martin Baulig <martin@gnome.org>
18660 * statement.cs (Fixed): Moved all code that does variable lookups
18661 and resolvings from Emit to Resolve.
18663 * statement.cs (For): Moved all code that does variable lookups
18664 and resolvings from Emit to Resolve.
18666 * statement.cs (Using): Moved all code that does variable lookups
18667 and resolvings from Emit to Resolve.
18669 2002-07-29 Martin Baulig <martin@gnome.org>
18671 * attribute.cs (Attribute.Resolve): Explicitly catch a
18672 System.NullReferenceException when creating the
18673 CustromAttributeBuilder and report a different warning message.
18675 2002-07-29 Martin Baulig <martin@gnome.org>
18677 * support.cs (ParameterData.ParameterName): Added method to
18678 get the name of a parameter.
18680 * typemanager.cs (TypeManager.IsValueType): New public method.
18682 2002-07-29 Martin Baulig <martin@gnome.org>
18684 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
18685 is a flag which specifies that it's either ref or out.
18686 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
18687 the out parameter to `out Parameter.Modifier mod', also set the
18688 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
18690 * support.cs (InternalParameters.ParameterModifier): Distinguish
18691 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18692 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18694 * expression.cs (Argument.GetParameterModifier): Distinguish
18695 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18696 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18698 2002-07-29 Martin Baulig <martin@gnome.org>
18700 * expression.cs (ParameterReference.ParameterReference): Added
18701 `Location loc' argument to the constructor.
18703 * cs-parser.jay: Pass location to ParameterReference.
18705 2002-07-28 Miguel de Icaza <miguel@ximian.com>
18707 * statement.cs (Try): Initialize the location.
18709 * cs-parser.jay: pass location to Try.
18711 * expression.cs (Unary.Reduce): Change the prototype to return
18712 whether a constant fold could be performed or not. The result is
18713 returned in an out parameters. In the case of Indirection and
18714 AddressOf, we want to perform the full tests.
18716 2002-07-26 Miguel de Icaza <miguel@ximian.com>
18718 * statement.cs (Statement.Emit): Flag dead code.
18720 2002-07-27 Andrew Birkett <andy@nobugs.org>
18722 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
18724 2002-07-27 Martin Baulig <martin@gnome.org>
18726 * class.cs (MethodData.Define): Put back call to
18727 TypeManager.AddMethod(), accidentally commented this out.
18729 * report.cs (Debug): New public method to print debugging information,
18730 this is `[Conditional ("DEBUG")]'.
18732 2002-07-26 Martin Baulig <martin@gnome.org>
18734 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
18735 (switch_statement): Push the current_block to the switch_stack and
18736 pop it again when we're done with the switch.
18737 (switch_section): The new block is a child of the current_block.
18738 Fixes bug #24007, added test-152.cs.
18740 2002-07-27 Martin Baulig <martin@gnome.org>
18742 * expression.cs (Invocation.EmitArguments): When calling a varargs
18743 function with only its fixed arguments, we need to pass an empty
18746 2002-07-27 Martin Baulig <martin@gnome.org>
18748 Mono 0.13 has been released.
18750 2002-07-25 Miguel de Icaza <miguel@ximian.com>
18752 * driver.cs: Rename --resource to --linkres, because that is what
18753 we do currently, we dont support --resource yet.
18755 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
18757 2002-07-25 Martin Baulig <martin@gnome.org>
18759 * class.cs (MethodData): New public class. This is a `method builder'
18760 class for a method or one accessor of a Property/Indexer/Event.
18761 (MethodData.GetMethodFlags): Moved here from MemberBase.
18762 (MethodData.ApplyAttributes): Likewise.
18763 (MethodData.ApplyObsoleteAttribute): Likewise.
18764 (MethodData.ApplyConditionalAttribute): Likewise.
18765 (MethodData.ApplyDllImportAttribute): Likewise.
18766 (MethodData.CheckAbstractAndExternal): Likewise.
18767 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
18768 (MethodData.Emit): Formerly known as Method.Emit().
18769 (MemberBase): Moved everything which was specific to a single
18770 accessor/method to MethodData.
18771 (Method): Create a new MethodData and call Define() and Emit() on it.
18772 (Property, Indexer, Event): Create a new MethodData objects for each
18773 accessor and call Define() and Emit() on them.
18775 2002-07-25 Martin Baulig <martin@gnome.org>
18777 Made MethodCore derive from MemberBase to reuse the code from there.
18778 MemberBase now also checks for attributes.
18780 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
18781 (MemberBase.GetMethodFlags): Moved here from class Method and marked
18783 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
18784 `CallingConventions cc' and `Attributes opt_attrs' arguments.
18785 (MemberBase.ApplyAttributes): New virtual method; applies the
18786 attributes to a method or accessor.
18787 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
18788 (MemberBase.ApplyConditionalAttribute): Likewise.
18789 (MemberBase.ApplyDllImportAttribute): Likewise.
18790 (MemberBase.CheckAbstractAndExternal): Likewise.
18791 (MethodCore.ParameterTypes): This is now a property instead of a
18792 method, it's initialized from DoDefineParameters().
18793 (MethodCore.ParameterInfo): Removed the set accessor.
18794 (MethodCore.DoDefineParameters): New protected virtual method to
18795 initialize ParameterTypes and ParameterInfo.
18796 (Method.GetReturnType): We can now simply return the MemberType.
18797 (Method.GetMethodFlags): Override the MemberBase version and add
18798 the conditional flags.
18799 (Method.CheckBase): Moved some code from Define() here, call
18800 DoDefineParameters() here.
18801 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
18802 here to avoid some larger code duplication.
18803 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
18804 ensure that abstract and external accessors don't declare a body.
18806 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
18807 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
18808 lookup in the attribute's parent classes, so we need to abort as soon
18809 as we found the first match.
18810 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
18811 the attribute has no arguments.
18813 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
18816 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18818 * cs-parser.jay: reverted previous patch.
18820 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18822 * cs-parser.jay: fixed bug #22119.
18824 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18826 * attribute.cs: fixed compilation. The error was:
18827 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
18828 be assigned to before control leaves the current method."
18829 [FIXME: Filed as bug #28186: MCS must report this error.]
18831 2002-07-25 Martin Baulig <martin@gnome.org>
18833 * attribute.cs (Attribute.Conditional_GetConditionName): New static
18834 method to pull the condition name ouf of a Conditional attribute.
18835 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
18836 the obsolete message and error flag out of an Obsolete attribute.
18838 * class.cs (Method.GetMethodFlags): New public method to get the
18839 TypeManager.MethodFlags for this method.
18840 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
18842 (Method.Define): Get and apply the Obsolete and Conditional attributes;
18843 if we're overriding a virtual function, set the new private variable
18844 `parent_method'; call the new TypeManager.AddMethod().
18846 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
18847 the MethodBuilder and the Method in a PtrHashtable.
18848 (TypeManager.builder_to_method): Added for this purpose.
18849 (TypeManager.MethodFlags): Added IsObsoleteError.
18850 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
18851 Obsolete and Conditional arguments in MethodBuilders. If we discover
18852 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
18853 the message from the attribute.
18855 2002-07-24 Martin Baulig <martin@gnome.org>
18857 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
18858 preprocessor directives, ensure that the argument to #define/#undef is
18859 exactly one identifier and that it's actually an identifier.
18861 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
18864 2002-07-24 Martin Baulig <martin@gnome.org>
18866 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
18867 initialize it to TypeManager.object_type in the constructor.
18868 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
18869 of the `hm.get_current' method if we're using the collection pattern.
18870 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
18871 for the explicit conversion to make it work when we're using the collection
18872 pattern and the `Current' property has a different return type than `object'.
18875 2002-07-24 Martin Baulig <martin@gnome.org>
18877 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
18878 does not match, but don't report any errors. This method is called in
18879 order for all methods in a MethodGroupExpr until a matching method is
18880 found, so we don't want to bail out if the first method doesn't match.
18881 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
18882 matches, report the 123. Fixes #28070.
18884 2002-07-24 Martin Baulig <martin@gnome.org>
18886 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
18887 TypeManager.TypeToCoreType() to the top of the method so the
18888 following equality checks will work. Fixes #28107.
18890 2002-07-24 Martin Baulig <martin@gnome.org>
18892 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
18893 operand is of type uint, and the other operand is of type sbyte,
18894 short or int, the operands are converted to type long." -
18895 Actually do what this comment already told us. Fixes bug #28106,
18898 2002-07-24 Martin Baulig <martin@gnome.org>
18900 * class.cs (MethodBase): New abstract class. This is now a base
18901 class for Property, Indexer and Event to avoid some code duplication
18902 in their Define() and DefineMethods() methods.
18903 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
18904 generic methods for Define() and DefineMethods().
18905 (FieldBase): Derive from MemberBase, not MemberCore.
18906 (Property): Derive from MemberBase, not MemberCore.
18907 (Property.DefineMethod): Moved all the code from this method to the
18908 new MethodBase.DefineAccessor(), just call it with appropriate
18910 (Property.Define): Call the new Property.DoDefine(), this does some
18911 sanity checks and we don't need to duplicate the code everywhere.
18912 (Event): Derive from MemberBase, not MemberCore.
18913 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
18914 accessors, this will also make them work with interface events.
18915 (Indexer): Derive from MemberBase, not MemberCore.
18916 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
18917 (Indexer.Define): Use the new MethodBase functions.
18919 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
18920 argument to the constructor.
18921 (Interface.FindMembers): Added support for interface events.
18922 (Interface.PopluateEvent): Implemented.
18924 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
18926 2002-07-22 Miguel de Icaza <miguel@ximian.com>
18928 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
18929 but this is required to check for a method name being the same as
18930 the containing class.
18934 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18936 * interface.cs: initialize variable.
18938 2002-07-23 Martin Baulig <martin@gnome.org>
18940 Implemented the IndexerName attribute in interfaces.
18942 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
18943 name if this is an explicit interface implementation.
18944 (Indexer.InterfaceIndexerName): New public variable. If we're
18945 implementing an interface indexer, this is the IndexerName in that
18946 interface. Otherwise, it's the IndexerName.
18947 (Indexer.DefineMethod): If we're implementing interface indexer,
18948 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
18949 and Pending.ImplementIndexer methods.
18950 (Indexer.Define): Also define the PropertyBuilder if we're
18951 implementing an interface indexer and this is neither an explicit
18952 interface implementation nor do the IndexerName match the one in
18955 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
18956 If a method is defined here, then we always need to create a proxy
18957 for it. This is used when implementing interface indexers.
18958 (Pending.IsInterfaceIndexer): New public method.
18959 (Pending.ImplementIndexer): New public method.
18960 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
18961 This is used when implementing interface indexers to define a proxy
18963 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
18964 define a proxy if necessary.
18966 * interface.cs (Interface.IndexerName): New public variable.
18967 (Interface.PopulateIndexer): Set the IndexerName.
18968 (Interface.DefineIndexers): New private method. Populate all the
18969 indexers and make sure their IndexerNames match.
18971 * typemanager.cs (IndexerPropertyName): Added support for interface
18974 2002-07-22 Martin Baulig <martin@gnome.org>
18976 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
18977 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
18978 ret if HasReturnLabel.
18979 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
18982 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
18983 and set the ec.LoopBeginTryCatchLevel.
18984 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
18985 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
18986 the current ec.TryCatchLevel, the branch goes out of an exception
18987 block. In this case, we need to use Leave and not Br.
18989 2002-07-22 Martin Baulig <martin@gnome.org>
18991 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
18992 block unless the block does not always return or it is contained in
18993 another try { ... } catch { ... } block. Fixes bug #26506.
18994 Added verify-1.cs to the test suite.
18996 2002-07-22 Martin Baulig <martin@gnome.org>
18998 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
18999 then we do not always return. Fixes bug #24985.
19001 2002-07-22 Martin Baulig <martin@gnome.org>
19003 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
19004 lookup on a per-class level; ie. walk up the class hierarchy until we
19005 found at least one applicable method, then choose the best among them.
19006 Fixes bug #24463 and test-29.cs.
19008 2002-07-22 Martin Baulig <martin@gnome.org>
19010 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
19011 return types of the methods. The return type is not part of the
19012 signature and we must not check it to make the `new' modifier work.
19013 Fixes bug #27999, also added test-147.cs.
19014 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
19016 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
19017 on the method's return type.
19019 2002-07-21 Martin Baulig <martin@gnome.org>
19021 * assign.cs: Make this work if the rightmost source is a constant and
19022 we need to do an implicit type conversion. Also adding a few more tests
19023 to test-38.cs which should have caught this.
19025 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
19026 target in the makefile for this. The makefile.gnu is primarily intended
19027 for end-users who don't want to debug the compiler.
19029 2002-07-21 Martin Baulig <martin@gnome.org>
19031 * assign.cs: Improved the Assign class so it can now handle embedded
19032 assignments (X = Y = Z = something). As a side-effect this'll now also
19033 consume less local variables. test-38.cs now passes with MCS, added
19034 a few new test cases to that test.
19036 2002-07-20 Martin Baulig <martin@gnome.org>
19038 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
19039 instructions. Fixes bug #27977, also added test-146.cs.
19041 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19043 * cs-tokenizer.cs: fixed getHex ().
19045 2002-07-19 Martin Baulig <martin@gnome.org>
19047 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
19048 not Type.GetType() to lookup the array type. This is needed when
19049 we're constructing an array of a user-defined type.
19050 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
19051 single-dimensional arrays, but also for single-dimensial arrays of
19054 2002-07-19 Martin Baulig <martin@gnome.org>
19056 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
19057 this function is called, it's not allowed to share LocalBuilders
19058 among ILGenerators.
19060 2002-07-19 Martin Baulig <martin@gnome.org>
19062 * expression.cs (Argument.Resolve): Report an error 118 when trying
19063 to pass a type as argument.
19065 2002-07-18 Martin Baulig <martin@gnome.org>
19067 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
19068 Conv_R_Un for the signed `long' type.
19070 2002-07-15 Miguel de Icaza <miguel@ximian.com>
19072 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
19073 `expr' for the temporary result, as that will fail if we do
19074 multiple resolves on the same expression.
19076 2002-07-05 Miguel de Icaza <miguel@ximian.com>
19078 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
19079 ec.TypeContainer for looking up aliases.
19081 * class.cs (TypeContainer): Remove LookupAlias from here.
19083 * decl.cs (DeclSpace); Move here.
19085 2002-07-01 Miguel de Icaza <miguel@ximian.com>
19087 * class.cs (FindMembers): Only call filter if the constructor
19088 bulider is not null.
19090 Also handle delegates in `NestedTypes' now. Now we will perform
19091 type lookups using the standard resolution process. This also
19094 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
19095 This uses Expressions (the limited kind that can be parsed by the
19096 tree) instead of strings.
19098 * expression.cs (ComposedCast.ToString): Implement, used to flag
19099 errors since now we have to render expressions.
19101 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
19104 * ecore.cs (SimpleName.ToString): ditto.
19106 * cs-parser.jay: Instead of using strings to assemble types, use
19107 Expressions to assemble the type (using SimpleName, ComposedCast,
19108 MemberAccess). This should fix the type lookups in declarations,
19109 because we were using a different code path for this.
19111 * statement.cs (Block.Resolve): Continue processing statements
19112 even when there is an error.
19114 2002-07-17 Miguel de Icaza <miguel@ximian.com>
19116 * class.cs (Event.Define): Also remove the `remove' method from
19117 the list of pending items.
19119 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
19120 generate more compact code.
19122 2002-07-17 Martin Baulig <martin@gnome.org>
19124 * const.cs (Const.LookupConstantValue): Add support for constant
19125 `unchecked' and `checked' expressions.
19126 Also adding test case test-140.cs for this.
19128 2002-07-17 Martin Baulig <martin@gnome.org>
19130 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
19131 check whether mi.ReturnType implements the IEnumerator interface; the
19132 `==' and the IsAssignableFrom() will fail in this situation.
19134 2002-07-16 Ravi Pratap <ravi@ximian.com>
19136 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
19139 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19141 * expression.cs: fixed bug #27811.
19143 2002-07-14 Miguel de Icaza <miguel@ximian.com>
19145 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
19146 Molaro: when we are a ref, the value already contains a pointer
19147 value, do not take the address of it.
19149 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19150 * removed mb-parser.jay and mb-tokenizer.cs
19152 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19154 * expression.cs: check against the building corlib void type.
19156 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
19158 * ecore.cs: fix for valuetype static readonly fields: when
19159 initializing them, we need their address, not the address of a copy.
19161 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
19163 * typemanager.cs: register also enum_type in corlib.
19165 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19167 * class.cs: allow calling this (but not base) initializers in structs.
19169 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
19171 * ecore.cs: make sure we compare against the building base types
19174 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
19176 * typemanager.cs: fix TypeToCoreType() to handle void and object
19177 (corlib gets no more typerefs after this change).
19179 2002-07-12 Miguel de Icaza <miguel@ximian.com>
19181 * expression.cs (ArrayCreation.EmitArrayArguments): use
19182 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
19184 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
19185 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
19186 array indexes, the runtime actually forbids them.
19188 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
19189 for array arguments here.
19191 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
19192 instead of the default for ValueTypes.
19194 (New.DoEmit): Use IsValueType instead of
19195 IsSubclassOf (value_type)
19196 (New.DoResolve): ditto.
19197 (Invocation.EmitCall): ditto.
19199 * assign.cs (Assign): ditto.
19201 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
19202 Statements *are* currently doing part of their resolution during
19205 Expressions do always resolve during resolve, but statements are
19206 only required to propagate resolution to their children.
19208 2002-07-11 Miguel de Icaza <miguel@ximian.com>
19210 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
19212 (LoadAssembly): Do not add the dll if it is already specified
19214 (MainDriver): Add the System directory to the link path at the end,
19215 after all the other -L arguments.
19217 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
19218 wrong opcode for loading bytes and bools (ldelem.i1 instead of
19219 ldelem.u1) and using the opposite for sbytes.
19221 This fixes Digger, and we can finally run it.
19223 * driver.cs (UnixParseOption): Move the option parsing here.
19224 (CSCParseOption): Implement CSC-like parsing of options.
19226 We now support both modes of operation, the old Unix way, and the
19227 new CSC-like way. This should help those who wanted to make cross
19228 platform makefiles.
19230 The only thing broken is that /r:, /reference: and /lib: are not
19231 implemented, because I want to make those have the same semantics
19232 as the CSC compiler has, and kill once and for all the confussion
19233 around this. Will be doing this tomorrow.
19235 * statement.cs (Unsafe.Resolve): The state is checked during
19236 resolve, not emit, so we have to set the flags for IsUnsfe here.
19238 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19240 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
19241 not catch the Error_ObjectRefRequired in SimpleName (as it is
19242 possible to have a class/instance variable name that later gets
19243 deambiguated), we have to check this here.
19245 2002-07-10 Ravi Pratap <ravi@ximian.com>
19247 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
19248 make static and put into Expression.
19250 (Event.Define): Register the private field of the event with the
19251 TypeManager so that GetFieldFromEvent can get at it.
19253 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
19254 keep track of the private field associated with an event which
19257 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
19260 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
19262 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19264 * expression.cs (Binary.EmitBranchable): this routine emits the
19265 Binary expression in a branchable context. This basically means:
19266 we need to branch somewhere, not just get the value on the stack.
19268 This works together with Statement.EmitBoolExpression.
19270 * statement.cs (Statement.EmitBoolExpression): Use
19273 2002-07-09 Miguel de Icaza <miguel@ximian.com>
19275 * statement.cs (For): Reduce the number of jumps in loops.
19277 (For): Implement loop inversion for the For statement.
19279 (Break): We can be breaking out of a Try/Catch controlled section
19280 (foreach might have an implicit try/catch clause), so we need to
19281 use Leave instead of Br.
19283 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
19284 now). If the instace expression supports IMemoryLocation, we use
19285 the AddressOf method from the IMemoryLocation to extract the
19286 address instead of emitting the instance.
19288 This showed up with `This', as we were emitting the instance
19289 always (Emit) instead of the Address of This. Particularly
19290 interesting when This is a value type, as we dont want the Emit
19291 effect (which was to load the object).
19293 2002-07-08 Miguel de Icaza <miguel@ximian.com>
19295 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
19297 * statement.cs (Checked): Set the CheckedState during the resolve
19298 process too, as the ConvCast operations track the checked state on
19299 the resolve process, and not emit.
19301 * cs-parser.jay (namespace_member_declaration): Flag that we have
19302 found a declaration when we do. This is used to flag error 1529
19304 * driver.cs: Report ok when we display the help only.
19306 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
19308 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
19310 2002-07-04 Miguel de Icaza <miguel@ximian.com>
19312 * cs-tokenizer.cs (define): We also have to track locally the
19313 defines. AllDefines is just used for the Conditional Attribute,
19314 but we also need the local defines for the current source code.
19316 2002-07-03 Miguel de Icaza <miguel@ximian.com>
19318 * statement.cs (While, For, Do): These loops can exit through a
19319 Break statement, use this information to tell whether the
19320 statement is the last piece of code.
19322 (Break): Flag that we break.
19324 * codegen.cs (EmitContexts): New `Breaks' state variable.
19326 2002-07-03 Martin Baulig <martin@gnome.org>
19328 * class.cs (TypeContainer.MethodModifiersValid): Allow override
19329 modifiers in method declarations in structs. Otherwise, you won't
19330 be able to override things like Object.Equals().
19332 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19334 * class.cs (Method, Property, Indexer): Do not allow the public
19335 modifier to be used in explicit interface implementations.
19337 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
19338 override modifiers in method declarations in structs
19340 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
19342 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
19343 integer or real overflow, report an error
19345 2002-07-02 Martin Baulig <martin@gnome.org>
19347 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
19348 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
19349 to tell the runtime about our newly created System.Object and
19350 System.ValueType types.
19352 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19354 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
19355 struct instead of Ldarg/Starg.
19357 2002-07-02 Martin Baulig <martin@gnome.org>
19359 * expression.cs (Indirection.Indirection): Call
19360 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
19362 2002-07-02 Martin Baulig <martin@gnome.org>
19364 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
19365 ValueType, call TypeManager.TypeToCoreType() on it.
19366 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
19367 the OpCodes.Newarr argument.
19369 2002-07-02 Martin Baulig <martin@gnome.org>
19371 * expression.cs (Invocation.EmitCall): When compiling corlib,
19372 replace all calls to the system's System.Array type to calls to
19373 the newly created one.
19375 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
19376 System.Array methods.
19377 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
19378 from the system's System.Array type which must be replaced.
19380 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
19382 * typemanager.cs: load unverifiable_code_ctor so we can build
19383 corlib using the correct type. Avoid using GetTypeCode() with
19385 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
19386 TypeManager.object_type to allow building corlib.
19388 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
19390 * ecore.cs: handle System.Enum separately in LoadFromPtr().
19392 2002-07-01 Martin Baulig <martin@gnome.org>
19394 * class.cs: Make the last change actually work, we need to check
19395 whether `ifaces != null' to avoid a crash.
19397 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19399 * class.cs: when we build structs without fields that implement
19400 interfaces, we need to add the interfaces separately, since there is
19401 no API to both set the size and add the interfaces at type creation
19404 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19406 * expression.cs: the dimension arguments to the array constructors
19407 need to be converted if they are a long.
19409 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
19411 * class.cs: don't emit ldarg.0 if there is no parent constructor
19412 (fixes showstopper for corlib).
19414 2002-06-29 Martin Baulig <martin@gnome.org>
19416 MCS now compiles corlib on GNU/Linux :-)
19418 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
19419 ie. check for MethodImplOptions.InternalCall.
19421 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
19422 and TypeManager.attribute_type are null, so we must explicitly check
19423 whether parent is not null to find out whether it's an attribute type.
19424 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
19425 and SetBuilder, not only if the property is neither abstract nor external.
19426 This is necessary to set the MethodImplOptions on the accessor methods.
19427 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
19428 SetBuilder, see Property.Emit().
19430 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
19431 populate "System.Object", "System.ValueType" and "System.Attribute" since
19432 they've already been populated from BootCorlib_PopulateCoreTypes().
19434 2002-06-29 Martin Baulig <martin@gnome.org>
19436 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
19437 is the NullLiteral, we also need to make sure that target_type is not
19440 2002-06-29 Martin Baulig <martin@gnome.org>
19442 * rootcontext.cs (RootContext.ResolveCore): We must initialize
19443 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
19444 before calling BootstrapCorlib_ResolveDelegate ().
19446 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19448 * statement.cs: fixed build-breaker. All tests passed ok.
19450 2002-06-27 Martin Baulig <martin@gnome.org>
19452 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
19453 for System.Decimal when compiling corlib.
19455 2002-06-27 Martin Baulig <martin@gnome.org>
19457 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
19458 switch blocks which contain nothing but a default clause.
19460 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
19462 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
19464 2002-06-27 Martin Baulig <martin@gnome.org>
19466 * ecore.cs (PropertyExpr.PropertyExpr): Call
19467 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
19469 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
19470 is already a TypeBuilder.
19472 2002-06-27 Martin Baulig <martin@gnome.org>
19474 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
19475 `target_type == TypeManager.array_type', not IsAssignableFrom() in
19476 the "from an array-type to System.Array" case. This makes it work
19477 when compiling corlib.
19479 2002-06-27 Martin Baulig <martin@gnome.org>
19481 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
19482 non-static PropertyExpr, set its InstanceExpression. This makes
19483 the `ICollection.Count' property work in System/Array.cs.
19485 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
19487 * driver.cs: Made error handling more consistent. Errors now
19488 tracked by Report class, so many methods which used to return int
19489 now return void. Main() now prints success/failure and
19490 errors/warnings message.
19492 Renamed '--probe' compiler argument to '--expect-error'. Removed
19493 the magic number return values (123 and 124). Now, if the
19494 expected error occurs, the compiler exits with success (exit value
19495 0). If the compilation completes without seeing that particular
19496 error, the compiler exits with failure (exit value 1). The
19497 makefile in mcs/errors has been changed to handle the new behaviour.
19499 * report.cs: Made 'expected error' number a property and renamed
19500 it from 'Probe' to 'ExpectedError'.
19502 * genericparser.cs: Removed error handling support, since it is
19503 now all done by Report class.
19505 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
19506 class, so parse() no longer returns an int.
19508 * namespace.cs: Use Report.Error instead of GenericParser.error
19510 2002-06-22 Miguel de Icaza <miguel@ximian.com>
19512 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
19513 TypeContainer.AddOperator): At the front of the list put the
19514 explicit implementations, so they get resolved/defined first.
19516 2002-06-21 Miguel de Icaza <miguel@ximian.com>
19518 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
19519 interface type is implemented by this TypeContainer. Used during
19520 explicit interface implementation.
19522 (Property.Define, Indexer.Define, Method.Define): Validate that
19523 the given interface in the explicit implementation is one of the
19524 base classes for the containing type.
19526 Also if we are explicitly implementing an interface, but there is
19527 no match in the pending implementation table, report an error.
19529 (Property.Define): Only define the property if we are
19530 not explicitly implementing a property from an interface. Use the
19531 correct name also for those properties (the same CSC uses,
19532 although that is really not needed).
19534 (Property.Emit): Do not emit attributes for explicitly implemented
19535 properties, as there is no TypeBuilder.
19537 (Indexer.Emit): ditto.
19539 Hiding then means that we do not really *implement* a pending
19540 implementation, which makes code fail.
19542 2002-06-22 Martin Baulig <martin@gnome.org>
19544 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
19545 the return value of Object.GetType(). [FIXME: we need to do this whenever
19546 we get a type back from the reflection library].
19548 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
19550 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
19552 2002-06-20 Miguel de Icaza <miguel@ximian.com>
19554 * attribute.cs: Return null if we can not look up the type.
19556 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
19557 the interface types found.
19559 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
19560 interface types found.
19562 * typemanager.cs (GetInterfaces): Make this routine returns alll
19563 the interfaces and work around the lame differences between
19564 System.Type and System.Reflection.Emit.TypeBuilder in the results
19565 result for GetInterfaces.
19567 (ExpandInterfaces): Given an array of interface types, expand and
19568 eliminate repeated ocurrences of an interface. This expands in
19569 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
19572 2002-06-21 Martin Baulig <martin@gnome.org>
19574 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
19577 2002-06-21 Martin Baulig <martin@gnome.org>
19579 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
19580 and called with one of the core types, return the corresponding typebuilder for
19583 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
19586 2002-06-21 Martin Baulig <martin@gnome.org>
19588 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
19589 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
19590 (Expression.ConvertReferenceExplicit): Likewise.
19592 * expression.cs (ElementAccess.DoResolve): Likewise.
19593 (ElementAccess.DoResolveLValue): Likewise.
19595 2002-06-10 Martin Baulig <martin@gnome.org>
19597 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
19598 add the "value" parameter to the parameter list.
19600 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
19603 2002-06-19 Miguel de Icaza <miguel@ximian.com>
19605 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
19606 the argument to an int, uint, long or ulong, per the spec. Also
19607 catch negative constants in array creation.
19609 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
19611 * class.cs: do not allow the same interface to appear twice in
19612 the definition list.
19614 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
19616 * ecore.cs: don't use ldlen with System.Array.
19618 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
19620 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
19622 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
19624 * modifiers.cs: produce correct field attributes for protected
19625 internal. Easy fix so miguel can work on ther harder stuff:-)
19627 2002-06-18 Miguel de Icaza <miguel@ximian.com>
19629 * pending.cs: New file. Move the code from class.cs here.
19630 Support clearning the pending flag for all methods (when not doing
19631 explicit interface implementation).
19633 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
19635 * rootcontext.cs: added a couple more types needed to bootstrap.
19637 2002-06-17 Miguel de Icaza <miguel@ximian.com>
19639 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
19640 constructor in the type, instead of any constructor in the type
19641 hierarchy. Thanks to Paolo for finding this bug (it showed up as
19642 a bug in the Mono runtime when applying the params attribute).
19644 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19645 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
19647 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
19649 * expression.cs (Unary.ResolveOperator): Use TypeManager
19650 to resolve the type.
19652 2002-06-13 Ravi Pratap <ravi@ximian.com>
19654 * cs-parser.jay (enum_member_declaration): Pass in the attributes
19657 * enum.cs (AddEnumMember): Add support to store the attributes associated
19658 with each member too.
19660 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
19661 field builders too - this takes care of the enum member case.
19663 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
19665 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
19666 address-of operator on both value types and pointers.
19668 2002-06-10 Martin Baulig <martin@gnome.org>
19670 * interface.cs (Interface.PopulateIndexer): Add the indexer's
19671 PropertyBuilder to the `property_builders' list.
19673 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
19674 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
19675 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
19676 find any indexers which are inherited from an interface.
19678 2002-06-09 Martin Baulig <martin@gnome.org>
19680 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
19681 the same type as the constant if necessary. There's also a test-130.cs
19684 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
19686 * typemanager.cs (TypeManager.ChangeType): Previously known as
19687 Enum.ChangeEnumType().
19689 2002-06-09 Martin Baulig <martin@gnome.org>
19691 * expression.cs (Cast.TryReduce): Added support for consts.
19693 2002-06-08 Ravi Pratap <ravi@ximian.com>
19695 * class.cs (Accessor): Hold attributes information so we can pass
19698 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
19699 Modify to pass in attributes attached to the methods.
19701 (add_accessor_declaration, remove_accessor_declaration): Ditto.
19703 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
19704 to handle the Accessor kind :-)
19706 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
19708 2002-06-08 Martin Baulig <martin@gnome.org>
19710 * expression.cs (Unary.TryReduceNegative): Added support for
19713 2002-06-08 Martin Baulig <martin@gnome.org>
19715 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
19716 name can't be found in the `defined_names' - the caller will do a
19717 MemberLookup in this case and thus find methods in System.Enum
19718 such as Enum.IsDefined().
19720 2002-06-08 Martin Baulig <martin@gnome.org>
19722 * enum.cs (Enum.ChangeEnumType): This is a custom version of
19723 Convert.ChangeType() which works with TypeBuilder created types.
19724 (Enum.LookupEnumValue, Enum.Define): Use it here.
19726 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
19727 `TypeBuilder.BaseType != null' check.
19728 (TypeContainer.FindMembers): Only lookup parent members if we
19729 actually have a parent.
19730 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
19731 (ConstructorInitializer.Resolve): Likewise.
19733 * interface.cs (Interface.FindMembers): Added
19734 `TypeBuilder.BaseType != null' check.
19736 * rootcontext.cs (RootContext.ResolveCore): Added
19737 "System.Runtime.CompilerServices.IndexerNameAttribute" to
19738 classes_second_stage.
19740 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
19741 debug_type and trace_type when compiling with --nostdlib.
19743 2002-06-07 Martin Baulig <martin@gnome.org>
19745 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
19746 (AddField): Set it to true when adding a non-static field.
19747 (DefineType): Use `have_nonstatic_fields' to find out whether we
19748 have non-static fields, not `Fields != null'.
19750 2002-06-02 Miguel de Icaza <miguel@ximian.com>
19752 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
19753 dereferencing a null on the static-field code path)
19755 2002-05-30 Martin Baulig <martin@gnome.org>
19757 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
19758 to take command line arguments. Use reflection to call the new
19759 custom `Initialize' function on the symbol writer and pass it the
19760 command line arguments.
19762 * driver.cs (--debug-args): New command line argument to pass command
19763 line arguments to the symbol writer.
19765 2002-05-28 Miguel de Icaza <miguel@ximian.com>
19767 * assign.cs (DoResolve): Forgot to do the implicit conversion to
19768 the target type for indexers and properties. Thanks to Joe for
19771 2002-05-27 Miguel de Icaza <miguel@ximian.com>
19773 * typemanager.cs (MethodFlags): returns the method flags
19774 (Obsolete/ShouldIgnore) that control warning emission and whether
19775 the invocation should be made, or ignored.
19777 * expression.cs (Invocation.Emit): Remove previous hack, we should
19778 not do this on matching a base type, we should do this based on an attribute
19780 Only emit calls to System.Diagnostics.Debug and
19781 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
19782 on the command line.
19784 * rootcontext.cs: Global settings for tracing and debugging.
19786 * cs-tokenizer.cs (define): New utility function to track
19787 defines. Set the global settings for TRACE and DEBUG if found.
19789 2002-05-25 Ravi Pratap <ravi@ximian.com>
19791 * interface.cs (Populate*): Pass in the TypeContainer as well as
19792 the DeclSpace as parameters so that we can create EmitContexts and
19793 then use that to apply attributes etc.
19795 (PopulateMethod, PopulateEvent, PopulateProperty)
19796 (PopulateIndexer): Apply attributes everywhere.
19798 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
19801 (ApplyAttributes): Update accordingly.
19803 We now apply interface attributes for all members too.
19805 2002-05-26 Miguel de Icaza <miguel@ximian.com>
19807 * class.cs (Indexer.Define); Correctly check if we are explicit
19808 implementation (instead of checking the Name for a ".", we
19809 directly look up if the InterfaceType was specified).
19811 Delay the creation of the PropertyBuilder.
19813 Only create the PropertyBuilder if we are not an explicit
19814 interface implementation. This means that explicit interface
19815 implementation members do not participate in regular function
19816 lookups, and hence fixes another major ambiguity problem in
19817 overload resolution (that was the visible effect).
19819 (DefineMethod): Return whether we are doing an interface
19822 * typemanager.cs: Temporary hack until we get attributes in
19823 interfaces (Ravi is working on that) and we get IndexerName
19824 support in interfaces.
19826 * interface.cs: Register the indexers as properties.
19828 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
19829 warning, I have verified that this is a bug in the .NET runtime
19830 (JavaScript suffers of the same problem).
19832 * typemanager.cs (MemberLookup): When looking up members for
19833 interfaces, the parent of an interface is the implicit
19834 System.Object (so we succeed in searches of Object methods in an
19835 interface method invocation. Example: IEnumerable x; x.ToString
19838 2002-05-25 Miguel de Icaza <miguel@ximian.com>
19840 * class.cs (Event): Events should also register if they do
19841 implement the methods that an interface requires.
19843 * typemanager.cs (MemberLookup); use the new GetInterfaces
19846 (GetInterfaces): The code used to lookup interfaces for a type is
19847 used in more than one place, factor it here.
19849 * driver.cs: Track the errors at the bottom of the file, we kept
19852 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
19853 instance if the method we are calling is static!
19855 2002-05-24 Miguel de Icaza <miguel@ximian.com>
19857 * attribute.cs (ApplyAttributes): Make this function filter out
19858 the IndexerName attribute (as that attribute in reality is never
19859 applied) and return the string constant for the IndexerName
19862 * class.cs (TypeContainer.Emit): Validate that all the indexers
19863 have the same IndexerName attribute, and if so, set the
19864 DefaultName attribute on the class.
19866 * typemanager.cs: The return value might contain other stuff (not
19867 only methods). For instance, consider a method with an "Item"
19868 property and an Item method.
19870 * class.cs: If there is a problem with the parameter types,
19873 2002-05-24 Ravi Pratap <ravi@ximian.com>
19875 * ecore.cs (ImplicitConversionExists): Wrapper function which also
19876 looks at user defined conversion after making a call to
19877 StandardConversionExists - we need this for overload resolution.
19879 * expression.cs : Update accordingly the various method calls.
19881 This fixes 2 bugs filed against implicit user defined conversions
19883 2002-05-22 Miguel de Icaza <miguel@ximian.com>
19885 * statement.cs: Track the result of the assignment.
19887 2002-05-21 Miguel de Icaza <miguel@ximian.com>
19889 * expression.cs (MemberAccess): Improved error reporting for
19890 inaccessible members.
19892 2002-05-22 Martin Baulig <martin@gnome.org>
19894 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
19895 itself with debugging support.
19897 2002-05-22 Martin Baulig <martin@gnome.org>
19899 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
19900 Removed, this isn't needed anymore.
19902 2002-05-20 Martin Baulig <martin@gnome.org>
19904 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
19905 be underlying type for an enum.
19907 2002-05-20 Miguel de Icaza <miguel@ximian.com>
19909 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
19910 that splits out the loading of just the core types.
19912 * rootcontext.cs (ResolveCore): Split the struct resolution in
19913 two, so we can load the enumeration underlying types before any
19916 * expression.cs (Is): Bandaid until we fix properly Switch (see
19917 bug #24985 for details).
19919 * typemanager.cs (ImplementsInterface): The hashtable will contain
19920 a null if there are no interfaces implemented.
19922 2002-05-18 Miguel de Icaza <miguel@ximian.com>
19924 * cs-parser.jay (indexer_declarator): It is fine to have array
19927 2002-05-17 Miguel de Icaza <miguel@ximian.com>
19929 * typemanager.cs: (RegisterBuilder): New function used to register
19930 TypeBuilders that implement interfaces. Since
19931 TypeBuilder.GetInterfaces (as usual) does not work with lame
19933 (AddUserType): register interfaces.
19935 (ImplementsInterface): Use the builder_to_ifaces hash if we are
19936 dealing with TypeBuilder. Also, arrays are showing up as
19937 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
19938 methods can not be invoked on them!
19940 * ecore.cs (ExplicitReferenceConversionExists): Made public.
19941 (ImplicitReferenceConversionExists): Split out from
19942 StandardConversionExists.
19944 * expression.cs (As): We were only implementing one of the three
19945 cases for the as operator. We now implement them all.
19946 (Is): Implement the various other cases for Is as well.
19948 * typemanager.cs (CACHE): New define used to control if we want or
19949 not the FindMembers cache. Seems to have a negative impact on
19950 performance currently
19952 (MemberLookup): Nested types have full acess to
19953 enclosing type members
19955 Remove code that coped with instance/static returns for events, we
19956 now catch this in RealFindMembers.
19958 (RealFindMembers): only perform static lookup if the instance
19959 lookup did not return a type or an event.
19961 2002-05-17 Miguel de Icaza <miguel@ximian.com>
19963 * assign.cs (CompoundAssign): We pass more semantic information
19964 now to Compound Assignments than we did before: now we have all
19965 the information at hand, and now we resolve the target *before* we
19966 do the expression expansion, which allows the "CacheValue" method
19967 to have the effect we intended (before, a [x] += 1 would generate
19968 two differen ArrayAccess expressions from the ElementAccess,
19969 during the resolution process).
19971 (CompoundAssign.DoResolve): Resolve target and original_source here.
19973 2002-05-16 Miguel de Icaza <miguel@ximian.com>
19975 * expression.cs (ArrayAccess): dropped debugging information.
19977 * typemanager.cs: Small bug fix: I was always returning i_members,
19978 instead of one of i_members or s_members (depending on which had
19981 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
19982 method is invoked before any code generation takes place, and it
19983 is a mechanism to inform that the expression will be invoked more
19984 than once, and that the method should use temporary values to
19985 avoid having side effects
19987 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
19989 * ecore.cs (Expression.CacheTemporaries): Provide empty default
19992 * expression.cs (Indirection, ArrayAccess): Add support for
19993 CacheTemporaries in these two bad boys.
19995 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
19996 ldobj or ldind_ref.
19997 (StoreFromPtr): Handle stobj as well.
19999 * expression.cs (UnaryMutator): Share more code.
20001 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
20002 down: I was not tracking the Filter function as well, which
20003 was affecting the results of the cache.
20005 2002-05-15 Miguel de Icaza <miguel@ximian.com>
20007 * attribute.cs: Remove the hack to handle the CharSet property on
20010 2002-05-14 Miguel de Icaza <miguel@ximian.com>
20012 * attribute.cs (DoResolve): More uglyness, we now only try to
20013 resolve the attribute partially, to extract the CharSet
20014 information (only if we are a StructLayout attribute). Otherwise
20016 (GetExtraTypeInfo): Add some code to conditionally kill in the
20017 future this. I am more and more convinced that the .NET
20018 framework has special code to handle the attribute setting on
20021 * expression.cs (IsParamsMethodApplicable): Revert my previous
20022 foreach change here, it was wrong.
20024 2002-05-13 Miguel de Icaza <miguel@ximian.com>
20026 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
20027 (pp_expr): do not abort on unknown input, just return.
20028 (eval): abort if there are pending chars.
20030 * attribute.cs (Attribute.Resolve): Positional parameters are
20031 optional. Deal with that case.
20033 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
20034 the Ansi/Unicode/Auto information for the type.
20036 (TypeContainer.DefineType): instantiate the EmitContext here, as
20037 we will be using it during the type definition (to resolve
20038 attributes) and during the emit phase.
20040 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
20041 to pull type information out of the attributes
20043 (Attribute.Resolve): track the constructor builder, and allow for
20044 multiple invocations (structs and classes will use this).
20046 * ecore.cs (MemberLookupFinal): new version with all the
20047 parameters customizable.
20049 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
20050 constructors. Return if the result value is null (as the error
20051 would have been flagged already by MemberLookupFinal)
20053 Do not allow instances of abstract classes or interfaces to be
20056 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
20057 We have to compare the assembly property here when dealing with
20058 FamANDAssem and Assembly access modifiers, because we might be
20059 creating an assembly from *modules* (that means that we are not
20060 getting TypeBuilders for types defined in other modules that are
20061 part of this assembly).
20063 (Method.Emit): If the method is marked abstract and has a body,
20066 (TypeContainer.DefineMembers): If both the defined member and the
20067 parent name match are methods, then do not emit any warnings: let
20068 the Method.Define routine take care of flagging warnings. But if
20069 there is a mismatch (method overrides something else, or method is
20070 overriwritten by something, then emit warning).
20072 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
20073 set to null, this means `do not check for the return type on the
20076 (Method.Define): set the return type for the method signature to
20077 null, so that we get methods with the same name and parameters and
20078 different return types. This is used to flag warning 114 (you are
20079 hiding a method, and you probably want to use the new/override
20082 * typemanager.cs (MemberLookup): Implemented proper access
20083 control, closing a long standing set of bug reports. The problem
20084 was that the Framework only has two bits: Public and NonPublic,
20085 and NonPublic includes private and protected methods, but we need
20086 to enforce the FamANDAssem, FamOrAssem and Family.
20088 2002-05-11 Miguel de Icaza <miguel@ximian.com>
20090 * statement.cs (GotoCase): Return true: Ammounts to giving up
20091 knowledge on whether we return or not, and letting the other case
20092 be responsible for it.
20094 2002-05-10 Miguel de Icaza <miguel@ximian.com>
20096 * driver.cs: Do not load directories for each file processed, only
20097 do it if there is a pattern.
20099 * ecore.cs: Report readonly assigns here as well, as we might have
20100 been resolved only by MemberAccess.
20102 (SimpleName.SimpleNameResolve): Also be useful for LValue
20103 resolution. We need this to propagate assign to local readonly variables
20105 * typemanager.cs: Use a ptrhashtable for the criteria, because we
20106 do not want to reuse potential criteria memory.
20108 * class.cs (MyEventBuilder): Set reflected_type;
20110 * ecore.cs (Constantify): Added support for constifying bools.
20112 (RootContext.LookupType): Added a cache for values looked up in
20113 the declaration space.
20115 * typemanager.cs (FindMembers): Now is a front-end to
20116 RealFindMembers, and provides a two-level hashtable-based cache to
20119 15% performance improvement: from 22.5 to 19.2 seconds.
20121 * expression.cs (IsParamsMethodApplicable): use foreach.
20122 (Invocation.DoResolve): ditto.
20123 (New.DoResolve): ditto.
20124 (ArrayCreation.DoResolve): ditto.
20126 * ecore.cs (FindMostEncompassingType): use foreach.
20128 * delegate.cs (NewDelegate.DoResolve): Use foreach
20130 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
20131 (RemoveMethods): use foreach.
20133 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
20134 nested foreach statements instead of for, and also break out of
20135 the inner loop once a match is found.
20137 (Invocation.OverloadResolve): Use foreach, simplify the code.
20139 2002-05-08 Miguel de Icaza <miguel@ximian.com>
20141 * cfold.cs (BinaryFold): During an enumeration evaluation context,
20142 we actually unwrap the expression to allow for extra information
20145 * expression.cs: Use Shr_Un on unsigned operations.
20147 2002-05-08 Ravi Pratap <ravi@ximian.com>
20149 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
20150 applicable operators was not being considered correctly. This closes
20151 the bug Miguel reported.
20153 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
20155 * attribute.cs: check that the type derives from System.Attribute
20156 and report the correct error in that case (moved the duplicate code to
20157 its own method, too).
20159 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
20161 * attribute.cs: lookup attribute type name as the spec says: first the
20162 bare attribute name and then name + "Attribute" (nant compiles with
20163 mcs after this fix).
20165 2002-05-07 Miguel de Icaza <miguel@ximian.com>
20167 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
20168 Because of the way we parse things, we should try to see if a
20169 UIntConstant can fit in an integer.
20171 2002-05-07 Ravi Pratap <ravi@ximian.com>
20173 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
20174 when we are in an explicit context.
20176 (ConvertReferenceExplicit): When converting from Iface type S to Class
20177 T make sure the rules are implemented as an OR.
20179 * parameter.cs (ParameterType): Make it a property for now although the
20180 purpose really isn't anything immediate.
20182 * expression.cs (Is*Applicable): Do better checking on the parameter type
20183 of a ref/out parameter. The ones from the system assemblies are already
20184 marked with the correct type so we don't need to do any correction.
20186 * ecore.cs (StandardConversionExists): Conversion from Interface types to
20187 the object type is standard too so include that.
20189 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20191 * ecore.cs (StandardConversionExists): Augment with missing code:
20192 deal with IntConstant, LongConstants and Enumerations.
20194 * assign.cs: Report the error, instead of failing silently
20196 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
20197 typecontainer that they are declared, because the
20198 typecontainer/namespace will have the list of using clauses that
20199 need to be applied.
20201 Assembly Attributes were escaping the normal registration
20204 (EmitCode): Apply attributes within an EmitContext that represents
20205 the container they were declared on.
20207 * cs-parser.jay: Track bases for structs. How did I get this wrong?
20209 2002-05-06 Ravi Pratap <ravi@ximian.com>
20211 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
20212 Revamp completely - make much cleaner as we now operate only
20215 (FindMostSpecificSource, FindMostSpecificTarget): New methods
20216 to implement the logic detailed in the spec more correctly.
20218 (UserDefinedConversion): Update accordingly.
20220 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20222 * statement.cs: Return flow analysis information up.
20224 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
20227 (token): Do not consume an extra character before calling
20230 2002-05-06 Piers Haken <piersh@friskit.com>
20232 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
20234 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20236 * class.cs (Constructor.Emit): Set the IsStatic flag in the
20237 EmitContext during the instance constructor initializer
20238 resolution, to stop access to instance variables.
20240 This is mandated by the spec, last paragraph of the `constructor
20241 initializers' section.
20243 2002-05-05 Miguel de Icaza <miguel@ximian.com>
20245 * cs-parser.jay, class.cs (Accessor): new class used to represent
20246 an accessor (get or set). In the past we used `null' to represent
20247 a missing accessor. But this is ambiguous because there was no
20248 way to tell in abstract indexers/properties if one of them was
20251 Now there is a way of addressing that.
20253 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
20254 instead of FindMembers.
20256 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
20257 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
20259 * attribute.cs: Treat indexers and properties as the same in terms
20260 of applying attributes
20262 * ecore.cs (FindMostEncompassedType): Use statically initialized
20263 EmptyExpressions()s like we do elsewhere to avoid creating useless
20264 objects (and we take this out of the tight loop).
20266 (GetConversionOperators): Move the code to extract the actual
20267 operators to a separate routine to clean things up.
20269 2002-05-04 Miguel de Icaza <miguel@ximian.com>
20271 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
20272 events are always registered FieldBuilders.
20274 * class.cs (FieldBase): New class shared by Fields
20276 * delegate.cs: If we are a toplevel delegate, use our full name.
20277 If we are a nested delegate, then only use our tail name.
20279 2002-05-02 Ravi Pratap <ravi@ximian.com>
20281 * expression.cs (IsApplicable): Ensure that we add the "&" to
20282 ref/out types before comparing it with the type of the argument.
20284 (IsParamsMethodApplicable): Ditto.
20286 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
20289 * delegate.cs : Handle the case when we have more than one applicable
20290 method. Flag an error only when we finish checking all.
20292 2002-05-02 Miguel de Icaza <miguel@ximian.com>
20294 * expression.cs: Add support for boolean static initializers.
20296 2002-05-01 Miguel de Icaza <miguel@ximian.com>
20298 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
20300 * parameter.cs (ComputeParameterTypes,
20301 ComputeAndDefineParameterTypes): Better error handling: now we
20302 clear the `types' cache if we fail during any of the type lookups.
20303 We also return the status code correctly to our caller
20305 * delegate.cs: If we fail to define a delegate, abort the extra
20308 * expression.cs (Binary.ResolveOperator): for
20309 operator==(object,object) and operator !=(object, object) we also
20310 have to verify that there is an implicit conversion from one to
20313 (ArrayAccess.DoResolve): Array Access can operate on
20316 2002-04-30 Miguel de Icaza <miguel@ximian.com>
20318 * assign.cs (CompoundAssign): A new class used as a "flag" that
20319 the assignment actually is happening as part of a compound
20320 assignment operator.
20322 During compound assignment, a few new rules exist to enable things
20329 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
20330 to the type of x) if y is implicitly convertible to the type of x,
20331 and the operator is a builtin operator and the return type of the
20332 operator is explicitly convertible to the type of x.
20334 * rootcontext.cs: Reset warning level to 2. 4 catches various
20335 "interesting" features in mcs, we must clean this up at some
20336 point, but currently am trying to kill other bugs ;-)
20338 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
20339 in container classes as well.
20341 * expression.cs (Binary.ResolveOperator): Handle string case
20342 before anything else (as operator overloading does emit an error
20343 before doing anything else).
20345 This code could go away when we move to a table driven model, but
20346 i could not come up with a good plan last night.
20348 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
20350 * typemanager.cs (CSharpName): reimplementation using regex.
20351 * class.cs: added null check for fields in Emit
20352 * rootcontext.cs: set warninglevel to 4
20354 2002-04-29 Miguel de Icaza <miguel@ximian.com>
20356 * typemanager.cs (CSharpName): reimplemented with Lupus
20359 2002-04-28 Miguel de Icaza <miguel@ximian.com>
20361 * statement.cs (If): correclty implement Resolve, because we were
20362 not catching sem errors in there. The same process is needed
20364 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
20367 (Statement.Warning_DeadCodeFound): Factorize code.
20368 (While): Report dead code here too.
20370 (Statement): Added Resolve virtual method to allow
20371 for resolution split from the emit code.
20373 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20375 * statement.cs (EmitBoolExpression): No longer try to resolve the
20377 (MakeBoolean): New utility function that resolve, implicitly
20378 converts to boolean and tags the expression.
20381 (If, Do): Implement dead code elimination.
20382 (While): Implement loop inversion
20384 (Do, While, For, If): Resolve the expression prior to calling our
20387 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
20390 - added method Report28 (warning: program has more than one entry point)
20391 - added method IsEntryPoint, implements paragraph 10.1 of the spec
20392 - modified method Method.Define, the part at the end of the method
20394 * rootcontext.cs: added static public Location EntryPointLocation;
20396 * ../errors/cs0028.cs : Add test case for the above warning.
20399 - modified method CSharpName to allow arrays of primitive type to
20400 be printed nicely (e.g. instead of System.Int32[][] it now prints
20402 - added method CSharpSignature: returns the signature of a method
20403 in string format to be used in reporting errors, warnings, etc.
20405 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
20408 2002-04-26 Ravi Pratap <ravi@ximian.com>
20410 * delegate.cs (Define): Fix extremely silly bug where I was
20411 setting the type of the 'object' parameter of the BeginInvoke
20412 method to System.IAsyncResult instead of System.Object ;-)
20414 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20416 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
20419 (Constructor.Emit): return if we fail to initialize the
20420 constructor. Another door closed!
20422 * expression.cs (New.DoResolve): Improve error message (from -6 to
20423 1501). Use DeclaredOnly lookup to find the exact constructor.
20425 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
20426 loop. This is useful.
20428 * cs-parser.jay: Adjust the default parameters so that destructors
20429 have the proper signature.
20431 2002-04-26 Martin Baulig <martin@gnome.org>
20433 * driver.cs (LoadAssembly): If `assembly' contains any characters
20434 which are only valid in path names and not in assembly names
20435 (currently slash, backslash and point), use Assembly.LoadFrom ()
20436 instead of Assembly.Load () on the `assembly' (before iteration
20437 over the link_paths).
20439 2002-04-26 Martin Baulig <martin@gnome.org>
20441 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
20443 2002-04-25 Miguel de Icaza <miguel@ximian.com>
20445 * class.cs (Property): use the new typemanager.MemberLookup
20447 (TypeContainer.MemberLookup): Implement using the
20448 TypeManager.MemberLookup now.
20450 * typemanager.cs: Make MemberLookup a function of the TypeManager,
20451 and return MemberInfos, so that these can be used without an
20452 EmitContext (what we had before).
20454 2002-04-24 Miguel de Icaza <miguel@ximian.com>
20456 * expression.cs: Fix the case where the argument to params if the
20457 type of the params. I omitted handling this before. Fixed
20459 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20461 * driver.cs: Call BootCorlib_PopulateCoreType
20463 * class.cs (Property.CheckBase): Check for properties only, not
20466 * interface.cs: Temporary hack: try/catch around the
20467 CustomAttributeBuilder, because I am getting an exception that I
20470 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
20471 types whose definitions are required to be there (attributes are
20472 defined before standard types).
20474 Compute definitions as we boot the various types, as they are used
20475 immediately (value_type class will need object_type, but if we do
20476 not initialize object_type, we will pass a null, which will let
20477 the runtime pick the System.Object from the existing corlib, which
20478 is not what we want).
20480 2002-04-22 Patrik Torstensson <totte@labs2.com>
20482 * cs-tokenizer.cs: fixed a number of trim() issues.
20484 2002-04-22 Ravi Pratap <ravi@ximian.com>
20486 * expression.cs (Argument.Type): Ensure that we return the correct
20487 type when we have out or ref parameters [in which case we
20490 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20492 * class.cs (Property, Indexer): Allow extern modifier in there.
20494 * typemanager.cs (InitBaseTypes): Initializes object_type and
20495 value_type, since those will be used early on during the bootstrap
20496 process to compile corlib.
20498 (InitCoreTypes): Move code from here to InitBaseTypes.
20500 2002-04-21 Miguel de Icaza <miguel@ximian.com>
20502 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
20503 single-dimension arrays as using the ldlen opcode.
20505 Daniel Lewis discovered this optimization.
20507 * typemanager.cs: Add signature for System.Array::get_Length
20509 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20511 * statement.cs: report the error when the foreach does not apply to an
20512 array nor a collection.
20514 2002-04-19 Miguel de Icaza <miguel@ximian.com>
20516 * expression.cs: Add implicit conversions to the operator ~.
20518 * constant.cs (DecimalConstant.Emit): Emit decimal value.
20520 * typemanager.cs: Locate the decimal constructor.
20522 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20524 * attribute.cs: use the new property of TypeOf.
20525 * expression.cs: added 'get' property around typearg.
20527 These changes fix a build breaker reported by NickD. Is this the
20528 correct way to fix? If not, please, revert my changes and make it
20531 2002-04-17 Miguel de Icaza <miguel@ximian.com>
20533 * attribute.cs: Add support for typeof in attribute invocations.
20534 I am not sure that this is right though.
20536 2002-04-14 Duncan Mak <duncan@ximian.com>
20538 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
20539 Binary.Operator.Division case.
20541 2002-04-13 Ravi Pratap <ravi@ximian.com>
20543 * class.cs (DefineType): Ensure that we do a proper check on
20544 attribute types and also register it with the TypeManager.
20546 (TypeContainer.Targets): The default for attribute types is
20547 AttributeTargets.All.
20549 * attribute.cs (ApplyAttributes): Registering the attribute type
20550 is done elsewhere, not when we discover we have a Usage attribute.
20552 2002-04-12 Ravi Pratap <ravi@ximian.com>
20554 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
20555 and get rid of is_delegate parameter.
20557 * everywhere : update.
20559 2002-04-12 Ravi Pratap <ravi@ximian.com>
20561 * cs-parser.jay (compilation_unit): Revamp completely to use
20562 some new ideas that I got from Rhys' grammar to solve the problems
20563 with assembly level attributes.
20565 (outer_declaration): New grammar production.
20567 (attribute_sections): Add.
20569 (opt_attributes): Base on attribute_sections
20571 (namespace_declaration): Allow opt_attributes to tackle the case
20572 when we have assembly level attributes - we are clever in this
20575 * attribute.cs (ApplyAttributes): Do not worry about assembly
20576 attributes in the non-global context.
20578 * rootcontext.cs (AddGlobalAttributes): Go back to using this
20579 instead of SetGlobalAttributes.
20581 * class.cs, rootcontext.cs : Ensure we define and generate
20582 attribute types before anything else.
20584 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
20585 and flag the new error -20 for the case when the attribute type
20586 does not have valid targets specified. csc does not catch this.
20588 * ../errors/errors.txt : update for error # -20
20590 2002-04-11 Ravi Pratap <ravi@ximian.com>
20592 * support.cs (InternalParameters.ParameterModifier): Do some null
20593 checking and return sane values.
20595 * class.cs (Method.Define): If we are a PInvoke method, ensure
20596 that we are static and extern. Report error # 601
20598 * ../errors/cs0601.cs : Add test case for the above error.
20600 2002-04-07 Ravi Pratap <ravi@ximian.com>
20602 * rootcontext.cs (attribute_types): We need to keep type of
20603 all attribute types separately and emit code for them first.
20605 (RegisterAttribute) : Implement.
20607 * class.cs (DefineType): Check if the current Type is a custom
20608 attribute type and register it accordingly.
20610 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
20611 adding the first attribute twice and rename to
20613 (SetGlobalAttributes): this.
20615 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
20618 * attribute.cs (ApplyAttributes): Take an additional argument telling us
20619 if we are processing global arguments. Hmm, I am unsure of this.
20621 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20623 * expression.cs: added static array of strings to avoid calling
20624 Enum.ToString () for Operator in Binary. Significant recover of
20627 2002-04-10 Miguel de Icaza <miguel@ximian.com>
20629 * class.cs (FindMembers): Allow the Builders of the various
20630 members to be null. If they are skip them. This only happens
20631 during the PInvoke declaration.
20633 2002-04-09 Miguel de Icaza <miguel@ximian.com>
20635 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
20636 failure, so we do not keep going afterwards.
20638 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
20639 wanted to pass `false' as the `is_delegate' argument. If this is
20640 the case, why not use delegate_type == null to mean `is_delegate =
20641 false' and anything else as is_delegate = true.
20643 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
20645 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
20646 code for the section, not the beginning of the tests.
20648 2002-04-08 Miguel de Icaza <miguel@ximian.com>
20650 * cfold.cs: Handle operator + (Enum x, Underlying x)
20652 * expression.cs (Binary): same. Warn about errors where we have
20653 Enum/Enum in operator + as well.
20655 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
20658 - added support for switch(bool)
20659 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
20660 - add TableSwitchEmit() to handle table-based switch statements
20662 2002-04-05 Ravi Pratap <ravi@ximian.com>
20664 * expression.cs (Invocation.OverloadResolve): Factor out code which
20665 does parameter compatibility checking with arguments so that we can
20666 re-use the code even from Delegate.VerifyApplicability
20668 (VerifyArgumentsCompat): Move above code here.
20670 * delegate.cs (VerifyApplicability): Get rid of duplicate code
20671 and instead make a call to the above method.
20673 2002-03-31 Ravi Pratap <ravi@ximian.com>
20675 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
20676 We use it to keep track of classes which are attribute types.
20678 2002-04-02 Miguel de Icaza <miguel@ximian.com>
20680 * delegate.cs (Delegate.Define): Correctly define the types in the
20681 presence of fixed and array parameters.
20683 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
20686 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
20687 include NonPublic after the first iteration.
20689 * class.cs (Indexer.CheckBase): Only check if both parents are
20692 * cs-parser.jay (accessor_body): If empty, set to null.
20694 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
20695 same code path here to resolve constants names that we did have in
20696 MemberAccess.DoResolve. There is too much code duplicated here.
20698 2002-04-01 Miguel de Icaza <miguel@ximian.com>
20700 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
20702 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
20705 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
20706 tokens, numbers and strings.
20708 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
20711 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
20712 asyncronous parameters and the regular parameters.
20714 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
20715 specify the target directory.
20717 * expression.cs: (This.DoResolve): Simplify
20718 (As.Emit): Optimize, do not generate IsInst if the expression is
20719 always of the given type.
20721 (Is.DoResolve): Bug fix, we were reporting both always/never for
20724 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
20725 creating too many unnecessary arrays.
20727 2002-03-31 Miguel de Icaza <miguel@ximian.com>
20729 * class.cs (EmitFieldInitializer): Use Assign expression to assign
20730 fields instead of rolling our own initializer. Takes care of all
20731 implicit conversions, and drops unnecessary static checks/argument.
20733 2002-03-31 Dick Porter <dick@ximian.com>
20735 * driver.cs: use the GetDirectories() return values properly, and
20736 use "/" as path separator.
20738 2002-03-30 Miguel de Icaza <miguel@ximian.com>
20740 * expression.cs (Unary): Optimize - - expr into expr.
20741 (Binary): Optimize a + (-b) into a -b.
20743 * codegen.cs (CodeGen): Made all methods static.
20745 2002-03-29 Miguel de Icaza <miguel@ximian.com>
20749 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
20750 TypeBuilder property.
20752 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
20755 * tree.cs: Removed the various RecordXXXX, and replaced with a
20756 single RecordDecl. Removed all the accessor methods, and just
20757 left a single access point Type
20759 * enum.cs: Rename DefineEnum to DefineType.
20761 * decl.cs: New abstract method `DefineType' used to unify the
20762 Defines for Enumerations, Interfaces, TypeContainers and
20765 (FindType): Moved LookupInterfaceOrClass here. Moved the
20766 LookupBaseClasses method that used to live in class.cs and
20767 interface.cs here, and renamed to FindType.
20769 * delegate.cs: Implement DefineType. Take advantage of the
20770 refactored pattern for locating the parent builder without taking
20771 the parent_builder argument (which we know does not work if we are
20772 nested, and triggering a toplevel definition).
20774 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20776 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
20777 accessibility of a member has changed during override and report
20780 * class.cs (Method.Define, Property.Define): Only complain on
20781 overrides if the method is private, any other accessibility is
20782 fine (and since we just checked the permission is the same, we are
20785 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
20786 and elif are processed always. The other pre-processing
20787 directives are only processed if we are "taking" the path
20789 2002-03-29 Martin Baulig <martin@gnome.org>
20791 * class.cs (Method.Emit): Only emit symbolic debugging info if the
20792 current location is not Null.
20794 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
20795 a separate method so we can profile it.
20797 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
20798 `span.Seconds' are just seconds, but no minutes or hours.
20799 (MainDriver): Profile the CodeGen.SaveSymbols calls.
20801 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20803 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
20804 Remove the gratuitous set of Final:
20806 // If an interface implementation, then we can set Final.
20807 if (((flags & MethodAttributes.Abstract) == 0) &&
20808 implementing.DeclaringType.IsInterface)
20809 flags |= MethodAttributes.Final;
20811 I do not know what I was smoking when I used that.
20814 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
20815 step into fixing the name resolution issues for delegates and
20816 unifying the toplevel name resolution.
20818 2002-03-28 Martin Baulig <martin@gnome.org>
20820 * class.cs (Method.Emit): If we have a symbol writer, call its
20821 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
20822 tell it about the current method.
20824 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
20825 writer that we're going to emit the first byte of IL code for a new
20826 statement (a new source line).
20827 (EmitContext.EmitTopBlock): If we have a symbol writer, call
20828 EmitContext.Mark() before emitting any code.
20830 * location.cs (SymbolDocument): Return null when we're Null.
20832 * statement.cs (Statement): Moved the `Location loc' variable here.
20833 (Statement.EmitBoolExpression): If we have a symbol writer, call
20834 ec.Mark() before emitting any code to tell it that we're at the
20835 beginning of a new statement.
20836 (StatementExpression): Added `Location' argument to the constructor.
20837 (Block): Added public readonly variable `StartLocation' and public
20838 variable `EndLocation'. The latter is to be set using SetEndLocation().
20839 (Block): Added constructor which takes a start and end location.
20840 (Block.SetEndLocation): New method. This sets the end location.
20841 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
20842 local variables we create.
20843 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
20844 each statement and do also mark the begin and end of the block.
20846 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
20847 tell it the current lexer.Location, use Location.Null for the end of the
20849 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
20850 current block, set its end location using SetEndLocation().
20851 (statement_expression): StatementExpression constructor now takes the
20852 lexer.Location as additional argument.
20853 (for_statement, declare_local_variables): Likewise.
20854 (declare_local_variables): When creating a new implicit block, use the
20855 new Block constructor and pass it the lexer.Location.
20857 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20859 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
20860 members also on the parent interfaces recursively.
20862 2002-03-27 Miguel de Icaza <miguel@ximian.com>
20864 * report.cs: Use new formats, since Gonzalo finished the missing
20867 * expression.cs (Binary.ResolveOperator): added missing operator|
20868 operator& and operator^ for bool/bool.
20870 * cs-parser.jay: CheckDef now takes a Location argument that is
20871 used to report errors more precisly (instead of reporting the end
20872 of a definition, we try to track something which is a lot closer
20873 to the source of the problem).
20875 * cs-tokenizer.cs: Track global token use, so we can properly flag
20876 the use of #define/#undef after the first token has been seen.
20878 Also, rename the reportXXXX to Error_DescriptiveName
20880 * decl.cs (DeclSpace.IsTopLevel): Move property here from
20881 TypeContainer, so that Enum and Interface can use this too.
20883 * class.cs (TypeContainer.LookupInterfaceOrClass,
20884 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
20885 `builder' argument. Typically this was used to pass the parent
20886 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
20889 The problem is that a nested class could trigger the definition of
20890 a toplevel class, and the builder would be obviously wrong in that
20893 So we drop this argument, and we compute dynamically the
20894 TypeBuilder/ModuleBuilder (the correct information was available
20895 to us anyways from DeclSpace.Parent)
20897 * interface.cs (Interface.DefineInterface): Drop builder
20898 parameter cleanup like class.cs
20900 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
20903 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
20906 (Try.Emit): Propagate the returns value from the statement.
20908 (Return.Emit): Even if we are leavning
20910 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
20912 * modifiers.cs: Fix the computation of MethodAttributes flags.
20914 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
20916 * driver.cs: allow compilation of files that start with '/'.
20917 Add a default case when checking the argument of --target.
20919 2002-03-25 Miguel de Icaza <miguel@ximian.com>
20921 * interface.cs: Implement the same search algorithm for types in
20922 the interface code.
20924 * delegate.cs: Do not allow multiple definition.
20926 * Recovered ChangeLog that got accidentally amputated
20928 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
20930 * rootcontext.cs: Load manually enum to allow core classes to
20931 contain enumerations.
20933 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
20934 Update to new static methods in TypeManager.
20936 * typemanager.cs (GetMethod, GetConstructor): Use our
20937 implementation of FindMembers to find the members, since during
20938 corlib compilation, the types are TypeBuilders and GetMethod and
20939 GetConstructor do not work.
20941 Make all methods in TypeManager static.
20943 (InitCodeHelpers): Split the functionality from
20944 the InitCodeTypes function.
20946 * driver.cs: Call InitCodeHelpers after we have populated the
20949 * cs-parser.jay (delegate_declaration): we did not used to compute
20950 the delegate name correctly for void delegates.
20952 2002-03-24 Miguel de Icaza <miguel@ximian.com>
20954 * rootcontext.cs (RootContext): Init the interface_resolve_order
20955 and type_container_resolve_order always.
20957 (ResolveCore, BootstrapCorlib_ResolveClass,
20958 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
20959 compiler when compiling with --nostdlib
20961 * class.cs (TypeContainer.DefineType): Check that our parent is
20962 not null. This test is most important when we are bootstraping
20965 * codegen.cs: Split out the symbol writing code.
20967 2002-03-25 Martin Baulig <martin@gnome.org>
20969 * driver.cs (-g): Made -g an alias for --debug.
20971 2002-03-24 Martin Baulig <martin@gnome.org>
20973 * codegen.cs (SymbolWriter): New public variable. Returns the
20974 current symbol writer.
20975 (CodeGen): Added `bool want_debugging_support' argument to the
20976 constructor. If true, tell the ModuleBuild that we want debugging
20977 support and ask it for the ISymbolWriter.
20978 (Save): If we have a symbol writer, call it's Close() method after
20979 saving the assembly.
20981 * driver.c (--debug): New command line argument to create a
20982 debugger information file.
20984 * location.cs (SymbolDocument): New public property. Returns an
20985 ISymbolDocumentWriter object for the current source file or null
20986 if we don't have a symbol writer.
20988 2002-03-21 Miguel de Icaza <miguel@ximian.com>
20990 * driver.cs (LoadAssembly): Correctly return when all the paths
20991 have been tried and not before.
20993 * statement.cs (Switch.Emit): return the actual coverage for this
20994 statement (returns/not-returns)
20996 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
20997 switch of the statement if we are the last switch section. That
20998 kills two problems: try/catch problems (we used to emit an empty
20999 nop at the end) and switch statements where all branches would
21002 2002-03-19 Miguel de Icaza <miguel@ximian.com>
21004 * driver.cs: Add default assemblies (the equivalent to the
21005 Microsoft CSC.RSP file)
21007 * cs-tokenizer.cs: When updating `cols and setting it to zero,
21008 also update tokens_seen and set it to false.
21010 * driver.cs: Implement --recurse for Mike.
21012 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
21013 correctly splitting out the paths.
21015 2002-03-18 Miguel de Icaza <miguel@ximian.com>
21017 * interface.cs (Interface.PopulateProperty): Instead of using
21018 `parent' as the declaration space for the set parameters, use
21021 * support.cs (InternalParameters): InternalParameters constructor
21022 takes a DeclSpace instead of a TypeContainer.
21024 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
21025 types are being initialized, load the address of it before calling
21028 (New): Provide a mechanism to disable the generation of local
21029 value type temporaries when the caller will be providing us with
21030 an address to store it.
21032 (ArrayCreation.EmitDynamicInitializers): Use it.
21034 2002-03-17 Miguel de Icaza <miguel@ximian.com>
21036 * expression.cs (Invocation.EmitArguments): Only probe for array
21037 property if there is more than one argument. Sorry about that.
21039 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
21040 empty param arrays.
21042 * class.cs (Method.LabelParameters): Fix incorrect code path that
21043 prevented the `ParamArrayAttribute' from being applied to the
21046 2002-03-16 Miguel de Icaza <miguel@ximian.com>
21048 * support.cs (ReflectionParameters): Correctly compute whether the
21049 last argument is a params array. Fixes the problem with
21052 * typemanager.cs: Make the assemblies array always be non-null
21053 (empty, but non-null)
21055 * tree.cs (RecordDecl): New function that abstracts the recording
21056 of names. This reports error 101, and provides a pointer to the
21057 previous declaration. Fixes a crash in the compiler.
21059 * cs-parser.jay (constructor_declaration): Update to new grammar,
21060 and provide a constructor_body that can be empty.
21062 2002-03-15 Miguel de Icaza <miguel@ximian.com>
21064 * driver.cs: Add support for --resources.
21066 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
21067 Make all types for the various array helper methods be integer.
21069 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
21070 CheckState to ConvCast.
21072 (ConvCast): Now it takes a `checked' state argument, to avoid
21073 depending on the emit context for the conversion, and just using
21074 the resolve time setting.
21076 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
21077 instead of Invocation.EmitArguments. We do not emit the original
21078 arguments, instead we emit those which have been converted to
21079 unsigned int expressions.
21081 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
21083 * codegen.cs: ditto.
21085 * expression.cs (LocalVariableReference): Drop the use of the
21086 Store function that depended on the variable index.
21088 * statement.cs (VariableInfo): Drop the `Idx' property from this
21089 class, as this is not taking into account the indexes for
21090 temporaries tat we generate during the execution, getting the
21093 * class.cs: First emit class initializers, then call the parent
21096 * expression.cs (Binary): Fix opcode emision.
21097 (UnaryMutator.EmitCode): Support checked code generation
21099 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
21100 matches for events for both the Static and Instance scans,
21101 pointing to the same element. Fix that.
21103 2002-03-14 Miguel de Icaza <miguel@ximian.com>
21105 * rootcontext.cs (ResolveTree): Always set the
21106 interface_resolve_order, because nested interfaces will be calling
21109 * class.cs (GetInterfaceOrClass): Track the same resolution
21110 process used by TypeManager.LookupType. This fixes the nested
21111 type lookups in class declarations (separate path from
21114 (TypeContainer.DefineType): Also define nested interfaces.
21115 (TypeContainer.RegisterOrder): New public function used to
21116 register the order in which child interfaces need to be closed.
21118 Nested interfaces need to be closed after their parents have been
21121 * interface.cs (InterfaceAttr): Put all the logic for computing
21122 the interface attribute here.
21124 (DefineInterface): Register our interface order with the
21125 RootContext or with the TypeContainer depending on the case.
21127 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21129 * cs-parser.jay: rework foreach statement to work with the new
21130 changes to the policy on SimpleNames.
21132 * report.cs: support Stacktrace on warnings as well.
21134 * makefile: drop --unsafe and /unsafe from the compile.
21136 2002-03-13 Ravi Pratap <ravi@ximian.com>
21138 * ecore.cs (StandardConversionExists): Modify to take an Expression
21139 as the first parameter. Ensure we do null -> reference type conversion
21142 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
21143 temporary Expression objects.
21145 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
21147 * interface.cs: workaround bug in method overloading resolution
21148 (there is already a bugzilla bug for it).
21150 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21152 We could also solve this problem by having a separate path for
21153 performing type lookups, instead of DoResolve, we could have a
21154 ResolveType entry point, and only participating pieces of the
21155 production (simplename, deref, array) would implement this.
21157 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
21158 signal SimpleName to only resolve type names and not attempt to
21159 resolve anything else.
21161 * expression.cs (Cast): Set the flag.
21163 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
21165 * class.cs: Only report 108 if there is no `new' modifier.
21167 * cs-parser.jay: rework foreach statement to work with the new
21168 changes to the policy on SimpleNames.
21170 * report.cs: support Stacktrace on warnings as well.
21172 * makefile: drop --unsafe and /unsafe from the compile.
21174 2002-03-11 Miguel de Icaza <miguel@ximian.com>
21176 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21177 lookups here, instead of doing that at parse time. This means
21178 that our grammar will not introduce `LocalVariableReferences' as
21179 expressions at this point. That solves the problem of code like
21183 static void Main ()
21187 This is only half the fix. The full fix requires parameters to
21188 also be handled in this way.
21190 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
21191 makes the use more obvious of the DeclSpace. The
21192 ec.TypeContainer.TypeBuilder is now only used to pull the
21193 TypeBuilder for it.
21195 My theory is that I can get rid of the TypeBuilder completely from
21196 the EmitContext, and have typecasts where it is used (from
21197 DeclSpace to where it matters).
21199 The only pending problem is that the code that implements Aliases
21200 is on TypeContainer, and probably should go in DeclSpace.
21202 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21203 lookups here, instead of doing that at parse time. This means
21204 that our grammar will not introduce `LocalVariableReferences' as
21205 expressions at this point. That solves the problem of code like
21209 static void Main ()
21213 This is only half the fix. The full fix requires parameters to
21214 also be handled in this way.
21216 * class.cs (Property.DefineMethod): When implementing an interface
21217 method, set newslot, when implementing an abstract method, do not
21218 set the flag (before we tried never setting it, or always setting
21219 it, which is the difference).
21220 (Indexer.DefineMethod): same.
21221 (Method.DefineMethod): same.
21223 * ecore.cs: Only set the status used flag if we get back a Field.
21225 * attribute.cs: Temporary hack, so Paolo can keep working.
21227 2002-03-08 Ravi Pratap <ravi@ximian.com>
21229 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
21230 the unmanaged type in the case we have a MarshalAs attribute.
21232 (Resolve): Handle the case when we are parsing the special MarshalAs
21233 attribute [we need to store the unmanaged type to use later]
21235 * typemanager.cs (marshal_as_attr_type): Built in type for the
21236 MarshalAs Attribute.
21238 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
21239 on parameters and accordingly set the marshalling info.
21241 2002-03-09 Miguel de Icaza <miguel@ximian.com>
21243 * class.cs: Optimizing slightly by removing redundant code after
21244 we switched to the `NoTypes' return value.
21245 (Property.DefineMethod): use NoTypes here too.
21247 This fixes the bug I introduced in my last batch of changes.
21249 2002-03-05 Ravi Pratap <ravi@ximian.com>
21251 * tree.cs (RecordEnum): Add. We now keep track of enums too.
21253 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
21254 Enums since those are types too.
21256 * cs-parser.jay (enum_declaration): Record enums as we parse them.
21258 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
21259 thanks to a call during the lookup process.
21261 2002-03-07 Miguel de Icaza <miguel@ximian.com>
21263 * statement.cs (Foreach): Lots of work to accomodate a particular
21264 kind of foreach statement that I had not kept in mind. It is
21265 possible to have foreachs on classes that provide a GetEnumerator
21266 method that return objects that implement the "pattern" for using
21267 a foreach, there is no need to support GetEnumerator
21270 This is needed to compile nant.
21272 * decl.cs: Only report 114 if the member is not `Finalize' and if
21273 the warning level is at least 2.
21275 * class.cs: Moved the compare function from Method to
21278 (MethodSignature.InheritableMemberSignatureCompare): Add new
21279 filter function that is used to extract inheritable methods from a
21282 (Method.Define): Use the new `inheritable_method_signature_filter'
21285 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
21288 2002-03-06 Miguel de Icaza <miguel@ximian.com>
21290 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
21292 * cs-parser.jay: Add opt_semicolon to the interface declaration.
21294 * expression.cs: Pass location information to
21295 ConvertImplicitStandard.
21297 * class.cs: Added debugging code to track return values from
21300 2002-03-05 Miguel de Icaza <miguel@ximian.com>
21302 * expression.cs (Is.DoResolve): If either side of the `is' is an
21303 interface, do not flag the warning.
21305 * ecore.cs (ImplicitReferenceConversion): We need a separate test
21308 * report.cs: Allow for --fatal to be used with --probe.
21310 * typemanager.cs (NoTypes): Move the definition for the empty Type
21313 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
21315 (TypeContainer.DefineProxy): New function used to proxy to parent
21316 implementations when implementing interfaces.
21317 (TypeContainer.ParentImplements): used to lookup if our parent
21318 implements a public function that is required by an interface.
21319 (TypeContainer.VerifyPendingMethods): Hook this up.
21321 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
21322 `modules' and `assemblies' arraylists into arrays. We only grow
21323 these are the very early start up of the program, so this improves
21324 the speedof LookupType (nicely measured).
21326 * expression.cs (MakeByteBlob): Replaced unsafe code with
21327 BitConverter, as suggested by Paolo.
21329 * cfold.cs (ConstantFold.Binary): Special case: perform constant
21330 folding of string concatenation, but if either side is a string,
21331 and the other is not, then return null, and let the runtime use
21332 the concatenation on the string plus the object (using
21333 `Object.ToString').
21335 2002-03-04 Miguel de Icaza <miguel@ximian.com>
21337 Constant Folding has been implemented now.
21339 * expression.cs (Unary.Reduce): Do not throw an exception, catch
21340 the error instead on types that are not supported in one's
21343 * constant.cs (Constant and all children): New set of functions to
21344 perform implict and explicit conversions.
21346 * ecore.cs (EnumConstant): Implement the new functions to perform
21347 conversion by proxying to the child expression.
21349 * codegen.cs: (ConstantCheckState): Constant evaluation has its
21350 own separate setting that can not be turned off from the command
21351 line using --unchecked or --checked and is only controlled using
21352 the checked/unchecked statements and expressions. This setting is
21353 used by the constant folder to flag errors.
21355 * expression.cs (CheckedExpr, UncheckedExpr): Set the
21356 ConstantCheckState as well.
21358 During Resolve, they also have to flag the state, because the
21359 constant folder runs completely in the Resolve phase.
21361 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
21364 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21366 * cfold.cs: New file, this file contains the constant folder.
21368 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
21369 argument to track whether we are using the resulting address to
21370 load or store a value and provide better error messages.
21372 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
21373 new AddressOf arguments.
21375 * statement.cs (Foreach.EmitCollectionForeach): Update
21377 * expression.cs (Argument.Emit): Call AddressOf with proper
21378 arguments to track usage.
21380 (New.DoEmit): Call AddressOf with new arguments.
21382 (Unary.Emit): Adjust AddressOf call.
21384 2002-03-01 Ravi Pratap <ravi@ximian.com>
21386 * cs-parser.jay (member_access): Change the case for pre-defined types
21387 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
21390 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
21393 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
21394 essentially like methods and apply attributes like MethodImplOptions to them too.
21396 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
21399 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
21400 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
21403 * Update code everywhere accordingly.
21405 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
21407 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
21409 2002-02-28 Ravi Pratap <ravi@ximian.com>
21411 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
21412 try performing lookups against those instead of jumping straight into using
21413 the 'using' clauses.
21415 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
21417 (LookupType): Perform lookups in implicit parents too.
21419 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
21420 sequence as RootContext.LookupType.
21422 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
21423 the various cases of namespace lookups into this method.
21425 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21427 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
21428 in positional arguments)
21430 * class.cs (Operator): Update the AllowedModifiers to contain
21433 * cs-parser.jay: Update operator declaration to allow for the
21434 operator body to be empty.
21436 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
21439 2002-02-27 Miguel de Icaza <miguel@ximian.com>
21441 * class.cs (Method.Emit): Label parameters.
21443 * driver.cs: Return 1 or 0 as the program exit code.
21445 2002-02-26 Miguel de Icaza <miguel@ximian.com>
21447 * expression.cs: Special case the `null' object when trying to
21448 auto-compute the type, as anything can be explicitly converted to
21451 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
21452 spotting this Paolo.
21454 (Expression.ImplicitNumericConversion): Perform comparissions of
21455 the type using the underlying type in the case of an enumeration
21456 rather than using the enumeration type for the compare.
21458 Cope with the underlying == type case, which is not possible to
21461 (Expression.ConvertNumericExplicit): Perform comparissions of
21462 the type using the underlying type in the case of an enumeration
21463 rather than using the enumeration type for the compare.
21465 * driver.cs: If the user does not supply an extension, assume .exe
21467 * cs-parser.jay (if_statement): Rewrote so that we can track the
21468 location for the if statement.
21470 * expression.cs (Binary.ConstantFold): Only concat strings when
21471 the operation is "+", not everything ;-)
21473 * statement.cs (Statement.EmitBoolExpression): Take a location
21475 (If, While, Do): Track location.
21477 * expression.cs (Binary.ResolveOperator): In the object + string
21478 case, I was missing a call to ConvertImplicit
21480 2002-02-25 Ravi Pratap <ravi@ximian.com>
21482 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
21483 Location arguments. Ensure we use RootContext.LookupType to do our work
21484 and not try to do a direct Type.GetType and ModuleBuilder.GetType
21486 * interface.cs (PopulateMethod): Handle the type of the parameter being
21489 * expression.cs (Invocation.BetterFunction): Handle the case when we
21490 have a params method with no fixed arguments and a call is made with no
21493 2002-02-25 Miguel de Icaza <miguel@ximian.com>
21495 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
21496 the verbatim-string-literal
21498 * support.cs (InternalParameters.ParameterModifier): handle null
21500 (InternalParameters.ParameterType): ditto.
21502 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
21503 duplicating the name of the variable parameter.
21504 (GetParameterByName): Fix bug where we were not looking up array
21505 paramters if they were the only present (thanks Paolo!).
21506 (GetParameterInfo): We only have an empty set of types if both
21507 fixed and array are set to null.
21508 (GetParameterInfo-idx): Handle FixedParameter == null
21510 * cs-parser.jay: Handle the case where there is no catch
21511 statements (missing null test).
21513 2002-02-22 Miguel de Icaza <miguel@ximian.com>
21515 * driver.cs (MainDriver): Be conservative on our command line
21518 Catch DirectoryNotFoundException when calling GetFiles.
21520 (SplitPathAndPattern): Used to split the input specification into
21521 a path and a pattern that we can feed to Directory.GetFiles.
21523 2002-02-21 Miguel de Icaza <miguel@ximian.com>
21525 * statement.cs (Fixed): Implement the last case of the Fixed
21526 statement (string handling).
21528 * expression.cs (StringPtr): New class used to return a char * to
21529 a string; Used by the Fixed statement.
21531 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
21533 * expression.cs (Binary.ResolveOperator): Remove redundant
21534 MemberLookup pn parent type.
21535 Optimize union call, we do not need a union if the types are the same.
21536 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
21539 Specialize the use of MemberLookup everywhere, instead of using
21540 the default settings.
21542 (StackAlloc): Implement stackalloc keyword.
21544 * cs-parser.jay: Add rule to parse stackalloc.
21546 * driver.cs: Handle /h, /help, /?
21548 * expression.cs (MakeByteBlob): Removed the hacks we had in place
21549 before we supported unsafe code.
21551 * makefile: add --unsafe to the self compilation of mcs.
21553 2002-02-20 Miguel de Icaza <miguel@ximian.com>
21555 * expression.cs (PointerArithmetic): New class that is used to
21556 perform pointer arithmetic.
21557 (Binary.Resolve): Handle pointer arithmetic
21558 Handle pointer comparission.
21559 (ArrayPtr): Utility expression class that is used to take the
21560 address of an array.
21562 (ElementAccess): Implement array access for pointers
21564 * statement.cs (Fixed): Implement fixed statement for arrays, we
21565 are missing one more case before we are done.
21567 * expression.cs (Indirection): Implement EmitAssign and set the
21568 ExprClass to Variable. This allows pointer dereferences to be
21569 treated as variables, and to have values assigned to them.
21571 * ecore.cs (Expression.StoreFromPtr): New utility function to
21572 store values dereferencing.
21574 2002-02-20 Ravi Pratap <ravi@ximian.com>
21576 * expression.cs (Binary.ResolveOperator): Ensure that we are
21577 not trying to operate on a void type - this fixes the reported
21580 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
21581 the parent implementation is sealed.
21583 * ../errors/cs0239.cs : Add.
21585 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
21587 * typemanager.cs (unverifiable_code_type): Corresponds to
21588 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
21589 which have unsafe code in them.
21591 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
21594 2002-02-19 Miguel de Icaza <miguel@ximian.com>
21596 * cs-tokenizer.cs: Add support for @"litreal strings"
21598 Make tokenizer accept pre-processor directives
21599 on any column (remove the old C-like limitation).
21601 * rootcontext.cs (EmitCode): Emit any global attributes.
21602 (AddGlobalAttributes): Used to keep track of assembly attributes.
21604 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
21606 * cs-parser.jay: Add support for global attributes.
21608 2002-02-17 Miguel de Icaza <miguel@ximian.com>
21610 * expression.cs (Indirection): New helper class. Unary will
21611 create Indirection classes to be able to implement the
21612 IMemoryLocation interface on it.
21614 2002-02-16 Miguel de Icaza <miguel@ximian.com>
21616 * cs-parser.jay (fixed_statement): reference the right statement.
21618 * statement.cs (Fixed.Emit): Finish implementing the fixed
21619 statement for the &x case.
21621 2002-02-14 Miguel de Icaza <miguel@ximian.com>
21623 * class.cs (Property.Define, Method.Define): Remove newslot when
21626 * modifiers.cs: My use of NewSlot when `Abstract' was set was
21627 wrong. NewSlot should only be used if the `new' keyword is present.
21629 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
21630 locating our system dir. Sorry about this.
21632 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21634 * driver.cs (GetSystemDir): Compute correctly the location of our
21635 system assemblies. I was using the compiler directory instead of
21636 the library directory.
21638 2002-02-13 Ravi Pratap <ravi@ximian.com>
21640 * expression.cs (BetterFunction): Put back in what Miguel commented out
21641 since it is the correct fix. The problem is elsewhere ;-)
21643 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
21644 parameters of the parms method are themselves compatible or not !
21646 (StandardConversionExists): Fix very dangerous bug where we were forgetting
21647 to check that a class implements an interface before saying that an implicit
21648 conversion was allowed. Use ImplementsInterface to do the checking.
21650 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21652 * class.cs (Method.Define): Track whether we are an explicit
21653 implementation or not. And only call DefineMethodOverride if we
21654 are an explicit implementation.
21656 (Property.DefineMethod): Ditto.
21658 2002-02-11 Ravi Pratap <ravi@ximian.com>
21660 * expression.cs (BetterFunction): Catch hideous bug which was
21661 preventing us from detecting ambiguous calls due to implicit casts i.e
21664 2002-01-29 Miguel de Icaza <miguel@ximian.com>
21666 * support.cs (Pair): Remove un-needed method. I figured why I was
21667 getting the error in cs-parser.jay, the variable in a foreach loop
21668 is readonly, and the compiler does not really treat this as a variable.
21670 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
21671 instead of EQUALS in grammar.
21673 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
21675 * expression.cs (Unary.DoResolve): Check whether the argument is
21678 2002-01-28 Miguel de Icaza <miguel@ximian.com>
21680 * support.cs: Api for Pair to set a value. Despite the fact that
21681 the variables are public the MS C# compiler refuses to compile
21682 code that accesses the field if the variable is part of a foreach
21685 * statement.cs (Fixed): Begin implementation of the fixed
21688 (Block.AddVariable): Return the VariableInfo on success and null
21689 on failure instead of true/false.
21691 * cs-parser.jay (foreach): Catch errors on variables already
21692 defined (we were ignoring this value before) and properly unwind
21693 the block hierarchy
21695 (fixed_statement): grammar for the fixed statement.
21697 2002-01-25 Miguel de Icaza <miguel@ximian.com>
21699 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
21700 pointer types to be incretemented.
21702 (SizeOf): Implement.
21704 * cs-parser.jay (pointer_member_access): Implement
21705 expr->IDENTIFIER production.
21707 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
21708 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
21711 (Unary): Implement indirection.
21713 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
21714 use in non-unsafe context).
21716 (SimpleName.DoResolve): Check for pointers in field access on safe
21719 (Expression.LoadFromPtr): Factor the load-indirect code in this
21720 function. This was duplicated in UnboxCast and ParameterReference
21722 2002-01-24 Miguel de Icaza <miguel@ximian.com>
21724 * expression.cs (ComposedCast): report an error if a pointer cast
21725 is used in a safe region.
21727 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
21728 pointer type casts in unsafe context.
21730 * codegen.cs (EmitContext): Set up IsUnsafe.
21732 * cs-parser.jay (non_expression_type): Add productions for pointer
21735 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
21736 code. We should not use force into static mode if the method is
21737 not virtual. Fixes bug in MIS
21739 * statement.cs (Do.Emit, While.Emit, For.Emit,
21740 Statement.EmitBoolExpression): Add support to Do and While to
21741 propagate infinite loop as `I do return' semantics.
21743 Improve the For case to also test for boolean constants.
21745 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
21746 to the list of attributes we can add.
21748 Remove `EmitContext' argument.
21750 * class.cs (Method.Define): Apply parameter attributes.
21751 (Constructor.Define): Apply parameter attributes.
21752 (MethodCore.LabelParameters): Move here the core of labeling
21755 * support.cs (ReflectionParameters.ParameterModifier,
21756 InternalParameters.ParameterModifier): Use IsByRef on the type and
21757 only return the OUT bit for these parameters instead of in/out/ref
21760 This is because I miss-understood things. The ParameterInfo.IsIn
21761 and IsOut represent whether the parameter has the [In] and [Out]
21764 2002-01-22 Miguel de Icaza <miguel@ximian.com>
21766 * ecore.cs (FieldExpr.Emit): Release temporaries.
21768 * assign.cs (LocalTemporary.Release): new function.
21770 * codegen.cs (EmitContext.GetTemporaryStorage,
21771 EmitContext.FreeTemporaryStorage): Rework the way we deal with
21772 temporary storage. Now we can "put back" localbuilders when we
21775 2002-01-21 Miguel de Icaza <miguel@ximian.com>
21777 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
21778 need to make a copy of the variable to generate verifiable code.
21780 2002-01-19 Miguel de Icaza <miguel@ximian.com>
21782 * driver.cs: Compute dynamically the system directory.
21784 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
21785 Slower, but more generally useful. Used by the abstract
21786 registering implementation.
21788 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
21789 the rules for the special rule on Type/instances. First check if
21790 we have the same name, and if so, try that special static path
21791 rather than the instance path.
21793 2002-01-18 Miguel de Icaza <miguel@ximian.com>
21795 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
21798 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
21799 Enum, ValueType, Delegate or Array for non-corlib compiles.
21801 * cs-tokenizer.cs: Catch long identifiers (645)
21803 * typemanager.cs (IndexerPropetyName): Ravi never tested this
21806 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
21807 fix, we were returning too early, so we were not registering
21808 pending methods from abstract classes.
21810 Do not register pending methods if the class is abstract.
21812 * expression.cs (Conditional.DoResolve): Report circular implicit
21813 conversions when we neecd to compute it for conditional
21816 (Is.DoResolve): If the expression is always of the provided type,
21817 flag warning 183. If the expression can not ever be of the
21818 provided type flag warning 184.
21820 * class.cs: Catch 169 as well.
21822 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
21825 2002-01-18 Nick Drochak <ndrochak@gol.com>
21827 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
21829 2002-01-17 Miguel de Icaza <miguel@ximian.com>
21831 * interface.cs: (PopulateMethod): Check for pointers being defined
21832 only if the unsafe context is active.
21833 (PopulateProperty): ditto.
21834 (PopulateIndexer): ditto.
21836 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
21837 specified. If pointers are present, make sure that they are
21838 present in an unsafe context.
21839 (Constructor, Constructor.Define): ditto.
21840 (Field, Field.Define): ditto.
21841 (Property, Property.Define): ditto.
21842 (Event, Event.Define): ditto.
21844 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
21845 hashtable if there are classes or structs defined.
21847 * expression.cs (LocalVariableReference.DoResolve): Simplify this
21848 code, as the constant resolution moved.
21850 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
21851 the metadata, so we can flag error 133.
21853 * decl.cs (MemberCore.UnsafeOK): New function to test that a
21854 pointer is being declared in an unsafe context.
21856 2002-01-16 Miguel de Icaza <miguel@ximian.com>
21858 * modifiers.cs (Modifiers.Check): Require a Location argument.
21859 Report error 227 for Unsafe use.
21861 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
21863 * statement.cs (For.Emit): If the test is null, then report that
21864 we do `return', as we wont reach anything afterwards.
21866 (Switch.SwitchGoverningType): Track the expression that matched
21869 * driver.cs: Allow negative numbers as an error code to flag.
21871 * cs-parser.jay: Handle 1551.
21873 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
21875 2002-01-15 Miguel de Icaza <miguel@ximian.com>
21877 * cs-parser.jay: Report 1518 (type declaration can only contain
21878 class, struct, interface, enum or delegate)
21880 (switch_label): Report 1523 (keywords `case' or `default' must
21883 (opt_switch_sections): Report 1522 (empty switch)
21885 * driver.cs: Report 1515 (response file specified multiple times)
21886 Report 1516 (Source file specified multiple times).
21888 * expression.cs (Argument.Resolve): Signal 1510
21890 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
21891 access not allowed in static code)
21893 2002-01-11 Ravi Pratap <ravi@ximian.com>
21895 * typemanager.cs (IsPointerType): Utility method which we are going
21898 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
21899 the object type, so we take care of that.
21901 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
21903 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
21904 added to non-params parameters :-)
21906 * typemanager.cs (CSharpName): Include 'void' type too.
21908 (void_ptr_type): Include in the set of core types.
21910 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
21913 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
21916 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
21917 completely forgotten about it.
21919 2002-01-10 Ravi Pratap <ravi@ximian.com>
21921 * cs-parser.jay (pointer_type): Add. This begins our implementation
21922 of parsing rules for unsafe code.
21924 (unsafe_statement): Implement.
21926 (embedded_statement): Modify to include the above.
21928 * statement.cs (Unsafe): Implement new class for unsafe blocks.
21930 * codegen.cs (EmitContext.InUnsafe): Add. This determines
21931 if the current context is an unsafe one.
21933 * cs-parser.jay (local_variable_pointer_type): Since local variable types
21934 are handled differently, we need separate rules for them.
21936 (local_variable_declaration): Update to use local_variable_pointer_type
21937 to allow variable declarations of unmanaged pointer types.
21939 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
21940 in unsafe contexts.
21942 * ../errors/cs0214.cs : Add.
21944 2002-01-16 Nick Drochak <ndrochak@gol.com>
21946 * makefile: remove 'response' file when cleaning.
21948 2002-01-15 Miguel de Icaza <miguel@ximian.com>
21950 * cs-parser.jay: Report 1524.
21952 2002-01-14 Miguel de Icaza <miguel@ximian.com>
21954 * typemanager.cs (RegisterMethod): drop checking if we have
21955 registered this from here
21957 2002-01-12 Miguel de Icaza <miguel@ximian.com>
21959 * class.cs (Method.EmitDestructor): Implement calling our base
21962 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
21963 value of InFinally.
21965 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
21966 this routine and will wrap the call in a try/catch block. Deal
21969 2002-01-11 Miguel de Icaza <miguel@ximian.com>
21971 * ecore.cs (Expression.MemberLookup): instead of taking a
21972 parameter `same_type' that was used to tell whether we could
21973 access private members we compute our containing type from the
21976 (FieldExpr): Added partial support for volatile fields. This does
21977 not work for volatile fields exposed from assemblies, as I can not
21978 figure out how to extract the modreq from it.
21980 Updated all the source files to use this.
21982 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
21983 because it is referenced by MemberLookup very often.
21985 2002-01-09 Ravi Pratap <ravi@ximian.com>
21987 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
21988 TypeBuilder.GetCustomAttributes to retrieve what we need.
21990 Get rid of redundant default_member_attr_type as this is the same as
21991 default_member_type which already exists.
21993 * interface.cs, attribute.cs : Update accordingly.
21995 2002-01-08 Miguel de Icaza <miguel@ximian.com>
21997 * typemanager.cs: Enable IndexerPropertyName again. It does not
21998 work for TYpeBuilders though. Ravi, can you please fix this?
22000 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
22002 * expression.cs (Argument.Emit): Handle the case of ref objects
22003 being passed to ref functions;
22005 (ParameterReference.EmitLoad): Loads the content of the pointer
22006 without dereferencing.
22008 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22010 * cs-tokenizer.cs: Implemented the pre-processing expressions.
22012 2002-01-08 Ravi Pratap <ravi@ximian.com>
22014 * class.cs (Indexer.DefineMethod): Incorporate the interface
22015 type in the name of the method if we are doing explicit interface
22018 * expression.cs (ConversionExists): Remove as it is completely obsolete.
22020 (BetterConversion): Fix extremely trivial bug where we were referring to
22021 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
22024 * ../errors/bug16.cs : Add although we have fixed it.
22026 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22028 * expression.cs (BaseIndexer): Begin implementation.
22030 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
22032 * cs-parser.jay (indexer_declarator): Use qualified_identifier
22033 production directly to remove a shift/reduce, and implement
22034 explicit interface implementation.
22036 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
22037 after a floating point suffix.
22039 * expression.cs (DoNumericPromotions): Improved the conversion for
22040 uint/uint. If we have a constant, we avoid doing a typecast to a
22043 * class.cs (Indexer): Implement explicit interface implementation
22046 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
22048 * class.cs: make the default instance constructor public and hidebysig.
22050 2001-01-03 Ravi Pratap <ravi@ximian.com>
22052 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
22053 so we can call it from elsewhere.
22055 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
22056 we emit it internally if the class has a defined indexer; otherwise the user
22057 emits it by decorating the class definition with the DefaultMemberAttribute.
22059 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
22060 attribute is not used on a type which defines an indexer.
22062 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
22063 character when we skip whitespace.
22065 * ../errors/cs0646.cs : Add.
22067 2002-01-03 Miguel de Icaza <miguel@ximian.com>
22069 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
22072 * makefile: Add practical target `mcs3.exe' which builds the third
22073 generation compiler.
22075 * expression.cs (New): Fix structures constructor calling.
22077 * class.cs (Property, Method, Indexer): Emit Final flag on the
22078 method if we are an interface implementation and we are not
22081 * ecore.cs (PropertyExpr): New public field `IsBase', tells
22082 whether this property is referencing a `base' method.
22084 * expression.cs (Invocation.EmitCall): take an extra argument:
22085 is_base, this is used to determine whether the `call' or
22086 `callvirt' opcode should be used.
22089 * delegate.cs: update EmitCall.
22091 * class.cs (Method.Define): Set NewSlot for the cases where we are
22092 not implementing an interface method.
22094 (Property.Define): ditto.
22096 2002-01-02 Miguel de Icaza <miguel@ximian.com>
22098 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
22099 'r'. Allows mcs to parse itself fully.
22101 2002-01-02 Ravi Pratap <ravi@ximian.com>
22103 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
22104 of the number of initializers that require the InitializeArray method.
22106 (CheckIndices): Store the Expression in all cases - not the plain value. Also
22107 update the above field where necessary.
22109 (MakeByteBlob): Update accordingly.
22111 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
22114 (EmitDynamicInitializers): Update in accordance with the new optimization.
22116 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
22117 same OpCode applies.
22119 * cs-parser.jay : Fix some glaring errors I introduced.
22121 2002-01-01 Ravi Pratap <ravi@ximian.com>
22123 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
22124 so that we can check for name clashes there too.
22126 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
22127 for interface indexers.
22129 * interfaces.cs (Define): Emit the default member attribute.
22131 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
22132 variable was being referred to while setting the value ;-)
22134 2002-01-01 Miguel de Icaza <miguel@ximian.com>
22136 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
22137 byte-by-byte information when we know the data is zero.
22139 Make the block always a multiple of 4, because
22140 DefineInitializedData has a bug.
22142 * assign.cs: Fix, we should assign from the temporary, not from
22145 * expression.cs (MakeByteBlob): Fix my incorrect code.
22147 2001-12-31 Miguel de Icaza <miguel@ximian.com>
22149 * typemanager.cs (EnumToUnderlying): This function is used to get
22150 the underlying type from an enumeration, because it does not
22153 * constant.cs: Use the I4_S form for values between -128 and 127.
22155 * statement.cs (Block.LookupLabel): Looks up a label.
22156 (Block): Drop support for labeled blocks.
22158 (LabeledStatement): New kind of statement that represents a label
22161 (Goto): Finally implement this bad boy.
22163 * cs-parser.jay: Update to reflect new mechanism to implement
22166 2001-12-30 Miguel de Icaza <miguel@ximian.com>
22168 * codegen.cs (EmitContext.This): a codegen property that keeps the
22169 a single instance of this instead of creating many different this
22172 * delegate.cs (Delegate.DoResolve): Update to use the property;
22174 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
22176 * expression.cs (BaseAccess.DoResolve): Ditto.
22178 2001-12-29 Ravi Pratap <ravi@ximian.com>
22180 * typemanager.cs (methodimpl_attr_type): Add to hold the type
22181 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
22183 (InitCoreTypes): Update accordingly.
22185 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
22186 so we can quickly store the state.
22188 (ApplyAttributes): Set the correct implementation flags
22189 for InternalCall methods.
22191 2001-12-29 Miguel de Icaza <miguel@ximian.com>
22193 * expression.cs (EmitCall): if a method is not virtual, then do
22194 not use callvirt on it.
22196 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
22197 user defined stuff) requires the use of stobj, which takes an
22198 address on the stack instead of an array and an index. So emit
22199 the Ldelema operation for it.
22201 (EmitStoreOpcode): Use stobj for valuetypes.
22203 (UnaryMutator.EmitCode): Use the right 1 value depending on
22204 whether we are dealing with int64/uint64, float or doubles.
22206 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
22207 constructors that I implemented last night.
22209 (Constructor.IsDefault): Fix to work properly for static
22212 * cs-parser.jay (CheckDef): report method signature errors.
22213 Update error number 103 to be 132.
22215 * decl.cs: New AdditionResult enumeration value: MethodExists.
22216 Although we do this check for methods later on in the semantic
22217 analysis, catching repeated default constructors is so easy that
22218 we catch these here.
22220 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
22223 (ParameterReference.EmitAssign, Emit): handle
22226 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
22227 (ArrayAccess.EmitStoreOpcode): ditto.
22229 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
22231 * expression.cs (MakeByteBlob): Complete all the missing types
22232 (uint, short, ushort, byte, sbyte)
22234 * class.cs: Only init instance field initializers on instance
22237 Rename `constructors' to instance_constructors.
22239 (TypeContainer.AddConstructor): Only add constructors to the list
22240 if it is not static.
22242 Make sure that we handle default_static_constructor independently
22243 everywhere where we handle instance_constructors
22245 2001-12-28 Miguel de Icaza <miguel@ximian.com>
22247 * class.cs: Do not lookup or create a base initializer for a
22248 static constructor.
22250 (ConstructorInitializer.Resolve): use the proper type to lookup
22253 * cs-parser.jay: Report error 1585 (modifiers between type and name).
22255 * enum.cs, interface.cs: Remove CloseType, this is taken care by
22258 * decl.cs: CloseType is now an virtual method, the default
22259 implementation just closes this type.
22261 2001-12-28 Ravi Pratap <ravi@ximian.com>
22263 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
22264 to PreserveSig by default. Also emit HideBySig on such methods.
22266 Basically, set the defaults to standard values.
22268 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
22269 argument, if candidate is better, it can't be worse than the best !
22271 (Invocation): Re-write bits to differentiate between methods being
22272 applicable in their expanded form and their normal form - for params
22275 Get rid of use_standard everywhere as only standard conversions are allowed
22276 in overload resolution.
22278 More spec conformance.
22280 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22282 * driver.cs: Add --timestamp, to see where the compiler spends
22285 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
22286 `this' in static code.
22288 (SimpleName.DoResolve): Implement in terms of a helper function
22289 that allows static-references to be passed upstream to
22292 (Expression.ResolveWithSimpleName): Resolve specially simple
22293 names when called by MemberAccess to implement the special
22296 (Expression.ImplicitReferenceConversion): Handle conversions from
22297 Null to reference types before others, as Null's type is
22300 * expression.cs (Invocation.EmitCall): Handle the special case of
22301 calling methods declared on a reference type from a ValueType
22302 (Base classes System.Object and System.Enum)
22304 (MemberAccess.Resolve): Only perform lookups on Enumerations if
22305 the left hand side is a TypeExpr, not on every enumeration.
22307 (Binary.Resolve): If types are reference types, then do a cast to
22308 object on operators != and == of both arguments.
22310 * typemanager.cs (FindMembers): Extract instance and static
22311 members if requested.
22313 * interface.cs (PopulateProperty): Use void_type instead of null
22314 as the return type for the setter method.
22316 (PopulateIndexer): ditto.
22318 2001-12-27 Ravi Pratap <ravi@ximian.com>
22320 * support.cs (ReflectionParameters): Fix minor bug where we
22321 were examining the wrong parameter for the ParamArray attribute.
22323 Cope with requests for the type of the parameter at position
22324 greater than the params parameter's. We now return the element
22325 type of the params array as that makes more sense.
22327 * expression.cs (Invocation.IsParamsMethodApplicable): Update
22328 accordingly as we no longer have to extract the element type
22331 (Invocation.OverloadResolve): Update.
22333 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22335 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
22336 against IEnumerator, test whether the return value is a descendant
22337 of the IEnumerator interface.
22339 * class.cs (Indexer.Define): Use an auxiliary method to implement
22340 the other bits of the method definition. Begin support for
22341 explicit interface implementation.
22343 (Property.DefineMethod): Use TypeManager.void_type instead of null
22344 for an empty return value.
22346 2001-12-26 Miguel de Icaza <miguel@ximian.com>
22348 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
22349 dealing with a FieldExpr which is composed of a FieldBuilder, in
22350 the code path we did extract the constant, but we should have
22351 obtained the underlying value to be able to cast it (otherwise we
22352 end up in an infinite loop, this is what Ravi was running into).
22354 (ArrayCreation.UpdateIndices): Arrays might be empty.
22356 (MemberAccess.ResolveMemberAccess): Add support for section
22357 14.5.4.1 that deals with the special case of E.I when E is a type
22358 and something else, that I can be a reference to a static member.
22360 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
22361 handle a particular array type to create byte blobs, it is just
22362 something we dont generate byteblobs for.
22364 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
22367 * location.cs (Push): remove the key from the hashtable that we
22368 are about to add. This happens for empty files.
22370 * driver.cs: Dispose files after we have parsed them.
22372 (tokenize): new function that only runs the tokenizer on its
22373 input, for speed testing.
22375 2001-12-26 Ravi Pratap <ravi@ximian.com>
22377 * class.cs (Event.Define): Define the private field only if there
22378 are no accessors defined.
22380 * expression.cs (ResolveMemberAccess): If there is no associated
22381 field with the event, that means we have an event defined with its
22382 own accessors and we should flag error cs0070 since transforming
22383 ourselves into a field is not valid in that case.
22385 * ecore.cs (SimpleName.DoResolve): Same as above.
22387 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
22388 and charset to sane values.
22390 2001-12-25 Ravi Pratap <ravi@ximian.com>
22392 * assign.cs (DoResolve): Perform check on events only if they
22393 are being accessed outside the declaring type.
22395 * cs-parser.jay (event_declarations): Update rules to correctly
22396 set the type of the implicit parameter etc.
22398 (add_accessor, remove_accessor): Set current local parameters.
22400 * expression.cs (Binary): For delegate addition and subtraction,
22401 cast the return value from the method into the appropriate delegate
22404 2001-12-24 Ravi Pratap <ravi@ximian.com>
22406 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
22407 of these as the workaround is unnecessary.
22409 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
22410 delegate data - none of that is needed at all.
22412 Re-write bits to extract the instance expression and the delegate method
22415 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
22418 * attribute.cs (ApplyAttributes): New method to take care of common tasks
22419 of attaching attributes instead of duplicating code everywhere.
22421 * everywhere : Update code to do attribute emission using the above method.
22423 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22425 * expression.cs (IsParamsMethodApplicable): if there are not
22426 parameters, return immediately.
22428 * ecore.cs: The 0 literal can be implicity converted to an enum
22431 (SimpleName.DoResolve): First lookup the type, then lookup the
22434 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
22435 want to get its address. If the InstanceExpression is not
22436 addressable, store the result in a temporary variable, then get
22439 * codegen.cs: Only display 219 errors on warning level or above.
22441 * expression.cs (ArrayAccess): Make it implement the
22442 IMemoryLocation interface.
22444 (Binary.DoResolve): handle the operator == (object a, object b)
22445 and operator != (object a, object b) without incurring into a
22446 BoxedCast (because 5 != o should never be performed).
22448 Handle binary enumerator operators.
22450 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
22451 value type, otherwise use Ldelem_ref.
22453 Use precomputed names;
22455 (AddressOf): Implement address of
22457 * cs-parser.jay (labeled_statement): Fix recursive block
22458 addition by reworking the production.
22460 * expression.cs (New.DoEmit): New has a special case:
22462 If we are dealing with a ValueType, we have a few
22463 situations to deal with:
22465 * The target of New is a ValueType variable, that is
22466 easy, we just pass this as the variable reference
22468 * The target of New is being passed as an argument,
22469 to a boxing operation or a function that takes a
22472 In this case, we need to create a temporary variable
22473 that is the argument of New.
22476 2001-12-23 Ravi Pratap <ravi@ximian.com>
22478 * rootcontext.cs (LookupType): Check that current_type is not null before
22479 going about looking at nested types.
22481 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
22482 not implement the IAssignMethod interface any more.
22484 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
22485 where we tranform them into FieldExprs if they are being resolved from within
22486 the declaring type.
22488 * ecore.cs (SimpleName.DoResolve): Do the same here.
22490 * assign.cs (DoResolve, Emit): Clean up code considerably.
22492 * ../errors/bug10.cs : Add.
22494 * ../errors/cs0070.cs : Add.
22496 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
22498 * assign.cs : Get rid of EventIsLocal everywhere.
22500 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22502 * ecore.cs (ConvertIntLiteral): finished the implementation.
22504 * statement.cs (SwitchLabel): Convert the value we are using as a
22505 key before looking up the table.
22507 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22509 * codegen.cs (EmitTopBlock): Require a Location argument now.
22511 * cs-parser.jay (constructor_declarator): We need to setup
22512 current_local_parameters before we parse the
22513 opt_constructor_initializer, to allow the variables to be bound
22514 to the constructor arguments.
22516 * rootcontext.cs (LookupType): First lookup nested classes in our
22517 class and our parents before we go looking outside our class.
22519 * expression.cs (ConstantFold): Extract/debox the values at the
22522 * rootcontext.cs (EmitCode): Resolve the constants first before we
22523 resolve the types. This is not really needed, but it helps debugging.
22525 * statement.cs: report location.
22527 * cs-parser.jay: pass location to throw statement.
22529 * driver.cs: Small bug fix.
22531 * report.cs: Updated format to be 4-zero filled digits.
22533 2001-12-22 Ravi Pratap <ravi@ximian.com>
22535 * expression.cs (CheckIndices): Fix minor bug where the wrong
22536 variable was being referred to ;-)
22538 (DoEmit): Do not call EmitStaticInitializers when the
22539 underlying type is System.Object.
22541 2001-12-21 Ravi Pratap <ravi@ximian.com>
22543 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
22544 and do the usual workaround for SRE.
22546 * class.cs (MyEventBuilder.EventType): New member to get at the type
22547 of the event, quickly.
22549 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
22551 * assign.cs (Assign.DoResolve): Handle the case when the target
22552 is an EventExpr and perform the necessary checks.
22554 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
22557 (SimpleName.MemberStaticCheck): Include check for EventExpr.
22559 (EventExpr): Set the type in the constructor itself since we
22560 are meant to be born fully resolved.
22562 (EventExpr.Define): Revert code I wrote earlier.
22564 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
22565 instance expression is null. The instance expression is a This in that case
22566 or a null, depending on whether it is a static method or not.
22568 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
22569 refers to more than one method.
22571 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
22572 and accordingly flag errors.
22574 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22576 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
22578 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22580 * location.cs (ToString): Provide useful rutine.
22582 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22584 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
22585 objects, return the actual integral boxed.
22587 * statement.cs (SwitchLabel): define an ILLabel for each
22590 (Switch.CheckSwitch): If the value is a Literal, extract
22591 the underlying literal.
22593 Also in the unused hashtable we had, add the SwitchLabel so we can
22594 quickly look this value up.
22596 * constant.cs: Implement a bunch of new constants. Rewrite
22597 Literal based on this. Made changes everywhere to adapt to this.
22599 * expression.cs (Expression.MakeByteBlob): Optimize routine by
22600 dereferencing array only once, and also copes with enumrations.
22602 bytes are two bytes wide, not one.
22604 (Cast): Perform constant conversions.
22606 * ecore.cs (TryImplicitIntConversion): Return literals instead of
22607 wrappers to the literals here.
22609 * expression.cs (DoNumericPromotions): long literals can converted
22610 to ulong implicity (this is taken care of elsewhere, but I was
22611 missing this spot).
22613 * ecore.cs (Expression.Literalize): Make the return type Literal,
22614 to improve type checking.
22616 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
22618 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22620 * literal.cs: Revert code from ravi that checked the bounds. The
22621 bounds are sane by the definition of the type itself.
22623 * typemanager.cs: Fix implementation of ImplementsInterface. We
22624 need to actually look up in our parent hierarchy for interfaces
22627 * const.cs: Use the underlying type for enumerations
22629 * delegate.cs: Compute the basename for the delegate creation,
22630 that should fix the delegate test case, and restore the correct
22631 Type Lookup semantics in rootcontext
22633 * rootcontext.cs: Revert Ravi's last patch. The correct way of
22634 referencing a nested type with the Reflection API is using the "+"
22637 * cs-parser.jay: Do not require EOF token at the end.
22639 2001-12-20 Ravi Pratap <ravi@ximian.com>
22641 * rootcontext.cs (LookupType): Concatenate type names with
22642 a '.' instead of a '+' The test suite passes again.
22644 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
22645 field of the enumeration.
22647 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
22648 the case when the member is an EventExpr.
22650 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
22651 static has an associated instance expression.
22653 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
22655 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
22657 * class.cs (Event.Define): Register event and perform appropriate checks
22660 We define the Add and Remove methods even if the use provides none because
22661 in that case, we provide default implementations ourselves.
22663 Define a private field of the type of the event. This is done by the CSC compiler
22664 and we should be doing it too ;-)
22666 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
22667 More methods we use in code we generate.
22669 (multicast_delegate_type, delegate_type): Two separate types since the distinction
22672 (InitCoreTypes): Update accordingly for the above.
22674 * class.cs (Event.Emit): Generate code for default accessors that we provide
22676 (EmitDefaultMethod): Do the job in the above.
22678 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
22681 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22683 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
22684 builders even if we were missing one.
22686 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
22687 pass the Basename as our class name instead of the Name. The
22688 basename will be correctly composed for us.
22690 * parameter.cs (Paramters): Now takes a Location argument.
22692 * decl.cs (DeclSpace.LookupType): Removed convenience function and
22693 make all the code call directly LookupType in RootContext and take
22694 this chance to pass the Location information everywhere.
22696 * Everywhere: pass Location information.
22698 2001-12-19 Miguel de Icaza <miguel@ximian.com>
22700 * class.cs (Constructor.Define): Updated way of detecting the
22701 length of the parameters.
22703 (TypeContainer.DefineType): Use basename as the type name for
22706 (TypeContainer.Define): Do not recursively define types here, as
22707 definition is taken care in order by the RootContext.
22709 * tree.cs: Keep track of namespaces in a per-file basis.
22711 * parameter.cs (Parameter.ComputeSignature): Update to use
22714 (Parameters.GetSignature): ditto.
22716 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
22717 instead of a TypeContainer.
22719 (Interface.SemanticAnalysis): Use `this' instead of our parent to
22720 resolve names. Because we need to be resolve in our context, not
22723 * driver.cs: Implement response files.
22725 * class.cs (TypeContainer.DefineType): If we are defined, do not
22726 redefine ourselves.
22728 (Event.Emit): Emit the code for add/remove handlers.
22729 (Event.Define): Save the MethodBuilders for add/remove.
22731 * typemanager.cs: Use pair here too.
22733 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
22734 DictionaryEntry requires the first argument to be non-null.
22736 (enum_declaration): Compute full name for registering the
22739 (delegate_declaration): Instead of using
22740 formal_parameter_list, use opt_formal_parameter_list as the list
22743 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
22744 (EventParsing): New property that controls whether `add' and
22745 `remove' are returned as tokens or identifiers (for events);
22747 2001-12-19 Ravi Pratap <ravi@ximian.com>
22749 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
22750 use MyEventBuilder only and let it wrap the real builder for us.
22752 (MyEventBuilder): Revamp constructor etc.
22754 Implement all operations that we perform on EventBuilder in precisely the same
22757 (FindMembers): Update to use the EventBuilder member.
22759 (Event.Emit): Update accordingly.
22761 2001-12-18 Ravi Pratap <ravi@ximian.com>
22763 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
22764 by calling the appropriate methods.
22766 (GetCustomAttributes): Make stubs as they cannot possibly do anything
22769 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
22771 2001-12-17 Ravi Pratap <ravi@ximian.com>
22773 * delegate.cs (Delegate.Populate): Check that the return type
22774 and various parameters types are indeed accessible.
22776 * class.cs (Constructor.Define): Same here.
22778 (Field.Define): Ditto.
22780 (Event.Define): Ditto.
22782 (Operator.Define): Check that the underlying Method defined itself
22783 correctly - so it's MethodBuilder should not be null.
22785 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
22786 expression happens to be null.
22788 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
22789 members but as of now we don't seem to be able to do anything really useful with it.
22791 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
22792 not the EventBuilder.
22794 2001-12-18 Miguel de Icaza <miguel@ximian.com>
22796 * cs-tokenizer.cs: Add support for defines.
22797 Add support for #if, #elif, #else, #endif
22799 (eval_var): evaluates a variable.
22800 (eval): stubbed for evaluating functions.
22802 * cs-parser.jay: Pass the defines information
22804 * driver.cs: Add --define command line option.
22806 * decl.cs: Move MemberCore here.
22808 Make it the base class for DeclSpace. This allows us to catch and
22809 report 108 and 109 for everything now.
22811 * class.cs (TypeContainer.Define): Extract all the members
22812 before populating and emit the warning 108 (new keyword required
22813 to override) instead of having each member implement this.
22815 (MemberCore.Define): New abstract method, we will be using this in
22816 the warning reporting engine in Populate.
22818 (Operator.Define): Adjust to new MemberCore protocol.
22820 * const.cs (Const): This does not derive from Expression, it is a
22821 temporary object we use to create fields, it is a MemberCore.
22823 * class.cs (Method.Define): Allow the entry point to be in a
22826 * driver.cs: Rewrite the argument handler to clean it up a bit.
22828 * rootcontext.cs: Made it just an auxiliary namespace feature by
22829 making everything static.
22831 * driver.cs: Adapt code to use RootContext type name instead of
22834 * delegate.cs: Remove RootContext argument.
22836 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
22839 * class.cs (Event.Define): The lookup can fail.
22841 * cs-tokenizer.cs: Begin implementation of pre-procesor.
22843 * expression.cs: Resolve the this instance before invoking the code.
22845 2001-12-17 Miguel de Icaza <miguel@ximian.com>
22847 * cs-parser.jay: Add a production in element_access that allows
22848 the thing to become a "type" reference. This way we can parse
22849 things like "(string [])" as a type.
22851 Note that this still does not handle the more complex rules of
22855 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
22857 * ecore.cs: (CopyNewMethods): new utility function used to
22858 assemble the list of methods from running FindMembers.
22860 (MemberLookup): Rework FindMembers so that
22862 2001-12-16 Miguel de Icaza <miguel@ximian.com>
22864 * class.cs (TypeContainer): Remove Delegates who fail to be
22867 * delegate.cs (Populate): Verify that we dont get null return
22868 values. TODO: Check for AsAccessible.
22870 * cs-parser.jay: Use basename to emit error 574 (destructor should
22871 have the same name as container class), not the full name.
22873 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
22874 possible representation.
22876 Also implements integer type suffixes U and L.
22878 2001-12-15 Miguel de Icaza <miguel@ximian.com>
22880 * expression.cs (ArrayCreation.DoResolve): We need to do the
22881 argument resolution *always*.
22883 * decl.cs: Make this hold the namespace. Hold the root context as
22885 (LookupType): Move here.
22887 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
22889 * location.cs (Row, Name): Fixed the code, it was always returning
22890 references to the first file.
22892 * interface.cs: Register properties defined through interfaces.
22894 * driver.cs: Add support for globbing on the command line
22896 * class.cs (Field): Make it derive from MemberCore as well.
22899 2001-12-15 Ravi Pratap <ravi@ximian.com>
22901 * class.cs (Event::Define): Check that the type of the event is a delegate
22902 type else flag error #66.
22904 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
22907 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
22908 values of EntryPoint, CharSet etc etc.
22910 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
22912 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
22913 be null and we should ignore this. I am not sure if this is really clean. Apparently,
22914 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
22915 which needs this to do its work.
22917 * ../errors/cs0066.cs : Add.
22919 2001-12-14 Miguel de Icaza <miguel@ximian.com>
22921 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
22924 * class.cs: (MethodSignature.MethodSignature): Removed hack that
22925 clears out the parameters field.
22926 (MemberSignatureCompare): Cleanup
22928 (MemberCore): New base class used to share code between MethodCore
22931 (RegisterRequiredImplementations) BindingFlags.Public requires
22932 either BindingFlags.Instace or Static. Use instance here.
22934 (Property): Refactored code to cope better with the full spec.
22936 * parameter.cs (GetParameterInfo): Return an empty array instead
22939 * class.cs (Property): Abstract or extern properties have no bodies.
22941 * parameter.cs (GetParameterInfo): return a zero-sized array.
22943 * class.cs (TypeContainer.MethodModifiersValid): Move all the
22944 method modifier validation to the typecontainer so we can reuse
22945 this on properties.
22947 (MethodCore.ParameterTypes): return an empty sized array of types.
22949 (Property.Define): Test property modifier validity.
22951 Add tests for sealed/override too.
22953 (Method.Emit): abstract or extern methods have no bodies.
22955 2001-12-14 Ravi Pratap <ravi@ximian.com>
22957 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
22960 (Method::Define, ::Emit): Modify accordingly.
22962 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
22964 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
22966 * makefile: Pass in /unsafe.
22968 2001-12-13 Miguel de Icaza <miguel@ximian.com>
22970 * class.cs (MakeKey): Kill routine.
22972 * class.cs (TypeContainer.Define): Correctly define explicit
22973 method implementations (they require the full interface name plus
22976 * typemanager.cs: Deply the PtrHashtable here and stop using the
22977 lame keys. Things work so much better.
22979 This of course broke everyone who depended on `RegisterMethod' to
22980 do the `test for existance' test. This has to be done elsewhere.
22982 * support.cs (PtrHashtable): A hashtable that avoid comparing with
22983 the object stupid Equals method (because, that like fails all over
22984 the place). We still do not use it.
22986 * class.cs (TypeContainer.SetRequiredInterface,
22987 TypeContainer.RequireMethods): Killed these two routines and moved
22988 all the functionality to RegisterRequiredImplementations.
22990 (TypeContainer.RegisterRequiredImplementations): This routine now
22991 registers all the implementations required in an array for the
22992 interfaces and abstract methods. We use an array of structures
22993 which can be computed ahead of time to reduce memory usage and we
22994 also assume that lookups are cheap as most classes will not
22995 implement too many interfaces.
22997 We also avoid creating too many MethodSignatures.
22999 (TypeContainer.IsInterfaceMethod): Update and optionally does not
23000 clear the "pending" bit if we find that there are problems with
23003 (TypeContainer.VerifyPendingMethods): Update to report errors of
23004 methods that look like implementations but are not.
23006 (TypeContainer.Define): Add support for explicit interface method
23009 2001-12-12 Miguel de Icaza <miguel@ximian.com>
23011 * typemanager.cs: Keep track of the parameters here instead of
23012 being a feature of the TypeContainer.
23014 * class.cs: Drop the registration of parameters here, as
23015 InterfaceMethods are also interface declarations.
23017 * delegate.cs: Register methods with the TypeManager not only with
23018 the TypeContainer. This code was buggy.
23020 * interface.cs: Full registation here.
23022 2001-12-11 Miguel de Icaza <miguel@ximian.com>
23024 * expression.cs: Remove reducer for binary expressions, it can not
23027 * const.cs: Put here the code that used to go into constant.cs
23029 * constant.cs: Put here the code for constants, this is a new base
23030 class for Literals.
23032 * literal.cs: Make Literal derive from Constant.
23034 2001-12-09 Miguel de Icaza <miguel@ximian.com>
23036 * statement.cs (Return.Emit): Report error 157 if the user
23037 attempts to return from a finally block.
23039 (Return.Emit): Instead of emitting a return, jump to the end of
23042 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
23043 LocalBuilder to store the result of the function. ReturnLabel is
23044 the target where we jump.
23047 2001-12-09 Radek Doulik <rodo@ximian.com>
23049 * cs-parser.jay: remember alias in current namespace
23051 * ecore.cs (SimpleName::DoResolve): use aliases for types or
23054 * class.cs (LookupAlias): lookup alias in my_namespace
23056 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
23058 (LookupAlias): lookup alias in this and if needed in parent
23061 2001-12-08 Miguel de Icaza <miguel@ximian.com>
23065 * rootcontext.cs: (ModuleBuilder) Made static, first step into
23066 making things static. I need this to avoid passing the
23067 TypeContainer when calling ParameterType.
23069 * support.cs (InternalParameters.ParameterType): Remove ugly hack
23070 that did string manipulation to compute the type and then call
23071 GetType. Use Parameter.ParameterType instead.
23073 * cs-tokenizer.cs: Consume the suffix for floating values.
23075 * expression.cs (ParameterReference): figure out whether this is a
23076 reference parameter or not. Kill an extra variable by computing
23077 the arg_idx during emission.
23079 * parameter.cs (Parameters.GetParameterInfo): New overloaded
23080 function that returns whether a parameter is an out/ref value or not.
23082 (Parameter.ParameterType): The type of the parameter (base,
23083 without ref/out applied).
23085 (Parameter.Resolve): Perform resolution here.
23086 (Parameter.ExternalType): The full type (with ref/out applied).
23088 * statement.cs (Using.Emit, Using.EmitExpression): Implement
23089 support for expressions on the using statement.
23091 2001-12-07 Miguel de Icaza <miguel@ximian.com>
23093 * statement.cs (Using.EmitLocalVariableDecls): Split the
23094 localvariable handling of the using statement.
23096 (Block.EmitMeta): Keep track of variable count across blocks. We
23097 were reusing slots on separate branches of blocks.
23099 (Try.Emit): Emit the general code block, we were not emitting it.
23101 Check the type of the declaration to be an IDisposable or
23102 something that can be implicity converted to it.
23104 Emit conversions if required.
23106 * ecore.cs (EmptyExpression): New utility class.
23107 (Expression.ImplicitConversionExists): New utility function.
23109 2001-12-06 Miguel de Icaza <miguel@ximian.com>
23111 * statement.cs (Using): Implement.
23113 * expression.cs (LocalVariableReference): Support read only variables.
23115 * statement.cs: Remove the explicit emit for the Leave opcode.
23116 (VariableInfo): Add a readonly field.
23118 2001-12-05 Miguel de Icaza <miguel@ximian.com>
23120 * ecore.cs (ConvCast): new class used to encapsulate the various
23121 explicit integer conversions that works in both checked and
23122 unchecked contexts.
23124 (Expression.ConvertNumericExplicit): Use new ConvCast class to
23125 properly generate the overflow opcodes.
23127 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23129 * statement.cs: The correct type for the EmptyExpression is the
23130 element_type, not the variable type. Ravi pointed this out.
23132 2001-12-04 Ravi Pratap <ravi@ximian.com>
23134 * class.cs (Method::Define): Handle PInvoke methods specially
23135 by using DefinePInvokeMethod instead of the usual one.
23137 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
23138 above to do the task of extracting information and defining the method.
23140 2001-12-04 Ravi Pratap <ravi@ximian.com>
23142 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
23143 of the condition for string type.
23145 (Emit): Move that here.
23147 (ArrayCreation::CheckIndices): Keep string literals in their expression
23150 (EmitDynamicInitializers): Handle strings appropriately.
23152 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23154 * codegen.cs (EmitContext): Replace multiple variables with a
23155 single pointer to the current Switch statement.
23157 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
23160 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23164 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
23167 (Foreach.Emit): Foreach on arrays was not setting
23168 up the loop variables (for break/continue).
23170 (GotoCase): Semi-implented.
23172 2001-12-03 Ravi Pratap <ravi@ximian.com>
23174 * attribute.cs (CheckAttribute): Handle system attributes by using
23175 Attribute.GetAttributes to examine information we need.
23177 (GetValidPlaces): Same here.
23179 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
23181 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
23183 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
23185 (Method::Define): Set appropriate flags if we have a DllImport attribute.
23187 (Method::Emit): Handle the case when we are a PInvoke method.
23189 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23191 * expression.cs: Use ResolveWithSimpleName on compound names.
23193 2001-12-02 Ravi Pratap <ravi@ximian.com>
23195 * constant.cs (EmitConstant): Make sure we resolve the associated expression
23196 before trying to reduce it.
23198 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
23200 * constant.cs (LookupConstantValue): Implement.
23202 (EmitConstant): Use the above in emitting the constant.
23204 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
23205 that are user-defined by doing a LookupConstantValue on them.
23207 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
23210 2001-11-29 Miguel de Icaza <miguel@ximian.com>
23212 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
23214 (BaseAccess.DoResolve): Implement.
23216 (MemberAccess.DoResolve): Split this routine into a
23217 ResolveMemberAccess routine that can be used independently
23219 2001-11-28 Miguel de Icaza <miguel@ximian.com>
23221 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
23222 As that share bits of the implementation. Is returns a boolean,
23223 while As returns the Type that is being probed.
23225 2001-12-01 Ravi Pratap <ravi@ximian.com>
23227 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
23228 instead of a Literal - much easier.
23230 (EnumInTransit): Remove - utterly useless :-)
23232 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
23234 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
23236 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
23237 chain when we have no associated expression.
23239 2001-11-30 Ravi Pratap <ravi@ximian.com>
23241 * constant.cs (Define): Use Location while reporting the errror.
23243 Also emit a warning when 'new' is used and there is no inherited
23246 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
23249 (LookupEnumValue): Implement to lookup an enum member's value and define it
23252 (Populate): Re-write accordingly to use the above routine.
23254 2001-11-27 Miguel de Icaza <miguel@ximian.com>
23256 * expression.cs (This): Fix prototype for DoResolveLValue to
23257 override the base class DoResolveLValue.
23259 * cs-parser.cs: Report errors cs574 and cs575 (destructor
23262 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
23263 (we need to load the address of the field here). This fixes
23266 (FieldExpr.DoResolveLValue): Call the DoResolve
23267 function to initialize the Instance expression.
23269 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
23270 correctly the GetEnumerator operation on a value type.
23272 * cs-parser.jay: Add more simple parsing error catches.
23274 * statement.cs (Switch): Add support for string switches.
23275 Handle null specially.
23277 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
23279 2001-11-28 Ravi Pratap <ravi@ximian.com>
23281 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
23283 (declare_local_constant): New helper function.
23285 * statement.cs (AddConstant): Keep a separate record of constants
23287 (IsConstant): Implement to determine if a variable is a constant.
23289 (GetConstantExpression): Implement.
23291 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
23293 * statement.cs (IsVariableDefined): Re-write.
23295 2001-11-27 Ravi Pratap <ravi@ximian.com>
23297 * class.cs (TypeContainer::FindMembers): Look for constants
23298 in the case when we are looking for MemberTypes.Field
23300 * expression.cs (MemberAccess::DoResolve): Check that in the
23301 case we are a FieldExpr and a Literal, we are not being accessed
23302 by an instance reference.
23304 * cs-parser.jay (local_constant_declaration): Implement.
23306 (declaration_statement): Implement for constant declarations.
23308 2001-11-26 Miguel de Icaza <miguel@ximian.com>
23310 * statement.cs (Switch): Catch double defaults.
23312 (Switch): More work on the switch() statement
23313 implementation. It works for integral values now, need to finish
23317 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23319 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
23320 integer literals into other integer literals. To be used by
23323 2001-11-24 Ravi Pratap <ravi@ximian.com>
23325 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
23328 (EmitDynamicInitializers): Cope with the above since we extract data
23329 directly from ArrayData now.
23331 (ExpectInitializers): Keep track of whether initializers are mandatory
23334 (Bounds): Make it a hashtable to prevent the same dimension being
23335 recorded for every element in that dimension.
23337 (EmitDynamicInitializers): Fix bug which prevented the Set array method
23340 Also fix bug which was causing the indices to be emitted in the reverse
23343 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23345 * expression.cs (ArrayCreation): Implement the bits that Ravi left
23346 unfinished. They do not work, because the underlying code is
23349 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23351 * cs-parser.jay: Remove bogus fixme.
23353 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
23354 on Switch statement.
23356 2001-11-23 Ravi Pratap <ravi@ximian.com>
23358 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
23361 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
23362 parameter. Apparently, any expression is allowed.
23364 (ValidateInitializers): Update accordingly.
23366 (CheckIndices): Fix some tricky bugs thanks to recursion.
23368 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
23369 I was being completely brain-dead.
23371 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
23372 and re-write acordingly.
23374 (DelegateInvocation): Re-write accordingly.
23376 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
23378 (MakeByteBlob): Handle types more correctly.
23380 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
23381 initialization from expressions but it is incomplete because I am a complete
23384 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23386 * statement.cs (If.Emit): Fix a bug that generated incorrect code
23387 on If. Basically, we have to return `true' (ie, we do return to
23388 our caller) only if both branches of the if return.
23390 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
23391 short-circuit operators, handle them as short circuit operators.
23393 (Cast.DoResolve): Resolve type.
23394 (Cast.Cast): Take an expression as the target type.
23396 * cs-parser.jay (cast_expression): Remove old hack that only
23397 allowed a limited set of types to be handled. Now we take a
23398 unary_expression and we resolve to a type during semantic
23401 Use the grammar productions from Rhys to handle casts (this is
23402 not complete like Rhys syntax yet, we fail to handle that corner
23403 case that C# has regarding (-x), but we will get there.
23405 2001-11-22 Ravi Pratap <ravi@ximian.com>
23407 * class.cs (EmitFieldInitializer): Take care of the case when we have a
23408 field which is an array type.
23410 * cs-parser.jay (declare_local_variables): Support array initialization too.
23412 * typemanager.cs (MakeKey): Implement.
23414 (everywhere): Use the above appropriately.
23416 * cs-parser.jay (for_statement): Update for array initialization while
23417 declaring variables.
23419 * ecore.cs : The error message was correct, it's the variable's names that
23420 were misleading ;-) Make the code more readable.
23422 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
23423 the correct type etc.
23425 (ConvertExplicit): Handle Enum types by examining the underlying type.
23427 2001-11-21 Ravi Pratap <ravi@ximian.com>
23429 * parameter.cs (GetCallingConvention): Always return
23430 CallingConventions.Standard for now.
23432 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23434 * expression.cs (Binary.ResolveOperator): Update the values of `l'
23435 and `r' after calling DoNumericPromotions.
23437 * ecore.cs: Fix error message (the types were in the wrong order).
23439 * statement.cs (Foreach.ProbeCollectionType): Need to pass
23440 BindingFlags.Instance as well
23442 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
23443 implicit int literal conversion in an empty cast so that we
23444 propagate the right type upstream.
23446 (UnboxCast): new class used to unbox value types.
23447 (Expression.ConvertExplicit): Add explicit type conversions done
23450 (Expression.ImplicitNumericConversion): Oops, forgot to test for
23451 the target type before applying the implicit LongLiterals to ULong
23454 2001-11-21 Miguel de Icaza <miguel@ximian.com>
23456 * cs-parser.jay (for_statement): Reworked the way For works: now
23457 we declare manually any variables that are introduced in
23458 for_initializer to solve the problem of having out-of-band code
23459 emition (that is what got for broken).
23461 (declaration_statement): Perform the actual variable declaration
23462 that used to be done in local_variable_declaration here.
23464 (local_variable_declaration): Do not declare anything, just pass
23465 the information on a DictionaryEntry
23467 2001-11-20 Ravi Pratap <ravi@ximian.com>
23469 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
23470 re-write of the logic to now make it recursive.
23472 (UpdateIndices): Re-write accordingly.
23474 Store element data in a separate ArrayData list in the above methods.
23476 (MakeByteBlob): Implement to dump the array data into a byte array.
23478 2001-11-19 Ravi Pratap <ravi@ximian.com>
23480 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
23483 * constant.cs (Define): Implement.
23485 (EmitConstant): Re-write fully.
23487 Pass in location info.
23489 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
23492 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
23493 DictionaryEntry since we need location info too.
23495 (constant_declaration): Update accordingly.
23497 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
23498 code into another method : UpdateIndices.
23500 2001-11-18 Ravi Pratap <ravi@ximian.com>
23502 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
23503 some type checking etc.
23505 2001-11-17 Ravi Pratap <ravi@ximian.com>
23507 * expression.cs (ArrayCreation::ValidateInitializers): Implement
23508 bits to provide dimension info if the user skips doing that.
23510 Update second constructor to store the rank correctly.
23512 2001-11-16 Ravi Pratap <ravi@ximian.com>
23514 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
23515 and try to implement.
23517 * ../errors/cs0150.cs : Add.
23519 * ../errors/cs0178.cs : Add.
23521 2001-11-16 Miguel de Icaza <miguel@ximian.com>
23523 * statement.cs: Implement foreach on multi-dimensional arrays.
23525 * parameter.cs (Parameters.GetParameterByName): Also lookup the
23526 name of the params argument.
23528 * expression.cs: Use EmitStoreOpcode to get the right opcode while
23529 initializing the array.
23531 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
23532 we can use this elsewhere.
23534 * statement.cs: Finish implementation of foreach for single
23537 * cs-parser.jay: Use an out-of-band stack to pass information
23538 around, I wonder why I need this.
23540 foreach_block: Make the new foreach_block the current_block.
23542 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
23543 function used to return a static Parameters structure. Used for
23544 empty parameters, as those are created very frequently.
23546 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
23548 2001-11-15 Ravi Pratap <ravi@ximian.com>
23550 * interface.cs : Default modifier is private, not public. The
23551 make verify test passes again.
23553 2001-11-15 Ravi Pratap <ravi@ximian.com>
23555 * support.cs (ReflectionParameters): Fix logic to determine
23556 whether the last parameter is a params one. Test 9 passes again.
23558 * delegate.cs (Populate): Register the builders we define with
23559 RegisterParameterForBuilder. Test 19 passes again.
23561 * cs-parser.jay (property_declaration): Reference $6 instead
23562 of $$ to get at the location.
23564 (indexer_declaration): Similar stuff.
23566 (attribute): Ditto.
23568 * class.cs (Property): Register parameters for the Get and Set methods
23569 if they exist. Test 23 passes again.
23571 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
23572 call to EmitArguments as we are sure there aren't any params arguments.
23573 Test 32 passes again.
23575 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
23576 IndexOutOfRangeException.
23578 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
23579 Test 33 now passes again.
23581 2001-11-15 Miguel de Icaza <miguel@ximian.com>
23583 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
23584 broke a bunch of things. Will have to come up with a better way
23585 of tracking locations.
23587 * statement.cs: Implemented foreach for single dimension arrays.
23589 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23591 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
23592 an error. This removes the lookup from the critical path.
23594 * cs-parser.jay: Removed use of temporary_loc, which is completely
23597 2001-11-14 Miguel de Icaza <miguel@ximian.com>
23599 * support.cs (ReflectionParameters.ParameterModifier): Report
23600 whether the argument is a PARAMS argument or not.
23602 * class.cs: Set the attribute `ParamArrayAttribute' on the
23603 parameter argument.
23605 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
23606 and cons_param_array_attribute (ConstructorInfo for
23607 ParamArrayAttribute).,
23609 * codegen.cs: Emit the return using the `Return' statement, that
23610 way we can report the error correctly for missing return values.
23612 * class.cs (Method.Emit): Clean up.
23614 * expression.cs (Argument.Resolve): Take another argument: the
23615 location where this argument is used. Notice that this is not
23616 part of the "Argument" class as to reduce the size of the
23617 structure (we know the approximate location anyways).
23619 Test if the argument is a variable-reference, if not, then
23620 complain with a 206.
23622 (Argument.Emit): Emit addresses of variables.
23624 (Argument.FullDesc): Simplify.
23626 (Invocation.DoResolve): Update for Argument.Resolve.
23628 (ElementAccess.DoResolve): ditto.
23630 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
23631 method should be virtual, as this method is always virtual.
23633 (NewDelegate.DoResolve): Update for Argument.Resolve.
23635 * class.cs (ConstructorInitializer.DoResolve): ditto.
23637 * attribute.cs (Attribute.Resolve): ditto.
23639 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23641 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
23643 * expression.cs (ParameterReference): Drop IStackStorage and implement
23644 IAssignMethod instead.
23646 (LocalVariableReference): ditto.
23648 * ecore.cs (FieldExpr): Drop IStackStorage and implement
23649 IAssignMethod instead.
23651 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23653 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
23654 enumerations that are used in heavily used structures derive from
23655 byte in a laughable and pathetic attempt to reduce memory usage.
23656 This is the kind of pre-optimzations that you should not do at
23657 home without adult supervision.
23659 * expression.cs (UnaryMutator): New class, used to handle ++ and
23660 -- separatedly from the other unary operators. Cleans up the
23661 code, and kills the ExpressionStatement dependency in Unary.
23663 (Unary): Removed `method' and `Arguments' from this class, making
23664 it smaller, and moving it all to SimpleCall, so I can reuse this
23665 code in other locations and avoid creating a lot of transient data
23666 strucutres when not required.
23668 * cs-parser.jay: Adjust for new changes.
23670 2001-11-11 Miguel de Icaza <miguel@ximian.com>
23672 * enum.cs (Enum.Populate): If there is a failure during
23675 * cs-parser.jay (opt_enum_base): we used to catch type errors
23676 here, but this is really incorrect. The type error should be
23677 catched during semantic analysis.
23679 2001-12-11 Ravi Pratap <ravi@ximian.com>
23681 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
23682 current_local_parameters as expected since I, in my stupidity, had forgotten
23685 * attribute.cs (GetValidPlaces): Fix stupid bug.
23687 * class.cs (Method::Emit): Perform check on applicability of attributes.
23689 (Constructor::Emit): Ditto.
23691 (Field::Emit): Ditto.
23693 (Field.Location): Store location information.
23695 (Property, Event, Indexer, Operator): Ditto.
23697 * cs-parser.jay (field_declaration): Pass in location for each field.
23699 * ../errors/cs0592.cs : Add.
23701 2001-11-12 Ravi Pratap <ravi@ximian.com>
23703 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
23705 (InitCoreTypes): Update accordingly.
23707 (RegisterAttrType, LookupAttr): Implement.
23709 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
23710 info about the same.
23712 (Resolve): Update to populate the above as necessary.
23714 (Error592): Helper.
23716 (GetValidPlaces): Helper to the above.
23718 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
23720 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
23722 2001-11-12 Ravi Pratap <ravi@ximian.com>
23724 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
23726 * ../errors/cs0617.cs : Add.
23728 2001-11-11 Ravi Pratap <ravi@ximian.com>
23730 * enum.cs (Emit): Rename to Populate to be more consistent with what
23731 we expect it to do and when exactly it is called.
23733 * class.cs, rootcontext.cs : Update accordingly.
23735 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
23736 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
23738 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
23740 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
23741 of a fieldinfo using the above, when dealing with a FieldBuilder.
23743 2001-11-10 Ravi Pratap <ravi@ximian.com>
23745 * ../errors/cs0031.cs : Add.
23747 * ../errors/cs1008.cs : Add.
23749 * ../errrors/cs0543.cs : Add.
23751 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
23754 (FindMembers): Implement.
23756 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
23757 enums and delegates too.
23759 (enum_types): Rename to builder_to_enum.
23761 (delegate_types): Rename to builder_to_delegate.
23763 * delegate.cs (FindMembers): Implement.
23765 2001-11-09 Ravi Pratap <ravi@ximian.com>
23767 * typemanager.cs (IsEnumType): Implement.
23769 * enum.cs (Emit): Re-write parts to account for the underlying type
23770 better and perform checking etc.
23772 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
23773 of the underlying type.
23775 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
23778 * enum.cs (error31): Helper to report error #31.
23780 * cs-parser.jay (enum_declaration): Store location of each member too.
23782 * enum.cs (member_to_location): New hashtable.
23784 (AddEnumMember): Update location hashtable.
23786 (Emit): Use the location of each member while reporting errors.
23788 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23790 * cs-parser.jay: A for_initializer if is a
23791 local_variable_declaration really ammount to have an implicit
23792 block with the variable declaration and no initializer for for.
23794 * statement.cs (For.Emit): Cope with null initializers.
23796 This fixes the infinite loop on for initializers.
23798 2001-11-08 Miguel de Icaza <miguel@ximian.com>
23800 * enum.cs: More cleanup.
23802 * ecore.cs: Remove dead code.
23804 * class.cs (Property.Emit): More simplification.
23805 (Event.Emit): ditto.
23807 Reworked to have less levels of indentation.
23809 2001-11-08 Ravi Pratap <ravi@ximian.com>
23811 * class.cs (Property): Emit attributes.
23821 * enum.cs (Emit): Ditto.
23823 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
23826 * class.cs (Field, Event, etc.): Move attribute generation into the
23827 Emit method everywhere.
23829 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
23830 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
23831 as we had no way of defining nested enums !
23833 * rootcontext.cs : Adjust code accordingly.
23835 * typemanager.cs (AddEnumType): To keep track of enum types separately.
23837 2001-11-07 Ravi Pratap <ravi@ximian.com>
23839 * expression.cs (EvalConstantExpression): Move into ecore.cs
23841 * enum.cs (Enum): Rename some members and make them public and readonly
23842 according to our convention.
23844 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
23847 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
23849 (Enum::Emit): Write a simple version for now which doesn't try to compute
23850 expressions. I shall modify this to be more robust in just a while.
23852 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
23854 (TypeContainer::CloseType): Create the Enum types too.
23856 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
23858 * expression.cs (EvalConstantExpression): Get rid of completely.
23860 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
23861 user-defined values and other cases.
23863 (IsValidEnumLiteral): Helper function.
23865 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
23866 out there in the case we had a literal FieldExpr.
23868 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
23870 (Literalize): Revamp a bit to take two arguments.
23872 (EnumLiteral): New class which derives from Literal to wrap enum literals.
23874 2001-11-06 Ravi Pratap <ravi@ximian.com>
23876 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
23878 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
23880 (Resolve): Use the above to ensure we have proper initializers.
23882 2001-11-05 Ravi Pratap <ravi@ximian.com>
23884 * expression.cs (Expression::EvalConstantExpression): New method to
23885 evaluate constant expressions.
23887 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
23889 2001-11-07 Miguel de Icaza <miguel@ximian.com>
23891 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
23894 (Binary.ResolveOperator): Handle operator != (object a, object b)
23895 and operator == (object a, object b);
23897 (Binary.DoNumericPromotions): Indicate whether the numeric
23898 promotion was possible.
23900 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
23903 Made the ArrayAccess implement interface IAssignMethod instead of
23904 IStackStore as the order in which arguments are passed reflects
23907 * assign.cs: Instead of using expr.ExprClass to select the way of
23908 assinging, probe for the IStackStore/IAssignMethod interfaces.
23910 * typemanager.cs: Load InitializeArray definition.
23912 * rootcontext.cs (RootContext.MakeStaticData): Used to define
23913 static data that can be used to initialize arrays.
23915 2001-11-05 Miguel de Icaza <miguel@ximian.com>
23917 * expression.cs: Handle operator== and operator!= for booleans.
23919 (Conditioal.Reduce): Implement reducer for the ?: operator.
23921 (Conditional.Resolve): Implement dead code elimination.
23923 (Binary.Resolve): Catch string literals and return a new
23924 concatenated string.
23926 (Unary.Reduce): Implement reduction of unary expressions.
23928 * ecore.cs: Split out the expression core handling here.
23930 (Expression.Reduce): New method used to perform constant folding
23931 and CSE. This is needed to support constant-expressions.
23933 * statement.cs (Statement.EmitBoolExpression): Pass true and false
23934 targets, and optimize for !x.
23936 2001-11-04 Ravi Pratap <ravi@ximian.com>
23938 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
23939 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
23940 set custom atttributes.
23942 * literal.cs (Literal::GetValue): New abstract method to return the actual
23943 value of the literal, cast as an object.
23945 (*Literal): Implement GetValue method.
23947 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
23948 expressions to the arraylist but objects of type Argument.
23950 * class.cs (TypeContainer::Emit): Emit our attributes too.
23952 (Method::Emit, Constructor::Emit): Ditto.
23954 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
23955 to be ignoring earlier.
23957 2001-11-03 Ravi Pratap <ravi@ximian.com>
23959 * attribute.cs (AttributeSection::Define): Implement to do the business
23960 of constructing a CustomAttributeBuilder.
23962 (Attribute): New trivial class. Increases readability of code.
23964 * cs-parser.jay : Update accordingly.
23966 (positional_argument_list, named_argument_list, named_argument): New rules
23968 (attribute_arguments): Use the above so that we are more correct.
23970 2001-11-02 Ravi Pratap <ravi@ximian.com>
23972 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
23973 to perform all checks for a method with a params parameter.
23975 (Invocation::OverloadResolve): Update to use the above method and therefore
23976 cope correctly with params method invocations.
23978 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
23981 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
23982 constructors in our parent too because we can't afford to miss out on
23985 * attribute.cs (AttributeSection): New name for the class Attribute
23987 Other trivial changes to improve readability.
23989 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
23990 use the new class names.
23992 2001-11-01 Ravi Pratap <ravi@ximian.com>
23994 * class.cs (Method::Define): Complete definition for params types too
23996 (Indexer::Define): Ditto.
23998 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
23999 Cope everywhere with a request for info about the array parameter.
24001 2001-11-01 Ravi Pratap <ravi@ximian.com>
24003 * tree.cs (RecordNamespace): Fix up to check for the correct key.
24005 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
24006 local_variable_type to extract the string corresponding to the type.
24008 (local_variable_type): Fixup the action to use the new helper method.
24010 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
24013 * expression.cs : Clean out code which uses the above.
24015 2001-10-31 Ravi Pratap <ravi@ximian.com>
24017 * typemanager.cs (RegisterMethod): Check if we already have an existing key
24018 and bale out if necessary by returning a false.
24020 (RegisterProperty): Ditto.
24022 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
24023 and print out appropriate error messages.
24025 * interface.cs (everywhere): Ditto.
24027 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
24028 location to constructor.
24030 * class.cs (Property, Event, Indexer): Update accordingly.
24032 * ../errors/cs111.cs : Added.
24034 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
24035 of a method, as laid down by the spec.
24037 (Invocation::OverloadResolve): Use the above method.
24039 2001-10-31 Ravi Pratap <ravi@ximian.com>
24041 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
24042 now take a TypeContainer and a Parameters object.
24044 (ParameterData): Modify return type of ParameterModifier method to be
24045 Parameter.Modifier and not a string.
24047 (ReflectionParameters, InternalParameters): Update accordingly.
24049 * expression.cs (Argument::GetParameterModifier): Same here.
24051 * support.cs (InternalParameters::ParameterType): Find a better way of determining
24052 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
24053 symbol in it at all so maybe this is only for now.
24055 2001-10-30 Ravi Pratap <ravi@ximian.com>
24057 * support.cs (InternalParameters): Constructor now takes an extra argument
24058 which is the actual Parameters class.
24060 (ParameterDesc): Update to provide info on ref/out modifiers.
24062 * class.cs (everywhere): Update call to InternalParameters to pass in
24063 the second argument too.
24065 * support.cs (ParameterData): Add ParameterModifier, which is a method
24066 to return the modifier info [ref/out etc]
24068 (InternalParameters, ReflectionParameters): Implement the above.
24070 * expression.cs (Argument::ParameterModifier): Similar function to return
24071 info about the argument's modifiers.
24073 (Invocation::OverloadResolve): Update to take into account matching modifiers
24076 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
24077 a new SetFormalParameters object which we pass to InternalParameters.
24079 2001-10-30 Ravi Pratap <ravi@ximian.com>
24081 * expression.cs (NewArray): Merge into the ArrayCreation class.
24083 2001-10-29 Ravi Pratap <ravi@ximian.com>
24085 * expression.cs (NewArray): Merge classes NewBuiltinArray and
24086 NewUserdefinedArray into one as there wasn't much of a use in having
24089 * expression.cs (Argument): Change field's name to ArgType from Type.
24091 (Type): New readonly property which returns the proper type, taking into
24092 account ref/out modifiers.
24094 (everywhere): Adjust code accordingly for the above.
24096 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
24097 whether we are emitting for a ref or out parameter.
24099 * expression.cs (Argument::Emit): Use the above field to set the state.
24101 (LocalVariableReference::Emit): Update to honour the flag and emit the
24104 * parameter.cs (Attributes): Set the correct flags for ref parameters.
24106 * expression.cs (Argument::FullDesc): New function to provide a full desc.
24108 * support.cs (ParameterData): Add method ParameterDesc to the interface.
24110 (ReflectionParameters, InternalParameters): Implement the above method.
24112 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
24115 (Invocation::FullMethodDesc): Ditto.
24117 2001-10-29 Miguel de Icaza <miguel@ximian.com>
24119 * cs-parser.jay: Add extra production for the second form of array
24122 * expression.cs (ArrayCreation): Update to reflect the above
24125 * Small changes to prepare for Array initialization.
24127 2001-10-28 Miguel de Icaza <miguel@ximian.com>
24129 * typemanager.cs (ImplementsInterface): interface might be null;
24130 Deal with this problem;
24132 Also, we do store negative hits on the cache (null values), so use
24133 this instead of calling t.GetInterfaces on the type everytime.
24135 2001-10-28 Ravi Pratap <ravi@ximian.com>
24137 * typemanager.cs (IsBuiltinType): New method to help determine the same.
24139 * expression.cs (New::DoResolve): Get rid of array creation code and instead
24140 split functionality out into different classes.
24142 (New::FormArrayType): Move into NewBuiltinArray.
24144 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
24147 (NewBuiltinArray): New class to handle creation of built-in arrays.
24149 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
24150 account creation of one-dimensional arrays.
24152 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
24154 (NewUserdefinedArray::DoResolve): Implement.
24156 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
24158 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
24159 we maintain inside the TypeManager. This is necessary to perform lookups on the
24162 (LookupType): Update to perform GetType on the module builders too.
24164 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
24166 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
24168 2001-10-23 Ravi Pratap <ravi@ximian.com>
24170 * expression.cs (New::DoResolve): Implement guts of array creation.
24172 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
24174 2001-10-27 Miguel de Icaza <miguel@ximian.com>
24176 * expression.cs: Fix bug I introduced lsat night that broke
24179 (Expression.Resolve): Report a 246 error (can not resolve name)
24180 if we find a SimpleName in the stream.
24182 (Expression.ResolveLValue): Ditto.
24184 (Expression.ResolveWithSimpleName): This function is a variant of
24185 ResolveName, this one allows SimpleNames to be returned without a
24186 warning. The only consumer of SimpleNames is MemberAccess
24188 2001-10-26 Miguel de Icaza <miguel@ximian.com>
24190 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
24191 might arrive here. I have my doubts that this is correct.
24193 * statement.cs (Lock): Implement lock statement.
24195 * cs-parser.jay: Small fixes to support `lock' and `using'
24197 * cs-tokenizer.cs: Remove extra space
24199 * driver.cs: New flag --checked, allows to turn on integer math
24202 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
24203 Threading.Monitor.Exit
24205 2001-10-23 Miguel de Icaza <miguel@ximian.com>
24207 * expression.cs (IndexerAccess::DoResolveLValue): Set the
24208 Expression Class to be IndexerAccess.
24210 Notice that Indexer::DoResolve sets the eclass to Value.
24212 2001-10-22 Miguel de Icaza <miguel@ximian.com>
24214 * class.cs (TypeContainer::Emit): Emit code for indexers.
24216 * assign.cs (IAssignMethod): New interface implemented by Indexers
24217 and Properties for handling assignment.
24219 (Assign::Emit): Simplify and reuse code.
24221 * expression.cs (IndexerAccess, PropertyExpr): Implement
24222 IAssignMethod, clean up old code.
24224 2001-10-22 Ravi Pratap <ravi@ximian.com>
24226 * typemanager.cs (ImplementsInterface): New method to determine if a type
24227 implements a given interface. Provides a nice cache too.
24229 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
24232 (ConvertReferenceExplicit): Ditto.
24234 * delegate.cs (Delegate::Populate): Update to define the parameters on the
24235 various methods, with correct names etc.
24237 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
24238 Operator.UnaryNegation.
24240 * cs-parser.jay (operator_declarator): Be a little clever in the case where
24241 we have a unary plus or minus operator.
24243 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
24246 * everywhere : update accordingly.
24248 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
24251 * class.cs (Method::Define): For the case where we are implementing a method
24252 inherited from an interface, we need to set the MethodAttributes.Final flag too.
24253 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
24255 2001-10-21 Ravi Pratap <ravi@ximian.com>
24257 * interface.cs (FindMembers): Implement to work around S.R.E
24260 * typemanager.cs (IsInterfaceType): Implement.
24262 (FindMembers): Update to handle interface types too.
24264 * expression.cs (ImplicitReferenceConversion): Re-write bits which
24265 use IsAssignableFrom as that is not correct - it doesn't work.
24267 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
24268 and accordingly override EmitStatement.
24270 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
24271 using the correct logic :-)
24273 2001-10-19 Ravi Pratap <ravi@ximian.com>
24275 * ../errors/cs-11.cs : Add to demonstrate error -11
24277 2001-10-17 Miguel de Icaza <miguel@ximian.com>
24279 * assign.cs (Assign::Resolve): Resolve right hand side first, and
24280 then pass this as a hint to ResolveLValue.
24282 * expression.cs (FieldExpr): Add Location information
24284 (FieldExpr::LValueResolve): Report assignment to readonly
24287 (Expression::ExprClassFromMemberInfo): Pass location information.
24289 (Expression::ResolveLValue): Add new method that resolves an
24292 (Expression::DoResolveLValue): Default invocation calls
24295 (Indexers): New class used to keep track of indexers in a given
24298 (IStackStore): Renamed from LValue, as it did not really describe
24299 what this did. Also ResolveLValue is gone from this interface and
24300 now is part of Expression.
24302 (ElementAccess): Depending on the element access type
24304 * typemanager.cs: Add `indexer_name_type' as a Core type
24305 (System.Runtime.CompilerServices.IndexerNameAttribute)
24307 * statement.cs (Goto): Take a location.
24309 2001-10-18 Ravi Pratap <ravi@ximian.com>
24311 * delegate.cs (Delegate::VerifyDelegate): New method to verify
24312 if two delegates are compatible.
24314 (NewDelegate::DoResolve): Update to take care of the case when
24315 we instantiate a delegate from another delegate.
24317 * typemanager.cs (FindMembers): Don't even try to look up members
24318 of Delegate types for now.
24320 2001-10-18 Ravi Pratap <ravi@ximian.com>
24322 * delegate.cs (NewDelegate): New class to take care of delegate
24325 * expression.cs (New): Split the delegate related code out into
24326 the NewDelegate class.
24328 * delegate.cs (DelegateInvocation): New class to handle delegate
24331 * expression.cs (Invocation): Split out delegate related code into
24332 the DelegateInvocation class.
24334 2001-10-17 Ravi Pratap <ravi@ximian.com>
24336 * expression.cs (New::DoResolve): Implement delegate creation fully
24337 and according to the spec.
24339 (New::DoEmit): Update to handle delegates differently.
24341 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
24342 because of which we were printing out arguments in reverse order !
24344 * delegate.cs (VerifyMethod): Implement to check if the given method
24345 matches the delegate.
24347 (FullDelegateDesc): Implement.
24349 (VerifyApplicability): Implement.
24351 * expression.cs (Invocation::DoResolve): Update to accordingly handle
24352 delegate invocations too.
24354 (Invocation::Emit): Ditto.
24356 * ../errors/cs1593.cs : Added.
24358 * ../errors/cs1594.cs : Added.
24360 * delegate.cs (InstanceExpression, TargetMethod): New properties.
24362 2001-10-16 Ravi Pratap <ravi@ximian.com>
24364 * typemanager.cs (intptr_type): Core type for System.IntPtr
24366 (InitCoreTypes): Update for the same.
24368 (iasyncresult_type, asynccallback_type): Ditto.
24370 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
24373 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
24376 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
24377 the builders for the 4 members of a delegate type :-)
24379 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
24382 * expression.cs (New::DoResolve): Implement guts for delegate creation.
24384 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
24386 2001-10-15 Miguel de Icaza <miguel@ximian.com>
24388 * statement.cs (Break::Emit): Implement.
24389 (Continue::Emit): Implement.
24391 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
24392 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
24393 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
24394 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
24397 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
24398 properties that track the label for the current loop (begin of the
24399 loop and end of the loop).
24401 2001-10-15 Ravi Pratap <ravi@ximian.com>
24403 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
24404 use of emitting anything at all.
24406 * class.cs, rootcontext.cs : Get rid of calls to the same.
24408 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
24410 (Populate): Define the constructor correctly and set the implementation
24413 * typemanager.cs (delegate_types): New hashtable to hold delegates that
24416 (AddDelegateType): Implement.
24418 (IsDelegateType): Implement helper method.
24420 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
24422 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
24423 and accordingly handle it.
24425 * delegate.cs (Populate): Take TypeContainer argument.
24426 Implement bits to define the Invoke method. However, I still haven't figured out
24427 how to take care of the native int bit :-(
24429 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
24430 Qualify the name of the delegate, not its return type !
24432 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
24435 (StandardConversionExists): Checking for array types turns out to be recursive.
24437 (ConvertReferenceExplicit): Implement array conversion.
24439 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
24441 2001-10-12 Ravi Pratap <ravi@ximian.com>
24443 * cs-parser.jay (delegate_declaration): Store the fully qualified
24444 name as it is a type declaration.
24446 * delegate.cs (ReturnType, Name): Rename members to these. Make them
24449 (DefineDelegate): Renamed from Define. Does the same thing essentially,
24450 as TypeContainer::DefineType.
24452 (Populate): Method in which all the definition of the various methods (Invoke)
24455 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
24458 (CloseDelegate): Finally creates the delegate.
24460 * class.cs (TypeContainer::DefineType): Update to define delegates.
24461 (Populate, Emit and CloseType): Do the same thing here too.
24463 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
24464 delegates in all these operations.
24466 2001-10-14 Miguel de Icaza <miguel@ximian.com>
24468 * expression.cs: LocalTemporary: a new expression used to
24469 reference a temporary that has been created.
24471 * assign.cs: Handle PropertyAccess back here, so that we can
24472 provide the proper semantic access to properties.
24474 * expression.cs (Expression::ConvertReferenceExplicit): Implement
24475 a few more explicit conversions.
24477 * modifiers.cs: `NEW' modifier maps to HideBySig.
24479 * expression.cs (PropertyExpr): Make this into an
24480 ExpressionStatement, and support the EmitStatement code path.
24482 Perform get/set error checking, clean up the interface.
24484 * assign.cs: recognize PropertyExprs as targets, and if so, turn
24485 them into toplevel access objects.
24487 2001-10-12 Miguel de Icaza <miguel@ximian.com>
24489 * expression.cs: PropertyExpr::PropertyExpr: use work around the
24492 * typemanager.cs: Keep track here of our PropertyBuilders again to
24493 work around lameness in SRE.
24495 2001-10-11 Miguel de Icaza <miguel@ximian.com>
24497 * expression.cs (LValue::LValueResolve): New method in the
24498 interface, used to perform a second resolution pass for LValues.
24500 (This::DoResolve): Catch the use of this in static methods.
24502 (This::LValueResolve): Implement.
24504 (This::Store): Remove warning, assigning to `this' in structures
24507 (Invocation::Emit): Deal with invocation of
24508 methods on value types. We need to pass the address to structure
24509 methods rather than the object itself. (The equivalent code to
24510 emit "this" for structures leaves the entire structure on the
24511 stack instead of a pointer to it).
24513 (ParameterReference::DoResolve): Compute the real index for the
24514 argument based on whether the method takes or not a `this' pointer
24515 (ie, the method is static).
24517 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
24518 value types returned from functions when we need to invoke a
24519 method on the sturcture.
24522 2001-10-11 Ravi Pratap <ravi@ximian.com>
24524 * class.cs (TypeContainer::DefineType): Method to actually do the business of
24525 defining the type in the Modulebuilder or Typebuilder. This is to take
24526 care of nested types which need to be defined on the TypeBuilder using
24527 DefineNestedMethod.
24529 (TypeContainer::GetClassBases): Implement. Essentially the code from the
24530 methods in RootContext, only ported to be part of TypeContainer.
24532 (TypeContainer::GetInterfaceOrClass): Ditto.
24534 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
24536 * interface.cs (Interface::DefineInterface): New method. Does exactly
24537 what RootContext.CreateInterface did earlier, only it takes care of nested types
24540 (Interface::GetInterfaces): Move from RootContext here and port.
24542 (Interface::GetInterfaceByName): Same here.
24544 * rootcontext.cs (ResolveTree): Re-write.
24546 (PopulateTypes): Re-write.
24548 * class.cs (TypeContainer::Populate): Populate nested types too.
24549 (TypeContainer::Emit): Emit nested members too.
24551 * typemanager.cs (AddUserType): Do not make use of the FullName property,
24552 instead just use the name argument passed in as it is already fully
24555 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
24556 to TypeContainer mapping to see if a type is user-defined.
24558 * class.cs (TypeContainer::CloseType): Implement.
24560 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
24561 the default constructor.
24563 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
24566 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
24568 * interface.cs (CloseType): Create the type here.
24570 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
24573 Remove all the methods which are now in TypeContainer.
24575 2001-10-10 Ravi Pratap <ravi@ximian.com>
24577 * delegate.cs (Define): Re-write bits to define the delegate
24580 2001-10-10 Miguel de Icaza <miguel@ximian.com>
24582 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
24584 * expression.cs (ImplicitReferenceConversion): handle null as well
24585 as a source to convert to any reference type.
24587 * statement.cs (Return): Perform any implicit conversions to
24588 expected return type.
24590 Validate use of return statement.
24592 * codegen.cs (EmitContext): Pass the expected return type here.
24594 * class.cs (Method, Constructor, Property): Pass expected return
24595 type to EmitContext.
24597 2001-10-09 Miguel de Icaza <miguel@ximian.com>
24599 * expression.cs: Make DoResolve take an EmitContext instead of a
24602 Replaced `l' and `location' for `loc', for consistency.
24604 (Error, Warning): Remove unneeded Tc argument.
24606 * assign.cs, literal.cs, constant.cs: Update to new calling
24609 * codegen.cs: EmitContext now contains a flag indicating whether
24610 code is being generated in a static method or not.
24612 * cs-parser.jay: DecomposeQI, new function that replaces the old
24613 QualifiedIdentifier. Now we always decompose the assembled
24614 strings from qualified_identifier productions into a group of
24617 2001-10-08 Miguel de Icaza <miguel@ximian.com>
24619 * rootcontext.cs: Deal with field-less struct types correctly now
24620 by passing the size option to Define Type.
24622 * class.cs: Removed hack that created one static field.
24624 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24626 * statement.cs: Moved most of the code generation here.
24628 2001-10-09 Ravi Pratap <ravi@ximian.com>
24630 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
24633 (ElementAccess): Remove useless bits for now - keep checks as the spec
24636 2001-10-08 Ravi Pratap <ravi@ximian.com>
24638 * expression.cs (ElementAccess::DoResolve): Remove my crap code
24639 and start performing checks according to the spec.
24641 2001-10-07 Ravi Pratap <ravi@ximian.com>
24643 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
24644 rank_specifiers instead.
24646 (rank_specifiers): Change the order in which the rank specifiers are stored
24648 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
24650 * expression.cs (ElementAccess): Implement the LValue interface too.
24652 2001-10-06 Ravi Pratap <ravi@ximian.com>
24654 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
24655 except that user defined conversions are not included.
24657 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
24658 perform the conversion of the return type, if necessary.
24660 (New::DoResolve): Check whether we are creating an array or an object
24661 and accordingly do the needful.
24663 (New::Emit): Same here.
24665 (New::DoResolve): Implement guts of array creation.
24667 (New::FormLookupType): Helper function.
24669 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24671 * codegen.cs: Removed most of the code generation here, and move the
24672 corresponding code generation bits to the statement classes.
24674 Added support for try/catch/finalize and throw.
24676 * cs-parser.jay: Added support for try/catch/finalize.
24678 * class.cs: Catch static methods having the flags override,
24679 virtual or abstract.
24681 * expression.cs (UserCast): This user cast was not really doing
24682 what it was supposed to do. Which is to be born in fully resolved
24683 state. Parts of the resolution were being performed at Emit time!
24687 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24689 * expression.cs: Implicity convert the result from UserCast.
24691 2001-10-05 Ravi Pratap <ravi@ximian.com>
24693 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
24694 prevented it from working correctly.
24696 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
24697 merely ConvertImplicit.
24699 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24701 * typemanager.cs: Make the LookupTypeContainer function static,
24702 and not per-instance.
24704 * class.cs: Make static FindMembers (the one that takes a Type
24707 * codegen.cs: Add EmitForeach here.
24709 * cs-parser.jay: Make foreach a toplevel object instead of the
24710 inline expansion, as we need to perform semantic analysis on it.
24712 2001-10-05 Ravi Pratap <ravi@ximian.com>
24714 * expression.cs (Expression::ImplicitUserConversion): Rename to
24715 UserDefinedConversion.
24717 (Expression::UserDefinedConversion): Take an extra argument specifying
24718 whether we look for explicit user conversions too.
24720 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
24722 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
24724 (ExplicitUserConversion): Make it a call to UserDefinedConversion
24725 with the appropriate arguments.
24727 * cs-parser.jay (cast_expression): Record location too.
24729 * expression.cs (Cast): Record location info.
24731 (Expression::ConvertExplicit): Take location argument.
24733 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
24734 to determine if we are doing explicit conversions.
24736 (UserCast::Emit): Update accordingly.
24738 (Expression::ConvertExplicit): Report an error if everything fails.
24740 * ../errors/cs0030.cs : Add.
24742 2001-10-04 Miguel de Icaza <miguel@ximian.com>
24744 * modifiers.cs: If the ABSTRACT keyword is present, also set the
24745 virtual and newslot bits.
24747 * class.cs (TypeContainer::RegisterRequiredImplementations):
24748 Record methods we need.
24750 (TypeContainer::MakeKey): Helper function to make keys for
24751 MethodBases, since the Methodbase key is useless.
24753 (TypeContainer::Populate): Call RegisterRequiredImplementations
24754 before defining the methods.
24756 Create a mapping for method_builders_to_methods ahead of time
24757 instead of inside a tight loop.
24759 (::RequireMethods): Accept an object as the data to set into the
24760 hashtable so we can report interface vs abstract method mismatch.
24762 2001-10-03 Miguel de Icaza <miguel@ximian.com>
24764 * report.cs: Make all of it static.
24766 * rootcontext.cs: Drop object_type and value_type computations, as
24767 we have those in the TypeManager anyways.
24769 Drop report instance variable too, now it is a global.
24771 * driver.cs: Use try/catch on command line handling.
24773 Add --probe option to debug the error reporting system with a test
24776 * report.cs: Add support for exiting program when a probe
24777 condition is reached.
24779 2001-10-03 Ravi Pratap <ravi@ximian.com>
24781 * expression.cs (Binary::DoNumericPromotions): Fix the case when
24782 we do a forcible conversion regardless of type, to check if
24783 ForceConversion returns a null.
24785 (Binary::error19): Use location to report error.
24787 (Unary::error23): Use location here too.
24789 * ../errors/cs0019.cs : Check in.
24791 * ../errors/cs0023.cs : Check in.
24793 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
24794 case of a non-null MethodInfo object with a length of 0 !
24796 (Binary::ResolveOperator): Flag error if overload resolution fails to find
24797 an applicable member - according to the spec :-)
24798 Also fix logic to find members in base types.
24800 (Unary::ResolveOperator): Same here.
24802 (Unary::report23): Change name to error23 and make first argument a TypeContainer
24803 as I was getting thoroughly confused between this and error19 :-)
24805 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
24806 (::FindMostEncompassedType): Implement.
24807 (::FindMostEncompassingType): Implement.
24808 (::StandardConversionExists): Implement.
24810 (UserImplicitCast): Re-vamp. We now need info about most specific
24811 source and target types so that we can do the necessary conversions.
24813 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
24814 mathematical union with no duplicates.
24816 2001-10-03 Miguel de Icaza <miguel@ximian.com>
24818 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
24819 in order from base classes to child classes, so that we can in
24820 child classes look up in our parent for method names and
24821 attributes (required for handling abstract, virtual, new, override
24822 constructs: we need to instrospect our base class, and if we dont
24823 populate the classes in order, the introspection might be
24824 incorrect. For example, a method could query its parent before
24825 the parent has any methods and would determine that the parent has
24826 no abstract methods (while it could have had them)).
24828 (RootContext::CreateType): Record the order in which we define the
24831 2001-10-02 Miguel de Icaza <miguel@ximian.com>
24833 * class.cs (TypeContainer::Populate): Also method definitions can
24834 fail now, keep track of this.
24836 (TypeContainer::FindMembers): Implement support for
24837 DeclaredOnly/noDeclaredOnly flag.
24839 (Constructor::Emit) Return the ConstructorBuilder.
24841 (Method::Emit) Return the MethodBuilder.
24842 Check for abstract or virtual methods to be public.
24844 * rootcontext.cs (RootContext::CreateType): Register all the
24845 abstract methods required for the class to be complete and the
24846 interface methods that must be implemented.
24848 * cs-parser.jay: Report error 501 (method requires body if it is
24849 not marked abstract or extern).
24851 * expression.cs (TypeOf::Emit): Implement.
24853 * typemanager.cs: runtime_handle_type, new global type.
24855 * class.cs (Property::Emit): Generate code for properties.
24857 2001-10-02 Ravi Pratap <ravi@ximian.com>
24859 * expression.cs (Unary::ResolveOperator): Find operators on base type
24860 too - we now conform exactly to the spec.
24862 (Binary::ResolveOperator): Same here.
24864 * class.cs (Operator::Define): Fix minor quirk in the tests.
24866 * ../errors/cs0215.cs : Added.
24868 * ../errors/cs0556.cs : Added.
24870 * ../errors/cs0555.cs : Added.
24872 2001-10-01 Miguel de Icaza <miguel@ximian.com>
24874 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
24875 single integer which is really efficient
24877 2001-10-01 Ravi Pratap <ravi@ximian.com>
24879 * expression.cs (Expression::ImplicitUserConversion): Use location
24880 even in the case when we are examining True operators.
24882 * class.cs (Operator::Define): Perform extensive checks to conform
24883 with the rules for operator overloading in the spec.
24885 * expression.cs (Expression::ImplicitReferenceConversion): Implement
24886 some of the other conversions mentioned in the spec.
24888 * typemanager.cs (array_type): New static member for the System.Array built-in
24891 (cloneable_interface): For System.ICloneable interface.
24893 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
24894 we start resolving the tree and populating types.
24896 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
24898 2001-10-01 Miguel de Icaza <miguel@ximian.com>
24900 * expression.cs (Expression::ExprClassFromMemberInfo,
24901 Expression::Literalize): Create literal expressions from
24902 FieldInfos which are literals.
24904 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
24905 type casts, because they were wrong. The test suite in tests
24908 (ImplicitNumericConversion): ushort to ulong requires a widening
24911 Int32 constant to long requires widening cast as well.
24913 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
24914 for integers because the type on the stack is not i4.
24916 2001-09-30 Miguel de Icaza <miguel@ximian.com>
24918 * expression.cs (report118): require location argument.
24920 * parameter.cs: Do not dereference potential null value.
24922 * class.cs: Catch methods that lack the `new' keyword when
24923 overriding a name. Report warnings when `new' is used without
24924 anything being there to override.
24926 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
24928 * class.cs: Only add constructor to hashtable if it is non-null
24929 (as now constructors can fail on define).
24931 (TypeManager, Class, Struct): Take location arguments.
24933 Catch field instance initialization in structs as errors.
24935 accepting_filter: a new filter for FindMembers that is static so
24936 that we dont create an instance per invocation.
24938 (Constructor::Define): Catch errors where a struct constructor is
24941 * cs-parser.jay: Pass location information for various new
24944 * delegate.cs (Delegate): take a location argument.
24946 * driver.cs: Do not call EmitCode if there were problesm in the
24947 Definition of the types, as many Builders wont be there.
24949 * decl.cs (Decl::Decl): Require a location argument.
24951 * cs-tokenizer.cs: Handle properly hex constants that can not fit
24952 into integers, and find the most appropiate integer for it.
24954 * literal.cs: Implement ULongLiteral.
24956 * rootcontext.cs: Provide better information about the location of
24957 failure when CreateType fails.
24959 2001-09-29 Miguel de Icaza <miguel@ximian.com>
24961 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
24964 * expression.cs (Binary::CheckShiftArguments): Add missing type
24966 (Binary::ResolveOperator): Add type to the logical and and logical
24967 or, Bitwise And/Or and Exclusive Or code paths, it was missing
24970 (Binary::DoNumericPromotions): In the case where either argument
24971 is ulong (and most signed types combined with ulong cause an
24972 error) perform implicit integer constant conversions as well.
24974 2001-09-28 Miguel de Icaza <miguel@ximian.com>
24976 * expression.cs (UserImplicitCast): Method should always be
24978 (Invocation::BetterConversion): Simplified test for IntLiteral.
24980 (Expression::ImplicitNumericConversion): Split this routine out.
24981 Put the code that performs implicit constant integer conversions
24984 (Expression::Resolve): Become a wrapper around DoResolve so we can
24985 check eclass and type being set after resolve.
24987 (Invocation::Badness): Remove this dead function
24989 (Binary::ResolveOperator): Do not compute the expensive argumnets
24990 unless we have a union for it.
24992 (Probe::Emit): Is needs to do an isinst and then
24993 compare against null.
24995 (::CanConvert): Added Location argument. If the Location argument
24996 is null (Location.Null), then we do not report errors. This is
24997 used by the `probe' mechanism of the Explicit conversion. We do
24998 not want to generate an error for something that the user
24999 explicitly requested to be casted. But the pipeline for an
25000 explicit cast first tests for potential implicit casts.
25002 So for now, if the Location is null, it means `Probe only' to
25003 avoid adding another argument. Might have to revise this
25006 (ClassCast): New class used to type cast objects into arbitrary
25007 classes (used in Explicit Reference Conversions).
25009 Implement `as' as well.
25011 Reverted all the patches from Ravi below: they were broken:
25013 * The use of `level' as a mechanism to stop recursive
25014 invocations is wrong. That was there just to catch the
25015 bug with a strack trace but not as a way of addressing
25018 To fix the problem we have to *understand* what is going
25019 on and the interactions and come up with a plan, not
25020 just get things going.
25022 * The use of the type conversion cache that I proposed
25023 last night had an open topic: How does this work across
25024 protection domains. A user defined conversion might not
25025 be public in the location where we are applying the
25026 conversion, a different conversion might be selected
25027 (ie, private A->B (better) but public B->A (worse),
25028 inside A, A->B applies, but outside it, B->A will
25031 * On top of that (ie, even if the above is solved),
25032 conversions in a cache need to be abstract. Ie, `To
25033 convert from an Int to a Short use an OpcodeCast', not
25034 `To convert from an Int to a Short use the OpcodeCast on
25035 the variable 5' (which is what this patch was doing).
25037 2001-09-28 Ravi Pratap <ravi@ximian.com>
25039 * expression.cs (Invocation::ConversionExists): Re-write to use
25040 the conversion cache
25042 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
25043 cache all conversions done, not just user-defined ones.
25045 (Invocation::BetterConversion): The real culprit. Use ConversionExists
25046 to determine if a conversion exists instead of acutually trying to
25047 perform the conversion. It's faster too.
25049 (Expression::ConvertExplicit): Modify to use ConversionExists to check
25050 and only then attempt the implicit conversion.
25052 2001-09-28 Ravi Pratap <ravi@ximian.com>
25054 * expression.cs (ConvertImplicit): Use a cache for conversions
25055 already found. Check level of recursion and bail out if necessary.
25057 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25059 * typemanager.cs (string_concat_string_string, string_concat_object_object):
25060 Export standard methods that we expect for string operations.
25062 * statement.cs (Block::UsageWarning): Track usage of variables and
25063 report the errors for not used variables.
25065 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
25068 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25070 * codegen.cs: remove unnneded code
25072 * expression.cs: Removed BuiltinTypeAccess class
25074 Fix the order in which implicit conversions are
25077 The previous fixed dropped support for boxed conversions (adding a
25078 test to the test suite now)
25080 (UserImplicitCast::CanConvert): Remove test for source being null,
25081 that code is broken. We should not feed a null to begin with, if
25082 we do, then we should track the bug where the problem originates
25083 and not try to cover it up here.
25085 Return a resolved expression of type UserImplicitCast on success
25086 rather than true/false. Ravi: this is what I was talking about,
25087 the pattern is to use a static method as a "constructor" for
25090 Also, do not create arguments until the very last minute,
25091 otherwise we always create the arguments even for lookups that
25092 will never be performed.
25094 (UserImplicitCast::Resolve): Eliminate, objects of type
25095 UserImplicitCast are born in a fully resolved state.
25097 * typemanager.cs (InitCoreTypes): Init also value_type
25098 (System.ValueType).
25100 * expression.cs (Cast::Resolve): First resolve the child expression.
25102 (LValue): Add new method AddressOf to be used by
25105 Change the argument of Store to take an EmitContext instead of an
25106 ILGenerator, because things like FieldExpr need to be able to call
25107 their children expression to generate the instance code.
25109 (Expression::Error, Expression::Warning): Sugar functions for
25112 (Expression::MemberLookup): Accept a TypeContainer instead of a
25113 Report as the first argument.
25115 (Expression::ResolvePrimary): Killed. I still want to improve
25116 this as currently the code is just not right.
25118 (Expression::ResolveMemberAccess): Simplify, but it is still
25121 (Unary::Resolve): Catch errors in AddressOf operators.
25123 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
25124 index to a byte for the short-version, or the compiler will choose
25125 the wrong Emit call, which generates the wrong data.
25127 (ParameterReference::Emit, ::Store): same.
25129 (FieldExpr::AddressOf): Implement.
25131 * typemanager.cs: TypeManager: made public variable instead of
25134 * driver.cs: document --fatal.
25136 * report.cs (ErrorMessage, WarningMessage): new names for the old
25137 Error and Warning classes.
25139 * cs-parser.jay (member_access): Turn built-in access to types
25140 into a normal simplename
25142 2001-09-27 Ravi Pratap <ravi@ximian.com>
25144 * expression.cs (Invocation::BetterConversion): Fix to cope
25145 with q being null, since this was introducing a bug.
25147 * expression.cs (ConvertImplicit): Do built-in conversions first.
25149 2001-09-27 Ravi Pratap <ravi@ximian.com>
25151 * expression.cs (UserImplicitCast::Resolve): Fix bug.
25153 2001-09-27 Ravi Pratap <ravi@ximian.com>
25155 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
25156 I had introduced long ago (what's new ?).
25158 * expression.cs (UserImplicitCast::CanConvert): Static method to do
25159 the work of all the checking.
25160 (ConvertImplicit): Call CanConvert and only then create object if necessary.
25161 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
25163 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
25164 that is the right way.
25166 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
25167 overloading resolution. Use everywhere instead of cutting and pasting code.
25169 (Binary::ResolveOperator): Use MakeUnionSet.
25171 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
25172 we have to convert to bool types. Not complete yet.
25174 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25176 * typemanager.cs (TypeManager::CSharpName): support ushort.
25178 * expression.cs (Expression::TryImplicitIntConversion): Attempts
25179 to provide an expression that performsn an implicit constant int
25180 conversion (section 6.1.6).
25181 (Expression::ConvertImplicitRequired): Reworked to include
25182 implicit constant expression conversions.
25184 (Expression::ConvertNumericExplicit): Finished.
25186 (Invocation::Emit): If InstanceExpression is null, then it means
25187 that we perform a call on this.
25189 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25191 * expression.cs (Unary::Emit): Remove some dead code.
25192 (Probe): Implement Resolve and Emit for `is'.
25193 (Expression::ConvertImplicitRequired): Attempt to do constant
25194 expression conversions here. Maybe should be moved to
25195 ConvertImplicit, but I am not sure.
25196 (Expression::ImplicitLongConstantConversionPossible,
25197 Expression::ImplicitIntConstantConversionPossible): New functions
25198 that tell whether is it possible to apply an implicit constant
25199 expression conversion.
25201 (ConvertNumericExplicit): Started work on explicit numeric
25204 * cs-parser.jay: Update operator constants.
25206 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
25207 (Parameters::GetSignature): Hook up VerifyArgs here.
25208 (Parameters::VerifyArgs): Verifies that no two arguments have the
25211 * class.cs (Operator): Update the operator names to reflect the
25212 ones that the spec expects (as we are just stringizing the
25215 * expression.cs (Unary::ResolveOperator): Fix bug: Use
25216 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
25217 previous usage did only work for our methods.
25218 (Expression::ConvertImplicit): Handle decimal implicit numeric
25219 conversions as well.
25220 (Expression::InternalTypeConstructor): Used to invoke constructors
25221 on internal types for default promotions.
25223 (Unary::Emit): Implement special handling for the pre/post
25224 increment/decrement for overloaded operators, as they need to have
25225 the same semantics as the other operators.
25227 (Binary::ResolveOperator): ditto.
25228 (Invocation::ConversionExists): ditto.
25229 (UserImplicitCast::Resolve): ditto.
25231 2001-09-26 Ravi Pratap <ravi@ximian.com>
25233 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
25234 operator, return after emitting body. Regression tests pass again !
25236 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
25237 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
25238 (Invocation::OverloadResolve): Ditto.
25239 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
25241 * everywhere : update calls to the above methods accordingly.
25243 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25245 * assign.cs (Assign): Make it inherit from ExpressionStatement.
25247 * expression.cs (ExpressionStatement): New base class used for
25248 expressions that can appear in statements, so that we can provide
25249 an alternate path to generate expression that do not leave a value
25252 (Expression::Emit, and all the derivatives): We no longer return
25253 whether a value is left on the stack or not. Every expression
25254 after being emitted leaves a single value on the stack.
25256 * codegen.cs (EmitContext::EmitStatementExpression): Use the
25257 facilties of ExpressionStatement if possible.
25259 * cs-parser.jay: Update statement_expression.
25261 2001-09-25 Miguel de Icaza <miguel@ximian.com>
25263 * driver.cs: Change the wording of message
25265 2001-09-25 Ravi Pratap <ravi@ximian.com>
25267 * expression.cs (Binary::ResolveOperator): Had forgottten to set
25268 the type of the expression to the return type of the method if
25269 we have an overloaded operator match ! The regression tests pass again !
25270 (Unary::ResolveOperator): Ditto.
25272 * expression.cs (Invocation::ConversionExists): Correct the member lookup
25273 to find "op_Implicit", not "implicit" ;-)
25274 (UserImplicitCast): New class to take care of user-defined implicit conversions.
25275 (ConvertImplicit, ForceConversion): Take TypeContainer argument
25277 * everywhere : Correct calls to the above accordingly.
25279 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
25280 (ConvertImplicit): Do user-defined conversion if it exists.
25282 2001-09-24 Miguel de Icaza <miguel@ximian.com>
25284 * assign.cs: track location.
25285 (Resolve): Use implicit conversions on assignment.
25287 * literal.cs: Oops. Not good, Emit of short access values should
25288 pass (Bytes) or the wrong argument will be selected.
25290 * expression.cs (Unary::Emit): Emit code for -expr.
25292 (Unary::ResolveOperator): Handle `Substract' for non-constants
25293 (substract from zero from the non-constants).
25294 Deal with Doubles as well.
25296 (Expression::ConvertImplicitRequired): New routine that reports an
25297 error if no implicit conversion exists.
25299 (Invocation::OverloadResolve): Store the converted implicit
25300 expressions if we make them
25302 2001-09-24 Ravi Pratap <ravi@ximian.com>
25304 * class.cs (ConstructorInitializer): Take a Location argument.
25305 (ConstructorBaseInitializer): Same here.
25306 (ConstructorThisInitializer): Same here.
25308 * cs-parser.jay : Update all calls accordingly.
25310 * expression.cs (Unary, Binary, New): Take location argument.
25311 Update accordingly everywhere.
25313 * cs-parser.jay : Update all calls to the above to take a location
25316 * class.cs : Ditto.
25318 2001-09-24 Ravi Pratap <ravi@ximian.com>
25320 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
25321 (Invocation::BetterConversion): Same here
25322 (Invocation::ConversionExists): Ditto.
25324 (Invocation::ConversionExists): Implement.
25326 2001-09-22 Ravi Pratap <ravi@ximian.com>
25328 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
25329 Also take an additional TypeContainer argument.
25331 * All over : Pass in TypeContainer as argument to OverloadResolve.
25333 * typemanager.cs (CSharpName): Update to check for the string type and return
25336 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
25339 2001-09-21 Ravi Pratap <ravi@ximian.com>
25341 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
25342 (Invocation::BetterFunction): Implement.
25343 (Invocation::BetterConversion): Implement.
25344 (Invocation::ConversionExists): Skeleton, no implementation yet.
25346 Okay, things work fine !
25348 2001-09-21 Miguel de Icaza <miguel@ximian.com>
25350 * typemanager.cs: declare and load enum_type, delegate_type and
25353 * expression.cs (Expression::Emit): Now emit returns a value that
25354 tells whether a value is left on the stack or not. This strategy
25355 might be reveted tomorrow with a mechanism that would address
25356 multiple assignments.
25357 (Expression::report118): Utility routine to report mismatches on
25360 (Unary::Report23): Report impossible type/operator combination
25363 (Unary::IsIncrementableNumber): Whether the type can be
25364 incremented or decremented with add.
25365 (Unary::ResolveOperator): Also allow enumerations to be bitwise
25367 (Unary::ResolveOperator): Implement ++, !, ~,
25369 (Invocation::Emit): Deal with new Emit convetion.
25371 * All Expression derivatives: Updated their Emit method to return
25372 whether they leave values on the stack or not.
25374 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
25375 stack for expressions that are statements.
25377 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25379 * expression.cs (LValue): New interface. Must be implemented by
25381 (LocalVariableReference, ParameterReference, FieldExpr): Implement
25384 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
25385 interface for generating code, simplifies the code.
25387 2001-09-20 Ravi Pratap <ravi@ximian.com>
25389 * expression.cs (everywhere): Comment out return statements in ::Resolve
25390 methods to avoid the warnings.
25392 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25394 * driver.cs (parse): Report error 2001 if we can not open the
25397 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
25400 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
25403 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
25404 otherwise nested blocks end up with the same index.
25406 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
25408 * expression.cs: Instead of having FIXMEs in the Resolve
25409 functions, throw exceptions so it is obvious that we are facing a
25412 * cs-parser.jay (invocation_expression): Pass Location information.
25414 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
25415 Use a basename for those routines because .NET does not like paths
25418 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
25421 2001-09-19 Miguel de Icaza <miguel@ximian.com>
25423 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
25424 are loading the correct data types (throws an exception if not).
25425 (TypeManager::InitCoreTypes): Use CoreLookupType
25427 * expression.cs (Unary::ResolveOperator): return the child
25428 expression for expressions which are just +expr.
25429 (Unary::ResolveOperator): Return negative literals for -LITERAL
25430 expressions (otherwise they are Unary {Literal}).
25431 (Invocation::Badness): Take into account `Implicit constant
25432 expression conversions'.
25434 * literal.cs (LongLiteral): Implement long literal class.
25435 (IntLiteral): export the `Value' of the intliteral.
25437 2001-09-19 Ravi Pratap <ravi@ximian.com>
25439 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
25441 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
25442 instead of 'Operator'
25444 * expression.cs (Binary::ResolveOperator): Update accordingly.
25445 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
25448 * cs-parser.jay (unary_expression): Update to use the new names.
25450 * gen-treedump.cs (GetUnary): Same here.
25452 * expression.cs (Unary::Resolve): Implement.
25453 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
25454 operators are found instead of making noise ;-)
25455 (Unary::ResolveOperator): New method to do precisely the same thing which
25456 Binary::ResolveOperator does for Binary expressions.
25457 (Unary.method, .Arguments): Add.
25458 (Unary::OperName): Implement.
25459 (Unary::ForceConversion): Copy and Paste !
25461 * class.cs (Operator::Define): Fix a small bug for the case when we have
25464 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
25465 for the inbuilt operators. Only overloading works for now ;-)
25467 2001-09-18 Miguel de Icaza <miguel@ximian.com>
25469 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
25470 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
25472 * expression.cs (This::Emit): Implement.
25473 (This::Resolve): Implement.
25474 (TypeOf:Resolve): Implement.
25475 (Expression::ResolveSimpleName): Add an implicit this to instance
25477 (MemberAccess::Resolve): Deal with Parameters and Fields.
25478 Bind instance variable to Field expressions.
25479 (FieldExpr::Instance): New field used to track the expression that
25480 represents the object instance.
25481 (FieldExpr::Resolve): Track potential errors from MemberLookup not
25483 (FieldExpr::Emit): Implement.
25485 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
25486 the last instruction contains a return opcode to avoid generating
25487 the last `ret' instruction (this generates correct code, and it is
25488 nice to pass the peverify output).
25490 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
25491 initializer for static and instance variables.
25492 (Constructor::Emit): Allow initializer to be null in the case of
25493 static constructors. Only emit initializer for instance
25496 (TypeContainer::FindMembers): Return a null array if there are no
25499 Also fix the code for the MemberTypes.Method branch, as it was not
25500 scanning that for operators (or tried to access null variables before).
25502 * assign.cs (Assign::Emit): Handle instance and static fields.
25506 * driver.cs: Stop compilation if there are parse errors.
25508 * cs-parser.jay (constructor_declaration): Provide default base
25509 initializer for non-static constructors.
25510 (constructor_declarator): Do not provide a default base
25511 initializers if none was specified.
25512 Catch the fact that constructors should not have parameters.
25514 * class.cs: Do not emit parent class initializers for static
25515 constructors, that should be flagged as an error.
25517 2001-09-18 Ravi Pratap <ravi@ximian.com>
25519 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
25520 Move back code into TypeContainer::Populate.
25522 2001-09-18 Ravi Pratap <ravi@ximian.com>
25524 * class.cs (TypeContainer::AddConstructor): Fix the check to
25525 compare against Name, not Basename.
25526 (Operator::OpType): Change Plus and Minus to Add and Subtract.
25528 * cs-parser.jay : Update accordingly.
25530 * class.cs (TypeContainer::FindMembers): For the case where we are searching
25531 for methods, don't forget to look into the operators too.
25532 (RegisterMethodBuilder): Helper method to take care of this for
25533 methods, constructors and operators.
25534 (Operator::Define): Completely revamp.
25535 (Operator.OperatorMethod, MethodName): New fields.
25536 (TypeContainer::Populate): Move the registering of builders into
25537 RegisterMethodBuilder.
25538 (Operator::Emit): Re-write.
25540 * expression.cs (Binary::Emit): Comment out code path to emit method
25541 invocation stuff for the case when we have a user defined operator. I am
25542 just not able to get it right !
25544 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25546 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
25549 (Expression::MemberLookup): Provide a version that allows to
25550 specify the MemberTypes and BindingFlags.
25552 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
25553 so it was not fetching variable information from outer blocks.
25555 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
25556 Beforefieldinit as it was buggy.
25558 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
25559 that Ravi put here.
25561 * class.cs (Constructor::Emit): Only emit if block is not null.
25562 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
25563 deal with this by semantically definining it as if the user had
25566 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
25567 constructors as we now "emit" them at a higher level.
25569 (TypeContainer::DefineDefaultConstructor): Used to define the
25570 default constructors if none was provided.
25572 (ConstructorInitializer): Add methods Resolve and Emit.
25574 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
25576 2001-09-17 Ravi Pratap <ravi@ximian.com>
25578 * class.cs (TypeContainer::EmitDefaultConstructor): Register
25579 the default constructor builder with our hashtable for methodbuilders
25582 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
25583 and argument_count is 0 in which case we have a match.
25584 (Binary::ResolveOperator): More null checking and miscellaneous coding
25587 2001-09-17 Ravi Pratap <ravi@ximian.com>
25589 * rootcontext.cs (IsNameSpace): Compare against null.
25591 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
25593 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
25594 and Unary::Operator.
25596 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
25599 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
25600 we have overloaded operators.
25601 (Binary::ResolveOperator): Implement the part which does the operator overload
25604 * class.cs (Operator::Emit): Implement.
25605 (TypeContainer::Emit): Emit the operators we have too.
25607 * expression.cs (Binary::Emit): Update to emit the appropriate code for
25608 the case when we have a user-defined operator.
25610 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25612 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
25614 2001-09-16 Ravi Pratap <ravi@ximian.com>
25616 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
25617 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
25618 (Constructor::Emit): Implement.
25619 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
25620 if we have no work to do.
25621 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
25624 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
25625 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
25627 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
25630 2001-09-15 Ravi Pratap <ravi@ximian.com>
25632 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
25634 (Tree::RecordNamespace): Method to do what the name says ;-)
25635 (Tree::Namespaces): Property to get at the namespaces hashtable.
25637 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
25640 * rootcontext.cs (IsNamespace): Fixed it :-)
25642 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25644 * class.cs (TypeContainer::FindMembers): Add support for
25646 (MethodCore): New class that encapsulates both the shared aspects
25647 of a Constructor and a Method.
25648 (Method, Constructor): Factored pieces into MethodCore.
25650 * driver.cs: Added --fatal which makes errors throw exceptions.
25651 Load System assembly as well as part of the standard library.
25653 * report.cs: Allow throwing exceptions on errors for debugging.
25655 * modifiers.cs: Do not use `parent', instead use the real type
25656 container to evaluate permission settings.
25658 * class.cs: Put Ravi's patch back in. He is right, and we will
25659 have to cope with the
25661 2001-09-14 Ravi Pratap <ravi@ximian.com>
25663 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
25664 FamORAssem, not FamANDAssem.
25666 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25668 * driver.cs: Added --parse option that only parses its input files
25671 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
25672 incorrect. IsTopLevel is not used to tell whether an object is
25673 root_types or not (that can be achieved by testing this ==
25674 root_types). But to see if this is a top-level *class* (not
25675 necessarly our "toplevel" container).
25677 2001-09-14 Ravi Pratap <ravi@ximian.com>
25679 * enum.cs (Enum::Define): Modify to call the Lookup method on the
25680 parent instead of a direct call to GetType.
25682 2001-09-14 Ravi Pratap <ravi@ximian.com>
25684 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
25685 Modifiers.TypeAttr. This should just be a call to that method.
25687 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
25688 object so that we can determine if we are top-level or not.
25690 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
25693 * enum.cs (Enum::Define): Ditto.
25695 * modifiers.cs (FieldAttr): Re-write.
25697 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
25698 (TypeContainer::HaveStaticConstructor): New property to provide access
25699 to precisely that info.
25701 * modifiers.cs (MethodAttr): Re-write.
25702 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
25704 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
25705 of top-level types as claimed.
25707 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25709 * expression.cs (MemberLookup): Fruitless attempt to lookup
25710 constructors. Maybe I need to emit default constructors? That
25711 might be it (currently .NET emits this for me automatically).
25712 (Invocation::OverloadResolve): Cope with Arguments == null.
25713 (Invocation::EmitArguments): new function, shared by the new
25714 constructor and us.
25715 (Invocation::Emit): Handle static and instance methods. Emit
25716 proper call instruction for virtual or non-virtual invocations.
25717 (New::Emit): Implement.
25718 (New::Resolve): Implement.
25719 (MemberAccess:Resolve): Implement.
25720 (MethodGroupExpr::InstanceExpression): used conforming to the spec
25721 to track instances.
25722 (FieldExpr::Resolve): Set type.
25724 * support.cs: Handle empty arguments.
25726 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
25727 SimpleLookup): Auxiliary routines to help parse a qualifier
25730 Update qualifier_identifier rule.
25732 * codegen.cs: Removed debugging messages.
25734 * class.cs: Make this a global thing, this acts just as a "key" to
25735 objects that we might have around.
25737 (Populate): Only initialize method_builders_to_methods once.
25739 * expression.cs (PropertyExpr): Initialize type from the
25742 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
25743 Resolve pattern. Attempt to implicitly convert value to boolean.
25746 * expression.cs: Set the type for the int32/int32 argument case.
25747 (Binary::ResolveOperator): Set the return type to boolean for
25748 comparission operators
25750 * typemanager.cs: Remove debugging print code.
25752 (Invocation::Resolve): resolve type.
25754 * class.cs: Allocate a MemberInfo of the correct size, as the code
25755 elsewhere depends on the test to reflect the correct contents.
25757 (Method::) Keep track of parameters, due to System.Reflection holes
25759 (TypeContainer::Populate): Keep track of MethodBuilders to Method
25762 (TypeContainer::FindMembers): Use ArrayList and then copy an array
25763 of the exact size and return that.
25765 (Class::LookupMethodByBuilder): New function that maps
25766 MethodBuilders to its methods. Required to locate the information
25767 on methods because System.Reflection bit us again.
25769 * support.cs: New file, contains an interface ParameterData and
25770 two implementations: ReflectionParameters and InternalParameters
25771 used to access Parameter information. We will need to grow this
25774 * expression.cs (Invocation::GetParameterData): implement a cache
25775 and a wrapper around the ParameterData creation for methods.
25776 (Invocation::OverloadResolve): Use new code.
25778 2001-09-13 Ravi Pratap <ravi@ximian.com>
25780 * class.cs (TypeContainer::EmitField): Remove and move into
25781 (Field::Define): here and modify accordingly.
25782 (Field.FieldBuilder): New member.
25783 (TypeContainer::Populate): Update accordingly.
25784 (TypeContainer::FindMembers): Implement.
25786 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25788 * statement.cs: (VariableInfo::VariableType): New field to be
25789 initialized with the full type once it is resolved.
25791 2001-09-12 Miguel de Icaza <miguel@ximian.com>
25793 * parameter.cs (GetParameterInfo): Use a type cache to compute
25794 things only once, and to reuse this information
25796 * expression.cs (LocalVariableReference::Emit): Implement.
25797 (OpcodeCast::Emit): fix.
25799 (ParameterReference::Resolve): Implement.
25800 (ParameterReference::Emit): Implement.
25802 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
25803 that are expressions need to stay as Expressions.
25805 * typemanager.cs (CSharpName): Returns the C# name of a type if
25808 * expression.cs (Expression::ConvertImplicit): New function that
25809 implements implicit type conversions.
25811 (Expression::ImplicitReferenceConversion): Implements implicit
25812 reference conversions.
25814 (EmptyCast): New type for transparent casts.
25816 (OpcodeCast): New type for casts of types that are performed with
25817 a sequence of bytecodes.
25819 (BoxedCast): New type used for casting value types into reference
25820 types. Emits a box opcode.
25822 (Binary::DoNumericPromotions): Implements numeric promotions of
25823 and computation of the Binary::Type.
25825 (Binary::EmitBranchable): Optimization.
25827 (Binary::Emit): Implement code emission for expressions.
25829 * typemanager.cs (TypeManager): Added two new core types: sbyte
25832 2001-09-12 Ravi Pratap <ravi@ximian.com>
25834 * class.cs (TypeContainer::FindMembers): Method which does exactly
25835 what Type.FindMembers does, only we don't have to use reflection. No
25836 implementation yet.
25838 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
25839 typecontainer objects as we need to get at them.
25840 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
25842 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
25843 typecontainer object.
25845 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
25846 of just a Report object.
25848 2001-09-11 Ravi Pratap <ravi@ximian.com>
25850 * class.cs (Event::Define): Go back to using the prefixes "add_" and
25852 (TypeContainer::Populate): Now define the delegates of the type too.
25853 (TypeContainer.Delegates): Property to access the list of delegates defined
25856 * delegates.cs (Delegate::Define): Implement partially.
25858 * modifiers.cs (TypeAttr): Handle more flags.
25860 2001-09-11 Ravi Pratap <ravi@ximian.com>
25862 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
25864 (Operator::Define): Re-write logic to get types by using the LookupType method
25865 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
25866 (Indexer::Define): Ditto.
25867 (Event::Define): Ditto.
25868 (Property::Define): Ditto.
25870 2001-09-10 Ravi Pratap <ravi@ximian.com>
25872 * class.cs (TypeContainer::Populate): Now define operators too.
25873 (TypeContainer.Operators): New property to access the list of operators
25875 (Operator.OperatorMethodBuilder): New member to hold the method builder
25876 for the operator we are defining.
25877 (Operator::Define): Implement.
25879 2001-09-10 Ravi Pratap <ravi@ximian.com>
25881 * class.cs (Event::Define): Make the prefixes of the accessor methods
25882 addOn_ and removeOn_
25884 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
25885 of the location being passed in too. Ideally, this should go later since all
25886 error reporting should be done through the Report object.
25888 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
25889 (Populate): Iterate thru the indexers we have and define them too.
25890 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
25891 for the get and set accessors.
25892 (Indexer::Define): Implement.
25894 2001-09-09 Miguel de Icaza <miguel@ximian.com>
25896 * expression.cs (Binary::Resolve): Beginning of it. I scratched
25897 my previous implementation, did not work.
25899 * typemanager.cs: Add a couple of missing types (the longs).
25901 * literal.cs: Use TypeManager.bool_type instead of getting it.
25903 * expression.cs (EventExpr): New kind of expressions.
25904 (Expressio::ExprClassFromMemberInfo): finish
25906 2001-09-08 Miguel de Icaza <miguel@ximian.com>
25908 * assign.cs: Emit stores to static fields differently.
25910 2001-09-08 Ravi Pratap <ravi@ximian.com>
25912 * Merge in changes and adjust code to tackle conflicts. Backed out my
25913 code in Assign::Resolve ;-)
25915 2001-09-08 Ravi Pratap <ravi@ximian.com>
25917 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
25918 instead Report.Error and also pass in the location.
25919 (CSharpParser::Lexer): New readonly property to return the reference
25920 to the Tokenizer object.
25921 (declare_local_variables): Use Report.Error with location instead of plain
25925 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
25926 (Operator.CheckBinaryOperator): Ditto.
25928 * cs-parser.jay (operator_declarator): Update accordingly.
25930 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
25931 (CheckBinaryOperator): Same here.
25933 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
25934 on the name without any prefixes of namespace names etc. This is because we
25935 already might have something already fully qualified like
25936 'System.Console.WriteLine'
25938 * assign.cs (Resolve): Begin implementation. Stuck ;-)
25940 2001-09-07 Ravi Pratap <ravi@ximian.com>
25942 * cs-tokenizer.cs (location): Return a string which also contains
25945 * expression.cs (ElementAccess): New class for expressions of the
25946 type 'element access.'
25947 (BaseAccess): New class for expressions of the type 'base access.'
25948 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
25951 * cs-parser.jay (element_access): Implement action.
25952 (base_access): Implement actions.
25953 (checked_expression, unchecked_expression): Implement.
25955 * cs-parser.jay (local_variable_type): Correct and implement.
25956 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
25958 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
25960 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
25961 name and the specifiers.
25963 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
25965 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
25966 making them all public ;-)
25968 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
25971 2001-09-07 Miguel de Icaza <miguel@ximian.com>
25973 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
25975 (FieldExpr, PropertyExprs): New resolved expressions.
25976 (SimpleName::MemberStaticCheck): Perform static checks for access
25977 to non-static fields on static methods. Maybe this should be
25978 generalized for MemberAccesses.
25979 (SimpleName::ResolveSimpleName): More work on simple name
25982 * cs-parser.jay (primary_expression/qualified_identifier): track
25983 the parameter index.
25985 * codegen.cs (CodeGen::Save): Catch save exception, report error.
25986 (EmitContext::EmitBoolExpression): Chain to expression generation
25987 instead of temporary hack.
25988 (::EmitStatementExpression): Put generic expression code generation.
25990 * assign.cs (Assign::Emit): Implement variable assignments to
25991 local variables, parameters and fields.
25993 2001-09-06 Miguel de Icaza <miguel@ximian.com>
25995 * statement.cs (Block::GetVariableInfo): New method, returns the
25996 VariableInfo for a variable name in a block.
25997 (Block::GetVariableType): Implement in terms of GetVariableInfo
25999 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
26000 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
26002 2001-09-06 Ravi Pratap <ravi@ximian.com>
26004 * cs-parser.jay (operator_declaration): Continue on my quest : update
26005 to take attributes argument.
26006 (event_declaration): Ditto.
26007 (enum_declaration): Ditto.
26008 (indexer_declaration): Ditto.
26010 * class.cs (Operator::Operator): Update constructor accordingly.
26011 (Event::Event): Ditto.
26013 * delegate.cs (Delegate::Delegate): Same here.
26015 * enum.cs (Enum::Enum): Same here.
26017 2001-09-05 Ravi Pratap <ravi@ximian.com>
26019 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
26021 * ../tests/cs0658.cs : New file to demonstrate error 0658.
26023 * attribute.cs (Attributes): New class to encapsulate all attributes which were
26024 being passed around as an arraylist.
26025 (Attributes::AddAttribute): Method to add attribute sections.
26027 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
26028 (struct_declaration): Update accordingly.
26029 (constant_declaration): Update.
26030 (field_declaration): Update.
26031 (method_header): Update.
26032 (fixed_parameter): Update.
26033 (parameter_array): Ditto.
26034 (property_declaration): Ditto.
26035 (destructor_declaration): Ditto.
26037 * class.cs (Struct::Struct): Update constructors accordingly.
26038 (Class::Class): Ditto.
26039 (Field::Field): Ditto.
26040 (Method::Method): Ditto.
26041 (Property::Property): Ditto.
26042 (TypeContainer::OptAttribute): update property's return type.
26044 * interface.cs (Interface.opt_attributes): New member.
26045 (Interface::Interface): Update to take the extra Attributes argument.
26047 * parameter.cs (Parameter::Parameter): Ditto.
26049 * constant.cs (Constant::Constant): Ditto.
26051 * interface.cs (InterfaceMemberBase): New OptAttributes field.
26052 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
26053 the attributes as a parameter.
26054 (InterfaceProperty): Update constructor call.
26055 (InterfaceEvent): Ditto.
26056 (InterfaceMethod): Ditto.
26057 (InterfaceIndexer): Ditto.
26059 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
26060 pass the attributes too.
26061 (interface_event_declaration): Ditto.
26062 (interface_property_declaration): Ditto.
26063 (interface_method_declaration): Ditto.
26064 (interface_declaration): Ditto.
26066 2001-09-05 Miguel de Icaza <miguel@ximian.com>
26068 * class.cs (Method::Define): Track the "static Main" definition to
26069 create an entry point.
26071 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
26072 EntryPoint if we find it.
26074 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
26075 (EmitContext::ig): Make this variable public.
26077 * driver.cs: Make the default output file be the first file name
26078 with the .exe extension.
26080 Detect empty compilations
26082 Handle various kinds of output targets. Handle --target and
26083 rename -t to --dumper.
26085 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
26086 methods inherited from Expression return now an Expression. This
26087 will is used during the tree rewriting as we resolve them during
26090 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
26091 the spec. Missing entirely is the information about
26092 accessability of elements of it.
26094 (Expression::ExprClassFromMemberInfo): New constructor for
26095 Expressions that creates a fully initialized Expression based on
26096 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
26099 (Invocation::Resolve): Begin implementing resolution of invocations.
26101 * literal.cs (StringLiteral): Implement Emit.
26103 2001-09-05 Ravi Pratap <ravi@ximian.com>
26105 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
26108 2001-09-04 Ravi Pratap <ravi@ximian.com>
26110 * cs-parser.jay (attribute_arguments): Implement actions.
26111 (attribute): Fix bug in production. Implement action.
26112 (attribute_list): Implement.
26113 (attribute_target): Implement.
26114 (attribute_target_specifier, opt_target_specifier): Implement
26115 (CheckAttributeTarget): New method to check if the attribute target
26117 (attribute_section): Implement.
26118 (opt_attributes): Implement.
26120 * attribute.cs : New file to handle attributes.
26121 (Attribute): Class to hold attribute info.
26123 * cs-parser.jay (opt_attribute_target_specifier): Remove production
26124 (attribute_section): Modify production to use 2 different rules to
26125 achieve the same thing. 1 s/r conflict down !
26126 Clean out commented, useless, non-reducing dimension_separator rules.
26128 * class.cs (TypeContainer.attributes): New member to hold list
26129 of attributes for a type.
26130 (Struct::Struct): Modify to take one more argument, the attribute list.
26131 (Class::Class): Ditto.
26132 (Field::Field): Ditto.
26133 (Method::Method): Ditto.
26134 (Property::Property): Ditto.
26136 * cs-parser.jay (struct_declaration): Update constructor call to
26137 pass in the attributes too.
26138 (class_declaration): Ditto.
26139 (constant_declaration): Ditto.
26140 (field_declaration): Ditto.
26141 (method_header): Ditto.
26142 (fixed_parameter): Ditto.
26143 (parameter_array): Ditto.
26144 (property_declaration): Ditto.
26146 * constant.cs (Constant::Constant): Update constructor similarly.
26147 Use System.Collections.
26149 * parameter.cs (Parameter::Parameter): Update as above.
26151 2001-09-02 Ravi Pratap <ravi@ximian.com>
26153 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
26154 (TypeContainer.delegates): New member to hold list of delegates.
26156 * cs-parser.jay (delegate_declaration): Implement the action correctly
26157 this time as I seem to be on crack ;-)
26159 2001-09-02 Miguel de Icaza <miguel@ximian.com>
26161 * rootcontext.cs (RootContext::IsNamespace): new function, used to
26162 tell whether an identifier represents a namespace.
26164 * expression.cs (NamespaceExpr): A namespace expression, used only
26165 temporarly during expression resolution.
26166 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
26167 utility functions to resolve names on expressions.
26169 2001-09-01 Miguel de Icaza <miguel@ximian.com>
26171 * codegen.cs: Add hook for StatementExpressions.
26173 * class.cs: Fix inverted test for static flag in methods.
26175 2001-09-02 Ravi Pratap <ravi@ximian.com>
26177 * class.cs (Operator::CheckUnaryOperator): Correct error number used
26178 to make it coincide with MS' number.
26179 (Operator::CheckBinaryOperator): Ditto.
26181 * ../errors/errors.txt : Remove error numbers added earlier.
26183 * ../errors/cs1019.cs : Test case for error # 1019
26185 * ../errros/cs1020.cs : Test case for error # 1020
26187 * cs-parser.jay : Clean out commented cruft.
26188 (dimension_separators, dimension_separator): Comment out. Ostensibly not
26189 used anywhere - non-reducing rule.
26190 (namespace_declarations): Non-reducing rule - comment out.
26192 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
26193 with TypeContainer::AddEnum.
26195 * delegate.cs : New file for delegate handling classes.
26196 (Delegate): Class for declaring delegates.
26198 * makefile : Update.
26200 * cs-parser.jay (delegate_declaration): Implement.
26202 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
26204 * class.cs (Event::Define): Implement.
26205 (Event.EventBuilder): New member.
26207 * class.cs (TypeContainer::Populate): Update to define all enums and events
26209 (Events): New property for the events arraylist we hold. Shouldn't we move to using
26210 readonly fields for all these cases ?
26212 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26214 * class.cs (Property): Revamp to use the convention of making fields readonly.
26215 Accordingly modify code elsewhere.
26217 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
26218 the Define method of the Property class.
26220 * class.cs : Clean up applied patch and update references to variables etc. Fix
26222 (TypeContainer::Populate): Update to define all the properties we have. Also
26223 define all enumerations.
26225 * enum.cs (Define): Implement.
26227 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26229 * cs-parser.jay (overloadable_operator): The semantic value is an
26230 enum of the Operator class.
26231 (operator_declarator): Implement actions.
26232 (operator_declaration): Implement.
26234 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
26235 validity of definitions.
26236 (Operator::CheckBinaryOperator): Static method to check for binary operators
26237 (TypeContainer::AddOperator): New method to add an operator to a type.
26239 * cs-parser.jay (indexer_declaration): Added line to actually call the
26240 AddIndexer method so it gets added ;-)
26242 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
26243 already taken care of by the MS compiler ?
26245 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26247 * class.cs (Operator): New class for operator declarations.
26248 (Operator::OpType): Enum for the various operators.
26250 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26252 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
26253 ostensibly handle this in semantic analysis.
26255 * cs-parser.jay (general_catch_clause): Comment out
26256 (specific_catch_clauses, specific_catch_clause): Ditto.
26257 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
26258 (catch_args, opt_catch_args): New productions.
26259 (catch_clause): Rewrite to use the new productions above
26260 (catch_clauses): Modify accordingly.
26261 (opt_catch_clauses): New production to use in try_statement
26262 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
26263 and re-write the code in the actions to extract the specific and
26264 general catch clauses by being a little smart ;-)
26266 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
26267 Hooray, try and catch statements parse fine !
26269 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26271 * statement.cs (Block::GetVariableType): Fix logic to extract the type
26272 string from the hashtable of variables.
26274 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
26275 I end up making that mistake ;-)
26276 (catch_clauses): Fixed gross error which made Key and Value of the
26277 DictionaryEntry the same : $1 !!
26279 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26281 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
26283 * cs-parser.jay (event_declaration): Correct to remove the semicolon
26284 when the add and remove accessors are specified.
26286 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26288 * cs-parser.jay (IndexerDeclaration): New helper class to hold
26289 information about indexer_declarator.
26290 (indexer_declarator): Implement actions.
26291 (parsing_indexer): New local boolean used to keep track of whether
26292 we are parsing indexers or properties. This is necessary because
26293 implicit_parameters come into picture even for the get accessor in the
26294 case of an indexer.
26295 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
26297 * class.cs (Indexer): New class for indexer declarations.
26298 (TypeContainer::AddIndexer): New method to add an indexer to a type.
26299 (TypeContainer::indexers): New member to hold list of indexers for the
26302 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26304 * cs-parser.jay (add_accessor_declaration): Implement action.
26305 (remove_accessor_declaration): Implement action.
26306 (event_accessors_declaration): Implement
26307 (variable_declarators): swap statements for first rule - trivial.
26309 * class.cs (Event): New class to hold information about event
26311 (TypeContainer::AddEvent): New method to add an event to a type
26312 (TypeContainer::events): New member to hold list of events.
26314 * cs-parser.jay (event_declaration): Implement actions.
26316 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26318 * cs-parser.jay (dim_separators): Implement. Make it a string
26319 concatenating all the commas together, just as they appear.
26320 (opt_dim_separators): Modify accordingly
26321 (rank_specifiers): Update accordingly. Basically do the same
26322 thing - instead, collect the brackets here.
26323 (opt_rank_sepcifiers): Modify accordingly.
26324 (array_type): Modify to actually return the complete type string
26325 instead of ignoring the rank_specifiers.
26326 (expression_list): Implement to collect the expressions
26327 (variable_initializer): Implement. We make it a list of expressions
26328 essentially so that we can handle the array_initializer case neatly too.
26329 (variable_initializer_list): Implement.
26330 (array_initializer): Make it a list of variable_initializers
26331 (opt_array_initializer): Modify accordingly.
26333 * expression.cs (New::NType): Add enumeration to help us
26334 keep track of whether we have an object/delegate creation
26335 or an array creation.
26336 (New:NewType, New::Rank, New::Indices, New::Initializers): New
26337 members to hold data about array creation.
26338 (New:New): Modify to update NewType
26339 (New:New): New Overloaded contructor for the array creation
26342 * cs-parser.jay (array_creation_expression): Implement to call
26343 the overloaded New constructor.
26345 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
26347 * class.cs (TypeContainer::Constructors): Return member
26348 constructors instead of returning null.
26350 2001-08-26 Miguel de Icaza <miguel@ximian.com>
26352 * typemanager.cs (InitCoreTypes): Initialize the various core
26353 types after we have populated the type manager with the user
26354 defined types (this distinction will be important later while
26355 compiling corlib.dll)
26357 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
26358 on Expression Classification. Now all expressions have a method
26359 `Resolve' and a method `Emit'.
26361 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
26362 generation from working. Also add some temporary debugging
26365 2001-08-24 Miguel de Icaza <miguel@ximian.com>
26367 * codegen.cs: Lots of code generation pieces. This is only the
26368 beginning, will continue tomorrow with more touches of polish. We
26369 handle the fundamentals of if, while, do, for, return. Others are
26370 trickier and I need to start working on invocations soon.
26372 * gen-treedump.cs: Bug fix, use s.Increment here instead of
26375 * codegen.cs (EmitContext): New struct, used during code
26376 emission to keep a context. Most of the code generation will be
26379 * cs-parser.jay: Add embedded blocks to the list of statements of
26380 this block. So code generation proceeds in a top down fashion.
26382 2001-08-23 Miguel de Icaza <miguel@ximian.com>
26384 * statement.cs: Add support for multiple child blocks.
26386 2001-08-22 Miguel de Icaza <miguel@ximian.com>
26388 * codegen.cs (EmitCode): New function, will emit the code for a
26389 Block of code given a TypeContainer and its ILGenerator.
26391 * statement.cs (Block): Standard public readonly optimization.
26392 (Block::Block constructors): Link children.
26393 (Block::Child): Child Linker.
26394 (Block::EmitVariables): Emits IL variable declarations.
26396 * class.cs: Drop support for MethodGroups here, delay until
26398 (Method::): Applied the same simplification that I did before, and
26399 move from Properties to public readonly fields.
26400 (Method::ParameterTypes): Returns the parameter types for the
26401 function, and implements a cache that will be useful later when I
26402 do error checking and the semantic analysis on the methods is
26404 (Constructor::GetCallingConvention): Renamed from CallingConvetion
26405 and made a method, optional argument tells whether this is a class
26406 or a structure to apply the `has-this' bit.
26407 (Method::GetCallingConvention): Implement, returns the calling
26409 (Method::Define): Defines the type, a second pass is performed
26410 later to populate the methods.
26412 (Constructor::ParameterTypes): implement a cache similar to the
26413 one on Method::ParameterTypes, useful later when we do semantic
26416 (TypeContainer::EmitMethod): New method. Emits methods.
26418 * expression.cs: Removed MethodGroup class from here.
26420 * parameter.cs (Parameters::GetCallingConvention): new method.
26422 2001-08-21 Miguel de Icaza <miguel@ximian.com>
26424 * class.cs (TypeContainer::Populate): Drop RootContext from the
26427 (Constructor::CallingConvention): Returns the calling convention.
26428 (Constructor::ParameterTypes): Returns the constructor parameter
26431 (TypeContainer::AddConstructor): Keep track of default constructor
26432 and the default static constructor.
26434 (Constructor::) Another class that starts using `public readonly'
26435 instead of properties.
26437 (Constructor::IsDefault): Whether this is a default constructor.
26439 (Field::) use readonly public fields instead of properties also.
26441 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
26442 track of static constructors; If none is used, turn on
26443 BeforeFieldInit in the TypeAttributes.
26445 * cs-parser.jay (opt_argument_list): now the return can be null
26446 for the cases where there are no arguments.
26448 (constructor_declarator): If there is no implicit `base' or
26449 `this', then invoke the default parent constructor.
26451 * modifiers.cs (MethodAttr): New static function maps a set of
26452 modifiers flags into a MethodAttributes enum
26453 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
26454 MethodAttr, TypeAttr to represent the various mappings where the
26455 modifiers are used.
26456 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
26458 2001-08-19 Miguel de Icaza <miguel@ximian.com>
26460 * parameter.cs (GetParameterInfo): Fix bug where there would be no
26463 * interface.cs (PopulateIndexer): Implemented the code generator
26464 for interface indexers.
26466 2001-08-17 Miguel de Icaza <miguel@ximian.com>
26468 * interface.cs (InterfaceMemberBase): Now we track the new status
26471 (PopulateProperty): Implement property population. Woohoo! Got
26472 Methods and Properties going today.
26474 Removed all the properties for interfaces, and replaced them with
26475 `public readonly' fields.
26477 2001-08-16 Miguel de Icaza <miguel@ximian.com>
26479 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
26480 initialize their hashtables/arraylists only when they are needed
26481 instead of doing this always.
26483 * parameter.cs: Handle refs and out parameters.
26485 * cs-parser.jay: Use an ArrayList to construct the arguments
26486 instead of the ParameterCollection, and then cast that to a
26489 * parameter.cs: Drop the use of ParameterCollection and use
26490 instead arrays of Parameters.
26492 (GetParameterInfo): Use the Type, not the Name when resolving
26495 2001-08-13 Miguel de Icaza <miguel@ximian.com>
26497 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
26498 and instead use public readonly fields.
26500 * class.cs: Put back walking code for type containers.
26502 2001-08-11 Miguel de Icaza <miguel@ximian.com>
26504 * class.cs (MakeConstant): Code to define constants.
26506 * rootcontext.cs (LookupType): New function. Used to locate types
26509 2001-08-08 Miguel de Icaza <miguel@ximian.com>
26511 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
26512 this System.Reflection code is. Kudos to Microsoft
26514 * typemanager.cs: Implement a type cache and avoid loading all
26515 types at boot time. Wrap in LookupType the internals. This made
26516 the compiler so much faster. Wow. I rule!
26518 * driver.cs: Make sure we always load mscorlib first (for
26519 debugging purposes, nothing really important).
26521 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
26522 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
26524 * rootcontext.cs: Lookup types on their namespace; Lookup types
26525 on namespaces that have been imported using the `using' keyword.
26527 * class.cs (TypeContainer::TypeAttr): Virtualize.
26528 (Class::TypeAttr): Return attributes suitable for this bad boy.
26529 (Struct::TypeAttr): ditto.
26530 Handle nested classes.
26531 (TypeContainer::) Remove all the type visiting code, it is now
26532 replaced with the rootcontext.cs code
26534 * rootcontext.cs (GetClassBases): Added support for structs.
26536 2001-08-06 Miguel de Icaza <miguel@ximian.com>
26538 * interface.cs, statement.cs, class.cs, parameter.cs,
26539 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
26540 Drop use of TypeRefs, and use strings instead.
26542 2001-08-04 Miguel de Icaza <miguel@ximian.com>
26546 * class.cs (Struct::Struct): set the SEALED flags after
26547 checking the modifiers.
26548 (TypeContainer::TypeAttr): new property, returns the
26549 TypeAttributes for a class.
26551 * cs-parser.jay (type_list): Oops, list production was creating a
26552 new list of base types.
26554 * rootcontext.cs (StdLib): New property.
26555 (GetInterfaceTypeByName): returns an interface by type name, and
26556 encapsulates error handling here.
26557 (GetInterfaces): simplified.
26558 (ResolveTree): Encapsulated all the tree resolution here.
26559 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
26562 * driver.cs: Add support for --nostdlib, to avoid loading the
26563 default assemblies.
26564 (Main): Do not put tree resolution here.
26566 * rootcontext.cs: Beginning of the class resolution.
26568 2001-08-03 Miguel de Icaza <miguel@ximian.com>
26570 * rootcontext.cs: Provide better error reporting.
26572 * cs-parser.jay (interface_base): set our $$ to be interfaces.
26574 * rootcontext.cs (CreateInterface): Handle the case where there
26575 are no parent interfaces.
26577 (CloseTypes): Routine to flush types at the end.
26578 (CreateInterface): Track types.
26579 (GetInterfaces): Returns an array of Types from the list of
26580 defined interfaces.
26582 * typemanager.c (AddUserType): Mechanism to track user types (puts
26583 the type on the global type hash, and allows us to close it at the
26586 2001-08-02 Miguel de Icaza <miguel@ximian.com>
26588 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
26589 RecordInterface instead.
26591 * cs-parser.jay: Updated to reflect changes above.
26593 * decl.cs (Definition): Keep track of the TypeBuilder type that
26594 represents this type here. Not sure we will use it in the long
26595 run, but wont hurt for now.
26597 * driver.cs: Smaller changes to accomodate the new code.
26599 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
26602 * rootcontext.cs (CreateInterface): New method, used to create
26603 the System.TypeBuilder type for interfaces.
26604 (ResolveInterfaces): new entry point to resolve the interface
26606 (CodeGen): Property, used to keep track of the code generator.
26608 2001-07-26 Miguel de Icaza <miguel@ximian.com>
26610 * cs-parser.jay: Add a second production for delegate_declaration
26613 (enum_body): Put an opt_comma here instead of putting it on
26614 enum_body or enum_member_declarations so we can handle trailing
26615 commas on enumeration members. Gets rid of a shift/reduce.
26617 (type_list): Need a COMMA in the middle.
26619 (indexer_declaration): Tell tokenizer to recognize get/set
26621 * Remove old targets.
26623 * Re-add the parser target.
26625 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26627 * cs-parser.jay: Add precendence rules for a number of operators
26628 ot reduce the number of shift/reduce conflicts in the grammar.
26630 2001-07-17 Miguel de Icaza <miguel@ximian.com>
26632 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
26635 Get rid of old crufty code.
26637 * rootcontext.cs: Use this to keep track of the parsed
26638 representation and the defined types available to the program.
26640 * gen-treedump.cs: adjust for new convention.
26642 * type.cs: Split out the type manager, and the assembly builder
26645 * typemanager.cs: the type manager will live here now.
26647 * cil-codegen.cs: And the code generator here.
26649 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
26651 * makefile: Fixed up for easy making.
26653 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26655 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
26658 (unary_expression): Expand pre_increment_expression and
26659 post_decrement_expression to reduce a shift/reduce.
26661 2001-07-11 Simon Cozens
26663 * cs-tokenizer.cs: Hex numbers should begin with a 0.
26665 Improve allow_keyword_as_indent name.
26667 2001-06-19 Miguel de Icaza <miguel@ximian.com>
26669 * Adjustments for Beta2.
26671 2001-06-13 Miguel de Icaza <miguel@ximian.com>
26673 * decl.cs: Added `Define' abstract method.
26674 (InTransit): new property, used to catch recursive definitions.
26676 * interface.cs: Implement `Define'.
26678 * modifiers.cs: Map Modifiers.constants to
26679 System.Reflection.TypeAttribute flags.
26681 * class.cs: Keep track of types and user-defined types.
26682 (BuilderInit): New method for creating an assembly
26683 (ResolveType): New function to launch the resolution process, only
26684 used by interfaces for now.
26686 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
26687 that are inserted into the name space.
26689 2001-06-08 Miguel de Icaza <miguel@ximian.com>
26691 * ARGH. I have screwed up my tree so many times due to the use of
26692 rsync rather than using CVS. Going to fix this at once.
26694 * driver.cs: Objetify driver. Load assemblies, use assemblies to
26697 2001-06-07 Miguel de Icaza <miguel@ximian.com>
26699 * Experiment successful: Use System.Type rather that our own
26702 2001-05-25 Miguel de Icaza <miguel@ximian.com>
26704 * cs-parser.jay: Removed nsAliases from here.
26706 Use new namespaces, handle `using XXX;'
26708 * namespace.cs: Reimplemented namespace handling, use a recursive
26709 definition of the class. Now we can keep track of using clauses
26710 and catch invalid using clauses.
26712 2001-05-24 Miguel de Icaza <miguel@ximian.com>
26714 * gen-treedump.cs: Adapted for all the renaming.
26716 * expression.cs (Expression): this class now has a Type property
26717 which returns an expression Type.
26719 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
26720 `Type', as this has a different meaning now in the base
26722 2001-05-22 Miguel de Icaza <miguel@ximian.com>
26724 * interface.cs, class.cs: Removed from all the sources the
26725 references to signature computation, as we can not do method
26726 signature computation during the parsing time, as we are not
26727 trying to solve at that point distinguishing:
26731 void a (NS.Blah x) {}
26734 Which depending on the context might be valid or not, as we do not
26735 know if Blah is the same thing as NS.Blah at that point.
26737 * Redid everything so the code uses TypeRefs now instead of
26738 Types. TypeRefs are just temporary type placeholders, that need
26739 to be resolved. They initially have a pointer to a string and the
26740 current scope in which they are used. This is used later by the
26741 compiler to resolve the reference to an actual Type.
26743 * DeclSpace is no longer a CIR.Type, and neither are
26744 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
26745 are all DeclSpaces, but no Types.
26747 * type.cs (TypeRefManager): This implements the TypeRef manager,
26748 which keeps track of all the types that need to be resolved after
26749 the parsing has finished.
26751 2001-05-13 Miguel de Icaza <miguel@ximian.com>
26753 * ARGH. We are going to have to store `foreach' as a class rather
26754 than resolving it, as we need to verify error 1579 after name
26755 resolution. *OR* we could keep a flag that says `This request to
26756 IEnumerator comes from a foreach statement' which we can then use
26757 to generate the error.
26759 2001-05-10 Miguel de Icaza <miguel@ximian.com>
26761 * class.cs (TypeContainer.AddMethod): we now add methods to the
26762 MethodGroup instead of the method hashtable.
26764 * expression.cs: Add MethodGroup abstraction, which gets us one
26765 step closer to the specification in the way we handle method
26768 * cs-parser.jay (primary_expression): qualified_identifier now
26769 tried to match up an identifier to a local variable reference or
26770 to a parameter reference.
26772 current_local_parameters is now a parser global variable that
26773 points to the current parameters for the block, used during name
26776 (property_declaration): Now creates an implicit `value' argument to
26779 2001-05-09 Miguel de Icaza <miguel@ximian.com>
26781 * parameter.cs: Do not use `param' arguments as part of the
26782 signature, per the spec.
26784 2001-05-08 Miguel de Icaza <miguel@ximian.com>
26786 * decl.cs: Base class for classes, structs and interfaces. This
26787 is the "Declaration Space"
26789 * cs-parser.jay: Use CheckDef for checking declaration errors
26790 instead of having one on each function.
26792 * class.cs: Factor out some code for handling error handling in
26793 accordance to the "Declarations" section in the "Basic Concepts"
26794 chapter in the ECMA C# spec.
26796 * interface.cs: Make all interface member classes derive from
26797 InterfaceMemberBase.
26799 2001-05-07 Miguel de Icaza <miguel@ximian.com>
26801 * Many things: all interfaces are parsed and generated in
26802 gen-treedump. Support for member variables, constructors,
26803 destructors, properties, constants is there.
26805 Beginning of the IL backend, but very little done, just there for
26808 2001-04-29 Miguel de Icaza <miguel@ximian.com>
26810 * cs-parser.jay: Fix labeled statement.
26812 * cs-tokenizer.cs (escape): Escape " and ' always.
26813 ref_line, ref_name: keep track of the line/filename as instructed
26814 by #line by the compiler.
26817 2001-04-27 Miguel de Icaza <miguel@ximian.com>
26819 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
26820 to match the values in System.CodeDOM.
26822 Divid renamed to Divide.
26824 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
26826 (Statements.set): remove.
26828 * System.CodeDOM/CodeCatchClause.cs: always have a valid
26831 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
26832 falseStatements always have valid values.
26834 * cs-parser.jay: Use System.CodeDOM now.