1 2005-01-30 Miguel de Icaza <miguel@novell.com>
3 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
4 is null it means that there has been no need to capture anything,
5 so we just create a sibling.
7 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
9 Just a partial fix. The other half is fairly elusive.
11 2005-02-10 Raja R Harinath <rharinath@novell.com>
13 Fix #52586, cs0121-4.cs.
14 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15 and return a hashtable.
16 (MemberCache.ClearDeclaredOnly): New.
17 (MemberCache.MemberCache): Update to change. Make a deep copy of
18 the method_hash of a base type too.
19 (MemberCache.AddMethods): Adapt to having a deep copy of the base
20 type methods. Overwrite entries with the same MethodHandle so
21 that the ReflectedType is correct. The process leaves in base
22 virtual functions and their overrides as distinct entries.
23 (CacheEntry): Now a class instead of a struct. It shouldn't alter
24 matters since it was boxed in a ArrayList before.
25 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
27 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
28 case of a virtual function and its override (choose the overload
30 (Invocation.OverloadResolve): Avoid 'override' members during
31 'applicable_type' calculation.
33 2005-03-28 Raja R Harinath <rharinath@novell.com>
35 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
36 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
37 GetTypeHandle. It is possible for a reflected type to derive from
38 a TypeBuilder (e.g., int[] derives from the TypeBuilder
39 System.Array during mscorlib compilation).
40 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
41 contain a method_hash, don't create one either. Don't create a
42 deep copy of the base cache's method_hash.
43 (MemberCache.SetupCache): Rename back from DeepCopy.
44 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
45 already initialized. If we see an override function, add its
46 underlying base virtual function to the member_hash too.
48 2005-02-09 Raja R Harinath <rharinath@novell.com>
50 Combine two near-redundant caches.
51 * typemanager.cs (method_params): Rename from method_internal_params.
52 (TypeManager.GetParameterData): New. Replace
53 Invocation.GetParameterData.
54 (TypeManager.LookupParametersByBuilder): Remove.
55 * expression.cs (Invocation.method_parameter_cache): Remove.
56 (Invocation.GetParameterData): Remove.
58 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
61 2005-02-08 Raja R Harinath <rharinath@novell.com>
64 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
65 TypeManager.multicast_delegate_type is null, resolve it by looking
66 up "System.MulticastDelegate".
67 * rootcontext.cs (RootContext.ResolveCore): Simplify.
69 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
70 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
71 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
74 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
75 (LabeledStatement.AddReference): New. Set 'referenced'.
76 (Goto.Resolve): Use it.
78 2005-02-05 John Luke <john.luke@gmail.com>
80 * driver.cs: remove duplicate -doc line in Usage ()
82 2005-02-04 Raja R Harinath <rharinath@novell.com>
84 * location.cs (Location.AddFile): Fix CS2002 error report.
86 2005-02-02 Martin Baulig <martin@ximian.com>
88 * delegate.cs (Delegate.DefineType): Report an internal error if
89 TypeManager.multicast_delegate_type is null. See bug #72015 for
92 2005-02-02 Raja R Harinath <rharinath@novell.com>
94 Fix a crasher in a variant of #31984.
95 * const.cs (Constant.CheckBase): New override that defers the
96 new-or-override check in case the base type hasn't been populated
98 (Constant.Define): Ensure the new-or-override check is performed.
100 2005-02-01 Duncan Mak <duncan@ximian.com>
102 * const.cs (LookupConstantValue): Check that `ce' is not null
103 before calling GetValue ().
105 2005-02-01 Raja R Harinath <rharinath@novell.com>
107 Fix test-334.cs (#69519).
108 * cs-parser.jay (using_alias_directive): Pass in an expression to
109 NamespaceEntry.UsingAlias.
110 (using_namespace_directive): Pass in an expression to
111 NamespaceEntry.Using.
112 (namespace_name): Don't flatten to a string.
113 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
114 (NamespaceEntry.AliasEntry.Resolve): Lookup using
116 (NamespaceEntry.UsingEntry): Likewise.
117 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
119 (NamespaceEntry.LookupForUsing): Remove.
120 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
122 (NamespaceEntry.Lookup): Remove support for dotted names.
124 2005-02-01 Raja R Harinath <rharinath@novell.com>
126 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
128 (NamespaceEntry.ImplicitParent): Compute on demand.
129 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
130 parallels the current.
131 (NamespaceEntry.LookupForUsing): Use it.
132 (NamespaceEntry.Lookup): If the current namespace-entry is
133 implicit, don't search aliases and using tables.
135 2005-02-01 Raja R Harinath <rharinath@novell.com>
138 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
140 (TypeContainer.BaseCache): Compute on demand.
141 (TypeContainer.FindMembers): Define constants and types if they're
143 (FieldMember.Define): Move resetting of ec.InUnsafe before error
145 * const.cs (Constant.Define): Make idempotent.
147 2005-01-29 Miguel de Icaza <miguel@novell.com>
149 * pending.cs: Produce better code (no nops produced by using Ldarg
152 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
153 i - 1' it should be arg + 1.
157 2005-01-28 Raja R Harinath <rharinath@novell.com>
159 * attribute.cs (Attribute.CheckAttributeType): Make private
161 (Attribute.ResolveType): Make virtual.
162 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
163 handling of RootContext.Tree.Types.
165 2005-01-27 Raja R Harinath <rharinath@novell.com>
167 Update attribute-handling to use the SimpleName/MemberAccess
169 * cs-parser.jay (attribute): Pass in an expression to the
170 constructors of Attribute and GlobalAttribute.
171 * attribute.cs (Attribute): Take an expression for the name.
172 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
173 passed in attribute name expression.
174 (Attribute.CheckAttributeType): Use it.
175 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
176 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
177 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
178 argument to prevent error messages if the lookup fails.
180 2005-01-27 Marek Safar <marek.safar@seznam.cz>
182 * expression.cs (Indirection): Implemented IVariable interface
183 to support indirection in AddressOf operator.
184 (PointerArithmetic.Emit): Add optimalization for case where
185 result can be precomputed.
187 2005-01-26 Martin Baulig <martin@ximian.com>
189 * class.cs (TypeContainer.AttributeTargets): Return the correct
190 AttributeTargets depending on our `Kind' instead of throwing an
191 exception; fixes #71632.
193 2005-01-26 Marek Safar <marek.safar@seznam.cz>
196 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
199 2005-03-17 Martin Baulig <martin@ximian.com>
201 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
202 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
204 2005-03-17 Martin Baulig <martin@ximian.com>
206 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
207 to bool so we can return an error condition.
208 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
211 2005-03-17 Martin Baulig <martin@ximian.com>
213 * generic.cs (TypeMananager.IsIEnumerable): New public method.
215 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
216 converting from an array-type of T to `IEnumerable<T>'.
218 2005-03-16 Martin Baulig <martin@ximian.com>
220 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
221 (Nullable.LiftedUnaryMutator): New public class.
223 * expression.cs (UnaryMutator.DoResolve): Added support for
226 2005-03-14 Martin Baulig <martin@ximian.com>
228 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
230 2005-03-14 Martin Baulig <martin@ximian.com>
232 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
233 the comparision operators `<', `>', `<=' and `>='.
235 2005-03-13 Martin Baulig <martin@ximian.com>
238 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
239 avoid confusion with the `NullLiteral'.
240 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
242 2005-03-13 Martin Baulig <martin@ximian.com>
244 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
245 comparing arbitrary types with the null literal.
247 2005-03-13 Martin Baulig <martin@ximian.com>
249 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
250 boolean operators '&&', '||', '&' and '|'.
251 (Nullable.OperatorTrueOrFalse): New public class.
253 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
254 instead of a `StaticCallExpr'; added support for nullables.
256 2005-03-10 Martin Baulig <martin@ximian.com>
259 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
260 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
262 2005-03-07 Martin Baulig <martin@ximian.com>
264 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
265 it work if `expr' is not an IMemoryLocation.
266 (Nullable.Lifted): Implement IMemoryLocation.
267 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
270 2005-03-05 Martin Baulig <martin@ximian.com>
272 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
273 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
274 (Nullable): Added support for lifted unary and binary operators.
276 * expression.cs (Unary.DoResolve): Added support for nullable types.
277 (Binary.DoResolve): Likewise.
278 (Conditional.DoResolve): Likewise.
280 2005-03-02 Martin Baulig <martin@ximian.com>
282 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
284 * class.cs (ClassPart.SetParameterInfo): Override this.
285 (PartialContainer.SetParameterInfo): Override this.
286 (TypeContainer.CheckConstraints): New protected method.
287 (PartialContainer.CheckConstraints): Override this and check
288 whether the same contraints were specified in all parts of a
289 partial generic type definition.
290 (PartialContainer.UpdateConstraints): New public method.
292 * generic.cs (TypeParameter.UpdateConstraints): New public method.
294 2005-03-02 Martin Baulig <martin@ximian.com>
296 Committing a patch from Carlos Alberto Cortez to fix #72887.
298 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
299 casts from `T []' to `int []'.
301 2005-03-02 Martin Baulig <martin@ximian.com>
303 * generic.cs (TypeManager.IsEqual): Make this symmetric.
305 * expression.cs (Binary.ResolveOperator): When resolving a
306 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
307 `=='. Fixes #71866. See gen-127.cs.
309 2005-03-02 Martin Baulig <martin@ximian.com>
311 * class.cs (TypeContainer.DoDefineMembers): We also need a default
312 static constructor in static classes.
314 2005-03-02 Martin Baulig <martin@ximian.com>
317 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
318 (Nullable.LiftedConversion): Added support for user-defined
321 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
323 * cs-parser.jay: Use ComposedCast everywhere instead of
324 NullableType, so we don't need to check for NullableType
326 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
327 case where we'll be resolved into a `parenthesized_expression_0'
331 (Convert.UserDefinedConversion): Added nullable conversions.
333 2005-02-28 Martin Baulig <martin@ximian.com>
335 * generic.cs (TypeManager.IsNullableType): New static method.
336 (Nullable): New abstract class.
337 (Nullable.NullLiteral): New public class.
338 (Nullable.LiftedConversion): New public class.
340 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
341 `builtin_types opt_nullable'.
344 (Convert.ImplicitConversionStandard): Added nullable conversions.
345 (Convert.ExplicitConversionStandard): Likewise.
346 (Convert.ExplicitConversion): Likewise.
348 2005-02-26 Martin Baulig <martin@ximian.com>
350 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
351 begin with a "?", for instance "?[]". Don't do a type lookup if
354 2005-02-25 Martin Baulig <martin@ximian.com>
356 The first part of Nullable Types :-)
358 * generic.cs (NullableType): New public class.
359 (NullCoalescingOperator): New public class.
360 (TypeArguments.Resolve): Add a CS0306 check.
362 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
363 (opt_nullable): New rule.
364 (type): Added `opt_nullable' to `namespace_or_type_name',
365 `builtin_types' and `pointer_type'.
366 (array_type): Added `opt_nullable'.
367 (opt_rank_specifier_or_nullable): New rule; this is the
368 combination of `opt_rank_specifier' and `opt_nullable'.
369 (opt_error): New rule; catch errors here.
370 (nullable_type_or_conditional): New rule; we use this to check for
371 nullable and still detect the conditional operator.
372 (local_variable_type): Use `opt_rank_specifier_or_nullable'
373 instead `opt_rank_specifier'.
375 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
378 2005-02-24 Martin Baulig <martin@ximian.com>
380 * README, README.Changes: Removed; they're old and obsolete.
382 2005-02-22 Martin Baulig <martin@ximian.com>
384 * generic.cs (TypeParameter.Resolve): If resolving the constraints
385 returned an error, set `constraints' to null to avoid a crash
387 (TypeParameter.ResolveType): Likewise.
389 2005-02-22 Martin Baulig <martin@ximian.com>
392 (Constraints.ResolveTypes): Protect against being called twice.
393 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
394 (TypeParameter.ResolveType): New public method; calls
395 constraints.ResolveTypes().
396 (TypeParameter.DefineType): Moved constraints.ResolveType() out
397 into the new ResolveType().
398 (GenericMethod.Define): Call ResolveType() on all our
401 2005-02-21 Martin Baulig <martin@ximian.com>
404 (TypeManager.generic_nullable_type): New static public field.
405 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
408 (RootContext.ResolveCore): Resolve "System.Nullable`1".
410 2005-02-15 Martin Baulig <martin@ximian.com>
412 * generic.cs (ConstructedType.Constraints): Correctly check
413 constraints if the argument type is a type parameter; fixes
416 2005-02-02 Martin Baulig <martin@ximian.com>
418 * delegate.cs (Delegate.DefineType): Report an internal error if
419 TypeManager.multicast_delegate_type is null. See bug #72015 for
422 2005-01-29 Miguel de Icaza <miguel@novell.com>
424 * pending.cs: Produce better code (no nops produced by using Ldarg
427 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
428 i - 1' it should be arg + 1.
432 2005-01-26 Martin Baulig <martin@ximian.com>
434 * cs-parser.jay (indexer_declarator): Don't report an error if we
435 have type parameters since we can be an explicit interface
436 implementation; fixes #71449.
438 2005-01-26 Martin Baulig <martin@ximian.com>
440 * class.cs (TypeContainer.AttributeTargets): Return the correct
441 AttributeTargets depending on our `Kind' instead of throwing an
442 exception; fixes #71632.
444 2005-01-26 Martin Baulig <martin@ximian.com>
446 * delegate.cs (Delegate.DefineType): Correctly define our type
447 parameters. Fixes #71483.
449 2005-01-25 Raja R Harinath <rharinath@novell.com>
452 * expression.cs (MemberAccess.DoResolve): Don't complain with
453 cs0572 when the LHS of a member access has identical name and type
456 2005-01-25 Marek Safar <marek.safar@seznam.cz>
459 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
461 Create custom PermissionSet only for PermissionSetAttribute.
463 2005-01-24 Marek Safar <marek.safar@seznam.cz>
466 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
467 delegates in static class.
469 2005-01-24 Martin Baulig <martin@ximian.com>
471 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
472 merging an implicit block, just use its reachability.
474 * statement.cs (Block.Resolve): Make the unreachable code check
475 work wrt. implicit blocks; see test-337 from #63842.
477 2005-01-21 Alp Toker <alp@atoker.com>
479 * cs-parser.jay: destructor_declaration's container is PartialContainer
480 not Class when partial types are used, so use Kind prop instead of
483 2005-01-22 Miguel de Icaza <miguel@ximian.com>
485 * cs-parser.jay: Improve error reporting when an interface
488 2005-01-20 Dick Porter <dick@ximian.com>
490 * support.cs: SeekableStreamReader fix from Sandor Dobos
491 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
492 chars are read. Fixes bug 70369.
494 2005-01-20 Raja R Harinath <rharinath@novell.com>
496 * cs-parser.jay (catch_clause): Simplify current_block handling
499 2005-01-17 Miguel de Icaza <miguel@ximian.com>
501 * convert.cs (ImplicitStandardConversionExists): Synchronize the
502 code with ImplicitStandardConversion to handle the implicit
503 conversion of method groups into valid delegate invocations.
505 The problem is that in parameter handling we were using this code
506 path. Fixes bug #64698
508 2005-01-19 Raja R Harinath <rharinath@novell.com>
510 * cs-parser.jay: Fix several infelicities.
511 - Avoid assigning to the parser value stack. Code like
512 '$3 = null' is unclean. Synthesize a value for the code block
514 - Avoid using oob_stack for storing location information. Use ...
515 (_mark_): ... this. New (empty) rule. Saves the current location
517 (foreach_statement): Avoid using oob_stack for current_block
518 handling. Use technique used in for_statement and
519 using_statement. Synthesize a value for the code block to store
520 additional intermediate information.
522 2005-01-13 Miguel de Icaza <miguel@ximian.com>
524 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
525 of a different type is only allowed to private fields of a
526 containing type, not on fields of a base class.
528 See test-174.cs and error cs0122-9.cs
530 2005-01-13 Raja R Harinath <rharinath@novell.com>
532 Fix test-335.cs (bug #58126).
533 * cs-parser.jay (argument): Split out non-expression parts of the
534 rule into 'non_simple_argument'.
535 (invocation_expression): Support parenthesized invocations with
536 multiple arguments, and with single non-simple arguments.
538 2005-01-13 Raja R Harinath <rharinath@novell.com>
540 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
543 2005-01-12 Raja R Harinath <rharinath@novell.com>
545 Fix cs0038-1.cs, cs1640-6.cs.
546 * ecore.cs (Expression.Resolve): Remove special-case for
547 SimpleName in error-handling.
548 (Expression.almostMatchedMembers): Relax access permission to
550 (Expression.MemberLookupFailed): Handle duplicates in
551 almostMatchedMembers list.
552 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
553 * expression.cs (New.DoResolve): Report CS1540 for more cases.
554 * typemanager.cs (GetFullNameSignature): Use the MethodBase
555 overload if the passed in MemberInfo is a MethodBase.
557 2005-01-25 Martin Baulig <martin@ximian.com>
560 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
562 2005-01-12 Marek Safar <marek.safar@seznam.cz>
565 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
566 for non-CAS & merge permission sets properly.
568 2005-01-11 Raja R Harinath <rharinath@novell.com>
570 Improve standard-compliance of simple name and member access
571 resolution. Fixes bugs #52697, #57200, #67520, #69519.
572 * ecore.cs (FullNamedExpression): New abstract base class
573 for Namespaces and TypeExpressions.
574 (ResolveFlags.SimpleName): Remove.
575 (SimpleName): Remove support for dotted names.
576 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
577 DeclSpace.FindType and DeclSpace.LookupType.
578 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
579 (Expression.ExprClassName): Make member function.
580 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
581 a namespace. Remove creation of dotted "SimpleName"s.
582 (MemberAccess.DoResolve): Likewise.
583 * decl.cs (DeclSpace.Cache): Make private.
584 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
585 (DeclSpace.FindType): Update.
586 (DeclSpace.LookupType): Move here from RootContext. Return a
588 * namespace.cs (Namespace): Derive from FullNamedExpression
589 so that it can be part of expression resolution.
590 (Namespace.Lookup): Return an FullNamedExpression.
591 (NamespaceEntry.LookupAlias): Lookup aliases only in current
593 * rootcontext.cs (NamespaceLookup): Remove.
594 (LookupType): Move to DeclSpace.
595 * attribute.cs (CheckAttributeType): Update.
596 * doc.cs (FindDocumentedType): Remove allowAlias argument.
597 (FindDocumentedTypeNonArray): Likewise.
599 2005-01-11 Raja R Harinath <rharinath@novell.com>
601 Fix cs0509.cs, cs1632.cs.
602 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
603 is the same as IsInterface.
604 (TypeContainer.GetClassBases): Likewise.
605 * statement.cs (LabeledStatement.ig): New field.
606 (LabeledStatement.LabelTarget): Save ILGenerator which created the
608 (LabeledStatement.DoEmit): Check that the label was created with
609 the same ILGenerator.
611 2005-01-10 Marek Safar <marek.safar@seznam.cz>
614 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
615 accessors to its properties.
617 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
618 from accessors to property.
620 2005-01-10 Marek Safar <marek.safar@seznam.cz>
623 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
626 2005-01-08 Miguel de Icaza <miguel@ximian.com>
628 * attribute.cs: Check for null and empty strings.
630 I have lost another battle to Paolo.
632 2005-01-07 Marek Safar <marek.safar@seznam.cz>
635 * class.cs (PropertyMethod): Set Parent field in ctors.
636 (SetMethod.InternalParameters): Add unsafe switch hack.
637 Override MarkForDuplicationCheck where it is appropriate.
639 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
640 It says whether container allows members with the same name.
642 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
643 Removed is_method parameter.
645 2005-01-06 Duncan Mak <duncan@ximian.com>
647 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
648 because the previous change led to incorrect reporting of CS1032
649 ("Cannot define/undefine preprocessor symbols after first token in
650 file"). Instead of using `tokens_seen' as the only flag that
651 triggers CS1040, introduce `comments_seen'. This new flag is used
652 to signify having seen comments on the current line, so it is
653 unset after a newline.
655 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
657 * doc.cs : When searching for a type, find nested type too.
658 This fixes bug #71040.
660 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
663 - Warn missing member comment on those classes which also does not
664 have doc comments. Fixed bug #71041.
665 - Don't warn missing doc comment on default constructor.
668 2005-01-06 Duncan Mak <duncan@ximian.com>
670 * cs-tokenizer.cs (xtoken): After handling traditional C-style
671 comments, set `tokens_seen' to true. This allows us to detect
672 misplaced preprocessor directives (i.e. not at the beginning of
673 the a line, nor after whitespaces). In that case, report error
674 CS1040. This fixes bug #56460.
676 * cs-parser.jay (interface_member_declaration): Add checks for
677 IsExplicitImpl, and report CS0541 error if an interface member is
678 defined as an explicit interface declaration.
680 2005-01-06 Marek Safar <marek.safar@seznam.cz>
683 * class.cs (PropertyMethod): Set Parent field in ctors.
684 (SetMethod.InternalParameters): Add unsafe switch hack.
686 * decl.cs (MemberCore.Parent): Cannot be readonly.
688 2005-01-06 Raja R Harinath <rharinath@novell.com>
690 * decl.cs (DeclSpace.ResolveType): Remove.
691 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
692 Merge in code from ...
693 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
694 * class.cs, enum.cs: Update to changes.
696 2005-01-06 Miguel de Icaza <miguel@ximian.com>
698 * anonymous.cs: Ensure that we init the scope of our parent if it
699 has not been initialized yet.
701 2004-12-30 Duncan Mak <duncan@ximian.com>
703 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
704 if field.FieldBuilder is null. Fixes #70758.
706 * convert.cs: Fixed some typos and updated some of the comments.
707 (ImplicitStandardConversionExists):
708 (TryImplicitIntConversion): If `target_type' is an interface and
709 the type of `ic' implements this interface, return true or a new
710 BoxedCast instead of null. This fixes #70468.
712 2004-12-29 Duncan Mak <duncan@ximian.com>
714 * expression.cs (Argument.Emit): Check that Expr is
715 IMemoryLocation before casting to it, and report CS1510 otherwise.
719 2004-12-21 Ben Maurer <bmaurer@ximian.com>
721 * statement.cs (Block.ThisVariable): remove the recursion here, to
722 make the --profile more sane.
724 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
726 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
727 assembly, by JB Evain.
729 2004-12-17 Raja R Harinath <rharinath@novell.com>
731 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
732 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
733 "parent" refers to enclosing type/class. "base" refers to superclass.
735 2004-12-17 Raja R Harinath <rharinath@novell.com>
737 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
738 Ensure that we only have GlobalAttributes.
739 * attribute.cs (Attribute.Emit): Make non-virtual.
740 (GlobalAttribute.Emit): Remove.
741 (Attribute.Resolve): Make virtual.
742 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
743 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
744 the argument. Don't create one.
745 (Attribute.GetObsoleteAttribute): Likewise.
746 (Attribute.GetClsCompliantAttributeValue): Likewise.
747 * class.cs, decl.cs: Update to changes.
749 2004-12-17 Marek Safar <marek.safar@seznam.cz>
751 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
753 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
755 * statement.cs (Foreach.Resolve): Add error 186 report.
757 2004-12-16 Marek Safar <marek.safar@seznam.cz>
759 * expression.cs (Conditional.DoResolve): Add warning 429.
761 * statement.cs (If.Resolve): Add warning 665.
763 2004-12-16 Raja R Harinath <rharinath@novell.com>
765 New invariant: RootContext.Tree.Types.NamespaceEntry == null
766 except when in the parser, and in GlobalAttribute.
767 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
768 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
769 RootContext.Tree.Types.NamespaceEntry once work is done.
770 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
771 and resets RootContext.Tree.Types.NamespaceEntry.
773 2004-12-15 Marek Safar <marek.safar@seznam.cz>
775 * cs-parser.jay: Don't create a block for every variable.
777 2004-12-14 Miguel de Icaza <miguel@ximian.com>
779 * location.cs: Provide extra information.
781 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
782 variables from the captured environment, it is the ldarg_0.
784 2004-12-14 Marek Safar <marek.safar@seznam.cz>
786 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
789 * class.cs: Changed warning level for 169 to avoid developer
790 displeasure from warning flooding. It will be changed back when they
791 fix most of current BCL warnings.
793 * RootContext.cs: Pushed default WarningLevel to 3.
795 * statement.cs: Removed unused variable.
797 2004-12-14 Marek Safar <marek.safar@seznam.cz>
799 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
800 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
801 Add error 502 report.
802 (StaticClass.DefineType): Add error 441 report.
803 (Class.AllowedModifiersProp): New virtual property as temporary
804 extension to AllowedModifiers.
805 (Class.DefineType): Add error 418 report. Moved ModFlags check here
806 to share implementation with StaticClass and don't call virtual
809 * driver.cs (MainDriver): Add error 1558 test.
811 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
812 report. Moved error 36 test here.
814 * statement.cs (Throw.Resolve): Add error 724 report.
816 * typemanager.cs: Add out_attribute_type core type.
818 2004-12-13 Marek Safar <marek.safar@seznam.cz>
820 * class.cs (TypeContainer.VerifyClsCompliance): Add error
822 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
824 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
827 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
829 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
830 Add error 3023 report.
831 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
833 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
836 2004-12-12 John Luke <john.luke@gmail.com>
838 * driver.cs (AddArgs): take -- into account when
839 adding arguments, fixes bug 65710
841 2004-12-12 Martin Baulig <martin@ximian.com>
843 * expression.cs (Unary.TryReduceNegative): Added support for
844 SByteConstant and ByteConstant.
845 (Unary.Reduce): Check error values from TryReduceNegative().
847 2004-12-10 Marek Safar <marek.safar@seznam.cz>
849 * attributes.cs (Attribute.Resolve): Avoid multiple error report
850 and report exception as error 182.
852 2004-12-10 Raja R Harinath <rharinath@novell.com>
854 * driver.cs (Main): Fix message when there are warnings.
856 2004-12-09 Miguel de Icaza <miguel@ximian.com>
858 * delegate.cs: Fixed my fix from yesterday, sorry about that.
860 2004-12-09 Marek Safar <marek.safar@seznam.cz>
862 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
863 Reduced number of warnings.
865 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
867 2004-12-08 Miguel de Icaza <miguel@ximian.com>
869 * driver.cs: Removed message.
871 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
873 2004-12-08 <vargaz@freemail.hu>
875 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
877 2004-12-08 Martin Baulig <martin@ximian.com>
879 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
880 instead of a CS3002 for properties and indexer.
882 2004-12-08 Martin Baulig <martin@ximian.com>
884 * decl.cs (MemberName.ToString): Make this work again.
886 2004-12-08 Marek Safar <marek.safar@seznam.cz>
888 * attribute.cs (Resolve): Add error 591 detection.
890 * class.cs (FieldMember.Define): Add error 1547 detection.
891 (Indexer.Define): Add error 620 detection.
892 (Operator.Define): Add error 590 detection.
894 * ecore.cs: Missing argument for error 79.
896 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
899 2004-12-07 Marek Safar <marek.safar@seznam.cz>
902 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
905 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
907 * cs-parser.jay : handle doc comments on implicit/explicit operators.
908 Some operator comments were suppressed.
909 * doc.cs : Implicit/explicit operator name in doc comments are like
910 "op_Explicit(type)~returnType", so added suffix handling.
912 2005-01-21 Alp Toker <alp@atoker.com>
914 * cs-parser.jay: destructor_declaration's container is PartialContainer
915 not Class when partial types are used, so use Kind prop instead of 'is'.
917 2004-12-12 Martin Baulig <martin@ximian.com>
919 * expression.cs (Unary.TryReduceNegative): Added support for
920 SByteConstant and ByteConstant.
921 (Unary.Reduce): Check error values from TryReduceNegative().
923 2004-12-11 Martin Baulig <martin@ximian.com>
925 * support.cs (ReflectionParameters.ParameterName): If we have a
926 `gpd', call `ParameterName' on it.
928 * parameter.cs (Parameter.GetParameterAttributes): New static method.
930 * pending.cs (PendingImplementation.DefineProxy): Call
931 DefineParameter() for all of the MethodBuilder's arguments.
933 2004-12-09 Martin Baulig <martin@ximian.com>
935 * doc.cs (DocUtil): Make this a static class.
937 2004-12-09 Martin Baulig <martin@ximian.com>
939 * expression.cs (Invocation.InferType): Moved the type inference
940 implementation into TypeManager.
942 * generics.cs (TypeManager): Moved the type inference
945 2004-12-09 Martin Baulig <martin@ximian.com>
947 * typemanager.cs (TypeManager): Make this a partial class.
950 (TypeManager): Move the generics part of `TypeManager' here.
952 2004-12-08 Martin Baulig <martin@ximian.com>
954 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
955 instead of a CS3002 for properties and indexer. Added CS3024
956 check for generic interfaces.
958 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
959 instances are not CLS-compliant.
961 2004-12-08 Martin Baulig <martin@ximian.com>
964 (void_pointer_expression): New rule for `void*', `void**' etc.
965 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
967 2004-12-08 Martin Baulig <martin@ximian.com>
969 * expression.cs (Invocation.InferType): Removed the hack for
970 MethodCore.MayUnify().
972 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
975 * class.cs (MethodCore.MayUnify): Use
976 TypeManager.MayBecomeEqualGenericTypes().
978 2004-12-08 Martin Baulig <martin@ximian.com>
980 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
981 parameter, box it. Fixes #69233.
983 2004-12-08 Martin Baulig <martin@ximian.com>
985 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
986 have the ctor constraint. Fixes #68326.
988 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
990 * cs-parser.jay : interface comment was not consumed because of
991 extra opt_semicolon before doc handling.
993 2004-12-03 Raja R Harinath <rharinath@novell.com>
995 Fix test-327.cs, test-328.cs, and put in early infrastructure
996 for eventually fixing #52697.
997 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
998 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
1000 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
1001 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
1002 (VerifyUsing, error246): Update.
1003 * rootcontext.cs (RootContext.NamespaceLookup): Just use
1004 'NamespaceEntry.LookupNamespaceOrType'.
1006 2004-12-07 Martin Baulig <martin@ximian.com>
1008 * driver.cs: Call it "BETA SOFTWARE" :-)
1010 2004-12-06 Raja R Harinath <rharinath@novell.com>
1012 Fix crash on cs0657-17.cs.
1013 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
1014 Use RootContext.Tree.Types, not 'new RootTypes ()'.
1015 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
1016 the case where the NamespaceEntry gets overwritten.
1018 2004-12-06 Marek Safar <marek.safar@seznam.cz>
1020 Fixed #69195, #56821
1021 * ecore.cs (ResolveBoolean): Tiny refactoring.
1023 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
1024 of right expression resolving when left is false constant and
1025 operator is LogicalAnd OR true constant and operator is LogicalOr.
1027 * statement.cs (ResolveUnreachable): Always reports warning.
1029 2004-12-05 Miguel de Icaza <miguel@ximian.com>
1031 * class.cs: Distinguish between 1721 and 1722 (just a little help
1032 for the programmer).
1034 2004-12-03 Miguel de Icaza <miguel@ximian.com>
1036 * delegate.cs: Only allow this on new versions of the language.
1038 2004-12-02 Duncan Mak <duncan@ximian.com>
1040 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
1042 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
1043 here as a static method. Take an additional bool out parameter
1044 `must_do_cs1540_check' for signaling to InstanceResolve.
1045 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
1046 member field from PropertyExpr class and made it an argument of
1048 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
1049 check for MarshalByRefObject, and report CS0122 instead of CS1540.
1050 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
1051 and `remove_accessor' as well as InstanceResolve: report CS0122
1056 2004-12-07 Martin Baulig <martin@ximian.com>
1058 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
1059 and CS0692 where appropriate.
1061 2004-12-06 Martin Baulig <martin@ximian.com>
1063 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
1064 IsDuplicateImplementation() and improved it.
1066 * expression.cs (Invocation.InferTypeArguments): Added
1067 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
1068 and removed the "ref" modifier from `infered_types'.
1070 * decl.cs (MemberName.ToString): Removed the exception.
1072 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
1074 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
1075 comments are allowed.
1077 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
1079 * delegate.cs: Add checks for subtypes in paramaters and return values
1080 in VerifyMethod () to add support for Covariance/Contravariance
1083 2004-12-02 Miguel de Icaza <miguel@ximian.com>
1085 * report.cs: Remove extra closing parenthesis.
1087 * convert.cs (Error_CannotImplicitConversion): If the name of the
1088 types are the same, provide some extra information.
1090 2004-12-02 Marek Safar <marek.safar@seznam.cz>
1093 * attribute.cs (Resolve): Improved implementation of params
1094 attribute arguments.
1096 * support.cs (ParameterData): Add HasParams to be faster.
1098 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
1100 all things are for /doc support:
1102 * doc.cs: new file that supports XML documentation generation.
1103 * mcs.exe.sources: added doc.cs.
1105 Handle /doc command line option.
1106 Report error 2006 instead of 5 for missing file name for /doc.
1107 Generate XML documentation when required, after type resolution.
1109 Added support for picking up documentation (/// and /** ... */),
1110 including a new XmlCommentState enumeration.
1112 Added lines to fill Documentation element for field, constant,
1113 property, indexer, method, constructor, destructor, operator, event
1114 and class, struct, interface, delegate, enum.
1115 Added lines to warn incorrect comment.
1117 Added Documentation field (passed only when /doc was specified).
1119 Added DocComment, DocCommentHeader, GenerateDocComment() and
1120 OnGenerateDocComment() and some supporting private members for
1121 /doc feature to MemberCore.
1123 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
1125 Added overriden DocCommentHeader.
1127 Added overriden DocCommentHeader and GenerateDocComment().
1129 2004-12-01 Miguel de Icaza <miguel@ximian.com>
1131 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
1132 unwrapping the enumeration values, chain to
1133 DoConstantNumericPromotions again, so we can promote things to the
1134 fundamental types (takes care of enums that are bytes, sbytes).
1138 2004-12-01 Raja R Harinath <rharinath@novell.com>
1140 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
1141 Fix long-standing bug in type-lookup. Use FindType instead of
1142 LookupType when ec.ResolvingTypeTree.
1143 (Attribute.ResolveType, Attribute.Resolve)
1144 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
1146 (Attributes.Search): Remove internal version. Update.
1147 (Attributes.SearchMulti): Update.
1148 (Attributes.GetClsCompliantAttribute): Remove.
1149 (Attributes.GetIndexerNameAttribute): Remove.
1150 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
1151 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
1152 * class.cs (Indexer.Define): Likewise.
1154 2004-12-01 Marek Safar <marek.safar@seznam.cz>
1157 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
1158 MarshallByReference members access.
1160 * expression.cs: Use CheckMarshallByRefAccess;
1161 Better error CS0197 message.
1163 * report.cs: Print whole related error message.
1165 2004-11-29 Marek Safar <marek.safar@seznam.cz>
1167 * class (GetClassBases): Better error 60 report.
1168 (EventProperty): Disabled warning 67 detection.
1170 2004-11-29 Marek Safar <marek.safar@seznam.cz>
1173 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
1175 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
1178 2004-11-29 Marek Safar <marek.safar@seznam.cz>
1181 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
1183 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
1185 2004-11-26 Miguel de Icaza <miguel@ximian.com>
1187 * attribute.cs (Attribute.Resolve): Refine error reporting and
1188 report a cs0117 if the identifier does not exist, to distinguish
1189 from 0617 which is a miss-use of the actual identifier.
1191 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
1192 between cs0070 and cs0079.
1194 * class.cs (MemberBase.DoDefine): When reporting a wrong
1195 accessibility level, we use MethodCore to compare instead of
1196 Method (this was a regression in some refactoring effort).
1198 So now we correctly report cs0056 again.
1200 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
1201 testing the target_type (which was known to be object_type) and
1202 not the source type (which is anonymous_method).
1204 Fixed reporting of error cs1660.
1206 * expression.cs (UserCast.Source): Expose the underlying cast.
1208 * statement.cs (Switch.SwitchGoverningType): Sort the list of
1209 allowed types to find a match to int32 first (most common).
1211 In addition, it ignores any ImplicitUserConversions that did an
1212 internal implicit conversion (as the switch statement allows only
1213 one integral conversion to exist).
1215 * class.cs (PartialContainer.Create): rename `name' to
1216 `member_name' for clarity. Then replace the string calls with a
1217 call to MemberName.GetPartialName, as now using
1218 MemberName.ToString is an error (this is due to the side effects
1219 it had, that were fixed in the past).
1221 This will restore the error reporting on a number of partial class
1222 errors that were missusing this (and getting an exception as a
1223 results, which is now just a plain textual warning, because
1224 yyparse debug output would crash otherwise).
1226 2004-11-26 Raja R Harinath <rharinath@novell.com>
1228 * Makefile (PROGRAM_INSTALL_DIR): Remove.
1230 2004-11-25 Ben Maurer <bmaurer@ximian.com>
1232 * rootcontext.cs (LookupType): Make sure to cache lookups that
1233 don't give us a negative result. This saves about 5% of corlib
1236 2004-11-25 Miguel de Icaza <miguel@ximian.com>
1238 * report.cs (AbstractMessage.Print): messages are sent to stderr
1240 * class.cs (TypeContainer.GetClassBases): It is an error to have a
1241 non-interface in the list of interfaces (at this point, either
1242 parent was properly set, or a base class is being listed in the
1243 interfaces section).
1245 This flags error 1722, and resolves the crash from bug 69259.
1247 2004-11-25 Ben Maurer <bmaurer@ximian.com>
1249 * statement.cs (Using.EmitExpressionFinally): make this work right
1250 for valuetypes. Fixes 69926.
1252 2004-11-25 Miguel de Icaza <miguel@ximian.com>
1254 * const.cs (Const.ChangeType): Cope with the "0 literal can be
1255 converted to an enum" here, before we try to change the underlying
1256 type. This code exists, but it is a different code path than the
1257 one used while encoding constants.
1259 (ImplicitReferenceConversionExists): In addition, resynchronized
1260 the code here, so it matches the same code in
1261 ImplicitReferenceConversionExists for the `from any class-type S
1262 to any interface-type T'.
1264 2004-11-25 Marek Safar <marek.safar@seznam.cz>
1266 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
1268 2004-11-24 Miguel de Icaza <miguel@ximian.com>
1270 * cs-parser.jay: Use verbosity accordingly.
1272 2004-11-24 Marek Safar <marek.safar@seznam.cz>
1274 * expression.cs (Unary.ResolveOperator): Do not report warning;
1275 AddressOf reads from variable.
1277 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
1279 2004-11-24 Marek Safar <marek.safar@seznam.cz>
1283 * attribute.cs (Attributable): Removed CheckTargets.
1284 (Attributes.Emit): Explicit attribute targets are tested here.
1286 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
1287 not enabled for interfaces.
1289 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
1290 (GetAssemblyName): Ouch next bug there.
1292 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
1294 * expression.cs: Error 275 added.
1296 2004-11-23 Marek Safar <marek.safar@seznam.cz>
1298 Fix bug #69177 (Implemented decimal constant support)
1300 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
1301 (BinaryFold): Add DecimalConstant.
1303 * const.cs (Define): Decimal constant
1305 (ChangeType): Add decimal type handling.
1306 (LookupConstantValue): Don't set value for decimal type but
1307 emit DecimalConstantAttribute. Needed for constant optimization.
1309 * constant.cs (ToDecimal): New method.
1310 (ConvertToDecimal): New method.
1311 (IntConstant): Implemented ConvertToDecimal.
1312 (DecimalConstant.Emit): Emit optimized version for decimals in
1315 * expression.cs (ResolveOperator): Changed order of constant
1316 reduction to work correctly with native types which have
1317 overloaded operators.
1318 (ResolveMemberAccess): Extract constant value from attribute
1321 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
1323 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
1324 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
1325 (ChangeType): Decimal is special.
1326 (TypeToCoreType): Add decimal type.
1328 2004-11-22 Marek Safar <marek.safar@seznam.cz>
1330 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
1333 2004-11-22 Marek Safar <marek.safar@seznam.cz>
1335 * class.cs (EventField.ApplyAttributeBuilder): Fix error
1338 2004-11-19 Marek Safar <marek.safar@seznam.cz>
1340 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
1342 * pending.cs (PendingImplementation): Grab only interfaces.
1344 2004-11-19 Marek Safar <marek.safar@seznam.cz>
1346 * statement.cs (ForeachHelperMethods): Add location member and
1347 error 202 detection.
1349 2004-11-18 Marek Safar <marek.safar@seznam.cz>
1351 * expression.cs (DoResolveBase): Fixed wrong warning for out
1354 2004-12-04 Martin Baulig <martin@ximian.com>
1356 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
1357 to check whether the conversion is ok.
1359 * typemanager.cs (TypeManager.GetTypeArguments): Just return
1360 `Type.EmptyTypes' if we're not a generic TypeContainer.
1362 2004-11-25 Miguel de Icaza <miguel@ximian.com>
1364 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
1365 old bug: when converting from the null literal to a pointer,
1366 return an EmptyCast, not the NullLiteral.
1368 This fixes #69921, the recent null_type changes probably made this
1371 2004-12-03 Martin Baulig <martin@ximian.com>
1373 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
1374 method as our child, call AnonymousMethod.Compatible() on it.
1376 2004-12-02 Miguel de Icaza <miguel@ximian.com>
1378 * class.cs (FieldBase): Use an unused bit field from the field to
1379 encode the `has_offset' property from the FieldMember. This saves
1380 a couple of Ks on bootstrap compilation.
1382 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
1383 method as our child, return the AnonymousMethod resolved
1386 * expression.cs (New.DoResolve): Allow return values from
1387 NewDelegate to also include AnonymousMethods.
1391 2004-11-29 Raja R Harinath <rharinath@novell.com>
1393 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
1395 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
1396 System.Runtime.InteropServices._Exception, since it's a base
1397 interface of the core type System.Exception in the net_2_0 profile.
1399 2004-11-27 Martin Baulig <martin@ximian.com>
1401 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
1403 2004-11-26 Raja R Harinath <rharinath@novell.com>
1405 * Makefile: Convert to use executable.make.
1406 * gmcs.exe.sources: New.
1408 2004-11-25 Martin Baulig <martin@ximian.com>
1410 * expression.cs (Invocation.InferType): Added support for byref types.
1412 2004-11-25 Martin Baulig <martin@ximian.com>
1414 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
1415 in TypeManager.TypeToCoreType().
1417 2004-11-25 Martin Baulig <martin@ximian.com>
1419 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
1420 "Dispose" method from the `current_type'.
1421 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
1422 DoDefineMembers() instead of using the MethodBuilder; this is
1423 required for generic iterators.
1425 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
1427 2004-11-24 Martin Baulig <martin@ximian.com>
1429 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
1431 2004-11-20 Martin Baulig <martin@ximian.com>
1433 * expression.cs (Invocation.InferType): Correctly infer generic
1434 instances; see gen-103.cs.
1435 (Invocation.InferTypeArguments): If a generic method doesn't have
1436 any unbound type parameters, we don't need to infer anything.
1438 2004-11-19 Raja R Harinath <rharinath@novell.com>
1440 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
1442 2004-11-17 Raja R Harinath <rharinath@novell.com>
1444 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
1445 (TypeHandle.GetMemberCache): New.
1446 (TypeHandle.TypeHandle): Update.
1447 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
1448 (TypeManager.LookupParentInterfacesCache):
1449 Rename from LookupInterfaceCache. Optimize slightly.
1450 (TypeManager.MemberLookup_FindMembers): Update.
1451 * decl.cs (MemberCache.MemberCache): Set Container to null in the
1453 (AddCacheContents): Rename from AddHashtable.
1454 * class.cs (TypeContainer.parent_container): Remove.
1455 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
1456 (TypeContainer.DoDefineMembers): Don't initialize it.
1457 Update to name changes.
1459 2004-11-17 Miguel de Icaza <miguel@ximian.com>
1461 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
1462 that factors the code to check access modifiers on override.
1464 (PropertyBase): Use the code here.
1466 Patch from Lluis S'anchez, fixes bug #69361.
1468 2004-11-15 Miguel de Icaza <miguel@ximian.com>
1470 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
1471 routine that is used to report the use of a captured variable
1472 whose address has been taken.
1474 There are two checks: one when variables are being captured and
1475 the other check is when the address of a variable is taken.
1477 (because an anonymous methods might be resolved before *or* after
1478 the address has been taken) and
1480 * expression.cs (Conditional.DoResolve): Remove the special
1481 casing that Martin added to trueExpr and falseExpr being both
1482 NullLiteral. We get the right behavior now just by introducing
1483 the null_type into the compiler.
1485 * convert.cs (ExplicitConversion): Change the code to use
1486 null_type instead of testing `expr is NullLiteral'.
1487 (ImplicitConversionStandard): use null_type too.
1488 (ImplicitReferenceConversionExists): use null_type too.
1489 (ImplicitReferenceConversion): use null_type too.
1491 * literal.cs: The type of `NullLiteral' is now null_type instead
1493 (Resolve): Set the type here.
1495 * typemanager.cs: Introduce null_type.
1497 2004-11-18 Martin Baulig <martin@ximian.com>
1500 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
1502 2004-11-18 Martin Baulig <martin@ximian.com>
1504 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
1506 2004-11-18 Martin Baulig <martin@ximian.com>
1508 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
1509 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
1510 call ResolveConstructedType() on it to resolve it without checking
1512 (Constraints.ResolveTypes): Check them here.
1513 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
1514 but don't check constraints.
1515 (ConstructedType.ResolveAsTypeTerminal): Override this and also
1516 check constraints here.
1517 (ConstructedType.ResolveConstructedType): New public method. This
1518 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
1519 resolve ourselves without checking constraints.
1521 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
1523 2004-11-18 Martin Baulig <martin@ximian.com>
1526 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
1528 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
1530 2004-11-18 Martin Baulig <martin@ximian.com>
1532 * ecore.cs (TypeExpr.ResolveType): Removed.
1533 (Expression.ResolveAsTypeTerminal): We always return a fully
1534 resolved `TypeExpr', so we can just access its `Type'.
1536 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
1538 2004-11-17 Martin Baulig <martin@ximian.com>
1540 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
1541 sure we don't return any unresolved TypeExpr's.
1542 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
1544 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
1546 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
1547 unresolved `ConstructedType's.
1549 2004-11-17 Martin Baulig <martin@ximian.com>
1551 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
1553 2004-11-17 Martin Baulig <martin@ximian.com>
1556 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
1558 * decl.cs (DeclSpace.ResolveType): Removed.
1559 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
1561 2004-11-17 Martin Baulig <martin@ximian.com>
1563 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
1564 direction, like FindMembers() does. Fixes #69546, testcase is in
1567 2004-11-16 Martin Baulig <martin@ximian.com>
1569 This is based on a patch from Marek Safar, see bug #69082.
1570 Fixes bugs #63705 and #67130.
1572 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
1573 method; create a MemberCache for an interface type and cache the
1576 * decl.cs (IMemberContainer.ParentContainer): Removed.
1577 (IMemberContainer.ParentCache): New property.
1578 (MemberCache.SetupCacheForInterface): Removed.
1579 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
1580 to create a cache for an interface's "parent".
1582 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
1585 2004-11-14 Ben Maurer <bmaurer@ximian.com>
1587 * statement.cs: Avoid adding bools to a hashtable.
1589 2004-11-15 Martin Baulig <martin@ximian.com>
1591 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
1593 2004-11-11 Martin Baulig <martin@ximian.com>
1595 * typemanager.cs (TypeManager.GetMethodName): New method.
1597 * class.cs (MethodData.Define): Include the generic arity in the
1598 name of an explicit interface; also add it to the method name.
1600 * pending.cs (PendingImplementation.InterfaceMethod): The method
1601 name now includes the generic arity.
1603 2004-11-07 Miguel de Icaza <miguel@ximian.com>
1605 * expression.cs (Invocation.OverloadResolve): Flag error if we are
1606 calling an unsafe method from a safe location.
1608 2004-11-06 Marek Safar <marek.safar@seznam.cz>
1611 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
1613 2004-11-06 Miguel de Icaza <miguel@ximian.com>
1615 * namespace.cs (VerifyUsing): use GetPartialName instead of
1618 2004-11-05 Miguel de Icaza <miguel@ximian.com>
1620 * statement.cs (Return.Resolve): Fix regression in typo: if
1621 `in_exc', we have to request a NeedReturnLabel, this was a typo
1622 introduced in the anonymous method check-in. Fixes #69131.
1624 * Indexers were using the ShortName when defining themselves,
1625 causing a regression in the compiler bootstrap when applying the
1626 patch from 2004-11-02 (first part), now they use their full name
1627 and the bug is gone.
1629 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
1631 * driver.cs: Strip the path from the names of embedded resources. Fixes
1634 2004-11-04 Raja R Harinath <rharinath@novell.com>
1636 Fix error message regression: cs0104-2.cs.
1637 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
1638 (AliasEntry.Resolve): Update.
1639 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
1641 (RootContext.LookupType): Update.
1643 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
1645 * cs-parser.jay: Add support for handling accessor modifiers
1646 * class: Add support port accessor modifiers and error checking,
1647 define PropertyMethod.Define as virtual (not abstract anymore)
1648 * ecore.cs: Add checking for proeprties access with access modifiers
1649 * iterators.cs: Modify Accessor constructor call based in the modified
1651 2004-11-02 Ben Maurer <bmaurer@ximian.com>
1653 * expression.cs (StringConcat): Handle being called twice,
1654 as when we have a concat in a field init with more than two
1657 2004-11-02 Miguel de Icaza <miguel@ximian.com>
1659 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
1660 special case explicit implementations, we should always produce
1661 the .property or .event declaration.
1663 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
1664 since it will not return correct data if people use this
1665 unresolved in the presence of using statements (see test-313).
1667 * class.cs (MethodData.Define): If we are an explicit interface
1668 implementation, set the method name to the full name of the
1669 interface plus the name of the method.
1671 Notice that using the method.MethodName.GetFullName() does not
1672 work, as it will only contain the name as declared on the source
1673 file (it can be a shorthand in the presence of using statements)
1674 and not the fully qualifed type name, for example:
1678 class D : ICloneable {
1679 object ICloneable.Clone () {
1683 Would produce a method called `ICloneable.Clone' instead of
1684 `System.ICloneable.Clone'.
1686 * namespace.cs (Alias.Resolve): Use GetPartialName.
1688 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1690 * cs-parser.jay: Add error 1055 report.
1692 2004-11-01 Miguel de Icaza <miguel@ximian.com>
1694 * assign.cs (Assign.DoResolve): Only do the transform of
1695 assignment into a New if the types are compatible, if not, fall
1696 through and let the implicit code deal with the errors and with
1697 the necessary conversions.
1699 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1701 * cs-parser.jay: Add error 1031 report.
1703 * cs-tokenizer.cs: Add location for error 1038.
1705 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1707 * cs-parser.jay: Add error 1016 report.
1709 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1711 * cs-parser.jay: Add errors 1575,1611 report.
1713 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1715 * cs-parser.jay: Add error 1001 report.
1717 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1720 * attribute.cs (GetMarshal): Add method argument for
1721 caller identification.
1723 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
1724 agument for GetMarshal and RuntimeMissingSupport.
1726 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1728 * attribute.cs (ExtractSecurityPermissionSet): Removed
1729 TypeManager.code_access_permission_type.
1731 * typemanager.cs: Removed TypeManager.code_access_permission_type.
1733 2004-10-27 Miguel de Icaza <miguel@ximian.com>
1735 * expression.cs (LocalVariableReference.DoResolveLValue): Check
1736 for obsolete use of a variable here. Fixes regression on errors
1737 cs0619-25 and cs0619-26.
1739 2004-10-27 Marek Safar <marek.safar@seznam.cz>
1741 Fix #62358, implemented security attribute encoding.
1743 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
1744 Tests permitted SecurityAction for assembly or other types.
1745 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
1746 data from SecurityPermissionAttribute to PermisionSet class.
1748 * class.cs (ApplyAttributeBuilder): Added special handling
1749 for System.Security.Permissions.SecurityAttribute based types.
1751 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
1752 special handling for System.Security.Permissions.SecurityAttribute
1755 * enum.cs (ApplyAttributeBuilder): Added special handling
1756 for System.Security.Permissions.SecurityAttribute based types.
1758 * parameter.cs (ApplyAttributeBuilder): Added special handling
1759 for System.Security.Permissions.SecurityAttribute based types.
1761 * rootcontext.cs: Next 2 core types.
1763 * typemanager.cs (TypeManager.security_permission_attr_type):
1764 Built in type for the SecurityPermission Attribute.
1765 (code_access_permission_type): Build in type.
1767 2004-10-17 Miguel de Icaza <miguel@ximian.com>
1769 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
1770 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
1771 all of this information into
1772 EmitContext.EmitCapturedVariableInstance.
1774 * codegen.cs (EmitCapturedVariableInstance): move here the
1775 funcionality of emitting an ldarg.0 in the presence of a
1776 remapping. This centralizes the instance emit code.
1778 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
1779 then emit a load of this: it means that we have reached the
1780 topmost ScopeInfo: the one that contains the pointer to the
1781 instance of the class hosting the anonymous method.
1783 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
1784 captures to the topmost CaptureContext.
1786 2004-10-12 Miguel de Icaza <miguel@ximian.com>
1788 * expression.cs (LocalVariableReference): Move the knowledge about
1789 the iterators into codegen's EmitCapturedVariableInstance.
1791 2004-10-11 Miguel de Icaza <miguel@ximian.com>
1793 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
1794 all code paths return a value from an anonymous method (it is the
1795 same as the 161 error, but for anonymous methods).
1797 2004-10-08 Miguel de Icaza <miguel@ximian.com>
1799 The introduction of anonymous methods in the compiler changed
1800 various ways of doing things in the compiler. The most
1801 significant one is the hard split between the resolution phase
1802 and the emission phases of the compiler.
1804 For instance, routines that referenced local variables no
1805 longer can safely create temporary variables during the
1806 resolution phase: they must do so from the emission phase,
1807 since the variable might have been "captured", hence access to
1808 it can not be done with the local-variable operations from the runtime.
1812 (Block.Flags): New flag `IsTopLevel' to indicate that this block
1813 is a toplevel block.
1815 (ToplevelBlock): A new kind of Block, these are the blocks that
1816 are created by the parser for all toplevel method bodies. These
1817 include methods, accessors and anonymous methods.
1819 These contain some extra information not found in regular blocks:
1820 A pointer to an optional CaptureContext (for tracking captured
1821 local variables and parameters). A pointer to the parent
1824 (Return.Resolve): Catch missmatches when returning a value from an
1825 anonymous method (error 1662).
1826 Invoke NeedReturnLabel from the Resolve phase instead of the emit
1829 (Break.Resolve): ditto.
1831 (SwitchLabel): instead of defining the labels during the
1832 resolution phase, we now turned the public ILLabel and ILLabelCode
1833 labels into methods called GetILLabelCode() and GetILLabel() that
1834 only define the label during the Emit phase.
1836 (GotoCase): Track the SwitchLabel instead of the computed label
1837 (its contained therein). Emit the code by using
1838 SwitchLabel.GetILLabelCode ().
1840 (LocalInfo.Flags.Captured): A new flag has been introduce to track
1841 whether the Local has been captured or not.
1843 (LocalInfo.IsCaptured): New property, used to tell whether the
1844 local has been captured.
1846 * anonymous.cs: Vastly updated to contain the anonymous method
1849 The main classes here are: CaptureContext which tracks any
1850 captured information for a toplevel block and ScopeInfo used to
1851 track the activation frames for various local variables.
1853 Each toplevel block has an optional capture context associated
1854 with it. When a method contains an anonymous method both the
1855 toplevel method and the anonymous method will create a capture
1856 context. When variables or parameters are captured, they are
1857 recorded on the CaptureContext that owns them, for example:
1861 MyDelegate d = delegate {
1866 Here `a' will be recorded as captured on the toplevel
1867 CapturedContext, the inner captured context will not have anything
1868 (it will only have data if local variables or parameters from it
1869 are captured in a nested anonymous method.
1871 The ScopeInfo is used to track the activation frames for local
1872 variables, for example:
1874 for (int i = 0; i < 10; i++)
1875 for (int j = 0; j < 10; j++){
1876 MyDelegate d = delegate {
1881 At runtime this captures a single captured variable `i', but it
1882 captures 10 different versions of the variable `j'. The variable
1883 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
1884 recorded on a child.
1886 The toplevel ScopeInfo will also track information like the `this'
1887 pointer if instance variables were referenced (this is necessary
1888 as the anonymous method lives inside a nested class in the host
1889 type of the method).
1891 (AnonymousMethod): Expanded to track the Toplevel, implement
1892 `AnonymousMethod.Compatible' to tell whether an anonymous method
1893 can be converted to a target delegate type.
1895 The routine now also produces the anonymous method content
1897 (AnonymousDelegate): A helper class that derives from
1898 DelegateCreation, this is used to generate the code necessary to
1899 produce the delegate for the anonymous method that was created.
1901 * assign.cs: API adjustments for new changes in
1902 Convert.ImplicitStandardConversionExists.
1904 * class.cs: Adjustments to cope with the fact that now toplevel
1905 blocks are of type `ToplevelBlock'.
1907 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
1908 insteda of standard blocks.
1910 Flag errors if params arguments are passed to anonymous methods.
1912 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
1913 `CurrentAnonymousMethod' which points to the current Anonymous
1914 Method. The variable points to the AnonymousMethod class that
1915 holds the code being compiled. It is set in the new EmitContext
1916 created for the anonymous method.
1918 (EmitContext.Phase): Introduce a variable and an enumeration to
1919 assist in enforcing some rules about when and where we are allowed
1920 to invoke certain methods (EmitContext.NeedsReturnLabel is the
1921 only one that enfonces this right now).
1923 (EmitContext.HaveCaptureInfo): new helper method that returns
1924 whether we have a CapturedContext initialized.
1926 (EmitContext.CaptureVariable): New method used to register that a
1927 LocalInfo must be flagged for capturing.
1929 (EmitContext.CapturedParameter): New method used to register that a
1930 parameters must be flagged for capturing.
1932 (EmitContext.CapturedField): New method used to register that a
1933 field must be flagged for capturing.
1935 (EmitContext.HaveCapturedVariables,
1936 EmitContext.HaveCapturedFields): Return whether there are captured
1937 variables or fields.
1939 (EmitContext.EmitMethodHostInstance): This is used to emit the
1940 instance for the anonymous method. The instance might be null
1941 (static methods), this (for anonymous methods that capture nothing
1942 and happen to live side-by-side with the current method body) or a
1943 more complicated expression if the method has a CaptureContext.
1945 (EmitContext.EmitTopBlock): Routine that drives the emission of
1946 code: it will first resolve the top block, then emit any metadata
1947 and then emit the code. The split is done so that we can extract
1948 any anonymous methods and flag any captured variables/parameters.
1950 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
1951 during this phase, the ILGenerator should not be used as labels
1952 and local variables declared here might not be accessible to any
1953 code that is part of an anonymous method.
1955 Exceptions to this include the temporary variables that are
1956 created by some statements internally for holding temporary
1959 (EmitContext.EmitMeta): New routine, in charge of emitting all the
1962 (EmitContext.TemporaryReturn): This method is typically called
1963 from the Emit phase, and its the only place where we allow the
1964 ReturnLabel to be defined other than the EmitMeta. The reason is
1965 that otherwise we would have to duplicate a lot of logic in the
1966 Resolve phases of various methods that today is on the Emit
1969 (EmitContext.NeedReturnLabel): This no longer creates the label,
1970 as the ILGenerator is not valid during the resolve phase.
1972 (EmitContext.EmitThis): Extended the knowledge in this class to
1973 work in anonymous methods in addition to iterators.
1975 (EmitContext.EmitCapturedVariableInstance): This emits whatever
1976 code is necessary on the stack to access the instance to a local
1977 variable (the variable will be accessed as a field).
1979 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
1980 EmitContext.EmitAddressOfParameter): Routines to support
1981 parameters (not completed at this point).
1983 Removals: Removed RemapLocal and RemapLocalLValue. We probably
1984 will also remove the parameters.
1986 * convert.cs (Convert): Define a `ConstantEC' which points to a
1987 null. This is just to prefity some code that uses
1988 ImplicitStandardConversion code and do not have an EmitContext
1991 The idea is to flag explicitly that at that point in time, it is
1992 known that the conversion will not trigger the delegate checking
1993 code in implicit conversions (which requires a valid
1996 Everywhere: pass new EmitContext parameter since
1997 ImplicitStandardConversionExists now requires it to check for
1998 anonymous method conversions.
2000 (Convert.ImplicitStandardConversionExists): If the type of an
2001 expression is the anonymous_method_type, and the type is a
2002 delegate, we invoke the AnonymousMethod.Compatible method to check
2003 whether an implicit conversion is possible.
2005 (Convert.ImplicitConversionStandard): Only do implicit method
2006 group conversions if the language level is not ISO_1.
2008 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
2009 MethodInfo for the Invoke method. used by Delegate and
2012 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
2013 method conversions if the target type is a delegate.
2015 Removed extra debugging nops.
2017 (LocalVariableReference): Turn the `local_info' into a public
2020 Add `prepared' field, the same hack used for FieldExprs to cope
2021 with composed assignments, as Local variables do not necessarily
2022 operate purely on the stack as they used to: they can be captured
2025 Add `temp' for a temporary result, like fields.
2027 Refactor DoResolve and DoResolveLValue into DoResolveBase.
2029 It now copes with Local variables that are captured and emits the
2030 proper instance variable to load it from a field in the captured
2033 (ParameterReference.DoResolveBase): During the resolve phase,
2034 capture parameters if we are in an anonymous method.
2036 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
2037 anonymous method, use the EmitContext helper routines to emit the
2038 parameter reference.
2040 * iterators.cs: Set RemapToProxy to true/false during the
2043 * parameters.cs (GetParameterByName): New helper method.
2045 * typemanager.cs (anonymous_method_type) a new type that
2046 represents an anonyous method. This is always an internal type,
2047 used as a fencepost to test against the anonymous-methodness of an
2050 2004-10-20 Marek Safar <marek.safar@seznam.cz>
2052 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
2054 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
2056 2004-11-10 Martin Baulig <martin@ximian.com>
2058 * expression.cs (Invocation.BetterFunction): If two methods have
2059 equal parameter types, but only one of them is generic, the
2060 non-generic one wins.
2061 (New.DoResolve): Don't set `is_struct' to false if we're a generic
2062 instance; just use `Type.IsValueType' to determine whether
2063 something is a struct or not.
2064 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
2065 so we can be called multiple times.
2067 2004-11-10 Martin Baulig <martin@ximian.com>
2069 * generic.cs (TypeParameter.DefineConstraints): New public method.
2070 (TypeParameter.CheckAccessLevel): Override this and return true.
2071 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
2072 override ResolveType() anymore.
2073 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
2075 2004-11-10 Martin Baulig <martin@ximian.com>
2077 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
2078 call DeclSpace.ResolveNestedType() on it.
2080 2004-11-10 Martin Baulig <martin@ximian.com>
2082 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
2083 non-null, call ParameterModifier() on it.
2085 2004-11-10 Martin Baulig <martin@ximian.com>
2088 (Iterators): Added `current_type' and `this_type' fields.
2089 (Iterators.DefineIterator): Create a new EmitContext and store it
2090 in `ec'; compute `this_type'.
2092 2004-11-10 Martin Baulig <martin@ximian.com>
2095 (TypeManager.IsPrivateAccessible): New public method.
2096 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
2098 2004-11-10 Martin Baulig <martin@ximian.com>
2100 * class.cs (TypeContainer.DefineType): Call
2101 TypeBuilder.DefineGenericParameters() before resolving the type
2103 (MethodData.parent_method): New protected field.
2104 (MethodData..ctor): Added `MethodInfo parent_method' argument.
2105 (MethodData.Define): Compute `parent_method'.
2108 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
2109 (MemberCore.GetClsCompliantAttributeValue): Likewise.
2110 (DeclSpace.ec): New protected field; store the EmitContext here.
2111 (DeclSpace.EmitContext): New public property.
2112 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
2113 (DeclSpace.ResolveNestedType): New public method.
2114 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
2115 (DeclSpace.NestedAccessible): Added `Type tb' argument.
2116 (DeclSpace.FamilyAccessible): Likewise.
2117 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
2118 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
2121 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
2124 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
2125 (Enum.Emit): Don't create a new EmitContext.
2127 2004-10-18 Martin Baulig <martin@ximian.com>
2129 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
2130 `Type' directly, but call ResolveType() on it.
2131 (Catch.Resolve): Likewise.
2132 (Foreach.Resolve): Likewise.
2134 2004-10-18 Martin Baulig <martin@ximian.com>
2136 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
2137 `Type' directly, but call ResolveType() on it.
2138 (Probe.DoResolve): Likewise.
2139 (ArrayCreation.LookupType): Likewise.
2140 (TypeOf.DoResolve): Likewise.
2141 (SizeOf.DoResolve): Likewise.
2143 2004-10-18 Raja R Harinath <rharinath@novell.com>
2145 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
2148 2004-10-17 John Luke <john.luke@gmail.com>
2150 * class.cs (Operator.GetSignatureForError): use CSharpName
2152 * parameter.cs (Parameter.GetSignatureForError): Returns
2153 correct name even if was not defined.
2155 2004-10-13 Raja R Harinath <rharinath@novell.com>
2158 * class.cs (TypeContainer.EmitContext): New property.
2159 (DefineNestedTypes): Create an emitcontext for each part.
2160 (MethodCore.DoDefineParameters): Use container's emitcontext.
2161 Pass type array to InternalParameters.
2162 (MemberBase.DoDefine): Use container's emitcontext.
2163 (FieldMember.Define): Likewise.
2164 (Event.Define): Likewise.
2165 (SetMethod.GetParameterInfo): Change argument to EmitContext.
2166 Pass type array to InternalParameters.
2167 (SetIndexerMethod.GetParameterInfo): Likewise.
2168 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
2169 * delegate.cs (Define): Pass emitcontext to
2170 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
2171 array to InternalParameters.
2172 * expression.cs (ParameterReference.DoResolveBase): Pass
2173 emitcontext to GetParameterInfo.
2174 (ComposedCast.DoResolveAsTypeStep): Remove check on
2175 ec.ResolvingTypeTree.
2176 * parameter.cs (Parameter.Resolve): Change argument to
2177 EmitContext. Use ResolveAsTypeTerminal.
2178 (Parameter.GetSignature): Change argument to EmitContext.
2179 (Parameters.ComputeSignature): Likewise.
2180 (Parameters.ComputeParameterTypes): Likewise.
2181 (Parameters.GetParameterInfo): Likewise.
2182 (Parameters.ComputeAndDefineParameterTypes): Likewise.
2183 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
2184 * support.cs (InternalParameters..ctor): Remove variant that takes
2186 * typemanager.cs (system_intptr_expr): New.
2187 (InitExpressionTypes): Initialize it.
2189 2004-10-12 Chris Toshok <toshok@ximian.com>
2191 * cs-parser.jay: fix location for try_statement and catch_clause.
2193 2004-10-18 Martin Baulig <martin@ximian.com>
2195 * class.cs (FieldMember.Define): Don't access the TypeExpr's
2196 `Type' directly, but call ResolveType() on it.
2197 (MemberBase.DoDefine): Likewise.
2199 * expression.cs (New.DoResolve): Don't access the TypeExpr's
2200 `Type' directly, but call ResolveType() on it.
2201 (ComposedCast.DoResolveAsTypeStep): Likewise.
2203 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
2204 `Type' directly, but call ResolveType() on it.
2206 2004-10-17 John Luke <john.luke@gmail.com>
2208 * class.cs (Operator.GetSignatureForError): use CSharpName
2210 * parameter.cs (Parameter.GetSignatureForError): Returns
2211 correct name even if was not defined.
2213 2004-10-13 Raja R Harinath <rharinath@novell.com>
2216 * class.cs (TypeContainer.EmitContext): New property.
2217 (DefineNestedTypes): Create an emitcontext for each part.
2218 (MethodCore.DoDefineParameters): Use container's emitcontext.
2219 Pass type array to InternalParameters.
2220 (MemberBase.DoDefine): Use container's emitcontext.
2221 (FieldMember.Define): Likewise.
2222 (Event.Define): Likewise.
2223 (SetMethod.GetParameterInfo): Change argument to EmitContext.
2224 Pass type array to InternalParameters.
2225 (SetIndexerMethod.GetParameterInfo): Likewise.
2226 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
2227 * delegate.cs (Define): Pass emitcontext to
2228 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
2229 array to InternalParameters.
2230 * expression.cs (ParameterReference.DoResolveBase): Pass
2231 emitcontext to GetParameterInfo.
2232 (ComposedCast.DoResolveAsTypeStep): Remove check on
2233 ec.ResolvingTypeTree.
2234 * parameter.cs (Parameter.Resolve): Change argument to
2235 EmitContext. Use ResolveAsTypeTerminal.
2236 (Parameter.GetSignature): Change argument to EmitContext.
2237 (Parameters.ComputeSignature): Likewise.
2238 (Parameters.ComputeParameterTypes): Likewise.
2239 (Parameters.GetParameterInfo): Likewise.
2240 (Parameters.ComputeAndDefineParameterTypes): Likewise.
2241 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
2242 * support.cs (InternalParameters..ctor): Remove variant that takes
2244 * typemanager.cs (system_intptr_expr): New.
2245 (InitExpressionTypes): Initialize it.
2247 2004-10-12 Chris Toshok <toshok@ximian.com>
2249 * cs-parser.jay: fix location for try_statement and catch_clause.
2251 2004-10-07 Raja R Harinath <rharinath@novell.com>
2253 More DeclSpace.ResolveType avoidance.
2254 * decl.cs (MemberCore.InUnsafe): New property.
2255 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
2256 with newly created EmitContext.
2257 (FieldMember.Define): Likewise.
2258 * delegate.cs (Delegate.Define): Likewise.
2259 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
2260 only if normal name-lookup fails.
2261 (TypeExpr.DoResolve): Enable error-checking.
2262 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
2263 (SizeOf.DoResolve): Likewise.
2264 (ComposedCast.DoResolveAsTypeStep): Likewise.
2265 (StackAlloc.DoResolve): Likewise.
2266 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
2267 (Block.Unsafe): New property.
2268 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
2269 (Unsafe): Set 'unsafe' flag of contained block.
2270 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
2271 (Fixed.Resolve): Likewise.
2272 (Catch.Resolve): Likewise.
2273 (Using.ResolveLocalVariableDecls): Likewise.
2274 (Foreach.Resolve): Likewise.
2276 2004-10-05 John Luke <john.luke@gmail.com>
2278 * cs-parser.jay: add location to error CS0175
2280 2004-10-04 Miguel de Icaza <miguel@ximian.com>
2282 * ecore.cs (Expression.Constantity): Add support for turning null
2285 * const.cs (Const.Define): Allow constants to be reference types
2286 as long as the value is Null.
2288 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
2290 * namespace.cs (NamespaceEntry.Using): No matter which warning
2291 level is set, check if this namespace name has already been added.
2293 2004-10-03 Ben Maurer <bmaurer@ximian.com>
2295 * expression.cs: reftype [!=]= null should always use br[true,false].
2298 2004-10-03 Marek Safar <marek.safar@seznam.cz>
2301 * attribute.cs: Enum conversion moved to
2302 GetAttributeArgumentExpression to be applied to the all
2305 2004-10-01 Raja R Harinath <rharinath@novell.com>
2307 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
2308 * class.c (TypeContainer.DefineType): Flag error if
2309 base types aren't accessible due to access permissions.
2310 * decl.cs (DeclSpace.ResolveType): Move logic to
2311 Expression.ResolveAsTypeTerminal.
2312 (DeclSpace.ResolveTypeExpr): Thin layer over
2313 Expression.ResolveAsTypeTerminal.
2314 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
2315 Refactor code into NestedAccess. Use it.
2316 (DeclSpace.NestedAccess): New.
2317 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
2318 argument to silence errors. Check access permissions.
2319 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
2320 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
2321 (Cast.DoResolve): Likewise.
2322 (New.DoResolve): Likewise.
2323 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
2324 (TypeOf.DoResolve): Likewise.
2326 * expression.cs (Invocation.BetterConversion): Return the Type of
2327 the better conversion. Implement section 14.4.2.3 more faithfully.
2328 (Invocation.BetterFunction): Make boolean. Make correspondence to
2329 section 14.4.2.2 explicit.
2330 (Invocation.OverloadResolve): Update.
2331 (Invocation): Remove is_base field.
2332 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
2333 (Invocation.Emit): Likewise.
2335 2004-09-24 Marek Safar <marek.safar@seznam.cz>
2337 * cs-parser.jay: Reverted 642 warning fix.
2339 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2342 * decl.cs (FindMemberWithSameName): Indexer can have more than
2345 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2347 * expression.cs (LocalVariableReference.DoResolveLValue):
2348 Do not report warning 219 for out values.
2349 (EmptyExpression.Null): New member to avoid extra allocations.
2351 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2353 * cs-parser.jay: Fix wrong warning 642 report.
2355 * cs-tokenizer.cs (CheckNextToken): New helper;
2356 Inspect next character if is same as expected.
2358 2004-09-23 Martin Baulig <martin@ximian.com>
2360 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
2361 (Convert.ImplicitReferenceConversionExists): Likewise.
2363 2004-11-09 Raja R Harinath <rharinath@novell.com>
2365 * Makefile (DISTFILES): Comment out a few missing files.
2367 2004-10-29 Raja R Harinath <rharinath@novell.com>
2369 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
2370 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
2371 (gmcs.exe): Invoke bootstrap-libs.
2372 (clean-local): Clean the net_2_0_bootstrap profile too.
2373 (PROGRAM_INSTALL_DIR): New.
2374 (install-local): Use it.
2376 2004-10-13 Martin Baulig <martin@ximian.com>
2378 * generic.cs (TypeManager.InflatedConstraints): New nested class.
2379 (TypeParameter.DefineType): If we're a method type parameter and
2380 that method is overriding something, "inflate" its constraints.
2382 2004-10-12 Martin Baulig <martin@ximian.com>
2384 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
2385 and have type arguments, create and resolve a ConstructedType.
2387 2004-10-12 Martin Baulig <martin@ximian.com>
2389 * decl.cs (MemberCache.FindMemberToOverride): Use
2390 TypeManager.IsEqual() to compare the parameters and Type.Equals()
2391 to compare the invocationType.
2393 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
2394 When comparing two type parameters, only do the signature-only
2395 comparision for method type parameters.
2397 2004-10-11 Martin Baulig <martin@ximian.com>
2399 * report.cs: Don't make --fatal abort on warnings, we have
2400 -warnaserror for that.
2402 2004-10-11 Martin Baulig <martin@ximian.com>
2405 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
2406 (TypeManager.IsEqual): Call ourself recursively instead of using
2409 2004-10-11 Martin Baulig <martin@ximian.com>
2411 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
2412 on our own type parameters, not on the ones we inherit from a containing
2415 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
2418 * generic.cs (TypeParameter.Define): We may only be called once.
2420 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
2421 instead of TypeManager.IsEqual().
2423 2004-09-28 Martin Baulig <martin@ximian.com>
2426 (GenericConstraints.EffectiveBaseClass): New public property.
2427 (TypeParameter.GenericConstraints): New public property.
2428 (ConstructedType.CheckConstraints): Improved.
2430 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
2431 (Convert.TypeParameterConversion): New private method; use this in
2432 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
2433 for all conversions related to type parameters.
2435 2004-09-24 Martin Baulig <martin@ximian.com>
2437 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
2438 type parameter conversions for type parameters which are known to
2441 2004-09-24 Martin Baulig <martin@ximian.com>
2443 * generic.cs (GenericConstraints): Added `IsReferenceType' and
2444 `IsValueType' properties.
2446 * support.cs (ReflectionConstraints): Use
2447 Type.GetGenericParameterConstraints() instead of the old hack.
2449 2004-09-24 Martin Baulig <martin@ximian.com>
2451 * generic.cs (GenericConstraints): Moved here and made it an
2454 * support.cs (GenericConstraints): Moved to generic.cs.
2456 2004-09-24 Martin Baulig <martin@ximian.com>
2459 (ReflectionConstraints): Un-nested this class and made it public.
2462 (TypeManager.GetTypeParameterConstraints): New public method.
2463 (TypeManager.HasConstructorConstraint): Use the attributes.
2465 2004-09-24 Martin Baulig <martin@ximian.com>
2467 * support.cs (GenericConstraints): Replaced `HasConstructor',
2468 `IsReferenceType' and `IsValueType' with `Attributes'.
2469 (ReflectionParameters.ReflectionConstraints): Removed the Create()
2470 method and made the .ctor public.
2472 * generic.cs (Constraints.Attributes): New public property.
2473 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
2474 `IsReferenceType' -> `HasReferenceTypeConstraint' and
2475 `IsValueType' -> `HasValueTypeConstraint'.
2477 2004-09-23 Martin Baulig <martin@ximian.com>
2479 * generic.cs (Constraints): Reflect latest runtime changes.
2481 2004-09-23 Martin Baulig <martin@ximian.com>
2483 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
2484 (Convert.ImplicitReferenceConversionExists): Likewise.
2486 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2488 * class.cs (Operator.Define): Add error 448 and 559 report.
2490 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2492 * class.cs (MemberBase.IsTypePermitted): New protected
2493 method for checking error CS0610.
2495 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2497 * class.cs (TypeContainer.HasExplicitLayout): New property
2498 Returns whether container has StructLayout attribute set Explicit.
2499 (FieldMember): New abstract class for consts and fields.
2500 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
2501 (Field): Reuse FieldMember.
2503 * const.cs (Const): Reuse FieldMember.
2505 * rootcontext.cs: EmitConstants call moved to class.
2507 2004-09-22 Martin Baulig <martin@ximian.com>
2509 Marek and me just fixed one of our oldest bugs: #28562 :-)
2511 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
2513 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
2514 we're an EnumConstant, just return that.
2515 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
2516 an EnumConstant. In this case, we need to use GetValueAsEnumType()
2517 to get the value which'll actually be written into the attribute.
2518 However, we have to use GetValue() to access the attribute's value
2521 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2523 * constant.cs (Constant.IsNegative): New abstract property
2526 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
2527 (StackAlloc.DoResolve): Reused IsNegative.
2529 2004-09-22 Martin Baulig <martin@ximian.com>
2531 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
2532 public method; like LookupTypeContainer, but also works for
2535 * report.cs (Report.SymbolRelatedToPreviousError): Use
2536 TypeManager.LookupGenericTypeContainer().
2538 2004-09-22 Martin Baulig <martin@ximian.com>
2540 Thanks to Peter Sestoft for this bug report.
2542 * expression.cs (Conditional): If both the `trueExpr' and the
2543 `falseExpr' is a NullLiteral, return a NullLiteral.
2545 2004-09-22 Martin Baulig <martin@ximian.com>
2547 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
2548 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
2549 for the "get_Current" call.
2551 2004-09-21 Martin Baulig <martin@ximian.com>
2553 * convert.cs (Convert.ImplicitReferenceConversion): When
2554 converting to an interface type, first check whether we're
2555 converting from a reference type.
2557 2004-09-14 Martin Baulig <martin@ximian.com>
2559 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
2561 2004-09-14 Marek Safar <marek.safar@seznam.cz>
2564 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
2565 called and is obsolete then this member suppress message
2566 when call is inside next [Obsolete] method or type.
2568 * expression.cs: Use TestObsoleteMethodUsage member.
2570 2004-09-14 Martin Baulig <martin@ximian.com>
2572 * genericparser.cs: Removed.
2574 2004-09-13 Marek Safar <marek.safar@seznam.cz>
2576 * class.cs (MethodCore.CheckBase): Fix bug #65757.
2578 2004-09-12 Marek Safar <marek.safar@seznam.cz>
2580 * attribute.cs (Attribute.Resolve): Add error 653 report.
2582 * class.cs (Class.ApplyAttributeBuilder): Add error 641
2584 (Method.ApplyAttributeBuilder): Add error 685 report.
2585 (Operator.Define): Add error 564 report.
2587 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
2589 * expression.cs (Invocation.DoResolve): Add error
2592 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
2595 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2597 * class.cs (ConstructorInitializer.Resolve):
2598 Wrong error number (515->516).
2600 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2602 * class.cs (Indexer.Define): Add error 631 report.
2604 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2606 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
2608 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2610 * expression.cs (Probe.DoResolve): Add error CS0241 report.
2612 2004-09-10 Marek Safar <marek.safar@seznam.cz>
2614 * cs-parser.jay: Added error CS0241 report.
2616 2004-09-10 Raja R Harinath <rharinath@novell.com>
2618 * cs-parser.jay (fixed_statement): Introduce a scope for the
2619 declaration in the 'fixed' statement.
2621 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2623 * cs-parser.jay: Added CS0230 error report.
2625 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2627 * cs-parser.jay: Added errors CS0231 and CS0257 report.
2629 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2631 * expression.cs (Argument.Resolve): Added error CS0192 and
2634 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2636 C# 2.0 #pragma warning feature
2638 * cs-tokenizer.cs (PreProcessPragma): New method;
2639 Handles #pragma directive.
2641 * report.cs (WarningRegions): New class; Support
2642 class for #pragma warning directive. It tests whether
2643 warning is enabled for a given line.
2645 2004-09-08 Miguel de Icaza <miguel@ximian.com>
2647 * const.cs: Add more descriptive error report, tahnks to
2650 2004-09-08 Marek Safar <marek.safar@seznam.cz>
2652 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
2654 2004-09-07 Miguel de Icaza <miguel@ximian.com>
2656 * expression.cs: Apply patch from Ben: Remove dead code from
2657 ArrayCreation, and remove the TurnintoConstant call in const.cs,
2658 as that code just threw an exception anwyays.
2660 * const.cs: Remove the call to the turnintoconstant, for details
2663 * literal.cs: The type of the null-literal is the null type; So
2664 we use a placeholder type (literal.cs:System.Null, defined here)
2667 * expression.cs (Conditional.DoResolve): Remove some old code that
2668 is no longer needed, conversions have been fixed.
2670 (ArrayCreationExpression.DoResolve): Return false if we fail to
2671 resolve the inner expression.
2673 2004-09-07 Raja R Harinath <rharinath@novell.com>
2676 * cs-parser.jay (delegate_declaration): Record a delegate
2677 declaration as a type declaration.
2678 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
2680 2004-09-06 Miguel de Icaza <miguel@ximian.com>
2682 * parameter.cs: Do not crash if the type can not be resolved.
2684 * expression.cs: Report errors with unsafe pointers, fixes #64896
2686 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
2688 * expression.cs: Pointer arith always needs to do a conv.i
2689 if the operand is a long. fix 65320
2691 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2693 Fixed cs0619-37.cs, cs0619-38.cs
2695 * enum.cs (GetObsoleteAttribute): Removed.
2697 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
2698 on Enum member is double staged. The first is tested member
2701 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2703 Fixed #56986, #63631, #65231
2705 * class.cs: (TypeContainer.AddToMemberContainer): New method,
2706 adds member to name container.
2707 (TypeContainer.AddToTypeContainer): New method, adds type to
2709 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
2710 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
2711 AddOperator): Simplified by reusing AddToMemberContainer.
2712 (TypeContainer.UserDefinedStaticConstructor): Changed to property
2714 (Method.CheckForDuplications): Fixed implementation to test all
2716 (MemberBase): Detection whether member is explicit interface
2717 implementation is now in constructor.
2718 (MemberBase.UpdateMemberName): Handles IndexerName.
2719 (Accessor): Changed to keep also location information.
2720 (AbstractPropertyEventMethod): Is derived from MemberCore.
2721 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
2722 will be emited or not.
2723 (PropertyBase.AreAccessorsDuplicateImplementation):
2724 Tests whether accessors are not in collision with some method.
2725 (Operator): Is derived from MethodCore to simplify common
2728 * decl.cs (Flags.TestMethodDuplication): Test for duplication
2730 (DeclSpace.AddToContainer): Adds the member to defined_names
2731 table. It tests for duplications and enclosing name conflicts.
2733 * enum.cs (EnumMember): Clean up to reuse the base structures
2735 2004-09-03 Martin Baulig <martin@ximian.com>
2737 Merged latest changes into gmcs. Please keep this comment in
2738 here, it makes it easier for me to see what changed in MCS since
2739 the last time I merged.
2741 2004-09-03 Martin Baulig <martin@ximian.com>
2743 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
2744 into TypeContainer, to make partial classes work again.
2746 2004-09-03 Martin Baulig <martin@ximian.com>
2748 * rootcontext.cs (RootContext.V2): Removed.
2750 2004-03-23 Martin Baulig <martin@ximian.com>
2752 * expression.cs (Invocation.OverloadResolve): Added `bool
2753 may_fail' argument and use it instead of the Location.IsNull() hack.
2755 2004-09-09 Martin Baulig <martin@ximian.com>
2757 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
2759 2004-09-09 Martin Baulig <martin@ximian.com>
2761 * generic.cs (TypeParameter.DefineType): Added support for
2762 explicit interface methods.
2764 2004-09-09 Martin Baulig <martin@ximian.com>
2766 * README.Changes: New document. Started to list important changes
2767 between MCS and GMCS here.
2769 2004-09-08 Martin Baulig <martin@ximian.com>
2772 (TypeContainer.CheckRecursiveDefinition): New protected method.
2773 (TypeContainer.DefineType): Move the CS0146 check into
2774 CheckRecursiveDefinition().
2776 2004-09-06 Martin Baulig <martin@ximian.com>
2778 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
2779 types for the constructor constraint.
2781 2004-09-03 Martin Baulig <martin@ximian.com>
2783 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
2784 into TypeContainer, to make partial classes work again.
2786 2004-09-03 Martin Baulig <martin@ximian.com>
2788 * rootcontext.cs (RootContext.V2): Removed.
2790 2004-03-23 Martin Baulig <martin@ximian.com>
2792 * expression.cs (Invocation.OverloadResolve): Added `bool
2793 may_fail' argument and use it instead of the Location.IsNull() hack.
2795 2004-09-03 Martin Baulig <martin@ximian.com>
2797 Merged latest changes into gmcs. Please keep this comment in
2798 here, it makes it easier for me to see what changed in MCS since
2799 the last time I merged.
2801 2004-09-03 Raja R Harinath <rharinath@novell.com>
2804 * expression.cs (BetterConversion): Don't allow either conversion
2805 to be null. Remove redundant implicit conversion test when 'q ==
2806 null' -- when this function is invoked, we already know that the
2807 implicit conversion exists.
2808 (BetterFunction): Assume that 'best' is non-null. Remove
2809 redundant reimplementation of IsApplicable when 'best' is null.
2810 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
2811 number of arguments.
2812 (IsAncestralType): Extract from OverloadResolve.
2813 (OverloadResolve): Make robust to the MethodGroupExpr being
2814 unsorted. Implement all the logic of Section 14.5.5.1, and
2815 support overloading of methods from multiple applicable types.
2816 Clean up logic somewhat. Don't pass null methods to BetterFunction.
2818 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
2819 (RealError, Warning): Append type of report to related symbol.
2821 2004-09-03 Marek Safar <marek.safar@seznam.cz>
2823 * enum.cs: Fixed CLS-Compliance checks for enum members.
2824 Error tests cs3008-8.cs, cs3014-8.cs
2826 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2828 Fixed bug #62342, #63102
2829 * class.cs: ImplementIndexer uses member.IsExplicitImpl
2830 like ImplementMethod.
2832 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2834 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2837 2004-09-02 Martin Baulig <martin@ximian.com>
2839 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
2840 TypeManager.GetArgumentTypes() rather than calling GetParameters()
2843 2004-09-01 Marek Safar <marek.safar@seznam.cz>
2845 C# 2.0 Static classes implemented
2847 * class.cs (TypeContainer): instance_constructors,
2848 initialized_fields, initialized_static_fields,
2849 default_constructor, base_inteface_types are protected to be
2850 accessible from StaticClass.
2851 (TypeContainer.DefineDefaultConstructor): New virtual method
2852 for custom default constructor generating
2853 (StaticClass): New class to handle "Static classes" feature.
2855 * cs-parser.jay: Handle static keyword on class like instance
2858 * driver.cs: Added "/langversion" command line switch with two
2859 options (iso-1, default).
2861 2004-08-31 Marek Safar <marek.safar@seznam.cz>
2863 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
2865 2004-08-31 Miguel de Icaza <miguel@ximian.com>
2867 * delegate.cs: Style.
2869 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
2871 * delegate.cs: Add seperate instance expr field for miguel.
2873 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2875 * PointerArithmetic (Resolve): make sure we are not doing
2876 pointer arith on void*. Also, make sure we are resolved
2877 by not setting eclass until resolve.
2879 All callers: Make sure that PointerArithmetic gets resolved.
2881 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2883 * ArrayCreation (LookupType): If the type does not resolve
2884 to an array, give an error.
2886 2004-08-27 Marek Safar <marek.safar@seznam.cz>
2888 * statement.cs (Try.Resolve): Fixed bug #64222
2890 2004-08-27 Martin Baulig <martin@ximian.com>
2893 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
2896 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2898 * ecore.cs (Constantify): Get underlying type via
2899 System.Enum.GetUnderlyingType to avoid StackOverflow on the
2900 Windows in special cases.
2902 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2904 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
2905 for obtaining also private methods.
2906 (GetRemoveMethod): Used GetRemoveMethod (true)
2907 for obtaining also private methods.
2909 2004-09-02 Martin Baulig <martin@ximian.com>
2911 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
2912 TypeManager.GetArgumentTypes() rather than calling GetParameters()
2915 2004-08-27 Martin Baulig <martin@ximian.com>
2918 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
2921 2004-08-25 Martin Baulig <martin@ximian.com>
2923 * support.cs (ReflectionParameters..ctor): If this is a generic
2924 method, retrieve and store its type parameters.
2925 (InternalParameters..ctor): Added `TypeParameter[]' argument.
2926 (ReflectionParameters.GenericConstraints): The argument specifies
2927 the type parameter, not the method parameter.
2928 (InternalParameters.GenericConstraints): Likewise.
2930 * generic.cs (TypeParameter.DefineType): Correctly handle
2931 constraints wrt. generic methods in interfaces and their
2934 2004-08-24 Martin Baulig <martin@ximian.com>
2936 * generic.cs (TypeParameter.IsSubclassOf): New public method.
2937 (Constraints.IsSubclassOf): New internal method.
2939 * typemanager.cs (TypeManager.FindMembers): Added special support
2940 for GenericTypeParameterBuilder's.
2941 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
2944 2004-08-24 Martin Baulig <martin@ximian.com>
2947 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
2948 this for accessibility checks.
2949 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
2950 IsNestedFamilyAccessible.
2951 (TypeManager.IsSubclassOf): New method, do what the name actually
2954 2004-08-24 Martin Baulig <martin@ximian.com>
2956 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
2957 as a SimpleName, include the generic arity.
2959 2004-08-24 Martin Baulig <martin@ximian.com>
2961 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
2962 MethodAttributes.HideBySig for operators.
2964 2004-08-23 Martin Baulig <martin@ximian.com>
2966 Back to the old error reporting system :-)
2968 * report.cs (Message): Removed.
2969 (Report.MessageData, ErrorData, WarningData): Removed.
2970 (Report.Error, Warning): Back to the old system.
2972 2004-08-23 Martin Baulig <martin@ximian.com>
2974 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
2976 * class.cs (TypeContainer.ParentContainer): New public virtual
2977 method; replaces the explicit interface implementation.
2978 (ClassPart.ParentContainer): Override.
2980 2004-08-23 Martin Baulig <martin@ximian.com>
2982 * statement.cs (Switch): Added support for constant switches; see
2983 #59428 or test-285.cs.
2985 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2988 * statement.cs (GetEnumeratorFilter): Removed useless
2989 logic because C# specs is strict. GetEnumerator must be
2992 2004-08-22 Martin Baulig <martin@ximian.com>
2994 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2995 a switch and may break, reset the barrier. Fixes #59867.
2997 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2999 CLS-Compliance speed up (~5% for corlib)
3001 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
3002 New method. Tests container for CLS-Compliant names
3004 * class.cs (TypeContainer.VerifyClsName): New method.
3005 Checks whether container name is CLS Compliant.
3006 (Constructor): Implements IMethodData.
3008 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
3009 low-case table for CLS Compliance test.
3010 (MemberCache.VerifyClsParameterConflict): New method.
3011 Checks method parameters for CS3006 error.
3013 * enum.cs (EnumMember): Is derived from MemberCore.
3014 (Enum.VerifyClsName): Optimized for better performance.
3016 2004-08-06 Marek Safar <marek.safar@seznam.cz>
3018 * report.cs: Renamed Error_T to Error and changed all
3021 2004-08-06 Marek Safar <marek.safar@seznam.cz>
3023 * class.cs (TypeContainer.IndexerArrayList): New inner class
3024 container for indexers.
3025 (TypeContainer.DefaultIndexerName): New constant for default
3026 indexer name. Replaced all "Item" with this constant.
3027 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
3029 * typemanager.cs (TypeManager.default_member_ctor): Cache here
3030 DefaultMemberAttribute constructor.
3032 2004-08-05 Martin Baulig <martin@ximian.com>
3034 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
3037 2004-08-05 Marek Safar <marek.safar@seznam.cz>
3039 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
3040 multi platforms problem.
3042 * compiler.csproj: Included shared files.
3044 2004-08-04 Marek Safar <marek.safar@seznam.cz>
3046 Fix bug 60333, 55971 in the more general way
3047 * attribute.cs (Attribute.GetAttributeArgumentExpression):
3048 Added arg_type argument for constant conversion.
3049 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
3051 2004-08-04 Marek Safar <marek.safar@seznam.cz>
3054 * class.cs (TypeContainer ): New inner classes MethodArrayList,
3055 OperatorArrayList, MethodCoreArrayList for typecontainer
3056 containers. Changed class member types to these new types.
3057 (MethodArrayList.DefineMembers): Added test for CS0659.
3059 2004-08-04 Miguel de Icaza <miguel@ximian.com>
3061 * cfold.cs: Synchronize the folding with the code in expression.cs
3062 Binary.DoNumericPromotions for uint operands.
3064 * attribute.cs: Revert patch from Raja, it introduced a regression
3065 while building Blam-1.2.1 (hard to isolate a test case).
3067 2004-08-04 Marek Safar <marek.safar@seznam.cz>
3071 (TypeContainer.Define): Renamed to DefineContainerMembers because of
3073 (MethodCore.parent_method): New member. The method we're overriding
3074 if this is an override method.
3075 (MethodCore.CheckBase): Moved from Method class and made common.
3076 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
3078 (MethodCore.CheckForDuplications): New abstract method. For custom
3079 member duplication search in a container
3080 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
3081 method and its return type.
3082 (Event.conflict_symbol): New member. Symbol with same name in the
3086 (MemberCache.FindMemberWithSameName): New method. The method
3087 is looking for conflict with inherited symbols.
3089 2004-08-04 Martin Baulig <martin@ximian.com>
3091 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
3093 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
3095 2004-08-03 Marek Safar <marek.safar@seznam.cz>
3097 * report.cs (Message): New enum for better error, warning reference in
3099 (MessageData): New inner abstract class. It generally handles printing of
3100 error and warning messages.
3101 Removed unused Error, Warning, Message methods.
3103 2004-08-03 Marek Safar <marek.safar@seznam.cz>
3105 Fix for cs0592-8.cs test
3107 (Attributable.ValidAttributeTargets): Made public.
3108 (Attribute.ExplicitTarget): New member for explicit target value.
3109 (Attribute.CheckTargets): Now we translate explicit attribute
3110 target to Target here.
3112 2004-08-03 Ben Maurer <bmaurer@ximian.com>
3114 * ecore.cs (MethodGroupExpr): new IsBase property.
3116 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
3118 * delegate.cs (DelegateCreation): store a MethodGroupExpr
3119 rather than an instance expr.
3121 (DelegateCreation.Emit): Use the method group rather than
3122 the instance expression. Also, if you have base.Foo as the
3123 method for a delegate, make sure to emit ldftn, not ldftnvirt.
3125 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
3127 (NewDelegate.DoResolve): Only check for the existance of Invoke
3128 if the method is going to be needed. Use MethodGroupExpr.
3130 (NewDelegate.Emit): Remove, DelegateCreation implements this.
3132 * expression.cs: For pointer arith., make sure to use
3133 the size of the type, not the size of the pointer to
3136 2004-08-03 Marek Safar <marek.safar@seznam.cz>
3139 * class.cs (Class): Added error CS0502 test.
3141 2004-08-03 John Luke <jluke@cfl.rr.com>
3142 Raja R Harinath <rharinath@novell.com>
3145 * attribute.cs (Attribute.complained_before): New flag.
3146 (Attribute.ResolveType, Attribute.Resolve),
3147 (Attribute.DefinePInvokeMethod): Set it.
3148 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
3150 2004-08-03 Martin Baulig <martin@ximian.com>
3152 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
3153 use a user-defined operator; we still need to do numeric
3154 promotions in case one argument is a builtin type and the other
3155 one has an implicit conversion to that type. Fixes #62322.
3157 2004-08-18 Martin Baulig <martin@ximian.com>
3159 * class.cs (Method.Define): Use the correct method name when
3160 creating the MethodBuilder for a generic method.
3162 2004-08-17 Martin Baulig <martin@ximian.com>
3164 * generic.cs (Constraints): Support type parameter constraints.
3166 2004-08-16 Martin Baulig <martin@ximian.com>
3168 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
3169 (Token.GENERIC_DIMENSION): New token; this is returned if we
3170 encounter an unbound generic type in a typeof() expression.
3172 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
3173 this token is only generated while parsing a typeof() expression.
3174 (typeof_expression): Removed the old unbound_type hack.
3176 * generic.cs (TypeArguments.IsUnbound): New public property.
3178 * decl.cs (MemberName): Added support for unbound types.
3180 2004-08-14 Martin Baulig <martin@ximian.com>
3183 (TypeManager.IsEqualGenericInstance): New static method.
3184 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
3185 just used to check accessibility, so follow the rules of 26.1.6.
3187 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
3188 ConstructedType instead of a TypeExpression if we have type arguments.
3190 * cs-parser.jay (typeof_expression): Support unbound generic types.
3192 * ecore.cs (UnboundTypeExpression): New public class.
3194 2004-08-12 Martin Baulig <martin@ximian.com>
3196 * typemanager.cs (TypeManager.IsNestedChildOf): Use
3197 TypeManager.IsEqual() rather than `=='.
3199 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
3200 generic instances as well.
3202 2004-08-12 Martin Baulig <martin@ximian.com>
3204 * expression.cs (Invocation.InferType): We can only infer method
3205 type parameters. Fixes #62647.
3207 2004-08-11 Martin Baulig <martin@ximian.com>
3209 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
3210 before resolving the base classes.
3212 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3214 * Makefile: install .mdb file too.
3216 2004-08-05 Martin Baulig <martin@ximian.com>
3218 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
3219 initializer, the current type is just the TypeBuilder, not the
3220 instantiated generic type.
3221 (FieldExpr.IsFieldInitializer): New public property.
3223 2004-08-04 Martin Baulig <martin@ximian.com>
3225 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
3227 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
3229 2004-08-03 Martin Baulig <martin@ximian.com>
3231 * class.cs (MethodData.Define): If we're an explicit
3232 implementation, remove the generic arity from the type name.
3234 2004-08-03 Martin Baulig <martin@ximian.com>
3236 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
3237 use a user-defined operator; we still need to do numeric
3238 promotions in case one argument is a builtin type and the other
3239 one has an implicit conversion to that type. Fixes #62322.
3241 2004-08-02 Martin Baulig <martin@ximian.com>
3243 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
3245 (TypeContainer.GetClassBases): Return the unexpanded list of
3246 interfaces; we expand them later.
3247 (TypeContainer.DefineType): After creating the TypeBuilder, call
3248 TypeManager.ExpandInterfaces() to get an expanded and resolved
3251 * ecore.cs (TypeExpr.GetInterfaces): Removed
3253 * generics.cs (Constraints.InterfaceConstraints): Remove.
3254 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
3255 register the interface constraints.
3258 (TypeManager.AddUserType): Removed the `ifaces' argument.
3259 (TypeManager.AddTypeParameter): Likewise.
3260 (TypeManager.AddUserInterface): Removed, was unused.
3261 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
3262 `TypeExpr[]' array for the interfaces.
3263 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
3264 has been defined, returns a list of the resolved interfaces types.
3265 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
3266 (TypeManager.GetExplicitInterfaces): Likewise.
3268 2004-08-02 Martin Baulig <martin@ximian.com>
3270 * expression.cs (Invocation.EmitCall): If we're invoking a method
3271 on a type parameter, use the new `Constrained' prefix opcode.
3273 2004-08-02 Martin Baulig <martin@ximian.com>
3275 * statement.cs (LocalInfo.Flags): Added `IsThis'.
3276 (LocalInfo.IsThis): New public property.
3277 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
3279 2004-08-01 Martin Baulig <martin@ximian.com>
3281 * class.cs (TypeContainer.GetClassBases): Don't set the default
3282 here since we may get called from GetPartialBases().
3283 (TypeContainer.DefineType): If GetClassBases() didn't return a
3284 parent, use the default one.
3286 2004-07-30 Martin Baulig <martin@ximian.com>
3288 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
3290 * class.cs (SourceMethod): New public class, derive from the
3291 symbol writer's ISourceMethod.
3292 (Method): Use the new symbol writer API.
3294 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
3295 as argument and use the new symbol writer.
3298 (SourceFile): Implement the symbol writer's ISourceFile.
3299 (Location.SymbolDocument): Removed.
3300 (Location.SourceFile): New public property.
3302 * symbolwriter.cs: Use the new symbol writer API.
3304 2004-07-30 Raja R Harinath <rharinath@novell.com>
3306 * Makefile (install-local): Remove. Functionality moved to
3309 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
3311 * Makefile: Install mcs.exe.config file together with mcs.exe.
3312 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
3313 correct runtime version.
3315 2004-07-25 Martin Baulig <martin@ximian.com>
3318 (TypeContainer.RegisterOrder): Removed, this was unused.
3319 (TypeContainer, interface_order): Removed.
3320 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
3321 TypeContainer as argument since we can also be called with a
3322 `PartialContainer' for a partial class/struct/interface.
3323 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
3324 of checking whether we're an `Interface' - we could be a
3326 (PartialContainer.Register): Override; call
3327 AddClass()/AddStruct()/AddInterface() on our parent.
3329 * cs-parser.jay (interface_member_declaration): Add things to the
3330 `current_container', not the `current_class'.
3332 * rootcontext.cs (RegisterOrder): The overloaded version which
3333 takes an `Interface' was unused, removed.
3335 * typemanager.cs (TypeManager.LookupInterface): Return a
3336 `TypeContainer', not an `Interface'.
3337 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
3338 contain a `PartialContainer' for an interface, so check it's
3339 `Kind' to figure out what it is.
3341 2004-07-25 Martin Baulig <martin@ximian.com>
3343 * class.cs (Class.DefaultTypeAttributes): New public constant.
3344 (Struct.DefaultTypeAttributes): Likewise.
3345 (Interface.DefaultTypeAttributes): Likewise.
3346 (PartialContainer.TypeAttr): Override this and add the
3347 DefaultTypeAttributes.
3349 2004-07-25 Martin Baulig <martin@ximian.com>
3351 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
3352 we can just use the `Parent' field instead.
3354 2004-07-25 Martin Baulig <martin@ximian.com>
3356 * class.cs (TypeContainer.Emit): Renamed to EmitType().
3358 2004-07-25 Martin Baulig <martin@ximian.com>
3360 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
3361 our parts before defining any methods.
3362 (TypeContainer.VerifyImplements): Make this virtual.
3363 (ClassPart.VerifyImplements): Override and call VerifyImplements()
3364 on our PartialContainer.
3366 2004-07-25 Martin Baulig <martin@ximian.com>
3368 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
3370 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
3371 argument, we can just use the `Parent' field instead.
3374 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
3375 (MemberBase.DoDefine): Likewise.
3377 2004-07-24 Martin Baulig <martin@ximian.com>
3379 * decl.cs (MemberCore.Parent): New public field.
3380 (DeclSpace.Parent): Moved to MemberCore.
3382 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
3383 (MemberBase.ctor): Added TypeContainer argument, pass it to our
3385 (FieldBase, Field, Operator): Likewise.
3386 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
3387 (EventField, Event): Likewise.
3389 2004-07-23 Martin Baulig <martin@ximian.com>
3391 * class.cs (PartialContainer): New public class.
3392 (ClassPart): New public class.
3393 (TypeContainer): Added support for partial classes.
3394 (TypeContainer.GetClassBases): Splitted some of the functionality
3395 out into GetNormalBases() and GetPartialBases().
3397 * cs-tokenizer.cs (Token.PARTIAL): New token.
3398 (Tokenizer.consume_identifier): Added some hacks to recognize
3399 `partial', but only if it's immediately followed by `class',
3400 `struct' or `interface'.
3402 * cs-parser.jay: Added support for partial clases.
3404 2004-07-23 Martin Baulig <martin@ximian.com>
3406 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
3407 a `DeclSpace' and also made it readonly.
3408 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
3409 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
3410 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
3412 * cs-parser.jay: Pass the `current_class', not the
3413 `current_container' (at the moment, this is still the same thing)
3414 to a new Method, Property, Event, Indexer or Constructor.
3416 2004-07-23 Martin Baulig <martin@ximian.com>
3418 * cs-parser.jay (CSharpParser): Added a new `current_class' field
3419 and removed the `current_interface' one.
3420 (struct_declaration, class_declaration, interface_declaration):
3421 Set `current_class' to the newly created class/struct/interface;
3422 set their `Bases' and call Register() before parsing their body.
3424 2004-07-23 Martin Baulig <martin@ximian.com>
3426 * class.cs (Kind): New public enum.
3427 (TypeContainer): Made this class abstract.
3428 (TypeContainer.Kind): New public readonly field.
3429 (TypeContainer.CheckDef): New public method; moved here from
3431 (TypeContainer.Register): New public abstract method.
3432 (TypeContainer.GetPendingImplementations): New public abstract
3434 (TypeContainer.GetClassBases): Removed the `is_class' and
3435 `is_iface' parameters.
3436 (TypeContainer.DefineNestedTypes): Formerly known as
3438 (ClassOrStruct): Made this class abstract.
3440 * tree.cs (RootTypes): New public type.
3442 2004-07-20 Martin Baulig <martin@ximian.com>
3444 * tree.cs (Tree.RecordNamespace): Removed.
3445 (Tree.Namespaces): Removed.
3447 * rootcontext.cs (RootContext.IsNamespace): Removed.
3449 * cs-parser.jay (namespace_declaration): Just create a new
3450 NamespaceEntry here.
3452 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
3454 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
3455 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
3456 entry to make sure it runs in the correct runtime version.
3458 2004-07-18 Martin Baulig <martin@ximian.com>
3460 * generic.cs (ConstructedType.CheckConstraints): Improved
3461 constraints checking.
3463 2004-07-18 Martin Baulig <martin@ximian.com>
3465 * expression.cs (Invocation.BetterMethod): Call
3466 TypeManager.TypeToCoreType() on all types and removed my previous
3467 hack; we're already doig the right thing here.
3469 2004-07-17 Martin Baulig <martin@ximian.com>
3471 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
3473 2004-07-16 Martin Baulig <martin@ximian.com>
3475 * iterators.cs: Added generics support.
3477 2004-07-16 Martin Baulig <martin@ximian.com>
3479 * iterators.cs: Rewrote this. We're now using one single Proxy
3480 class for both the IEnumerable and the IEnumerator interface and
3481 `Iterator' derives from Class so we can use the high-level API.
3483 * class.cs (TypeContainer.AddIterator): New method.
3484 (TypeContainer.DoDefineType): New protected virtual method, which
3485 is called from DefineType().
3486 (TypeContainer.DoDefineMembers): Call DefineType() and
3487 DefineMembers() on all our iterators.
3488 (TypeContainer.Emit): Call Emit() on all our iterators.
3489 (TypeContainer.CloseType): Call CloseType() on all our iterators.
3491 * codegen.cs (EmitContext.CurrentIterator): New public field.
3493 2004-07-15 Martin Baulig <martin@ximian.com>
3496 (TypeManager.not_supported_exception_type): New type.
3498 2004-07-14 Martin Baulig <martin@ximian.com>
3501 (TypeManager.generic_ienumerable_type): New type.
3502 (TypeManager.generic_ienumerator_type): New type.
3505 (RootContext.interfaces_first_stage): Added
3506 "System.Collections.Generic.IEnumerator`1" and
3507 "System.Collections.Generic.IEnumerable`1".
3509 2004-07-14 Martin Baulig <martin@ximian.com>
3511 * iterators.cs: Use real error numbers.
3513 2004-07-14 Martin Baulig <martin@ximian.com>
3515 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
3516 requires this to be a System.Collection.IEnumerable and not a
3517 class implementing that interface.
3518 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
3520 2004-07-13 Marek Safar <marek.safar@seznam.cz>
3522 * class.cs: Fixed previous fix, it broke some error tests.
3524 2004-07-12 Martin Baulig <martin@ximian.com>
3526 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
3529 2004-07-14 Martin Baulig <martin@ximian.com>
3531 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
3532 an exclamation mark (!) for the generic arity to reflect the
3533 latest spec changes; ie. use "System.Collections.Generic.IList`1".
3535 2004-07-13 Martin Baulig <martin@ximian.com>
3537 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
3538 specifiers being part of a type argument.
3540 2004-07-13 Martin Baulig <martin@ximian.com>
3542 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
3543 name for generic types.
3545 2004-07-13 Martin Baulig <martin@ximian.com>
3547 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
3550 2004-07-09 Miguel de Icaza <miguel@ximian.com>
3552 * assign.cs (LocalTemporary): Add new argument: is_address,If
3553 `is_address' is true, then the value that we store is the address
3554 to the real value, and not the value itself.
3556 * ecore.cs (PropertyExpr): use the new local temporary
3557 stuff to allow us to handle X.Y += z (where X is a struct)
3559 2004-07-08 Martin Baulig <martin@ximian.com>
3561 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
3562 not always return, just like we're doing in Using.Resolve().
3564 2004-07-07 Miguel de Icaza <miguel@ximian.com>
3566 * cs-parser.jay (fixed_statement): flag this as Pinned.
3568 2004-07-06 Miguel de Icaza <miguel@ximian.com>
3570 * typemanager.cs (TypeManager): Removed MakePinned method, this
3571 mechanism is replaced with the .NET 2.x compatible mechanism of
3572 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
3574 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
3575 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
3576 `IsFixed' property which has a different meaning.
3578 2004-07-02 Raja R Harinath <rharinath@novell.com>
3580 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
3581 visible from inside a nested class, not just the names of the
3582 immediately enclosing class.
3585 2004-06-24 Raja R Harinath <rharinath@novell.com>
3587 * expression.cs (BetterConversion): Remove buggy special-case
3588 handling of "implicit constant expression conversions". At this
3589 point, we already know that the conversion is possible -- we're
3590 only checking to see which is better.
3592 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3594 * cs-parser.jay: Added error CS0210 test.
3596 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3598 * cs-parser.jay: Added error CS0134 test.
3600 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3603 * cs-parser.jay: Added error CS0145 test.
3605 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3607 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
3609 2004-06-23 Ben Maurer <bmaurer@ximian.com>
3611 * expression.cs (StackAlloc.Resolve): The argument may not
3612 be a constant; deal with this case.
3614 2004-06-23 Marek Safar <marek.safar@seznam.cz>
3616 * attribute.cs (IndexerName_GetIndexerName): Renamed to
3617 GetIndexerAttributeValue.
3618 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
3620 * class.cs (Indexer.Define): Added error tests for CS0415,
3623 2004-06-23 Miguel de Icaza <miguel@ximian.com>
3625 * attribute.cs (Attribute.Resolve): Keep field code in sync with
3628 2004-06-23 Martin Baulig <martin@ximian.com>
3630 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
3631 neither return nor throw, reset the barrier as well. Fixes #60457.
3633 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
3635 * class.cs : EventAttributes is now set to None by default.
3636 This fixes bug #60459.
3638 2004-06-18 Marek Safar <marek.safar@seznam.cz>
3641 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3642 Don't throw exception but return null (it's sufficient now).
3644 2004-06-18 Marek Safar <marek.safar@seznam.cz>
3646 * typemanager.cs (GetArgumentTypes): Faster implementation.
3648 2004-06-18 Martin Baulig <martin@ximian.com>
3650 * attribute.cs (Attribute.Resolve): Check whether we're an
3651 EmptyCast which a Constant child. Fixes #60333.
3653 2004-06-17 Ben Maurer <bmaurer@ximian.com>
3655 * statement.cs (EmitCollectionForeach): Account for the fact that
3656 not all valuetypes are in areas which we can take the address of.
3657 For these variables, we store to a temporary variable. Also, make
3658 sure that we dont emit a `callvirt' on a valuetype method.
3660 2004-06-15 Marek Safar <marek.safar@seznam.cz>
3662 * expression.cs (StackAlloc.DoReSolve): Added test for
3663 negative parameter (CS0247).
3665 2004-06-15 Marek Safar <marek.safar@seznam.cz>
3668 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
3670 2004-06-15 Marek Safar <marek.safar@seznam.cz>
3673 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
3676 2004-06-14 Marek Safar <marek.safar@seznam.cz>
3678 Fix bug #58254 & cs1555.cs, cs1556.cs
3679 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
3681 2004-06-14 Marek Safar <marek.safar@seznam.cz>
3683 * cs-parser.jay: Added error CS1669 test for indexers.
3685 2004-06-18 Martin Baulig <martin@ximian.com>
3687 * generics.cs (GenericMethod.ctor): Don't take an Attributes
3688 argument. Fixes #60441.
3690 2004-06-16 Ben Maurer <bmaurer@ximian.com>
3691 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
3692 The name needs to have the actual name of the method in order
3693 for other tests (such as the one in OverloadResolve for Invoke
3694 on a delegate) to work. As well, it does not really help
3695 error reporting because the method group had multiple methods.
3696 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
3697 Make profiling work.
3699 2004-06-13 Martin Baulig <martin@ximian.com>
3701 * cs-parser.jay: Don't allow generic attributes.
3703 2004-06-13 Martin Baulig <martin@ximian.com>
3705 * class.cs (MemberBase.DoDefineBase): New protected method.
3706 (MemberBase.DoDefine): Compute the `flags' in the new
3707 DoDefineBase() which must be called first.
3708 (Method.Define): Call DoDefineBase() first so we have the flags
3709 when defining the generic method.
3711 * cs-parser.jay (interface_method_declaration): Support generic methods.
3713 2004-06-13 Martin Baulig <martin@ximian.com>
3715 * decl.cs (TypeName): Removed.
3716 (MemberName): Removed TypeName and MemberNow; now we just have
3719 * cs-parser.jay: Don't distinguish between type arguments and type
3720 parameters in the grammar and simplified the rules a bit. The
3721 reduce/reduce conflicts are now gone (except the one we inherited
3724 2004-06-11 Martin Baulig <martin@ximian.com>
3726 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
3727 call this twice: for params and varargs methods.
3729 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3732 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
3734 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3736 * attribute.cs (Attribute.GetValidTargets): Made public.
3739 (AbstractPropertyEventMethod): New class for better code sharing.
3740 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
3742 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
3744 2004-06-09 Martin Baulig <martin@ximian.com>
3746 * cs-parser.jay: Removed a reduce/reduce conflict.
3748 2004-06-03 Martin Baulig <martin@ximian.com>
3750 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
3751 GetSimpleName() and return a SimpleName.
3753 * ecore.cs (SimpleName.Arguments): New public field.
3754 (SimpleName): Added overloaded ctor which takes an additional
3755 TypeArguments argument.
3756 (SimpleName.SimpleNameResolve): Added support for generic methods.
3757 (MethodGroupExpr.ResolveGeneric): New public method. The code was
3758 formerly in MemberAccess.DoResolve(), but we also need it in
3759 SimpleNameResolve().
3761 * expression.cs (MemberAccess.DoResolve): Use the new
3762 MethodGroupExpr.ResolveGeneric().
3764 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3766 * decl.cs: If possible, use lookuptypedirect here. We can only do
3767 this if there is no `.' after the namespace. Avoids using
3768 LookupType, which does lots of slow processing.
3769 (FindNestedType) New method, does what it says :-).
3770 * namespace.cs: use LookupTypeDirect.
3771 * rootcontext.cs: use membercache, if possible.
3772 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
3774 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3777 According to the spec,
3779 In a member access of the form E.I, if E is a single identifier,
3780 and if the meaning of E as a simple-name (§7.5.2) is a constant,
3781 field, property, localvariable, or parameter with the same type as
3782 the meaning of E as a type-name (§3.8), then both possible
3783 meanings of E are permitted.
3785 We did not check that E as a simple-name had the same type as E as
3788 This trivial check gives us 5-7% on bootstrap time.
3790 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3792 * expression.cs (Invocation.OverloadResolve): Avoid the
3793 use of hashtables and boxing here by allocating on demand.
3795 2004-05-30 Martin Baulig <martin@ximian.com>
3797 * rootcontext.cs (RootContext.LookupType): Don't cache things if
3798 we're doing a silent lookup. Don't try to lookup nested types in
3799 TypeManager.object_type (thanks to Ben Maurer).
3801 2004-05-30 Martin Baulig <martin@ximian.com>
3803 Committing a patch from Ben Maurer.
3805 * rootcontext.cs (RootContext.LookupType): Cache negative results.
3807 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3809 * convert.cs: add a trivial cache for overload operator resolution.
3811 2004-05-31 Marek Safar <marek.safar@seznam.cz>
3814 (AttributeTester.GetObsoleteAttribute): Returns instance of
3815 ObsoleteAttribute when type is obsolete.
3818 (TypeContainer.VerifyObsoleteAttribute): Override.
3819 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
3820 (MethodCode.VerifyObsoleteAttribute): Override.
3821 (MemberBase.VerifyObsoleteAttribute): Override.
3824 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
3825 and report proper error.
3828 (Delegate.VerifyObsoleteAttribute): Override.
3831 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
3832 and report proper error.
3833 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
3836 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
3840 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
3841 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
3842 Added test for ObsoleteAttribute.
3845 (Catch): Derived from Statement.
3847 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3849 * decl.cs: If possible, use lookuptypedirect here. We can only do
3850 this if there is no `.' after the namespace. Avoids using
3851 LookupType, which does lots of slow processing.
3852 (FindNestedType) New method, does what it says :-).
3853 * namespace.cs: use LookupTypeDirect.
3854 * rootcontext.cs: use membercache, if possible.
3855 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
3857 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3860 According to the spec,
3862 In a member access of the form E.I, if E is a single identifier,
3863 and if the meaning of E as a simple-name (§7.5.2) is a constant,
3864 field, property, localvariable, or parameter with the same type as
3865 the meaning of E as a type-name (§3.8), then both possible
3866 meanings of E are permitted.
3868 We did not check that E as a simple-name had the same type as E as
3871 This trivial check gives us 5-7% on bootstrap time.
3873 2004-05-30 Marek Safar <marek.safar@seznam.cz>
3875 Fixed bug #59071 & cs0160.cs
3876 * statement.cs (Try.Resolve): Check here whether order of catch
3877 clauses matches their dependencies.
3879 2004-05-30 Marek Safar <marek.safar@seznam.cz>
3882 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
3885 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3887 * expression.cs (Invocation.OverloadResolve): Avoid the
3888 use of hashtables and boxing here by allocating on demand.
3890 2004-05-30 Martin Baulig <martin@ximian.com>
3892 * rootcontext.cs (RootContext.LookupType): Don't cache things if
3893 we're doing a silent lookup. Don't try to lookup nested types in
3894 TypeManager.object_type (thanks to Ben Maurer).
3896 2004-05-30 Martin Baulig <martin@ximian.com>
3898 Committing a patch from Ben Maurer.
3900 * rootcontext.cs (RootContext.LookupType): Cache negative results.
3902 2004-05-29 Martin Baulig <martin@ximian.com>
3904 * class.cs (IMethodData.ShouldIgnore): New method.
3906 * typemanager.cs (TypeManager.MethodFlags): Don't take a
3907 `Location' argument, we don't need it anywhere. Use
3908 `IMethodData.ShouldIgnore ()' instead of
3909 `MethodData.GetMethodFlags ()'.
3910 (TypeManager.AddMethod): Removed.
3911 (TypeManager.AddMethod2): Renamed to AddMethod.
3913 2004-05-29 Martin Baulig <martin@ximian.com>
3915 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
3917 * convert.cs (Convert.ImplicitReferenceConversion): If we're
3918 converting from a class type S to an interface type and we already
3919 have an object on the stack, don't box it again. Fixes #52578.
3921 2004-05-29 Martin Baulig <martin@ximian.com>
3923 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3924 Added support for `params' parameters. Fixes #59267.
3926 2004-05-29 Martin Baulig <martin@ximian.com>
3928 * literal.cs (NullPointer): Provide a private .ctor which sets
3929 `type' to TypeManager.object_type. Fixes #59048.
3931 2004-05-29 Martin Baulig <martin@ximian.com>
3933 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
3934 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
3936 * ecore.cs (EventExpr.instance_expr): Make the field private.
3938 2004-05-26 Marek Safar <marek.safar@seznam.cz>
3940 Fixed bug #50080 & cs0214-2.cs
3941 * expression.cs (Cast.DoResolve): Check unsafe context here.
3943 * statement.cs (Resolve.DoResolve): Likewise.
3945 2004-05-26 Martin Baulig <martin@ximian.com>
3947 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
3949 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
3950 (RootContext.LookupType): Pass down the `silent' flag.
3952 2004-05-25 Martin Baulig <martin@ximian.com>
3955 (MethodGroupExpr.IdenticalTypeName): New public property.
3956 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
3957 expression actually refers to a type.
3959 2004-05-25 Martin Baulig <martin@ximian.com>
3961 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
3962 for #56176 and made it actually work.
3964 2004-05-25 Martin Baulig <martin@ximian.com>
3966 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
3967 (FieldExpr, PropertyExpr): Override and implement
3968 CacheTemporaries. Fixes #52279.
3970 2004-05-25 Miguel de Icaza <miguel@ximian.com>
3972 * location.cs: In the new compiler listing a file twice is a
3973 warning, not an error.
3975 2004-05-24 Martin Baulig <martin@ximian.com>
3977 * enum.cs (Enum.DefineType): For the `BaseType' to be a
3978 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
3980 2004-05-24 Martin Baulig <martin@ximian.com>
3982 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
3983 walking the `using' list. Fixes #53921.
3985 2004-05-24 Martin Baulig <martin@ximian.com>
3987 * const.cs (Const.LookupConstantValue): Added support for
3988 EmptyCast's; fixes #55251.
3990 2004-05-24 Martin Baulig <martin@ximian.com>
3992 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
3993 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
3994 which does the CS0135 check. The reason is that we first need to
3995 check whether the variable actually exists.
3997 2004-05-24 Martin Baulig <martin@ximian.com>
3999 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
4000 than RootContext.LookupType() to find the explicit interface
4003 2004-05-24 Raja R Harinath <rharinath@novell.com>
4005 * Makefile: Simplify. Use executable.make.
4006 * mcs.exe.sources: New file. List of sources of mcs.exe.
4008 2004-05-24 Anders Carlsson <andersca@gnome.org>
4012 Use the invariant culture when doing String.Compare for CLS case
4015 2004-05-23 Martin Baulig <martin@ximian.com>
4017 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
4018 don't have any dots. Fixes #52622, added cs0246-8.cs.
4020 * namespace.cs (NamespaceEntry.Lookup): Likewise.
4022 2004-05-23 Marek Safar <marek.safar@seznam.cz>
4024 * class.cs (MemberBase.Define): Reuse MemberType member for
4025 resolved type. Other methods can use it too.
4027 2004-05-23 Martin Baulig <martin@ximian.com>
4029 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
4030 the variable also exists in the current block (otherwise, we need
4031 to report a CS0103). Fixes #58670.
4033 2004-05-23 Martin Baulig <martin@ximian.com>
4035 * flowanalysis.cs (Reachability.Reachable): Compute this
4036 on-the-fly rather than storing it as a field.
4038 2004-05-23 Martin Baulig <martin@ximian.com>
4040 * flowanalysis.cs (Reachability.And): Manually compute the
4041 resulting `barrier' from the reachability.
4043 2004-05-23 Marek Safar <marek.safar@seznam.cz>
4046 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
4047 instance of ObsoleteAttribute when symbol is obsolete.
4050 (IMethodData): Extended interface for ObsoleteAttribute support.
4052 2004-05-22 Marek Safar <marek.safar@seznam.cz>
4054 * attribute.cs: Fix bug #55970
4056 2004-05-22 Marek Safar <marek.safar@seznam.cz>
4060 (GetObsoleteAttribute): New method. Creates the instance of
4062 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
4063 ObsoleteAttribute when member is obsolete.
4064 (AttributeTester.Report_ObsoleteMessage): Common method for
4065 Obsolete error/warning reporting.
4068 (TypeContainer.base_classs_type): New member for storing parent type.
4071 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
4072 for this MemberCore.
4074 2004-05-21 Marek Safar <marek.safar@seznam.cz>
4076 * attribute.cs, const.cs: Fix bug #58590
4078 2004-05-21 Martin Baulig <martin@ximian.com>
4080 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
4081 out parameters if the end of the method is unreachable. Fixes
4084 2004-05-21 Marek Safar <marek.safar@seznam.cz>
4086 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
4087 Hari was right, why extra method.
4089 2004-05-21 Marek Safar <marek.safar@seznam.cz>
4091 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
4093 2004-05-20 Martin Baulig <martin@ximian.com>
4095 * delegate.cs: Convert this file to Unix mode - like the original
4098 2004-05-20 Martin Baulig <martin@ximian.com>
4100 * attribute.cs: Convert this file to Unix mode - like the original
4103 2004-05-19 Marek Safar <marek.safar@seznam.cz>
4105 Fix bug #58688 (MCS does not report error when the same attribute
4108 * attribute.cs (Attribute.Emit): Distinction between null and default.
4110 2004-05-19 Raja R Harinath <rharinath@novell.com>
4112 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
4113 of a top-level attribute without an attribute target.
4114 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
4116 (Attribute.Conditional_GetConditionName),
4117 (Attribute.Obsolete_GetObsoleteMessage): Update.
4118 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
4119 part of ScanForIndexerName.
4120 (Attribute.CanIgnoreInvalidAttribute): New function.
4121 (Attribute.ScanForIndexerName): Move to ...
4122 (Attributes.ScanForIndexerName): ... here.
4123 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
4124 (Attributes.Search): New internal variant that can choose not to
4125 complain if types aren't resolved. The original signature now
4127 (Attributes.GetClsCompliantAttribute): Use internal variant, with
4128 complaints suppressed.
4129 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
4130 only if it not useful.
4131 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
4132 top-level for attributes that are shared between the assembly
4133 and a top-level class.
4134 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
4135 * class.cs: Update to reflect changes.
4136 (DefineIndexers): Fuse loops.
4137 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
4138 a couple more variants of attribute names.
4140 2004-05-18 Marek Safar <marek.safar@seznam.cz>
4142 Fix bug #52585 (Implemented explicit attribute declaration)
4145 (Attributable.ValidAttributeTargets): New abstract method. It gets
4146 list of valid attribute targets for explicit target declaration.
4147 (Attribute.Target): It holds target itself.
4148 (AttributeSection): Removed.
4149 (Attribute.CheckTargets): New method. It checks whether attribute
4150 target is valid for the current element.
4153 (EventProperty): New class. For events that are declared like
4154 property (with add and remove accessors).
4155 (EventField): New class. For events that are declared like field.
4158 * cs-parser.jay: Implemented explicit attribute target declaration.
4160 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
4161 Override ValidAttributeTargets.
4164 (ReturnParameter): Class for applying custom attributes on
4166 (ParameterAtribute): New class. Class for applying custom
4167 attributes on the parameter type.
4169 2004-05-17 Miguel de Icaza <miguel@ximian.com>
4171 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
4174 (Method): Allow UNSAFE here.
4176 * modifiers.cs: Support unsafe reporting.
4178 2004-05-17 Marek Safar <marek.safar@seznam.cz>
4180 * decl.cs: Fix bug #58478.
4182 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4184 * statement.cs: When checking for unreachable code on an EmptyStatement,
4185 set the location. Fixes bug #58488.
4187 2004-05-13 Miguel de Icaza <miguel@ximian.com>
4189 * driver.cs: Add -pkg handling.
4191 From Gonzalo: UseShelLExecute=false
4193 2004-05-12 Marek Safar <marek.safar@seznam.cz>
4196 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
4198 (Attribute.IsClsCompliaceRequired): Moved to base for better
4200 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
4201 when attribute is AttributeUsageAttribute.
4202 (Attribute.GetValidTargets): Simplified.
4203 (Attribute.GetAttributeUsage): New method returns AttributeUsage
4204 attribute for this type.
4205 (Attribute.ApplyAttributes): Method renamed to Emit and make
4207 (GlobalAttributeSection): New class for special handling of global
4208 attributes (assembly, module).
4209 (AttributeSection.Emit): New method.
4211 * class.cs: Implemented Attributable abstract methods.
4212 (MethodCore.LabelParameters): Moved to Parameter class.
4213 (Accessor): Is back simple class.
4214 (PropertyMethod): Implemented Attributable abstract class.
4215 (DelegateMethod): Implemented Attributable abstract class.
4216 (Event): New constructor for disctintion between normal Event
4217 and Event with accessors.
4219 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
4221 * codegen.cs, const.cs, decl.cs, delegate.cs:
4222 (CommonAssemblyModulClass): Implemented Attributable abstract class
4225 * enum.cs: Implement IAttributeSupport interface.
4226 (EnumMember): New class for emum members. Implemented Attributable
4230 (ParameterBase): Is abstract.
4231 (ReturnParameter): New class for easier [return:] attribute handling.
4233 * typemanager.cs: Removed builder_to_attr.
4235 2004-05-11 Raja R Harinath <rharinath@novell.com>
4238 * attribute.cs (Attribute.GetPositionalValue): New function.
4239 * class.cs (TypeContainer.VerifyMembers): New function.
4240 (TypeContainer.Emit): Use it.
4241 (ClassOrStruct): New base class for Class and Struct.
4242 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
4243 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
4245 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
4246 then each non-static field should have a FieldOffset attribute.
4247 Otherwise, none of the fields should have a FieldOffset attribute.
4248 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
4249 and FieldOffset attributes.
4250 * typemanager.cs (TypeManager.struct_layout_attribute_type)
4251 (TypeManager.field_offset_attribute_type): New core types.
4252 (TypeManager.InitCoreTypes): Initialize them.
4254 2004-05-11 Michal Moskal <malekith@pld-linux.org>
4256 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
4257 Return correct type.
4260 2004-05-09 Miguel de Icaza <miguel@ximian.com>
4262 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
4263 be implicitly converted to ulong.
4265 * expression.cs: The logic for allowing operator &, | and ^ worked
4266 was wrong, it worked before because we did not report an error in
4267 an else branch. Fixes 57895.
4269 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
4270 allow volatile fields to be reference types.
4272 2004-05-07 Miguel de Icaza <miguel@ximian.com>
4274 * driver.cs: Add support for /debug-
4276 2004-05-07 Raja R Harinath <rharinath@novell.com>
4278 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
4279 Add a 'complain' parameter to silence errors.
4280 (Attribute.Resolve): Update to changes. Put in sanity check to catch
4281 silently overlooked type-resolutions.
4282 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
4284 (Attributes.Search): New function.
4285 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
4286 (Attributes.GetAttributeFullName): Remove hack.
4287 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
4288 Update to reflect changes.
4289 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
4290 Use Attributes.Search instead of nested loops.
4292 2004-05-07 Marek Safar <marek.safar@seznam.cz>
4295 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
4296 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
4297 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
4299 * report.cs: (Report.Warning): Renamed to Warning_T because of
4300 parameter collision.
4302 2004-05-05 Raja R Harinath <rharinath@novell.com>
4304 * expression.cs (MemberAccess.ResolveMemberAccess):
4305 Exit with non-zero status after Report.Error.
4306 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
4308 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
4310 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
4312 * support.cs: Don't hang when the file is empty.
4314 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
4316 * support.cs: In SeekableStreamReader, compute the preamble size of the
4317 underlying stream. Position changes should take into account that initial
4320 2004-05-03 Todd Berman <tberman@sevenl.net>
4322 * driver.cs: remove unused GetSysVersion function.
4324 2004-05-03 Todd Berman <tberman@sevenl.net>
4326 * driver.cs: Remove the hack from saturday, as well as the hack
4327 from jackson (LoadAssemblyFromGac), also adds the CWD to the
4328 link_paths to get that bit proper.
4330 2004-05-01 Todd Berman <tberman@sevenl.net>
4332 * driver.cs: Try a LoadFrom before a Load, this checks the current
4333 path. This is currently a bug in mono that is be fixed, however, this
4334 provides a workaround for now. This will be removed when the bug
4337 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
4339 * CryptoConvert.cs: Updated to latest version. Fix issue with
4340 incomplete key pairs (#57941).
4342 2004-05-01 Todd Berman <tberman@sevenl.net>
4344 * driver.cs: Remove '.' from path_chars, now System.* loads properly
4347 2004-04-30 Jackson Harper <jackson@ximian.com>
4349 * codegen.cs: Open keys readonly.
4351 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4353 * typemanager.cs: don't report cyclic struct layout when a struct
4354 contains 2 or more fields of the same type. Failed for Pango.AttrShape
4355 which has 2 Pango.Rectangle fields.
4357 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
4359 * expression.cs: Handle IntPtr comparisons with IL code
4360 rather than a method call.
4362 2004-04-29 Martin Baulig <martin@ximian.com>
4364 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
4365 the list of PropertyInfo's in class hierarchy and find the
4366 accessor. Fixes #56013.
4368 2004-04-29 Martin Baulig <martin@ximian.com>
4370 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
4372 2004-04-29 Martin Baulig <martin@ximian.com>
4374 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
4376 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
4378 2004-04-29 Martin Baulig <martin@ximian.com>
4380 * class.cs (ConstructorInitializer.Resolve): Check whether the
4381 parent .ctor is accessible. Fixes #52146.
4383 2004-04-29 Martin Baulig <martin@ximian.com>
4385 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
4387 * statement.cs (Using.EmitLocalVariableDecls): Use
4388 TypeManager.idisposable_type, not typeof (IDisposable).
4389 (Foreach.EmitCollectionForeach): Added support for valuetypes.
4391 2004-04-29 Martin Baulig <martin@ximian.com>
4393 * class.cs (Event.Define): Don't emit the field and don't set
4394 RTSpecialName and SpecialName for events on interfaces. Fixes
4397 2004-04-29 Raja R Harinath <rharinath@novell.com>
4399 Refactor Attribute.ApplyAttributes.
4400 * attribute.cs (Attributable): New base class for objects that can
4401 have Attributes applied on them.
4402 (Attribute): Make AttributeUsage fields public.
4403 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
4404 (Attribute.IsInternalCall): New property.
4405 (Attribute.UsageAttr): Convert to a public read-only property.
4406 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
4407 (Attribute.ResolveType, Attribute.Resolve)
4408 (Attribute.ScanForIndexerName): Update to reflect changes.
4409 (Attribute.CheckAttributeTarget): Re-format.
4410 (Attribute.ApplyAttributes): Refactor, to various
4411 Attributable.ApplyAttributeBuilder methods.
4412 * decl.cs (MemberCore): Make Attributable.
4413 * class.cs (Accessor): Make Attributable.
4414 (MethodData.ApplyAttributes): Use proper attribute types, not
4416 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
4417 (TypeContainer.ApplyAttributeBuilder)
4418 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
4419 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
4420 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
4421 (Operator.ApplyAttributeBuilder): New factored-out methods.
4422 * const.cs (Const.ApplyAttributeBuilder): Likewise.
4423 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
4424 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
4425 * parameter.cs (ParameterBase): New Attributable base class
4426 that can also represent Return types.
4427 (Parameter): Update to the changes.
4429 2004-04-29 Jackson Harper <jackson@ximian.com>
4431 * driver.cs: Prefer the corlib system version when looking for
4432 assemblies in the GAC. This is still a hack, but its a better hack
4435 2004-04-29 Marek Safar <marek.safar@seznam.cz>
4437 * decl.cs, enum.cs: Improved error 3005 reporting.
4439 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
4440 (related_symbols): New private member for list of symbols
4441 related to reported error/warning.
4443 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
4445 2004-04-29 Martin Baulig <martin@ximian.com>
4447 * ecore.cs (Expression.Constantify): If we're an enum and
4448 TypeManager.TypeToCoreType() doesn't give us another type, use
4449 t.UnderlyingSystemType. Fixes #56178.
4451 2004-04-29 Martin Baulig <martin@ximian.com>
4453 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
4454 interfaces and for each interface, only add members directly
4455 declared in that interface. Fixes #53255.
4457 2004-04-28 Martin Baulig <martin@ximian.com>
4459 * expression.cs (ConditionalLogicalOperator): Use a temporary
4460 variable for `left' to avoid that we evaluate it more than once;
4463 2004-04-28 Martin Baulig <martin@ximian.com>
4465 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
4468 2004-04-28 Martin Baulig <martin@ximian.com>
4470 * statement.cs (LocalInfo.Resolve): Check whether the type is not
4473 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
4474 whether the type is not void (CS1547).
4476 2004-04-28 Martin Baulig <martin@ximian.com>
4478 * expression.cs (Unary.DoResolveLValue): Override this and report
4479 CS0131 for anything but Operator.Indirection.
4481 2004-04-28 Martin Baulig <martin@ximian.com>
4483 Committing a patch from Ben Maurer; see bug #50820.
4485 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
4488 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
4491 2004-04-28 Martin Baulig <martin@ximian.com>
4493 Committing a patch from Ben Maurer; see bug #50820.
4495 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
4498 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
4501 2004-04-28 Martin Baulig <martin@ximian.com>
4503 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
4504 (Block.AddLabel): Call DoLookupLabel() to only search in the
4507 2004-04-28 Martin Baulig <martin@ximian.com>
4509 * cfold.cs (ConstantFold.BinaryFold): Added special support for
4510 comparing StringConstants and NullLiterals in Equality and Inequality.
4512 2004-04-28 Jackson Harper <jackson@ximian.com>
4514 * driver.cs: Attempt to load referenced assemblies from the
4515 GAC. This is the quick and dirty version of this method that
4516 doesnt take into account versions and just takes the first
4517 canidate found. Will be good enough for now as we will not have more
4518 then one version installed into the GAC until I update this method.
4520 2004-04-28 Martin Baulig <martin@ximian.com>
4522 * typemanager.cs (TypeManager.CheckStructCycles): New public
4523 static method to check for cycles in the struct layout.
4525 * rootcontext.cs (RootContext.PopulateTypes): Call
4526 TypeManager.CheckStructCycles() for each TypeContainer.
4527 [Note: We only need to visit each type once.]
4529 2004-04-28 Martin Baulig <martin@ximian.com>
4531 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
4533 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
4534 success and added `out object value'. Use a `bool resolved' field
4535 to check whether we've already been called rather than
4536 `ConstantValue != null' since this breaks for NullLiterals.
4538 2004-04-28 Raja R Harinath <rharinath@novell.com>
4540 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
4541 setting of this flag, since the 'set' method may be non-public.
4543 2004-04-28 Raja R Harinath <rharinath@novell.com>
4545 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
4546 check on current_vector.Block.
4548 2004-04-27 Martin Baulig <martin@ximian.com>
4550 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
4551 a field initializer. Fixes #56459.
4553 2004-04-27 Martin Baulig <martin@ximian.com>
4555 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
4556 we're not attempting to use an indexer. Fixes #52154.
4558 2004-04-27 Martin Baulig <martin@ximian.com>
4560 * statement.cs (Return): Don't create a return label if we don't
4561 need it; reverts my change from January 20th. Thanks to Ben
4564 2004-04-27 Martin Baulig <martin@ximian.com>
4566 According to the spec, `goto' can only leave a nested scope, but
4569 * statement.cs (Block.LookupLabel): Only lookup in the current
4570 block, don't recurse into parent or child blocks.
4571 (Block.AddLabel): Check in parent and child blocks, report
4572 CS0140/CS0158 if we find a duplicate.
4573 (Block): Removed this indexer for label lookups.
4574 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
4575 this already does the error reporting for us.
4578 (FlowBranching.UsageVector.Block): New public variable; may be null.
4579 (FlowBranching.CreateSibling): Added `Block' argument.
4580 (FlowBranching.LookupLabel): New public virtual method. Lookup a
4581 label for the target of a `goto' and check whether we're not
4582 leaving a `finally'.
4584 2004-04-27 Martin Baulig <martin@ximian.com>
4586 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
4587 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
4590 2004-04-27 Martin Baulig <martin@ximian.com>
4592 * statement.cs (Block.AddLabel): Also check for implicit blocks
4593 and added a CS0158 check.
4595 2004-04-27 Martin Baulig <martin@ximian.com>
4597 * flowanalysis.cs (FlowBranchingLoop): New class.
4598 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
4599 UsageVector's instead of an ArrayList.
4600 (FlowBranching.Label): Likewise.
4601 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
4602 (FlowBranching.AddBreakVector): New method.
4604 2004-04-27 Miguel de Icaza <miguel@ximian.com>
4606 * attribute.cs: Small regression fix: only convert the type if we
4607 the type is different, fixes System.Drawing build.
4609 2004-04-27 Martin Baulig <martin@ximian.com>
4611 * attribute.cs (Attribute.Resolve): If we have a constant value
4612 for a named field or property, implicity convert it to the correct
4615 2004-04-27 Raja R Harinath <rharinath@novell.com>
4617 * statement.cs (Block.Block): Implicit blocks share
4618 'child_variable_names' fields with parent blocks.
4619 (Block.AddChildVariableNames): Remove.
4620 (Block.AddVariable): Mark variable as "used by a child block" in
4621 every surrounding block.
4622 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
4623 been used in a child block, complain about violation of "Invariant
4624 meaning in blocks" rule.
4625 * cs-parser.jay (declare_local_variables): Don't use
4626 AddChildVariableNames.
4627 (foreach_statement): Don't create an implicit block: 'foreach'
4630 2004-04-23 Miguel de Icaza <miguel@ximian.com>
4632 * convert.cs (ImplicitNumericConversion): 0 is also positive when
4633 converting from 0L to ulong. Fixes 57522.
4635 2004-04-22 Marek Safar <marek.safar@seznam.cz>
4637 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
4638 derived class hides via 'new' keyword field from base class (test-242.cs).
4639 TODO: Handle this in the more general way.
4641 * class.cs (CheckBase): Ditto.
4643 2004-04-22 Marek Safar <marek.safar@seznam.cz>
4645 * decl.cs (caching_flags): New member for storing cached values
4647 (MemberCore.Flags): New enum where bit flags for caching_flags
4649 (MemberCore.cls_compliance): Moved to caching_flags.
4650 (DeclSpace.Created): Moved to caching_flags.
4652 * class.cs: Use caching_flags instead of DeclSpace.Created
4654 2004-04-21 Miguel de Icaza <miguel@ximian.com>
4656 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
4657 if we are only a derived class, not a nested class.
4659 * typemanager.cs: Same as above, but do this at the MemberLookup
4660 level (used by field and methods, properties are handled in
4661 PropertyExpr). Allow for the qualified access if we are a nested
4664 2004-04-21 Marek Safar <marek.safar@seznam.cz>
4666 * class.cs: Refactoring.
4667 (IMethodData): New inteface; Holds links to parent members
4668 to avoid member duplication (reduced memory allocation).
4669 (Method): Implemented IMethodData interface.
4670 (PropertyBase): New inner classes for get/set methods.
4671 (PropertyBase.PropertyMethod): Implemented IMethodData interface
4672 (Event): New inner classes for add/remove methods.
4673 (Event.DelegateMethod): Implemented IMethodData interface.
4675 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
4676 EmitContext (related to class.cs refactoring).
4678 2004-04-21 Raja R Harinath <rharinath@novell.com>
4680 * delegate.cs (Delegate.VerifyApplicability): If the number of
4681 arguments are the same as the number of parameters, first try to
4682 verify applicability ignoring any 'params' modifier on the last
4686 2004-04-08 Martin Baulig <martin@ximian.com>
4688 Merged latest changes into gmcs. Please keep this comment in
4689 here, it makes it easier for me to see what changed in MCS since
4690 the last time I merged.
4692 2004-04-16 Raja R Harinath <rharinath@novell.com>
4694 * class.cs (TypeContainer.AddIndexer): Use
4695 'ExplicitInterfaceName' to determine if interface name was
4696 explicitly specified. 'InterfaceType' is not initialized at this time.
4697 (TypeContainer.DefineIndexers): Remove use of temporary list. The
4698 Indexers array is already in the required order. Initialize
4699 'IndexerName' only if there are normal indexers.
4700 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
4701 (TypeContainer.Emit): Emit DefaultMember attribute only if
4702 IndexerName is initialized.
4705 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
4707 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
4710 2004-04-15 Raja R Harinath <rharinath@novell.com>
4712 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
4716 * attribute.cs (Attribute.Resolve): Check for duplicate named
4720 2004-04-15 Miguel de Icaza <miguel@ximian.com>
4722 * iterators.cs (MarkYield): track whether we are in an exception,
4723 and generate code accordingly. Use a temporary value to store the
4724 result for our state.
4726 I had ignored a bit the interaction of try/catch with iterators
4727 since their behavior was not entirely obvious, but now it is
4728 possible to verify that our behavior is the same as MS .NET 2.0
4732 2004-04-14 Miguel de Icaza <miguel@ximian.com>
4734 * iterators.cs: Avoid creating temporaries if there is no work to
4737 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
4738 Enumerations, use TypeManager.EnumToUnderlying and call
4741 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
4744 (This.Emit): Use EmitContext.EmitThis to emit our
4747 (This.EmitAssign): Ditto.
4749 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
4750 codepaths, we will move all the functionality into
4753 (FieldExpr.EmitAssign): Ditto.
4755 This fixes several hidden bugs that I uncovered while doing a code
4756 review of this today.
4758 * codegen.cs (EmitThis): reworked so the semantics are more clear
4759 and also support value types "this" instances.
4761 * iterators.cs: Changed so that for iterators in value types, we
4762 do not pass the value type as a parameter.
4764 Initialization of the enumerator helpers is now done in the caller
4765 instead of passing the parameters to the constructors and having
4766 the constructor set the fields.
4768 The fields have now `assembly' visibility instead of private.
4770 2004-04-11 Miguel de Icaza <miguel@ximian.com>
4772 * expression.cs (Argument.Resolve): Check if fields passed as ref
4773 or out are contained in a MarshalByRefObject.
4775 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
4776 another compiler type.
4778 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
4780 * class.cs (Indexer.Define): use the new name checking method.
4781 Also, return false on an error.
4782 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
4783 (is_identifier_[start/part]_character): make static.
4785 2004-04-10 Miguel de Icaza <miguel@ximian.com>
4787 * expression.cs (Binary.ResolveOperator): Do no append strings
4788 twice: since we can be invoked more than once (array evaluation)
4789 on the same concatenation, take care of this here. Based on a fix
4790 from Ben (bug #56454)
4792 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
4794 * codegen.cs: Fix another case where CS1548 must be reported (when
4795 delay-sign isn't specified and no private is available #56564). Fix
4796 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
4797 error when MCS is used on the MS runtime and we need to delay-sign
4798 (which seems unsupported by AssemblyBuilder - see #56621).
4800 2004-04-08 Marek Safar <marek.safar@seznam.cz>
4802 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
4803 (TypeManager.ComputeNamespaces): Faster implementation for
4806 * compiler.csproj: Updated AssemblyName to mcs.
4808 2004-05-11 Jackson Harper <jackson@ximian.com>
4810 * Makefile: Preserve MONO_PATH
4812 2004-05-11 Jackson Harper <jackson@ximian.com>
4814 * Makefile: Use mono and mcs to build gmcs
4816 2004-05-03 Miguel de Icaza <miguel@ximian.com>
4818 * codegen.cs: Add patch from Robert Shade
4819 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
4822 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
4824 * CryptoConvert.cs: Updated to latest version. Fix issue with
4825 incomplete key pairs (#57941).
4827 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
4829 * codegen.cs: Fix another case where CS1548 must be reported (when
4830 delay-sign isn't specified and no private is available #56564). Fix
4831 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
4832 error when MCS is used on the MS runtime and we need to delay-sign
4833 (which seems unsupported by AssemblyBuilder - see #56621).
4835 2004-04-29 Jackson Harper <jackson@ximian.com>
4837 * Makefile: Set MONO_PATH to use the bootstrap corlib
4838 * driver.cs: Check the GAC for referenced assemblies.
4840 2004-04-29 Martin Baulig <martin@ximian.com>
4842 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
4844 2004-04-07 Martin Baulig <martin@ximian.com>
4846 * expression.cs (Binary.ResolveOperator): Added special case for
4847 Equality/Inequality between a type parameter and a null literal.
4849 2004-04-07 Martin Baulig <martin@ximian.com>
4851 * convert.cs: Check null literal -> type parameter conversions.
4853 2004-04-07 Martin Baulig <martin@ximian.com>
4855 * generic.cs (ConstructedType.CheckConstraints): Enforce the
4856 `class' and `struct' constraints.
4858 2004-04-07 Martin Baulig <martin@ximian.com>
4860 * generic.cs (SpecialConstraint): New public enum.
4861 (Constraints.Resolve): Added support for the `class' and `struct'
4864 * cs-parser.jay (type_parameter_constraint): Added support for the
4865 `class' and `struct' constraints.
4867 2004-04-07 Martin Baulig <martin@ximian.com>
4869 * support.cs (GenericConstraints): Replaced `Types' by
4870 `ClassConstraint' and `InterfaceConstraints'; added
4871 `HasClassConstraint'.
4873 2004-04-07 Martin Baulig <martin@ximian.com>
4876 (Constraints.InterfaceConstraints): New public property.
4877 (Constraints.Types): Make this property public
4878 (TypeParameter): Implement IMemberContainer.
4879 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
4880 instead of a TypeBuilder/MethodBuilder; pass the interface
4881 constraints to TypeManager.AddTypeParameter().
4882 (TypeParameter.DefineType): Just take an EmitContext and no
4883 TypeBuilder/MethodBuilder. Use the new public API.
4885 * typemanager.cs (TypeManager.AddTypeParameter): Added
4886 `TypeExpr[]' argument; add the interfaces to the
4887 `builder_to_ifaces' hash.
4888 (TypeManager.LookupMemberContainer): For
4889 GenericTypeParameterBuilders, get the TypeParameter from the
4890 `builder_to_type_param'.
4891 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
4892 the TypeParameter and call FindMembers on it.
4894 2004-04-07 Martin Baulig <martin@ximian.com>
4897 (MethodCore.GenericMethod): Moved this field here from Method.
4898 (MethodCore.IsDuplicateImplementation): Take the number of type
4899 parameters into account if we're a generic method.
4901 * expression.cs (Invocation.InferTypeArguments): Don't return true
4902 if `arguments' is null; we still need to check whether we actually
4903 don't need to infer anything in this case.
4904 (MemberAccess): Merged the functionality from GenericMemberAccess
4907 * generic.cs (GenericMemberAccess): Removed.
4909 2004-04-05 Martin Baulig <martin@ximian.com>
4911 * decl.cs (MemberCore): For generic classes, interfaces and
4912 structs, `Name' now includes the number of type parameters
4914 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
4915 encode the number of type arguments in the type name.
4917 * expression.cs (Expression.MemberLookup): Removed the
4918 `num_type_args' argument; we now encode the number of type
4919 arguments in the type name.
4921 * ecore.cs (SimpleName): Encode the number of type arguments in
4922 the type name itself.
4924 * generic.cs (ConstructedType): Likewise.
4926 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
4927 `MemberName'; we now include the number of type parameters in the
4930 * typemanager.cs (TypeManager.CheckGeneric): Removed.
4931 (TypeManager.MemberLookup): Removed the
4932 `num_type_args' argument; we now encode the number of type
4933 arguments in the type name.
4935 2004-04-03 Martin Baulig <martin@ximian.com>
4937 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
4938 (MemberCore.MemberName): Moved here from MemberBase.
4939 (DeclSpace.SetParameterInfo): Just take the constraints as an
4940 ArrayList; we already have the type parameters in our
4941 `MemberName'; also do the CS0080 reporting here.
4943 * cs-parser.jay (struct_declaration): Use `member_name' instead of
4944 `IDENTIFIER opt_type_parameter_list'; when constructing our
4945 `MemberName', it'll already include our type parameters.
4946 (class_declaration, interface_declaration): Likewise.
4947 (delegate_declaration): Likewise.
4948 (MakeName): Take a MemberName and return a MemberName.
4949 The following two changes are required to avoid shift/reduce conflicts:
4950 (member_name): Don't include a TypeName anymore; ie. this is now
4951 just 'IDENTIFIER opt_type_parameter_list'.
4952 (property_declaration, event_declaration): Use a
4953 `namespace_or_type_name' instead of a `member_name'.
4955 2004-04-03 Martin Baulig <martin@ximian.com>
4957 * decl.cs (MemberName): Renamed to `TypeName' and created a new
4959 (TypeName): Formerly known as MemberName.
4961 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
4962 instead of a `MemberName'.
4964 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
4965 (member_name): New rule; create a MemberName.
4967 2004-04-02 Martin Baulig <martin@ximian.com>
4969 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
4970 (CS0305 and CS0308).
4972 2004-04-02 Martin Baulig <martin@ximian.com>
4974 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
4975 support for nested types.
4977 2004-04-02 Martin Baulig <martin@ximian.com>
4979 * ecore.cs (IAlias): New public interface.
4980 (TypeExpr, TypeExpression): Implement IAlias.
4981 (TypeAliasExpression): New public class.
4983 * namespace.cs (Namespace): Implement IAlias.
4984 (Namespace.Lookup): Return an IAlias instead on an object.
4985 (Namespace.DefineName): Take an IAlias instead of an object.
4986 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
4988 (NamespaceEntry.UsingAlias): Take a Membername instead of an
4990 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
4992 (NamespaceEntry.Lookup): Likewise.
4994 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
4997 * decl.cs (DeclSpace): Implement IAlias.
4998 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
5000 * generic.cs (ConstructedType): Improved error checking.
5002 2004-04-02 Martin Baulig <martin@ximian.com>
5004 * convert.cs: Added type parameter conversions.
5007 (UnboxCast.Emit): Emit an `unbox.any' for type params.
5008 (ClassCast.Emit): If the source type is a type parameter, box it.
5009 If the target type is a type parameter, emit an `unbox.any'
5010 instead of a `classcast'.1
5012 2004-04-01 Martin Baulig <martin@ximian.com>
5014 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
5016 2004-04-01 Martin Baulig <martin@ximian.com>
5018 * generic.cs (ConstructedType.CheckConstraints): Use
5019 Convert.ImplicitStandardConversionExists(); user-defined implicit
5020 conversions are not allowed according to the spec.
5022 2004-03-30 Martin Baulig <martin@ximian.com>
5024 * expression.cs (New): Added support for type parameters.
5027 (TypeManager.activator_type): New public static field.
5028 (TypeManager.activator_create_instance): Likewise.
5030 2004-03-30 Martin Baulig <martin@ximian.com>
5032 * typemanager.cs (TypeManager.HasConstructorConstraint): New
5035 2004-03-30 Martin Baulig <martin@ximian.com>
5037 * generic.cs (ConstructedType.CheckConstraints): Actually follow
5038 the spec here: the argument type must be convertible to the
5041 2004-03-30 Martin Baulig <martin@ximian.com>
5044 (TypeParameter.Define, TypeParameter.DefineMethod): Call
5045 TypeManager.AddTypeParameter().
5046 (ConstructedType.CheckConstraints): Re-enable this and actually
5047 check whether we have a constructor constraint.
5050 (TypeManager.builder_to_type_param): New static field.
5051 (TypeManager.AddTypeParameter): New static method.
5052 (TypeManager.LookupTypeParameter): New public method.
5054 2004-03-30 Martin Baulig <martin@ximian.com>
5056 * generic.cs (TypeParameter.DefineType): Return a boolean and use
5057 the new API to actually define the constructor constraint.
5060 (TypeManager.new_constraint_attr_type): New static field.
5061 (TypeManager.InitCoreTypes): Initialize it.
5063 2004-03-30 Martin Baulig <martin@ximian.com>
5065 * generic.cs (Constraints): Completed error checking, use correct
5068 2004-03-29 Martin Baulig <martin@ximian.com>
5070 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
5072 * expression.cs (Invocation.InferTypeArguments): Added overloaded
5073 public version which takes a `ParameterData pd' instead of an
5076 2004-03-29 Martin Baulig <martin@ximian.com>
5078 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
5081 2004-03-29 Martin Baulig <martin@ximian.com>
5083 * expression.cs (Argument.ResolveMethodGroup): If we're a
5084 ConstructedType, call GetMemberAccess() on it.
5086 2004-03-29 Martin Baulig <martin@ximian.com>
5088 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
5089 (MethodCore.CheckGenericOverride): When overriding a generic
5090 method, check whether the constraints match.
5092 * support.cs (GenericConstraints): New public interface.
5093 (ParameterData.GenericConstraints): New public method.
5095 * parameter.cs (Parameter.Resolve): Check whether we're a generic
5096 method parameter and compute our constraints if appropriate.
5097 (Parameter.GenericConstraints): New public property.
5099 * generic.cs (Constraints): Implement GenericConstraints.
5101 2004-03-29 Martin Baulig <martin@ximian.com>
5103 * decl.cs (MemberCache.FindMemberToOverride): Use
5104 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
5106 2004-03-29 Martin Baulig <martin@ximian.com>
5108 * generic.cs (GenericMethod.Define): Resolve our type parameters.
5110 2004-03-29 Martin Baulig <martin@ximian.com>
5112 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
5113 not allowed on non-generic declarations").
5115 2004-03-29 Martin Baulig <martin@ximian.com>
5117 * expression.cs (Invocation.InferTypeArguments): Added overloaded
5118 public version of this method.
5120 * class.cs (MethodCore.IsDuplicateImplementation): Use
5121 Invocation.InferTypeArguments() to check this.
5123 2004-03-29 Martin Baulig <martin@ximian.com>
5125 * convert.cs: Use TypeManager.IsDelegateType() instead of
5126 comparing types correctly.
5128 2004-03-29 Martin Baulig <martin@ximian.com>
5130 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
5131 types directly to make it work for generic instances.
5133 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
5135 2004-03-29 Martin Baulig <martin@ximian.com>
5137 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
5140 2004-03-24 Martin Baulig <martin@ximian.com>
5142 * decl.cs (DeclSpace.FindType): Also use
5143 TypeManager.CheckGeneric() for types from the using clauses.
5145 2004-03-23 Martin Baulig <martin@ximian.com>
5147 * expression.cs (Invocation.OverloadResolve): Added `bool
5148 may_fail' argument and use it instead of the Location.IsNull() hack.
5150 2004-03-23 Martin Baulig <martin@ximian.com>
5152 * expression.cs (Invocation.InferType): Use correct type inference
5155 2004-03-23 Martin Baulig <martin@ximian.com>
5157 * ecore.cs (MethodGroupExpr.Name): Use
5158 TypeManager.CSharpSignature() instead of just the name.
5160 * expression.cs (Invocation.OverloadResolve): Provide better error
5162 (Invocation.DoResolve): OverloadResolve() never returns null
5163 without reporting an error, so removed the error -6 reporting here.
5165 2004-03-23 Martin Baulig <martin@ximian.com>
5167 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
5170 * cs-parser.jay (delegate_declaration): Support generic delegates.
5172 * delegate.cs: Support generic delegates.
5174 2004-03-22 Martin Baulig <martin@ximian.com>
5176 * expression.cs (Invocation.InferParamsTypeArguments): New static
5177 method; does type inference for params arguments.
5179 2004-03-21 Martin Baulig <martin@ximian.com>
5181 * typemanager.cs (TypeManager.IsGenericMethod): New public static
5182 method; checks whether a method is a generic method.
5184 * expression.cs (Invocation.InferTypeArguments): New static method;
5185 infer type arguments for generic method invocation.
5187 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
5188 property; we set this to true if we're resolving a generic method
5189 invocation and the user specified type arguments, ie. we're not
5190 doing type inference.
5192 2004-03-20 Martin Baulig <martin@ximian.com>
5194 * class.cs (MethodData.DeclaringType): New public property.
5195 (MethodData.Define): Set DeclaringType here.
5196 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
5197 instead of OperatorMethodBuilder.DeclaringType.
5199 2004-03-20 Martin Baulig <martin@ximian.com>
5201 * cs-tokenizer.cs (xtoken): Return a special
5202 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
5204 * cs-parser.jay (default_value_expression): Switch to the new
5207 2004-03-19 Martin Baulig <martin@ximian.com>
5209 * decl.cs (MemberName): New class. We use this to "construct"
5210 namespace_or_type_name's.
5212 * generics.cs (TypeArguments.GetDeclarations): New public method;
5213 returns the type arguments as a string[] and reports a CS0081 if
5214 one of them is not an identifier.
5216 * class.cs (MemberBase): The .ctor now takes the name as a
5217 MemberName instead of a string.
5218 (MemberBase.ExplicitInterfaceName): Changed type from string to
5220 (MemberBase.DoDefine): If we're an explicit implementation, the
5221 InterfaceType may be a generic instance.
5223 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
5224 (namespace_name): Call MemberName.GetName () to transform the
5225 MemberName into a string and ensure we don't have any type
5227 (type_name): Call MemberName.GetTypeExpression() to transfrom the
5228 MemberName into an expression.
5229 (method_header): Use namespace_or_type_name instead of member_name.
5231 2004-04-07 Miguel de Icaza <miguel@ximian.com>
5233 * rootcontext.cs: Add new types to the boot resolution.
5235 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
5236 MulticastDelegate is not allowed.
5238 * typemanager.cs: Add new types to lookup: System.TypedReference
5241 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
5242 check for TypedReference or ArgIterator, they are not allowed.
5244 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
5245 makes us properly catch 1510 in some conditions (see bug 56016 for
5248 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
5250 * CryptoConvert.cs: update from corlib version
5253 2004-04-05 Miguel de Icaza <miguel@ximian.com>
5255 * class.cs (Indexer.Define): Check indexername declaration
5257 2004-04-05 Marek Safar <marek.safar@seznam.cz>
5259 * attribute.cs (IsClsCompliant): Fixed problem with handling
5260 all three states (compliant, not-compliant, undetected).
5262 2004-03-30 Marek Safar <marek.safar@seznam.cz>
5264 * attribute.cs (Attribute): Location is now public.
5265 (Resolve): Store resolved arguments (pos_values) in attribute class.
5266 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
5267 (GetClsCompliantAttributeValue): New method that gets
5268 CLSCompliantAttribute value.
5269 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
5270 if exists else null.
5271 (AttributeTester): New class for CLS-Compliant verification routines.
5273 * class.cs (Emit): Add CLS-Compliant verification.
5274 (Method.GetSignatureForError): Implemented.
5275 (Constructor.GetSignatureForError): Implemented
5276 (Constructor.HasCompliantArgs): Returns if constructor has
5277 CLS-Compliant arguments.
5278 (Constructor.Emit): Override.
5279 (Construcor.IsIdentifierClsCompliant): New method; For constructors
5280 is needed to test only parameters.
5281 (FieldBase.GetSignatureForError): Implemented.
5282 (TypeContainer): New member for storing base interfaces.
5283 (TypeContainer.FindMembers): Search in base interfaces too.
5285 * codegen.cs (GetClsComplianceAttribute): New method that gets
5286 assembly or module CLSCompliantAttribute value.
5287 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
5289 (ModuleClass.Emit): Add error 3012 test.
5291 * const.cs (Emit): Override and call base for CLS-Compliant tests.
5293 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
5294 state for all decl types.
5295 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
5296 if CLS-Compliant tests are required.
5297 (IsClsCompliaceRequired): New method. Analyze whether code
5298 must be CLS-Compliant.
5299 (IsExposedFromAssembly): New method. Returns true when MemberCore
5300 is exposed from assembly.
5301 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
5302 value or gets cached value.
5303 (HasClsCompliantAttribute): New method. Returns true if MemberCore
5304 is explicitly marked with CLSCompliantAttribute.
5305 (IsIdentifierClsCompliant): New abstract method. This method is
5306 used to testing error 3005.
5307 (IsIdentifierAndParamClsCompliant): New method. Common helper method
5308 for identifier and parameters CLS-Compliant testing.
5309 (VerifyClsCompliance): New method. The main virtual method for
5310 CLS-Compliant verifications.
5311 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
5312 null. I don't know why is null (too many public members !).
5313 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
5314 and get value of first CLSCompliantAttribute that found.
5316 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
5317 (VerifyClsCompliance): Override and add extra tests.
5319 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
5320 clscheck- disable CLS-Compliant verification event if assembly is has
5321 CLSCompliantAttribute(true).
5323 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
5324 ApllyAttribute is now called in emit section as in the other cases.
5325 Possible future Emit integration.
5326 (IsIdentifierClsCompliant): New override.
5327 (VerifyClsCompliance): New override.
5328 (GetEnumeratorName): Returns full enum name.
5330 * parameter.cs (GetSignatureForError): Implemented.
5332 * report.cs (WarningData): New struct for Warning message information.
5333 (LocationOfPreviousError): New method.
5334 (Warning): New method. Reports warning based on the warning table.
5335 (Error_T): New method. Reports error based on the error table.
5337 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
5338 verifications are done here.
5340 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
5342 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
5343 CLSCompliantAttribute.
5344 (all_imported_types): New member holds all imported types from other
5346 (LoadAllImportedTypes): New method fills static table with exported types
5347 from all referenced assemblies.
5348 (Modules): New property returns all assembly modules.
5350 2004-03-30 Miguel de Icaza <miguel@ximian.com>
5352 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
5353 throwing a parser error.
5355 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
5356 which removes the hardcoded get_/set_ prefixes for properties, as
5357 IL allows for the properties to be named something else.
5361 * expression.cs: Do not override operand before we know if it is
5364 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
5366 * typemanager.cs: support for pinned variables.
5368 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
5370 * decl.cs, typemanager.cs: Avoid using an arraylist
5371 as a buffer if there is only one result set.
5373 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
5375 * expression.cs: Make sure you cant call a static method
5376 with an instance expression, bug #56174.
5378 2004-03-29 Miguel de Icaza <miguel@ximian.com>
5380 * class.cs (IsDuplicateImplementation): Improve error reporting to
5381 flag 663 (method only differs in parameter modifier).
5383 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
5384 in preprocessor directives.
5386 * location.cs (LookupFile): Allow for the empty path.
5388 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
5389 better approach for some of that patch, but its failing with the
5390 CharSet enumeration. For now try/catch will do.
5392 * typemanager.cs: Do not crash if a struct does not have fields.
5395 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
5397 * expression.cs: cs0213, cant fix a fixed expression.
5400 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
5402 * cs-parser.jay: detect invalid embeded statements gracefully.
5405 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
5407 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
5410 the invocation type may not be a subclass of the tye of the item/
5411 The type of the item must be a subclass of the invocation item.
5416 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
5418 * attribute.cs: Added methods to get a string and a bool from an
5419 attribute. Required to information from AssemblyKeyFileAttribute,
5420 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
5421 * codegen.cs: Modified AssemblyName creation to include support for
5422 strongnames. Catch additional exceptions to report them as CS1548.
5423 * compiler.csproj: Updated include CryptoConvert.cs.
5424 * compiler.csproj.user: Removed file - user specific configuration.
5425 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
5426 Mono.Security assembly. The original class is maintained and tested in
5427 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
5428 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
5429 like CSC 8.0 (C# v2) supports.
5430 * Makefile: Added CryptoConvert.cs to mcs sources.
5431 * rootcontext.cs: Added new options for strongnames.
5433 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
5435 * driver.cs: For --expect-error, report error code `2'
5436 if the program compiled with no errors, error code `1' if
5437 it compiled with an error other than the one expected.
5439 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
5441 * compiler.csproj: Updated for Visual Studio .NET 2003.
5442 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
5443 * compiler.sln: Updated for Visual Studio .NET 2003.
5445 2004-03-24 Ravi Pratap M <ravi@ximian.com>
5447 * expression.cs: Fix bug #47234. We basically need to apply the
5448 rule that we prefer the conversion of null to a reference type
5449 when faced with a conversion to 'object' (csc behaviour).
5451 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5453 * statement.cs: Shorter form for foreach, eliminates
5454 a local variable. r=Martin.
5456 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5458 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
5459 checks if we can use brtrue/brfalse to test for 0.
5460 * expression.cs: use the above in the test for using brtrue/brfalse.
5463 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5465 * expression.cs: Rewrite string concat stuff. Benefits:
5467 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
5468 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
5469 rather than a concat chain.
5471 * typemanager.cs: Add lookups for more concat overloads.
5473 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5475 * expression.cs: Emit shorter il code for array init.
5492 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
5494 * statement.cs: Before, two switch blocks would be merged if the
5495 total size of the blocks (end_item - begin_item + 1) was less than
5496 two times the combined sizes of the blocks.
5498 Now, it will only merge if after the merge at least half of the
5503 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
5505 * class.cs : csc build fix for GetMethods(). See bug #52503.
5507 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
5509 * expression.cs: Make sure fp comparisons work with NaN.
5510 This fixes bug #54303. Mig approved this patch a long
5511 time ago, but we were not able to test b/c the runtime
5514 2004-03-19 Miguel de Icaza <miguel@ximian.com>
5516 * ecore.cs (TypExpr.GetHashCode): implement this overload.
5518 2004-03-19 Martin Baulig <martin@ximian.com>
5520 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
5521 two overloads may unify for some type parameter substitutions and
5522 report a CS0408 if appropriate.
5524 2004-03-19 Martin Baulig <martin@ximian.com>
5526 * class.cs (MemberCore.IsDuplicateImplementation): Report the
5527 error here and not in our caller.
5529 2004-03-19 Martin Baulig <martin@ximian.com>
5531 * interface.cs: Completely killed this file.
5532 (Interface): We're now a TypeContainer and live in class.cs.
5534 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
5535 argument; we're now also called for interfaces.
5536 (TypeContainer.DefineMembers): Allow this method being called
5538 (TypeContainer.GetMethods): New public method; formerly known as
5539 Interface.GetMethod(). This is used by PendingImplementation.
5540 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
5541 it's now private and non-static.
5542 (Interface): Moved this here; it's now implemented similar to
5544 (Method, Property, Event, Indexer): Added `bool is_interface'
5545 argument to their .ctor's.
5546 (MemberBase.IsInterface): New public field.
5548 * cs-parser.jay: Create normal Method, Property, Event, Indexer
5549 instances instead of InterfaceMethod, InterfaceProperty, etc.
5550 (opt_interface_base): Removed; we now use `opt_class_base' instead.
5551 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
5553 2004-03-19 Martin Baulig <martin@ximian.com>
5555 * class.cs (MethodCore.IsDuplicateImplementation): New private
5556 method which does the CS0111 checking.
5557 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
5558 Use IsDuplicateImplementation().
5560 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
5562 * decl.cs (FindMemberToOverride): New method to find the correct
5563 method or property to override in the base class.
5565 - Make Method/Property use the above method to find the
5566 version in the base class.
5567 - Remove the InheritableMemberSignatureCompare as it is now
5570 This patch makes large code bases much faster to compile, as it is
5571 O(n) rather than O(n^2) to do this validation.
5573 Also, it fixes bug 52458 which is that nested classes are not
5574 taken into account when finding the base class member.
5576 Reviewed/Approved by Martin.
5578 2004-03-17 Martin Baulig <martin@ximian.com>
5580 * expression.cs (MemberAccess.DoResolve): Take the parent's number
5581 of type arguments into account; use the `real_num_type_args'
5582 approach like in DoResolveAsTypeStep().
5584 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
5587 2004-03-17 Marek Safar <marek.safar@seznam.cz>
5589 * interface.cs: In all interface classes removed redundant
5590 member initialization.
5592 2004-03-16 Martin Baulig <martin@ximian.com>
5594 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
5596 2004-03-15 Miguel de Icaza <miguel@ximian.com>
5598 * decl.cs (DefineTypeAndParents): New helper method to define a
5599 type's containers before the type itself is defined; This is a
5600 bug exposed by the recent changes to Windows.Forms when an
5601 implemented interface was defined inside a class that had not been
5604 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
5606 (Check): Loop correctly to report errors modifiers
5607 (UNSAFE was not in the loop, since it was the same as TOP).
5609 * interface.cs: Every interface member now takes a ModFlags,
5610 instead of a "is_new" bool, which we set on the base MemberCore.
5612 Every place where we called "UnsafeOk" in the interface, now we
5613 call the proper member (InterfaceMethod.UnsafeOK) instead to get
5614 the unsafe settings from the member declaration instead of the
5615 container interface.
5617 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
5619 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
5620 `set_indexer_name' to the pending bits (one per type).
5622 We fixed a bug today that was picking the wrong method to
5623 override, since for properties the existing InterfaceMethod code
5624 basically ignored the method name. Now we make sure that the
5625 method name is one of the valid indexer names.
5627 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
5629 * support.cs (SeekableStreamReader): Keep track of stream byte
5630 positions and don't mix them with character offsets to the buffer.
5632 Patch from Gustavo Giráldez
5634 2004-03-15 Marek Safar <marek.safar@seznam.cz>
5636 * interface.cs (InterfaceSetGetBase): Removed double member
5637 initialization, base class does it as well.
5639 2004-03-13 Martin Baulig <martin@ximian.com>
5641 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
5642 when compiling corlib.
5644 2004-03-13 Miguel de Icaza <miguel@ximian.com>
5646 * convert.cs (ExplicitConversion): We were reporting an error on
5647 certain conversions (object_type source to a value type, when the
5648 expression was `null') before we had a chance to pass it through
5649 the user defined conversions.
5651 * driver.cs: Replace / and \ in resource specifications to dots.
5654 * class.cs: Add check for duplicate operators. Fixes 52477
5656 2004-03-11 Miguel de Icaza <miguel@ximian.com>
5658 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
5659 that are in the middle of the statements, not only at the end.
5662 * class.cs (TypeContainer.AddField): No longer set the
5663 `HaveStaticConstructor' flag, now we call it
5664 `UserDefineStaticConstructor' to diferentiate the slightly
5665 semantic difference.
5667 The situation is that we were not adding BeforeFieldInit (from
5668 Modifiers.TypeAttr) to classes that could have it.
5669 BeforeFieldInit should be set to classes that have no static
5674 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
5676 And most importantly Zoltan's comment:
5678 http://bugzilla.ximian.com/show_bug.cgi?id=44229
5680 "I think beforefieldinit means 'it's ok to initialize the type sometime
5681 before its static fields are used', i.e. initialization does not need
5682 to be triggered by the first access to the type. Setting this flag
5683 helps the JIT to compile better code, since it can run the static
5684 constructor at JIT time, and does not need to generate code to call it
5685 (possibly lots of times) at runtime. Unfortunately, mcs does not set
5686 this flag for lots of classes like String.
5688 csc sets this flag if the type does not have an explicit static
5689 constructor. The reasoning seems to be that if there are only static
5690 initalizers for a type, and no static constructor, then the programmer
5691 does not care when this initialization happens, so beforefieldinit
5694 This bug prevents the AOT compiler from being usable, since it
5695 generates so many calls to mono_runtime_class_init that the AOT code
5696 is much slower than the JITted code. The JITted code is faster,
5697 because it does not generate these calls if the vtable is type is
5698 already initialized, which is true in the majority of cases. But the
5699 AOT compiler can't do this."
5701 2004-03-10 Miguel de Icaza <miguel@ximian.com>
5703 * class.cs (MethodData.Emit): Refactor the code so symbolic
5704 information is generated for destructors; For some reasons we
5705 were taking a code path that did not generate symbolic information
5708 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
5710 * class.cs: Create a Constructor.CheckBase method that
5711 takes care of all validation type code. The method
5712 contains some code that was moved from Define.
5714 It also includes new code that checks for duplicate ctors.
5715 This fixes bug #55148.
5717 2004-03-09 Joshua Tauberer <tauberer@for.net>
5719 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
5720 a { ... }-style array creation invokes EmitStaticInitializers
5721 which is not good for reference-type arrays. String, decimal
5722 and now null constants (NullCast) are not counted toward
5723 static initializers.
5725 2004-03-05 Martin Baulig <martin@ximian.com>
5727 * location.cs (SourceFile.HasLineDirective): New public field;
5728 specifies whether the file contains or is referenced by a "#line"
5730 (Location.DefineSymbolDocuments): Ignore source files which
5731 either contain or are referenced by a "#line" directive.
5733 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
5735 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
5736 direct access to our parent, so check the method inline there.
5738 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
5740 * expression.cs (Invocation.EmitCall): Miguel's last commit
5741 caused a regression. If you had:
5746 In Foo the implict this would be null.
5748 2004-02-27 Miguel de Icaza <miguel@ximian.com>
5750 * expression.cs (Invocation.EmitCall): If the method is not
5751 virtual, do not emit a CallVirt to it, use Call.
5753 * typemanager.cs (GetFullNameSignature): Improve the method to
5754 cope with ".ctor" and replace it with the type name.
5756 * class.cs (ConstructorInitializer.Resolve): Now the method takes
5757 as an argument the ConstructorBuilder where it is being defined,
5758 to catch the recursive constructor invocations.
5760 2004-03-16 Martin Baulig <martin@ximian.com>
5762 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
5763 ConstructedType, call ResolveType() on it to get the type rather
5764 than just using `expr.Type'.
5766 2004-03-16 Martin Baulig <martin@ximian.com>
5768 * generics.cs (ConstructedType.GetMemberAccess): Take the
5769 EmitContext instead on the TypeExpr and use
5770 ec.TypeContainer.CurrentType/ec.ContainerType.
5772 2004-03-16 Martin Baulig <martin@ximian.com>
5774 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
5775 parameters before aliases.
5777 2004-03-16 Martin Baulig <martin@ximian.com>
5779 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
5780 New oublic function; checks whether two generic instances may become
5781 equal under some instantiations (26.3.1).
5783 * class.cs (TypeContainer.Define): Call
5784 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
5787 2004-03-16 Martin Baulig <martin@ximian.com>
5789 * class.cs (TypeContainer.GetClassBases): Moved
5790 Error_TypeParameterAsBase() here and also check whether the base
5791 class is not an attribute.
5793 2004-03-16 Martin Baulig <martin@ximian.com>
5795 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
5797 2004-03-16 Martin Baulig <martin@ximian.com>
5799 * class.cs (Error_TypeParameterAsBase): Use correct error number
5802 2004-03-16 Martin Baulig <martin@ximian.com>
5804 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
5807 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
5810 2004-03-15 Martin Baulig <martin@ximian.com>
5812 * typemanager.cs (TypeManager.GetFullName): New public method.
5813 (TypeManager.MemberLookup): Added `int_num_type_arguments'
5814 argument; only return members with the correct number of type
5816 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
5817 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
5818 whether the number of type arguments matches.
5820 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
5821 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
5823 * expression.cs (MemberAccess): Added public `NumTypeArguments'
5824 field; it's set by the protected .ctor when we're actually a
5825 GenericMemberAccess.
5826 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
5827 arguments and pass it to MemberLookupFinal ().
5829 * ecore.cs (Expression.MemberLookup): Added `int
5830 num_type_arguments' argument; only return members with the correct
5831 number of type arguments.
5832 (Expression.MemberLookupFailed): Check whether the MemberLookup
5833 failed because we did not have the correct number of type
5834 arguments; report CS0305 in this case.
5836 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
5837 `e.ResolveAsTypeTerminal()' already did so.
5839 2004-03-15 Martin Baulig <martin@ximian.com>
5841 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
5842 we're a ConstructedType; in this case, the caller must report an
5843 error (for instance CS0131).
5845 * generic.cs (TypeArguments): Added Location argument to the .ctor.
5846 (TypeArguments.Resolve): Actually report errors here.
5848 2004-03-15 Miguel de Icaza <miguel@ximian.com>
5850 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
5851 `set_indexer_name' to the pending bits (one per type).
5853 We fixed a bug today that was picking the wrong method to
5854 override, since for properties the existing InterfaceMethod code
5855 basically ignored the method name. Now we make sure that the
5856 method name is one of the valid indexer names.
5858 2004-03-15 Martin Baulig <martin@ximian.com>
5860 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
5861 for generic instances.
5863 2004-03-13 Martin Baulig <martin@ximian.com>
5865 * class.cs (TypeContainer.DefineType): Call
5866 TypeManager.AddUserType() immediately after creating the
5867 TypeBuilder; pass all type parameters when creating the
5870 * decl.cs (DeclSpace.FindNestedType): New public method.
5871 (DeclSpace.FindType): Added `int num_type_args' argument; only
5872 return types with the correct number of type parameters.
5873 (DeclSpace.CountTypeParams): New public property.
5875 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
5876 the number of type parameters; defaults to zero.
5878 * generic.cs (TypeArguments.Count): New public property.
5879 (ConstructedType.DoResolveAsTypeStep): First call
5880 ds.FindNestedType() to find out whether we're nested in the
5881 current generic type; in this case, we inherit all type parameters
5882 from the current class.
5884 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
5885 num_type_args' argument.
5886 (RootContext.LookupType): Added overloaded version which takes the
5887 number of type arguments; only return types with the correct
5888 number of type arguments.
5890 * typemanager.cs (TypeManager.CheckGeneric): New public function;
5891 checks whether `Type t' has `int num_type_args'.
5893 2004-03-13 Martin Baulig <martin@ximian.com>
5895 * generic.cs (GenericMethod.DefineType): New method; calls
5896 DefineType() on all the type parameters.
5898 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
5899 (MethodData.Define): If we're a generic method, call
5900 GenericMethod.DefineType() to define the type parameters.
5902 2004-03-10 Martin Baulig <martin@ximian.com>
5904 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
5905 instead of IsAssignableFrom.
5907 2004-03-10 Martin Baulig <martin@ximian.com>
5909 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
5911 * support.cs (ParameterData.HasArrayParameter): New property.
5912 (ReflectionParameters.ctor): Take a MethodBase instead of a
5913 ParameterInfo[]. If we have any type parameters, get the generic
5914 method definition and ask it whether we have variable arguments.
5916 2004-02-26 Miguel de Icaza <miguel@ximian.com>
5918 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
5919 routines to check if a type is an enumerable/enumerator allow
5920 classes that implement the IEnumerable or IEnumerator interfaces.
5922 * class.cs (Property, Operator): Implement IIteratorContainer, and
5923 implement SetYields.
5925 (Property.Define): Do the block swapping for get_methods in the
5926 context of iterators. We need to check if Properties also
5927 include indexers or not.
5929 (Operator): Assign the Block before invoking the
5930 OperatorMethod.Define, so we can trigger the Iterator code
5933 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
5934 Property and Operator classes are not created when we parse the
5935 declarator but until we have the block completed, so we use a
5936 singleton SimpleIteratorContainer.Simple to flag whether the
5937 SetYields has been invoked.
5939 We propagate this setting then to the Property or the Operator to
5940 allow the `yield' to function.
5942 2004-02-25 Marek Safar <marek.safar@seznam.cz>
5944 * codegen.cs: Implemented attribute support for modules.
5945 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
5946 Assembly/Module functionality.
5948 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
5949 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
5950 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
5952 2004-02-16 Marek Safar <marek.safar@seznam.cz>
5954 * interface.cs (FindMembers): The operation is performed on all base
5955 interfaces and not only on the first. It is required for future CLS Compliance patch.
5957 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
5959 * statement.cs, codegen.cs:
5960 This patch deals with patterns such as:
5962 public class List : IEnumerable {
5964 public MyEnumerator GetEnumerator () {
5965 return new MyEnumerator(this);
5968 IEnumerator IEnumerable.GetEnumerator () {
5972 public struct MyEnumerator : IEnumerator {
5977 Before, there were a few things we did wrong:
5978 1) we would emit callvirt on a struct, which is illegal
5979 2) we emited ldarg when we needed to emit ldarga
5980 3) we would mistakenly call the interface methods on an enumerator
5981 type that derived from IEnumerator and was in another assembly. For example:
5983 public class MyEnumerator : IEnumerator
5985 Would have the interface methods called, even if there were public impls of the
5986 method. In a struct, this lead to invalid IL code.
5988 2004-02-11 Marek Safar <marek.safar@seznam.cz>
5990 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
5993 * delegate.cs (Define): Fixed crash when delegate type is undefined.
5995 2004-02-11 Miguel de Icaza <miguel@ximian.com>
5997 * cs-parser.jay: Fix small regression: we were not testing V2
5998 compiler features correctly.
6000 * interface.cs: If the emit context is null, then create one
6002 2004-02-09 Marek Safar <marek.safar@seznam.cz>
6004 * decl.cs (GetSignatureForError): New virtual method to get full name
6007 * attribute.cs (IAttributeSupport): New interface for attribute setting.
6008 Now it is possible to rewrite ApplyAttributes method to be less if/else.
6010 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
6011 Duplicated members and code in these classes has been removed.
6012 Better encapsulation in these classes.
6014 2004-02-07 Miguel de Icaza <miguel@ximian.com>
6016 * assign.cs (Assign.DoResolve): When dealing with compound
6017 assignments, there is a new rule in ECMA C# 2.4 (might have been
6018 there before, but it is documented here) that states that in:
6022 If b is of type int, and the `op' is a shift-operator, then the
6023 above is evaluated as:
6027 * expression.cs (Binary.ResolveOperator): Instead of testing for
6028 int/uint/long/ulong, try to implicitly convert to any of those
6029 types and use that in pointer arithmetic.
6031 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
6032 method to print information for from the type, not from the
6033 null-method we were given.
6035 2004-02-01 Duncan Mak <duncan@ximian.com>
6037 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
6038 parsing for cmd, fixes bug #53694.
6040 2004-02-04 Marek Safar <marek.safar@seznam.cz>
6042 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
6043 in the member name duplication tests. Property and operator name duplication
6044 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
6046 2004-02-03 Marek Safar <marek.safar@seznam.cz>
6048 * interface.cs (PopulateMethod): Fixed crash when interface method
6049 returns not existing type (error test cs0246-3.cs).
6051 2004-02-02 Ravi Pratap M <ravi@ximian.com>
6053 * cs-parser.jay (interface_accessors): Re-write actions to also
6054 store attributes attached to get and set methods. Fix spelling
6057 (inteface_property_declaration): Modify accordingly.
6059 (InterfaceAccessorInfo): New helper class to store information to pass
6060 around between rules that use interface_accessors.
6062 * interface.cs (Emit): Apply attributes on the get and set
6063 accessors of properties and indexers too.
6065 * attribute.cs (ApplyAttributes): Modify accordingly to use the
6066 right MethodBuilder when applying attributes to the get and set accessors.
6068 2004-01-31 Miguel de Icaza <miguel@ximian.com>
6070 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
6072 2004-01-26 Miguel de Icaza <miguel@ximian.com>
6074 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
6076 2004-01-25 Miguel de Icaza <miguel@ximian.com>
6078 * cs-parser.jay: Remove YIELD token, instead use the new grammar
6079 changes that treat `yield' specially when present before `break'
6082 * cs-tokenizer.cs: yield is no longer a keyword.
6084 2004-01-23 Marek Safar <marek.safar@seznam.cz>
6086 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
6087 setting for default constructors.
6088 For default constructors are almost every time set wrong Modifier. The
6089 generated IL code has been alright. But inside mcs this values was
6090 wrong and this was reason why several of my CLS Compliance tests
6093 2004-02-27 Martin Baulig <martin@ximian.com>
6095 * generics.cs (ConstructedType.ResolveType): Make the nested type
6096 stuff actually work.
6098 2004-02-25 Martin Baulig <martin@ximian.com>
6100 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
6101 property; returns the type parameters just from the current type,
6102 ie. with the ones from outer classes.
6103 (DeclSpace.LookupGeneric): First search in the current class, then
6105 (DeclSpace.initialize_type_params): When hiding a type parameter
6106 from an outer class, put it into the `type_param_list' anyways.
6108 * expression.cs (MemberAccess.expr): Made this field protected.
6110 * class.cs (TypeContainer.Define): The `CurrentType' just contains
6111 the type parameters from the current class.
6113 * generic.cs (ConstructedType.ResolveType): Support nested generic
6114 types by taking the type parameters which we inherit from outer
6115 classes into account.
6116 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
6117 support for nested generic types.
6119 2004-02-23 Martin Baulig <martin@ximian.com>
6121 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
6122 field and check whether we're nested inside a generic type.
6123 (DeclSpace.ResolveType): If we're resolving to a generic type
6124 definition, create a ConstructedType and return its resolved type.
6125 (DeclSpace.initialize_type_params): New private method;
6126 initializes the `type_param_list' field from the type parameters
6127 from this and all enclosing classes.
6128 (DeclSpace.TypeParameters): Call initialize_type_params() unless
6129 we're already initialized.
6131 2004-02-23 Martin Baulig <martin@ximian.com>
6133 * class.cs (Method.Define): Create the generic method before
6135 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
6136 the TypeContainer one); we use this for generic methods.
6138 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
6139 parent's TypeBuilder.
6141 2004-02-18 Martin Baulig <martin@ximian.com>
6143 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
6144 to check for equality.
6146 2004-02-05 Martin Baulig <martin@ximian.com>
6148 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
6149 `ec.TypeContainer.CurrentType', use it instead of
6150 `ec.ContainerType' to check whether we're in the type's ctor.
6152 2004-01-29 Martin Baulig <martin@ximian.com>
6154 * expression.cs (Invocation.DoResolve): If we're a
6155 `ConstructedType', then we're actually a generic method, so
6156 rewrite the expr as a GenericMemberAccess.
6158 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
6159 here; manually parse it into a string.
6161 2004-01-28 Martin Baulig <martin@ximian.com>
6163 * typemanager.cs (TypeManager.IsEqual): New static method.
6164 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
6165 check for equality instead of using `=='.
6167 2004-01-26 Martin Baulig <martin@ximian.com>
6169 * decl.cs (DeclSpace.CurrentType): New public field.
6171 * expression.cs (This.ResolveBase): If we have an
6172 `ec.TypeContainer.CurrentType', use it instead of
6175 * class.cs (TypeContainer.DefineType): If we're a generic type,
6176 create the `CurrentType' (unresolved).
6177 (TypeContainer.GenericType): New private field.
6178 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
6179 it and store it in `GenericType' before creating the MemberCache.
6180 (TypeContainer.GetMembers): If we have a `GenericType', call
6181 TypeManager.FindMembers() on it.
6183 * interface.cs (Interface.GenericType): New private field.
6184 (Interface.DefineType): If we're a generic type, create the
6185 `CurrentType' (unresolved).
6186 (Interface.DefineMembers): If we have a `CurrentType', resolve it
6187 and store it in `GenericType' before creating the MemberCache.
6188 (Interface.GetMembers): If we have a `GenericType', call
6189 TypeManager.FindMembers() on it.
6191 2004-01-22 Martin Baulig <martin@ximian.com>
6193 * cs-parser.jay (namespace_or_type_name): Return an Expression,
6194 not a QualifiedIdentifier. This is what `type_name_expression'
6195 was previously doing.
6196 (type_name_expression): Removed; the code is now in
6197 `namespace_or_type_name'.
6198 (qualified_identifier): Removed, use `namespace_or_type_name'
6200 (QualifiedIdentifier): Removed this class.
6202 2004-01-22 Martin Baulig <martin@ximian.com>
6204 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
6205 not a string as alias name.
6207 2004-01-21 Miguel de Icaza <miguel@ximian.com>
6209 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
6210 #52730 bug, and instead compute correctly the need to use a
6211 temporary variable when requesting an address based on the
6212 static/instace modified of the field and the constructor.
6214 2004-01-21 Martin Baulig <martin@ximian.com>
6216 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
6217 class and namespace before looking up aliases. Fixes #52517.
6219 2004-01-21 Martin Baulig <martin@ximian.com>
6221 * flowanalysis.cs (UsageVector.Merge): Allow variables being
6222 assinged in a 'try'; fixes exception4.cs.
6224 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6225 * class.cs : Implemented parameter-less constructor for TypeContainer
6227 * decl.cs: Attributes are now stored here. New property OptAttributes
6229 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
6231 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
6233 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6235 * typemanager.cs (CSharpSignature): Now reports also inner class name.
6236 (CSharpSignature): New method for indexer and property signature.
6238 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6240 * pending.cs (IsVirtualFilter): Faster implementation.
6242 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6244 * typemanager.cs: Avoid inclusion of same assembly more than once.
6246 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6248 * cs-parser.jay: Fixed problem where the last assembly attribute
6249 has been applied also to following declaration (class, struct, etc.)
6251 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6253 * class.cs: Added error CS0538, CS0539 reporting.
6254 Fixed crash on Microsoft runtime when field type is void.
6256 * cs-parser.jay: Added error CS0537 reporting.
6258 * pending.cs: Added error CS0535 reporting.
6259 Improved error report for errors CS0536, CS0534.
6261 2004-01-20 Miguel de Icaza <miguel@ximian.com>
6263 Merge a few bits from the Anonymous Method MCS tree.
6265 * statement.cs (ToplevelBlock): New class for toplevel methods,
6266 will hold anonymous methods, lifted variables.
6268 * cs-parser.jay: Create toplevel blocks for delegates and for
6269 regular blocks of code.
6271 2004-01-20 Martin Baulig <martin@ximian.com>
6273 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
6274 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
6275 and `NeedExplicitReturn'; added `IsLastStatement'.
6276 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
6277 have a `ReturnLabel' or we're not unreachable.
6279 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
6280 child's reachability; don't just override ours with it. Fixes
6281 #58058 (lluis's example).
6282 (FlowBranching): Added public InTryOrCatch(), InCatch(),
6283 InFinally(), InLoop(), InSwitch() and
6284 BreakCrossesTryCatchBoundary() methods.
6286 * statement.cs (Return): Do all error checking in Resolve().
6287 Unless we are the last statement in a top-level block, always
6288 create a return label and jump to it.
6289 (Break, Continue): Do all error checking in Resolve(); also make
6290 sure we aren't leaving a `finally'.
6291 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
6292 statement in a top-level block.
6293 (Block.Flags): Added `IsDestructor'.
6294 (Block.IsDestructor): New public property.
6296 2004-01-20 Martin Baulig <martin@ximian.com>
6298 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
6300 2004-01-20 Martin Baulig <martin@ximian.com>
6302 * statement.cs (Statement.ResolveUnreachable): New public method.
6303 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
6304 (Block.Resolve): Resolve unreachable statements.
6306 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
6308 * expression.cs: We need to fix the case where we do
6309 not have a temp variable here.
6311 * assign.cs: Only expression compound assignments need
6312 temporary variables.
6314 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
6316 * flowanalysis.cs: Reduce memory allocation in a few ways:
6317 - A block with no variables should not allocate a bit
6319 - A method with no out parameters does not need any tracking
6320 for assignment of the parameters, so we need not allocate
6323 public readonly Type[] VariableTypes;
6324 public readonly string[] VariableNames;
6325 Are redundant. The data is already stored in the variable
6326 map, so we need not allocate another array for it.
6327 - We need to add alot of checks for if (params | locals) == null
6328 due to the first two changes.
6330 2004-01-18 Miguel de Icaza <miguel@ximian.com>
6332 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
6333 implement IMemoryLocation, we store a copy on a local variable and
6334 take the address of it. Patch from Benjamin Jemlich
6336 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
6337 to use a special "type_name_expression" rule which reduces the
6338 number of "QualifiedIdentifier" classes created, and instead
6339 directly creates MemberAccess expressions.
6341 2004-01-17 Miguel de Icaza <miguel@ximian.com>
6343 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
6344 that fixes #52853. Null literal assignment to ValueType
6346 * class.cs (MethodData.Emit): Instead of checking the name of the
6347 method to determine if its a destructor, create a new derived
6348 class from Method called Destructor, and test for that.
6350 * cs-parser.jay: Create a Destructor object instead of a Method.
6352 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
6356 2004-01-16 Miguel de Icaza <miguel@ximian.com>
6358 * expression.cs (Binary.ResolveOperator): Perform an implicit
6359 conversion from MethodGroups to their delegate types on the
6362 * delegate.cs: Introduce a new class DelegateCreation that is the
6363 base class for `NewDelegate' and `ImplicitDelegateCreation',
6364 factor some code in here.
6366 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
6367 conversion from MethodGroups to compatible delegate types.
6369 * ecore.cs (Expression.Resolve): Do not flag error 654
6370 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
6371 we allow conversions from MethodGroups to delegate types now.
6373 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
6374 assignments in v2 either.
6376 2004-01-10 Miguel de Icaza <miguel@ximian.com>
6378 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
6379 static read-only fields in ctors.
6381 Applied patch from Benjamin Jemlich
6383 * expression.cs (UnaryMutator): Avoid leaking local variables.
6385 2004-01-09 Miguel de Icaza <miguel@ximian.com>
6387 * cs-tokenizer.cs (IsCastToken): Allow the various native types
6388 here to return true, as they can be used like this:
6392 Fixed 49836 and all the other dups
6394 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
6396 * driver.cs: Implement /win32res and /win32icon.
6398 2004-01-08 Miguel de Icaza <miguel@ximian.com>
6400 * cs-parser.jay: Add a rule to improve error handling for the
6401 common mistake of placing modifiers after the type.
6403 2004-01-07 Miguel de Icaza <miguel@ximian.com>
6405 * cs-parser.jay (interface_event_declaration): Catch
6406 initialization of events on interfaces, and report cs0068
6408 * cs-parser.jay (interface_event_declaration): Catch
6409 initialization of events.
6411 * ecore.cs: Better report missing constructors.
6413 * expression.cs (Binary.ResolveOperator): My previous bug fix had
6414 the error reporting done in the wrong place. Fix.
6416 * expression.cs (Binary.ResolveOperator): Catch the
6417 operator + (E x, E y) error earlier, and later allow for implicit
6418 conversions in operator +/- (E e, U x) from U to the underlying
6421 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
6422 52596, if the container class is abstract, the default constructor
6423 is protected otherwise its public (before, we were always public).
6425 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
6428 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
6429 Jemlich that fixes bug #52597, MCS was generating invalid code for
6430 idisposable structs. Thanks to Ben for following up with this
6433 2004-01-06 Miguel de Icaza <miguel@ximian.com>
6435 * driver.cs: Allow assemblies without code to be generated, fixes
6438 2004-01-07 Nick Drochak <ndrochak@gol.com>
6440 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
6442 2004-01-05 Miguel de Icaza <miguel@ximian.com>
6444 * cs-parser.jay: Add rules to improve error reporting if fields or
6445 methods are declared at the namespace level (error 116)
6447 * Add rules to catch event add/remove
6449 2004-01-04 David Sheldon <dave-mono@earth.li>
6451 * expression.cs: Added matching ")" to error message for
6454 2004-01-03 Todd Berman <tberman@gentoo.org>
6456 * ecore.cs, attribute.cs:
6457 Applying fix from #52429.
6459 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6461 * ecore.cs, expression.cs, statement.cs:
6462 Total rewrite of how we handle branching. We
6463 now handle complex boolean expressions with fewer
6464 jumps. As well if (x == 0) no longer emits a ceq.
6466 if (x is Foo) is much faster now, because we generate
6469 Overall, we get a pretty big improvement on our benchmark
6470 tests. The code we generate is smaller and more readable.
6472 I did a full two-stage bootstrap. The patch was reviewed
6473 by Martin and Miguel.
6475 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6477 * cs-parser.jay: Make primary_expression not take a QI.
6478 we dont need this because the member_access rule covers
6479 us here. So we replace the rule with just IDENTIFIER.
6481 This has two good effects. First, we remove a s/r conflict.
6482 Second, we allocate many fewer QualifiedIdentifier objects.
6484 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6486 * attribute.cs: Handle MarshalAs attributes as pseudo, and
6487 set the correct information via SRE. This prevents
6488 hanging on the MS runtime. Fixes #29374.
6490 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6492 * convert.cs: correctly handle conversions to value types
6493 from Enum and ValueType as unboxing conversions.
6495 Fixes bug #52569. Patch by Benjamin Jemlich.
6497 2004-01-02 Ravi Pratap <ravi@ximian.com>
6499 * expression.cs (BetterConversion): Prefer int -> uint
6500 over int -> ulong (csc's behaviour). This fixed bug #52046.
6502 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
6504 * decl.cs (MemberCache.FindMembers): now returns a
6507 * typemanager.cs: In general, go with with ^^.
6508 (CopyNewMethods): take an IList.
6509 (RealMemberLookup): Only allocate an arraylist
6510 if we copy from two sets of methods.
6512 This change basically does two things:
6513 1) Fewer array lists allocated due to CopyNewMethods.
6514 2) the explicit cast in MemberList costed ALOT.
6516 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
6518 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
6519 a hashtable to avoid needless string allocations when an identifier is
6520 used more than once (the common case).
6522 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
6524 * pending.cs: MS's TypeBuilder.GetInterfaces ()
6525 is broken, it will not return anything. So, we
6526 have to use the information we have in mcs to
6529 * typemanager.cs: Add a cache for GetInterfaces,
6530 since this will now be used more often (due to ^^)
6532 (GetExplicitInterfaces) New method that gets the
6533 declared, not effective, interfaces on a type
6534 builder (eg, if you have interface IFoo, interface
6535 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
6538 This patch makes MCS able to bootstrap itself on
6541 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
6543 * expression.cs: Remove the Nop's that Miguel put
6546 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
6548 * report.cs, codegen.cs: Give the real stack trace to
6549 the error when an exception is thrown.
6551 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
6553 * decl.cs: only allocate hashtables for ifaces if
6556 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
6558 * expression.cs: fix the error from cs0121-2.cs
6559 (a parent interface has two child interfaces that
6560 have a function with the same name and 0 params
6561 and the function is called through the parent).
6563 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
6565 * class.cs, rootcontext.cs, typmanager.cs: do not
6568 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
6570 * codegen.cs: remove stack for the ec flow branching.
6571 It is already a linked list, so no need.
6573 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
6575 * Makefile: Allow custom profiler here.
6577 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
6579 * typemanager.cs (LookupType):
6580 - Use a static char [], because split takes
6581 a param array for args, so it was allocating
6583 - Do not store true in a hashtable, it boxes.
6585 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
6587 * flowanalysis.cs: bytify common enums.
6589 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
6591 * modifiers.cs: Add a new set of flags for the
6592 flags allowed on explicit interface impls.
6593 * cs-parser.jay: catch the use of modifiers in
6594 interfaces correctly.
6595 * class.cs: catch private void IFoo.Blah ().
6597 All related to bug #50572.
6599 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
6601 * decl.cs: Rewrite the consistant accessability checking.
6602 Accessability is not linear, it must be implemented in
6603 a tableish way. Fixes #49704.
6605 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
6607 * expression.cs: Handle negation in a checked context.
6608 We must use subtraction from zero. Fixes #38674.
6610 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
6612 * class.cs: Ignore static void main in DLLs.
6613 * rootcontext.cs: Handle the target type here,
6614 since we are have to access it from class.cs
6615 * driver.cs: account for the above.
6617 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
6619 * report.cs: Give line numbers and files if available.
6621 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
6623 * driver.cs: Implement /addmodule.
6625 * typemanager.cs: Change 'modules' field so it now contains Modules not
6628 2003-12-20 Martin Baulig <martin@ximian.com>
6630 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
6631 (FieldBase.IsAssigned): Removed this field.
6632 (FieldBase.SetAssigned): New public method.
6633 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
6635 2003-12-20 Martin Baulig <martin@ximian.com>
6637 * expression.cs (LocalVariableReference.DoResolve): Don't set
6638 `vi.Used' if we're called from DoResolveLValue().
6640 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
6641 returns the usage vector it just merged into the current one -
6642 pass this one to UsageWarning().
6643 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
6644 of the `EmitContext', don't call this recursively on our children.
6646 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
6648 * driver.cs: Implement /target:module.
6650 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
6652 * support.cs (CharArrayHashtable): New helper class.
6654 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
6655 char arrays, not strings, so we can avoid creating a string in
6656 consume_identifier if the identifier is a keyword.
6658 2003-12-16 Martin Baulig <martin@ximian.com>
6660 * statement.cs (LocalInfo.Assigned): Removed this property.
6661 (LocalInfo.Flags): Removed `Assigned'.
6662 (LocalInfo.IsAssigned): New public method; takes the EmitContext
6663 and uses flow analysis.
6664 (Block.UsageWarning): Made this method private.
6665 (Block.Resolve): Call UsageWarning() if appropriate.
6667 * expression.cs (LocalVariableReference.DoResolve): Always set
6668 LocalInfo.Used here.
6670 2003-12-13 Martin Baulig <martin@ximian.com>
6672 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
6673 any value here; we're now using flow analysis to figure out
6674 whether a statement/block returns a value.
6676 2003-12-13 Martin Baulig <martin@ximian.com>
6678 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
6680 (FlowBranching.MergeFinally): Don't call
6681 `branching.CheckOutParameters()' here, this is called in
6683 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
6684 when adding the `finally' vector.
6686 2003-12-13 Martin Baulig <martin@ximian.com>
6689 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
6690 actually work and also fix #48962.
6692 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
6694 * decl.cs: Do not check System.Object for nested types,
6695 since we know it does not have any. Big bang for buck:
6700 corlib: 17.99 seconds
6704 corlib: 17.39 seconds
6706 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
6708 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
6709 time we are returning 0 members, so we save alot here.
6711 2003-12-11 Martin Baulig <martin@ximian.com>
6713 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
6714 `MergeChild()', also just take the `FlowBranching' as argument;
6715 call Merge() on it and return the result.
6716 (FlowBranching.Merge): We don't need to do anything if we just
6719 2003-12-11 Martin Baulig <martin@ximian.com>
6721 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
6722 them in an `ArrayList' to reduce memory usage. Thanks to Ben
6723 Maurer for this idea.
6725 2003-12-11 Martin Baulig <martin@ximian.com>
6727 * flowanalysis.cs (MergeResult): This class is now gone; we now
6728 use the `UsageVector' for this. The reason for this is that if a
6729 branching just has one sibling, we don't need to "merge" them at
6730 all - that's the next step to do.
6731 (FlowBranching.Merge): We now return a `UsageVector' instead of a
6734 2003-12-11 Martin Baulig <martin@ximian.com>
6736 Reworked flow analyis and made it more precise and bug-free. The
6737 most important change is that we're now using a special `Reachability'
6738 class instead of having "magic" meanings of `FlowReturns'. I'll
6739 do some more cleanups and optimizations and also add some more
6740 documentation this week.
6742 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
6743 largely reworked this class.
6744 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
6745 the new `Reachability' class instead of having "magic" values here.
6746 (FlowBranching): We're now using an instance of `Reachability'
6747 instead of having separate `Returns', `Breaks' etc. fields.
6749 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
6750 based on flow analysis; ignore the return value of block.Emit ().
6752 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
6754 * driver.cs typemanager.cs: Find the mono extensions to corlib even
6755 if they are private.
6757 2003-12-09 Martin Baulig <martin@ximian.com>
6759 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
6760 call them directly on the UsageVector.
6762 2003-12-09 Martin Baulig <martin@ximian.com>
6764 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
6765 Changed return type from `FlowReturns' to `Reachability'.
6767 2003-12-09 Martin Baulig <martin@ximian.com>
6769 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
6770 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
6771 `Reachable' fields with a single `Reachability' one.
6773 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6775 * class.cs (FindMembers): Remove foreach's.
6788 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6793 This patch does a few things:
6794 1. EmptyStatement is now a singleton, so it is never reallocated.
6795 2. All blah is EmptyStatement constructs have been changed to
6796 blah == EmptyStatement.Value, which is much faster and valid
6797 now that EmptyStatement is a singleton.
6798 3. When resolving a block, rather than allocating a new array for
6799 the non-empty statements, empty statements are replaced with
6800 EmptyStatement.Value
6801 4. Some recursive functions have been made non-recursive.
6802 Mainly the performance impact is from (3), however (1) and (2) are needed for
6803 this to work. (4) does not make a big difference in normal situations, however
6804 it makes the profile look saner.
6809 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
6810 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
6811 Total memory allocated: 56397 KB
6814 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
6815 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
6816 Total memory allocated: 55666 KB
6818 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6820 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
6821 than the hashtable in a hashtable version
6823 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
6824 we always end up concating a string. This results in a huge perf
6825 loss, because many strings have to be tracked by the GC. In this
6826 patch, we first use a hashtable that works with two keys, so that
6827 the strings do not need to be concat'ed.
6838 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6840 * Makefile: Add a new target `do-time' that does a quick and simple
6841 profile, leaving easy to parse output.
6843 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
6845 * codegen.cs (Init): Create the dynamic assembly with
6846 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
6848 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
6850 * support.cs: Make the PtrHashtable use only one
6851 instance of its comparer.
6853 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
6855 * typemanager.cs: Fix lookup of GetNamespaces.
6857 2003-11-29 Miguel de Icaza <miguel@ximian.com>
6859 * expression.cs: Removed redundant line.
6861 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
6862 ArrayLists, use for loops with bounds.
6864 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
6867 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
6868 arraylists, use for loop with bounds.
6870 The above three changes give us a 0.071 second performance
6871 improvement out of 3.294 seconds down to 3.223. On my machine
6872 the above changes reduced the memory usage by 1,387 KB during
6875 * cs-parser.jay (QualifiedIdentifier): New class used to represent
6876 QualifiedIdentifiers. Before we created a new string through
6877 concatenation, and mostly later on, the result would be
6878 manipulated by DecomposeQI through string manipulation.
6880 This reduced the compiler memory usage for bootstrapping from
6881 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
6882 compile times in 0.05 seconds.
6884 2003-11-28 Dick Porter <dick@ximian.com>
6886 * support.cs: Do string compares with the Invariant culture.
6894 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
6895 the comparison is done with the Invariant culture.
6897 2003-11-27 Miguel de Icaza <miguel@ximian.com>
6899 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
6900 GetEnumerator method.
6902 (ProbeCollectionType): Iterate starting at the most specific type
6903 upwards looking for a GetEnumerator
6905 * expression.cs: Shift count can be up to 31 for int/uint and 63
6908 2003-11-26 Miguel de Icaza <miguel@ximian.com>
6910 * statement.cs (Block.LookupLabel): Also look for the label on the
6911 children blocks. Use a hash table to keep track of visited
6914 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
6915 we actually did transform the other operand, otherwise fall back
6916 to the common codepath that casts to long.
6918 * cs-tokenizer.cs: Use the same code pattern as the int case.
6919 Maybe I should do the parsing myself, and avoid depending on the
6920 Parse routines to get this done.
6922 2003-11-25 Miguel de Icaza <miguel@ximian.com>
6924 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
6925 which fixes bug 51347. This time test it.
6927 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
6928 attributes for example can not tell the difference between these.
6929 The difference was only a syntax feature of the language.
6931 * attribute.cs: Apply attributes to delegates.
6933 * delegate.cs: Call the apply attributes method.
6935 2003-11-24 Miguel de Icaza <miguel@ximian.com>
6937 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
6938 comparing 0 vs Byte.MinValue, not the value
6940 (ImplicitConversionRequired): When reporting a conversion error,
6941 use error 31 to print out the constant error instead of the
6944 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
6945 which fixes bug 51347.
6947 2003-11-22 Miguel de Icaza <miguel@ximian.com>
6949 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
6950 which fixes the -warnaserror command line option.
6952 2003-11-21 Miguel de Icaza <miguel@ximian.com>
6954 * cfold.cs (DoNumericPromotions): During constant folding of
6955 additions on UIntConstant, special case intconstants with
6956 IntConstants like we do on the expression binary operator.
6958 2003-11-12 Miguel de Icaza <miguel@ximian.com>
6960 * convert.cs (ImplicitReferenceConversion): We were missing a case
6961 (System.Enum are not value types or class types, so we need to
6962 classify them separatedly).
6964 * driver.cs: We do not support error 2007.
6966 2003-11-12 Jackson Harper <jackson@ximian.com>
6968 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
6969 system directory. Also use the full file name so users can
6970 libraries names mscorlib-o-tron.dll in a non system dir.
6972 2004-01-04 David Sheldon <dave-mono@earth.li>
6974 * expression.cs: Added matching ")" to error message for CS0077.
6976 2003-12-19 Martin Baulig <martin@ximian.com>
6978 * typemanager.cs (TypeManager.IsEqualGenericType): New public
6979 static method; see documentation in the method.
6980 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
6982 * convert.cs (Convert.ImplicitReferenceConversion,
6983 Convert.ImplicitReferenceConversionExists): Add support for
6984 generic type declarations; see gen-36.cs.
6986 2003-12-19 Martin Baulig <martin@ximian.com>
6988 * pending.cs (Pending.InterfaceMethod): Use
6989 `Type.IsAssignableFrom()' instead of `=='.
6991 2003-12-18 Martin Baulig <martin@ximian.com>
6993 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
6996 * convert.cs (Convert.ImplicitStandardConversionExists): Use
6997 `expr_type.Equals (target_type)' instead of `=='.
6999 2003-12-08 Martin Baulig <martin@ximian.com>
7001 * generics.cs (Constraints.Types): Removed.
7002 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
7004 (Constraints.ResolveTypes): New public method; resolves the
7005 TypeExpr's to Type's.
7006 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
7007 longer takes the constraints.
7008 (TypeParameter.DefineMethod): Likewise.
7009 (TypeParameter.DefineType): New public method. Calls
7010 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
7013 2003-12-08 Martin Baulig <martin@ximian.com>
7015 * convert.cs (Convert.ImplicitConversionStandard): Use
7016 `expr_type.Equals (target_type)' instead of `=='.
7018 2003-12-08 Martin Baulig <martin@ximian.com>
7020 * typemanager.cs (TypeManager.GetReferenceType): Call
7021 `Type.MakeByRefType ()'.
7023 2003-12-08 Martin Baulig <martin@ximian.com>
7025 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
7026 just has some special meaning in some situations. For instance,
7027 it is allowed to use `where' as the name of a variable etc.
7029 2003-12-04 Martin Baulig <martin@ximian.com>
7031 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
7032 `Type.MakeArrayType()' for array types.
7034 2003-11-18 Miguel de Icaza <miguel@ximian.com>
7036 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
7039 (SizeOf.DoResolve): assign the `type_queried' field. This gets
7042 2003-11-16 Martin Baulig <martin@ximian.com>
7044 * codegen.cs (EmitContext.IsGeneric): Removed.
7046 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
7047 ResolveGeneric() on the DeclSpace.
7049 2003-11-16 Martin Baulig <martin@ximian.com>
7051 * generic.cs (TypeArguments.Resolve):
7052 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
7053 `ResolveType()' on it to get the Type.
7055 2003-11-15 Martin Baulig <martin@ximian.com>
7057 * generic.cs (ConstructedType.GetInterfaces): Override this.
7059 2003-11-14 Martin Baulig <martin@ximian.com>
7061 * interface.cs (Interface.DefineType): Define all type parameters
7062 before adding the interfaces we inherit.
7064 2003-11-11 Martin Baulig <martin@ximian.com>
7066 * generic.cs (ConstructedType.ResolveType): Always call
7067 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
7069 2003-11-10 Martin Baulig <martin@ximian.com>
7071 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
7072 (TypeManager.InitCoreTypes): Initialize them here, but instead of
7073 calling `ResolveType()' on them, directly assign their `Type'.
7075 2003-11-08 Martin Baulig <martin@ximian.com>
7077 * generic.cs (ConstructedType): Override `IsClass' etc.
7079 2003-11-08 Martin Baulig <martin@ximian.com>
7081 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
7082 return value and the `out parent' parameter.
7083 (TypeContainer.DefineType): Moved the CS0644 check into
7084 GetClassBases(). Don't pass the interface types to the
7085 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
7086 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
7088 * ecore.cs (TypeExpr.IsAttribute): New property.
7089 (TypeExpr.GetInterfaces): New method.
7091 * interface.cs (Interface.GetInterfaceTypeByName): Return a
7092 TypeExpr instead of a Type.
7093 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
7094 (Interface.DefineType): Don't pass the interface types to the
7095 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
7096 them later and then call `TypeBulider.AddInterfaceImplementation()'.
7098 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
7099 instead of a `Type[]'.
7100 (TypeManager.RegisterBuilder): Likewise.
7101 (TypeManager.AddUserInterface): Likewise.
7102 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
7103 `Type[]' and also return a `TypeExpr[]'.
7104 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
7106 2003-11-08 Martin Baulig <martin@ximian.com>
7108 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
7111 2003-11-08 Martin Baulig <martin@ximian.com>
7113 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
7114 TypeManager.ResolveExpressionTypes().
7116 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
7117 instead of an Expression.
7118 (TypeExpr): This is now an abstract base class for `TypeExpression'.
7119 (TypeExpression): New public class; formerly known as `TypeExpr'.
7121 * expression.cs (ComposedCast): Derive from TypeExpr.
7123 * typemanager.cs (TypeManager.system_*_expr): These are now
7124 TypExpr's instead of Expression's.
7125 (TypeManager.ResolveExpressionTypes): New public static function;
7126 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
7129 2003-11-06 Miguel de Icaza <miguel@ximian.com>
7131 * expression.cs (New.DoResolve): Do not dereference value that
7132 might be a null return.
7134 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
7135 sure that the constant value has the right type. Fixes an
7136 unreported bug, similar to 50425.
7138 * const.cs (Const.LookupConstantValue): Call
7139 ImplicitStandardConversionExists before doing a conversion to
7140 avoid havng the TypeManager.ChangeType do conversions.
7142 Reduced the number of casts used
7144 (Const.ChangeType): New routine to enable reuse of the constant
7145 type changing code from statement.
7147 * typemanager.cs (ChangeType): Move common initialization to
7148 static global variables.
7152 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
7153 every value type to go through, even if it was void. Fix that.
7155 * cs-tokenizer.cs: Use is_identifier_start_character on the start
7156 character of the define, and the is_identifier_part_character for
7157 the rest of the string.
7159 2003-11-05 Miguel de Icaza <miguel@ximian.com>
7161 * expression.cs (UnaryMutator.EmitCode): When I updated
7162 LocalVariableReference.DoResolve, I overdid it, and dropped an
7163 optimization done on local variable references.
7165 2003-11-04 Miguel de Icaza <miguel@ximian.com>
7167 * ecore.cs: Convert the return from Ldlen into an int.
7169 2003-10-20 Miguel de Icaza <miguel@ximian.com>
7171 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
7172 the accessibility, this is a special case for toplevel non-public
7173 classes (internal for instance).
7175 2003-10-20 Nick Drochak <ndrochak@gol.com>
7177 * ecore.cs: Fix typo and build. Needed another right paren.
7179 2003-10-19 Miguel de Icaza <miguel@ximian.com>
7181 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
7182 `internal' case regular and protected, but not allowing protected
7183 to be evaluated later. Bug 49840
7185 2003-10-15 Miguel de Icaza <miguel@ximian.com>
7187 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
7188 to kb.Nlast, and not the kb.nFirst to isolate the switch
7191 Extract the underlying type, so enumerations of long/ulong are
7192 treated like long/ulong.
7194 2003-10-14 Miguel de Icaza <miguel@ximian.com>
7196 * expression.cs (New): Overload the meaning of RequestedType to
7197 track the possible creation of the NewDelegate type, since
7198 DoResolve is invoked more than once for new constructors on field
7201 See bugs: #48800 and #37014
7203 * cs-parser.jay (declare_local_constants): Take an arraylist
7204 instead of a single constant.
7206 (local_constant_declaration): It should take a
7207 constant_declarators, not a constant_declarator. Fixes 49487
7209 * convert.cs: Fix error report.
7211 2003-10-13 Jackson Harper <jackson@ximian.com>
7213 * typemanager.cs (TypeToCoreType): Add float and double this fixes
7216 2003-11-03 Martin Baulig <martin@ximian.com>
7218 * expression.cs (ArrayAccess.GetStoreOpcode): Added
7219 `out bool has_type_arg'; if set, we need to pass the type to
7221 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
7222 Stelem_Any/Ldelem_Any for generic parameters.
7224 2003-11-02 Martin Baulig <martin@ximian.com>
7226 * expression.cs (Invocation.EmitCall): Use
7227 `TypeManager.IsValueType()' to check whether it's a value type.
7228 Don't set `struct_call' when calling a method on a type parameter.
7230 2003-11-02 Martin Baulig <martin@ximian.com>
7232 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
7233 and removed the TypeBuilder argument.
7235 * typemanager.cs (TypeManager.IsValueType): Return
7236 `t.IsGenericParameter || t.IsValueType'.
7238 2003-10-25 Martin Baulig <martin@ximian.com>
7240 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
7241 call ConstructedType.Resolve() on it.
7243 * generic.cs (ConstructedType.Resolve): Set `type' on success.
7245 2003-10-25 Martin Baulig <martin@ximian.com>
7247 * class.cs (TypeContainer.GetClassBases): Changed
7248 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
7249 CS8214 reporting here.
7250 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
7251 instead of a `Type' for our parent. In case of a recursive
7252 declaration (see tests/gen-23.cs for an example), our parent is a
7253 ConstructedType and it doesn't have its type set. So, first
7254 create our own TypeBuilder, then call constructed.Resolve() to get
7255 the parent's type and finally TypeBuilder.SetParent() it.
7257 * ecore.cs (TypeExpr.Name): New public virtual property.
7260 (ConstructedType): We're now a TypeExpr and not just an Expression.
7261 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
7262 arguments here; this is done later.
7263 (ConstructedType.Resolve): New public method to resolve the type
7264 arguments and bind them.
7266 2003-10-21 Martin Baulig <martin@ximian.com>
7268 * convert.cs: Use `TypeManager.IsValueType' instead of
7269 'type.IsValueType' everywhere.
7271 * typemanager.cs (TypeManager.IsValueType): Return true for type
7272 parameters. The reason for this is that we need to box a type
7273 parameter when converting it to a reference type.
7275 * cs-parser.jay: Added support for default value expressions.
7277 * generics.cs (DefaultValueExpression): New public class.
7279 2003-10-17 Martin Baulig <martin@ximian.com>
7281 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
7282 TypeContainer so we can also use this for Interfaces.
7283 (TypeParameter.Resolve): Likewise.
7285 * interface.cs (Interface.DefineType): Added support for generic
7288 * cs-parser.jay: Added support for generic structs and interfaces.
7290 2003-10-17 Martin Baulig <martin@ximian.com>
7292 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
7293 call generic methods :-)
7295 2003-10-16 Martin Baulig <martin@ximian.com>
7297 * cs-parser.jay (namespace_or_type_name): Only create a
7298 GenericMemberAccess if we actually have type arguments.
7300 2003-10-13 Martin Baulig <martin@ximian.com>
7302 * class.cs (Method.Define): If we're a generic method, call
7303 TypeBuilder.DefineGenericMethod () before resolving
7305 (MethodData): Added .ctor which takes an additional MethodBuilder
7306 argument; this is used for generic methods.
7307 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
7308 we already have a MethodBuilder.
7310 2003-10-10 Martin Baulig <martin@ximian.com>
7312 * class.cs (Method): Added .ctor which takes a `GenericMethod'
7313 instead of a `DeclSpace'. This is used for generic methods.
7315 * cs-parser.jay (method_header): Added support for generic
7316 methods; create a `GenericMethod' instance and pass it to the
7317 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
7318 parameters and locals.
7320 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
7321 since we already have the location. Check whether we're a generic
7322 type declaration or a generic method and create the correct type
7325 * generic.cs (TypeParameter.DefineMethod): New public method.
7326 (GenericMethod): New public class; derives from DeclSpace and is
7327 used for generic methods.
7329 2003-10-09 Martin Baulig <martin@ximian.com>
7331 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
7333 (MethodCore.DoDefineParameters): Removed the TypeContainer
7334 argument; use the DeclSpace which was passed to the .ctor instead.
7335 (MethodCore.CheckParameter): Take a DeclSpace instead of a
7336 TypeContainer; we only need a DeclSpace here.
7338 2003-10-09 Martin Baulig <martin@ximian.com>
7340 * class.cs (MethodData): Added additional `DeclSpace ds' argument
7342 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
7343 EmitContext's .ctor.
7345 2003-10-09 Martin Baulig <martin@ximian.com>
7347 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
7348 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
7349 AsAccessible(), moved them as well.
7351 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
7353 2003-10-07 Miguel de Icaza <miguel@ximian.com>
7355 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
7356 generation for >=, as spotted by Paolo, bug 48679.
7357 Patch from David Waite.
7359 * cs-tokenizer.cs: Add handling for #pragma.
7361 * cs-parser.jay: Allow for both yield and yield return in the
7362 syntax. The anti-cobolization of C# fight will go on!
7364 * class.cs (TypeBuilder.DefineType): Catch error condition here
7365 (Parent.DefineType erroring out and returning null).
7367 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
7368 coping with enumerations variables, we were mistakenly processing
7369 them as a regular value type instead of built-in types. Fixes the
7372 * typemanager.cs (IsBuiltinOrEnum): New method.
7374 2003-09-30 Miguel de Icaza <miguel@ximian.com>
7376 * cs-parser.jay: Upgrade: yield now needs the return clause.
7378 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
7380 * cs-parser.jay : Renamed yyName to yyNames related to jay.
7382 2003-09-29 Martin Baulig <martin@ximian.com>
7384 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
7385 inflated generic methods.
7387 * generics.cs (ConstructedType): Distinguish between open and
7388 closed constructed types; correctly resolve the arguments.
7390 2003-09-22 Martin Baulig <martin@ximian.com>
7392 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
7393 all type arguments meet their constraints.
7395 2003-09-19 Martin Baulig <martin@ximian.com>
7397 * decl.cs (MemberCache.SetupCacheForInterface): Take a
7398 `MemberCache parent' argument. Normally, an interface doesn't
7399 have a parent type except System.Object, but we use this in gmcs
7400 for generic type parameters.
7402 2003-09-18 Martin Baulig <martin@ximian.com>
7404 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
7405 on `type.IsInterface'; don't check whether the type has a parent
7406 to determine whether it's an interface.
7408 2003-09-17 Martin Baulig <martin@ximian.com>
7410 * generic.cs (ConstructedType.ToString): Always use `name' as the
7413 2003-09-15 Martin Baulig <martin@ximian.com>
7415 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
7417 * generic.cs (Constraints.Resolve): New public method; this is
7418 called to resolve the constraint types and to check whether all
7419 the constraints are correct.
7420 (Constraints.Types): New public property.
7421 (TypeParameter.Resolve): New public method; resolves all the
7424 * class.cs (TypeContainer.DefineType): Call
7425 TypeParameter.Resolve() before actually defining the type.
7427 2003-09-15 Martin Baulig <martin@ximian.com>
7429 * class.cs (TypeContainer.DefineType): Added an error flag to
7430 avoid reporting duplicate CS0146's ("class definition is
7433 * driver.cs (Driver.MainDriver): Abort if
7434 RootContext.ResolveTree() reported any errors.
7436 2003-09-07 Martin Baulig <martin@ximian.com>
7438 * report.cs (Error, Warning): Added overloaded versions which take
7439 a `params object[] args' and call String.Format().
7441 2003-09-07 Martin Baulig <martin@ximian.com>
7443 * decl.cs (DeclSpace..ctor): Don't call
7444 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
7445 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
7446 (DeclSpace.RecordDecl): New method.
7448 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
7450 2003-09-02 Ravi Pratap <ravi@ximian.com>
7452 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
7453 value attributes to be applied to ParameterBuilders.
7455 * class.cs (MethodCore.LabelParameters): Make static and more
7456 generic so that it can be used from other places - like interface
7457 methods, for instance.
7459 * interface.cs (Interface.Emit): Call LabelParameters before
7460 emitting attributes on the InterfaceMethod.
7462 2003-09-07 Martin Baulig <martin@ximian.com>
7464 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
7465 if the number of type parameters doesn't match.
7467 2003-09-04 Martin Baulig <martin@ximian.com>
7469 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
7470 for arrays of generic type params (ie. `!0[]').
7472 2003-09-04 Martin Baulig <martin@ximian.com>
7474 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
7477 2003-09-04 Martin Baulig <martin@ximian.com>
7479 * decl.cs (DeclSpace.LookupGeneric): New method.
7480 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
7483 * generic.cs (TypeParameterExpr): Take a TypeParameter as
7484 argument, not just a string.
7485 (TypeParameter.Define): New public method; this is called to
7486 actually define the generic parameter; after this, you can use the
7487 new `Type' property to get the type.
7489 2003-09-04 Martin Baulig <martin@ximian.com>
7491 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
7492 is now an ArrayList; initialize the result of the `TypeParameters'
7494 (DeclSpace.GetGenericData): Removed.
7495 (DeclSpace.LookupGeneric): Temporarily removed; we need to
7496 implement this in a different way.
7497 (DeclSpace.GetTypeParameters): Removed; there's now a
7498 `TypeParameters' property.
7499 (DeclSpace.TypeParameters): New public property.
7501 * generic.cs (Constraints): Make this class public.
7502 (TypeParameter): New public class.
7504 2003-09-04 Martin Baulig <martin@ximian.com>
7506 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
7509 * class.cs (TypeContainer.DefineType): Call
7510 TypeBuilder.DefineGenericParameter () on all generic parameters if
7511 this is a generic type.
7513 2003-08-28 Martin Baulig <martin@ximian.com>
7515 * sample-stack.il: Compile this with ilasm: "ilasm /dll
7518 * sample-hello.cs: Compile this with gmcs: "gmcs
7519 /r:sample-stack.dll sample-hello.cs".
7521 2003-08-28 Martin Baulig <martin@ximian.com>
7523 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
7524 the parameters to the generic type.
7526 2003-08-28 Martin Baulig <martin@ximian.com>
7528 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
7530 2003-08-28 Martin Baulig <martin@ximian.com>
7532 * cs-parser.jay (opt_type_argument_list): Use
7533 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
7534 (primary_expression): Replace `qualified_identifier' with `type_name'.
7535 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
7537 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
7538 parser to check whether it is syntactically a type parameter list;
7539 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
7542 2003-08-26 Martin Baulig <martin@ximian.com>
7544 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
7545 resolving aliases; fixes #47927.
7547 2003-08-26 Martin Baulig <martin@ximian.com>
7549 * statement.cs (Using.DoResolve): This is internally emitting a
7550 try/finally clause, so we need to set ec.NeedExplicitReturn if we
7551 do not always return. Fixes #47681.
7553 2003-08-26 Martin Baulig <martin@ximian.com>
7555 * decl.cs (MemberCore): Moved WarningNotHiding(),
7556 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
7558 (AdditionResult): Make this nested in DeclSpace.
7559 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
7560 argument; call NamespaceEntry.Define() unless we're nested in a
7563 * namespace.cs (Namespace.DefineName): New public function. This
7564 is called from DeclSpace's .ctor to add
7565 (Namespace.Lookup): Include DeclSpaces in the lookup.
7567 * class.cs (Operator): Derive from MemberBase, not MemberCore.
7569 * const.cs (Const): Derive from MemberBase, not MemberCore.
7571 2003-08-25 Martin Baulig <martin@ximian.com>
7573 * convert.cs (Convert.ExplicitReferenceConversion): When
7574 converting from an interface type to a class, unbox if the target
7575 type is a struct type. Fixes #47822.
7577 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7579 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
7582 2003-08-22 Martin Baulig <martin@ximian.com>
7584 * class.cs (TypeManager.DefineType): When defining a nested type,
7585 call DefineType() on our parent; fixes #47801.
7587 2003-08-22 Martin Baulig <martin@ximian.com>
7589 * class.cs (MethodData.Define): While checking if a method is an
7590 interface implementation, improve the test a bit more to fix #47654.
7592 2003-08-22 Martin Baulig <martin@ximian.com>
7594 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
7595 correctly; fixes #47722.
7597 2003-08-22 Martin Baulig <martin@ximian.com>
7599 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
7600 LocalVariableReference, ensure it's not read-only. Fixes #47536.
7602 * statement.cs (Fixed.DoResolve): Make all variables read-only.
7604 2003-08-22 Martin Baulig <martin@ximian.com>
7606 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
7607 can only be assigned in static constructors. Fixes #47161.
7609 2003-08-22 Martin Baulig <martin@ximian.com>
7611 Rewrote and improved the flow analysis code.
7613 * flowbranching.cs (FlowBranching): Make this class abstract.
7614 (FlowBranching.CreateBranching): New static function to create a
7616 (FlowBranchingBlock, FlowBranchingException): New classes.
7617 (FlowBranching.UsageVector.Type): New public readonly field.
7618 (FlowBranching.UsageVector.Breaks): Removed the setter.
7619 (FlowBranching.UsageVector.Returns): Removed the setter.
7620 (FlowBranching.UsageVector): Added Break(), Return(),
7621 NeverReachable() and Throw() methods to modify the reachability.
7622 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
7623 done by FlowBranching.Merge().
7624 (FlowBranching.UsageVector.MergeChild): New method; merges the
7625 merge result into the current vector.
7626 (FlowBranching.Merge): New abstract method to merge a branching.
7628 2003-08-12 Martin Baulig <martin@ximian.com>
7630 * expression.cs (Indirection.CacheTemporaries): Create the
7631 LocalTemporary with the pointer type, not its element type.
7633 2003-08-10 Miguel de Icaza <miguel@ximian.com>
7635 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
7636 token was a keyword or not.
7638 Add `error' options where an IDENTIFIER was expected; Provide
7639 CheckToken and CheckIdentifierToken convenience error reporting
7642 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
7644 * decl.cs: Rename `NamespaceEntry Namespace' public field into
7645 NameSpaceEntry NameSpaceEntry.
7647 (LookupInterfaceOrClass): Avoid creating a full qualified name
7648 from namespace and name: avoid doing lookups when we know the
7649 namespace is non-existant. Use new Tree.LookupByNamespace which
7650 looks up DeclSpaces based on their namespace, name pair.
7652 * driver.cs: Provide a new `parser verbose' to display the
7653 exception thrown during parsing. This is turned off by default
7654 now, so the output of a failure from mcs is more graceful.
7656 * namespace.cs: Track all the namespaces defined in a hashtable
7659 (IsNamespace): New method
7661 2003-08-09 Miguel de Icaza <miguel@ximian.com>
7663 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
7664 we know that we need to concatenate (full typename can never be
7669 * statement.cs: Use a bitfield; Do not initialize to null things
7670 which are done by the constructor by default.
7672 * cs-parser.jay: bug fix, parameter was 4, not 3.
7674 * expression.cs: Just use the property;
7676 * statement.cs: No need for GetVariableInfo method.
7678 2003-08-08 Martin Baulig <martin@ximian.com>
7680 * flowanalysis.cs (FlowReturns): This is now nested in the
7681 `FlowBranching' class.
7682 (MyBitVector): Moved this here from statement.cs.
7683 (FlowBranching.SiblingType): New enum type.
7684 (FlowBranching.CreateSibling): Added `SiblingType' argument.
7686 2003-08-07 Martin Baulig <martin@ximian.com>
7688 * flowanalysis.cs (FlowBranchingType): This is now nested in the
7689 `FlowBranching' class and called `BranchingType'.
7691 2003-08-07 Martin Baulig <martin@ximian.com>
7693 * flowanalysis.cs: Moved all the control flow analysis code into
7696 2003-08-07 Martin Baulig <martin@ximian.com>
7698 * assign.cs (Assign.DoResolve): `target' must either be an
7699 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
7702 2003-08-07 Miguel de Icaza <miguel@ximian.com>
7704 * expression.cs (BinaryMethod): This kind of expression is created by the
7705 Binary class if it determines that the operator has to be handled
7708 (BinaryDelegate): This kind of expression is created if we are
7709 dealing with a + or - operator on delegates.
7711 (Binary): remove method, argumetns, and DelegateOperator: when
7712 dealing with methods,
7714 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
7716 * statement.cs (Block): use bitfields for the three extra booleans
7717 we had in use. Remove unused topblock parameter.
7719 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
7721 * assign.cs: Drop extra unneeded tests.
7723 2003-08-06 Miguel de Icaza <miguel@ximian.com>
7725 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
7727 * statement.cs (Foreach): Use VariableStorage instead of
7730 * codegen.cs (VariableStorage): New class used by clients that
7731 require a variable stored: locals or fields for variables that
7732 need to live across yield.
7734 Maybe provide a convenience api for EmitThis+EmitLoad?
7736 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
7739 2003-08-05 Miguel de Icaza <miguel@ximian.com>
7741 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
7742 RemapParameterLValue): New methods that are used to turn a
7743 precomputed FieldInfo into an expression like this:
7747 The idea is to use this instead of making LocalVariableReference
7748 have more than one meaning.
7750 * cs-parser.jay: Add error production to BASE.
7752 * ecore.cs: Deal with TypeManager.GetField returning null, which
7753 is now a valid return value.
7755 (FieldExprNoAddress): New expression for Fields whose address can
7758 * expression.cs (LocalVariableReference): During the resolve
7759 phases, create new expressions if we are in a remapping context.
7760 Remove code that dealt with remapping here.
7762 (ParameterReference): same.
7764 (ProxyInstance): New expression, like the `This' expression, but
7765 it is born fully resolved. We know what we are doing, so remove
7766 the errors that are targeted to user-provided uses of `this'.
7768 * statement.cs (Foreach): our variable is now stored as an
7769 Expression; During resolution, follow the protocol, dont just
7770 assume it will return this.
7772 2003-08-06 Martin Baulig <martin@ximian.com>
7774 * support.cs (SeekableStreamReader.cs): New public class.
7776 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
7777 SeekableStreamReader instead of the normal StreamReader.
7779 2003-08-04 Martin Baulig <martin@ximian.com>
7781 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
7782 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
7783 deambiguate casts and delegate invocations.
7784 (parenthesized_expression): Use the new tokens to ensure this is
7785 not a cast of method invocation.
7787 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
7788 when reading a `)' and Deambiguate_CloseParens () was previously
7791 * expression.cs (ParenthesizedExpression): New class. This is
7792 just used for the CS0075 test.
7793 (Binary.DoResolve): Check for CS0075.
7795 2003-07-29 Ravi Pratap <ravi@ximian.com>
7797 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
7798 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
7799 reference comparison.
7801 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
7802 examine the ReturnType for equality - this is necessary in the
7803 cases of implicit and explicit operators whose signature also
7804 includes the return type.
7806 2003-07-26 Miguel de Icaza <miguel@ximian.com>
7808 * namespace.cs: Cache the result of the namespace computation,
7809 instead of computing it every time.
7811 2003-07-24 Miguel de Icaza <miguel@ximian.com>
7813 * decl.cs: Use a global arraylist that we reuse over invocations
7814 to avoid excesive memory consumption. Reduces memory usage on an
7815 mcs compile by one meg (45 average).
7817 * typemanager.cs (LookupTypeReflection): In .NET pointers are
7818 private, work around that.
7820 2003-07-23 Miguel de Icaza <miguel@ximian.com>
7822 * literal.cs (IntLiteral): Define Zero and One static literals.
7824 * cs-parser.jay (integer_literal): use static literals to reduce
7825 memory usage for the most used literals (0, 1 and -1). 211kb
7826 reduced in memory usage.
7828 Replace all calls to `new ArrayList' with `new
7829 ArrayList(4)' which is a good average number for most allocations,
7830 and also requires only 16 bytes of memory for its buffer by
7833 This reduced MCS memory usage in seven megabytes for the RSS after
7836 2003-07-28 Ravi Pratap <ravi@ximian.com>
7838 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
7839 handle params methods the correct way by forming only one
7840 applicable set with params and normal methods in them. Earlier we
7841 were looking at params methods only if we found no normal methods
7842 which was not the correct thing to do.
7844 (Invocation.BetterFunction): Take separate arguments indicating
7845 when candidate and the best method are params methods in their
7848 This fixes bugs #43367 and #46199.
7850 * attribute.cs: Documentation updates.
7852 (CheckAttribute): Rename to CheckAttributeTarget.
7853 (GetValidPlaces): Rename to GetValidTargets.
7855 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
7856 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
7860 2003-07-28 Miguel de Icaza <miguel@ximian.com>
7862 * codegen.cs: Compute IsGeneric correctly.
7864 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
7867 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
7868 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
7869 regressions, and I was chasing more bugs than I required.
7871 * interface.cs: Use expressions for base type names (like classes
7872 and structs have been doing for a while now), and resolve that.
7873 This patch should probably go into head as well.
7875 This makes it one less user of FindType.
7877 2003-07-24 Miguel de Icaza <miguel@ximian.com>
7879 This compiler can not self host currently. Need to fix that.
7881 * Makefile: compile to `gmcs.exe'
7883 * driver.cs: Turn on v2 by default on gmcs.
7885 * generic.cs (ConstructedType): Does no longer take a container
7886 type argument; That will be taken care of later.
7888 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
7889 Use SimpleName to resolve for now, so we can continue the work on
7890 the parser, until we get Type.GetType that understands generics.
7892 (ConstructedType.ToString): Implement
7894 (TypeArguments.Resolve): Resolve the child expressions as types.
7896 * cs-parser.jay: Rename interface_constraints to
7897 type_parameter_constraints
7899 (namespace_or_type_name): Only use constructed types for the basic
7900 construction, we will deal with identifier<...> later.
7902 (type/type_name): No longer call DecomposeQI, as
7903 namespace_or_type_name is always decoded now.
7905 2003-07-22 Ravi Pratap <ravi@ximian.com>
7907 * expression.cs (Invocation.OverloadResolve): Follow the spec more
7908 closely: we eliminate methods in base types when we have an
7909 applicable method in a top-level type.
7911 Please see section 14.5.5.1 for an exact description of what goes
7914 This fixes bug #45127 and a host of other related to corlib compilation.
7916 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
7917 array is the method corresponding to the top-level type (this is
7918 because of the changes made to icall.c) so we change this
7921 (MethodGroupExpr.Name): This too.
7923 * typemanager.cs (GetElementType): New method which does the right
7924 thing when compiling corlib.
7926 * everywhere: Make use of the above in the relevant places.
7928 2003-07-22 Martin Baulig <martin@ximian.com>
7930 * cs-parser.jay (invocation_expression): Moved
7931 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
7932 `cast_expression', but create a InvocationOrCast which later
7933 resolves to either an Invocation or a Cast.
7935 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
7936 method; call this before EmitStatement() to make sure that this
7937 expression can be used as a statement.
7939 * expression.cs (InvocationOrCast): New class; resolves to either
7940 an Invocation or a Cast.
7942 * statement.cs (StatementExpression): Call ResolveStatement() on
7943 the ExpressionStatement before emitting it.
7945 2003-07-21 Martin Baulig <martin@ximian.com>
7947 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
7948 `ref' and `out' attributes match; fixes #46220.
7949 (MemberAccess.ResolveMemberAccess): You can't reference a type
7950 through an expression; fixes #33180.
7951 (Indexers.GetIndexersForType): Don't return the indexers from
7952 interfaces the class implements; fixes #46502.
7954 2003-07-21 Martin Baulig <martin@ximian.com>
7956 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
7957 CS0661 checks; fixes bug #30442.
7959 2003-07-21 Martin Baulig <martin@ximian.com>
7961 * decl.cs (AdditionResult): Added `Error'.
7963 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
7965 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
7966 cs0031.cs actually work.
7968 2003-07-20 Miguel de Icaza <miguel@ximian.com>
7970 * cs-parser.jay (namespace_name): do not use
7971 namespace_or_type_name, use qualified_identifier, because
7972 namespace_or_type_name will soon return a composed expression
7973 instead of a string.
7975 (namespace_or_type_name): Instead of returning a string, now this
7976 production returns an expression.
7978 * codegen.cs (EmitContext): Setup IsGeneric property based on
7979 whether our DeclSpace is generic, our the method is generic.
7981 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
7982 the method is generic.
7984 * cs-parser.jay (type_arguments, opt_type_argument_list,
7985 type_parameters, type_parameter_list, opt_type_parameter_list,
7986 type_parameter,, opt_type_parameter_constraints_clauses,
7987 type_parameter_constraints_clauses,
7988 type_parameter_constraint_clause, type_parameter_constraint,
7989 interface_constraints): Add new production
7991 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
7992 DeclSpace is generic or not.
7994 (DeclSpace.SetParameterInfo): New routine, used to set the
7995 parameter info for a type.
7997 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
7998 returns a GenericTypeExpr
8000 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
8001 generic, lookup the generic argument.
8003 * attribute.cs: Do not allow TypeParameterExpressions in
8006 * class.cs: Do not allow the Main method to be defined in a
8009 * expression.cs (SizeOf): Do not allow generic types to be used as
8010 arguments to sizeof.
8012 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
8013 it: whether a type is generic or not. Only works for types we are
8014 currently building for now.
8016 2003-07-20 Martin Baulig <martin@ximian.com>
8018 * namespace.cs: Fixed that bug which caused a crash when compiling
8021 2003-07-20 Miguel de Icaza <miguel@ximian.com>
8023 * typemanager.cs (LookupTypeReflection): Never expose types which
8024 are NotPublic, NestedPrivate, NestedAssembly, or
8025 NestedFamANDAssem. We used to return these, and later do a check
8026 that would report a meaningful error, but the problem is that we
8027 would not get the real match, if there was a name override.
8029 2003-07-18 Miguel de Icaza <miguel@ximian.com>
8031 * namespace.cs (Namespace, Name): Do not compute the namespace
8032 name dynamically, compute it in the constructor. This reduced
8033 memory usage by 1697 KB.
8035 * driver.cs: Use --pause to pause at the end.
8037 2003-07-17 Peter Williams <peter@newton.cx>
8039 * Makefile: Change the name of the test target so that it doesn't
8040 conflict with the recursive test target.
8042 2003-07-17 Miguel de Icaza <miguel@ximian.com>
8044 * expression.cs (LocalVariableReference.Emit, EmitAssign,
8045 AddressOf): Do not use EmitThis, that was wrong, use the actual
8048 2003-07-15 Miguel de Icaza <miguel@ximian.com>
8050 * class.cs (MethodData.Define): While checking if a method is an
8051 interface implementation, improve the test: If we are not public
8052 (use new test here: use the computed MethodAttributes directly,
8053 instead of the parsed modifier flags) check if the `implementing'
8054 method comes from an interface or not.
8056 * pending.cs (VerifyPendingMethods): Slightly better error
8059 * makefile: add test target that does the mcs bootstrap.
8061 2003-07-16 Ravi Pratap <ravi@ximian.com>
8063 * interface.cs (Define): Do nothing here since there are no
8064 members to populate etc. Move the attribute emission out of here
8065 since this was just totally the wrong place to put it. Attribute
8066 application happens during the 'Emit' phase, not in the 'Define'
8069 (Emit): Add this method and move the attribute emission here
8071 * rootcontext.cs (EmitCode): Call the Emit method on interface
8074 2003-07-14 Ravi Pratap M <ravi@ximian.com>
8076 * expression.cs (OverloadResolve): Report error only if Location
8077 is not 'Null' which means that there was a probe going on.
8079 2003-07-14 Martin Baulig <martin@ximian.com>
8081 * expression.cs (ConditionalLogicalOperator): New public class to
8082 implement user defined conditional logical operators.
8083 This is section 14.11.2 in the spec and bug #40505.
8085 2003-07-14 Martin Baulig <martin@ximian.com>
8087 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
8089 2003-07-14 Martin Baulig <martin@ximian.com>
8091 * codegen.cs (EmitContext.InFixedInitializer): New public field.
8093 * ecore.cs (IVariable.VerifyFixed): New interface method.
8095 * expression.cs (Unary.ResolveOperator): When resolving the `&'
8096 operator, check whether the variable is actually fixed. Fixes bug
8097 #36055. Set a variable definitely assigned when taking its
8098 address as required by the spec.
8100 * statement.cs (LocalInfo.IsFixed): New field.
8101 (LocalInfo.MakePinned): Set `IsFixed' to true.
8103 2003-07-14 Ravi Pratap M <ravi@ximian.com>
8105 * attribute.cs (Attribute.Resolve): While doing a Member lookup
8106 for .ctors, ensure that we only ask for members declared in the
8107 attribute type (BindingFlags.DeclaredOnly).
8111 * expression.cs (Error_WrongNumArguments): Report error 1501
8112 correctly the way CSC does.
8114 2003-07-13 Martin Baulig <martin@ximian.com>
8116 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
8117 lookup on the fully qualified name, to make things like "X.X" work
8118 where "X.X" is a fully qualified type name, but we also have a
8119 namespace "X" in the using list. Fixes #41975.
8121 2003-07-13 Martin Baulig <martin@ximian.com>
8123 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
8124 function. If we're a CompoundAssign, we need to create an embedded
8125 CompoundAssign, not an embedded Assign.
8126 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
8129 2003-07-13 Martin Baulig <martin@ximian.com>
8131 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
8132 work to fix bug #46088.
8134 2003-07-13 Ravi Pratap <ravi@ximian.com>
8136 * class.cs (Operator.Emit): Do not emit attributes here - it is
8137 taken care of by the Method class that we delegate too. This takes
8140 2003-07-10 Martin Baulig <martin@ximian.com>
8142 * expression.cs (TypeOfVoid): New class.
8143 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
8145 2003-07-10 Martin Baulig <martin@ximian.com>
8147 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
8150 2003-07-10 Martin Baulig <martin@ximian.com>
8152 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
8153 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
8155 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
8157 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
8159 2003-07-10 Martin Baulig <martin@ximian.com>
8161 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
8162 of decimal. Fixes #42850.
8164 NOTE: I also fixed the created byte blob, but this doesn't work on
8165 the MS runtime and csc never produces any byte blobs for decimal
8168 2003-07-10 Martin Baulig <martin@ximian.com>
8170 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
8171 structs; fixes #32068.
8172 (Block.AddChildVariableNames): Fixed #44302.
8174 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8176 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
8178 2003-07-07 Miguel de Icaza <miguel@ximian.com>
8180 * attribute.cs: And this test is onger needed.
8182 2003-07-08 Martin Baulig <martin@ximian.com>
8184 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
8185 inaccessible types. Fixes #36313.
8187 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
8189 * namespace.cs (NamespaceEntry): Create implicit entries for all
8190 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
8191 implicit entries for N1.N2 and N1.
8193 2003-07-08 Martin Baulig <martin@ximian.com>
8195 Rewrote the handling of namespaces to fix a lot of the issues
8196 wrt. `using' aliases etc.
8198 * namespace.cs (Namespace): Splitted this class into a
8199 per-assembly `Namespace' and a per-file `NamespaceEntry'.
8201 * typemanager.cs (TypeManager.IsNamespace): Removed.
8202 (TypeManager.ComputeNamespaces): Only compute namespaces from
8203 loaded assemblies here, not the namespaces from the assembly we're
8204 currently compiling.
8206 2003-07-08 Martin Baulig <martin@ximian.com>
8208 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
8210 2003-07-07 Miguel de Icaza <miguel@ximian.com>
8212 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
8215 I thought about the memory savings here, but LookupTypeReflection
8216 is used under already very constrained scenarios. Compiling
8217 corlib or mcs only exposes one hit, so it would not really reduce
8218 any memory consumption.
8220 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8222 * typemanager.cs: fixes bug #45889 by only adding public types from
8223 other assemblies to the list of known types.
8225 2003-07-07 Miguel de Icaza <miguel@ximian.com>
8227 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
8228 on the type we resolved.
8230 2003-07-05 Martin Baulig <martin@ximian.com>
8232 * pending.cs (PendingImplementation.ParentImplements): Don't
8233 create the proxy if the parent is abstract.
8235 * class.cs (TypeContainer.DefineIndexers): Process explicit
8236 interface implementations first. Fixes #37714.
8238 2003-07-04 Miguel de Icaza <miguel@ximian.com>
8240 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
8241 defined recursively; but since we modify the input parameters
8242 (left is set to `this' temporarily), we reset this value if the
8243 left_is_explicit is false, which gives the original semantics to
8246 * literal.cs (NullPointer): new class used to represent a null
8247 literal in a pointer context.
8249 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
8250 type is a pointer, use a NullPointer object instead of a
8251 NullLiteral. Closes 43687
8253 (ExplicitConversion): Convert pointer values using
8254 the conv opcode to the proper type.
8256 * ecore.cs (New): change ValueTypeVariable property into a method,
8257 that returns whether the valuetype is suitable for being used.
8259 * expression.cs (Binary.DoNumericPromotions): Only return if we
8260 the int constant was a valid uint, and we can return both left and
8261 right as uints. If not, we continue processing, to trigger the
8262 type conversion. This fixes 39018.
8264 * statement.cs (Block.EmitMeta): During constant resolution, set
8265 the CurrentBlock property on the emitcontext, so that we resolve
8266 constants propertly.
8268 2003-07-02 Martin Baulig <martin@ximian.com>
8270 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
8271 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
8273 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
8274 than emitting it here.
8276 * statement.cs: Fixed some more flow analysis bugs.
8278 2003-07-02 Martin Baulig <martin@ximian.com>
8280 * class.cs (MethodData.Define): When implementing interface
8281 methods, set Final unless we're Virtual.
8283 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
8284 check work for interface methods.
8286 2003-07-01 Martin Baulig <martin@ximian.com>
8288 * ecore.cs (EmitContext.This): Replaced this property with a
8289 GetThis() method which takes a Location argument. This ensures
8290 that we get the correct error location for a CS0188.
8292 2003-07-01 Miguel de Icaza <miguel@ximian.com>
8294 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
8295 ImplicitStandardConversion.
8297 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
8299 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
8301 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
8304 2003-06-30 Miguel de Icaza <miguel@ximian.com>
8306 * class.cs (Constructor.Define): Turn off initlocals for unsafe
8309 (MethodData.Define): Turn off initlocals for unsafe methods.
8311 2003-06-29 Miguel de Icaza <miguel@ximian.com>
8313 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
8314 complete; Fixes #37521.
8316 * delegate.cs: Use Modifiers.TypeAttr to compute the
8317 TypeAttributes, instead of rolling our own. This makes the flags
8318 correct for the delegates.
8320 2003-06-28 Miguel de Icaza <miguel@ximian.com>
8322 * class.cs (Constructor.Define): Set the private flag for static
8323 constructors as well.
8325 * cs-parser.jay (statement_expression): Set the return value to
8326 null, to avoid a crash when we catch an error.
8328 2003-06-24 Miguel de Icaza <miguel@ximian.com>
8330 * cs-parser.jay: Applied patch from Jackson that adds support for
8331 extern and unsafe modifiers to destructor declarations.
8333 * expression.cs: Report error 21 if the user is trying to index a
8336 * driver.cs: Add an error message, suggested by the bug report.
8338 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
8339 if we do not have a ": this ()" constructor initializer. Fixes 45149
8341 2003-06-14 Miguel de Icaza <miguel@ximian.com>
8343 * namespace.cs: Add some information to reduce FAQs.
8345 2003-06-13 Miguel de Icaza <miguel@ximian.com>
8347 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
8348 underlying enumeration types. Fixes #43915.
8350 * expression.cs: Treat ushort/short as legal values to be used in
8353 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
8355 * delegate.cs: transfer custom attributes for paramenters from
8356 the delegate declaration to Invoke and BeginInvoke.
8358 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
8360 * attribute.cs: handle custom marshalers and emit marshal info
8363 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
8365 * makefile.gnu: Added anonymous.cs to the compiler sources.
8367 2003-05-28 Miguel de Icaza <miguel@ximian.com>
8369 * iterators.cs: Change the name of the proxy class to include two
8372 * cs-parser.jay: Update grammar to include anonymous methods.
8374 * anonymous.cs: new file.
8376 2003-05-27 Miguel de Icaza <miguel@ximian.com>
8378 * class.cs (Field.Define): Add missing test for pointers and
8381 2003-05-27 Ravi Pratap <ravi@ximian.com>
8383 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
8384 we use the stobj opcode.
8386 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
8387 since it wasn't the correct fix.
8389 It still is puzzling that we are required to use stobj for IntPtr
8390 which seems to be a ValueType.
8392 2003-05-26 Miguel de Icaza <miguel@ximian.com>
8394 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
8395 during regular simple name resolution. Now, the trick is that
8396 instead of returning for processing the simplename, we do a
8397 TypeManager.LookupType (ie, a rooted lookup as opposed to a
8398 contextual lookup type). If a match is found, return that, if
8399 not, return for further composition.
8401 This fixes long-standing 30485.
8403 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
8404 using the address to initialize an object, do an Stobj instead of
8405 using the regular Stelem.
8407 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
8408 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
8409 Because if we are a BaseIndexerAccess that value will be true.
8412 * statement.cs (GotoCase.Resolve): Return after reporting an
8413 error, do not attempt to continue.
8415 * expression.cs (PointerArithmetic.Emit): If our operand is a
8416 long, convert our constants to match the operand before
8417 multiplying. Convert to I type before adding. Fixes 43670.
8419 2003-05-14 Ravi Pratap <ravi@ximian.com>
8421 * enum.cs (ImplicitConversionExists) : Rename to
8422 ImplicitEnumConversionExists to remove ambiguity.
8424 * ecore.cs (NullCast): New type of cast expression class which
8425 basically is very similar to EmptyCast with the difference being
8426 it still is a constant since it is used only to cast a null to
8430 * convert.cs (ImplicitReferenceConversion): When casting a null
8431 literal, we return a NullCast.
8433 * literal.cs (NullLiteralTyped): Remove - I don't see why this
8434 should be around anymore.
8436 The renaming (reported was slightly wrong). Corrections:
8438 ConvertImplicitStandard -> ImplicitConversionStandard
8439 ConvertExplicitStandard -> ExplicitConversionStandard
8441 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
8442 before passing them in !
8444 * convert.cs (ImplicitConversionStandard): When comparing for
8445 equal expr and target types, ensure that expr is not a
8448 In general, we must not be checking (expr_type ==
8449 target_type) in the top level conversion methods
8450 (ImplicitConversion, ExplicitConversion etc). This checking is
8451 done in the methods that they delegate to.
8453 2003-05-20 Miguel de Icaza <miguel@ximian.com>
8455 * convert.cs: Move Error_CannotConvertType,
8456 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
8457 ImplicitNumericConversion, ImplicitConversionExists,
8458 ImplicitUserConversionExists, StandardConversionExists,
8459 FindMostEncompassedType, FindMostSpecificSource,
8460 FindMostSpecificTarget, ImplicitUserConversion,
8461 ExplicitUserConversion, GetConversionOperators,
8462 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
8463 TryImplicitIntConversion, Error_CannotConvertImplicit,
8464 ConvertImplicitRequired, ConvertNumericExplicit,
8465 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
8466 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
8469 Perform the following renames:
8471 StandardConversionExists -> ImplicitStandardConversionExists
8472 ConvertImplicit -> ImplicitConversion
8473 ConvertImplicitStandard -> ImplicitStandardConversion
8474 TryImplicitIntConversion -> ImplicitIntConversion
8475 ConvertImplicitRequired -> ImplicitConversionRequired
8476 ConvertNumericExplicit -> ExplicitNumericConversion
8477 ConvertReferenceExplicit -> ExplicitReferenceConversion
8478 ConvertExplicit -> ExplicitConversion
8479 ConvertExplicitStandard -> ExplicitStandardConversion
8481 2003-05-19 Martin Baulig <martin@ximian.com>
8483 * statement.cs (TypeInfo.StructInfo): Made this type protected.
8484 (TypeInfo): Added support for structs having structs as fields.
8486 * ecore.cs (FieldExpr): Implement IVariable.
8487 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
8488 VariableInfo for the field.
8490 2003-05-18 Martin Baulig <martin@ximian.com>
8492 * expression.cs (This.DoResolve): Report a CS0027 if we're
8493 emitting a field initializer.
8495 2003-05-18 Martin Baulig <martin@ximian.com>
8497 * expression.cs (This.ResolveBase): New public function.
8498 (This.DoResolve): Check for CS0188.
8500 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
8503 * ecore.cs (MethodGroupExpr.DoResolve): Set the
8504 `instance_expression' to null if we don't have any non-static
8507 2003-05-18 Martin Baulig <martin@ximian.com>
8509 Reworked the way how local variables and parameters are handled by
8510 the flow analysis code.
8512 * statement.cs (TypeInfo, VariableMap): New public classes.
8513 (VariableInfo): New public class. This is now responsible for
8514 checking whether a variable has been assigned. It is used for
8515 parameters and local variables.
8516 (Block.EmitMeta): Take the InternalParameters as argument; compute
8517 the layout of the flow vectors here.
8518 (Block.LocalMap, Block.ParameterMap): New public properties.
8519 (FlowBranching): The .ctor doesn't get the InternalParameters
8520 anymore since Block.EmitMeta() now computes the layout of the flow
8522 (MyStructInfo): This class is now known as `StructInfo' and nested
8523 in `TypeInfo'; we don't access this directly anymore.
8525 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
8526 property and removed IsAssigned(), IsFieldAssigned(),
8527 SetAssigned() and SetFieldAssigned(); we now call them on the
8528 VariableInfo so we don't need to duplicate this code everywhere.
8530 * expression.cs (ParameterReference): Added `Block block' argument
8532 (LocalVariableReference, ParameterReference, This): The new
8533 VariableInfo class is now responsible for all the definite
8536 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
8537 IsParameterAssigned, SetParameterAssigned): Removed.
8539 2003-05-18 Martin Baulig <martin@ximian.com>
8541 * typemanager.cs (InitCoreTypes): Try calling
8542 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
8543 the 3-args-version. Corlib now also needs our `void_type'.
8544 (GetMethod): Added overloaded version which takes an optional
8545 `bool report_errors' to allow lookups of optional methods.
8547 2003-05-12 Martin Baulig <martin@ximian.com>
8549 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
8550 only used for locals and not for parameters.
8552 2003-05-12 Miguel de Icaza <miguel@ximian.com>
8554 * support.cs (InternalParameters.ParameterType): Return the
8555 ExternalType of the parameter.
8557 * parameter.cs (Parameter.ExternalType): drop the two arguments,
8560 2003-05-11 Miguel de Icaza <miguel@ximian.com>
8562 * class.cs (MethodData.Define): Do not set the `newslot' on
8563 interface members, if they are also flagged as "override".
8565 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
8566 better code for ++i and i++. This only works for static fields
8567 and local variables.
8569 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
8570 want to pull the DeclSpace out of the builder_to_declspace instead
8571 of the TypeBuilder (like in TypeContainer.FindMembers).
8573 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
8574 instead of LookupTypeContainer. Fixes the crash on .NET for
8575 looking up interface members.
8577 * const.cs: Create our own emit context during the Definition
8578 stage, so that constants are evaluated in the proper context, when
8579 a recursive definition happens.
8581 2003-05-11 Martin Baulig <martin@ximian.com>
8583 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
8584 new block for a switch section.
8585 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
8586 the adding/lookup in the switch block. Fixes #39828.
8588 2003-05-09 Miguel de Icaza <miguel@ximian.com>
8590 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
8591 functionality: I needed to convert the data after I had performed
8592 the add/sub operation into the operands type size.
8594 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
8595 pass the type for the box operation, otherwise the resulting
8596 object would have been of type object.
8598 (BoxedCast): Add constructor to specify the type to box as.
8600 2003-05-07 Miguel de Icaza <miguel@ximian.com>
8602 * iterators.cs: I was reusing the `count' variable inadvertently,
8603 take steps to not allow this to happen.
8605 2003-05-06 Miguel de Icaza <miguel@ximian.com>
8607 * attribute.cs (Attribute.Resolve): Params attributes are encoded
8608 by creating an array at the point where the params starts and
8609 putting all those arguments there, then adjusting the size of the
8612 2003-05-05 Miguel de Icaza <miguel@ximian.com>
8614 * expression.cs (New.AddressOf): Implement interface
8615 IMemoryLocation. This is used when the `new' operator is used in
8616 the context of an invocation to a method on a value type.
8618 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
8621 * namespace.cs: Also check the using aliases here.
8623 * driver.cs: Move the test for using validity after the types have
8624 been entered, so we do a single pass that also includes the using
8627 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
8628 in the regular case. CreateSiblingForFinally is doing extra
8631 * attribute.cs (GetAttributeArgumentExpression): Store the result
8632 on an out value, and use the return value to indicate failure
8633 instead of using null (which is a valid return for Constant.GetValue).
8635 * statement.cs: Perform the analysis flow for the increment
8636 portion after the statement, because this will be the real flow of
8637 execution. Fixes #42385
8639 * codegen.cs (EmitContext.EmitArgument,
8640 EmitContext.EmitStoreArgument): New helper functions when the
8641 RemapToProxy flag is set.
8643 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
8646 Add support for remapping parameters.
8648 * iterators.cs: Propagate parameter values; Store parameter
8649 values in the proxy classes.
8651 2003-05-04 Miguel de Icaza <miguel@ximian.com>
8653 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
8654 need a proxy reference; I do not know what I was thinking
8656 * cs-parser.jay (constructor_initializer): catch another error,
8657 and display nice message.
8659 (field_declaration): catch void field declaration
8660 to flag a better error.
8662 * class.cs (MemberBase.CheckBase): Report an error instead of a
8663 warning if a new protected member is declared in a struct.
8664 (Field.Define): catch the error of readonly/volatile.
8666 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
8668 (FieldExpr.AddressOf): ditto. Catch error where the address of a
8669 volatile variable is taken
8671 2003-05-02 Miguel de Icaza <miguel@ximian.com>
8673 * statement.cs (Fixed.Resolve): Report an error if we are not in
8676 2003-05-01 Miguel de Icaza <miguel@ximian.com>
8678 * typemanager.cs: reuse the code that handles type clashes for
8679 delegates and enumerations.
8681 * class.cs (Report28): Always report.
8683 * expression.cs (EncodeAsAttribute): Allow nulls here.
8685 2003-04-28 Miguel de Icaza <miguel@ximian.com>
8687 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
8688 the functionality for testing whether an expression is valid for
8689 an attribute here. Also handle the case of arrays of elements
8692 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
8693 encoding a linear array into an array of objects that are suitable
8694 to be passed to an CustomAttributeBuilder.
8696 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
8698 * ecore.cs: (FieldExpr): Handle field remapping here.
8700 * iteratators.cs: Pass the instance variable (if the method is an
8701 instance method) to the constructors, so we can access the field
8702 variables on the class.
8704 TODO: Test this with structs. I think the THIS variable on
8705 structs might have to be a pointer, and not a refenrece
8707 2003-04-27 Miguel de Icaza <miguel@ximian.com>
8709 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
8710 local variables to fields in a proxy class.
8712 * iterators.cs (PopulateProxy): Rename our internal fields to
8714 Create a <THIS> field if we are an instance method, so we can
8715 reference our parent container variables.
8716 (MapVariable): Called back from the EmitContext code to enter a
8717 new variable to field mapping into the proxy class (we just create
8721 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
8722 for using the remapped locals to fields.
8724 I placed the code here, because that gives the same semantics to
8725 local variables, and only changes the Emit code.
8727 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
8728 statements inside iterators.
8729 (VariableInfo): Add a FieldBuilder for the cases when we are
8730 remapping local variables to fields in a proxy class
8732 * ecore.cs (SimpleNameResolve): Avoid testing two times for
8733 current_block != null.
8735 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
8736 not cope with strings, as it has been moved to the
8737 TableSwitchEmit. Fixed bug in switch generation.
8739 * expression.cs (New.DoResolve): Provide more context for the user
8740 when reporting an error.
8742 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
8745 * expression.cs (MemberAccess.DoResolve): When we get a type back,
8746 check the permissions for it. Note than in a type-resolution
8747 context the check was already present in DeclSpace.ResolveType,
8748 but was missing from the MemberAccess.
8750 (ArrayCreation.CheckIndices): warn if the user has
8751 more nested levels of expressions, but there are no more
8752 dimensions specified. Avoids crash on bug 41906.
8754 2003-04-26 Miguel de Icaza <miguel@ximian.com>
8756 * statement.cs (Block): replace Implicit bool, for a generic
8758 New flag: `Unchecked'. This is used during the EmitMeta phase
8759 (which is out-of-line with the regular Resolve/Emit process for a
8760 statement, as this is done ahead of time, but still gets a chance
8761 to call constant resolve).
8763 (Block.Flags): new enum for adding a new flag.
8765 (Block.EmitMeta): track the state of unchecked.
8767 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
8768 to enable constant resolution to work there as well.
8770 2003-04-22 Miguel de Icaza <miguel@ximian.com>
8772 * typemanager.cs (ienumerable_type): Also look up
8773 System.Collections.IEnumerable.
8775 2003-04-21 Miguel de Icaza <miguel@ximian.com>
8777 TODO: Test more than one conditional per method.
8779 * class.cs (Indexer.Define): Report the location where the user is
8780 referencing the unsupported feature.
8782 (MethodData): Overload the use of `conditionals' to
8783 minimize the creation of needless ArrayLists. This saves roughly
8784 212kb on my machine.
8786 (Method): Implement the new IIteratorContainer interface.
8787 (Method.SetYields): Implement the method by setting the ModFlags
8788 to contain METHOD_YIELDS.
8790 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
8791 which just got set to null.
8793 * iterators.cs: New file.
8795 (Yield, YieldBreak): New statements.
8797 * statement.cs (Return.Resolve): Flag an error if we are used in
8800 * codegen.cs (InIterator): New flag set if the code is being
8801 compiled in an iterator method.
8803 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
8804 internal modifier, and we just use it to avoid adding extra
8805 fields, as this is seldom used.
8807 * cs-parser.jay: Add yield_statement (yield and yield break).
8809 * driver.cs: New flag -v2 to turn on version 2 features.
8811 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
8812 hashtable when v2 is enabled.
8814 2003-04-20 Miguel de Icaza <miguel@ximian.com>
8816 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
8817 there is already a namespace defined with this name.
8819 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
8820 people upgraded their corlibs.
8822 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
8823 always use fully qualified types, no need to use the compiler
8826 (TypeManager.IsNamespace): Use binarysearch.
8828 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
8829 AddDelegate): I did not quite use the new IsValid API properly: I
8830 have to pass the short-name and the fullname. I was passing only
8831 the basename instead of the fullname sometimes.
8833 (TypeContainer.DefineType): call NamespaceClash.
8835 * interface.cs (Interface.DefineType): use NamespaceClash before
8838 * delegate.cs (Delegate.DefineType): use NamespaceClash before
8841 * enum.cs: (Enum.DefineType): use NamespaceClash before
8844 * typemanager.cs (: 3-line patch that gives us some tasty 11%
8845 speed increase. First, use the negative_hits cache when we get a
8846 negative. Second, add the type with its full original name
8847 instead of the new . and + encoded name (reflection uses + to
8848 separate type from a nested type). Use LookupTypeReflection
8849 directly which bypasses the type->name hashtable (that we already
8850 know does not contain the type.
8852 * decl.cs (DeclSpace.ResolveTypeExpr): track the
8853 location/container type.
8855 * driver.cs: When passing utf8, use directly the UTF8Encoding.
8857 2003-04-19 Miguel de Icaza <miguel@ximian.com>
8859 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
8861 * delegate.cs (NewDelegate.Resolve): Test whether an instance
8862 method is being referenced in the method group from a static
8863 context, and report error 120 if so.
8865 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
8868 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
8869 is created, we create the A namespace).
8871 * cs-parser.jay: A namespace also introduces a DeclarationFound.
8874 2003-04-18 Miguel de Icaza <miguel@ximian.com>
8876 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
8877 invocation to ModuleBuilder.GetType with the same values will
8878 return a new type instance, so we need to cache its return
8881 * expression.cs (Binary.ResolveOperator): Only allow the compare
8882 operators on enums if they are of the same type.
8884 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
8885 types of ValueType on their own case. Before we were giving them
8886 the same treatment as objects.
8888 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
8889 fullname. Short name is used to compare against container name.
8890 Fullname is used to check against defined namespace names.
8892 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
8893 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
8895 (Method.CheckBase): Call parent.
8896 (MemberBase.CheckBase): Check for protected members on sealed
8898 (PropertyBase.CheckBase): Call parent.
8899 (Field.Define): Call parent.
8901 * report.cs: Negative error codes are now mapped to 8000 - code,
8902 so that the display is render more nicely.
8904 * typemanager.cs: Do not use try/catch, instead report a regular
8907 (GetPointerType, GetReferenceType): These methods provide
8908 mechanisms to obtain the T* and T& from a T. We had the code
8909 previously scattered around the code base, and it also used
8910 TypeManager.LookupType that would go through plenty of caches.
8911 This one goes directly to the type source.
8913 In some places we did the Type.GetType followed by
8914 ModuleBuilder.GetType, but not in others, so this unifies the
8917 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
8918 statements now that we have namespace information.
8920 * typemanager.cs (IsNamespace): New method, returns whether the
8921 string presented is a namespace or not.
8923 (ComputeNamespaces): New public entry point, computes the list of
8924 available namespaces, using the GetNamespaces API call in Mono, or
8925 the slower version in MS.NET.
8927 Now before we start the semantic analysis phase, we have a
8928 complete list of namespaces including everything that the user has
8931 Deleted old code to cache namespaces in .nsc files.
8933 2003-04-17 Miguel de Icaza <miguel@ximian.com>
8935 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
8936 class/struct location definition Location for the implicit
8937 constructor location.
8939 (Operator.Define): Use the location of the operator for the
8940 implicit Method definition.
8942 (Constructor.Emit): use the constructor location for the implicit
8943 base initializer constructor.
8945 * ecore.cs: Remove ITypeExpression. This interface is now gone,
8946 and the Expression class now contains two new methods:
8948 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
8949 isolate type lookup from the rest of the resolution process.
8951 Since we use Expressions to hold type definitions due to the way
8952 we parse the input we have historically overloaded Resolve to
8953 perform the Type lookups if a special flag is passed. Now this is
8954 eliminated and two methods take their place.
8956 The differences in the two methods between xStep and xTerminal is
8957 that xStep is involved in our current lookup system that uses
8958 SimpleNames to compose a name, while xTerminal is used just to
8959 catch the case where the simplename lookup failed.
8961 2003-04-16 Miguel de Icaza <miguel@ximian.com>
8963 * expression.cs (ResolveMemberAccess): Remove redundant code.
8964 TypeExpr expressions are always born fully resolved.
8966 * interface.cs (PopulateMethod): Do not lookup the types twice.
8967 We were doing it once during SemanticAnalysis and once during
8970 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
8971 in local variable type definitions, were being returned as a
8972 SimpleName (we decomposed everything into a string), that is
8973 because primary_expression was being used instead of a type in the
8974 grammar (reduce/reduce conflicts).
8976 The part that was wrong is that we converted the expression into a
8977 string (an oversimplification in one hand, compounded with primary
8978 expressions doing string concatenation).
8984 Would return "A.B.C[]" as a SimpleName. This stopped things like
8985 using clauses from working on this particular context. And a type
8986 was being matched directly against "A.B.C[]".
8988 We now use the correct approach, and allow for ComposedCast to be
8989 part of the unary expression. So the "A.B.C []" become a composed
8990 cast of "A.B.C" (as a nested group of MemberAccess with a
8991 SimpleName at the end) plus the rank composition "[]".
8995 2003-04-10 Miguel de Icaza <miguel@ximian.com>
8997 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
8998 for the access level checking.
9000 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
9001 `TypeContainer container', because I kept getting confused when I
9002 was debugging this code.
9004 * expression.cs (Indexers): Instead of tracking getters/setters,
9005 we now track them in parallel. We create one arraylist less, but
9006 most importantly it is possible now for the LValue code to find a
9007 matching get for a set.
9009 (IndexerAccess.DoResolveLValue): Update the code.
9010 GetIndexersForType has been modified already to extract all the
9011 indexers from a type. The code assumed it did not.
9013 Also make the code set the correct return type for the indexer.
9014 This was fixed a long time ago for properties, but was missing for
9015 indexers. It used to be void_type.
9017 (Binary.Emit): Test first for doubles instead of
9018 floats, as they are more common.
9020 (Binary.EmitBranchable): Use the .un version of the branch opcodes
9021 when dealing with floats and the <=, >= operators. This fixes bug
9024 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
9025 to load the array value by emitting a load on the foreach variable
9026 type. This was incorrect.
9028 We now emit the code to load an element using the the array
9029 variable type, and then we emit the conversion operator.
9033 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
9035 * attribute.cs: Avoid allocation of ArrayLists in the common case.
9037 2003-04-09 Miguel de Icaza <miguel@ximian.com>
9039 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
9040 test for protection before we test for signatures.
9042 (MethodSignature.ToString): implement.
9044 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
9045 to the case where we reduced into a LongConstant.
9047 * decl.cs (CheckAccessLevel): If the type is an array, we can not
9048 depend on whether the information is acurrate, because the
9049 Microsoft runtime will always claim that the array type is public,
9050 regardless of the real state.
9052 If the type is a pointer, another problem happens: the type is
9053 reported as non-public in Microsoft.
9055 In both cases we have to call CheckAccessLevel recursively with
9056 the underlying type as the argument to be tested.
9058 2003-04-08 Miguel de Icaza <miguel@ximian.com>
9060 * assign.cs (Assign.Emit): If we are dealing with a compound
9061 assignment expression, we should use the code path that stores the
9062 intermediate result in a temporary value. This fixes #40903.
9064 *expression.cs (Indirection.ToString): Provide ToString method for
9067 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
9069 * class.cs: Null out fields holding references to Block objects so
9070 they can be garbage collected.
9072 * expression.cs (OverloadResolve): Remove unused local.
9074 2003-04-07 Martin Baulig <martin@ximian.com>
9076 * codegen.cs (EmitContext.CurrentFile): New public field.
9077 (EmitContext.Mark): Use the CurrentFile to check whether the
9078 location is in the correct file.
9079 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
9081 2003-04-07 Martin Baulig <martin@ximian.com>
9083 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
9085 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
9086 location. [FIXME: The location argument which gets passed to this
9087 method is sometimes wrong!]
9089 2003-04-07 Nick Drochak <ndrochak@gol.com>
9091 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
9093 2003-04-07 Miguel de Icaza <miguel@ximian.com>
9095 * expression.cs (Indirection.EmitAssign): We were using the
9096 temporary, but returning immediately instead of continuing the
9099 2003-04-06 Martin Baulig <martin@ximian.com>
9101 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
9102 if it's a nested child, but also deriving from the outer class.
9105 * typemanager.cs (IsNestedChildOf): Make this work if it's a
9106 nested child, but also deriving from the outer class. See
9108 (FilterWithClosure): We may access private members of the outer
9109 class if we're a nested child and deriving from the outer class.
9110 (RealMemberLookup): Only set `closure_private_ok' if the
9111 `original_bf' contained BindingFlags.NonPublic.
9113 2003-04-05 Martin Baulig <martin@ximian.com>
9115 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
9116 probe if its a type parameter, and if so, flag an error.
9118 * decl.cs: Move here the SetParameterInfo code from class.cs.
9119 Handle IsGeneric here.
9121 Handle a variety of errors in the parameter info definition.
9123 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
9124 type parameters here.
9126 * cs-parser.jay (class_declaration): report errors for parameters
9129 2003-01-21 Miguel de Icaza <miguel@ximian.com>
9131 * generic.cs: New file, contains support code for generics.
9133 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
9134 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
9136 Update parser for the above removals.
9138 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
9139 now taken care of in the parser.
9141 2003-04-02 Miguel de Icaza <miguel@ximian.com>
9143 * class.cs (Event.Define): Do not allow abstract events to have
9146 2003-04-01 Miguel de Icaza <miguel@ximian.com>
9148 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
9149 block in event declarations.
9151 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
9152 value type, get its address.
9154 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
9155 leaving a class on the stack instead of a boolean value (int
9156 0/1). Change the code so we compare against null, and then the
9157 result against zero.
9159 * class.cs (TypeContainer.GetClassBases): We were checking for the
9160 parent class being sealed too late.
9162 * expression.cs (Binary.Emit): For <= and >= when dealing with
9163 floating point values, use cgt.un and clt.un instead of cgt and
9166 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
9168 * statement.cs: Apply the same optimization as MS: skip the
9169 GetEnumerator returning an IEnumerator, and use the one returning a
9170 CharEnumerator instead. This allows us to avoid the try-finally block
9173 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
9175 * cs-parser.jay: Attributes cannot be applied to
9176 namespaces. Fixes #40473
9178 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9181 (Add*): check if the name is valid using the full name for constants,
9182 fields, properties and events.
9184 2003-03-28 Miguel de Icaza <miguel@ximian.com>
9186 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
9187 char constants to be part of the enumeration.
9189 * expression.cs (Conditional.DoResolve): Add support for operator
9190 true. Implements the missing functionality from 14.12
9192 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
9193 operator true/false as required by the spec.
9195 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
9196 implicit conversion to boolean.
9198 * statement.cs (Statement.ResolveBoolean): A boolean expression is
9199 also one where the type implements `operator true'.
9201 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
9202 get an expression that will invoke operator true based on an
9205 (GetConversionOperators): Removed the hack that called op_True
9208 (Expression.ResolveBoolean): Move this from Statement.
9210 2003-03-17 Miguel de Icaza <miguel@ximian.com>
9212 * ecore.cs (FieldExpr): do not allow initialization of initonly
9213 fields on derived classes
9215 2003-03-13 Martin Baulig <martin@ximian.com>
9217 * statement.cs (Block.Emit): Call ig.BeginScope() and
9218 ig.EndScope() when compiling with debugging info; call
9219 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
9221 2003-03-08 Miguel de Icaza <miguel@ximian.com>
9223 * expression.cs (Indexers): Do not construct immediately, allow
9224 for new members to be appended as we go. Fixes 38143
9226 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9228 * expression.cs: save/restore context when resolving an unchecked
9231 2003-03-05 Miguel de Icaza <miguel@ximian.com>
9233 * cfold.cs: Catch division by zero in modulus operator during
9236 2003-03-03 Miguel de Icaza <miguel@ximian.com>
9238 * interface.cs (Interface.DefineMembers): Avoid defining members
9241 2003-02-27 Miguel de Icaza <miguel@ximian.com>
9243 * driver.cs: handle the +/- options for -noconfig
9245 * statement.cs (Unckeched.Resolve): Also track the state of
9246 unchecked in the Resolve phase.
9248 2003-02-27 Martin Baulig <martin@ximian.com>
9250 * ecore.cs (Expression.MemberLookup): Don't create a
9251 MethodGroupExpr for something which is not a method. Fixes #38291.
9253 2003-02-25 Miguel de Icaza <miguel@ximian.com>
9255 * class.cs (MemberBase.CheckParameters): Also check that the type
9256 is unmanaged if it is a pointer.
9258 * expression.cs (SizeOf.Resolve): Add location information.
9260 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
9261 a managed type is declared.
9263 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
9264 parameter modifiers as well. Fixes bug 38606
9266 * class.cs: Very sad. Am backing out the speed up changes
9267 introduced by the ArrayList -> Array in the TypeContainer, as they
9268 were not actually that much faster, and introduced a bug (no error
9269 reports on duplicated methods).
9271 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
9272 source first, this will guarantee that we have a valid expression
9273 before calling in lower levels functions that will require a
9274 resolved object. Then use this original_source in the
9275 target.ResolveLValue instead of the original source that was
9278 Another change. Use target.Resolve instead of LValueResolve.
9279 Although we are resolving for LValues, we will let the Assign code
9280 take care of that (it will be called again from Resolve). This
9281 basically allows code like this:
9283 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
9284 class Y { void A (X x) { x [0] += o; }
9286 The problem was that the indexer was trying to resolve for
9287 set_Item (idx, object o) and never finding one. The real set_Item
9288 was set_Item (idx, X). By delaying the process we get the right
9293 2003-02-23 Martin Baulig <martin@ximian.com>
9295 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
9296 while calling DoEmit ().
9298 * codegen.cs (EmitContext.Mark): Don't mark locations in other
9299 source files; if you use the #line directive inside a method, the
9300 compiler stops emitting line numbers for the debugger until it
9301 reaches the end of the method or another #line directive which
9302 restores the original file.
9304 2003-02-23 Martin Baulig <martin@ximian.com>
9306 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
9308 2003-02-23 Martin Baulig <martin@ximian.com>
9310 * statement.cs (Block.AddChildVariableNames): We need to call this
9311 recursively, not just for our immediate children.
9313 2003-02-23 Martin Baulig <martin@ximian.com>
9315 * class.cs (Event.Define): Always make the field private, like csc does.
9317 * typemanager.cs (TypeManager.RealMemberLookup): Make events
9318 actually work, fixes bug #37521.
9320 2003-02-23 Miguel de Icaza <miguel@ximian.com>
9322 * delegate.cs: When creating the various temporary "Parameters"
9323 classes, make sure that we call the ComputeAndDefineParameterTypes
9324 on those new parameters (just like we do with the formal ones), to
9325 allow them to be resolved in the context of the DeclSpace.
9327 This fixes the bug that Dick observed in Bugzilla #38530.
9329 2003-02-22 Miguel de Icaza <miguel@ximian.com>
9331 * expression.cs (ResolveMemberAccess): When resolving a constant,
9332 do not attempt to pull a constant if the value was not able to
9333 generate a valid constant.
9335 * const.cs (LookupConstantValue): Do not report more errors than required.
9337 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9339 * expression.cs: fixes bug #38328.
9341 2003-02-18 Miguel de Icaza <miguel@ximian.com>
9343 * class.cs: Changed all the various members that can be part of a
9344 class from being an ArrayList to be an Array of the right type.
9345 During the DefineType type_list, interface_list, delegate_list and
9346 enum_list are turned into types, interfaces, delegates and enums
9349 And during the member population, indexer_list, event_list,
9350 constant_list, field_list, instance_constructor_list, method_list,
9351 operator_list and property_list are turned into their real arrays.
9353 Although we could probably perform this operation earlier, for
9354 good error reporting we need to keep the lists and remove the
9355 lists for longer than required.
9357 This optimization was triggered by Paolo profiling the compiler
9358 speed on the output of `gen-sample-program.pl' perl script.
9360 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
9361 not crash in methods like MemberLookupFailed that use this field.
9363 This problem arises when the compiler fails to resolve a type
9364 during interface type definition for example.
9366 2003-02-18 Miguel de Icaza <miguel@ximian.com>
9368 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
9369 inherit from System.Object, so we have to stop at null, not only
9370 when reaching System.Object.
9372 2003-02-17 Miguel de Icaza <miguel@ximian.com>
9374 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
9375 DeclaredOnly because the parent indexer might have had a different
9376 name, but did not loop until the top of the hierarchy was reached.
9378 The problem this one fixes is 35492: when a class implemented an
9379 indexer from an interface, we were getting the interface method
9380 (which was abstract) and we were flagging an error (can not invoke
9383 This also keeps bug 33089 functioning, and test-148 functioning.
9385 * typemanager.cs (IsSpecialMethod): The correct way of figuring
9386 out if a method is special is to see if it is declared in a
9387 property or event, or whether it is one of the predefined operator
9388 names. This should fix correctly #36804.
9390 2003-02-15 Miguel de Icaza <miguel@ximian.com>
9392 The goal here is to remove the dependency on EmptyCast.Peel ().
9393 Killing it completely.
9395 The problem is that currently in a number of places where
9396 constants are expected, we have to "probe" for an EmptyCast, and
9397 Peel, which is not the correct thing to do, as this will be
9398 repetitive and will likely lead to errors.
9400 The idea is to remove any EmptyCasts that are used in casts that
9401 can be reduced to constants, so we only have to cope with
9404 This bug hunt was triggered by Bug 37363 and the desire to remove
9405 the duplicate pattern where we were "peeling" emptycasts to check
9406 whether they were constants. Now constants will always be
9409 * ecore.cs: Use an enumconstant here instead of wrapping with
9412 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
9413 throwing me off. By handling this we can get rid of a few hacks.
9415 * statement.cs (Switch): Removed Peel() code.
9417 2003-02-14 Miguel de Icaza <miguel@ximian.com>
9419 * class.cs: Location information for error 508
9421 * expression.cs (New.DoResolve): Add a guard against double
9422 resolution of an expression.
9424 The New DoResolve might be called twice when initializing field
9425 expressions (see EmitFieldInitializers, the call to
9426 GetInitializerExpression will perform a resolve on the expression,
9427 and later the assign will trigger another resolution
9429 This leads to bugs (#37014)
9431 * delegate.cs: The signature for EndInvoke should contain any ref
9432 or out parameters as well. We were not doing this in the past.
9434 * class.cs (Field.Define): Do not overwrite the type definition
9435 inside the `volatile' group. Turns out that volatile enumerations
9436 were changing the type here to perform a validity test, which
9439 2003-02-12 Miguel de Icaza <miguel@ximian.com>
9441 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
9442 and structs, we do not want to load the instance variable
9444 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
9445 enum_type has to be handled like an object reference (implicit
9446 conversions exists from this to object), but the regular IsClass
9447 and IsValueType tests will never return true for this one.
9449 Also we use TypeManager.IsValueType instead of type.IsValueType,
9450 just for consistency with the rest of the code (this is only
9451 needed if we ever use the construct exposed by test-180.cs inside
9452 corlib, which we dont today).
9454 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
9456 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
9459 2003-02-09 Martin Baulig <martin@ximian.com>
9461 * namespace.cs (Namespace..ctor): Added SourceFile argument.
9462 (Namespace.DefineNamespaces): New static public method; this is
9463 called when we're compiling with debugging to add all namespaces
9466 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
9467 pass it to the Namespace's .ctor.
9469 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
9470 and MethodBase arguments; pass the namespace ID to the symwriter;
9471 pass the MethodBase instead of the token to the symwriter.
9472 (SymbolWriter.DefineNamespace): New method to add a namespace to
9475 2003-02-09 Martin Baulig <martin@ximian.com>
9477 * symbolwriter.cs: New file. This is a wrapper around
9478 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
9479 methods here in near future.
9481 2003-02-09 Martin Baulig <martin@ximian.com>
9483 * codegen.cs (EmitContext.Mark): Just pass the arguments to
9484 ILGenerator.MarkSequencePoint() which are actually used by the
9487 2003-02-09 Martin Baulig <martin@ximian.com>
9489 * location.cs (SourceFile): New public sealed class. This
9490 contains the name and an index which is used in the location's token.
9491 (Location): Reserve an appropriate number of bits in the token for
9492 the source file instead of walking over that list, this gives us a
9493 really huge performance improvement when compiling with debugging.
9495 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
9496 `SourceFile' argument instead of a string.
9497 (Driver.ProcessFile): Add all the files via Location.AddFile(),
9498 but don't parse/tokenize here, we need to generate the list of all
9499 source files before we do that.
9500 (Driver.ProcessFiles): New static function. Parses/tokenizes all
9503 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
9504 instead of a string.
9506 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
9509 2003-02-09 Martin Baulig <martin@ximian.com>
9511 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
9512 filename on `#line default'.
9514 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
9516 * statement.cs: don't clear the pinned var when the fixed statement
9517 returns from the method (fixes bug#37752).
9519 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
9521 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
9524 2003-02-07 Martin Baulig <martin@ximian.com>
9526 * driver.cs: Removed the `--debug-args' command line argument.
9528 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
9529 automatically by the AsssemblyBuilder.
9530 (CodeGen.InitializeSymbolWriter): We don't need to call any
9531 initialization function on the symbol writer anymore. This method
9532 doesn't take any arguments.
9534 2003-02-03 Miguel de Icaza <miguel@ximian.com>
9536 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
9537 from referenced assemblies as well.
9539 2003-02-02 Martin Baulig <martin@ximian.com>
9541 * class.cs (MethodData.Emit): Generate debugging info for external methods.
9543 2003-02-02 Martin Baulig <martin@ximian.com>
9545 * class.cs (Constructor.Emit): Open the symbol writer before
9546 emitting the constructor initializer.
9547 (ConstructorInitializer.Emit): Call ec.Mark() to allow
9548 single-stepping through constructor initializers.
9550 2003-01-30 Miguel de Icaza <miguel@ximian.com>
9552 * class.cs: Handle error 549: do not allow virtual methods in
9555 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
9557 * decl.cs: Check access levels when resolving types
9559 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
9561 * statement.cs: Add parameters and locals set in catch blocks that might
9562 return to set vector
9564 2003-01-29 Miguel de Icaza <miguel@ximian.com>
9566 * class.cs (Operator): Set the SpecialName flags for operators.
9568 * expression.cs (Invocation.DoResolve): Only block calls to
9569 accessors and operators on SpecialName methods.
9571 (Cast.TryReduce): Handle conversions from char constants.
9574 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
9576 * statement.cs: small memory and time optimization in FlowBranching.
9578 2003-01-28 Pedro Mart <yoros@wanadoo.es>
9580 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
9581 problem that the last fix but in the other sid (Set).
9583 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
9584 access when there is no indexer in the hierarchy.
9586 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
9588 * class.cs: Combine some if statements.
9590 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9592 * driver.cs: fixed bug #37187.
9594 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
9596 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
9597 any indexer, it's needed to build a list with all the indexers in the
9598 hierarchy (AllGetters), else we have problems. Fixes #35653.
9600 2003-01-23 Miguel de Icaza <miguel@ximian.com>
9602 * class.cs (MethodData.Define): It is wrong for an interface
9603 implementation to be static in both cases: explicit and implicit.
9604 We were only handling this in one case.
9606 Improve the if situation there to not have negations.
9608 * class.cs (Field.Define): Turns out that we do not need to check
9609 the unsafe bit on field definition, only on usage. Remove the test.
9611 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9613 * driver.cs: use assembly.Location instead of Codebase (the latest
9614 patch made mcs fail when using MS assemblies).
9616 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
9618 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
9619 get the path to *corlib.dll.
9621 2003-01-21 Nick Drochak <ndrochak@gol.com>
9625 * typemanager.cs: Remove compiler warnings
9627 2003-01-20 Duncan Mak <duncan@ximian.com>
9629 * AssemblyInfo.cs: Bump the version number to 0.19.
9631 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9633 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
9635 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
9637 * class.cs (Constructor::Emit): Emit debugging info for constructors.
9639 2003-01-17 Miguel de Icaza <miguel@ximian.com>
9641 * cs-parser.jay: Small fix: we were not comparing the constructor
9642 name correctly. Thanks to Zoltan for the initial pointer.
9644 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
9646 * cs-tokenizer.cs: Set file name when specified with #line
9648 2003-01-15 Miguel de Icaza <miguel@ximian.com>
9650 * cs-parser.jay: Only perform the constructor checks here if we
9651 are named like the class; This will help provider a better
9652 error. The constructor path is taken when a type definition is
9653 not found, but most likely the user forgot to add the type, so
9654 report that rather than the constructor error.
9656 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
9658 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
9661 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
9663 * cs-parser.jay: Add cleanup call.
9665 2003-01-13 Duncan Mak <duncan@ximian.com>
9667 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
9668 consistent with other methods.
9670 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
9672 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
9674 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
9676 * attribute.cs: only set GuidAttr to true when we have a
9679 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9683 * typemanager.cs: fixes to allow mcs compile corlib with the new
9684 Type.IsSubclassOf fix.
9686 2003-01-08 Miguel de Icaza <miguel@ximian.com>
9688 * expression.cs (LocalVariableReference.DoResolve): Classify a
9689 constant as a value, not as a variable. Also, set the type for
9692 * cs-parser.jay (fixed_statement): take a type instead of a
9693 pointer_type, so we can produce a better error message later.
9695 * statement.cs (Fixed.Resolve): Flag types that are not pointers
9698 (For.DoEmit): Make inifinite loops have a
9699 non-conditional branch back.
9701 (Fixed.DoEmit): First populate the pinned variables, then emit the
9702 statement, then clear the variables. Before I was emitting the
9703 code once for each fixed piece.
9706 2003-01-08 Martin Baulig <martin@ximian.com>
9708 * statement.cs (FlowBranching.MergeChild): A break in a
9709 SWITCH_SECTION does not leave a loop. Fixes #36155.
9711 2003-01-08 Martin Baulig <martin@ximian.com>
9713 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
9714 lives in the same number space than `param_map'. Fixes #36154.
9716 2003-01-07 Miguel de Icaza <miguel@ximian.com>
9718 * cs-parser.jay (constructor_declaration): Set the
9719 Constructor.ModFlags before probing for it. This makes the
9720 compiler report 514, 515 and 132 (the code was there, but got
9723 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
9724 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
9725 (GotoCase.Resolve): Set `Returns' to ALWAYS.
9727 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
9729 * enum.cs: create the enum static fields using the enum type.
9731 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
9733 * class.cs: don't try to create the ParamBuilder for the return
9734 type if it's not needed (and handle it breaking for the ms runtime
9737 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
9739 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
9741 2002-12-29 Miguel de Icaza <miguel@ximian.com>
9743 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
9744 the command. This showed up while compiling the JANET source
9745 code, which used \r as its only newline separator.
9747 2002-12-28 Miguel de Icaza <miguel@ximian.com>
9749 * class.cs (Method.Define): If we are an operator (because it
9750 reuses our code), then set the SpecialName and HideBySig. #36128
9752 2002-12-22 Miguel de Icaza <miguel@ximian.com>
9754 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
9755 exception, report error 120 `object reference required'.
9757 * driver.cs: Add --pause option, used during to measure the size
9758 of the process as it goes with --timestamp.
9760 * expression.cs (Invocation.DoResolve): Do not allow methods with
9761 SpecialName to be invoked.
9763 2002-12-21 Miguel de Icaza <miguel@ximian.com>
9765 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
9766 number before adding it.
9768 2002-12-21 Ravi Pratap <ravi@ximian.com>
9770 * ecore.cs (StandardImplicitConversion): When in an unsafe
9771 context, we allow conversion between void * to any other pointer
9772 type. This fixes bug #35973.
9774 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
9776 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
9777 is not thrown when extensionless outputs are used
9779 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9781 * rootcontext.cs: fixed compilation of corlib.
9783 2002-12-19 Miguel de Icaza <miguel@ximian.com>
9785 * attribute.cs (Attributes.Contains): Add new method.
9787 * class.cs (MethodCore.LabelParameters): if the parameter is an
9788 `out' parameter, check that no attribute `[In]' has been passed.
9790 * enum.cs: Handle the `value__' name in an enumeration.
9792 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
9794 * decl.cs: Added special case to allow overrides on "protected
9797 2002-12-18 Ravi Pratap <ravi@ximian.com>
9799 * attribute.cs (Attributes.AddAttributeSection): Rename to this
9800 since it makes much more sense.
9802 (Attributes.ctor): Don't require a Location parameter.
9804 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
9806 * attribute.cs (ApplyAttributes): Remove extra Location parameters
9807 since we already have that information per attribute.
9809 * everywhere : make appropriate changes.
9811 * class.cs (LabelParameters): Write the code which actually
9812 applies attributes to the return type. We can't do this on the MS
9813 .NET runtime so we flag a warning in the case an exception is
9816 2002-12-18 Miguel de Icaza <miguel@ximian.com>
9818 * const.cs: Handle implicit null conversions here too.
9820 2002-12-17 Ravi Pratap <ravi@ximian.com>
9822 * class.cs (MethodCore.LabelParameters): Remove the extra
9823 Type [] parameter since it is completely unnecessary. Instead
9824 pass in the method's attributes so that we can extract
9825 the "return" attribute.
9827 2002-12-17 Miguel de Icaza <miguel@ximian.com>
9829 * cs-parser.jay (parse): Use Report.Error to flag errors instead
9830 of ignoring it and letting the compile continue.
9832 * typemanager.cs (ChangeType): use an extra argument to return an
9833 error condition instead of throwing an exception.
9835 2002-12-15 Miguel de Icaza <miguel@ximian.com>
9837 * expression.cs (Unary.TryReduce): mimic the code for the regular
9838 code path. Perform an implicit cast in the cases where we can
9839 implicitly convert to one of the integral types, and then reduce
9840 based on that constant. This fixes bug #35483.
9842 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9844 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
9846 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9848 * namespace.cs: fixed bug #35489.
9850 2002-12-12 Miguel de Icaza <miguel@ximian.com>
9852 * class.cs: Remove some dead code.
9854 * cs-parser.jay: Estimate the number of methods needed
9855 (RootContext.MethodCount);
9857 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
9858 numbers instead of StringBuilders.
9860 * support.cs (PtrHashtable): Add constructor with initial size;
9861 We can now reduce reallocations of the method table.
9863 2002-12-10 Ravi Pratap <ravi@ximian.com>
9865 * attribute.cs (ApplyAttributes): Keep track of the emitted
9866 attributes on a per-target basis. This fixes bug #35413.
9868 2002-12-10 Miguel de Icaza <miguel@ximian.com>
9870 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
9871 default to the Windows 1252 encoding.
9873 (UnixParseOption): Support version, thanks to Alp for the missing
9876 * AssemblyInfo.cs: Add nice assembly information.
9878 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
9881 * cs-parser.jay: Allow a trailing comma before the close bracked
9882 in the attribute_section production.
9884 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
9885 address of the instance was being taken, I will take this out,
9886 because we take the address of the object immediately here.
9888 2002-12-09 Ravi Pratap <ravi@ximian.com>
9890 * typemanager.cs (AreMultipleAllowed): Take care of the most
9891 obvious case where attribute type is not in the current assembly -
9894 2002-12-08 Miguel de Icaza <miguel@ximian.com>
9896 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
9897 definitions, instead of doing that afterwards.
9899 Also we use a nice little hack, depending on the constructor, we
9900 know if we are a "composed" name or a simple name. Hence, we
9901 avoid the IndexOf test, and we avoid
9903 * codegen.cs: Add code to assist in a bug reporter to track down
9904 the source of a compiler crash.
9906 2002-12-07 Ravi Pratap <ravi@ximian.com>
9908 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
9909 types have been emitted for a given element and flag an error
9910 if something which does not have AllowMultiple set is used more
9913 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
9914 attribute types and their corresponding AllowMultiple properties
9916 (AreMultipleAllowed): Check the property for a given type.
9918 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
9919 property in the case we have a TypeContainer.
9921 (Attributes.AddAttribute): Detect duplicates and just skip on
9922 adding them. This trivial fix catches a pretty gross error in our
9923 attribute emission - global attributes were being emitted twice!
9925 Bugzilla bug #33187 is now fixed.
9927 2002-12-06 Miguel de Icaza <miguel@ximian.com>
9929 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
9932 * expression.cs (Binary.ResolveOperator): I can only use the
9933 Concat (string, string, string) and Concat (string, string,
9934 string, string) if the child is actually a concatenation of
9937 2002-12-04 Miguel de Icaza <miguel@ximian.com>
9939 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
9940 context where we need a 2-character lookahead.
9942 * pending.cs (PendingImplementation): Rework so we can keep track
9943 of interface types all the time, and flag those which were
9944 implemented by parents as optional.
9946 2002-12-03 Miguel de Icaza <miguel@ximian.com>
9948 * expression.cs (Binary.ResolveOperator): Use
9949 String.Concat(string,string,string) or
9950 String.Concat(string,string,string,string) when possible.
9952 * typemanager: More helper methods.
9955 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
9957 * pending.cs: remove the bogus return from GetMissingInterfaces()
9958 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
9960 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9962 * namespace.cs: avoid duplicated 'using xxx' being added to
9963 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
9964 when we get more than one 'using' statement for the same namespace.
9965 Report a CS0105 warning for it.
9967 2002-11-30 Miguel de Icaza <miguel@ximian.com>
9969 * cs-tokenizer.cs (consume_identifier): use read directly, instead
9970 of calling getChar/putback, uses internal knowledge of it.
9972 (xtoken): Reorder tokenizer so most common patterns are checked
9973 first. This reduces the compilation time in another 5% (from 8.11s
9974 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
9976 The parsing time is 22% of the compilation in mcs, and from that
9977 64% is spent on the tokenization process.
9979 I tried using a binary search for keywords, but this is slower
9980 than the hashtable. Another option would be to do a couple of
9983 * Not use a StringBuilder, instead use an array of chars,
9984 with a set value. Notice that this way we could catch
9985 the 645 error without having to do it *afterwards*.
9987 * We could write a hand-parser to avoid the hashtable
9988 compares altogether.
9990 The identifier consumption process takes 37% of the tokenization
9991 time. Another 15% is spent on is_number. 56% of the time spent
9992 on is_number is spent on Int64.Parse:
9994 * We could probably choose based on the string length to
9995 use Int32.Parse or Int64.Parse and avoid all the 64-bit
9998 Another 3% is spend on wrapping `xtoken' in the `token' function.
10000 Handle 0xa0 as whitespace (#34752)
10002 2002-11-26 Miguel de Icaza <miguel@ximian.com>
10004 * typemanager.cs (IsCLRType): New routine to tell whether a type
10005 is one of the builtin types.
10007 Maybe it needs to use TypeCodes to be faster. Maybe we could use
10008 typecode in more places instead of doing pointer comparissions.
10009 We could leverage some knowledge about the way the typecodes are
10012 New code to cache namespaces in assemblies, it is currently not
10013 invoked, to be used soon.
10015 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
10017 * expression.cs (Binary.ResolveOperator): specially handle
10018 strings, and do not perform user-defined operator overloading for
10021 2002-11-24 Miguel de Icaza <miguel@ximian.com>
10023 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
10024 internalcall as it is a pretty simple operation; Avoid whenever
10025 possible to call Char.IsLetter.
10027 (consume_identifier): Cut by half the number of
10028 hashtable calls by merging the is_keyword and GetKeyword behavior.
10030 Do not short-circuit, because if we do, we
10031 report errors (ie, #if false && true would produce an invalid
10035 2002-11-24 Martin Baulig <martin@ximian.com>
10037 * expression.cs (Cast.TryReduce): If we're in checked syntax,
10038 check constant ranges and report a CS0221. Fixes #33186.
10040 2002-11-24 Martin Baulig <martin@ximian.com>
10042 * cs-parser.jay: Make this work for uninitialized variable
10043 declarations in the `for' initializer. Fixes #32416.
10045 2002-11-24 Martin Baulig <martin@ximian.com>
10047 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
10048 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
10050 2002-11-24 Martin Baulig <martin@ximian.com>
10052 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
10053 argument; if true, we also check for user-defined conversions.
10054 This is only needed if both arguments are of a user-defined type.
10055 Fixes #30443, added test-175.cs.
10056 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
10058 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
10060 2002-11-24 Martin Baulig <martin@ximian.com>
10062 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
10063 function to get the store opcode.
10064 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
10065 only emit the Ldelema if the store opcode is Stobj. You must run
10066 both test-34 and test-167 to test this. Fixes #34529.
10068 2002-11-23 Martin Baulig <martin@ximian.com>
10070 * ecore.cs (Expression.MemberLookup): Added additional
10071 `qualifier_type' argument which is used when we're being called
10072 from MemberAccess.DoResolve() and null if we're called from a
10074 (Expression.MemberLookupFailed): New method to report errors; this
10075 does the CS1540 check and reports the correct error message.
10077 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
10078 argument for the CS1540 check and redone the way how we're dealing
10079 with private members. See the comment in the source code for details.
10080 (FilterWithClosure): Reverted this back to revision 1.197; renamed
10081 `closure_start_type' to `closure_qualifier_type' and check whether
10082 it's not null. It was not this filter being broken, it was just
10083 being called with the wrong arguments.
10085 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
10086 and pass it the correct `qualifier_type'; this also does the error
10089 2002-11-22 Miguel de Icaza <miguel@ximian.com>
10091 * expression.cs (Invocation.EmitParams): If the we are dealing
10092 with a non-built-in value type, load its address as well.
10094 (ArrayCreation): Use a a pretty constant instead
10095 of the hardcoded value 2. Use 6 instead of 2 for the number of
10096 static initializers.
10098 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
10099 because they are not really value types, just glorified integers.
10101 * driver.cs: Do not append .exe, the CSC compiler does not do it.
10103 * ecore.cs: Remove redundant code for enumerations, make them use
10104 the same code path as everything else, fixes the casting issue
10105 with enumerations in Windows.Forms.
10107 * attribute.cs: Do only cast to string if it is a string, the
10108 validation happens later.
10110 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
10111 people upgrade their corlibs.
10113 * ecore.cs: Oops, enumerations were not following the entire code path
10115 2002-11-21 Miguel de Icaza <miguel@ximian.com>
10117 * typemanager.cs (FilterWithClosure): Commented out the test for
10118 1540 in typemanager.cs, as it has problems when accessing
10119 protected methods from a parent class (see test-174.cs).
10121 * attribute.cs (Attribute.ValidateGuid): new method.
10122 (Attribute.Resolve): Use above.
10124 2002-11-19 Miguel de Icaza <miguel@ximian.com>
10126 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
10128 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
10129 handling for enumerations, as we only needed the TypeContainer
10130 functionality to begin with (this is required for the fix below to
10131 work for enums that reference constants in a container class for
10134 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
10136 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
10137 a valid TypeBuilder to perform lookups on.o
10139 * class.cs (InheritableMemberSignatureCompare): Use true in the
10140 call to GetGetMethod and GetSetMethod, because we are comparing
10141 the signature, and we need to get the methods *even* if they are
10144 (PropertyBase.CheckBase): ditto.
10146 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
10147 GotoCase.Resolve): Use Peel on EmpytCasts.
10149 * ecore.cs (EmptyCast): drop child, add Peel method.
10151 2002-11-17 Martin Baulig <martin@ximian.com>
10153 * ecore.cs (EmptyCast.Child): New public property.
10155 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
10156 label resolved to an EmptyCast. Fixes #34162.
10157 (GotoCase.Resolve): Likewise.
10158 (Block.EmitMeta): Likewise.
10160 2002-11-17 Martin Baulig <martin@ximian.com>
10162 * expression.cs (Invocation.BetterConversion): Prefer int over
10163 uint; short over ushort; long over ulong for integer literals.
10164 Use ImplicitConversionExists instead of StandardConversionExists
10165 since we also need to check for user-defined implicit conversions.
10166 Fixes #34165. Added test-173.cs.
10168 2002-11-16 Martin Baulig <martin@ximian.com>
10170 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
10171 with the `true' and `false' literals. Fixes #33151.
10173 2002-11-16 Martin Baulig <martin@ximian.com>
10175 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
10176 October 22nd; don't do the cs1540 check for static members.
10178 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
10179 now using our own filter here and doing the cs1540 check again.
10181 2002-11-16 Martin Baulig <martin@ximian.com>
10183 * support.cs (InternalParameters): Don't crash if we don't have
10184 any fixed parameters. Fixes #33532.
10186 2002-11-16 Martin Baulig <martin@ximian.com>
10188 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
10189 when looking up static methods to make this work on Windows.
10192 2002-11-16 Martin Baulig <martin@ximian.com>
10194 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
10195 a setter rather than using PropertyInfo.CanWrite.
10197 2002-11-15 Nick Drochak <ndrochak@gol.com>
10199 * class.cs: Allow acces to block member by subclasses. Fixes build
10202 2002-11-14 Martin Baulig <martin@ximian.com>
10204 * class.cs (Constructor.Emit): Added the extern/block check.
10207 2002-11-14 Martin Baulig <martin@ximian.com>
10209 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
10210 iteration while looking for indexers, this is needed because the
10211 indexer may have a different name in our base classes. Fixed the
10212 error reporting (no indexers at all, not get accessor, no
10213 overloaded match). Fixes bug #33089.
10214 (IndexerAccess.DoResolveLValue): Likewise.
10216 2002-11-14 Martin Baulig <martin@ximian.com>
10218 * class.cs (PropertyBase.CheckBase): Make this work for multiple
10219 indexers. Fixes the first part of bug #33089.
10220 (MethodSignature.InheritableMemberSignatureCompare): Added support
10223 2002-11-13 Ravi Pratap <ravi@ximian.com>
10225 * attribute.cs (Attribute.Resolve): Catch the
10226 NullReferenceException and report it since it isn't supposed to
10229 2002-11-12 Miguel de Icaza <miguel@ximian.com>
10231 * expression.cs (Binary.EmitBranchable): Also handle the cases for
10232 LogicalOr and LogicalAnd that can benefit from recursively
10233 handling EmitBranchable. The code now should be nice for Paolo.
10235 2002-11-08 Miguel de Icaza <miguel@ximian.com>
10237 * typemanager.cs (LookupType): Added a negative-hit hashtable for
10238 the Type lookups, as we perform quite a number of lookups on
10239 non-Types. This can be removed once we can deterministically tell
10240 whether we have a type or a namespace in advance.
10242 But this might require special hacks from our corlib.
10246 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
10247 and double which avoids a conversion from an integer to a double.
10249 * expression.cs: tiny optimization, avoid calling IsConstant,
10250 because it effectively performs the lookup twice.
10252 2002-11-06 Miguel de Icaza <miguel@ximian.com>
10254 But a bogus return here to keep the semantics of the old code
10255 until the Mono runtime is fixed.
10257 * pending.cs (GetMissingInterfaces): New method used to remove all
10258 the interfaces that are already implemented by our parent
10259 classes from the list of pending methods.
10261 * interface.cs: Add checks for calls after ResolveTypeExpr.
10263 2002-11-05 Miguel de Icaza <miguel@ximian.com>
10265 * class.cs (Class.Emit): Report warning 67: event not used if the
10266 warning level is beyond 3.
10268 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
10269 being a NullLiteral.
10271 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
10274 * class.cs (TypeContainer.GetClassBases): Cover a missing code
10275 path that might fail if a type can not be resolved.
10277 * expression.cs (Binary.Emit): Emit unsigned versions of the
10280 * driver.cs: use error 5.
10282 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
10284 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
10286 2002-11-01 Miguel de Icaza <miguel@ximian.com>
10288 * cs-parser.jay (switch_section): A beautiful patch from Martin
10289 Baulig that fixed 33094.
10291 2002-10-31 Miguel de Icaza <miguel@ximian.com>
10293 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
10294 Check whether the base is abstract and report an error if so.
10296 * expression.cs (IndexerAccess.DoResolveLValue,
10297 IndexerAccess.DoResolve): ditto.
10299 (Invocation.DoResolve): ditto.
10301 (Invocation.FullMethodDesc): Improve the report string.
10303 * statement.cs (Block): Eliminate IsVariableDefined as it is
10304 basically just a wrapper for GetVariableInfo.
10306 * ecore.cs (SimpleName): Use new
10308 * support.cs (ReflectionParamter.ParameterType): We unwrap the
10309 type, as we return the actual parameter ref/unref state on a
10312 2002-10-30 Miguel de Icaza <miguel@ximian.com>
10314 * support.cs: Return proper flags REF/OUT fixing the previous
10317 * expression.cs: Reverted last patch, that was wrong. Is_ref is
10318 not used to mean `ref' but `ref or out' in ParameterReference
10320 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
10321 full type signature instead of calling TypeManger.CSharpName
10324 * support.cs (InternalParameters.ParameterDesc): Do not compare
10325 directly to the modflags, because REF/OUT will actually be bitsets
10328 * delegate.cs (VerifyMethod): Check also the modifiers.
10330 * cs-tokenizer.cs: Fix bug where floating point values with an
10331 exponent where a sign was missing was ignored.
10333 * driver.cs: Allow multiple assemblies to be specified in a single
10336 2002-10-28 Miguel de Icaza <miguel@ximian.com>
10338 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
10339 because identifiers after a parenthesis would end up in this kind
10340 of production, and we needed to desamiguate it for having casts
10343 (UserDefinedType *) xxx
10345 2002-10-24 Miguel de Icaza <miguel@ximian.com>
10347 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
10348 we should set on the Bindingflags.NonPublic, but not turn on
10349 private_ok. private_ok controls whether a Private member is
10350 returned (this is chekced on the filter routine), while the
10351 BindingFlags.NonPublic just controls whether private/protected
10352 will be allowed. This fixes the problem part of the problem of
10353 private properties being allowed to be used in derived classes.
10355 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
10356 so we can call the children DoResolveLValue method (this will
10357 properly signal errors on lvalue assignments to base properties)
10359 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
10360 getter are null, and we have a property info, we know that this
10361 happened because the lookup failed, so we report an error 122 for
10362 protection level violation.
10364 We also silently return if setter and getter are null in the
10365 resolve functions, this condition only happens if we have flagged
10366 the error before. This is the other half of the problem.
10368 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
10369 not have accessibility information, that is why we were returning
10370 true in the filter function in typemanager.cs.
10372 To properly report 122 (property is inaccessible because of its
10373 protection level) correctly, we report this error in ResolveAccess
10374 by failing if both the setter and the getter are lacking (ie, the
10377 DoResolve and DoLResolve have been modified to check for both
10378 setter/getter being null and returning silently, the reason being
10379 that I did not want to put the knowledge about this error in upper
10382 int old = Report.Errors;
10383 x = new PropertyExpr (...);
10384 if (old != Report.Errors)
10389 So the property expr is returned, but it is invalid, so the error
10390 will be flagged during the resolve process.
10392 * class.cs: Remove InheritablePropertySignatureCompare from the
10393 class, as we no longer depend on the property signature to compute
10394 whether it is possible to implement a method or not.
10396 The reason is that calling PropertyInfo.GetGetMethod will return
10397 null (in .NET, in Mono it works, and we should change this), in
10398 cases where the Get Method does not exist in that particular
10403 class X { public virtual int A { get { return 1; } } }
10405 class Z : Y { public override int A { get { return 2; } } }
10407 Would fail in Z because the parent (Y) would not have the property
10408 defined. So we avoid this completely now (because the alternative
10409 fix was ugly and slow), and we now depend exclusively on the
10412 (PropertyBase.CheckBase): Use a method-base mechanism to find our
10413 reference method, instead of using the property.
10415 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
10416 routines are gone now.
10418 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
10419 names, they were incorrectly named.
10421 * cs-tokenizer.cs: Return are more gentle token on failure.
10423 * pending.cs (PendingImplementation.InterfaceMethod): This routine
10424 had an out-of-sync index variable, which caused it to remove from
10425 the list of pending methods the wrong method sometimes.
10427 2002-10-22 Miguel de Icaza <miguel@ximian.com>
10429 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
10430 CanWrite, because those refer to this particular instance of the
10431 property, and do not take into account the fact that we can
10432 override single members of a property.
10434 Constructor requires an EmitContext. The resolution process does
10435 not happen here, but we need to compute the accessors before,
10436 because the resolution does not always happen for properties.
10438 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
10439 subclass, before we did not update this flag, but we did update
10442 (GetAccessors): Drop this routine, as it did not work in the
10443 presence of partially overwritten set/get methods.
10445 Notice that this broke the cs1540 detection, but that will require
10448 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10452 * driver.cs: issue a warning instead of an error if we don't support
10453 debugging for the platform. Also ignore a couple of errors that may
10454 arise when trying to write the symbols. Undo my previous patch.
10456 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10458 * driver.cs: ignore /debug switch except for Unix platforms.
10460 2002-10-23 Nick Drochak <ndrochak@gol.com>
10462 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
10464 2002-10-21 Miguel de Icaza <miguel@ximian.com>
10466 * driver.cs: Do not make mcs-debug conditional, so we do not break
10467 builds that use it.
10469 * statement.cs (UsageVector.MergeChildren): I would like Martin to
10470 review this patch. But basically after all the children variables
10471 have been merged, the value of "Breaks" was not being set to
10472 new_breaks for Switch blocks. I think that it should be set after
10473 it has executed. Currently I set this to the value of new_breaks,
10474 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
10475 conservative, but I do not understand this code very well.
10477 I did not break anything in the build, so that is good ;-)
10479 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
10481 2002-10-20 Mark Crichton <crichton@gimp.org>
10483 * cfold.cs: Fixed compile blocker. Really fixed it this time.
10485 2002-10-20 Nick Drochak <ndrochak@gol.com>
10487 * cfold.cs: Fixed compile blocker.
10489 2002-10-20 Miguel de Icaza <miguel@ximian.com>
10491 * driver.cs: I was chekcing the key, not the file.
10493 2002-10-19 Ravi Pratap <ravi@ximian.com>
10495 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
10496 message that we were generating - we just need to silently return
10499 2002-10-19 Miguel de Icaza <miguel@ximian.com>
10501 * class.cs (Event.Define): Change my previous commit, as this
10502 breaks the debugger. This is a temporary hack, as it seems like
10503 the compiler is generating events incorrectly to begin with.
10505 * expression.cs (Binary.ResolveOperator): Added support for
10506 "U operator - (E x, E y)"
10508 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
10511 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
10512 init-only variables, but this path did not take into account that
10513 there might be also instance readonly variables. Correct this
10516 This fixes bug 32253
10518 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
10521 * driver.cs: Change the extension for modules to `netmodule'
10523 * cs-parser.jay: Improved slightly the location tracking for
10524 the debugger symbols.
10526 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
10527 modifiers that were specified instead of the hardcoded value
10528 (FamAndAssem). This was basically ignoring the static modifier,
10529 and others. Fixes 32429.
10531 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
10532 fixed a bug in the process (32476)
10534 * expression.cs (ArrayAccess.EmitAssign): Patch from
10535 hwang_rob@yahoo.ca that fixes bug 31834.3
10537 2002-10-18 Miguel de Icaza <miguel@ximian.com>
10539 * driver.cs: Make the module extension .netmodule.
10541 2002-10-16 Miguel de Icaza <miguel@ximian.com>
10543 * driver.cs: Report an error if the resource file is not found
10544 instead of crashing.
10546 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
10547 false, like Emit does.
10549 2002-10-16 Nick Drochak <ndrochak@gol.com>
10551 * typemanager.cs: Remove unused private member. Also reported mcs
10552 bug to report this as a warning like csc.
10554 2002-10-15 Martin Baulig <martin@gnome.org>
10556 * statement.cs (Statement.Emit): Made this a virtual method; emits
10557 the line number info and calls DoEmit().
10558 (Statement.DoEmit): New protected abstract method, formerly knows
10559 as Statement.Emit().
10561 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
10563 2002-10-11 Miguel de Icaza <miguel@ximian.com>
10565 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
10566 have fixed a remaining problem: not every AddXXXX was adding a
10567 fully qualified name.
10569 Now everyone registers a fully qualified name in the DeclSpace as
10570 being defined instead of the partial name.
10572 Downsides: we are slower than we need to be due to the excess
10573 copies and the names being registered this way.
10575 The reason for this is that we currently depend (on the corlib
10576 bootstrap for instance) that types are fully qualified, because
10577 we dump all the types in the namespace, and we should really have
10578 types inserted into the proper namespace, so we can only store the
10579 basenames in the defined_names array.
10581 2002-10-10 Martin Baulig <martin@gnome.org>
10583 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
10584 from bug #31834, see the bug report for a testcase which is
10587 2002-10-10 Martin Baulig <martin@gnome.org>
10589 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
10590 flow analysis code for this.
10592 * statement.cs (Do, While, For): Tell the flow analysis code about
10594 (FlowBranching.UsageVector): Added support for infinite loops.
10595 (Block.Resolve): Moved the dead code elimination here and use flow
10598 2002-10-09 Miguel de Icaza <miguel@ximian.com>
10600 * class.cs (Field.Define): Catch cycles on struct type
10603 * typemanager.cs (IsUnmanagedtype): Do not recursively check
10604 fields if the fields are static. We only need to check instance
10607 * expression.cs (As.DoResolve): Test for reference type.
10609 * statement.cs (Using.ResolveExpression): Use
10610 ConvertImplicitRequired, not ConvertImplicit which reports an
10612 (Using.ResolveLocalVariableDecls): ditto.
10614 * expression.cs (Binary.ResolveOperator): Report errors in a few
10615 places where we had to.
10617 * typemanager.cs (IsUnmanagedtype): Finish implementation.
10619 2002-10-08 Miguel de Icaza <miguel@ximian.com>
10621 * expression.cs: Use StoreFromPtr instead of extracting the type
10622 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
10624 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
10625 an enumeration value to a System.Enum, but System.Enum is not a
10626 value type, but an class type, so we need to box.
10628 (Expression.ConvertExplicit): One codepath could return
10629 errors but not flag them. Fix this. Fixes #31853
10631 * parameter.cs (Resolve): Do not allow void as a parameter type.
10633 2002-10-06 Martin Baulig <martin@gnome.org>
10635 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
10636 if it's a class type and not a struct. Fixes #31815.
10638 2002-10-06 Martin Baulig <martin@gnome.org>
10640 * statement.cs: Reworked the flow analysis code a bit to make it
10641 usable for dead code elimination.
10643 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10645 * cs-parser.jay: allow empty source files. Fixes bug #31781.
10647 2002-10-04 Miguel de Icaza <miguel@ximian.com>
10649 * expression.cs (ComposedCast.DoResolveType): A quick workaround
10650 to fix the test 165, will investigate deeper.
10652 2002-10-04 Martin Baulig <martin@gnome.org>
10654 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
10655 finally blocks actually work.
10656 (Try.Resolve): We don't need to create a sibling for `finally' if
10657 there is no finally block.
10659 2002-10-04 Martin Baulig <martin@gnome.org>
10661 * class.cs (Constructor.Define): The default accessibility for a
10662 non-default constructor is private, not public.
10664 2002-10-04 Miguel de Icaza <miguel@ximian.com>
10666 * class.cs (Constructor): Make AllowedModifiers public, add
10669 * cs-parser.jay: Perform the modifiers test here, as the
10670 constructor for the Constructor class usually receives a zero
10671 because of the way we create it (first we create, later we
10672 customize, and we were never checking the modifiers).
10674 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
10675 is a version of LookupTypeReflection that includes the type-name
10676 cache. This can be used as a fast path for functions that know
10677 the fully qualified name and are only calling into *.GetType() to
10678 obtain a composed type.
10680 This is also used by TypeManager.LookupType during its type
10683 (LookupType): We now also track the real type name, as sometimes
10684 we can get a quey for the real type name from things like
10685 ComposedCast. This fixes bug 31422.
10687 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
10688 complete type fullname, it does not have to go through the type
10689 resolution system to obtain the composed version of the type (for
10690 obtaining arrays or pointers).
10692 (Conditional.Emit): Use the EmitBoolExpression to
10693 generate nicer code, as requested by Paolo.
10695 (ArrayCreation.CheckIndices): Use the patch from
10696 hwang_rob@yahoo.ca to validate the array initializers.
10698 2002-10-03 Miguel de Icaza <miguel@ximian.com>
10700 * class.cs (ConstructorInitializer.Emit): simplify code by using
10701 Invocation.EmitCall, and at the same time, fix the bugs in calling
10702 parent constructors that took variable arguments.
10704 * ecore.cs (Expression.ConvertNumericExplicit,
10705 Expression.ImplicitNumericConversion): Remove the code that
10706 manually wrapped decimal (InternalTypeConstructor call is now gone
10709 * expression.cs (Cast.TryReduce): Also handle decimal types when
10710 trying to perform a constant fold on the type.
10712 * typemanager.cs (IsUnmanagedtype): Partially implemented.
10714 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
10715 that only turned off an error report, and did nothing else.
10717 2002-10-02 Miguel de Icaza <miguel@ximian.com>
10719 * driver.cs: Handle and ignore /fullpaths
10721 2002-10-01 Miguel de Icaza <miguel@ximian.com>
10723 * expression.cs (Binary.ResolveOperator): Catch the case where
10724 DoNumericPromotions returns true,
10726 (Binary.DoNumericPromotions): Simplify the code, and the tests.
10728 2002-09-27 Miguel de Icaza <miguel@ximian.com>
10730 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
10733 2002-09-26 Miguel de Icaza <miguel@ximian.com>
10735 * ecore.cs (ConvertNumericExplicit): It is not enough that the
10736 conversion exists, but it is also required that the conversion be
10737 performed. This manifested in "(Type64Enum) 2".
10739 * class.cs (TypeManager.AddMethod): The fix is not to change
10740 AddEnum, because that one was using a fully qualified name (every
10741 DeclSpace derivative does), but to change the AddMethod routine
10742 that was using an un-namespaced name. This now correctly reports
10743 the duplicated name.
10745 Revert patch until I can properly fix it. The issue
10746 is that we have a shared Type space across all namespaces
10747 currently, which is wrong.
10749 Options include making the Namespace a DeclSpace, and merge
10750 current_namespace/current_container in the parser.
10752 2002-09-25 Miguel de Icaza <miguel@ximian.com>
10754 * cs-parser.jay: Improve error reporting when we get a different
10755 kind of expression in local_variable_type and
10756 local_variable_pointer_type.
10758 Propagate this to avoid missleading errors being reported.
10760 * ecore.cs (ImplicitReferenceConversion): treat
10761 TypeManager.value_type as a target just like object_type. As
10766 Is valid, and needs to result in the int 1 being boxed before it
10767 is assigned to the value type v.
10769 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
10770 to validate the enumeration name.
10772 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
10773 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
10774 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
10776 * ecore.cs (TryImplicitIntConversion): When doing an
10777 implicit-enumeration-conversion, check if the type is 64-bits and
10778 perform a conversion before passing to EnumConstant.
10780 2002-09-23 Miguel de Icaza <miguel@ximian.com>
10782 * decl.cs (Error_AmbiguousTypeReference); New routine used to
10783 report ambiguous type references. Unlike the MS version, we
10784 report what the ambiguity is. Innovation at work ;-)
10786 (DeclSpace.FindType): Require a location argument to
10787 display when we display an ambiguous error.
10789 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
10791 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
10793 * expression.cs (EmitDynamicInitializers): Apply patch from
10794 hwang_rob@yahoo.ca that fixes the order in which we emit our
10797 2002-09-21 Martin Baulig <martin@gnome.org>
10799 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
10800 delegate takes no arguments.
10802 2002-09-20 Miguel de Icaza <miguel@ximian.com>
10804 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
10807 * expression.cs: Extract the underlying type.
10809 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
10811 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
10813 2002-09-19 Miguel de Icaza <miguel@ximian.com>
10815 * class.cs (TypeContainer.DefineType): We can not use the nice
10816 PackingSize with the size set to 1 DefineType method, because it
10817 will not allow us to define the interfaces that the struct
10820 This completes the fixing of bug 27287
10822 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
10823 means also structs. This fixes part of the problem.
10824 (Expresion.ImplicitReferenceConversionExists): ditto.
10826 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
10827 error if there were no errors reported during the type lookup
10828 process, to avoid duplicates or redundant errors. Without this
10829 you would get an ambiguous errors plus a type not found. We have
10830 beaten the user enough with the first error.
10832 (DeclSparce.FindType): Emit a warning if we have an ambiguous
10835 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
10836 during the resolution process, stop the lookup, this avoids
10837 repeated error reports (same error twice).
10839 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
10841 * typemanager.cs (LookupType): Redo the type lookup code to match
10842 the needs of System.Reflection.
10844 The issue is that System.Reflection requires references to nested
10845 types to begin with a "+" sign instead of a dot. So toplevel
10846 types look like: "NameSpace.TopLevelClass", and nested ones look
10847 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
10850 2002-09-19 Martin Baulig <martin@gnome.org>
10852 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
10853 says that a method always returns or always throws an exception,
10854 don't report the CS0161.
10856 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
10857 set `Returns = new_returns'.
10859 2002-09-19 Martin Baulig <martin@gnome.org>
10861 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
10862 to an enum constant, check for a CS0176.
10864 2002-09-18 Miguel de Icaza <miguel@ximian.com>
10866 * class.cs (TypeContainer.CheckPairedOperators): Now we check
10867 for operators that must be in pairs and report errors.
10869 * ecore.cs (SimpleName.DoResolveType): During the initial type
10870 resolution process, when we define types recursively, we must
10871 check first for types in our current scope before we perform
10872 lookups in the enclosing scopes.
10874 * expression.cs (MakeByteBlob): Handle Decimal blobs.
10876 (Invocation.VerifyArgumentsCompat): Call
10877 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
10878 I thought we were supposed to always call this, but there are a
10879 few places in the code where we dont do it.
10881 2002-09-17 Miguel de Icaza <miguel@ximian.com>
10883 * driver.cs: Add support in -linkres and -resource to specify the
10884 name of the identifier.
10886 2002-09-16 Miguel de Icaza <miguel@ximian.com>
10888 * ecore.cs (StandardConversionExists): Sync with the conversion
10889 code: allow anything-* to void* conversions.
10891 (FindMostSpecificSource): Use an Expression argument
10892 instead of a Type, because we might be handed over a Literal which
10893 gets a few more implicit conversions that plain types do not. So
10894 this information was being lost.
10896 Also, we drop the temporary type-holder expression when not
10899 2002-09-17 Martin Baulig <martin@gnome.org>
10901 * class.cs (PropertyBase.CheckBase): Don't check the base class if
10902 this is an explicit interface implementation.
10904 2002-09-17 Martin Baulig <martin@gnome.org>
10906 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
10907 different `IndexerName' attributes.
10909 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
10910 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
10911 virtual CommonResolve().
10913 2002-09-16 Miguel de Icaza <miguel@ximian.com>
10915 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
10916 and convert that to the UnderlyingType.
10918 * statement.cs (Foreach.Resolve): Indexers are just like variables
10919 or PropertyAccesses.
10921 * cs-tokenizer.cs (consume_string): Track line numbers and columns
10922 inside quoted strings, we were not doing this before.
10924 2002-09-16 Martin Baulig <martin@gnome.org>
10926 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
10927 resolve it. This is needed for the definite assignment check of the
10928 instance expression, fixes bug #29846.
10929 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
10931 2002-09-16 Nick Drochak <ndrochak@gol.com>
10933 * parameter.cs: Fix compile error. Cannot reference static member
10934 from an instance object. Is this an mcs bug?
10936 2002-09-14 Martin Baulig <martin@gnome.org>
10938 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
10939 multiple times. Fixes bug #30295, added test-166.cs.
10941 2002-09-14 Martin Baulig <martin@gnome.org>
10943 * statement.cs (Block.Emit): Don't emit unreachable code.
10944 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
10945 `break' statements.
10946 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
10948 2002-09-14 Martin Baulig <martin@gnome.org>
10950 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
10953 2002-09-14 Martin Baulig <martin@gnome.org>
10955 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
10956 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
10957 be false on the ms runtime.
10959 2002-09-13 Martin Baulig <martin@gnome.org>
10961 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
10962 the CS0038 error message.
10964 2002-09-12 Miguel de Icaza <miguel@ximian.com>
10966 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
10967 constant inside, return it.
10969 2002-09-12 Martin Baulig <martin@gnome.org>
10971 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
10972 implicit conversion can be done between enum types.
10974 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
10975 check whether an implicit conversion to the current enum's UnderlyingType
10976 exists and report an error if not.
10978 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
10979 without debugging support.
10981 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
10982 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
10984 2002-09-12 Martin Baulig <martin@gnome.org>
10986 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
10988 * ecore.cs (IMemberExpr.DeclaringType): New property.
10989 (SimpleName.SimpleNameResolve): Check whether we're accessing a
10990 nonstatic member of an outer type (CS0038).
10992 2002-09-11 Miguel de Icaza <miguel@ximian.com>
10994 * driver.cs: Activate the using-error detector at warning level
10995 4 (at least for MS-compatible APIs).
10997 * namespace.cs (VerifyUsing): Small buglett fix.
10999 * pending.cs (PendingImplementation): pass the container pointer.
11001 * interface.cs (GetMethods): Allow for recursive definition. Long
11002 term, I would like to move every type to support recursive
11003 definitions, not the current ordering mechanism that we have right
11006 The situation is this: Attributes are handled before interfaces,
11007 so we can apply attributes to interfaces. But some attributes
11008 implement interfaces, we will now handle the simple cases
11009 (recursive definitions will just get an error).
11011 * parameter.cs: Only invalidate types at the end if we fail to
11014 2002-09-09 Martin Baulig <martin@gnome.org>
11016 * ecore.cs (PropertyExpr.Emit): Also check for
11017 TypeManager.system_int_array_get_length so this'll also work when
11018 compiling corlib. Fixes #30003.
11020 2002-09-09 Martin Baulig <martin@gnome.org>
11022 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
11023 and throw an exception if we can't get the type's size. Fixed #30040,
11026 2002-09-09 Martin Baulig <martin@gnome.org>
11028 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
11030 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
11031 context. Fixes bug #30027.
11033 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
11034 virtual functions. Fixes bug #30043, added test-164.cs.
11036 2002-09-08 Ravi Pratap <ravi@ximian.com>
11038 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
11040 2002-09-08 Nick Drochak <ndrochak@gol.com>
11042 * driver.cs: Use an object to get the windows codepage since it's not a
11045 2002-09-08 Miguel de Icaza <miguel@ximian.com>
11047 * statement.cs (For.Emit): for infinite loops (test == null)
11048 return whether there is a break inside, not always "true".
11050 * namespace.cs (UsingEntry): New struct to hold the name of the
11051 using definition, the location where it is defined, and whether it
11052 has been used in a successful type lookup.
11054 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
11059 2002-09-06 Ravi Pratap <ravi@ximian.com>
11061 * attribute.cs : Fix incorrect code which relied on catching
11062 a NullReferenceException to detect a null being passed in
11063 where an object was expected.
11065 2002-09-06 Miguel de Icaza <miguel@ximian.com>
11067 * statement.cs (Try): flag the catch variable as assigned
11069 * expression.cs (Cast): Simplified by using ResolveType instead of
11070 manually resolving.
11072 * statement.cs (Catch): Fix bug by using ResolveType.
11074 2002-09-06 Ravi Pratap <ravi@ximian.com>
11076 * expression.cs (BetterConversion): Special case for when we have
11077 a NullLiteral as the argument and we have to choose between string
11078 and object types - we choose string the way csc does.
11080 * attribute.cs (Attribute.Resolve): Catch the
11081 NullReferenceException and report error #182 since the Mono
11082 runtime no more has the bug and having this exception raised means
11083 we tried to select a constructor which takes an object and is
11086 2002-09-05 Ravi Pratap <ravi@ximian.com>
11088 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
11089 message (1502, 1503) when we can't locate a method after overload
11090 resolution. This is much more informative and closes the bug
11093 * interface.cs (PopulateMethod): Return if there are no argument
11094 types. Fixes a NullReferenceException bug.
11096 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
11097 expressions too. Previously we were checking only in one place for
11098 positional arguments leaving out named arguments.
11100 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
11101 type to the enum type is not allowed. Remove code corresponding to
11104 (ConvertNumericExplicit): Allow explicit conversions from
11105 the underlying type to enum type. This precisely follows the spec
11106 and closes a bug filed by Gonzalo.
11108 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11111 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
11113 2002-09-03 Miguel de Icaza <miguel@ximian.com>
11115 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
11116 it was important that we stored the right value after the
11117 reduction in `converted'.
11119 2002-09-04 Martin Baulig <martin@gnome.org>
11121 * location.cs (Location.SymbolDocument): Use full pathnames for the
11124 2002-08-30 Miguel de Icaza <miguel@ximian.com>
11126 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
11127 of the expression resolve mechanism, because that will catch the
11128 SimpleName error failures.
11130 (Conditional): If we can not resolve the
11131 expression, return, do not crash.
11133 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11136 (location): display token name instead of its number.
11138 2002-08-28 Martin Baulig <martin@gnome.org>
11140 * expression.cs (Binary.ResolveOperator): Don't silently return
11141 but return an error if an operator cannot be applied between two
11144 2002-08-28 Martin Baulig <martin@gnome.org>
11146 * class.cs (Constructor.Define): Set the permission attributes
11147 correctly instead of making all constructors public.
11149 2002-08-28 Martin Baulig <martin@gnome.org>
11151 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
11152 for private members before reporting a CS0103; if we find anything,
11155 2002-08-28 Martin Baulig <martin@gnome.org>
11157 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
11158 to check whether `closure_start_type == closure_invocation_type',
11159 we also need to check whether `m.DeclaringType == closure_invocation_type'
11160 before bypassing the permission checks. We might be accessing
11161 protected/private members from the base class.
11162 (TypeManager.RealMemberLookup): Only set private_ok if private
11163 members were requested via BindingFlags.NonPublic.
11165 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
11167 * expression.cs (MemberAccess.ResolveMemberAccess): Set
11168 MethodGroupExpr.IsExplicitImpl if appropriate.
11169 (Invocation.DoResolve): Don't report the CS0120 for explicit
11170 interface implementations.
11172 2002-08-27 Martin Baulig <martin@gnome.org>
11174 * expression.cs (Invocation.DoResolve): If this is a static
11175 method and we don't have an InstanceExpression, we must report
11178 2002-08-25 Martin Baulig <martin@gnome.org>
11180 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
11181 `==' between a valuetype and an object.
11183 2002-08-25 Miguel de Icaza <miguel@ximian.com>
11185 * ecore.cs (TypeExpr): Provide a ToString method.
11187 2002-08-24 Martin Baulig <martin@gnome.org>
11189 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
11190 now called proggie.dbg and it's a binary file.
11192 2002-08-23 Martin Baulig <martin@gnome.org>
11194 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
11196 2002-08-23 Martin Baulig <martin@gnome.org>
11198 * struct.cs (MyStructInfo.ctor): Make this work with empty
11199 structs; it's not allowed to use foreach() on null.
11201 2002-08-23 Martin Baulig <martin@gnome.org>
11203 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
11204 writer the full pathname of the generated assembly.
11206 2002-08-23 Martin Baulig <martin@gnome.org>
11208 * statements.cs (FlowBranching.UsageVector.MergeChildren):
11209 A `finally' block never returns or breaks; improved handling of
11212 2002-08-23 Martin Baulig <martin@gnome.org>
11214 * statement.cs (Throw.Resolve): Allow `throw null'.
11216 2002-08-23 Martin Baulig <martin@gnome.org>
11218 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
11219 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
11220 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
11221 MemberLookup would return a wrong event if this is an explicit
11222 interface implementation and the class has an event with the same
11225 2002-08-23 Martin Baulig <martin@gnome.org>
11227 * statement.cs (Block.AddChildVariableNames): New public method.
11228 (Block.AddChildVariableName): Likewise.
11229 (Block.IsVariableNameUsedInChildBlock): Likewise.
11230 (Block.AddVariable): Check whether a variable name has already
11231 been used in a child block.
11233 * cs-parser.jay (declare_local_variables): Mark all variable names
11234 from the current block as being used in a child block in the
11237 2002-08-23 Martin Baulig <martin@gnome.org>
11239 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
11240 find the symbol writer.
11242 * driver.cs: csc also allows the arguments to /define being
11243 separated by commas, not only by semicolons.
11245 2002-08-23 Martin Baulig <martin@gnome.org>
11247 * interface.cs (Interface.GetMembers): Added static check for events.
11249 2002-08-15 Martin Baulig <martin@gnome.org>
11251 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
11252 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
11254 * ecore.cs (Expression.MemberLookup): Added documentation and explained
11255 why the MethodData.EmitDestructor() change was necessary.
11257 2002-08-20 Martin Baulig <martin@gnome.org>
11259 * class.cs (TypeContainer.FindMembers): Added static check for events.
11261 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
11263 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
11264 use Type.GetEvents(), not Type.FindMembers().
11266 2002-08-20 Martin Baulig <martin@gnome.org>
11268 * decl.cs (MemberCache): Added a special method cache which will
11269 be used for method-only searched. This ensures that a method
11270 search will return a MethodInfo with the correct ReflectedType for
11273 2002-08-20 Martin Baulig <martin@gnome.org>
11275 * decl.cs (DeclSpace.FindMembers): Made this public.
11277 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11279 * delegate.cs: fixed build on windows.
11280 [FIXME: Filed as bug #29150: MCS must report these errors.]
11282 2002-08-19 Ravi Pratap <ravi@ximian.com>
11284 * ecore.cs (StandardConversionExists): Return a false
11285 if we are trying to convert the void type to anything else
11286 since that is not allowed.
11288 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
11289 we flag error 70 in the event an event is trying to be accessed
11290 directly from outside the declaring type.
11292 2002-08-20 Martin Baulig <martin@gnome.org>
11294 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
11295 MemberCache from typemanager.cs to decl.cs.
11297 2002-08-19 Martin Baulig <martin@gnome.org>
11299 * class.cs (TypeContainer): Implement IMemberContainer.
11300 (TypeContainer.DefineMembers): Create the MemberCache.
11301 (TypeContainer.FindMembers): Do better BindingFlags checking; only
11302 return public members if BindingFlags.Public was given, check
11303 whether members are static.
11305 2002-08-16 Martin Baulig <martin@gnome.org>
11307 * decl.cs (DeclSpace.Define): Splitted this in Define and
11308 DefineMembers. DefineMembers is called first and initializes the
11311 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
11312 DefineMembers() on all our DeclSpaces.
11314 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
11315 but call DefineMembers() on all nested interfaces. We call their
11316 Define() in our new Define() function.
11318 * interface.cs (Interface): Implement IMemberContainer.
11319 (Interface.Define): Moved all code except the attribute stuf to
11321 (Interface.DefineMembers): Initialize the member cache.
11323 * typemanager.cs (IMemberFinder): Removed this interface, we don't
11324 need this anymore since we can use MemberCache.FindMembers directly.
11326 2002-08-19 Martin Baulig <martin@gnome.org>
11328 * typemanager.cs (MemberCache): When creating the cache for an
11329 interface type, add all inherited members.
11330 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
11331 to `out bool used_cache' and documented it.
11332 (TypeManager.MemberLookup): If we already used the cache in the first
11333 iteration, we don't need to do the interfaces check.
11335 2002-08-19 Martin Baulig <martin@gnome.org>
11337 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
11338 here from IMemberFinder and don't implement this interface anymore.
11339 (DeclSpace.MemberCache): Moved here from IMemberFinder.
11341 * typemanager.cs (IMemberFinder): This interface is now only used by
11342 classes which actually support the member cache.
11343 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
11344 since we only put DeclSpaces into this Hashtable.
11345 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
11346 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
11348 2002-08-16 Martin Baulig <martin@gnome.org>
11350 * typemanager.cs (ICachingMemberFinder): Removed.
11351 (IMemberFinder.MemberCache): New property.
11352 (TypeManager.FindMembers): Merged this with RealFindMembers().
11353 This function will never be called from TypeManager.MemberLookup()
11354 so we can't use the cache here, just the IMemberFinder.
11355 (TypeManager.MemberLookup_FindMembers): Check whether the
11356 IMemberFinder has a MemberCache and call the cache's FindMembers
11358 (MemberCache): Rewrote larger parts of this yet another time and
11359 cleaned it up a bit.
11361 2002-08-15 Miguel de Icaza <miguel@ximian.com>
11363 * driver.cs (LoadArgs): Support quoting.
11365 (Usage): Show the CSC-like command line arguments.
11367 Improved a few error messages.
11369 2002-08-15 Martin Baulig <martin@gnome.org>
11371 * typemanager.cs (IMemberContainer.Type): New property.
11372 (IMemberContainer.IsInterface): New property.
11374 The following changes are conditional to BROKEN_RUNTIME, which is
11375 defined at the top of the file.
11377 * typemanager.cs (MemberCache.MemberCache): Don't add the base
11378 class'es members, but add all members from TypeHandle.ObjectType
11379 if we're an interface.
11380 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
11381 is the current type.
11382 (MemberCache.CacheEntry.Container): Removed this field.
11383 (TypeHandle.GetMembers): Include inherited members.
11385 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11387 * typemanager.cs: fixed compilation and added a comment on a field that
11390 2002-08-15 Martin Baulig <martin@gnome.org>
11392 * class.cs (ConstructorInitializer.Resolve): In the
11393 Expression.MemberLookup call, use the queried_type as
11396 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
11397 declared' attribute, it's always true.
11398 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
11399 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
11400 temporary wrapper for FindMembers which tells MemberLookup whether
11401 members from the base classes are included in the return value.
11402 This will go away soon.
11403 (TypeManager.MemberLookup): Use this temporary hack here; once the
11404 new MemberCache is completed, we don't need to do the DeclaredOnly
11405 looping here anymore since the MemberCache will take care of this.
11406 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
11407 (MemberCache): When creating the MemberCache for a class, get
11408 members from the current class and all its base classes.
11409 (MemberCache.CacheEntry.Container): New field. This is a
11410 temporary hack until the Mono runtime is fixed to distinguish
11411 between ReflectedType and DeclaringType. It allows us to use MCS
11412 with both the MS runtime and the unfixed Mono runtime without
11413 problems and without accecting performance.
11414 (MemberCache.SearchMembers): The DeclaredOnly looping from
11415 TypeManager.MemberLookup is now done here.
11417 2002-08-14 Martin Baulig <martin@gnome.org>
11419 * statement.cs (MyStructInfo.MyStructInfo): Don't call
11420 Type.GetFields on dynamic types but get the fields from the
11421 corresponding TypeContainer.
11422 (MyStructInfo.GetStructInfo): Added check for enum types.
11424 * typemanager.cs (MemberList.IsSynchronized): Implemented.
11425 (MemberList.SyncRoot): Implemented.
11426 (TypeManager.FilterWithClosure): No need to check permissions if
11427 closure_start_type == closure_invocation_type, don't crash if
11428 closure_invocation_type is null.
11430 2002-08-13 Martin Baulig <martin@gnome.org>
11432 Rewrote TypeContainer.FindMembers to use a member cache. This
11433 gives us a speed increase of about 35% for the self-hosting MCS
11434 build and of about 15-20% for the class libs (both on GNU/Linux).
11436 * report.cs (Timer): New class to get enhanced profiling. This
11437 whole class is "TIMER" conditional since it remarkably slows down
11440 * class.cs (MemberList): New class. This is an IList wrapper
11441 which we're now using instead of passing MemberInfo[]'s around to
11442 avoid copying this array unnecessarily.
11443 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
11444 (ICachingMemberFinder, IMemberContainer): New interface.
11445 (TypeManager.FilterWithClosure): If `criteria' is null, the name
11446 has already been checked, otherwise use it for the name comparision.
11447 (TypeManager.FindMembers): Renamed to RealMemberFinder and
11448 provided wrapper which tries to use ICachingMemberFinder.FindMembers
11449 if possible. Returns a MemberList, not a MemberInfo [].
11450 (TypeHandle): New class, implements IMemberContainer. We create
11451 one instance of this class per type, it contains a MemberCache
11452 which is used to do the member lookups.
11453 (MemberCache): New class. Each instance of this class contains
11454 all members of a type and a name-based hash table.
11455 (MemberCache.FindMembers): This is our new member lookup
11456 function. First, it looks up all members of the requested name in
11457 the hash table. Then, it walks this list and sorts out all
11458 applicable members and returns them.
11460 2002-08-13 Martin Baulig <martin@gnome.org>
11462 In addition to a nice code cleanup, this gives us a performance
11463 increase of about 1.4% on GNU/Linux - not much, but it's already
11464 half a second for the self-hosting MCS compilation.
11466 * typemanager.cs (IMemberFinder): New interface. It is used by
11467 TypeManager.FindMembers to call FindMembers on a TypeContainer,
11468 Enum, Delegate or Interface.
11469 (TypeManager.finder_to_member_finder): New PtrHashtable.
11470 (TypeManager.finder_to_container): Removed.
11471 (TypeManager.finder_to_delegate): Removed.
11472 (TypeManager.finder_to_interface): Removed.
11473 (TypeManager.finder_to_enum): Removed.
11475 * interface.cs (Interface): Implement IMemberFinder.
11477 * delegate.cs (Delegate): Implement IMemberFinder.
11479 * enum.cs (Enum): Implement IMemberFinder.
11481 * class.cs (TypeContainer): Implement IMemberFinder.
11483 2002-08-12 Martin Baulig <martin@gnome.org>
11485 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
11487 2002-08-12 Martin Baulig <martin@gnome.org>
11489 * ecore.cs (ITypeExpression): New interface for expressions which
11491 (TypeExpression): Renamed to TypeLookupExpression.
11492 (Expression.DoResolve): If we're doing a types-only lookup, the
11493 expression must implement the ITypeExpression interface and we
11494 call DoResolveType() on it.
11495 (SimpleName): Implement the new ITypeExpression interface.
11496 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
11497 hack, the situation that we're only looking up types can't happen
11498 anymore when this method is called. Moved the type lookup code to
11499 DoResolveType() and call it.
11500 (SimpleName.DoResolveType): This ITypeExpression interface method
11501 is now doing the types-only lookup.
11502 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
11503 (ResolveFlags): Added MaskExprClass.
11505 * expression.cs (MemberAccess): Implement the ITypeExpression
11507 (MemberAccess.DoResolve): Added support for a types-only lookup
11508 when we're called via ITypeExpression.DoResolveType().
11509 (ComposedCast): Implement the ITypeExpression interface.
11511 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
11512 Expression.Resolve() with ResolveFlags.Type instead.
11514 2002-08-12 Martin Baulig <martin@gnome.org>
11516 * interface.cs (Interface.Define): Apply attributes.
11518 * attribute.cs (Attribute.ApplyAttributes): Added support for
11519 interface attributes.
11521 2002-08-11 Martin Baulig <martin@gnome.org>
11523 * statement.cs (Block.Emit): Only check the "this" variable if we
11524 do not always throw an exception.
11526 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
11527 whether the property has a set accessor.
11529 2002-08-11 Martin Baulig <martin@gnome.org>
11531 Added control flow analysis support for structs.
11533 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
11534 with control flow analysis turned off.
11535 (IVariable): New interface.
11536 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
11537 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
11538 (FieldExpr.DoResolve): Resolve the instance expression with flow
11539 analysis turned off and do the definite assignment check after the
11540 resolving when we know what the expression will resolve to.
11542 * expression.cs (LocalVariableReference, ParameterReference):
11543 Implement the new IVariable interface, only call the flow analysis
11544 code if ec.DoFlowAnalysis is true.
11545 (This): Added constructor which takes a Block argument. Implement
11546 the new IVariable interface.
11547 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
11548 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
11549 This does the definite assignment checks for struct members.
11551 * class.cs (Constructor.Emit): If this is a non-static `struct'
11552 constructor which doesn't have any initializer, call
11553 Block.AddThisVariable() to tell the flow analysis code that all
11554 struct elements must be initialized before control returns from
11557 * statement.cs (MyStructInfo): New public class.
11558 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
11559 argument to this indexer. If non-zero, check an individual struct
11560 member, not the whole struct.
11561 (FlowBranching.CheckOutParameters): Check struct members.
11562 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
11563 overloaded versions of these methods which take an additional
11564 `int field_idx' argument to check struct members.
11565 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
11566 overloaded versions of these methods which take an additional
11567 `string field_name' argument to check struct member.s
11568 (VariableInfo): Implement the IVariable interface.
11569 (VariableInfo.StructInfo): New public property. Returns the
11570 MyStructInfo instance of the variable if it's a struct or null.
11571 (Block.AddThisVariable): New public method. This is called from
11572 Constructor.Emit() for non-static `struct' constructor which do
11573 not have any initializer. It creates a special variable for the
11574 "this" instance variable which will be checked by the flow
11575 analysis code to ensure that all of the struct's fields are
11576 initialized before control returns from the constructor.
11577 (UsageVector): Added support for struct members. If a
11578 variable/parameter is a struct with N members, we reserve a slot
11579 in the usage vector for each member. A struct is considered fully
11580 initialized if either the struct itself (slot 0) or all its
11581 members are initialized.
11583 2002-08-08 Martin Baulig <martin@gnome.org>
11585 * driver.cs (Driver.MainDriver): Only report an error CS5001
11586 if there were no compilation errors.
11588 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
11589 `UnsafeContext' property to determine whether the parent is in
11590 unsafe context rather than checking the parent's ModFlags:
11591 classes nested in an unsafe class are unsafe as well.
11593 2002-08-08 Martin Baulig <martin@gnome.org>
11595 * statement.cs (UsageVector.MergeChildren): Distinguish between
11596 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
11597 we return. Added test17() and test18() to test-154.cs.
11599 2002-08-08 Martin Baulig <martin@gnome.org>
11601 * typemanager.cs (TypeManager.FilterWithClosure): If we have
11602 Family access, make sure the invoking type isn't a subclass of the
11603 queried type (that'd be a CS1540).
11605 * ecore.cs (Expression.MemberLookup): Added overloaded version of
11606 this method which takes an additional `Type invocation_type'.
11608 * expression.cs (BaseAccess.DoResolve): Use the base type as
11609 invocation and query type.
11610 (MemberAccess.DoResolve): If the lookup failed and we're about to
11611 report a CS0122, try a lookup with the ec.ContainerType - if this
11612 succeeds, we must report a CS1540.
11614 2002-08-08 Martin Baulig <martin@gnome.org>
11616 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
11617 (MethodGroupExpr): Implement the IMemberExpr interface.
11619 * expression (MemberAccess.ResolveMemberAccess): No need to have
11620 any special code for MethodGroupExprs anymore, they're now
11623 2002-08-08 Martin Baulig <martin@gnome.org>
11625 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
11626 Family, FamANDAssem and FamORAssem permissions.
11627 (TypeManager.IsSubclassOrNestedChildOf): New public method.
11629 2002-08-08 Martin Baulig <martin@gnome.org>
11631 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
11632 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
11635 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
11637 * driver.cs: implemented /resource option to embed managed resources.
11639 2002-08-07 Martin Baulig <martin@gnome.org>
11641 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
11642 (FieldBase.HasFieldInitializer): New public property.
11643 (FieldBase.GetInitializerExpression): New public method. Resolves and
11644 returns the field initializer and makes sure it is only resolved once.
11645 (TypeContainer.EmitFieldInitializers): Call
11646 FieldBase.GetInitializerExpression to get the initializer, this ensures
11647 that it isn't resolved multiple times.
11649 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
11650 the resolving process (SimpleName/MemberLookup) that we're currently
11651 emitting a field initializer (which must not access any instance members,
11652 this is an error CS0236).
11654 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
11655 argument, if the `IsFieldInitializer' flag is set, we must report and
11656 error CS0236 and not an error CS0120.
11658 2002-08-07 Martin Baulig <martin@gnome.org>
11660 * ecore.cs (IMemberExpr): New public interface.
11661 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
11662 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
11663 if the expression is an IMemberExpr.
11665 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
11666 to be null, implicitly default to `this' if we're non-static in
11667 this case. Simplified the code a lot by using the new IMemberExpr
11668 interface. Also fixed bug #28176 here.
11670 2002-08-06 Martin Baulig <martin@gnome.org>
11672 * cs-parser.jay (SimpleLookup): Removed. We need to create
11673 ParameterReferences during semantic analysis so that we can do a
11674 type-only search when resolving Cast, TypeOf and SizeOf.
11675 (block): Pass the `current_local_parameters' to the Block's
11678 * class.cs (ConstructorInitializer): Added `Parameters parameters'
11679 argument to the constructor.
11680 (ConstructorInitializer.Resolve): Create a temporary implicit
11681 block with the parameters.
11683 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
11684 references here if we aren't doing a type-only search.
11686 * statement.cs (Block): Added constructor which takes a
11687 `Parameters parameters' argument.
11688 (Block.Parameters): New public property.
11690 * support.cs (InternalParameters.Parameters): Renamed `parameters'
11691 to `Parameters' and made it public readonly.
11693 2002-08-06 Martin Baulig <martin@gnome.org>
11695 * ecore.cs (Expression.Warning): Made this public as well.
11697 * report.cs (Report.Debug): Print the contents of collections.
11699 2002-08-06 Martin Baulig <martin@gnome.org>
11701 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
11702 used to tell Resolve() which kinds of expressions it may return.
11703 (Expression.Resolve): Added overloaded version of this method which
11704 takes a `ResolveFlags flags' argument. This can be used to tell
11705 Resolve() which kinds of expressions it may return. Reports a
11707 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
11708 ResolveFlags.SimpleName.
11709 (Expression.Error118): Added overloaded version of this method which
11710 takes a `ResolveFlags flags' argument. It uses the flags to determine
11711 which kinds of expressions are allowed.
11713 * expression.cs (Argument.ResolveMethodGroup): New public method.
11714 Resolves an argument, but allows a MethodGroup to be returned.
11715 This is used when invoking a delegate.
11717 * TODO: Updated a bit.
11719 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11721 Fixed compilation with csc.
11723 * ecore.cs: Expression.Error made public. Is this correct? Should
11724 Warning be made public too?
11726 * expression.cs: use ea.Location instead of ea.loc.
11727 [FIXME: Filed as bug #28607: MCS must report these errors.]
11729 2002-08-06 Martin Baulig <martin@gnome.org>
11731 * ecore.cs (Expression.loc): Moved the location here instead of
11732 duplicating it in all derived classes.
11733 (Expression.Location): New public property.
11734 (Expression.Error, Expression.Warning): Made them non-static and
11735 removed the location argument.
11736 (Expression.Warning): Added overloaded version which takes an
11737 `int level' argument.
11738 (Expression.Error118): Make this non-static and removed the
11739 expression and location arguments.
11740 (TypeExpr): Added location argument to the constructor.
11742 * expression.cs (StaticCallExpr): Added location argument to
11744 (Indirection, PointerArithmetic): Likewise.
11745 (CheckedExpr, UnCheckedExpr): Likewise.
11746 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
11747 (StringPtr): Likewise.
11750 2002-08-05 Martin Baulig <martin@gnome.org>
11752 * expression.cs (BaseAccess.DoResolve): Actually report errors.
11754 * assign.cs (Assign.DoResolve): Check whether the source
11755 expression is a value or variable.
11757 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
11758 while resolving the corresponding blocks.
11760 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
11761 an error, don't silently return null.
11763 * statement.cs (Block.AddVariable): Do the error reporting here
11764 and distinguish between CS0128 and CS0136.
11765 (Block.DoResolve): Report all unused labels (warning CS0164).
11766 (LabeledStatement): Pass the location to the constructor.
11767 (LabeledStatement.HasBeenReferenced): New property.
11768 (LabeledStatement.Resolve): Set it to true here.
11770 * statement.cs (Return.Emit): Return success even after reporting
11771 a type mismatch error (CS0126 or CS0127), this is what csc does and
11772 it avoids confusing the users with any consecutive errors.
11774 2002-08-05 Martin Baulig <martin@gnome.org>
11776 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
11778 * const.cs (Const.LookupConstantValue): Catch circular definitions.
11780 * expression.cs (MemberAccess.DoResolve): Silently return if an
11781 error has already been reported.
11783 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
11784 error has already been reported.
11786 2002-08-05 Martin Baulig <martin@gnome.org>
11788 * statement.cs (UsageVector): Only initialize the `parameters'
11789 vector if we actually have any "out" parameters.
11791 2002-08-05 Martin Baulig <martin@gnome.org>
11793 * expression.cs (Binary.ResolveOperator): When combining delegates,
11794 they must have the same type.
11796 2002-08-05 Martin Baulig <martin@gnome.org>
11798 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
11799 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
11800 work with the ms runtime and we also don't need it: if we're a
11801 PropertyBuilder and not in the `indexer_arguments' hash, then we
11802 are a property and not an indexer.
11804 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
11805 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
11806 since the latter one doesn't work with the ms runtime.
11808 2002-08-03 Martin Baulig <martin@gnome.org>
11810 Fixed bugs #27998 and #22735.
11812 * class.cs (Method.IsOperator): New public field.
11813 (Method.CheckBase): Report CS0111 if there's already a method
11814 with the same parameters in the current class. Report CS0508 when
11815 attempting to change the return type of an inherited method.
11816 (MethodData.Emit): Report CS0179 if a method doesn't have a body
11817 and it's not marked abstract or extern.
11818 (PropertyBase): New abstract base class for Property and Indexer.
11819 (PropertyBase.CheckBase): Moved here from Property and made it work
11821 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
11822 the same so we can reuse it there.
11823 (Property, Indexer): Derive from PropertyBase.
11824 (MethodSignature.inheritable_property_signature_filter): New delegate
11825 to find properties and indexers.
11827 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
11828 argument and improved error reporting.
11830 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
11831 EmptyReadOnlyParameters and made it a property.
11833 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
11834 version of this method which takes a `PropertyInfo indexer'.
11835 (TypeManager.RegisterIndexer): New method.
11837 * class.cs: Added myself as author of this file :-)
11839 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11841 * class.cs: fixed compilation on windoze.
11843 2002-08-03 Martin Baulig <martin@gnome.org>
11845 * interface.cs (Interface.GetInterfaceBases): Check whether all
11846 base interfaces are at least as accessible than the current one.
11848 * class.cs (TypeContainer.GetClassBases): Check whether base types
11849 are at least as accessible than the current type.
11850 (TypeContainer.AsAccessible): Implemented and made non-static.
11851 (MemberBase.CheckParameters): Report errors if the accessibility
11854 * delegate.cs (Delegate.Delegate): The default visibility is
11855 internal for top-level types and private for nested types.
11856 (Delegate.Define): Report errors if the accessibility checks fail.
11858 * enum.cs (Enum.Enum): The default visibility is internal for
11859 top-level types and private for nested types.
11860 (Enum.DefineType): Compute the correct visibility.
11862 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
11863 function which takes a `bool is_toplevel' instead of a TypeContainer.
11865 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
11868 2002-08-02 Martin Baulig <martin@gnome.org>
11870 * expression.cs (LocalVariableReferenc): Added constructor which
11871 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
11872 (LocalVariableReference.IsReadOnly): New property.
11873 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
11874 variable is readonly, use our own readonly flag to do this; you can
11875 use the new constructor to get a writable reference to a read-only
11878 * cs-parser.jay (foreach_statement, using_statement): Get a writable
11879 reference to the local variable.
11881 2002-08-01 Miguel de Icaza <miguel@ximian.com>
11883 * rootcontext.cs (ResolveCore): Also include System.Exception
11885 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
11886 we reach an EmptyStatement.
11888 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
11891 * expression.cs (Binary.ResolveOperator): Check error result in
11894 use brtrue/brfalse directly and avoid compares to null.
11896 2002-08-02 Martin Baulig <martin@gnome.org>
11898 * class.cs (TypeContainer.Define): Define all nested interfaces here.
11899 Fixes bug #28407, added test-155.cs.
11901 2002-08-01 Martin Baulig <martin@gnome.org>
11903 * class.cs (Event.EmitDefaultMethod): Make this work with static
11904 events. Fixes #28311, added verify-3.cs.
11906 2002-08-01 Martin Baulig <martin@gnome.org>
11908 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
11909 `is_disposable' fields.
11910 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
11911 `hm.is_disposable' if we're using the collection pattern.
11912 (Foreach.EmitCollectionForeach): Use the correct type for the
11913 enumerator's local variable, only emit the try/finally block if
11914 necessary (fixes #27713).
11916 2002-08-01 Martin Baulig <martin@gnome.org>
11918 * ecore.cs (Expression.report118): Renamed to Error118 and made
11921 * statement.cs (Throw.Resolve): Check whether the expression is of
11922 the correct type (CS0118) and whether the type derives from
11923 System.Exception (CS0155).
11924 (Catch.Resolve): New method. Do the type lookup here and check
11925 whether it derives from System.Exception (CS0155).
11926 (Catch.CatchType, Catch.IsGeneral): New public properties.
11928 * typemanager.cs (TypeManager.exception_type): Added.
11930 2002-07-31 Miguel de Icaza <miguel@ximian.com>
11932 * driver.cs: Updated About function.
11934 2002-07-31 Martin Baulig <martin@gnome.org>
11936 Implemented Control Flow Analysis.
11938 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
11939 (EmitContext.CurrentBranching): Added.
11940 (EmitContext.StartFlowBranching): Added.
11941 (EmitContext.EndFlowBranching): Added.
11942 (EmitContext.KillFlowBranching): Added.
11943 (EmitContext.IsVariableAssigned): Added.
11944 (EmitContext.SetVariableAssigned): Added.
11945 (EmitContext.IsParameterAssigned): Added.
11946 (EmitContext.SetParameterAssigned): Added.
11947 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
11948 Added control flow analysis stuff here.
11950 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
11951 resolve the expression as lvalue.
11952 (LocalVariableReference.DoResolve): Check whether the variable has
11953 already been assigned.
11954 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
11955 the parameter as assigned here.
11956 (ParameterReference.DoResolve): Check whether the parameter has already
11958 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
11959 expression as lvalue.
11961 * statement.cs (FlowBranching): New class for the flow analysis code.
11962 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
11963 (LabeledStatement.IsDefined): New public property.
11964 (LabeledStatement.AddUsageVector): New public method to tell flow
11965 analyis that the label may be reached via a forward jump.
11966 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
11968 (VariableInfo.Number): New public field. This is used by flow analysis
11969 to number all locals of a block.
11970 (Block.CountVariables): New public property. This is the number of
11971 local variables in this block (including the locals from all parent
11973 (Block.EmitMeta): Number all the variables.
11975 * statement.cs: Added flow analysis support to all classes.
11977 2002-07-31 Martin Baulig <martin@gnome.org>
11979 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
11980 To get debugging messages, compile mcs with /define:MCS_DEBUG and
11981 then use this argument.
11983 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
11985 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
11986 use this to specify /define options.
11988 2002-07-29 Martin Baulig <martin@gnome.org>
11990 * statement.cs (Fixed): Moved all code that does variable lookups
11991 and resolvings from Emit to Resolve.
11993 * statement.cs (For): Moved all code that does variable lookups
11994 and resolvings from Emit to Resolve.
11996 * statement.cs (Using): Moved all code that does variable lookups
11997 and resolvings from Emit to Resolve.
11999 2002-07-29 Martin Baulig <martin@gnome.org>
12001 * attribute.cs (Attribute.Resolve): Explicitly catch a
12002 System.NullReferenceException when creating the
12003 CustromAttributeBuilder and report a different warning message.
12005 2002-07-29 Martin Baulig <martin@gnome.org>
12007 * support.cs (ParameterData.ParameterName): Added method to
12008 get the name of a parameter.
12010 * typemanager.cs (TypeManager.IsValueType): New public method.
12012 2002-07-29 Martin Baulig <martin@gnome.org>
12014 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
12015 is a flag which specifies that it's either ref or out.
12016 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
12017 the out parameter to `out Parameter.Modifier mod', also set the
12018 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
12020 * support.cs (InternalParameters.ParameterModifier): Distinguish
12021 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
12022 Parameter.Modifier.ISBYREF flag if it's either ref or out.
12024 * expression.cs (Argument.GetParameterModifier): Distinguish
12025 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
12026 Parameter.Modifier.ISBYREF flag if it's either ref or out.
12028 2002-07-29 Martin Baulig <martin@gnome.org>
12030 * expression.cs (ParameterReference.ParameterReference): Added
12031 `Location loc' argument to the constructor.
12033 * cs-parser.jay: Pass location to ParameterReference.
12035 2002-07-28 Miguel de Icaza <miguel@ximian.com>
12037 * statement.cs (Try): Initialize the location.
12039 * cs-parser.jay: pass location to Try.
12041 * expression.cs (Unary.Reduce): Change the prototype to return
12042 whether a constant fold could be performed or not. The result is
12043 returned in an out parameters. In the case of Indirection and
12044 AddressOf, we want to perform the full tests.
12046 2002-07-26 Miguel de Icaza <miguel@ximian.com>
12048 * statement.cs (Statement.Emit): Flag dead code.
12050 2002-07-27 Andrew Birkett <andy@nobugs.org>
12052 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
12054 2002-07-27 Martin Baulig <martin@gnome.org>
12056 * class.cs (MethodData.Define): Put back call to
12057 TypeManager.AddMethod(), accidentally commented this out.
12059 * report.cs (Debug): New public method to print debugging information,
12060 this is `[Conditional ("DEBUG")]'.
12062 2002-07-26 Martin Baulig <martin@gnome.org>
12064 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
12065 (switch_statement): Push the current_block to the switch_stack and
12066 pop it again when we're done with the switch.
12067 (switch_section): The new block is a child of the current_block.
12068 Fixes bug #24007, added test-152.cs.
12070 2002-07-27 Martin Baulig <martin@gnome.org>
12072 * expression.cs (Invocation.EmitArguments): When calling a varargs
12073 function with only its fixed arguments, we need to pass an empty
12076 2002-07-27 Martin Baulig <martin@gnome.org>
12078 Mono 0.13 has been released.
12080 2002-07-25 Miguel de Icaza <miguel@ximian.com>
12082 * driver.cs: Rename --resource to --linkres, because that is what
12083 we do currently, we dont support --resource yet.
12085 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
12087 2002-07-25 Martin Baulig <martin@gnome.org>
12089 * class.cs (MethodData): New public class. This is a `method builder'
12090 class for a method or one accessor of a Property/Indexer/Event.
12091 (MethodData.GetMethodFlags): Moved here from MemberBase.
12092 (MethodData.ApplyAttributes): Likewise.
12093 (MethodData.ApplyObsoleteAttribute): Likewise.
12094 (MethodData.ApplyConditionalAttribute): Likewise.
12095 (MethodData.ApplyDllImportAttribute): Likewise.
12096 (MethodData.CheckAbstractAndExternal): Likewise.
12097 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
12098 (MethodData.Emit): Formerly known as Method.Emit().
12099 (MemberBase): Moved everything which was specific to a single
12100 accessor/method to MethodData.
12101 (Method): Create a new MethodData and call Define() and Emit() on it.
12102 (Property, Indexer, Event): Create a new MethodData objects for each
12103 accessor and call Define() and Emit() on them.
12105 2002-07-25 Martin Baulig <martin@gnome.org>
12107 Made MethodCore derive from MemberBase to reuse the code from there.
12108 MemberBase now also checks for attributes.
12110 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
12111 (MemberBase.GetMethodFlags): Moved here from class Method and marked
12113 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
12114 `CallingConventions cc' and `Attributes opt_attrs' arguments.
12115 (MemberBase.ApplyAttributes): New virtual method; applies the
12116 attributes to a method or accessor.
12117 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
12118 (MemberBase.ApplyConditionalAttribute): Likewise.
12119 (MemberBase.ApplyDllImportAttribute): Likewise.
12120 (MemberBase.CheckAbstractAndExternal): Likewise.
12121 (MethodCore.ParameterTypes): This is now a property instead of a
12122 method, it's initialized from DoDefineParameters().
12123 (MethodCore.ParameterInfo): Removed the set accessor.
12124 (MethodCore.DoDefineParameters): New protected virtual method to
12125 initialize ParameterTypes and ParameterInfo.
12126 (Method.GetReturnType): We can now simply return the MemberType.
12127 (Method.GetMethodFlags): Override the MemberBase version and add
12128 the conditional flags.
12129 (Method.CheckBase): Moved some code from Define() here, call
12130 DoDefineParameters() here.
12131 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
12132 here to avoid some larger code duplication.
12133 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
12134 ensure that abstract and external accessors don't declare a body.
12136 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
12137 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
12138 lookup in the attribute's parent classes, so we need to abort as soon
12139 as we found the first match.
12140 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
12141 the attribute has no arguments.
12143 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
12146 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12148 * cs-parser.jay: reverted previous patch.
12150 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12152 * cs-parser.jay: fixed bug #22119.
12154 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12156 * attribute.cs: fixed compilation. The error was:
12157 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
12158 be assigned to before control leaves the current method."
12159 [FIXME: Filed as bug #28186: MCS must report this error.]
12161 2002-07-25 Martin Baulig <martin@gnome.org>
12163 * attribute.cs (Attribute.Conditional_GetConditionName): New static
12164 method to pull the condition name ouf of a Conditional attribute.
12165 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
12166 the obsolete message and error flag out of an Obsolete attribute.
12168 * class.cs (Method.GetMethodFlags): New public method to get the
12169 TypeManager.MethodFlags for this method.
12170 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
12172 (Method.Define): Get and apply the Obsolete and Conditional attributes;
12173 if we're overriding a virtual function, set the new private variable
12174 `parent_method'; call the new TypeManager.AddMethod().
12176 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
12177 the MethodBuilder and the Method in a PtrHashtable.
12178 (TypeManager.builder_to_method): Added for this purpose.
12179 (TypeManager.MethodFlags): Added IsObsoleteError.
12180 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
12181 Obsolete and Conditional arguments in MethodBuilders. If we discover
12182 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
12183 the message from the attribute.
12185 2002-07-24 Martin Baulig <martin@gnome.org>
12187 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
12188 preprocessor directives, ensure that the argument to #define/#undef is
12189 exactly one identifier and that it's actually an identifier.
12191 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
12194 2002-07-24 Martin Baulig <martin@gnome.org>
12196 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
12197 initialize it to TypeManager.object_type in the constructor.
12198 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
12199 of the `hm.get_current' method if we're using the collection pattern.
12200 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
12201 for the explicit conversion to make it work when we're using the collection
12202 pattern and the `Current' property has a different return type than `object'.
12205 2002-07-24 Martin Baulig <martin@gnome.org>
12207 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
12208 does not match, but don't report any errors. This method is called in
12209 order for all methods in a MethodGroupExpr until a matching method is
12210 found, so we don't want to bail out if the first method doesn't match.
12211 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
12212 matches, report the 123. Fixes #28070.
12214 2002-07-24 Martin Baulig <martin@gnome.org>
12216 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
12217 TypeManager.TypeToCoreType() to the top of the method so the
12218 following equality checks will work. Fixes #28107.
12220 2002-07-24 Martin Baulig <martin@gnome.org>
12222 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
12223 operand is of type uint, and the other operand is of type sbyte,
12224 short or int, the operands are converted to type long." -
12225 Actually do what this comment already told us. Fixes bug #28106,
12228 2002-07-24 Martin Baulig <martin@gnome.org>
12230 * class.cs (MethodBase): New abstract class. This is now a base
12231 class for Property, Indexer and Event to avoid some code duplication
12232 in their Define() and DefineMethods() methods.
12233 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
12234 generic methods for Define() and DefineMethods().
12235 (FieldBase): Derive from MemberBase, not MemberCore.
12236 (Property): Derive from MemberBase, not MemberCore.
12237 (Property.DefineMethod): Moved all the code from this method to the
12238 new MethodBase.DefineAccessor(), just call it with appropriate
12240 (Property.Define): Call the new Property.DoDefine(), this does some
12241 sanity checks and we don't need to duplicate the code everywhere.
12242 (Event): Derive from MemberBase, not MemberCore.
12243 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
12244 accessors, this will also make them work with interface events.
12245 (Indexer): Derive from MemberBase, not MemberCore.
12246 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
12247 (Indexer.Define): Use the new MethodBase functions.
12249 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
12250 argument to the constructor.
12251 (Interface.FindMembers): Added support for interface events.
12252 (Interface.PopluateEvent): Implemented.
12254 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
12256 2002-07-22 Miguel de Icaza <miguel@ximian.com>
12258 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
12259 but this is required to check for a method name being the same as
12260 the containing class.
12264 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12266 * interface.cs: initialize variable.
12268 2002-07-23 Martin Baulig <martin@gnome.org>
12270 Implemented the IndexerName attribute in interfaces.
12272 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
12273 name if this is an explicit interface implementation.
12274 (Indexer.InterfaceIndexerName): New public variable. If we're
12275 implementing an interface indexer, this is the IndexerName in that
12276 interface. Otherwise, it's the IndexerName.
12277 (Indexer.DefineMethod): If we're implementing interface indexer,
12278 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
12279 and Pending.ImplementIndexer methods.
12280 (Indexer.Define): Also define the PropertyBuilder if we're
12281 implementing an interface indexer and this is neither an explicit
12282 interface implementation nor do the IndexerName match the one in
12285 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
12286 If a method is defined here, then we always need to create a proxy
12287 for it. This is used when implementing interface indexers.
12288 (Pending.IsInterfaceIndexer): New public method.
12289 (Pending.ImplementIndexer): New public method.
12290 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
12291 This is used when implementing interface indexers to define a proxy
12293 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
12294 define a proxy if necessary.
12296 * interface.cs (Interface.IndexerName): New public variable.
12297 (Interface.PopulateIndexer): Set the IndexerName.
12298 (Interface.DefineIndexers): New private method. Populate all the
12299 indexers and make sure their IndexerNames match.
12301 * typemanager.cs (IndexerPropertyName): Added support for interface
12304 2002-07-22 Martin Baulig <martin@gnome.org>
12306 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
12307 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
12308 ret if HasReturnLabel.
12309 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
12312 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
12313 and set the ec.LoopBeginTryCatchLevel.
12314 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
12315 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
12316 the current ec.TryCatchLevel, the branch goes out of an exception
12317 block. In this case, we need to use Leave and not Br.
12319 2002-07-22 Martin Baulig <martin@gnome.org>
12321 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
12322 block unless the block does not always return or it is contained in
12323 another try { ... } catch { ... } block. Fixes bug #26506.
12324 Added verify-1.cs to the test suite.
12326 2002-07-22 Martin Baulig <martin@gnome.org>
12328 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
12329 then we do not always return. Fixes bug #24985.
12331 2002-07-22 Martin Baulig <martin@gnome.org>
12333 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
12334 lookup on a per-class level; ie. walk up the class hierarchy until we
12335 found at least one applicable method, then choose the best among them.
12336 Fixes bug #24463 and test-29.cs.
12338 2002-07-22 Martin Baulig <martin@gnome.org>
12340 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
12341 return types of the methods. The return type is not part of the
12342 signature and we must not check it to make the `new' modifier work.
12343 Fixes bug #27999, also added test-147.cs.
12344 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
12346 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
12347 on the method's return type.
12349 2002-07-21 Martin Baulig <martin@gnome.org>
12351 * assign.cs: Make this work if the rightmost source is a constant and
12352 we need to do an implicit type conversion. Also adding a few more tests
12353 to test-38.cs which should have caught this.
12355 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
12356 target in the makefile for this. The makefile.gnu is primarily intended
12357 for end-users who don't want to debug the compiler.
12359 2002-07-21 Martin Baulig <martin@gnome.org>
12361 * assign.cs: Improved the Assign class so it can now handle embedded
12362 assignments (X = Y = Z = something). As a side-effect this'll now also
12363 consume less local variables. test-38.cs now passes with MCS, added
12364 a few new test cases to that test.
12366 2002-07-20 Martin Baulig <martin@gnome.org>
12368 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
12369 instructions. Fixes bug #27977, also added test-146.cs.
12371 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12373 * cs-tokenizer.cs: fixed getHex ().
12375 2002-07-19 Martin Baulig <martin@gnome.org>
12377 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
12378 not Type.GetType() to lookup the array type. This is needed when
12379 we're constructing an array of a user-defined type.
12380 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
12381 single-dimensional arrays, but also for single-dimensial arrays of
12384 2002-07-19 Martin Baulig <martin@gnome.org>
12386 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
12387 this function is called, it's not allowed to share LocalBuilders
12388 among ILGenerators.
12390 2002-07-19 Martin Baulig <martin@gnome.org>
12392 * expression.cs (Argument.Resolve): Report an error 118 when trying
12393 to pass a type as argument.
12395 2002-07-18 Martin Baulig <martin@gnome.org>
12397 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
12398 Conv_R_Un for the signed `long' type.
12400 2002-07-15 Miguel de Icaza <miguel@ximian.com>
12402 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
12403 `expr' for the temporary result, as that will fail if we do
12404 multiple resolves on the same expression.
12406 2002-07-05 Miguel de Icaza <miguel@ximian.com>
12408 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
12409 ec.TypeContainer for looking up aliases.
12411 * class.cs (TypeContainer): Remove LookupAlias from here.
12413 * decl.cs (DeclSpace); Move here.
12415 2002-07-01 Miguel de Icaza <miguel@ximian.com>
12417 * class.cs (FindMembers): Only call filter if the constructor
12418 bulider is not null.
12420 Also handle delegates in `NestedTypes' now. Now we will perform
12421 type lookups using the standard resolution process. This also
12424 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
12425 This uses Expressions (the limited kind that can be parsed by the
12426 tree) instead of strings.
12428 * expression.cs (ComposedCast.ToString): Implement, used to flag
12429 errors since now we have to render expressions.
12431 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
12434 * ecore.cs (SimpleName.ToString): ditto.
12436 * cs-parser.jay: Instead of using strings to assemble types, use
12437 Expressions to assemble the type (using SimpleName, ComposedCast,
12438 MemberAccess). This should fix the type lookups in declarations,
12439 because we were using a different code path for this.
12441 * statement.cs (Block.Resolve): Continue processing statements
12442 even when there is an error.
12444 2002-07-17 Miguel de Icaza <miguel@ximian.com>
12446 * class.cs (Event.Define): Also remove the `remove' method from
12447 the list of pending items.
12449 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
12450 generate more compact code.
12452 2002-07-17 Martin Baulig <martin@gnome.org>
12454 * const.cs (Const.LookupConstantValue): Add support for constant
12455 `unchecked' and `checked' expressions.
12456 Also adding test case test-140.cs for this.
12458 2002-07-17 Martin Baulig <martin@gnome.org>
12460 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
12461 check whether mi.ReturnType implements the IEnumerator interface; the
12462 `==' and the IsAssignableFrom() will fail in this situation.
12464 2002-07-16 Ravi Pratap <ravi@ximian.com>
12466 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
12469 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12471 * expression.cs: fixed bug #27811.
12473 2002-07-14 Miguel de Icaza <miguel@ximian.com>
12475 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
12476 Molaro: when we are a ref, the value already contains a pointer
12477 value, do not take the address of it.
12479 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
12480 * removed mb-parser.jay and mb-tokenizer.cs
12482 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
12484 * expression.cs: check against the building corlib void type.
12486 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
12488 * ecore.cs: fix for valuetype static readonly fields: when
12489 initializing them, we need their address, not the address of a copy.
12491 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
12493 * typemanager.cs: register also enum_type in corlib.
12495 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
12497 * class.cs: allow calling this (but not base) initializers in structs.
12499 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
12501 * ecore.cs: make sure we compare against the building base types
12504 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
12506 * typemanager.cs: fix TypeToCoreType() to handle void and object
12507 (corlib gets no more typerefs after this change).
12509 2002-07-12 Miguel de Icaza <miguel@ximian.com>
12511 * expression.cs (ArrayCreation.EmitArrayArguments): use
12512 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
12514 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
12515 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
12516 array indexes, the runtime actually forbids them.
12518 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
12519 for array arguments here.
12521 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
12522 instead of the default for ValueTypes.
12524 (New.DoEmit): Use IsValueType instead of
12525 IsSubclassOf (value_type)
12526 (New.DoResolve): ditto.
12527 (Invocation.EmitCall): ditto.
12529 * assign.cs (Assign): ditto.
12531 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
12532 Statements *are* currently doing part of their resolution during
12535 Expressions do always resolve during resolve, but statements are
12536 only required to propagate resolution to their children.
12538 2002-07-11 Miguel de Icaza <miguel@ximian.com>
12540 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
12542 (LoadAssembly): Do not add the dll if it is already specified
12544 (MainDriver): Add the System directory to the link path at the end,
12545 after all the other -L arguments.
12547 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
12548 wrong opcode for loading bytes and bools (ldelem.i1 instead of
12549 ldelem.u1) and using the opposite for sbytes.
12551 This fixes Digger, and we can finally run it.
12553 * driver.cs (UnixParseOption): Move the option parsing here.
12554 (CSCParseOption): Implement CSC-like parsing of options.
12556 We now support both modes of operation, the old Unix way, and the
12557 new CSC-like way. This should help those who wanted to make cross
12558 platform makefiles.
12560 The only thing broken is that /r:, /reference: and /lib: are not
12561 implemented, because I want to make those have the same semantics
12562 as the CSC compiler has, and kill once and for all the confussion
12563 around this. Will be doing this tomorrow.
12565 * statement.cs (Unsafe.Resolve): The state is checked during
12566 resolve, not emit, so we have to set the flags for IsUnsfe here.
12568 2002-07-10 Miguel de Icaza <miguel@ximian.com>
12570 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
12571 not catch the Error_ObjectRefRequired in SimpleName (as it is
12572 possible to have a class/instance variable name that later gets
12573 deambiguated), we have to check this here.
12575 2002-07-10 Ravi Pratap <ravi@ximian.com>
12577 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
12578 make static and put into Expression.
12580 (Event.Define): Register the private field of the event with the
12581 TypeManager so that GetFieldFromEvent can get at it.
12583 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
12584 keep track of the private field associated with an event which
12587 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
12590 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
12592 2002-07-10 Miguel de Icaza <miguel@ximian.com>
12594 * expression.cs (Binary.EmitBranchable): this routine emits the
12595 Binary expression in a branchable context. This basically means:
12596 we need to branch somewhere, not just get the value on the stack.
12598 This works together with Statement.EmitBoolExpression.
12600 * statement.cs (Statement.EmitBoolExpression): Use
12603 2002-07-09 Miguel de Icaza <miguel@ximian.com>
12605 * statement.cs (For): Reduce the number of jumps in loops.
12607 (For): Implement loop inversion for the For statement.
12609 (Break): We can be breaking out of a Try/Catch controlled section
12610 (foreach might have an implicit try/catch clause), so we need to
12611 use Leave instead of Br.
12613 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
12614 now). If the instace expression supports IMemoryLocation, we use
12615 the AddressOf method from the IMemoryLocation to extract the
12616 address instead of emitting the instance.
12618 This showed up with `This', as we were emitting the instance
12619 always (Emit) instead of the Address of This. Particularly
12620 interesting when This is a value type, as we dont want the Emit
12621 effect (which was to load the object).
12623 2002-07-08 Miguel de Icaza <miguel@ximian.com>
12625 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
12627 * statement.cs (Checked): Set the CheckedState during the resolve
12628 process too, as the ConvCast operations track the checked state on
12629 the resolve process, and not emit.
12631 * cs-parser.jay (namespace_member_declaration): Flag that we have
12632 found a declaration when we do. This is used to flag error 1529
12634 * driver.cs: Report ok when we display the help only.
12636 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
12638 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
12640 2002-07-04 Miguel de Icaza <miguel@ximian.com>
12642 * cs-tokenizer.cs (define): We also have to track locally the
12643 defines. AllDefines is just used for the Conditional Attribute,
12644 but we also need the local defines for the current source code.
12646 2002-07-03 Miguel de Icaza <miguel@ximian.com>
12648 * statement.cs (While, For, Do): These loops can exit through a
12649 Break statement, use this information to tell whether the
12650 statement is the last piece of code.
12652 (Break): Flag that we break.
12654 * codegen.cs (EmitContexts): New `Breaks' state variable.
12656 2002-07-03 Martin Baulig <martin@gnome.org>
12658 * class.cs (TypeContainer.MethodModifiersValid): Allow override
12659 modifiers in method declarations in structs. Otherwise, you won't
12660 be able to override things like Object.Equals().
12662 2002-07-02 Miguel de Icaza <miguel@ximian.com>
12664 * class.cs (Method, Property, Indexer): Do not allow the public
12665 modifier to be used in explicit interface implementations.
12667 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
12668 override modifiers in method declarations in structs
12670 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
12672 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
12673 integer or real overflow, report an error
12675 2002-07-02 Martin Baulig <martin@gnome.org>
12677 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
12678 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
12679 to tell the runtime about our newly created System.Object and
12680 System.ValueType types.
12682 2002-07-02 Miguel de Icaza <miguel@ximian.com>
12684 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
12685 struct instead of Ldarg/Starg.
12687 2002-07-02 Martin Baulig <martin@gnome.org>
12689 * expression.cs (Indirection.Indirection): Call
12690 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
12692 2002-07-02 Martin Baulig <martin@gnome.org>
12694 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
12695 ValueType, call TypeManager.TypeToCoreType() on it.
12696 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
12697 the OpCodes.Newarr argument.
12699 2002-07-02 Martin Baulig <martin@gnome.org>
12701 * expression.cs (Invocation.EmitCall): When compiling corlib,
12702 replace all calls to the system's System.Array type to calls to
12703 the newly created one.
12705 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
12706 System.Array methods.
12707 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
12708 from the system's System.Array type which must be replaced.
12710 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
12712 * typemanager.cs: load unverifiable_code_ctor so we can build
12713 corlib using the correct type. Avoid using GetTypeCode() with
12715 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
12716 TypeManager.object_type to allow building corlib.
12718 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
12720 * ecore.cs: handle System.Enum separately in LoadFromPtr().
12722 2002-07-01 Martin Baulig <martin@gnome.org>
12724 * class.cs: Make the last change actually work, we need to check
12725 whether `ifaces != null' to avoid a crash.
12727 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
12729 * class.cs: when we build structs without fields that implement
12730 interfaces, we need to add the interfaces separately, since there is
12731 no API to both set the size and add the interfaces at type creation
12734 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
12736 * expression.cs: the dimension arguments to the array constructors
12737 need to be converted if they are a long.
12739 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
12741 * class.cs: don't emit ldarg.0 if there is no parent constructor
12742 (fixes showstopper for corlib).
12744 2002-06-29 Martin Baulig <martin@gnome.org>
12746 MCS now compiles corlib on GNU/Linux :-)
12748 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
12749 ie. check for MethodImplOptions.InternalCall.
12751 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
12752 and TypeManager.attribute_type are null, so we must explicitly check
12753 whether parent is not null to find out whether it's an attribute type.
12754 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
12755 and SetBuilder, not only if the property is neither abstract nor external.
12756 This is necessary to set the MethodImplOptions on the accessor methods.
12757 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
12758 SetBuilder, see Property.Emit().
12760 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
12761 populate "System.Object", "System.ValueType" and "System.Attribute" since
12762 they've already been populated from BootCorlib_PopulateCoreTypes().
12764 2002-06-29 Martin Baulig <martin@gnome.org>
12766 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
12767 is the NullLiteral, we also need to make sure that target_type is not
12770 2002-06-29 Martin Baulig <martin@gnome.org>
12772 * rootcontext.cs (RootContext.ResolveCore): We must initialize
12773 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
12774 before calling BootstrapCorlib_ResolveDelegate ().
12776 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12778 * statement.cs: fixed build-breaker. All tests passed ok.
12780 2002-06-27 Martin Baulig <martin@gnome.org>
12782 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
12783 for System.Decimal when compiling corlib.
12785 2002-06-27 Martin Baulig <martin@gnome.org>
12787 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
12788 switch blocks which contain nothing but a default clause.
12790 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
12792 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
12794 2002-06-27 Martin Baulig <martin@gnome.org>
12796 * ecore.cs (PropertyExpr.PropertyExpr): Call
12797 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
12799 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
12800 is already a TypeBuilder.
12802 2002-06-27 Martin Baulig <martin@gnome.org>
12804 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
12805 `target_type == TypeManager.array_type', not IsAssignableFrom() in
12806 the "from an array-type to System.Array" case. This makes it work
12807 when compiling corlib.
12809 2002-06-27 Martin Baulig <martin@gnome.org>
12811 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
12812 non-static PropertyExpr, set its InstanceExpression. This makes
12813 the `ICollection.Count' property work in System/Array.cs.
12815 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
12817 * driver.cs: Made error handling more consistent. Errors now
12818 tracked by Report class, so many methods which used to return int
12819 now return void. Main() now prints success/failure and
12820 errors/warnings message.
12822 Renamed '--probe' compiler argument to '--expect-error'. Removed
12823 the magic number return values (123 and 124). Now, if the
12824 expected error occurs, the compiler exits with success (exit value
12825 0). If the compilation completes without seeing that particular
12826 error, the compiler exits with failure (exit value 1). The
12827 makefile in mcs/errors has been changed to handle the new behaviour.
12829 * report.cs: Made 'expected error' number a property and renamed
12830 it from 'Probe' to 'ExpectedError'.
12832 * genericparser.cs: Removed error handling support, since it is
12833 now all done by Report class.
12835 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
12836 class, so parse() no longer returns an int.
12838 * namespace.cs: Use Report.Error instead of GenericParser.error
12840 2002-06-22 Miguel de Icaza <miguel@ximian.com>
12842 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
12843 TypeContainer.AddOperator): At the front of the list put the
12844 explicit implementations, so they get resolved/defined first.
12846 2002-06-21 Miguel de Icaza <miguel@ximian.com>
12848 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
12849 interface type is implemented by this TypeContainer. Used during
12850 explicit interface implementation.
12852 (Property.Define, Indexer.Define, Method.Define): Validate that
12853 the given interface in the explicit implementation is one of the
12854 base classes for the containing type.
12856 Also if we are explicitly implementing an interface, but there is
12857 no match in the pending implementation table, report an error.
12859 (Property.Define): Only define the property if we are
12860 not explicitly implementing a property from an interface. Use the
12861 correct name also for those properties (the same CSC uses,
12862 although that is really not needed).
12864 (Property.Emit): Do not emit attributes for explicitly implemented
12865 properties, as there is no TypeBuilder.
12867 (Indexer.Emit): ditto.
12869 Hiding then means that we do not really *implement* a pending
12870 implementation, which makes code fail.
12872 2002-06-22 Martin Baulig <martin@gnome.org>
12874 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
12875 the return value of Object.GetType(). [FIXME: we need to do this whenever
12876 we get a type back from the reflection library].
12878 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
12880 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
12882 2002-06-20 Miguel de Icaza <miguel@ximian.com>
12884 * attribute.cs: Return null if we can not look up the type.
12886 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
12887 the interface types found.
12889 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
12890 interface types found.
12892 * typemanager.cs (GetInterfaces): Make this routine returns alll
12893 the interfaces and work around the lame differences between
12894 System.Type and System.Reflection.Emit.TypeBuilder in the results
12895 result for GetInterfaces.
12897 (ExpandInterfaces): Given an array of interface types, expand and
12898 eliminate repeated ocurrences of an interface. This expands in
12899 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
12902 2002-06-21 Martin Baulig <martin@gnome.org>
12904 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
12907 2002-06-21 Martin Baulig <martin@gnome.org>
12909 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
12910 and called with one of the core types, return the corresponding typebuilder for
12913 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
12916 2002-06-21 Martin Baulig <martin@gnome.org>
12918 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
12919 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
12920 (Expression.ConvertReferenceExplicit): Likewise.
12922 * expression.cs (ElementAccess.DoResolve): Likewise.
12923 (ElementAccess.DoResolveLValue): Likewise.
12925 2002-06-10 Martin Baulig <martin@gnome.org>
12927 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
12928 add the "value" parameter to the parameter list.
12930 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
12933 2002-06-19 Miguel de Icaza <miguel@ximian.com>
12935 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
12936 the argument to an int, uint, long or ulong, per the spec. Also
12937 catch negative constants in array creation.
12939 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
12941 * class.cs: do not allow the same interface to appear twice in
12942 the definition list.
12944 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
12946 * ecore.cs: don't use ldlen with System.Array.
12948 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
12950 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
12952 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
12954 * modifiers.cs: produce correct field attributes for protected
12955 internal. Easy fix so miguel can work on ther harder stuff:-)
12957 2002-06-18 Miguel de Icaza <miguel@ximian.com>
12959 * pending.cs: New file. Move the code from class.cs here.
12960 Support clearning the pending flag for all methods (when not doing
12961 explicit interface implementation).
12963 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
12965 * rootcontext.cs: added a couple more types needed to bootstrap.
12967 2002-06-17 Miguel de Icaza <miguel@ximian.com>
12969 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
12970 constructor in the type, instead of any constructor in the type
12971 hierarchy. Thanks to Paolo for finding this bug (it showed up as
12972 a bug in the Mono runtime when applying the params attribute).
12974 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
12975 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
12977 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
12979 * expression.cs (Unary.ResolveOperator): Use TypeManager
12980 to resolve the type.
12982 2002-06-13 Ravi Pratap <ravi@ximian.com>
12984 * cs-parser.jay (enum_member_declaration): Pass in the attributes
12987 * enum.cs (AddEnumMember): Add support to store the attributes associated
12988 with each member too.
12990 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
12991 field builders too - this takes care of the enum member case.
12993 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
12995 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
12996 address-of operator on both value types and pointers.
12998 2002-06-10 Martin Baulig <martin@gnome.org>
13000 * interface.cs (Interface.PopulateIndexer): Add the indexer's
13001 PropertyBuilder to the `property_builders' list.
13003 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
13004 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
13005 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
13006 find any indexers which are inherited from an interface.
13008 2002-06-09 Martin Baulig <martin@gnome.org>
13010 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
13011 the same type as the constant if necessary. There's also a test-130.cs
13014 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
13016 * typemanager.cs (TypeManager.ChangeType): Previously known as
13017 Enum.ChangeEnumType().
13019 2002-06-09 Martin Baulig <martin@gnome.org>
13021 * expression.cs (Cast.TryReduce): Added support for consts.
13023 2002-06-08 Ravi Pratap <ravi@ximian.com>
13025 * class.cs (Accessor): Hold attributes information so we can pass
13028 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
13029 Modify to pass in attributes attached to the methods.
13031 (add_accessor_declaration, remove_accessor_declaration): Ditto.
13033 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
13034 to handle the Accessor kind :-)
13036 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
13038 2002-06-08 Martin Baulig <martin@gnome.org>
13040 * expression.cs (Unary.TryReduceNegative): Added support for
13043 2002-06-08 Martin Baulig <martin@gnome.org>
13045 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
13046 name can't be found in the `defined_names' - the caller will do a
13047 MemberLookup in this case and thus find methods in System.Enum
13048 such as Enum.IsDefined().
13050 2002-06-08 Martin Baulig <martin@gnome.org>
13052 * enum.cs (Enum.ChangeEnumType): This is a custom version of
13053 Convert.ChangeType() which works with TypeBuilder created types.
13054 (Enum.LookupEnumValue, Enum.Define): Use it here.
13056 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
13057 `TypeBuilder.BaseType != null' check.
13058 (TypeContainer.FindMembers): Only lookup parent members if we
13059 actually have a parent.
13060 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
13061 (ConstructorInitializer.Resolve): Likewise.
13063 * interface.cs (Interface.FindMembers): Added
13064 `TypeBuilder.BaseType != null' check.
13066 * rootcontext.cs (RootContext.ResolveCore): Added
13067 "System.Runtime.CompilerServices.IndexerNameAttribute" to
13068 classes_second_stage.
13070 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
13071 debug_type and trace_type when compiling with --nostdlib.
13073 2002-06-07 Martin Baulig <martin@gnome.org>
13075 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
13076 (AddField): Set it to true when adding a non-static field.
13077 (DefineType): Use `have_nonstatic_fields' to find out whether we
13078 have non-static fields, not `Fields != null'.
13080 2002-06-02 Miguel de Icaza <miguel@ximian.com>
13082 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
13083 dereferencing a null on the static-field code path)
13085 2002-05-30 Martin Baulig <martin@gnome.org>
13087 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
13088 to take command line arguments. Use reflection to call the new
13089 custom `Initialize' function on the symbol writer and pass it the
13090 command line arguments.
13092 * driver.cs (--debug-args): New command line argument to pass command
13093 line arguments to the symbol writer.
13095 2002-05-28 Miguel de Icaza <miguel@ximian.com>
13097 * assign.cs (DoResolve): Forgot to do the implicit conversion to
13098 the target type for indexers and properties. Thanks to Joe for
13101 2002-05-27 Miguel de Icaza <miguel@ximian.com>
13103 * typemanager.cs (MethodFlags): returns the method flags
13104 (Obsolete/ShouldIgnore) that control warning emission and whether
13105 the invocation should be made, or ignored.
13107 * expression.cs (Invocation.Emit): Remove previous hack, we should
13108 not do this on matching a base type, we should do this based on an attribute
13110 Only emit calls to System.Diagnostics.Debug and
13111 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
13112 on the command line.
13114 * rootcontext.cs: Global settings for tracing and debugging.
13116 * cs-tokenizer.cs (define): New utility function to track
13117 defines. Set the global settings for TRACE and DEBUG if found.
13119 2002-05-25 Ravi Pratap <ravi@ximian.com>
13121 * interface.cs (Populate*): Pass in the TypeContainer as well as
13122 the DeclSpace as parameters so that we can create EmitContexts and
13123 then use that to apply attributes etc.
13125 (PopulateMethod, PopulateEvent, PopulateProperty)
13126 (PopulateIndexer): Apply attributes everywhere.
13128 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
13131 (ApplyAttributes): Update accordingly.
13133 We now apply interface attributes for all members too.
13135 2002-05-26 Miguel de Icaza <miguel@ximian.com>
13137 * class.cs (Indexer.Define); Correctly check if we are explicit
13138 implementation (instead of checking the Name for a ".", we
13139 directly look up if the InterfaceType was specified).
13141 Delay the creation of the PropertyBuilder.
13143 Only create the PropertyBuilder if we are not an explicit
13144 interface implementation. This means that explicit interface
13145 implementation members do not participate in regular function
13146 lookups, and hence fixes another major ambiguity problem in
13147 overload resolution (that was the visible effect).
13149 (DefineMethod): Return whether we are doing an interface
13152 * typemanager.cs: Temporary hack until we get attributes in
13153 interfaces (Ravi is working on that) and we get IndexerName
13154 support in interfaces.
13156 * interface.cs: Register the indexers as properties.
13158 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
13159 warning, I have verified that this is a bug in the .NET runtime
13160 (JavaScript suffers of the same problem).
13162 * typemanager.cs (MemberLookup): When looking up members for
13163 interfaces, the parent of an interface is the implicit
13164 System.Object (so we succeed in searches of Object methods in an
13165 interface method invocation. Example: IEnumerable x; x.ToString
13168 2002-05-25 Miguel de Icaza <miguel@ximian.com>
13170 * class.cs (Event): Events should also register if they do
13171 implement the methods that an interface requires.
13173 * typemanager.cs (MemberLookup); use the new GetInterfaces
13176 (GetInterfaces): The code used to lookup interfaces for a type is
13177 used in more than one place, factor it here.
13179 * driver.cs: Track the errors at the bottom of the file, we kept
13182 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
13183 instance if the method we are calling is static!
13185 2002-05-24 Miguel de Icaza <miguel@ximian.com>
13187 * attribute.cs (ApplyAttributes): Make this function filter out
13188 the IndexerName attribute (as that attribute in reality is never
13189 applied) and return the string constant for the IndexerName
13192 * class.cs (TypeContainer.Emit): Validate that all the indexers
13193 have the same IndexerName attribute, and if so, set the
13194 DefaultName attribute on the class.
13196 * typemanager.cs: The return value might contain other stuff (not
13197 only methods). For instance, consider a method with an "Item"
13198 property and an Item method.
13200 * class.cs: If there is a problem with the parameter types,
13203 2002-05-24 Ravi Pratap <ravi@ximian.com>
13205 * ecore.cs (ImplicitConversionExists): Wrapper function which also
13206 looks at user defined conversion after making a call to
13207 StandardConversionExists - we need this for overload resolution.
13209 * expression.cs : Update accordingly the various method calls.
13211 This fixes 2 bugs filed against implicit user defined conversions
13213 2002-05-22 Miguel de Icaza <miguel@ximian.com>
13215 * statement.cs: Track the result of the assignment.
13217 2002-05-21 Miguel de Icaza <miguel@ximian.com>
13219 * expression.cs (MemberAccess): Improved error reporting for
13220 inaccessible members.
13222 2002-05-22 Martin Baulig <martin@gnome.org>
13224 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
13225 itself with debugging support.
13227 2002-05-22 Martin Baulig <martin@gnome.org>
13229 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
13230 Removed, this isn't needed anymore.
13232 2002-05-20 Martin Baulig <martin@gnome.org>
13234 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
13235 be underlying type for an enum.
13237 2002-05-20 Miguel de Icaza <miguel@ximian.com>
13239 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
13240 that splits out the loading of just the core types.
13242 * rootcontext.cs (ResolveCore): Split the struct resolution in
13243 two, so we can load the enumeration underlying types before any
13246 * expression.cs (Is): Bandaid until we fix properly Switch (see
13247 bug #24985 for details).
13249 * typemanager.cs (ImplementsInterface): The hashtable will contain
13250 a null if there are no interfaces implemented.
13252 2002-05-18 Miguel de Icaza <miguel@ximian.com>
13254 * cs-parser.jay (indexer_declarator): It is fine to have array
13257 2002-05-17 Miguel de Icaza <miguel@ximian.com>
13259 * typemanager.cs: (RegisterBuilder): New function used to register
13260 TypeBuilders that implement interfaces. Since
13261 TypeBuilder.GetInterfaces (as usual) does not work with lame
13263 (AddUserType): register interfaces.
13265 (ImplementsInterface): Use the builder_to_ifaces hash if we are
13266 dealing with TypeBuilder. Also, arrays are showing up as
13267 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
13268 methods can not be invoked on them!
13270 * ecore.cs (ExplicitReferenceConversionExists): Made public.
13271 (ImplicitReferenceConversionExists): Split out from
13272 StandardConversionExists.
13274 * expression.cs (As): We were only implementing one of the three
13275 cases for the as operator. We now implement them all.
13276 (Is): Implement the various other cases for Is as well.
13278 * typemanager.cs (CACHE): New define used to control if we want or
13279 not the FindMembers cache. Seems to have a negative impact on
13280 performance currently
13282 (MemberLookup): Nested types have full acess to
13283 enclosing type members
13285 Remove code that coped with instance/static returns for events, we
13286 now catch this in RealFindMembers.
13288 (RealFindMembers): only perform static lookup if the instance
13289 lookup did not return a type or an event.
13291 2002-05-17 Miguel de Icaza <miguel@ximian.com>
13293 * assign.cs (CompoundAssign): We pass more semantic information
13294 now to Compound Assignments than we did before: now we have all
13295 the information at hand, and now we resolve the target *before* we
13296 do the expression expansion, which allows the "CacheValue" method
13297 to have the effect we intended (before, a [x] += 1 would generate
13298 two differen ArrayAccess expressions from the ElementAccess,
13299 during the resolution process).
13301 (CompoundAssign.DoResolve): Resolve target and original_source here.
13303 2002-05-16 Miguel de Icaza <miguel@ximian.com>
13305 * expression.cs (ArrayAccess): dropped debugging information.
13307 * typemanager.cs: Small bug fix: I was always returning i_members,
13308 instead of one of i_members or s_members (depending on which had
13311 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
13312 method is invoked before any code generation takes place, and it
13313 is a mechanism to inform that the expression will be invoked more
13314 than once, and that the method should use temporary values to
13315 avoid having side effects
13317 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
13319 * ecore.cs (Expression.CacheTemporaries): Provide empty default
13322 * expression.cs (Indirection, ArrayAccess): Add support for
13323 CacheTemporaries in these two bad boys.
13325 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
13326 ldobj or ldind_ref.
13327 (StoreFromPtr): Handle stobj as well.
13329 * expression.cs (UnaryMutator): Share more code.
13331 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
13332 down: I was not tracking the Filter function as well, which
13333 was affecting the results of the cache.
13335 2002-05-15 Miguel de Icaza <miguel@ximian.com>
13337 * attribute.cs: Remove the hack to handle the CharSet property on
13340 2002-05-14 Miguel de Icaza <miguel@ximian.com>
13342 * attribute.cs (DoResolve): More uglyness, we now only try to
13343 resolve the attribute partially, to extract the CharSet
13344 information (only if we are a StructLayout attribute). Otherwise
13346 (GetExtraTypeInfo): Add some code to conditionally kill in the
13347 future this. I am more and more convinced that the .NET
13348 framework has special code to handle the attribute setting on
13351 * expression.cs (IsParamsMethodApplicable): Revert my previous
13352 foreach change here, it was wrong.
13354 2002-05-13 Miguel de Icaza <miguel@ximian.com>
13356 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
13357 (pp_expr): do not abort on unknown input, just return.
13358 (eval): abort if there are pending chars.
13360 * attribute.cs (Attribute.Resolve): Positional parameters are
13361 optional. Deal with that case.
13363 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
13364 the Ansi/Unicode/Auto information for the type.
13366 (TypeContainer.DefineType): instantiate the EmitContext here, as
13367 we will be using it during the type definition (to resolve
13368 attributes) and during the emit phase.
13370 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
13371 to pull type information out of the attributes
13373 (Attribute.Resolve): track the constructor builder, and allow for
13374 multiple invocations (structs and classes will use this).
13376 * ecore.cs (MemberLookupFinal): new version with all the
13377 parameters customizable.
13379 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
13380 constructors. Return if the result value is null (as the error
13381 would have been flagged already by MemberLookupFinal)
13383 Do not allow instances of abstract classes or interfaces to be
13386 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
13387 We have to compare the assembly property here when dealing with
13388 FamANDAssem and Assembly access modifiers, because we might be
13389 creating an assembly from *modules* (that means that we are not
13390 getting TypeBuilders for types defined in other modules that are
13391 part of this assembly).
13393 (Method.Emit): If the method is marked abstract and has a body,
13396 (TypeContainer.DefineMembers): If both the defined member and the
13397 parent name match are methods, then do not emit any warnings: let
13398 the Method.Define routine take care of flagging warnings. But if
13399 there is a mismatch (method overrides something else, or method is
13400 overriwritten by something, then emit warning).
13402 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
13403 set to null, this means `do not check for the return type on the
13406 (Method.Define): set the return type for the method signature to
13407 null, so that we get methods with the same name and parameters and
13408 different return types. This is used to flag warning 114 (you are
13409 hiding a method, and you probably want to use the new/override
13412 * typemanager.cs (MemberLookup): Implemented proper access
13413 control, closing a long standing set of bug reports. The problem
13414 was that the Framework only has two bits: Public and NonPublic,
13415 and NonPublic includes private and protected methods, but we need
13416 to enforce the FamANDAssem, FamOrAssem and Family.
13418 2002-05-11 Miguel de Icaza <miguel@ximian.com>
13420 * statement.cs (GotoCase): Return true: Ammounts to giving up
13421 knowledge on whether we return or not, and letting the other case
13422 be responsible for it.
13424 2002-05-10 Miguel de Icaza <miguel@ximian.com>
13426 * driver.cs: Do not load directories for each file processed, only
13427 do it if there is a pattern.
13429 * ecore.cs: Report readonly assigns here as well, as we might have
13430 been resolved only by MemberAccess.
13432 (SimpleName.SimpleNameResolve): Also be useful for LValue
13433 resolution. We need this to propagate assign to local readonly variables
13435 * typemanager.cs: Use a ptrhashtable for the criteria, because we
13436 do not want to reuse potential criteria memory.
13438 * class.cs (MyEventBuilder): Set reflected_type;
13440 * ecore.cs (Constantify): Added support for constifying bools.
13442 (RootContext.LookupType): Added a cache for values looked up in
13443 the declaration space.
13445 * typemanager.cs (FindMembers): Now is a front-end to
13446 RealFindMembers, and provides a two-level hashtable-based cache to
13449 15% performance improvement: from 22.5 to 19.2 seconds.
13451 * expression.cs (IsParamsMethodApplicable): use foreach.
13452 (Invocation.DoResolve): ditto.
13453 (New.DoResolve): ditto.
13454 (ArrayCreation.DoResolve): ditto.
13456 * ecore.cs (FindMostEncompassingType): use foreach.
13458 * delegate.cs (NewDelegate.DoResolve): Use foreach
13460 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
13461 (RemoveMethods): use foreach.
13463 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
13464 nested foreach statements instead of for, and also break out of
13465 the inner loop once a match is found.
13467 (Invocation.OverloadResolve): Use foreach, simplify the code.
13469 2002-05-08 Miguel de Icaza <miguel@ximian.com>
13471 * cfold.cs (BinaryFold): During an enumeration evaluation context,
13472 we actually unwrap the expression to allow for extra information
13475 * expression.cs: Use Shr_Un on unsigned operations.
13477 2002-05-08 Ravi Pratap <ravi@ximian.com>
13479 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
13480 applicable operators was not being considered correctly. This closes
13481 the bug Miguel reported.
13483 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
13485 * attribute.cs: check that the type derives from System.Attribute
13486 and report the correct error in that case (moved the duplicate code to
13487 its own method, too).
13489 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
13491 * attribute.cs: lookup attribute type name as the spec says: first the
13492 bare attribute name and then name + "Attribute" (nant compiles with
13493 mcs after this fix).
13495 2002-05-07 Miguel de Icaza <miguel@ximian.com>
13497 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
13498 Because of the way we parse things, we should try to see if a
13499 UIntConstant can fit in an integer.
13501 2002-05-07 Ravi Pratap <ravi@ximian.com>
13503 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
13504 when we are in an explicit context.
13506 (ConvertReferenceExplicit): When converting from Iface type S to Class
13507 T make sure the rules are implemented as an OR.
13509 * parameter.cs (ParameterType): Make it a property for now although the
13510 purpose really isn't anything immediate.
13512 * expression.cs (Is*Applicable): Do better checking on the parameter type
13513 of a ref/out parameter. The ones from the system assemblies are already
13514 marked with the correct type so we don't need to do any correction.
13516 * ecore.cs (StandardConversionExists): Conversion from Interface types to
13517 the object type is standard too so include that.
13519 2002-05-06 Miguel de Icaza <miguel@ximian.com>
13521 * ecore.cs (StandardConversionExists): Augment with missing code:
13522 deal with IntConstant, LongConstants and Enumerations.
13524 * assign.cs: Report the error, instead of failing silently
13526 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
13527 typecontainer that they are declared, because the
13528 typecontainer/namespace will have the list of using clauses that
13529 need to be applied.
13531 Assembly Attributes were escaping the normal registration
13534 (EmitCode): Apply attributes within an EmitContext that represents
13535 the container they were declared on.
13537 * cs-parser.jay: Track bases for structs. How did I get this wrong?
13539 2002-05-06 Ravi Pratap <ravi@ximian.com>
13541 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
13542 Revamp completely - make much cleaner as we now operate only
13545 (FindMostSpecificSource, FindMostSpecificTarget): New methods
13546 to implement the logic detailed in the spec more correctly.
13548 (UserDefinedConversion): Update accordingly.
13550 2002-05-06 Miguel de Icaza <miguel@ximian.com>
13552 * statement.cs: Return flow analysis information up.
13554 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
13557 (token): Do not consume an extra character before calling
13560 2002-05-06 Piers Haken <piersh@friskit.com>
13562 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
13564 2002-05-06 Miguel de Icaza <miguel@ximian.com>
13566 * class.cs (Constructor.Emit): Set the IsStatic flag in the
13567 EmitContext during the instance constructor initializer
13568 resolution, to stop access to instance variables.
13570 This is mandated by the spec, last paragraph of the `constructor
13571 initializers' section.
13573 2002-05-05 Miguel de Icaza <miguel@ximian.com>
13575 * cs-parser.jay, class.cs (Accessor): new class used to represent
13576 an accessor (get or set). In the past we used `null' to represent
13577 a missing accessor. But this is ambiguous because there was no
13578 way to tell in abstract indexers/properties if one of them was
13581 Now there is a way of addressing that.
13583 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
13584 instead of FindMembers.
13586 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
13587 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
13589 * attribute.cs: Treat indexers and properties as the same in terms
13590 of applying attributes
13592 * ecore.cs (FindMostEncompassedType): Use statically initialized
13593 EmptyExpressions()s like we do elsewhere to avoid creating useless
13594 objects (and we take this out of the tight loop).
13596 (GetConversionOperators): Move the code to extract the actual
13597 operators to a separate routine to clean things up.
13599 2002-05-04 Miguel de Icaza <miguel@ximian.com>
13601 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
13602 events are always registered FieldBuilders.
13604 * class.cs (FieldBase): New class shared by Fields
13606 * delegate.cs: If we are a toplevel delegate, use our full name.
13607 If we are a nested delegate, then only use our tail name.
13609 2002-05-02 Ravi Pratap <ravi@ximian.com>
13611 * expression.cs (IsApplicable): Ensure that we add the "&" to
13612 ref/out types before comparing it with the type of the argument.
13614 (IsParamsMethodApplicable): Ditto.
13616 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
13619 * delegate.cs : Handle the case when we have more than one applicable
13620 method. Flag an error only when we finish checking all.
13622 2002-05-02 Miguel de Icaza <miguel@ximian.com>
13624 * expression.cs: Add support for boolean static initializers.
13626 2002-05-01 Miguel de Icaza <miguel@ximian.com>
13628 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
13630 * parameter.cs (ComputeParameterTypes,
13631 ComputeAndDefineParameterTypes): Better error handling: now we
13632 clear the `types' cache if we fail during any of the type lookups.
13633 We also return the status code correctly to our caller
13635 * delegate.cs: If we fail to define a delegate, abort the extra
13638 * expression.cs (Binary.ResolveOperator): for
13639 operator==(object,object) and operator !=(object, object) we also
13640 have to verify that there is an implicit conversion from one to
13643 (ArrayAccess.DoResolve): Array Access can operate on
13646 2002-04-30 Miguel de Icaza <miguel@ximian.com>
13648 * assign.cs (CompoundAssign): A new class used as a "flag" that
13649 the assignment actually is happening as part of a compound
13650 assignment operator.
13652 During compound assignment, a few new rules exist to enable things
13659 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
13660 to the type of x) if y is implicitly convertible to the type of x,
13661 and the operator is a builtin operator and the return type of the
13662 operator is explicitly convertible to the type of x.
13664 * rootcontext.cs: Reset warning level to 2. 4 catches various
13665 "interesting" features in mcs, we must clean this up at some
13666 point, but currently am trying to kill other bugs ;-)
13668 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
13669 in container classes as well.
13671 * expression.cs (Binary.ResolveOperator): Handle string case
13672 before anything else (as operator overloading does emit an error
13673 before doing anything else).
13675 This code could go away when we move to a table driven model, but
13676 i could not come up with a good plan last night.
13678 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
13680 * typemanager.cs (CSharpName): reimplementation using regex.
13681 * class.cs: added null check for fields in Emit
13682 * rootcontext.cs: set warninglevel to 4
13684 2002-04-29 Miguel de Icaza <miguel@ximian.com>
13686 * typemanager.cs (CSharpName): reimplemented with Lupus
13689 2002-04-28 Miguel de Icaza <miguel@ximian.com>
13691 * statement.cs (If): correclty implement Resolve, because we were
13692 not catching sem errors in there. The same process is needed
13694 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
13697 (Statement.Warning_DeadCodeFound): Factorize code.
13698 (While): Report dead code here too.
13700 (Statement): Added Resolve virtual method to allow
13701 for resolution split from the emit code.
13703 2002-04-26 Miguel de Icaza <miguel@ximian.com>
13705 * statement.cs (EmitBoolExpression): No longer try to resolve the
13707 (MakeBoolean): New utility function that resolve, implicitly
13708 converts to boolean and tags the expression.
13711 (If, Do): Implement dead code elimination.
13712 (While): Implement loop inversion
13714 (Do, While, For, If): Resolve the expression prior to calling our
13717 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
13720 - added method Report28 (warning: program has more than one entry point)
13721 - added method IsEntryPoint, implements paragraph 10.1 of the spec
13722 - modified method Method.Define, the part at the end of the method
13724 * rootcontext.cs: added static public Location EntryPointLocation;
13726 * ../errors/cs0028.cs : Add test case for the above warning.
13729 - modified method CSharpName to allow arrays of primitive type to
13730 be printed nicely (e.g. instead of System.Int32[][] it now prints
13732 - added method CSharpSignature: returns the signature of a method
13733 in string format to be used in reporting errors, warnings, etc.
13735 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
13738 2002-04-26 Ravi Pratap <ravi@ximian.com>
13740 * delegate.cs (Define): Fix extremely silly bug where I was
13741 setting the type of the 'object' parameter of the BeginInvoke
13742 method to System.IAsyncResult instead of System.Object ;-)
13744 2002-04-26 Miguel de Icaza <miguel@ximian.com>
13746 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
13749 (Constructor.Emit): return if we fail to initialize the
13750 constructor. Another door closed!
13752 * expression.cs (New.DoResolve): Improve error message (from -6 to
13753 1501). Use DeclaredOnly lookup to find the exact constructor.
13755 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
13756 loop. This is useful.
13758 * cs-parser.jay: Adjust the default parameters so that destructors
13759 have the proper signature.
13761 2002-04-26 Martin Baulig <martin@gnome.org>
13763 * driver.cs (LoadAssembly): If `assembly' contains any characters
13764 which are only valid in path names and not in assembly names
13765 (currently slash, backslash and point), use Assembly.LoadFrom ()
13766 instead of Assembly.Load () on the `assembly' (before iteration
13767 over the link_paths).
13769 2002-04-26 Martin Baulig <martin@gnome.org>
13771 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
13773 2002-04-25 Miguel de Icaza <miguel@ximian.com>
13775 * class.cs (Property): use the new typemanager.MemberLookup
13777 (TypeContainer.MemberLookup): Implement using the
13778 TypeManager.MemberLookup now.
13780 * typemanager.cs: Make MemberLookup a function of the TypeManager,
13781 and return MemberInfos, so that these can be used without an
13782 EmitContext (what we had before).
13784 2002-04-24 Miguel de Icaza <miguel@ximian.com>
13786 * expression.cs: Fix the case where the argument to params if the
13787 type of the params. I omitted handling this before. Fixed
13789 2002-04-22 Miguel de Icaza <miguel@ximian.com>
13791 * driver.cs: Call BootCorlib_PopulateCoreType
13793 * class.cs (Property.CheckBase): Check for properties only, not
13796 * interface.cs: Temporary hack: try/catch around the
13797 CustomAttributeBuilder, because I am getting an exception that I
13800 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
13801 types whose definitions are required to be there (attributes are
13802 defined before standard types).
13804 Compute definitions as we boot the various types, as they are used
13805 immediately (value_type class will need object_type, but if we do
13806 not initialize object_type, we will pass a null, which will let
13807 the runtime pick the System.Object from the existing corlib, which
13808 is not what we want).
13810 2002-04-22 Patrik Torstensson <totte@labs2.com>
13812 * cs-tokenizer.cs: fixed a number of trim() issues.
13814 2002-04-22 Ravi Pratap <ravi@ximian.com>
13816 * expression.cs (Argument.Type): Ensure that we return the correct
13817 type when we have out or ref parameters [in which case we
13820 2002-04-22 Miguel de Icaza <miguel@ximian.com>
13822 * class.cs (Property, Indexer): Allow extern modifier in there.
13824 * typemanager.cs (InitBaseTypes): Initializes object_type and
13825 value_type, since those will be used early on during the bootstrap
13826 process to compile corlib.
13828 (InitCoreTypes): Move code from here to InitBaseTypes.
13830 2002-04-21 Miguel de Icaza <miguel@ximian.com>
13832 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
13833 single-dimension arrays as using the ldlen opcode.
13835 Daniel Lewis discovered this optimization.
13837 * typemanager.cs: Add signature for System.Array::get_Length
13839 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13841 * statement.cs: report the error when the foreach does not apply to an
13842 array nor a collection.
13844 2002-04-19 Miguel de Icaza <miguel@ximian.com>
13846 * expression.cs: Add implicit conversions to the operator ~.
13848 * constant.cs (DecimalConstant.Emit): Emit decimal value.
13850 * typemanager.cs: Locate the decimal constructor.
13852 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13854 * attribute.cs: use the new property of TypeOf.
13855 * expression.cs: added 'get' property around typearg.
13857 These changes fix a build breaker reported by NickD. Is this the
13858 correct way to fix? If not, please, revert my changes and make it
13861 2002-04-17 Miguel de Icaza <miguel@ximian.com>
13863 * attribute.cs: Add support for typeof in attribute invocations.
13864 I am not sure that this is right though.
13866 2002-04-14 Duncan Mak <duncan@ximian.com>
13868 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
13869 Binary.Operator.Division case.
13871 2002-04-13 Ravi Pratap <ravi@ximian.com>
13873 * class.cs (DefineType): Ensure that we do a proper check on
13874 attribute types and also register it with the TypeManager.
13876 (TypeContainer.Targets): The default for attribute types is
13877 AttributeTargets.All.
13879 * attribute.cs (ApplyAttributes): Registering the attribute type
13880 is done elsewhere, not when we discover we have a Usage attribute.
13882 2002-04-12 Ravi Pratap <ravi@ximian.com>
13884 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
13885 and get rid of is_delegate parameter.
13887 * everywhere : update.
13889 2002-04-12 Ravi Pratap <ravi@ximian.com>
13891 * cs-parser.jay (compilation_unit): Revamp completely to use
13892 some new ideas that I got from Rhys' grammar to solve the problems
13893 with assembly level attributes.
13895 (outer_declaration): New grammar production.
13897 (attribute_sections): Add.
13899 (opt_attributes): Base on attribute_sections
13901 (namespace_declaration): Allow opt_attributes to tackle the case
13902 when we have assembly level attributes - we are clever in this
13905 * attribute.cs (ApplyAttributes): Do not worry about assembly
13906 attributes in the non-global context.
13908 * rootcontext.cs (AddGlobalAttributes): Go back to using this
13909 instead of SetGlobalAttributes.
13911 * class.cs, rootcontext.cs : Ensure we define and generate
13912 attribute types before anything else.
13914 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
13915 and flag the new error -20 for the case when the attribute type
13916 does not have valid targets specified. csc does not catch this.
13918 * ../errors/errors.txt : update for error # -20
13920 2002-04-11 Ravi Pratap <ravi@ximian.com>
13922 * support.cs (InternalParameters.ParameterModifier): Do some null
13923 checking and return sane values.
13925 * class.cs (Method.Define): If we are a PInvoke method, ensure
13926 that we are static and extern. Report error # 601
13928 * ../errors/cs0601.cs : Add test case for the above error.
13930 2002-04-07 Ravi Pratap <ravi@ximian.com>
13932 * rootcontext.cs (attribute_types): We need to keep type of
13933 all attribute types separately and emit code for them first.
13935 (RegisterAttribute) : Implement.
13937 * class.cs (DefineType): Check if the current Type is a custom
13938 attribute type and register it accordingly.
13940 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
13941 adding the first attribute twice and rename to
13943 (SetGlobalAttributes): this.
13945 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
13948 * attribute.cs (ApplyAttributes): Take an additional argument telling us
13949 if we are processing global arguments. Hmm, I am unsure of this.
13951 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13953 * expression.cs: added static array of strings to avoid calling
13954 Enum.ToString () for Operator in Binary. Significant recover of
13957 2002-04-10 Miguel de Icaza <miguel@ximian.com>
13959 * class.cs (FindMembers): Allow the Builders of the various
13960 members to be null. If they are skip them. This only happens
13961 during the PInvoke declaration.
13963 2002-04-09 Miguel de Icaza <miguel@ximian.com>
13965 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
13966 failure, so we do not keep going afterwards.
13968 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
13969 wanted to pass `false' as the `is_delegate' argument. If this is
13970 the case, why not use delegate_type == null to mean `is_delegate =
13971 false' and anything else as is_delegate = true.
13973 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
13975 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
13976 code for the section, not the beginning of the tests.
13978 2002-04-08 Miguel de Icaza <miguel@ximian.com>
13980 * cfold.cs: Handle operator + (Enum x, Underlying x)
13982 * expression.cs (Binary): same. Warn about errors where we have
13983 Enum/Enum in operator + as well.
13985 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
13988 - added support for switch(bool)
13989 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
13990 - add TableSwitchEmit() to handle table-based switch statements
13992 2002-04-05 Ravi Pratap <ravi@ximian.com>
13994 * expression.cs (Invocation.OverloadResolve): Factor out code which
13995 does parameter compatibility checking with arguments so that we can
13996 re-use the code even from Delegate.VerifyApplicability
13998 (VerifyArgumentsCompat): Move above code here.
14000 * delegate.cs (VerifyApplicability): Get rid of duplicate code
14001 and instead make a call to the above method.
14003 2002-03-31 Ravi Pratap <ravi@ximian.com>
14005 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
14006 We use it to keep track of classes which are attribute types.
14008 2002-04-02 Miguel de Icaza <miguel@ximian.com>
14010 * delegate.cs (Delegate.Define): Correctly define the types in the
14011 presence of fixed and array parameters.
14013 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
14016 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
14017 include NonPublic after the first iteration.
14019 * class.cs (Indexer.CheckBase): Only check if both parents are
14022 * cs-parser.jay (accessor_body): If empty, set to null.
14024 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
14025 same code path here to resolve constants names that we did have in
14026 MemberAccess.DoResolve. There is too much code duplicated here.
14028 2002-04-01 Miguel de Icaza <miguel@ximian.com>
14030 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
14032 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
14035 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
14036 tokens, numbers and strings.
14038 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
14041 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
14042 asyncronous parameters and the regular parameters.
14044 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
14045 specify the target directory.
14047 * expression.cs: (This.DoResolve): Simplify
14048 (As.Emit): Optimize, do not generate IsInst if the expression is
14049 always of the given type.
14051 (Is.DoResolve): Bug fix, we were reporting both always/never for
14054 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
14055 creating too many unnecessary arrays.
14057 2002-03-31 Miguel de Icaza <miguel@ximian.com>
14059 * class.cs (EmitFieldInitializer): Use Assign expression to assign
14060 fields instead of rolling our own initializer. Takes care of all
14061 implicit conversions, and drops unnecessary static checks/argument.
14063 2002-03-31 Dick Porter <dick@ximian.com>
14065 * driver.cs: use the GetDirectories() return values properly, and
14066 use "/" as path separator.
14068 2002-03-30 Miguel de Icaza <miguel@ximian.com>
14070 * expression.cs (Unary): Optimize - - expr into expr.
14071 (Binary): Optimize a + (-b) into a -b.
14073 * codegen.cs (CodeGen): Made all methods static.
14075 2002-03-29 Miguel de Icaza <miguel@ximian.com>
14079 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
14080 TypeBuilder property.
14082 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
14085 * tree.cs: Removed the various RecordXXXX, and replaced with a
14086 single RecordDecl. Removed all the accessor methods, and just
14087 left a single access point Type
14089 * enum.cs: Rename DefineEnum to DefineType.
14091 * decl.cs: New abstract method `DefineType' used to unify the
14092 Defines for Enumerations, Interfaces, TypeContainers and
14095 (FindType): Moved LookupInterfaceOrClass here. Moved the
14096 LookupBaseClasses method that used to live in class.cs and
14097 interface.cs here, and renamed to FindType.
14099 * delegate.cs: Implement DefineType. Take advantage of the
14100 refactored pattern for locating the parent builder without taking
14101 the parent_builder argument (which we know does not work if we are
14102 nested, and triggering a toplevel definition).
14104 2002-03-28 Miguel de Icaza <miguel@ximian.com>
14106 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
14107 accessibility of a member has changed during override and report
14110 * class.cs (Method.Define, Property.Define): Only complain on
14111 overrides if the method is private, any other accessibility is
14112 fine (and since we just checked the permission is the same, we are
14115 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
14116 and elif are processed always. The other pre-processing
14117 directives are only processed if we are "taking" the path
14119 2002-03-29 Martin Baulig <martin@gnome.org>
14121 * class.cs (Method.Emit): Only emit symbolic debugging info if the
14122 current location is not Null.
14124 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
14125 a separate method so we can profile it.
14127 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
14128 `span.Seconds' are just seconds, but no minutes or hours.
14129 (MainDriver): Profile the CodeGen.SaveSymbols calls.
14131 2002-03-28 Miguel de Icaza <miguel@ximian.com>
14133 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
14134 Remove the gratuitous set of Final:
14136 // If an interface implementation, then we can set Final.
14137 if (((flags & MethodAttributes.Abstract) == 0) &&
14138 implementing.DeclaringType.IsInterface)
14139 flags |= MethodAttributes.Final;
14141 I do not know what I was smoking when I used that.
14144 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
14145 step into fixing the name resolution issues for delegates and
14146 unifying the toplevel name resolution.
14148 2002-03-28 Martin Baulig <martin@gnome.org>
14150 * class.cs (Method.Emit): If we have a symbol writer, call its
14151 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
14152 tell it about the current method.
14154 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
14155 writer that we're going to emit the first byte of IL code for a new
14156 statement (a new source line).
14157 (EmitContext.EmitTopBlock): If we have a symbol writer, call
14158 EmitContext.Mark() before emitting any code.
14160 * location.cs (SymbolDocument): Return null when we're Null.
14162 * statement.cs (Statement): Moved the `Location loc' variable here.
14163 (Statement.EmitBoolExpression): If we have a symbol writer, call
14164 ec.Mark() before emitting any code to tell it that we're at the
14165 beginning of a new statement.
14166 (StatementExpression): Added `Location' argument to the constructor.
14167 (Block): Added public readonly variable `StartLocation' and public
14168 variable `EndLocation'. The latter is to be set using SetEndLocation().
14169 (Block): Added constructor which takes a start and end location.
14170 (Block.SetEndLocation): New method. This sets the end location.
14171 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
14172 local variables we create.
14173 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
14174 each statement and do also mark the begin and end of the block.
14176 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
14177 tell it the current lexer.Location, use Location.Null for the end of the
14179 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
14180 current block, set its end location using SetEndLocation().
14181 (statement_expression): StatementExpression constructor now takes the
14182 lexer.Location as additional argument.
14183 (for_statement, declare_local_variables): Likewise.
14184 (declare_local_variables): When creating a new implicit block, use the
14185 new Block constructor and pass it the lexer.Location.
14187 2002-03-28 Miguel de Icaza <miguel@ximian.com>
14189 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
14190 members also on the parent interfaces recursively.
14192 2002-03-27 Miguel de Icaza <miguel@ximian.com>
14194 * report.cs: Use new formats, since Gonzalo finished the missing
14197 * expression.cs (Binary.ResolveOperator): added missing operator|
14198 operator& and operator^ for bool/bool.
14200 * cs-parser.jay: CheckDef now takes a Location argument that is
14201 used to report errors more precisly (instead of reporting the end
14202 of a definition, we try to track something which is a lot closer
14203 to the source of the problem).
14205 * cs-tokenizer.cs: Track global token use, so we can properly flag
14206 the use of #define/#undef after the first token has been seen.
14208 Also, rename the reportXXXX to Error_DescriptiveName
14210 * decl.cs (DeclSpace.IsTopLevel): Move property here from
14211 TypeContainer, so that Enum and Interface can use this too.
14213 * class.cs (TypeContainer.LookupInterfaceOrClass,
14214 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
14215 `builder' argument. Typically this was used to pass the parent
14216 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
14219 The problem is that a nested class could trigger the definition of
14220 a toplevel class, and the builder would be obviously wrong in that
14223 So we drop this argument, and we compute dynamically the
14224 TypeBuilder/ModuleBuilder (the correct information was available
14225 to us anyways from DeclSpace.Parent)
14227 * interface.cs (Interface.DefineInterface): Drop builder
14228 parameter cleanup like class.cs
14230 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
14233 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
14236 (Try.Emit): Propagate the returns value from the statement.
14238 (Return.Emit): Even if we are leavning
14240 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
14242 * modifiers.cs: Fix the computation of MethodAttributes flags.
14244 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
14246 * driver.cs: allow compilation of files that start with '/'.
14247 Add a default case when checking the argument of --target.
14249 2002-03-25 Miguel de Icaza <miguel@ximian.com>
14251 * interface.cs: Implement the same search algorithm for types in
14252 the interface code.
14254 * delegate.cs: Do not allow multiple definition.
14256 * Recovered ChangeLog that got accidentally amputated
14258 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
14260 * rootcontext.cs: Load manually enum to allow core classes to
14261 contain enumerations.
14263 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
14264 Update to new static methods in TypeManager.
14266 * typemanager.cs (GetMethod, GetConstructor): Use our
14267 implementation of FindMembers to find the members, since during
14268 corlib compilation, the types are TypeBuilders and GetMethod and
14269 GetConstructor do not work.
14271 Make all methods in TypeManager static.
14273 (InitCodeHelpers): Split the functionality from
14274 the InitCodeTypes function.
14276 * driver.cs: Call InitCodeHelpers after we have populated the
14279 * cs-parser.jay (delegate_declaration): we did not used to compute
14280 the delegate name correctly for void delegates.
14282 2002-03-24 Miguel de Icaza <miguel@ximian.com>
14284 * rootcontext.cs (RootContext): Init the interface_resolve_order
14285 and type_container_resolve_order always.
14287 (ResolveCore, BootstrapCorlib_ResolveClass,
14288 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
14289 compiler when compiling with --nostdlib
14291 * class.cs (TypeContainer.DefineType): Check that our parent is
14292 not null. This test is most important when we are bootstraping
14295 * codegen.cs: Split out the symbol writing code.
14297 2002-03-25 Martin Baulig <martin@gnome.org>
14299 * driver.cs (-g): Made -g an alias for --debug.
14301 2002-03-24 Martin Baulig <martin@gnome.org>
14303 * codegen.cs (SymbolWriter): New public variable. Returns the
14304 current symbol writer.
14305 (CodeGen): Added `bool want_debugging_support' argument to the
14306 constructor. If true, tell the ModuleBuild that we want debugging
14307 support and ask it for the ISymbolWriter.
14308 (Save): If we have a symbol writer, call it's Close() method after
14309 saving the assembly.
14311 * driver.c (--debug): New command line argument to create a
14312 debugger information file.
14314 * location.cs (SymbolDocument): New public property. Returns an
14315 ISymbolDocumentWriter object for the current source file or null
14316 if we don't have a symbol writer.
14318 2002-03-21 Miguel de Icaza <miguel@ximian.com>
14320 * driver.cs (LoadAssembly): Correctly return when all the paths
14321 have been tried and not before.
14323 * statement.cs (Switch.Emit): return the actual coverage for this
14324 statement (returns/not-returns)
14326 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
14327 switch of the statement if we are the last switch section. That
14328 kills two problems: try/catch problems (we used to emit an empty
14329 nop at the end) and switch statements where all branches would
14332 2002-03-19 Miguel de Icaza <miguel@ximian.com>
14334 * driver.cs: Add default assemblies (the equivalent to the
14335 Microsoft CSC.RSP file)
14337 * cs-tokenizer.cs: When updating `cols and setting it to zero,
14338 also update tokens_seen and set it to false.
14340 * driver.cs: Implement --recurse for Mike.
14342 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
14343 correctly splitting out the paths.
14345 2002-03-18 Miguel de Icaza <miguel@ximian.com>
14347 * interface.cs (Interface.PopulateProperty): Instead of using
14348 `parent' as the declaration space for the set parameters, use
14351 * support.cs (InternalParameters): InternalParameters constructor
14352 takes a DeclSpace instead of a TypeContainer.
14354 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
14355 types are being initialized, load the address of it before calling
14358 (New): Provide a mechanism to disable the generation of local
14359 value type temporaries when the caller will be providing us with
14360 an address to store it.
14362 (ArrayCreation.EmitDynamicInitializers): Use it.
14364 2002-03-17 Miguel de Icaza <miguel@ximian.com>
14366 * expression.cs (Invocation.EmitArguments): Only probe for array
14367 property if there is more than one argument. Sorry about that.
14369 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
14370 empty param arrays.
14372 * class.cs (Method.LabelParameters): Fix incorrect code path that
14373 prevented the `ParamArrayAttribute' from being applied to the
14376 2002-03-16 Miguel de Icaza <miguel@ximian.com>
14378 * support.cs (ReflectionParameters): Correctly compute whether the
14379 last argument is a params array. Fixes the problem with
14382 * typemanager.cs: Make the assemblies array always be non-null
14383 (empty, but non-null)
14385 * tree.cs (RecordDecl): New function that abstracts the recording
14386 of names. This reports error 101, and provides a pointer to the
14387 previous declaration. Fixes a crash in the compiler.
14389 * cs-parser.jay (constructor_declaration): Update to new grammar,
14390 and provide a constructor_body that can be empty.
14392 2002-03-15 Miguel de Icaza <miguel@ximian.com>
14394 * driver.cs: Add support for --resources.
14396 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
14397 Make all types for the various array helper methods be integer.
14399 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
14400 CheckState to ConvCast.
14402 (ConvCast): Now it takes a `checked' state argument, to avoid
14403 depending on the emit context for the conversion, and just using
14404 the resolve time setting.
14406 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
14407 instead of Invocation.EmitArguments. We do not emit the original
14408 arguments, instead we emit those which have been converted to
14409 unsigned int expressions.
14411 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
14413 * codegen.cs: ditto.
14415 * expression.cs (LocalVariableReference): Drop the use of the
14416 Store function that depended on the variable index.
14418 * statement.cs (VariableInfo): Drop the `Idx' property from this
14419 class, as this is not taking into account the indexes for
14420 temporaries tat we generate during the execution, getting the
14423 * class.cs: First emit class initializers, then call the parent
14426 * expression.cs (Binary): Fix opcode emision.
14427 (UnaryMutator.EmitCode): Support checked code generation
14429 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
14430 matches for events for both the Static and Instance scans,
14431 pointing to the same element. Fix that.
14433 2002-03-14 Miguel de Icaza <miguel@ximian.com>
14435 * rootcontext.cs (ResolveTree): Always set the
14436 interface_resolve_order, because nested interfaces will be calling
14439 * class.cs (GetInterfaceOrClass): Track the same resolution
14440 process used by TypeManager.LookupType. This fixes the nested
14441 type lookups in class declarations (separate path from
14444 (TypeContainer.DefineType): Also define nested interfaces.
14445 (TypeContainer.RegisterOrder): New public function used to
14446 register the order in which child interfaces need to be closed.
14448 Nested interfaces need to be closed after their parents have been
14451 * interface.cs (InterfaceAttr): Put all the logic for computing
14452 the interface attribute here.
14454 (DefineInterface): Register our interface order with the
14455 RootContext or with the TypeContainer depending on the case.
14457 2002-03-12 Miguel de Icaza <miguel@ximian.com>
14459 * cs-parser.jay: rework foreach statement to work with the new
14460 changes to the policy on SimpleNames.
14462 * report.cs: support Stacktrace on warnings as well.
14464 * makefile: drop --unsafe and /unsafe from the compile.
14466 2002-03-13 Ravi Pratap <ravi@ximian.com>
14468 * ecore.cs (StandardConversionExists): Modify to take an Expression
14469 as the first parameter. Ensure we do null -> reference type conversion
14472 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
14473 temporary Expression objects.
14475 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
14477 * interface.cs: workaround bug in method overloading resolution
14478 (there is already a bugzilla bug for it).
14480 2002-03-12 Miguel de Icaza <miguel@ximian.com>
14482 We could also solve this problem by having a separate path for
14483 performing type lookups, instead of DoResolve, we could have a
14484 ResolveType entry point, and only participating pieces of the
14485 production (simplename, deref, array) would implement this.
14487 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
14488 signal SimpleName to only resolve type names and not attempt to
14489 resolve anything else.
14491 * expression.cs (Cast): Set the flag.
14493 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
14495 * class.cs: Only report 108 if there is no `new' modifier.
14497 * cs-parser.jay: rework foreach statement to work with the new
14498 changes to the policy on SimpleNames.
14500 * report.cs: support Stacktrace on warnings as well.
14502 * makefile: drop --unsafe and /unsafe from the compile.
14504 2002-03-11 Miguel de Icaza <miguel@ximian.com>
14506 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
14507 lookups here, instead of doing that at parse time. This means
14508 that our grammar will not introduce `LocalVariableReferences' as
14509 expressions at this point. That solves the problem of code like
14513 static void Main ()
14517 This is only half the fix. The full fix requires parameters to
14518 also be handled in this way.
14520 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
14521 makes the use more obvious of the DeclSpace. The
14522 ec.TypeContainer.TypeBuilder is now only used to pull the
14523 TypeBuilder for it.
14525 My theory is that I can get rid of the TypeBuilder completely from
14526 the EmitContext, and have typecasts where it is used (from
14527 DeclSpace to where it matters).
14529 The only pending problem is that the code that implements Aliases
14530 is on TypeContainer, and probably should go in DeclSpace.
14532 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
14533 lookups here, instead of doing that at parse time. This means
14534 that our grammar will not introduce `LocalVariableReferences' as
14535 expressions at this point. That solves the problem of code like
14539 static void Main ()
14543 This is only half the fix. The full fix requires parameters to
14544 also be handled in this way.
14546 * class.cs (Property.DefineMethod): When implementing an interface
14547 method, set newslot, when implementing an abstract method, do not
14548 set the flag (before we tried never setting it, or always setting
14549 it, which is the difference).
14550 (Indexer.DefineMethod): same.
14551 (Method.DefineMethod): same.
14553 * ecore.cs: Only set the status used flag if we get back a Field.
14555 * attribute.cs: Temporary hack, so Paolo can keep working.
14557 2002-03-08 Ravi Pratap <ravi@ximian.com>
14559 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
14560 the unmanaged type in the case we have a MarshalAs attribute.
14562 (Resolve): Handle the case when we are parsing the special MarshalAs
14563 attribute [we need to store the unmanaged type to use later]
14565 * typemanager.cs (marshal_as_attr_type): Built in type for the
14566 MarshalAs Attribute.
14568 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
14569 on parameters and accordingly set the marshalling info.
14571 2002-03-09 Miguel de Icaza <miguel@ximian.com>
14573 * class.cs: Optimizing slightly by removing redundant code after
14574 we switched to the `NoTypes' return value.
14575 (Property.DefineMethod): use NoTypes here too.
14577 This fixes the bug I introduced in my last batch of changes.
14579 2002-03-05 Ravi Pratap <ravi@ximian.com>
14581 * tree.cs (RecordEnum): Add. We now keep track of enums too.
14583 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
14584 Enums since those are types too.
14586 * cs-parser.jay (enum_declaration): Record enums as we parse them.
14588 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
14589 thanks to a call during the lookup process.
14591 2002-03-07 Miguel de Icaza <miguel@ximian.com>
14593 * statement.cs (Foreach): Lots of work to accomodate a particular
14594 kind of foreach statement that I had not kept in mind. It is
14595 possible to have foreachs on classes that provide a GetEnumerator
14596 method that return objects that implement the "pattern" for using
14597 a foreach, there is no need to support GetEnumerator
14600 This is needed to compile nant.
14602 * decl.cs: Only report 114 if the member is not `Finalize' and if
14603 the warning level is at least 2.
14605 * class.cs: Moved the compare function from Method to
14608 (MethodSignature.InheritableMemberSignatureCompare): Add new
14609 filter function that is used to extract inheritable methods from a
14612 (Method.Define): Use the new `inheritable_method_signature_filter'
14615 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
14618 2002-03-06 Miguel de Icaza <miguel@ximian.com>
14620 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
14622 * cs-parser.jay: Add opt_semicolon to the interface declaration.
14624 * expression.cs: Pass location information to
14625 ConvertImplicitStandard.
14627 * class.cs: Added debugging code to track return values from
14630 2002-03-05 Miguel de Icaza <miguel@ximian.com>
14632 * expression.cs (Is.DoResolve): If either side of the `is' is an
14633 interface, do not flag the warning.
14635 * ecore.cs (ImplicitReferenceConversion): We need a separate test
14638 * report.cs: Allow for --fatal to be used with --probe.
14640 * typemanager.cs (NoTypes): Move the definition for the empty Type
14643 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
14645 (TypeContainer.DefineProxy): New function used to proxy to parent
14646 implementations when implementing interfaces.
14647 (TypeContainer.ParentImplements): used to lookup if our parent
14648 implements a public function that is required by an interface.
14649 (TypeContainer.VerifyPendingMethods): Hook this up.
14651 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
14652 `modules' and `assemblies' arraylists into arrays. We only grow
14653 these are the very early start up of the program, so this improves
14654 the speedof LookupType (nicely measured).
14656 * expression.cs (MakeByteBlob): Replaced unsafe code with
14657 BitConverter, as suggested by Paolo.
14659 * cfold.cs (ConstantFold.Binary): Special case: perform constant
14660 folding of string concatenation, but if either side is a string,
14661 and the other is not, then return null, and let the runtime use
14662 the concatenation on the string plus the object (using
14663 `Object.ToString').
14665 2002-03-04 Miguel de Icaza <miguel@ximian.com>
14667 Constant Folding has been implemented now.
14669 * expression.cs (Unary.Reduce): Do not throw an exception, catch
14670 the error instead on types that are not supported in one's
14673 * constant.cs (Constant and all children): New set of functions to
14674 perform implict and explicit conversions.
14676 * ecore.cs (EnumConstant): Implement the new functions to perform
14677 conversion by proxying to the child expression.
14679 * codegen.cs: (ConstantCheckState): Constant evaluation has its
14680 own separate setting that can not be turned off from the command
14681 line using --unchecked or --checked and is only controlled using
14682 the checked/unchecked statements and expressions. This setting is
14683 used by the constant folder to flag errors.
14685 * expression.cs (CheckedExpr, UncheckedExpr): Set the
14686 ConstantCheckState as well.
14688 During Resolve, they also have to flag the state, because the
14689 constant folder runs completely in the Resolve phase.
14691 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
14694 2002-03-01 Miguel de Icaza <miguel@ximian.com>
14696 * cfold.cs: New file, this file contains the constant folder.
14698 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
14699 argument to track whether we are using the resulting address to
14700 load or store a value and provide better error messages.
14702 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
14703 new AddressOf arguments.
14705 * statement.cs (Foreach.EmitCollectionForeach): Update
14707 * expression.cs (Argument.Emit): Call AddressOf with proper
14708 arguments to track usage.
14710 (New.DoEmit): Call AddressOf with new arguments.
14712 (Unary.Emit): Adjust AddressOf call.
14714 2002-03-01 Ravi Pratap <ravi@ximian.com>
14716 * cs-parser.jay (member_access): Change the case for pre-defined types
14717 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
14720 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
14723 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
14724 essentially like methods and apply attributes like MethodImplOptions to them too.
14726 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
14729 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
14730 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
14733 * Update code everywhere accordingly.
14735 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
14737 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
14739 2002-02-28 Ravi Pratap <ravi@ximian.com>
14741 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
14742 try performing lookups against those instead of jumping straight into using
14743 the 'using' clauses.
14745 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
14747 (LookupType): Perform lookups in implicit parents too.
14749 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
14750 sequence as RootContext.LookupType.
14752 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
14753 the various cases of namespace lookups into this method.
14755 2002-03-01 Miguel de Icaza <miguel@ximian.com>
14757 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
14758 in positional arguments)
14760 * class.cs (Operator): Update the AllowedModifiers to contain
14763 * cs-parser.jay: Update operator declaration to allow for the
14764 operator body to be empty.
14766 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
14769 2002-02-27 Miguel de Icaza <miguel@ximian.com>
14771 * class.cs (Method.Emit): Label parameters.
14773 * driver.cs: Return 1 or 0 as the program exit code.
14775 2002-02-26 Miguel de Icaza <miguel@ximian.com>
14777 * expression.cs: Special case the `null' object when trying to
14778 auto-compute the type, as anything can be explicitly converted to
14781 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
14782 spotting this Paolo.
14784 (Expression.ImplicitNumericConversion): Perform comparissions of
14785 the type using the underlying type in the case of an enumeration
14786 rather than using the enumeration type for the compare.
14788 Cope with the underlying == type case, which is not possible to
14791 (Expression.ConvertNumericExplicit): Perform comparissions of
14792 the type using the underlying type in the case of an enumeration
14793 rather than using the enumeration type for the compare.
14795 * driver.cs: If the user does not supply an extension, assume .exe
14797 * cs-parser.jay (if_statement): Rewrote so that we can track the
14798 location for the if statement.
14800 * expression.cs (Binary.ConstantFold): Only concat strings when
14801 the operation is "+", not everything ;-)
14803 * statement.cs (Statement.EmitBoolExpression): Take a location
14805 (If, While, Do): Track location.
14807 * expression.cs (Binary.ResolveOperator): In the object + string
14808 case, I was missing a call to ConvertImplicit
14810 2002-02-25 Ravi Pratap <ravi@ximian.com>
14812 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
14813 Location arguments. Ensure we use RootContext.LookupType to do our work
14814 and not try to do a direct Type.GetType and ModuleBuilder.GetType
14816 * interface.cs (PopulateMethod): Handle the type of the parameter being
14819 * expression.cs (Invocation.BetterFunction): Handle the case when we
14820 have a params method with no fixed arguments and a call is made with no
14823 2002-02-25 Miguel de Icaza <miguel@ximian.com>
14825 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
14826 the verbatim-string-literal
14828 * support.cs (InternalParameters.ParameterModifier): handle null
14830 (InternalParameters.ParameterType): ditto.
14832 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
14833 duplicating the name of the variable parameter.
14834 (GetParameterByName): Fix bug where we were not looking up array
14835 paramters if they were the only present (thanks Paolo!).
14836 (GetParameterInfo): We only have an empty set of types if both
14837 fixed and array are set to null.
14838 (GetParameterInfo-idx): Handle FixedParameter == null
14840 * cs-parser.jay: Handle the case where there is no catch
14841 statements (missing null test).
14843 2002-02-22 Miguel de Icaza <miguel@ximian.com>
14845 * driver.cs (MainDriver): Be conservative on our command line
14848 Catch DirectoryNotFoundException when calling GetFiles.
14850 (SplitPathAndPattern): Used to split the input specification into
14851 a path and a pattern that we can feed to Directory.GetFiles.
14853 2002-02-21 Miguel de Icaza <miguel@ximian.com>
14855 * statement.cs (Fixed): Implement the last case of the Fixed
14856 statement (string handling).
14858 * expression.cs (StringPtr): New class used to return a char * to
14859 a string; Used by the Fixed statement.
14861 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
14863 * expression.cs (Binary.ResolveOperator): Remove redundant
14864 MemberLookup pn parent type.
14865 Optimize union call, we do not need a union if the types are the same.
14866 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
14869 Specialize the use of MemberLookup everywhere, instead of using
14870 the default settings.
14872 (StackAlloc): Implement stackalloc keyword.
14874 * cs-parser.jay: Add rule to parse stackalloc.
14876 * driver.cs: Handle /h, /help, /?
14878 * expression.cs (MakeByteBlob): Removed the hacks we had in place
14879 before we supported unsafe code.
14881 * makefile: add --unsafe to the self compilation of mcs.
14883 2002-02-20 Miguel de Icaza <miguel@ximian.com>
14885 * expression.cs (PointerArithmetic): New class that is used to
14886 perform pointer arithmetic.
14887 (Binary.Resolve): Handle pointer arithmetic
14888 Handle pointer comparission.
14889 (ArrayPtr): Utility expression class that is used to take the
14890 address of an array.
14892 (ElementAccess): Implement array access for pointers
14894 * statement.cs (Fixed): Implement fixed statement for arrays, we
14895 are missing one more case before we are done.
14897 * expression.cs (Indirection): Implement EmitAssign and set the
14898 ExprClass to Variable. This allows pointer dereferences to be
14899 treated as variables, and to have values assigned to them.
14901 * ecore.cs (Expression.StoreFromPtr): New utility function to
14902 store values dereferencing.
14904 2002-02-20 Ravi Pratap <ravi@ximian.com>
14906 * expression.cs (Binary.ResolveOperator): Ensure that we are
14907 not trying to operate on a void type - this fixes the reported
14910 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
14911 the parent implementation is sealed.
14913 * ../errors/cs0239.cs : Add.
14915 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
14917 * typemanager.cs (unverifiable_code_type): Corresponds to
14918 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
14919 which have unsafe code in them.
14921 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
14924 2002-02-19 Miguel de Icaza <miguel@ximian.com>
14926 * cs-tokenizer.cs: Add support for @"litreal strings"
14928 Make tokenizer accept pre-processor directives
14929 on any column (remove the old C-like limitation).
14931 * rootcontext.cs (EmitCode): Emit any global attributes.
14932 (AddGlobalAttributes): Used to keep track of assembly attributes.
14934 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
14936 * cs-parser.jay: Add support for global attributes.
14938 2002-02-17 Miguel de Icaza <miguel@ximian.com>
14940 * expression.cs (Indirection): New helper class. Unary will
14941 create Indirection classes to be able to implement the
14942 IMemoryLocation interface on it.
14944 2002-02-16 Miguel de Icaza <miguel@ximian.com>
14946 * cs-parser.jay (fixed_statement): reference the right statement.
14948 * statement.cs (Fixed.Emit): Finish implementing the fixed
14949 statement for the &x case.
14951 2002-02-14 Miguel de Icaza <miguel@ximian.com>
14953 * class.cs (Property.Define, Method.Define): Remove newslot when
14956 * modifiers.cs: My use of NewSlot when `Abstract' was set was
14957 wrong. NewSlot should only be used if the `new' keyword is present.
14959 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
14960 locating our system dir. Sorry about this.
14962 2002-02-13 Miguel de Icaza <miguel@ximian.com>
14964 * driver.cs (GetSystemDir): Compute correctly the location of our
14965 system assemblies. I was using the compiler directory instead of
14966 the library directory.
14968 2002-02-13 Ravi Pratap <ravi@ximian.com>
14970 * expression.cs (BetterFunction): Put back in what Miguel commented out
14971 since it is the correct fix. The problem is elsewhere ;-)
14973 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
14974 parameters of the parms method are themselves compatible or not !
14976 (StandardConversionExists): Fix very dangerous bug where we were forgetting
14977 to check that a class implements an interface before saying that an implicit
14978 conversion was allowed. Use ImplementsInterface to do the checking.
14980 2002-02-13 Miguel de Icaza <miguel@ximian.com>
14982 * class.cs (Method.Define): Track whether we are an explicit
14983 implementation or not. And only call DefineMethodOverride if we
14984 are an explicit implementation.
14986 (Property.DefineMethod): Ditto.
14988 2002-02-11 Ravi Pratap <ravi@ximian.com>
14990 * expression.cs (BetterFunction): Catch hideous bug which was
14991 preventing us from detecting ambiguous calls due to implicit casts i.e
14994 2002-01-29 Miguel de Icaza <miguel@ximian.com>
14996 * support.cs (Pair): Remove un-needed method. I figured why I was
14997 getting the error in cs-parser.jay, the variable in a foreach loop
14998 is readonly, and the compiler does not really treat this as a variable.
15000 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
15001 instead of EQUALS in grammar.
15003 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
15005 * expression.cs (Unary.DoResolve): Check whether the argument is
15008 2002-01-28 Miguel de Icaza <miguel@ximian.com>
15010 * support.cs: Api for Pair to set a value. Despite the fact that
15011 the variables are public the MS C# compiler refuses to compile
15012 code that accesses the field if the variable is part of a foreach
15015 * statement.cs (Fixed): Begin implementation of the fixed
15018 (Block.AddVariable): Return the VariableInfo on success and null
15019 on failure instead of true/false.
15021 * cs-parser.jay (foreach): Catch errors on variables already
15022 defined (we were ignoring this value before) and properly unwind
15023 the block hierarchy
15025 (fixed_statement): grammar for the fixed statement.
15027 2002-01-25 Miguel de Icaza <miguel@ximian.com>
15029 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
15030 pointer types to be incretemented.
15032 (SizeOf): Implement.
15034 * cs-parser.jay (pointer_member_access): Implement
15035 expr->IDENTIFIER production.
15037 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
15038 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
15041 (Unary): Implement indirection.
15043 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
15044 use in non-unsafe context).
15046 (SimpleName.DoResolve): Check for pointers in field access on safe
15049 (Expression.LoadFromPtr): Factor the load-indirect code in this
15050 function. This was duplicated in UnboxCast and ParameterReference
15052 2002-01-24 Miguel de Icaza <miguel@ximian.com>
15054 * expression.cs (ComposedCast): report an error if a pointer cast
15055 is used in a safe region.
15057 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
15058 pointer type casts in unsafe context.
15060 * codegen.cs (EmitContext): Set up IsUnsafe.
15062 * cs-parser.jay (non_expression_type): Add productions for pointer
15065 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
15066 code. We should not use force into static mode if the method is
15067 not virtual. Fixes bug in MIS
15069 * statement.cs (Do.Emit, While.Emit, For.Emit,
15070 Statement.EmitBoolExpression): Add support to Do and While to
15071 propagate infinite loop as `I do return' semantics.
15073 Improve the For case to also test for boolean constants.
15075 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
15076 to the list of attributes we can add.
15078 Remove `EmitContext' argument.
15080 * class.cs (Method.Define): Apply parameter attributes.
15081 (Constructor.Define): Apply parameter attributes.
15082 (MethodCore.LabelParameters): Move here the core of labeling
15085 * support.cs (ReflectionParameters.ParameterModifier,
15086 InternalParameters.ParameterModifier): Use IsByRef on the type and
15087 only return the OUT bit for these parameters instead of in/out/ref
15090 This is because I miss-understood things. The ParameterInfo.IsIn
15091 and IsOut represent whether the parameter has the [In] and [Out]
15094 2002-01-22 Miguel de Icaza <miguel@ximian.com>
15096 * ecore.cs (FieldExpr.Emit): Release temporaries.
15098 * assign.cs (LocalTemporary.Release): new function.
15100 * codegen.cs (EmitContext.GetTemporaryStorage,
15101 EmitContext.FreeTemporaryStorage): Rework the way we deal with
15102 temporary storage. Now we can "put back" localbuilders when we
15105 2002-01-21 Miguel de Icaza <miguel@ximian.com>
15107 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
15108 need to make a copy of the variable to generate verifiable code.
15110 2002-01-19 Miguel de Icaza <miguel@ximian.com>
15112 * driver.cs: Compute dynamically the system directory.
15114 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
15115 Slower, but more generally useful. Used by the abstract
15116 registering implementation.
15118 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
15119 the rules for the special rule on Type/instances. First check if
15120 we have the same name, and if so, try that special static path
15121 rather than the instance path.
15123 2002-01-18 Miguel de Icaza <miguel@ximian.com>
15125 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
15128 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
15129 Enum, ValueType, Delegate or Array for non-corlib compiles.
15131 * cs-tokenizer.cs: Catch long identifiers (645)
15133 * typemanager.cs (IndexerPropetyName): Ravi never tested this
15136 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
15137 fix, we were returning too early, so we were not registering
15138 pending methods from abstract classes.
15140 Do not register pending methods if the class is abstract.
15142 * expression.cs (Conditional.DoResolve): Report circular implicit
15143 conversions when we neecd to compute it for conditional
15146 (Is.DoResolve): If the expression is always of the provided type,
15147 flag warning 183. If the expression can not ever be of the
15148 provided type flag warning 184.
15150 * class.cs: Catch 169 as well.
15152 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
15155 2002-01-18 Nick Drochak <ndrochak@gol.com>
15157 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
15159 2002-01-17 Miguel de Icaza <miguel@ximian.com>
15161 * interface.cs: (PopulateMethod): Check for pointers being defined
15162 only if the unsafe context is active.
15163 (PopulateProperty): ditto.
15164 (PopulateIndexer): ditto.
15166 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
15167 specified. If pointers are present, make sure that they are
15168 present in an unsafe context.
15169 (Constructor, Constructor.Define): ditto.
15170 (Field, Field.Define): ditto.
15171 (Property, Property.Define): ditto.
15172 (Event, Event.Define): ditto.
15174 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
15175 hashtable if there are classes or structs defined.
15177 * expression.cs (LocalVariableReference.DoResolve): Simplify this
15178 code, as the constant resolution moved.
15180 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
15181 the metadata, so we can flag error 133.
15183 * decl.cs (MemberCore.UnsafeOK): New function to test that a
15184 pointer is being declared in an unsafe context.
15186 2002-01-16 Miguel de Icaza <miguel@ximian.com>
15188 * modifiers.cs (Modifiers.Check): Require a Location argument.
15189 Report error 227 for Unsafe use.
15191 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
15193 * statement.cs (For.Emit): If the test is null, then report that
15194 we do `return', as we wont reach anything afterwards.
15196 (Switch.SwitchGoverningType): Track the expression that matched
15199 * driver.cs: Allow negative numbers as an error code to flag.
15201 * cs-parser.jay: Handle 1551.
15203 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
15205 2002-01-15 Miguel de Icaza <miguel@ximian.com>
15207 * cs-parser.jay: Report 1518 (type declaration can only contain
15208 class, struct, interface, enum or delegate)
15210 (switch_label): Report 1523 (keywords `case' or `default' must
15213 (opt_switch_sections): Report 1522 (empty switch)
15215 * driver.cs: Report 1515 (response file specified multiple times)
15216 Report 1516 (Source file specified multiple times).
15218 * expression.cs (Argument.Resolve): Signal 1510
15220 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
15221 access not allowed in static code)
15223 2002-01-11 Ravi Pratap <ravi@ximian.com>
15225 * typemanager.cs (IsPointerType): Utility method which we are going
15228 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
15229 the object type, so we take care of that.
15231 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
15233 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
15234 added to non-params parameters :-)
15236 * typemanager.cs (CSharpName): Include 'void' type too.
15238 (void_ptr_type): Include in the set of core types.
15240 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
15243 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
15246 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
15247 completely forgotten about it.
15249 2002-01-10 Ravi Pratap <ravi@ximian.com>
15251 * cs-parser.jay (pointer_type): Add. This begins our implementation
15252 of parsing rules for unsafe code.
15254 (unsafe_statement): Implement.
15256 (embedded_statement): Modify to include the above.
15258 * statement.cs (Unsafe): Implement new class for unsafe blocks.
15260 * codegen.cs (EmitContext.InUnsafe): Add. This determines
15261 if the current context is an unsafe one.
15263 * cs-parser.jay (local_variable_pointer_type): Since local variable types
15264 are handled differently, we need separate rules for them.
15266 (local_variable_declaration): Update to use local_variable_pointer_type
15267 to allow variable declarations of unmanaged pointer types.
15269 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
15270 in unsafe contexts.
15272 * ../errors/cs0214.cs : Add.
15274 2002-01-16 Nick Drochak <ndrochak@gol.com>
15276 * makefile: remove 'response' file when cleaning.
15278 2002-01-15 Miguel de Icaza <miguel@ximian.com>
15280 * cs-parser.jay: Report 1524.
15282 2002-01-14 Miguel de Icaza <miguel@ximian.com>
15284 * typemanager.cs (RegisterMethod): drop checking if we have
15285 registered this from here
15287 2002-01-12 Miguel de Icaza <miguel@ximian.com>
15289 * class.cs (Method.EmitDestructor): Implement calling our base
15292 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
15293 value of InFinally.
15295 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
15296 this routine and will wrap the call in a try/catch block. Deal
15299 2002-01-11 Miguel de Icaza <miguel@ximian.com>
15301 * ecore.cs (Expression.MemberLookup): instead of taking a
15302 parameter `same_type' that was used to tell whether we could
15303 access private members we compute our containing type from the
15306 (FieldExpr): Added partial support for volatile fields. This does
15307 not work for volatile fields exposed from assemblies, as I can not
15308 figure out how to extract the modreq from it.
15310 Updated all the source files to use this.
15312 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
15313 because it is referenced by MemberLookup very often.
15315 2002-01-09 Ravi Pratap <ravi@ximian.com>
15317 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
15318 TypeBuilder.GetCustomAttributes to retrieve what we need.
15320 Get rid of redundant default_member_attr_type as this is the same as
15321 default_member_type which already exists.
15323 * interface.cs, attribute.cs : Update accordingly.
15325 2002-01-08 Miguel de Icaza <miguel@ximian.com>
15327 * typemanager.cs: Enable IndexerPropertyName again. It does not
15328 work for TYpeBuilders though. Ravi, can you please fix this?
15330 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
15332 * expression.cs (Argument.Emit): Handle the case of ref objects
15333 being passed to ref functions;
15335 (ParameterReference.EmitLoad): Loads the content of the pointer
15336 without dereferencing.
15338 2002-01-07 Miguel de Icaza <miguel@ximian.com>
15340 * cs-tokenizer.cs: Implemented the pre-processing expressions.
15342 2002-01-08 Ravi Pratap <ravi@ximian.com>
15344 * class.cs (Indexer.DefineMethod): Incorporate the interface
15345 type in the name of the method if we are doing explicit interface
15348 * expression.cs (ConversionExists): Remove as it is completely obsolete.
15350 (BetterConversion): Fix extremely trivial bug where we were referring to
15351 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
15354 * ../errors/bug16.cs : Add although we have fixed it.
15356 2002-01-07 Miguel de Icaza <miguel@ximian.com>
15358 * expression.cs (BaseIndexer): Begin implementation.
15360 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
15362 * cs-parser.jay (indexer_declarator): Use qualified_identifier
15363 production directly to remove a shift/reduce, and implement
15364 explicit interface implementation.
15366 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
15367 after a floating point suffix.
15369 * expression.cs (DoNumericPromotions): Improved the conversion for
15370 uint/uint. If we have a constant, we avoid doing a typecast to a
15373 * class.cs (Indexer): Implement explicit interface implementation
15376 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
15378 * class.cs: make the default instance constructor public and hidebysig.
15380 2001-01-03 Ravi Pratap <ravi@ximian.com>
15382 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
15383 so we can call it from elsewhere.
15385 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
15386 we emit it internally if the class has a defined indexer; otherwise the user
15387 emits it by decorating the class definition with the DefaultMemberAttribute.
15389 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
15390 attribute is not used on a type which defines an indexer.
15392 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
15393 character when we skip whitespace.
15395 * ../errors/cs0646.cs : Add.
15397 2002-01-03 Miguel de Icaza <miguel@ximian.com>
15399 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
15402 * makefile: Add practical target `mcs3.exe' which builds the third
15403 generation compiler.
15405 * expression.cs (New): Fix structures constructor calling.
15407 * class.cs (Property, Method, Indexer): Emit Final flag on the
15408 method if we are an interface implementation and we are not
15411 * ecore.cs (PropertyExpr): New public field `IsBase', tells
15412 whether this property is referencing a `base' method.
15414 * expression.cs (Invocation.EmitCall): take an extra argument:
15415 is_base, this is used to determine whether the `call' or
15416 `callvirt' opcode should be used.
15419 * delegate.cs: update EmitCall.
15421 * class.cs (Method.Define): Set NewSlot for the cases where we are
15422 not implementing an interface method.
15424 (Property.Define): ditto.
15426 2002-01-02 Miguel de Icaza <miguel@ximian.com>
15428 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
15429 'r'. Allows mcs to parse itself fully.
15431 2002-01-02 Ravi Pratap <ravi@ximian.com>
15433 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
15434 of the number of initializers that require the InitializeArray method.
15436 (CheckIndices): Store the Expression in all cases - not the plain value. Also
15437 update the above field where necessary.
15439 (MakeByteBlob): Update accordingly.
15441 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
15444 (EmitDynamicInitializers): Update in accordance with the new optimization.
15446 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
15447 same OpCode applies.
15449 * cs-parser.jay : Fix some glaring errors I introduced.
15451 2002-01-01 Ravi Pratap <ravi@ximian.com>
15453 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
15454 so that we can check for name clashes there too.
15456 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
15457 for interface indexers.
15459 * interfaces.cs (Define): Emit the default member attribute.
15461 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
15462 variable was being referred to while setting the value ;-)
15464 2002-01-01 Miguel de Icaza <miguel@ximian.com>
15466 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
15467 byte-by-byte information when we know the data is zero.
15469 Make the block always a multiple of 4, because
15470 DefineInitializedData has a bug.
15472 * assign.cs: Fix, we should assign from the temporary, not from
15475 * expression.cs (MakeByteBlob): Fix my incorrect code.
15477 2001-12-31 Miguel de Icaza <miguel@ximian.com>
15479 * typemanager.cs (EnumToUnderlying): This function is used to get
15480 the underlying type from an enumeration, because it does not
15483 * constant.cs: Use the I4_S form for values between -128 and 127.
15485 * statement.cs (Block.LookupLabel): Looks up a label.
15486 (Block): Drop support for labeled blocks.
15488 (LabeledStatement): New kind of statement that represents a label
15491 (Goto): Finally implement this bad boy.
15493 * cs-parser.jay: Update to reflect new mechanism to implement
15496 2001-12-30 Miguel de Icaza <miguel@ximian.com>
15498 * codegen.cs (EmitContext.This): a codegen property that keeps the
15499 a single instance of this instead of creating many different this
15502 * delegate.cs (Delegate.DoResolve): Update to use the property;
15504 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
15506 * expression.cs (BaseAccess.DoResolve): Ditto.
15508 2001-12-29 Ravi Pratap <ravi@ximian.com>
15510 * typemanager.cs (methodimpl_attr_type): Add to hold the type
15511 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
15513 (InitCoreTypes): Update accordingly.
15515 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
15516 so we can quickly store the state.
15518 (ApplyAttributes): Set the correct implementation flags
15519 for InternalCall methods.
15521 2001-12-29 Miguel de Icaza <miguel@ximian.com>
15523 * expression.cs (EmitCall): if a method is not virtual, then do
15524 not use callvirt on it.
15526 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
15527 user defined stuff) requires the use of stobj, which takes an
15528 address on the stack instead of an array and an index. So emit
15529 the Ldelema operation for it.
15531 (EmitStoreOpcode): Use stobj for valuetypes.
15533 (UnaryMutator.EmitCode): Use the right 1 value depending on
15534 whether we are dealing with int64/uint64, float or doubles.
15536 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
15537 constructors that I implemented last night.
15539 (Constructor.IsDefault): Fix to work properly for static
15542 * cs-parser.jay (CheckDef): report method signature errors.
15543 Update error number 103 to be 132.
15545 * decl.cs: New AdditionResult enumeration value: MethodExists.
15546 Although we do this check for methods later on in the semantic
15547 analysis, catching repeated default constructors is so easy that
15548 we catch these here.
15550 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
15553 (ParameterReference.EmitAssign, Emit): handle
15556 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
15557 (ArrayAccess.EmitStoreOpcode): ditto.
15559 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
15561 * expression.cs (MakeByteBlob): Complete all the missing types
15562 (uint, short, ushort, byte, sbyte)
15564 * class.cs: Only init instance field initializers on instance
15567 Rename `constructors' to instance_constructors.
15569 (TypeContainer.AddConstructor): Only add constructors to the list
15570 if it is not static.
15572 Make sure that we handle default_static_constructor independently
15573 everywhere where we handle instance_constructors
15575 2001-12-28 Miguel de Icaza <miguel@ximian.com>
15577 * class.cs: Do not lookup or create a base initializer for a
15578 static constructor.
15580 (ConstructorInitializer.Resolve): use the proper type to lookup
15583 * cs-parser.jay: Report error 1585 (modifiers between type and name).
15585 * enum.cs, interface.cs: Remove CloseType, this is taken care by
15588 * decl.cs: CloseType is now an virtual method, the default
15589 implementation just closes this type.
15591 2001-12-28 Ravi Pratap <ravi@ximian.com>
15593 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
15594 to PreserveSig by default. Also emit HideBySig on such methods.
15596 Basically, set the defaults to standard values.
15598 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
15599 argument, if candidate is better, it can't be worse than the best !
15601 (Invocation): Re-write bits to differentiate between methods being
15602 applicable in their expanded form and their normal form - for params
15605 Get rid of use_standard everywhere as only standard conversions are allowed
15606 in overload resolution.
15608 More spec conformance.
15610 2001-12-27 Miguel de Icaza <miguel@ximian.com>
15612 * driver.cs: Add --timestamp, to see where the compiler spends
15615 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
15616 `this' in static code.
15618 (SimpleName.DoResolve): Implement in terms of a helper function
15619 that allows static-references to be passed upstream to
15622 (Expression.ResolveWithSimpleName): Resolve specially simple
15623 names when called by MemberAccess to implement the special
15626 (Expression.ImplicitReferenceConversion): Handle conversions from
15627 Null to reference types before others, as Null's type is
15630 * expression.cs (Invocation.EmitCall): Handle the special case of
15631 calling methods declared on a reference type from a ValueType
15632 (Base classes System.Object and System.Enum)
15634 (MemberAccess.Resolve): Only perform lookups on Enumerations if
15635 the left hand side is a TypeExpr, not on every enumeration.
15637 (Binary.Resolve): If types are reference types, then do a cast to
15638 object on operators != and == of both arguments.
15640 * typemanager.cs (FindMembers): Extract instance and static
15641 members if requested.
15643 * interface.cs (PopulateProperty): Use void_type instead of null
15644 as the return type for the setter method.
15646 (PopulateIndexer): ditto.
15648 2001-12-27 Ravi Pratap <ravi@ximian.com>
15650 * support.cs (ReflectionParameters): Fix minor bug where we
15651 were examining the wrong parameter for the ParamArray attribute.
15653 Cope with requests for the type of the parameter at position
15654 greater than the params parameter's. We now return the element
15655 type of the params array as that makes more sense.
15657 * expression.cs (Invocation.IsParamsMethodApplicable): Update
15658 accordingly as we no longer have to extract the element type
15661 (Invocation.OverloadResolve): Update.
15663 2001-12-27 Miguel de Icaza <miguel@ximian.com>
15665 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
15666 against IEnumerator, test whether the return value is a descendant
15667 of the IEnumerator interface.
15669 * class.cs (Indexer.Define): Use an auxiliary method to implement
15670 the other bits of the method definition. Begin support for
15671 explicit interface implementation.
15673 (Property.DefineMethod): Use TypeManager.void_type instead of null
15674 for an empty return value.
15676 2001-12-26 Miguel de Icaza <miguel@ximian.com>
15678 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
15679 dealing with a FieldExpr which is composed of a FieldBuilder, in
15680 the code path we did extract the constant, but we should have
15681 obtained the underlying value to be able to cast it (otherwise we
15682 end up in an infinite loop, this is what Ravi was running into).
15684 (ArrayCreation.UpdateIndices): Arrays might be empty.
15686 (MemberAccess.ResolveMemberAccess): Add support for section
15687 14.5.4.1 that deals with the special case of E.I when E is a type
15688 and something else, that I can be a reference to a static member.
15690 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
15691 handle a particular array type to create byte blobs, it is just
15692 something we dont generate byteblobs for.
15694 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
15697 * location.cs (Push): remove the key from the hashtable that we
15698 are about to add. This happens for empty files.
15700 * driver.cs: Dispose files after we have parsed them.
15702 (tokenize): new function that only runs the tokenizer on its
15703 input, for speed testing.
15705 2001-12-26 Ravi Pratap <ravi@ximian.com>
15707 * class.cs (Event.Define): Define the private field only if there
15708 are no accessors defined.
15710 * expression.cs (ResolveMemberAccess): If there is no associated
15711 field with the event, that means we have an event defined with its
15712 own accessors and we should flag error cs0070 since transforming
15713 ourselves into a field is not valid in that case.
15715 * ecore.cs (SimpleName.DoResolve): Same as above.
15717 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
15718 and charset to sane values.
15720 2001-12-25 Ravi Pratap <ravi@ximian.com>
15722 * assign.cs (DoResolve): Perform check on events only if they
15723 are being accessed outside the declaring type.
15725 * cs-parser.jay (event_declarations): Update rules to correctly
15726 set the type of the implicit parameter etc.
15728 (add_accessor, remove_accessor): Set current local parameters.
15730 * expression.cs (Binary): For delegate addition and subtraction,
15731 cast the return value from the method into the appropriate delegate
15734 2001-12-24 Ravi Pratap <ravi@ximian.com>
15736 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
15737 of these as the workaround is unnecessary.
15739 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
15740 delegate data - none of that is needed at all.
15742 Re-write bits to extract the instance expression and the delegate method
15745 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
15748 * attribute.cs (ApplyAttributes): New method to take care of common tasks
15749 of attaching attributes instead of duplicating code everywhere.
15751 * everywhere : Update code to do attribute emission using the above method.
15753 2001-12-23 Miguel de Icaza <miguel@ximian.com>
15755 * expression.cs (IsParamsMethodApplicable): if there are not
15756 parameters, return immediately.
15758 * ecore.cs: The 0 literal can be implicity converted to an enum
15761 (SimpleName.DoResolve): First lookup the type, then lookup the
15764 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
15765 want to get its address. If the InstanceExpression is not
15766 addressable, store the result in a temporary variable, then get
15769 * codegen.cs: Only display 219 errors on warning level or above.
15771 * expression.cs (ArrayAccess): Make it implement the
15772 IMemoryLocation interface.
15774 (Binary.DoResolve): handle the operator == (object a, object b)
15775 and operator != (object a, object b) without incurring into a
15776 BoxedCast (because 5 != o should never be performed).
15778 Handle binary enumerator operators.
15780 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
15781 value type, otherwise use Ldelem_ref.
15783 Use precomputed names;
15785 (AddressOf): Implement address of
15787 * cs-parser.jay (labeled_statement): Fix recursive block
15788 addition by reworking the production.
15790 * expression.cs (New.DoEmit): New has a special case:
15792 If we are dealing with a ValueType, we have a few
15793 situations to deal with:
15795 * The target of New is a ValueType variable, that is
15796 easy, we just pass this as the variable reference
15798 * The target of New is being passed as an argument,
15799 to a boxing operation or a function that takes a
15802 In this case, we need to create a temporary variable
15803 that is the argument of New.
15806 2001-12-23 Ravi Pratap <ravi@ximian.com>
15808 * rootcontext.cs (LookupType): Check that current_type is not null before
15809 going about looking at nested types.
15811 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
15812 not implement the IAssignMethod interface any more.
15814 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
15815 where we tranform them into FieldExprs if they are being resolved from within
15816 the declaring type.
15818 * ecore.cs (SimpleName.DoResolve): Do the same here.
15820 * assign.cs (DoResolve, Emit): Clean up code considerably.
15822 * ../errors/bug10.cs : Add.
15824 * ../errors/cs0070.cs : Add.
15826 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
15828 * assign.cs : Get rid of EventIsLocal everywhere.
15830 2001-12-23 Miguel de Icaza <miguel@ximian.com>
15832 * ecore.cs (ConvertIntLiteral): finished the implementation.
15834 * statement.cs (SwitchLabel): Convert the value we are using as a
15835 key before looking up the table.
15837 2001-12-22 Miguel de Icaza <miguel@ximian.com>
15839 * codegen.cs (EmitTopBlock): Require a Location argument now.
15841 * cs-parser.jay (constructor_declarator): We need to setup
15842 current_local_parameters before we parse the
15843 opt_constructor_initializer, to allow the variables to be bound
15844 to the constructor arguments.
15846 * rootcontext.cs (LookupType): First lookup nested classes in our
15847 class and our parents before we go looking outside our class.
15849 * expression.cs (ConstantFold): Extract/debox the values at the
15852 * rootcontext.cs (EmitCode): Resolve the constants first before we
15853 resolve the types. This is not really needed, but it helps debugging.
15855 * statement.cs: report location.
15857 * cs-parser.jay: pass location to throw statement.
15859 * driver.cs: Small bug fix.
15861 * report.cs: Updated format to be 4-zero filled digits.
15863 2001-12-22 Ravi Pratap <ravi@ximian.com>
15865 * expression.cs (CheckIndices): Fix minor bug where the wrong
15866 variable was being referred to ;-)
15868 (DoEmit): Do not call EmitStaticInitializers when the
15869 underlying type is System.Object.
15871 2001-12-21 Ravi Pratap <ravi@ximian.com>
15873 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
15874 and do the usual workaround for SRE.
15876 * class.cs (MyEventBuilder.EventType): New member to get at the type
15877 of the event, quickly.
15879 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
15881 * assign.cs (Assign.DoResolve): Handle the case when the target
15882 is an EventExpr and perform the necessary checks.
15884 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
15887 (SimpleName.MemberStaticCheck): Include check for EventExpr.
15889 (EventExpr): Set the type in the constructor itself since we
15890 are meant to be born fully resolved.
15892 (EventExpr.Define): Revert code I wrote earlier.
15894 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
15895 instance expression is null. The instance expression is a This in that case
15896 or a null, depending on whether it is a static method or not.
15898 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
15899 refers to more than one method.
15901 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
15902 and accordingly flag errors.
15904 2001-12-21 Miguel de Icaza <miguel@ximian.com>
15906 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
15908 2001-12-22 Miguel de Icaza <miguel@ximian.com>
15910 * location.cs (ToString): Provide useful rutine.
15912 2001-12-21 Miguel de Icaza <miguel@ximian.com>
15914 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
15915 objects, return the actual integral boxed.
15917 * statement.cs (SwitchLabel): define an ILLabel for each
15920 (Switch.CheckSwitch): If the value is a Literal, extract
15921 the underlying literal.
15923 Also in the unused hashtable we had, add the SwitchLabel so we can
15924 quickly look this value up.
15926 * constant.cs: Implement a bunch of new constants. Rewrite
15927 Literal based on this. Made changes everywhere to adapt to this.
15929 * expression.cs (Expression.MakeByteBlob): Optimize routine by
15930 dereferencing array only once, and also copes with enumrations.
15932 bytes are two bytes wide, not one.
15934 (Cast): Perform constant conversions.
15936 * ecore.cs (TryImplicitIntConversion): Return literals instead of
15937 wrappers to the literals here.
15939 * expression.cs (DoNumericPromotions): long literals can converted
15940 to ulong implicity (this is taken care of elsewhere, but I was
15941 missing this spot).
15943 * ecore.cs (Expression.Literalize): Make the return type Literal,
15944 to improve type checking.
15946 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
15948 2001-12-20 Miguel de Icaza <miguel@ximian.com>
15950 * literal.cs: Revert code from ravi that checked the bounds. The
15951 bounds are sane by the definition of the type itself.
15953 * typemanager.cs: Fix implementation of ImplementsInterface. We
15954 need to actually look up in our parent hierarchy for interfaces
15957 * const.cs: Use the underlying type for enumerations
15959 * delegate.cs: Compute the basename for the delegate creation,
15960 that should fix the delegate test case, and restore the correct
15961 Type Lookup semantics in rootcontext
15963 * rootcontext.cs: Revert Ravi's last patch. The correct way of
15964 referencing a nested type with the Reflection API is using the "+"
15967 * cs-parser.jay: Do not require EOF token at the end.
15969 2001-12-20 Ravi Pratap <ravi@ximian.com>
15971 * rootcontext.cs (LookupType): Concatenate type names with
15972 a '.' instead of a '+' The test suite passes again.
15974 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
15975 field of the enumeration.
15977 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
15978 the case when the member is an EventExpr.
15980 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
15981 static has an associated instance expression.
15983 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
15985 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
15987 * class.cs (Event.Define): Register event and perform appropriate checks
15990 We define the Add and Remove methods even if the use provides none because
15991 in that case, we provide default implementations ourselves.
15993 Define a private field of the type of the event. This is done by the CSC compiler
15994 and we should be doing it too ;-)
15996 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
15997 More methods we use in code we generate.
15999 (multicast_delegate_type, delegate_type): Two separate types since the distinction
16002 (InitCoreTypes): Update accordingly for the above.
16004 * class.cs (Event.Emit): Generate code for default accessors that we provide
16006 (EmitDefaultMethod): Do the job in the above.
16008 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
16011 2001-12-20 Miguel de Icaza <miguel@ximian.com>
16013 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
16014 builders even if we were missing one.
16016 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
16017 pass the Basename as our class name instead of the Name. The
16018 basename will be correctly composed for us.
16020 * parameter.cs (Paramters): Now takes a Location argument.
16022 * decl.cs (DeclSpace.LookupType): Removed convenience function and
16023 make all the code call directly LookupType in RootContext and take
16024 this chance to pass the Location information everywhere.
16026 * Everywhere: pass Location information.
16028 2001-12-19 Miguel de Icaza <miguel@ximian.com>
16030 * class.cs (Constructor.Define): Updated way of detecting the
16031 length of the parameters.
16033 (TypeContainer.DefineType): Use basename as the type name for
16036 (TypeContainer.Define): Do not recursively define types here, as
16037 definition is taken care in order by the RootContext.
16039 * tree.cs: Keep track of namespaces in a per-file basis.
16041 * parameter.cs (Parameter.ComputeSignature): Update to use
16044 (Parameters.GetSignature): ditto.
16046 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
16047 instead of a TypeContainer.
16049 (Interface.SemanticAnalysis): Use `this' instead of our parent to
16050 resolve names. Because we need to be resolve in our context, not
16053 * driver.cs: Implement response files.
16055 * class.cs (TypeContainer.DefineType): If we are defined, do not
16056 redefine ourselves.
16058 (Event.Emit): Emit the code for add/remove handlers.
16059 (Event.Define): Save the MethodBuilders for add/remove.
16061 * typemanager.cs: Use pair here too.
16063 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
16064 DictionaryEntry requires the first argument to be non-null.
16066 (enum_declaration): Compute full name for registering the
16069 (delegate_declaration): Instead of using
16070 formal_parameter_list, use opt_formal_parameter_list as the list
16073 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
16074 (EventParsing): New property that controls whether `add' and
16075 `remove' are returned as tokens or identifiers (for events);
16077 2001-12-19 Ravi Pratap <ravi@ximian.com>
16079 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
16080 use MyEventBuilder only and let it wrap the real builder for us.
16082 (MyEventBuilder): Revamp constructor etc.
16084 Implement all operations that we perform on EventBuilder in precisely the same
16087 (FindMembers): Update to use the EventBuilder member.
16089 (Event.Emit): Update accordingly.
16091 2001-12-18 Ravi Pratap <ravi@ximian.com>
16093 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
16094 by calling the appropriate methods.
16096 (GetCustomAttributes): Make stubs as they cannot possibly do anything
16099 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
16101 2001-12-17 Ravi Pratap <ravi@ximian.com>
16103 * delegate.cs (Delegate.Populate): Check that the return type
16104 and various parameters types are indeed accessible.
16106 * class.cs (Constructor.Define): Same here.
16108 (Field.Define): Ditto.
16110 (Event.Define): Ditto.
16112 (Operator.Define): Check that the underlying Method defined itself
16113 correctly - so it's MethodBuilder should not be null.
16115 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
16116 expression happens to be null.
16118 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
16119 members but as of now we don't seem to be able to do anything really useful with it.
16121 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
16122 not the EventBuilder.
16124 2001-12-18 Miguel de Icaza <miguel@ximian.com>
16126 * cs-tokenizer.cs: Add support for defines.
16127 Add support for #if, #elif, #else, #endif
16129 (eval_var): evaluates a variable.
16130 (eval): stubbed for evaluating functions.
16132 * cs-parser.jay: Pass the defines information
16134 * driver.cs: Add --define command line option.
16136 * decl.cs: Move MemberCore here.
16138 Make it the base class for DeclSpace. This allows us to catch and
16139 report 108 and 109 for everything now.
16141 * class.cs (TypeContainer.Define): Extract all the members
16142 before populating and emit the warning 108 (new keyword required
16143 to override) instead of having each member implement this.
16145 (MemberCore.Define): New abstract method, we will be using this in
16146 the warning reporting engine in Populate.
16148 (Operator.Define): Adjust to new MemberCore protocol.
16150 * const.cs (Const): This does not derive from Expression, it is a
16151 temporary object we use to create fields, it is a MemberCore.
16153 * class.cs (Method.Define): Allow the entry point to be in a
16156 * driver.cs: Rewrite the argument handler to clean it up a bit.
16158 * rootcontext.cs: Made it just an auxiliary namespace feature by
16159 making everything static.
16161 * driver.cs: Adapt code to use RootContext type name instead of
16164 * delegate.cs: Remove RootContext argument.
16166 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
16169 * class.cs (Event.Define): The lookup can fail.
16171 * cs-tokenizer.cs: Begin implementation of pre-procesor.
16173 * expression.cs: Resolve the this instance before invoking the code.
16175 2001-12-17 Miguel de Icaza <miguel@ximian.com>
16177 * cs-parser.jay: Add a production in element_access that allows
16178 the thing to become a "type" reference. This way we can parse
16179 things like "(string [])" as a type.
16181 Note that this still does not handle the more complex rules of
16185 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
16187 * ecore.cs: (CopyNewMethods): new utility function used to
16188 assemble the list of methods from running FindMembers.
16190 (MemberLookup): Rework FindMembers so that
16192 2001-12-16 Miguel de Icaza <miguel@ximian.com>
16194 * class.cs (TypeContainer): Remove Delegates who fail to be
16197 * delegate.cs (Populate): Verify that we dont get null return
16198 values. TODO: Check for AsAccessible.
16200 * cs-parser.jay: Use basename to emit error 574 (destructor should
16201 have the same name as container class), not the full name.
16203 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
16204 possible representation.
16206 Also implements integer type suffixes U and L.
16208 2001-12-15 Miguel de Icaza <miguel@ximian.com>
16210 * expression.cs (ArrayCreation.DoResolve): We need to do the
16211 argument resolution *always*.
16213 * decl.cs: Make this hold the namespace. Hold the root context as
16215 (LookupType): Move here.
16217 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
16219 * location.cs (Row, Name): Fixed the code, it was always returning
16220 references to the first file.
16222 * interface.cs: Register properties defined through interfaces.
16224 * driver.cs: Add support for globbing on the command line
16226 * class.cs (Field): Make it derive from MemberCore as well.
16229 2001-12-15 Ravi Pratap <ravi@ximian.com>
16231 * class.cs (Event::Define): Check that the type of the event is a delegate
16232 type else flag error #66.
16234 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
16237 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
16238 values of EntryPoint, CharSet etc etc.
16240 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
16242 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
16243 be null and we should ignore this. I am not sure if this is really clean. Apparently,
16244 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
16245 which needs this to do its work.
16247 * ../errors/cs0066.cs : Add.
16249 2001-12-14 Miguel de Icaza <miguel@ximian.com>
16251 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
16254 * class.cs: (MethodSignature.MethodSignature): Removed hack that
16255 clears out the parameters field.
16256 (MemberSignatureCompare): Cleanup
16258 (MemberCore): New base class used to share code between MethodCore
16261 (RegisterRequiredImplementations) BindingFlags.Public requires
16262 either BindingFlags.Instace or Static. Use instance here.
16264 (Property): Refactored code to cope better with the full spec.
16266 * parameter.cs (GetParameterInfo): Return an empty array instead
16269 * class.cs (Property): Abstract or extern properties have no bodies.
16271 * parameter.cs (GetParameterInfo): return a zero-sized array.
16273 * class.cs (TypeContainer.MethodModifiersValid): Move all the
16274 method modifier validation to the typecontainer so we can reuse
16275 this on properties.
16277 (MethodCore.ParameterTypes): return an empty sized array of types.
16279 (Property.Define): Test property modifier validity.
16281 Add tests for sealed/override too.
16283 (Method.Emit): abstract or extern methods have no bodies.
16285 2001-12-14 Ravi Pratap <ravi@ximian.com>
16287 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
16290 (Method::Define, ::Emit): Modify accordingly.
16292 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
16294 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
16296 * makefile: Pass in /unsafe.
16298 2001-12-13 Miguel de Icaza <miguel@ximian.com>
16300 * class.cs (MakeKey): Kill routine.
16302 * class.cs (TypeContainer.Define): Correctly define explicit
16303 method implementations (they require the full interface name plus
16306 * typemanager.cs: Deply the PtrHashtable here and stop using the
16307 lame keys. Things work so much better.
16309 This of course broke everyone who depended on `RegisterMethod' to
16310 do the `test for existance' test. This has to be done elsewhere.
16312 * support.cs (PtrHashtable): A hashtable that avoid comparing with
16313 the object stupid Equals method (because, that like fails all over
16314 the place). We still do not use it.
16316 * class.cs (TypeContainer.SetRequiredInterface,
16317 TypeContainer.RequireMethods): Killed these two routines and moved
16318 all the functionality to RegisterRequiredImplementations.
16320 (TypeContainer.RegisterRequiredImplementations): This routine now
16321 registers all the implementations required in an array for the
16322 interfaces and abstract methods. We use an array of structures
16323 which can be computed ahead of time to reduce memory usage and we
16324 also assume that lookups are cheap as most classes will not
16325 implement too many interfaces.
16327 We also avoid creating too many MethodSignatures.
16329 (TypeContainer.IsInterfaceMethod): Update and optionally does not
16330 clear the "pending" bit if we find that there are problems with
16333 (TypeContainer.VerifyPendingMethods): Update to report errors of
16334 methods that look like implementations but are not.
16336 (TypeContainer.Define): Add support for explicit interface method
16339 2001-12-12 Miguel de Icaza <miguel@ximian.com>
16341 * typemanager.cs: Keep track of the parameters here instead of
16342 being a feature of the TypeContainer.
16344 * class.cs: Drop the registration of parameters here, as
16345 InterfaceMethods are also interface declarations.
16347 * delegate.cs: Register methods with the TypeManager not only with
16348 the TypeContainer. This code was buggy.
16350 * interface.cs: Full registation here.
16352 2001-12-11 Miguel de Icaza <miguel@ximian.com>
16354 * expression.cs: Remove reducer for binary expressions, it can not
16357 * const.cs: Put here the code that used to go into constant.cs
16359 * constant.cs: Put here the code for constants, this is a new base
16360 class for Literals.
16362 * literal.cs: Make Literal derive from Constant.
16364 2001-12-09 Miguel de Icaza <miguel@ximian.com>
16366 * statement.cs (Return.Emit): Report error 157 if the user
16367 attempts to return from a finally block.
16369 (Return.Emit): Instead of emitting a return, jump to the end of
16372 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
16373 LocalBuilder to store the result of the function. ReturnLabel is
16374 the target where we jump.
16377 2001-12-09 Radek Doulik <rodo@ximian.com>
16379 * cs-parser.jay: remember alias in current namespace
16381 * ecore.cs (SimpleName::DoResolve): use aliases for types or
16384 * class.cs (LookupAlias): lookup alias in my_namespace
16386 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
16388 (LookupAlias): lookup alias in this and if needed in parent
16391 2001-12-08 Miguel de Icaza <miguel@ximian.com>
16395 * rootcontext.cs: (ModuleBuilder) Made static, first step into
16396 making things static. I need this to avoid passing the
16397 TypeContainer when calling ParameterType.
16399 * support.cs (InternalParameters.ParameterType): Remove ugly hack
16400 that did string manipulation to compute the type and then call
16401 GetType. Use Parameter.ParameterType instead.
16403 * cs-tokenizer.cs: Consume the suffix for floating values.
16405 * expression.cs (ParameterReference): figure out whether this is a
16406 reference parameter or not. Kill an extra variable by computing
16407 the arg_idx during emission.
16409 * parameter.cs (Parameters.GetParameterInfo): New overloaded
16410 function that returns whether a parameter is an out/ref value or not.
16412 (Parameter.ParameterType): The type of the parameter (base,
16413 without ref/out applied).
16415 (Parameter.Resolve): Perform resolution here.
16416 (Parameter.ExternalType): The full type (with ref/out applied).
16418 * statement.cs (Using.Emit, Using.EmitExpression): Implement
16419 support for expressions on the using statement.
16421 2001-12-07 Miguel de Icaza <miguel@ximian.com>
16423 * statement.cs (Using.EmitLocalVariableDecls): Split the
16424 localvariable handling of the using statement.
16426 (Block.EmitMeta): Keep track of variable count across blocks. We
16427 were reusing slots on separate branches of blocks.
16429 (Try.Emit): Emit the general code block, we were not emitting it.
16431 Check the type of the declaration to be an IDisposable or
16432 something that can be implicity converted to it.
16434 Emit conversions if required.
16436 * ecore.cs (EmptyExpression): New utility class.
16437 (Expression.ImplicitConversionExists): New utility function.
16439 2001-12-06 Miguel de Icaza <miguel@ximian.com>
16441 * statement.cs (Using): Implement.
16443 * expression.cs (LocalVariableReference): Support read only variables.
16445 * statement.cs: Remove the explicit emit for the Leave opcode.
16446 (VariableInfo): Add a readonly field.
16448 2001-12-05 Miguel de Icaza <miguel@ximian.com>
16450 * ecore.cs (ConvCast): new class used to encapsulate the various
16451 explicit integer conversions that works in both checked and
16452 unchecked contexts.
16454 (Expression.ConvertNumericExplicit): Use new ConvCast class to
16455 properly generate the overflow opcodes.
16457 2001-12-04 Miguel de Icaza <miguel@ximian.com>
16459 * statement.cs: The correct type for the EmptyExpression is the
16460 element_type, not the variable type. Ravi pointed this out.
16462 2001-12-04 Ravi Pratap <ravi@ximian.com>
16464 * class.cs (Method::Define): Handle PInvoke methods specially
16465 by using DefinePInvokeMethod instead of the usual one.
16467 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
16468 above to do the task of extracting information and defining the method.
16470 2001-12-04 Ravi Pratap <ravi@ximian.com>
16472 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
16473 of the condition for string type.
16475 (Emit): Move that here.
16477 (ArrayCreation::CheckIndices): Keep string literals in their expression
16480 (EmitDynamicInitializers): Handle strings appropriately.
16482 2001-12-04 Miguel de Icaza <miguel@ximian.com>
16484 * codegen.cs (EmitContext): Replace multiple variables with a
16485 single pointer to the current Switch statement.
16487 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
16490 2001-12-03 Miguel de Icaza <miguel@ximian.com>
16494 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
16497 (Foreach.Emit): Foreach on arrays was not setting
16498 up the loop variables (for break/continue).
16500 (GotoCase): Semi-implented.
16502 2001-12-03 Ravi Pratap <ravi@ximian.com>
16504 * attribute.cs (CheckAttribute): Handle system attributes by using
16505 Attribute.GetAttributes to examine information we need.
16507 (GetValidPlaces): Same here.
16509 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
16511 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
16513 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
16515 (Method::Define): Set appropriate flags if we have a DllImport attribute.
16517 (Method::Emit): Handle the case when we are a PInvoke method.
16519 2001-12-03 Miguel de Icaza <miguel@ximian.com>
16521 * expression.cs: Use ResolveWithSimpleName on compound names.
16523 2001-12-02 Ravi Pratap <ravi@ximian.com>
16525 * constant.cs (EmitConstant): Make sure we resolve the associated expression
16526 before trying to reduce it.
16528 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
16530 * constant.cs (LookupConstantValue): Implement.
16532 (EmitConstant): Use the above in emitting the constant.
16534 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
16535 that are user-defined by doing a LookupConstantValue on them.
16537 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
16540 2001-11-29 Miguel de Icaza <miguel@ximian.com>
16542 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
16544 (BaseAccess.DoResolve): Implement.
16546 (MemberAccess.DoResolve): Split this routine into a
16547 ResolveMemberAccess routine that can be used independently
16549 2001-11-28 Miguel de Icaza <miguel@ximian.com>
16551 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
16552 As that share bits of the implementation. Is returns a boolean,
16553 while As returns the Type that is being probed.
16555 2001-12-01 Ravi Pratap <ravi@ximian.com>
16557 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
16558 instead of a Literal - much easier.
16560 (EnumInTransit): Remove - utterly useless :-)
16562 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
16564 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
16566 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
16567 chain when we have no associated expression.
16569 2001-11-30 Ravi Pratap <ravi@ximian.com>
16571 * constant.cs (Define): Use Location while reporting the errror.
16573 Also emit a warning when 'new' is used and there is no inherited
16576 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
16579 (LookupEnumValue): Implement to lookup an enum member's value and define it
16582 (Populate): Re-write accordingly to use the above routine.
16584 2001-11-27 Miguel de Icaza <miguel@ximian.com>
16586 * expression.cs (This): Fix prototype for DoResolveLValue to
16587 override the base class DoResolveLValue.
16589 * cs-parser.cs: Report errors cs574 and cs575 (destructor
16592 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
16593 (we need to load the address of the field here). This fixes
16596 (FieldExpr.DoResolveLValue): Call the DoResolve
16597 function to initialize the Instance expression.
16599 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
16600 correctly the GetEnumerator operation on a value type.
16602 * cs-parser.jay: Add more simple parsing error catches.
16604 * statement.cs (Switch): Add support for string switches.
16605 Handle null specially.
16607 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
16609 2001-11-28 Ravi Pratap <ravi@ximian.com>
16611 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
16613 (declare_local_constant): New helper function.
16615 * statement.cs (AddConstant): Keep a separate record of constants
16617 (IsConstant): Implement to determine if a variable is a constant.
16619 (GetConstantExpression): Implement.
16621 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
16623 * statement.cs (IsVariableDefined): Re-write.
16625 2001-11-27 Ravi Pratap <ravi@ximian.com>
16627 * class.cs (TypeContainer::FindMembers): Look for constants
16628 in the case when we are looking for MemberTypes.Field
16630 * expression.cs (MemberAccess::DoResolve): Check that in the
16631 case we are a FieldExpr and a Literal, we are not being accessed
16632 by an instance reference.
16634 * cs-parser.jay (local_constant_declaration): Implement.
16636 (declaration_statement): Implement for constant declarations.
16638 2001-11-26 Miguel de Icaza <miguel@ximian.com>
16640 * statement.cs (Switch): Catch double defaults.
16642 (Switch): More work on the switch() statement
16643 implementation. It works for integral values now, need to finish
16647 2001-11-24 Miguel de Icaza <miguel@ximian.com>
16649 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
16650 integer literals into other integer literals. To be used by
16653 2001-11-24 Ravi Pratap <ravi@ximian.com>
16655 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
16658 (EmitDynamicInitializers): Cope with the above since we extract data
16659 directly from ArrayData now.
16661 (ExpectInitializers): Keep track of whether initializers are mandatory
16664 (Bounds): Make it a hashtable to prevent the same dimension being
16665 recorded for every element in that dimension.
16667 (EmitDynamicInitializers): Fix bug which prevented the Set array method
16670 Also fix bug which was causing the indices to be emitted in the reverse
16673 2001-11-24 Miguel de Icaza <miguel@ximian.com>
16675 * expression.cs (ArrayCreation): Implement the bits that Ravi left
16676 unfinished. They do not work, because the underlying code is
16679 2001-11-22 Miguel de Icaza <miguel@ximian.com>
16681 * cs-parser.jay: Remove bogus fixme.
16683 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
16684 on Switch statement.
16686 2001-11-23 Ravi Pratap <ravi@ximian.com>
16688 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
16691 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
16692 parameter. Apparently, any expression is allowed.
16694 (ValidateInitializers): Update accordingly.
16696 (CheckIndices): Fix some tricky bugs thanks to recursion.
16698 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
16699 I was being completely brain-dead.
16701 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
16702 and re-write acordingly.
16704 (DelegateInvocation): Re-write accordingly.
16706 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
16708 (MakeByteBlob): Handle types more correctly.
16710 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
16711 initialization from expressions but it is incomplete because I am a complete
16714 2001-11-22 Miguel de Icaza <miguel@ximian.com>
16716 * statement.cs (If.Emit): Fix a bug that generated incorrect code
16717 on If. Basically, we have to return `true' (ie, we do return to
16718 our caller) only if both branches of the if return.
16720 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
16721 short-circuit operators, handle them as short circuit operators.
16723 (Cast.DoResolve): Resolve type.
16724 (Cast.Cast): Take an expression as the target type.
16726 * cs-parser.jay (cast_expression): Remove old hack that only
16727 allowed a limited set of types to be handled. Now we take a
16728 unary_expression and we resolve to a type during semantic
16731 Use the grammar productions from Rhys to handle casts (this is
16732 not complete like Rhys syntax yet, we fail to handle that corner
16733 case that C# has regarding (-x), but we will get there.
16735 2001-11-22 Ravi Pratap <ravi@ximian.com>
16737 * class.cs (EmitFieldInitializer): Take care of the case when we have a
16738 field which is an array type.
16740 * cs-parser.jay (declare_local_variables): Support array initialization too.
16742 * typemanager.cs (MakeKey): Implement.
16744 (everywhere): Use the above appropriately.
16746 * cs-parser.jay (for_statement): Update for array initialization while
16747 declaring variables.
16749 * ecore.cs : The error message was correct, it's the variable's names that
16750 were misleading ;-) Make the code more readable.
16752 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
16753 the correct type etc.
16755 (ConvertExplicit): Handle Enum types by examining the underlying type.
16757 2001-11-21 Ravi Pratap <ravi@ximian.com>
16759 * parameter.cs (GetCallingConvention): Always return
16760 CallingConventions.Standard for now.
16762 2001-11-22 Miguel de Icaza <miguel@ximian.com>
16764 * expression.cs (Binary.ResolveOperator): Update the values of `l'
16765 and `r' after calling DoNumericPromotions.
16767 * ecore.cs: Fix error message (the types were in the wrong order).
16769 * statement.cs (Foreach.ProbeCollectionType): Need to pass
16770 BindingFlags.Instance as well
16772 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
16773 implicit int literal conversion in an empty cast so that we
16774 propagate the right type upstream.
16776 (UnboxCast): new class used to unbox value types.
16777 (Expression.ConvertExplicit): Add explicit type conversions done
16780 (Expression.ImplicitNumericConversion): Oops, forgot to test for
16781 the target type before applying the implicit LongLiterals to ULong
16784 2001-11-21 Miguel de Icaza <miguel@ximian.com>
16786 * cs-parser.jay (for_statement): Reworked the way For works: now
16787 we declare manually any variables that are introduced in
16788 for_initializer to solve the problem of having out-of-band code
16789 emition (that is what got for broken).
16791 (declaration_statement): Perform the actual variable declaration
16792 that used to be done in local_variable_declaration here.
16794 (local_variable_declaration): Do not declare anything, just pass
16795 the information on a DictionaryEntry
16797 2001-11-20 Ravi Pratap <ravi@ximian.com>
16799 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
16800 re-write of the logic to now make it recursive.
16802 (UpdateIndices): Re-write accordingly.
16804 Store element data in a separate ArrayData list in the above methods.
16806 (MakeByteBlob): Implement to dump the array data into a byte array.
16808 2001-11-19 Ravi Pratap <ravi@ximian.com>
16810 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
16813 * constant.cs (Define): Implement.
16815 (EmitConstant): Re-write fully.
16817 Pass in location info.
16819 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
16822 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
16823 DictionaryEntry since we need location info too.
16825 (constant_declaration): Update accordingly.
16827 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
16828 code into another method : UpdateIndices.
16830 2001-11-18 Ravi Pratap <ravi@ximian.com>
16832 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
16833 some type checking etc.
16835 2001-11-17 Ravi Pratap <ravi@ximian.com>
16837 * expression.cs (ArrayCreation::ValidateInitializers): Implement
16838 bits to provide dimension info if the user skips doing that.
16840 Update second constructor to store the rank correctly.
16842 2001-11-16 Ravi Pratap <ravi@ximian.com>
16844 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
16845 and try to implement.
16847 * ../errors/cs0150.cs : Add.
16849 * ../errors/cs0178.cs : Add.
16851 2001-11-16 Miguel de Icaza <miguel@ximian.com>
16853 * statement.cs: Implement foreach on multi-dimensional arrays.
16855 * parameter.cs (Parameters.GetParameterByName): Also lookup the
16856 name of the params argument.
16858 * expression.cs: Use EmitStoreOpcode to get the right opcode while
16859 initializing the array.
16861 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
16862 we can use this elsewhere.
16864 * statement.cs: Finish implementation of foreach for single
16867 * cs-parser.jay: Use an out-of-band stack to pass information
16868 around, I wonder why I need this.
16870 foreach_block: Make the new foreach_block the current_block.
16872 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
16873 function used to return a static Parameters structure. Used for
16874 empty parameters, as those are created very frequently.
16876 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
16878 2001-11-15 Ravi Pratap <ravi@ximian.com>
16880 * interface.cs : Default modifier is private, not public. The
16881 make verify test passes again.
16883 2001-11-15 Ravi Pratap <ravi@ximian.com>
16885 * support.cs (ReflectionParameters): Fix logic to determine
16886 whether the last parameter is a params one. Test 9 passes again.
16888 * delegate.cs (Populate): Register the builders we define with
16889 RegisterParameterForBuilder. Test 19 passes again.
16891 * cs-parser.jay (property_declaration): Reference $6 instead
16892 of $$ to get at the location.
16894 (indexer_declaration): Similar stuff.
16896 (attribute): Ditto.
16898 * class.cs (Property): Register parameters for the Get and Set methods
16899 if they exist. Test 23 passes again.
16901 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
16902 call to EmitArguments as we are sure there aren't any params arguments.
16903 Test 32 passes again.
16905 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
16906 IndexOutOfRangeException.
16908 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
16909 Test 33 now passes again.
16911 2001-11-15 Miguel de Icaza <miguel@ximian.com>
16913 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
16914 broke a bunch of things. Will have to come up with a better way
16915 of tracking locations.
16917 * statement.cs: Implemented foreach for single dimension arrays.
16919 2001-11-09 Miguel de Icaza <miguel@ximian.com>
16921 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
16922 an error. This removes the lookup from the critical path.
16924 * cs-parser.jay: Removed use of temporary_loc, which is completely
16927 2001-11-14 Miguel de Icaza <miguel@ximian.com>
16929 * support.cs (ReflectionParameters.ParameterModifier): Report
16930 whether the argument is a PARAMS argument or not.
16932 * class.cs: Set the attribute `ParamArrayAttribute' on the
16933 parameter argument.
16935 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
16936 and cons_param_array_attribute (ConstructorInfo for
16937 ParamArrayAttribute).,
16939 * codegen.cs: Emit the return using the `Return' statement, that
16940 way we can report the error correctly for missing return values.
16942 * class.cs (Method.Emit): Clean up.
16944 * expression.cs (Argument.Resolve): Take another argument: the
16945 location where this argument is used. Notice that this is not
16946 part of the "Argument" class as to reduce the size of the
16947 structure (we know the approximate location anyways).
16949 Test if the argument is a variable-reference, if not, then
16950 complain with a 206.
16952 (Argument.Emit): Emit addresses of variables.
16954 (Argument.FullDesc): Simplify.
16956 (Invocation.DoResolve): Update for Argument.Resolve.
16958 (ElementAccess.DoResolve): ditto.
16960 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
16961 method should be virtual, as this method is always virtual.
16963 (NewDelegate.DoResolve): Update for Argument.Resolve.
16965 * class.cs (ConstructorInitializer.DoResolve): ditto.
16967 * attribute.cs (Attribute.Resolve): ditto.
16969 2001-11-13 Miguel de Icaza <miguel@ximian.com>
16971 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
16973 * expression.cs (ParameterReference): Drop IStackStorage and implement
16974 IAssignMethod instead.
16976 (LocalVariableReference): ditto.
16978 * ecore.cs (FieldExpr): Drop IStackStorage and implement
16979 IAssignMethod instead.
16981 2001-11-13 Miguel de Icaza <miguel@ximian.com>
16983 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
16984 enumerations that are used in heavily used structures derive from
16985 byte in a laughable and pathetic attempt to reduce memory usage.
16986 This is the kind of pre-optimzations that you should not do at
16987 home without adult supervision.
16989 * expression.cs (UnaryMutator): New class, used to handle ++ and
16990 -- separatedly from the other unary operators. Cleans up the
16991 code, and kills the ExpressionStatement dependency in Unary.
16993 (Unary): Removed `method' and `Arguments' from this class, making
16994 it smaller, and moving it all to SimpleCall, so I can reuse this
16995 code in other locations and avoid creating a lot of transient data
16996 strucutres when not required.
16998 * cs-parser.jay: Adjust for new changes.
17000 2001-11-11 Miguel de Icaza <miguel@ximian.com>
17002 * enum.cs (Enum.Populate): If there is a failure during
17005 * cs-parser.jay (opt_enum_base): we used to catch type errors
17006 here, but this is really incorrect. The type error should be
17007 catched during semantic analysis.
17009 2001-12-11 Ravi Pratap <ravi@ximian.com>
17011 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
17012 current_local_parameters as expected since I, in my stupidity, had forgotten
17015 * attribute.cs (GetValidPlaces): Fix stupid bug.
17017 * class.cs (Method::Emit): Perform check on applicability of attributes.
17019 (Constructor::Emit): Ditto.
17021 (Field::Emit): Ditto.
17023 (Field.Location): Store location information.
17025 (Property, Event, Indexer, Operator): Ditto.
17027 * cs-parser.jay (field_declaration): Pass in location for each field.
17029 * ../errors/cs0592.cs : Add.
17031 2001-11-12 Ravi Pratap <ravi@ximian.com>
17033 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
17035 (InitCoreTypes): Update accordingly.
17037 (RegisterAttrType, LookupAttr): Implement.
17039 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
17040 info about the same.
17042 (Resolve): Update to populate the above as necessary.
17044 (Error592): Helper.
17046 (GetValidPlaces): Helper to the above.
17048 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
17050 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
17052 2001-11-12 Ravi Pratap <ravi@ximian.com>
17054 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
17056 * ../errors/cs0617.cs : Add.
17058 2001-11-11 Ravi Pratap <ravi@ximian.com>
17060 * enum.cs (Emit): Rename to Populate to be more consistent with what
17061 we expect it to do and when exactly it is called.
17063 * class.cs, rootcontext.cs : Update accordingly.
17065 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
17066 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
17068 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
17070 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
17071 of a fieldinfo using the above, when dealing with a FieldBuilder.
17073 2001-11-10 Ravi Pratap <ravi@ximian.com>
17075 * ../errors/cs0031.cs : Add.
17077 * ../errors/cs1008.cs : Add.
17079 * ../errrors/cs0543.cs : Add.
17081 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
17084 (FindMembers): Implement.
17086 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
17087 enums and delegates too.
17089 (enum_types): Rename to builder_to_enum.
17091 (delegate_types): Rename to builder_to_delegate.
17093 * delegate.cs (FindMembers): Implement.
17095 2001-11-09 Ravi Pratap <ravi@ximian.com>
17097 * typemanager.cs (IsEnumType): Implement.
17099 * enum.cs (Emit): Re-write parts to account for the underlying type
17100 better and perform checking etc.
17102 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
17103 of the underlying type.
17105 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
17108 * enum.cs (error31): Helper to report error #31.
17110 * cs-parser.jay (enum_declaration): Store location of each member too.
17112 * enum.cs (member_to_location): New hashtable.
17114 (AddEnumMember): Update location hashtable.
17116 (Emit): Use the location of each member while reporting errors.
17118 2001-11-09 Miguel de Icaza <miguel@ximian.com>
17120 * cs-parser.jay: A for_initializer if is a
17121 local_variable_declaration really ammount to have an implicit
17122 block with the variable declaration and no initializer for for.
17124 * statement.cs (For.Emit): Cope with null initializers.
17126 This fixes the infinite loop on for initializers.
17128 2001-11-08 Miguel de Icaza <miguel@ximian.com>
17130 * enum.cs: More cleanup.
17132 * ecore.cs: Remove dead code.
17134 * class.cs (Property.Emit): More simplification.
17135 (Event.Emit): ditto.
17137 Reworked to have less levels of indentation.
17139 2001-11-08 Ravi Pratap <ravi@ximian.com>
17141 * class.cs (Property): Emit attributes.
17151 * enum.cs (Emit): Ditto.
17153 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
17156 * class.cs (Field, Event, etc.): Move attribute generation into the
17157 Emit method everywhere.
17159 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
17160 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
17161 as we had no way of defining nested enums !
17163 * rootcontext.cs : Adjust code accordingly.
17165 * typemanager.cs (AddEnumType): To keep track of enum types separately.
17167 2001-11-07 Ravi Pratap <ravi@ximian.com>
17169 * expression.cs (EvalConstantExpression): Move into ecore.cs
17171 * enum.cs (Enum): Rename some members and make them public and readonly
17172 according to our convention.
17174 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
17177 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
17179 (Enum::Emit): Write a simple version for now which doesn't try to compute
17180 expressions. I shall modify this to be more robust in just a while.
17182 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
17184 (TypeContainer::CloseType): Create the Enum types too.
17186 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
17188 * expression.cs (EvalConstantExpression): Get rid of completely.
17190 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
17191 user-defined values and other cases.
17193 (IsValidEnumLiteral): Helper function.
17195 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
17196 out there in the case we had a literal FieldExpr.
17198 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
17200 (Literalize): Revamp a bit to take two arguments.
17202 (EnumLiteral): New class which derives from Literal to wrap enum literals.
17204 2001-11-06 Ravi Pratap <ravi@ximian.com>
17206 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
17208 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
17210 (Resolve): Use the above to ensure we have proper initializers.
17212 2001-11-05 Ravi Pratap <ravi@ximian.com>
17214 * expression.cs (Expression::EvalConstantExpression): New method to
17215 evaluate constant expressions.
17217 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
17219 2001-11-07 Miguel de Icaza <miguel@ximian.com>
17221 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
17224 (Binary.ResolveOperator): Handle operator != (object a, object b)
17225 and operator == (object a, object b);
17227 (Binary.DoNumericPromotions): Indicate whether the numeric
17228 promotion was possible.
17230 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
17233 Made the ArrayAccess implement interface IAssignMethod instead of
17234 IStackStore as the order in which arguments are passed reflects
17237 * assign.cs: Instead of using expr.ExprClass to select the way of
17238 assinging, probe for the IStackStore/IAssignMethod interfaces.
17240 * typemanager.cs: Load InitializeArray definition.
17242 * rootcontext.cs (RootContext.MakeStaticData): Used to define
17243 static data that can be used to initialize arrays.
17245 2001-11-05 Miguel de Icaza <miguel@ximian.com>
17247 * expression.cs: Handle operator== and operator!= for booleans.
17249 (Conditioal.Reduce): Implement reducer for the ?: operator.
17251 (Conditional.Resolve): Implement dead code elimination.
17253 (Binary.Resolve): Catch string literals and return a new
17254 concatenated string.
17256 (Unary.Reduce): Implement reduction of unary expressions.
17258 * ecore.cs: Split out the expression core handling here.
17260 (Expression.Reduce): New method used to perform constant folding
17261 and CSE. This is needed to support constant-expressions.
17263 * statement.cs (Statement.EmitBoolExpression): Pass true and false
17264 targets, and optimize for !x.
17266 2001-11-04 Ravi Pratap <ravi@ximian.com>
17268 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
17269 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
17270 set custom atttributes.
17272 * literal.cs (Literal::GetValue): New abstract method to return the actual
17273 value of the literal, cast as an object.
17275 (*Literal): Implement GetValue method.
17277 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
17278 expressions to the arraylist but objects of type Argument.
17280 * class.cs (TypeContainer::Emit): Emit our attributes too.
17282 (Method::Emit, Constructor::Emit): Ditto.
17284 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
17285 to be ignoring earlier.
17287 2001-11-03 Ravi Pratap <ravi@ximian.com>
17289 * attribute.cs (AttributeSection::Define): Implement to do the business
17290 of constructing a CustomAttributeBuilder.
17292 (Attribute): New trivial class. Increases readability of code.
17294 * cs-parser.jay : Update accordingly.
17296 (positional_argument_list, named_argument_list, named_argument): New rules
17298 (attribute_arguments): Use the above so that we are more correct.
17300 2001-11-02 Ravi Pratap <ravi@ximian.com>
17302 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
17303 to perform all checks for a method with a params parameter.
17305 (Invocation::OverloadResolve): Update to use the above method and therefore
17306 cope correctly with params method invocations.
17308 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
17311 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
17312 constructors in our parent too because we can't afford to miss out on
17315 * attribute.cs (AttributeSection): New name for the class Attribute
17317 Other trivial changes to improve readability.
17319 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
17320 use the new class names.
17322 2001-11-01 Ravi Pratap <ravi@ximian.com>
17324 * class.cs (Method::Define): Complete definition for params types too
17326 (Indexer::Define): Ditto.
17328 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
17329 Cope everywhere with a request for info about the array parameter.
17331 2001-11-01 Ravi Pratap <ravi@ximian.com>
17333 * tree.cs (RecordNamespace): Fix up to check for the correct key.
17335 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
17336 local_variable_type to extract the string corresponding to the type.
17338 (local_variable_type): Fixup the action to use the new helper method.
17340 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
17343 * expression.cs : Clean out code which uses the above.
17345 2001-10-31 Ravi Pratap <ravi@ximian.com>
17347 * typemanager.cs (RegisterMethod): Check if we already have an existing key
17348 and bale out if necessary by returning a false.
17350 (RegisterProperty): Ditto.
17352 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
17353 and print out appropriate error messages.
17355 * interface.cs (everywhere): Ditto.
17357 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
17358 location to constructor.
17360 * class.cs (Property, Event, Indexer): Update accordingly.
17362 * ../errors/cs111.cs : Added.
17364 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
17365 of a method, as laid down by the spec.
17367 (Invocation::OverloadResolve): Use the above method.
17369 2001-10-31 Ravi Pratap <ravi@ximian.com>
17371 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
17372 now take a TypeContainer and a Parameters object.
17374 (ParameterData): Modify return type of ParameterModifier method to be
17375 Parameter.Modifier and not a string.
17377 (ReflectionParameters, InternalParameters): Update accordingly.
17379 * expression.cs (Argument::GetParameterModifier): Same here.
17381 * support.cs (InternalParameters::ParameterType): Find a better way of determining
17382 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
17383 symbol in it at all so maybe this is only for now.
17385 2001-10-30 Ravi Pratap <ravi@ximian.com>
17387 * support.cs (InternalParameters): Constructor now takes an extra argument
17388 which is the actual Parameters class.
17390 (ParameterDesc): Update to provide info on ref/out modifiers.
17392 * class.cs (everywhere): Update call to InternalParameters to pass in
17393 the second argument too.
17395 * support.cs (ParameterData): Add ParameterModifier, which is a method
17396 to return the modifier info [ref/out etc]
17398 (InternalParameters, ReflectionParameters): Implement the above.
17400 * expression.cs (Argument::ParameterModifier): Similar function to return
17401 info about the argument's modifiers.
17403 (Invocation::OverloadResolve): Update to take into account matching modifiers
17406 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
17407 a new SetFormalParameters object which we pass to InternalParameters.
17409 2001-10-30 Ravi Pratap <ravi@ximian.com>
17411 * expression.cs (NewArray): Merge into the ArrayCreation class.
17413 2001-10-29 Ravi Pratap <ravi@ximian.com>
17415 * expression.cs (NewArray): Merge classes NewBuiltinArray and
17416 NewUserdefinedArray into one as there wasn't much of a use in having
17419 * expression.cs (Argument): Change field's name to ArgType from Type.
17421 (Type): New readonly property which returns the proper type, taking into
17422 account ref/out modifiers.
17424 (everywhere): Adjust code accordingly for the above.
17426 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
17427 whether we are emitting for a ref or out parameter.
17429 * expression.cs (Argument::Emit): Use the above field to set the state.
17431 (LocalVariableReference::Emit): Update to honour the flag and emit the
17434 * parameter.cs (Attributes): Set the correct flags for ref parameters.
17436 * expression.cs (Argument::FullDesc): New function to provide a full desc.
17438 * support.cs (ParameterData): Add method ParameterDesc to the interface.
17440 (ReflectionParameters, InternalParameters): Implement the above method.
17442 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
17445 (Invocation::FullMethodDesc): Ditto.
17447 2001-10-29 Miguel de Icaza <miguel@ximian.com>
17449 * cs-parser.jay: Add extra production for the second form of array
17452 * expression.cs (ArrayCreation): Update to reflect the above
17455 * Small changes to prepare for Array initialization.
17457 2001-10-28 Miguel de Icaza <miguel@ximian.com>
17459 * typemanager.cs (ImplementsInterface): interface might be null;
17460 Deal with this problem;
17462 Also, we do store negative hits on the cache (null values), so use
17463 this instead of calling t.GetInterfaces on the type everytime.
17465 2001-10-28 Ravi Pratap <ravi@ximian.com>
17467 * typemanager.cs (IsBuiltinType): New method to help determine the same.
17469 * expression.cs (New::DoResolve): Get rid of array creation code and instead
17470 split functionality out into different classes.
17472 (New::FormArrayType): Move into NewBuiltinArray.
17474 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
17477 (NewBuiltinArray): New class to handle creation of built-in arrays.
17479 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
17480 account creation of one-dimensional arrays.
17482 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
17484 (NewUserdefinedArray::DoResolve): Implement.
17486 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
17488 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
17489 we maintain inside the TypeManager. This is necessary to perform lookups on the
17492 (LookupType): Update to perform GetType on the module builders too.
17494 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
17496 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
17498 2001-10-23 Ravi Pratap <ravi@ximian.com>
17500 * expression.cs (New::DoResolve): Implement guts of array creation.
17502 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
17504 2001-10-27 Miguel de Icaza <miguel@ximian.com>
17506 * expression.cs: Fix bug I introduced lsat night that broke
17509 (Expression.Resolve): Report a 246 error (can not resolve name)
17510 if we find a SimpleName in the stream.
17512 (Expression.ResolveLValue): Ditto.
17514 (Expression.ResolveWithSimpleName): This function is a variant of
17515 ResolveName, this one allows SimpleNames to be returned without a
17516 warning. The only consumer of SimpleNames is MemberAccess
17518 2001-10-26 Miguel de Icaza <miguel@ximian.com>
17520 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
17521 might arrive here. I have my doubts that this is correct.
17523 * statement.cs (Lock): Implement lock statement.
17525 * cs-parser.jay: Small fixes to support `lock' and `using'
17527 * cs-tokenizer.cs: Remove extra space
17529 * driver.cs: New flag --checked, allows to turn on integer math
17532 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
17533 Threading.Monitor.Exit
17535 2001-10-23 Miguel de Icaza <miguel@ximian.com>
17537 * expression.cs (IndexerAccess::DoResolveLValue): Set the
17538 Expression Class to be IndexerAccess.
17540 Notice that Indexer::DoResolve sets the eclass to Value.
17542 2001-10-22 Miguel de Icaza <miguel@ximian.com>
17544 * class.cs (TypeContainer::Emit): Emit code for indexers.
17546 * assign.cs (IAssignMethod): New interface implemented by Indexers
17547 and Properties for handling assignment.
17549 (Assign::Emit): Simplify and reuse code.
17551 * expression.cs (IndexerAccess, PropertyExpr): Implement
17552 IAssignMethod, clean up old code.
17554 2001-10-22 Ravi Pratap <ravi@ximian.com>
17556 * typemanager.cs (ImplementsInterface): New method to determine if a type
17557 implements a given interface. Provides a nice cache too.
17559 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
17562 (ConvertReferenceExplicit): Ditto.
17564 * delegate.cs (Delegate::Populate): Update to define the parameters on the
17565 various methods, with correct names etc.
17567 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
17568 Operator.UnaryNegation.
17570 * cs-parser.jay (operator_declarator): Be a little clever in the case where
17571 we have a unary plus or minus operator.
17573 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
17576 * everywhere : update accordingly.
17578 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
17581 * class.cs (Method::Define): For the case where we are implementing a method
17582 inherited from an interface, we need to set the MethodAttributes.Final flag too.
17583 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
17585 2001-10-21 Ravi Pratap <ravi@ximian.com>
17587 * interface.cs (FindMembers): Implement to work around S.R.E
17590 * typemanager.cs (IsInterfaceType): Implement.
17592 (FindMembers): Update to handle interface types too.
17594 * expression.cs (ImplicitReferenceConversion): Re-write bits which
17595 use IsAssignableFrom as that is not correct - it doesn't work.
17597 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
17598 and accordingly override EmitStatement.
17600 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
17601 using the correct logic :-)
17603 2001-10-19 Ravi Pratap <ravi@ximian.com>
17605 * ../errors/cs-11.cs : Add to demonstrate error -11
17607 2001-10-17 Miguel de Icaza <miguel@ximian.com>
17609 * assign.cs (Assign::Resolve): Resolve right hand side first, and
17610 then pass this as a hint to ResolveLValue.
17612 * expression.cs (FieldExpr): Add Location information
17614 (FieldExpr::LValueResolve): Report assignment to readonly
17617 (Expression::ExprClassFromMemberInfo): Pass location information.
17619 (Expression::ResolveLValue): Add new method that resolves an
17622 (Expression::DoResolveLValue): Default invocation calls
17625 (Indexers): New class used to keep track of indexers in a given
17628 (IStackStore): Renamed from LValue, as it did not really describe
17629 what this did. Also ResolveLValue is gone from this interface and
17630 now is part of Expression.
17632 (ElementAccess): Depending on the element access type
17634 * typemanager.cs: Add `indexer_name_type' as a Core type
17635 (System.Runtime.CompilerServices.IndexerNameAttribute)
17637 * statement.cs (Goto): Take a location.
17639 2001-10-18 Ravi Pratap <ravi@ximian.com>
17641 * delegate.cs (Delegate::VerifyDelegate): New method to verify
17642 if two delegates are compatible.
17644 (NewDelegate::DoResolve): Update to take care of the case when
17645 we instantiate a delegate from another delegate.
17647 * typemanager.cs (FindMembers): Don't even try to look up members
17648 of Delegate types for now.
17650 2001-10-18 Ravi Pratap <ravi@ximian.com>
17652 * delegate.cs (NewDelegate): New class to take care of delegate
17655 * expression.cs (New): Split the delegate related code out into
17656 the NewDelegate class.
17658 * delegate.cs (DelegateInvocation): New class to handle delegate
17661 * expression.cs (Invocation): Split out delegate related code into
17662 the DelegateInvocation class.
17664 2001-10-17 Ravi Pratap <ravi@ximian.com>
17666 * expression.cs (New::DoResolve): Implement delegate creation fully
17667 and according to the spec.
17669 (New::DoEmit): Update to handle delegates differently.
17671 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
17672 because of which we were printing out arguments in reverse order !
17674 * delegate.cs (VerifyMethod): Implement to check if the given method
17675 matches the delegate.
17677 (FullDelegateDesc): Implement.
17679 (VerifyApplicability): Implement.
17681 * expression.cs (Invocation::DoResolve): Update to accordingly handle
17682 delegate invocations too.
17684 (Invocation::Emit): Ditto.
17686 * ../errors/cs1593.cs : Added.
17688 * ../errors/cs1594.cs : Added.
17690 * delegate.cs (InstanceExpression, TargetMethod): New properties.
17692 2001-10-16 Ravi Pratap <ravi@ximian.com>
17694 * typemanager.cs (intptr_type): Core type for System.IntPtr
17696 (InitCoreTypes): Update for the same.
17698 (iasyncresult_type, asynccallback_type): Ditto.
17700 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
17703 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
17706 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
17707 the builders for the 4 members of a delegate type :-)
17709 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
17712 * expression.cs (New::DoResolve): Implement guts for delegate creation.
17714 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
17716 2001-10-15 Miguel de Icaza <miguel@ximian.com>
17718 * statement.cs (Break::Emit): Implement.
17719 (Continue::Emit): Implement.
17721 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
17722 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
17723 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
17724 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
17727 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
17728 properties that track the label for the current loop (begin of the
17729 loop and end of the loop).
17731 2001-10-15 Ravi Pratap <ravi@ximian.com>
17733 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
17734 use of emitting anything at all.
17736 * class.cs, rootcontext.cs : Get rid of calls to the same.
17738 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
17740 (Populate): Define the constructor correctly and set the implementation
17743 * typemanager.cs (delegate_types): New hashtable to hold delegates that
17746 (AddDelegateType): Implement.
17748 (IsDelegateType): Implement helper method.
17750 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
17752 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
17753 and accordingly handle it.
17755 * delegate.cs (Populate): Take TypeContainer argument.
17756 Implement bits to define the Invoke method. However, I still haven't figured out
17757 how to take care of the native int bit :-(
17759 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
17760 Qualify the name of the delegate, not its return type !
17762 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
17765 (StandardConversionExists): Checking for array types turns out to be recursive.
17767 (ConvertReferenceExplicit): Implement array conversion.
17769 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
17771 2001-10-12 Ravi Pratap <ravi@ximian.com>
17773 * cs-parser.jay (delegate_declaration): Store the fully qualified
17774 name as it is a type declaration.
17776 * delegate.cs (ReturnType, Name): Rename members to these. Make them
17779 (DefineDelegate): Renamed from Define. Does the same thing essentially,
17780 as TypeContainer::DefineType.
17782 (Populate): Method in which all the definition of the various methods (Invoke)
17785 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
17788 (CloseDelegate): Finally creates the delegate.
17790 * class.cs (TypeContainer::DefineType): Update to define delegates.
17791 (Populate, Emit and CloseType): Do the same thing here too.
17793 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
17794 delegates in all these operations.
17796 2001-10-14 Miguel de Icaza <miguel@ximian.com>
17798 * expression.cs: LocalTemporary: a new expression used to
17799 reference a temporary that has been created.
17801 * assign.cs: Handle PropertyAccess back here, so that we can
17802 provide the proper semantic access to properties.
17804 * expression.cs (Expression::ConvertReferenceExplicit): Implement
17805 a few more explicit conversions.
17807 * modifiers.cs: `NEW' modifier maps to HideBySig.
17809 * expression.cs (PropertyExpr): Make this into an
17810 ExpressionStatement, and support the EmitStatement code path.
17812 Perform get/set error checking, clean up the interface.
17814 * assign.cs: recognize PropertyExprs as targets, and if so, turn
17815 them into toplevel access objects.
17817 2001-10-12 Miguel de Icaza <miguel@ximian.com>
17819 * expression.cs: PropertyExpr::PropertyExpr: use work around the
17822 * typemanager.cs: Keep track here of our PropertyBuilders again to
17823 work around lameness in SRE.
17825 2001-10-11 Miguel de Icaza <miguel@ximian.com>
17827 * expression.cs (LValue::LValueResolve): New method in the
17828 interface, used to perform a second resolution pass for LValues.
17830 (This::DoResolve): Catch the use of this in static methods.
17832 (This::LValueResolve): Implement.
17834 (This::Store): Remove warning, assigning to `this' in structures
17837 (Invocation::Emit): Deal with invocation of
17838 methods on value types. We need to pass the address to structure
17839 methods rather than the object itself. (The equivalent code to
17840 emit "this" for structures leaves the entire structure on the
17841 stack instead of a pointer to it).
17843 (ParameterReference::DoResolve): Compute the real index for the
17844 argument based on whether the method takes or not a `this' pointer
17845 (ie, the method is static).
17847 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
17848 value types returned from functions when we need to invoke a
17849 method on the sturcture.
17852 2001-10-11 Ravi Pratap <ravi@ximian.com>
17854 * class.cs (TypeContainer::DefineType): Method to actually do the business of
17855 defining the type in the Modulebuilder or Typebuilder. This is to take
17856 care of nested types which need to be defined on the TypeBuilder using
17857 DefineNestedMethod.
17859 (TypeContainer::GetClassBases): Implement. Essentially the code from the
17860 methods in RootContext, only ported to be part of TypeContainer.
17862 (TypeContainer::GetInterfaceOrClass): Ditto.
17864 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
17866 * interface.cs (Interface::DefineInterface): New method. Does exactly
17867 what RootContext.CreateInterface did earlier, only it takes care of nested types
17870 (Interface::GetInterfaces): Move from RootContext here and port.
17872 (Interface::GetInterfaceByName): Same here.
17874 * rootcontext.cs (ResolveTree): Re-write.
17876 (PopulateTypes): Re-write.
17878 * class.cs (TypeContainer::Populate): Populate nested types too.
17879 (TypeContainer::Emit): Emit nested members too.
17881 * typemanager.cs (AddUserType): Do not make use of the FullName property,
17882 instead just use the name argument passed in as it is already fully
17885 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
17886 to TypeContainer mapping to see if a type is user-defined.
17888 * class.cs (TypeContainer::CloseType): Implement.
17890 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
17891 the default constructor.
17893 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
17896 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
17898 * interface.cs (CloseType): Create the type here.
17900 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
17903 Remove all the methods which are now in TypeContainer.
17905 2001-10-10 Ravi Pratap <ravi@ximian.com>
17907 * delegate.cs (Define): Re-write bits to define the delegate
17910 2001-10-10 Miguel de Icaza <miguel@ximian.com>
17912 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
17914 * expression.cs (ImplicitReferenceConversion): handle null as well
17915 as a source to convert to any reference type.
17917 * statement.cs (Return): Perform any implicit conversions to
17918 expected return type.
17920 Validate use of return statement.
17922 * codegen.cs (EmitContext): Pass the expected return type here.
17924 * class.cs (Method, Constructor, Property): Pass expected return
17925 type to EmitContext.
17927 2001-10-09 Miguel de Icaza <miguel@ximian.com>
17929 * expression.cs: Make DoResolve take an EmitContext instead of a
17932 Replaced `l' and `location' for `loc', for consistency.
17934 (Error, Warning): Remove unneeded Tc argument.
17936 * assign.cs, literal.cs, constant.cs: Update to new calling
17939 * codegen.cs: EmitContext now contains a flag indicating whether
17940 code is being generated in a static method or not.
17942 * cs-parser.jay: DecomposeQI, new function that replaces the old
17943 QualifiedIdentifier. Now we always decompose the assembled
17944 strings from qualified_identifier productions into a group of
17947 2001-10-08 Miguel de Icaza <miguel@ximian.com>
17949 * rootcontext.cs: Deal with field-less struct types correctly now
17950 by passing the size option to Define Type.
17952 * class.cs: Removed hack that created one static field.
17954 2001-10-07 Miguel de Icaza <miguel@ximian.com>
17956 * statement.cs: Moved most of the code generation here.
17958 2001-10-09 Ravi Pratap <ravi@ximian.com>
17960 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
17963 (ElementAccess): Remove useless bits for now - keep checks as the spec
17966 2001-10-08 Ravi Pratap <ravi@ximian.com>
17968 * expression.cs (ElementAccess::DoResolve): Remove my crap code
17969 and start performing checks according to the spec.
17971 2001-10-07 Ravi Pratap <ravi@ximian.com>
17973 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
17974 rank_specifiers instead.
17976 (rank_specifiers): Change the order in which the rank specifiers are stored
17978 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
17980 * expression.cs (ElementAccess): Implement the LValue interface too.
17982 2001-10-06 Ravi Pratap <ravi@ximian.com>
17984 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
17985 except that user defined conversions are not included.
17987 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
17988 perform the conversion of the return type, if necessary.
17990 (New::DoResolve): Check whether we are creating an array or an object
17991 and accordingly do the needful.
17993 (New::Emit): Same here.
17995 (New::DoResolve): Implement guts of array creation.
17997 (New::FormLookupType): Helper function.
17999 2001-10-07 Miguel de Icaza <miguel@ximian.com>
18001 * codegen.cs: Removed most of the code generation here, and move the
18002 corresponding code generation bits to the statement classes.
18004 Added support for try/catch/finalize and throw.
18006 * cs-parser.jay: Added support for try/catch/finalize.
18008 * class.cs: Catch static methods having the flags override,
18009 virtual or abstract.
18011 * expression.cs (UserCast): This user cast was not really doing
18012 what it was supposed to do. Which is to be born in fully resolved
18013 state. Parts of the resolution were being performed at Emit time!
18017 2001-10-05 Miguel de Icaza <miguel@ximian.com>
18019 * expression.cs: Implicity convert the result from UserCast.
18021 2001-10-05 Ravi Pratap <ravi@ximian.com>
18023 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
18024 prevented it from working correctly.
18026 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
18027 merely ConvertImplicit.
18029 2001-10-05 Miguel de Icaza <miguel@ximian.com>
18031 * typemanager.cs: Make the LookupTypeContainer function static,
18032 and not per-instance.
18034 * class.cs: Make static FindMembers (the one that takes a Type
18037 * codegen.cs: Add EmitForeach here.
18039 * cs-parser.jay: Make foreach a toplevel object instead of the
18040 inline expansion, as we need to perform semantic analysis on it.
18042 2001-10-05 Ravi Pratap <ravi@ximian.com>
18044 * expression.cs (Expression::ImplicitUserConversion): Rename to
18045 UserDefinedConversion.
18047 (Expression::UserDefinedConversion): Take an extra argument specifying
18048 whether we look for explicit user conversions too.
18050 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
18052 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
18054 (ExplicitUserConversion): Make it a call to UserDefinedConversion
18055 with the appropriate arguments.
18057 * cs-parser.jay (cast_expression): Record location too.
18059 * expression.cs (Cast): Record location info.
18061 (Expression::ConvertExplicit): Take location argument.
18063 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
18064 to determine if we are doing explicit conversions.
18066 (UserCast::Emit): Update accordingly.
18068 (Expression::ConvertExplicit): Report an error if everything fails.
18070 * ../errors/cs0030.cs : Add.
18072 2001-10-04 Miguel de Icaza <miguel@ximian.com>
18074 * modifiers.cs: If the ABSTRACT keyword is present, also set the
18075 virtual and newslot bits.
18077 * class.cs (TypeContainer::RegisterRequiredImplementations):
18078 Record methods we need.
18080 (TypeContainer::MakeKey): Helper function to make keys for
18081 MethodBases, since the Methodbase key is useless.
18083 (TypeContainer::Populate): Call RegisterRequiredImplementations
18084 before defining the methods.
18086 Create a mapping for method_builders_to_methods ahead of time
18087 instead of inside a tight loop.
18089 (::RequireMethods): Accept an object as the data to set into the
18090 hashtable so we can report interface vs abstract method mismatch.
18092 2001-10-03 Miguel de Icaza <miguel@ximian.com>
18094 * report.cs: Make all of it static.
18096 * rootcontext.cs: Drop object_type and value_type computations, as
18097 we have those in the TypeManager anyways.
18099 Drop report instance variable too, now it is a global.
18101 * driver.cs: Use try/catch on command line handling.
18103 Add --probe option to debug the error reporting system with a test
18106 * report.cs: Add support for exiting program when a probe
18107 condition is reached.
18109 2001-10-03 Ravi Pratap <ravi@ximian.com>
18111 * expression.cs (Binary::DoNumericPromotions): Fix the case when
18112 we do a forcible conversion regardless of type, to check if
18113 ForceConversion returns a null.
18115 (Binary::error19): Use location to report error.
18117 (Unary::error23): Use location here too.
18119 * ../errors/cs0019.cs : Check in.
18121 * ../errors/cs0023.cs : Check in.
18123 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
18124 case of a non-null MethodInfo object with a length of 0 !
18126 (Binary::ResolveOperator): Flag error if overload resolution fails to find
18127 an applicable member - according to the spec :-)
18128 Also fix logic to find members in base types.
18130 (Unary::ResolveOperator): Same here.
18132 (Unary::report23): Change name to error23 and make first argument a TypeContainer
18133 as I was getting thoroughly confused between this and error19 :-)
18135 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
18136 (::FindMostEncompassedType): Implement.
18137 (::FindMostEncompassingType): Implement.
18138 (::StandardConversionExists): Implement.
18140 (UserImplicitCast): Re-vamp. We now need info about most specific
18141 source and target types so that we can do the necessary conversions.
18143 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
18144 mathematical union with no duplicates.
18146 2001-10-03 Miguel de Icaza <miguel@ximian.com>
18148 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
18149 in order from base classes to child classes, so that we can in
18150 child classes look up in our parent for method names and
18151 attributes (required for handling abstract, virtual, new, override
18152 constructs: we need to instrospect our base class, and if we dont
18153 populate the classes in order, the introspection might be
18154 incorrect. For example, a method could query its parent before
18155 the parent has any methods and would determine that the parent has
18156 no abstract methods (while it could have had them)).
18158 (RootContext::CreateType): Record the order in which we define the
18161 2001-10-02 Miguel de Icaza <miguel@ximian.com>
18163 * class.cs (TypeContainer::Populate): Also method definitions can
18164 fail now, keep track of this.
18166 (TypeContainer::FindMembers): Implement support for
18167 DeclaredOnly/noDeclaredOnly flag.
18169 (Constructor::Emit) Return the ConstructorBuilder.
18171 (Method::Emit) Return the MethodBuilder.
18172 Check for abstract or virtual methods to be public.
18174 * rootcontext.cs (RootContext::CreateType): Register all the
18175 abstract methods required for the class to be complete and the
18176 interface methods that must be implemented.
18178 * cs-parser.jay: Report error 501 (method requires body if it is
18179 not marked abstract or extern).
18181 * expression.cs (TypeOf::Emit): Implement.
18183 * typemanager.cs: runtime_handle_type, new global type.
18185 * class.cs (Property::Emit): Generate code for properties.
18187 2001-10-02 Ravi Pratap <ravi@ximian.com>
18189 * expression.cs (Unary::ResolveOperator): Find operators on base type
18190 too - we now conform exactly to the spec.
18192 (Binary::ResolveOperator): Same here.
18194 * class.cs (Operator::Define): Fix minor quirk in the tests.
18196 * ../errors/cs0215.cs : Added.
18198 * ../errors/cs0556.cs : Added.
18200 * ../errors/cs0555.cs : Added.
18202 2001-10-01 Miguel de Icaza <miguel@ximian.com>
18204 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
18205 single integer which is really efficient
18207 2001-10-01 Ravi Pratap <ravi@ximian.com>
18209 * expression.cs (Expression::ImplicitUserConversion): Use location
18210 even in the case when we are examining True operators.
18212 * class.cs (Operator::Define): Perform extensive checks to conform
18213 with the rules for operator overloading in the spec.
18215 * expression.cs (Expression::ImplicitReferenceConversion): Implement
18216 some of the other conversions mentioned in the spec.
18218 * typemanager.cs (array_type): New static member for the System.Array built-in
18221 (cloneable_interface): For System.ICloneable interface.
18223 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
18224 we start resolving the tree and populating types.
18226 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
18228 2001-10-01 Miguel de Icaza <miguel@ximian.com>
18230 * expression.cs (Expression::ExprClassFromMemberInfo,
18231 Expression::Literalize): Create literal expressions from
18232 FieldInfos which are literals.
18234 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
18235 type casts, because they were wrong. The test suite in tests
18238 (ImplicitNumericConversion): ushort to ulong requires a widening
18241 Int32 constant to long requires widening cast as well.
18243 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
18244 for integers because the type on the stack is not i4.
18246 2001-09-30 Miguel de Icaza <miguel@ximian.com>
18248 * expression.cs (report118): require location argument.
18250 * parameter.cs: Do not dereference potential null value.
18252 * class.cs: Catch methods that lack the `new' keyword when
18253 overriding a name. Report warnings when `new' is used without
18254 anything being there to override.
18256 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
18258 * class.cs: Only add constructor to hashtable if it is non-null
18259 (as now constructors can fail on define).
18261 (TypeManager, Class, Struct): Take location arguments.
18263 Catch field instance initialization in structs as errors.
18265 accepting_filter: a new filter for FindMembers that is static so
18266 that we dont create an instance per invocation.
18268 (Constructor::Define): Catch errors where a struct constructor is
18271 * cs-parser.jay: Pass location information for various new
18274 * delegate.cs (Delegate): take a location argument.
18276 * driver.cs: Do not call EmitCode if there were problesm in the
18277 Definition of the types, as many Builders wont be there.
18279 * decl.cs (Decl::Decl): Require a location argument.
18281 * cs-tokenizer.cs: Handle properly hex constants that can not fit
18282 into integers, and find the most appropiate integer for it.
18284 * literal.cs: Implement ULongLiteral.
18286 * rootcontext.cs: Provide better information about the location of
18287 failure when CreateType fails.
18289 2001-09-29 Miguel de Icaza <miguel@ximian.com>
18291 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
18294 * expression.cs (Binary::CheckShiftArguments): Add missing type
18296 (Binary::ResolveOperator): Add type to the logical and and logical
18297 or, Bitwise And/Or and Exclusive Or code paths, it was missing
18300 (Binary::DoNumericPromotions): In the case where either argument
18301 is ulong (and most signed types combined with ulong cause an
18302 error) perform implicit integer constant conversions as well.
18304 2001-09-28 Miguel de Icaza <miguel@ximian.com>
18306 * expression.cs (UserImplicitCast): Method should always be
18308 (Invocation::BetterConversion): Simplified test for IntLiteral.
18310 (Expression::ImplicitNumericConversion): Split this routine out.
18311 Put the code that performs implicit constant integer conversions
18314 (Expression::Resolve): Become a wrapper around DoResolve so we can
18315 check eclass and type being set after resolve.
18317 (Invocation::Badness): Remove this dead function
18319 (Binary::ResolveOperator): Do not compute the expensive argumnets
18320 unless we have a union for it.
18322 (Probe::Emit): Is needs to do an isinst and then
18323 compare against null.
18325 (::CanConvert): Added Location argument. If the Location argument
18326 is null (Location.Null), then we do not report errors. This is
18327 used by the `probe' mechanism of the Explicit conversion. We do
18328 not want to generate an error for something that the user
18329 explicitly requested to be casted. But the pipeline for an
18330 explicit cast first tests for potential implicit casts.
18332 So for now, if the Location is null, it means `Probe only' to
18333 avoid adding another argument. Might have to revise this
18336 (ClassCast): New class used to type cast objects into arbitrary
18337 classes (used in Explicit Reference Conversions).
18339 Implement `as' as well.
18341 Reverted all the patches from Ravi below: they were broken:
18343 * The use of `level' as a mechanism to stop recursive
18344 invocations is wrong. That was there just to catch the
18345 bug with a strack trace but not as a way of addressing
18348 To fix the problem we have to *understand* what is going
18349 on and the interactions and come up with a plan, not
18350 just get things going.
18352 * The use of the type conversion cache that I proposed
18353 last night had an open topic: How does this work across
18354 protection domains. A user defined conversion might not
18355 be public in the location where we are applying the
18356 conversion, a different conversion might be selected
18357 (ie, private A->B (better) but public B->A (worse),
18358 inside A, A->B applies, but outside it, B->A will
18361 * On top of that (ie, even if the above is solved),
18362 conversions in a cache need to be abstract. Ie, `To
18363 convert from an Int to a Short use an OpcodeCast', not
18364 `To convert from an Int to a Short use the OpcodeCast on
18365 the variable 5' (which is what this patch was doing).
18367 2001-09-28 Ravi Pratap <ravi@ximian.com>
18369 * expression.cs (Invocation::ConversionExists): Re-write to use
18370 the conversion cache
18372 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
18373 cache all conversions done, not just user-defined ones.
18375 (Invocation::BetterConversion): The real culprit. Use ConversionExists
18376 to determine if a conversion exists instead of acutually trying to
18377 perform the conversion. It's faster too.
18379 (Expression::ConvertExplicit): Modify to use ConversionExists to check
18380 and only then attempt the implicit conversion.
18382 2001-09-28 Ravi Pratap <ravi@ximian.com>
18384 * expression.cs (ConvertImplicit): Use a cache for conversions
18385 already found. Check level of recursion and bail out if necessary.
18387 2001-09-28 Miguel de Icaza <miguel@ximian.com>
18389 * typemanager.cs (string_concat_string_string, string_concat_object_object):
18390 Export standard methods that we expect for string operations.
18392 * statement.cs (Block::UsageWarning): Track usage of variables and
18393 report the errors for not used variables.
18395 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
18398 2001-09-27 Miguel de Icaza <miguel@ximian.com>
18400 * codegen.cs: remove unnneded code
18402 * expression.cs: Removed BuiltinTypeAccess class
18404 Fix the order in which implicit conversions are
18407 The previous fixed dropped support for boxed conversions (adding a
18408 test to the test suite now)
18410 (UserImplicitCast::CanConvert): Remove test for source being null,
18411 that code is broken. We should not feed a null to begin with, if
18412 we do, then we should track the bug where the problem originates
18413 and not try to cover it up here.
18415 Return a resolved expression of type UserImplicitCast on success
18416 rather than true/false. Ravi: this is what I was talking about,
18417 the pattern is to use a static method as a "constructor" for
18420 Also, do not create arguments until the very last minute,
18421 otherwise we always create the arguments even for lookups that
18422 will never be performed.
18424 (UserImplicitCast::Resolve): Eliminate, objects of type
18425 UserImplicitCast are born in a fully resolved state.
18427 * typemanager.cs (InitCoreTypes): Init also value_type
18428 (System.ValueType).
18430 * expression.cs (Cast::Resolve): First resolve the child expression.
18432 (LValue): Add new method AddressOf to be used by
18435 Change the argument of Store to take an EmitContext instead of an
18436 ILGenerator, because things like FieldExpr need to be able to call
18437 their children expression to generate the instance code.
18439 (Expression::Error, Expression::Warning): Sugar functions for
18442 (Expression::MemberLookup): Accept a TypeContainer instead of a
18443 Report as the first argument.
18445 (Expression::ResolvePrimary): Killed. I still want to improve
18446 this as currently the code is just not right.
18448 (Expression::ResolveMemberAccess): Simplify, but it is still
18451 (Unary::Resolve): Catch errors in AddressOf operators.
18453 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
18454 index to a byte for the short-version, or the compiler will choose
18455 the wrong Emit call, which generates the wrong data.
18457 (ParameterReference::Emit, ::Store): same.
18459 (FieldExpr::AddressOf): Implement.
18461 * typemanager.cs: TypeManager: made public variable instead of
18464 * driver.cs: document --fatal.
18466 * report.cs (ErrorMessage, WarningMessage): new names for the old
18467 Error and Warning classes.
18469 * cs-parser.jay (member_access): Turn built-in access to types
18470 into a normal simplename
18472 2001-09-27 Ravi Pratap <ravi@ximian.com>
18474 * expression.cs (Invocation::BetterConversion): Fix to cope
18475 with q being null, since this was introducing a bug.
18477 * expression.cs (ConvertImplicit): Do built-in conversions first.
18479 2001-09-27 Ravi Pratap <ravi@ximian.com>
18481 * expression.cs (UserImplicitCast::Resolve): Fix bug.
18483 2001-09-27 Ravi Pratap <ravi@ximian.com>
18485 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
18486 I had introduced long ago (what's new ?).
18488 * expression.cs (UserImplicitCast::CanConvert): Static method to do
18489 the work of all the checking.
18490 (ConvertImplicit): Call CanConvert and only then create object if necessary.
18491 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
18493 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
18494 that is the right way.
18496 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
18497 overloading resolution. Use everywhere instead of cutting and pasting code.
18499 (Binary::ResolveOperator): Use MakeUnionSet.
18501 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
18502 we have to convert to bool types. Not complete yet.
18504 2001-09-27 Miguel de Icaza <miguel@ximian.com>
18506 * typemanager.cs (TypeManager::CSharpName): support ushort.
18508 * expression.cs (Expression::TryImplicitIntConversion): Attempts
18509 to provide an expression that performsn an implicit constant int
18510 conversion (section 6.1.6).
18511 (Expression::ConvertImplicitRequired): Reworked to include
18512 implicit constant expression conversions.
18514 (Expression::ConvertNumericExplicit): Finished.
18516 (Invocation::Emit): If InstanceExpression is null, then it means
18517 that we perform a call on this.
18519 2001-09-26 Miguel de Icaza <miguel@ximian.com>
18521 * expression.cs (Unary::Emit): Remove some dead code.
18522 (Probe): Implement Resolve and Emit for `is'.
18523 (Expression::ConvertImplicitRequired): Attempt to do constant
18524 expression conversions here. Maybe should be moved to
18525 ConvertImplicit, but I am not sure.
18526 (Expression::ImplicitLongConstantConversionPossible,
18527 Expression::ImplicitIntConstantConversionPossible): New functions
18528 that tell whether is it possible to apply an implicit constant
18529 expression conversion.
18531 (ConvertNumericExplicit): Started work on explicit numeric
18534 * cs-parser.jay: Update operator constants.
18536 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
18537 (Parameters::GetSignature): Hook up VerifyArgs here.
18538 (Parameters::VerifyArgs): Verifies that no two arguments have the
18541 * class.cs (Operator): Update the operator names to reflect the
18542 ones that the spec expects (as we are just stringizing the
18545 * expression.cs (Unary::ResolveOperator): Fix bug: Use
18546 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
18547 previous usage did only work for our methods.
18548 (Expression::ConvertImplicit): Handle decimal implicit numeric
18549 conversions as well.
18550 (Expression::InternalTypeConstructor): Used to invoke constructors
18551 on internal types for default promotions.
18553 (Unary::Emit): Implement special handling for the pre/post
18554 increment/decrement for overloaded operators, as they need to have
18555 the same semantics as the other operators.
18557 (Binary::ResolveOperator): ditto.
18558 (Invocation::ConversionExists): ditto.
18559 (UserImplicitCast::Resolve): ditto.
18561 2001-09-26 Ravi Pratap <ravi@ximian.com>
18563 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
18564 operator, return after emitting body. Regression tests pass again !
18566 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
18567 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
18568 (Invocation::OverloadResolve): Ditto.
18569 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
18571 * everywhere : update calls to the above methods accordingly.
18573 2001-09-26 Miguel de Icaza <miguel@ximian.com>
18575 * assign.cs (Assign): Make it inherit from ExpressionStatement.
18577 * expression.cs (ExpressionStatement): New base class used for
18578 expressions that can appear in statements, so that we can provide
18579 an alternate path to generate expression that do not leave a value
18582 (Expression::Emit, and all the derivatives): We no longer return
18583 whether a value is left on the stack or not. Every expression
18584 after being emitted leaves a single value on the stack.
18586 * codegen.cs (EmitContext::EmitStatementExpression): Use the
18587 facilties of ExpressionStatement if possible.
18589 * cs-parser.jay: Update statement_expression.
18591 2001-09-25 Miguel de Icaza <miguel@ximian.com>
18593 * driver.cs: Change the wording of message
18595 2001-09-25 Ravi Pratap <ravi@ximian.com>
18597 * expression.cs (Binary::ResolveOperator): Had forgottten to set
18598 the type of the expression to the return type of the method if
18599 we have an overloaded operator match ! The regression tests pass again !
18600 (Unary::ResolveOperator): Ditto.
18602 * expression.cs (Invocation::ConversionExists): Correct the member lookup
18603 to find "op_Implicit", not "implicit" ;-)
18604 (UserImplicitCast): New class to take care of user-defined implicit conversions.
18605 (ConvertImplicit, ForceConversion): Take TypeContainer argument
18607 * everywhere : Correct calls to the above accordingly.
18609 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
18610 (ConvertImplicit): Do user-defined conversion if it exists.
18612 2001-09-24 Miguel de Icaza <miguel@ximian.com>
18614 * assign.cs: track location.
18615 (Resolve): Use implicit conversions on assignment.
18617 * literal.cs: Oops. Not good, Emit of short access values should
18618 pass (Bytes) or the wrong argument will be selected.
18620 * expression.cs (Unary::Emit): Emit code for -expr.
18622 (Unary::ResolveOperator): Handle `Substract' for non-constants
18623 (substract from zero from the non-constants).
18624 Deal with Doubles as well.
18626 (Expression::ConvertImplicitRequired): New routine that reports an
18627 error if no implicit conversion exists.
18629 (Invocation::OverloadResolve): Store the converted implicit
18630 expressions if we make them
18632 2001-09-24 Ravi Pratap <ravi@ximian.com>
18634 * class.cs (ConstructorInitializer): Take a Location argument.
18635 (ConstructorBaseInitializer): Same here.
18636 (ConstructorThisInitializer): Same here.
18638 * cs-parser.jay : Update all calls accordingly.
18640 * expression.cs (Unary, Binary, New): Take location argument.
18641 Update accordingly everywhere.
18643 * cs-parser.jay : Update all calls to the above to take a location
18646 * class.cs : Ditto.
18648 2001-09-24 Ravi Pratap <ravi@ximian.com>
18650 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
18651 (Invocation::BetterConversion): Same here
18652 (Invocation::ConversionExists): Ditto.
18654 (Invocation::ConversionExists): Implement.
18656 2001-09-22 Ravi Pratap <ravi@ximian.com>
18658 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
18659 Also take an additional TypeContainer argument.
18661 * All over : Pass in TypeContainer as argument to OverloadResolve.
18663 * typemanager.cs (CSharpName): Update to check for the string type and return
18666 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
18669 2001-09-21 Ravi Pratap <ravi@ximian.com>
18671 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
18672 (Invocation::BetterFunction): Implement.
18673 (Invocation::BetterConversion): Implement.
18674 (Invocation::ConversionExists): Skeleton, no implementation yet.
18676 Okay, things work fine !
18678 2001-09-21 Miguel de Icaza <miguel@ximian.com>
18680 * typemanager.cs: declare and load enum_type, delegate_type and
18683 * expression.cs (Expression::Emit): Now emit returns a value that
18684 tells whether a value is left on the stack or not. This strategy
18685 might be reveted tomorrow with a mechanism that would address
18686 multiple assignments.
18687 (Expression::report118): Utility routine to report mismatches on
18690 (Unary::Report23): Report impossible type/operator combination
18693 (Unary::IsIncrementableNumber): Whether the type can be
18694 incremented or decremented with add.
18695 (Unary::ResolveOperator): Also allow enumerations to be bitwise
18697 (Unary::ResolveOperator): Implement ++, !, ~,
18699 (Invocation::Emit): Deal with new Emit convetion.
18701 * All Expression derivatives: Updated their Emit method to return
18702 whether they leave values on the stack or not.
18704 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
18705 stack for expressions that are statements.
18707 2001-09-20 Miguel de Icaza <miguel@ximian.com>
18709 * expression.cs (LValue): New interface. Must be implemented by
18711 (LocalVariableReference, ParameterReference, FieldExpr): Implement
18714 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
18715 interface for generating code, simplifies the code.
18717 2001-09-20 Ravi Pratap <ravi@ximian.com>
18719 * expression.cs (everywhere): Comment out return statements in ::Resolve
18720 methods to avoid the warnings.
18722 2001-09-20 Miguel de Icaza <miguel@ximian.com>
18724 * driver.cs (parse): Report error 2001 if we can not open the
18727 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
18730 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
18733 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
18734 otherwise nested blocks end up with the same index.
18736 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
18738 * expression.cs: Instead of having FIXMEs in the Resolve
18739 functions, throw exceptions so it is obvious that we are facing a
18742 * cs-parser.jay (invocation_expression): Pass Location information.
18744 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
18745 Use a basename for those routines because .NET does not like paths
18748 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
18751 2001-09-19 Miguel de Icaza <miguel@ximian.com>
18753 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
18754 are loading the correct data types (throws an exception if not).
18755 (TypeManager::InitCoreTypes): Use CoreLookupType
18757 * expression.cs (Unary::ResolveOperator): return the child
18758 expression for expressions which are just +expr.
18759 (Unary::ResolveOperator): Return negative literals for -LITERAL
18760 expressions (otherwise they are Unary {Literal}).
18761 (Invocation::Badness): Take into account `Implicit constant
18762 expression conversions'.
18764 * literal.cs (LongLiteral): Implement long literal class.
18765 (IntLiteral): export the `Value' of the intliteral.
18767 2001-09-19 Ravi Pratap <ravi@ximian.com>
18769 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
18771 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
18772 instead of 'Operator'
18774 * expression.cs (Binary::ResolveOperator): Update accordingly.
18775 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
18778 * cs-parser.jay (unary_expression): Update to use the new names.
18780 * gen-treedump.cs (GetUnary): Same here.
18782 * expression.cs (Unary::Resolve): Implement.
18783 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
18784 operators are found instead of making noise ;-)
18785 (Unary::ResolveOperator): New method to do precisely the same thing which
18786 Binary::ResolveOperator does for Binary expressions.
18787 (Unary.method, .Arguments): Add.
18788 (Unary::OperName): Implement.
18789 (Unary::ForceConversion): Copy and Paste !
18791 * class.cs (Operator::Define): Fix a small bug for the case when we have
18794 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
18795 for the inbuilt operators. Only overloading works for now ;-)
18797 2001-09-18 Miguel de Icaza <miguel@ximian.com>
18799 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
18800 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
18802 * expression.cs (This::Emit): Implement.
18803 (This::Resolve): Implement.
18804 (TypeOf:Resolve): Implement.
18805 (Expression::ResolveSimpleName): Add an implicit this to instance
18807 (MemberAccess::Resolve): Deal with Parameters and Fields.
18808 Bind instance variable to Field expressions.
18809 (FieldExpr::Instance): New field used to track the expression that
18810 represents the object instance.
18811 (FieldExpr::Resolve): Track potential errors from MemberLookup not
18813 (FieldExpr::Emit): Implement.
18815 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
18816 the last instruction contains a return opcode to avoid generating
18817 the last `ret' instruction (this generates correct code, and it is
18818 nice to pass the peverify output).
18820 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
18821 initializer for static and instance variables.
18822 (Constructor::Emit): Allow initializer to be null in the case of
18823 static constructors. Only emit initializer for instance
18826 (TypeContainer::FindMembers): Return a null array if there are no
18829 Also fix the code for the MemberTypes.Method branch, as it was not
18830 scanning that for operators (or tried to access null variables before).
18832 * assign.cs (Assign::Emit): Handle instance and static fields.
18836 * driver.cs: Stop compilation if there are parse errors.
18838 * cs-parser.jay (constructor_declaration): Provide default base
18839 initializer for non-static constructors.
18840 (constructor_declarator): Do not provide a default base
18841 initializers if none was specified.
18842 Catch the fact that constructors should not have parameters.
18844 * class.cs: Do not emit parent class initializers for static
18845 constructors, that should be flagged as an error.
18847 2001-09-18 Ravi Pratap <ravi@ximian.com>
18849 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
18850 Move back code into TypeContainer::Populate.
18852 2001-09-18 Ravi Pratap <ravi@ximian.com>
18854 * class.cs (TypeContainer::AddConstructor): Fix the check to
18855 compare against Name, not Basename.
18856 (Operator::OpType): Change Plus and Minus to Add and Subtract.
18858 * cs-parser.jay : Update accordingly.
18860 * class.cs (TypeContainer::FindMembers): For the case where we are searching
18861 for methods, don't forget to look into the operators too.
18862 (RegisterMethodBuilder): Helper method to take care of this for
18863 methods, constructors and operators.
18864 (Operator::Define): Completely revamp.
18865 (Operator.OperatorMethod, MethodName): New fields.
18866 (TypeContainer::Populate): Move the registering of builders into
18867 RegisterMethodBuilder.
18868 (Operator::Emit): Re-write.
18870 * expression.cs (Binary::Emit): Comment out code path to emit method
18871 invocation stuff for the case when we have a user defined operator. I am
18872 just not able to get it right !
18874 2001-09-17 Miguel de Icaza <miguel@ximian.com>
18876 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
18879 (Expression::MemberLookup): Provide a version that allows to
18880 specify the MemberTypes and BindingFlags.
18882 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
18883 so it was not fetching variable information from outer blocks.
18885 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
18886 Beforefieldinit as it was buggy.
18888 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
18889 that Ravi put here.
18891 * class.cs (Constructor::Emit): Only emit if block is not null.
18892 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
18893 deal with this by semantically definining it as if the user had
18896 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
18897 constructors as we now "emit" them at a higher level.
18899 (TypeContainer::DefineDefaultConstructor): Used to define the
18900 default constructors if none was provided.
18902 (ConstructorInitializer): Add methods Resolve and Emit.
18904 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
18906 2001-09-17 Ravi Pratap <ravi@ximian.com>
18908 * class.cs (TypeContainer::EmitDefaultConstructor): Register
18909 the default constructor builder with our hashtable for methodbuilders
18912 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
18913 and argument_count is 0 in which case we have a match.
18914 (Binary::ResolveOperator): More null checking and miscellaneous coding
18917 2001-09-17 Ravi Pratap <ravi@ximian.com>
18919 * rootcontext.cs (IsNameSpace): Compare against null.
18921 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
18923 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
18924 and Unary::Operator.
18926 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
18929 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
18930 we have overloaded operators.
18931 (Binary::ResolveOperator): Implement the part which does the operator overload
18934 * class.cs (Operator::Emit): Implement.
18935 (TypeContainer::Emit): Emit the operators we have too.
18937 * expression.cs (Binary::Emit): Update to emit the appropriate code for
18938 the case when we have a user-defined operator.
18940 2001-09-17 Miguel de Icaza <miguel@ximian.com>
18942 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
18944 2001-09-16 Ravi Pratap <ravi@ximian.com>
18946 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
18947 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
18948 (Constructor::Emit): Implement.
18949 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
18950 if we have no work to do.
18951 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
18954 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
18955 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
18957 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
18960 2001-09-15 Ravi Pratap <ravi@ximian.com>
18962 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
18964 (Tree::RecordNamespace): Method to do what the name says ;-)
18965 (Tree::Namespaces): Property to get at the namespaces hashtable.
18967 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
18970 * rootcontext.cs (IsNamespace): Fixed it :-)
18972 2001-09-14 Miguel de Icaza <miguel@ximian.com>
18974 * class.cs (TypeContainer::FindMembers): Add support for
18976 (MethodCore): New class that encapsulates both the shared aspects
18977 of a Constructor and a Method.
18978 (Method, Constructor): Factored pieces into MethodCore.
18980 * driver.cs: Added --fatal which makes errors throw exceptions.
18981 Load System assembly as well as part of the standard library.
18983 * report.cs: Allow throwing exceptions on errors for debugging.
18985 * modifiers.cs: Do not use `parent', instead use the real type
18986 container to evaluate permission settings.
18988 * class.cs: Put Ravi's patch back in. He is right, and we will
18989 have to cope with the
18991 2001-09-14 Ravi Pratap <ravi@ximian.com>
18993 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
18994 FamORAssem, not FamANDAssem.
18996 2001-09-14 Miguel de Icaza <miguel@ximian.com>
18998 * driver.cs: Added --parse option that only parses its input files
19001 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
19002 incorrect. IsTopLevel is not used to tell whether an object is
19003 root_types or not (that can be achieved by testing this ==
19004 root_types). But to see if this is a top-level *class* (not
19005 necessarly our "toplevel" container).
19007 2001-09-14 Ravi Pratap <ravi@ximian.com>
19009 * enum.cs (Enum::Define): Modify to call the Lookup method on the
19010 parent instead of a direct call to GetType.
19012 2001-09-14 Ravi Pratap <ravi@ximian.com>
19014 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
19015 Modifiers.TypeAttr. This should just be a call to that method.
19017 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
19018 object so that we can determine if we are top-level or not.
19020 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
19023 * enum.cs (Enum::Define): Ditto.
19025 * modifiers.cs (FieldAttr): Re-write.
19027 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
19028 (TypeContainer::HaveStaticConstructor): New property to provide access
19029 to precisely that info.
19031 * modifiers.cs (MethodAttr): Re-write.
19032 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
19034 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
19035 of top-level types as claimed.
19037 2001-09-13 Miguel de Icaza <miguel@ximian.com>
19039 * expression.cs (MemberLookup): Fruitless attempt to lookup
19040 constructors. Maybe I need to emit default constructors? That
19041 might be it (currently .NET emits this for me automatically).
19042 (Invocation::OverloadResolve): Cope with Arguments == null.
19043 (Invocation::EmitArguments): new function, shared by the new
19044 constructor and us.
19045 (Invocation::Emit): Handle static and instance methods. Emit
19046 proper call instruction for virtual or non-virtual invocations.
19047 (New::Emit): Implement.
19048 (New::Resolve): Implement.
19049 (MemberAccess:Resolve): Implement.
19050 (MethodGroupExpr::InstanceExpression): used conforming to the spec
19051 to track instances.
19052 (FieldExpr::Resolve): Set type.
19054 * support.cs: Handle empty arguments.
19056 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
19057 SimpleLookup): Auxiliary routines to help parse a qualifier
19060 Update qualifier_identifier rule.
19062 * codegen.cs: Removed debugging messages.
19064 * class.cs: Make this a global thing, this acts just as a "key" to
19065 objects that we might have around.
19067 (Populate): Only initialize method_builders_to_methods once.
19069 * expression.cs (PropertyExpr): Initialize type from the
19072 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
19073 Resolve pattern. Attempt to implicitly convert value to boolean.
19076 * expression.cs: Set the type for the int32/int32 argument case.
19077 (Binary::ResolveOperator): Set the return type to boolean for
19078 comparission operators
19080 * typemanager.cs: Remove debugging print code.
19082 (Invocation::Resolve): resolve type.
19084 * class.cs: Allocate a MemberInfo of the correct size, as the code
19085 elsewhere depends on the test to reflect the correct contents.
19087 (Method::) Keep track of parameters, due to System.Reflection holes
19089 (TypeContainer::Populate): Keep track of MethodBuilders to Method
19092 (TypeContainer::FindMembers): Use ArrayList and then copy an array
19093 of the exact size and return that.
19095 (Class::LookupMethodByBuilder): New function that maps
19096 MethodBuilders to its methods. Required to locate the information
19097 on methods because System.Reflection bit us again.
19099 * support.cs: New file, contains an interface ParameterData and
19100 two implementations: ReflectionParameters and InternalParameters
19101 used to access Parameter information. We will need to grow this
19104 * expression.cs (Invocation::GetParameterData): implement a cache
19105 and a wrapper around the ParameterData creation for methods.
19106 (Invocation::OverloadResolve): Use new code.
19108 2001-09-13 Ravi Pratap <ravi@ximian.com>
19110 * class.cs (TypeContainer::EmitField): Remove and move into
19111 (Field::Define): here and modify accordingly.
19112 (Field.FieldBuilder): New member.
19113 (TypeContainer::Populate): Update accordingly.
19114 (TypeContainer::FindMembers): Implement.
19116 2001-09-13 Miguel de Icaza <miguel@ximian.com>
19118 * statement.cs: (VariableInfo::VariableType): New field to be
19119 initialized with the full type once it is resolved.
19121 2001-09-12 Miguel de Icaza <miguel@ximian.com>
19123 * parameter.cs (GetParameterInfo): Use a type cache to compute
19124 things only once, and to reuse this information
19126 * expression.cs (LocalVariableReference::Emit): Implement.
19127 (OpcodeCast::Emit): fix.
19129 (ParameterReference::Resolve): Implement.
19130 (ParameterReference::Emit): Implement.
19132 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
19133 that are expressions need to stay as Expressions.
19135 * typemanager.cs (CSharpName): Returns the C# name of a type if
19138 * expression.cs (Expression::ConvertImplicit): New function that
19139 implements implicit type conversions.
19141 (Expression::ImplicitReferenceConversion): Implements implicit
19142 reference conversions.
19144 (EmptyCast): New type for transparent casts.
19146 (OpcodeCast): New type for casts of types that are performed with
19147 a sequence of bytecodes.
19149 (BoxedCast): New type used for casting value types into reference
19150 types. Emits a box opcode.
19152 (Binary::DoNumericPromotions): Implements numeric promotions of
19153 and computation of the Binary::Type.
19155 (Binary::EmitBranchable): Optimization.
19157 (Binary::Emit): Implement code emission for expressions.
19159 * typemanager.cs (TypeManager): Added two new core types: sbyte
19162 2001-09-12 Ravi Pratap <ravi@ximian.com>
19164 * class.cs (TypeContainer::FindMembers): Method which does exactly
19165 what Type.FindMembers does, only we don't have to use reflection. No
19166 implementation yet.
19168 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
19169 typecontainer objects as we need to get at them.
19170 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
19172 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
19173 typecontainer object.
19175 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
19176 of just a Report object.
19178 2001-09-11 Ravi Pratap <ravi@ximian.com>
19180 * class.cs (Event::Define): Go back to using the prefixes "add_" and
19182 (TypeContainer::Populate): Now define the delegates of the type too.
19183 (TypeContainer.Delegates): Property to access the list of delegates defined
19186 * delegates.cs (Delegate::Define): Implement partially.
19188 * modifiers.cs (TypeAttr): Handle more flags.
19190 2001-09-11 Ravi Pratap <ravi@ximian.com>
19192 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
19194 (Operator::Define): Re-write logic to get types by using the LookupType method
19195 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
19196 (Indexer::Define): Ditto.
19197 (Event::Define): Ditto.
19198 (Property::Define): Ditto.
19200 2001-09-10 Ravi Pratap <ravi@ximian.com>
19202 * class.cs (TypeContainer::Populate): Now define operators too.
19203 (TypeContainer.Operators): New property to access the list of operators
19205 (Operator.OperatorMethodBuilder): New member to hold the method builder
19206 for the operator we are defining.
19207 (Operator::Define): Implement.
19209 2001-09-10 Ravi Pratap <ravi@ximian.com>
19211 * class.cs (Event::Define): Make the prefixes of the accessor methods
19212 addOn_ and removeOn_
19214 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
19215 of the location being passed in too. Ideally, this should go later since all
19216 error reporting should be done through the Report object.
19218 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
19219 (Populate): Iterate thru the indexers we have and define them too.
19220 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
19221 for the get and set accessors.
19222 (Indexer::Define): Implement.
19224 2001-09-09 Miguel de Icaza <miguel@ximian.com>
19226 * expression.cs (Binary::Resolve): Beginning of it. I scratched
19227 my previous implementation, did not work.
19229 * typemanager.cs: Add a couple of missing types (the longs).
19231 * literal.cs: Use TypeManager.bool_type instead of getting it.
19233 * expression.cs (EventExpr): New kind of expressions.
19234 (Expressio::ExprClassFromMemberInfo): finish
19236 2001-09-08 Miguel de Icaza <miguel@ximian.com>
19238 * assign.cs: Emit stores to static fields differently.
19240 2001-09-08 Ravi Pratap <ravi@ximian.com>
19242 * Merge in changes and adjust code to tackle conflicts. Backed out my
19243 code in Assign::Resolve ;-)
19245 2001-09-08 Ravi Pratap <ravi@ximian.com>
19247 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
19248 instead Report.Error and also pass in the location.
19249 (CSharpParser::Lexer): New readonly property to return the reference
19250 to the Tokenizer object.
19251 (declare_local_variables): Use Report.Error with location instead of plain
19255 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
19256 (Operator.CheckBinaryOperator): Ditto.
19258 * cs-parser.jay (operator_declarator): Update accordingly.
19260 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
19261 (CheckBinaryOperator): Same here.
19263 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
19264 on the name without any prefixes of namespace names etc. This is because we
19265 already might have something already fully qualified like
19266 'System.Console.WriteLine'
19268 * assign.cs (Resolve): Begin implementation. Stuck ;-)
19270 2001-09-07 Ravi Pratap <ravi@ximian.com>
19272 * cs-tokenizer.cs (location): Return a string which also contains
19275 * expression.cs (ElementAccess): New class for expressions of the
19276 type 'element access.'
19277 (BaseAccess): New class for expressions of the type 'base access.'
19278 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
19281 * cs-parser.jay (element_access): Implement action.
19282 (base_access): Implement actions.
19283 (checked_expression, unchecked_expression): Implement.
19285 * cs-parser.jay (local_variable_type): Correct and implement.
19286 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
19288 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
19290 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
19291 name and the specifiers.
19293 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
19295 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
19296 making them all public ;-)
19298 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
19301 2001-09-07 Miguel de Icaza <miguel@ximian.com>
19303 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
19305 (FieldExpr, PropertyExprs): New resolved expressions.
19306 (SimpleName::MemberStaticCheck): Perform static checks for access
19307 to non-static fields on static methods. Maybe this should be
19308 generalized for MemberAccesses.
19309 (SimpleName::ResolveSimpleName): More work on simple name
19312 * cs-parser.jay (primary_expression/qualified_identifier): track
19313 the parameter index.
19315 * codegen.cs (CodeGen::Save): Catch save exception, report error.
19316 (EmitContext::EmitBoolExpression): Chain to expression generation
19317 instead of temporary hack.
19318 (::EmitStatementExpression): Put generic expression code generation.
19320 * assign.cs (Assign::Emit): Implement variable assignments to
19321 local variables, parameters and fields.
19323 2001-09-06 Miguel de Icaza <miguel@ximian.com>
19325 * statement.cs (Block::GetVariableInfo): New method, returns the
19326 VariableInfo for a variable name in a block.
19327 (Block::GetVariableType): Implement in terms of GetVariableInfo
19329 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
19330 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
19332 2001-09-06 Ravi Pratap <ravi@ximian.com>
19334 * cs-parser.jay (operator_declaration): Continue on my quest : update
19335 to take attributes argument.
19336 (event_declaration): Ditto.
19337 (enum_declaration): Ditto.
19338 (indexer_declaration): Ditto.
19340 * class.cs (Operator::Operator): Update constructor accordingly.
19341 (Event::Event): Ditto.
19343 * delegate.cs (Delegate::Delegate): Same here.
19345 * enum.cs (Enum::Enum): Same here.
19347 2001-09-05 Ravi Pratap <ravi@ximian.com>
19349 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
19351 * ../tests/cs0658.cs : New file to demonstrate error 0658.
19353 * attribute.cs (Attributes): New class to encapsulate all attributes which were
19354 being passed around as an arraylist.
19355 (Attributes::AddAttribute): Method to add attribute sections.
19357 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
19358 (struct_declaration): Update accordingly.
19359 (constant_declaration): Update.
19360 (field_declaration): Update.
19361 (method_header): Update.
19362 (fixed_parameter): Update.
19363 (parameter_array): Ditto.
19364 (property_declaration): Ditto.
19365 (destructor_declaration): Ditto.
19367 * class.cs (Struct::Struct): Update constructors accordingly.
19368 (Class::Class): Ditto.
19369 (Field::Field): Ditto.
19370 (Method::Method): Ditto.
19371 (Property::Property): Ditto.
19372 (TypeContainer::OptAttribute): update property's return type.
19374 * interface.cs (Interface.opt_attributes): New member.
19375 (Interface::Interface): Update to take the extra Attributes argument.
19377 * parameter.cs (Parameter::Parameter): Ditto.
19379 * constant.cs (Constant::Constant): Ditto.
19381 * interface.cs (InterfaceMemberBase): New OptAttributes field.
19382 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
19383 the attributes as a parameter.
19384 (InterfaceProperty): Update constructor call.
19385 (InterfaceEvent): Ditto.
19386 (InterfaceMethod): Ditto.
19387 (InterfaceIndexer): Ditto.
19389 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
19390 pass the attributes too.
19391 (interface_event_declaration): Ditto.
19392 (interface_property_declaration): Ditto.
19393 (interface_method_declaration): Ditto.
19394 (interface_declaration): Ditto.
19396 2001-09-05 Miguel de Icaza <miguel@ximian.com>
19398 * class.cs (Method::Define): Track the "static Main" definition to
19399 create an entry point.
19401 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
19402 EntryPoint if we find it.
19404 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
19405 (EmitContext::ig): Make this variable public.
19407 * driver.cs: Make the default output file be the first file name
19408 with the .exe extension.
19410 Detect empty compilations
19412 Handle various kinds of output targets. Handle --target and
19413 rename -t to --dumper.
19415 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
19416 methods inherited from Expression return now an Expression. This
19417 will is used during the tree rewriting as we resolve them during
19420 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
19421 the spec. Missing entirely is the information about
19422 accessability of elements of it.
19424 (Expression::ExprClassFromMemberInfo): New constructor for
19425 Expressions that creates a fully initialized Expression based on
19426 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
19429 (Invocation::Resolve): Begin implementing resolution of invocations.
19431 * literal.cs (StringLiteral): Implement Emit.
19433 2001-09-05 Ravi Pratap <ravi@ximian.com>
19435 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
19438 2001-09-04 Ravi Pratap <ravi@ximian.com>
19440 * cs-parser.jay (attribute_arguments): Implement actions.
19441 (attribute): Fix bug in production. Implement action.
19442 (attribute_list): Implement.
19443 (attribute_target): Implement.
19444 (attribute_target_specifier, opt_target_specifier): Implement
19445 (CheckAttributeTarget): New method to check if the attribute target
19447 (attribute_section): Implement.
19448 (opt_attributes): Implement.
19450 * attribute.cs : New file to handle attributes.
19451 (Attribute): Class to hold attribute info.
19453 * cs-parser.jay (opt_attribute_target_specifier): Remove production
19454 (attribute_section): Modify production to use 2 different rules to
19455 achieve the same thing. 1 s/r conflict down !
19456 Clean out commented, useless, non-reducing dimension_separator rules.
19458 * class.cs (TypeContainer.attributes): New member to hold list
19459 of attributes for a type.
19460 (Struct::Struct): Modify to take one more argument, the attribute list.
19461 (Class::Class): Ditto.
19462 (Field::Field): Ditto.
19463 (Method::Method): Ditto.
19464 (Property::Property): Ditto.
19466 * cs-parser.jay (struct_declaration): Update constructor call to
19467 pass in the attributes too.
19468 (class_declaration): Ditto.
19469 (constant_declaration): Ditto.
19470 (field_declaration): Ditto.
19471 (method_header): Ditto.
19472 (fixed_parameter): Ditto.
19473 (parameter_array): Ditto.
19474 (property_declaration): Ditto.
19476 * constant.cs (Constant::Constant): Update constructor similarly.
19477 Use System.Collections.
19479 * parameter.cs (Parameter::Parameter): Update as above.
19481 2001-09-02 Ravi Pratap <ravi@ximian.com>
19483 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
19484 (TypeContainer.delegates): New member to hold list of delegates.
19486 * cs-parser.jay (delegate_declaration): Implement the action correctly
19487 this time as I seem to be on crack ;-)
19489 2001-09-02 Miguel de Icaza <miguel@ximian.com>
19491 * rootcontext.cs (RootContext::IsNamespace): new function, used to
19492 tell whether an identifier represents a namespace.
19494 * expression.cs (NamespaceExpr): A namespace expression, used only
19495 temporarly during expression resolution.
19496 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
19497 utility functions to resolve names on expressions.
19499 2001-09-01 Miguel de Icaza <miguel@ximian.com>
19501 * codegen.cs: Add hook for StatementExpressions.
19503 * class.cs: Fix inverted test for static flag in methods.
19505 2001-09-02 Ravi Pratap <ravi@ximian.com>
19507 * class.cs (Operator::CheckUnaryOperator): Correct error number used
19508 to make it coincide with MS' number.
19509 (Operator::CheckBinaryOperator): Ditto.
19511 * ../errors/errors.txt : Remove error numbers added earlier.
19513 * ../errors/cs1019.cs : Test case for error # 1019
19515 * ../errros/cs1020.cs : Test case for error # 1020
19517 * cs-parser.jay : Clean out commented cruft.
19518 (dimension_separators, dimension_separator): Comment out. Ostensibly not
19519 used anywhere - non-reducing rule.
19520 (namespace_declarations): Non-reducing rule - comment out.
19522 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
19523 with TypeContainer::AddEnum.
19525 * delegate.cs : New file for delegate handling classes.
19526 (Delegate): Class for declaring delegates.
19528 * makefile : Update.
19530 * cs-parser.jay (delegate_declaration): Implement.
19532 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
19534 * class.cs (Event::Define): Implement.
19535 (Event.EventBuilder): New member.
19537 * class.cs (TypeContainer::Populate): Update to define all enums and events
19539 (Events): New property for the events arraylist we hold. Shouldn't we move to using
19540 readonly fields for all these cases ?
19542 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
19544 * class.cs (Property): Revamp to use the convention of making fields readonly.
19545 Accordingly modify code elsewhere.
19547 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
19548 the Define method of the Property class.
19550 * class.cs : Clean up applied patch and update references to variables etc. Fix
19552 (TypeContainer::Populate): Update to define all the properties we have. Also
19553 define all enumerations.
19555 * enum.cs (Define): Implement.
19557 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
19559 * cs-parser.jay (overloadable_operator): The semantic value is an
19560 enum of the Operator class.
19561 (operator_declarator): Implement actions.
19562 (operator_declaration): Implement.
19564 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
19565 validity of definitions.
19566 (Operator::CheckBinaryOperator): Static method to check for binary operators
19567 (TypeContainer::AddOperator): New method to add an operator to a type.
19569 * cs-parser.jay (indexer_declaration): Added line to actually call the
19570 AddIndexer method so it gets added ;-)
19572 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
19573 already taken care of by the MS compiler ?
19575 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
19577 * class.cs (Operator): New class for operator declarations.
19578 (Operator::OpType): Enum for the various operators.
19580 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
19582 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
19583 ostensibly handle this in semantic analysis.
19585 * cs-parser.jay (general_catch_clause): Comment out
19586 (specific_catch_clauses, specific_catch_clause): Ditto.
19587 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
19588 (catch_args, opt_catch_args): New productions.
19589 (catch_clause): Rewrite to use the new productions above
19590 (catch_clauses): Modify accordingly.
19591 (opt_catch_clauses): New production to use in try_statement
19592 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
19593 and re-write the code in the actions to extract the specific and
19594 general catch clauses by being a little smart ;-)
19596 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
19597 Hooray, try and catch statements parse fine !
19599 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
19601 * statement.cs (Block::GetVariableType): Fix logic to extract the type
19602 string from the hashtable of variables.
19604 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
19605 I end up making that mistake ;-)
19606 (catch_clauses): Fixed gross error which made Key and Value of the
19607 DictionaryEntry the same : $1 !!
19609 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
19611 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
19613 * cs-parser.jay (event_declaration): Correct to remove the semicolon
19614 when the add and remove accessors are specified.
19616 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
19618 * cs-parser.jay (IndexerDeclaration): New helper class to hold
19619 information about indexer_declarator.
19620 (indexer_declarator): Implement actions.
19621 (parsing_indexer): New local boolean used to keep track of whether
19622 we are parsing indexers or properties. This is necessary because
19623 implicit_parameters come into picture even for the get accessor in the
19624 case of an indexer.
19625 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
19627 * class.cs (Indexer): New class for indexer declarations.
19628 (TypeContainer::AddIndexer): New method to add an indexer to a type.
19629 (TypeContainer::indexers): New member to hold list of indexers for the
19632 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
19634 * cs-parser.jay (add_accessor_declaration): Implement action.
19635 (remove_accessor_declaration): Implement action.
19636 (event_accessors_declaration): Implement
19637 (variable_declarators): swap statements for first rule - trivial.
19639 * class.cs (Event): New class to hold information about event
19641 (TypeContainer::AddEvent): New method to add an event to a type
19642 (TypeContainer::events): New member to hold list of events.
19644 * cs-parser.jay (event_declaration): Implement actions.
19646 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
19648 * cs-parser.jay (dim_separators): Implement. Make it a string
19649 concatenating all the commas together, just as they appear.
19650 (opt_dim_separators): Modify accordingly
19651 (rank_specifiers): Update accordingly. Basically do the same
19652 thing - instead, collect the brackets here.
19653 (opt_rank_sepcifiers): Modify accordingly.
19654 (array_type): Modify to actually return the complete type string
19655 instead of ignoring the rank_specifiers.
19656 (expression_list): Implement to collect the expressions
19657 (variable_initializer): Implement. We make it a list of expressions
19658 essentially so that we can handle the array_initializer case neatly too.
19659 (variable_initializer_list): Implement.
19660 (array_initializer): Make it a list of variable_initializers
19661 (opt_array_initializer): Modify accordingly.
19663 * expression.cs (New::NType): Add enumeration to help us
19664 keep track of whether we have an object/delegate creation
19665 or an array creation.
19666 (New:NewType, New::Rank, New::Indices, New::Initializers): New
19667 members to hold data about array creation.
19668 (New:New): Modify to update NewType
19669 (New:New): New Overloaded contructor for the array creation
19672 * cs-parser.jay (array_creation_expression): Implement to call
19673 the overloaded New constructor.
19675 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
19677 * class.cs (TypeContainer::Constructors): Return member
19678 constructors instead of returning null.
19680 2001-08-26 Miguel de Icaza <miguel@ximian.com>
19682 * typemanager.cs (InitCoreTypes): Initialize the various core
19683 types after we have populated the type manager with the user
19684 defined types (this distinction will be important later while
19685 compiling corlib.dll)
19687 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
19688 on Expression Classification. Now all expressions have a method
19689 `Resolve' and a method `Emit'.
19691 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
19692 generation from working. Also add some temporary debugging
19695 2001-08-24 Miguel de Icaza <miguel@ximian.com>
19697 * codegen.cs: Lots of code generation pieces. This is only the
19698 beginning, will continue tomorrow with more touches of polish. We
19699 handle the fundamentals of if, while, do, for, return. Others are
19700 trickier and I need to start working on invocations soon.
19702 * gen-treedump.cs: Bug fix, use s.Increment here instead of
19705 * codegen.cs (EmitContext): New struct, used during code
19706 emission to keep a context. Most of the code generation will be
19709 * cs-parser.jay: Add embedded blocks to the list of statements of
19710 this block. So code generation proceeds in a top down fashion.
19712 2001-08-23 Miguel de Icaza <miguel@ximian.com>
19714 * statement.cs: Add support for multiple child blocks.
19716 2001-08-22 Miguel de Icaza <miguel@ximian.com>
19718 * codegen.cs (EmitCode): New function, will emit the code for a
19719 Block of code given a TypeContainer and its ILGenerator.
19721 * statement.cs (Block): Standard public readonly optimization.
19722 (Block::Block constructors): Link children.
19723 (Block::Child): Child Linker.
19724 (Block::EmitVariables): Emits IL variable declarations.
19726 * class.cs: Drop support for MethodGroups here, delay until
19728 (Method::): Applied the same simplification that I did before, and
19729 move from Properties to public readonly fields.
19730 (Method::ParameterTypes): Returns the parameter types for the
19731 function, and implements a cache that will be useful later when I
19732 do error checking and the semantic analysis on the methods is
19734 (Constructor::GetCallingConvention): Renamed from CallingConvetion
19735 and made a method, optional argument tells whether this is a class
19736 or a structure to apply the `has-this' bit.
19737 (Method::GetCallingConvention): Implement, returns the calling
19739 (Method::Define): Defines the type, a second pass is performed
19740 later to populate the methods.
19742 (Constructor::ParameterTypes): implement a cache similar to the
19743 one on Method::ParameterTypes, useful later when we do semantic
19746 (TypeContainer::EmitMethod): New method. Emits methods.
19748 * expression.cs: Removed MethodGroup class from here.
19750 * parameter.cs (Parameters::GetCallingConvention): new method.
19752 2001-08-21 Miguel de Icaza <miguel@ximian.com>
19754 * class.cs (TypeContainer::Populate): Drop RootContext from the
19757 (Constructor::CallingConvention): Returns the calling convention.
19758 (Constructor::ParameterTypes): Returns the constructor parameter
19761 (TypeContainer::AddConstructor): Keep track of default constructor
19762 and the default static constructor.
19764 (Constructor::) Another class that starts using `public readonly'
19765 instead of properties.
19767 (Constructor::IsDefault): Whether this is a default constructor.
19769 (Field::) use readonly public fields instead of properties also.
19771 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
19772 track of static constructors; If none is used, turn on
19773 BeforeFieldInit in the TypeAttributes.
19775 * cs-parser.jay (opt_argument_list): now the return can be null
19776 for the cases where there are no arguments.
19778 (constructor_declarator): If there is no implicit `base' or
19779 `this', then invoke the default parent constructor.
19781 * modifiers.cs (MethodAttr): New static function maps a set of
19782 modifiers flags into a MethodAttributes enum
19783 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
19784 MethodAttr, TypeAttr to represent the various mappings where the
19785 modifiers are used.
19786 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
19788 2001-08-19 Miguel de Icaza <miguel@ximian.com>
19790 * parameter.cs (GetParameterInfo): Fix bug where there would be no
19793 * interface.cs (PopulateIndexer): Implemented the code generator
19794 for interface indexers.
19796 2001-08-17 Miguel de Icaza <miguel@ximian.com>
19798 * interface.cs (InterfaceMemberBase): Now we track the new status
19801 (PopulateProperty): Implement property population. Woohoo! Got
19802 Methods and Properties going today.
19804 Removed all the properties for interfaces, and replaced them with
19805 `public readonly' fields.
19807 2001-08-16 Miguel de Icaza <miguel@ximian.com>
19809 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
19810 initialize their hashtables/arraylists only when they are needed
19811 instead of doing this always.
19813 * parameter.cs: Handle refs and out parameters.
19815 * cs-parser.jay: Use an ArrayList to construct the arguments
19816 instead of the ParameterCollection, and then cast that to a
19819 * parameter.cs: Drop the use of ParameterCollection and use
19820 instead arrays of Parameters.
19822 (GetParameterInfo): Use the Type, not the Name when resolving
19825 2001-08-13 Miguel de Icaza <miguel@ximian.com>
19827 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
19828 and instead use public readonly fields.
19830 * class.cs: Put back walking code for type containers.
19832 2001-08-11 Miguel de Icaza <miguel@ximian.com>
19834 * class.cs (MakeConstant): Code to define constants.
19836 * rootcontext.cs (LookupType): New function. Used to locate types
19839 2001-08-08 Miguel de Icaza <miguel@ximian.com>
19841 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
19842 this System.Reflection code is. Kudos to Microsoft
19844 * typemanager.cs: Implement a type cache and avoid loading all
19845 types at boot time. Wrap in LookupType the internals. This made
19846 the compiler so much faster. Wow. I rule!
19848 * driver.cs: Make sure we always load mscorlib first (for
19849 debugging purposes, nothing really important).
19851 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
19852 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
19854 * rootcontext.cs: Lookup types on their namespace; Lookup types
19855 on namespaces that have been imported using the `using' keyword.
19857 * class.cs (TypeContainer::TypeAttr): Virtualize.
19858 (Class::TypeAttr): Return attributes suitable for this bad boy.
19859 (Struct::TypeAttr): ditto.
19860 Handle nested classes.
19861 (TypeContainer::) Remove all the type visiting code, it is now
19862 replaced with the rootcontext.cs code
19864 * rootcontext.cs (GetClassBases): Added support for structs.
19866 2001-08-06 Miguel de Icaza <miguel@ximian.com>
19868 * interface.cs, statement.cs, class.cs, parameter.cs,
19869 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
19870 Drop use of TypeRefs, and use strings instead.
19872 2001-08-04 Miguel de Icaza <miguel@ximian.com>
19876 * class.cs (Struct::Struct): set the SEALED flags after
19877 checking the modifiers.
19878 (TypeContainer::TypeAttr): new property, returns the
19879 TypeAttributes for a class.
19881 * cs-parser.jay (type_list): Oops, list production was creating a
19882 new list of base types.
19884 * rootcontext.cs (StdLib): New property.
19885 (GetInterfaceTypeByName): returns an interface by type name, and
19886 encapsulates error handling here.
19887 (GetInterfaces): simplified.
19888 (ResolveTree): Encapsulated all the tree resolution here.
19889 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
19892 * driver.cs: Add support for --nostdlib, to avoid loading the
19893 default assemblies.
19894 (Main): Do not put tree resolution here.
19896 * rootcontext.cs: Beginning of the class resolution.
19898 2001-08-03 Miguel de Icaza <miguel@ximian.com>
19900 * rootcontext.cs: Provide better error reporting.
19902 * cs-parser.jay (interface_base): set our $$ to be interfaces.
19904 * rootcontext.cs (CreateInterface): Handle the case where there
19905 are no parent interfaces.
19907 (CloseTypes): Routine to flush types at the end.
19908 (CreateInterface): Track types.
19909 (GetInterfaces): Returns an array of Types from the list of
19910 defined interfaces.
19912 * typemanager.c (AddUserType): Mechanism to track user types (puts
19913 the type on the global type hash, and allows us to close it at the
19916 2001-08-02 Miguel de Icaza <miguel@ximian.com>
19918 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
19919 RecordInterface instead.
19921 * cs-parser.jay: Updated to reflect changes above.
19923 * decl.cs (Definition): Keep track of the TypeBuilder type that
19924 represents this type here. Not sure we will use it in the long
19925 run, but wont hurt for now.
19927 * driver.cs: Smaller changes to accomodate the new code.
19929 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
19932 * rootcontext.cs (CreateInterface): New method, used to create
19933 the System.TypeBuilder type for interfaces.
19934 (ResolveInterfaces): new entry point to resolve the interface
19936 (CodeGen): Property, used to keep track of the code generator.
19938 2001-07-26 Miguel de Icaza <miguel@ximian.com>
19940 * cs-parser.jay: Add a second production for delegate_declaration
19943 (enum_body): Put an opt_comma here instead of putting it on
19944 enum_body or enum_member_declarations so we can handle trailing
19945 commas on enumeration members. Gets rid of a shift/reduce.
19947 (type_list): Need a COMMA in the middle.
19949 (indexer_declaration): Tell tokenizer to recognize get/set
19951 * Remove old targets.
19953 * Re-add the parser target.
19955 2001-07-13 Simon Cozens <simon@simon-cozens.org>
19957 * cs-parser.jay: Add precendence rules for a number of operators
19958 ot reduce the number of shift/reduce conflicts in the grammar.
19960 2001-07-17 Miguel de Icaza <miguel@ximian.com>
19962 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
19965 Get rid of old crufty code.
19967 * rootcontext.cs: Use this to keep track of the parsed
19968 representation and the defined types available to the program.
19970 * gen-treedump.cs: adjust for new convention.
19972 * type.cs: Split out the type manager, and the assembly builder
19975 * typemanager.cs: the type manager will live here now.
19977 * cil-codegen.cs: And the code generator here.
19979 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
19981 * makefile: Fixed up for easy making.
19983 2001-07-13 Simon Cozens <simon@simon-cozens.org>
19985 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
19988 (unary_expression): Expand pre_increment_expression and
19989 post_decrement_expression to reduce a shift/reduce.
19991 2001-07-11 Simon Cozens
19993 * cs-tokenizer.cs: Hex numbers should begin with a 0.
19995 Improve allow_keyword_as_indent name.
19997 2001-06-19 Miguel de Icaza <miguel@ximian.com>
19999 * Adjustments for Beta2.
20001 2001-06-13 Miguel de Icaza <miguel@ximian.com>
20003 * decl.cs: Added `Define' abstract method.
20004 (InTransit): new property, used to catch recursive definitions.
20006 * interface.cs: Implement `Define'.
20008 * modifiers.cs: Map Modifiers.constants to
20009 System.Reflection.TypeAttribute flags.
20011 * class.cs: Keep track of types and user-defined types.
20012 (BuilderInit): New method for creating an assembly
20013 (ResolveType): New function to launch the resolution process, only
20014 used by interfaces for now.
20016 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
20017 that are inserted into the name space.
20019 2001-06-08 Miguel de Icaza <miguel@ximian.com>
20021 * ARGH. I have screwed up my tree so many times due to the use of
20022 rsync rather than using CVS. Going to fix this at once.
20024 * driver.cs: Objetify driver. Load assemblies, use assemblies to
20027 2001-06-07 Miguel de Icaza <miguel@ximian.com>
20029 * Experiment successful: Use System.Type rather that our own
20032 2001-05-25 Miguel de Icaza <miguel@ximian.com>
20034 * cs-parser.jay: Removed nsAliases from here.
20036 Use new namespaces, handle `using XXX;'
20038 * namespace.cs: Reimplemented namespace handling, use a recursive
20039 definition of the class. Now we can keep track of using clauses
20040 and catch invalid using clauses.
20042 2001-05-24 Miguel de Icaza <miguel@ximian.com>
20044 * gen-treedump.cs: Adapted for all the renaming.
20046 * expression.cs (Expression): this class now has a Type property
20047 which returns an expression Type.
20049 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
20050 `Type', as this has a different meaning now in the base
20052 2001-05-22 Miguel de Icaza <miguel@ximian.com>
20054 * interface.cs, class.cs: Removed from all the sources the
20055 references to signature computation, as we can not do method
20056 signature computation during the parsing time, as we are not
20057 trying to solve at that point distinguishing:
20061 void a (NS.Blah x) {}
20064 Which depending on the context might be valid or not, as we do not
20065 know if Blah is the same thing as NS.Blah at that point.
20067 * Redid everything so the code uses TypeRefs now instead of
20068 Types. TypeRefs are just temporary type placeholders, that need
20069 to be resolved. They initially have a pointer to a string and the
20070 current scope in which they are used. This is used later by the
20071 compiler to resolve the reference to an actual Type.
20073 * DeclSpace is no longer a CIR.Type, and neither are
20074 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
20075 are all DeclSpaces, but no Types.
20077 * type.cs (TypeRefManager): This implements the TypeRef manager,
20078 which keeps track of all the types that need to be resolved after
20079 the parsing has finished.
20081 2001-05-13 Miguel de Icaza <miguel@ximian.com>
20083 * ARGH. We are going to have to store `foreach' as a class rather
20084 than resolving it, as we need to verify error 1579 after name
20085 resolution. *OR* we could keep a flag that says `This request to
20086 IEnumerator comes from a foreach statement' which we can then use
20087 to generate the error.
20089 2001-05-10 Miguel de Icaza <miguel@ximian.com>
20091 * class.cs (TypeContainer.AddMethod): we now add methods to the
20092 MethodGroup instead of the method hashtable.
20094 * expression.cs: Add MethodGroup abstraction, which gets us one
20095 step closer to the specification in the way we handle method
20098 * cs-parser.jay (primary_expression): qualified_identifier now
20099 tried to match up an identifier to a local variable reference or
20100 to a parameter reference.
20102 current_local_parameters is now a parser global variable that
20103 points to the current parameters for the block, used during name
20106 (property_declaration): Now creates an implicit `value' argument to
20109 2001-05-09 Miguel de Icaza <miguel@ximian.com>
20111 * parameter.cs: Do not use `param' arguments as part of the
20112 signature, per the spec.
20114 2001-05-08 Miguel de Icaza <miguel@ximian.com>
20116 * decl.cs: Base class for classes, structs and interfaces. This
20117 is the "Declaration Space"
20119 * cs-parser.jay: Use CheckDef for checking declaration errors
20120 instead of having one on each function.
20122 * class.cs: Factor out some code for handling error handling in
20123 accordance to the "Declarations" section in the "Basic Concepts"
20124 chapter in the ECMA C# spec.
20126 * interface.cs: Make all interface member classes derive from
20127 InterfaceMemberBase.
20129 2001-05-07 Miguel de Icaza <miguel@ximian.com>
20131 * Many things: all interfaces are parsed and generated in
20132 gen-treedump. Support for member variables, constructors,
20133 destructors, properties, constants is there.
20135 Beginning of the IL backend, but very little done, just there for
20138 2001-04-29 Miguel de Icaza <miguel@ximian.com>
20140 * cs-parser.jay: Fix labeled statement.
20142 * cs-tokenizer.cs (escape): Escape " and ' always.
20143 ref_line, ref_name: keep track of the line/filename as instructed
20144 by #line by the compiler.
20147 2001-04-27 Miguel de Icaza <miguel@ximian.com>
20149 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
20150 to match the values in System.CodeDOM.
20152 Divid renamed to Divide.
20154 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
20156 (Statements.set): remove.
20158 * System.CodeDOM/CodeCatchClause.cs: always have a valid
20161 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
20162 falseStatements always have valid values.
20164 * cs-parser.jay: Use System.CodeDOM now.