1 2005-02-28 Marek Safar <marek.safar@seznam.cz>
3 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
4 in the fields and not in the properties.
6 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
8 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
11 2005-02-28 Marek Safar <marek.safar@seznam.cz>
13 * attribute.cs: Small refactoring (improved robustness).
14 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
15 (ValidateGuid): Removed.
16 (Resolve): Removed referenced to above mentioned.
17 (GetAttributeUsage): Made private and changed to work without
19 (GetIndexerAttributeValue): Don't crash.
20 (GetConditionalAttributeValue): Ditto.
21 (GetClsCompliantAttributeValue): Ditto.
22 (ExtractSecurityPermissionSet): All attributes exceptions are
24 (GetPropertyValue): New helper.
25 (GetMethodImplOptions): New method.
26 (DefinePInvokeMethod): Reuse common code. Implemented handling of
27 some missing properties.
29 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
30 (Method.ApplyAttributeBuilder): Updated.
32 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
35 2005-02-28 Raja R Harinath <rharinath@novell.com>
38 * report.cs (Report.SymbolRelatedToPreviousError): Handle
39 non-simple types (array, pointer, reference).
41 2005-02-28 Marek Safar <marek.safar@seznam.cz>
43 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
45 * class.cs (MethodCore.IsDuplicateImplementation): Special error
47 (Method.CheckBase): Catch wrong destructor here.
48 (MethodData.Define): Add errors 550, 668.
50 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
52 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
54 * pending.cs (VerifyPendingMethods): Add error 551.
56 * typemanager.cs (CSharpName): Next error report helper.
58 2005-02-25 Marek Safar <marek.safar@seznam.cz>
60 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
61 attributes. Removed useless attribute double check.
62 It saves almost 2MBs for corlib.
64 2005-02-25 Raja R Harinath <rharinath@novell.com>
67 * statement.cs (ExpressionStatement.Resolve): Make robust to being
68 called twice in case of error.
70 2005-02-23 Chris Toshok <toshok@ximian.com>
72 Fix compiler portions of #72827.
73 * statement.cs (Block.Emit): call Begin/EndScope on the
74 EmitContext instead of the ILGenerator.
76 * codegen.cs (EmitContext.BeginScope): new method, call
77 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
79 (EmitContext.BeginScope): same, but EndScope and CloseScope
81 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
82 offset and call the superclass's OpenScope(int) with it.
83 (SymbolWriter.CloseScope): get the current il
84 offset and call superclass's CloseScope(int) with it.
86 2005-02-23 Marek Safar <marek.safar@seznam.cz>
88 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
89 CS1677 for out and ref as well.
91 * class.cs (Method.Define): Add error CS1599 detection.
93 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
95 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
97 * delegate.cs (Delegate.Define): Add error CS1599 detection.
99 * support.cs.cs (ModifierDesc): New helper method.
101 2005-02-23 Raja R Harinath <rharinath@novell.com>
102 Abin Thomas <projectmonokochi@rediffmail.com>
103 Anoob V E <projectmonokochi@rediffmail.com>
104 Harilal P R <projectmonokochi@rediffmail.com>
107 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
108 MemberLookup (used for error reporting) actually returns a result.
109 Fix error report number (122, not 112).
111 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
112 Anoob V E <projectmonokochi@rediffmail.com>
113 Harilal P R <projectmonokochi@rediffmail.com>
116 * pending.cs (PendingImplementation.GetAbstractMethods):
117 Find NonPublic members too.
119 2005-02-22 Marek Safar <marek.safar@seznam.cz>
121 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
124 * class.cs (MethodCore.CheckMethodAgainstBase):
125 Add error 239 report.
127 2005-02-21 Marek Safar <marek.safar@seznam.cz>
129 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
131 * class.cs (Operator.Define): Add error 217 report.
133 2005-02-21 Raja R Harinath <rharinath@novell.com>
136 * expression.cs (Invocation.IsApplicable): Make public.
137 (Invocation.IsParamsMethodApplicable): Likewise.
138 * delegate.cs (Delegate.VerifyApplicability): Don't use
139 Invocation.VerifyArgumentCompat for parameter applicability
140 testing. Use Invocation.IsApplicable and
141 Invocation.IsParamsMethodApplicable.
143 2005-02-21 Marek Safar <marek.safar@seznam.cz>
145 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
147 * class.cs (Operator.Define): Add error 217 report.
149 2005-02-21 Raja R Harinath <rharinath@novell.com>
151 * namespace.cs (UsingEntry.Resolve): Undo change below.
153 2005-02-21 Raja R Harinath <rharinath@novell.com>
156 * ecore.cs (Expression.MemberLookupFailed): Add argument to
157 disable the error message when the extended MemberLookup also
159 (Expression.MemberLookupFinal): Update.
160 (SimpleName.DoSimpleNameResolve): Update.
161 * expression.cs (MemberAccess.ResolveNamespaceOrType):
162 Don't use MemberLookupFinal.
163 (New.DoResolve): Update.
164 (BaseAccess.CommonResolve): Update.
166 2005-02-21 Raja R Harinath <rharinath@novell.com>
169 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
170 occured previously, don't resolve again.
172 2005-02-21 Marek Safar <marek.safar@seznam.cz>
175 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
176 argument. Call ResolveAttributeUsage for unresolved.
177 when types doesn't match ctor arguments.
179 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
180 for nested attribute classes.
181 (Class.attribute_usage): Removed.
182 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
185 * ecore.cs (IsAttribute): Removed.
187 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
189 * rootcontext.cs (RegisterAttribute): Removed, attributes are
191 (attribute_types): Removed.
192 (EmitCode): Global attributes are emited as the latest.
194 2005-02-18 Marek Safar <marek.safar@seznam.cz>
196 * class.cs (EmitFieldInitializers): Don't emit field initializer
197 for default values when optimilization is on.
199 * constant.cs (Constant.IsDefaultValue): New property.
201 * driver.cs: Add /optimize handling.
205 * literal.cs: Implement new IsDefaultValue property.
207 * rootcontext.cs (Optimize): New field, holds /optimize option.
209 2005-02-18 Raja R Harinath <rharinath@novell.com>
211 Fix crasher in re-opened #72347.
212 * namespace.cs (Namespace.Lookup): Return null if
213 DeclSpace.DefineType returns null.
216 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
218 2005-02-18 Raja R Harinath <rharinath@novell.com>
220 Fix remainder of #63202. Change semantics of DoResolveLValue: it
221 now returns null if it cannot resolve to an lvalue.
222 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
223 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
224 returned null. Remove check for SimpleName.
225 (EventExpr.DoResolveLValue): New.
226 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
227 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
229 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
231 (Unary.ResolveOperator): Move CS0211 check ...
232 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
234 (Unary.DoResolveLValue): Simplify.
235 (AddressOf.DoResolveLValue): New.
236 (ArrayAccess.DoResolveLValue): New.
238 2005-02-16 Marek Safar <marek.safar@seznam.cz>
240 * attribute.cs (Attribute.Resolve): Add arguments casting for
241 when types doesn't match ctor arguments.
243 2005-02-16 Raja R Harinath <rharinath@novell.com>
246 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
247 lookup of operator in base type. Ensure that all checks happen
248 when the operator resolves to an "op_..." method.
250 2005-02-15 Raja R Harinath <rharinath@novell.com>
253 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
254 'ignore_cs0104' parameter. Pass it to ...
255 (NamespaceEntry.Lookup): ... this.
256 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
257 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
258 (TypeLookupExpression.DoResolveAsTypeStep): Update.
259 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
260 Update. Request that cs0104 errors be ignored.
261 (ComposedCast.ResolveAsTypeStep): Update.
263 2005-02-14 Raja R Harinath <rharinath@novell.com>
266 * expression.cs (Invocation.BetterFunction): Remove support for
267 comparing virtual functions and their overrides.
268 (Invocation.IsOverride): New.
269 (Invocation.OverloadResolve): Don't consider 'override' functions
270 during candidate selection. Store them in a lookaside list.
271 If the selected method is a 'virtual' function, use the list to
272 find any overrides that are closer to the LHS type.
274 2005-02-14 Marek Safar <marek.safar@seznam.cz>
276 * expression.cs (New.DoResolve): Add complex core type reduction.
277 (New.Constantify): Converts complex core type syntax like 'new int ()'
280 2005-02-14 Raja R Harinath <rharinath@novell.com>
282 * decl.cs (EntryType.EntryType): New constructor to create an
283 updated copy of a cache entry.
284 (MemberCache.AddMethods): Use it.
285 (MemberCache.ClearDeclaredOnly): Remove.
286 (MemberCache.MemberCache): Update.
288 2005-02-11 Miguel de Icaza <miguel@novell.com>
290 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
291 variable. This one is represents the actual low-level declaration
292 of the method, as opposed to the semantic level `IsStatic'.
294 An anonymous method which is hosted into a static method might be
295 actually an instance method. IsStatic would reflect the
296 container, while MethodIsStatic represents the actual code
299 * expression.cs (ParameterReference): Use the new MethodIsStatic
302 * anonymous.cs (AnonymousMethod.Compatible): Pass the
303 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
304 set on the current EmitContext.
306 * expression.cs (Cast): Overload DoResolveLValue so we can pass
307 resolve our casted expression as an LValue. This triggers the
308 proper LValue processing that is later required by Assign.
312 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
314 2005-02-11 Marek Safar <marek.safar@seznam.cz>
316 C# 2.0 Fixed buffer implementation
318 * anonymous.cs: Update after RegisterHelperClass renaming.
320 * attribute.cs (AttributeTester.fixed_buffer_cache):
321 Cache of external fixed buffers.
322 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
323 implementation if field is fixed buffer else null.
326 (TypeContainer.AddField): Accept FieldMember instead of Field.
327 (FieldBase.IsFieldClsCompliant): Extracted code from
328 VerifyClsCompliance descendant customization.
329 (FixedField): New class handles fixed buffer fields.
330 (FixedFieldExternal): Keeps information about imported fixed
332 (IFixedField): Make access to internal or external fixed buffer
335 * cs-parser.jay: Add fixed buffer parsing.
337 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
340 * expression.cs (Indirection): Extended implementation to accept
342 (PointerArithmetic.Emit): Get element from fixed buffer as well.
343 (ElementAccess.MakePointerAccess): Get type as parameter.
344 (DoResolve): Add fixed buffer field expression conversion.
345 (DoResolveLValue): Ditto.
346 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
347 (ArrayPtr): Derives from FixedBufferPtr.
348 (ArrayPtr.Emit): Add extra emit for array elements.
350 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
352 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
353 for compiler generated types.
354 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
356 * statement.cs (Fixed): Refactored to be easier add fixed buffer
357 and consume less memory.
358 (Fixed.Resolve): Add fixed buffer case.
360 * typemanager.cs (compiler_generated_attr_ctor,
361 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
362 (HasElementType): Add our own implementation to work on every
365 2005-02-11 Miguel de Icaza <miguel@novell.com>
367 * anonymous.cs (CaptureContext): Track whether `this' has been
370 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
371 only captured `this' if it was implicitly done (instance
372 methods/variables were used).
374 * codegen.cs (EmitContext.CaptureThis): New method to flag that
375 `this' must be captured.
377 2005-01-30 Miguel de Icaza <miguel@novell.com>
379 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
380 is null it means that there has been no need to capture anything,
381 so we just create a sibling.
383 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
385 Just a partial fix. The other half is fairly elusive.
387 2005-02-10 Raja R Harinath <rharinath@novell.com>
389 Fix #52586, cs0121-4.cs.
390 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
391 and return a hashtable.
392 (MemberCache.ClearDeclaredOnly): New.
393 (MemberCache.MemberCache): Update to change. Make a deep copy of
394 the method_hash of a base type too.
395 (MemberCache.AddMethods): Adapt to having a deep copy of the base
396 type methods. Overwrite entries with the same MethodHandle so
397 that the ReflectedType is correct. The process leaves in base
398 virtual functions and their overrides as distinct entries.
399 (CacheEntry): Now a class instead of a struct. It shouldn't alter
400 matters since it was boxed in a ArrayList before.
401 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
403 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
404 case of a virtual function and its override (choose the overload
406 (Invocation.OverloadResolve): Avoid 'override' members during
407 'applicable_type' calculation.
409 2005-03-28 Raja R Harinath <rharinath@novell.com>
411 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
412 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
413 GetTypeHandle. It is possible for a reflected type to derive from
414 a TypeBuilder (e.g., int[] derives from the TypeBuilder
415 System.Array during mscorlib compilation).
416 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
417 contain a method_hash, don't create one either. Don't create a
418 deep copy of the base cache's method_hash.
419 (MemberCache.SetupCache): Rename back from DeepCopy.
420 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
421 already initialized. If we see an override function, add its
422 underlying base virtual function to the member_hash too.
424 2005-02-09 Raja R Harinath <rharinath@novell.com>
426 Combine two near-redundant caches.
427 * typemanager.cs (method_params): Rename from method_internal_params.
428 (TypeManager.GetParameterData): New. Replace
429 Invocation.GetParameterData.
430 (TypeManager.LookupParametersByBuilder): Remove.
431 * expression.cs (Invocation.method_parameter_cache): Remove.
432 (Invocation.GetParameterData): Remove.
434 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
437 2005-02-08 Raja R Harinath <rharinath@novell.com>
440 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
441 TypeManager.multicast_delegate_type is null, resolve it by looking
442 up "System.MulticastDelegate".
443 * rootcontext.cs (RootContext.ResolveCore): Simplify.
445 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
446 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
447 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
450 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
451 (LabeledStatement.AddReference): New. Set 'referenced'.
452 (Goto.Resolve): Use it.
454 2005-02-05 John Luke <john.luke@gmail.com>
456 * driver.cs: remove duplicate -doc line in Usage ()
458 2005-02-04 Raja R Harinath <rharinath@novell.com>
460 * location.cs (Location.AddFile): Fix CS2002 error report.
462 2005-02-02 Martin Baulig <martin@ximian.com>
464 * delegate.cs (Delegate.DefineType): Report an internal error if
465 TypeManager.multicast_delegate_type is null. See bug #72015 for
468 2005-02-02 Raja R Harinath <rharinath@novell.com>
470 Fix a crasher in a variant of #31984.
471 * const.cs (Constant.CheckBase): New override that defers the
472 new-or-override check in case the base type hasn't been populated
474 (Constant.Define): Ensure the new-or-override check is performed.
476 2005-02-01 Duncan Mak <duncan@ximian.com>
478 * const.cs (LookupConstantValue): Check that `ce' is not null
479 before calling GetValue ().
481 2005-02-01 Raja R Harinath <rharinath@novell.com>
483 Fix test-334.cs (#69519).
484 * cs-parser.jay (using_alias_directive): Pass in an expression to
485 NamespaceEntry.UsingAlias.
486 (using_namespace_directive): Pass in an expression to
487 NamespaceEntry.Using.
488 (namespace_name): Don't flatten to a string.
489 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
490 (NamespaceEntry.AliasEntry.Resolve): Lookup using
492 (NamespaceEntry.UsingEntry): Likewise.
493 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
495 (NamespaceEntry.LookupForUsing): Remove.
496 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
498 (NamespaceEntry.Lookup): Remove support for dotted names.
500 2005-02-01 Raja R Harinath <rharinath@novell.com>
502 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
504 (NamespaceEntry.ImplicitParent): Compute on demand.
505 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
506 parallels the current.
507 (NamespaceEntry.LookupForUsing): Use it.
508 (NamespaceEntry.Lookup): If the current namespace-entry is
509 implicit, don't search aliases and using tables.
511 2005-02-01 Raja R Harinath <rharinath@novell.com>
514 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
516 (TypeContainer.BaseCache): Compute on demand.
517 (TypeContainer.FindMembers): Define constants and types if they're
519 (FieldMember.Define): Move resetting of ec.InUnsafe before error
521 * const.cs (Constant.Define): Make idempotent.
523 2005-01-29 Miguel de Icaza <miguel@novell.com>
525 * pending.cs: Produce better code (no nops produced by using Ldarg
528 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
529 i - 1' it should be arg + 1.
533 2005-01-28 Raja R Harinath <rharinath@novell.com>
535 * attribute.cs (Attribute.CheckAttributeType): Make private
537 (Attribute.ResolveType): Make virtual.
538 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
539 handling of RootContext.Tree.Types.
541 2005-01-27 Raja R Harinath <rharinath@novell.com>
543 Update attribute-handling to use the SimpleName/MemberAccess
545 * cs-parser.jay (attribute): Pass in an expression to the
546 constructors of Attribute and GlobalAttribute.
547 * attribute.cs (Attribute): Take an expression for the name.
548 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
549 passed in attribute name expression.
550 (Attribute.CheckAttributeType): Use it.
551 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
552 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
553 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
554 argument to prevent error messages if the lookup fails.
556 2005-01-27 Marek Safar <marek.safar@seznam.cz>
558 * expression.cs (Indirection): Implemented IVariable interface
559 to support indirection in AddressOf operator.
560 (PointerArithmetic.Emit): Add optimalization for case where
561 result can be precomputed.
563 2005-01-26 Martin Baulig <martin@ximian.com>
565 * class.cs (TypeContainer.AttributeTargets): Return the correct
566 AttributeTargets depending on our `Kind' instead of throwing an
567 exception; fixes #71632.
569 2005-01-26 Marek Safar <marek.safar@seznam.cz>
572 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
575 2005-03-17 Martin Baulig <martin@ximian.com>
577 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
578 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
580 2005-03-17 Martin Baulig <martin@ximian.com>
582 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
583 to bool so we can return an error condition.
584 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
587 2005-03-17 Martin Baulig <martin@ximian.com>
589 * generic.cs (TypeMananager.IsIEnumerable): New public method.
591 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
592 converting from an array-type of T to `IEnumerable<T>'.
594 2005-03-16 Martin Baulig <martin@ximian.com>
596 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
597 (Nullable.LiftedUnaryMutator): New public class.
599 * expression.cs (UnaryMutator.DoResolve): Added support for
602 2005-03-14 Martin Baulig <martin@ximian.com>
604 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
606 2005-03-14 Martin Baulig <martin@ximian.com>
608 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
609 the comparision operators `<', `>', `<=' and `>='.
611 2005-03-13 Martin Baulig <martin@ximian.com>
614 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
615 avoid confusion with the `NullLiteral'.
616 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
618 2005-03-13 Martin Baulig <martin@ximian.com>
620 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
621 comparing arbitrary types with the null literal.
623 2005-03-13 Martin Baulig <martin@ximian.com>
625 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
626 boolean operators '&&', '||', '&' and '|'.
627 (Nullable.OperatorTrueOrFalse): New public class.
629 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
630 instead of a `StaticCallExpr'; added support for nullables.
632 2005-03-10 Martin Baulig <martin@ximian.com>
635 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
636 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
638 2005-03-07 Martin Baulig <martin@ximian.com>
640 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
641 it work if `expr' is not an IMemoryLocation.
642 (Nullable.Lifted): Implement IMemoryLocation.
643 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
646 2005-03-05 Martin Baulig <martin@ximian.com>
648 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
649 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
650 (Nullable): Added support for lifted unary and binary operators.
652 * expression.cs (Unary.DoResolve): Added support for nullable types.
653 (Binary.DoResolve): Likewise.
654 (Conditional.DoResolve): Likewise.
656 2005-03-02 Martin Baulig <martin@ximian.com>
658 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
660 * class.cs (ClassPart.SetParameterInfo): Override this.
661 (PartialContainer.SetParameterInfo): Override this.
662 (TypeContainer.CheckConstraints): New protected method.
663 (PartialContainer.CheckConstraints): Override this and check
664 whether the same contraints were specified in all parts of a
665 partial generic type definition.
666 (PartialContainer.UpdateConstraints): New public method.
668 * generic.cs (TypeParameter.UpdateConstraints): New public method.
670 2005-03-02 Martin Baulig <martin@ximian.com>
672 Committing a patch from Carlos Alberto Cortez to fix #72887.
674 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
675 casts from `T []' to `int []'.
677 2005-03-02 Martin Baulig <martin@ximian.com>
679 * generic.cs (TypeManager.IsEqual): Make this symmetric.
681 * expression.cs (Binary.ResolveOperator): When resolving a
682 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
683 `=='. Fixes #71866. See gen-127.cs.
685 2005-03-02 Martin Baulig <martin@ximian.com>
687 * class.cs (TypeContainer.DoDefineMembers): We also need a default
688 static constructor in static classes.
690 2005-03-02 Martin Baulig <martin@ximian.com>
693 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
694 (Nullable.LiftedConversion): Added support for user-defined
697 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
699 * cs-parser.jay: Use ComposedCast everywhere instead of
700 NullableType, so we don't need to check for NullableType
702 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
703 case where we'll be resolved into a `parenthesized_expression_0'
707 (Convert.UserDefinedConversion): Added nullable conversions.
709 2005-02-28 Martin Baulig <martin@ximian.com>
711 * generic.cs (TypeManager.IsNullableType): New static method.
712 (Nullable): New abstract class.
713 (Nullable.NullLiteral): New public class.
714 (Nullable.LiftedConversion): New public class.
716 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
717 `builtin_types opt_nullable'.
720 (Convert.ImplicitConversionStandard): Added nullable conversions.
721 (Convert.ExplicitConversionStandard): Likewise.
722 (Convert.ExplicitConversion): Likewise.
724 2005-02-26 Martin Baulig <martin@ximian.com>
726 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
727 begin with a "?", for instance "?[]". Don't do a type lookup if
730 2005-02-25 Martin Baulig <martin@ximian.com>
732 The first part of Nullable Types :-)
734 * generic.cs (NullableType): New public class.
735 (NullCoalescingOperator): New public class.
736 (TypeArguments.Resolve): Add a CS0306 check.
738 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
739 (opt_nullable): New rule.
740 (type): Added `opt_nullable' to `namespace_or_type_name',
741 `builtin_types' and `pointer_type'.
742 (array_type): Added `opt_nullable'.
743 (opt_rank_specifier_or_nullable): New rule; this is the
744 combination of `opt_rank_specifier' and `opt_nullable'.
745 (opt_error): New rule; catch errors here.
746 (nullable_type_or_conditional): New rule; we use this to check for
747 nullable and still detect the conditional operator.
748 (local_variable_type): Use `opt_rank_specifier_or_nullable'
749 instead `opt_rank_specifier'.
751 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
754 2005-02-24 Martin Baulig <martin@ximian.com>
756 * README, README.Changes: Removed; they're old and obsolete.
758 2005-02-22 Martin Baulig <martin@ximian.com>
760 * generic.cs (TypeParameter.Resolve): If resolving the constraints
761 returned an error, set `constraints' to null to avoid a crash
763 (TypeParameter.ResolveType): Likewise.
765 2005-02-22 Martin Baulig <martin@ximian.com>
768 (Constraints.ResolveTypes): Protect against being called twice.
769 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
770 (TypeParameter.ResolveType): New public method; calls
771 constraints.ResolveTypes().
772 (TypeParameter.DefineType): Moved constraints.ResolveType() out
773 into the new ResolveType().
774 (GenericMethod.Define): Call ResolveType() on all our
777 2005-02-21 Martin Baulig <martin@ximian.com>
780 (TypeManager.generic_nullable_type): New static public field.
781 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
784 (RootContext.ResolveCore): Resolve "System.Nullable`1".
786 2005-02-15 Martin Baulig <martin@ximian.com>
788 * generic.cs (ConstructedType.Constraints): Correctly check
789 constraints if the argument type is a type parameter; fixes
792 2005-02-02 Martin Baulig <martin@ximian.com>
794 * delegate.cs (Delegate.DefineType): Report an internal error if
795 TypeManager.multicast_delegate_type is null. See bug #72015 for
798 2005-01-29 Miguel de Icaza <miguel@novell.com>
800 * pending.cs: Produce better code (no nops produced by using Ldarg
803 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
804 i - 1' it should be arg + 1.
808 2005-01-26 Martin Baulig <martin@ximian.com>
810 * cs-parser.jay (indexer_declarator): Don't report an error if we
811 have type parameters since we can be an explicit interface
812 implementation; fixes #71449.
814 2005-01-26 Martin Baulig <martin@ximian.com>
816 * class.cs (TypeContainer.AttributeTargets): Return the correct
817 AttributeTargets depending on our `Kind' instead of throwing an
818 exception; fixes #71632.
820 2005-01-26 Martin Baulig <martin@ximian.com>
822 * delegate.cs (Delegate.DefineType): Correctly define our type
823 parameters. Fixes #71483.
825 2005-01-25 Raja R Harinath <rharinath@novell.com>
828 * expression.cs (MemberAccess.DoResolve): Don't complain with
829 cs0572 when the LHS of a member access has identical name and type
832 2005-01-25 Marek Safar <marek.safar@seznam.cz>
835 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
837 Create custom PermissionSet only for PermissionSetAttribute.
839 2005-01-24 Marek Safar <marek.safar@seznam.cz>
842 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
843 delegates in static class.
845 2005-01-24 Martin Baulig <martin@ximian.com>
847 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
848 merging an implicit block, just use its reachability.
850 * statement.cs (Block.Resolve): Make the unreachable code check
851 work wrt. implicit blocks; see test-337 from #63842.
853 2005-01-21 Alp Toker <alp@atoker.com>
855 * cs-parser.jay: destructor_declaration's container is PartialContainer
856 not Class when partial types are used, so use Kind prop instead of
859 2005-01-22 Miguel de Icaza <miguel@ximian.com>
861 * cs-parser.jay: Improve error reporting when an interface
864 2005-01-20 Dick Porter <dick@ximian.com>
866 * support.cs: SeekableStreamReader fix from Sandor Dobos
867 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
868 chars are read. Fixes bug 70369.
870 2005-01-20 Raja R Harinath <rharinath@novell.com>
872 * cs-parser.jay (catch_clause): Simplify current_block handling
875 2005-01-17 Miguel de Icaza <miguel@ximian.com>
877 * convert.cs (ImplicitStandardConversionExists): Synchronize the
878 code with ImplicitStandardConversion to handle the implicit
879 conversion of method groups into valid delegate invocations.
881 The problem is that in parameter handling we were using this code
882 path. Fixes bug #64698
884 2005-01-19 Raja R Harinath <rharinath@novell.com>
886 * cs-parser.jay: Fix several infelicities.
887 - Avoid assigning to the parser value stack. Code like
888 '$3 = null' is unclean. Synthesize a value for the code block
890 - Avoid using oob_stack for storing location information. Use ...
891 (_mark_): ... this. New (empty) rule. Saves the current location
893 (foreach_statement): Avoid using oob_stack for current_block
894 handling. Use technique used in for_statement and
895 using_statement. Synthesize a value for the code block to store
896 additional intermediate information.
898 2005-01-13 Miguel de Icaza <miguel@ximian.com>
900 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
901 of a different type is only allowed to private fields of a
902 containing type, not on fields of a base class.
904 See test-174.cs and error cs0122-9.cs
906 2005-01-13 Raja R Harinath <rharinath@novell.com>
908 Fix test-335.cs (bug #58126).
909 * cs-parser.jay (argument): Split out non-expression parts of the
910 rule into 'non_simple_argument'.
911 (invocation_expression): Support parenthesized invocations with
912 multiple arguments, and with single non-simple arguments.
914 2005-01-13 Raja R Harinath <rharinath@novell.com>
916 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
919 2005-01-12 Raja R Harinath <rharinath@novell.com>
921 Fix cs0038-1.cs, cs1640-6.cs.
922 * ecore.cs (Expression.Resolve): Remove special-case for
923 SimpleName in error-handling.
924 (Expression.almostMatchedMembers): Relax access permission to
926 (Expression.MemberLookupFailed): Handle duplicates in
927 almostMatchedMembers list.
928 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
929 * expression.cs (New.DoResolve): Report CS1540 for more cases.
930 * typemanager.cs (GetFullNameSignature): Use the MethodBase
931 overload if the passed in MemberInfo is a MethodBase.
933 2005-01-25 Martin Baulig <martin@ximian.com>
936 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
938 2005-01-12 Marek Safar <marek.safar@seznam.cz>
941 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
942 for non-CAS & merge permission sets properly.
944 2005-01-11 Raja R Harinath <rharinath@novell.com>
946 Improve standard-compliance of simple name and member access
947 resolution. Fixes bugs #52697, #57200, #67520, #69519.
948 * ecore.cs (FullNamedExpression): New abstract base class
949 for Namespaces and TypeExpressions.
950 (ResolveFlags.SimpleName): Remove.
951 (SimpleName): Remove support for dotted names.
952 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
953 DeclSpace.FindType and DeclSpace.LookupType.
954 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
955 (Expression.ExprClassName): Make member function.
956 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
957 a namespace. Remove creation of dotted "SimpleName"s.
958 (MemberAccess.DoResolve): Likewise.
959 * decl.cs (DeclSpace.Cache): Make private.
960 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
961 (DeclSpace.FindType): Update.
962 (DeclSpace.LookupType): Move here from RootContext. Return a
964 * namespace.cs (Namespace): Derive from FullNamedExpression
965 so that it can be part of expression resolution.
966 (Namespace.Lookup): Return an FullNamedExpression.
967 (NamespaceEntry.LookupAlias): Lookup aliases only in current
969 * rootcontext.cs (NamespaceLookup): Remove.
970 (LookupType): Move to DeclSpace.
971 * attribute.cs (CheckAttributeType): Update.
972 * doc.cs (FindDocumentedType): Remove allowAlias argument.
973 (FindDocumentedTypeNonArray): Likewise.
975 2005-01-11 Raja R Harinath <rharinath@novell.com>
977 Fix cs0509.cs, cs1632.cs.
978 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
979 is the same as IsInterface.
980 (TypeContainer.GetClassBases): Likewise.
981 * statement.cs (LabeledStatement.ig): New field.
982 (LabeledStatement.LabelTarget): Save ILGenerator which created the
984 (LabeledStatement.DoEmit): Check that the label was created with
985 the same ILGenerator.
987 2005-01-10 Marek Safar <marek.safar@seznam.cz>
990 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
991 accessors to its properties.
993 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
994 from accessors to property.
996 2005-01-10 Marek Safar <marek.safar@seznam.cz>
999 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
1002 2005-01-08 Miguel de Icaza <miguel@ximian.com>
1004 * attribute.cs: Check for null and empty strings.
1006 I have lost another battle to Paolo.
1008 2005-01-07 Marek Safar <marek.safar@seznam.cz>
1011 * class.cs (PropertyMethod): Set Parent field in ctors.
1012 (SetMethod.InternalParameters): Add unsafe switch hack.
1013 Override MarkForDuplicationCheck where it is appropriate.
1015 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
1016 It says whether container allows members with the same name.
1018 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
1019 Removed is_method parameter.
1021 2005-01-06 Duncan Mak <duncan@ximian.com>
1023 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
1024 because the previous change led to incorrect reporting of CS1032
1025 ("Cannot define/undefine preprocessor symbols after first token in
1026 file"). Instead of using `tokens_seen' as the only flag that
1027 triggers CS1040, introduce `comments_seen'. This new flag is used
1028 to signify having seen comments on the current line, so it is
1029 unset after a newline.
1031 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
1033 * doc.cs : When searching for a type, find nested type too.
1034 This fixes bug #71040.
1036 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
1039 - Warn missing member comment on those classes which also does not
1040 have doc comments. Fixed bug #71041.
1041 - Don't warn missing doc comment on default constructor.
1044 2005-01-06 Duncan Mak <duncan@ximian.com>
1046 * cs-tokenizer.cs (xtoken): After handling traditional C-style
1047 comments, set `tokens_seen' to true. This allows us to detect
1048 misplaced preprocessor directives (i.e. not at the beginning of
1049 the a line, nor after whitespaces). In that case, report error
1050 CS1040. This fixes bug #56460.
1052 * cs-parser.jay (interface_member_declaration): Add checks for
1053 IsExplicitImpl, and report CS0541 error if an interface member is
1054 defined as an explicit interface declaration.
1056 2005-01-06 Marek Safar <marek.safar@seznam.cz>
1059 * class.cs (PropertyMethod): Set Parent field in ctors.
1060 (SetMethod.InternalParameters): Add unsafe switch hack.
1062 * decl.cs (MemberCore.Parent): Cannot be readonly.
1064 2005-01-06 Raja R Harinath <rharinath@novell.com>
1066 * decl.cs (DeclSpace.ResolveType): Remove.
1067 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
1068 Merge in code from ...
1069 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
1070 * class.cs, enum.cs: Update to changes.
1072 2005-01-06 Miguel de Icaza <miguel@ximian.com>
1074 * anonymous.cs: Ensure that we init the scope of our parent if it
1075 has not been initialized yet.
1077 2004-12-30 Duncan Mak <duncan@ximian.com>
1079 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
1080 if field.FieldBuilder is null. Fixes #70758.
1082 * convert.cs: Fixed some typos and updated some of the comments.
1083 (ImplicitStandardConversionExists):
1084 (TryImplicitIntConversion): If `target_type' is an interface and
1085 the type of `ic' implements this interface, return true or a new
1086 BoxedCast instead of null. This fixes #70468.
1088 2004-12-29 Duncan Mak <duncan@ximian.com>
1090 * expression.cs (Argument.Emit): Check that Expr is
1091 IMemoryLocation before casting to it, and report CS1510 otherwise.
1095 2004-12-21 Ben Maurer <bmaurer@ximian.com>
1097 * statement.cs (Block.ThisVariable): remove the recursion here, to
1098 make the --profile more sane.
1100 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
1102 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
1103 assembly, by JB Evain.
1105 2004-12-17 Raja R Harinath <rharinath@novell.com>
1107 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
1108 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
1109 "parent" refers to enclosing type/class. "base" refers to superclass.
1111 2004-12-17 Raja R Harinath <rharinath@novell.com>
1113 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
1114 Ensure that we only have GlobalAttributes.
1115 * attribute.cs (Attribute.Emit): Make non-virtual.
1116 (GlobalAttribute.Emit): Remove.
1117 (Attribute.Resolve): Make virtual.
1118 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
1119 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
1120 the argument. Don't create one.
1121 (Attribute.GetObsoleteAttribute): Likewise.
1122 (Attribute.GetClsCompliantAttributeValue): Likewise.
1123 * class.cs, decl.cs: Update to changes.
1125 2004-12-17 Marek Safar <marek.safar@seznam.cz>
1127 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
1129 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
1131 * statement.cs (Foreach.Resolve): Add error 186 report.
1133 2004-12-16 Marek Safar <marek.safar@seznam.cz>
1135 * expression.cs (Conditional.DoResolve): Add warning 429.
1137 * statement.cs (If.Resolve): Add warning 665.
1139 2004-12-16 Raja R Harinath <rharinath@novell.com>
1141 New invariant: RootContext.Tree.Types.NamespaceEntry == null
1142 except when in the parser, and in GlobalAttribute.
1143 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
1144 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
1145 RootContext.Tree.Types.NamespaceEntry once work is done.
1146 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
1147 and resets RootContext.Tree.Types.NamespaceEntry.
1149 2004-12-15 Marek Safar <marek.safar@seznam.cz>
1151 * cs-parser.jay: Don't create a block for every variable.
1153 2004-12-14 Miguel de Icaza <miguel@ximian.com>
1155 * location.cs: Provide extra information.
1157 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
1158 variables from the captured environment, it is the ldarg_0.
1160 2004-12-14 Marek Safar <marek.safar@seznam.cz>
1162 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
1165 * class.cs: Changed warning level for 169 to avoid developer
1166 displeasure from warning flooding. It will be changed back when they
1167 fix most of current BCL warnings.
1169 * RootContext.cs: Pushed default WarningLevel to 3.
1171 * statement.cs: Removed unused variable.
1173 2004-12-14 Marek Safar <marek.safar@seznam.cz>
1175 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
1176 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
1177 Add error 502 report.
1178 (StaticClass.DefineType): Add error 441 report.
1179 (Class.AllowedModifiersProp): New virtual property as temporary
1180 extension to AllowedModifiers.
1181 (Class.DefineType): Add error 418 report. Moved ModFlags check here
1182 to share implementation with StaticClass and don't call virtual
1185 * driver.cs (MainDriver): Add error 1558 test.
1187 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
1188 report. Moved error 36 test here.
1190 * statement.cs (Throw.Resolve): Add error 724 report.
1192 * typemanager.cs: Add out_attribute_type core type.
1194 2004-12-13 Marek Safar <marek.safar@seznam.cz>
1196 * class.cs (TypeContainer.VerifyClsCompliance): Add error
1198 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
1200 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
1203 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
1205 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
1206 Add error 3023 report.
1207 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
1209 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
1212 2004-12-12 John Luke <john.luke@gmail.com>
1214 * driver.cs (AddArgs): take -- into account when
1215 adding arguments, fixes bug 65710
1217 2004-12-12 Martin Baulig <martin@ximian.com>
1219 * expression.cs (Unary.TryReduceNegative): Added support for
1220 SByteConstant and ByteConstant.
1221 (Unary.Reduce): Check error values from TryReduceNegative().
1223 2004-12-10 Marek Safar <marek.safar@seznam.cz>
1225 * attributes.cs (Attribute.Resolve): Avoid multiple error report
1226 and report exception as error 182.
1228 2004-12-10 Raja R Harinath <rharinath@novell.com>
1230 * driver.cs (Main): Fix message when there are warnings.
1232 2004-12-09 Miguel de Icaza <miguel@ximian.com>
1234 * delegate.cs: Fixed my fix from yesterday, sorry about that.
1236 2004-12-09 Marek Safar <marek.safar@seznam.cz>
1238 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
1239 Reduced number of warnings.
1241 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
1243 2004-12-08 Miguel de Icaza <miguel@ximian.com>
1245 * driver.cs: Removed message.
1247 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
1249 2004-12-08 <vargaz@freemail.hu>
1251 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
1253 2004-12-08 Martin Baulig <martin@ximian.com>
1255 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
1256 instead of a CS3002 for properties and indexer.
1258 2004-12-08 Martin Baulig <martin@ximian.com>
1260 * decl.cs (MemberName.ToString): Make this work again.
1262 2004-12-08 Marek Safar <marek.safar@seznam.cz>
1264 * attribute.cs (Resolve): Add error 591 detection.
1266 * class.cs (FieldMember.Define): Add error 1547 detection.
1267 (Indexer.Define): Add error 620 detection.
1268 (Operator.Define): Add error 590 detection.
1270 * ecore.cs: Missing argument for error 79.
1272 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
1275 2004-12-07 Marek Safar <marek.safar@seznam.cz>
1278 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
1281 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
1283 * cs-parser.jay : handle doc comments on implicit/explicit operators.
1284 Some operator comments were suppressed.
1285 * doc.cs : Implicit/explicit operator name in doc comments are like
1286 "op_Explicit(type)~returnType", so added suffix handling.
1288 2005-01-21 Alp Toker <alp@atoker.com>
1290 * cs-parser.jay: destructor_declaration's container is PartialContainer
1291 not Class when partial types are used, so use Kind prop instead of 'is'.
1293 2004-12-12 Martin Baulig <martin@ximian.com>
1295 * expression.cs (Unary.TryReduceNegative): Added support for
1296 SByteConstant and ByteConstant.
1297 (Unary.Reduce): Check error values from TryReduceNegative().
1299 2004-12-11 Martin Baulig <martin@ximian.com>
1301 * support.cs (ReflectionParameters.ParameterName): If we have a
1302 `gpd', call `ParameterName' on it.
1304 * parameter.cs (Parameter.GetParameterAttributes): New static method.
1306 * pending.cs (PendingImplementation.DefineProxy): Call
1307 DefineParameter() for all of the MethodBuilder's arguments.
1309 2004-12-09 Martin Baulig <martin@ximian.com>
1311 * doc.cs (DocUtil): Make this a static class.
1313 2004-12-09 Martin Baulig <martin@ximian.com>
1315 * expression.cs (Invocation.InferType): Moved the type inference
1316 implementation into TypeManager.
1318 * generics.cs (TypeManager): Moved the type inference
1319 implementation here.
1321 2004-12-09 Martin Baulig <martin@ximian.com>
1323 * typemanager.cs (TypeManager): Make this a partial class.
1326 (TypeManager): Move the generics part of `TypeManager' here.
1328 2004-12-08 Martin Baulig <martin@ximian.com>
1330 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
1331 instead of a CS3002 for properties and indexer. Added CS3024
1332 check for generic interfaces.
1334 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
1335 instances are not CLS-compliant.
1337 2004-12-08 Martin Baulig <martin@ximian.com>
1340 (void_pointer_expression): New rule for `void*', `void**' etc.
1341 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
1343 2004-12-08 Martin Baulig <martin@ximian.com>
1345 * expression.cs (Invocation.InferType): Removed the hack for
1346 MethodCore.MayUnify().
1348 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
1351 * class.cs (MethodCore.MayUnify): Use
1352 TypeManager.MayBecomeEqualGenericTypes().
1354 2004-12-08 Martin Baulig <martin@ximian.com>
1356 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
1357 parameter, box it. Fixes #69233.
1359 2004-12-08 Martin Baulig <martin@ximian.com>
1361 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
1362 have the ctor constraint. Fixes #68326.
1364 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
1366 * cs-parser.jay : interface comment was not consumed because of
1367 extra opt_semicolon before doc handling.
1369 2004-12-03 Raja R Harinath <rharinath@novell.com>
1371 Fix test-327.cs, test-328.cs, and put in early infrastructure
1372 for eventually fixing #52697.
1373 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
1374 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
1376 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
1377 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
1378 (VerifyUsing, error246): Update.
1379 * rootcontext.cs (RootContext.NamespaceLookup): Just use
1380 'NamespaceEntry.LookupNamespaceOrType'.
1382 2004-12-07 Martin Baulig <martin@ximian.com>
1384 * driver.cs: Call it "BETA SOFTWARE" :-)
1386 2004-12-06 Raja R Harinath <rharinath@novell.com>
1388 Fix crash on cs0657-17.cs.
1389 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
1390 Use RootContext.Tree.Types, not 'new RootTypes ()'.
1391 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
1392 the case where the NamespaceEntry gets overwritten.
1394 2004-12-06 Marek Safar <marek.safar@seznam.cz>
1396 Fixed #69195, #56821
1397 * ecore.cs (ResolveBoolean): Tiny refactoring.
1399 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
1400 of right expression resolving when left is false constant and
1401 operator is LogicalAnd OR true constant and operator is LogicalOr.
1403 * statement.cs (ResolveUnreachable): Always reports warning.
1405 2004-12-05 Miguel de Icaza <miguel@ximian.com>
1407 * class.cs: Distinguish between 1721 and 1722 (just a little help
1408 for the programmer).
1410 2004-12-03 Miguel de Icaza <miguel@ximian.com>
1412 * delegate.cs: Only allow this on new versions of the language.
1414 2004-12-02 Duncan Mak <duncan@ximian.com>
1416 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
1418 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
1419 here as a static method. Take an additional bool out parameter
1420 `must_do_cs1540_check' for signaling to InstanceResolve.
1421 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
1422 member field from PropertyExpr class and made it an argument of
1424 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
1425 check for MarshalByRefObject, and report CS0122 instead of CS1540.
1426 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
1427 and `remove_accessor' as well as InstanceResolve: report CS0122
1432 2004-12-07 Martin Baulig <martin@ximian.com>
1434 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
1435 and CS0692 where appropriate.
1437 2004-12-06 Martin Baulig <martin@ximian.com>
1439 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
1440 IsDuplicateImplementation() and improved it.
1442 * expression.cs (Invocation.InferTypeArguments): Added
1443 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
1444 and removed the "ref" modifier from `infered_types'.
1446 * decl.cs (MemberName.ToString): Removed the exception.
1448 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
1450 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
1451 comments are allowed.
1453 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
1455 * delegate.cs: Add checks for subtypes in paramaters and return values
1456 in VerifyMethod () to add support for Covariance/Contravariance
1459 2004-12-02 Miguel de Icaza <miguel@ximian.com>
1461 * report.cs: Remove extra closing parenthesis.
1463 * convert.cs (Error_CannotImplicitConversion): If the name of the
1464 types are the same, provide some extra information.
1466 2004-12-02 Marek Safar <marek.safar@seznam.cz>
1469 * attribute.cs (Resolve): Improved implementation of params
1470 attribute arguments.
1472 * support.cs (ParameterData): Add HasParams to be faster.
1474 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
1476 all things are for /doc support:
1478 * doc.cs: new file that supports XML documentation generation.
1479 * mcs.exe.sources: added doc.cs.
1481 Handle /doc command line option.
1482 Report error 2006 instead of 5 for missing file name for /doc.
1483 Generate XML documentation when required, after type resolution.
1485 Added support for picking up documentation (/// and /** ... */),
1486 including a new XmlCommentState enumeration.
1488 Added lines to fill Documentation element for field, constant,
1489 property, indexer, method, constructor, destructor, operator, event
1490 and class, struct, interface, delegate, enum.
1491 Added lines to warn incorrect comment.
1493 Added Documentation field (passed only when /doc was specified).
1495 Added DocComment, DocCommentHeader, GenerateDocComment() and
1496 OnGenerateDocComment() and some supporting private members for
1497 /doc feature to MemberCore.
1499 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
1501 Added overriden DocCommentHeader.
1503 Added overriden DocCommentHeader and GenerateDocComment().
1505 2004-12-01 Miguel de Icaza <miguel@ximian.com>
1507 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
1508 unwrapping the enumeration values, chain to
1509 DoConstantNumericPromotions again, so we can promote things to the
1510 fundamental types (takes care of enums that are bytes, sbytes).
1514 2004-12-01 Raja R Harinath <rharinath@novell.com>
1516 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
1517 Fix long-standing bug in type-lookup. Use FindType instead of
1518 LookupType when ec.ResolvingTypeTree.
1519 (Attribute.ResolveType, Attribute.Resolve)
1520 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
1522 (Attributes.Search): Remove internal version. Update.
1523 (Attributes.SearchMulti): Update.
1524 (Attributes.GetClsCompliantAttribute): Remove.
1525 (Attributes.GetIndexerNameAttribute): Remove.
1526 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
1527 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
1528 * class.cs (Indexer.Define): Likewise.
1530 2004-12-01 Marek Safar <marek.safar@seznam.cz>
1533 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
1534 MarshallByReference members access.
1536 * expression.cs: Use CheckMarshallByRefAccess;
1537 Better error CS0197 message.
1539 * report.cs: Print whole related error message.
1541 2004-11-29 Marek Safar <marek.safar@seznam.cz>
1543 * class (GetClassBases): Better error 60 report.
1544 (EventProperty): Disabled warning 67 detection.
1546 2004-11-29 Marek Safar <marek.safar@seznam.cz>
1549 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
1551 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
1554 2004-11-29 Marek Safar <marek.safar@seznam.cz>
1557 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
1559 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
1561 2004-11-26 Miguel de Icaza <miguel@ximian.com>
1563 * attribute.cs (Attribute.Resolve): Refine error reporting and
1564 report a cs0117 if the identifier does not exist, to distinguish
1565 from 0617 which is a miss-use of the actual identifier.
1567 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
1568 between cs0070 and cs0079.
1570 * class.cs (MemberBase.DoDefine): When reporting a wrong
1571 accessibility level, we use MethodCore to compare instead of
1572 Method (this was a regression in some refactoring effort).
1574 So now we correctly report cs0056 again.
1576 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
1577 testing the target_type (which was known to be object_type) and
1578 not the source type (which is anonymous_method).
1580 Fixed reporting of error cs1660.
1582 * expression.cs (UserCast.Source): Expose the underlying cast.
1584 * statement.cs (Switch.SwitchGoverningType): Sort the list of
1585 allowed types to find a match to int32 first (most common).
1587 In addition, it ignores any ImplicitUserConversions that did an
1588 internal implicit conversion (as the switch statement allows only
1589 one integral conversion to exist).
1591 * class.cs (PartialContainer.Create): rename `name' to
1592 `member_name' for clarity. Then replace the string calls with a
1593 call to MemberName.GetPartialName, as now using
1594 MemberName.ToString is an error (this is due to the side effects
1595 it had, that were fixed in the past).
1597 This will restore the error reporting on a number of partial class
1598 errors that were missusing this (and getting an exception as a
1599 results, which is now just a plain textual warning, because
1600 yyparse debug output would crash otherwise).
1602 2004-11-26 Raja R Harinath <rharinath@novell.com>
1604 * Makefile (PROGRAM_INSTALL_DIR): Remove.
1606 2004-11-25 Ben Maurer <bmaurer@ximian.com>
1608 * rootcontext.cs (LookupType): Make sure to cache lookups that
1609 don't give us a negative result. This saves about 5% of corlib
1612 2004-11-25 Miguel de Icaza <miguel@ximian.com>
1614 * report.cs (AbstractMessage.Print): messages are sent to stderr
1616 * class.cs (TypeContainer.GetClassBases): It is an error to have a
1617 non-interface in the list of interfaces (at this point, either
1618 parent was properly set, or a base class is being listed in the
1619 interfaces section).
1621 This flags error 1722, and resolves the crash from bug 69259.
1623 2004-11-25 Ben Maurer <bmaurer@ximian.com>
1625 * statement.cs (Using.EmitExpressionFinally): make this work right
1626 for valuetypes. Fixes 69926.
1628 2004-11-25 Miguel de Icaza <miguel@ximian.com>
1630 * const.cs (Const.ChangeType): Cope with the "0 literal can be
1631 converted to an enum" here, before we try to change the underlying
1632 type. This code exists, but it is a different code path than the
1633 one used while encoding constants.
1635 (ImplicitReferenceConversionExists): In addition, resynchronized
1636 the code here, so it matches the same code in
1637 ImplicitReferenceConversionExists for the `from any class-type S
1638 to any interface-type T'.
1640 2004-11-25 Marek Safar <marek.safar@seznam.cz>
1642 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
1644 2004-11-24 Miguel de Icaza <miguel@ximian.com>
1646 * cs-parser.jay: Use verbosity accordingly.
1648 2004-11-24 Marek Safar <marek.safar@seznam.cz>
1650 * expression.cs (Unary.ResolveOperator): Do not report warning;
1651 AddressOf reads from variable.
1653 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
1655 2004-11-24 Marek Safar <marek.safar@seznam.cz>
1659 * attribute.cs (Attributable): Removed CheckTargets.
1660 (Attributes.Emit): Explicit attribute targets are tested here.
1662 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
1663 not enabled for interfaces.
1665 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
1666 (GetAssemblyName): Ouch next bug there.
1668 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
1670 * expression.cs: Error 275 added.
1672 2004-11-23 Marek Safar <marek.safar@seznam.cz>
1674 Fix bug #69177 (Implemented decimal constant support)
1676 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
1677 (BinaryFold): Add DecimalConstant.
1679 * const.cs (Define): Decimal constant
1681 (ChangeType): Add decimal type handling.
1682 (LookupConstantValue): Don't set value for decimal type but
1683 emit DecimalConstantAttribute. Needed for constant optimization.
1685 * constant.cs (ToDecimal): New method.
1686 (ConvertToDecimal): New method.
1687 (IntConstant): Implemented ConvertToDecimal.
1688 (DecimalConstant.Emit): Emit optimized version for decimals in
1691 * expression.cs (ResolveOperator): Changed order of constant
1692 reduction to work correctly with native types which have
1693 overloaded operators.
1694 (ResolveMemberAccess): Extract constant value from attribute
1697 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
1699 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
1700 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
1701 (ChangeType): Decimal is special.
1702 (TypeToCoreType): Add decimal type.
1704 2004-11-22 Marek Safar <marek.safar@seznam.cz>
1706 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
1709 2004-11-22 Marek Safar <marek.safar@seznam.cz>
1711 * class.cs (EventField.ApplyAttributeBuilder): Fix error
1714 2004-11-19 Marek Safar <marek.safar@seznam.cz>
1716 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
1718 * pending.cs (PendingImplementation): Grab only interfaces.
1720 2004-11-19 Marek Safar <marek.safar@seznam.cz>
1722 * statement.cs (ForeachHelperMethods): Add location member and
1723 error 202 detection.
1725 2004-11-18 Marek Safar <marek.safar@seznam.cz>
1727 * expression.cs (DoResolveBase): Fixed wrong warning for out
1730 2004-12-04 Martin Baulig <martin@ximian.com>
1732 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
1733 to check whether the conversion is ok.
1735 * typemanager.cs (TypeManager.GetTypeArguments): Just return
1736 `Type.EmptyTypes' if we're not a generic TypeContainer.
1738 2004-11-25 Miguel de Icaza <miguel@ximian.com>
1740 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
1741 old bug: when converting from the null literal to a pointer,
1742 return an EmptyCast, not the NullLiteral.
1744 This fixes #69921, the recent null_type changes probably made this
1747 2004-12-03 Martin Baulig <martin@ximian.com>
1749 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
1750 method as our child, call AnonymousMethod.Compatible() on it.
1752 2004-12-02 Miguel de Icaza <miguel@ximian.com>
1754 * class.cs (FieldBase): Use an unused bit field from the field to
1755 encode the `has_offset' property from the FieldMember. This saves
1756 a couple of Ks on bootstrap compilation.
1758 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
1759 method as our child, return the AnonymousMethod resolved
1762 * expression.cs (New.DoResolve): Allow return values from
1763 NewDelegate to also include AnonymousMethods.
1767 2004-11-29 Raja R Harinath <rharinath@novell.com>
1769 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
1771 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
1772 System.Runtime.InteropServices._Exception, since it's a base
1773 interface of the core type System.Exception in the net_2_0 profile.
1775 2004-11-27 Martin Baulig <martin@ximian.com>
1777 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
1779 2004-11-26 Raja R Harinath <rharinath@novell.com>
1781 * Makefile: Convert to use executable.make.
1782 * gmcs.exe.sources: New.
1784 2004-11-25 Martin Baulig <martin@ximian.com>
1786 * expression.cs (Invocation.InferType): Added support for byref types.
1788 2004-11-25 Martin Baulig <martin@ximian.com>
1790 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
1791 in TypeManager.TypeToCoreType().
1793 2004-11-25 Martin Baulig <martin@ximian.com>
1795 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
1796 "Dispose" method from the `current_type'.
1797 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
1798 DoDefineMembers() instead of using the MethodBuilder; this is
1799 required for generic iterators.
1801 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
1803 2004-11-24 Martin Baulig <martin@ximian.com>
1805 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
1807 2004-11-20 Martin Baulig <martin@ximian.com>
1809 * expression.cs (Invocation.InferType): Correctly infer generic
1810 instances; see gen-103.cs.
1811 (Invocation.InferTypeArguments): If a generic method doesn't have
1812 any unbound type parameters, we don't need to infer anything.
1814 2004-11-19 Raja R Harinath <rharinath@novell.com>
1816 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
1818 2004-11-17 Raja R Harinath <rharinath@novell.com>
1820 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
1821 (TypeHandle.GetMemberCache): New.
1822 (TypeHandle.TypeHandle): Update.
1823 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
1824 (TypeManager.LookupParentInterfacesCache):
1825 Rename from LookupInterfaceCache. Optimize slightly.
1826 (TypeManager.MemberLookup_FindMembers): Update.
1827 * decl.cs (MemberCache.MemberCache): Set Container to null in the
1829 (AddCacheContents): Rename from AddHashtable.
1830 * class.cs (TypeContainer.parent_container): Remove.
1831 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
1832 (TypeContainer.DoDefineMembers): Don't initialize it.
1833 Update to name changes.
1835 2004-11-17 Miguel de Icaza <miguel@ximian.com>
1837 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
1838 that factors the code to check access modifiers on override.
1840 (PropertyBase): Use the code here.
1842 Patch from Lluis S'anchez, fixes bug #69361.
1844 2004-11-15 Miguel de Icaza <miguel@ximian.com>
1846 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
1847 routine that is used to report the use of a captured variable
1848 whose address has been taken.
1850 There are two checks: one when variables are being captured and
1851 the other check is when the address of a variable is taken.
1853 (because an anonymous methods might be resolved before *or* after
1854 the address has been taken) and
1856 * expression.cs (Conditional.DoResolve): Remove the special
1857 casing that Martin added to trueExpr and falseExpr being both
1858 NullLiteral. We get the right behavior now just by introducing
1859 the null_type into the compiler.
1861 * convert.cs (ExplicitConversion): Change the code to use
1862 null_type instead of testing `expr is NullLiteral'.
1863 (ImplicitConversionStandard): use null_type too.
1864 (ImplicitReferenceConversionExists): use null_type too.
1865 (ImplicitReferenceConversion): use null_type too.
1867 * literal.cs: The type of `NullLiteral' is now null_type instead
1869 (Resolve): Set the type here.
1871 * typemanager.cs: Introduce null_type.
1873 2004-11-18 Martin Baulig <martin@ximian.com>
1876 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
1878 2004-11-18 Martin Baulig <martin@ximian.com>
1880 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
1882 2004-11-18 Martin Baulig <martin@ximian.com>
1884 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
1885 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
1886 call ResolveConstructedType() on it to resolve it without checking
1888 (Constraints.ResolveTypes): Check them here.
1889 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
1890 but don't check constraints.
1891 (ConstructedType.ResolveAsTypeTerminal): Override this and also
1892 check constraints here.
1893 (ConstructedType.ResolveConstructedType): New public method. This
1894 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
1895 resolve ourselves without checking constraints.
1897 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
1899 2004-11-18 Martin Baulig <martin@ximian.com>
1902 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
1904 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
1906 2004-11-18 Martin Baulig <martin@ximian.com>
1908 * ecore.cs (TypeExpr.ResolveType): Removed.
1909 (Expression.ResolveAsTypeTerminal): We always return a fully
1910 resolved `TypeExpr', so we can just access its `Type'.
1912 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
1914 2004-11-17 Martin Baulig <martin@ximian.com>
1916 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
1917 sure we don't return any unresolved TypeExpr's.
1918 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
1920 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
1922 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
1923 unresolved `ConstructedType's.
1925 2004-11-17 Martin Baulig <martin@ximian.com>
1927 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
1929 2004-11-17 Martin Baulig <martin@ximian.com>
1932 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
1934 * decl.cs (DeclSpace.ResolveType): Removed.
1935 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
1937 2004-11-17 Martin Baulig <martin@ximian.com>
1939 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
1940 direction, like FindMembers() does. Fixes #69546, testcase is in
1943 2004-11-16 Martin Baulig <martin@ximian.com>
1945 This is based on a patch from Marek Safar, see bug #69082.
1946 Fixes bugs #63705 and #67130.
1948 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
1949 method; create a MemberCache for an interface type and cache the
1952 * decl.cs (IMemberContainer.ParentContainer): Removed.
1953 (IMemberContainer.ParentCache): New property.
1954 (MemberCache.SetupCacheForInterface): Removed.
1955 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
1956 to create a cache for an interface's "parent".
1958 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
1961 2004-11-14 Ben Maurer <bmaurer@ximian.com>
1963 * statement.cs: Avoid adding bools to a hashtable.
1965 2004-11-15 Martin Baulig <martin@ximian.com>
1967 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
1969 2004-11-11 Martin Baulig <martin@ximian.com>
1971 * typemanager.cs (TypeManager.GetMethodName): New method.
1973 * class.cs (MethodData.Define): Include the generic arity in the
1974 name of an explicit interface; also add it to the method name.
1976 * pending.cs (PendingImplementation.InterfaceMethod): The method
1977 name now includes the generic arity.
1979 2004-11-07 Miguel de Icaza <miguel@ximian.com>
1981 * expression.cs (Invocation.OverloadResolve): Flag error if we are
1982 calling an unsafe method from a safe location.
1984 2004-11-06 Marek Safar <marek.safar@seznam.cz>
1987 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
1989 2004-11-06 Miguel de Icaza <miguel@ximian.com>
1991 * namespace.cs (VerifyUsing): use GetPartialName instead of
1994 2004-11-05 Miguel de Icaza <miguel@ximian.com>
1996 * statement.cs (Return.Resolve): Fix regression in typo: if
1997 `in_exc', we have to request a NeedReturnLabel, this was a typo
1998 introduced in the anonymous method check-in. Fixes #69131.
2000 * Indexers were using the ShortName when defining themselves,
2001 causing a regression in the compiler bootstrap when applying the
2002 patch from 2004-11-02 (first part), now they use their full name
2003 and the bug is gone.
2005 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
2007 * driver.cs: Strip the path from the names of embedded resources. Fixes
2010 2004-11-04 Raja R Harinath <rharinath@novell.com>
2012 Fix error message regression: cs0104-2.cs.
2013 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
2014 (AliasEntry.Resolve): Update.
2015 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
2017 (RootContext.LookupType): Update.
2019 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
2021 * cs-parser.jay: Add support for handling accessor modifiers
2022 * class: Add support port accessor modifiers and error checking,
2023 define PropertyMethod.Define as virtual (not abstract anymore)
2024 * ecore.cs: Add checking for proeprties access with access modifiers
2025 * iterators.cs: Modify Accessor constructor call based in the modified
2027 2004-11-02 Ben Maurer <bmaurer@ximian.com>
2029 * expression.cs (StringConcat): Handle being called twice,
2030 as when we have a concat in a field init with more than two
2033 2004-11-02 Miguel de Icaza <miguel@ximian.com>
2035 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
2036 special case explicit implementations, we should always produce
2037 the .property or .event declaration.
2039 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
2040 since it will not return correct data if people use this
2041 unresolved in the presence of using statements (see test-313).
2043 * class.cs (MethodData.Define): If we are an explicit interface
2044 implementation, set the method name to the full name of the
2045 interface plus the name of the method.
2047 Notice that using the method.MethodName.GetFullName() does not
2048 work, as it will only contain the name as declared on the source
2049 file (it can be a shorthand in the presence of using statements)
2050 and not the fully qualifed type name, for example:
2054 class D : ICloneable {
2055 object ICloneable.Clone () {
2059 Would produce a method called `ICloneable.Clone' instead of
2060 `System.ICloneable.Clone'.
2062 * namespace.cs (Alias.Resolve): Use GetPartialName.
2064 2004-11-01 Marek Safar <marek.safar@seznam.cz>
2066 * cs-parser.jay: Add error 1055 report.
2068 2004-11-01 Miguel de Icaza <miguel@ximian.com>
2070 * assign.cs (Assign.DoResolve): Only do the transform of
2071 assignment into a New if the types are compatible, if not, fall
2072 through and let the implicit code deal with the errors and with
2073 the necessary conversions.
2075 2004-11-01 Marek Safar <marek.safar@seznam.cz>
2077 * cs-parser.jay: Add error 1031 report.
2079 * cs-tokenizer.cs: Add location for error 1038.
2081 2004-10-31 Marek Safar <marek.safar@seznam.cz>
2083 * cs-parser.jay: Add error 1016 report.
2085 2004-10-31 Marek Safar <marek.safar@seznam.cz>
2087 * cs-parser.jay: Add errors 1575,1611 report.
2089 2004-10-31 Marek Safar <marek.safar@seznam.cz>
2091 * cs-parser.jay: Add error 1001 report.
2093 2004-10-31 Marek Safar <marek.safar@seznam.cz>
2096 * attribute.cs (GetMarshal): Add method argument for
2097 caller identification.
2099 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
2100 agument for GetMarshal and RuntimeMissingSupport.
2102 2004-10-31 Marek Safar <marek.safar@seznam.cz>
2104 * attribute.cs (ExtractSecurityPermissionSet): Removed
2105 TypeManager.code_access_permission_type.
2107 * typemanager.cs: Removed TypeManager.code_access_permission_type.
2109 2004-10-27 Miguel de Icaza <miguel@ximian.com>
2111 * expression.cs (LocalVariableReference.DoResolveLValue): Check
2112 for obsolete use of a variable here. Fixes regression on errors
2113 cs0619-25 and cs0619-26.
2115 2004-10-27 Marek Safar <marek.safar@seznam.cz>
2117 Fix #62358, implemented security attribute encoding.
2119 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
2120 Tests permitted SecurityAction for assembly or other types.
2121 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
2122 data from SecurityPermissionAttribute to PermisionSet class.
2124 * class.cs (ApplyAttributeBuilder): Added special handling
2125 for System.Security.Permissions.SecurityAttribute based types.
2127 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
2128 special handling for System.Security.Permissions.SecurityAttribute
2131 * enum.cs (ApplyAttributeBuilder): Added special handling
2132 for System.Security.Permissions.SecurityAttribute based types.
2134 * parameter.cs (ApplyAttributeBuilder): Added special handling
2135 for System.Security.Permissions.SecurityAttribute based types.
2137 * rootcontext.cs: Next 2 core types.
2139 * typemanager.cs (TypeManager.security_permission_attr_type):
2140 Built in type for the SecurityPermission Attribute.
2141 (code_access_permission_type): Build in type.
2143 2004-10-17 Miguel de Icaza <miguel@ximian.com>
2145 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
2146 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
2147 all of this information into
2148 EmitContext.EmitCapturedVariableInstance.
2150 * codegen.cs (EmitCapturedVariableInstance): move here the
2151 funcionality of emitting an ldarg.0 in the presence of a
2152 remapping. This centralizes the instance emit code.
2154 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
2155 then emit a load of this: it means that we have reached the
2156 topmost ScopeInfo: the one that contains the pointer to the
2157 instance of the class hosting the anonymous method.
2159 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
2160 captures to the topmost CaptureContext.
2162 2004-10-12 Miguel de Icaza <miguel@ximian.com>
2164 * expression.cs (LocalVariableReference): Move the knowledge about
2165 the iterators into codegen's EmitCapturedVariableInstance.
2167 2004-10-11 Miguel de Icaza <miguel@ximian.com>
2169 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
2170 all code paths return a value from an anonymous method (it is the
2171 same as the 161 error, but for anonymous methods).
2173 2004-10-08 Miguel de Icaza <miguel@ximian.com>
2175 The introduction of anonymous methods in the compiler changed
2176 various ways of doing things in the compiler. The most
2177 significant one is the hard split between the resolution phase
2178 and the emission phases of the compiler.
2180 For instance, routines that referenced local variables no
2181 longer can safely create temporary variables during the
2182 resolution phase: they must do so from the emission phase,
2183 since the variable might have been "captured", hence access to
2184 it can not be done with the local-variable operations from the runtime.
2188 (Block.Flags): New flag `IsTopLevel' to indicate that this block
2189 is a toplevel block.
2191 (ToplevelBlock): A new kind of Block, these are the blocks that
2192 are created by the parser for all toplevel method bodies. These
2193 include methods, accessors and anonymous methods.
2195 These contain some extra information not found in regular blocks:
2196 A pointer to an optional CaptureContext (for tracking captured
2197 local variables and parameters). A pointer to the parent
2200 (Return.Resolve): Catch missmatches when returning a value from an
2201 anonymous method (error 1662).
2202 Invoke NeedReturnLabel from the Resolve phase instead of the emit
2205 (Break.Resolve): ditto.
2207 (SwitchLabel): instead of defining the labels during the
2208 resolution phase, we now turned the public ILLabel and ILLabelCode
2209 labels into methods called GetILLabelCode() and GetILLabel() that
2210 only define the label during the Emit phase.
2212 (GotoCase): Track the SwitchLabel instead of the computed label
2213 (its contained therein). Emit the code by using
2214 SwitchLabel.GetILLabelCode ().
2216 (LocalInfo.Flags.Captured): A new flag has been introduce to track
2217 whether the Local has been captured or not.
2219 (LocalInfo.IsCaptured): New property, used to tell whether the
2220 local has been captured.
2222 * anonymous.cs: Vastly updated to contain the anonymous method
2225 The main classes here are: CaptureContext which tracks any
2226 captured information for a toplevel block and ScopeInfo used to
2227 track the activation frames for various local variables.
2229 Each toplevel block has an optional capture context associated
2230 with it. When a method contains an anonymous method both the
2231 toplevel method and the anonymous method will create a capture
2232 context. When variables or parameters are captured, they are
2233 recorded on the CaptureContext that owns them, for example:
2237 MyDelegate d = delegate {
2242 Here `a' will be recorded as captured on the toplevel
2243 CapturedContext, the inner captured context will not have anything
2244 (it will only have data if local variables or parameters from it
2245 are captured in a nested anonymous method.
2247 The ScopeInfo is used to track the activation frames for local
2248 variables, for example:
2250 for (int i = 0; i < 10; i++)
2251 for (int j = 0; j < 10; j++){
2252 MyDelegate d = delegate {
2257 At runtime this captures a single captured variable `i', but it
2258 captures 10 different versions of the variable `j'. The variable
2259 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
2260 recorded on a child.
2262 The toplevel ScopeInfo will also track information like the `this'
2263 pointer if instance variables were referenced (this is necessary
2264 as the anonymous method lives inside a nested class in the host
2265 type of the method).
2267 (AnonymousMethod): Expanded to track the Toplevel, implement
2268 `AnonymousMethod.Compatible' to tell whether an anonymous method
2269 can be converted to a target delegate type.
2271 The routine now also produces the anonymous method content
2273 (AnonymousDelegate): A helper class that derives from
2274 DelegateCreation, this is used to generate the code necessary to
2275 produce the delegate for the anonymous method that was created.
2277 * assign.cs: API adjustments for new changes in
2278 Convert.ImplicitStandardConversionExists.
2280 * class.cs: Adjustments to cope with the fact that now toplevel
2281 blocks are of type `ToplevelBlock'.
2283 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
2284 insteda of standard blocks.
2286 Flag errors if params arguments are passed to anonymous methods.
2288 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
2289 `CurrentAnonymousMethod' which points to the current Anonymous
2290 Method. The variable points to the AnonymousMethod class that
2291 holds the code being compiled. It is set in the new EmitContext
2292 created for the anonymous method.
2294 (EmitContext.Phase): Introduce a variable and an enumeration to
2295 assist in enforcing some rules about when and where we are allowed
2296 to invoke certain methods (EmitContext.NeedsReturnLabel is the
2297 only one that enfonces this right now).
2299 (EmitContext.HaveCaptureInfo): new helper method that returns
2300 whether we have a CapturedContext initialized.
2302 (EmitContext.CaptureVariable): New method used to register that a
2303 LocalInfo must be flagged for capturing.
2305 (EmitContext.CapturedParameter): New method used to register that a
2306 parameters must be flagged for capturing.
2308 (EmitContext.CapturedField): New method used to register that a
2309 field must be flagged for capturing.
2311 (EmitContext.HaveCapturedVariables,
2312 EmitContext.HaveCapturedFields): Return whether there are captured
2313 variables or fields.
2315 (EmitContext.EmitMethodHostInstance): This is used to emit the
2316 instance for the anonymous method. The instance might be null
2317 (static methods), this (for anonymous methods that capture nothing
2318 and happen to live side-by-side with the current method body) or a
2319 more complicated expression if the method has a CaptureContext.
2321 (EmitContext.EmitTopBlock): Routine that drives the emission of
2322 code: it will first resolve the top block, then emit any metadata
2323 and then emit the code. The split is done so that we can extract
2324 any anonymous methods and flag any captured variables/parameters.
2326 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
2327 during this phase, the ILGenerator should not be used as labels
2328 and local variables declared here might not be accessible to any
2329 code that is part of an anonymous method.
2331 Exceptions to this include the temporary variables that are
2332 created by some statements internally for holding temporary
2335 (EmitContext.EmitMeta): New routine, in charge of emitting all the
2338 (EmitContext.TemporaryReturn): This method is typically called
2339 from the Emit phase, and its the only place where we allow the
2340 ReturnLabel to be defined other than the EmitMeta. The reason is
2341 that otherwise we would have to duplicate a lot of logic in the
2342 Resolve phases of various methods that today is on the Emit
2345 (EmitContext.NeedReturnLabel): This no longer creates the label,
2346 as the ILGenerator is not valid during the resolve phase.
2348 (EmitContext.EmitThis): Extended the knowledge in this class to
2349 work in anonymous methods in addition to iterators.
2351 (EmitContext.EmitCapturedVariableInstance): This emits whatever
2352 code is necessary on the stack to access the instance to a local
2353 variable (the variable will be accessed as a field).
2355 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
2356 EmitContext.EmitAddressOfParameter): Routines to support
2357 parameters (not completed at this point).
2359 Removals: Removed RemapLocal and RemapLocalLValue. We probably
2360 will also remove the parameters.
2362 * convert.cs (Convert): Define a `ConstantEC' which points to a
2363 null. This is just to prefity some code that uses
2364 ImplicitStandardConversion code and do not have an EmitContext
2367 The idea is to flag explicitly that at that point in time, it is
2368 known that the conversion will not trigger the delegate checking
2369 code in implicit conversions (which requires a valid
2372 Everywhere: pass new EmitContext parameter since
2373 ImplicitStandardConversionExists now requires it to check for
2374 anonymous method conversions.
2376 (Convert.ImplicitStandardConversionExists): If the type of an
2377 expression is the anonymous_method_type, and the type is a
2378 delegate, we invoke the AnonymousMethod.Compatible method to check
2379 whether an implicit conversion is possible.
2381 (Convert.ImplicitConversionStandard): Only do implicit method
2382 group conversions if the language level is not ISO_1.
2384 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
2385 MethodInfo for the Invoke method. used by Delegate and
2388 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
2389 method conversions if the target type is a delegate.
2391 Removed extra debugging nops.
2393 (LocalVariableReference): Turn the `local_info' into a public
2396 Add `prepared' field, the same hack used for FieldExprs to cope
2397 with composed assignments, as Local variables do not necessarily
2398 operate purely on the stack as they used to: they can be captured
2401 Add `temp' for a temporary result, like fields.
2403 Refactor DoResolve and DoResolveLValue into DoResolveBase.
2405 It now copes with Local variables that are captured and emits the
2406 proper instance variable to load it from a field in the captured
2409 (ParameterReference.DoResolveBase): During the resolve phase,
2410 capture parameters if we are in an anonymous method.
2412 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
2413 anonymous method, use the EmitContext helper routines to emit the
2414 parameter reference.
2416 * iterators.cs: Set RemapToProxy to true/false during the
2419 * parameters.cs (GetParameterByName): New helper method.
2421 * typemanager.cs (anonymous_method_type) a new type that
2422 represents an anonyous method. This is always an internal type,
2423 used as a fencepost to test against the anonymous-methodness of an
2426 2004-10-20 Marek Safar <marek.safar@seznam.cz>
2428 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
2430 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
2432 2004-11-10 Martin Baulig <martin@ximian.com>
2434 * expression.cs (Invocation.BetterFunction): If two methods have
2435 equal parameter types, but only one of them is generic, the
2436 non-generic one wins.
2437 (New.DoResolve): Don't set `is_struct' to false if we're a generic
2438 instance; just use `Type.IsValueType' to determine whether
2439 something is a struct or not.
2440 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
2441 so we can be called multiple times.
2443 2004-11-10 Martin Baulig <martin@ximian.com>
2445 * generic.cs (TypeParameter.DefineConstraints): New public method.
2446 (TypeParameter.CheckAccessLevel): Override this and return true.
2447 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
2448 override ResolveType() anymore.
2449 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
2451 2004-11-10 Martin Baulig <martin@ximian.com>
2453 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
2454 call DeclSpace.ResolveNestedType() on it.
2456 2004-11-10 Martin Baulig <martin@ximian.com>
2458 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
2459 non-null, call ParameterModifier() on it.
2461 2004-11-10 Martin Baulig <martin@ximian.com>
2464 (Iterators): Added `current_type' and `this_type' fields.
2465 (Iterators.DefineIterator): Create a new EmitContext and store it
2466 in `ec'; compute `this_type'.
2468 2004-11-10 Martin Baulig <martin@ximian.com>
2471 (TypeManager.IsPrivateAccessible): New public method.
2472 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
2474 2004-11-10 Martin Baulig <martin@ximian.com>
2476 * class.cs (TypeContainer.DefineType): Call
2477 TypeBuilder.DefineGenericParameters() before resolving the type
2479 (MethodData.parent_method): New protected field.
2480 (MethodData..ctor): Added `MethodInfo parent_method' argument.
2481 (MethodData.Define): Compute `parent_method'.
2484 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
2485 (MemberCore.GetClsCompliantAttributeValue): Likewise.
2486 (DeclSpace.ec): New protected field; store the EmitContext here.
2487 (DeclSpace.EmitContext): New public property.
2488 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
2489 (DeclSpace.ResolveNestedType): New public method.
2490 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
2491 (DeclSpace.NestedAccessible): Added `Type tb' argument.
2492 (DeclSpace.FamilyAccessible): Likewise.
2493 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
2494 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
2497 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
2500 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
2501 (Enum.Emit): Don't create a new EmitContext.
2503 2004-10-18 Martin Baulig <martin@ximian.com>
2505 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
2506 `Type' directly, but call ResolveType() on it.
2507 (Catch.Resolve): Likewise.
2508 (Foreach.Resolve): Likewise.
2510 2004-10-18 Martin Baulig <martin@ximian.com>
2512 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
2513 `Type' directly, but call ResolveType() on it.
2514 (Probe.DoResolve): Likewise.
2515 (ArrayCreation.LookupType): Likewise.
2516 (TypeOf.DoResolve): Likewise.
2517 (SizeOf.DoResolve): Likewise.
2519 2004-10-18 Raja R Harinath <rharinath@novell.com>
2521 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
2524 2004-10-17 John Luke <john.luke@gmail.com>
2526 * class.cs (Operator.GetSignatureForError): use CSharpName
2528 * parameter.cs (Parameter.GetSignatureForError): Returns
2529 correct name even if was not defined.
2531 2004-10-13 Raja R Harinath <rharinath@novell.com>
2534 * class.cs (TypeContainer.EmitContext): New property.
2535 (DefineNestedTypes): Create an emitcontext for each part.
2536 (MethodCore.DoDefineParameters): Use container's emitcontext.
2537 Pass type array to InternalParameters.
2538 (MemberBase.DoDefine): Use container's emitcontext.
2539 (FieldMember.Define): Likewise.
2540 (Event.Define): Likewise.
2541 (SetMethod.GetParameterInfo): Change argument to EmitContext.
2542 Pass type array to InternalParameters.
2543 (SetIndexerMethod.GetParameterInfo): Likewise.
2544 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
2545 * delegate.cs (Define): Pass emitcontext to
2546 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
2547 array to InternalParameters.
2548 * expression.cs (ParameterReference.DoResolveBase): Pass
2549 emitcontext to GetParameterInfo.
2550 (ComposedCast.DoResolveAsTypeStep): Remove check on
2551 ec.ResolvingTypeTree.
2552 * parameter.cs (Parameter.Resolve): Change argument to
2553 EmitContext. Use ResolveAsTypeTerminal.
2554 (Parameter.GetSignature): Change argument to EmitContext.
2555 (Parameters.ComputeSignature): Likewise.
2556 (Parameters.ComputeParameterTypes): Likewise.
2557 (Parameters.GetParameterInfo): Likewise.
2558 (Parameters.ComputeAndDefineParameterTypes): Likewise.
2559 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
2560 * support.cs (InternalParameters..ctor): Remove variant that takes
2562 * typemanager.cs (system_intptr_expr): New.
2563 (InitExpressionTypes): Initialize it.
2565 2004-10-12 Chris Toshok <toshok@ximian.com>
2567 * cs-parser.jay: fix location for try_statement and catch_clause.
2569 2004-10-18 Martin Baulig <martin@ximian.com>
2571 * class.cs (FieldMember.Define): Don't access the TypeExpr's
2572 `Type' directly, but call ResolveType() on it.
2573 (MemberBase.DoDefine): Likewise.
2575 * expression.cs (New.DoResolve): Don't access the TypeExpr's
2576 `Type' directly, but call ResolveType() on it.
2577 (ComposedCast.DoResolveAsTypeStep): Likewise.
2579 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
2580 `Type' directly, but call ResolveType() on it.
2582 2004-10-17 John Luke <john.luke@gmail.com>
2584 * class.cs (Operator.GetSignatureForError): use CSharpName
2586 * parameter.cs (Parameter.GetSignatureForError): Returns
2587 correct name even if was not defined.
2589 2004-10-13 Raja R Harinath <rharinath@novell.com>
2592 * class.cs (TypeContainer.EmitContext): New property.
2593 (DefineNestedTypes): Create an emitcontext for each part.
2594 (MethodCore.DoDefineParameters): Use container's emitcontext.
2595 Pass type array to InternalParameters.
2596 (MemberBase.DoDefine): Use container's emitcontext.
2597 (FieldMember.Define): Likewise.
2598 (Event.Define): Likewise.
2599 (SetMethod.GetParameterInfo): Change argument to EmitContext.
2600 Pass type array to InternalParameters.
2601 (SetIndexerMethod.GetParameterInfo): Likewise.
2602 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
2603 * delegate.cs (Define): Pass emitcontext to
2604 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
2605 array to InternalParameters.
2606 * expression.cs (ParameterReference.DoResolveBase): Pass
2607 emitcontext to GetParameterInfo.
2608 (ComposedCast.DoResolveAsTypeStep): Remove check on
2609 ec.ResolvingTypeTree.
2610 * parameter.cs (Parameter.Resolve): Change argument to
2611 EmitContext. Use ResolveAsTypeTerminal.
2612 (Parameter.GetSignature): Change argument to EmitContext.
2613 (Parameters.ComputeSignature): Likewise.
2614 (Parameters.ComputeParameterTypes): Likewise.
2615 (Parameters.GetParameterInfo): Likewise.
2616 (Parameters.ComputeAndDefineParameterTypes): Likewise.
2617 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
2618 * support.cs (InternalParameters..ctor): Remove variant that takes
2620 * typemanager.cs (system_intptr_expr): New.
2621 (InitExpressionTypes): Initialize it.
2623 2004-10-12 Chris Toshok <toshok@ximian.com>
2625 * cs-parser.jay: fix location for try_statement and catch_clause.
2627 2004-10-07 Raja R Harinath <rharinath@novell.com>
2629 More DeclSpace.ResolveType avoidance.
2630 * decl.cs (MemberCore.InUnsafe): New property.
2631 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
2632 with newly created EmitContext.
2633 (FieldMember.Define): Likewise.
2634 * delegate.cs (Delegate.Define): Likewise.
2635 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
2636 only if normal name-lookup fails.
2637 (TypeExpr.DoResolve): Enable error-checking.
2638 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
2639 (SizeOf.DoResolve): Likewise.
2640 (ComposedCast.DoResolveAsTypeStep): Likewise.
2641 (StackAlloc.DoResolve): Likewise.
2642 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
2643 (Block.Unsafe): New property.
2644 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
2645 (Unsafe): Set 'unsafe' flag of contained block.
2646 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
2647 (Fixed.Resolve): Likewise.
2648 (Catch.Resolve): Likewise.
2649 (Using.ResolveLocalVariableDecls): Likewise.
2650 (Foreach.Resolve): Likewise.
2652 2004-10-05 John Luke <john.luke@gmail.com>
2654 * cs-parser.jay: add location to error CS0175
2656 2004-10-04 Miguel de Icaza <miguel@ximian.com>
2658 * ecore.cs (Expression.Constantity): Add support for turning null
2661 * const.cs (Const.Define): Allow constants to be reference types
2662 as long as the value is Null.
2664 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
2666 * namespace.cs (NamespaceEntry.Using): No matter which warning
2667 level is set, check if this namespace name has already been added.
2669 2004-10-03 Ben Maurer <bmaurer@ximian.com>
2671 * expression.cs: reftype [!=]= null should always use br[true,false].
2674 2004-10-03 Marek Safar <marek.safar@seznam.cz>
2677 * attribute.cs: Enum conversion moved to
2678 GetAttributeArgumentExpression to be applied to the all
2681 2004-10-01 Raja R Harinath <rharinath@novell.com>
2683 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
2684 * class.c (TypeContainer.DefineType): Flag error if
2685 base types aren't accessible due to access permissions.
2686 * decl.cs (DeclSpace.ResolveType): Move logic to
2687 Expression.ResolveAsTypeTerminal.
2688 (DeclSpace.ResolveTypeExpr): Thin layer over
2689 Expression.ResolveAsTypeTerminal.
2690 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
2691 Refactor code into NestedAccess. Use it.
2692 (DeclSpace.NestedAccess): New.
2693 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
2694 argument to silence errors. Check access permissions.
2695 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
2696 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
2697 (Cast.DoResolve): Likewise.
2698 (New.DoResolve): Likewise.
2699 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
2700 (TypeOf.DoResolve): Likewise.
2702 * expression.cs (Invocation.BetterConversion): Return the Type of
2703 the better conversion. Implement section 14.4.2.3 more faithfully.
2704 (Invocation.BetterFunction): Make boolean. Make correspondence to
2705 section 14.4.2.2 explicit.
2706 (Invocation.OverloadResolve): Update.
2707 (Invocation): Remove is_base field.
2708 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
2709 (Invocation.Emit): Likewise.
2711 2004-09-24 Marek Safar <marek.safar@seznam.cz>
2713 * cs-parser.jay: Reverted 642 warning fix.
2715 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2718 * decl.cs (FindMemberWithSameName): Indexer can have more than
2721 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2723 * expression.cs (LocalVariableReference.DoResolveLValue):
2724 Do not report warning 219 for out values.
2725 (EmptyExpression.Null): New member to avoid extra allocations.
2727 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2729 * cs-parser.jay: Fix wrong warning 642 report.
2731 * cs-tokenizer.cs (CheckNextToken): New helper;
2732 Inspect next character if is same as expected.
2734 2004-09-23 Martin Baulig <martin@ximian.com>
2736 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
2737 (Convert.ImplicitReferenceConversionExists): Likewise.
2739 2004-11-09 Raja R Harinath <rharinath@novell.com>
2741 * Makefile (DISTFILES): Comment out a few missing files.
2743 2004-10-29 Raja R Harinath <rharinath@novell.com>
2745 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
2746 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
2747 (gmcs.exe): Invoke bootstrap-libs.
2748 (clean-local): Clean the net_2_0_bootstrap profile too.
2749 (PROGRAM_INSTALL_DIR): New.
2750 (install-local): Use it.
2752 2004-10-13 Martin Baulig <martin@ximian.com>
2754 * generic.cs (TypeManager.InflatedConstraints): New nested class.
2755 (TypeParameter.DefineType): If we're a method type parameter and
2756 that method is overriding something, "inflate" its constraints.
2758 2004-10-12 Martin Baulig <martin@ximian.com>
2760 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
2761 and have type arguments, create and resolve a ConstructedType.
2763 2004-10-12 Martin Baulig <martin@ximian.com>
2765 * decl.cs (MemberCache.FindMemberToOverride): Use
2766 TypeManager.IsEqual() to compare the parameters and Type.Equals()
2767 to compare the invocationType.
2769 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
2770 When comparing two type parameters, only do the signature-only
2771 comparision for method type parameters.
2773 2004-10-11 Martin Baulig <martin@ximian.com>
2775 * report.cs: Don't make --fatal abort on warnings, we have
2776 -warnaserror for that.
2778 2004-10-11 Martin Baulig <martin@ximian.com>
2781 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
2782 (TypeManager.IsEqual): Call ourself recursively instead of using
2785 2004-10-11 Martin Baulig <martin@ximian.com>
2787 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
2788 on our own type parameters, not on the ones we inherit from a containing
2791 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
2794 * generic.cs (TypeParameter.Define): We may only be called once.
2796 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
2797 instead of TypeManager.IsEqual().
2799 2004-09-28 Martin Baulig <martin@ximian.com>
2802 (GenericConstraints.EffectiveBaseClass): New public property.
2803 (TypeParameter.GenericConstraints): New public property.
2804 (ConstructedType.CheckConstraints): Improved.
2806 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
2807 (Convert.TypeParameterConversion): New private method; use this in
2808 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
2809 for all conversions related to type parameters.
2811 2004-09-24 Martin Baulig <martin@ximian.com>
2813 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
2814 type parameter conversions for type parameters which are known to
2817 2004-09-24 Martin Baulig <martin@ximian.com>
2819 * generic.cs (GenericConstraints): Added `IsReferenceType' and
2820 `IsValueType' properties.
2822 * support.cs (ReflectionConstraints): Use
2823 Type.GetGenericParameterConstraints() instead of the old hack.
2825 2004-09-24 Martin Baulig <martin@ximian.com>
2827 * generic.cs (GenericConstraints): Moved here and made it an
2830 * support.cs (GenericConstraints): Moved to generic.cs.
2832 2004-09-24 Martin Baulig <martin@ximian.com>
2835 (ReflectionConstraints): Un-nested this class and made it public.
2838 (TypeManager.GetTypeParameterConstraints): New public method.
2839 (TypeManager.HasConstructorConstraint): Use the attributes.
2841 2004-09-24 Martin Baulig <martin@ximian.com>
2843 * support.cs (GenericConstraints): Replaced `HasConstructor',
2844 `IsReferenceType' and `IsValueType' with `Attributes'.
2845 (ReflectionParameters.ReflectionConstraints): Removed the Create()
2846 method and made the .ctor public.
2848 * generic.cs (Constraints.Attributes): New public property.
2849 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
2850 `IsReferenceType' -> `HasReferenceTypeConstraint' and
2851 `IsValueType' -> `HasValueTypeConstraint'.
2853 2004-09-23 Martin Baulig <martin@ximian.com>
2855 * generic.cs (Constraints): Reflect latest runtime changes.
2857 2004-09-23 Martin Baulig <martin@ximian.com>
2859 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
2860 (Convert.ImplicitReferenceConversionExists): Likewise.
2862 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2864 * class.cs (Operator.Define): Add error 448 and 559 report.
2866 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2868 * class.cs (MemberBase.IsTypePermitted): New protected
2869 method for checking error CS0610.
2871 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2873 * class.cs (TypeContainer.HasExplicitLayout): New property
2874 Returns whether container has StructLayout attribute set Explicit.
2875 (FieldMember): New abstract class for consts and fields.
2876 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
2877 (Field): Reuse FieldMember.
2879 * const.cs (Const): Reuse FieldMember.
2881 * rootcontext.cs: EmitConstants call moved to class.
2883 2004-09-22 Martin Baulig <martin@ximian.com>
2885 Marek and me just fixed one of our oldest bugs: #28562 :-)
2887 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
2889 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
2890 we're an EnumConstant, just return that.
2891 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
2892 an EnumConstant. In this case, we need to use GetValueAsEnumType()
2893 to get the value which'll actually be written into the attribute.
2894 However, we have to use GetValue() to access the attribute's value
2897 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2899 * constant.cs (Constant.IsNegative): New abstract property
2902 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
2903 (StackAlloc.DoResolve): Reused IsNegative.
2905 2004-09-22 Martin Baulig <martin@ximian.com>
2907 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
2908 public method; like LookupTypeContainer, but also works for
2911 * report.cs (Report.SymbolRelatedToPreviousError): Use
2912 TypeManager.LookupGenericTypeContainer().
2914 2004-09-22 Martin Baulig <martin@ximian.com>
2916 Thanks to Peter Sestoft for this bug report.
2918 * expression.cs (Conditional): If both the `trueExpr' and the
2919 `falseExpr' is a NullLiteral, return a NullLiteral.
2921 2004-09-22 Martin Baulig <martin@ximian.com>
2923 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
2924 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
2925 for the "get_Current" call.
2927 2004-09-21 Martin Baulig <martin@ximian.com>
2929 * convert.cs (Convert.ImplicitReferenceConversion): When
2930 converting to an interface type, first check whether we're
2931 converting from a reference type.
2933 2004-09-14 Martin Baulig <martin@ximian.com>
2935 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
2937 2004-09-14 Marek Safar <marek.safar@seznam.cz>
2940 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
2941 called and is obsolete then this member suppress message
2942 when call is inside next [Obsolete] method or type.
2944 * expression.cs: Use TestObsoleteMethodUsage member.
2946 2004-09-14 Martin Baulig <martin@ximian.com>
2948 * genericparser.cs: Removed.
2950 2004-09-13 Marek Safar <marek.safar@seznam.cz>
2952 * class.cs (MethodCore.CheckBase): Fix bug #65757.
2954 2004-09-12 Marek Safar <marek.safar@seznam.cz>
2956 * attribute.cs (Attribute.Resolve): Add error 653 report.
2958 * class.cs (Class.ApplyAttributeBuilder): Add error 641
2960 (Method.ApplyAttributeBuilder): Add error 685 report.
2961 (Operator.Define): Add error 564 report.
2963 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
2965 * expression.cs (Invocation.DoResolve): Add error
2968 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
2971 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2973 * class.cs (ConstructorInitializer.Resolve):
2974 Wrong error number (515->516).
2976 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2978 * class.cs (Indexer.Define): Add error 631 report.
2980 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2982 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
2984 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2986 * expression.cs (Probe.DoResolve): Add error CS0241 report.
2988 2004-09-10 Marek Safar <marek.safar@seznam.cz>
2990 * cs-parser.jay: Added error CS0241 report.
2992 2004-09-10 Raja R Harinath <rharinath@novell.com>
2994 * cs-parser.jay (fixed_statement): Introduce a scope for the
2995 declaration in the 'fixed' statement.
2997 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2999 * cs-parser.jay: Added CS0230 error report.
3001 2004-09-09 Marek Safar <marek.safar@seznam.cz>
3003 * cs-parser.jay: Added errors CS0231 and CS0257 report.
3005 2004-09-09 Marek Safar <marek.safar@seznam.cz>
3007 * expression.cs (Argument.Resolve): Added error CS0192 and
3010 2004-09-09 Marek Safar <marek.safar@seznam.cz>
3012 C# 2.0 #pragma warning feature
3014 * cs-tokenizer.cs (PreProcessPragma): New method;
3015 Handles #pragma directive.
3017 * report.cs (WarningRegions): New class; Support
3018 class for #pragma warning directive. It tests whether
3019 warning is enabled for a given line.
3021 2004-09-08 Miguel de Icaza <miguel@ximian.com>
3023 * const.cs: Add more descriptive error report, tahnks to
3026 2004-09-08 Marek Safar <marek.safar@seznam.cz>
3028 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
3030 2004-09-07 Miguel de Icaza <miguel@ximian.com>
3032 * expression.cs: Apply patch from Ben: Remove dead code from
3033 ArrayCreation, and remove the TurnintoConstant call in const.cs,
3034 as that code just threw an exception anwyays.
3036 * const.cs: Remove the call to the turnintoconstant, for details
3039 * literal.cs: The type of the null-literal is the null type; So
3040 we use a placeholder type (literal.cs:System.Null, defined here)
3043 * expression.cs (Conditional.DoResolve): Remove some old code that
3044 is no longer needed, conversions have been fixed.
3046 (ArrayCreationExpression.DoResolve): Return false if we fail to
3047 resolve the inner expression.
3049 2004-09-07 Raja R Harinath <rharinath@novell.com>
3052 * cs-parser.jay (delegate_declaration): Record a delegate
3053 declaration as a type declaration.
3054 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
3056 2004-09-06 Miguel de Icaza <miguel@ximian.com>
3058 * parameter.cs: Do not crash if the type can not be resolved.
3060 * expression.cs: Report errors with unsafe pointers, fixes #64896
3062 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
3064 * expression.cs: Pointer arith always needs to do a conv.i
3065 if the operand is a long. fix 65320
3067 2004-09-04 Marek Safar <marek.safar@seznam.cz>
3069 Fixed cs0619-37.cs, cs0619-38.cs
3071 * enum.cs (GetObsoleteAttribute): Removed.
3073 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
3074 on Enum member is double staged. The first is tested member
3077 2004-09-04 Marek Safar <marek.safar@seznam.cz>
3079 Fixed #56986, #63631, #65231
3081 * class.cs: (TypeContainer.AddToMemberContainer): New method,
3082 adds member to name container.
3083 (TypeContainer.AddToTypeContainer): New method, adds type to
3085 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
3086 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
3087 AddOperator): Simplified by reusing AddToMemberContainer.
3088 (TypeContainer.UserDefinedStaticConstructor): Changed to property
3090 (Method.CheckForDuplications): Fixed implementation to test all
3092 (MemberBase): Detection whether member is explicit interface
3093 implementation is now in constructor.
3094 (MemberBase.UpdateMemberName): Handles IndexerName.
3095 (Accessor): Changed to keep also location information.
3096 (AbstractPropertyEventMethod): Is derived from MemberCore.
3097 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
3098 will be emited or not.
3099 (PropertyBase.AreAccessorsDuplicateImplementation):
3100 Tests whether accessors are not in collision with some method.
3101 (Operator): Is derived from MethodCore to simplify common
3104 * decl.cs (Flags.TestMethodDuplication): Test for duplication
3106 (DeclSpace.AddToContainer): Adds the member to defined_names
3107 table. It tests for duplications and enclosing name conflicts.
3109 * enum.cs (EnumMember): Clean up to reuse the base structures
3111 2004-09-03 Martin Baulig <martin@ximian.com>
3113 Merged latest changes into gmcs. Please keep this comment in
3114 here, it makes it easier for me to see what changed in MCS since
3115 the last time I merged.
3117 2004-09-03 Martin Baulig <martin@ximian.com>
3119 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
3120 into TypeContainer, to make partial classes work again.
3122 2004-09-03 Martin Baulig <martin@ximian.com>
3124 * rootcontext.cs (RootContext.V2): Removed.
3126 2004-03-23 Martin Baulig <martin@ximian.com>
3128 * expression.cs (Invocation.OverloadResolve): Added `bool
3129 may_fail' argument and use it instead of the Location.IsNull() hack.
3131 2004-09-09 Martin Baulig <martin@ximian.com>
3133 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
3135 2004-09-09 Martin Baulig <martin@ximian.com>
3137 * generic.cs (TypeParameter.DefineType): Added support for
3138 explicit interface methods.
3140 2004-09-09 Martin Baulig <martin@ximian.com>
3142 * README.Changes: New document. Started to list important changes
3143 between MCS and GMCS here.
3145 2004-09-08 Martin Baulig <martin@ximian.com>
3148 (TypeContainer.CheckRecursiveDefinition): New protected method.
3149 (TypeContainer.DefineType): Move the CS0146 check into
3150 CheckRecursiveDefinition().
3152 2004-09-06 Martin Baulig <martin@ximian.com>
3154 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
3155 types for the constructor constraint.
3157 2004-09-03 Martin Baulig <martin@ximian.com>
3159 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
3160 into TypeContainer, to make partial classes work again.
3162 2004-09-03 Martin Baulig <martin@ximian.com>
3164 * rootcontext.cs (RootContext.V2): Removed.
3166 2004-03-23 Martin Baulig <martin@ximian.com>
3168 * expression.cs (Invocation.OverloadResolve): Added `bool
3169 may_fail' argument and use it instead of the Location.IsNull() hack.
3171 2004-09-03 Martin Baulig <martin@ximian.com>
3173 Merged latest changes into gmcs. Please keep this comment in
3174 here, it makes it easier for me to see what changed in MCS since
3175 the last time I merged.
3177 2004-09-03 Raja R Harinath <rharinath@novell.com>
3180 * expression.cs (BetterConversion): Don't allow either conversion
3181 to be null. Remove redundant implicit conversion test when 'q ==
3182 null' -- when this function is invoked, we already know that the
3183 implicit conversion exists.
3184 (BetterFunction): Assume that 'best' is non-null. Remove
3185 redundant reimplementation of IsApplicable when 'best' is null.
3186 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
3187 number of arguments.
3188 (IsAncestralType): Extract from OverloadResolve.
3189 (OverloadResolve): Make robust to the MethodGroupExpr being
3190 unsorted. Implement all the logic of Section 14.5.5.1, and
3191 support overloading of methods from multiple applicable types.
3192 Clean up logic somewhat. Don't pass null methods to BetterFunction.
3194 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
3195 (RealError, Warning): Append type of report to related symbol.
3197 2004-09-03 Marek Safar <marek.safar@seznam.cz>
3199 * enum.cs: Fixed CLS-Compliance checks for enum members.
3200 Error tests cs3008-8.cs, cs3014-8.cs
3202 2004-09-02 Marek Safar <marek.safar@seznam.cz>
3204 Fixed bug #62342, #63102
3205 * class.cs: ImplementIndexer uses member.IsExplicitImpl
3206 like ImplementMethod.
3208 2004-09-02 Marek Safar <marek.safar@seznam.cz>
3210 * attribute.cs (Attribute.GetAttributeArgumentExpression):
3213 2004-09-02 Martin Baulig <martin@ximian.com>
3215 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
3216 TypeManager.GetArgumentTypes() rather than calling GetParameters()
3219 2004-09-01 Marek Safar <marek.safar@seznam.cz>
3221 C# 2.0 Static classes implemented
3223 * class.cs (TypeContainer): instance_constructors,
3224 initialized_fields, initialized_static_fields,
3225 default_constructor, base_inteface_types are protected to be
3226 accessible from StaticClass.
3227 (TypeContainer.DefineDefaultConstructor): New virtual method
3228 for custom default constructor generating
3229 (StaticClass): New class to handle "Static classes" feature.
3231 * cs-parser.jay: Handle static keyword on class like instance
3234 * driver.cs: Added "/langversion" command line switch with two
3235 options (iso-1, default).
3237 2004-08-31 Marek Safar <marek.safar@seznam.cz>
3239 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
3241 2004-08-31 Miguel de Icaza <miguel@ximian.com>
3243 * delegate.cs: Style.
3245 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
3247 * delegate.cs: Add seperate instance expr field for miguel.
3249 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
3251 * PointerArithmetic (Resolve): make sure we are not doing
3252 pointer arith on void*. Also, make sure we are resolved
3253 by not setting eclass until resolve.
3255 All callers: Make sure that PointerArithmetic gets resolved.
3257 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
3259 * ArrayCreation (LookupType): If the type does not resolve
3260 to an array, give an error.
3262 2004-08-27 Marek Safar <marek.safar@seznam.cz>
3264 * statement.cs (Try.Resolve): Fixed bug #64222
3266 2004-08-27 Martin Baulig <martin@ximian.com>
3269 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
3272 2004-08-26 Marek Safar <marek.safar@seznam.cz>
3274 * ecore.cs (Constantify): Get underlying type via
3275 System.Enum.GetUnderlyingType to avoid StackOverflow on the
3276 Windows in special cases.
3278 2004-08-26 Marek Safar <marek.safar@seznam.cz>
3280 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
3281 for obtaining also private methods.
3282 (GetRemoveMethod): Used GetRemoveMethod (true)
3283 for obtaining also private methods.
3285 2004-09-02 Martin Baulig <martin@ximian.com>
3287 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
3288 TypeManager.GetArgumentTypes() rather than calling GetParameters()
3291 2004-08-27 Martin Baulig <martin@ximian.com>
3294 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
3297 2004-08-25 Martin Baulig <martin@ximian.com>
3299 * support.cs (ReflectionParameters..ctor): If this is a generic
3300 method, retrieve and store its type parameters.
3301 (InternalParameters..ctor): Added `TypeParameter[]' argument.
3302 (ReflectionParameters.GenericConstraints): The argument specifies
3303 the type parameter, not the method parameter.
3304 (InternalParameters.GenericConstraints): Likewise.
3306 * generic.cs (TypeParameter.DefineType): Correctly handle
3307 constraints wrt. generic methods in interfaces and their
3310 2004-08-24 Martin Baulig <martin@ximian.com>
3312 * generic.cs (TypeParameter.IsSubclassOf): New public method.
3313 (Constraints.IsSubclassOf): New internal method.
3315 * typemanager.cs (TypeManager.FindMembers): Added special support
3316 for GenericTypeParameterBuilder's.
3317 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
3320 2004-08-24 Martin Baulig <martin@ximian.com>
3323 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
3324 this for accessibility checks.
3325 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
3326 IsNestedFamilyAccessible.
3327 (TypeManager.IsSubclassOf): New method, do what the name actually
3330 2004-08-24 Martin Baulig <martin@ximian.com>
3332 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
3333 as a SimpleName, include the generic arity.
3335 2004-08-24 Martin Baulig <martin@ximian.com>
3337 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
3338 MethodAttributes.HideBySig for operators.
3340 2004-08-23 Martin Baulig <martin@ximian.com>
3342 Back to the old error reporting system :-)
3344 * report.cs (Message): Removed.
3345 (Report.MessageData, ErrorData, WarningData): Removed.
3346 (Report.Error, Warning): Back to the old system.
3348 2004-08-23 Martin Baulig <martin@ximian.com>
3350 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
3352 * class.cs (TypeContainer.ParentContainer): New public virtual
3353 method; replaces the explicit interface implementation.
3354 (ClassPart.ParentContainer): Override.
3356 2004-08-23 Martin Baulig <martin@ximian.com>
3358 * statement.cs (Switch): Added support for constant switches; see
3359 #59428 or test-285.cs.
3361 2004-08-22 Marek Safar <marek.safar@seznam.cz>
3364 * statement.cs (GetEnumeratorFilter): Removed useless
3365 logic because C# specs is strict. GetEnumerator must be
3368 2004-08-22 Martin Baulig <martin@ximian.com>
3370 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3371 a switch and may break, reset the barrier. Fixes #59867.
3373 2004-08-22 Marek Safar <marek.safar@seznam.cz>
3375 CLS-Compliance speed up (~5% for corlib)
3377 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
3378 New method. Tests container for CLS-Compliant names
3380 * class.cs (TypeContainer.VerifyClsName): New method.
3381 Checks whether container name is CLS Compliant.
3382 (Constructor): Implements IMethodData.
3384 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
3385 low-case table for CLS Compliance test.
3386 (MemberCache.VerifyClsParameterConflict): New method.
3387 Checks method parameters for CS3006 error.
3389 * enum.cs (EnumMember): Is derived from MemberCore.
3390 (Enum.VerifyClsName): Optimized for better performance.
3392 2004-08-06 Marek Safar <marek.safar@seznam.cz>
3394 * report.cs: Renamed Error_T to Error and changed all
3397 2004-08-06 Marek Safar <marek.safar@seznam.cz>
3399 * class.cs (TypeContainer.IndexerArrayList): New inner class
3400 container for indexers.
3401 (TypeContainer.DefaultIndexerName): New constant for default
3402 indexer name. Replaced all "Item" with this constant.
3403 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
3405 * typemanager.cs (TypeManager.default_member_ctor): Cache here
3406 DefaultMemberAttribute constructor.
3408 2004-08-05 Martin Baulig <martin@ximian.com>
3410 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
3413 2004-08-05 Marek Safar <marek.safar@seznam.cz>
3415 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
3416 multi platforms problem.
3418 * compiler.csproj: Included shared files.
3420 2004-08-04 Marek Safar <marek.safar@seznam.cz>
3422 Fix bug 60333, 55971 in the more general way
3423 * attribute.cs (Attribute.GetAttributeArgumentExpression):
3424 Added arg_type argument for constant conversion.
3425 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
3427 2004-08-04 Marek Safar <marek.safar@seznam.cz>
3430 * class.cs (TypeContainer ): New inner classes MethodArrayList,
3431 OperatorArrayList, MethodCoreArrayList for typecontainer
3432 containers. Changed class member types to these new types.
3433 (MethodArrayList.DefineMembers): Added test for CS0659.
3435 2004-08-04 Miguel de Icaza <miguel@ximian.com>
3437 * cfold.cs: Synchronize the folding with the code in expression.cs
3438 Binary.DoNumericPromotions for uint operands.
3440 * attribute.cs: Revert patch from Raja, it introduced a regression
3441 while building Blam-1.2.1 (hard to isolate a test case).
3443 2004-08-04 Marek Safar <marek.safar@seznam.cz>
3447 (TypeContainer.Define): Renamed to DefineContainerMembers because of
3449 (MethodCore.parent_method): New member. The method we're overriding
3450 if this is an override method.
3451 (MethodCore.CheckBase): Moved from Method class and made common.
3452 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
3454 (MethodCore.CheckForDuplications): New abstract method. For custom
3455 member duplication search in a container
3456 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
3457 method and its return type.
3458 (Event.conflict_symbol): New member. Symbol with same name in the
3462 (MemberCache.FindMemberWithSameName): New method. The method
3463 is looking for conflict with inherited symbols.
3465 2004-08-04 Martin Baulig <martin@ximian.com>
3467 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
3469 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
3471 2004-08-03 Marek Safar <marek.safar@seznam.cz>
3473 * report.cs (Message): New enum for better error, warning reference in
3475 (MessageData): New inner abstract class. It generally handles printing of
3476 error and warning messages.
3477 Removed unused Error, Warning, Message methods.
3479 2004-08-03 Marek Safar <marek.safar@seznam.cz>
3481 Fix for cs0592-8.cs test
3483 (Attributable.ValidAttributeTargets): Made public.
3484 (Attribute.ExplicitTarget): New member for explicit target value.
3485 (Attribute.CheckTargets): Now we translate explicit attribute
3486 target to Target here.
3488 2004-08-03 Ben Maurer <bmaurer@ximian.com>
3490 * ecore.cs (MethodGroupExpr): new IsBase property.
3492 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
3494 * delegate.cs (DelegateCreation): store a MethodGroupExpr
3495 rather than an instance expr.
3497 (DelegateCreation.Emit): Use the method group rather than
3498 the instance expression. Also, if you have base.Foo as the
3499 method for a delegate, make sure to emit ldftn, not ldftnvirt.
3501 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
3503 (NewDelegate.DoResolve): Only check for the existance of Invoke
3504 if the method is going to be needed. Use MethodGroupExpr.
3506 (NewDelegate.Emit): Remove, DelegateCreation implements this.
3508 * expression.cs: For pointer arith., make sure to use
3509 the size of the type, not the size of the pointer to
3512 2004-08-03 Marek Safar <marek.safar@seznam.cz>
3515 * class.cs (Class): Added error CS0502 test.
3517 2004-08-03 John Luke <jluke@cfl.rr.com>
3518 Raja R Harinath <rharinath@novell.com>
3521 * attribute.cs (Attribute.complained_before): New flag.
3522 (Attribute.ResolveType, Attribute.Resolve),
3523 (Attribute.DefinePInvokeMethod): Set it.
3524 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
3526 2004-08-03 Martin Baulig <martin@ximian.com>
3528 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
3529 use a user-defined operator; we still need to do numeric
3530 promotions in case one argument is a builtin type and the other
3531 one has an implicit conversion to that type. Fixes #62322.
3533 2004-08-18 Martin Baulig <martin@ximian.com>
3535 * class.cs (Method.Define): Use the correct method name when
3536 creating the MethodBuilder for a generic method.
3538 2004-08-17 Martin Baulig <martin@ximian.com>
3540 * generic.cs (Constraints): Support type parameter constraints.
3542 2004-08-16 Martin Baulig <martin@ximian.com>
3544 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
3545 (Token.GENERIC_DIMENSION): New token; this is returned if we
3546 encounter an unbound generic type in a typeof() expression.
3548 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
3549 this token is only generated while parsing a typeof() expression.
3550 (typeof_expression): Removed the old unbound_type hack.
3552 * generic.cs (TypeArguments.IsUnbound): New public property.
3554 * decl.cs (MemberName): Added support for unbound types.
3556 2004-08-14 Martin Baulig <martin@ximian.com>
3559 (TypeManager.IsEqualGenericInstance): New static method.
3560 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
3561 just used to check accessibility, so follow the rules of 26.1.6.
3563 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
3564 ConstructedType instead of a TypeExpression if we have type arguments.
3566 * cs-parser.jay (typeof_expression): Support unbound generic types.
3568 * ecore.cs (UnboundTypeExpression): New public class.
3570 2004-08-12 Martin Baulig <martin@ximian.com>
3572 * typemanager.cs (TypeManager.IsNestedChildOf): Use
3573 TypeManager.IsEqual() rather than `=='.
3575 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
3576 generic instances as well.
3578 2004-08-12 Martin Baulig <martin@ximian.com>
3580 * expression.cs (Invocation.InferType): We can only infer method
3581 type parameters. Fixes #62647.
3583 2004-08-11 Martin Baulig <martin@ximian.com>
3585 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
3586 before resolving the base classes.
3588 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3590 * Makefile: install .mdb file too.
3592 2004-08-05 Martin Baulig <martin@ximian.com>
3594 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
3595 initializer, the current type is just the TypeBuilder, not the
3596 instantiated generic type.
3597 (FieldExpr.IsFieldInitializer): New public property.
3599 2004-08-04 Martin Baulig <martin@ximian.com>
3601 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
3603 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
3605 2004-08-03 Martin Baulig <martin@ximian.com>
3607 * class.cs (MethodData.Define): If we're an explicit
3608 implementation, remove the generic arity from the type name.
3610 2004-08-03 Martin Baulig <martin@ximian.com>
3612 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
3613 use a user-defined operator; we still need to do numeric
3614 promotions in case one argument is a builtin type and the other
3615 one has an implicit conversion to that type. Fixes #62322.
3617 2004-08-02 Martin Baulig <martin@ximian.com>
3619 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
3621 (TypeContainer.GetClassBases): Return the unexpanded list of
3622 interfaces; we expand them later.
3623 (TypeContainer.DefineType): After creating the TypeBuilder, call
3624 TypeManager.ExpandInterfaces() to get an expanded and resolved
3627 * ecore.cs (TypeExpr.GetInterfaces): Removed
3629 * generics.cs (Constraints.InterfaceConstraints): Remove.
3630 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
3631 register the interface constraints.
3634 (TypeManager.AddUserType): Removed the `ifaces' argument.
3635 (TypeManager.AddTypeParameter): Likewise.
3636 (TypeManager.AddUserInterface): Removed, was unused.
3637 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
3638 `TypeExpr[]' array for the interfaces.
3639 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
3640 has been defined, returns a list of the resolved interfaces types.
3641 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
3642 (TypeManager.GetExplicitInterfaces): Likewise.
3644 2004-08-02 Martin Baulig <martin@ximian.com>
3646 * expression.cs (Invocation.EmitCall): If we're invoking a method
3647 on a type parameter, use the new `Constrained' prefix opcode.
3649 2004-08-02 Martin Baulig <martin@ximian.com>
3651 * statement.cs (LocalInfo.Flags): Added `IsThis'.
3652 (LocalInfo.IsThis): New public property.
3653 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
3655 2004-08-01 Martin Baulig <martin@ximian.com>
3657 * class.cs (TypeContainer.GetClassBases): Don't set the default
3658 here since we may get called from GetPartialBases().
3659 (TypeContainer.DefineType): If GetClassBases() didn't return a
3660 parent, use the default one.
3662 2004-07-30 Martin Baulig <martin@ximian.com>
3664 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
3666 * class.cs (SourceMethod): New public class, derive from the
3667 symbol writer's ISourceMethod.
3668 (Method): Use the new symbol writer API.
3670 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
3671 as argument and use the new symbol writer.
3674 (SourceFile): Implement the symbol writer's ISourceFile.
3675 (Location.SymbolDocument): Removed.
3676 (Location.SourceFile): New public property.
3678 * symbolwriter.cs: Use the new symbol writer API.
3680 2004-07-30 Raja R Harinath <rharinath@novell.com>
3682 * Makefile (install-local): Remove. Functionality moved to
3685 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
3687 * Makefile: Install mcs.exe.config file together with mcs.exe.
3688 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
3689 correct runtime version.
3691 2004-07-25 Martin Baulig <martin@ximian.com>
3694 (TypeContainer.RegisterOrder): Removed, this was unused.
3695 (TypeContainer, interface_order): Removed.
3696 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
3697 TypeContainer as argument since we can also be called with a
3698 `PartialContainer' for a partial class/struct/interface.
3699 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
3700 of checking whether we're an `Interface' - we could be a
3702 (PartialContainer.Register): Override; call
3703 AddClass()/AddStruct()/AddInterface() on our parent.
3705 * cs-parser.jay (interface_member_declaration): Add things to the
3706 `current_container', not the `current_class'.
3708 * rootcontext.cs (RegisterOrder): The overloaded version which
3709 takes an `Interface' was unused, removed.
3711 * typemanager.cs (TypeManager.LookupInterface): Return a
3712 `TypeContainer', not an `Interface'.
3713 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
3714 contain a `PartialContainer' for an interface, so check it's
3715 `Kind' to figure out what it is.
3717 2004-07-25 Martin Baulig <martin@ximian.com>
3719 * class.cs (Class.DefaultTypeAttributes): New public constant.
3720 (Struct.DefaultTypeAttributes): Likewise.
3721 (Interface.DefaultTypeAttributes): Likewise.
3722 (PartialContainer.TypeAttr): Override this and add the
3723 DefaultTypeAttributes.
3725 2004-07-25 Martin Baulig <martin@ximian.com>
3727 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
3728 we can just use the `Parent' field instead.
3730 2004-07-25 Martin Baulig <martin@ximian.com>
3732 * class.cs (TypeContainer.Emit): Renamed to EmitType().
3734 2004-07-25 Martin Baulig <martin@ximian.com>
3736 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
3737 our parts before defining any methods.
3738 (TypeContainer.VerifyImplements): Make this virtual.
3739 (ClassPart.VerifyImplements): Override and call VerifyImplements()
3740 on our PartialContainer.
3742 2004-07-25 Martin Baulig <martin@ximian.com>
3744 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
3746 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
3747 argument, we can just use the `Parent' field instead.
3750 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
3751 (MemberBase.DoDefine): Likewise.
3753 2004-07-24 Martin Baulig <martin@ximian.com>
3755 * decl.cs (MemberCore.Parent): New public field.
3756 (DeclSpace.Parent): Moved to MemberCore.
3758 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
3759 (MemberBase.ctor): Added TypeContainer argument, pass it to our
3761 (FieldBase, Field, Operator): Likewise.
3762 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
3763 (EventField, Event): Likewise.
3765 2004-07-23 Martin Baulig <martin@ximian.com>
3767 * class.cs (PartialContainer): New public class.
3768 (ClassPart): New public class.
3769 (TypeContainer): Added support for partial classes.
3770 (TypeContainer.GetClassBases): Splitted some of the functionality
3771 out into GetNormalBases() and GetPartialBases().
3773 * cs-tokenizer.cs (Token.PARTIAL): New token.
3774 (Tokenizer.consume_identifier): Added some hacks to recognize
3775 `partial', but only if it's immediately followed by `class',
3776 `struct' or `interface'.
3778 * cs-parser.jay: Added support for partial clases.
3780 2004-07-23 Martin Baulig <martin@ximian.com>
3782 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
3783 a `DeclSpace' and also made it readonly.
3784 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
3785 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
3786 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
3788 * cs-parser.jay: Pass the `current_class', not the
3789 `current_container' (at the moment, this is still the same thing)
3790 to a new Method, Property, Event, Indexer or Constructor.
3792 2004-07-23 Martin Baulig <martin@ximian.com>
3794 * cs-parser.jay (CSharpParser): Added a new `current_class' field
3795 and removed the `current_interface' one.
3796 (struct_declaration, class_declaration, interface_declaration):
3797 Set `current_class' to the newly created class/struct/interface;
3798 set their `Bases' and call Register() before parsing their body.
3800 2004-07-23 Martin Baulig <martin@ximian.com>
3802 * class.cs (Kind): New public enum.
3803 (TypeContainer): Made this class abstract.
3804 (TypeContainer.Kind): New public readonly field.
3805 (TypeContainer.CheckDef): New public method; moved here from
3807 (TypeContainer.Register): New public abstract method.
3808 (TypeContainer.GetPendingImplementations): New public abstract
3810 (TypeContainer.GetClassBases): Removed the `is_class' and
3811 `is_iface' parameters.
3812 (TypeContainer.DefineNestedTypes): Formerly known as
3814 (ClassOrStruct): Made this class abstract.
3816 * tree.cs (RootTypes): New public type.
3818 2004-07-20 Martin Baulig <martin@ximian.com>
3820 * tree.cs (Tree.RecordNamespace): Removed.
3821 (Tree.Namespaces): Removed.
3823 * rootcontext.cs (RootContext.IsNamespace): Removed.
3825 * cs-parser.jay (namespace_declaration): Just create a new
3826 NamespaceEntry here.
3828 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
3830 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
3831 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
3832 entry to make sure it runs in the correct runtime version.
3834 2004-07-18 Martin Baulig <martin@ximian.com>
3836 * generic.cs (ConstructedType.CheckConstraints): Improved
3837 constraints checking.
3839 2004-07-18 Martin Baulig <martin@ximian.com>
3841 * expression.cs (Invocation.BetterMethod): Call
3842 TypeManager.TypeToCoreType() on all types and removed my previous
3843 hack; we're already doig the right thing here.
3845 2004-07-17 Martin Baulig <martin@ximian.com>
3847 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
3849 2004-07-16 Martin Baulig <martin@ximian.com>
3851 * iterators.cs: Added generics support.
3853 2004-07-16 Martin Baulig <martin@ximian.com>
3855 * iterators.cs: Rewrote this. We're now using one single Proxy
3856 class for both the IEnumerable and the IEnumerator interface and
3857 `Iterator' derives from Class so we can use the high-level API.
3859 * class.cs (TypeContainer.AddIterator): New method.
3860 (TypeContainer.DoDefineType): New protected virtual method, which
3861 is called from DefineType().
3862 (TypeContainer.DoDefineMembers): Call DefineType() and
3863 DefineMembers() on all our iterators.
3864 (TypeContainer.Emit): Call Emit() on all our iterators.
3865 (TypeContainer.CloseType): Call CloseType() on all our iterators.
3867 * codegen.cs (EmitContext.CurrentIterator): New public field.
3869 2004-07-15 Martin Baulig <martin@ximian.com>
3872 (TypeManager.not_supported_exception_type): New type.
3874 2004-07-14 Martin Baulig <martin@ximian.com>
3877 (TypeManager.generic_ienumerable_type): New type.
3878 (TypeManager.generic_ienumerator_type): New type.
3881 (RootContext.interfaces_first_stage): Added
3882 "System.Collections.Generic.IEnumerator`1" and
3883 "System.Collections.Generic.IEnumerable`1".
3885 2004-07-14 Martin Baulig <martin@ximian.com>
3887 * iterators.cs: Use real error numbers.
3889 2004-07-14 Martin Baulig <martin@ximian.com>
3891 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
3892 requires this to be a System.Collection.IEnumerable and not a
3893 class implementing that interface.
3894 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
3896 2004-07-13 Marek Safar <marek.safar@seznam.cz>
3898 * class.cs: Fixed previous fix, it broke some error tests.
3900 2004-07-12 Martin Baulig <martin@ximian.com>
3902 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
3905 2004-07-14 Martin Baulig <martin@ximian.com>
3907 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
3908 an exclamation mark (!) for the generic arity to reflect the
3909 latest spec changes; ie. use "System.Collections.Generic.IList`1".
3911 2004-07-13 Martin Baulig <martin@ximian.com>
3913 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
3914 specifiers being part of a type argument.
3916 2004-07-13 Martin Baulig <martin@ximian.com>
3918 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
3919 name for generic types.
3921 2004-07-13 Martin Baulig <martin@ximian.com>
3923 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
3926 2004-07-09 Miguel de Icaza <miguel@ximian.com>
3928 * assign.cs (LocalTemporary): Add new argument: is_address,If
3929 `is_address' is true, then the value that we store is the address
3930 to the real value, and not the value itself.
3932 * ecore.cs (PropertyExpr): use the new local temporary
3933 stuff to allow us to handle X.Y += z (where X is a struct)
3935 2004-07-08 Martin Baulig <martin@ximian.com>
3937 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
3938 not always return, just like we're doing in Using.Resolve().
3940 2004-07-07 Miguel de Icaza <miguel@ximian.com>
3942 * cs-parser.jay (fixed_statement): flag this as Pinned.
3944 2004-07-06 Miguel de Icaza <miguel@ximian.com>
3946 * typemanager.cs (TypeManager): Removed MakePinned method, this
3947 mechanism is replaced with the .NET 2.x compatible mechanism of
3948 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
3950 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
3951 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
3952 `IsFixed' property which has a different meaning.
3954 2004-07-02 Raja R Harinath <rharinath@novell.com>
3956 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
3957 visible from inside a nested class, not just the names of the
3958 immediately enclosing class.
3961 2004-06-24 Raja R Harinath <rharinath@novell.com>
3963 * expression.cs (BetterConversion): Remove buggy special-case
3964 handling of "implicit constant expression conversions". At this
3965 point, we already know that the conversion is possible -- we're
3966 only checking to see which is better.
3968 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3970 * cs-parser.jay: Added error CS0210 test.
3972 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3974 * cs-parser.jay: Added error CS0134 test.
3976 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3979 * cs-parser.jay: Added error CS0145 test.
3981 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3983 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
3985 2004-06-23 Ben Maurer <bmaurer@ximian.com>
3987 * expression.cs (StackAlloc.Resolve): The argument may not
3988 be a constant; deal with this case.
3990 2004-06-23 Marek Safar <marek.safar@seznam.cz>
3992 * attribute.cs (IndexerName_GetIndexerName): Renamed to
3993 GetIndexerAttributeValue.
3994 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
3996 * class.cs (Indexer.Define): Added error tests for CS0415,
3999 2004-06-23 Miguel de Icaza <miguel@ximian.com>
4001 * attribute.cs (Attribute.Resolve): Keep field code in sync with
4004 2004-06-23 Martin Baulig <martin@ximian.com>
4006 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
4007 neither return nor throw, reset the barrier as well. Fixes #60457.
4009 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
4011 * class.cs : EventAttributes is now set to None by default.
4012 This fixes bug #60459.
4014 2004-06-18 Marek Safar <marek.safar@seznam.cz>
4017 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
4018 Don't throw exception but return null (it's sufficient now).
4020 2004-06-18 Marek Safar <marek.safar@seznam.cz>
4022 * typemanager.cs (GetArgumentTypes): Faster implementation.
4024 2004-06-18 Martin Baulig <martin@ximian.com>
4026 * attribute.cs (Attribute.Resolve): Check whether we're an
4027 EmptyCast which a Constant child. Fixes #60333.
4029 2004-06-17 Ben Maurer <bmaurer@ximian.com>
4031 * statement.cs (EmitCollectionForeach): Account for the fact that
4032 not all valuetypes are in areas which we can take the address of.
4033 For these variables, we store to a temporary variable. Also, make
4034 sure that we dont emit a `callvirt' on a valuetype method.
4036 2004-06-15 Marek Safar <marek.safar@seznam.cz>
4038 * expression.cs (StackAlloc.DoReSolve): Added test for
4039 negative parameter (CS0247).
4041 2004-06-15 Marek Safar <marek.safar@seznam.cz>
4044 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
4046 2004-06-15 Marek Safar <marek.safar@seznam.cz>
4049 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
4052 2004-06-14 Marek Safar <marek.safar@seznam.cz>
4054 Fix bug #58254 & cs1555.cs, cs1556.cs
4055 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
4057 2004-06-14 Marek Safar <marek.safar@seznam.cz>
4059 * cs-parser.jay: Added error CS1669 test for indexers.
4061 2004-06-18 Martin Baulig <martin@ximian.com>
4063 * generics.cs (GenericMethod.ctor): Don't take an Attributes
4064 argument. Fixes #60441.
4066 2004-06-16 Ben Maurer <bmaurer@ximian.com>
4067 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
4068 The name needs to have the actual name of the method in order
4069 for other tests (such as the one in OverloadResolve for Invoke
4070 on a delegate) to work. As well, it does not really help
4071 error reporting because the method group had multiple methods.
4072 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
4073 Make profiling work.
4075 2004-06-13 Martin Baulig <martin@ximian.com>
4077 * cs-parser.jay: Don't allow generic attributes.
4079 2004-06-13 Martin Baulig <martin@ximian.com>
4081 * class.cs (MemberBase.DoDefineBase): New protected method.
4082 (MemberBase.DoDefine): Compute the `flags' in the new
4083 DoDefineBase() which must be called first.
4084 (Method.Define): Call DoDefineBase() first so we have the flags
4085 when defining the generic method.
4087 * cs-parser.jay (interface_method_declaration): Support generic methods.
4089 2004-06-13 Martin Baulig <martin@ximian.com>
4091 * decl.cs (TypeName): Removed.
4092 (MemberName): Removed TypeName and MemberNow; now we just have
4095 * cs-parser.jay: Don't distinguish between type arguments and type
4096 parameters in the grammar and simplified the rules a bit. The
4097 reduce/reduce conflicts are now gone (except the one we inherited
4100 2004-06-11 Martin Baulig <martin@ximian.com>
4102 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
4103 call this twice: for params and varargs methods.
4105 2004-06-11 Marek Safar <marek.safar@seznam.cz>
4108 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
4110 2004-06-11 Marek Safar <marek.safar@seznam.cz>
4112 * attribute.cs (Attribute.GetValidTargets): Made public.
4115 (AbstractPropertyEventMethod): New class for better code sharing.
4116 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
4118 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
4120 2004-06-09 Martin Baulig <martin@ximian.com>
4122 * cs-parser.jay: Removed a reduce/reduce conflict.
4124 2004-06-03 Martin Baulig <martin@ximian.com>
4126 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
4127 GetSimpleName() and return a SimpleName.
4129 * ecore.cs (SimpleName.Arguments): New public field.
4130 (SimpleName): Added overloaded ctor which takes an additional
4131 TypeArguments argument.
4132 (SimpleName.SimpleNameResolve): Added support for generic methods.
4133 (MethodGroupExpr.ResolveGeneric): New public method. The code was
4134 formerly in MemberAccess.DoResolve(), but we also need it in
4135 SimpleNameResolve().
4137 * expression.cs (MemberAccess.DoResolve): Use the new
4138 MethodGroupExpr.ResolveGeneric().
4140 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
4142 * decl.cs: If possible, use lookuptypedirect here. We can only do
4143 this if there is no `.' after the namespace. Avoids using
4144 LookupType, which does lots of slow processing.
4145 (FindNestedType) New method, does what it says :-).
4146 * namespace.cs: use LookupTypeDirect.
4147 * rootcontext.cs: use membercache, if possible.
4148 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
4150 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
4153 According to the spec,
4155 In a member access of the form E.I, if E is a single identifier,
4156 and if the meaning of E as a simple-name (§7.5.2) is a constant,
4157 field, property, localvariable, or parameter with the same type as
4158 the meaning of E as a type-name (§3.8), then both possible
4159 meanings of E are permitted.
4161 We did not check that E as a simple-name had the same type as E as
4164 This trivial check gives us 5-7% on bootstrap time.
4166 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
4168 * expression.cs (Invocation.OverloadResolve): Avoid the
4169 use of hashtables and boxing here by allocating on demand.
4171 2004-05-30 Martin Baulig <martin@ximian.com>
4173 * rootcontext.cs (RootContext.LookupType): Don't cache things if
4174 we're doing a silent lookup. Don't try to lookup nested types in
4175 TypeManager.object_type (thanks to Ben Maurer).
4177 2004-05-30 Martin Baulig <martin@ximian.com>
4179 Committing a patch from Ben Maurer.
4181 * rootcontext.cs (RootContext.LookupType): Cache negative results.
4183 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
4185 * convert.cs: add a trivial cache for overload operator resolution.
4187 2004-05-31 Marek Safar <marek.safar@seznam.cz>
4190 (AttributeTester.GetObsoleteAttribute): Returns instance of
4191 ObsoleteAttribute when type is obsolete.
4194 (TypeContainer.VerifyObsoleteAttribute): Override.
4195 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
4196 (MethodCode.VerifyObsoleteAttribute): Override.
4197 (MemberBase.VerifyObsoleteAttribute): Override.
4200 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
4201 and report proper error.
4204 (Delegate.VerifyObsoleteAttribute): Override.
4207 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
4208 and report proper error.
4209 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
4212 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
4216 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
4217 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
4218 Added test for ObsoleteAttribute.
4221 (Catch): Derived from Statement.
4223 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
4225 * decl.cs: If possible, use lookuptypedirect here. We can only do
4226 this if there is no `.' after the namespace. Avoids using
4227 LookupType, which does lots of slow processing.
4228 (FindNestedType) New method, does what it says :-).
4229 * namespace.cs: use LookupTypeDirect.
4230 * rootcontext.cs: use membercache, if possible.
4231 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
4233 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
4236 According to the spec,
4238 In a member access of the form E.I, if E is a single identifier,
4239 and if the meaning of E as a simple-name (§7.5.2) is a constant,
4240 field, property, localvariable, or parameter with the same type as
4241 the meaning of E as a type-name (§3.8), then both possible
4242 meanings of E are permitted.
4244 We did not check that E as a simple-name had the same type as E as
4247 This trivial check gives us 5-7% on bootstrap time.
4249 2004-05-30 Marek Safar <marek.safar@seznam.cz>
4251 Fixed bug #59071 & cs0160.cs
4252 * statement.cs (Try.Resolve): Check here whether order of catch
4253 clauses matches their dependencies.
4255 2004-05-30 Marek Safar <marek.safar@seznam.cz>
4258 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
4261 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
4263 * expression.cs (Invocation.OverloadResolve): Avoid the
4264 use of hashtables and boxing here by allocating on demand.
4266 2004-05-30 Martin Baulig <martin@ximian.com>
4268 * rootcontext.cs (RootContext.LookupType): Don't cache things if
4269 we're doing a silent lookup. Don't try to lookup nested types in
4270 TypeManager.object_type (thanks to Ben Maurer).
4272 2004-05-30 Martin Baulig <martin@ximian.com>
4274 Committing a patch from Ben Maurer.
4276 * rootcontext.cs (RootContext.LookupType): Cache negative results.
4278 2004-05-29 Martin Baulig <martin@ximian.com>
4280 * class.cs (IMethodData.ShouldIgnore): New method.
4282 * typemanager.cs (TypeManager.MethodFlags): Don't take a
4283 `Location' argument, we don't need it anywhere. Use
4284 `IMethodData.ShouldIgnore ()' instead of
4285 `MethodData.GetMethodFlags ()'.
4286 (TypeManager.AddMethod): Removed.
4287 (TypeManager.AddMethod2): Renamed to AddMethod.
4289 2004-05-29 Martin Baulig <martin@ximian.com>
4291 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
4293 * convert.cs (Convert.ImplicitReferenceConversion): If we're
4294 converting from a class type S to an interface type and we already
4295 have an object on the stack, don't box it again. Fixes #52578.
4297 2004-05-29 Martin Baulig <martin@ximian.com>
4299 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
4300 Added support for `params' parameters. Fixes #59267.
4302 2004-05-29 Martin Baulig <martin@ximian.com>
4304 * literal.cs (NullPointer): Provide a private .ctor which sets
4305 `type' to TypeManager.object_type. Fixes #59048.
4307 2004-05-29 Martin Baulig <martin@ximian.com>
4309 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
4310 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
4312 * ecore.cs (EventExpr.instance_expr): Make the field private.
4314 2004-05-26 Marek Safar <marek.safar@seznam.cz>
4316 Fixed bug #50080 & cs0214-2.cs
4317 * expression.cs (Cast.DoResolve): Check unsafe context here.
4319 * statement.cs (Resolve.DoResolve): Likewise.
4321 2004-05-26 Martin Baulig <martin@ximian.com>
4323 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
4325 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
4326 (RootContext.LookupType): Pass down the `silent' flag.
4328 2004-05-25 Martin Baulig <martin@ximian.com>
4331 (MethodGroupExpr.IdenticalTypeName): New public property.
4332 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
4333 expression actually refers to a type.
4335 2004-05-25 Martin Baulig <martin@ximian.com>
4337 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
4338 for #56176 and made it actually work.
4340 2004-05-25 Martin Baulig <martin@ximian.com>
4342 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
4343 (FieldExpr, PropertyExpr): Override and implement
4344 CacheTemporaries. Fixes #52279.
4346 2004-05-25 Miguel de Icaza <miguel@ximian.com>
4348 * location.cs: In the new compiler listing a file twice is a
4349 warning, not an error.
4351 2004-05-24 Martin Baulig <martin@ximian.com>
4353 * enum.cs (Enum.DefineType): For the `BaseType' to be a
4354 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
4356 2004-05-24 Martin Baulig <martin@ximian.com>
4358 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
4359 walking the `using' list. Fixes #53921.
4361 2004-05-24 Martin Baulig <martin@ximian.com>
4363 * const.cs (Const.LookupConstantValue): Added support for
4364 EmptyCast's; fixes #55251.
4366 2004-05-24 Martin Baulig <martin@ximian.com>
4368 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
4369 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
4370 which does the CS0135 check. The reason is that we first need to
4371 check whether the variable actually exists.
4373 2004-05-24 Martin Baulig <martin@ximian.com>
4375 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
4376 than RootContext.LookupType() to find the explicit interface
4379 2004-05-24 Raja R Harinath <rharinath@novell.com>
4381 * Makefile: Simplify. Use executable.make.
4382 * mcs.exe.sources: New file. List of sources of mcs.exe.
4384 2004-05-24 Anders Carlsson <andersca@gnome.org>
4388 Use the invariant culture when doing String.Compare for CLS case
4391 2004-05-23 Martin Baulig <martin@ximian.com>
4393 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
4394 don't have any dots. Fixes #52622, added cs0246-8.cs.
4396 * namespace.cs (NamespaceEntry.Lookup): Likewise.
4398 2004-05-23 Marek Safar <marek.safar@seznam.cz>
4400 * class.cs (MemberBase.Define): Reuse MemberType member for
4401 resolved type. Other methods can use it too.
4403 2004-05-23 Martin Baulig <martin@ximian.com>
4405 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
4406 the variable also exists in the current block (otherwise, we need
4407 to report a CS0103). Fixes #58670.
4409 2004-05-23 Martin Baulig <martin@ximian.com>
4411 * flowanalysis.cs (Reachability.Reachable): Compute this
4412 on-the-fly rather than storing it as a field.
4414 2004-05-23 Martin Baulig <martin@ximian.com>
4416 * flowanalysis.cs (Reachability.And): Manually compute the
4417 resulting `barrier' from the reachability.
4419 2004-05-23 Marek Safar <marek.safar@seznam.cz>
4422 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
4423 instance of ObsoleteAttribute when symbol is obsolete.
4426 (IMethodData): Extended interface for ObsoleteAttribute support.
4428 2004-05-22 Marek Safar <marek.safar@seznam.cz>
4430 * attribute.cs: Fix bug #55970
4432 2004-05-22 Marek Safar <marek.safar@seznam.cz>
4436 (GetObsoleteAttribute): New method. Creates the instance of
4438 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
4439 ObsoleteAttribute when member is obsolete.
4440 (AttributeTester.Report_ObsoleteMessage): Common method for
4441 Obsolete error/warning reporting.
4444 (TypeContainer.base_classs_type): New member for storing parent type.
4447 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
4448 for this MemberCore.
4450 2004-05-21 Marek Safar <marek.safar@seznam.cz>
4452 * attribute.cs, const.cs: Fix bug #58590
4454 2004-05-21 Martin Baulig <martin@ximian.com>
4456 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
4457 out parameters if the end of the method is unreachable. Fixes
4460 2004-05-21 Marek Safar <marek.safar@seznam.cz>
4462 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
4463 Hari was right, why extra method.
4465 2004-05-21 Marek Safar <marek.safar@seznam.cz>
4467 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
4469 2004-05-20 Martin Baulig <martin@ximian.com>
4471 * delegate.cs: Convert this file to Unix mode - like the original
4474 2004-05-20 Martin Baulig <martin@ximian.com>
4476 * attribute.cs: Convert this file to Unix mode - like the original
4479 2004-05-19 Marek Safar <marek.safar@seznam.cz>
4481 Fix bug #58688 (MCS does not report error when the same attribute
4484 * attribute.cs (Attribute.Emit): Distinction between null and default.
4486 2004-05-19 Raja R Harinath <rharinath@novell.com>
4488 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
4489 of a top-level attribute without an attribute target.
4490 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
4492 (Attribute.Conditional_GetConditionName),
4493 (Attribute.Obsolete_GetObsoleteMessage): Update.
4494 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
4495 part of ScanForIndexerName.
4496 (Attribute.CanIgnoreInvalidAttribute): New function.
4497 (Attribute.ScanForIndexerName): Move to ...
4498 (Attributes.ScanForIndexerName): ... here.
4499 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
4500 (Attributes.Search): New internal variant that can choose not to
4501 complain if types aren't resolved. The original signature now
4503 (Attributes.GetClsCompliantAttribute): Use internal variant, with
4504 complaints suppressed.
4505 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
4506 only if it not useful.
4507 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
4508 top-level for attributes that are shared between the assembly
4509 and a top-level class.
4510 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
4511 * class.cs: Update to reflect changes.
4512 (DefineIndexers): Fuse loops.
4513 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
4514 a couple more variants of attribute names.
4516 2004-05-18 Marek Safar <marek.safar@seznam.cz>
4518 Fix bug #52585 (Implemented explicit attribute declaration)
4521 (Attributable.ValidAttributeTargets): New abstract method. It gets
4522 list of valid attribute targets for explicit target declaration.
4523 (Attribute.Target): It holds target itself.
4524 (AttributeSection): Removed.
4525 (Attribute.CheckTargets): New method. It checks whether attribute
4526 target is valid for the current element.
4529 (EventProperty): New class. For events that are declared like
4530 property (with add and remove accessors).
4531 (EventField): New class. For events that are declared like field.
4534 * cs-parser.jay: Implemented explicit attribute target declaration.
4536 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
4537 Override ValidAttributeTargets.
4540 (ReturnParameter): Class for applying custom attributes on
4542 (ParameterAtribute): New class. Class for applying custom
4543 attributes on the parameter type.
4545 2004-05-17 Miguel de Icaza <miguel@ximian.com>
4547 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
4550 (Method): Allow UNSAFE here.
4552 * modifiers.cs: Support unsafe reporting.
4554 2004-05-17 Marek Safar <marek.safar@seznam.cz>
4556 * decl.cs: Fix bug #58478.
4558 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4560 * statement.cs: When checking for unreachable code on an EmptyStatement,
4561 set the location. Fixes bug #58488.
4563 2004-05-13 Miguel de Icaza <miguel@ximian.com>
4565 * driver.cs: Add -pkg handling.
4567 From Gonzalo: UseShelLExecute=false
4569 2004-05-12 Marek Safar <marek.safar@seznam.cz>
4572 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
4574 (Attribute.IsClsCompliaceRequired): Moved to base for better
4576 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
4577 when attribute is AttributeUsageAttribute.
4578 (Attribute.GetValidTargets): Simplified.
4579 (Attribute.GetAttributeUsage): New method returns AttributeUsage
4580 attribute for this type.
4581 (Attribute.ApplyAttributes): Method renamed to Emit and make
4583 (GlobalAttributeSection): New class for special handling of global
4584 attributes (assembly, module).
4585 (AttributeSection.Emit): New method.
4587 * class.cs: Implemented Attributable abstract methods.
4588 (MethodCore.LabelParameters): Moved to Parameter class.
4589 (Accessor): Is back simple class.
4590 (PropertyMethod): Implemented Attributable abstract class.
4591 (DelegateMethod): Implemented Attributable abstract class.
4592 (Event): New constructor for disctintion between normal Event
4593 and Event with accessors.
4595 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
4597 * codegen.cs, const.cs, decl.cs, delegate.cs:
4598 (CommonAssemblyModulClass): Implemented Attributable abstract class
4601 * enum.cs: Implement IAttributeSupport interface.
4602 (EnumMember): New class for emum members. Implemented Attributable
4606 (ParameterBase): Is abstract.
4607 (ReturnParameter): New class for easier [return:] attribute handling.
4609 * typemanager.cs: Removed builder_to_attr.
4611 2004-05-11 Raja R Harinath <rharinath@novell.com>
4614 * attribute.cs (Attribute.GetPositionalValue): New function.
4615 * class.cs (TypeContainer.VerifyMembers): New function.
4616 (TypeContainer.Emit): Use it.
4617 (ClassOrStruct): New base class for Class and Struct.
4618 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
4619 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
4621 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
4622 then each non-static field should have a FieldOffset attribute.
4623 Otherwise, none of the fields should have a FieldOffset attribute.
4624 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
4625 and FieldOffset attributes.
4626 * typemanager.cs (TypeManager.struct_layout_attribute_type)
4627 (TypeManager.field_offset_attribute_type): New core types.
4628 (TypeManager.InitCoreTypes): Initialize them.
4630 2004-05-11 Michal Moskal <malekith@pld-linux.org>
4632 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
4633 Return correct type.
4636 2004-05-09 Miguel de Icaza <miguel@ximian.com>
4638 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
4639 be implicitly converted to ulong.
4641 * expression.cs: The logic for allowing operator &, | and ^ worked
4642 was wrong, it worked before because we did not report an error in
4643 an else branch. Fixes 57895.
4645 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
4646 allow volatile fields to be reference types.
4648 2004-05-07 Miguel de Icaza <miguel@ximian.com>
4650 * driver.cs: Add support for /debug-
4652 2004-05-07 Raja R Harinath <rharinath@novell.com>
4654 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
4655 Add a 'complain' parameter to silence errors.
4656 (Attribute.Resolve): Update to changes. Put in sanity check to catch
4657 silently overlooked type-resolutions.
4658 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
4660 (Attributes.Search): New function.
4661 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
4662 (Attributes.GetAttributeFullName): Remove hack.
4663 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
4664 Update to reflect changes.
4665 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
4666 Use Attributes.Search instead of nested loops.
4668 2004-05-07 Marek Safar <marek.safar@seznam.cz>
4671 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
4672 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
4673 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
4675 * report.cs: (Report.Warning): Renamed to Warning_T because of
4676 parameter collision.
4678 2004-05-05 Raja R Harinath <rharinath@novell.com>
4680 * expression.cs (MemberAccess.ResolveMemberAccess):
4681 Exit with non-zero status after Report.Error.
4682 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
4684 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
4686 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
4688 * support.cs: Don't hang when the file is empty.
4690 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
4692 * support.cs: In SeekableStreamReader, compute the preamble size of the
4693 underlying stream. Position changes should take into account that initial
4696 2004-05-03 Todd Berman <tberman@sevenl.net>
4698 * driver.cs: remove unused GetSysVersion function.
4700 2004-05-03 Todd Berman <tberman@sevenl.net>
4702 * driver.cs: Remove the hack from saturday, as well as the hack
4703 from jackson (LoadAssemblyFromGac), also adds the CWD to the
4704 link_paths to get that bit proper.
4706 2004-05-01 Todd Berman <tberman@sevenl.net>
4708 * driver.cs: Try a LoadFrom before a Load, this checks the current
4709 path. This is currently a bug in mono that is be fixed, however, this
4710 provides a workaround for now. This will be removed when the bug
4713 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
4715 * CryptoConvert.cs: Updated to latest version. Fix issue with
4716 incomplete key pairs (#57941).
4718 2004-05-01 Todd Berman <tberman@sevenl.net>
4720 * driver.cs: Remove '.' from path_chars, now System.* loads properly
4723 2004-04-30 Jackson Harper <jackson@ximian.com>
4725 * codegen.cs: Open keys readonly.
4727 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4729 * typemanager.cs: don't report cyclic struct layout when a struct
4730 contains 2 or more fields of the same type. Failed for Pango.AttrShape
4731 which has 2 Pango.Rectangle fields.
4733 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
4735 * expression.cs: Handle IntPtr comparisons with IL code
4736 rather than a method call.
4738 2004-04-29 Martin Baulig <martin@ximian.com>
4740 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
4741 the list of PropertyInfo's in class hierarchy and find the
4742 accessor. Fixes #56013.
4744 2004-04-29 Martin Baulig <martin@ximian.com>
4746 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
4748 2004-04-29 Martin Baulig <martin@ximian.com>
4750 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
4752 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
4754 2004-04-29 Martin Baulig <martin@ximian.com>
4756 * class.cs (ConstructorInitializer.Resolve): Check whether the
4757 parent .ctor is accessible. Fixes #52146.
4759 2004-04-29 Martin Baulig <martin@ximian.com>
4761 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
4763 * statement.cs (Using.EmitLocalVariableDecls): Use
4764 TypeManager.idisposable_type, not typeof (IDisposable).
4765 (Foreach.EmitCollectionForeach): Added support for valuetypes.
4767 2004-04-29 Martin Baulig <martin@ximian.com>
4769 * class.cs (Event.Define): Don't emit the field and don't set
4770 RTSpecialName and SpecialName for events on interfaces. Fixes
4773 2004-04-29 Raja R Harinath <rharinath@novell.com>
4775 Refactor Attribute.ApplyAttributes.
4776 * attribute.cs (Attributable): New base class for objects that can
4777 have Attributes applied on them.
4778 (Attribute): Make AttributeUsage fields public.
4779 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
4780 (Attribute.IsInternalCall): New property.
4781 (Attribute.UsageAttr): Convert to a public read-only property.
4782 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
4783 (Attribute.ResolveType, Attribute.Resolve)
4784 (Attribute.ScanForIndexerName): Update to reflect changes.
4785 (Attribute.CheckAttributeTarget): Re-format.
4786 (Attribute.ApplyAttributes): Refactor, to various
4787 Attributable.ApplyAttributeBuilder methods.
4788 * decl.cs (MemberCore): Make Attributable.
4789 * class.cs (Accessor): Make Attributable.
4790 (MethodData.ApplyAttributes): Use proper attribute types, not
4792 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
4793 (TypeContainer.ApplyAttributeBuilder)
4794 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
4795 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
4796 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
4797 (Operator.ApplyAttributeBuilder): New factored-out methods.
4798 * const.cs (Const.ApplyAttributeBuilder): Likewise.
4799 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
4800 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
4801 * parameter.cs (ParameterBase): New Attributable base class
4802 that can also represent Return types.
4803 (Parameter): Update to the changes.
4805 2004-04-29 Jackson Harper <jackson@ximian.com>
4807 * driver.cs: Prefer the corlib system version when looking for
4808 assemblies in the GAC. This is still a hack, but its a better hack
4811 2004-04-29 Marek Safar <marek.safar@seznam.cz>
4813 * decl.cs, enum.cs: Improved error 3005 reporting.
4815 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
4816 (related_symbols): New private member for list of symbols
4817 related to reported error/warning.
4819 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
4821 2004-04-29 Martin Baulig <martin@ximian.com>
4823 * ecore.cs (Expression.Constantify): If we're an enum and
4824 TypeManager.TypeToCoreType() doesn't give us another type, use
4825 t.UnderlyingSystemType. Fixes #56178.
4827 2004-04-29 Martin Baulig <martin@ximian.com>
4829 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
4830 interfaces and for each interface, only add members directly
4831 declared in that interface. Fixes #53255.
4833 2004-04-28 Martin Baulig <martin@ximian.com>
4835 * expression.cs (ConditionalLogicalOperator): Use a temporary
4836 variable for `left' to avoid that we evaluate it more than once;
4839 2004-04-28 Martin Baulig <martin@ximian.com>
4841 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
4844 2004-04-28 Martin Baulig <martin@ximian.com>
4846 * statement.cs (LocalInfo.Resolve): Check whether the type is not
4849 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
4850 whether the type is not void (CS1547).
4852 2004-04-28 Martin Baulig <martin@ximian.com>
4854 * expression.cs (Unary.DoResolveLValue): Override this and report
4855 CS0131 for anything but Operator.Indirection.
4857 2004-04-28 Martin Baulig <martin@ximian.com>
4859 Committing a patch from Ben Maurer; see bug #50820.
4861 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
4864 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
4867 2004-04-28 Martin Baulig <martin@ximian.com>
4869 Committing a patch from Ben Maurer; see bug #50820.
4871 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
4874 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
4877 2004-04-28 Martin Baulig <martin@ximian.com>
4879 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
4880 (Block.AddLabel): Call DoLookupLabel() to only search in the
4883 2004-04-28 Martin Baulig <martin@ximian.com>
4885 * cfold.cs (ConstantFold.BinaryFold): Added special support for
4886 comparing StringConstants and NullLiterals in Equality and Inequality.
4888 2004-04-28 Jackson Harper <jackson@ximian.com>
4890 * driver.cs: Attempt to load referenced assemblies from the
4891 GAC. This is the quick and dirty version of this method that
4892 doesnt take into account versions and just takes the first
4893 canidate found. Will be good enough for now as we will not have more
4894 then one version installed into the GAC until I update this method.
4896 2004-04-28 Martin Baulig <martin@ximian.com>
4898 * typemanager.cs (TypeManager.CheckStructCycles): New public
4899 static method to check for cycles in the struct layout.
4901 * rootcontext.cs (RootContext.PopulateTypes): Call
4902 TypeManager.CheckStructCycles() for each TypeContainer.
4903 [Note: We only need to visit each type once.]
4905 2004-04-28 Martin Baulig <martin@ximian.com>
4907 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
4909 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
4910 success and added `out object value'. Use a `bool resolved' field
4911 to check whether we've already been called rather than
4912 `ConstantValue != null' since this breaks for NullLiterals.
4914 2004-04-28 Raja R Harinath <rharinath@novell.com>
4916 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
4917 setting of this flag, since the 'set' method may be non-public.
4919 2004-04-28 Raja R Harinath <rharinath@novell.com>
4921 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
4922 check on current_vector.Block.
4924 2004-04-27 Martin Baulig <martin@ximian.com>
4926 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
4927 a field initializer. Fixes #56459.
4929 2004-04-27 Martin Baulig <martin@ximian.com>
4931 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
4932 we're not attempting to use an indexer. Fixes #52154.
4934 2004-04-27 Martin Baulig <martin@ximian.com>
4936 * statement.cs (Return): Don't create a return label if we don't
4937 need it; reverts my change from January 20th. Thanks to Ben
4940 2004-04-27 Martin Baulig <martin@ximian.com>
4942 According to the spec, `goto' can only leave a nested scope, but
4945 * statement.cs (Block.LookupLabel): Only lookup in the current
4946 block, don't recurse into parent or child blocks.
4947 (Block.AddLabel): Check in parent and child blocks, report
4948 CS0140/CS0158 if we find a duplicate.
4949 (Block): Removed this indexer for label lookups.
4950 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
4951 this already does the error reporting for us.
4954 (FlowBranching.UsageVector.Block): New public variable; may be null.
4955 (FlowBranching.CreateSibling): Added `Block' argument.
4956 (FlowBranching.LookupLabel): New public virtual method. Lookup a
4957 label for the target of a `goto' and check whether we're not
4958 leaving a `finally'.
4960 2004-04-27 Martin Baulig <martin@ximian.com>
4962 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
4963 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
4966 2004-04-27 Martin Baulig <martin@ximian.com>
4968 * statement.cs (Block.AddLabel): Also check for implicit blocks
4969 and added a CS0158 check.
4971 2004-04-27 Martin Baulig <martin@ximian.com>
4973 * flowanalysis.cs (FlowBranchingLoop): New class.
4974 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
4975 UsageVector's instead of an ArrayList.
4976 (FlowBranching.Label): Likewise.
4977 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
4978 (FlowBranching.AddBreakVector): New method.
4980 2004-04-27 Miguel de Icaza <miguel@ximian.com>
4982 * attribute.cs: Small regression fix: only convert the type if we
4983 the type is different, fixes System.Drawing build.
4985 2004-04-27 Martin Baulig <martin@ximian.com>
4987 * attribute.cs (Attribute.Resolve): If we have a constant value
4988 for a named field or property, implicity convert it to the correct
4991 2004-04-27 Raja R Harinath <rharinath@novell.com>
4993 * statement.cs (Block.Block): Implicit blocks share
4994 'child_variable_names' fields with parent blocks.
4995 (Block.AddChildVariableNames): Remove.
4996 (Block.AddVariable): Mark variable as "used by a child block" in
4997 every surrounding block.
4998 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
4999 been used in a child block, complain about violation of "Invariant
5000 meaning in blocks" rule.
5001 * cs-parser.jay (declare_local_variables): Don't use
5002 AddChildVariableNames.
5003 (foreach_statement): Don't create an implicit block: 'foreach'
5006 2004-04-23 Miguel de Icaza <miguel@ximian.com>
5008 * convert.cs (ImplicitNumericConversion): 0 is also positive when
5009 converting from 0L to ulong. Fixes 57522.
5011 2004-04-22 Marek Safar <marek.safar@seznam.cz>
5013 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
5014 derived class hides via 'new' keyword field from base class (test-242.cs).
5015 TODO: Handle this in the more general way.
5017 * class.cs (CheckBase): Ditto.
5019 2004-04-22 Marek Safar <marek.safar@seznam.cz>
5021 * decl.cs (caching_flags): New member for storing cached values
5023 (MemberCore.Flags): New enum where bit flags for caching_flags
5025 (MemberCore.cls_compliance): Moved to caching_flags.
5026 (DeclSpace.Created): Moved to caching_flags.
5028 * class.cs: Use caching_flags instead of DeclSpace.Created
5030 2004-04-21 Miguel de Icaza <miguel@ximian.com>
5032 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
5033 if we are only a derived class, not a nested class.
5035 * typemanager.cs: Same as above, but do this at the MemberLookup
5036 level (used by field and methods, properties are handled in
5037 PropertyExpr). Allow for the qualified access if we are a nested
5040 2004-04-21 Marek Safar <marek.safar@seznam.cz>
5042 * class.cs: Refactoring.
5043 (IMethodData): New inteface; Holds links to parent members
5044 to avoid member duplication (reduced memory allocation).
5045 (Method): Implemented IMethodData interface.
5046 (PropertyBase): New inner classes for get/set methods.
5047 (PropertyBase.PropertyMethod): Implemented IMethodData interface
5048 (Event): New inner classes for add/remove methods.
5049 (Event.DelegateMethod): Implemented IMethodData interface.
5051 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
5052 EmitContext (related to class.cs refactoring).
5054 2004-04-21 Raja R Harinath <rharinath@novell.com>
5056 * delegate.cs (Delegate.VerifyApplicability): If the number of
5057 arguments are the same as the number of parameters, first try to
5058 verify applicability ignoring any 'params' modifier on the last
5062 2004-04-08 Martin Baulig <martin@ximian.com>
5064 Merged latest changes into gmcs. Please keep this comment in
5065 here, it makes it easier for me to see what changed in MCS since
5066 the last time I merged.
5068 2004-04-16 Raja R Harinath <rharinath@novell.com>
5070 * class.cs (TypeContainer.AddIndexer): Use
5071 'ExplicitInterfaceName' to determine if interface name was
5072 explicitly specified. 'InterfaceType' is not initialized at this time.
5073 (TypeContainer.DefineIndexers): Remove use of temporary list. The
5074 Indexers array is already in the required order. Initialize
5075 'IndexerName' only if there are normal indexers.
5076 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
5077 (TypeContainer.Emit): Emit DefaultMember attribute only if
5078 IndexerName is initialized.
5081 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
5083 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
5086 2004-04-15 Raja R Harinath <rharinath@novell.com>
5088 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
5092 * attribute.cs (Attribute.Resolve): Check for duplicate named
5096 2004-04-15 Miguel de Icaza <miguel@ximian.com>
5098 * iterators.cs (MarkYield): track whether we are in an exception,
5099 and generate code accordingly. Use a temporary value to store the
5100 result for our state.
5102 I had ignored a bit the interaction of try/catch with iterators
5103 since their behavior was not entirely obvious, but now it is
5104 possible to verify that our behavior is the same as MS .NET 2.0
5108 2004-04-14 Miguel de Icaza <miguel@ximian.com>
5110 * iterators.cs: Avoid creating temporaries if there is no work to
5113 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
5114 Enumerations, use TypeManager.EnumToUnderlying and call
5117 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
5120 (This.Emit): Use EmitContext.EmitThis to emit our
5123 (This.EmitAssign): Ditto.
5125 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
5126 codepaths, we will move all the functionality into
5129 (FieldExpr.EmitAssign): Ditto.
5131 This fixes several hidden bugs that I uncovered while doing a code
5132 review of this today.
5134 * codegen.cs (EmitThis): reworked so the semantics are more clear
5135 and also support value types "this" instances.
5137 * iterators.cs: Changed so that for iterators in value types, we
5138 do not pass the value type as a parameter.
5140 Initialization of the enumerator helpers is now done in the caller
5141 instead of passing the parameters to the constructors and having
5142 the constructor set the fields.
5144 The fields have now `assembly' visibility instead of private.
5146 2004-04-11 Miguel de Icaza <miguel@ximian.com>
5148 * expression.cs (Argument.Resolve): Check if fields passed as ref
5149 or out are contained in a MarshalByRefObject.
5151 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
5152 another compiler type.
5154 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
5156 * class.cs (Indexer.Define): use the new name checking method.
5157 Also, return false on an error.
5158 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
5159 (is_identifier_[start/part]_character): make static.
5161 2004-04-10 Miguel de Icaza <miguel@ximian.com>
5163 * expression.cs (Binary.ResolveOperator): Do no append strings
5164 twice: since we can be invoked more than once (array evaluation)
5165 on the same concatenation, take care of this here. Based on a fix
5166 from Ben (bug #56454)
5168 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
5170 * codegen.cs: Fix another case where CS1548 must be reported (when
5171 delay-sign isn't specified and no private is available #56564). Fix
5172 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
5173 error when MCS is used on the MS runtime and we need to delay-sign
5174 (which seems unsupported by AssemblyBuilder - see #56621).
5176 2004-04-08 Marek Safar <marek.safar@seznam.cz>
5178 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
5179 (TypeManager.ComputeNamespaces): Faster implementation for
5182 * compiler.csproj: Updated AssemblyName to mcs.
5184 2004-05-11 Jackson Harper <jackson@ximian.com>
5186 * Makefile: Preserve MONO_PATH
5188 2004-05-11 Jackson Harper <jackson@ximian.com>
5190 * Makefile: Use mono and mcs to build gmcs
5192 2004-05-03 Miguel de Icaza <miguel@ximian.com>
5194 * codegen.cs: Add patch from Robert Shade
5195 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
5198 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
5200 * CryptoConvert.cs: Updated to latest version. Fix issue with
5201 incomplete key pairs (#57941).
5203 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
5205 * codegen.cs: Fix another case where CS1548 must be reported (when
5206 delay-sign isn't specified and no private is available #56564). Fix
5207 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
5208 error when MCS is used on the MS runtime and we need to delay-sign
5209 (which seems unsupported by AssemblyBuilder - see #56621).
5211 2004-04-29 Jackson Harper <jackson@ximian.com>
5213 * Makefile: Set MONO_PATH to use the bootstrap corlib
5214 * driver.cs: Check the GAC for referenced assemblies.
5216 2004-04-29 Martin Baulig <martin@ximian.com>
5218 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
5220 2004-04-07 Martin Baulig <martin@ximian.com>
5222 * expression.cs (Binary.ResolveOperator): Added special case for
5223 Equality/Inequality between a type parameter and a null literal.
5225 2004-04-07 Martin Baulig <martin@ximian.com>
5227 * convert.cs: Check null literal -> type parameter conversions.
5229 2004-04-07 Martin Baulig <martin@ximian.com>
5231 * generic.cs (ConstructedType.CheckConstraints): Enforce the
5232 `class' and `struct' constraints.
5234 2004-04-07 Martin Baulig <martin@ximian.com>
5236 * generic.cs (SpecialConstraint): New public enum.
5237 (Constraints.Resolve): Added support for the `class' and `struct'
5240 * cs-parser.jay (type_parameter_constraint): Added support for the
5241 `class' and `struct' constraints.
5243 2004-04-07 Martin Baulig <martin@ximian.com>
5245 * support.cs (GenericConstraints): Replaced `Types' by
5246 `ClassConstraint' and `InterfaceConstraints'; added
5247 `HasClassConstraint'.
5249 2004-04-07 Martin Baulig <martin@ximian.com>
5252 (Constraints.InterfaceConstraints): New public property.
5253 (Constraints.Types): Make this property public
5254 (TypeParameter): Implement IMemberContainer.
5255 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
5256 instead of a TypeBuilder/MethodBuilder; pass the interface
5257 constraints to TypeManager.AddTypeParameter().
5258 (TypeParameter.DefineType): Just take an EmitContext and no
5259 TypeBuilder/MethodBuilder. Use the new public API.
5261 * typemanager.cs (TypeManager.AddTypeParameter): Added
5262 `TypeExpr[]' argument; add the interfaces to the
5263 `builder_to_ifaces' hash.
5264 (TypeManager.LookupMemberContainer): For
5265 GenericTypeParameterBuilders, get the TypeParameter from the
5266 `builder_to_type_param'.
5267 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
5268 the TypeParameter and call FindMembers on it.
5270 2004-04-07 Martin Baulig <martin@ximian.com>
5273 (MethodCore.GenericMethod): Moved this field here from Method.
5274 (MethodCore.IsDuplicateImplementation): Take the number of type
5275 parameters into account if we're a generic method.
5277 * expression.cs (Invocation.InferTypeArguments): Don't return true
5278 if `arguments' is null; we still need to check whether we actually
5279 don't need to infer anything in this case.
5280 (MemberAccess): Merged the functionality from GenericMemberAccess
5283 * generic.cs (GenericMemberAccess): Removed.
5285 2004-04-05 Martin Baulig <martin@ximian.com>
5287 * decl.cs (MemberCore): For generic classes, interfaces and
5288 structs, `Name' now includes the number of type parameters
5290 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
5291 encode the number of type arguments in the type name.
5293 * expression.cs (Expression.MemberLookup): Removed the
5294 `num_type_args' argument; we now encode the number of type
5295 arguments in the type name.
5297 * ecore.cs (SimpleName): Encode the number of type arguments in
5298 the type name itself.
5300 * generic.cs (ConstructedType): Likewise.
5302 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
5303 `MemberName'; we now include the number of type parameters in the
5306 * typemanager.cs (TypeManager.CheckGeneric): Removed.
5307 (TypeManager.MemberLookup): Removed the
5308 `num_type_args' argument; we now encode the number of type
5309 arguments in the type name.
5311 2004-04-03 Martin Baulig <martin@ximian.com>
5313 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
5314 (MemberCore.MemberName): Moved here from MemberBase.
5315 (DeclSpace.SetParameterInfo): Just take the constraints as an
5316 ArrayList; we already have the type parameters in our
5317 `MemberName'; also do the CS0080 reporting here.
5319 * cs-parser.jay (struct_declaration): Use `member_name' instead of
5320 `IDENTIFIER opt_type_parameter_list'; when constructing our
5321 `MemberName', it'll already include our type parameters.
5322 (class_declaration, interface_declaration): Likewise.
5323 (delegate_declaration): Likewise.
5324 (MakeName): Take a MemberName and return a MemberName.
5325 The following two changes are required to avoid shift/reduce conflicts:
5326 (member_name): Don't include a TypeName anymore; ie. this is now
5327 just 'IDENTIFIER opt_type_parameter_list'.
5328 (property_declaration, event_declaration): Use a
5329 `namespace_or_type_name' instead of a `member_name'.
5331 2004-04-03 Martin Baulig <martin@ximian.com>
5333 * decl.cs (MemberName): Renamed to `TypeName' and created a new
5335 (TypeName): Formerly known as MemberName.
5337 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
5338 instead of a `MemberName'.
5340 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
5341 (member_name): New rule; create a MemberName.
5343 2004-04-02 Martin Baulig <martin@ximian.com>
5345 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
5346 (CS0305 and CS0308).
5348 2004-04-02 Martin Baulig <martin@ximian.com>
5350 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
5351 support for nested types.
5353 2004-04-02 Martin Baulig <martin@ximian.com>
5355 * ecore.cs (IAlias): New public interface.
5356 (TypeExpr, TypeExpression): Implement IAlias.
5357 (TypeAliasExpression): New public class.
5359 * namespace.cs (Namespace): Implement IAlias.
5360 (Namespace.Lookup): Return an IAlias instead on an object.
5361 (Namespace.DefineName): Take an IAlias instead of an object.
5362 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
5364 (NamespaceEntry.UsingAlias): Take a Membername instead of an
5366 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
5368 (NamespaceEntry.Lookup): Likewise.
5370 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
5373 * decl.cs (DeclSpace): Implement IAlias.
5374 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
5376 * generic.cs (ConstructedType): Improved error checking.
5378 2004-04-02 Martin Baulig <martin@ximian.com>
5380 * convert.cs: Added type parameter conversions.
5383 (UnboxCast.Emit): Emit an `unbox.any' for type params.
5384 (ClassCast.Emit): If the source type is a type parameter, box it.
5385 If the target type is a type parameter, emit an `unbox.any'
5386 instead of a `classcast'.1
5388 2004-04-01 Martin Baulig <martin@ximian.com>
5390 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
5392 2004-04-01 Martin Baulig <martin@ximian.com>
5394 * generic.cs (ConstructedType.CheckConstraints): Use
5395 Convert.ImplicitStandardConversionExists(); user-defined implicit
5396 conversions are not allowed according to the spec.
5398 2004-03-30 Martin Baulig <martin@ximian.com>
5400 * expression.cs (New): Added support for type parameters.
5403 (TypeManager.activator_type): New public static field.
5404 (TypeManager.activator_create_instance): Likewise.
5406 2004-03-30 Martin Baulig <martin@ximian.com>
5408 * typemanager.cs (TypeManager.HasConstructorConstraint): New
5411 2004-03-30 Martin Baulig <martin@ximian.com>
5413 * generic.cs (ConstructedType.CheckConstraints): Actually follow
5414 the spec here: the argument type must be convertible to the
5417 2004-03-30 Martin Baulig <martin@ximian.com>
5420 (TypeParameter.Define, TypeParameter.DefineMethod): Call
5421 TypeManager.AddTypeParameter().
5422 (ConstructedType.CheckConstraints): Re-enable this and actually
5423 check whether we have a constructor constraint.
5426 (TypeManager.builder_to_type_param): New static field.
5427 (TypeManager.AddTypeParameter): New static method.
5428 (TypeManager.LookupTypeParameter): New public method.
5430 2004-03-30 Martin Baulig <martin@ximian.com>
5432 * generic.cs (TypeParameter.DefineType): Return a boolean and use
5433 the new API to actually define the constructor constraint.
5436 (TypeManager.new_constraint_attr_type): New static field.
5437 (TypeManager.InitCoreTypes): Initialize it.
5439 2004-03-30 Martin Baulig <martin@ximian.com>
5441 * generic.cs (Constraints): Completed error checking, use correct
5444 2004-03-29 Martin Baulig <martin@ximian.com>
5446 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
5448 * expression.cs (Invocation.InferTypeArguments): Added overloaded
5449 public version which takes a `ParameterData pd' instead of an
5452 2004-03-29 Martin Baulig <martin@ximian.com>
5454 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
5457 2004-03-29 Martin Baulig <martin@ximian.com>
5459 * expression.cs (Argument.ResolveMethodGroup): If we're a
5460 ConstructedType, call GetMemberAccess() on it.
5462 2004-03-29 Martin Baulig <martin@ximian.com>
5464 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
5465 (MethodCore.CheckGenericOverride): When overriding a generic
5466 method, check whether the constraints match.
5468 * support.cs (GenericConstraints): New public interface.
5469 (ParameterData.GenericConstraints): New public method.
5471 * parameter.cs (Parameter.Resolve): Check whether we're a generic
5472 method parameter and compute our constraints if appropriate.
5473 (Parameter.GenericConstraints): New public property.
5475 * generic.cs (Constraints): Implement GenericConstraints.
5477 2004-03-29 Martin Baulig <martin@ximian.com>
5479 * decl.cs (MemberCache.FindMemberToOverride): Use
5480 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
5482 2004-03-29 Martin Baulig <martin@ximian.com>
5484 * generic.cs (GenericMethod.Define): Resolve our type parameters.
5486 2004-03-29 Martin Baulig <martin@ximian.com>
5488 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
5489 not allowed on non-generic declarations").
5491 2004-03-29 Martin Baulig <martin@ximian.com>
5493 * expression.cs (Invocation.InferTypeArguments): Added overloaded
5494 public version of this method.
5496 * class.cs (MethodCore.IsDuplicateImplementation): Use
5497 Invocation.InferTypeArguments() to check this.
5499 2004-03-29 Martin Baulig <martin@ximian.com>
5501 * convert.cs: Use TypeManager.IsDelegateType() instead of
5502 comparing types correctly.
5504 2004-03-29 Martin Baulig <martin@ximian.com>
5506 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
5507 types directly to make it work for generic instances.
5509 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
5511 2004-03-29 Martin Baulig <martin@ximian.com>
5513 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
5516 2004-03-24 Martin Baulig <martin@ximian.com>
5518 * decl.cs (DeclSpace.FindType): Also use
5519 TypeManager.CheckGeneric() for types from the using clauses.
5521 2004-03-23 Martin Baulig <martin@ximian.com>
5523 * expression.cs (Invocation.OverloadResolve): Added `bool
5524 may_fail' argument and use it instead of the Location.IsNull() hack.
5526 2004-03-23 Martin Baulig <martin@ximian.com>
5528 * expression.cs (Invocation.InferType): Use correct type inference
5531 2004-03-23 Martin Baulig <martin@ximian.com>
5533 * ecore.cs (MethodGroupExpr.Name): Use
5534 TypeManager.CSharpSignature() instead of just the name.
5536 * expression.cs (Invocation.OverloadResolve): Provide better error
5538 (Invocation.DoResolve): OverloadResolve() never returns null
5539 without reporting an error, so removed the error -6 reporting here.
5541 2004-03-23 Martin Baulig <martin@ximian.com>
5543 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
5546 * cs-parser.jay (delegate_declaration): Support generic delegates.
5548 * delegate.cs: Support generic delegates.
5550 2004-03-22 Martin Baulig <martin@ximian.com>
5552 * expression.cs (Invocation.InferParamsTypeArguments): New static
5553 method; does type inference for params arguments.
5555 2004-03-21 Martin Baulig <martin@ximian.com>
5557 * typemanager.cs (TypeManager.IsGenericMethod): New public static
5558 method; checks whether a method is a generic method.
5560 * expression.cs (Invocation.InferTypeArguments): New static method;
5561 infer type arguments for generic method invocation.
5563 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
5564 property; we set this to true if we're resolving a generic method
5565 invocation and the user specified type arguments, ie. we're not
5566 doing type inference.
5568 2004-03-20 Martin Baulig <martin@ximian.com>
5570 * class.cs (MethodData.DeclaringType): New public property.
5571 (MethodData.Define): Set DeclaringType here.
5572 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
5573 instead of OperatorMethodBuilder.DeclaringType.
5575 2004-03-20 Martin Baulig <martin@ximian.com>
5577 * cs-tokenizer.cs (xtoken): Return a special
5578 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
5580 * cs-parser.jay (default_value_expression): Switch to the new
5583 2004-03-19 Martin Baulig <martin@ximian.com>
5585 * decl.cs (MemberName): New class. We use this to "construct"
5586 namespace_or_type_name's.
5588 * generics.cs (TypeArguments.GetDeclarations): New public method;
5589 returns the type arguments as a string[] and reports a CS0081 if
5590 one of them is not an identifier.
5592 * class.cs (MemberBase): The .ctor now takes the name as a
5593 MemberName instead of a string.
5594 (MemberBase.ExplicitInterfaceName): Changed type from string to
5596 (MemberBase.DoDefine): If we're an explicit implementation, the
5597 InterfaceType may be a generic instance.
5599 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
5600 (namespace_name): Call MemberName.GetName () to transform the
5601 MemberName into a string and ensure we don't have any type
5603 (type_name): Call MemberName.GetTypeExpression() to transfrom the
5604 MemberName into an expression.
5605 (method_header): Use namespace_or_type_name instead of member_name.
5607 2004-04-07 Miguel de Icaza <miguel@ximian.com>
5609 * rootcontext.cs: Add new types to the boot resolution.
5611 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
5612 MulticastDelegate is not allowed.
5614 * typemanager.cs: Add new types to lookup: System.TypedReference
5617 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
5618 check for TypedReference or ArgIterator, they are not allowed.
5620 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
5621 makes us properly catch 1510 in some conditions (see bug 56016 for
5624 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
5626 * CryptoConvert.cs: update from corlib version
5629 2004-04-05 Miguel de Icaza <miguel@ximian.com>
5631 * class.cs (Indexer.Define): Check indexername declaration
5633 2004-04-05 Marek Safar <marek.safar@seznam.cz>
5635 * attribute.cs (IsClsCompliant): Fixed problem with handling
5636 all three states (compliant, not-compliant, undetected).
5638 2004-03-30 Marek Safar <marek.safar@seznam.cz>
5640 * attribute.cs (Attribute): Location is now public.
5641 (Resolve): Store resolved arguments (pos_values) in attribute class.
5642 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
5643 (GetClsCompliantAttributeValue): New method that gets
5644 CLSCompliantAttribute value.
5645 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
5646 if exists else null.
5647 (AttributeTester): New class for CLS-Compliant verification routines.
5649 * class.cs (Emit): Add CLS-Compliant verification.
5650 (Method.GetSignatureForError): Implemented.
5651 (Constructor.GetSignatureForError): Implemented
5652 (Constructor.HasCompliantArgs): Returns if constructor has
5653 CLS-Compliant arguments.
5654 (Constructor.Emit): Override.
5655 (Construcor.IsIdentifierClsCompliant): New method; For constructors
5656 is needed to test only parameters.
5657 (FieldBase.GetSignatureForError): Implemented.
5658 (TypeContainer): New member for storing base interfaces.
5659 (TypeContainer.FindMembers): Search in base interfaces too.
5661 * codegen.cs (GetClsComplianceAttribute): New method that gets
5662 assembly or module CLSCompliantAttribute value.
5663 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
5665 (ModuleClass.Emit): Add error 3012 test.
5667 * const.cs (Emit): Override and call base for CLS-Compliant tests.
5669 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
5670 state for all decl types.
5671 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
5672 if CLS-Compliant tests are required.
5673 (IsClsCompliaceRequired): New method. Analyze whether code
5674 must be CLS-Compliant.
5675 (IsExposedFromAssembly): New method. Returns true when MemberCore
5676 is exposed from assembly.
5677 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
5678 value or gets cached value.
5679 (HasClsCompliantAttribute): New method. Returns true if MemberCore
5680 is explicitly marked with CLSCompliantAttribute.
5681 (IsIdentifierClsCompliant): New abstract method. This method is
5682 used to testing error 3005.
5683 (IsIdentifierAndParamClsCompliant): New method. Common helper method
5684 for identifier and parameters CLS-Compliant testing.
5685 (VerifyClsCompliance): New method. The main virtual method for
5686 CLS-Compliant verifications.
5687 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
5688 null. I don't know why is null (too many public members !).
5689 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
5690 and get value of first CLSCompliantAttribute that found.
5692 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
5693 (VerifyClsCompliance): Override and add extra tests.
5695 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
5696 clscheck- disable CLS-Compliant verification event if assembly is has
5697 CLSCompliantAttribute(true).
5699 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
5700 ApllyAttribute is now called in emit section as in the other cases.
5701 Possible future Emit integration.
5702 (IsIdentifierClsCompliant): New override.
5703 (VerifyClsCompliance): New override.
5704 (GetEnumeratorName): Returns full enum name.
5706 * parameter.cs (GetSignatureForError): Implemented.
5708 * report.cs (WarningData): New struct for Warning message information.
5709 (LocationOfPreviousError): New method.
5710 (Warning): New method. Reports warning based on the warning table.
5711 (Error_T): New method. Reports error based on the error table.
5713 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
5714 verifications are done here.
5716 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
5718 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
5719 CLSCompliantAttribute.
5720 (all_imported_types): New member holds all imported types from other
5722 (LoadAllImportedTypes): New method fills static table with exported types
5723 from all referenced assemblies.
5724 (Modules): New property returns all assembly modules.
5726 2004-03-30 Miguel de Icaza <miguel@ximian.com>
5728 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
5729 throwing a parser error.
5731 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
5732 which removes the hardcoded get_/set_ prefixes for properties, as
5733 IL allows for the properties to be named something else.
5737 * expression.cs: Do not override operand before we know if it is
5740 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
5742 * typemanager.cs: support for pinned variables.
5744 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
5746 * decl.cs, typemanager.cs: Avoid using an arraylist
5747 as a buffer if there is only one result set.
5749 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
5751 * expression.cs: Make sure you cant call a static method
5752 with an instance expression, bug #56174.
5754 2004-03-29 Miguel de Icaza <miguel@ximian.com>
5756 * class.cs (IsDuplicateImplementation): Improve error reporting to
5757 flag 663 (method only differs in parameter modifier).
5759 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
5760 in preprocessor directives.
5762 * location.cs (LookupFile): Allow for the empty path.
5764 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
5765 better approach for some of that patch, but its failing with the
5766 CharSet enumeration. For now try/catch will do.
5768 * typemanager.cs: Do not crash if a struct does not have fields.
5771 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
5773 * expression.cs: cs0213, cant fix a fixed expression.
5776 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
5778 * cs-parser.jay: detect invalid embeded statements gracefully.
5781 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
5783 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
5786 the invocation type may not be a subclass of the tye of the item/
5787 The type of the item must be a subclass of the invocation item.
5792 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
5794 * attribute.cs: Added methods to get a string and a bool from an
5795 attribute. Required to information from AssemblyKeyFileAttribute,
5796 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
5797 * codegen.cs: Modified AssemblyName creation to include support for
5798 strongnames. Catch additional exceptions to report them as CS1548.
5799 * compiler.csproj: Updated include CryptoConvert.cs.
5800 * compiler.csproj.user: Removed file - user specific configuration.
5801 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
5802 Mono.Security assembly. The original class is maintained and tested in
5803 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
5804 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
5805 like CSC 8.0 (C# v2) supports.
5806 * Makefile: Added CryptoConvert.cs to mcs sources.
5807 * rootcontext.cs: Added new options for strongnames.
5809 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
5811 * driver.cs: For --expect-error, report error code `2'
5812 if the program compiled with no errors, error code `1' if
5813 it compiled with an error other than the one expected.
5815 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
5817 * compiler.csproj: Updated for Visual Studio .NET 2003.
5818 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
5819 * compiler.sln: Updated for Visual Studio .NET 2003.
5821 2004-03-24 Ravi Pratap M <ravi@ximian.com>
5823 * expression.cs: Fix bug #47234. We basically need to apply the
5824 rule that we prefer the conversion of null to a reference type
5825 when faced with a conversion to 'object' (csc behaviour).
5827 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5829 * statement.cs: Shorter form for foreach, eliminates
5830 a local variable. r=Martin.
5832 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5834 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
5835 checks if we can use brtrue/brfalse to test for 0.
5836 * expression.cs: use the above in the test for using brtrue/brfalse.
5839 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5841 * expression.cs: Rewrite string concat stuff. Benefits:
5843 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
5844 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
5845 rather than a concat chain.
5847 * typemanager.cs: Add lookups for more concat overloads.
5849 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5851 * expression.cs: Emit shorter il code for array init.
5868 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
5870 * statement.cs: Before, two switch blocks would be merged if the
5871 total size of the blocks (end_item - begin_item + 1) was less than
5872 two times the combined sizes of the blocks.
5874 Now, it will only merge if after the merge at least half of the
5879 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
5881 * class.cs : csc build fix for GetMethods(). See bug #52503.
5883 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
5885 * expression.cs: Make sure fp comparisons work with NaN.
5886 This fixes bug #54303. Mig approved this patch a long
5887 time ago, but we were not able to test b/c the runtime
5890 2004-03-19 Miguel de Icaza <miguel@ximian.com>
5892 * ecore.cs (TypExpr.GetHashCode): implement this overload.
5894 2004-03-19 Martin Baulig <martin@ximian.com>
5896 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
5897 two overloads may unify for some type parameter substitutions and
5898 report a CS0408 if appropriate.
5900 2004-03-19 Martin Baulig <martin@ximian.com>
5902 * class.cs (MemberCore.IsDuplicateImplementation): Report the
5903 error here and not in our caller.
5905 2004-03-19 Martin Baulig <martin@ximian.com>
5907 * interface.cs: Completely killed this file.
5908 (Interface): We're now a TypeContainer and live in class.cs.
5910 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
5911 argument; we're now also called for interfaces.
5912 (TypeContainer.DefineMembers): Allow this method being called
5914 (TypeContainer.GetMethods): New public method; formerly known as
5915 Interface.GetMethod(). This is used by PendingImplementation.
5916 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
5917 it's now private and non-static.
5918 (Interface): Moved this here; it's now implemented similar to
5920 (Method, Property, Event, Indexer): Added `bool is_interface'
5921 argument to their .ctor's.
5922 (MemberBase.IsInterface): New public field.
5924 * cs-parser.jay: Create normal Method, Property, Event, Indexer
5925 instances instead of InterfaceMethod, InterfaceProperty, etc.
5926 (opt_interface_base): Removed; we now use `opt_class_base' instead.
5927 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
5929 2004-03-19 Martin Baulig <martin@ximian.com>
5931 * class.cs (MethodCore.IsDuplicateImplementation): New private
5932 method which does the CS0111 checking.
5933 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
5934 Use IsDuplicateImplementation().
5936 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
5938 * decl.cs (FindMemberToOverride): New method to find the correct
5939 method or property to override in the base class.
5941 - Make Method/Property use the above method to find the
5942 version in the base class.
5943 - Remove the InheritableMemberSignatureCompare as it is now
5946 This patch makes large code bases much faster to compile, as it is
5947 O(n) rather than O(n^2) to do this validation.
5949 Also, it fixes bug 52458 which is that nested classes are not
5950 taken into account when finding the base class member.
5952 Reviewed/Approved by Martin.
5954 2004-03-17 Martin Baulig <martin@ximian.com>
5956 * expression.cs (MemberAccess.DoResolve): Take the parent's number
5957 of type arguments into account; use the `real_num_type_args'
5958 approach like in DoResolveAsTypeStep().
5960 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
5963 2004-03-17 Marek Safar <marek.safar@seznam.cz>
5965 * interface.cs: In all interface classes removed redundant
5966 member initialization.
5968 2004-03-16 Martin Baulig <martin@ximian.com>
5970 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
5972 2004-03-15 Miguel de Icaza <miguel@ximian.com>
5974 * decl.cs (DefineTypeAndParents): New helper method to define a
5975 type's containers before the type itself is defined; This is a
5976 bug exposed by the recent changes to Windows.Forms when an
5977 implemented interface was defined inside a class that had not been
5980 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
5982 (Check): Loop correctly to report errors modifiers
5983 (UNSAFE was not in the loop, since it was the same as TOP).
5985 * interface.cs: Every interface member now takes a ModFlags,
5986 instead of a "is_new" bool, which we set on the base MemberCore.
5988 Every place where we called "UnsafeOk" in the interface, now we
5989 call the proper member (InterfaceMethod.UnsafeOK) instead to get
5990 the unsafe settings from the member declaration instead of the
5991 container interface.
5993 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
5995 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
5996 `set_indexer_name' to the pending bits (one per type).
5998 We fixed a bug today that was picking the wrong method to
5999 override, since for properties the existing InterfaceMethod code
6000 basically ignored the method name. Now we make sure that the
6001 method name is one of the valid indexer names.
6003 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
6005 * support.cs (SeekableStreamReader): Keep track of stream byte
6006 positions and don't mix them with character offsets to the buffer.
6008 Patch from Gustavo Giráldez
6010 2004-03-15 Marek Safar <marek.safar@seznam.cz>
6012 * interface.cs (InterfaceSetGetBase): Removed double member
6013 initialization, base class does it as well.
6015 2004-03-13 Martin Baulig <martin@ximian.com>
6017 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
6018 when compiling corlib.
6020 2004-03-13 Miguel de Icaza <miguel@ximian.com>
6022 * convert.cs (ExplicitConversion): We were reporting an error on
6023 certain conversions (object_type source to a value type, when the
6024 expression was `null') before we had a chance to pass it through
6025 the user defined conversions.
6027 * driver.cs: Replace / and \ in resource specifications to dots.
6030 * class.cs: Add check for duplicate operators. Fixes 52477
6032 2004-03-11 Miguel de Icaza <miguel@ximian.com>
6034 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
6035 that are in the middle of the statements, not only at the end.
6038 * class.cs (TypeContainer.AddField): No longer set the
6039 `HaveStaticConstructor' flag, now we call it
6040 `UserDefineStaticConstructor' to diferentiate the slightly
6041 semantic difference.
6043 The situation is that we were not adding BeforeFieldInit (from
6044 Modifiers.TypeAttr) to classes that could have it.
6045 BeforeFieldInit should be set to classes that have no static
6050 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
6052 And most importantly Zoltan's comment:
6054 http://bugzilla.ximian.com/show_bug.cgi?id=44229
6056 "I think beforefieldinit means 'it's ok to initialize the type sometime
6057 before its static fields are used', i.e. initialization does not need
6058 to be triggered by the first access to the type. Setting this flag
6059 helps the JIT to compile better code, since it can run the static
6060 constructor at JIT time, and does not need to generate code to call it
6061 (possibly lots of times) at runtime. Unfortunately, mcs does not set
6062 this flag for lots of classes like String.
6064 csc sets this flag if the type does not have an explicit static
6065 constructor. The reasoning seems to be that if there are only static
6066 initalizers for a type, and no static constructor, then the programmer
6067 does not care when this initialization happens, so beforefieldinit
6070 This bug prevents the AOT compiler from being usable, since it
6071 generates so many calls to mono_runtime_class_init that the AOT code
6072 is much slower than the JITted code. The JITted code is faster,
6073 because it does not generate these calls if the vtable is type is
6074 already initialized, which is true in the majority of cases. But the
6075 AOT compiler can't do this."
6077 2004-03-10 Miguel de Icaza <miguel@ximian.com>
6079 * class.cs (MethodData.Emit): Refactor the code so symbolic
6080 information is generated for destructors; For some reasons we
6081 were taking a code path that did not generate symbolic information
6084 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
6086 * class.cs: Create a Constructor.CheckBase method that
6087 takes care of all validation type code. The method
6088 contains some code that was moved from Define.
6090 It also includes new code that checks for duplicate ctors.
6091 This fixes bug #55148.
6093 2004-03-09 Joshua Tauberer <tauberer@for.net>
6095 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
6096 a { ... }-style array creation invokes EmitStaticInitializers
6097 which is not good for reference-type arrays. String, decimal
6098 and now null constants (NullCast) are not counted toward
6099 static initializers.
6101 2004-03-05 Martin Baulig <martin@ximian.com>
6103 * location.cs (SourceFile.HasLineDirective): New public field;
6104 specifies whether the file contains or is referenced by a "#line"
6106 (Location.DefineSymbolDocuments): Ignore source files which
6107 either contain or are referenced by a "#line" directive.
6109 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
6111 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
6112 direct access to our parent, so check the method inline there.
6114 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
6116 * expression.cs (Invocation.EmitCall): Miguel's last commit
6117 caused a regression. If you had:
6122 In Foo the implict this would be null.
6124 2004-02-27 Miguel de Icaza <miguel@ximian.com>
6126 * expression.cs (Invocation.EmitCall): If the method is not
6127 virtual, do not emit a CallVirt to it, use Call.
6129 * typemanager.cs (GetFullNameSignature): Improve the method to
6130 cope with ".ctor" and replace it with the type name.
6132 * class.cs (ConstructorInitializer.Resolve): Now the method takes
6133 as an argument the ConstructorBuilder where it is being defined,
6134 to catch the recursive constructor invocations.
6136 2004-03-16 Martin Baulig <martin@ximian.com>
6138 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
6139 ConstructedType, call ResolveType() on it to get the type rather
6140 than just using `expr.Type'.
6142 2004-03-16 Martin Baulig <martin@ximian.com>
6144 * generics.cs (ConstructedType.GetMemberAccess): Take the
6145 EmitContext instead on the TypeExpr and use
6146 ec.TypeContainer.CurrentType/ec.ContainerType.
6148 2004-03-16 Martin Baulig <martin@ximian.com>
6150 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
6151 parameters before aliases.
6153 2004-03-16 Martin Baulig <martin@ximian.com>
6155 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
6156 New oublic function; checks whether two generic instances may become
6157 equal under some instantiations (26.3.1).
6159 * class.cs (TypeContainer.Define): Call
6160 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
6163 2004-03-16 Martin Baulig <martin@ximian.com>
6165 * class.cs (TypeContainer.GetClassBases): Moved
6166 Error_TypeParameterAsBase() here and also check whether the base
6167 class is not an attribute.
6169 2004-03-16 Martin Baulig <martin@ximian.com>
6171 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
6173 2004-03-16 Martin Baulig <martin@ximian.com>
6175 * class.cs (Error_TypeParameterAsBase): Use correct error number
6178 2004-03-16 Martin Baulig <martin@ximian.com>
6180 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
6183 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
6186 2004-03-15 Martin Baulig <martin@ximian.com>
6188 * typemanager.cs (TypeManager.GetFullName): New public method.
6189 (TypeManager.MemberLookup): Added `int_num_type_arguments'
6190 argument; only return members with the correct number of type
6192 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
6193 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
6194 whether the number of type arguments matches.
6196 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
6197 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
6199 * expression.cs (MemberAccess): Added public `NumTypeArguments'
6200 field; it's set by the protected .ctor when we're actually a
6201 GenericMemberAccess.
6202 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
6203 arguments and pass it to MemberLookupFinal ().
6205 * ecore.cs (Expression.MemberLookup): Added `int
6206 num_type_arguments' argument; only return members with the correct
6207 number of type arguments.
6208 (Expression.MemberLookupFailed): Check whether the MemberLookup
6209 failed because we did not have the correct number of type
6210 arguments; report CS0305 in this case.
6212 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
6213 `e.ResolveAsTypeTerminal()' already did so.
6215 2004-03-15 Martin Baulig <martin@ximian.com>
6217 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
6218 we're a ConstructedType; in this case, the caller must report an
6219 error (for instance CS0131).
6221 * generic.cs (TypeArguments): Added Location argument to the .ctor.
6222 (TypeArguments.Resolve): Actually report errors here.
6224 2004-03-15 Miguel de Icaza <miguel@ximian.com>
6226 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
6227 `set_indexer_name' to the pending bits (one per type).
6229 We fixed a bug today that was picking the wrong method to
6230 override, since for properties the existing InterfaceMethod code
6231 basically ignored the method name. Now we make sure that the
6232 method name is one of the valid indexer names.
6234 2004-03-15 Martin Baulig <martin@ximian.com>
6236 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
6237 for generic instances.
6239 2004-03-13 Martin Baulig <martin@ximian.com>
6241 * class.cs (TypeContainer.DefineType): Call
6242 TypeManager.AddUserType() immediately after creating the
6243 TypeBuilder; pass all type parameters when creating the
6246 * decl.cs (DeclSpace.FindNestedType): New public method.
6247 (DeclSpace.FindType): Added `int num_type_args' argument; only
6248 return types with the correct number of type parameters.
6249 (DeclSpace.CountTypeParams): New public property.
6251 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
6252 the number of type parameters; defaults to zero.
6254 * generic.cs (TypeArguments.Count): New public property.
6255 (ConstructedType.DoResolveAsTypeStep): First call
6256 ds.FindNestedType() to find out whether we're nested in the
6257 current generic type; in this case, we inherit all type parameters
6258 from the current class.
6260 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
6261 num_type_args' argument.
6262 (RootContext.LookupType): Added overloaded version which takes the
6263 number of type arguments; only return types with the correct
6264 number of type arguments.
6266 * typemanager.cs (TypeManager.CheckGeneric): New public function;
6267 checks whether `Type t' has `int num_type_args'.
6269 2004-03-13 Martin Baulig <martin@ximian.com>
6271 * generic.cs (GenericMethod.DefineType): New method; calls
6272 DefineType() on all the type parameters.
6274 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
6275 (MethodData.Define): If we're a generic method, call
6276 GenericMethod.DefineType() to define the type parameters.
6278 2004-03-10 Martin Baulig <martin@ximian.com>
6280 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
6281 instead of IsAssignableFrom.
6283 2004-03-10 Martin Baulig <martin@ximian.com>
6285 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
6287 * support.cs (ParameterData.HasArrayParameter): New property.
6288 (ReflectionParameters.ctor): Take a MethodBase instead of a
6289 ParameterInfo[]. If we have any type parameters, get the generic
6290 method definition and ask it whether we have variable arguments.
6292 2004-02-26 Miguel de Icaza <miguel@ximian.com>
6294 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
6295 routines to check if a type is an enumerable/enumerator allow
6296 classes that implement the IEnumerable or IEnumerator interfaces.
6298 * class.cs (Property, Operator): Implement IIteratorContainer, and
6299 implement SetYields.
6301 (Property.Define): Do the block swapping for get_methods in the
6302 context of iterators. We need to check if Properties also
6303 include indexers or not.
6305 (Operator): Assign the Block before invoking the
6306 OperatorMethod.Define, so we can trigger the Iterator code
6309 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
6310 Property and Operator classes are not created when we parse the
6311 declarator but until we have the block completed, so we use a
6312 singleton SimpleIteratorContainer.Simple to flag whether the
6313 SetYields has been invoked.
6315 We propagate this setting then to the Property or the Operator to
6316 allow the `yield' to function.
6318 2004-02-25 Marek Safar <marek.safar@seznam.cz>
6320 * codegen.cs: Implemented attribute support for modules.
6321 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
6322 Assembly/Module functionality.
6324 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
6325 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
6326 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
6328 2004-02-16 Marek Safar <marek.safar@seznam.cz>
6330 * interface.cs (FindMembers): The operation is performed on all base
6331 interfaces and not only on the first. It is required for future CLS Compliance patch.
6333 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
6335 * statement.cs, codegen.cs:
6336 This patch deals with patterns such as:
6338 public class List : IEnumerable {
6340 public MyEnumerator GetEnumerator () {
6341 return new MyEnumerator(this);
6344 IEnumerator IEnumerable.GetEnumerator () {
6348 public struct MyEnumerator : IEnumerator {
6353 Before, there were a few things we did wrong:
6354 1) we would emit callvirt on a struct, which is illegal
6355 2) we emited ldarg when we needed to emit ldarga
6356 3) we would mistakenly call the interface methods on an enumerator
6357 type that derived from IEnumerator and was in another assembly. For example:
6359 public class MyEnumerator : IEnumerator
6361 Would have the interface methods called, even if there were public impls of the
6362 method. In a struct, this lead to invalid IL code.
6364 2004-02-11 Marek Safar <marek.safar@seznam.cz>
6366 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
6369 * delegate.cs (Define): Fixed crash when delegate type is undefined.
6371 2004-02-11 Miguel de Icaza <miguel@ximian.com>
6373 * cs-parser.jay: Fix small regression: we were not testing V2
6374 compiler features correctly.
6376 * interface.cs: If the emit context is null, then create one
6378 2004-02-09 Marek Safar <marek.safar@seznam.cz>
6380 * decl.cs (GetSignatureForError): New virtual method to get full name
6383 * attribute.cs (IAttributeSupport): New interface for attribute setting.
6384 Now it is possible to rewrite ApplyAttributes method to be less if/else.
6386 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
6387 Duplicated members and code in these classes has been removed.
6388 Better encapsulation in these classes.
6390 2004-02-07 Miguel de Icaza <miguel@ximian.com>
6392 * assign.cs (Assign.DoResolve): When dealing with compound
6393 assignments, there is a new rule in ECMA C# 2.4 (might have been
6394 there before, but it is documented here) that states that in:
6398 If b is of type int, and the `op' is a shift-operator, then the
6399 above is evaluated as:
6403 * expression.cs (Binary.ResolveOperator): Instead of testing for
6404 int/uint/long/ulong, try to implicitly convert to any of those
6405 types and use that in pointer arithmetic.
6407 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
6408 method to print information for from the type, not from the
6409 null-method we were given.
6411 2004-02-01 Duncan Mak <duncan@ximian.com>
6413 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
6414 parsing for cmd, fixes bug #53694.
6416 2004-02-04 Marek Safar <marek.safar@seznam.cz>
6418 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
6419 in the member name duplication tests. Property and operator name duplication
6420 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
6422 2004-02-03 Marek Safar <marek.safar@seznam.cz>
6424 * interface.cs (PopulateMethod): Fixed crash when interface method
6425 returns not existing type (error test cs0246-3.cs).
6427 2004-02-02 Ravi Pratap M <ravi@ximian.com>
6429 * cs-parser.jay (interface_accessors): Re-write actions to also
6430 store attributes attached to get and set methods. Fix spelling
6433 (inteface_property_declaration): Modify accordingly.
6435 (InterfaceAccessorInfo): New helper class to store information to pass
6436 around between rules that use interface_accessors.
6438 * interface.cs (Emit): Apply attributes on the get and set
6439 accessors of properties and indexers too.
6441 * attribute.cs (ApplyAttributes): Modify accordingly to use the
6442 right MethodBuilder when applying attributes to the get and set accessors.
6444 2004-01-31 Miguel de Icaza <miguel@ximian.com>
6446 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
6448 2004-01-26 Miguel de Icaza <miguel@ximian.com>
6450 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
6452 2004-01-25 Miguel de Icaza <miguel@ximian.com>
6454 * cs-parser.jay: Remove YIELD token, instead use the new grammar
6455 changes that treat `yield' specially when present before `break'
6458 * cs-tokenizer.cs: yield is no longer a keyword.
6460 2004-01-23 Marek Safar <marek.safar@seznam.cz>
6462 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
6463 setting for default constructors.
6464 For default constructors are almost every time set wrong Modifier. The
6465 generated IL code has been alright. But inside mcs this values was
6466 wrong and this was reason why several of my CLS Compliance tests
6469 2004-02-27 Martin Baulig <martin@ximian.com>
6471 * generics.cs (ConstructedType.ResolveType): Make the nested type
6472 stuff actually work.
6474 2004-02-25 Martin Baulig <martin@ximian.com>
6476 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
6477 property; returns the type parameters just from the current type,
6478 ie. with the ones from outer classes.
6479 (DeclSpace.LookupGeneric): First search in the current class, then
6481 (DeclSpace.initialize_type_params): When hiding a type parameter
6482 from an outer class, put it into the `type_param_list' anyways.
6484 * expression.cs (MemberAccess.expr): Made this field protected.
6486 * class.cs (TypeContainer.Define): The `CurrentType' just contains
6487 the type parameters from the current class.
6489 * generic.cs (ConstructedType.ResolveType): Support nested generic
6490 types by taking the type parameters which we inherit from outer
6491 classes into account.
6492 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
6493 support for nested generic types.
6495 2004-02-23 Martin Baulig <martin@ximian.com>
6497 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
6498 field and check whether we're nested inside a generic type.
6499 (DeclSpace.ResolveType): If we're resolving to a generic type
6500 definition, create a ConstructedType and return its resolved type.
6501 (DeclSpace.initialize_type_params): New private method;
6502 initializes the `type_param_list' field from the type parameters
6503 from this and all enclosing classes.
6504 (DeclSpace.TypeParameters): Call initialize_type_params() unless
6505 we're already initialized.
6507 2004-02-23 Martin Baulig <martin@ximian.com>
6509 * class.cs (Method.Define): Create the generic method before
6511 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
6512 the TypeContainer one); we use this for generic methods.
6514 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
6515 parent's TypeBuilder.
6517 2004-02-18 Martin Baulig <martin@ximian.com>
6519 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
6520 to check for equality.
6522 2004-02-05 Martin Baulig <martin@ximian.com>
6524 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
6525 `ec.TypeContainer.CurrentType', use it instead of
6526 `ec.ContainerType' to check whether we're in the type's ctor.
6528 2004-01-29 Martin Baulig <martin@ximian.com>
6530 * expression.cs (Invocation.DoResolve): If we're a
6531 `ConstructedType', then we're actually a generic method, so
6532 rewrite the expr as a GenericMemberAccess.
6534 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
6535 here; manually parse it into a string.
6537 2004-01-28 Martin Baulig <martin@ximian.com>
6539 * typemanager.cs (TypeManager.IsEqual): New static method.
6540 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
6541 check for equality instead of using `=='.
6543 2004-01-26 Martin Baulig <martin@ximian.com>
6545 * decl.cs (DeclSpace.CurrentType): New public field.
6547 * expression.cs (This.ResolveBase): If we have an
6548 `ec.TypeContainer.CurrentType', use it instead of
6551 * class.cs (TypeContainer.DefineType): If we're a generic type,
6552 create the `CurrentType' (unresolved).
6553 (TypeContainer.GenericType): New private field.
6554 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
6555 it and store it in `GenericType' before creating the MemberCache.
6556 (TypeContainer.GetMembers): If we have a `GenericType', call
6557 TypeManager.FindMembers() on it.
6559 * interface.cs (Interface.GenericType): New private field.
6560 (Interface.DefineType): If we're a generic type, create the
6561 `CurrentType' (unresolved).
6562 (Interface.DefineMembers): If we have a `CurrentType', resolve it
6563 and store it in `GenericType' before creating the MemberCache.
6564 (Interface.GetMembers): If we have a `GenericType', call
6565 TypeManager.FindMembers() on it.
6567 2004-01-22 Martin Baulig <martin@ximian.com>
6569 * cs-parser.jay (namespace_or_type_name): Return an Expression,
6570 not a QualifiedIdentifier. This is what `type_name_expression'
6571 was previously doing.
6572 (type_name_expression): Removed; the code is now in
6573 `namespace_or_type_name'.
6574 (qualified_identifier): Removed, use `namespace_or_type_name'
6576 (QualifiedIdentifier): Removed this class.
6578 2004-01-22 Martin Baulig <martin@ximian.com>
6580 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
6581 not a string as alias name.
6583 2004-01-21 Miguel de Icaza <miguel@ximian.com>
6585 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
6586 #52730 bug, and instead compute correctly the need to use a
6587 temporary variable when requesting an address based on the
6588 static/instace modified of the field and the constructor.
6590 2004-01-21 Martin Baulig <martin@ximian.com>
6592 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
6593 class and namespace before looking up aliases. Fixes #52517.
6595 2004-01-21 Martin Baulig <martin@ximian.com>
6597 * flowanalysis.cs (UsageVector.Merge): Allow variables being
6598 assinged in a 'try'; fixes exception4.cs.
6600 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6601 * class.cs : Implemented parameter-less constructor for TypeContainer
6603 * decl.cs: Attributes are now stored here. New property OptAttributes
6605 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
6607 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
6609 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6611 * typemanager.cs (CSharpSignature): Now reports also inner class name.
6612 (CSharpSignature): New method for indexer and property signature.
6614 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6616 * pending.cs (IsVirtualFilter): Faster implementation.
6618 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6620 * typemanager.cs: Avoid inclusion of same assembly more than once.
6622 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6624 * cs-parser.jay: Fixed problem where the last assembly attribute
6625 has been applied also to following declaration (class, struct, etc.)
6627 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6629 * class.cs: Added error CS0538, CS0539 reporting.
6630 Fixed crash on Microsoft runtime when field type is void.
6632 * cs-parser.jay: Added error CS0537 reporting.
6634 * pending.cs: Added error CS0535 reporting.
6635 Improved error report for errors CS0536, CS0534.
6637 2004-01-20 Miguel de Icaza <miguel@ximian.com>
6639 Merge a few bits from the Anonymous Method MCS tree.
6641 * statement.cs (ToplevelBlock): New class for toplevel methods,
6642 will hold anonymous methods, lifted variables.
6644 * cs-parser.jay: Create toplevel blocks for delegates and for
6645 regular blocks of code.
6647 2004-01-20 Martin Baulig <martin@ximian.com>
6649 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
6650 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
6651 and `NeedExplicitReturn'; added `IsLastStatement'.
6652 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
6653 have a `ReturnLabel' or we're not unreachable.
6655 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
6656 child's reachability; don't just override ours with it. Fixes
6657 #58058 (lluis's example).
6658 (FlowBranching): Added public InTryOrCatch(), InCatch(),
6659 InFinally(), InLoop(), InSwitch() and
6660 BreakCrossesTryCatchBoundary() methods.
6662 * statement.cs (Return): Do all error checking in Resolve().
6663 Unless we are the last statement in a top-level block, always
6664 create a return label and jump to it.
6665 (Break, Continue): Do all error checking in Resolve(); also make
6666 sure we aren't leaving a `finally'.
6667 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
6668 statement in a top-level block.
6669 (Block.Flags): Added `IsDestructor'.
6670 (Block.IsDestructor): New public property.
6672 2004-01-20 Martin Baulig <martin@ximian.com>
6674 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
6676 2004-01-20 Martin Baulig <martin@ximian.com>
6678 * statement.cs (Statement.ResolveUnreachable): New public method.
6679 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
6680 (Block.Resolve): Resolve unreachable statements.
6682 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
6684 * expression.cs: We need to fix the case where we do
6685 not have a temp variable here.
6687 * assign.cs: Only expression compound assignments need
6688 temporary variables.
6690 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
6692 * flowanalysis.cs: Reduce memory allocation in a few ways:
6693 - A block with no variables should not allocate a bit
6695 - A method with no out parameters does not need any tracking
6696 for assignment of the parameters, so we need not allocate
6699 public readonly Type[] VariableTypes;
6700 public readonly string[] VariableNames;
6701 Are redundant. The data is already stored in the variable
6702 map, so we need not allocate another array for it.
6703 - We need to add alot of checks for if (params | locals) == null
6704 due to the first two changes.
6706 2004-01-18 Miguel de Icaza <miguel@ximian.com>
6708 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
6709 implement IMemoryLocation, we store a copy on a local variable and
6710 take the address of it. Patch from Benjamin Jemlich
6712 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
6713 to use a special "type_name_expression" rule which reduces the
6714 number of "QualifiedIdentifier" classes created, and instead
6715 directly creates MemberAccess expressions.
6717 2004-01-17 Miguel de Icaza <miguel@ximian.com>
6719 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
6720 that fixes #52853. Null literal assignment to ValueType
6722 * class.cs (MethodData.Emit): Instead of checking the name of the
6723 method to determine if its a destructor, create a new derived
6724 class from Method called Destructor, and test for that.
6726 * cs-parser.jay: Create a Destructor object instead of a Method.
6728 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
6732 2004-01-16 Miguel de Icaza <miguel@ximian.com>
6734 * expression.cs (Binary.ResolveOperator): Perform an implicit
6735 conversion from MethodGroups to their delegate types on the
6738 * delegate.cs: Introduce a new class DelegateCreation that is the
6739 base class for `NewDelegate' and `ImplicitDelegateCreation',
6740 factor some code in here.
6742 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
6743 conversion from MethodGroups to compatible delegate types.
6745 * ecore.cs (Expression.Resolve): Do not flag error 654
6746 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
6747 we allow conversions from MethodGroups to delegate types now.
6749 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
6750 assignments in v2 either.
6752 2004-01-10 Miguel de Icaza <miguel@ximian.com>
6754 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
6755 static read-only fields in ctors.
6757 Applied patch from Benjamin Jemlich
6759 * expression.cs (UnaryMutator): Avoid leaking local variables.
6761 2004-01-09 Miguel de Icaza <miguel@ximian.com>
6763 * cs-tokenizer.cs (IsCastToken): Allow the various native types
6764 here to return true, as they can be used like this:
6768 Fixed 49836 and all the other dups
6770 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
6772 * driver.cs: Implement /win32res and /win32icon.
6774 2004-01-08 Miguel de Icaza <miguel@ximian.com>
6776 * cs-parser.jay: Add a rule to improve error handling for the
6777 common mistake of placing modifiers after the type.
6779 2004-01-07 Miguel de Icaza <miguel@ximian.com>
6781 * cs-parser.jay (interface_event_declaration): Catch
6782 initialization of events on interfaces, and report cs0068
6784 * cs-parser.jay (interface_event_declaration): Catch
6785 initialization of events.
6787 * ecore.cs: Better report missing constructors.
6789 * expression.cs (Binary.ResolveOperator): My previous bug fix had
6790 the error reporting done in the wrong place. Fix.
6792 * expression.cs (Binary.ResolveOperator): Catch the
6793 operator + (E x, E y) error earlier, and later allow for implicit
6794 conversions in operator +/- (E e, U x) from U to the underlying
6797 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
6798 52596, if the container class is abstract, the default constructor
6799 is protected otherwise its public (before, we were always public).
6801 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
6804 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
6805 Jemlich that fixes bug #52597, MCS was generating invalid code for
6806 idisposable structs. Thanks to Ben for following up with this
6809 2004-01-06 Miguel de Icaza <miguel@ximian.com>
6811 * driver.cs: Allow assemblies without code to be generated, fixes
6814 2004-01-07 Nick Drochak <ndrochak@gol.com>
6816 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
6818 2004-01-05 Miguel de Icaza <miguel@ximian.com>
6820 * cs-parser.jay: Add rules to improve error reporting if fields or
6821 methods are declared at the namespace level (error 116)
6823 * Add rules to catch event add/remove
6825 2004-01-04 David Sheldon <dave-mono@earth.li>
6827 * expression.cs: Added matching ")" to error message for
6830 2004-01-03 Todd Berman <tberman@gentoo.org>
6832 * ecore.cs, attribute.cs:
6833 Applying fix from #52429.
6835 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6837 * ecore.cs, expression.cs, statement.cs:
6838 Total rewrite of how we handle branching. We
6839 now handle complex boolean expressions with fewer
6840 jumps. As well if (x == 0) no longer emits a ceq.
6842 if (x is Foo) is much faster now, because we generate
6845 Overall, we get a pretty big improvement on our benchmark
6846 tests. The code we generate is smaller and more readable.
6848 I did a full two-stage bootstrap. The patch was reviewed
6849 by Martin and Miguel.
6851 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6853 * cs-parser.jay: Make primary_expression not take a QI.
6854 we dont need this because the member_access rule covers
6855 us here. So we replace the rule with just IDENTIFIER.
6857 This has two good effects. First, we remove a s/r conflict.
6858 Second, we allocate many fewer QualifiedIdentifier objects.
6860 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6862 * attribute.cs: Handle MarshalAs attributes as pseudo, and
6863 set the correct information via SRE. This prevents
6864 hanging on the MS runtime. Fixes #29374.
6866 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6868 * convert.cs: correctly handle conversions to value types
6869 from Enum and ValueType as unboxing conversions.
6871 Fixes bug #52569. Patch by Benjamin Jemlich.
6873 2004-01-02 Ravi Pratap <ravi@ximian.com>
6875 * expression.cs (BetterConversion): Prefer int -> uint
6876 over int -> ulong (csc's behaviour). This fixed bug #52046.
6878 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
6880 * decl.cs (MemberCache.FindMembers): now returns a
6883 * typemanager.cs: In general, go with with ^^.
6884 (CopyNewMethods): take an IList.
6885 (RealMemberLookup): Only allocate an arraylist
6886 if we copy from two sets of methods.
6888 This change basically does two things:
6889 1) Fewer array lists allocated due to CopyNewMethods.
6890 2) the explicit cast in MemberList costed ALOT.
6892 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
6894 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
6895 a hashtable to avoid needless string allocations when an identifier is
6896 used more than once (the common case).
6898 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
6900 * pending.cs: MS's TypeBuilder.GetInterfaces ()
6901 is broken, it will not return anything. So, we
6902 have to use the information we have in mcs to
6905 * typemanager.cs: Add a cache for GetInterfaces,
6906 since this will now be used more often (due to ^^)
6908 (GetExplicitInterfaces) New method that gets the
6909 declared, not effective, interfaces on a type
6910 builder (eg, if you have interface IFoo, interface
6911 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
6914 This patch makes MCS able to bootstrap itself on
6917 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
6919 * expression.cs: Remove the Nop's that Miguel put
6922 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
6924 * report.cs, codegen.cs: Give the real stack trace to
6925 the error when an exception is thrown.
6927 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
6929 * decl.cs: only allocate hashtables for ifaces if
6932 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
6934 * expression.cs: fix the error from cs0121-2.cs
6935 (a parent interface has two child interfaces that
6936 have a function with the same name and 0 params
6937 and the function is called through the parent).
6939 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
6941 * class.cs, rootcontext.cs, typmanager.cs: do not
6944 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
6946 * codegen.cs: remove stack for the ec flow branching.
6947 It is already a linked list, so no need.
6949 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
6951 * Makefile: Allow custom profiler here.
6953 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
6955 * typemanager.cs (LookupType):
6956 - Use a static char [], because split takes
6957 a param array for args, so it was allocating
6959 - Do not store true in a hashtable, it boxes.
6961 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
6963 * flowanalysis.cs: bytify common enums.
6965 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
6967 * modifiers.cs: Add a new set of flags for the
6968 flags allowed on explicit interface impls.
6969 * cs-parser.jay: catch the use of modifiers in
6970 interfaces correctly.
6971 * class.cs: catch private void IFoo.Blah ().
6973 All related to bug #50572.
6975 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
6977 * decl.cs: Rewrite the consistant accessability checking.
6978 Accessability is not linear, it must be implemented in
6979 a tableish way. Fixes #49704.
6981 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
6983 * expression.cs: Handle negation in a checked context.
6984 We must use subtraction from zero. Fixes #38674.
6986 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
6988 * class.cs: Ignore static void main in DLLs.
6989 * rootcontext.cs: Handle the target type here,
6990 since we are have to access it from class.cs
6991 * driver.cs: account for the above.
6993 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
6995 * report.cs: Give line numbers and files if available.
6997 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
6999 * driver.cs: Implement /addmodule.
7001 * typemanager.cs: Change 'modules' field so it now contains Modules not
7004 2003-12-20 Martin Baulig <martin@ximian.com>
7006 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
7007 (FieldBase.IsAssigned): Removed this field.
7008 (FieldBase.SetAssigned): New public method.
7009 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
7011 2003-12-20 Martin Baulig <martin@ximian.com>
7013 * expression.cs (LocalVariableReference.DoResolve): Don't set
7014 `vi.Used' if we're called from DoResolveLValue().
7016 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
7017 returns the usage vector it just merged into the current one -
7018 pass this one to UsageWarning().
7019 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
7020 of the `EmitContext', don't call this recursively on our children.
7022 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
7024 * driver.cs: Implement /target:module.
7026 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
7028 * support.cs (CharArrayHashtable): New helper class.
7030 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
7031 char arrays, not strings, so we can avoid creating a string in
7032 consume_identifier if the identifier is a keyword.
7034 2003-12-16 Martin Baulig <martin@ximian.com>
7036 * statement.cs (LocalInfo.Assigned): Removed this property.
7037 (LocalInfo.Flags): Removed `Assigned'.
7038 (LocalInfo.IsAssigned): New public method; takes the EmitContext
7039 and uses flow analysis.
7040 (Block.UsageWarning): Made this method private.
7041 (Block.Resolve): Call UsageWarning() if appropriate.
7043 * expression.cs (LocalVariableReference.DoResolve): Always set
7044 LocalInfo.Used here.
7046 2003-12-13 Martin Baulig <martin@ximian.com>
7048 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
7049 any value here; we're now using flow analysis to figure out
7050 whether a statement/block returns a value.
7052 2003-12-13 Martin Baulig <martin@ximian.com>
7054 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
7056 (FlowBranching.MergeFinally): Don't call
7057 `branching.CheckOutParameters()' here, this is called in
7059 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
7060 when adding the `finally' vector.
7062 2003-12-13 Martin Baulig <martin@ximian.com>
7065 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
7066 actually work and also fix #48962.
7068 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
7070 * decl.cs: Do not check System.Object for nested types,
7071 since we know it does not have any. Big bang for buck:
7076 corlib: 17.99 seconds
7080 corlib: 17.39 seconds
7082 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
7084 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
7085 time we are returning 0 members, so we save alot here.
7087 2003-12-11 Martin Baulig <martin@ximian.com>
7089 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
7090 `MergeChild()', also just take the `FlowBranching' as argument;
7091 call Merge() on it and return the result.
7092 (FlowBranching.Merge): We don't need to do anything if we just
7095 2003-12-11 Martin Baulig <martin@ximian.com>
7097 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
7098 them in an `ArrayList' to reduce memory usage. Thanks to Ben
7099 Maurer for this idea.
7101 2003-12-11 Martin Baulig <martin@ximian.com>
7103 * flowanalysis.cs (MergeResult): This class is now gone; we now
7104 use the `UsageVector' for this. The reason for this is that if a
7105 branching just has one sibling, we don't need to "merge" them at
7106 all - that's the next step to do.
7107 (FlowBranching.Merge): We now return a `UsageVector' instead of a
7110 2003-12-11 Martin Baulig <martin@ximian.com>
7112 Reworked flow analyis and made it more precise and bug-free. The
7113 most important change is that we're now using a special `Reachability'
7114 class instead of having "magic" meanings of `FlowReturns'. I'll
7115 do some more cleanups and optimizations and also add some more
7116 documentation this week.
7118 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
7119 largely reworked this class.
7120 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
7121 the new `Reachability' class instead of having "magic" values here.
7122 (FlowBranching): We're now using an instance of `Reachability'
7123 instead of having separate `Returns', `Breaks' etc. fields.
7125 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
7126 based on flow analysis; ignore the return value of block.Emit ().
7128 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
7130 * driver.cs typemanager.cs: Find the mono extensions to corlib even
7131 if they are private.
7133 2003-12-09 Martin Baulig <martin@ximian.com>
7135 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
7136 call them directly on the UsageVector.
7138 2003-12-09 Martin Baulig <martin@ximian.com>
7140 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
7141 Changed return type from `FlowReturns' to `Reachability'.
7143 2003-12-09 Martin Baulig <martin@ximian.com>
7145 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
7146 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
7147 `Reachable' fields with a single `Reachability' one.
7149 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
7151 * class.cs (FindMembers): Remove foreach's.
7164 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
7169 This patch does a few things:
7170 1. EmptyStatement is now a singleton, so it is never reallocated.
7171 2. All blah is EmptyStatement constructs have been changed to
7172 blah == EmptyStatement.Value, which is much faster and valid
7173 now that EmptyStatement is a singleton.
7174 3. When resolving a block, rather than allocating a new array for
7175 the non-empty statements, empty statements are replaced with
7176 EmptyStatement.Value
7177 4. Some recursive functions have been made non-recursive.
7178 Mainly the performance impact is from (3), however (1) and (2) are needed for
7179 this to work. (4) does not make a big difference in normal situations, however
7180 it makes the profile look saner.
7185 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
7186 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
7187 Total memory allocated: 56397 KB
7190 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
7191 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
7192 Total memory allocated: 55666 KB
7194 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
7196 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
7197 than the hashtable in a hashtable version
7199 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
7200 we always end up concating a string. This results in a huge perf
7201 loss, because many strings have to be tracked by the GC. In this
7202 patch, we first use a hashtable that works with two keys, so that
7203 the strings do not need to be concat'ed.
7214 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
7216 * Makefile: Add a new target `do-time' that does a quick and simple
7217 profile, leaving easy to parse output.
7219 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
7221 * codegen.cs (Init): Create the dynamic assembly with
7222 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
7224 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
7226 * support.cs: Make the PtrHashtable use only one
7227 instance of its comparer.
7229 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
7231 * typemanager.cs: Fix lookup of GetNamespaces.
7233 2003-11-29 Miguel de Icaza <miguel@ximian.com>
7235 * expression.cs: Removed redundant line.
7237 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
7238 ArrayLists, use for loops with bounds.
7240 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
7243 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
7244 arraylists, use for loop with bounds.
7246 The above three changes give us a 0.071 second performance
7247 improvement out of 3.294 seconds down to 3.223. On my machine
7248 the above changes reduced the memory usage by 1,387 KB during
7251 * cs-parser.jay (QualifiedIdentifier): New class used to represent
7252 QualifiedIdentifiers. Before we created a new string through
7253 concatenation, and mostly later on, the result would be
7254 manipulated by DecomposeQI through string manipulation.
7256 This reduced the compiler memory usage for bootstrapping from
7257 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
7258 compile times in 0.05 seconds.
7260 2003-11-28 Dick Porter <dick@ximian.com>
7262 * support.cs: Do string compares with the Invariant culture.
7270 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
7271 the comparison is done with the Invariant culture.
7273 2003-11-27 Miguel de Icaza <miguel@ximian.com>
7275 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
7276 GetEnumerator method.
7278 (ProbeCollectionType): Iterate starting at the most specific type
7279 upwards looking for a GetEnumerator
7281 * expression.cs: Shift count can be up to 31 for int/uint and 63
7284 2003-11-26 Miguel de Icaza <miguel@ximian.com>
7286 * statement.cs (Block.LookupLabel): Also look for the label on the
7287 children blocks. Use a hash table to keep track of visited
7290 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
7291 we actually did transform the other operand, otherwise fall back
7292 to the common codepath that casts to long.
7294 * cs-tokenizer.cs: Use the same code pattern as the int case.
7295 Maybe I should do the parsing myself, and avoid depending on the
7296 Parse routines to get this done.
7298 2003-11-25 Miguel de Icaza <miguel@ximian.com>
7300 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
7301 which fixes bug 51347. This time test it.
7303 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
7304 attributes for example can not tell the difference between these.
7305 The difference was only a syntax feature of the language.
7307 * attribute.cs: Apply attributes to delegates.
7309 * delegate.cs: Call the apply attributes method.
7311 2003-11-24 Miguel de Icaza <miguel@ximian.com>
7313 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
7314 comparing 0 vs Byte.MinValue, not the value
7316 (ImplicitConversionRequired): When reporting a conversion error,
7317 use error 31 to print out the constant error instead of the
7320 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
7321 which fixes bug 51347.
7323 2003-11-22 Miguel de Icaza <miguel@ximian.com>
7325 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
7326 which fixes the -warnaserror command line option.
7328 2003-11-21 Miguel de Icaza <miguel@ximian.com>
7330 * cfold.cs (DoNumericPromotions): During constant folding of
7331 additions on UIntConstant, special case intconstants with
7332 IntConstants like we do on the expression binary operator.
7334 2003-11-12 Miguel de Icaza <miguel@ximian.com>
7336 * convert.cs (ImplicitReferenceConversion): We were missing a case
7337 (System.Enum are not value types or class types, so we need to
7338 classify them separatedly).
7340 * driver.cs: We do not support error 2007.
7342 2003-11-12 Jackson Harper <jackson@ximian.com>
7344 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
7345 system directory. Also use the full file name so users can
7346 libraries names mscorlib-o-tron.dll in a non system dir.
7348 2004-01-04 David Sheldon <dave-mono@earth.li>
7350 * expression.cs: Added matching ")" to error message for CS0077.
7352 2003-12-19 Martin Baulig <martin@ximian.com>
7354 * typemanager.cs (TypeManager.IsEqualGenericType): New public
7355 static method; see documentation in the method.
7356 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
7358 * convert.cs (Convert.ImplicitReferenceConversion,
7359 Convert.ImplicitReferenceConversionExists): Add support for
7360 generic type declarations; see gen-36.cs.
7362 2003-12-19 Martin Baulig <martin@ximian.com>
7364 * pending.cs (Pending.InterfaceMethod): Use
7365 `Type.IsAssignableFrom()' instead of `=='.
7367 2003-12-18 Martin Baulig <martin@ximian.com>
7369 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
7372 * convert.cs (Convert.ImplicitStandardConversionExists): Use
7373 `expr_type.Equals (target_type)' instead of `=='.
7375 2003-12-08 Martin Baulig <martin@ximian.com>
7377 * generics.cs (Constraints.Types): Removed.
7378 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
7380 (Constraints.ResolveTypes): New public method; resolves the
7381 TypeExpr's to Type's.
7382 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
7383 longer takes the constraints.
7384 (TypeParameter.DefineMethod): Likewise.
7385 (TypeParameter.DefineType): New public method. Calls
7386 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
7389 2003-12-08 Martin Baulig <martin@ximian.com>
7391 * convert.cs (Convert.ImplicitConversionStandard): Use
7392 `expr_type.Equals (target_type)' instead of `=='.
7394 2003-12-08 Martin Baulig <martin@ximian.com>
7396 * typemanager.cs (TypeManager.GetReferenceType): Call
7397 `Type.MakeByRefType ()'.
7399 2003-12-08 Martin Baulig <martin@ximian.com>
7401 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
7402 just has some special meaning in some situations. For instance,
7403 it is allowed to use `where' as the name of a variable etc.
7405 2003-12-04 Martin Baulig <martin@ximian.com>
7407 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
7408 `Type.MakeArrayType()' for array types.
7410 2003-11-18 Miguel de Icaza <miguel@ximian.com>
7412 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
7415 (SizeOf.DoResolve): assign the `type_queried' field. This gets
7418 2003-11-16 Martin Baulig <martin@ximian.com>
7420 * codegen.cs (EmitContext.IsGeneric): Removed.
7422 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
7423 ResolveGeneric() on the DeclSpace.
7425 2003-11-16 Martin Baulig <martin@ximian.com>
7427 * generic.cs (TypeArguments.Resolve):
7428 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
7429 `ResolveType()' on it to get the Type.
7431 2003-11-15 Martin Baulig <martin@ximian.com>
7433 * generic.cs (ConstructedType.GetInterfaces): Override this.
7435 2003-11-14 Martin Baulig <martin@ximian.com>
7437 * interface.cs (Interface.DefineType): Define all type parameters
7438 before adding the interfaces we inherit.
7440 2003-11-11 Martin Baulig <martin@ximian.com>
7442 * generic.cs (ConstructedType.ResolveType): Always call
7443 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
7445 2003-11-10 Martin Baulig <martin@ximian.com>
7447 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
7448 (TypeManager.InitCoreTypes): Initialize them here, but instead of
7449 calling `ResolveType()' on them, directly assign their `Type'.
7451 2003-11-08 Martin Baulig <martin@ximian.com>
7453 * generic.cs (ConstructedType): Override `IsClass' etc.
7455 2003-11-08 Martin Baulig <martin@ximian.com>
7457 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
7458 return value and the `out parent' parameter.
7459 (TypeContainer.DefineType): Moved the CS0644 check into
7460 GetClassBases(). Don't pass the interface types to the
7461 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
7462 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
7464 * ecore.cs (TypeExpr.IsAttribute): New property.
7465 (TypeExpr.GetInterfaces): New method.
7467 * interface.cs (Interface.GetInterfaceTypeByName): Return a
7468 TypeExpr instead of a Type.
7469 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
7470 (Interface.DefineType): Don't pass the interface types to the
7471 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
7472 them later and then call `TypeBulider.AddInterfaceImplementation()'.
7474 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
7475 instead of a `Type[]'.
7476 (TypeManager.RegisterBuilder): Likewise.
7477 (TypeManager.AddUserInterface): Likewise.
7478 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
7479 `Type[]' and also return a `TypeExpr[]'.
7480 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
7482 2003-11-08 Martin Baulig <martin@ximian.com>
7484 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
7487 2003-11-08 Martin Baulig <martin@ximian.com>
7489 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
7490 TypeManager.ResolveExpressionTypes().
7492 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
7493 instead of an Expression.
7494 (TypeExpr): This is now an abstract base class for `TypeExpression'.
7495 (TypeExpression): New public class; formerly known as `TypeExpr'.
7497 * expression.cs (ComposedCast): Derive from TypeExpr.
7499 * typemanager.cs (TypeManager.system_*_expr): These are now
7500 TypExpr's instead of Expression's.
7501 (TypeManager.ResolveExpressionTypes): New public static function;
7502 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
7505 2003-11-06 Miguel de Icaza <miguel@ximian.com>
7507 * expression.cs (New.DoResolve): Do not dereference value that
7508 might be a null return.
7510 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
7511 sure that the constant value has the right type. Fixes an
7512 unreported bug, similar to 50425.
7514 * const.cs (Const.LookupConstantValue): Call
7515 ImplicitStandardConversionExists before doing a conversion to
7516 avoid havng the TypeManager.ChangeType do conversions.
7518 Reduced the number of casts used
7520 (Const.ChangeType): New routine to enable reuse of the constant
7521 type changing code from statement.
7523 * typemanager.cs (ChangeType): Move common initialization to
7524 static global variables.
7528 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
7529 every value type to go through, even if it was void. Fix that.
7531 * cs-tokenizer.cs: Use is_identifier_start_character on the start
7532 character of the define, and the is_identifier_part_character for
7533 the rest of the string.
7535 2003-11-05 Miguel de Icaza <miguel@ximian.com>
7537 * expression.cs (UnaryMutator.EmitCode): When I updated
7538 LocalVariableReference.DoResolve, I overdid it, and dropped an
7539 optimization done on local variable references.
7541 2003-11-04 Miguel de Icaza <miguel@ximian.com>
7543 * ecore.cs: Convert the return from Ldlen into an int.
7545 2003-10-20 Miguel de Icaza <miguel@ximian.com>
7547 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
7548 the accessibility, this is a special case for toplevel non-public
7549 classes (internal for instance).
7551 2003-10-20 Nick Drochak <ndrochak@gol.com>
7553 * ecore.cs: Fix typo and build. Needed another right paren.
7555 2003-10-19 Miguel de Icaza <miguel@ximian.com>
7557 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
7558 `internal' case regular and protected, but not allowing protected
7559 to be evaluated later. Bug 49840
7561 2003-10-15 Miguel de Icaza <miguel@ximian.com>
7563 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
7564 to kb.Nlast, and not the kb.nFirst to isolate the switch
7567 Extract the underlying type, so enumerations of long/ulong are
7568 treated like long/ulong.
7570 2003-10-14 Miguel de Icaza <miguel@ximian.com>
7572 * expression.cs (New): Overload the meaning of RequestedType to
7573 track the possible creation of the NewDelegate type, since
7574 DoResolve is invoked more than once for new constructors on field
7577 See bugs: #48800 and #37014
7579 * cs-parser.jay (declare_local_constants): Take an arraylist
7580 instead of a single constant.
7582 (local_constant_declaration): It should take a
7583 constant_declarators, not a constant_declarator. Fixes 49487
7585 * convert.cs: Fix error report.
7587 2003-10-13 Jackson Harper <jackson@ximian.com>
7589 * typemanager.cs (TypeToCoreType): Add float and double this fixes
7592 2003-11-03 Martin Baulig <martin@ximian.com>
7594 * expression.cs (ArrayAccess.GetStoreOpcode): Added
7595 `out bool has_type_arg'; if set, we need to pass the type to
7597 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
7598 Stelem_Any/Ldelem_Any for generic parameters.
7600 2003-11-02 Martin Baulig <martin@ximian.com>
7602 * expression.cs (Invocation.EmitCall): Use
7603 `TypeManager.IsValueType()' to check whether it's a value type.
7604 Don't set `struct_call' when calling a method on a type parameter.
7606 2003-11-02 Martin Baulig <martin@ximian.com>
7608 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
7609 and removed the TypeBuilder argument.
7611 * typemanager.cs (TypeManager.IsValueType): Return
7612 `t.IsGenericParameter || t.IsValueType'.
7614 2003-10-25 Martin Baulig <martin@ximian.com>
7616 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
7617 call ConstructedType.Resolve() on it.
7619 * generic.cs (ConstructedType.Resolve): Set `type' on success.
7621 2003-10-25 Martin Baulig <martin@ximian.com>
7623 * class.cs (TypeContainer.GetClassBases): Changed
7624 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
7625 CS8214 reporting here.
7626 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
7627 instead of a `Type' for our parent. In case of a recursive
7628 declaration (see tests/gen-23.cs for an example), our parent is a
7629 ConstructedType and it doesn't have its type set. So, first
7630 create our own TypeBuilder, then call constructed.Resolve() to get
7631 the parent's type and finally TypeBuilder.SetParent() it.
7633 * ecore.cs (TypeExpr.Name): New public virtual property.
7636 (ConstructedType): We're now a TypeExpr and not just an Expression.
7637 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
7638 arguments here; this is done later.
7639 (ConstructedType.Resolve): New public method to resolve the type
7640 arguments and bind them.
7642 2003-10-21 Martin Baulig <martin@ximian.com>
7644 * convert.cs: Use `TypeManager.IsValueType' instead of
7645 'type.IsValueType' everywhere.
7647 * typemanager.cs (TypeManager.IsValueType): Return true for type
7648 parameters. The reason for this is that we need to box a type
7649 parameter when converting it to a reference type.
7651 * cs-parser.jay: Added support for default value expressions.
7653 * generics.cs (DefaultValueExpression): New public class.
7655 2003-10-17 Martin Baulig <martin@ximian.com>
7657 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
7658 TypeContainer so we can also use this for Interfaces.
7659 (TypeParameter.Resolve): Likewise.
7661 * interface.cs (Interface.DefineType): Added support for generic
7664 * cs-parser.jay: Added support for generic structs and interfaces.
7666 2003-10-17 Martin Baulig <martin@ximian.com>
7668 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
7669 call generic methods :-)
7671 2003-10-16 Martin Baulig <martin@ximian.com>
7673 * cs-parser.jay (namespace_or_type_name): Only create a
7674 GenericMemberAccess if we actually have type arguments.
7676 2003-10-13 Martin Baulig <martin@ximian.com>
7678 * class.cs (Method.Define): If we're a generic method, call
7679 TypeBuilder.DefineGenericMethod () before resolving
7681 (MethodData): Added .ctor which takes an additional MethodBuilder
7682 argument; this is used for generic methods.
7683 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
7684 we already have a MethodBuilder.
7686 2003-10-10 Martin Baulig <martin@ximian.com>
7688 * class.cs (Method): Added .ctor which takes a `GenericMethod'
7689 instead of a `DeclSpace'. This is used for generic methods.
7691 * cs-parser.jay (method_header): Added support for generic
7692 methods; create a `GenericMethod' instance and pass it to the
7693 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
7694 parameters and locals.
7696 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
7697 since we already have the location. Check whether we're a generic
7698 type declaration or a generic method and create the correct type
7701 * generic.cs (TypeParameter.DefineMethod): New public method.
7702 (GenericMethod): New public class; derives from DeclSpace and is
7703 used for generic methods.
7705 2003-10-09 Martin Baulig <martin@ximian.com>
7707 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
7709 (MethodCore.DoDefineParameters): Removed the TypeContainer
7710 argument; use the DeclSpace which was passed to the .ctor instead.
7711 (MethodCore.CheckParameter): Take a DeclSpace instead of a
7712 TypeContainer; we only need a DeclSpace here.
7714 2003-10-09 Martin Baulig <martin@ximian.com>
7716 * class.cs (MethodData): Added additional `DeclSpace ds' argument
7718 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
7719 EmitContext's .ctor.
7721 2003-10-09 Martin Baulig <martin@ximian.com>
7723 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
7724 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
7725 AsAccessible(), moved them as well.
7727 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
7729 2003-10-07 Miguel de Icaza <miguel@ximian.com>
7731 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
7732 generation for >=, as spotted by Paolo, bug 48679.
7733 Patch from David Waite.
7735 * cs-tokenizer.cs: Add handling for #pragma.
7737 * cs-parser.jay: Allow for both yield and yield return in the
7738 syntax. The anti-cobolization of C# fight will go on!
7740 * class.cs (TypeBuilder.DefineType): Catch error condition here
7741 (Parent.DefineType erroring out and returning null).
7743 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
7744 coping with enumerations variables, we were mistakenly processing
7745 them as a regular value type instead of built-in types. Fixes the
7748 * typemanager.cs (IsBuiltinOrEnum): New method.
7750 2003-09-30 Miguel de Icaza <miguel@ximian.com>
7752 * cs-parser.jay: Upgrade: yield now needs the return clause.
7754 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
7756 * cs-parser.jay : Renamed yyName to yyNames related to jay.
7758 2003-09-29 Martin Baulig <martin@ximian.com>
7760 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
7761 inflated generic methods.
7763 * generics.cs (ConstructedType): Distinguish between open and
7764 closed constructed types; correctly resolve the arguments.
7766 2003-09-22 Martin Baulig <martin@ximian.com>
7768 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
7769 all type arguments meet their constraints.
7771 2003-09-19 Martin Baulig <martin@ximian.com>
7773 * decl.cs (MemberCache.SetupCacheForInterface): Take a
7774 `MemberCache parent' argument. Normally, an interface doesn't
7775 have a parent type except System.Object, but we use this in gmcs
7776 for generic type parameters.
7778 2003-09-18 Martin Baulig <martin@ximian.com>
7780 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
7781 on `type.IsInterface'; don't check whether the type has a parent
7782 to determine whether it's an interface.
7784 2003-09-17 Martin Baulig <martin@ximian.com>
7786 * generic.cs (ConstructedType.ToString): Always use `name' as the
7789 2003-09-15 Martin Baulig <martin@ximian.com>
7791 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
7793 * generic.cs (Constraints.Resolve): New public method; this is
7794 called to resolve the constraint types and to check whether all
7795 the constraints are correct.
7796 (Constraints.Types): New public property.
7797 (TypeParameter.Resolve): New public method; resolves all the
7800 * class.cs (TypeContainer.DefineType): Call
7801 TypeParameter.Resolve() before actually defining the type.
7803 2003-09-15 Martin Baulig <martin@ximian.com>
7805 * class.cs (TypeContainer.DefineType): Added an error flag to
7806 avoid reporting duplicate CS0146's ("class definition is
7809 * driver.cs (Driver.MainDriver): Abort if
7810 RootContext.ResolveTree() reported any errors.
7812 2003-09-07 Martin Baulig <martin@ximian.com>
7814 * report.cs (Error, Warning): Added overloaded versions which take
7815 a `params object[] args' and call String.Format().
7817 2003-09-07 Martin Baulig <martin@ximian.com>
7819 * decl.cs (DeclSpace..ctor): Don't call
7820 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
7821 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
7822 (DeclSpace.RecordDecl): New method.
7824 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
7826 2003-09-02 Ravi Pratap <ravi@ximian.com>
7828 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
7829 value attributes to be applied to ParameterBuilders.
7831 * class.cs (MethodCore.LabelParameters): Make static and more
7832 generic so that it can be used from other places - like interface
7833 methods, for instance.
7835 * interface.cs (Interface.Emit): Call LabelParameters before
7836 emitting attributes on the InterfaceMethod.
7838 2003-09-07 Martin Baulig <martin@ximian.com>
7840 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
7841 if the number of type parameters doesn't match.
7843 2003-09-04 Martin Baulig <martin@ximian.com>
7845 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
7846 for arrays of generic type params (ie. `!0[]').
7848 2003-09-04 Martin Baulig <martin@ximian.com>
7850 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
7853 2003-09-04 Martin Baulig <martin@ximian.com>
7855 * decl.cs (DeclSpace.LookupGeneric): New method.
7856 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
7859 * generic.cs (TypeParameterExpr): Take a TypeParameter as
7860 argument, not just a string.
7861 (TypeParameter.Define): New public method; this is called to
7862 actually define the generic parameter; after this, you can use the
7863 new `Type' property to get the type.
7865 2003-09-04 Martin Baulig <martin@ximian.com>
7867 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
7868 is now an ArrayList; initialize the result of the `TypeParameters'
7870 (DeclSpace.GetGenericData): Removed.
7871 (DeclSpace.LookupGeneric): Temporarily removed; we need to
7872 implement this in a different way.
7873 (DeclSpace.GetTypeParameters): Removed; there's now a
7874 `TypeParameters' property.
7875 (DeclSpace.TypeParameters): New public property.
7877 * generic.cs (Constraints): Make this class public.
7878 (TypeParameter): New public class.
7880 2003-09-04 Martin Baulig <martin@ximian.com>
7882 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
7885 * class.cs (TypeContainer.DefineType): Call
7886 TypeBuilder.DefineGenericParameter () on all generic parameters if
7887 this is a generic type.
7889 2003-08-28 Martin Baulig <martin@ximian.com>
7891 * sample-stack.il: Compile this with ilasm: "ilasm /dll
7894 * sample-hello.cs: Compile this with gmcs: "gmcs
7895 /r:sample-stack.dll sample-hello.cs".
7897 2003-08-28 Martin Baulig <martin@ximian.com>
7899 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
7900 the parameters to the generic type.
7902 2003-08-28 Martin Baulig <martin@ximian.com>
7904 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
7906 2003-08-28 Martin Baulig <martin@ximian.com>
7908 * cs-parser.jay (opt_type_argument_list): Use
7909 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
7910 (primary_expression): Replace `qualified_identifier' with `type_name'.
7911 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
7913 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
7914 parser to check whether it is syntactically a type parameter list;
7915 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
7918 2003-08-26 Martin Baulig <martin@ximian.com>
7920 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
7921 resolving aliases; fixes #47927.
7923 2003-08-26 Martin Baulig <martin@ximian.com>
7925 * statement.cs (Using.DoResolve): This is internally emitting a
7926 try/finally clause, so we need to set ec.NeedExplicitReturn if we
7927 do not always return. Fixes #47681.
7929 2003-08-26 Martin Baulig <martin@ximian.com>
7931 * decl.cs (MemberCore): Moved WarningNotHiding(),
7932 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
7934 (AdditionResult): Make this nested in DeclSpace.
7935 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
7936 argument; call NamespaceEntry.Define() unless we're nested in a
7939 * namespace.cs (Namespace.DefineName): New public function. This
7940 is called from DeclSpace's .ctor to add
7941 (Namespace.Lookup): Include DeclSpaces in the lookup.
7943 * class.cs (Operator): Derive from MemberBase, not MemberCore.
7945 * const.cs (Const): Derive from MemberBase, not MemberCore.
7947 2003-08-25 Martin Baulig <martin@ximian.com>
7949 * convert.cs (Convert.ExplicitReferenceConversion): When
7950 converting from an interface type to a class, unbox if the target
7951 type is a struct type. Fixes #47822.
7953 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7955 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
7958 2003-08-22 Martin Baulig <martin@ximian.com>
7960 * class.cs (TypeManager.DefineType): When defining a nested type,
7961 call DefineType() on our parent; fixes #47801.
7963 2003-08-22 Martin Baulig <martin@ximian.com>
7965 * class.cs (MethodData.Define): While checking if a method is an
7966 interface implementation, improve the test a bit more to fix #47654.
7968 2003-08-22 Martin Baulig <martin@ximian.com>
7970 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
7971 correctly; fixes #47722.
7973 2003-08-22 Martin Baulig <martin@ximian.com>
7975 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
7976 LocalVariableReference, ensure it's not read-only. Fixes #47536.
7978 * statement.cs (Fixed.DoResolve): Make all variables read-only.
7980 2003-08-22 Martin Baulig <martin@ximian.com>
7982 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
7983 can only be assigned in static constructors. Fixes #47161.
7985 2003-08-22 Martin Baulig <martin@ximian.com>
7987 Rewrote and improved the flow analysis code.
7989 * flowbranching.cs (FlowBranching): Make this class abstract.
7990 (FlowBranching.CreateBranching): New static function to create a
7992 (FlowBranchingBlock, FlowBranchingException): New classes.
7993 (FlowBranching.UsageVector.Type): New public readonly field.
7994 (FlowBranching.UsageVector.Breaks): Removed the setter.
7995 (FlowBranching.UsageVector.Returns): Removed the setter.
7996 (FlowBranching.UsageVector): Added Break(), Return(),
7997 NeverReachable() and Throw() methods to modify the reachability.
7998 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
7999 done by FlowBranching.Merge().
8000 (FlowBranching.UsageVector.MergeChild): New method; merges the
8001 merge result into the current vector.
8002 (FlowBranching.Merge): New abstract method to merge a branching.
8004 2003-08-12 Martin Baulig <martin@ximian.com>
8006 * expression.cs (Indirection.CacheTemporaries): Create the
8007 LocalTemporary with the pointer type, not its element type.
8009 2003-08-10 Miguel de Icaza <miguel@ximian.com>
8011 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
8012 token was a keyword or not.
8014 Add `error' options where an IDENTIFIER was expected; Provide
8015 CheckToken and CheckIdentifierToken convenience error reporting
8018 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
8020 * decl.cs: Rename `NamespaceEntry Namespace' public field into
8021 NameSpaceEntry NameSpaceEntry.
8023 (LookupInterfaceOrClass): Avoid creating a full qualified name
8024 from namespace and name: avoid doing lookups when we know the
8025 namespace is non-existant. Use new Tree.LookupByNamespace which
8026 looks up DeclSpaces based on their namespace, name pair.
8028 * driver.cs: Provide a new `parser verbose' to display the
8029 exception thrown during parsing. This is turned off by default
8030 now, so the output of a failure from mcs is more graceful.
8032 * namespace.cs: Track all the namespaces defined in a hashtable
8035 (IsNamespace): New method
8037 2003-08-09 Miguel de Icaza <miguel@ximian.com>
8039 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
8040 we know that we need to concatenate (full typename can never be
8045 * statement.cs: Use a bitfield; Do not initialize to null things
8046 which are done by the constructor by default.
8048 * cs-parser.jay: bug fix, parameter was 4, not 3.
8050 * expression.cs: Just use the property;
8052 * statement.cs: No need for GetVariableInfo method.
8054 2003-08-08 Martin Baulig <martin@ximian.com>
8056 * flowanalysis.cs (FlowReturns): This is now nested in the
8057 `FlowBranching' class.
8058 (MyBitVector): Moved this here from statement.cs.
8059 (FlowBranching.SiblingType): New enum type.
8060 (FlowBranching.CreateSibling): Added `SiblingType' argument.
8062 2003-08-07 Martin Baulig <martin@ximian.com>
8064 * flowanalysis.cs (FlowBranchingType): This is now nested in the
8065 `FlowBranching' class and called `BranchingType'.
8067 2003-08-07 Martin Baulig <martin@ximian.com>
8069 * flowanalysis.cs: Moved all the control flow analysis code into
8072 2003-08-07 Martin Baulig <martin@ximian.com>
8074 * assign.cs (Assign.DoResolve): `target' must either be an
8075 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
8078 2003-08-07 Miguel de Icaza <miguel@ximian.com>
8080 * expression.cs (BinaryMethod): This kind of expression is created by the
8081 Binary class if it determines that the operator has to be handled
8084 (BinaryDelegate): This kind of expression is created if we are
8085 dealing with a + or - operator on delegates.
8087 (Binary): remove method, argumetns, and DelegateOperator: when
8088 dealing with methods,
8090 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
8092 * statement.cs (Block): use bitfields for the three extra booleans
8093 we had in use. Remove unused topblock parameter.
8095 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
8097 * assign.cs: Drop extra unneeded tests.
8099 2003-08-06 Miguel de Icaza <miguel@ximian.com>
8101 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
8103 * statement.cs (Foreach): Use VariableStorage instead of
8106 * codegen.cs (VariableStorage): New class used by clients that
8107 require a variable stored: locals or fields for variables that
8108 need to live across yield.
8110 Maybe provide a convenience api for EmitThis+EmitLoad?
8112 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
8115 2003-08-05 Miguel de Icaza <miguel@ximian.com>
8117 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
8118 RemapParameterLValue): New methods that are used to turn a
8119 precomputed FieldInfo into an expression like this:
8123 The idea is to use this instead of making LocalVariableReference
8124 have more than one meaning.
8126 * cs-parser.jay: Add error production to BASE.
8128 * ecore.cs: Deal with TypeManager.GetField returning null, which
8129 is now a valid return value.
8131 (FieldExprNoAddress): New expression for Fields whose address can
8134 * expression.cs (LocalVariableReference): During the resolve
8135 phases, create new expressions if we are in a remapping context.
8136 Remove code that dealt with remapping here.
8138 (ParameterReference): same.
8140 (ProxyInstance): New expression, like the `This' expression, but
8141 it is born fully resolved. We know what we are doing, so remove
8142 the errors that are targeted to user-provided uses of `this'.
8144 * statement.cs (Foreach): our variable is now stored as an
8145 Expression; During resolution, follow the protocol, dont just
8146 assume it will return this.
8148 2003-08-06 Martin Baulig <martin@ximian.com>
8150 * support.cs (SeekableStreamReader.cs): New public class.
8152 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
8153 SeekableStreamReader instead of the normal StreamReader.
8155 2003-08-04 Martin Baulig <martin@ximian.com>
8157 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
8158 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
8159 deambiguate casts and delegate invocations.
8160 (parenthesized_expression): Use the new tokens to ensure this is
8161 not a cast of method invocation.
8163 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
8164 when reading a `)' and Deambiguate_CloseParens () was previously
8167 * expression.cs (ParenthesizedExpression): New class. This is
8168 just used for the CS0075 test.
8169 (Binary.DoResolve): Check for CS0075.
8171 2003-07-29 Ravi Pratap <ravi@ximian.com>
8173 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
8174 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
8175 reference comparison.
8177 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
8178 examine the ReturnType for equality - this is necessary in the
8179 cases of implicit and explicit operators whose signature also
8180 includes the return type.
8182 2003-07-26 Miguel de Icaza <miguel@ximian.com>
8184 * namespace.cs: Cache the result of the namespace computation,
8185 instead of computing it every time.
8187 2003-07-24 Miguel de Icaza <miguel@ximian.com>
8189 * decl.cs: Use a global arraylist that we reuse over invocations
8190 to avoid excesive memory consumption. Reduces memory usage on an
8191 mcs compile by one meg (45 average).
8193 * typemanager.cs (LookupTypeReflection): In .NET pointers are
8194 private, work around that.
8196 2003-07-23 Miguel de Icaza <miguel@ximian.com>
8198 * literal.cs (IntLiteral): Define Zero and One static literals.
8200 * cs-parser.jay (integer_literal): use static literals to reduce
8201 memory usage for the most used literals (0, 1 and -1). 211kb
8202 reduced in memory usage.
8204 Replace all calls to `new ArrayList' with `new
8205 ArrayList(4)' which is a good average number for most allocations,
8206 and also requires only 16 bytes of memory for its buffer by
8209 This reduced MCS memory usage in seven megabytes for the RSS after
8212 2003-07-28 Ravi Pratap <ravi@ximian.com>
8214 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
8215 handle params methods the correct way by forming only one
8216 applicable set with params and normal methods in them. Earlier we
8217 were looking at params methods only if we found no normal methods
8218 which was not the correct thing to do.
8220 (Invocation.BetterFunction): Take separate arguments indicating
8221 when candidate and the best method are params methods in their
8224 This fixes bugs #43367 and #46199.
8226 * attribute.cs: Documentation updates.
8228 (CheckAttribute): Rename to CheckAttributeTarget.
8229 (GetValidPlaces): Rename to GetValidTargets.
8231 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
8232 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
8236 2003-07-28 Miguel de Icaza <miguel@ximian.com>
8238 * codegen.cs: Compute IsGeneric correctly.
8240 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
8243 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
8244 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
8245 regressions, and I was chasing more bugs than I required.
8247 * interface.cs: Use expressions for base type names (like classes
8248 and structs have been doing for a while now), and resolve that.
8249 This patch should probably go into head as well.
8251 This makes it one less user of FindType.
8253 2003-07-24 Miguel de Icaza <miguel@ximian.com>
8255 This compiler can not self host currently. Need to fix that.
8257 * Makefile: compile to `gmcs.exe'
8259 * driver.cs: Turn on v2 by default on gmcs.
8261 * generic.cs (ConstructedType): Does no longer take a container
8262 type argument; That will be taken care of later.
8264 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
8265 Use SimpleName to resolve for now, so we can continue the work on
8266 the parser, until we get Type.GetType that understands generics.
8268 (ConstructedType.ToString): Implement
8270 (TypeArguments.Resolve): Resolve the child expressions as types.
8272 * cs-parser.jay: Rename interface_constraints to
8273 type_parameter_constraints
8275 (namespace_or_type_name): Only use constructed types for the basic
8276 construction, we will deal with identifier<...> later.
8278 (type/type_name): No longer call DecomposeQI, as
8279 namespace_or_type_name is always decoded now.
8281 2003-07-22 Ravi Pratap <ravi@ximian.com>
8283 * expression.cs (Invocation.OverloadResolve): Follow the spec more
8284 closely: we eliminate methods in base types when we have an
8285 applicable method in a top-level type.
8287 Please see section 14.5.5.1 for an exact description of what goes
8290 This fixes bug #45127 and a host of other related to corlib compilation.
8292 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
8293 array is the method corresponding to the top-level type (this is
8294 because of the changes made to icall.c) so we change this
8297 (MethodGroupExpr.Name): This too.
8299 * typemanager.cs (GetElementType): New method which does the right
8300 thing when compiling corlib.
8302 * everywhere: Make use of the above in the relevant places.
8304 2003-07-22 Martin Baulig <martin@ximian.com>
8306 * cs-parser.jay (invocation_expression): Moved
8307 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
8308 `cast_expression', but create a InvocationOrCast which later
8309 resolves to either an Invocation or a Cast.
8311 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
8312 method; call this before EmitStatement() to make sure that this
8313 expression can be used as a statement.
8315 * expression.cs (InvocationOrCast): New class; resolves to either
8316 an Invocation or a Cast.
8318 * statement.cs (StatementExpression): Call ResolveStatement() on
8319 the ExpressionStatement before emitting it.
8321 2003-07-21 Martin Baulig <martin@ximian.com>
8323 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
8324 `ref' and `out' attributes match; fixes #46220.
8325 (MemberAccess.ResolveMemberAccess): You can't reference a type
8326 through an expression; fixes #33180.
8327 (Indexers.GetIndexersForType): Don't return the indexers from
8328 interfaces the class implements; fixes #46502.
8330 2003-07-21 Martin Baulig <martin@ximian.com>
8332 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
8333 CS0661 checks; fixes bug #30442.
8335 2003-07-21 Martin Baulig <martin@ximian.com>
8337 * decl.cs (AdditionResult): Added `Error'.
8339 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
8341 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
8342 cs0031.cs actually work.
8344 2003-07-20 Miguel de Icaza <miguel@ximian.com>
8346 * cs-parser.jay (namespace_name): do not use
8347 namespace_or_type_name, use qualified_identifier, because
8348 namespace_or_type_name will soon return a composed expression
8349 instead of a string.
8351 (namespace_or_type_name): Instead of returning a string, now this
8352 production returns an expression.
8354 * codegen.cs (EmitContext): Setup IsGeneric property based on
8355 whether our DeclSpace is generic, our the method is generic.
8357 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
8358 the method is generic.
8360 * cs-parser.jay (type_arguments, opt_type_argument_list,
8361 type_parameters, type_parameter_list, opt_type_parameter_list,
8362 type_parameter,, opt_type_parameter_constraints_clauses,
8363 type_parameter_constraints_clauses,
8364 type_parameter_constraint_clause, type_parameter_constraint,
8365 interface_constraints): Add new production
8367 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
8368 DeclSpace is generic or not.
8370 (DeclSpace.SetParameterInfo): New routine, used to set the
8371 parameter info for a type.
8373 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
8374 returns a GenericTypeExpr
8376 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
8377 generic, lookup the generic argument.
8379 * attribute.cs: Do not allow TypeParameterExpressions in
8382 * class.cs: Do not allow the Main method to be defined in a
8385 * expression.cs (SizeOf): Do not allow generic types to be used as
8386 arguments to sizeof.
8388 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
8389 it: whether a type is generic or not. Only works for types we are
8390 currently building for now.
8392 2003-07-20 Martin Baulig <martin@ximian.com>
8394 * namespace.cs: Fixed that bug which caused a crash when compiling
8397 2003-07-20 Miguel de Icaza <miguel@ximian.com>
8399 * typemanager.cs (LookupTypeReflection): Never expose types which
8400 are NotPublic, NestedPrivate, NestedAssembly, or
8401 NestedFamANDAssem. We used to return these, and later do a check
8402 that would report a meaningful error, but the problem is that we
8403 would not get the real match, if there was a name override.
8405 2003-07-18 Miguel de Icaza <miguel@ximian.com>
8407 * namespace.cs (Namespace, Name): Do not compute the namespace
8408 name dynamically, compute it in the constructor. This reduced
8409 memory usage by 1697 KB.
8411 * driver.cs: Use --pause to pause at the end.
8413 2003-07-17 Peter Williams <peter@newton.cx>
8415 * Makefile: Change the name of the test target so that it doesn't
8416 conflict with the recursive test target.
8418 2003-07-17 Miguel de Icaza <miguel@ximian.com>
8420 * expression.cs (LocalVariableReference.Emit, EmitAssign,
8421 AddressOf): Do not use EmitThis, that was wrong, use the actual
8424 2003-07-15 Miguel de Icaza <miguel@ximian.com>
8426 * class.cs (MethodData.Define): While checking if a method is an
8427 interface implementation, improve the test: If we are not public
8428 (use new test here: use the computed MethodAttributes directly,
8429 instead of the parsed modifier flags) check if the `implementing'
8430 method comes from an interface or not.
8432 * pending.cs (VerifyPendingMethods): Slightly better error
8435 * makefile: add test target that does the mcs bootstrap.
8437 2003-07-16 Ravi Pratap <ravi@ximian.com>
8439 * interface.cs (Define): Do nothing here since there are no
8440 members to populate etc. Move the attribute emission out of here
8441 since this was just totally the wrong place to put it. Attribute
8442 application happens during the 'Emit' phase, not in the 'Define'
8445 (Emit): Add this method and move the attribute emission here
8447 * rootcontext.cs (EmitCode): Call the Emit method on interface
8450 2003-07-14 Ravi Pratap M <ravi@ximian.com>
8452 * expression.cs (OverloadResolve): Report error only if Location
8453 is not 'Null' which means that there was a probe going on.
8455 2003-07-14 Martin Baulig <martin@ximian.com>
8457 * expression.cs (ConditionalLogicalOperator): New public class to
8458 implement user defined conditional logical operators.
8459 This is section 14.11.2 in the spec and bug #40505.
8461 2003-07-14 Martin Baulig <martin@ximian.com>
8463 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
8465 2003-07-14 Martin Baulig <martin@ximian.com>
8467 * codegen.cs (EmitContext.InFixedInitializer): New public field.
8469 * ecore.cs (IVariable.VerifyFixed): New interface method.
8471 * expression.cs (Unary.ResolveOperator): When resolving the `&'
8472 operator, check whether the variable is actually fixed. Fixes bug
8473 #36055. Set a variable definitely assigned when taking its
8474 address as required by the spec.
8476 * statement.cs (LocalInfo.IsFixed): New field.
8477 (LocalInfo.MakePinned): Set `IsFixed' to true.
8479 2003-07-14 Ravi Pratap M <ravi@ximian.com>
8481 * attribute.cs (Attribute.Resolve): While doing a Member lookup
8482 for .ctors, ensure that we only ask for members declared in the
8483 attribute type (BindingFlags.DeclaredOnly).
8487 * expression.cs (Error_WrongNumArguments): Report error 1501
8488 correctly the way CSC does.
8490 2003-07-13 Martin Baulig <martin@ximian.com>
8492 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
8493 lookup on the fully qualified name, to make things like "X.X" work
8494 where "X.X" is a fully qualified type name, but we also have a
8495 namespace "X" in the using list. Fixes #41975.
8497 2003-07-13 Martin Baulig <martin@ximian.com>
8499 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
8500 function. If we're a CompoundAssign, we need to create an embedded
8501 CompoundAssign, not an embedded Assign.
8502 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
8505 2003-07-13 Martin Baulig <martin@ximian.com>
8507 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
8508 work to fix bug #46088.
8510 2003-07-13 Ravi Pratap <ravi@ximian.com>
8512 * class.cs (Operator.Emit): Do not emit attributes here - it is
8513 taken care of by the Method class that we delegate too. This takes
8516 2003-07-10 Martin Baulig <martin@ximian.com>
8518 * expression.cs (TypeOfVoid): New class.
8519 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
8521 2003-07-10 Martin Baulig <martin@ximian.com>
8523 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
8526 2003-07-10 Martin Baulig <martin@ximian.com>
8528 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
8529 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
8531 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
8533 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
8535 2003-07-10 Martin Baulig <martin@ximian.com>
8537 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
8538 of decimal. Fixes #42850.
8540 NOTE: I also fixed the created byte blob, but this doesn't work on
8541 the MS runtime and csc never produces any byte blobs for decimal
8544 2003-07-10 Martin Baulig <martin@ximian.com>
8546 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
8547 structs; fixes #32068.
8548 (Block.AddChildVariableNames): Fixed #44302.
8550 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8552 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
8554 2003-07-07 Miguel de Icaza <miguel@ximian.com>
8556 * attribute.cs: And this test is onger needed.
8558 2003-07-08 Martin Baulig <martin@ximian.com>
8560 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
8561 inaccessible types. Fixes #36313.
8563 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
8565 * namespace.cs (NamespaceEntry): Create implicit entries for all
8566 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
8567 implicit entries for N1.N2 and N1.
8569 2003-07-08 Martin Baulig <martin@ximian.com>
8571 Rewrote the handling of namespaces to fix a lot of the issues
8572 wrt. `using' aliases etc.
8574 * namespace.cs (Namespace): Splitted this class into a
8575 per-assembly `Namespace' and a per-file `NamespaceEntry'.
8577 * typemanager.cs (TypeManager.IsNamespace): Removed.
8578 (TypeManager.ComputeNamespaces): Only compute namespaces from
8579 loaded assemblies here, not the namespaces from the assembly we're
8580 currently compiling.
8582 2003-07-08 Martin Baulig <martin@ximian.com>
8584 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
8586 2003-07-07 Miguel de Icaza <miguel@ximian.com>
8588 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
8591 I thought about the memory savings here, but LookupTypeReflection
8592 is used under already very constrained scenarios. Compiling
8593 corlib or mcs only exposes one hit, so it would not really reduce
8594 any memory consumption.
8596 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8598 * typemanager.cs: fixes bug #45889 by only adding public types from
8599 other assemblies to the list of known types.
8601 2003-07-07 Miguel de Icaza <miguel@ximian.com>
8603 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
8604 on the type we resolved.
8606 2003-07-05 Martin Baulig <martin@ximian.com>
8608 * pending.cs (PendingImplementation.ParentImplements): Don't
8609 create the proxy if the parent is abstract.
8611 * class.cs (TypeContainer.DefineIndexers): Process explicit
8612 interface implementations first. Fixes #37714.
8614 2003-07-04 Miguel de Icaza <miguel@ximian.com>
8616 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
8617 defined recursively; but since we modify the input parameters
8618 (left is set to `this' temporarily), we reset this value if the
8619 left_is_explicit is false, which gives the original semantics to
8622 * literal.cs (NullPointer): new class used to represent a null
8623 literal in a pointer context.
8625 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
8626 type is a pointer, use a NullPointer object instead of a
8627 NullLiteral. Closes 43687
8629 (ExplicitConversion): Convert pointer values using
8630 the conv opcode to the proper type.
8632 * ecore.cs (New): change ValueTypeVariable property into a method,
8633 that returns whether the valuetype is suitable for being used.
8635 * expression.cs (Binary.DoNumericPromotions): Only return if we
8636 the int constant was a valid uint, and we can return both left and
8637 right as uints. If not, we continue processing, to trigger the
8638 type conversion. This fixes 39018.
8640 * statement.cs (Block.EmitMeta): During constant resolution, set
8641 the CurrentBlock property on the emitcontext, so that we resolve
8642 constants propertly.
8644 2003-07-02 Martin Baulig <martin@ximian.com>
8646 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
8647 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
8649 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
8650 than emitting it here.
8652 * statement.cs: Fixed some more flow analysis bugs.
8654 2003-07-02 Martin Baulig <martin@ximian.com>
8656 * class.cs (MethodData.Define): When implementing interface
8657 methods, set Final unless we're Virtual.
8659 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
8660 check work for interface methods.
8662 2003-07-01 Martin Baulig <martin@ximian.com>
8664 * ecore.cs (EmitContext.This): Replaced this property with a
8665 GetThis() method which takes a Location argument. This ensures
8666 that we get the correct error location for a CS0188.
8668 2003-07-01 Miguel de Icaza <miguel@ximian.com>
8670 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
8671 ImplicitStandardConversion.
8673 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
8675 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
8677 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
8680 2003-06-30 Miguel de Icaza <miguel@ximian.com>
8682 * class.cs (Constructor.Define): Turn off initlocals for unsafe
8685 (MethodData.Define): Turn off initlocals for unsafe methods.
8687 2003-06-29 Miguel de Icaza <miguel@ximian.com>
8689 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
8690 complete; Fixes #37521.
8692 * delegate.cs: Use Modifiers.TypeAttr to compute the
8693 TypeAttributes, instead of rolling our own. This makes the flags
8694 correct for the delegates.
8696 2003-06-28 Miguel de Icaza <miguel@ximian.com>
8698 * class.cs (Constructor.Define): Set the private flag for static
8699 constructors as well.
8701 * cs-parser.jay (statement_expression): Set the return value to
8702 null, to avoid a crash when we catch an error.
8704 2003-06-24 Miguel de Icaza <miguel@ximian.com>
8706 * cs-parser.jay: Applied patch from Jackson that adds support for
8707 extern and unsafe modifiers to destructor declarations.
8709 * expression.cs: Report error 21 if the user is trying to index a
8712 * driver.cs: Add an error message, suggested by the bug report.
8714 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
8715 if we do not have a ": this ()" constructor initializer. Fixes 45149
8717 2003-06-14 Miguel de Icaza <miguel@ximian.com>
8719 * namespace.cs: Add some information to reduce FAQs.
8721 2003-06-13 Miguel de Icaza <miguel@ximian.com>
8723 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
8724 underlying enumeration types. Fixes #43915.
8726 * expression.cs: Treat ushort/short as legal values to be used in
8729 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
8731 * delegate.cs: transfer custom attributes for paramenters from
8732 the delegate declaration to Invoke and BeginInvoke.
8734 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
8736 * attribute.cs: handle custom marshalers and emit marshal info
8739 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
8741 * makefile.gnu: Added anonymous.cs to the compiler sources.
8743 2003-05-28 Miguel de Icaza <miguel@ximian.com>
8745 * iterators.cs: Change the name of the proxy class to include two
8748 * cs-parser.jay: Update grammar to include anonymous methods.
8750 * anonymous.cs: new file.
8752 2003-05-27 Miguel de Icaza <miguel@ximian.com>
8754 * class.cs (Field.Define): Add missing test for pointers and
8757 2003-05-27 Ravi Pratap <ravi@ximian.com>
8759 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
8760 we use the stobj opcode.
8762 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
8763 since it wasn't the correct fix.
8765 It still is puzzling that we are required to use stobj for IntPtr
8766 which seems to be a ValueType.
8768 2003-05-26 Miguel de Icaza <miguel@ximian.com>
8770 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
8771 during regular simple name resolution. Now, the trick is that
8772 instead of returning for processing the simplename, we do a
8773 TypeManager.LookupType (ie, a rooted lookup as opposed to a
8774 contextual lookup type). If a match is found, return that, if
8775 not, return for further composition.
8777 This fixes long-standing 30485.
8779 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
8780 using the address to initialize an object, do an Stobj instead of
8781 using the regular Stelem.
8783 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
8784 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
8785 Because if we are a BaseIndexerAccess that value will be true.
8788 * statement.cs (GotoCase.Resolve): Return after reporting an
8789 error, do not attempt to continue.
8791 * expression.cs (PointerArithmetic.Emit): If our operand is a
8792 long, convert our constants to match the operand before
8793 multiplying. Convert to I type before adding. Fixes 43670.
8795 2003-05-14 Ravi Pratap <ravi@ximian.com>
8797 * enum.cs (ImplicitConversionExists) : Rename to
8798 ImplicitEnumConversionExists to remove ambiguity.
8800 * ecore.cs (NullCast): New type of cast expression class which
8801 basically is very similar to EmptyCast with the difference being
8802 it still is a constant since it is used only to cast a null to
8806 * convert.cs (ImplicitReferenceConversion): When casting a null
8807 literal, we return a NullCast.
8809 * literal.cs (NullLiteralTyped): Remove - I don't see why this
8810 should be around anymore.
8812 The renaming (reported was slightly wrong). Corrections:
8814 ConvertImplicitStandard -> ImplicitConversionStandard
8815 ConvertExplicitStandard -> ExplicitConversionStandard
8817 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
8818 before passing them in !
8820 * convert.cs (ImplicitConversionStandard): When comparing for
8821 equal expr and target types, ensure that expr is not a
8824 In general, we must not be checking (expr_type ==
8825 target_type) in the top level conversion methods
8826 (ImplicitConversion, ExplicitConversion etc). This checking is
8827 done in the methods that they delegate to.
8829 2003-05-20 Miguel de Icaza <miguel@ximian.com>
8831 * convert.cs: Move Error_CannotConvertType,
8832 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
8833 ImplicitNumericConversion, ImplicitConversionExists,
8834 ImplicitUserConversionExists, StandardConversionExists,
8835 FindMostEncompassedType, FindMostSpecificSource,
8836 FindMostSpecificTarget, ImplicitUserConversion,
8837 ExplicitUserConversion, GetConversionOperators,
8838 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
8839 TryImplicitIntConversion, Error_CannotConvertImplicit,
8840 ConvertImplicitRequired, ConvertNumericExplicit,
8841 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
8842 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
8845 Perform the following renames:
8847 StandardConversionExists -> ImplicitStandardConversionExists
8848 ConvertImplicit -> ImplicitConversion
8849 ConvertImplicitStandard -> ImplicitStandardConversion
8850 TryImplicitIntConversion -> ImplicitIntConversion
8851 ConvertImplicitRequired -> ImplicitConversionRequired
8852 ConvertNumericExplicit -> ExplicitNumericConversion
8853 ConvertReferenceExplicit -> ExplicitReferenceConversion
8854 ConvertExplicit -> ExplicitConversion
8855 ConvertExplicitStandard -> ExplicitStandardConversion
8857 2003-05-19 Martin Baulig <martin@ximian.com>
8859 * statement.cs (TypeInfo.StructInfo): Made this type protected.
8860 (TypeInfo): Added support for structs having structs as fields.
8862 * ecore.cs (FieldExpr): Implement IVariable.
8863 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
8864 VariableInfo for the field.
8866 2003-05-18 Martin Baulig <martin@ximian.com>
8868 * expression.cs (This.DoResolve): Report a CS0027 if we're
8869 emitting a field initializer.
8871 2003-05-18 Martin Baulig <martin@ximian.com>
8873 * expression.cs (This.ResolveBase): New public function.
8874 (This.DoResolve): Check for CS0188.
8876 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
8879 * ecore.cs (MethodGroupExpr.DoResolve): Set the
8880 `instance_expression' to null if we don't have any non-static
8883 2003-05-18 Martin Baulig <martin@ximian.com>
8885 Reworked the way how local variables and parameters are handled by
8886 the flow analysis code.
8888 * statement.cs (TypeInfo, VariableMap): New public classes.
8889 (VariableInfo): New public class. This is now responsible for
8890 checking whether a variable has been assigned. It is used for
8891 parameters and local variables.
8892 (Block.EmitMeta): Take the InternalParameters as argument; compute
8893 the layout of the flow vectors here.
8894 (Block.LocalMap, Block.ParameterMap): New public properties.
8895 (FlowBranching): The .ctor doesn't get the InternalParameters
8896 anymore since Block.EmitMeta() now computes the layout of the flow
8898 (MyStructInfo): This class is now known as `StructInfo' and nested
8899 in `TypeInfo'; we don't access this directly anymore.
8901 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
8902 property and removed IsAssigned(), IsFieldAssigned(),
8903 SetAssigned() and SetFieldAssigned(); we now call them on the
8904 VariableInfo so we don't need to duplicate this code everywhere.
8906 * expression.cs (ParameterReference): Added `Block block' argument
8908 (LocalVariableReference, ParameterReference, This): The new
8909 VariableInfo class is now responsible for all the definite
8912 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
8913 IsParameterAssigned, SetParameterAssigned): Removed.
8915 2003-05-18 Martin Baulig <martin@ximian.com>
8917 * typemanager.cs (InitCoreTypes): Try calling
8918 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
8919 the 3-args-version. Corlib now also needs our `void_type'.
8920 (GetMethod): Added overloaded version which takes an optional
8921 `bool report_errors' to allow lookups of optional methods.
8923 2003-05-12 Martin Baulig <martin@ximian.com>
8925 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
8926 only used for locals and not for parameters.
8928 2003-05-12 Miguel de Icaza <miguel@ximian.com>
8930 * support.cs (InternalParameters.ParameterType): Return the
8931 ExternalType of the parameter.
8933 * parameter.cs (Parameter.ExternalType): drop the two arguments,
8936 2003-05-11 Miguel de Icaza <miguel@ximian.com>
8938 * class.cs (MethodData.Define): Do not set the `newslot' on
8939 interface members, if they are also flagged as "override".
8941 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
8942 better code for ++i and i++. This only works for static fields
8943 and local variables.
8945 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
8946 want to pull the DeclSpace out of the builder_to_declspace instead
8947 of the TypeBuilder (like in TypeContainer.FindMembers).
8949 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
8950 instead of LookupTypeContainer. Fixes the crash on .NET for
8951 looking up interface members.
8953 * const.cs: Create our own emit context during the Definition
8954 stage, so that constants are evaluated in the proper context, when
8955 a recursive definition happens.
8957 2003-05-11 Martin Baulig <martin@ximian.com>
8959 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
8960 new block for a switch section.
8961 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
8962 the adding/lookup in the switch block. Fixes #39828.
8964 2003-05-09 Miguel de Icaza <miguel@ximian.com>
8966 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
8967 functionality: I needed to convert the data after I had performed
8968 the add/sub operation into the operands type size.
8970 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
8971 pass the type for the box operation, otherwise the resulting
8972 object would have been of type object.
8974 (BoxedCast): Add constructor to specify the type to box as.
8976 2003-05-07 Miguel de Icaza <miguel@ximian.com>
8978 * iterators.cs: I was reusing the `count' variable inadvertently,
8979 take steps to not allow this to happen.
8981 2003-05-06 Miguel de Icaza <miguel@ximian.com>
8983 * attribute.cs (Attribute.Resolve): Params attributes are encoded
8984 by creating an array at the point where the params starts and
8985 putting all those arguments there, then adjusting the size of the
8988 2003-05-05 Miguel de Icaza <miguel@ximian.com>
8990 * expression.cs (New.AddressOf): Implement interface
8991 IMemoryLocation. This is used when the `new' operator is used in
8992 the context of an invocation to a method on a value type.
8994 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
8997 * namespace.cs: Also check the using aliases here.
8999 * driver.cs: Move the test for using validity after the types have
9000 been entered, so we do a single pass that also includes the using
9003 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
9004 in the regular case. CreateSiblingForFinally is doing extra
9007 * attribute.cs (GetAttributeArgumentExpression): Store the result
9008 on an out value, and use the return value to indicate failure
9009 instead of using null (which is a valid return for Constant.GetValue).
9011 * statement.cs: Perform the analysis flow for the increment
9012 portion after the statement, because this will be the real flow of
9013 execution. Fixes #42385
9015 * codegen.cs (EmitContext.EmitArgument,
9016 EmitContext.EmitStoreArgument): New helper functions when the
9017 RemapToProxy flag is set.
9019 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
9022 Add support for remapping parameters.
9024 * iterators.cs: Propagate parameter values; Store parameter
9025 values in the proxy classes.
9027 2003-05-04 Miguel de Icaza <miguel@ximian.com>
9029 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
9030 need a proxy reference; I do not know what I was thinking
9032 * cs-parser.jay (constructor_initializer): catch another error,
9033 and display nice message.
9035 (field_declaration): catch void field declaration
9036 to flag a better error.
9038 * class.cs (MemberBase.CheckBase): Report an error instead of a
9039 warning if a new protected member is declared in a struct.
9040 (Field.Define): catch the error of readonly/volatile.
9042 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
9044 (FieldExpr.AddressOf): ditto. Catch error where the address of a
9045 volatile variable is taken
9047 2003-05-02 Miguel de Icaza <miguel@ximian.com>
9049 * statement.cs (Fixed.Resolve): Report an error if we are not in
9052 2003-05-01 Miguel de Icaza <miguel@ximian.com>
9054 * typemanager.cs: reuse the code that handles type clashes for
9055 delegates and enumerations.
9057 * class.cs (Report28): Always report.
9059 * expression.cs (EncodeAsAttribute): Allow nulls here.
9061 2003-04-28 Miguel de Icaza <miguel@ximian.com>
9063 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
9064 the functionality for testing whether an expression is valid for
9065 an attribute here. Also handle the case of arrays of elements
9068 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
9069 encoding a linear array into an array of objects that are suitable
9070 to be passed to an CustomAttributeBuilder.
9072 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
9074 * ecore.cs: (FieldExpr): Handle field remapping here.
9076 * iteratators.cs: Pass the instance variable (if the method is an
9077 instance method) to the constructors, so we can access the field
9078 variables on the class.
9080 TODO: Test this with structs. I think the THIS variable on
9081 structs might have to be a pointer, and not a refenrece
9083 2003-04-27 Miguel de Icaza <miguel@ximian.com>
9085 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
9086 local variables to fields in a proxy class.
9088 * iterators.cs (PopulateProxy): Rename our internal fields to
9090 Create a <THIS> field if we are an instance method, so we can
9091 reference our parent container variables.
9092 (MapVariable): Called back from the EmitContext code to enter a
9093 new variable to field mapping into the proxy class (we just create
9097 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
9098 for using the remapped locals to fields.
9100 I placed the code here, because that gives the same semantics to
9101 local variables, and only changes the Emit code.
9103 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
9104 statements inside iterators.
9105 (VariableInfo): Add a FieldBuilder for the cases when we are
9106 remapping local variables to fields in a proxy class
9108 * ecore.cs (SimpleNameResolve): Avoid testing two times for
9109 current_block != null.
9111 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
9112 not cope with strings, as it has been moved to the
9113 TableSwitchEmit. Fixed bug in switch generation.
9115 * expression.cs (New.DoResolve): Provide more context for the user
9116 when reporting an error.
9118 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
9121 * expression.cs (MemberAccess.DoResolve): When we get a type back,
9122 check the permissions for it. Note than in a type-resolution
9123 context the check was already present in DeclSpace.ResolveType,
9124 but was missing from the MemberAccess.
9126 (ArrayCreation.CheckIndices): warn if the user has
9127 more nested levels of expressions, but there are no more
9128 dimensions specified. Avoids crash on bug 41906.
9130 2003-04-26 Miguel de Icaza <miguel@ximian.com>
9132 * statement.cs (Block): replace Implicit bool, for a generic
9134 New flag: `Unchecked'. This is used during the EmitMeta phase
9135 (which is out-of-line with the regular Resolve/Emit process for a
9136 statement, as this is done ahead of time, but still gets a chance
9137 to call constant resolve).
9139 (Block.Flags): new enum for adding a new flag.
9141 (Block.EmitMeta): track the state of unchecked.
9143 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
9144 to enable constant resolution to work there as well.
9146 2003-04-22 Miguel de Icaza <miguel@ximian.com>
9148 * typemanager.cs (ienumerable_type): Also look up
9149 System.Collections.IEnumerable.
9151 2003-04-21 Miguel de Icaza <miguel@ximian.com>
9153 TODO: Test more than one conditional per method.
9155 * class.cs (Indexer.Define): Report the location where the user is
9156 referencing the unsupported feature.
9158 (MethodData): Overload the use of `conditionals' to
9159 minimize the creation of needless ArrayLists. This saves roughly
9160 212kb on my machine.
9162 (Method): Implement the new IIteratorContainer interface.
9163 (Method.SetYields): Implement the method by setting the ModFlags
9164 to contain METHOD_YIELDS.
9166 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
9167 which just got set to null.
9169 * iterators.cs: New file.
9171 (Yield, YieldBreak): New statements.
9173 * statement.cs (Return.Resolve): Flag an error if we are used in
9176 * codegen.cs (InIterator): New flag set if the code is being
9177 compiled in an iterator method.
9179 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
9180 internal modifier, and we just use it to avoid adding extra
9181 fields, as this is seldom used.
9183 * cs-parser.jay: Add yield_statement (yield and yield break).
9185 * driver.cs: New flag -v2 to turn on version 2 features.
9187 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
9188 hashtable when v2 is enabled.
9190 2003-04-20 Miguel de Icaza <miguel@ximian.com>
9192 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
9193 there is already a namespace defined with this name.
9195 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
9196 people upgraded their corlibs.
9198 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
9199 always use fully qualified types, no need to use the compiler
9202 (TypeManager.IsNamespace): Use binarysearch.
9204 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
9205 AddDelegate): I did not quite use the new IsValid API properly: I
9206 have to pass the short-name and the fullname. I was passing only
9207 the basename instead of the fullname sometimes.
9209 (TypeContainer.DefineType): call NamespaceClash.
9211 * interface.cs (Interface.DefineType): use NamespaceClash before
9214 * delegate.cs (Delegate.DefineType): use NamespaceClash before
9217 * enum.cs: (Enum.DefineType): use NamespaceClash before
9220 * typemanager.cs (: 3-line patch that gives us some tasty 11%
9221 speed increase. First, use the negative_hits cache when we get a
9222 negative. Second, add the type with its full original name
9223 instead of the new . and + encoded name (reflection uses + to
9224 separate type from a nested type). Use LookupTypeReflection
9225 directly which bypasses the type->name hashtable (that we already
9226 know does not contain the type.
9228 * decl.cs (DeclSpace.ResolveTypeExpr): track the
9229 location/container type.
9231 * driver.cs: When passing utf8, use directly the UTF8Encoding.
9233 2003-04-19 Miguel de Icaza <miguel@ximian.com>
9235 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
9237 * delegate.cs (NewDelegate.Resolve): Test whether an instance
9238 method is being referenced in the method group from a static
9239 context, and report error 120 if so.
9241 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
9244 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
9245 is created, we create the A namespace).
9247 * cs-parser.jay: A namespace also introduces a DeclarationFound.
9250 2003-04-18 Miguel de Icaza <miguel@ximian.com>
9252 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
9253 invocation to ModuleBuilder.GetType with the same values will
9254 return a new type instance, so we need to cache its return
9257 * expression.cs (Binary.ResolveOperator): Only allow the compare
9258 operators on enums if they are of the same type.
9260 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
9261 types of ValueType on their own case. Before we were giving them
9262 the same treatment as objects.
9264 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
9265 fullname. Short name is used to compare against container name.
9266 Fullname is used to check against defined namespace names.
9268 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
9269 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
9271 (Method.CheckBase): Call parent.
9272 (MemberBase.CheckBase): Check for protected members on sealed
9274 (PropertyBase.CheckBase): Call parent.
9275 (Field.Define): Call parent.
9277 * report.cs: Negative error codes are now mapped to 8000 - code,
9278 so that the display is render more nicely.
9280 * typemanager.cs: Do not use try/catch, instead report a regular
9283 (GetPointerType, GetReferenceType): These methods provide
9284 mechanisms to obtain the T* and T& from a T. We had the code
9285 previously scattered around the code base, and it also used
9286 TypeManager.LookupType that would go through plenty of caches.
9287 This one goes directly to the type source.
9289 In some places we did the Type.GetType followed by
9290 ModuleBuilder.GetType, but not in others, so this unifies the
9293 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
9294 statements now that we have namespace information.
9296 * typemanager.cs (IsNamespace): New method, returns whether the
9297 string presented is a namespace or not.
9299 (ComputeNamespaces): New public entry point, computes the list of
9300 available namespaces, using the GetNamespaces API call in Mono, or
9301 the slower version in MS.NET.
9303 Now before we start the semantic analysis phase, we have a
9304 complete list of namespaces including everything that the user has
9307 Deleted old code to cache namespaces in .nsc files.
9309 2003-04-17 Miguel de Icaza <miguel@ximian.com>
9311 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
9312 class/struct location definition Location for the implicit
9313 constructor location.
9315 (Operator.Define): Use the location of the operator for the
9316 implicit Method definition.
9318 (Constructor.Emit): use the constructor location for the implicit
9319 base initializer constructor.
9321 * ecore.cs: Remove ITypeExpression. This interface is now gone,
9322 and the Expression class now contains two new methods:
9324 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
9325 isolate type lookup from the rest of the resolution process.
9327 Since we use Expressions to hold type definitions due to the way
9328 we parse the input we have historically overloaded Resolve to
9329 perform the Type lookups if a special flag is passed. Now this is
9330 eliminated and two methods take their place.
9332 The differences in the two methods between xStep and xTerminal is
9333 that xStep is involved in our current lookup system that uses
9334 SimpleNames to compose a name, while xTerminal is used just to
9335 catch the case where the simplename lookup failed.
9337 2003-04-16 Miguel de Icaza <miguel@ximian.com>
9339 * expression.cs (ResolveMemberAccess): Remove redundant code.
9340 TypeExpr expressions are always born fully resolved.
9342 * interface.cs (PopulateMethod): Do not lookup the types twice.
9343 We were doing it once during SemanticAnalysis and once during
9346 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
9347 in local variable type definitions, were being returned as a
9348 SimpleName (we decomposed everything into a string), that is
9349 because primary_expression was being used instead of a type in the
9350 grammar (reduce/reduce conflicts).
9352 The part that was wrong is that we converted the expression into a
9353 string (an oversimplification in one hand, compounded with primary
9354 expressions doing string concatenation).
9360 Would return "A.B.C[]" as a SimpleName. This stopped things like
9361 using clauses from working on this particular context. And a type
9362 was being matched directly against "A.B.C[]".
9364 We now use the correct approach, and allow for ComposedCast to be
9365 part of the unary expression. So the "A.B.C []" become a composed
9366 cast of "A.B.C" (as a nested group of MemberAccess with a
9367 SimpleName at the end) plus the rank composition "[]".
9371 2003-04-10 Miguel de Icaza <miguel@ximian.com>
9373 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
9374 for the access level checking.
9376 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
9377 `TypeContainer container', because I kept getting confused when I
9378 was debugging this code.
9380 * expression.cs (Indexers): Instead of tracking getters/setters,
9381 we now track them in parallel. We create one arraylist less, but
9382 most importantly it is possible now for the LValue code to find a
9383 matching get for a set.
9385 (IndexerAccess.DoResolveLValue): Update the code.
9386 GetIndexersForType has been modified already to extract all the
9387 indexers from a type. The code assumed it did not.
9389 Also make the code set the correct return type for the indexer.
9390 This was fixed a long time ago for properties, but was missing for
9391 indexers. It used to be void_type.
9393 (Binary.Emit): Test first for doubles instead of
9394 floats, as they are more common.
9396 (Binary.EmitBranchable): Use the .un version of the branch opcodes
9397 when dealing with floats and the <=, >= operators. This fixes bug
9400 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
9401 to load the array value by emitting a load on the foreach variable
9402 type. This was incorrect.
9404 We now emit the code to load an element using the the array
9405 variable type, and then we emit the conversion operator.
9409 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
9411 * attribute.cs: Avoid allocation of ArrayLists in the common case.
9413 2003-04-09 Miguel de Icaza <miguel@ximian.com>
9415 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
9416 test for protection before we test for signatures.
9418 (MethodSignature.ToString): implement.
9420 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
9421 to the case where we reduced into a LongConstant.
9423 * decl.cs (CheckAccessLevel): If the type is an array, we can not
9424 depend on whether the information is acurrate, because the
9425 Microsoft runtime will always claim that the array type is public,
9426 regardless of the real state.
9428 If the type is a pointer, another problem happens: the type is
9429 reported as non-public in Microsoft.
9431 In both cases we have to call CheckAccessLevel recursively with
9432 the underlying type as the argument to be tested.
9434 2003-04-08 Miguel de Icaza <miguel@ximian.com>
9436 * assign.cs (Assign.Emit): If we are dealing with a compound
9437 assignment expression, we should use the code path that stores the
9438 intermediate result in a temporary value. This fixes #40903.
9440 *expression.cs (Indirection.ToString): Provide ToString method for
9443 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
9445 * class.cs: Null out fields holding references to Block objects so
9446 they can be garbage collected.
9448 * expression.cs (OverloadResolve): Remove unused local.
9450 2003-04-07 Martin Baulig <martin@ximian.com>
9452 * codegen.cs (EmitContext.CurrentFile): New public field.
9453 (EmitContext.Mark): Use the CurrentFile to check whether the
9454 location is in the correct file.
9455 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
9457 2003-04-07 Martin Baulig <martin@ximian.com>
9459 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
9461 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
9462 location. [FIXME: The location argument which gets passed to this
9463 method is sometimes wrong!]
9465 2003-04-07 Nick Drochak <ndrochak@gol.com>
9467 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
9469 2003-04-07 Miguel de Icaza <miguel@ximian.com>
9471 * expression.cs (Indirection.EmitAssign): We were using the
9472 temporary, but returning immediately instead of continuing the
9475 2003-04-06 Martin Baulig <martin@ximian.com>
9477 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
9478 if it's a nested child, but also deriving from the outer class.
9481 * typemanager.cs (IsNestedChildOf): Make this work if it's a
9482 nested child, but also deriving from the outer class. See
9484 (FilterWithClosure): We may access private members of the outer
9485 class if we're a nested child and deriving from the outer class.
9486 (RealMemberLookup): Only set `closure_private_ok' if the
9487 `original_bf' contained BindingFlags.NonPublic.
9489 2003-04-05 Martin Baulig <martin@ximian.com>
9491 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
9492 probe if its a type parameter, and if so, flag an error.
9494 * decl.cs: Move here the SetParameterInfo code from class.cs.
9495 Handle IsGeneric here.
9497 Handle a variety of errors in the parameter info definition.
9499 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
9500 type parameters here.
9502 * cs-parser.jay (class_declaration): report errors for parameters
9505 2003-01-21 Miguel de Icaza <miguel@ximian.com>
9507 * generic.cs: New file, contains support code for generics.
9509 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
9510 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
9512 Update parser for the above removals.
9514 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
9515 now taken care of in the parser.
9517 2003-04-02 Miguel de Icaza <miguel@ximian.com>
9519 * class.cs (Event.Define): Do not allow abstract events to have
9522 2003-04-01 Miguel de Icaza <miguel@ximian.com>
9524 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
9525 block in event declarations.
9527 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
9528 value type, get its address.
9530 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
9531 leaving a class on the stack instead of a boolean value (int
9532 0/1). Change the code so we compare against null, and then the
9533 result against zero.
9535 * class.cs (TypeContainer.GetClassBases): We were checking for the
9536 parent class being sealed too late.
9538 * expression.cs (Binary.Emit): For <= and >= when dealing with
9539 floating point values, use cgt.un and clt.un instead of cgt and
9542 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
9544 * statement.cs: Apply the same optimization as MS: skip the
9545 GetEnumerator returning an IEnumerator, and use the one returning a
9546 CharEnumerator instead. This allows us to avoid the try-finally block
9549 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
9551 * cs-parser.jay: Attributes cannot be applied to
9552 namespaces. Fixes #40473
9554 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9557 (Add*): check if the name is valid using the full name for constants,
9558 fields, properties and events.
9560 2003-03-28 Miguel de Icaza <miguel@ximian.com>
9562 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
9563 char constants to be part of the enumeration.
9565 * expression.cs (Conditional.DoResolve): Add support for operator
9566 true. Implements the missing functionality from 14.12
9568 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
9569 operator true/false as required by the spec.
9571 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
9572 implicit conversion to boolean.
9574 * statement.cs (Statement.ResolveBoolean): A boolean expression is
9575 also one where the type implements `operator true'.
9577 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
9578 get an expression that will invoke operator true based on an
9581 (GetConversionOperators): Removed the hack that called op_True
9584 (Expression.ResolveBoolean): Move this from Statement.
9586 2003-03-17 Miguel de Icaza <miguel@ximian.com>
9588 * ecore.cs (FieldExpr): do not allow initialization of initonly
9589 fields on derived classes
9591 2003-03-13 Martin Baulig <martin@ximian.com>
9593 * statement.cs (Block.Emit): Call ig.BeginScope() and
9594 ig.EndScope() when compiling with debugging info; call
9595 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
9597 2003-03-08 Miguel de Icaza <miguel@ximian.com>
9599 * expression.cs (Indexers): Do not construct immediately, allow
9600 for new members to be appended as we go. Fixes 38143
9602 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9604 * expression.cs: save/restore context when resolving an unchecked
9607 2003-03-05 Miguel de Icaza <miguel@ximian.com>
9609 * cfold.cs: Catch division by zero in modulus operator during
9612 2003-03-03 Miguel de Icaza <miguel@ximian.com>
9614 * interface.cs (Interface.DefineMembers): Avoid defining members
9617 2003-02-27 Miguel de Icaza <miguel@ximian.com>
9619 * driver.cs: handle the +/- options for -noconfig
9621 * statement.cs (Unckeched.Resolve): Also track the state of
9622 unchecked in the Resolve phase.
9624 2003-02-27 Martin Baulig <martin@ximian.com>
9626 * ecore.cs (Expression.MemberLookup): Don't create a
9627 MethodGroupExpr for something which is not a method. Fixes #38291.
9629 2003-02-25 Miguel de Icaza <miguel@ximian.com>
9631 * class.cs (MemberBase.CheckParameters): Also check that the type
9632 is unmanaged if it is a pointer.
9634 * expression.cs (SizeOf.Resolve): Add location information.
9636 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
9637 a managed type is declared.
9639 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
9640 parameter modifiers as well. Fixes bug 38606
9642 * class.cs: Very sad. Am backing out the speed up changes
9643 introduced by the ArrayList -> Array in the TypeContainer, as they
9644 were not actually that much faster, and introduced a bug (no error
9645 reports on duplicated methods).
9647 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
9648 source first, this will guarantee that we have a valid expression
9649 before calling in lower levels functions that will require a
9650 resolved object. Then use this original_source in the
9651 target.ResolveLValue instead of the original source that was
9654 Another change. Use target.Resolve instead of LValueResolve.
9655 Although we are resolving for LValues, we will let the Assign code
9656 take care of that (it will be called again from Resolve). This
9657 basically allows code like this:
9659 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
9660 class Y { void A (X x) { x [0] += o; }
9662 The problem was that the indexer was trying to resolve for
9663 set_Item (idx, object o) and never finding one. The real set_Item
9664 was set_Item (idx, X). By delaying the process we get the right
9669 2003-02-23 Martin Baulig <martin@ximian.com>
9671 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
9672 while calling DoEmit ().
9674 * codegen.cs (EmitContext.Mark): Don't mark locations in other
9675 source files; if you use the #line directive inside a method, the
9676 compiler stops emitting line numbers for the debugger until it
9677 reaches the end of the method or another #line directive which
9678 restores the original file.
9680 2003-02-23 Martin Baulig <martin@ximian.com>
9682 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
9684 2003-02-23 Martin Baulig <martin@ximian.com>
9686 * statement.cs (Block.AddChildVariableNames): We need to call this
9687 recursively, not just for our immediate children.
9689 2003-02-23 Martin Baulig <martin@ximian.com>
9691 * class.cs (Event.Define): Always make the field private, like csc does.
9693 * typemanager.cs (TypeManager.RealMemberLookup): Make events
9694 actually work, fixes bug #37521.
9696 2003-02-23 Miguel de Icaza <miguel@ximian.com>
9698 * delegate.cs: When creating the various temporary "Parameters"
9699 classes, make sure that we call the ComputeAndDefineParameterTypes
9700 on those new parameters (just like we do with the formal ones), to
9701 allow them to be resolved in the context of the DeclSpace.
9703 This fixes the bug that Dick observed in Bugzilla #38530.
9705 2003-02-22 Miguel de Icaza <miguel@ximian.com>
9707 * expression.cs (ResolveMemberAccess): When resolving a constant,
9708 do not attempt to pull a constant if the value was not able to
9709 generate a valid constant.
9711 * const.cs (LookupConstantValue): Do not report more errors than required.
9713 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9715 * expression.cs: fixes bug #38328.
9717 2003-02-18 Miguel de Icaza <miguel@ximian.com>
9719 * class.cs: Changed all the various members that can be part of a
9720 class from being an ArrayList to be an Array of the right type.
9721 During the DefineType type_list, interface_list, delegate_list and
9722 enum_list are turned into types, interfaces, delegates and enums
9725 And during the member population, indexer_list, event_list,
9726 constant_list, field_list, instance_constructor_list, method_list,
9727 operator_list and property_list are turned into their real arrays.
9729 Although we could probably perform this operation earlier, for
9730 good error reporting we need to keep the lists and remove the
9731 lists for longer than required.
9733 This optimization was triggered by Paolo profiling the compiler
9734 speed on the output of `gen-sample-program.pl' perl script.
9736 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
9737 not crash in methods like MemberLookupFailed that use this field.
9739 This problem arises when the compiler fails to resolve a type
9740 during interface type definition for example.
9742 2003-02-18 Miguel de Icaza <miguel@ximian.com>
9744 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
9745 inherit from System.Object, so we have to stop at null, not only
9746 when reaching System.Object.
9748 2003-02-17 Miguel de Icaza <miguel@ximian.com>
9750 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
9751 DeclaredOnly because the parent indexer might have had a different
9752 name, but did not loop until the top of the hierarchy was reached.
9754 The problem this one fixes is 35492: when a class implemented an
9755 indexer from an interface, we were getting the interface method
9756 (which was abstract) and we were flagging an error (can not invoke
9759 This also keeps bug 33089 functioning, and test-148 functioning.
9761 * typemanager.cs (IsSpecialMethod): The correct way of figuring
9762 out if a method is special is to see if it is declared in a
9763 property or event, or whether it is one of the predefined operator
9764 names. This should fix correctly #36804.
9766 2003-02-15 Miguel de Icaza <miguel@ximian.com>
9768 The goal here is to remove the dependency on EmptyCast.Peel ().
9769 Killing it completely.
9771 The problem is that currently in a number of places where
9772 constants are expected, we have to "probe" for an EmptyCast, and
9773 Peel, which is not the correct thing to do, as this will be
9774 repetitive and will likely lead to errors.
9776 The idea is to remove any EmptyCasts that are used in casts that
9777 can be reduced to constants, so we only have to cope with
9780 This bug hunt was triggered by Bug 37363 and the desire to remove
9781 the duplicate pattern where we were "peeling" emptycasts to check
9782 whether they were constants. Now constants will always be
9785 * ecore.cs: Use an enumconstant here instead of wrapping with
9788 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
9789 throwing me off. By handling this we can get rid of a few hacks.
9791 * statement.cs (Switch): Removed Peel() code.
9793 2003-02-14 Miguel de Icaza <miguel@ximian.com>
9795 * class.cs: Location information for error 508
9797 * expression.cs (New.DoResolve): Add a guard against double
9798 resolution of an expression.
9800 The New DoResolve might be called twice when initializing field
9801 expressions (see EmitFieldInitializers, the call to
9802 GetInitializerExpression will perform a resolve on the expression,
9803 and later the assign will trigger another resolution
9805 This leads to bugs (#37014)
9807 * delegate.cs: The signature for EndInvoke should contain any ref
9808 or out parameters as well. We were not doing this in the past.
9810 * class.cs (Field.Define): Do not overwrite the type definition
9811 inside the `volatile' group. Turns out that volatile enumerations
9812 were changing the type here to perform a validity test, which
9815 2003-02-12 Miguel de Icaza <miguel@ximian.com>
9817 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
9818 and structs, we do not want to load the instance variable
9820 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
9821 enum_type has to be handled like an object reference (implicit
9822 conversions exists from this to object), but the regular IsClass
9823 and IsValueType tests will never return true for this one.
9825 Also we use TypeManager.IsValueType instead of type.IsValueType,
9826 just for consistency with the rest of the code (this is only
9827 needed if we ever use the construct exposed by test-180.cs inside
9828 corlib, which we dont today).
9830 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
9832 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
9835 2003-02-09 Martin Baulig <martin@ximian.com>
9837 * namespace.cs (Namespace..ctor): Added SourceFile argument.
9838 (Namespace.DefineNamespaces): New static public method; this is
9839 called when we're compiling with debugging to add all namespaces
9842 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
9843 pass it to the Namespace's .ctor.
9845 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
9846 and MethodBase arguments; pass the namespace ID to the symwriter;
9847 pass the MethodBase instead of the token to the symwriter.
9848 (SymbolWriter.DefineNamespace): New method to add a namespace to
9851 2003-02-09 Martin Baulig <martin@ximian.com>
9853 * symbolwriter.cs: New file. This is a wrapper around
9854 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
9855 methods here in near future.
9857 2003-02-09 Martin Baulig <martin@ximian.com>
9859 * codegen.cs (EmitContext.Mark): Just pass the arguments to
9860 ILGenerator.MarkSequencePoint() which are actually used by the
9863 2003-02-09 Martin Baulig <martin@ximian.com>
9865 * location.cs (SourceFile): New public sealed class. This
9866 contains the name and an index which is used in the location's token.
9867 (Location): Reserve an appropriate number of bits in the token for
9868 the source file instead of walking over that list, this gives us a
9869 really huge performance improvement when compiling with debugging.
9871 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
9872 `SourceFile' argument instead of a string.
9873 (Driver.ProcessFile): Add all the files via Location.AddFile(),
9874 but don't parse/tokenize here, we need to generate the list of all
9875 source files before we do that.
9876 (Driver.ProcessFiles): New static function. Parses/tokenizes all
9879 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
9880 instead of a string.
9882 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
9885 2003-02-09 Martin Baulig <martin@ximian.com>
9887 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
9888 filename on `#line default'.
9890 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
9892 * statement.cs: don't clear the pinned var when the fixed statement
9893 returns from the method (fixes bug#37752).
9895 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
9897 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
9900 2003-02-07 Martin Baulig <martin@ximian.com>
9902 * driver.cs: Removed the `--debug-args' command line argument.
9904 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
9905 automatically by the AsssemblyBuilder.
9906 (CodeGen.InitializeSymbolWriter): We don't need to call any
9907 initialization function on the symbol writer anymore. This method
9908 doesn't take any arguments.
9910 2003-02-03 Miguel de Icaza <miguel@ximian.com>
9912 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
9913 from referenced assemblies as well.
9915 2003-02-02 Martin Baulig <martin@ximian.com>
9917 * class.cs (MethodData.Emit): Generate debugging info for external methods.
9919 2003-02-02 Martin Baulig <martin@ximian.com>
9921 * class.cs (Constructor.Emit): Open the symbol writer before
9922 emitting the constructor initializer.
9923 (ConstructorInitializer.Emit): Call ec.Mark() to allow
9924 single-stepping through constructor initializers.
9926 2003-01-30 Miguel de Icaza <miguel@ximian.com>
9928 * class.cs: Handle error 549: do not allow virtual methods in
9931 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
9933 * decl.cs: Check access levels when resolving types
9935 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
9937 * statement.cs: Add parameters and locals set in catch blocks that might
9938 return to set vector
9940 2003-01-29 Miguel de Icaza <miguel@ximian.com>
9942 * class.cs (Operator): Set the SpecialName flags for operators.
9944 * expression.cs (Invocation.DoResolve): Only block calls to
9945 accessors and operators on SpecialName methods.
9947 (Cast.TryReduce): Handle conversions from char constants.
9950 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
9952 * statement.cs: small memory and time optimization in FlowBranching.
9954 2003-01-28 Pedro Mart <yoros@wanadoo.es>
9956 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
9957 problem that the last fix but in the other sid (Set).
9959 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
9960 access when there is no indexer in the hierarchy.
9962 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
9964 * class.cs: Combine some if statements.
9966 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9968 * driver.cs: fixed bug #37187.
9970 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
9972 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
9973 any indexer, it's needed to build a list with all the indexers in the
9974 hierarchy (AllGetters), else we have problems. Fixes #35653.
9976 2003-01-23 Miguel de Icaza <miguel@ximian.com>
9978 * class.cs (MethodData.Define): It is wrong for an interface
9979 implementation to be static in both cases: explicit and implicit.
9980 We were only handling this in one case.
9982 Improve the if situation there to not have negations.
9984 * class.cs (Field.Define): Turns out that we do not need to check
9985 the unsafe bit on field definition, only on usage. Remove the test.
9987 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9989 * driver.cs: use assembly.Location instead of Codebase (the latest
9990 patch made mcs fail when using MS assemblies).
9992 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
9994 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
9995 get the path to *corlib.dll.
9997 2003-01-21 Nick Drochak <ndrochak@gol.com>
10001 * typemanager.cs: Remove compiler warnings
10003 2003-01-20 Duncan Mak <duncan@ximian.com>
10005 * AssemblyInfo.cs: Bump the version number to 0.19.
10007 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10009 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
10011 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
10013 * class.cs (Constructor::Emit): Emit debugging info for constructors.
10015 2003-01-17 Miguel de Icaza <miguel@ximian.com>
10017 * cs-parser.jay: Small fix: we were not comparing the constructor
10018 name correctly. Thanks to Zoltan for the initial pointer.
10020 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
10022 * cs-tokenizer.cs: Set file name when specified with #line
10024 2003-01-15 Miguel de Icaza <miguel@ximian.com>
10026 * cs-parser.jay: Only perform the constructor checks here if we
10027 are named like the class; This will help provider a better
10028 error. The constructor path is taken when a type definition is
10029 not found, but most likely the user forgot to add the type, so
10030 report that rather than the constructor error.
10032 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
10034 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
10037 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
10039 * cs-parser.jay: Add cleanup call.
10041 2003-01-13 Duncan Mak <duncan@ximian.com>
10043 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
10044 consistent with other methods.
10046 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
10048 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
10050 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
10052 * attribute.cs: only set GuidAttr to true when we have a
10055 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10059 * typemanager.cs: fixes to allow mcs compile corlib with the new
10060 Type.IsSubclassOf fix.
10062 2003-01-08 Miguel de Icaza <miguel@ximian.com>
10064 * expression.cs (LocalVariableReference.DoResolve): Classify a
10065 constant as a value, not as a variable. Also, set the type for
10068 * cs-parser.jay (fixed_statement): take a type instead of a
10069 pointer_type, so we can produce a better error message later.
10071 * statement.cs (Fixed.Resolve): Flag types that are not pointers
10074 (For.DoEmit): Make inifinite loops have a
10075 non-conditional branch back.
10077 (Fixed.DoEmit): First populate the pinned variables, then emit the
10078 statement, then clear the variables. Before I was emitting the
10079 code once for each fixed piece.
10082 2003-01-08 Martin Baulig <martin@ximian.com>
10084 * statement.cs (FlowBranching.MergeChild): A break in a
10085 SWITCH_SECTION does not leave a loop. Fixes #36155.
10087 2003-01-08 Martin Baulig <martin@ximian.com>
10089 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
10090 lives in the same number space than `param_map'. Fixes #36154.
10092 2003-01-07 Miguel de Icaza <miguel@ximian.com>
10094 * cs-parser.jay (constructor_declaration): Set the
10095 Constructor.ModFlags before probing for it. This makes the
10096 compiler report 514, 515 and 132 (the code was there, but got
10099 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
10100 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
10101 (GotoCase.Resolve): Set `Returns' to ALWAYS.
10103 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
10105 * enum.cs: create the enum static fields using the enum type.
10107 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
10109 * class.cs: don't try to create the ParamBuilder for the return
10110 type if it's not needed (and handle it breaking for the ms runtime
10113 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
10115 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
10117 2002-12-29 Miguel de Icaza <miguel@ximian.com>
10119 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
10120 the command. This showed up while compiling the JANET source
10121 code, which used \r as its only newline separator.
10123 2002-12-28 Miguel de Icaza <miguel@ximian.com>
10125 * class.cs (Method.Define): If we are an operator (because it
10126 reuses our code), then set the SpecialName and HideBySig. #36128
10128 2002-12-22 Miguel de Icaza <miguel@ximian.com>
10130 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
10131 exception, report error 120 `object reference required'.
10133 * driver.cs: Add --pause option, used during to measure the size
10134 of the process as it goes with --timestamp.
10136 * expression.cs (Invocation.DoResolve): Do not allow methods with
10137 SpecialName to be invoked.
10139 2002-12-21 Miguel de Icaza <miguel@ximian.com>
10141 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
10142 number before adding it.
10144 2002-12-21 Ravi Pratap <ravi@ximian.com>
10146 * ecore.cs (StandardImplicitConversion): When in an unsafe
10147 context, we allow conversion between void * to any other pointer
10148 type. This fixes bug #35973.
10150 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
10152 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
10153 is not thrown when extensionless outputs are used
10155 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10157 * rootcontext.cs: fixed compilation of corlib.
10159 2002-12-19 Miguel de Icaza <miguel@ximian.com>
10161 * attribute.cs (Attributes.Contains): Add new method.
10163 * class.cs (MethodCore.LabelParameters): if the parameter is an
10164 `out' parameter, check that no attribute `[In]' has been passed.
10166 * enum.cs: Handle the `value__' name in an enumeration.
10168 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
10170 * decl.cs: Added special case to allow overrides on "protected
10173 2002-12-18 Ravi Pratap <ravi@ximian.com>
10175 * attribute.cs (Attributes.AddAttributeSection): Rename to this
10176 since it makes much more sense.
10178 (Attributes.ctor): Don't require a Location parameter.
10180 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
10182 * attribute.cs (ApplyAttributes): Remove extra Location parameters
10183 since we already have that information per attribute.
10185 * everywhere : make appropriate changes.
10187 * class.cs (LabelParameters): Write the code which actually
10188 applies attributes to the return type. We can't do this on the MS
10189 .NET runtime so we flag a warning in the case an exception is
10192 2002-12-18 Miguel de Icaza <miguel@ximian.com>
10194 * const.cs: Handle implicit null conversions here too.
10196 2002-12-17 Ravi Pratap <ravi@ximian.com>
10198 * class.cs (MethodCore.LabelParameters): Remove the extra
10199 Type [] parameter since it is completely unnecessary. Instead
10200 pass in the method's attributes so that we can extract
10201 the "return" attribute.
10203 2002-12-17 Miguel de Icaza <miguel@ximian.com>
10205 * cs-parser.jay (parse): Use Report.Error to flag errors instead
10206 of ignoring it and letting the compile continue.
10208 * typemanager.cs (ChangeType): use an extra argument to return an
10209 error condition instead of throwing an exception.
10211 2002-12-15 Miguel de Icaza <miguel@ximian.com>
10213 * expression.cs (Unary.TryReduce): mimic the code for the regular
10214 code path. Perform an implicit cast in the cases where we can
10215 implicitly convert to one of the integral types, and then reduce
10216 based on that constant. This fixes bug #35483.
10218 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10220 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
10222 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10224 * namespace.cs: fixed bug #35489.
10226 2002-12-12 Miguel de Icaza <miguel@ximian.com>
10228 * class.cs: Remove some dead code.
10230 * cs-parser.jay: Estimate the number of methods needed
10231 (RootContext.MethodCount);
10233 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
10234 numbers instead of StringBuilders.
10236 * support.cs (PtrHashtable): Add constructor with initial size;
10237 We can now reduce reallocations of the method table.
10239 2002-12-10 Ravi Pratap <ravi@ximian.com>
10241 * attribute.cs (ApplyAttributes): Keep track of the emitted
10242 attributes on a per-target basis. This fixes bug #35413.
10244 2002-12-10 Miguel de Icaza <miguel@ximian.com>
10246 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
10247 default to the Windows 1252 encoding.
10249 (UnixParseOption): Support version, thanks to Alp for the missing
10252 * AssemblyInfo.cs: Add nice assembly information.
10254 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
10257 * cs-parser.jay: Allow a trailing comma before the close bracked
10258 in the attribute_section production.
10260 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
10261 address of the instance was being taken, I will take this out,
10262 because we take the address of the object immediately here.
10264 2002-12-09 Ravi Pratap <ravi@ximian.com>
10266 * typemanager.cs (AreMultipleAllowed): Take care of the most
10267 obvious case where attribute type is not in the current assembly -
10270 2002-12-08 Miguel de Icaza <miguel@ximian.com>
10272 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
10273 definitions, instead of doing that afterwards.
10275 Also we use a nice little hack, depending on the constructor, we
10276 know if we are a "composed" name or a simple name. Hence, we
10277 avoid the IndexOf test, and we avoid
10279 * codegen.cs: Add code to assist in a bug reporter to track down
10280 the source of a compiler crash.
10282 2002-12-07 Ravi Pratap <ravi@ximian.com>
10284 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
10285 types have been emitted for a given element and flag an error
10286 if something which does not have AllowMultiple set is used more
10289 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
10290 attribute types and their corresponding AllowMultiple properties
10292 (AreMultipleAllowed): Check the property for a given type.
10294 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
10295 property in the case we have a TypeContainer.
10297 (Attributes.AddAttribute): Detect duplicates and just skip on
10298 adding them. This trivial fix catches a pretty gross error in our
10299 attribute emission - global attributes were being emitted twice!
10301 Bugzilla bug #33187 is now fixed.
10303 2002-12-06 Miguel de Icaza <miguel@ximian.com>
10305 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
10306 instead of pp_and).
10308 * expression.cs (Binary.ResolveOperator): I can only use the
10309 Concat (string, string, string) and Concat (string, string,
10310 string, string) if the child is actually a concatenation of
10313 2002-12-04 Miguel de Icaza <miguel@ximian.com>
10315 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
10316 context where we need a 2-character lookahead.
10318 * pending.cs (PendingImplementation): Rework so we can keep track
10319 of interface types all the time, and flag those which were
10320 implemented by parents as optional.
10322 2002-12-03 Miguel de Icaza <miguel@ximian.com>
10324 * expression.cs (Binary.ResolveOperator): Use
10325 String.Concat(string,string,string) or
10326 String.Concat(string,string,string,string) when possible.
10328 * typemanager: More helper methods.
10331 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
10333 * pending.cs: remove the bogus return from GetMissingInterfaces()
10334 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
10336 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10338 * namespace.cs: avoid duplicated 'using xxx' being added to
10339 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
10340 when we get more than one 'using' statement for the same namespace.
10341 Report a CS0105 warning for it.
10343 2002-11-30 Miguel de Icaza <miguel@ximian.com>
10345 * cs-tokenizer.cs (consume_identifier): use read directly, instead
10346 of calling getChar/putback, uses internal knowledge of it.
10348 (xtoken): Reorder tokenizer so most common patterns are checked
10349 first. This reduces the compilation time in another 5% (from 8.11s
10350 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
10352 The parsing time is 22% of the compilation in mcs, and from that
10353 64% is spent on the tokenization process.
10355 I tried using a binary search for keywords, but this is slower
10356 than the hashtable. Another option would be to do a couple of
10359 * Not use a StringBuilder, instead use an array of chars,
10360 with a set value. Notice that this way we could catch
10361 the 645 error without having to do it *afterwards*.
10363 * We could write a hand-parser to avoid the hashtable
10364 compares altogether.
10366 The identifier consumption process takes 37% of the tokenization
10367 time. Another 15% is spent on is_number. 56% of the time spent
10368 on is_number is spent on Int64.Parse:
10370 * We could probably choose based on the string length to
10371 use Int32.Parse or Int64.Parse and avoid all the 64-bit
10374 Another 3% is spend on wrapping `xtoken' in the `token' function.
10376 Handle 0xa0 as whitespace (#34752)
10378 2002-11-26 Miguel de Icaza <miguel@ximian.com>
10380 * typemanager.cs (IsCLRType): New routine to tell whether a type
10381 is one of the builtin types.
10383 Maybe it needs to use TypeCodes to be faster. Maybe we could use
10384 typecode in more places instead of doing pointer comparissions.
10385 We could leverage some knowledge about the way the typecodes are
10388 New code to cache namespaces in assemblies, it is currently not
10389 invoked, to be used soon.
10391 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
10393 * expression.cs (Binary.ResolveOperator): specially handle
10394 strings, and do not perform user-defined operator overloading for
10397 2002-11-24 Miguel de Icaza <miguel@ximian.com>
10399 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
10400 internalcall as it is a pretty simple operation; Avoid whenever
10401 possible to call Char.IsLetter.
10403 (consume_identifier): Cut by half the number of
10404 hashtable calls by merging the is_keyword and GetKeyword behavior.
10406 Do not short-circuit, because if we do, we
10407 report errors (ie, #if false && true would produce an invalid
10411 2002-11-24 Martin Baulig <martin@ximian.com>
10413 * expression.cs (Cast.TryReduce): If we're in checked syntax,
10414 check constant ranges and report a CS0221. Fixes #33186.
10416 2002-11-24 Martin Baulig <martin@ximian.com>
10418 * cs-parser.jay: Make this work for uninitialized variable
10419 declarations in the `for' initializer. Fixes #32416.
10421 2002-11-24 Martin Baulig <martin@ximian.com>
10423 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
10424 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
10426 2002-11-24 Martin Baulig <martin@ximian.com>
10428 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
10429 argument; if true, we also check for user-defined conversions.
10430 This is only needed if both arguments are of a user-defined type.
10431 Fixes #30443, added test-175.cs.
10432 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
10434 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
10436 2002-11-24 Martin Baulig <martin@ximian.com>
10438 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
10439 function to get the store opcode.
10440 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
10441 only emit the Ldelema if the store opcode is Stobj. You must run
10442 both test-34 and test-167 to test this. Fixes #34529.
10444 2002-11-23 Martin Baulig <martin@ximian.com>
10446 * ecore.cs (Expression.MemberLookup): Added additional
10447 `qualifier_type' argument which is used when we're being called
10448 from MemberAccess.DoResolve() and null if we're called from a
10450 (Expression.MemberLookupFailed): New method to report errors; this
10451 does the CS1540 check and reports the correct error message.
10453 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
10454 argument for the CS1540 check and redone the way how we're dealing
10455 with private members. See the comment in the source code for details.
10456 (FilterWithClosure): Reverted this back to revision 1.197; renamed
10457 `closure_start_type' to `closure_qualifier_type' and check whether
10458 it's not null. It was not this filter being broken, it was just
10459 being called with the wrong arguments.
10461 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
10462 and pass it the correct `qualifier_type'; this also does the error
10465 2002-11-22 Miguel de Icaza <miguel@ximian.com>
10467 * expression.cs (Invocation.EmitParams): If the we are dealing
10468 with a non-built-in value type, load its address as well.
10470 (ArrayCreation): Use a a pretty constant instead
10471 of the hardcoded value 2. Use 6 instead of 2 for the number of
10472 static initializers.
10474 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
10475 because they are not really value types, just glorified integers.
10477 * driver.cs: Do not append .exe, the CSC compiler does not do it.
10479 * ecore.cs: Remove redundant code for enumerations, make them use
10480 the same code path as everything else, fixes the casting issue
10481 with enumerations in Windows.Forms.
10483 * attribute.cs: Do only cast to string if it is a string, the
10484 validation happens later.
10486 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
10487 people upgrade their corlibs.
10489 * ecore.cs: Oops, enumerations were not following the entire code path
10491 2002-11-21 Miguel de Icaza <miguel@ximian.com>
10493 * typemanager.cs (FilterWithClosure): Commented out the test for
10494 1540 in typemanager.cs, as it has problems when accessing
10495 protected methods from a parent class (see test-174.cs).
10497 * attribute.cs (Attribute.ValidateGuid): new method.
10498 (Attribute.Resolve): Use above.
10500 2002-11-19 Miguel de Icaza <miguel@ximian.com>
10502 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
10504 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
10505 handling for enumerations, as we only needed the TypeContainer
10506 functionality to begin with (this is required for the fix below to
10507 work for enums that reference constants in a container class for
10510 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
10512 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
10513 a valid TypeBuilder to perform lookups on.o
10515 * class.cs (InheritableMemberSignatureCompare): Use true in the
10516 call to GetGetMethod and GetSetMethod, because we are comparing
10517 the signature, and we need to get the methods *even* if they are
10520 (PropertyBase.CheckBase): ditto.
10522 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
10523 GotoCase.Resolve): Use Peel on EmpytCasts.
10525 * ecore.cs (EmptyCast): drop child, add Peel method.
10527 2002-11-17 Martin Baulig <martin@ximian.com>
10529 * ecore.cs (EmptyCast.Child): New public property.
10531 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
10532 label resolved to an EmptyCast. Fixes #34162.
10533 (GotoCase.Resolve): Likewise.
10534 (Block.EmitMeta): Likewise.
10536 2002-11-17 Martin Baulig <martin@ximian.com>
10538 * expression.cs (Invocation.BetterConversion): Prefer int over
10539 uint; short over ushort; long over ulong for integer literals.
10540 Use ImplicitConversionExists instead of StandardConversionExists
10541 since we also need to check for user-defined implicit conversions.
10542 Fixes #34165. Added test-173.cs.
10544 2002-11-16 Martin Baulig <martin@ximian.com>
10546 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
10547 with the `true' and `false' literals. Fixes #33151.
10549 2002-11-16 Martin Baulig <martin@ximian.com>
10551 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
10552 October 22nd; don't do the cs1540 check for static members.
10554 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
10555 now using our own filter here and doing the cs1540 check again.
10557 2002-11-16 Martin Baulig <martin@ximian.com>
10559 * support.cs (InternalParameters): Don't crash if we don't have
10560 any fixed parameters. Fixes #33532.
10562 2002-11-16 Martin Baulig <martin@ximian.com>
10564 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
10565 when looking up static methods to make this work on Windows.
10568 2002-11-16 Martin Baulig <martin@ximian.com>
10570 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
10571 a setter rather than using PropertyInfo.CanWrite.
10573 2002-11-15 Nick Drochak <ndrochak@gol.com>
10575 * class.cs: Allow acces to block member by subclasses. Fixes build
10578 2002-11-14 Martin Baulig <martin@ximian.com>
10580 * class.cs (Constructor.Emit): Added the extern/block check.
10583 2002-11-14 Martin Baulig <martin@ximian.com>
10585 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
10586 iteration while looking for indexers, this is needed because the
10587 indexer may have a different name in our base classes. Fixed the
10588 error reporting (no indexers at all, not get accessor, no
10589 overloaded match). Fixes bug #33089.
10590 (IndexerAccess.DoResolveLValue): Likewise.
10592 2002-11-14 Martin Baulig <martin@ximian.com>
10594 * class.cs (PropertyBase.CheckBase): Make this work for multiple
10595 indexers. Fixes the first part of bug #33089.
10596 (MethodSignature.InheritableMemberSignatureCompare): Added support
10599 2002-11-13 Ravi Pratap <ravi@ximian.com>
10601 * attribute.cs (Attribute.Resolve): Catch the
10602 NullReferenceException and report it since it isn't supposed to
10605 2002-11-12 Miguel de Icaza <miguel@ximian.com>
10607 * expression.cs (Binary.EmitBranchable): Also handle the cases for
10608 LogicalOr and LogicalAnd that can benefit from recursively
10609 handling EmitBranchable. The code now should be nice for Paolo.
10611 2002-11-08 Miguel de Icaza <miguel@ximian.com>
10613 * typemanager.cs (LookupType): Added a negative-hit hashtable for
10614 the Type lookups, as we perform quite a number of lookups on
10615 non-Types. This can be removed once we can deterministically tell
10616 whether we have a type or a namespace in advance.
10618 But this might require special hacks from our corlib.
10622 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
10623 and double which avoids a conversion from an integer to a double.
10625 * expression.cs: tiny optimization, avoid calling IsConstant,
10626 because it effectively performs the lookup twice.
10628 2002-11-06 Miguel de Icaza <miguel@ximian.com>
10630 But a bogus return here to keep the semantics of the old code
10631 until the Mono runtime is fixed.
10633 * pending.cs (GetMissingInterfaces): New method used to remove all
10634 the interfaces that are already implemented by our parent
10635 classes from the list of pending methods.
10637 * interface.cs: Add checks for calls after ResolveTypeExpr.
10639 2002-11-05 Miguel de Icaza <miguel@ximian.com>
10641 * class.cs (Class.Emit): Report warning 67: event not used if the
10642 warning level is beyond 3.
10644 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
10645 being a NullLiteral.
10647 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
10650 * class.cs (TypeContainer.GetClassBases): Cover a missing code
10651 path that might fail if a type can not be resolved.
10653 * expression.cs (Binary.Emit): Emit unsigned versions of the
10656 * driver.cs: use error 5.
10658 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
10660 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
10662 2002-11-01 Miguel de Icaza <miguel@ximian.com>
10664 * cs-parser.jay (switch_section): A beautiful patch from Martin
10665 Baulig that fixed 33094.
10667 2002-10-31 Miguel de Icaza <miguel@ximian.com>
10669 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
10670 Check whether the base is abstract and report an error if so.
10672 * expression.cs (IndexerAccess.DoResolveLValue,
10673 IndexerAccess.DoResolve): ditto.
10675 (Invocation.DoResolve): ditto.
10677 (Invocation.FullMethodDesc): Improve the report string.
10679 * statement.cs (Block): Eliminate IsVariableDefined as it is
10680 basically just a wrapper for GetVariableInfo.
10682 * ecore.cs (SimpleName): Use new
10684 * support.cs (ReflectionParamter.ParameterType): We unwrap the
10685 type, as we return the actual parameter ref/unref state on a
10688 2002-10-30 Miguel de Icaza <miguel@ximian.com>
10690 * support.cs: Return proper flags REF/OUT fixing the previous
10693 * expression.cs: Reverted last patch, that was wrong. Is_ref is
10694 not used to mean `ref' but `ref or out' in ParameterReference
10696 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
10697 full type signature instead of calling TypeManger.CSharpName
10700 * support.cs (InternalParameters.ParameterDesc): Do not compare
10701 directly to the modflags, because REF/OUT will actually be bitsets
10704 * delegate.cs (VerifyMethod): Check also the modifiers.
10706 * cs-tokenizer.cs: Fix bug where floating point values with an
10707 exponent where a sign was missing was ignored.
10709 * driver.cs: Allow multiple assemblies to be specified in a single
10712 2002-10-28 Miguel de Icaza <miguel@ximian.com>
10714 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
10715 because identifiers after a parenthesis would end up in this kind
10716 of production, and we needed to desamiguate it for having casts
10719 (UserDefinedType *) xxx
10721 2002-10-24 Miguel de Icaza <miguel@ximian.com>
10723 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
10724 we should set on the Bindingflags.NonPublic, but not turn on
10725 private_ok. private_ok controls whether a Private member is
10726 returned (this is chekced on the filter routine), while the
10727 BindingFlags.NonPublic just controls whether private/protected
10728 will be allowed. This fixes the problem part of the problem of
10729 private properties being allowed to be used in derived classes.
10731 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
10732 so we can call the children DoResolveLValue method (this will
10733 properly signal errors on lvalue assignments to base properties)
10735 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
10736 getter are null, and we have a property info, we know that this
10737 happened because the lookup failed, so we report an error 122 for
10738 protection level violation.
10740 We also silently return if setter and getter are null in the
10741 resolve functions, this condition only happens if we have flagged
10742 the error before. This is the other half of the problem.
10744 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
10745 not have accessibility information, that is why we were returning
10746 true in the filter function in typemanager.cs.
10748 To properly report 122 (property is inaccessible because of its
10749 protection level) correctly, we report this error in ResolveAccess
10750 by failing if both the setter and the getter are lacking (ie, the
10753 DoResolve and DoLResolve have been modified to check for both
10754 setter/getter being null and returning silently, the reason being
10755 that I did not want to put the knowledge about this error in upper
10758 int old = Report.Errors;
10759 x = new PropertyExpr (...);
10760 if (old != Report.Errors)
10765 So the property expr is returned, but it is invalid, so the error
10766 will be flagged during the resolve process.
10768 * class.cs: Remove InheritablePropertySignatureCompare from the
10769 class, as we no longer depend on the property signature to compute
10770 whether it is possible to implement a method or not.
10772 The reason is that calling PropertyInfo.GetGetMethod will return
10773 null (in .NET, in Mono it works, and we should change this), in
10774 cases where the Get Method does not exist in that particular
10779 class X { public virtual int A { get { return 1; } } }
10781 class Z : Y { public override int A { get { return 2; } } }
10783 Would fail in Z because the parent (Y) would not have the property
10784 defined. So we avoid this completely now (because the alternative
10785 fix was ugly and slow), and we now depend exclusively on the
10788 (PropertyBase.CheckBase): Use a method-base mechanism to find our
10789 reference method, instead of using the property.
10791 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
10792 routines are gone now.
10794 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
10795 names, they were incorrectly named.
10797 * cs-tokenizer.cs: Return are more gentle token on failure.
10799 * pending.cs (PendingImplementation.InterfaceMethod): This routine
10800 had an out-of-sync index variable, which caused it to remove from
10801 the list of pending methods the wrong method sometimes.
10803 2002-10-22 Miguel de Icaza <miguel@ximian.com>
10805 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
10806 CanWrite, because those refer to this particular instance of the
10807 property, and do not take into account the fact that we can
10808 override single members of a property.
10810 Constructor requires an EmitContext. The resolution process does
10811 not happen here, but we need to compute the accessors before,
10812 because the resolution does not always happen for properties.
10814 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
10815 subclass, before we did not update this flag, but we did update
10818 (GetAccessors): Drop this routine, as it did not work in the
10819 presence of partially overwritten set/get methods.
10821 Notice that this broke the cs1540 detection, but that will require
10824 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10828 * driver.cs: issue a warning instead of an error if we don't support
10829 debugging for the platform. Also ignore a couple of errors that may
10830 arise when trying to write the symbols. Undo my previous patch.
10832 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10834 * driver.cs: ignore /debug switch except for Unix platforms.
10836 2002-10-23 Nick Drochak <ndrochak@gol.com>
10838 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
10840 2002-10-21 Miguel de Icaza <miguel@ximian.com>
10842 * driver.cs: Do not make mcs-debug conditional, so we do not break
10843 builds that use it.
10845 * statement.cs (UsageVector.MergeChildren): I would like Martin to
10846 review this patch. But basically after all the children variables
10847 have been merged, the value of "Breaks" was not being set to
10848 new_breaks for Switch blocks. I think that it should be set after
10849 it has executed. Currently I set this to the value of new_breaks,
10850 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
10851 conservative, but I do not understand this code very well.
10853 I did not break anything in the build, so that is good ;-)
10855 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
10857 2002-10-20 Mark Crichton <crichton@gimp.org>
10859 * cfold.cs: Fixed compile blocker. Really fixed it this time.
10861 2002-10-20 Nick Drochak <ndrochak@gol.com>
10863 * cfold.cs: Fixed compile blocker.
10865 2002-10-20 Miguel de Icaza <miguel@ximian.com>
10867 * driver.cs: I was chekcing the key, not the file.
10869 2002-10-19 Ravi Pratap <ravi@ximian.com>
10871 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
10872 message that we were generating - we just need to silently return
10875 2002-10-19 Miguel de Icaza <miguel@ximian.com>
10877 * class.cs (Event.Define): Change my previous commit, as this
10878 breaks the debugger. This is a temporary hack, as it seems like
10879 the compiler is generating events incorrectly to begin with.
10881 * expression.cs (Binary.ResolveOperator): Added support for
10882 "U operator - (E x, E y)"
10884 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
10887 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
10888 init-only variables, but this path did not take into account that
10889 there might be also instance readonly variables. Correct this
10892 This fixes bug 32253
10894 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
10897 * driver.cs: Change the extension for modules to `netmodule'
10899 * cs-parser.jay: Improved slightly the location tracking for
10900 the debugger symbols.
10902 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
10903 modifiers that were specified instead of the hardcoded value
10904 (FamAndAssem). This was basically ignoring the static modifier,
10905 and others. Fixes 32429.
10907 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
10908 fixed a bug in the process (32476)
10910 * expression.cs (ArrayAccess.EmitAssign): Patch from
10911 hwang_rob@yahoo.ca that fixes bug 31834.3
10913 2002-10-18 Miguel de Icaza <miguel@ximian.com>
10915 * driver.cs: Make the module extension .netmodule.
10917 2002-10-16 Miguel de Icaza <miguel@ximian.com>
10919 * driver.cs: Report an error if the resource file is not found
10920 instead of crashing.
10922 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
10923 false, like Emit does.
10925 2002-10-16 Nick Drochak <ndrochak@gol.com>
10927 * typemanager.cs: Remove unused private member. Also reported mcs
10928 bug to report this as a warning like csc.
10930 2002-10-15 Martin Baulig <martin@gnome.org>
10932 * statement.cs (Statement.Emit): Made this a virtual method; emits
10933 the line number info and calls DoEmit().
10934 (Statement.DoEmit): New protected abstract method, formerly knows
10935 as Statement.Emit().
10937 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
10939 2002-10-11 Miguel de Icaza <miguel@ximian.com>
10941 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
10942 have fixed a remaining problem: not every AddXXXX was adding a
10943 fully qualified name.
10945 Now everyone registers a fully qualified name in the DeclSpace as
10946 being defined instead of the partial name.
10948 Downsides: we are slower than we need to be due to the excess
10949 copies and the names being registered this way.
10951 The reason for this is that we currently depend (on the corlib
10952 bootstrap for instance) that types are fully qualified, because
10953 we dump all the types in the namespace, and we should really have
10954 types inserted into the proper namespace, so we can only store the
10955 basenames in the defined_names array.
10957 2002-10-10 Martin Baulig <martin@gnome.org>
10959 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
10960 from bug #31834, see the bug report for a testcase which is
10963 2002-10-10 Martin Baulig <martin@gnome.org>
10965 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
10966 flow analysis code for this.
10968 * statement.cs (Do, While, For): Tell the flow analysis code about
10970 (FlowBranching.UsageVector): Added support for infinite loops.
10971 (Block.Resolve): Moved the dead code elimination here and use flow
10974 2002-10-09 Miguel de Icaza <miguel@ximian.com>
10976 * class.cs (Field.Define): Catch cycles on struct type
10979 * typemanager.cs (IsUnmanagedtype): Do not recursively check
10980 fields if the fields are static. We only need to check instance
10983 * expression.cs (As.DoResolve): Test for reference type.
10985 * statement.cs (Using.ResolveExpression): Use
10986 ConvertImplicitRequired, not ConvertImplicit which reports an
10988 (Using.ResolveLocalVariableDecls): ditto.
10990 * expression.cs (Binary.ResolveOperator): Report errors in a few
10991 places where we had to.
10993 * typemanager.cs (IsUnmanagedtype): Finish implementation.
10995 2002-10-08 Miguel de Icaza <miguel@ximian.com>
10997 * expression.cs: Use StoreFromPtr instead of extracting the type
10998 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
11000 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
11001 an enumeration value to a System.Enum, but System.Enum is not a
11002 value type, but an class type, so we need to box.
11004 (Expression.ConvertExplicit): One codepath could return
11005 errors but not flag them. Fix this. Fixes #31853
11007 * parameter.cs (Resolve): Do not allow void as a parameter type.
11009 2002-10-06 Martin Baulig <martin@gnome.org>
11011 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
11012 if it's a class type and not a struct. Fixes #31815.
11014 2002-10-06 Martin Baulig <martin@gnome.org>
11016 * statement.cs: Reworked the flow analysis code a bit to make it
11017 usable for dead code elimination.
11019 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11021 * cs-parser.jay: allow empty source files. Fixes bug #31781.
11023 2002-10-04 Miguel de Icaza <miguel@ximian.com>
11025 * expression.cs (ComposedCast.DoResolveType): A quick workaround
11026 to fix the test 165, will investigate deeper.
11028 2002-10-04 Martin Baulig <martin@gnome.org>
11030 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
11031 finally blocks actually work.
11032 (Try.Resolve): We don't need to create a sibling for `finally' if
11033 there is no finally block.
11035 2002-10-04 Martin Baulig <martin@gnome.org>
11037 * class.cs (Constructor.Define): The default accessibility for a
11038 non-default constructor is private, not public.
11040 2002-10-04 Miguel de Icaza <miguel@ximian.com>
11042 * class.cs (Constructor): Make AllowedModifiers public, add
11045 * cs-parser.jay: Perform the modifiers test here, as the
11046 constructor for the Constructor class usually receives a zero
11047 because of the way we create it (first we create, later we
11048 customize, and we were never checking the modifiers).
11050 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
11051 is a version of LookupTypeReflection that includes the type-name
11052 cache. This can be used as a fast path for functions that know
11053 the fully qualified name and are only calling into *.GetType() to
11054 obtain a composed type.
11056 This is also used by TypeManager.LookupType during its type
11059 (LookupType): We now also track the real type name, as sometimes
11060 we can get a quey for the real type name from things like
11061 ComposedCast. This fixes bug 31422.
11063 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
11064 complete type fullname, it does not have to go through the type
11065 resolution system to obtain the composed version of the type (for
11066 obtaining arrays or pointers).
11068 (Conditional.Emit): Use the EmitBoolExpression to
11069 generate nicer code, as requested by Paolo.
11071 (ArrayCreation.CheckIndices): Use the patch from
11072 hwang_rob@yahoo.ca to validate the array initializers.
11074 2002-10-03 Miguel de Icaza <miguel@ximian.com>
11076 * class.cs (ConstructorInitializer.Emit): simplify code by using
11077 Invocation.EmitCall, and at the same time, fix the bugs in calling
11078 parent constructors that took variable arguments.
11080 * ecore.cs (Expression.ConvertNumericExplicit,
11081 Expression.ImplicitNumericConversion): Remove the code that
11082 manually wrapped decimal (InternalTypeConstructor call is now gone
11085 * expression.cs (Cast.TryReduce): Also handle decimal types when
11086 trying to perform a constant fold on the type.
11088 * typemanager.cs (IsUnmanagedtype): Partially implemented.
11090 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
11091 that only turned off an error report, and did nothing else.
11093 2002-10-02 Miguel de Icaza <miguel@ximian.com>
11095 * driver.cs: Handle and ignore /fullpaths
11097 2002-10-01 Miguel de Icaza <miguel@ximian.com>
11099 * expression.cs (Binary.ResolveOperator): Catch the case where
11100 DoNumericPromotions returns true,
11102 (Binary.DoNumericPromotions): Simplify the code, and the tests.
11104 2002-09-27 Miguel de Icaza <miguel@ximian.com>
11106 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
11109 2002-09-26 Miguel de Icaza <miguel@ximian.com>
11111 * ecore.cs (ConvertNumericExplicit): It is not enough that the
11112 conversion exists, but it is also required that the conversion be
11113 performed. This manifested in "(Type64Enum) 2".
11115 * class.cs (TypeManager.AddMethod): The fix is not to change
11116 AddEnum, because that one was using a fully qualified name (every
11117 DeclSpace derivative does), but to change the AddMethod routine
11118 that was using an un-namespaced name. This now correctly reports
11119 the duplicated name.
11121 Revert patch until I can properly fix it. The issue
11122 is that we have a shared Type space across all namespaces
11123 currently, which is wrong.
11125 Options include making the Namespace a DeclSpace, and merge
11126 current_namespace/current_container in the parser.
11128 2002-09-25 Miguel de Icaza <miguel@ximian.com>
11130 * cs-parser.jay: Improve error reporting when we get a different
11131 kind of expression in local_variable_type and
11132 local_variable_pointer_type.
11134 Propagate this to avoid missleading errors being reported.
11136 * ecore.cs (ImplicitReferenceConversion): treat
11137 TypeManager.value_type as a target just like object_type. As
11142 Is valid, and needs to result in the int 1 being boxed before it
11143 is assigned to the value type v.
11145 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
11146 to validate the enumeration name.
11148 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
11149 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
11150 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
11152 * ecore.cs (TryImplicitIntConversion): When doing an
11153 implicit-enumeration-conversion, check if the type is 64-bits and
11154 perform a conversion before passing to EnumConstant.
11156 2002-09-23 Miguel de Icaza <miguel@ximian.com>
11158 * decl.cs (Error_AmbiguousTypeReference); New routine used to
11159 report ambiguous type references. Unlike the MS version, we
11160 report what the ambiguity is. Innovation at work ;-)
11162 (DeclSpace.FindType): Require a location argument to
11163 display when we display an ambiguous error.
11165 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
11167 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
11169 * expression.cs (EmitDynamicInitializers): Apply patch from
11170 hwang_rob@yahoo.ca that fixes the order in which we emit our
11173 2002-09-21 Martin Baulig <martin@gnome.org>
11175 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
11176 delegate takes no arguments.
11178 2002-09-20 Miguel de Icaza <miguel@ximian.com>
11180 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
11183 * expression.cs: Extract the underlying type.
11185 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
11187 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
11189 2002-09-19 Miguel de Icaza <miguel@ximian.com>
11191 * class.cs (TypeContainer.DefineType): We can not use the nice
11192 PackingSize with the size set to 1 DefineType method, because it
11193 will not allow us to define the interfaces that the struct
11196 This completes the fixing of bug 27287
11198 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
11199 means also structs. This fixes part of the problem.
11200 (Expresion.ImplicitReferenceConversionExists): ditto.
11202 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
11203 error if there were no errors reported during the type lookup
11204 process, to avoid duplicates or redundant errors. Without this
11205 you would get an ambiguous errors plus a type not found. We have
11206 beaten the user enough with the first error.
11208 (DeclSparce.FindType): Emit a warning if we have an ambiguous
11211 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
11212 during the resolution process, stop the lookup, this avoids
11213 repeated error reports (same error twice).
11215 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
11217 * typemanager.cs (LookupType): Redo the type lookup code to match
11218 the needs of System.Reflection.
11220 The issue is that System.Reflection requires references to nested
11221 types to begin with a "+" sign instead of a dot. So toplevel
11222 types look like: "NameSpace.TopLevelClass", and nested ones look
11223 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
11226 2002-09-19 Martin Baulig <martin@gnome.org>
11228 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
11229 says that a method always returns or always throws an exception,
11230 don't report the CS0161.
11232 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
11233 set `Returns = new_returns'.
11235 2002-09-19 Martin Baulig <martin@gnome.org>
11237 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
11238 to an enum constant, check for a CS0176.
11240 2002-09-18 Miguel de Icaza <miguel@ximian.com>
11242 * class.cs (TypeContainer.CheckPairedOperators): Now we check
11243 for operators that must be in pairs and report errors.
11245 * ecore.cs (SimpleName.DoResolveType): During the initial type
11246 resolution process, when we define types recursively, we must
11247 check first for types in our current scope before we perform
11248 lookups in the enclosing scopes.
11250 * expression.cs (MakeByteBlob): Handle Decimal blobs.
11252 (Invocation.VerifyArgumentsCompat): Call
11253 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
11254 I thought we were supposed to always call this, but there are a
11255 few places in the code where we dont do it.
11257 2002-09-17 Miguel de Icaza <miguel@ximian.com>
11259 * driver.cs: Add support in -linkres and -resource to specify the
11260 name of the identifier.
11262 2002-09-16 Miguel de Icaza <miguel@ximian.com>
11264 * ecore.cs (StandardConversionExists): Sync with the conversion
11265 code: allow anything-* to void* conversions.
11267 (FindMostSpecificSource): Use an Expression argument
11268 instead of a Type, because we might be handed over a Literal which
11269 gets a few more implicit conversions that plain types do not. So
11270 this information was being lost.
11272 Also, we drop the temporary type-holder expression when not
11275 2002-09-17 Martin Baulig <martin@gnome.org>
11277 * class.cs (PropertyBase.CheckBase): Don't check the base class if
11278 this is an explicit interface implementation.
11280 2002-09-17 Martin Baulig <martin@gnome.org>
11282 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
11283 different `IndexerName' attributes.
11285 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
11286 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
11287 virtual CommonResolve().
11289 2002-09-16 Miguel de Icaza <miguel@ximian.com>
11291 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
11292 and convert that to the UnderlyingType.
11294 * statement.cs (Foreach.Resolve): Indexers are just like variables
11295 or PropertyAccesses.
11297 * cs-tokenizer.cs (consume_string): Track line numbers and columns
11298 inside quoted strings, we were not doing this before.
11300 2002-09-16 Martin Baulig <martin@gnome.org>
11302 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
11303 resolve it. This is needed for the definite assignment check of the
11304 instance expression, fixes bug #29846.
11305 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
11307 2002-09-16 Nick Drochak <ndrochak@gol.com>
11309 * parameter.cs: Fix compile error. Cannot reference static member
11310 from an instance object. Is this an mcs bug?
11312 2002-09-14 Martin Baulig <martin@gnome.org>
11314 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
11315 multiple times. Fixes bug #30295, added test-166.cs.
11317 2002-09-14 Martin Baulig <martin@gnome.org>
11319 * statement.cs (Block.Emit): Don't emit unreachable code.
11320 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
11321 `break' statements.
11322 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
11324 2002-09-14 Martin Baulig <martin@gnome.org>
11326 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
11329 2002-09-14 Martin Baulig <martin@gnome.org>
11331 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
11332 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
11333 be false on the ms runtime.
11335 2002-09-13 Martin Baulig <martin@gnome.org>
11337 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
11338 the CS0038 error message.
11340 2002-09-12 Miguel de Icaza <miguel@ximian.com>
11342 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
11343 constant inside, return it.
11345 2002-09-12 Martin Baulig <martin@gnome.org>
11347 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
11348 implicit conversion can be done between enum types.
11350 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
11351 check whether an implicit conversion to the current enum's UnderlyingType
11352 exists and report an error if not.
11354 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
11355 without debugging support.
11357 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
11358 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
11360 2002-09-12 Martin Baulig <martin@gnome.org>
11362 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
11364 * ecore.cs (IMemberExpr.DeclaringType): New property.
11365 (SimpleName.SimpleNameResolve): Check whether we're accessing a
11366 nonstatic member of an outer type (CS0038).
11368 2002-09-11 Miguel de Icaza <miguel@ximian.com>
11370 * driver.cs: Activate the using-error detector at warning level
11371 4 (at least for MS-compatible APIs).
11373 * namespace.cs (VerifyUsing): Small buglett fix.
11375 * pending.cs (PendingImplementation): pass the container pointer.
11377 * interface.cs (GetMethods): Allow for recursive definition. Long
11378 term, I would like to move every type to support recursive
11379 definitions, not the current ordering mechanism that we have right
11382 The situation is this: Attributes are handled before interfaces,
11383 so we can apply attributes to interfaces. But some attributes
11384 implement interfaces, we will now handle the simple cases
11385 (recursive definitions will just get an error).
11387 * parameter.cs: Only invalidate types at the end if we fail to
11390 2002-09-09 Martin Baulig <martin@gnome.org>
11392 * ecore.cs (PropertyExpr.Emit): Also check for
11393 TypeManager.system_int_array_get_length so this'll also work when
11394 compiling corlib. Fixes #30003.
11396 2002-09-09 Martin Baulig <martin@gnome.org>
11398 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
11399 and throw an exception if we can't get the type's size. Fixed #30040,
11402 2002-09-09 Martin Baulig <martin@gnome.org>
11404 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
11406 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
11407 context. Fixes bug #30027.
11409 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
11410 virtual functions. Fixes bug #30043, added test-164.cs.
11412 2002-09-08 Ravi Pratap <ravi@ximian.com>
11414 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
11416 2002-09-08 Nick Drochak <ndrochak@gol.com>
11418 * driver.cs: Use an object to get the windows codepage since it's not a
11421 2002-09-08 Miguel de Icaza <miguel@ximian.com>
11423 * statement.cs (For.Emit): for infinite loops (test == null)
11424 return whether there is a break inside, not always "true".
11426 * namespace.cs (UsingEntry): New struct to hold the name of the
11427 using definition, the location where it is defined, and whether it
11428 has been used in a successful type lookup.
11430 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
11435 2002-09-06 Ravi Pratap <ravi@ximian.com>
11437 * attribute.cs : Fix incorrect code which relied on catching
11438 a NullReferenceException to detect a null being passed in
11439 where an object was expected.
11441 2002-09-06 Miguel de Icaza <miguel@ximian.com>
11443 * statement.cs (Try): flag the catch variable as assigned
11445 * expression.cs (Cast): Simplified by using ResolveType instead of
11446 manually resolving.
11448 * statement.cs (Catch): Fix bug by using ResolveType.
11450 2002-09-06 Ravi Pratap <ravi@ximian.com>
11452 * expression.cs (BetterConversion): Special case for when we have
11453 a NullLiteral as the argument and we have to choose between string
11454 and object types - we choose string the way csc does.
11456 * attribute.cs (Attribute.Resolve): Catch the
11457 NullReferenceException and report error #182 since the Mono
11458 runtime no more has the bug and having this exception raised means
11459 we tried to select a constructor which takes an object and is
11462 2002-09-05 Ravi Pratap <ravi@ximian.com>
11464 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
11465 message (1502, 1503) when we can't locate a method after overload
11466 resolution. This is much more informative and closes the bug
11469 * interface.cs (PopulateMethod): Return if there are no argument
11470 types. Fixes a NullReferenceException bug.
11472 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
11473 expressions too. Previously we were checking only in one place for
11474 positional arguments leaving out named arguments.
11476 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
11477 type to the enum type is not allowed. Remove code corresponding to
11480 (ConvertNumericExplicit): Allow explicit conversions from
11481 the underlying type to enum type. This precisely follows the spec
11482 and closes a bug filed by Gonzalo.
11484 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11487 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
11489 2002-09-03 Miguel de Icaza <miguel@ximian.com>
11491 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
11492 it was important that we stored the right value after the
11493 reduction in `converted'.
11495 2002-09-04 Martin Baulig <martin@gnome.org>
11497 * location.cs (Location.SymbolDocument): Use full pathnames for the
11500 2002-08-30 Miguel de Icaza <miguel@ximian.com>
11502 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
11503 of the expression resolve mechanism, because that will catch the
11504 SimpleName error failures.
11506 (Conditional): If we can not resolve the
11507 expression, return, do not crash.
11509 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11512 (location): display token name instead of its number.
11514 2002-08-28 Martin Baulig <martin@gnome.org>
11516 * expression.cs (Binary.ResolveOperator): Don't silently return
11517 but return an error if an operator cannot be applied between two
11520 2002-08-28 Martin Baulig <martin@gnome.org>
11522 * class.cs (Constructor.Define): Set the permission attributes
11523 correctly instead of making all constructors public.
11525 2002-08-28 Martin Baulig <martin@gnome.org>
11527 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
11528 for private members before reporting a CS0103; if we find anything,
11531 2002-08-28 Martin Baulig <martin@gnome.org>
11533 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
11534 to check whether `closure_start_type == closure_invocation_type',
11535 we also need to check whether `m.DeclaringType == closure_invocation_type'
11536 before bypassing the permission checks. We might be accessing
11537 protected/private members from the base class.
11538 (TypeManager.RealMemberLookup): Only set private_ok if private
11539 members were requested via BindingFlags.NonPublic.
11541 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
11543 * expression.cs (MemberAccess.ResolveMemberAccess): Set
11544 MethodGroupExpr.IsExplicitImpl if appropriate.
11545 (Invocation.DoResolve): Don't report the CS0120 for explicit
11546 interface implementations.
11548 2002-08-27 Martin Baulig <martin@gnome.org>
11550 * expression.cs (Invocation.DoResolve): If this is a static
11551 method and we don't have an InstanceExpression, we must report
11554 2002-08-25 Martin Baulig <martin@gnome.org>
11556 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
11557 `==' between a valuetype and an object.
11559 2002-08-25 Miguel de Icaza <miguel@ximian.com>
11561 * ecore.cs (TypeExpr): Provide a ToString method.
11563 2002-08-24 Martin Baulig <martin@gnome.org>
11565 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
11566 now called proggie.dbg and it's a binary file.
11568 2002-08-23 Martin Baulig <martin@gnome.org>
11570 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
11572 2002-08-23 Martin Baulig <martin@gnome.org>
11574 * struct.cs (MyStructInfo.ctor): Make this work with empty
11575 structs; it's not allowed to use foreach() on null.
11577 2002-08-23 Martin Baulig <martin@gnome.org>
11579 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
11580 writer the full pathname of the generated assembly.
11582 2002-08-23 Martin Baulig <martin@gnome.org>
11584 * statements.cs (FlowBranching.UsageVector.MergeChildren):
11585 A `finally' block never returns or breaks; improved handling of
11588 2002-08-23 Martin Baulig <martin@gnome.org>
11590 * statement.cs (Throw.Resolve): Allow `throw null'.
11592 2002-08-23 Martin Baulig <martin@gnome.org>
11594 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
11595 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
11596 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
11597 MemberLookup would return a wrong event if this is an explicit
11598 interface implementation and the class has an event with the same
11601 2002-08-23 Martin Baulig <martin@gnome.org>
11603 * statement.cs (Block.AddChildVariableNames): New public method.
11604 (Block.AddChildVariableName): Likewise.
11605 (Block.IsVariableNameUsedInChildBlock): Likewise.
11606 (Block.AddVariable): Check whether a variable name has already
11607 been used in a child block.
11609 * cs-parser.jay (declare_local_variables): Mark all variable names
11610 from the current block as being used in a child block in the
11613 2002-08-23 Martin Baulig <martin@gnome.org>
11615 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
11616 find the symbol writer.
11618 * driver.cs: csc also allows the arguments to /define being
11619 separated by commas, not only by semicolons.
11621 2002-08-23 Martin Baulig <martin@gnome.org>
11623 * interface.cs (Interface.GetMembers): Added static check for events.
11625 2002-08-15 Martin Baulig <martin@gnome.org>
11627 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
11628 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
11630 * ecore.cs (Expression.MemberLookup): Added documentation and explained
11631 why the MethodData.EmitDestructor() change was necessary.
11633 2002-08-20 Martin Baulig <martin@gnome.org>
11635 * class.cs (TypeContainer.FindMembers): Added static check for events.
11637 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
11639 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
11640 use Type.GetEvents(), not Type.FindMembers().
11642 2002-08-20 Martin Baulig <martin@gnome.org>
11644 * decl.cs (MemberCache): Added a special method cache which will
11645 be used for method-only searched. This ensures that a method
11646 search will return a MethodInfo with the correct ReflectedType for
11649 2002-08-20 Martin Baulig <martin@gnome.org>
11651 * decl.cs (DeclSpace.FindMembers): Made this public.
11653 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11655 * delegate.cs: fixed build on windows.
11656 [FIXME: Filed as bug #29150: MCS must report these errors.]
11658 2002-08-19 Ravi Pratap <ravi@ximian.com>
11660 * ecore.cs (StandardConversionExists): Return a false
11661 if we are trying to convert the void type to anything else
11662 since that is not allowed.
11664 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
11665 we flag error 70 in the event an event is trying to be accessed
11666 directly from outside the declaring type.
11668 2002-08-20 Martin Baulig <martin@gnome.org>
11670 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
11671 MemberCache from typemanager.cs to decl.cs.
11673 2002-08-19 Martin Baulig <martin@gnome.org>
11675 * class.cs (TypeContainer): Implement IMemberContainer.
11676 (TypeContainer.DefineMembers): Create the MemberCache.
11677 (TypeContainer.FindMembers): Do better BindingFlags checking; only
11678 return public members if BindingFlags.Public was given, check
11679 whether members are static.
11681 2002-08-16 Martin Baulig <martin@gnome.org>
11683 * decl.cs (DeclSpace.Define): Splitted this in Define and
11684 DefineMembers. DefineMembers is called first and initializes the
11687 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
11688 DefineMembers() on all our DeclSpaces.
11690 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
11691 but call DefineMembers() on all nested interfaces. We call their
11692 Define() in our new Define() function.
11694 * interface.cs (Interface): Implement IMemberContainer.
11695 (Interface.Define): Moved all code except the attribute stuf to
11697 (Interface.DefineMembers): Initialize the member cache.
11699 * typemanager.cs (IMemberFinder): Removed this interface, we don't
11700 need this anymore since we can use MemberCache.FindMembers directly.
11702 2002-08-19 Martin Baulig <martin@gnome.org>
11704 * typemanager.cs (MemberCache): When creating the cache for an
11705 interface type, add all inherited members.
11706 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
11707 to `out bool used_cache' and documented it.
11708 (TypeManager.MemberLookup): If we already used the cache in the first
11709 iteration, we don't need to do the interfaces check.
11711 2002-08-19 Martin Baulig <martin@gnome.org>
11713 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
11714 here from IMemberFinder and don't implement this interface anymore.
11715 (DeclSpace.MemberCache): Moved here from IMemberFinder.
11717 * typemanager.cs (IMemberFinder): This interface is now only used by
11718 classes which actually support the member cache.
11719 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
11720 since we only put DeclSpaces into this Hashtable.
11721 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
11722 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
11724 2002-08-16 Martin Baulig <martin@gnome.org>
11726 * typemanager.cs (ICachingMemberFinder): Removed.
11727 (IMemberFinder.MemberCache): New property.
11728 (TypeManager.FindMembers): Merged this with RealFindMembers().
11729 This function will never be called from TypeManager.MemberLookup()
11730 so we can't use the cache here, just the IMemberFinder.
11731 (TypeManager.MemberLookup_FindMembers): Check whether the
11732 IMemberFinder has a MemberCache and call the cache's FindMembers
11734 (MemberCache): Rewrote larger parts of this yet another time and
11735 cleaned it up a bit.
11737 2002-08-15 Miguel de Icaza <miguel@ximian.com>
11739 * driver.cs (LoadArgs): Support quoting.
11741 (Usage): Show the CSC-like command line arguments.
11743 Improved a few error messages.
11745 2002-08-15 Martin Baulig <martin@gnome.org>
11747 * typemanager.cs (IMemberContainer.Type): New property.
11748 (IMemberContainer.IsInterface): New property.
11750 The following changes are conditional to BROKEN_RUNTIME, which is
11751 defined at the top of the file.
11753 * typemanager.cs (MemberCache.MemberCache): Don't add the base
11754 class'es members, but add all members from TypeHandle.ObjectType
11755 if we're an interface.
11756 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
11757 is the current type.
11758 (MemberCache.CacheEntry.Container): Removed this field.
11759 (TypeHandle.GetMembers): Include inherited members.
11761 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11763 * typemanager.cs: fixed compilation and added a comment on a field that
11766 2002-08-15 Martin Baulig <martin@gnome.org>
11768 * class.cs (ConstructorInitializer.Resolve): In the
11769 Expression.MemberLookup call, use the queried_type as
11772 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
11773 declared' attribute, it's always true.
11774 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
11775 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
11776 temporary wrapper for FindMembers which tells MemberLookup whether
11777 members from the base classes are included in the return value.
11778 This will go away soon.
11779 (TypeManager.MemberLookup): Use this temporary hack here; once the
11780 new MemberCache is completed, we don't need to do the DeclaredOnly
11781 looping here anymore since the MemberCache will take care of this.
11782 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
11783 (MemberCache): When creating the MemberCache for a class, get
11784 members from the current class and all its base classes.
11785 (MemberCache.CacheEntry.Container): New field. This is a
11786 temporary hack until the Mono runtime is fixed to distinguish
11787 between ReflectedType and DeclaringType. It allows us to use MCS
11788 with both the MS runtime and the unfixed Mono runtime without
11789 problems and without accecting performance.
11790 (MemberCache.SearchMembers): The DeclaredOnly looping from
11791 TypeManager.MemberLookup is now done here.
11793 2002-08-14 Martin Baulig <martin@gnome.org>
11795 * statement.cs (MyStructInfo.MyStructInfo): Don't call
11796 Type.GetFields on dynamic types but get the fields from the
11797 corresponding TypeContainer.
11798 (MyStructInfo.GetStructInfo): Added check for enum types.
11800 * typemanager.cs (MemberList.IsSynchronized): Implemented.
11801 (MemberList.SyncRoot): Implemented.
11802 (TypeManager.FilterWithClosure): No need to check permissions if
11803 closure_start_type == closure_invocation_type, don't crash if
11804 closure_invocation_type is null.
11806 2002-08-13 Martin Baulig <martin@gnome.org>
11808 Rewrote TypeContainer.FindMembers to use a member cache. This
11809 gives us a speed increase of about 35% for the self-hosting MCS
11810 build and of about 15-20% for the class libs (both on GNU/Linux).
11812 * report.cs (Timer): New class to get enhanced profiling. This
11813 whole class is "TIMER" conditional since it remarkably slows down
11816 * class.cs (MemberList): New class. This is an IList wrapper
11817 which we're now using instead of passing MemberInfo[]'s around to
11818 avoid copying this array unnecessarily.
11819 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
11820 (ICachingMemberFinder, IMemberContainer): New interface.
11821 (TypeManager.FilterWithClosure): If `criteria' is null, the name
11822 has already been checked, otherwise use it for the name comparision.
11823 (TypeManager.FindMembers): Renamed to RealMemberFinder and
11824 provided wrapper which tries to use ICachingMemberFinder.FindMembers
11825 if possible. Returns a MemberList, not a MemberInfo [].
11826 (TypeHandle): New class, implements IMemberContainer. We create
11827 one instance of this class per type, it contains a MemberCache
11828 which is used to do the member lookups.
11829 (MemberCache): New class. Each instance of this class contains
11830 all members of a type and a name-based hash table.
11831 (MemberCache.FindMembers): This is our new member lookup
11832 function. First, it looks up all members of the requested name in
11833 the hash table. Then, it walks this list and sorts out all
11834 applicable members and returns them.
11836 2002-08-13 Martin Baulig <martin@gnome.org>
11838 In addition to a nice code cleanup, this gives us a performance
11839 increase of about 1.4% on GNU/Linux - not much, but it's already
11840 half a second for the self-hosting MCS compilation.
11842 * typemanager.cs (IMemberFinder): New interface. It is used by
11843 TypeManager.FindMembers to call FindMembers on a TypeContainer,
11844 Enum, Delegate or Interface.
11845 (TypeManager.finder_to_member_finder): New PtrHashtable.
11846 (TypeManager.finder_to_container): Removed.
11847 (TypeManager.finder_to_delegate): Removed.
11848 (TypeManager.finder_to_interface): Removed.
11849 (TypeManager.finder_to_enum): Removed.
11851 * interface.cs (Interface): Implement IMemberFinder.
11853 * delegate.cs (Delegate): Implement IMemberFinder.
11855 * enum.cs (Enum): Implement IMemberFinder.
11857 * class.cs (TypeContainer): Implement IMemberFinder.
11859 2002-08-12 Martin Baulig <martin@gnome.org>
11861 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
11863 2002-08-12 Martin Baulig <martin@gnome.org>
11865 * ecore.cs (ITypeExpression): New interface for expressions which
11867 (TypeExpression): Renamed to TypeLookupExpression.
11868 (Expression.DoResolve): If we're doing a types-only lookup, the
11869 expression must implement the ITypeExpression interface and we
11870 call DoResolveType() on it.
11871 (SimpleName): Implement the new ITypeExpression interface.
11872 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
11873 hack, the situation that we're only looking up types can't happen
11874 anymore when this method is called. Moved the type lookup code to
11875 DoResolveType() and call it.
11876 (SimpleName.DoResolveType): This ITypeExpression interface method
11877 is now doing the types-only lookup.
11878 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
11879 (ResolveFlags): Added MaskExprClass.
11881 * expression.cs (MemberAccess): Implement the ITypeExpression
11883 (MemberAccess.DoResolve): Added support for a types-only lookup
11884 when we're called via ITypeExpression.DoResolveType().
11885 (ComposedCast): Implement the ITypeExpression interface.
11887 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
11888 Expression.Resolve() with ResolveFlags.Type instead.
11890 2002-08-12 Martin Baulig <martin@gnome.org>
11892 * interface.cs (Interface.Define): Apply attributes.
11894 * attribute.cs (Attribute.ApplyAttributes): Added support for
11895 interface attributes.
11897 2002-08-11 Martin Baulig <martin@gnome.org>
11899 * statement.cs (Block.Emit): Only check the "this" variable if we
11900 do not always throw an exception.
11902 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
11903 whether the property has a set accessor.
11905 2002-08-11 Martin Baulig <martin@gnome.org>
11907 Added control flow analysis support for structs.
11909 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
11910 with control flow analysis turned off.
11911 (IVariable): New interface.
11912 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
11913 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
11914 (FieldExpr.DoResolve): Resolve the instance expression with flow
11915 analysis turned off and do the definite assignment check after the
11916 resolving when we know what the expression will resolve to.
11918 * expression.cs (LocalVariableReference, ParameterReference):
11919 Implement the new IVariable interface, only call the flow analysis
11920 code if ec.DoFlowAnalysis is true.
11921 (This): Added constructor which takes a Block argument. Implement
11922 the new IVariable interface.
11923 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
11924 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
11925 This does the definite assignment checks for struct members.
11927 * class.cs (Constructor.Emit): If this is a non-static `struct'
11928 constructor which doesn't have any initializer, call
11929 Block.AddThisVariable() to tell the flow analysis code that all
11930 struct elements must be initialized before control returns from
11933 * statement.cs (MyStructInfo): New public class.
11934 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
11935 argument to this indexer. If non-zero, check an individual struct
11936 member, not the whole struct.
11937 (FlowBranching.CheckOutParameters): Check struct members.
11938 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
11939 overloaded versions of these methods which take an additional
11940 `int field_idx' argument to check struct members.
11941 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
11942 overloaded versions of these methods which take an additional
11943 `string field_name' argument to check struct member.s
11944 (VariableInfo): Implement the IVariable interface.
11945 (VariableInfo.StructInfo): New public property. Returns the
11946 MyStructInfo instance of the variable if it's a struct or null.
11947 (Block.AddThisVariable): New public method. This is called from
11948 Constructor.Emit() for non-static `struct' constructor which do
11949 not have any initializer. It creates a special variable for the
11950 "this" instance variable which will be checked by the flow
11951 analysis code to ensure that all of the struct's fields are
11952 initialized before control returns from the constructor.
11953 (UsageVector): Added support for struct members. If a
11954 variable/parameter is a struct with N members, we reserve a slot
11955 in the usage vector for each member. A struct is considered fully
11956 initialized if either the struct itself (slot 0) or all its
11957 members are initialized.
11959 2002-08-08 Martin Baulig <martin@gnome.org>
11961 * driver.cs (Driver.MainDriver): Only report an error CS5001
11962 if there were no compilation errors.
11964 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
11965 `UnsafeContext' property to determine whether the parent is in
11966 unsafe context rather than checking the parent's ModFlags:
11967 classes nested in an unsafe class are unsafe as well.
11969 2002-08-08 Martin Baulig <martin@gnome.org>
11971 * statement.cs (UsageVector.MergeChildren): Distinguish between
11972 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
11973 we return. Added test17() and test18() to test-154.cs.
11975 2002-08-08 Martin Baulig <martin@gnome.org>
11977 * typemanager.cs (TypeManager.FilterWithClosure): If we have
11978 Family access, make sure the invoking type isn't a subclass of the
11979 queried type (that'd be a CS1540).
11981 * ecore.cs (Expression.MemberLookup): Added overloaded version of
11982 this method which takes an additional `Type invocation_type'.
11984 * expression.cs (BaseAccess.DoResolve): Use the base type as
11985 invocation and query type.
11986 (MemberAccess.DoResolve): If the lookup failed and we're about to
11987 report a CS0122, try a lookup with the ec.ContainerType - if this
11988 succeeds, we must report a CS1540.
11990 2002-08-08 Martin Baulig <martin@gnome.org>
11992 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
11993 (MethodGroupExpr): Implement the IMemberExpr interface.
11995 * expression (MemberAccess.ResolveMemberAccess): No need to have
11996 any special code for MethodGroupExprs anymore, they're now
11999 2002-08-08 Martin Baulig <martin@gnome.org>
12001 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
12002 Family, FamANDAssem and FamORAssem permissions.
12003 (TypeManager.IsSubclassOrNestedChildOf): New public method.
12005 2002-08-08 Martin Baulig <martin@gnome.org>
12007 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
12008 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
12011 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
12013 * driver.cs: implemented /resource option to embed managed resources.
12015 2002-08-07 Martin Baulig <martin@gnome.org>
12017 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
12018 (FieldBase.HasFieldInitializer): New public property.
12019 (FieldBase.GetInitializerExpression): New public method. Resolves and
12020 returns the field initializer and makes sure it is only resolved once.
12021 (TypeContainer.EmitFieldInitializers): Call
12022 FieldBase.GetInitializerExpression to get the initializer, this ensures
12023 that it isn't resolved multiple times.
12025 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
12026 the resolving process (SimpleName/MemberLookup) that we're currently
12027 emitting a field initializer (which must not access any instance members,
12028 this is an error CS0236).
12030 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
12031 argument, if the `IsFieldInitializer' flag is set, we must report and
12032 error CS0236 and not an error CS0120.
12034 2002-08-07 Martin Baulig <martin@gnome.org>
12036 * ecore.cs (IMemberExpr): New public interface.
12037 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
12038 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
12039 if the expression is an IMemberExpr.
12041 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
12042 to be null, implicitly default to `this' if we're non-static in
12043 this case. Simplified the code a lot by using the new IMemberExpr
12044 interface. Also fixed bug #28176 here.
12046 2002-08-06 Martin Baulig <martin@gnome.org>
12048 * cs-parser.jay (SimpleLookup): Removed. We need to create
12049 ParameterReferences during semantic analysis so that we can do a
12050 type-only search when resolving Cast, TypeOf and SizeOf.
12051 (block): Pass the `current_local_parameters' to the Block's
12054 * class.cs (ConstructorInitializer): Added `Parameters parameters'
12055 argument to the constructor.
12056 (ConstructorInitializer.Resolve): Create a temporary implicit
12057 block with the parameters.
12059 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
12060 references here if we aren't doing a type-only search.
12062 * statement.cs (Block): Added constructor which takes a
12063 `Parameters parameters' argument.
12064 (Block.Parameters): New public property.
12066 * support.cs (InternalParameters.Parameters): Renamed `parameters'
12067 to `Parameters' and made it public readonly.
12069 2002-08-06 Martin Baulig <martin@gnome.org>
12071 * ecore.cs (Expression.Warning): Made this public as well.
12073 * report.cs (Report.Debug): Print the contents of collections.
12075 2002-08-06 Martin Baulig <martin@gnome.org>
12077 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
12078 used to tell Resolve() which kinds of expressions it may return.
12079 (Expression.Resolve): Added overloaded version of this method which
12080 takes a `ResolveFlags flags' argument. This can be used to tell
12081 Resolve() which kinds of expressions it may return. Reports a
12083 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
12084 ResolveFlags.SimpleName.
12085 (Expression.Error118): Added overloaded version of this method which
12086 takes a `ResolveFlags flags' argument. It uses the flags to determine
12087 which kinds of expressions are allowed.
12089 * expression.cs (Argument.ResolveMethodGroup): New public method.
12090 Resolves an argument, but allows a MethodGroup to be returned.
12091 This is used when invoking a delegate.
12093 * TODO: Updated a bit.
12095 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12097 Fixed compilation with csc.
12099 * ecore.cs: Expression.Error made public. Is this correct? Should
12100 Warning be made public too?
12102 * expression.cs: use ea.Location instead of ea.loc.
12103 [FIXME: Filed as bug #28607: MCS must report these errors.]
12105 2002-08-06 Martin Baulig <martin@gnome.org>
12107 * ecore.cs (Expression.loc): Moved the location here instead of
12108 duplicating it in all derived classes.
12109 (Expression.Location): New public property.
12110 (Expression.Error, Expression.Warning): Made them non-static and
12111 removed the location argument.
12112 (Expression.Warning): Added overloaded version which takes an
12113 `int level' argument.
12114 (Expression.Error118): Make this non-static and removed the
12115 expression and location arguments.
12116 (TypeExpr): Added location argument to the constructor.
12118 * expression.cs (StaticCallExpr): Added location argument to
12120 (Indirection, PointerArithmetic): Likewise.
12121 (CheckedExpr, UnCheckedExpr): Likewise.
12122 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
12123 (StringPtr): Likewise.
12126 2002-08-05 Martin Baulig <martin@gnome.org>
12128 * expression.cs (BaseAccess.DoResolve): Actually report errors.
12130 * assign.cs (Assign.DoResolve): Check whether the source
12131 expression is a value or variable.
12133 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
12134 while resolving the corresponding blocks.
12136 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
12137 an error, don't silently return null.
12139 * statement.cs (Block.AddVariable): Do the error reporting here
12140 and distinguish between CS0128 and CS0136.
12141 (Block.DoResolve): Report all unused labels (warning CS0164).
12142 (LabeledStatement): Pass the location to the constructor.
12143 (LabeledStatement.HasBeenReferenced): New property.
12144 (LabeledStatement.Resolve): Set it to true here.
12146 * statement.cs (Return.Emit): Return success even after reporting
12147 a type mismatch error (CS0126 or CS0127), this is what csc does and
12148 it avoids confusing the users with any consecutive errors.
12150 2002-08-05 Martin Baulig <martin@gnome.org>
12152 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
12154 * const.cs (Const.LookupConstantValue): Catch circular definitions.
12156 * expression.cs (MemberAccess.DoResolve): Silently return if an
12157 error has already been reported.
12159 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
12160 error has already been reported.
12162 2002-08-05 Martin Baulig <martin@gnome.org>
12164 * statement.cs (UsageVector): Only initialize the `parameters'
12165 vector if we actually have any "out" parameters.
12167 2002-08-05 Martin Baulig <martin@gnome.org>
12169 * expression.cs (Binary.ResolveOperator): When combining delegates,
12170 they must have the same type.
12172 2002-08-05 Martin Baulig <martin@gnome.org>
12174 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
12175 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
12176 work with the ms runtime and we also don't need it: if we're a
12177 PropertyBuilder and not in the `indexer_arguments' hash, then we
12178 are a property and not an indexer.
12180 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
12181 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
12182 since the latter one doesn't work with the ms runtime.
12184 2002-08-03 Martin Baulig <martin@gnome.org>
12186 Fixed bugs #27998 and #22735.
12188 * class.cs (Method.IsOperator): New public field.
12189 (Method.CheckBase): Report CS0111 if there's already a method
12190 with the same parameters in the current class. Report CS0508 when
12191 attempting to change the return type of an inherited method.
12192 (MethodData.Emit): Report CS0179 if a method doesn't have a body
12193 and it's not marked abstract or extern.
12194 (PropertyBase): New abstract base class for Property and Indexer.
12195 (PropertyBase.CheckBase): Moved here from Property and made it work
12197 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
12198 the same so we can reuse it there.
12199 (Property, Indexer): Derive from PropertyBase.
12200 (MethodSignature.inheritable_property_signature_filter): New delegate
12201 to find properties and indexers.
12203 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
12204 argument and improved error reporting.
12206 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
12207 EmptyReadOnlyParameters and made it a property.
12209 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
12210 version of this method which takes a `PropertyInfo indexer'.
12211 (TypeManager.RegisterIndexer): New method.
12213 * class.cs: Added myself as author of this file :-)
12215 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12217 * class.cs: fixed compilation on windoze.
12219 2002-08-03 Martin Baulig <martin@gnome.org>
12221 * interface.cs (Interface.GetInterfaceBases): Check whether all
12222 base interfaces are at least as accessible than the current one.
12224 * class.cs (TypeContainer.GetClassBases): Check whether base types
12225 are at least as accessible than the current type.
12226 (TypeContainer.AsAccessible): Implemented and made non-static.
12227 (MemberBase.CheckParameters): Report errors if the accessibility
12230 * delegate.cs (Delegate.Delegate): The default visibility is
12231 internal for top-level types and private for nested types.
12232 (Delegate.Define): Report errors if the accessibility checks fail.
12234 * enum.cs (Enum.Enum): The default visibility is internal for
12235 top-level types and private for nested types.
12236 (Enum.DefineType): Compute the correct visibility.
12238 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
12239 function which takes a `bool is_toplevel' instead of a TypeContainer.
12241 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
12244 2002-08-02 Martin Baulig <martin@gnome.org>
12246 * expression.cs (LocalVariableReferenc): Added constructor which
12247 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
12248 (LocalVariableReference.IsReadOnly): New property.
12249 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
12250 variable is readonly, use our own readonly flag to do this; you can
12251 use the new constructor to get a writable reference to a read-only
12254 * cs-parser.jay (foreach_statement, using_statement): Get a writable
12255 reference to the local variable.
12257 2002-08-01 Miguel de Icaza <miguel@ximian.com>
12259 * rootcontext.cs (ResolveCore): Also include System.Exception
12261 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
12262 we reach an EmptyStatement.
12264 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
12267 * expression.cs (Binary.ResolveOperator): Check error result in
12270 use brtrue/brfalse directly and avoid compares to null.
12272 2002-08-02 Martin Baulig <martin@gnome.org>
12274 * class.cs (TypeContainer.Define): Define all nested interfaces here.
12275 Fixes bug #28407, added test-155.cs.
12277 2002-08-01 Martin Baulig <martin@gnome.org>
12279 * class.cs (Event.EmitDefaultMethod): Make this work with static
12280 events. Fixes #28311, added verify-3.cs.
12282 2002-08-01 Martin Baulig <martin@gnome.org>
12284 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
12285 `is_disposable' fields.
12286 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
12287 `hm.is_disposable' if we're using the collection pattern.
12288 (Foreach.EmitCollectionForeach): Use the correct type for the
12289 enumerator's local variable, only emit the try/finally block if
12290 necessary (fixes #27713).
12292 2002-08-01 Martin Baulig <martin@gnome.org>
12294 * ecore.cs (Expression.report118): Renamed to Error118 and made
12297 * statement.cs (Throw.Resolve): Check whether the expression is of
12298 the correct type (CS0118) and whether the type derives from
12299 System.Exception (CS0155).
12300 (Catch.Resolve): New method. Do the type lookup here and check
12301 whether it derives from System.Exception (CS0155).
12302 (Catch.CatchType, Catch.IsGeneral): New public properties.
12304 * typemanager.cs (TypeManager.exception_type): Added.
12306 2002-07-31 Miguel de Icaza <miguel@ximian.com>
12308 * driver.cs: Updated About function.
12310 2002-07-31 Martin Baulig <martin@gnome.org>
12312 Implemented Control Flow Analysis.
12314 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
12315 (EmitContext.CurrentBranching): Added.
12316 (EmitContext.StartFlowBranching): Added.
12317 (EmitContext.EndFlowBranching): Added.
12318 (EmitContext.KillFlowBranching): Added.
12319 (EmitContext.IsVariableAssigned): Added.
12320 (EmitContext.SetVariableAssigned): Added.
12321 (EmitContext.IsParameterAssigned): Added.
12322 (EmitContext.SetParameterAssigned): Added.
12323 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
12324 Added control flow analysis stuff here.
12326 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
12327 resolve the expression as lvalue.
12328 (LocalVariableReference.DoResolve): Check whether the variable has
12329 already been assigned.
12330 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
12331 the parameter as assigned here.
12332 (ParameterReference.DoResolve): Check whether the parameter has already
12334 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
12335 expression as lvalue.
12337 * statement.cs (FlowBranching): New class for the flow analysis code.
12338 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
12339 (LabeledStatement.IsDefined): New public property.
12340 (LabeledStatement.AddUsageVector): New public method to tell flow
12341 analyis that the label may be reached via a forward jump.
12342 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
12344 (VariableInfo.Number): New public field. This is used by flow analysis
12345 to number all locals of a block.
12346 (Block.CountVariables): New public property. This is the number of
12347 local variables in this block (including the locals from all parent
12349 (Block.EmitMeta): Number all the variables.
12351 * statement.cs: Added flow analysis support to all classes.
12353 2002-07-31 Martin Baulig <martin@gnome.org>
12355 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
12356 To get debugging messages, compile mcs with /define:MCS_DEBUG and
12357 then use this argument.
12359 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
12361 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
12362 use this to specify /define options.
12364 2002-07-29 Martin Baulig <martin@gnome.org>
12366 * statement.cs (Fixed): Moved all code that does variable lookups
12367 and resolvings from Emit to Resolve.
12369 * statement.cs (For): Moved all code that does variable lookups
12370 and resolvings from Emit to Resolve.
12372 * statement.cs (Using): Moved all code that does variable lookups
12373 and resolvings from Emit to Resolve.
12375 2002-07-29 Martin Baulig <martin@gnome.org>
12377 * attribute.cs (Attribute.Resolve): Explicitly catch a
12378 System.NullReferenceException when creating the
12379 CustromAttributeBuilder and report a different warning message.
12381 2002-07-29 Martin Baulig <martin@gnome.org>
12383 * support.cs (ParameterData.ParameterName): Added method to
12384 get the name of a parameter.
12386 * typemanager.cs (TypeManager.IsValueType): New public method.
12388 2002-07-29 Martin Baulig <martin@gnome.org>
12390 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
12391 is a flag which specifies that it's either ref or out.
12392 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
12393 the out parameter to `out Parameter.Modifier mod', also set the
12394 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
12396 * support.cs (InternalParameters.ParameterModifier): Distinguish
12397 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
12398 Parameter.Modifier.ISBYREF flag if it's either ref or out.
12400 * expression.cs (Argument.GetParameterModifier): Distinguish
12401 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
12402 Parameter.Modifier.ISBYREF flag if it's either ref or out.
12404 2002-07-29 Martin Baulig <martin@gnome.org>
12406 * expression.cs (ParameterReference.ParameterReference): Added
12407 `Location loc' argument to the constructor.
12409 * cs-parser.jay: Pass location to ParameterReference.
12411 2002-07-28 Miguel de Icaza <miguel@ximian.com>
12413 * statement.cs (Try): Initialize the location.
12415 * cs-parser.jay: pass location to Try.
12417 * expression.cs (Unary.Reduce): Change the prototype to return
12418 whether a constant fold could be performed or not. The result is
12419 returned in an out parameters. In the case of Indirection and
12420 AddressOf, we want to perform the full tests.
12422 2002-07-26 Miguel de Icaza <miguel@ximian.com>
12424 * statement.cs (Statement.Emit): Flag dead code.
12426 2002-07-27 Andrew Birkett <andy@nobugs.org>
12428 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
12430 2002-07-27 Martin Baulig <martin@gnome.org>
12432 * class.cs (MethodData.Define): Put back call to
12433 TypeManager.AddMethod(), accidentally commented this out.
12435 * report.cs (Debug): New public method to print debugging information,
12436 this is `[Conditional ("DEBUG")]'.
12438 2002-07-26 Martin Baulig <martin@gnome.org>
12440 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
12441 (switch_statement): Push the current_block to the switch_stack and
12442 pop it again when we're done with the switch.
12443 (switch_section): The new block is a child of the current_block.
12444 Fixes bug #24007, added test-152.cs.
12446 2002-07-27 Martin Baulig <martin@gnome.org>
12448 * expression.cs (Invocation.EmitArguments): When calling a varargs
12449 function with only its fixed arguments, we need to pass an empty
12452 2002-07-27 Martin Baulig <martin@gnome.org>
12454 Mono 0.13 has been released.
12456 2002-07-25 Miguel de Icaza <miguel@ximian.com>
12458 * driver.cs: Rename --resource to --linkres, because that is what
12459 we do currently, we dont support --resource yet.
12461 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
12463 2002-07-25 Martin Baulig <martin@gnome.org>
12465 * class.cs (MethodData): New public class. This is a `method builder'
12466 class for a method or one accessor of a Property/Indexer/Event.
12467 (MethodData.GetMethodFlags): Moved here from MemberBase.
12468 (MethodData.ApplyAttributes): Likewise.
12469 (MethodData.ApplyObsoleteAttribute): Likewise.
12470 (MethodData.ApplyConditionalAttribute): Likewise.
12471 (MethodData.ApplyDllImportAttribute): Likewise.
12472 (MethodData.CheckAbstractAndExternal): Likewise.
12473 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
12474 (MethodData.Emit): Formerly known as Method.Emit().
12475 (MemberBase): Moved everything which was specific to a single
12476 accessor/method to MethodData.
12477 (Method): Create a new MethodData and call Define() and Emit() on it.
12478 (Property, Indexer, Event): Create a new MethodData objects for each
12479 accessor and call Define() and Emit() on them.
12481 2002-07-25 Martin Baulig <martin@gnome.org>
12483 Made MethodCore derive from MemberBase to reuse the code from there.
12484 MemberBase now also checks for attributes.
12486 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
12487 (MemberBase.GetMethodFlags): Moved here from class Method and marked
12489 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
12490 `CallingConventions cc' and `Attributes opt_attrs' arguments.
12491 (MemberBase.ApplyAttributes): New virtual method; applies the
12492 attributes to a method or accessor.
12493 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
12494 (MemberBase.ApplyConditionalAttribute): Likewise.
12495 (MemberBase.ApplyDllImportAttribute): Likewise.
12496 (MemberBase.CheckAbstractAndExternal): Likewise.
12497 (MethodCore.ParameterTypes): This is now a property instead of a
12498 method, it's initialized from DoDefineParameters().
12499 (MethodCore.ParameterInfo): Removed the set accessor.
12500 (MethodCore.DoDefineParameters): New protected virtual method to
12501 initialize ParameterTypes and ParameterInfo.
12502 (Method.GetReturnType): We can now simply return the MemberType.
12503 (Method.GetMethodFlags): Override the MemberBase version and add
12504 the conditional flags.
12505 (Method.CheckBase): Moved some code from Define() here, call
12506 DoDefineParameters() here.
12507 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
12508 here to avoid some larger code duplication.
12509 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
12510 ensure that abstract and external accessors don't declare a body.
12512 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
12513 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
12514 lookup in the attribute's parent classes, so we need to abort as soon
12515 as we found the first match.
12516 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
12517 the attribute has no arguments.
12519 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
12522 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12524 * cs-parser.jay: reverted previous patch.
12526 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12528 * cs-parser.jay: fixed bug #22119.
12530 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12532 * attribute.cs: fixed compilation. The error was:
12533 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
12534 be assigned to before control leaves the current method."
12535 [FIXME: Filed as bug #28186: MCS must report this error.]
12537 2002-07-25 Martin Baulig <martin@gnome.org>
12539 * attribute.cs (Attribute.Conditional_GetConditionName): New static
12540 method to pull the condition name ouf of a Conditional attribute.
12541 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
12542 the obsolete message and error flag out of an Obsolete attribute.
12544 * class.cs (Method.GetMethodFlags): New public method to get the
12545 TypeManager.MethodFlags for this method.
12546 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
12548 (Method.Define): Get and apply the Obsolete and Conditional attributes;
12549 if we're overriding a virtual function, set the new private variable
12550 `parent_method'; call the new TypeManager.AddMethod().
12552 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
12553 the MethodBuilder and the Method in a PtrHashtable.
12554 (TypeManager.builder_to_method): Added for this purpose.
12555 (TypeManager.MethodFlags): Added IsObsoleteError.
12556 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
12557 Obsolete and Conditional arguments in MethodBuilders. If we discover
12558 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
12559 the message from the attribute.
12561 2002-07-24 Martin Baulig <martin@gnome.org>
12563 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
12564 preprocessor directives, ensure that the argument to #define/#undef is
12565 exactly one identifier and that it's actually an identifier.
12567 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
12570 2002-07-24 Martin Baulig <martin@gnome.org>
12572 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
12573 initialize it to TypeManager.object_type in the constructor.
12574 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
12575 of the `hm.get_current' method if we're using the collection pattern.
12576 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
12577 for the explicit conversion to make it work when we're using the collection
12578 pattern and the `Current' property has a different return type than `object'.
12581 2002-07-24 Martin Baulig <martin@gnome.org>
12583 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
12584 does not match, but don't report any errors. This method is called in
12585 order for all methods in a MethodGroupExpr until a matching method is
12586 found, so we don't want to bail out if the first method doesn't match.
12587 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
12588 matches, report the 123. Fixes #28070.
12590 2002-07-24 Martin Baulig <martin@gnome.org>
12592 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
12593 TypeManager.TypeToCoreType() to the top of the method so the
12594 following equality checks will work. Fixes #28107.
12596 2002-07-24 Martin Baulig <martin@gnome.org>
12598 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
12599 operand is of type uint, and the other operand is of type sbyte,
12600 short or int, the operands are converted to type long." -
12601 Actually do what this comment already told us. Fixes bug #28106,
12604 2002-07-24 Martin Baulig <martin@gnome.org>
12606 * class.cs (MethodBase): New abstract class. This is now a base
12607 class for Property, Indexer and Event to avoid some code duplication
12608 in their Define() and DefineMethods() methods.
12609 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
12610 generic methods for Define() and DefineMethods().
12611 (FieldBase): Derive from MemberBase, not MemberCore.
12612 (Property): Derive from MemberBase, not MemberCore.
12613 (Property.DefineMethod): Moved all the code from this method to the
12614 new MethodBase.DefineAccessor(), just call it with appropriate
12616 (Property.Define): Call the new Property.DoDefine(), this does some
12617 sanity checks and we don't need to duplicate the code everywhere.
12618 (Event): Derive from MemberBase, not MemberCore.
12619 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
12620 accessors, this will also make them work with interface events.
12621 (Indexer): Derive from MemberBase, not MemberCore.
12622 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
12623 (Indexer.Define): Use the new MethodBase functions.
12625 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
12626 argument to the constructor.
12627 (Interface.FindMembers): Added support for interface events.
12628 (Interface.PopluateEvent): Implemented.
12630 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
12632 2002-07-22 Miguel de Icaza <miguel@ximian.com>
12634 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
12635 but this is required to check for a method name being the same as
12636 the containing class.
12640 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12642 * interface.cs: initialize variable.
12644 2002-07-23 Martin Baulig <martin@gnome.org>
12646 Implemented the IndexerName attribute in interfaces.
12648 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
12649 name if this is an explicit interface implementation.
12650 (Indexer.InterfaceIndexerName): New public variable. If we're
12651 implementing an interface indexer, this is the IndexerName in that
12652 interface. Otherwise, it's the IndexerName.
12653 (Indexer.DefineMethod): If we're implementing interface indexer,
12654 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
12655 and Pending.ImplementIndexer methods.
12656 (Indexer.Define): Also define the PropertyBuilder if we're
12657 implementing an interface indexer and this is neither an explicit
12658 interface implementation nor do the IndexerName match the one in
12661 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
12662 If a method is defined here, then we always need to create a proxy
12663 for it. This is used when implementing interface indexers.
12664 (Pending.IsInterfaceIndexer): New public method.
12665 (Pending.ImplementIndexer): New public method.
12666 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
12667 This is used when implementing interface indexers to define a proxy
12669 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
12670 define a proxy if necessary.
12672 * interface.cs (Interface.IndexerName): New public variable.
12673 (Interface.PopulateIndexer): Set the IndexerName.
12674 (Interface.DefineIndexers): New private method. Populate all the
12675 indexers and make sure their IndexerNames match.
12677 * typemanager.cs (IndexerPropertyName): Added support for interface
12680 2002-07-22 Martin Baulig <martin@gnome.org>
12682 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
12683 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
12684 ret if HasReturnLabel.
12685 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
12688 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
12689 and set the ec.LoopBeginTryCatchLevel.
12690 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
12691 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
12692 the current ec.TryCatchLevel, the branch goes out of an exception
12693 block. In this case, we need to use Leave and not Br.
12695 2002-07-22 Martin Baulig <martin@gnome.org>
12697 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
12698 block unless the block does not always return or it is contained in
12699 another try { ... } catch { ... } block. Fixes bug #26506.
12700 Added verify-1.cs to the test suite.
12702 2002-07-22 Martin Baulig <martin@gnome.org>
12704 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
12705 then we do not always return. Fixes bug #24985.
12707 2002-07-22 Martin Baulig <martin@gnome.org>
12709 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
12710 lookup on a per-class level; ie. walk up the class hierarchy until we
12711 found at least one applicable method, then choose the best among them.
12712 Fixes bug #24463 and test-29.cs.
12714 2002-07-22 Martin Baulig <martin@gnome.org>
12716 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
12717 return types of the methods. The return type is not part of the
12718 signature and we must not check it to make the `new' modifier work.
12719 Fixes bug #27999, also added test-147.cs.
12720 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
12722 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
12723 on the method's return type.
12725 2002-07-21 Martin Baulig <martin@gnome.org>
12727 * assign.cs: Make this work if the rightmost source is a constant and
12728 we need to do an implicit type conversion. Also adding a few more tests
12729 to test-38.cs which should have caught this.
12731 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
12732 target in the makefile for this. The makefile.gnu is primarily intended
12733 for end-users who don't want to debug the compiler.
12735 2002-07-21 Martin Baulig <martin@gnome.org>
12737 * assign.cs: Improved the Assign class so it can now handle embedded
12738 assignments (X = Y = Z = something). As a side-effect this'll now also
12739 consume less local variables. test-38.cs now passes with MCS, added
12740 a few new test cases to that test.
12742 2002-07-20 Martin Baulig <martin@gnome.org>
12744 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
12745 instructions. Fixes bug #27977, also added test-146.cs.
12747 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12749 * cs-tokenizer.cs: fixed getHex ().
12751 2002-07-19 Martin Baulig <martin@gnome.org>
12753 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
12754 not Type.GetType() to lookup the array type. This is needed when
12755 we're constructing an array of a user-defined type.
12756 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
12757 single-dimensional arrays, but also for single-dimensial arrays of
12760 2002-07-19 Martin Baulig <martin@gnome.org>
12762 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
12763 this function is called, it's not allowed to share LocalBuilders
12764 among ILGenerators.
12766 2002-07-19 Martin Baulig <martin@gnome.org>
12768 * expression.cs (Argument.Resolve): Report an error 118 when trying
12769 to pass a type as argument.
12771 2002-07-18 Martin Baulig <martin@gnome.org>
12773 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
12774 Conv_R_Un for the signed `long' type.
12776 2002-07-15 Miguel de Icaza <miguel@ximian.com>
12778 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
12779 `expr' for the temporary result, as that will fail if we do
12780 multiple resolves on the same expression.
12782 2002-07-05 Miguel de Icaza <miguel@ximian.com>
12784 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
12785 ec.TypeContainer for looking up aliases.
12787 * class.cs (TypeContainer): Remove LookupAlias from here.
12789 * decl.cs (DeclSpace); Move here.
12791 2002-07-01 Miguel de Icaza <miguel@ximian.com>
12793 * class.cs (FindMembers): Only call filter if the constructor
12794 bulider is not null.
12796 Also handle delegates in `NestedTypes' now. Now we will perform
12797 type lookups using the standard resolution process. This also
12800 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
12801 This uses Expressions (the limited kind that can be parsed by the
12802 tree) instead of strings.
12804 * expression.cs (ComposedCast.ToString): Implement, used to flag
12805 errors since now we have to render expressions.
12807 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
12810 * ecore.cs (SimpleName.ToString): ditto.
12812 * cs-parser.jay: Instead of using strings to assemble types, use
12813 Expressions to assemble the type (using SimpleName, ComposedCast,
12814 MemberAccess). This should fix the type lookups in declarations,
12815 because we were using a different code path for this.
12817 * statement.cs (Block.Resolve): Continue processing statements
12818 even when there is an error.
12820 2002-07-17 Miguel de Icaza <miguel@ximian.com>
12822 * class.cs (Event.Define): Also remove the `remove' method from
12823 the list of pending items.
12825 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
12826 generate more compact code.
12828 2002-07-17 Martin Baulig <martin@gnome.org>
12830 * const.cs (Const.LookupConstantValue): Add support for constant
12831 `unchecked' and `checked' expressions.
12832 Also adding test case test-140.cs for this.
12834 2002-07-17 Martin Baulig <martin@gnome.org>
12836 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
12837 check whether mi.ReturnType implements the IEnumerator interface; the
12838 `==' and the IsAssignableFrom() will fail in this situation.
12840 2002-07-16 Ravi Pratap <ravi@ximian.com>
12842 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
12845 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12847 * expression.cs: fixed bug #27811.
12849 2002-07-14 Miguel de Icaza <miguel@ximian.com>
12851 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
12852 Molaro: when we are a ref, the value already contains a pointer
12853 value, do not take the address of it.
12855 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
12856 * removed mb-parser.jay and mb-tokenizer.cs
12858 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
12860 * expression.cs: check against the building corlib void type.
12862 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
12864 * ecore.cs: fix for valuetype static readonly fields: when
12865 initializing them, we need their address, not the address of a copy.
12867 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
12869 * typemanager.cs: register also enum_type in corlib.
12871 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
12873 * class.cs: allow calling this (but not base) initializers in structs.
12875 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
12877 * ecore.cs: make sure we compare against the building base types
12880 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
12882 * typemanager.cs: fix TypeToCoreType() to handle void and object
12883 (corlib gets no more typerefs after this change).
12885 2002-07-12 Miguel de Icaza <miguel@ximian.com>
12887 * expression.cs (ArrayCreation.EmitArrayArguments): use
12888 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
12890 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
12891 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
12892 array indexes, the runtime actually forbids them.
12894 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
12895 for array arguments here.
12897 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
12898 instead of the default for ValueTypes.
12900 (New.DoEmit): Use IsValueType instead of
12901 IsSubclassOf (value_type)
12902 (New.DoResolve): ditto.
12903 (Invocation.EmitCall): ditto.
12905 * assign.cs (Assign): ditto.
12907 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
12908 Statements *are* currently doing part of their resolution during
12911 Expressions do always resolve during resolve, but statements are
12912 only required to propagate resolution to their children.
12914 2002-07-11 Miguel de Icaza <miguel@ximian.com>
12916 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
12918 (LoadAssembly): Do not add the dll if it is already specified
12920 (MainDriver): Add the System directory to the link path at the end,
12921 after all the other -L arguments.
12923 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
12924 wrong opcode for loading bytes and bools (ldelem.i1 instead of
12925 ldelem.u1) and using the opposite for sbytes.
12927 This fixes Digger, and we can finally run it.
12929 * driver.cs (UnixParseOption): Move the option parsing here.
12930 (CSCParseOption): Implement CSC-like parsing of options.
12932 We now support both modes of operation, the old Unix way, and the
12933 new CSC-like way. This should help those who wanted to make cross
12934 platform makefiles.
12936 The only thing broken is that /r:, /reference: and /lib: are not
12937 implemented, because I want to make those have the same semantics
12938 as the CSC compiler has, and kill once and for all the confussion
12939 around this. Will be doing this tomorrow.
12941 * statement.cs (Unsafe.Resolve): The state is checked during
12942 resolve, not emit, so we have to set the flags for IsUnsfe here.
12944 2002-07-10 Miguel de Icaza <miguel@ximian.com>
12946 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
12947 not catch the Error_ObjectRefRequired in SimpleName (as it is
12948 possible to have a class/instance variable name that later gets
12949 deambiguated), we have to check this here.
12951 2002-07-10 Ravi Pratap <ravi@ximian.com>
12953 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
12954 make static and put into Expression.
12956 (Event.Define): Register the private field of the event with the
12957 TypeManager so that GetFieldFromEvent can get at it.
12959 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
12960 keep track of the private field associated with an event which
12963 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
12966 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
12968 2002-07-10 Miguel de Icaza <miguel@ximian.com>
12970 * expression.cs (Binary.EmitBranchable): this routine emits the
12971 Binary expression in a branchable context. This basically means:
12972 we need to branch somewhere, not just get the value on the stack.
12974 This works together with Statement.EmitBoolExpression.
12976 * statement.cs (Statement.EmitBoolExpression): Use
12979 2002-07-09 Miguel de Icaza <miguel@ximian.com>
12981 * statement.cs (For): Reduce the number of jumps in loops.
12983 (For): Implement loop inversion for the For statement.
12985 (Break): We can be breaking out of a Try/Catch controlled section
12986 (foreach might have an implicit try/catch clause), so we need to
12987 use Leave instead of Br.
12989 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
12990 now). If the instace expression supports IMemoryLocation, we use
12991 the AddressOf method from the IMemoryLocation to extract the
12992 address instead of emitting the instance.
12994 This showed up with `This', as we were emitting the instance
12995 always (Emit) instead of the Address of This. Particularly
12996 interesting when This is a value type, as we dont want the Emit
12997 effect (which was to load the object).
12999 2002-07-08 Miguel de Icaza <miguel@ximian.com>
13001 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
13003 * statement.cs (Checked): Set the CheckedState during the resolve
13004 process too, as the ConvCast operations track the checked state on
13005 the resolve process, and not emit.
13007 * cs-parser.jay (namespace_member_declaration): Flag that we have
13008 found a declaration when we do. This is used to flag error 1529
13010 * driver.cs: Report ok when we display the help only.
13012 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
13014 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
13016 2002-07-04 Miguel de Icaza <miguel@ximian.com>
13018 * cs-tokenizer.cs (define): We also have to track locally the
13019 defines. AllDefines is just used for the Conditional Attribute,
13020 but we also need the local defines for the current source code.
13022 2002-07-03 Miguel de Icaza <miguel@ximian.com>
13024 * statement.cs (While, For, Do): These loops can exit through a
13025 Break statement, use this information to tell whether the
13026 statement is the last piece of code.
13028 (Break): Flag that we break.
13030 * codegen.cs (EmitContexts): New `Breaks' state variable.
13032 2002-07-03 Martin Baulig <martin@gnome.org>
13034 * class.cs (TypeContainer.MethodModifiersValid): Allow override
13035 modifiers in method declarations in structs. Otherwise, you won't
13036 be able to override things like Object.Equals().
13038 2002-07-02 Miguel de Icaza <miguel@ximian.com>
13040 * class.cs (Method, Property, Indexer): Do not allow the public
13041 modifier to be used in explicit interface implementations.
13043 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
13044 override modifiers in method declarations in structs
13046 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
13048 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
13049 integer or real overflow, report an error
13051 2002-07-02 Martin Baulig <martin@gnome.org>
13053 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
13054 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
13055 to tell the runtime about our newly created System.Object and
13056 System.ValueType types.
13058 2002-07-02 Miguel de Icaza <miguel@ximian.com>
13060 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
13061 struct instead of Ldarg/Starg.
13063 2002-07-02 Martin Baulig <martin@gnome.org>
13065 * expression.cs (Indirection.Indirection): Call
13066 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
13068 2002-07-02 Martin Baulig <martin@gnome.org>
13070 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
13071 ValueType, call TypeManager.TypeToCoreType() on it.
13072 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
13073 the OpCodes.Newarr argument.
13075 2002-07-02 Martin Baulig <martin@gnome.org>
13077 * expression.cs (Invocation.EmitCall): When compiling corlib,
13078 replace all calls to the system's System.Array type to calls to
13079 the newly created one.
13081 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
13082 System.Array methods.
13083 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
13084 from the system's System.Array type which must be replaced.
13086 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
13088 * typemanager.cs: load unverifiable_code_ctor so we can build
13089 corlib using the correct type. Avoid using GetTypeCode() with
13091 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
13092 TypeManager.object_type to allow building corlib.
13094 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
13096 * ecore.cs: handle System.Enum separately in LoadFromPtr().
13098 2002-07-01 Martin Baulig <martin@gnome.org>
13100 * class.cs: Make the last change actually work, we need to check
13101 whether `ifaces != null' to avoid a crash.
13103 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
13105 * class.cs: when we build structs without fields that implement
13106 interfaces, we need to add the interfaces separately, since there is
13107 no API to both set the size and add the interfaces at type creation
13110 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
13112 * expression.cs: the dimension arguments to the array constructors
13113 need to be converted if they are a long.
13115 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
13117 * class.cs: don't emit ldarg.0 if there is no parent constructor
13118 (fixes showstopper for corlib).
13120 2002-06-29 Martin Baulig <martin@gnome.org>
13122 MCS now compiles corlib on GNU/Linux :-)
13124 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
13125 ie. check for MethodImplOptions.InternalCall.
13127 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
13128 and TypeManager.attribute_type are null, so we must explicitly check
13129 whether parent is not null to find out whether it's an attribute type.
13130 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
13131 and SetBuilder, not only if the property is neither abstract nor external.
13132 This is necessary to set the MethodImplOptions on the accessor methods.
13133 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
13134 SetBuilder, see Property.Emit().
13136 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
13137 populate "System.Object", "System.ValueType" and "System.Attribute" since
13138 they've already been populated from BootCorlib_PopulateCoreTypes().
13140 2002-06-29 Martin Baulig <martin@gnome.org>
13142 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
13143 is the NullLiteral, we also need to make sure that target_type is not
13146 2002-06-29 Martin Baulig <martin@gnome.org>
13148 * rootcontext.cs (RootContext.ResolveCore): We must initialize
13149 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
13150 before calling BootstrapCorlib_ResolveDelegate ().
13152 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13154 * statement.cs: fixed build-breaker. All tests passed ok.
13156 2002-06-27 Martin Baulig <martin@gnome.org>
13158 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
13159 for System.Decimal when compiling corlib.
13161 2002-06-27 Martin Baulig <martin@gnome.org>
13163 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
13164 switch blocks which contain nothing but a default clause.
13166 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
13168 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
13170 2002-06-27 Martin Baulig <martin@gnome.org>
13172 * ecore.cs (PropertyExpr.PropertyExpr): Call
13173 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
13175 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
13176 is already a TypeBuilder.
13178 2002-06-27 Martin Baulig <martin@gnome.org>
13180 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
13181 `target_type == TypeManager.array_type', not IsAssignableFrom() in
13182 the "from an array-type to System.Array" case. This makes it work
13183 when compiling corlib.
13185 2002-06-27 Martin Baulig <martin@gnome.org>
13187 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
13188 non-static PropertyExpr, set its InstanceExpression. This makes
13189 the `ICollection.Count' property work in System/Array.cs.
13191 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
13193 * driver.cs: Made error handling more consistent. Errors now
13194 tracked by Report class, so many methods which used to return int
13195 now return void. Main() now prints success/failure and
13196 errors/warnings message.
13198 Renamed '--probe' compiler argument to '--expect-error'. Removed
13199 the magic number return values (123 and 124). Now, if the
13200 expected error occurs, the compiler exits with success (exit value
13201 0). If the compilation completes without seeing that particular
13202 error, the compiler exits with failure (exit value 1). The
13203 makefile in mcs/errors has been changed to handle the new behaviour.
13205 * report.cs: Made 'expected error' number a property and renamed
13206 it from 'Probe' to 'ExpectedError'.
13208 * genericparser.cs: Removed error handling support, since it is
13209 now all done by Report class.
13211 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
13212 class, so parse() no longer returns an int.
13214 * namespace.cs: Use Report.Error instead of GenericParser.error
13216 2002-06-22 Miguel de Icaza <miguel@ximian.com>
13218 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
13219 TypeContainer.AddOperator): At the front of the list put the
13220 explicit implementations, so they get resolved/defined first.
13222 2002-06-21 Miguel de Icaza <miguel@ximian.com>
13224 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
13225 interface type is implemented by this TypeContainer. Used during
13226 explicit interface implementation.
13228 (Property.Define, Indexer.Define, Method.Define): Validate that
13229 the given interface in the explicit implementation is one of the
13230 base classes for the containing type.
13232 Also if we are explicitly implementing an interface, but there is
13233 no match in the pending implementation table, report an error.
13235 (Property.Define): Only define the property if we are
13236 not explicitly implementing a property from an interface. Use the
13237 correct name also for those properties (the same CSC uses,
13238 although that is really not needed).
13240 (Property.Emit): Do not emit attributes for explicitly implemented
13241 properties, as there is no TypeBuilder.
13243 (Indexer.Emit): ditto.
13245 Hiding then means that we do not really *implement* a pending
13246 implementation, which makes code fail.
13248 2002-06-22 Martin Baulig <martin@gnome.org>
13250 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
13251 the return value of Object.GetType(). [FIXME: we need to do this whenever
13252 we get a type back from the reflection library].
13254 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
13256 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
13258 2002-06-20 Miguel de Icaza <miguel@ximian.com>
13260 * attribute.cs: Return null if we can not look up the type.
13262 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
13263 the interface types found.
13265 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
13266 interface types found.
13268 * typemanager.cs (GetInterfaces): Make this routine returns alll
13269 the interfaces and work around the lame differences between
13270 System.Type and System.Reflection.Emit.TypeBuilder in the results
13271 result for GetInterfaces.
13273 (ExpandInterfaces): Given an array of interface types, expand and
13274 eliminate repeated ocurrences of an interface. This expands in
13275 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
13278 2002-06-21 Martin Baulig <martin@gnome.org>
13280 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
13283 2002-06-21 Martin Baulig <martin@gnome.org>
13285 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
13286 and called with one of the core types, return the corresponding typebuilder for
13289 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
13292 2002-06-21 Martin Baulig <martin@gnome.org>
13294 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
13295 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
13296 (Expression.ConvertReferenceExplicit): Likewise.
13298 * expression.cs (ElementAccess.DoResolve): Likewise.
13299 (ElementAccess.DoResolveLValue): Likewise.
13301 2002-06-10 Martin Baulig <martin@gnome.org>
13303 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
13304 add the "value" parameter to the parameter list.
13306 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
13309 2002-06-19 Miguel de Icaza <miguel@ximian.com>
13311 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
13312 the argument to an int, uint, long or ulong, per the spec. Also
13313 catch negative constants in array creation.
13315 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
13317 * class.cs: do not allow the same interface to appear twice in
13318 the definition list.
13320 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
13322 * ecore.cs: don't use ldlen with System.Array.
13324 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
13326 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
13328 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
13330 * modifiers.cs: produce correct field attributes for protected
13331 internal. Easy fix so miguel can work on ther harder stuff:-)
13333 2002-06-18 Miguel de Icaza <miguel@ximian.com>
13335 * pending.cs: New file. Move the code from class.cs here.
13336 Support clearning the pending flag for all methods (when not doing
13337 explicit interface implementation).
13339 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
13341 * rootcontext.cs: added a couple more types needed to bootstrap.
13343 2002-06-17 Miguel de Icaza <miguel@ximian.com>
13345 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
13346 constructor in the type, instead of any constructor in the type
13347 hierarchy. Thanks to Paolo for finding this bug (it showed up as
13348 a bug in the Mono runtime when applying the params attribute).
13350 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
13351 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
13353 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
13355 * expression.cs (Unary.ResolveOperator): Use TypeManager
13356 to resolve the type.
13358 2002-06-13 Ravi Pratap <ravi@ximian.com>
13360 * cs-parser.jay (enum_member_declaration): Pass in the attributes
13363 * enum.cs (AddEnumMember): Add support to store the attributes associated
13364 with each member too.
13366 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
13367 field builders too - this takes care of the enum member case.
13369 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
13371 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
13372 address-of operator on both value types and pointers.
13374 2002-06-10 Martin Baulig <martin@gnome.org>
13376 * interface.cs (Interface.PopulateIndexer): Add the indexer's
13377 PropertyBuilder to the `property_builders' list.
13379 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
13380 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
13381 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
13382 find any indexers which are inherited from an interface.
13384 2002-06-09 Martin Baulig <martin@gnome.org>
13386 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
13387 the same type as the constant if necessary. There's also a test-130.cs
13390 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
13392 * typemanager.cs (TypeManager.ChangeType): Previously known as
13393 Enum.ChangeEnumType().
13395 2002-06-09 Martin Baulig <martin@gnome.org>
13397 * expression.cs (Cast.TryReduce): Added support for consts.
13399 2002-06-08 Ravi Pratap <ravi@ximian.com>
13401 * class.cs (Accessor): Hold attributes information so we can pass
13404 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
13405 Modify to pass in attributes attached to the methods.
13407 (add_accessor_declaration, remove_accessor_declaration): Ditto.
13409 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
13410 to handle the Accessor kind :-)
13412 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
13414 2002-06-08 Martin Baulig <martin@gnome.org>
13416 * expression.cs (Unary.TryReduceNegative): Added support for
13419 2002-06-08 Martin Baulig <martin@gnome.org>
13421 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
13422 name can't be found in the `defined_names' - the caller will do a
13423 MemberLookup in this case and thus find methods in System.Enum
13424 such as Enum.IsDefined().
13426 2002-06-08 Martin Baulig <martin@gnome.org>
13428 * enum.cs (Enum.ChangeEnumType): This is a custom version of
13429 Convert.ChangeType() which works with TypeBuilder created types.
13430 (Enum.LookupEnumValue, Enum.Define): Use it here.
13432 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
13433 `TypeBuilder.BaseType != null' check.
13434 (TypeContainer.FindMembers): Only lookup parent members if we
13435 actually have a parent.
13436 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
13437 (ConstructorInitializer.Resolve): Likewise.
13439 * interface.cs (Interface.FindMembers): Added
13440 `TypeBuilder.BaseType != null' check.
13442 * rootcontext.cs (RootContext.ResolveCore): Added
13443 "System.Runtime.CompilerServices.IndexerNameAttribute" to
13444 classes_second_stage.
13446 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
13447 debug_type and trace_type when compiling with --nostdlib.
13449 2002-06-07 Martin Baulig <martin@gnome.org>
13451 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
13452 (AddField): Set it to true when adding a non-static field.
13453 (DefineType): Use `have_nonstatic_fields' to find out whether we
13454 have non-static fields, not `Fields != null'.
13456 2002-06-02 Miguel de Icaza <miguel@ximian.com>
13458 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
13459 dereferencing a null on the static-field code path)
13461 2002-05-30 Martin Baulig <martin@gnome.org>
13463 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
13464 to take command line arguments. Use reflection to call the new
13465 custom `Initialize' function on the symbol writer and pass it the
13466 command line arguments.
13468 * driver.cs (--debug-args): New command line argument to pass command
13469 line arguments to the symbol writer.
13471 2002-05-28 Miguel de Icaza <miguel@ximian.com>
13473 * assign.cs (DoResolve): Forgot to do the implicit conversion to
13474 the target type for indexers and properties. Thanks to Joe for
13477 2002-05-27 Miguel de Icaza <miguel@ximian.com>
13479 * typemanager.cs (MethodFlags): returns the method flags
13480 (Obsolete/ShouldIgnore) that control warning emission and whether
13481 the invocation should be made, or ignored.
13483 * expression.cs (Invocation.Emit): Remove previous hack, we should
13484 not do this on matching a base type, we should do this based on an attribute
13486 Only emit calls to System.Diagnostics.Debug and
13487 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
13488 on the command line.
13490 * rootcontext.cs: Global settings for tracing and debugging.
13492 * cs-tokenizer.cs (define): New utility function to track
13493 defines. Set the global settings for TRACE and DEBUG if found.
13495 2002-05-25 Ravi Pratap <ravi@ximian.com>
13497 * interface.cs (Populate*): Pass in the TypeContainer as well as
13498 the DeclSpace as parameters so that we can create EmitContexts and
13499 then use that to apply attributes etc.
13501 (PopulateMethod, PopulateEvent, PopulateProperty)
13502 (PopulateIndexer): Apply attributes everywhere.
13504 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
13507 (ApplyAttributes): Update accordingly.
13509 We now apply interface attributes for all members too.
13511 2002-05-26 Miguel de Icaza <miguel@ximian.com>
13513 * class.cs (Indexer.Define); Correctly check if we are explicit
13514 implementation (instead of checking the Name for a ".", we
13515 directly look up if the InterfaceType was specified).
13517 Delay the creation of the PropertyBuilder.
13519 Only create the PropertyBuilder if we are not an explicit
13520 interface implementation. This means that explicit interface
13521 implementation members do not participate in regular function
13522 lookups, and hence fixes another major ambiguity problem in
13523 overload resolution (that was the visible effect).
13525 (DefineMethod): Return whether we are doing an interface
13528 * typemanager.cs: Temporary hack until we get attributes in
13529 interfaces (Ravi is working on that) and we get IndexerName
13530 support in interfaces.
13532 * interface.cs: Register the indexers as properties.
13534 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
13535 warning, I have verified that this is a bug in the .NET runtime
13536 (JavaScript suffers of the same problem).
13538 * typemanager.cs (MemberLookup): When looking up members for
13539 interfaces, the parent of an interface is the implicit
13540 System.Object (so we succeed in searches of Object methods in an
13541 interface method invocation. Example: IEnumerable x; x.ToString
13544 2002-05-25 Miguel de Icaza <miguel@ximian.com>
13546 * class.cs (Event): Events should also register if they do
13547 implement the methods that an interface requires.
13549 * typemanager.cs (MemberLookup); use the new GetInterfaces
13552 (GetInterfaces): The code used to lookup interfaces for a type is
13553 used in more than one place, factor it here.
13555 * driver.cs: Track the errors at the bottom of the file, we kept
13558 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
13559 instance if the method we are calling is static!
13561 2002-05-24 Miguel de Icaza <miguel@ximian.com>
13563 * attribute.cs (ApplyAttributes): Make this function filter out
13564 the IndexerName attribute (as that attribute in reality is never
13565 applied) and return the string constant for the IndexerName
13568 * class.cs (TypeContainer.Emit): Validate that all the indexers
13569 have the same IndexerName attribute, and if so, set the
13570 DefaultName attribute on the class.
13572 * typemanager.cs: The return value might contain other stuff (not
13573 only methods). For instance, consider a method with an "Item"
13574 property and an Item method.
13576 * class.cs: If there is a problem with the parameter types,
13579 2002-05-24 Ravi Pratap <ravi@ximian.com>
13581 * ecore.cs (ImplicitConversionExists): Wrapper function which also
13582 looks at user defined conversion after making a call to
13583 StandardConversionExists - we need this for overload resolution.
13585 * expression.cs : Update accordingly the various method calls.
13587 This fixes 2 bugs filed against implicit user defined conversions
13589 2002-05-22 Miguel de Icaza <miguel@ximian.com>
13591 * statement.cs: Track the result of the assignment.
13593 2002-05-21 Miguel de Icaza <miguel@ximian.com>
13595 * expression.cs (MemberAccess): Improved error reporting for
13596 inaccessible members.
13598 2002-05-22 Martin Baulig <martin@gnome.org>
13600 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
13601 itself with debugging support.
13603 2002-05-22 Martin Baulig <martin@gnome.org>
13605 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
13606 Removed, this isn't needed anymore.
13608 2002-05-20 Martin Baulig <martin@gnome.org>
13610 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
13611 be underlying type for an enum.
13613 2002-05-20 Miguel de Icaza <miguel@ximian.com>
13615 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
13616 that splits out the loading of just the core types.
13618 * rootcontext.cs (ResolveCore): Split the struct resolution in
13619 two, so we can load the enumeration underlying types before any
13622 * expression.cs (Is): Bandaid until we fix properly Switch (see
13623 bug #24985 for details).
13625 * typemanager.cs (ImplementsInterface): The hashtable will contain
13626 a null if there are no interfaces implemented.
13628 2002-05-18 Miguel de Icaza <miguel@ximian.com>
13630 * cs-parser.jay (indexer_declarator): It is fine to have array
13633 2002-05-17 Miguel de Icaza <miguel@ximian.com>
13635 * typemanager.cs: (RegisterBuilder): New function used to register
13636 TypeBuilders that implement interfaces. Since
13637 TypeBuilder.GetInterfaces (as usual) does not work with lame
13639 (AddUserType): register interfaces.
13641 (ImplementsInterface): Use the builder_to_ifaces hash if we are
13642 dealing with TypeBuilder. Also, arrays are showing up as
13643 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
13644 methods can not be invoked on them!
13646 * ecore.cs (ExplicitReferenceConversionExists): Made public.
13647 (ImplicitReferenceConversionExists): Split out from
13648 StandardConversionExists.
13650 * expression.cs (As): We were only implementing one of the three
13651 cases for the as operator. We now implement them all.
13652 (Is): Implement the various other cases for Is as well.
13654 * typemanager.cs (CACHE): New define used to control if we want or
13655 not the FindMembers cache. Seems to have a negative impact on
13656 performance currently
13658 (MemberLookup): Nested types have full acess to
13659 enclosing type members
13661 Remove code that coped with instance/static returns for events, we
13662 now catch this in RealFindMembers.
13664 (RealFindMembers): only perform static lookup if the instance
13665 lookup did not return a type or an event.
13667 2002-05-17 Miguel de Icaza <miguel@ximian.com>
13669 * assign.cs (CompoundAssign): We pass more semantic information
13670 now to Compound Assignments than we did before: now we have all
13671 the information at hand, and now we resolve the target *before* we
13672 do the expression expansion, which allows the "CacheValue" method
13673 to have the effect we intended (before, a [x] += 1 would generate
13674 two differen ArrayAccess expressions from the ElementAccess,
13675 during the resolution process).
13677 (CompoundAssign.DoResolve): Resolve target and original_source here.
13679 2002-05-16 Miguel de Icaza <miguel@ximian.com>
13681 * expression.cs (ArrayAccess): dropped debugging information.
13683 * typemanager.cs: Small bug fix: I was always returning i_members,
13684 instead of one of i_members or s_members (depending on which had
13687 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
13688 method is invoked before any code generation takes place, and it
13689 is a mechanism to inform that the expression will be invoked more
13690 than once, and that the method should use temporary values to
13691 avoid having side effects
13693 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
13695 * ecore.cs (Expression.CacheTemporaries): Provide empty default
13698 * expression.cs (Indirection, ArrayAccess): Add support for
13699 CacheTemporaries in these two bad boys.
13701 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
13702 ldobj or ldind_ref.
13703 (StoreFromPtr): Handle stobj as well.
13705 * expression.cs (UnaryMutator): Share more code.
13707 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
13708 down: I was not tracking the Filter function as well, which
13709 was affecting the results of the cache.
13711 2002-05-15 Miguel de Icaza <miguel@ximian.com>
13713 * attribute.cs: Remove the hack to handle the CharSet property on
13716 2002-05-14 Miguel de Icaza <miguel@ximian.com>
13718 * attribute.cs (DoResolve): More uglyness, we now only try to
13719 resolve the attribute partially, to extract the CharSet
13720 information (only if we are a StructLayout attribute). Otherwise
13722 (GetExtraTypeInfo): Add some code to conditionally kill in the
13723 future this. I am more and more convinced that the .NET
13724 framework has special code to handle the attribute setting on
13727 * expression.cs (IsParamsMethodApplicable): Revert my previous
13728 foreach change here, it was wrong.
13730 2002-05-13 Miguel de Icaza <miguel@ximian.com>
13732 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
13733 (pp_expr): do not abort on unknown input, just return.
13734 (eval): abort if there are pending chars.
13736 * attribute.cs (Attribute.Resolve): Positional parameters are
13737 optional. Deal with that case.
13739 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
13740 the Ansi/Unicode/Auto information for the type.
13742 (TypeContainer.DefineType): instantiate the EmitContext here, as
13743 we will be using it during the type definition (to resolve
13744 attributes) and during the emit phase.
13746 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
13747 to pull type information out of the attributes
13749 (Attribute.Resolve): track the constructor builder, and allow for
13750 multiple invocations (structs and classes will use this).
13752 * ecore.cs (MemberLookupFinal): new version with all the
13753 parameters customizable.
13755 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
13756 constructors. Return if the result value is null (as the error
13757 would have been flagged already by MemberLookupFinal)
13759 Do not allow instances of abstract classes or interfaces to be
13762 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
13763 We have to compare the assembly property here when dealing with
13764 FamANDAssem and Assembly access modifiers, because we might be
13765 creating an assembly from *modules* (that means that we are not
13766 getting TypeBuilders for types defined in other modules that are
13767 part of this assembly).
13769 (Method.Emit): If the method is marked abstract and has a body,
13772 (TypeContainer.DefineMembers): If both the defined member and the
13773 parent name match are methods, then do not emit any warnings: let
13774 the Method.Define routine take care of flagging warnings. But if
13775 there is a mismatch (method overrides something else, or method is
13776 overriwritten by something, then emit warning).
13778 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
13779 set to null, this means `do not check for the return type on the
13782 (Method.Define): set the return type for the method signature to
13783 null, so that we get methods with the same name and parameters and
13784 different return types. This is used to flag warning 114 (you are
13785 hiding a method, and you probably want to use the new/override
13788 * typemanager.cs (MemberLookup): Implemented proper access
13789 control, closing a long standing set of bug reports. The problem
13790 was that the Framework only has two bits: Public and NonPublic,
13791 and NonPublic includes private and protected methods, but we need
13792 to enforce the FamANDAssem, FamOrAssem and Family.
13794 2002-05-11 Miguel de Icaza <miguel@ximian.com>
13796 * statement.cs (GotoCase): Return true: Ammounts to giving up
13797 knowledge on whether we return or not, and letting the other case
13798 be responsible for it.
13800 2002-05-10 Miguel de Icaza <miguel@ximian.com>
13802 * driver.cs: Do not load directories for each file processed, only
13803 do it if there is a pattern.
13805 * ecore.cs: Report readonly assigns here as well, as we might have
13806 been resolved only by MemberAccess.
13808 (SimpleName.SimpleNameResolve): Also be useful for LValue
13809 resolution. We need this to propagate assign to local readonly variables
13811 * typemanager.cs: Use a ptrhashtable for the criteria, because we
13812 do not want to reuse potential criteria memory.
13814 * class.cs (MyEventBuilder): Set reflected_type;
13816 * ecore.cs (Constantify): Added support for constifying bools.
13818 (RootContext.LookupType): Added a cache for values looked up in
13819 the declaration space.
13821 * typemanager.cs (FindMembers): Now is a front-end to
13822 RealFindMembers, and provides a two-level hashtable-based cache to
13825 15% performance improvement: from 22.5 to 19.2 seconds.
13827 * expression.cs (IsParamsMethodApplicable): use foreach.
13828 (Invocation.DoResolve): ditto.
13829 (New.DoResolve): ditto.
13830 (ArrayCreation.DoResolve): ditto.
13832 * ecore.cs (FindMostEncompassingType): use foreach.
13834 * delegate.cs (NewDelegate.DoResolve): Use foreach
13836 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
13837 (RemoveMethods): use foreach.
13839 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
13840 nested foreach statements instead of for, and also break out of
13841 the inner loop once a match is found.
13843 (Invocation.OverloadResolve): Use foreach, simplify the code.
13845 2002-05-08 Miguel de Icaza <miguel@ximian.com>
13847 * cfold.cs (BinaryFold): During an enumeration evaluation context,
13848 we actually unwrap the expression to allow for extra information
13851 * expression.cs: Use Shr_Un on unsigned operations.
13853 2002-05-08 Ravi Pratap <ravi@ximian.com>
13855 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
13856 applicable operators was not being considered correctly. This closes
13857 the bug Miguel reported.
13859 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
13861 * attribute.cs: check that the type derives from System.Attribute
13862 and report the correct error in that case (moved the duplicate code to
13863 its own method, too).
13865 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
13867 * attribute.cs: lookup attribute type name as the spec says: first the
13868 bare attribute name and then name + "Attribute" (nant compiles with
13869 mcs after this fix).
13871 2002-05-07 Miguel de Icaza <miguel@ximian.com>
13873 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
13874 Because of the way we parse things, we should try to see if a
13875 UIntConstant can fit in an integer.
13877 2002-05-07 Ravi Pratap <ravi@ximian.com>
13879 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
13880 when we are in an explicit context.
13882 (ConvertReferenceExplicit): When converting from Iface type S to Class
13883 T make sure the rules are implemented as an OR.
13885 * parameter.cs (ParameterType): Make it a property for now although the
13886 purpose really isn't anything immediate.
13888 * expression.cs (Is*Applicable): Do better checking on the parameter type
13889 of a ref/out parameter. The ones from the system assemblies are already
13890 marked with the correct type so we don't need to do any correction.
13892 * ecore.cs (StandardConversionExists): Conversion from Interface types to
13893 the object type is standard too so include that.
13895 2002-05-06 Miguel de Icaza <miguel@ximian.com>
13897 * ecore.cs (StandardConversionExists): Augment with missing code:
13898 deal with IntConstant, LongConstants and Enumerations.
13900 * assign.cs: Report the error, instead of failing silently
13902 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
13903 typecontainer that they are declared, because the
13904 typecontainer/namespace will have the list of using clauses that
13905 need to be applied.
13907 Assembly Attributes were escaping the normal registration
13910 (EmitCode): Apply attributes within an EmitContext that represents
13911 the container they were declared on.
13913 * cs-parser.jay: Track bases for structs. How did I get this wrong?
13915 2002-05-06 Ravi Pratap <ravi@ximian.com>
13917 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
13918 Revamp completely - make much cleaner as we now operate only
13921 (FindMostSpecificSource, FindMostSpecificTarget): New methods
13922 to implement the logic detailed in the spec more correctly.
13924 (UserDefinedConversion): Update accordingly.
13926 2002-05-06 Miguel de Icaza <miguel@ximian.com>
13928 * statement.cs: Return flow analysis information up.
13930 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
13933 (token): Do not consume an extra character before calling
13936 2002-05-06 Piers Haken <piersh@friskit.com>
13938 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
13940 2002-05-06 Miguel de Icaza <miguel@ximian.com>
13942 * class.cs (Constructor.Emit): Set the IsStatic flag in the
13943 EmitContext during the instance constructor initializer
13944 resolution, to stop access to instance variables.
13946 This is mandated by the spec, last paragraph of the `constructor
13947 initializers' section.
13949 2002-05-05 Miguel de Icaza <miguel@ximian.com>
13951 * cs-parser.jay, class.cs (Accessor): new class used to represent
13952 an accessor (get or set). In the past we used `null' to represent
13953 a missing accessor. But this is ambiguous because there was no
13954 way to tell in abstract indexers/properties if one of them was
13957 Now there is a way of addressing that.
13959 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
13960 instead of FindMembers.
13962 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
13963 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
13965 * attribute.cs: Treat indexers and properties as the same in terms
13966 of applying attributes
13968 * ecore.cs (FindMostEncompassedType): Use statically initialized
13969 EmptyExpressions()s like we do elsewhere to avoid creating useless
13970 objects (and we take this out of the tight loop).
13972 (GetConversionOperators): Move the code to extract the actual
13973 operators to a separate routine to clean things up.
13975 2002-05-04 Miguel de Icaza <miguel@ximian.com>
13977 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
13978 events are always registered FieldBuilders.
13980 * class.cs (FieldBase): New class shared by Fields
13982 * delegate.cs: If we are a toplevel delegate, use our full name.
13983 If we are a nested delegate, then only use our tail name.
13985 2002-05-02 Ravi Pratap <ravi@ximian.com>
13987 * expression.cs (IsApplicable): Ensure that we add the "&" to
13988 ref/out types before comparing it with the type of the argument.
13990 (IsParamsMethodApplicable): Ditto.
13992 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
13995 * delegate.cs : Handle the case when we have more than one applicable
13996 method. Flag an error only when we finish checking all.
13998 2002-05-02 Miguel de Icaza <miguel@ximian.com>
14000 * expression.cs: Add support for boolean static initializers.
14002 2002-05-01 Miguel de Icaza <miguel@ximian.com>
14004 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
14006 * parameter.cs (ComputeParameterTypes,
14007 ComputeAndDefineParameterTypes): Better error handling: now we
14008 clear the `types' cache if we fail during any of the type lookups.
14009 We also return the status code correctly to our caller
14011 * delegate.cs: If we fail to define a delegate, abort the extra
14014 * expression.cs (Binary.ResolveOperator): for
14015 operator==(object,object) and operator !=(object, object) we also
14016 have to verify that there is an implicit conversion from one to
14019 (ArrayAccess.DoResolve): Array Access can operate on
14022 2002-04-30 Miguel de Icaza <miguel@ximian.com>
14024 * assign.cs (CompoundAssign): A new class used as a "flag" that
14025 the assignment actually is happening as part of a compound
14026 assignment operator.
14028 During compound assignment, a few new rules exist to enable things
14035 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
14036 to the type of x) if y is implicitly convertible to the type of x,
14037 and the operator is a builtin operator and the return type of the
14038 operator is explicitly convertible to the type of x.
14040 * rootcontext.cs: Reset warning level to 2. 4 catches various
14041 "interesting" features in mcs, we must clean this up at some
14042 point, but currently am trying to kill other bugs ;-)
14044 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
14045 in container classes as well.
14047 * expression.cs (Binary.ResolveOperator): Handle string case
14048 before anything else (as operator overloading does emit an error
14049 before doing anything else).
14051 This code could go away when we move to a table driven model, but
14052 i could not come up with a good plan last night.
14054 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
14056 * typemanager.cs (CSharpName): reimplementation using regex.
14057 * class.cs: added null check for fields in Emit
14058 * rootcontext.cs: set warninglevel to 4
14060 2002-04-29 Miguel de Icaza <miguel@ximian.com>
14062 * typemanager.cs (CSharpName): reimplemented with Lupus
14065 2002-04-28 Miguel de Icaza <miguel@ximian.com>
14067 * statement.cs (If): correclty implement Resolve, because we were
14068 not catching sem errors in there. The same process is needed
14070 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
14073 (Statement.Warning_DeadCodeFound): Factorize code.
14074 (While): Report dead code here too.
14076 (Statement): Added Resolve virtual method to allow
14077 for resolution split from the emit code.
14079 2002-04-26 Miguel de Icaza <miguel@ximian.com>
14081 * statement.cs (EmitBoolExpression): No longer try to resolve the
14083 (MakeBoolean): New utility function that resolve, implicitly
14084 converts to boolean and tags the expression.
14087 (If, Do): Implement dead code elimination.
14088 (While): Implement loop inversion
14090 (Do, While, For, If): Resolve the expression prior to calling our
14093 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
14096 - added method Report28 (warning: program has more than one entry point)
14097 - added method IsEntryPoint, implements paragraph 10.1 of the spec
14098 - modified method Method.Define, the part at the end of the method
14100 * rootcontext.cs: added static public Location EntryPointLocation;
14102 * ../errors/cs0028.cs : Add test case for the above warning.
14105 - modified method CSharpName to allow arrays of primitive type to
14106 be printed nicely (e.g. instead of System.Int32[][] it now prints
14108 - added method CSharpSignature: returns the signature of a method
14109 in string format to be used in reporting errors, warnings, etc.
14111 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
14114 2002-04-26 Ravi Pratap <ravi@ximian.com>
14116 * delegate.cs (Define): Fix extremely silly bug where I was
14117 setting the type of the 'object' parameter of the BeginInvoke
14118 method to System.IAsyncResult instead of System.Object ;-)
14120 2002-04-26 Miguel de Icaza <miguel@ximian.com>
14122 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
14125 (Constructor.Emit): return if we fail to initialize the
14126 constructor. Another door closed!
14128 * expression.cs (New.DoResolve): Improve error message (from -6 to
14129 1501). Use DeclaredOnly lookup to find the exact constructor.
14131 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
14132 loop. This is useful.
14134 * cs-parser.jay: Adjust the default parameters so that destructors
14135 have the proper signature.
14137 2002-04-26 Martin Baulig <martin@gnome.org>
14139 * driver.cs (LoadAssembly): If `assembly' contains any characters
14140 which are only valid in path names and not in assembly names
14141 (currently slash, backslash and point), use Assembly.LoadFrom ()
14142 instead of Assembly.Load () on the `assembly' (before iteration
14143 over the link_paths).
14145 2002-04-26 Martin Baulig <martin@gnome.org>
14147 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
14149 2002-04-25 Miguel de Icaza <miguel@ximian.com>
14151 * class.cs (Property): use the new typemanager.MemberLookup
14153 (TypeContainer.MemberLookup): Implement using the
14154 TypeManager.MemberLookup now.
14156 * typemanager.cs: Make MemberLookup a function of the TypeManager,
14157 and return MemberInfos, so that these can be used without an
14158 EmitContext (what we had before).
14160 2002-04-24 Miguel de Icaza <miguel@ximian.com>
14162 * expression.cs: Fix the case where the argument to params if the
14163 type of the params. I omitted handling this before. Fixed
14165 2002-04-22 Miguel de Icaza <miguel@ximian.com>
14167 * driver.cs: Call BootCorlib_PopulateCoreType
14169 * class.cs (Property.CheckBase): Check for properties only, not
14172 * interface.cs: Temporary hack: try/catch around the
14173 CustomAttributeBuilder, because I am getting an exception that I
14176 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
14177 types whose definitions are required to be there (attributes are
14178 defined before standard types).
14180 Compute definitions as we boot the various types, as they are used
14181 immediately (value_type class will need object_type, but if we do
14182 not initialize object_type, we will pass a null, which will let
14183 the runtime pick the System.Object from the existing corlib, which
14184 is not what we want).
14186 2002-04-22 Patrik Torstensson <totte@labs2.com>
14188 * cs-tokenizer.cs: fixed a number of trim() issues.
14190 2002-04-22 Ravi Pratap <ravi@ximian.com>
14192 * expression.cs (Argument.Type): Ensure that we return the correct
14193 type when we have out or ref parameters [in which case we
14196 2002-04-22 Miguel de Icaza <miguel@ximian.com>
14198 * class.cs (Property, Indexer): Allow extern modifier in there.
14200 * typemanager.cs (InitBaseTypes): Initializes object_type and
14201 value_type, since those will be used early on during the bootstrap
14202 process to compile corlib.
14204 (InitCoreTypes): Move code from here to InitBaseTypes.
14206 2002-04-21 Miguel de Icaza <miguel@ximian.com>
14208 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
14209 single-dimension arrays as using the ldlen opcode.
14211 Daniel Lewis discovered this optimization.
14213 * typemanager.cs: Add signature for System.Array::get_Length
14215 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14217 * statement.cs: report the error when the foreach does not apply to an
14218 array nor a collection.
14220 2002-04-19 Miguel de Icaza <miguel@ximian.com>
14222 * expression.cs: Add implicit conversions to the operator ~.
14224 * constant.cs (DecimalConstant.Emit): Emit decimal value.
14226 * typemanager.cs: Locate the decimal constructor.
14228 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14230 * attribute.cs: use the new property of TypeOf.
14231 * expression.cs: added 'get' property around typearg.
14233 These changes fix a build breaker reported by NickD. Is this the
14234 correct way to fix? If not, please, revert my changes and make it
14237 2002-04-17 Miguel de Icaza <miguel@ximian.com>
14239 * attribute.cs: Add support for typeof in attribute invocations.
14240 I am not sure that this is right though.
14242 2002-04-14 Duncan Mak <duncan@ximian.com>
14244 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
14245 Binary.Operator.Division case.
14247 2002-04-13 Ravi Pratap <ravi@ximian.com>
14249 * class.cs (DefineType): Ensure that we do a proper check on
14250 attribute types and also register it with the TypeManager.
14252 (TypeContainer.Targets): The default for attribute types is
14253 AttributeTargets.All.
14255 * attribute.cs (ApplyAttributes): Registering the attribute type
14256 is done elsewhere, not when we discover we have a Usage attribute.
14258 2002-04-12 Ravi Pratap <ravi@ximian.com>
14260 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
14261 and get rid of is_delegate parameter.
14263 * everywhere : update.
14265 2002-04-12 Ravi Pratap <ravi@ximian.com>
14267 * cs-parser.jay (compilation_unit): Revamp completely to use
14268 some new ideas that I got from Rhys' grammar to solve the problems
14269 with assembly level attributes.
14271 (outer_declaration): New grammar production.
14273 (attribute_sections): Add.
14275 (opt_attributes): Base on attribute_sections
14277 (namespace_declaration): Allow opt_attributes to tackle the case
14278 when we have assembly level attributes - we are clever in this
14281 * attribute.cs (ApplyAttributes): Do not worry about assembly
14282 attributes in the non-global context.
14284 * rootcontext.cs (AddGlobalAttributes): Go back to using this
14285 instead of SetGlobalAttributes.
14287 * class.cs, rootcontext.cs : Ensure we define and generate
14288 attribute types before anything else.
14290 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
14291 and flag the new error -20 for the case when the attribute type
14292 does not have valid targets specified. csc does not catch this.
14294 * ../errors/errors.txt : update for error # -20
14296 2002-04-11 Ravi Pratap <ravi@ximian.com>
14298 * support.cs (InternalParameters.ParameterModifier): Do some null
14299 checking and return sane values.
14301 * class.cs (Method.Define): If we are a PInvoke method, ensure
14302 that we are static and extern. Report error # 601
14304 * ../errors/cs0601.cs : Add test case for the above error.
14306 2002-04-07 Ravi Pratap <ravi@ximian.com>
14308 * rootcontext.cs (attribute_types): We need to keep type of
14309 all attribute types separately and emit code for them first.
14311 (RegisterAttribute) : Implement.
14313 * class.cs (DefineType): Check if the current Type is a custom
14314 attribute type and register it accordingly.
14316 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
14317 adding the first attribute twice and rename to
14319 (SetGlobalAttributes): this.
14321 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
14324 * attribute.cs (ApplyAttributes): Take an additional argument telling us
14325 if we are processing global arguments. Hmm, I am unsure of this.
14327 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14329 * expression.cs: added static array of strings to avoid calling
14330 Enum.ToString () for Operator in Binary. Significant recover of
14333 2002-04-10 Miguel de Icaza <miguel@ximian.com>
14335 * class.cs (FindMembers): Allow the Builders of the various
14336 members to be null. If they are skip them. This only happens
14337 during the PInvoke declaration.
14339 2002-04-09 Miguel de Icaza <miguel@ximian.com>
14341 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
14342 failure, so we do not keep going afterwards.
14344 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
14345 wanted to pass `false' as the `is_delegate' argument. If this is
14346 the case, why not use delegate_type == null to mean `is_delegate =
14347 false' and anything else as is_delegate = true.
14349 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
14351 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
14352 code for the section, not the beginning of the tests.
14354 2002-04-08 Miguel de Icaza <miguel@ximian.com>
14356 * cfold.cs: Handle operator + (Enum x, Underlying x)
14358 * expression.cs (Binary): same. Warn about errors where we have
14359 Enum/Enum in operator + as well.
14361 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
14364 - added support for switch(bool)
14365 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
14366 - add TableSwitchEmit() to handle table-based switch statements
14368 2002-04-05 Ravi Pratap <ravi@ximian.com>
14370 * expression.cs (Invocation.OverloadResolve): Factor out code which
14371 does parameter compatibility checking with arguments so that we can
14372 re-use the code even from Delegate.VerifyApplicability
14374 (VerifyArgumentsCompat): Move above code here.
14376 * delegate.cs (VerifyApplicability): Get rid of duplicate code
14377 and instead make a call to the above method.
14379 2002-03-31 Ravi Pratap <ravi@ximian.com>
14381 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
14382 We use it to keep track of classes which are attribute types.
14384 2002-04-02 Miguel de Icaza <miguel@ximian.com>
14386 * delegate.cs (Delegate.Define): Correctly define the types in the
14387 presence of fixed and array parameters.
14389 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
14392 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
14393 include NonPublic after the first iteration.
14395 * class.cs (Indexer.CheckBase): Only check if both parents are
14398 * cs-parser.jay (accessor_body): If empty, set to null.
14400 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
14401 same code path here to resolve constants names that we did have in
14402 MemberAccess.DoResolve. There is too much code duplicated here.
14404 2002-04-01 Miguel de Icaza <miguel@ximian.com>
14406 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
14408 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
14411 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
14412 tokens, numbers and strings.
14414 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
14417 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
14418 asyncronous parameters and the regular parameters.
14420 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
14421 specify the target directory.
14423 * expression.cs: (This.DoResolve): Simplify
14424 (As.Emit): Optimize, do not generate IsInst if the expression is
14425 always of the given type.
14427 (Is.DoResolve): Bug fix, we were reporting both always/never for
14430 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
14431 creating too many unnecessary arrays.
14433 2002-03-31 Miguel de Icaza <miguel@ximian.com>
14435 * class.cs (EmitFieldInitializer): Use Assign expression to assign
14436 fields instead of rolling our own initializer. Takes care of all
14437 implicit conversions, and drops unnecessary static checks/argument.
14439 2002-03-31 Dick Porter <dick@ximian.com>
14441 * driver.cs: use the GetDirectories() return values properly, and
14442 use "/" as path separator.
14444 2002-03-30 Miguel de Icaza <miguel@ximian.com>
14446 * expression.cs (Unary): Optimize - - expr into expr.
14447 (Binary): Optimize a + (-b) into a -b.
14449 * codegen.cs (CodeGen): Made all methods static.
14451 2002-03-29 Miguel de Icaza <miguel@ximian.com>
14455 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
14456 TypeBuilder property.
14458 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
14461 * tree.cs: Removed the various RecordXXXX, and replaced with a
14462 single RecordDecl. Removed all the accessor methods, and just
14463 left a single access point Type
14465 * enum.cs: Rename DefineEnum to DefineType.
14467 * decl.cs: New abstract method `DefineType' used to unify the
14468 Defines for Enumerations, Interfaces, TypeContainers and
14471 (FindType): Moved LookupInterfaceOrClass here. Moved the
14472 LookupBaseClasses method that used to live in class.cs and
14473 interface.cs here, and renamed to FindType.
14475 * delegate.cs: Implement DefineType. Take advantage of the
14476 refactored pattern for locating the parent builder without taking
14477 the parent_builder argument (which we know does not work if we are
14478 nested, and triggering a toplevel definition).
14480 2002-03-28 Miguel de Icaza <miguel@ximian.com>
14482 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
14483 accessibility of a member has changed during override and report
14486 * class.cs (Method.Define, Property.Define): Only complain on
14487 overrides if the method is private, any other accessibility is
14488 fine (and since we just checked the permission is the same, we are
14491 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
14492 and elif are processed always. The other pre-processing
14493 directives are only processed if we are "taking" the path
14495 2002-03-29 Martin Baulig <martin@gnome.org>
14497 * class.cs (Method.Emit): Only emit symbolic debugging info if the
14498 current location is not Null.
14500 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
14501 a separate method so we can profile it.
14503 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
14504 `span.Seconds' are just seconds, but no minutes or hours.
14505 (MainDriver): Profile the CodeGen.SaveSymbols calls.
14507 2002-03-28 Miguel de Icaza <miguel@ximian.com>
14509 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
14510 Remove the gratuitous set of Final:
14512 // If an interface implementation, then we can set Final.
14513 if (((flags & MethodAttributes.Abstract) == 0) &&
14514 implementing.DeclaringType.IsInterface)
14515 flags |= MethodAttributes.Final;
14517 I do not know what I was smoking when I used that.
14520 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
14521 step into fixing the name resolution issues for delegates and
14522 unifying the toplevel name resolution.
14524 2002-03-28 Martin Baulig <martin@gnome.org>
14526 * class.cs (Method.Emit): If we have a symbol writer, call its
14527 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
14528 tell it about the current method.
14530 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
14531 writer that we're going to emit the first byte of IL code for a new
14532 statement (a new source line).
14533 (EmitContext.EmitTopBlock): If we have a symbol writer, call
14534 EmitContext.Mark() before emitting any code.
14536 * location.cs (SymbolDocument): Return null when we're Null.
14538 * statement.cs (Statement): Moved the `Location loc' variable here.
14539 (Statement.EmitBoolExpression): If we have a symbol writer, call
14540 ec.Mark() before emitting any code to tell it that we're at the
14541 beginning of a new statement.
14542 (StatementExpression): Added `Location' argument to the constructor.
14543 (Block): Added public readonly variable `StartLocation' and public
14544 variable `EndLocation'. The latter is to be set using SetEndLocation().
14545 (Block): Added constructor which takes a start and end location.
14546 (Block.SetEndLocation): New method. This sets the end location.
14547 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
14548 local variables we create.
14549 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
14550 each statement and do also mark the begin and end of the block.
14552 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
14553 tell it the current lexer.Location, use Location.Null for the end of the
14555 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
14556 current block, set its end location using SetEndLocation().
14557 (statement_expression): StatementExpression constructor now takes the
14558 lexer.Location as additional argument.
14559 (for_statement, declare_local_variables): Likewise.
14560 (declare_local_variables): When creating a new implicit block, use the
14561 new Block constructor and pass it the lexer.Location.
14563 2002-03-28 Miguel de Icaza <miguel@ximian.com>
14565 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
14566 members also on the parent interfaces recursively.
14568 2002-03-27 Miguel de Icaza <miguel@ximian.com>
14570 * report.cs: Use new formats, since Gonzalo finished the missing
14573 * expression.cs (Binary.ResolveOperator): added missing operator|
14574 operator& and operator^ for bool/bool.
14576 * cs-parser.jay: CheckDef now takes a Location argument that is
14577 used to report errors more precisly (instead of reporting the end
14578 of a definition, we try to track something which is a lot closer
14579 to the source of the problem).
14581 * cs-tokenizer.cs: Track global token use, so we can properly flag
14582 the use of #define/#undef after the first token has been seen.
14584 Also, rename the reportXXXX to Error_DescriptiveName
14586 * decl.cs (DeclSpace.IsTopLevel): Move property here from
14587 TypeContainer, so that Enum and Interface can use this too.
14589 * class.cs (TypeContainer.LookupInterfaceOrClass,
14590 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
14591 `builder' argument. Typically this was used to pass the parent
14592 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
14595 The problem is that a nested class could trigger the definition of
14596 a toplevel class, and the builder would be obviously wrong in that
14599 So we drop this argument, and we compute dynamically the
14600 TypeBuilder/ModuleBuilder (the correct information was available
14601 to us anyways from DeclSpace.Parent)
14603 * interface.cs (Interface.DefineInterface): Drop builder
14604 parameter cleanup like class.cs
14606 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
14609 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
14612 (Try.Emit): Propagate the returns value from the statement.
14614 (Return.Emit): Even if we are leavning
14616 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
14618 * modifiers.cs: Fix the computation of MethodAttributes flags.
14620 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
14622 * driver.cs: allow compilation of files that start with '/'.
14623 Add a default case when checking the argument of --target.
14625 2002-03-25 Miguel de Icaza <miguel@ximian.com>
14627 * interface.cs: Implement the same search algorithm for types in
14628 the interface code.
14630 * delegate.cs: Do not allow multiple definition.
14632 * Recovered ChangeLog that got accidentally amputated
14634 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
14636 * rootcontext.cs: Load manually enum to allow core classes to
14637 contain enumerations.
14639 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
14640 Update to new static methods in TypeManager.
14642 * typemanager.cs (GetMethod, GetConstructor): Use our
14643 implementation of FindMembers to find the members, since during
14644 corlib compilation, the types are TypeBuilders and GetMethod and
14645 GetConstructor do not work.
14647 Make all methods in TypeManager static.
14649 (InitCodeHelpers): Split the functionality from
14650 the InitCodeTypes function.
14652 * driver.cs: Call InitCodeHelpers after we have populated the
14655 * cs-parser.jay (delegate_declaration): we did not used to compute
14656 the delegate name correctly for void delegates.
14658 2002-03-24 Miguel de Icaza <miguel@ximian.com>
14660 * rootcontext.cs (RootContext): Init the interface_resolve_order
14661 and type_container_resolve_order always.
14663 (ResolveCore, BootstrapCorlib_ResolveClass,
14664 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
14665 compiler when compiling with --nostdlib
14667 * class.cs (TypeContainer.DefineType): Check that our parent is
14668 not null. This test is most important when we are bootstraping
14671 * codegen.cs: Split out the symbol writing code.
14673 2002-03-25 Martin Baulig <martin@gnome.org>
14675 * driver.cs (-g): Made -g an alias for --debug.
14677 2002-03-24 Martin Baulig <martin@gnome.org>
14679 * codegen.cs (SymbolWriter): New public variable. Returns the
14680 current symbol writer.
14681 (CodeGen): Added `bool want_debugging_support' argument to the
14682 constructor. If true, tell the ModuleBuild that we want debugging
14683 support and ask it for the ISymbolWriter.
14684 (Save): If we have a symbol writer, call it's Close() method after
14685 saving the assembly.
14687 * driver.c (--debug): New command line argument to create a
14688 debugger information file.
14690 * location.cs (SymbolDocument): New public property. Returns an
14691 ISymbolDocumentWriter object for the current source file or null
14692 if we don't have a symbol writer.
14694 2002-03-21 Miguel de Icaza <miguel@ximian.com>
14696 * driver.cs (LoadAssembly): Correctly return when all the paths
14697 have been tried and not before.
14699 * statement.cs (Switch.Emit): return the actual coverage for this
14700 statement (returns/not-returns)
14702 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
14703 switch of the statement if we are the last switch section. That
14704 kills two problems: try/catch problems (we used to emit an empty
14705 nop at the end) and switch statements where all branches would
14708 2002-03-19 Miguel de Icaza <miguel@ximian.com>
14710 * driver.cs: Add default assemblies (the equivalent to the
14711 Microsoft CSC.RSP file)
14713 * cs-tokenizer.cs: When updating `cols and setting it to zero,
14714 also update tokens_seen and set it to false.
14716 * driver.cs: Implement --recurse for Mike.
14718 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
14719 correctly splitting out the paths.
14721 2002-03-18 Miguel de Icaza <miguel@ximian.com>
14723 * interface.cs (Interface.PopulateProperty): Instead of using
14724 `parent' as the declaration space for the set parameters, use
14727 * support.cs (InternalParameters): InternalParameters constructor
14728 takes a DeclSpace instead of a TypeContainer.
14730 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
14731 types are being initialized, load the address of it before calling
14734 (New): Provide a mechanism to disable the generation of local
14735 value type temporaries when the caller will be providing us with
14736 an address to store it.
14738 (ArrayCreation.EmitDynamicInitializers): Use it.
14740 2002-03-17 Miguel de Icaza <miguel@ximian.com>
14742 * expression.cs (Invocation.EmitArguments): Only probe for array
14743 property if there is more than one argument. Sorry about that.
14745 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
14746 empty param arrays.
14748 * class.cs (Method.LabelParameters): Fix incorrect code path that
14749 prevented the `ParamArrayAttribute' from being applied to the
14752 2002-03-16 Miguel de Icaza <miguel@ximian.com>
14754 * support.cs (ReflectionParameters): Correctly compute whether the
14755 last argument is a params array. Fixes the problem with
14758 * typemanager.cs: Make the assemblies array always be non-null
14759 (empty, but non-null)
14761 * tree.cs (RecordDecl): New function that abstracts the recording
14762 of names. This reports error 101, and provides a pointer to the
14763 previous declaration. Fixes a crash in the compiler.
14765 * cs-parser.jay (constructor_declaration): Update to new grammar,
14766 and provide a constructor_body that can be empty.
14768 2002-03-15 Miguel de Icaza <miguel@ximian.com>
14770 * driver.cs: Add support for --resources.
14772 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
14773 Make all types for the various array helper methods be integer.
14775 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
14776 CheckState to ConvCast.
14778 (ConvCast): Now it takes a `checked' state argument, to avoid
14779 depending on the emit context for the conversion, and just using
14780 the resolve time setting.
14782 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
14783 instead of Invocation.EmitArguments. We do not emit the original
14784 arguments, instead we emit those which have been converted to
14785 unsigned int expressions.
14787 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
14789 * codegen.cs: ditto.
14791 * expression.cs (LocalVariableReference): Drop the use of the
14792 Store function that depended on the variable index.
14794 * statement.cs (VariableInfo): Drop the `Idx' property from this
14795 class, as this is not taking into account the indexes for
14796 temporaries tat we generate during the execution, getting the
14799 * class.cs: First emit class initializers, then call the parent
14802 * expression.cs (Binary): Fix opcode emision.
14803 (UnaryMutator.EmitCode): Support checked code generation
14805 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
14806 matches for events for both the Static and Instance scans,
14807 pointing to the same element. Fix that.
14809 2002-03-14 Miguel de Icaza <miguel@ximian.com>
14811 * rootcontext.cs (ResolveTree): Always set the
14812 interface_resolve_order, because nested interfaces will be calling
14815 * class.cs (GetInterfaceOrClass): Track the same resolution
14816 process used by TypeManager.LookupType. This fixes the nested
14817 type lookups in class declarations (separate path from
14820 (TypeContainer.DefineType): Also define nested interfaces.
14821 (TypeContainer.RegisterOrder): New public function used to
14822 register the order in which child interfaces need to be closed.
14824 Nested interfaces need to be closed after their parents have been
14827 * interface.cs (InterfaceAttr): Put all the logic for computing
14828 the interface attribute here.
14830 (DefineInterface): Register our interface order with the
14831 RootContext or with the TypeContainer depending on the case.
14833 2002-03-12 Miguel de Icaza <miguel@ximian.com>
14835 * cs-parser.jay: rework foreach statement to work with the new
14836 changes to the policy on SimpleNames.
14838 * report.cs: support Stacktrace on warnings as well.
14840 * makefile: drop --unsafe and /unsafe from the compile.
14842 2002-03-13 Ravi Pratap <ravi@ximian.com>
14844 * ecore.cs (StandardConversionExists): Modify to take an Expression
14845 as the first parameter. Ensure we do null -> reference type conversion
14848 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
14849 temporary Expression objects.
14851 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
14853 * interface.cs: workaround bug in method overloading resolution
14854 (there is already a bugzilla bug for it).
14856 2002-03-12 Miguel de Icaza <miguel@ximian.com>
14858 We could also solve this problem by having a separate path for
14859 performing type lookups, instead of DoResolve, we could have a
14860 ResolveType entry point, and only participating pieces of the
14861 production (simplename, deref, array) would implement this.
14863 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
14864 signal SimpleName to only resolve type names and not attempt to
14865 resolve anything else.
14867 * expression.cs (Cast): Set the flag.
14869 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
14871 * class.cs: Only report 108 if there is no `new' modifier.
14873 * cs-parser.jay: rework foreach statement to work with the new
14874 changes to the policy on SimpleNames.
14876 * report.cs: support Stacktrace on warnings as well.
14878 * makefile: drop --unsafe and /unsafe from the compile.
14880 2002-03-11 Miguel de Icaza <miguel@ximian.com>
14882 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
14883 lookups here, instead of doing that at parse time. This means
14884 that our grammar will not introduce `LocalVariableReferences' as
14885 expressions at this point. That solves the problem of code like
14889 static void Main ()
14893 This is only half the fix. The full fix requires parameters to
14894 also be handled in this way.
14896 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
14897 makes the use more obvious of the DeclSpace. The
14898 ec.TypeContainer.TypeBuilder is now only used to pull the
14899 TypeBuilder for it.
14901 My theory is that I can get rid of the TypeBuilder completely from
14902 the EmitContext, and have typecasts where it is used (from
14903 DeclSpace to where it matters).
14905 The only pending problem is that the code that implements Aliases
14906 is on TypeContainer, and probably should go in DeclSpace.
14908 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
14909 lookups here, instead of doing that at parse time. This means
14910 that our grammar will not introduce `LocalVariableReferences' as
14911 expressions at this point. That solves the problem of code like
14915 static void Main ()
14919 This is only half the fix. The full fix requires parameters to
14920 also be handled in this way.
14922 * class.cs (Property.DefineMethod): When implementing an interface
14923 method, set newslot, when implementing an abstract method, do not
14924 set the flag (before we tried never setting it, or always setting
14925 it, which is the difference).
14926 (Indexer.DefineMethod): same.
14927 (Method.DefineMethod): same.
14929 * ecore.cs: Only set the status used flag if we get back a Field.
14931 * attribute.cs: Temporary hack, so Paolo can keep working.
14933 2002-03-08 Ravi Pratap <ravi@ximian.com>
14935 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
14936 the unmanaged type in the case we have a MarshalAs attribute.
14938 (Resolve): Handle the case when we are parsing the special MarshalAs
14939 attribute [we need to store the unmanaged type to use later]
14941 * typemanager.cs (marshal_as_attr_type): Built in type for the
14942 MarshalAs Attribute.
14944 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
14945 on parameters and accordingly set the marshalling info.
14947 2002-03-09 Miguel de Icaza <miguel@ximian.com>
14949 * class.cs: Optimizing slightly by removing redundant code after
14950 we switched to the `NoTypes' return value.
14951 (Property.DefineMethod): use NoTypes here too.
14953 This fixes the bug I introduced in my last batch of changes.
14955 2002-03-05 Ravi Pratap <ravi@ximian.com>
14957 * tree.cs (RecordEnum): Add. We now keep track of enums too.
14959 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
14960 Enums since those are types too.
14962 * cs-parser.jay (enum_declaration): Record enums as we parse them.
14964 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
14965 thanks to a call during the lookup process.
14967 2002-03-07 Miguel de Icaza <miguel@ximian.com>
14969 * statement.cs (Foreach): Lots of work to accomodate a particular
14970 kind of foreach statement that I had not kept in mind. It is
14971 possible to have foreachs on classes that provide a GetEnumerator
14972 method that return objects that implement the "pattern" for using
14973 a foreach, there is no need to support GetEnumerator
14976 This is needed to compile nant.
14978 * decl.cs: Only report 114 if the member is not `Finalize' and if
14979 the warning level is at least 2.
14981 * class.cs: Moved the compare function from Method to
14984 (MethodSignature.InheritableMemberSignatureCompare): Add new
14985 filter function that is used to extract inheritable methods from a
14988 (Method.Define): Use the new `inheritable_method_signature_filter'
14991 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
14994 2002-03-06 Miguel de Icaza <miguel@ximian.com>
14996 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
14998 * cs-parser.jay: Add opt_semicolon to the interface declaration.
15000 * expression.cs: Pass location information to
15001 ConvertImplicitStandard.
15003 * class.cs: Added debugging code to track return values from
15006 2002-03-05 Miguel de Icaza <miguel@ximian.com>
15008 * expression.cs (Is.DoResolve): If either side of the `is' is an
15009 interface, do not flag the warning.
15011 * ecore.cs (ImplicitReferenceConversion): We need a separate test
15014 * report.cs: Allow for --fatal to be used with --probe.
15016 * typemanager.cs (NoTypes): Move the definition for the empty Type
15019 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
15021 (TypeContainer.DefineProxy): New function used to proxy to parent
15022 implementations when implementing interfaces.
15023 (TypeContainer.ParentImplements): used to lookup if our parent
15024 implements a public function that is required by an interface.
15025 (TypeContainer.VerifyPendingMethods): Hook this up.
15027 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
15028 `modules' and `assemblies' arraylists into arrays. We only grow
15029 these are the very early start up of the program, so this improves
15030 the speedof LookupType (nicely measured).
15032 * expression.cs (MakeByteBlob): Replaced unsafe code with
15033 BitConverter, as suggested by Paolo.
15035 * cfold.cs (ConstantFold.Binary): Special case: perform constant
15036 folding of string concatenation, but if either side is a string,
15037 and the other is not, then return null, and let the runtime use
15038 the concatenation on the string plus the object (using
15039 `Object.ToString').
15041 2002-03-04 Miguel de Icaza <miguel@ximian.com>
15043 Constant Folding has been implemented now.
15045 * expression.cs (Unary.Reduce): Do not throw an exception, catch
15046 the error instead on types that are not supported in one's
15049 * constant.cs (Constant and all children): New set of functions to
15050 perform implict and explicit conversions.
15052 * ecore.cs (EnumConstant): Implement the new functions to perform
15053 conversion by proxying to the child expression.
15055 * codegen.cs: (ConstantCheckState): Constant evaluation has its
15056 own separate setting that can not be turned off from the command
15057 line using --unchecked or --checked and is only controlled using
15058 the checked/unchecked statements and expressions. This setting is
15059 used by the constant folder to flag errors.
15061 * expression.cs (CheckedExpr, UncheckedExpr): Set the
15062 ConstantCheckState as well.
15064 During Resolve, they also have to flag the state, because the
15065 constant folder runs completely in the Resolve phase.
15067 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
15070 2002-03-01 Miguel de Icaza <miguel@ximian.com>
15072 * cfold.cs: New file, this file contains the constant folder.
15074 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
15075 argument to track whether we are using the resulting address to
15076 load or store a value and provide better error messages.
15078 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
15079 new AddressOf arguments.
15081 * statement.cs (Foreach.EmitCollectionForeach): Update
15083 * expression.cs (Argument.Emit): Call AddressOf with proper
15084 arguments to track usage.
15086 (New.DoEmit): Call AddressOf with new arguments.
15088 (Unary.Emit): Adjust AddressOf call.
15090 2002-03-01 Ravi Pratap <ravi@ximian.com>
15092 * cs-parser.jay (member_access): Change the case for pre-defined types
15093 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
15096 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
15099 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
15100 essentially like methods and apply attributes like MethodImplOptions to them too.
15102 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
15105 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
15106 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
15109 * Update code everywhere accordingly.
15111 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
15113 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
15115 2002-02-28 Ravi Pratap <ravi@ximian.com>
15117 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
15118 try performing lookups against those instead of jumping straight into using
15119 the 'using' clauses.
15121 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
15123 (LookupType): Perform lookups in implicit parents too.
15125 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
15126 sequence as RootContext.LookupType.
15128 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
15129 the various cases of namespace lookups into this method.
15131 2002-03-01 Miguel de Icaza <miguel@ximian.com>
15133 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
15134 in positional arguments)
15136 * class.cs (Operator): Update the AllowedModifiers to contain
15139 * cs-parser.jay: Update operator declaration to allow for the
15140 operator body to be empty.
15142 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
15145 2002-02-27 Miguel de Icaza <miguel@ximian.com>
15147 * class.cs (Method.Emit): Label parameters.
15149 * driver.cs: Return 1 or 0 as the program exit code.
15151 2002-02-26 Miguel de Icaza <miguel@ximian.com>
15153 * expression.cs: Special case the `null' object when trying to
15154 auto-compute the type, as anything can be explicitly converted to
15157 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
15158 spotting this Paolo.
15160 (Expression.ImplicitNumericConversion): Perform comparissions of
15161 the type using the underlying type in the case of an enumeration
15162 rather than using the enumeration type for the compare.
15164 Cope with the underlying == type case, which is not possible to
15167 (Expression.ConvertNumericExplicit): Perform comparissions of
15168 the type using the underlying type in the case of an enumeration
15169 rather than using the enumeration type for the compare.
15171 * driver.cs: If the user does not supply an extension, assume .exe
15173 * cs-parser.jay (if_statement): Rewrote so that we can track the
15174 location for the if statement.
15176 * expression.cs (Binary.ConstantFold): Only concat strings when
15177 the operation is "+", not everything ;-)
15179 * statement.cs (Statement.EmitBoolExpression): Take a location
15181 (If, While, Do): Track location.
15183 * expression.cs (Binary.ResolveOperator): In the object + string
15184 case, I was missing a call to ConvertImplicit
15186 2002-02-25 Ravi Pratap <ravi@ximian.com>
15188 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
15189 Location arguments. Ensure we use RootContext.LookupType to do our work
15190 and not try to do a direct Type.GetType and ModuleBuilder.GetType
15192 * interface.cs (PopulateMethod): Handle the type of the parameter being
15195 * expression.cs (Invocation.BetterFunction): Handle the case when we
15196 have a params method with no fixed arguments and a call is made with no
15199 2002-02-25 Miguel de Icaza <miguel@ximian.com>
15201 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
15202 the verbatim-string-literal
15204 * support.cs (InternalParameters.ParameterModifier): handle null
15206 (InternalParameters.ParameterType): ditto.
15208 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
15209 duplicating the name of the variable parameter.
15210 (GetParameterByName): Fix bug where we were not looking up array
15211 paramters if they were the only present (thanks Paolo!).
15212 (GetParameterInfo): We only have an empty set of types if both
15213 fixed and array are set to null.
15214 (GetParameterInfo-idx): Handle FixedParameter == null
15216 * cs-parser.jay: Handle the case where there is no catch
15217 statements (missing null test).
15219 2002-02-22 Miguel de Icaza <miguel@ximian.com>
15221 * driver.cs (MainDriver): Be conservative on our command line
15224 Catch DirectoryNotFoundException when calling GetFiles.
15226 (SplitPathAndPattern): Used to split the input specification into
15227 a path and a pattern that we can feed to Directory.GetFiles.
15229 2002-02-21 Miguel de Icaza <miguel@ximian.com>
15231 * statement.cs (Fixed): Implement the last case of the Fixed
15232 statement (string handling).
15234 * expression.cs (StringPtr): New class used to return a char * to
15235 a string; Used by the Fixed statement.
15237 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
15239 * expression.cs (Binary.ResolveOperator): Remove redundant
15240 MemberLookup pn parent type.
15241 Optimize union call, we do not need a union if the types are the same.
15242 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
15245 Specialize the use of MemberLookup everywhere, instead of using
15246 the default settings.
15248 (StackAlloc): Implement stackalloc keyword.
15250 * cs-parser.jay: Add rule to parse stackalloc.
15252 * driver.cs: Handle /h, /help, /?
15254 * expression.cs (MakeByteBlob): Removed the hacks we had in place
15255 before we supported unsafe code.
15257 * makefile: add --unsafe to the self compilation of mcs.
15259 2002-02-20 Miguel de Icaza <miguel@ximian.com>
15261 * expression.cs (PointerArithmetic): New class that is used to
15262 perform pointer arithmetic.
15263 (Binary.Resolve): Handle pointer arithmetic
15264 Handle pointer comparission.
15265 (ArrayPtr): Utility expression class that is used to take the
15266 address of an array.
15268 (ElementAccess): Implement array access for pointers
15270 * statement.cs (Fixed): Implement fixed statement for arrays, we
15271 are missing one more case before we are done.
15273 * expression.cs (Indirection): Implement EmitAssign and set the
15274 ExprClass to Variable. This allows pointer dereferences to be
15275 treated as variables, and to have values assigned to them.
15277 * ecore.cs (Expression.StoreFromPtr): New utility function to
15278 store values dereferencing.
15280 2002-02-20 Ravi Pratap <ravi@ximian.com>
15282 * expression.cs (Binary.ResolveOperator): Ensure that we are
15283 not trying to operate on a void type - this fixes the reported
15286 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
15287 the parent implementation is sealed.
15289 * ../errors/cs0239.cs : Add.
15291 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
15293 * typemanager.cs (unverifiable_code_type): Corresponds to
15294 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
15295 which have unsafe code in them.
15297 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
15300 2002-02-19 Miguel de Icaza <miguel@ximian.com>
15302 * cs-tokenizer.cs: Add support for @"litreal strings"
15304 Make tokenizer accept pre-processor directives
15305 on any column (remove the old C-like limitation).
15307 * rootcontext.cs (EmitCode): Emit any global attributes.
15308 (AddGlobalAttributes): Used to keep track of assembly attributes.
15310 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
15312 * cs-parser.jay: Add support for global attributes.
15314 2002-02-17 Miguel de Icaza <miguel@ximian.com>
15316 * expression.cs (Indirection): New helper class. Unary will
15317 create Indirection classes to be able to implement the
15318 IMemoryLocation interface on it.
15320 2002-02-16 Miguel de Icaza <miguel@ximian.com>
15322 * cs-parser.jay (fixed_statement): reference the right statement.
15324 * statement.cs (Fixed.Emit): Finish implementing the fixed
15325 statement for the &x case.
15327 2002-02-14 Miguel de Icaza <miguel@ximian.com>
15329 * class.cs (Property.Define, Method.Define): Remove newslot when
15332 * modifiers.cs: My use of NewSlot when `Abstract' was set was
15333 wrong. NewSlot should only be used if the `new' keyword is present.
15335 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
15336 locating our system dir. Sorry about this.
15338 2002-02-13 Miguel de Icaza <miguel@ximian.com>
15340 * driver.cs (GetSystemDir): Compute correctly the location of our
15341 system assemblies. I was using the compiler directory instead of
15342 the library directory.
15344 2002-02-13 Ravi Pratap <ravi@ximian.com>
15346 * expression.cs (BetterFunction): Put back in what Miguel commented out
15347 since it is the correct fix. The problem is elsewhere ;-)
15349 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
15350 parameters of the parms method are themselves compatible or not !
15352 (StandardConversionExists): Fix very dangerous bug where we were forgetting
15353 to check that a class implements an interface before saying that an implicit
15354 conversion was allowed. Use ImplementsInterface to do the checking.
15356 2002-02-13 Miguel de Icaza <miguel@ximian.com>
15358 * class.cs (Method.Define): Track whether we are an explicit
15359 implementation or not. And only call DefineMethodOverride if we
15360 are an explicit implementation.
15362 (Property.DefineMethod): Ditto.
15364 2002-02-11 Ravi Pratap <ravi@ximian.com>
15366 * expression.cs (BetterFunction): Catch hideous bug which was
15367 preventing us from detecting ambiguous calls due to implicit casts i.e
15370 2002-01-29 Miguel de Icaza <miguel@ximian.com>
15372 * support.cs (Pair): Remove un-needed method. I figured why I was
15373 getting the error in cs-parser.jay, the variable in a foreach loop
15374 is readonly, and the compiler does not really treat this as a variable.
15376 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
15377 instead of EQUALS in grammar.
15379 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
15381 * expression.cs (Unary.DoResolve): Check whether the argument is
15384 2002-01-28 Miguel de Icaza <miguel@ximian.com>
15386 * support.cs: Api for Pair to set a value. Despite the fact that
15387 the variables are public the MS C# compiler refuses to compile
15388 code that accesses the field if the variable is part of a foreach
15391 * statement.cs (Fixed): Begin implementation of the fixed
15394 (Block.AddVariable): Return the VariableInfo on success and null
15395 on failure instead of true/false.
15397 * cs-parser.jay (foreach): Catch errors on variables already
15398 defined (we were ignoring this value before) and properly unwind
15399 the block hierarchy
15401 (fixed_statement): grammar for the fixed statement.
15403 2002-01-25 Miguel de Icaza <miguel@ximian.com>
15405 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
15406 pointer types to be incretemented.
15408 (SizeOf): Implement.
15410 * cs-parser.jay (pointer_member_access): Implement
15411 expr->IDENTIFIER production.
15413 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
15414 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
15417 (Unary): Implement indirection.
15419 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
15420 use in non-unsafe context).
15422 (SimpleName.DoResolve): Check for pointers in field access on safe
15425 (Expression.LoadFromPtr): Factor the load-indirect code in this
15426 function. This was duplicated in UnboxCast and ParameterReference
15428 2002-01-24 Miguel de Icaza <miguel@ximian.com>
15430 * expression.cs (ComposedCast): report an error if a pointer cast
15431 is used in a safe region.
15433 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
15434 pointer type casts in unsafe context.
15436 * codegen.cs (EmitContext): Set up IsUnsafe.
15438 * cs-parser.jay (non_expression_type): Add productions for pointer
15441 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
15442 code. We should not use force into static mode if the method is
15443 not virtual. Fixes bug in MIS
15445 * statement.cs (Do.Emit, While.Emit, For.Emit,
15446 Statement.EmitBoolExpression): Add support to Do and While to
15447 propagate infinite loop as `I do return' semantics.
15449 Improve the For case to also test for boolean constants.
15451 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
15452 to the list of attributes we can add.
15454 Remove `EmitContext' argument.
15456 * class.cs (Method.Define): Apply parameter attributes.
15457 (Constructor.Define): Apply parameter attributes.
15458 (MethodCore.LabelParameters): Move here the core of labeling
15461 * support.cs (ReflectionParameters.ParameterModifier,
15462 InternalParameters.ParameterModifier): Use IsByRef on the type and
15463 only return the OUT bit for these parameters instead of in/out/ref
15466 This is because I miss-understood things. The ParameterInfo.IsIn
15467 and IsOut represent whether the parameter has the [In] and [Out]
15470 2002-01-22 Miguel de Icaza <miguel@ximian.com>
15472 * ecore.cs (FieldExpr.Emit): Release temporaries.
15474 * assign.cs (LocalTemporary.Release): new function.
15476 * codegen.cs (EmitContext.GetTemporaryStorage,
15477 EmitContext.FreeTemporaryStorage): Rework the way we deal with
15478 temporary storage. Now we can "put back" localbuilders when we
15481 2002-01-21 Miguel de Icaza <miguel@ximian.com>
15483 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
15484 need to make a copy of the variable to generate verifiable code.
15486 2002-01-19 Miguel de Icaza <miguel@ximian.com>
15488 * driver.cs: Compute dynamically the system directory.
15490 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
15491 Slower, but more generally useful. Used by the abstract
15492 registering implementation.
15494 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
15495 the rules for the special rule on Type/instances. First check if
15496 we have the same name, and if so, try that special static path
15497 rather than the instance path.
15499 2002-01-18 Miguel de Icaza <miguel@ximian.com>
15501 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
15504 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
15505 Enum, ValueType, Delegate or Array for non-corlib compiles.
15507 * cs-tokenizer.cs: Catch long identifiers (645)
15509 * typemanager.cs (IndexerPropetyName): Ravi never tested this
15512 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
15513 fix, we were returning too early, so we were not registering
15514 pending methods from abstract classes.
15516 Do not register pending methods if the class is abstract.
15518 * expression.cs (Conditional.DoResolve): Report circular implicit
15519 conversions when we neecd to compute it for conditional
15522 (Is.DoResolve): If the expression is always of the provided type,
15523 flag warning 183. If the expression can not ever be of the
15524 provided type flag warning 184.
15526 * class.cs: Catch 169 as well.
15528 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
15531 2002-01-18 Nick Drochak <ndrochak@gol.com>
15533 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
15535 2002-01-17 Miguel de Icaza <miguel@ximian.com>
15537 * interface.cs: (PopulateMethod): Check for pointers being defined
15538 only if the unsafe context is active.
15539 (PopulateProperty): ditto.
15540 (PopulateIndexer): ditto.
15542 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
15543 specified. If pointers are present, make sure that they are
15544 present in an unsafe context.
15545 (Constructor, Constructor.Define): ditto.
15546 (Field, Field.Define): ditto.
15547 (Property, Property.Define): ditto.
15548 (Event, Event.Define): ditto.
15550 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
15551 hashtable if there are classes or structs defined.
15553 * expression.cs (LocalVariableReference.DoResolve): Simplify this
15554 code, as the constant resolution moved.
15556 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
15557 the metadata, so we can flag error 133.
15559 * decl.cs (MemberCore.UnsafeOK): New function to test that a
15560 pointer is being declared in an unsafe context.
15562 2002-01-16 Miguel de Icaza <miguel@ximian.com>
15564 * modifiers.cs (Modifiers.Check): Require a Location argument.
15565 Report error 227 for Unsafe use.
15567 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
15569 * statement.cs (For.Emit): If the test is null, then report that
15570 we do `return', as we wont reach anything afterwards.
15572 (Switch.SwitchGoverningType): Track the expression that matched
15575 * driver.cs: Allow negative numbers as an error code to flag.
15577 * cs-parser.jay: Handle 1551.
15579 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
15581 2002-01-15 Miguel de Icaza <miguel@ximian.com>
15583 * cs-parser.jay: Report 1518 (type declaration can only contain
15584 class, struct, interface, enum or delegate)
15586 (switch_label): Report 1523 (keywords `case' or `default' must
15589 (opt_switch_sections): Report 1522 (empty switch)
15591 * driver.cs: Report 1515 (response file specified multiple times)
15592 Report 1516 (Source file specified multiple times).
15594 * expression.cs (Argument.Resolve): Signal 1510
15596 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
15597 access not allowed in static code)
15599 2002-01-11 Ravi Pratap <ravi@ximian.com>
15601 * typemanager.cs (IsPointerType): Utility method which we are going
15604 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
15605 the object type, so we take care of that.
15607 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
15609 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
15610 added to non-params parameters :-)
15612 * typemanager.cs (CSharpName): Include 'void' type too.
15614 (void_ptr_type): Include in the set of core types.
15616 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
15619 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
15622 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
15623 completely forgotten about it.
15625 2002-01-10 Ravi Pratap <ravi@ximian.com>
15627 * cs-parser.jay (pointer_type): Add. This begins our implementation
15628 of parsing rules for unsafe code.
15630 (unsafe_statement): Implement.
15632 (embedded_statement): Modify to include the above.
15634 * statement.cs (Unsafe): Implement new class for unsafe blocks.
15636 * codegen.cs (EmitContext.InUnsafe): Add. This determines
15637 if the current context is an unsafe one.
15639 * cs-parser.jay (local_variable_pointer_type): Since local variable types
15640 are handled differently, we need separate rules for them.
15642 (local_variable_declaration): Update to use local_variable_pointer_type
15643 to allow variable declarations of unmanaged pointer types.
15645 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
15646 in unsafe contexts.
15648 * ../errors/cs0214.cs : Add.
15650 2002-01-16 Nick Drochak <ndrochak@gol.com>
15652 * makefile: remove 'response' file when cleaning.
15654 2002-01-15 Miguel de Icaza <miguel@ximian.com>
15656 * cs-parser.jay: Report 1524.
15658 2002-01-14 Miguel de Icaza <miguel@ximian.com>
15660 * typemanager.cs (RegisterMethod): drop checking if we have
15661 registered this from here
15663 2002-01-12 Miguel de Icaza <miguel@ximian.com>
15665 * class.cs (Method.EmitDestructor): Implement calling our base
15668 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
15669 value of InFinally.
15671 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
15672 this routine and will wrap the call in a try/catch block. Deal
15675 2002-01-11 Miguel de Icaza <miguel@ximian.com>
15677 * ecore.cs (Expression.MemberLookup): instead of taking a
15678 parameter `same_type' that was used to tell whether we could
15679 access private members we compute our containing type from the
15682 (FieldExpr): Added partial support for volatile fields. This does
15683 not work for volatile fields exposed from assemblies, as I can not
15684 figure out how to extract the modreq from it.
15686 Updated all the source files to use this.
15688 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
15689 because it is referenced by MemberLookup very often.
15691 2002-01-09 Ravi Pratap <ravi@ximian.com>
15693 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
15694 TypeBuilder.GetCustomAttributes to retrieve what we need.
15696 Get rid of redundant default_member_attr_type as this is the same as
15697 default_member_type which already exists.
15699 * interface.cs, attribute.cs : Update accordingly.
15701 2002-01-08 Miguel de Icaza <miguel@ximian.com>
15703 * typemanager.cs: Enable IndexerPropertyName again. It does not
15704 work for TYpeBuilders though. Ravi, can you please fix this?
15706 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
15708 * expression.cs (Argument.Emit): Handle the case of ref objects
15709 being passed to ref functions;
15711 (ParameterReference.EmitLoad): Loads the content of the pointer
15712 without dereferencing.
15714 2002-01-07 Miguel de Icaza <miguel@ximian.com>
15716 * cs-tokenizer.cs: Implemented the pre-processing expressions.
15718 2002-01-08 Ravi Pratap <ravi@ximian.com>
15720 * class.cs (Indexer.DefineMethod): Incorporate the interface
15721 type in the name of the method if we are doing explicit interface
15724 * expression.cs (ConversionExists): Remove as it is completely obsolete.
15726 (BetterConversion): Fix extremely trivial bug where we were referring to
15727 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
15730 * ../errors/bug16.cs : Add although we have fixed it.
15732 2002-01-07 Miguel de Icaza <miguel@ximian.com>
15734 * expression.cs (BaseIndexer): Begin implementation.
15736 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
15738 * cs-parser.jay (indexer_declarator): Use qualified_identifier
15739 production directly to remove a shift/reduce, and implement
15740 explicit interface implementation.
15742 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
15743 after a floating point suffix.
15745 * expression.cs (DoNumericPromotions): Improved the conversion for
15746 uint/uint. If we have a constant, we avoid doing a typecast to a
15749 * class.cs (Indexer): Implement explicit interface implementation
15752 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
15754 * class.cs: make the default instance constructor public and hidebysig.
15756 2001-01-03 Ravi Pratap <ravi@ximian.com>
15758 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
15759 so we can call it from elsewhere.
15761 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
15762 we emit it internally if the class has a defined indexer; otherwise the user
15763 emits it by decorating the class definition with the DefaultMemberAttribute.
15765 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
15766 attribute is not used on a type which defines an indexer.
15768 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
15769 character when we skip whitespace.
15771 * ../errors/cs0646.cs : Add.
15773 2002-01-03 Miguel de Icaza <miguel@ximian.com>
15775 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
15778 * makefile: Add practical target `mcs3.exe' which builds the third
15779 generation compiler.
15781 * expression.cs (New): Fix structures constructor calling.
15783 * class.cs (Property, Method, Indexer): Emit Final flag on the
15784 method if we are an interface implementation and we are not
15787 * ecore.cs (PropertyExpr): New public field `IsBase', tells
15788 whether this property is referencing a `base' method.
15790 * expression.cs (Invocation.EmitCall): take an extra argument:
15791 is_base, this is used to determine whether the `call' or
15792 `callvirt' opcode should be used.
15795 * delegate.cs: update EmitCall.
15797 * class.cs (Method.Define): Set NewSlot for the cases where we are
15798 not implementing an interface method.
15800 (Property.Define): ditto.
15802 2002-01-02 Miguel de Icaza <miguel@ximian.com>
15804 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
15805 'r'. Allows mcs to parse itself fully.
15807 2002-01-02 Ravi Pratap <ravi@ximian.com>
15809 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
15810 of the number of initializers that require the InitializeArray method.
15812 (CheckIndices): Store the Expression in all cases - not the plain value. Also
15813 update the above field where necessary.
15815 (MakeByteBlob): Update accordingly.
15817 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
15820 (EmitDynamicInitializers): Update in accordance with the new optimization.
15822 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
15823 same OpCode applies.
15825 * cs-parser.jay : Fix some glaring errors I introduced.
15827 2002-01-01 Ravi Pratap <ravi@ximian.com>
15829 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
15830 so that we can check for name clashes there too.
15832 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
15833 for interface indexers.
15835 * interfaces.cs (Define): Emit the default member attribute.
15837 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
15838 variable was being referred to while setting the value ;-)
15840 2002-01-01 Miguel de Icaza <miguel@ximian.com>
15842 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
15843 byte-by-byte information when we know the data is zero.
15845 Make the block always a multiple of 4, because
15846 DefineInitializedData has a bug.
15848 * assign.cs: Fix, we should assign from the temporary, not from
15851 * expression.cs (MakeByteBlob): Fix my incorrect code.
15853 2001-12-31 Miguel de Icaza <miguel@ximian.com>
15855 * typemanager.cs (EnumToUnderlying): This function is used to get
15856 the underlying type from an enumeration, because it does not
15859 * constant.cs: Use the I4_S form for values between -128 and 127.
15861 * statement.cs (Block.LookupLabel): Looks up a label.
15862 (Block): Drop support for labeled blocks.
15864 (LabeledStatement): New kind of statement that represents a label
15867 (Goto): Finally implement this bad boy.
15869 * cs-parser.jay: Update to reflect new mechanism to implement
15872 2001-12-30 Miguel de Icaza <miguel@ximian.com>
15874 * codegen.cs (EmitContext.This): a codegen property that keeps the
15875 a single instance of this instead of creating many different this
15878 * delegate.cs (Delegate.DoResolve): Update to use the property;
15880 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
15882 * expression.cs (BaseAccess.DoResolve): Ditto.
15884 2001-12-29 Ravi Pratap <ravi@ximian.com>
15886 * typemanager.cs (methodimpl_attr_type): Add to hold the type
15887 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
15889 (InitCoreTypes): Update accordingly.
15891 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
15892 so we can quickly store the state.
15894 (ApplyAttributes): Set the correct implementation flags
15895 for InternalCall methods.
15897 2001-12-29 Miguel de Icaza <miguel@ximian.com>
15899 * expression.cs (EmitCall): if a method is not virtual, then do
15900 not use callvirt on it.
15902 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
15903 user defined stuff) requires the use of stobj, which takes an
15904 address on the stack instead of an array and an index. So emit
15905 the Ldelema operation for it.
15907 (EmitStoreOpcode): Use stobj for valuetypes.
15909 (UnaryMutator.EmitCode): Use the right 1 value depending on
15910 whether we are dealing with int64/uint64, float or doubles.
15912 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
15913 constructors that I implemented last night.
15915 (Constructor.IsDefault): Fix to work properly for static
15918 * cs-parser.jay (CheckDef): report method signature errors.
15919 Update error number 103 to be 132.
15921 * decl.cs: New AdditionResult enumeration value: MethodExists.
15922 Although we do this check for methods later on in the semantic
15923 analysis, catching repeated default constructors is so easy that
15924 we catch these here.
15926 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
15929 (ParameterReference.EmitAssign, Emit): handle
15932 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
15933 (ArrayAccess.EmitStoreOpcode): ditto.
15935 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
15937 * expression.cs (MakeByteBlob): Complete all the missing types
15938 (uint, short, ushort, byte, sbyte)
15940 * class.cs: Only init instance field initializers on instance
15943 Rename `constructors' to instance_constructors.
15945 (TypeContainer.AddConstructor): Only add constructors to the list
15946 if it is not static.
15948 Make sure that we handle default_static_constructor independently
15949 everywhere where we handle instance_constructors
15951 2001-12-28 Miguel de Icaza <miguel@ximian.com>
15953 * class.cs: Do not lookup or create a base initializer for a
15954 static constructor.
15956 (ConstructorInitializer.Resolve): use the proper type to lookup
15959 * cs-parser.jay: Report error 1585 (modifiers between type and name).
15961 * enum.cs, interface.cs: Remove CloseType, this is taken care by
15964 * decl.cs: CloseType is now an virtual method, the default
15965 implementation just closes this type.
15967 2001-12-28 Ravi Pratap <ravi@ximian.com>
15969 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
15970 to PreserveSig by default. Also emit HideBySig on such methods.
15972 Basically, set the defaults to standard values.
15974 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
15975 argument, if candidate is better, it can't be worse than the best !
15977 (Invocation): Re-write bits to differentiate between methods being
15978 applicable in their expanded form and their normal form - for params
15981 Get rid of use_standard everywhere as only standard conversions are allowed
15982 in overload resolution.
15984 More spec conformance.
15986 2001-12-27 Miguel de Icaza <miguel@ximian.com>
15988 * driver.cs: Add --timestamp, to see where the compiler spends
15991 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
15992 `this' in static code.
15994 (SimpleName.DoResolve): Implement in terms of a helper function
15995 that allows static-references to be passed upstream to
15998 (Expression.ResolveWithSimpleName): Resolve specially simple
15999 names when called by MemberAccess to implement the special
16002 (Expression.ImplicitReferenceConversion): Handle conversions from
16003 Null to reference types before others, as Null's type is
16006 * expression.cs (Invocation.EmitCall): Handle the special case of
16007 calling methods declared on a reference type from a ValueType
16008 (Base classes System.Object and System.Enum)
16010 (MemberAccess.Resolve): Only perform lookups on Enumerations if
16011 the left hand side is a TypeExpr, not on every enumeration.
16013 (Binary.Resolve): If types are reference types, then do a cast to
16014 object on operators != and == of both arguments.
16016 * typemanager.cs (FindMembers): Extract instance and static
16017 members if requested.
16019 * interface.cs (PopulateProperty): Use void_type instead of null
16020 as the return type for the setter method.
16022 (PopulateIndexer): ditto.
16024 2001-12-27 Ravi Pratap <ravi@ximian.com>
16026 * support.cs (ReflectionParameters): Fix minor bug where we
16027 were examining the wrong parameter for the ParamArray attribute.
16029 Cope with requests for the type of the parameter at position
16030 greater than the params parameter's. We now return the element
16031 type of the params array as that makes more sense.
16033 * expression.cs (Invocation.IsParamsMethodApplicable): Update
16034 accordingly as we no longer have to extract the element type
16037 (Invocation.OverloadResolve): Update.
16039 2001-12-27 Miguel de Icaza <miguel@ximian.com>
16041 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
16042 against IEnumerator, test whether the return value is a descendant
16043 of the IEnumerator interface.
16045 * class.cs (Indexer.Define): Use an auxiliary method to implement
16046 the other bits of the method definition. Begin support for
16047 explicit interface implementation.
16049 (Property.DefineMethod): Use TypeManager.void_type instead of null
16050 for an empty return value.
16052 2001-12-26 Miguel de Icaza <miguel@ximian.com>
16054 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
16055 dealing with a FieldExpr which is composed of a FieldBuilder, in
16056 the code path we did extract the constant, but we should have
16057 obtained the underlying value to be able to cast it (otherwise we
16058 end up in an infinite loop, this is what Ravi was running into).
16060 (ArrayCreation.UpdateIndices): Arrays might be empty.
16062 (MemberAccess.ResolveMemberAccess): Add support for section
16063 14.5.4.1 that deals with the special case of E.I when E is a type
16064 and something else, that I can be a reference to a static member.
16066 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
16067 handle a particular array type to create byte blobs, it is just
16068 something we dont generate byteblobs for.
16070 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
16073 * location.cs (Push): remove the key from the hashtable that we
16074 are about to add. This happens for empty files.
16076 * driver.cs: Dispose files after we have parsed them.
16078 (tokenize): new function that only runs the tokenizer on its
16079 input, for speed testing.
16081 2001-12-26 Ravi Pratap <ravi@ximian.com>
16083 * class.cs (Event.Define): Define the private field only if there
16084 are no accessors defined.
16086 * expression.cs (ResolveMemberAccess): If there is no associated
16087 field with the event, that means we have an event defined with its
16088 own accessors and we should flag error cs0070 since transforming
16089 ourselves into a field is not valid in that case.
16091 * ecore.cs (SimpleName.DoResolve): Same as above.
16093 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
16094 and charset to sane values.
16096 2001-12-25 Ravi Pratap <ravi@ximian.com>
16098 * assign.cs (DoResolve): Perform check on events only if they
16099 are being accessed outside the declaring type.
16101 * cs-parser.jay (event_declarations): Update rules to correctly
16102 set the type of the implicit parameter etc.
16104 (add_accessor, remove_accessor): Set current local parameters.
16106 * expression.cs (Binary): For delegate addition and subtraction,
16107 cast the return value from the method into the appropriate delegate
16110 2001-12-24 Ravi Pratap <ravi@ximian.com>
16112 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
16113 of these as the workaround is unnecessary.
16115 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
16116 delegate data - none of that is needed at all.
16118 Re-write bits to extract the instance expression and the delegate method
16121 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
16124 * attribute.cs (ApplyAttributes): New method to take care of common tasks
16125 of attaching attributes instead of duplicating code everywhere.
16127 * everywhere : Update code to do attribute emission using the above method.
16129 2001-12-23 Miguel de Icaza <miguel@ximian.com>
16131 * expression.cs (IsParamsMethodApplicable): if there are not
16132 parameters, return immediately.
16134 * ecore.cs: The 0 literal can be implicity converted to an enum
16137 (SimpleName.DoResolve): First lookup the type, then lookup the
16140 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
16141 want to get its address. If the InstanceExpression is not
16142 addressable, store the result in a temporary variable, then get
16145 * codegen.cs: Only display 219 errors on warning level or above.
16147 * expression.cs (ArrayAccess): Make it implement the
16148 IMemoryLocation interface.
16150 (Binary.DoResolve): handle the operator == (object a, object b)
16151 and operator != (object a, object b) without incurring into a
16152 BoxedCast (because 5 != o should never be performed).
16154 Handle binary enumerator operators.
16156 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
16157 value type, otherwise use Ldelem_ref.
16159 Use precomputed names;
16161 (AddressOf): Implement address of
16163 * cs-parser.jay (labeled_statement): Fix recursive block
16164 addition by reworking the production.
16166 * expression.cs (New.DoEmit): New has a special case:
16168 If we are dealing with a ValueType, we have a few
16169 situations to deal with:
16171 * The target of New is a ValueType variable, that is
16172 easy, we just pass this as the variable reference
16174 * The target of New is being passed as an argument,
16175 to a boxing operation or a function that takes a
16178 In this case, we need to create a temporary variable
16179 that is the argument of New.
16182 2001-12-23 Ravi Pratap <ravi@ximian.com>
16184 * rootcontext.cs (LookupType): Check that current_type is not null before
16185 going about looking at nested types.
16187 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
16188 not implement the IAssignMethod interface any more.
16190 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
16191 where we tranform them into FieldExprs if they are being resolved from within
16192 the declaring type.
16194 * ecore.cs (SimpleName.DoResolve): Do the same here.
16196 * assign.cs (DoResolve, Emit): Clean up code considerably.
16198 * ../errors/bug10.cs : Add.
16200 * ../errors/cs0070.cs : Add.
16202 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
16204 * assign.cs : Get rid of EventIsLocal everywhere.
16206 2001-12-23 Miguel de Icaza <miguel@ximian.com>
16208 * ecore.cs (ConvertIntLiteral): finished the implementation.
16210 * statement.cs (SwitchLabel): Convert the value we are using as a
16211 key before looking up the table.
16213 2001-12-22 Miguel de Icaza <miguel@ximian.com>
16215 * codegen.cs (EmitTopBlock): Require a Location argument now.
16217 * cs-parser.jay (constructor_declarator): We need to setup
16218 current_local_parameters before we parse the
16219 opt_constructor_initializer, to allow the variables to be bound
16220 to the constructor arguments.
16222 * rootcontext.cs (LookupType): First lookup nested classes in our
16223 class and our parents before we go looking outside our class.
16225 * expression.cs (ConstantFold): Extract/debox the values at the
16228 * rootcontext.cs (EmitCode): Resolve the constants first before we
16229 resolve the types. This is not really needed, but it helps debugging.
16231 * statement.cs: report location.
16233 * cs-parser.jay: pass location to throw statement.
16235 * driver.cs: Small bug fix.
16237 * report.cs: Updated format to be 4-zero filled digits.
16239 2001-12-22 Ravi Pratap <ravi@ximian.com>
16241 * expression.cs (CheckIndices): Fix minor bug where the wrong
16242 variable was being referred to ;-)
16244 (DoEmit): Do not call EmitStaticInitializers when the
16245 underlying type is System.Object.
16247 2001-12-21 Ravi Pratap <ravi@ximian.com>
16249 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
16250 and do the usual workaround for SRE.
16252 * class.cs (MyEventBuilder.EventType): New member to get at the type
16253 of the event, quickly.
16255 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
16257 * assign.cs (Assign.DoResolve): Handle the case when the target
16258 is an EventExpr and perform the necessary checks.
16260 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
16263 (SimpleName.MemberStaticCheck): Include check for EventExpr.
16265 (EventExpr): Set the type in the constructor itself since we
16266 are meant to be born fully resolved.
16268 (EventExpr.Define): Revert code I wrote earlier.
16270 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
16271 instance expression is null. The instance expression is a This in that case
16272 or a null, depending on whether it is a static method or not.
16274 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
16275 refers to more than one method.
16277 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
16278 and accordingly flag errors.
16280 2001-12-21 Miguel de Icaza <miguel@ximian.com>
16282 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
16284 2001-12-22 Miguel de Icaza <miguel@ximian.com>
16286 * location.cs (ToString): Provide useful rutine.
16288 2001-12-21 Miguel de Icaza <miguel@ximian.com>
16290 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
16291 objects, return the actual integral boxed.
16293 * statement.cs (SwitchLabel): define an ILLabel for each
16296 (Switch.CheckSwitch): If the value is a Literal, extract
16297 the underlying literal.
16299 Also in the unused hashtable we had, add the SwitchLabel so we can
16300 quickly look this value up.
16302 * constant.cs: Implement a bunch of new constants. Rewrite
16303 Literal based on this. Made changes everywhere to adapt to this.
16305 * expression.cs (Expression.MakeByteBlob): Optimize routine by
16306 dereferencing array only once, and also copes with enumrations.
16308 bytes are two bytes wide, not one.
16310 (Cast): Perform constant conversions.
16312 * ecore.cs (TryImplicitIntConversion): Return literals instead of
16313 wrappers to the literals here.
16315 * expression.cs (DoNumericPromotions): long literals can converted
16316 to ulong implicity (this is taken care of elsewhere, but I was
16317 missing this spot).
16319 * ecore.cs (Expression.Literalize): Make the return type Literal,
16320 to improve type checking.
16322 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
16324 2001-12-20 Miguel de Icaza <miguel@ximian.com>
16326 * literal.cs: Revert code from ravi that checked the bounds. The
16327 bounds are sane by the definition of the type itself.
16329 * typemanager.cs: Fix implementation of ImplementsInterface. We
16330 need to actually look up in our parent hierarchy for interfaces
16333 * const.cs: Use the underlying type for enumerations
16335 * delegate.cs: Compute the basename for the delegate creation,
16336 that should fix the delegate test case, and restore the correct
16337 Type Lookup semantics in rootcontext
16339 * rootcontext.cs: Revert Ravi's last patch. The correct way of
16340 referencing a nested type with the Reflection API is using the "+"
16343 * cs-parser.jay: Do not require EOF token at the end.
16345 2001-12-20 Ravi Pratap <ravi@ximian.com>
16347 * rootcontext.cs (LookupType): Concatenate type names with
16348 a '.' instead of a '+' The test suite passes again.
16350 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
16351 field of the enumeration.
16353 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
16354 the case when the member is an EventExpr.
16356 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
16357 static has an associated instance expression.
16359 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
16361 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
16363 * class.cs (Event.Define): Register event and perform appropriate checks
16366 We define the Add and Remove methods even if the use provides none because
16367 in that case, we provide default implementations ourselves.
16369 Define a private field of the type of the event. This is done by the CSC compiler
16370 and we should be doing it too ;-)
16372 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
16373 More methods we use in code we generate.
16375 (multicast_delegate_type, delegate_type): Two separate types since the distinction
16378 (InitCoreTypes): Update accordingly for the above.
16380 * class.cs (Event.Emit): Generate code for default accessors that we provide
16382 (EmitDefaultMethod): Do the job in the above.
16384 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
16387 2001-12-20 Miguel de Icaza <miguel@ximian.com>
16389 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
16390 builders even if we were missing one.
16392 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
16393 pass the Basename as our class name instead of the Name. The
16394 basename will be correctly composed for us.
16396 * parameter.cs (Paramters): Now takes a Location argument.
16398 * decl.cs (DeclSpace.LookupType): Removed convenience function and
16399 make all the code call directly LookupType in RootContext and take
16400 this chance to pass the Location information everywhere.
16402 * Everywhere: pass Location information.
16404 2001-12-19 Miguel de Icaza <miguel@ximian.com>
16406 * class.cs (Constructor.Define): Updated way of detecting the
16407 length of the parameters.
16409 (TypeContainer.DefineType): Use basename as the type name for
16412 (TypeContainer.Define): Do not recursively define types here, as
16413 definition is taken care in order by the RootContext.
16415 * tree.cs: Keep track of namespaces in a per-file basis.
16417 * parameter.cs (Parameter.ComputeSignature): Update to use
16420 (Parameters.GetSignature): ditto.
16422 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
16423 instead of a TypeContainer.
16425 (Interface.SemanticAnalysis): Use `this' instead of our parent to
16426 resolve names. Because we need to be resolve in our context, not
16429 * driver.cs: Implement response files.
16431 * class.cs (TypeContainer.DefineType): If we are defined, do not
16432 redefine ourselves.
16434 (Event.Emit): Emit the code for add/remove handlers.
16435 (Event.Define): Save the MethodBuilders for add/remove.
16437 * typemanager.cs: Use pair here too.
16439 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
16440 DictionaryEntry requires the first argument to be non-null.
16442 (enum_declaration): Compute full name for registering the
16445 (delegate_declaration): Instead of using
16446 formal_parameter_list, use opt_formal_parameter_list as the list
16449 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
16450 (EventParsing): New property that controls whether `add' and
16451 `remove' are returned as tokens or identifiers (for events);
16453 2001-12-19 Ravi Pratap <ravi@ximian.com>
16455 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
16456 use MyEventBuilder only and let it wrap the real builder for us.
16458 (MyEventBuilder): Revamp constructor etc.
16460 Implement all operations that we perform on EventBuilder in precisely the same
16463 (FindMembers): Update to use the EventBuilder member.
16465 (Event.Emit): Update accordingly.
16467 2001-12-18 Ravi Pratap <ravi@ximian.com>
16469 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
16470 by calling the appropriate methods.
16472 (GetCustomAttributes): Make stubs as they cannot possibly do anything
16475 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
16477 2001-12-17 Ravi Pratap <ravi@ximian.com>
16479 * delegate.cs (Delegate.Populate): Check that the return type
16480 and various parameters types are indeed accessible.
16482 * class.cs (Constructor.Define): Same here.
16484 (Field.Define): Ditto.
16486 (Event.Define): Ditto.
16488 (Operator.Define): Check that the underlying Method defined itself
16489 correctly - so it's MethodBuilder should not be null.
16491 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
16492 expression happens to be null.
16494 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
16495 members but as of now we don't seem to be able to do anything really useful with it.
16497 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
16498 not the EventBuilder.
16500 2001-12-18 Miguel de Icaza <miguel@ximian.com>
16502 * cs-tokenizer.cs: Add support for defines.
16503 Add support for #if, #elif, #else, #endif
16505 (eval_var): evaluates a variable.
16506 (eval): stubbed for evaluating functions.
16508 * cs-parser.jay: Pass the defines information
16510 * driver.cs: Add --define command line option.
16512 * decl.cs: Move MemberCore here.
16514 Make it the base class for DeclSpace. This allows us to catch and
16515 report 108 and 109 for everything now.
16517 * class.cs (TypeContainer.Define): Extract all the members
16518 before populating and emit the warning 108 (new keyword required
16519 to override) instead of having each member implement this.
16521 (MemberCore.Define): New abstract method, we will be using this in
16522 the warning reporting engine in Populate.
16524 (Operator.Define): Adjust to new MemberCore protocol.
16526 * const.cs (Const): This does not derive from Expression, it is a
16527 temporary object we use to create fields, it is a MemberCore.
16529 * class.cs (Method.Define): Allow the entry point to be in a
16532 * driver.cs: Rewrite the argument handler to clean it up a bit.
16534 * rootcontext.cs: Made it just an auxiliary namespace feature by
16535 making everything static.
16537 * driver.cs: Adapt code to use RootContext type name instead of
16540 * delegate.cs: Remove RootContext argument.
16542 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
16545 * class.cs (Event.Define): The lookup can fail.
16547 * cs-tokenizer.cs: Begin implementation of pre-procesor.
16549 * expression.cs: Resolve the this instance before invoking the code.
16551 2001-12-17 Miguel de Icaza <miguel@ximian.com>
16553 * cs-parser.jay: Add a production in element_access that allows
16554 the thing to become a "type" reference. This way we can parse
16555 things like "(string [])" as a type.
16557 Note that this still does not handle the more complex rules of
16561 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
16563 * ecore.cs: (CopyNewMethods): new utility function used to
16564 assemble the list of methods from running FindMembers.
16566 (MemberLookup): Rework FindMembers so that
16568 2001-12-16 Miguel de Icaza <miguel@ximian.com>
16570 * class.cs (TypeContainer): Remove Delegates who fail to be
16573 * delegate.cs (Populate): Verify that we dont get null return
16574 values. TODO: Check for AsAccessible.
16576 * cs-parser.jay: Use basename to emit error 574 (destructor should
16577 have the same name as container class), not the full name.
16579 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
16580 possible representation.
16582 Also implements integer type suffixes U and L.
16584 2001-12-15 Miguel de Icaza <miguel@ximian.com>
16586 * expression.cs (ArrayCreation.DoResolve): We need to do the
16587 argument resolution *always*.
16589 * decl.cs: Make this hold the namespace. Hold the root context as
16591 (LookupType): Move here.
16593 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
16595 * location.cs (Row, Name): Fixed the code, it was always returning
16596 references to the first file.
16598 * interface.cs: Register properties defined through interfaces.
16600 * driver.cs: Add support for globbing on the command line
16602 * class.cs (Field): Make it derive from MemberCore as well.
16605 2001-12-15 Ravi Pratap <ravi@ximian.com>
16607 * class.cs (Event::Define): Check that the type of the event is a delegate
16608 type else flag error #66.
16610 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
16613 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
16614 values of EntryPoint, CharSet etc etc.
16616 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
16618 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
16619 be null and we should ignore this. I am not sure if this is really clean. Apparently,
16620 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
16621 which needs this to do its work.
16623 * ../errors/cs0066.cs : Add.
16625 2001-12-14 Miguel de Icaza <miguel@ximian.com>
16627 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
16630 * class.cs: (MethodSignature.MethodSignature): Removed hack that
16631 clears out the parameters field.
16632 (MemberSignatureCompare): Cleanup
16634 (MemberCore): New base class used to share code between MethodCore
16637 (RegisterRequiredImplementations) BindingFlags.Public requires
16638 either BindingFlags.Instace or Static. Use instance here.
16640 (Property): Refactored code to cope better with the full spec.
16642 * parameter.cs (GetParameterInfo): Return an empty array instead
16645 * class.cs (Property): Abstract or extern properties have no bodies.
16647 * parameter.cs (GetParameterInfo): return a zero-sized array.
16649 * class.cs (TypeContainer.MethodModifiersValid): Move all the
16650 method modifier validation to the typecontainer so we can reuse
16651 this on properties.
16653 (MethodCore.ParameterTypes): return an empty sized array of types.
16655 (Property.Define): Test property modifier validity.
16657 Add tests for sealed/override too.
16659 (Method.Emit): abstract or extern methods have no bodies.
16661 2001-12-14 Ravi Pratap <ravi@ximian.com>
16663 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
16666 (Method::Define, ::Emit): Modify accordingly.
16668 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
16670 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
16672 * makefile: Pass in /unsafe.
16674 2001-12-13 Miguel de Icaza <miguel@ximian.com>
16676 * class.cs (MakeKey): Kill routine.
16678 * class.cs (TypeContainer.Define): Correctly define explicit
16679 method implementations (they require the full interface name plus
16682 * typemanager.cs: Deply the PtrHashtable here and stop using the
16683 lame keys. Things work so much better.
16685 This of course broke everyone who depended on `RegisterMethod' to
16686 do the `test for existance' test. This has to be done elsewhere.
16688 * support.cs (PtrHashtable): A hashtable that avoid comparing with
16689 the object stupid Equals method (because, that like fails all over
16690 the place). We still do not use it.
16692 * class.cs (TypeContainer.SetRequiredInterface,
16693 TypeContainer.RequireMethods): Killed these two routines and moved
16694 all the functionality to RegisterRequiredImplementations.
16696 (TypeContainer.RegisterRequiredImplementations): This routine now
16697 registers all the implementations required in an array for the
16698 interfaces and abstract methods. We use an array of structures
16699 which can be computed ahead of time to reduce memory usage and we
16700 also assume that lookups are cheap as most classes will not
16701 implement too many interfaces.
16703 We also avoid creating too many MethodSignatures.
16705 (TypeContainer.IsInterfaceMethod): Update and optionally does not
16706 clear the "pending" bit if we find that there are problems with
16709 (TypeContainer.VerifyPendingMethods): Update to report errors of
16710 methods that look like implementations but are not.
16712 (TypeContainer.Define): Add support for explicit interface method
16715 2001-12-12 Miguel de Icaza <miguel@ximian.com>
16717 * typemanager.cs: Keep track of the parameters here instead of
16718 being a feature of the TypeContainer.
16720 * class.cs: Drop the registration of parameters here, as
16721 InterfaceMethods are also interface declarations.
16723 * delegate.cs: Register methods with the TypeManager not only with
16724 the TypeContainer. This code was buggy.
16726 * interface.cs: Full registation here.
16728 2001-12-11 Miguel de Icaza <miguel@ximian.com>
16730 * expression.cs: Remove reducer for binary expressions, it can not
16733 * const.cs: Put here the code that used to go into constant.cs
16735 * constant.cs: Put here the code for constants, this is a new base
16736 class for Literals.
16738 * literal.cs: Make Literal derive from Constant.
16740 2001-12-09 Miguel de Icaza <miguel@ximian.com>
16742 * statement.cs (Return.Emit): Report error 157 if the user
16743 attempts to return from a finally block.
16745 (Return.Emit): Instead of emitting a return, jump to the end of
16748 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
16749 LocalBuilder to store the result of the function. ReturnLabel is
16750 the target where we jump.
16753 2001-12-09 Radek Doulik <rodo@ximian.com>
16755 * cs-parser.jay: remember alias in current namespace
16757 * ecore.cs (SimpleName::DoResolve): use aliases for types or
16760 * class.cs (LookupAlias): lookup alias in my_namespace
16762 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
16764 (LookupAlias): lookup alias in this and if needed in parent
16767 2001-12-08 Miguel de Icaza <miguel@ximian.com>
16771 * rootcontext.cs: (ModuleBuilder) Made static, first step into
16772 making things static. I need this to avoid passing the
16773 TypeContainer when calling ParameterType.
16775 * support.cs (InternalParameters.ParameterType): Remove ugly hack
16776 that did string manipulation to compute the type and then call
16777 GetType. Use Parameter.ParameterType instead.
16779 * cs-tokenizer.cs: Consume the suffix for floating values.
16781 * expression.cs (ParameterReference): figure out whether this is a
16782 reference parameter or not. Kill an extra variable by computing
16783 the arg_idx during emission.
16785 * parameter.cs (Parameters.GetParameterInfo): New overloaded
16786 function that returns whether a parameter is an out/ref value or not.
16788 (Parameter.ParameterType): The type of the parameter (base,
16789 without ref/out applied).
16791 (Parameter.Resolve): Perform resolution here.
16792 (Parameter.ExternalType): The full type (with ref/out applied).
16794 * statement.cs (Using.Emit, Using.EmitExpression): Implement
16795 support for expressions on the using statement.
16797 2001-12-07 Miguel de Icaza <miguel@ximian.com>
16799 * statement.cs (Using.EmitLocalVariableDecls): Split the
16800 localvariable handling of the using statement.
16802 (Block.EmitMeta): Keep track of variable count across blocks. We
16803 were reusing slots on separate branches of blocks.
16805 (Try.Emit): Emit the general code block, we were not emitting it.
16807 Check the type of the declaration to be an IDisposable or
16808 something that can be implicity converted to it.
16810 Emit conversions if required.
16812 * ecore.cs (EmptyExpression): New utility class.
16813 (Expression.ImplicitConversionExists): New utility function.
16815 2001-12-06 Miguel de Icaza <miguel@ximian.com>
16817 * statement.cs (Using): Implement.
16819 * expression.cs (LocalVariableReference): Support read only variables.
16821 * statement.cs: Remove the explicit emit for the Leave opcode.
16822 (VariableInfo): Add a readonly field.
16824 2001-12-05 Miguel de Icaza <miguel@ximian.com>
16826 * ecore.cs (ConvCast): new class used to encapsulate the various
16827 explicit integer conversions that works in both checked and
16828 unchecked contexts.
16830 (Expression.ConvertNumericExplicit): Use new ConvCast class to
16831 properly generate the overflow opcodes.
16833 2001-12-04 Miguel de Icaza <miguel@ximian.com>
16835 * statement.cs: The correct type for the EmptyExpression is the
16836 element_type, not the variable type. Ravi pointed this out.
16838 2001-12-04 Ravi Pratap <ravi@ximian.com>
16840 * class.cs (Method::Define): Handle PInvoke methods specially
16841 by using DefinePInvokeMethod instead of the usual one.
16843 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
16844 above to do the task of extracting information and defining the method.
16846 2001-12-04 Ravi Pratap <ravi@ximian.com>
16848 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
16849 of the condition for string type.
16851 (Emit): Move that here.
16853 (ArrayCreation::CheckIndices): Keep string literals in their expression
16856 (EmitDynamicInitializers): Handle strings appropriately.
16858 2001-12-04 Miguel de Icaza <miguel@ximian.com>
16860 * codegen.cs (EmitContext): Replace multiple variables with a
16861 single pointer to the current Switch statement.
16863 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
16866 2001-12-03 Miguel de Icaza <miguel@ximian.com>
16870 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
16873 (Foreach.Emit): Foreach on arrays was not setting
16874 up the loop variables (for break/continue).
16876 (GotoCase): Semi-implented.
16878 2001-12-03 Ravi Pratap <ravi@ximian.com>
16880 * attribute.cs (CheckAttribute): Handle system attributes by using
16881 Attribute.GetAttributes to examine information we need.
16883 (GetValidPlaces): Same here.
16885 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
16887 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
16889 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
16891 (Method::Define): Set appropriate flags if we have a DllImport attribute.
16893 (Method::Emit): Handle the case when we are a PInvoke method.
16895 2001-12-03 Miguel de Icaza <miguel@ximian.com>
16897 * expression.cs: Use ResolveWithSimpleName on compound names.
16899 2001-12-02 Ravi Pratap <ravi@ximian.com>
16901 * constant.cs (EmitConstant): Make sure we resolve the associated expression
16902 before trying to reduce it.
16904 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
16906 * constant.cs (LookupConstantValue): Implement.
16908 (EmitConstant): Use the above in emitting the constant.
16910 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
16911 that are user-defined by doing a LookupConstantValue on them.
16913 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
16916 2001-11-29 Miguel de Icaza <miguel@ximian.com>
16918 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
16920 (BaseAccess.DoResolve): Implement.
16922 (MemberAccess.DoResolve): Split this routine into a
16923 ResolveMemberAccess routine that can be used independently
16925 2001-11-28 Miguel de Icaza <miguel@ximian.com>
16927 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
16928 As that share bits of the implementation. Is returns a boolean,
16929 while As returns the Type that is being probed.
16931 2001-12-01 Ravi Pratap <ravi@ximian.com>
16933 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
16934 instead of a Literal - much easier.
16936 (EnumInTransit): Remove - utterly useless :-)
16938 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
16940 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
16942 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
16943 chain when we have no associated expression.
16945 2001-11-30 Ravi Pratap <ravi@ximian.com>
16947 * constant.cs (Define): Use Location while reporting the errror.
16949 Also emit a warning when 'new' is used and there is no inherited
16952 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
16955 (LookupEnumValue): Implement to lookup an enum member's value and define it
16958 (Populate): Re-write accordingly to use the above routine.
16960 2001-11-27 Miguel de Icaza <miguel@ximian.com>
16962 * expression.cs (This): Fix prototype for DoResolveLValue to
16963 override the base class DoResolveLValue.
16965 * cs-parser.cs: Report errors cs574 and cs575 (destructor
16968 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
16969 (we need to load the address of the field here). This fixes
16972 (FieldExpr.DoResolveLValue): Call the DoResolve
16973 function to initialize the Instance expression.
16975 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
16976 correctly the GetEnumerator operation on a value type.
16978 * cs-parser.jay: Add more simple parsing error catches.
16980 * statement.cs (Switch): Add support for string switches.
16981 Handle null specially.
16983 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
16985 2001-11-28 Ravi Pratap <ravi@ximian.com>
16987 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
16989 (declare_local_constant): New helper function.
16991 * statement.cs (AddConstant): Keep a separate record of constants
16993 (IsConstant): Implement to determine if a variable is a constant.
16995 (GetConstantExpression): Implement.
16997 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
16999 * statement.cs (IsVariableDefined): Re-write.
17001 2001-11-27 Ravi Pratap <ravi@ximian.com>
17003 * class.cs (TypeContainer::FindMembers): Look for constants
17004 in the case when we are looking for MemberTypes.Field
17006 * expression.cs (MemberAccess::DoResolve): Check that in the
17007 case we are a FieldExpr and a Literal, we are not being accessed
17008 by an instance reference.
17010 * cs-parser.jay (local_constant_declaration): Implement.
17012 (declaration_statement): Implement for constant declarations.
17014 2001-11-26 Miguel de Icaza <miguel@ximian.com>
17016 * statement.cs (Switch): Catch double defaults.
17018 (Switch): More work on the switch() statement
17019 implementation. It works for integral values now, need to finish
17023 2001-11-24 Miguel de Icaza <miguel@ximian.com>
17025 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
17026 integer literals into other integer literals. To be used by
17029 2001-11-24 Ravi Pratap <ravi@ximian.com>
17031 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
17034 (EmitDynamicInitializers): Cope with the above since we extract data
17035 directly from ArrayData now.
17037 (ExpectInitializers): Keep track of whether initializers are mandatory
17040 (Bounds): Make it a hashtable to prevent the same dimension being
17041 recorded for every element in that dimension.
17043 (EmitDynamicInitializers): Fix bug which prevented the Set array method
17046 Also fix bug which was causing the indices to be emitted in the reverse
17049 2001-11-24 Miguel de Icaza <miguel@ximian.com>
17051 * expression.cs (ArrayCreation): Implement the bits that Ravi left
17052 unfinished. They do not work, because the underlying code is
17055 2001-11-22 Miguel de Icaza <miguel@ximian.com>
17057 * cs-parser.jay: Remove bogus fixme.
17059 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
17060 on Switch statement.
17062 2001-11-23 Ravi Pratap <ravi@ximian.com>
17064 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
17067 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
17068 parameter. Apparently, any expression is allowed.
17070 (ValidateInitializers): Update accordingly.
17072 (CheckIndices): Fix some tricky bugs thanks to recursion.
17074 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
17075 I was being completely brain-dead.
17077 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
17078 and re-write acordingly.
17080 (DelegateInvocation): Re-write accordingly.
17082 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
17084 (MakeByteBlob): Handle types more correctly.
17086 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
17087 initialization from expressions but it is incomplete because I am a complete
17090 2001-11-22 Miguel de Icaza <miguel@ximian.com>
17092 * statement.cs (If.Emit): Fix a bug that generated incorrect code
17093 on If. Basically, we have to return `true' (ie, we do return to
17094 our caller) only if both branches of the if return.
17096 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
17097 short-circuit operators, handle them as short circuit operators.
17099 (Cast.DoResolve): Resolve type.
17100 (Cast.Cast): Take an expression as the target type.
17102 * cs-parser.jay (cast_expression): Remove old hack that only
17103 allowed a limited set of types to be handled. Now we take a
17104 unary_expression and we resolve to a type during semantic
17107 Use the grammar productions from Rhys to handle casts (this is
17108 not complete like Rhys syntax yet, we fail to handle that corner
17109 case that C# has regarding (-x), but we will get there.
17111 2001-11-22 Ravi Pratap <ravi@ximian.com>
17113 * class.cs (EmitFieldInitializer): Take care of the case when we have a
17114 field which is an array type.
17116 * cs-parser.jay (declare_local_variables): Support array initialization too.
17118 * typemanager.cs (MakeKey): Implement.
17120 (everywhere): Use the above appropriately.
17122 * cs-parser.jay (for_statement): Update for array initialization while
17123 declaring variables.
17125 * ecore.cs : The error message was correct, it's the variable's names that
17126 were misleading ;-) Make the code more readable.
17128 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
17129 the correct type etc.
17131 (ConvertExplicit): Handle Enum types by examining the underlying type.
17133 2001-11-21 Ravi Pratap <ravi@ximian.com>
17135 * parameter.cs (GetCallingConvention): Always return
17136 CallingConventions.Standard for now.
17138 2001-11-22 Miguel de Icaza <miguel@ximian.com>
17140 * expression.cs (Binary.ResolveOperator): Update the values of `l'
17141 and `r' after calling DoNumericPromotions.
17143 * ecore.cs: Fix error message (the types were in the wrong order).
17145 * statement.cs (Foreach.ProbeCollectionType): Need to pass
17146 BindingFlags.Instance as well
17148 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
17149 implicit int literal conversion in an empty cast so that we
17150 propagate the right type upstream.
17152 (UnboxCast): new class used to unbox value types.
17153 (Expression.ConvertExplicit): Add explicit type conversions done
17156 (Expression.ImplicitNumericConversion): Oops, forgot to test for
17157 the target type before applying the implicit LongLiterals to ULong
17160 2001-11-21 Miguel de Icaza <miguel@ximian.com>
17162 * cs-parser.jay (for_statement): Reworked the way For works: now
17163 we declare manually any variables that are introduced in
17164 for_initializer to solve the problem of having out-of-band code
17165 emition (that is what got for broken).
17167 (declaration_statement): Perform the actual variable declaration
17168 that used to be done in local_variable_declaration here.
17170 (local_variable_declaration): Do not declare anything, just pass
17171 the information on a DictionaryEntry
17173 2001-11-20 Ravi Pratap <ravi@ximian.com>
17175 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
17176 re-write of the logic to now make it recursive.
17178 (UpdateIndices): Re-write accordingly.
17180 Store element data in a separate ArrayData list in the above methods.
17182 (MakeByteBlob): Implement to dump the array data into a byte array.
17184 2001-11-19 Ravi Pratap <ravi@ximian.com>
17186 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
17189 * constant.cs (Define): Implement.
17191 (EmitConstant): Re-write fully.
17193 Pass in location info.
17195 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
17198 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
17199 DictionaryEntry since we need location info too.
17201 (constant_declaration): Update accordingly.
17203 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
17204 code into another method : UpdateIndices.
17206 2001-11-18 Ravi Pratap <ravi@ximian.com>
17208 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
17209 some type checking etc.
17211 2001-11-17 Ravi Pratap <ravi@ximian.com>
17213 * expression.cs (ArrayCreation::ValidateInitializers): Implement
17214 bits to provide dimension info if the user skips doing that.
17216 Update second constructor to store the rank correctly.
17218 2001-11-16 Ravi Pratap <ravi@ximian.com>
17220 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
17221 and try to implement.
17223 * ../errors/cs0150.cs : Add.
17225 * ../errors/cs0178.cs : Add.
17227 2001-11-16 Miguel de Icaza <miguel@ximian.com>
17229 * statement.cs: Implement foreach on multi-dimensional arrays.
17231 * parameter.cs (Parameters.GetParameterByName): Also lookup the
17232 name of the params argument.
17234 * expression.cs: Use EmitStoreOpcode to get the right opcode while
17235 initializing the array.
17237 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
17238 we can use this elsewhere.
17240 * statement.cs: Finish implementation of foreach for single
17243 * cs-parser.jay: Use an out-of-band stack to pass information
17244 around, I wonder why I need this.
17246 foreach_block: Make the new foreach_block the current_block.
17248 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
17249 function used to return a static Parameters structure. Used for
17250 empty parameters, as those are created very frequently.
17252 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
17254 2001-11-15 Ravi Pratap <ravi@ximian.com>
17256 * interface.cs : Default modifier is private, not public. The
17257 make verify test passes again.
17259 2001-11-15 Ravi Pratap <ravi@ximian.com>
17261 * support.cs (ReflectionParameters): Fix logic to determine
17262 whether the last parameter is a params one. Test 9 passes again.
17264 * delegate.cs (Populate): Register the builders we define with
17265 RegisterParameterForBuilder. Test 19 passes again.
17267 * cs-parser.jay (property_declaration): Reference $6 instead
17268 of $$ to get at the location.
17270 (indexer_declaration): Similar stuff.
17272 (attribute): Ditto.
17274 * class.cs (Property): Register parameters for the Get and Set methods
17275 if they exist. Test 23 passes again.
17277 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
17278 call to EmitArguments as we are sure there aren't any params arguments.
17279 Test 32 passes again.
17281 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
17282 IndexOutOfRangeException.
17284 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
17285 Test 33 now passes again.
17287 2001-11-15 Miguel de Icaza <miguel@ximian.com>
17289 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
17290 broke a bunch of things. Will have to come up with a better way
17291 of tracking locations.
17293 * statement.cs: Implemented foreach for single dimension arrays.
17295 2001-11-09 Miguel de Icaza <miguel@ximian.com>
17297 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
17298 an error. This removes the lookup from the critical path.
17300 * cs-parser.jay: Removed use of temporary_loc, which is completely
17303 2001-11-14 Miguel de Icaza <miguel@ximian.com>
17305 * support.cs (ReflectionParameters.ParameterModifier): Report
17306 whether the argument is a PARAMS argument or not.
17308 * class.cs: Set the attribute `ParamArrayAttribute' on the
17309 parameter argument.
17311 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
17312 and cons_param_array_attribute (ConstructorInfo for
17313 ParamArrayAttribute).,
17315 * codegen.cs: Emit the return using the `Return' statement, that
17316 way we can report the error correctly for missing return values.
17318 * class.cs (Method.Emit): Clean up.
17320 * expression.cs (Argument.Resolve): Take another argument: the
17321 location where this argument is used. Notice that this is not
17322 part of the "Argument" class as to reduce the size of the
17323 structure (we know the approximate location anyways).
17325 Test if the argument is a variable-reference, if not, then
17326 complain with a 206.
17328 (Argument.Emit): Emit addresses of variables.
17330 (Argument.FullDesc): Simplify.
17332 (Invocation.DoResolve): Update for Argument.Resolve.
17334 (ElementAccess.DoResolve): ditto.
17336 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
17337 method should be virtual, as this method is always virtual.
17339 (NewDelegate.DoResolve): Update for Argument.Resolve.
17341 * class.cs (ConstructorInitializer.DoResolve): ditto.
17343 * attribute.cs (Attribute.Resolve): ditto.
17345 2001-11-13 Miguel de Icaza <miguel@ximian.com>
17347 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
17349 * expression.cs (ParameterReference): Drop IStackStorage and implement
17350 IAssignMethod instead.
17352 (LocalVariableReference): ditto.
17354 * ecore.cs (FieldExpr): Drop IStackStorage and implement
17355 IAssignMethod instead.
17357 2001-11-13 Miguel de Icaza <miguel@ximian.com>
17359 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
17360 enumerations that are used in heavily used structures derive from
17361 byte in a laughable and pathetic attempt to reduce memory usage.
17362 This is the kind of pre-optimzations that you should not do at
17363 home without adult supervision.
17365 * expression.cs (UnaryMutator): New class, used to handle ++ and
17366 -- separatedly from the other unary operators. Cleans up the
17367 code, and kills the ExpressionStatement dependency in Unary.
17369 (Unary): Removed `method' and `Arguments' from this class, making
17370 it smaller, and moving it all to SimpleCall, so I can reuse this
17371 code in other locations and avoid creating a lot of transient data
17372 strucutres when not required.
17374 * cs-parser.jay: Adjust for new changes.
17376 2001-11-11 Miguel de Icaza <miguel@ximian.com>
17378 * enum.cs (Enum.Populate): If there is a failure during
17381 * cs-parser.jay (opt_enum_base): we used to catch type errors
17382 here, but this is really incorrect. The type error should be
17383 catched during semantic analysis.
17385 2001-12-11 Ravi Pratap <ravi@ximian.com>
17387 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
17388 current_local_parameters as expected since I, in my stupidity, had forgotten
17391 * attribute.cs (GetValidPlaces): Fix stupid bug.
17393 * class.cs (Method::Emit): Perform check on applicability of attributes.
17395 (Constructor::Emit): Ditto.
17397 (Field::Emit): Ditto.
17399 (Field.Location): Store location information.
17401 (Property, Event, Indexer, Operator): Ditto.
17403 * cs-parser.jay (field_declaration): Pass in location for each field.
17405 * ../errors/cs0592.cs : Add.
17407 2001-11-12 Ravi Pratap <ravi@ximian.com>
17409 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
17411 (InitCoreTypes): Update accordingly.
17413 (RegisterAttrType, LookupAttr): Implement.
17415 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
17416 info about the same.
17418 (Resolve): Update to populate the above as necessary.
17420 (Error592): Helper.
17422 (GetValidPlaces): Helper to the above.
17424 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
17426 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
17428 2001-11-12 Ravi Pratap <ravi@ximian.com>
17430 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
17432 * ../errors/cs0617.cs : Add.
17434 2001-11-11 Ravi Pratap <ravi@ximian.com>
17436 * enum.cs (Emit): Rename to Populate to be more consistent with what
17437 we expect it to do and when exactly it is called.
17439 * class.cs, rootcontext.cs : Update accordingly.
17441 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
17442 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
17444 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
17446 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
17447 of a fieldinfo using the above, when dealing with a FieldBuilder.
17449 2001-11-10 Ravi Pratap <ravi@ximian.com>
17451 * ../errors/cs0031.cs : Add.
17453 * ../errors/cs1008.cs : Add.
17455 * ../errrors/cs0543.cs : Add.
17457 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
17460 (FindMembers): Implement.
17462 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
17463 enums and delegates too.
17465 (enum_types): Rename to builder_to_enum.
17467 (delegate_types): Rename to builder_to_delegate.
17469 * delegate.cs (FindMembers): Implement.
17471 2001-11-09 Ravi Pratap <ravi@ximian.com>
17473 * typemanager.cs (IsEnumType): Implement.
17475 * enum.cs (Emit): Re-write parts to account for the underlying type
17476 better and perform checking etc.
17478 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
17479 of the underlying type.
17481 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
17484 * enum.cs (error31): Helper to report error #31.
17486 * cs-parser.jay (enum_declaration): Store location of each member too.
17488 * enum.cs (member_to_location): New hashtable.
17490 (AddEnumMember): Update location hashtable.
17492 (Emit): Use the location of each member while reporting errors.
17494 2001-11-09 Miguel de Icaza <miguel@ximian.com>
17496 * cs-parser.jay: A for_initializer if is a
17497 local_variable_declaration really ammount to have an implicit
17498 block with the variable declaration and no initializer for for.
17500 * statement.cs (For.Emit): Cope with null initializers.
17502 This fixes the infinite loop on for initializers.
17504 2001-11-08 Miguel de Icaza <miguel@ximian.com>
17506 * enum.cs: More cleanup.
17508 * ecore.cs: Remove dead code.
17510 * class.cs (Property.Emit): More simplification.
17511 (Event.Emit): ditto.
17513 Reworked to have less levels of indentation.
17515 2001-11-08 Ravi Pratap <ravi@ximian.com>
17517 * class.cs (Property): Emit attributes.
17527 * enum.cs (Emit): Ditto.
17529 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
17532 * class.cs (Field, Event, etc.): Move attribute generation into the
17533 Emit method everywhere.
17535 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
17536 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
17537 as we had no way of defining nested enums !
17539 * rootcontext.cs : Adjust code accordingly.
17541 * typemanager.cs (AddEnumType): To keep track of enum types separately.
17543 2001-11-07 Ravi Pratap <ravi@ximian.com>
17545 * expression.cs (EvalConstantExpression): Move into ecore.cs
17547 * enum.cs (Enum): Rename some members and make them public and readonly
17548 according to our convention.
17550 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
17553 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
17555 (Enum::Emit): Write a simple version for now which doesn't try to compute
17556 expressions. I shall modify this to be more robust in just a while.
17558 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
17560 (TypeContainer::CloseType): Create the Enum types too.
17562 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
17564 * expression.cs (EvalConstantExpression): Get rid of completely.
17566 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
17567 user-defined values and other cases.
17569 (IsValidEnumLiteral): Helper function.
17571 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
17572 out there in the case we had a literal FieldExpr.
17574 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
17576 (Literalize): Revamp a bit to take two arguments.
17578 (EnumLiteral): New class which derives from Literal to wrap enum literals.
17580 2001-11-06 Ravi Pratap <ravi@ximian.com>
17582 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
17584 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
17586 (Resolve): Use the above to ensure we have proper initializers.
17588 2001-11-05 Ravi Pratap <ravi@ximian.com>
17590 * expression.cs (Expression::EvalConstantExpression): New method to
17591 evaluate constant expressions.
17593 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
17595 2001-11-07 Miguel de Icaza <miguel@ximian.com>
17597 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
17600 (Binary.ResolveOperator): Handle operator != (object a, object b)
17601 and operator == (object a, object b);
17603 (Binary.DoNumericPromotions): Indicate whether the numeric
17604 promotion was possible.
17606 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
17609 Made the ArrayAccess implement interface IAssignMethod instead of
17610 IStackStore as the order in which arguments are passed reflects
17613 * assign.cs: Instead of using expr.ExprClass to select the way of
17614 assinging, probe for the IStackStore/IAssignMethod interfaces.
17616 * typemanager.cs: Load InitializeArray definition.
17618 * rootcontext.cs (RootContext.MakeStaticData): Used to define
17619 static data that can be used to initialize arrays.
17621 2001-11-05 Miguel de Icaza <miguel@ximian.com>
17623 * expression.cs: Handle operator== and operator!= for booleans.
17625 (Conditioal.Reduce): Implement reducer for the ?: operator.
17627 (Conditional.Resolve): Implement dead code elimination.
17629 (Binary.Resolve): Catch string literals and return a new
17630 concatenated string.
17632 (Unary.Reduce): Implement reduction of unary expressions.
17634 * ecore.cs: Split out the expression core handling here.
17636 (Expression.Reduce): New method used to perform constant folding
17637 and CSE. This is needed to support constant-expressions.
17639 * statement.cs (Statement.EmitBoolExpression): Pass true and false
17640 targets, and optimize for !x.
17642 2001-11-04 Ravi Pratap <ravi@ximian.com>
17644 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
17645 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
17646 set custom atttributes.
17648 * literal.cs (Literal::GetValue): New abstract method to return the actual
17649 value of the literal, cast as an object.
17651 (*Literal): Implement GetValue method.
17653 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
17654 expressions to the arraylist but objects of type Argument.
17656 * class.cs (TypeContainer::Emit): Emit our attributes too.
17658 (Method::Emit, Constructor::Emit): Ditto.
17660 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
17661 to be ignoring earlier.
17663 2001-11-03 Ravi Pratap <ravi@ximian.com>
17665 * attribute.cs (AttributeSection::Define): Implement to do the business
17666 of constructing a CustomAttributeBuilder.
17668 (Attribute): New trivial class. Increases readability of code.
17670 * cs-parser.jay : Update accordingly.
17672 (positional_argument_list, named_argument_list, named_argument): New rules
17674 (attribute_arguments): Use the above so that we are more correct.
17676 2001-11-02 Ravi Pratap <ravi@ximian.com>
17678 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
17679 to perform all checks for a method with a params parameter.
17681 (Invocation::OverloadResolve): Update to use the above method and therefore
17682 cope correctly with params method invocations.
17684 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
17687 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
17688 constructors in our parent too because we can't afford to miss out on
17691 * attribute.cs (AttributeSection): New name for the class Attribute
17693 Other trivial changes to improve readability.
17695 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
17696 use the new class names.
17698 2001-11-01 Ravi Pratap <ravi@ximian.com>
17700 * class.cs (Method::Define): Complete definition for params types too
17702 (Indexer::Define): Ditto.
17704 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
17705 Cope everywhere with a request for info about the array parameter.
17707 2001-11-01 Ravi Pratap <ravi@ximian.com>
17709 * tree.cs (RecordNamespace): Fix up to check for the correct key.
17711 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
17712 local_variable_type to extract the string corresponding to the type.
17714 (local_variable_type): Fixup the action to use the new helper method.
17716 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
17719 * expression.cs : Clean out code which uses the above.
17721 2001-10-31 Ravi Pratap <ravi@ximian.com>
17723 * typemanager.cs (RegisterMethod): Check if we already have an existing key
17724 and bale out if necessary by returning a false.
17726 (RegisterProperty): Ditto.
17728 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
17729 and print out appropriate error messages.
17731 * interface.cs (everywhere): Ditto.
17733 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
17734 location to constructor.
17736 * class.cs (Property, Event, Indexer): Update accordingly.
17738 * ../errors/cs111.cs : Added.
17740 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
17741 of a method, as laid down by the spec.
17743 (Invocation::OverloadResolve): Use the above method.
17745 2001-10-31 Ravi Pratap <ravi@ximian.com>
17747 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
17748 now take a TypeContainer and a Parameters object.
17750 (ParameterData): Modify return type of ParameterModifier method to be
17751 Parameter.Modifier and not a string.
17753 (ReflectionParameters, InternalParameters): Update accordingly.
17755 * expression.cs (Argument::GetParameterModifier): Same here.
17757 * support.cs (InternalParameters::ParameterType): Find a better way of determining
17758 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
17759 symbol in it at all so maybe this is only for now.
17761 2001-10-30 Ravi Pratap <ravi@ximian.com>
17763 * support.cs (InternalParameters): Constructor now takes an extra argument
17764 which is the actual Parameters class.
17766 (ParameterDesc): Update to provide info on ref/out modifiers.
17768 * class.cs (everywhere): Update call to InternalParameters to pass in
17769 the second argument too.
17771 * support.cs (ParameterData): Add ParameterModifier, which is a method
17772 to return the modifier info [ref/out etc]
17774 (InternalParameters, ReflectionParameters): Implement the above.
17776 * expression.cs (Argument::ParameterModifier): Similar function to return
17777 info about the argument's modifiers.
17779 (Invocation::OverloadResolve): Update to take into account matching modifiers
17782 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
17783 a new SetFormalParameters object which we pass to InternalParameters.
17785 2001-10-30 Ravi Pratap <ravi@ximian.com>
17787 * expression.cs (NewArray): Merge into the ArrayCreation class.
17789 2001-10-29 Ravi Pratap <ravi@ximian.com>
17791 * expression.cs (NewArray): Merge classes NewBuiltinArray and
17792 NewUserdefinedArray into one as there wasn't much of a use in having
17795 * expression.cs (Argument): Change field's name to ArgType from Type.
17797 (Type): New readonly property which returns the proper type, taking into
17798 account ref/out modifiers.
17800 (everywhere): Adjust code accordingly for the above.
17802 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
17803 whether we are emitting for a ref or out parameter.
17805 * expression.cs (Argument::Emit): Use the above field to set the state.
17807 (LocalVariableReference::Emit): Update to honour the flag and emit the
17810 * parameter.cs (Attributes): Set the correct flags for ref parameters.
17812 * expression.cs (Argument::FullDesc): New function to provide a full desc.
17814 * support.cs (ParameterData): Add method ParameterDesc to the interface.
17816 (ReflectionParameters, InternalParameters): Implement the above method.
17818 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
17821 (Invocation::FullMethodDesc): Ditto.
17823 2001-10-29 Miguel de Icaza <miguel@ximian.com>
17825 * cs-parser.jay: Add extra production for the second form of array
17828 * expression.cs (ArrayCreation): Update to reflect the above
17831 * Small changes to prepare for Array initialization.
17833 2001-10-28 Miguel de Icaza <miguel@ximian.com>
17835 * typemanager.cs (ImplementsInterface): interface might be null;
17836 Deal with this problem;
17838 Also, we do store negative hits on the cache (null values), so use
17839 this instead of calling t.GetInterfaces on the type everytime.
17841 2001-10-28 Ravi Pratap <ravi@ximian.com>
17843 * typemanager.cs (IsBuiltinType): New method to help determine the same.
17845 * expression.cs (New::DoResolve): Get rid of array creation code and instead
17846 split functionality out into different classes.
17848 (New::FormArrayType): Move into NewBuiltinArray.
17850 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
17853 (NewBuiltinArray): New class to handle creation of built-in arrays.
17855 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
17856 account creation of one-dimensional arrays.
17858 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
17860 (NewUserdefinedArray::DoResolve): Implement.
17862 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
17864 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
17865 we maintain inside the TypeManager. This is necessary to perform lookups on the
17868 (LookupType): Update to perform GetType on the module builders too.
17870 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
17872 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
17874 2001-10-23 Ravi Pratap <ravi@ximian.com>
17876 * expression.cs (New::DoResolve): Implement guts of array creation.
17878 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
17880 2001-10-27 Miguel de Icaza <miguel@ximian.com>
17882 * expression.cs: Fix bug I introduced lsat night that broke
17885 (Expression.Resolve): Report a 246 error (can not resolve name)
17886 if we find a SimpleName in the stream.
17888 (Expression.ResolveLValue): Ditto.
17890 (Expression.ResolveWithSimpleName): This function is a variant of
17891 ResolveName, this one allows SimpleNames to be returned without a
17892 warning. The only consumer of SimpleNames is MemberAccess
17894 2001-10-26 Miguel de Icaza <miguel@ximian.com>
17896 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
17897 might arrive here. I have my doubts that this is correct.
17899 * statement.cs (Lock): Implement lock statement.
17901 * cs-parser.jay: Small fixes to support `lock' and `using'
17903 * cs-tokenizer.cs: Remove extra space
17905 * driver.cs: New flag --checked, allows to turn on integer math
17908 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
17909 Threading.Monitor.Exit
17911 2001-10-23 Miguel de Icaza <miguel@ximian.com>
17913 * expression.cs (IndexerAccess::DoResolveLValue): Set the
17914 Expression Class to be IndexerAccess.
17916 Notice that Indexer::DoResolve sets the eclass to Value.
17918 2001-10-22 Miguel de Icaza <miguel@ximian.com>
17920 * class.cs (TypeContainer::Emit): Emit code for indexers.
17922 * assign.cs (IAssignMethod): New interface implemented by Indexers
17923 and Properties for handling assignment.
17925 (Assign::Emit): Simplify and reuse code.
17927 * expression.cs (IndexerAccess, PropertyExpr): Implement
17928 IAssignMethod, clean up old code.
17930 2001-10-22 Ravi Pratap <ravi@ximian.com>
17932 * typemanager.cs (ImplementsInterface): New method to determine if a type
17933 implements a given interface. Provides a nice cache too.
17935 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
17938 (ConvertReferenceExplicit): Ditto.
17940 * delegate.cs (Delegate::Populate): Update to define the parameters on the
17941 various methods, with correct names etc.
17943 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
17944 Operator.UnaryNegation.
17946 * cs-parser.jay (operator_declarator): Be a little clever in the case where
17947 we have a unary plus or minus operator.
17949 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
17952 * everywhere : update accordingly.
17954 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
17957 * class.cs (Method::Define): For the case where we are implementing a method
17958 inherited from an interface, we need to set the MethodAttributes.Final flag too.
17959 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
17961 2001-10-21 Ravi Pratap <ravi@ximian.com>
17963 * interface.cs (FindMembers): Implement to work around S.R.E
17966 * typemanager.cs (IsInterfaceType): Implement.
17968 (FindMembers): Update to handle interface types too.
17970 * expression.cs (ImplicitReferenceConversion): Re-write bits which
17971 use IsAssignableFrom as that is not correct - it doesn't work.
17973 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
17974 and accordingly override EmitStatement.
17976 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
17977 using the correct logic :-)
17979 2001-10-19 Ravi Pratap <ravi@ximian.com>
17981 * ../errors/cs-11.cs : Add to demonstrate error -11
17983 2001-10-17 Miguel de Icaza <miguel@ximian.com>
17985 * assign.cs (Assign::Resolve): Resolve right hand side first, and
17986 then pass this as a hint to ResolveLValue.
17988 * expression.cs (FieldExpr): Add Location information
17990 (FieldExpr::LValueResolve): Report assignment to readonly
17993 (Expression::ExprClassFromMemberInfo): Pass location information.
17995 (Expression::ResolveLValue): Add new method that resolves an
17998 (Expression::DoResolveLValue): Default invocation calls
18001 (Indexers): New class used to keep track of indexers in a given
18004 (IStackStore): Renamed from LValue, as it did not really describe
18005 what this did. Also ResolveLValue is gone from this interface and
18006 now is part of Expression.
18008 (ElementAccess): Depending on the element access type
18010 * typemanager.cs: Add `indexer_name_type' as a Core type
18011 (System.Runtime.CompilerServices.IndexerNameAttribute)
18013 * statement.cs (Goto): Take a location.
18015 2001-10-18 Ravi Pratap <ravi@ximian.com>
18017 * delegate.cs (Delegate::VerifyDelegate): New method to verify
18018 if two delegates are compatible.
18020 (NewDelegate::DoResolve): Update to take care of the case when
18021 we instantiate a delegate from another delegate.
18023 * typemanager.cs (FindMembers): Don't even try to look up members
18024 of Delegate types for now.
18026 2001-10-18 Ravi Pratap <ravi@ximian.com>
18028 * delegate.cs (NewDelegate): New class to take care of delegate
18031 * expression.cs (New): Split the delegate related code out into
18032 the NewDelegate class.
18034 * delegate.cs (DelegateInvocation): New class to handle delegate
18037 * expression.cs (Invocation): Split out delegate related code into
18038 the DelegateInvocation class.
18040 2001-10-17 Ravi Pratap <ravi@ximian.com>
18042 * expression.cs (New::DoResolve): Implement delegate creation fully
18043 and according to the spec.
18045 (New::DoEmit): Update to handle delegates differently.
18047 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
18048 because of which we were printing out arguments in reverse order !
18050 * delegate.cs (VerifyMethod): Implement to check if the given method
18051 matches the delegate.
18053 (FullDelegateDesc): Implement.
18055 (VerifyApplicability): Implement.
18057 * expression.cs (Invocation::DoResolve): Update to accordingly handle
18058 delegate invocations too.
18060 (Invocation::Emit): Ditto.
18062 * ../errors/cs1593.cs : Added.
18064 * ../errors/cs1594.cs : Added.
18066 * delegate.cs (InstanceExpression, TargetMethod): New properties.
18068 2001-10-16 Ravi Pratap <ravi@ximian.com>
18070 * typemanager.cs (intptr_type): Core type for System.IntPtr
18072 (InitCoreTypes): Update for the same.
18074 (iasyncresult_type, asynccallback_type): Ditto.
18076 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
18079 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
18082 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
18083 the builders for the 4 members of a delegate type :-)
18085 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
18088 * expression.cs (New::DoResolve): Implement guts for delegate creation.
18090 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
18092 2001-10-15 Miguel de Icaza <miguel@ximian.com>
18094 * statement.cs (Break::Emit): Implement.
18095 (Continue::Emit): Implement.
18097 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
18098 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
18099 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
18100 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
18103 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
18104 properties that track the label for the current loop (begin of the
18105 loop and end of the loop).
18107 2001-10-15 Ravi Pratap <ravi@ximian.com>
18109 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
18110 use of emitting anything at all.
18112 * class.cs, rootcontext.cs : Get rid of calls to the same.
18114 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
18116 (Populate): Define the constructor correctly and set the implementation
18119 * typemanager.cs (delegate_types): New hashtable to hold delegates that
18122 (AddDelegateType): Implement.
18124 (IsDelegateType): Implement helper method.
18126 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
18128 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
18129 and accordingly handle it.
18131 * delegate.cs (Populate): Take TypeContainer argument.
18132 Implement bits to define the Invoke method. However, I still haven't figured out
18133 how to take care of the native int bit :-(
18135 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
18136 Qualify the name of the delegate, not its return type !
18138 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
18141 (StandardConversionExists): Checking for array types turns out to be recursive.
18143 (ConvertReferenceExplicit): Implement array conversion.
18145 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
18147 2001-10-12 Ravi Pratap <ravi@ximian.com>
18149 * cs-parser.jay (delegate_declaration): Store the fully qualified
18150 name as it is a type declaration.
18152 * delegate.cs (ReturnType, Name): Rename members to these. Make them
18155 (DefineDelegate): Renamed from Define. Does the same thing essentially,
18156 as TypeContainer::DefineType.
18158 (Populate): Method in which all the definition of the various methods (Invoke)
18161 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
18164 (CloseDelegate): Finally creates the delegate.
18166 * class.cs (TypeContainer::DefineType): Update to define delegates.
18167 (Populate, Emit and CloseType): Do the same thing here too.
18169 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
18170 delegates in all these operations.
18172 2001-10-14 Miguel de Icaza <miguel@ximian.com>
18174 * expression.cs: LocalTemporary: a new expression used to
18175 reference a temporary that has been created.
18177 * assign.cs: Handle PropertyAccess back here, so that we can
18178 provide the proper semantic access to properties.
18180 * expression.cs (Expression::ConvertReferenceExplicit): Implement
18181 a few more explicit conversions.
18183 * modifiers.cs: `NEW' modifier maps to HideBySig.
18185 * expression.cs (PropertyExpr): Make this into an
18186 ExpressionStatement, and support the EmitStatement code path.
18188 Perform get/set error checking, clean up the interface.
18190 * assign.cs: recognize PropertyExprs as targets, and if so, turn
18191 them into toplevel access objects.
18193 2001-10-12 Miguel de Icaza <miguel@ximian.com>
18195 * expression.cs: PropertyExpr::PropertyExpr: use work around the
18198 * typemanager.cs: Keep track here of our PropertyBuilders again to
18199 work around lameness in SRE.
18201 2001-10-11 Miguel de Icaza <miguel@ximian.com>
18203 * expression.cs (LValue::LValueResolve): New method in the
18204 interface, used to perform a second resolution pass for LValues.
18206 (This::DoResolve): Catch the use of this in static methods.
18208 (This::LValueResolve): Implement.
18210 (This::Store): Remove warning, assigning to `this' in structures
18213 (Invocation::Emit): Deal with invocation of
18214 methods on value types. We need to pass the address to structure
18215 methods rather than the object itself. (The equivalent code to
18216 emit "this" for structures leaves the entire structure on the
18217 stack instead of a pointer to it).
18219 (ParameterReference::DoResolve): Compute the real index for the
18220 argument based on whether the method takes or not a `this' pointer
18221 (ie, the method is static).
18223 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
18224 value types returned from functions when we need to invoke a
18225 method on the sturcture.
18228 2001-10-11 Ravi Pratap <ravi@ximian.com>
18230 * class.cs (TypeContainer::DefineType): Method to actually do the business of
18231 defining the type in the Modulebuilder or Typebuilder. This is to take
18232 care of nested types which need to be defined on the TypeBuilder using
18233 DefineNestedMethod.
18235 (TypeContainer::GetClassBases): Implement. Essentially the code from the
18236 methods in RootContext, only ported to be part of TypeContainer.
18238 (TypeContainer::GetInterfaceOrClass): Ditto.
18240 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
18242 * interface.cs (Interface::DefineInterface): New method. Does exactly
18243 what RootContext.CreateInterface did earlier, only it takes care of nested types
18246 (Interface::GetInterfaces): Move from RootContext here and port.
18248 (Interface::GetInterfaceByName): Same here.
18250 * rootcontext.cs (ResolveTree): Re-write.
18252 (PopulateTypes): Re-write.
18254 * class.cs (TypeContainer::Populate): Populate nested types too.
18255 (TypeContainer::Emit): Emit nested members too.
18257 * typemanager.cs (AddUserType): Do not make use of the FullName property,
18258 instead just use the name argument passed in as it is already fully
18261 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
18262 to TypeContainer mapping to see if a type is user-defined.
18264 * class.cs (TypeContainer::CloseType): Implement.
18266 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
18267 the default constructor.
18269 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
18272 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
18274 * interface.cs (CloseType): Create the type here.
18276 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
18279 Remove all the methods which are now in TypeContainer.
18281 2001-10-10 Ravi Pratap <ravi@ximian.com>
18283 * delegate.cs (Define): Re-write bits to define the delegate
18286 2001-10-10 Miguel de Icaza <miguel@ximian.com>
18288 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
18290 * expression.cs (ImplicitReferenceConversion): handle null as well
18291 as a source to convert to any reference type.
18293 * statement.cs (Return): Perform any implicit conversions to
18294 expected return type.
18296 Validate use of return statement.
18298 * codegen.cs (EmitContext): Pass the expected return type here.
18300 * class.cs (Method, Constructor, Property): Pass expected return
18301 type to EmitContext.
18303 2001-10-09 Miguel de Icaza <miguel@ximian.com>
18305 * expression.cs: Make DoResolve take an EmitContext instead of a
18308 Replaced `l' and `location' for `loc', for consistency.
18310 (Error, Warning): Remove unneeded Tc argument.
18312 * assign.cs, literal.cs, constant.cs: Update to new calling
18315 * codegen.cs: EmitContext now contains a flag indicating whether
18316 code is being generated in a static method or not.
18318 * cs-parser.jay: DecomposeQI, new function that replaces the old
18319 QualifiedIdentifier. Now we always decompose the assembled
18320 strings from qualified_identifier productions into a group of
18323 2001-10-08 Miguel de Icaza <miguel@ximian.com>
18325 * rootcontext.cs: Deal with field-less struct types correctly now
18326 by passing the size option to Define Type.
18328 * class.cs: Removed hack that created one static field.
18330 2001-10-07 Miguel de Icaza <miguel@ximian.com>
18332 * statement.cs: Moved most of the code generation here.
18334 2001-10-09 Ravi Pratap <ravi@ximian.com>
18336 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
18339 (ElementAccess): Remove useless bits for now - keep checks as the spec
18342 2001-10-08 Ravi Pratap <ravi@ximian.com>
18344 * expression.cs (ElementAccess::DoResolve): Remove my crap code
18345 and start performing checks according to the spec.
18347 2001-10-07 Ravi Pratap <ravi@ximian.com>
18349 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
18350 rank_specifiers instead.
18352 (rank_specifiers): Change the order in which the rank specifiers are stored
18354 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
18356 * expression.cs (ElementAccess): Implement the LValue interface too.
18358 2001-10-06 Ravi Pratap <ravi@ximian.com>
18360 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
18361 except that user defined conversions are not included.
18363 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
18364 perform the conversion of the return type, if necessary.
18366 (New::DoResolve): Check whether we are creating an array or an object
18367 and accordingly do the needful.
18369 (New::Emit): Same here.
18371 (New::DoResolve): Implement guts of array creation.
18373 (New::FormLookupType): Helper function.
18375 2001-10-07 Miguel de Icaza <miguel@ximian.com>
18377 * codegen.cs: Removed most of the code generation here, and move the
18378 corresponding code generation bits to the statement classes.
18380 Added support for try/catch/finalize and throw.
18382 * cs-parser.jay: Added support for try/catch/finalize.
18384 * class.cs: Catch static methods having the flags override,
18385 virtual or abstract.
18387 * expression.cs (UserCast): This user cast was not really doing
18388 what it was supposed to do. Which is to be born in fully resolved
18389 state. Parts of the resolution were being performed at Emit time!
18393 2001-10-05 Miguel de Icaza <miguel@ximian.com>
18395 * expression.cs: Implicity convert the result from UserCast.
18397 2001-10-05 Ravi Pratap <ravi@ximian.com>
18399 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
18400 prevented it from working correctly.
18402 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
18403 merely ConvertImplicit.
18405 2001-10-05 Miguel de Icaza <miguel@ximian.com>
18407 * typemanager.cs: Make the LookupTypeContainer function static,
18408 and not per-instance.
18410 * class.cs: Make static FindMembers (the one that takes a Type
18413 * codegen.cs: Add EmitForeach here.
18415 * cs-parser.jay: Make foreach a toplevel object instead of the
18416 inline expansion, as we need to perform semantic analysis on it.
18418 2001-10-05 Ravi Pratap <ravi@ximian.com>
18420 * expression.cs (Expression::ImplicitUserConversion): Rename to
18421 UserDefinedConversion.
18423 (Expression::UserDefinedConversion): Take an extra argument specifying
18424 whether we look for explicit user conversions too.
18426 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
18428 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
18430 (ExplicitUserConversion): Make it a call to UserDefinedConversion
18431 with the appropriate arguments.
18433 * cs-parser.jay (cast_expression): Record location too.
18435 * expression.cs (Cast): Record location info.
18437 (Expression::ConvertExplicit): Take location argument.
18439 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
18440 to determine if we are doing explicit conversions.
18442 (UserCast::Emit): Update accordingly.
18444 (Expression::ConvertExplicit): Report an error if everything fails.
18446 * ../errors/cs0030.cs : Add.
18448 2001-10-04 Miguel de Icaza <miguel@ximian.com>
18450 * modifiers.cs: If the ABSTRACT keyword is present, also set the
18451 virtual and newslot bits.
18453 * class.cs (TypeContainer::RegisterRequiredImplementations):
18454 Record methods we need.
18456 (TypeContainer::MakeKey): Helper function to make keys for
18457 MethodBases, since the Methodbase key is useless.
18459 (TypeContainer::Populate): Call RegisterRequiredImplementations
18460 before defining the methods.
18462 Create a mapping for method_builders_to_methods ahead of time
18463 instead of inside a tight loop.
18465 (::RequireMethods): Accept an object as the data to set into the
18466 hashtable so we can report interface vs abstract method mismatch.
18468 2001-10-03 Miguel de Icaza <miguel@ximian.com>
18470 * report.cs: Make all of it static.
18472 * rootcontext.cs: Drop object_type and value_type computations, as
18473 we have those in the TypeManager anyways.
18475 Drop report instance variable too, now it is a global.
18477 * driver.cs: Use try/catch on command line handling.
18479 Add --probe option to debug the error reporting system with a test
18482 * report.cs: Add support for exiting program when a probe
18483 condition is reached.
18485 2001-10-03 Ravi Pratap <ravi@ximian.com>
18487 * expression.cs (Binary::DoNumericPromotions): Fix the case when
18488 we do a forcible conversion regardless of type, to check if
18489 ForceConversion returns a null.
18491 (Binary::error19): Use location to report error.
18493 (Unary::error23): Use location here too.
18495 * ../errors/cs0019.cs : Check in.
18497 * ../errors/cs0023.cs : Check in.
18499 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
18500 case of a non-null MethodInfo object with a length of 0 !
18502 (Binary::ResolveOperator): Flag error if overload resolution fails to find
18503 an applicable member - according to the spec :-)
18504 Also fix logic to find members in base types.
18506 (Unary::ResolveOperator): Same here.
18508 (Unary::report23): Change name to error23 and make first argument a TypeContainer
18509 as I was getting thoroughly confused between this and error19 :-)
18511 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
18512 (::FindMostEncompassedType): Implement.
18513 (::FindMostEncompassingType): Implement.
18514 (::StandardConversionExists): Implement.
18516 (UserImplicitCast): Re-vamp. We now need info about most specific
18517 source and target types so that we can do the necessary conversions.
18519 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
18520 mathematical union with no duplicates.
18522 2001-10-03 Miguel de Icaza <miguel@ximian.com>
18524 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
18525 in order from base classes to child classes, so that we can in
18526 child classes look up in our parent for method names and
18527 attributes (required for handling abstract, virtual, new, override
18528 constructs: we need to instrospect our base class, and if we dont
18529 populate the classes in order, the introspection might be
18530 incorrect. For example, a method could query its parent before
18531 the parent has any methods and would determine that the parent has
18532 no abstract methods (while it could have had them)).
18534 (RootContext::CreateType): Record the order in which we define the
18537 2001-10-02 Miguel de Icaza <miguel@ximian.com>
18539 * class.cs (TypeContainer::Populate): Also method definitions can
18540 fail now, keep track of this.
18542 (TypeContainer::FindMembers): Implement support for
18543 DeclaredOnly/noDeclaredOnly flag.
18545 (Constructor::Emit) Return the ConstructorBuilder.
18547 (Method::Emit) Return the MethodBuilder.
18548 Check for abstract or virtual methods to be public.
18550 * rootcontext.cs (RootContext::CreateType): Register all the
18551 abstract methods required for the class to be complete and the
18552 interface methods that must be implemented.
18554 * cs-parser.jay: Report error 501 (method requires body if it is
18555 not marked abstract or extern).
18557 * expression.cs (TypeOf::Emit): Implement.
18559 * typemanager.cs: runtime_handle_type, new global type.
18561 * class.cs (Property::Emit): Generate code for properties.
18563 2001-10-02 Ravi Pratap <ravi@ximian.com>
18565 * expression.cs (Unary::ResolveOperator): Find operators on base type
18566 too - we now conform exactly to the spec.
18568 (Binary::ResolveOperator): Same here.
18570 * class.cs (Operator::Define): Fix minor quirk in the tests.
18572 * ../errors/cs0215.cs : Added.
18574 * ../errors/cs0556.cs : Added.
18576 * ../errors/cs0555.cs : Added.
18578 2001-10-01 Miguel de Icaza <miguel@ximian.com>
18580 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
18581 single integer which is really efficient
18583 2001-10-01 Ravi Pratap <ravi@ximian.com>
18585 * expression.cs (Expression::ImplicitUserConversion): Use location
18586 even in the case when we are examining True operators.
18588 * class.cs (Operator::Define): Perform extensive checks to conform
18589 with the rules for operator overloading in the spec.
18591 * expression.cs (Expression::ImplicitReferenceConversion): Implement
18592 some of the other conversions mentioned in the spec.
18594 * typemanager.cs (array_type): New static member for the System.Array built-in
18597 (cloneable_interface): For System.ICloneable interface.
18599 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
18600 we start resolving the tree and populating types.
18602 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
18604 2001-10-01 Miguel de Icaza <miguel@ximian.com>
18606 * expression.cs (Expression::ExprClassFromMemberInfo,
18607 Expression::Literalize): Create literal expressions from
18608 FieldInfos which are literals.
18610 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
18611 type casts, because they were wrong. The test suite in tests
18614 (ImplicitNumericConversion): ushort to ulong requires a widening
18617 Int32 constant to long requires widening cast as well.
18619 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
18620 for integers because the type on the stack is not i4.
18622 2001-09-30 Miguel de Icaza <miguel@ximian.com>
18624 * expression.cs (report118): require location argument.
18626 * parameter.cs: Do not dereference potential null value.
18628 * class.cs: Catch methods that lack the `new' keyword when
18629 overriding a name. Report warnings when `new' is used without
18630 anything being there to override.
18632 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
18634 * class.cs: Only add constructor to hashtable if it is non-null
18635 (as now constructors can fail on define).
18637 (TypeManager, Class, Struct): Take location arguments.
18639 Catch field instance initialization in structs as errors.
18641 accepting_filter: a new filter for FindMembers that is static so
18642 that we dont create an instance per invocation.
18644 (Constructor::Define): Catch errors where a struct constructor is
18647 * cs-parser.jay: Pass location information for various new
18650 * delegate.cs (Delegate): take a location argument.
18652 * driver.cs: Do not call EmitCode if there were problesm in the
18653 Definition of the types, as many Builders wont be there.
18655 * decl.cs (Decl::Decl): Require a location argument.
18657 * cs-tokenizer.cs: Handle properly hex constants that can not fit
18658 into integers, and find the most appropiate integer for it.
18660 * literal.cs: Implement ULongLiteral.
18662 * rootcontext.cs: Provide better information about the location of
18663 failure when CreateType fails.
18665 2001-09-29 Miguel de Icaza <miguel@ximian.com>
18667 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
18670 * expression.cs (Binary::CheckShiftArguments): Add missing type
18672 (Binary::ResolveOperator): Add type to the logical and and logical
18673 or, Bitwise And/Or and Exclusive Or code paths, it was missing
18676 (Binary::DoNumericPromotions): In the case where either argument
18677 is ulong (and most signed types combined with ulong cause an
18678 error) perform implicit integer constant conversions as well.
18680 2001-09-28 Miguel de Icaza <miguel@ximian.com>
18682 * expression.cs (UserImplicitCast): Method should always be
18684 (Invocation::BetterConversion): Simplified test for IntLiteral.
18686 (Expression::ImplicitNumericConversion): Split this routine out.
18687 Put the code that performs implicit constant integer conversions
18690 (Expression::Resolve): Become a wrapper around DoResolve so we can
18691 check eclass and type being set after resolve.
18693 (Invocation::Badness): Remove this dead function
18695 (Binary::ResolveOperator): Do not compute the expensive argumnets
18696 unless we have a union for it.
18698 (Probe::Emit): Is needs to do an isinst and then
18699 compare against null.
18701 (::CanConvert): Added Location argument. If the Location argument
18702 is null (Location.Null), then we do not report errors. This is
18703 used by the `probe' mechanism of the Explicit conversion. We do
18704 not want to generate an error for something that the user
18705 explicitly requested to be casted. But the pipeline for an
18706 explicit cast first tests for potential implicit casts.
18708 So for now, if the Location is null, it means `Probe only' to
18709 avoid adding another argument. Might have to revise this
18712 (ClassCast): New class used to type cast objects into arbitrary
18713 classes (used in Explicit Reference Conversions).
18715 Implement `as' as well.
18717 Reverted all the patches from Ravi below: they were broken:
18719 * The use of `level' as a mechanism to stop recursive
18720 invocations is wrong. That was there just to catch the
18721 bug with a strack trace but not as a way of addressing
18724 To fix the problem we have to *understand* what is going
18725 on and the interactions and come up with a plan, not
18726 just get things going.
18728 * The use of the type conversion cache that I proposed
18729 last night had an open topic: How does this work across
18730 protection domains. A user defined conversion might not
18731 be public in the location where we are applying the
18732 conversion, a different conversion might be selected
18733 (ie, private A->B (better) but public B->A (worse),
18734 inside A, A->B applies, but outside it, B->A will
18737 * On top of that (ie, even if the above is solved),
18738 conversions in a cache need to be abstract. Ie, `To
18739 convert from an Int to a Short use an OpcodeCast', not
18740 `To convert from an Int to a Short use the OpcodeCast on
18741 the variable 5' (which is what this patch was doing).
18743 2001-09-28 Ravi Pratap <ravi@ximian.com>
18745 * expression.cs (Invocation::ConversionExists): Re-write to use
18746 the conversion cache
18748 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
18749 cache all conversions done, not just user-defined ones.
18751 (Invocation::BetterConversion): The real culprit. Use ConversionExists
18752 to determine if a conversion exists instead of acutually trying to
18753 perform the conversion. It's faster too.
18755 (Expression::ConvertExplicit): Modify to use ConversionExists to check
18756 and only then attempt the implicit conversion.
18758 2001-09-28 Ravi Pratap <ravi@ximian.com>
18760 * expression.cs (ConvertImplicit): Use a cache for conversions
18761 already found. Check level of recursion and bail out if necessary.
18763 2001-09-28 Miguel de Icaza <miguel@ximian.com>
18765 * typemanager.cs (string_concat_string_string, string_concat_object_object):
18766 Export standard methods that we expect for string operations.
18768 * statement.cs (Block::UsageWarning): Track usage of variables and
18769 report the errors for not used variables.
18771 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
18774 2001-09-27 Miguel de Icaza <miguel@ximian.com>
18776 * codegen.cs: remove unnneded code
18778 * expression.cs: Removed BuiltinTypeAccess class
18780 Fix the order in which implicit conversions are
18783 The previous fixed dropped support for boxed conversions (adding a
18784 test to the test suite now)
18786 (UserImplicitCast::CanConvert): Remove test for source being null,
18787 that code is broken. We should not feed a null to begin with, if
18788 we do, then we should track the bug where the problem originates
18789 and not try to cover it up here.
18791 Return a resolved expression of type UserImplicitCast on success
18792 rather than true/false. Ravi: this is what I was talking about,
18793 the pattern is to use a static method as a "constructor" for
18796 Also, do not create arguments until the very last minute,
18797 otherwise we always create the arguments even for lookups that
18798 will never be performed.
18800 (UserImplicitCast::Resolve): Eliminate, objects of type
18801 UserImplicitCast are born in a fully resolved state.
18803 * typemanager.cs (InitCoreTypes): Init also value_type
18804 (System.ValueType).
18806 * expression.cs (Cast::Resolve): First resolve the child expression.
18808 (LValue): Add new method AddressOf to be used by
18811 Change the argument of Store to take an EmitContext instead of an
18812 ILGenerator, because things like FieldExpr need to be able to call
18813 their children expression to generate the instance code.
18815 (Expression::Error, Expression::Warning): Sugar functions for
18818 (Expression::MemberLookup): Accept a TypeContainer instead of a
18819 Report as the first argument.
18821 (Expression::ResolvePrimary): Killed. I still want to improve
18822 this as currently the code is just not right.
18824 (Expression::ResolveMemberAccess): Simplify, but it is still
18827 (Unary::Resolve): Catch errors in AddressOf operators.
18829 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
18830 index to a byte for the short-version, or the compiler will choose
18831 the wrong Emit call, which generates the wrong data.
18833 (ParameterReference::Emit, ::Store): same.
18835 (FieldExpr::AddressOf): Implement.
18837 * typemanager.cs: TypeManager: made public variable instead of
18840 * driver.cs: document --fatal.
18842 * report.cs (ErrorMessage, WarningMessage): new names for the old
18843 Error and Warning classes.
18845 * cs-parser.jay (member_access): Turn built-in access to types
18846 into a normal simplename
18848 2001-09-27 Ravi Pratap <ravi@ximian.com>
18850 * expression.cs (Invocation::BetterConversion): Fix to cope
18851 with q being null, since this was introducing a bug.
18853 * expression.cs (ConvertImplicit): Do built-in conversions first.
18855 2001-09-27 Ravi Pratap <ravi@ximian.com>
18857 * expression.cs (UserImplicitCast::Resolve): Fix bug.
18859 2001-09-27 Ravi Pratap <ravi@ximian.com>
18861 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
18862 I had introduced long ago (what's new ?).
18864 * expression.cs (UserImplicitCast::CanConvert): Static method to do
18865 the work of all the checking.
18866 (ConvertImplicit): Call CanConvert and only then create object if necessary.
18867 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
18869 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
18870 that is the right way.
18872 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
18873 overloading resolution. Use everywhere instead of cutting and pasting code.
18875 (Binary::ResolveOperator): Use MakeUnionSet.
18877 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
18878 we have to convert to bool types. Not complete yet.
18880 2001-09-27 Miguel de Icaza <miguel@ximian.com>
18882 * typemanager.cs (TypeManager::CSharpName): support ushort.
18884 * expression.cs (Expression::TryImplicitIntConversion): Attempts
18885 to provide an expression that performsn an implicit constant int
18886 conversion (section 6.1.6).
18887 (Expression::ConvertImplicitRequired): Reworked to include
18888 implicit constant expression conversions.
18890 (Expression::ConvertNumericExplicit): Finished.
18892 (Invocation::Emit): If InstanceExpression is null, then it means
18893 that we perform a call on this.
18895 2001-09-26 Miguel de Icaza <miguel@ximian.com>
18897 * expression.cs (Unary::Emit): Remove some dead code.
18898 (Probe): Implement Resolve and Emit for `is'.
18899 (Expression::ConvertImplicitRequired): Attempt to do constant
18900 expression conversions here. Maybe should be moved to
18901 ConvertImplicit, but I am not sure.
18902 (Expression::ImplicitLongConstantConversionPossible,
18903 Expression::ImplicitIntConstantConversionPossible): New functions
18904 that tell whether is it possible to apply an implicit constant
18905 expression conversion.
18907 (ConvertNumericExplicit): Started work on explicit numeric
18910 * cs-parser.jay: Update operator constants.
18912 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
18913 (Parameters::GetSignature): Hook up VerifyArgs here.
18914 (Parameters::VerifyArgs): Verifies that no two arguments have the
18917 * class.cs (Operator): Update the operator names to reflect the
18918 ones that the spec expects (as we are just stringizing the
18921 * expression.cs (Unary::ResolveOperator): Fix bug: Use
18922 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
18923 previous usage did only work for our methods.
18924 (Expression::ConvertImplicit): Handle decimal implicit numeric
18925 conversions as well.
18926 (Expression::InternalTypeConstructor): Used to invoke constructors
18927 on internal types for default promotions.
18929 (Unary::Emit): Implement special handling for the pre/post
18930 increment/decrement for overloaded operators, as they need to have
18931 the same semantics as the other operators.
18933 (Binary::ResolveOperator): ditto.
18934 (Invocation::ConversionExists): ditto.
18935 (UserImplicitCast::Resolve): ditto.
18937 2001-09-26 Ravi Pratap <ravi@ximian.com>
18939 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
18940 operator, return after emitting body. Regression tests pass again !
18942 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
18943 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
18944 (Invocation::OverloadResolve): Ditto.
18945 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
18947 * everywhere : update calls to the above methods accordingly.
18949 2001-09-26 Miguel de Icaza <miguel@ximian.com>
18951 * assign.cs (Assign): Make it inherit from ExpressionStatement.
18953 * expression.cs (ExpressionStatement): New base class used for
18954 expressions that can appear in statements, so that we can provide
18955 an alternate path to generate expression that do not leave a value
18958 (Expression::Emit, and all the derivatives): We no longer return
18959 whether a value is left on the stack or not. Every expression
18960 after being emitted leaves a single value on the stack.
18962 * codegen.cs (EmitContext::EmitStatementExpression): Use the
18963 facilties of ExpressionStatement if possible.
18965 * cs-parser.jay: Update statement_expression.
18967 2001-09-25 Miguel de Icaza <miguel@ximian.com>
18969 * driver.cs: Change the wording of message
18971 2001-09-25 Ravi Pratap <ravi@ximian.com>
18973 * expression.cs (Binary::ResolveOperator): Had forgottten to set
18974 the type of the expression to the return type of the method if
18975 we have an overloaded operator match ! The regression tests pass again !
18976 (Unary::ResolveOperator): Ditto.
18978 * expression.cs (Invocation::ConversionExists): Correct the member lookup
18979 to find "op_Implicit", not "implicit" ;-)
18980 (UserImplicitCast): New class to take care of user-defined implicit conversions.
18981 (ConvertImplicit, ForceConversion): Take TypeContainer argument
18983 * everywhere : Correct calls to the above accordingly.
18985 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
18986 (ConvertImplicit): Do user-defined conversion if it exists.
18988 2001-09-24 Miguel de Icaza <miguel@ximian.com>
18990 * assign.cs: track location.
18991 (Resolve): Use implicit conversions on assignment.
18993 * literal.cs: Oops. Not good, Emit of short access values should
18994 pass (Bytes) or the wrong argument will be selected.
18996 * expression.cs (Unary::Emit): Emit code for -expr.
18998 (Unary::ResolveOperator): Handle `Substract' for non-constants
18999 (substract from zero from the non-constants).
19000 Deal with Doubles as well.
19002 (Expression::ConvertImplicitRequired): New routine that reports an
19003 error if no implicit conversion exists.
19005 (Invocation::OverloadResolve): Store the converted implicit
19006 expressions if we make them
19008 2001-09-24 Ravi Pratap <ravi@ximian.com>
19010 * class.cs (ConstructorInitializer): Take a Location argument.
19011 (ConstructorBaseInitializer): Same here.
19012 (ConstructorThisInitializer): Same here.
19014 * cs-parser.jay : Update all calls accordingly.
19016 * expression.cs (Unary, Binary, New): Take location argument.
19017 Update accordingly everywhere.
19019 * cs-parser.jay : Update all calls to the above to take a location
19022 * class.cs : Ditto.
19024 2001-09-24 Ravi Pratap <ravi@ximian.com>
19026 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
19027 (Invocation::BetterConversion): Same here
19028 (Invocation::ConversionExists): Ditto.
19030 (Invocation::ConversionExists): Implement.
19032 2001-09-22 Ravi Pratap <ravi@ximian.com>
19034 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
19035 Also take an additional TypeContainer argument.
19037 * All over : Pass in TypeContainer as argument to OverloadResolve.
19039 * typemanager.cs (CSharpName): Update to check for the string type and return
19042 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
19045 2001-09-21 Ravi Pratap <ravi@ximian.com>
19047 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
19048 (Invocation::BetterFunction): Implement.
19049 (Invocation::BetterConversion): Implement.
19050 (Invocation::ConversionExists): Skeleton, no implementation yet.
19052 Okay, things work fine !
19054 2001-09-21 Miguel de Icaza <miguel@ximian.com>
19056 * typemanager.cs: declare and load enum_type, delegate_type and
19059 * expression.cs (Expression::Emit): Now emit returns a value that
19060 tells whether a value is left on the stack or not. This strategy
19061 might be reveted tomorrow with a mechanism that would address
19062 multiple assignments.
19063 (Expression::report118): Utility routine to report mismatches on
19066 (Unary::Report23): Report impossible type/operator combination
19069 (Unary::IsIncrementableNumber): Whether the type can be
19070 incremented or decremented with add.
19071 (Unary::ResolveOperator): Also allow enumerations to be bitwise
19073 (Unary::ResolveOperator): Implement ++, !, ~,
19075 (Invocation::Emit): Deal with new Emit convetion.
19077 * All Expression derivatives: Updated their Emit method to return
19078 whether they leave values on the stack or not.
19080 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
19081 stack for expressions that are statements.
19083 2001-09-20 Miguel de Icaza <miguel@ximian.com>
19085 * expression.cs (LValue): New interface. Must be implemented by
19087 (LocalVariableReference, ParameterReference, FieldExpr): Implement
19090 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
19091 interface for generating code, simplifies the code.
19093 2001-09-20 Ravi Pratap <ravi@ximian.com>
19095 * expression.cs (everywhere): Comment out return statements in ::Resolve
19096 methods to avoid the warnings.
19098 2001-09-20 Miguel de Icaza <miguel@ximian.com>
19100 * driver.cs (parse): Report error 2001 if we can not open the
19103 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
19106 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
19109 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
19110 otherwise nested blocks end up with the same index.
19112 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
19114 * expression.cs: Instead of having FIXMEs in the Resolve
19115 functions, throw exceptions so it is obvious that we are facing a
19118 * cs-parser.jay (invocation_expression): Pass Location information.
19120 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
19121 Use a basename for those routines because .NET does not like paths
19124 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
19127 2001-09-19 Miguel de Icaza <miguel@ximian.com>
19129 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
19130 are loading the correct data types (throws an exception if not).
19131 (TypeManager::InitCoreTypes): Use CoreLookupType
19133 * expression.cs (Unary::ResolveOperator): return the child
19134 expression for expressions which are just +expr.
19135 (Unary::ResolveOperator): Return negative literals for -LITERAL
19136 expressions (otherwise they are Unary {Literal}).
19137 (Invocation::Badness): Take into account `Implicit constant
19138 expression conversions'.
19140 * literal.cs (LongLiteral): Implement long literal class.
19141 (IntLiteral): export the `Value' of the intliteral.
19143 2001-09-19 Ravi Pratap <ravi@ximian.com>
19145 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
19147 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
19148 instead of 'Operator'
19150 * expression.cs (Binary::ResolveOperator): Update accordingly.
19151 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
19154 * cs-parser.jay (unary_expression): Update to use the new names.
19156 * gen-treedump.cs (GetUnary): Same here.
19158 * expression.cs (Unary::Resolve): Implement.
19159 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
19160 operators are found instead of making noise ;-)
19161 (Unary::ResolveOperator): New method to do precisely the same thing which
19162 Binary::ResolveOperator does for Binary expressions.
19163 (Unary.method, .Arguments): Add.
19164 (Unary::OperName): Implement.
19165 (Unary::ForceConversion): Copy and Paste !
19167 * class.cs (Operator::Define): Fix a small bug for the case when we have
19170 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
19171 for the inbuilt operators. Only overloading works for now ;-)
19173 2001-09-18 Miguel de Icaza <miguel@ximian.com>
19175 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
19176 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
19178 * expression.cs (This::Emit): Implement.
19179 (This::Resolve): Implement.
19180 (TypeOf:Resolve): Implement.
19181 (Expression::ResolveSimpleName): Add an implicit this to instance
19183 (MemberAccess::Resolve): Deal with Parameters and Fields.
19184 Bind instance variable to Field expressions.
19185 (FieldExpr::Instance): New field used to track the expression that
19186 represents the object instance.
19187 (FieldExpr::Resolve): Track potential errors from MemberLookup not
19189 (FieldExpr::Emit): Implement.
19191 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
19192 the last instruction contains a return opcode to avoid generating
19193 the last `ret' instruction (this generates correct code, and it is
19194 nice to pass the peverify output).
19196 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
19197 initializer for static and instance variables.
19198 (Constructor::Emit): Allow initializer to be null in the case of
19199 static constructors. Only emit initializer for instance
19202 (TypeContainer::FindMembers): Return a null array if there are no
19205 Also fix the code for the MemberTypes.Method branch, as it was not
19206 scanning that for operators (or tried to access null variables before).
19208 * assign.cs (Assign::Emit): Handle instance and static fields.
19212 * driver.cs: Stop compilation if there are parse errors.
19214 * cs-parser.jay (constructor_declaration): Provide default base
19215 initializer for non-static constructors.
19216 (constructor_declarator): Do not provide a default base
19217 initializers if none was specified.
19218 Catch the fact that constructors should not have parameters.
19220 * class.cs: Do not emit parent class initializers for static
19221 constructors, that should be flagged as an error.
19223 2001-09-18 Ravi Pratap <ravi@ximian.com>
19225 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
19226 Move back code into TypeContainer::Populate.
19228 2001-09-18 Ravi Pratap <ravi@ximian.com>
19230 * class.cs (TypeContainer::AddConstructor): Fix the check to
19231 compare against Name, not Basename.
19232 (Operator::OpType): Change Plus and Minus to Add and Subtract.
19234 * cs-parser.jay : Update accordingly.
19236 * class.cs (TypeContainer::FindMembers): For the case where we are searching
19237 for methods, don't forget to look into the operators too.
19238 (RegisterMethodBuilder): Helper method to take care of this for
19239 methods, constructors and operators.
19240 (Operator::Define): Completely revamp.
19241 (Operator.OperatorMethod, MethodName): New fields.
19242 (TypeContainer::Populate): Move the registering of builders into
19243 RegisterMethodBuilder.
19244 (Operator::Emit): Re-write.
19246 * expression.cs (Binary::Emit): Comment out code path to emit method
19247 invocation stuff for the case when we have a user defined operator. I am
19248 just not able to get it right !
19250 2001-09-17 Miguel de Icaza <miguel@ximian.com>
19252 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
19255 (Expression::MemberLookup): Provide a version that allows to
19256 specify the MemberTypes and BindingFlags.
19258 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
19259 so it was not fetching variable information from outer blocks.
19261 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
19262 Beforefieldinit as it was buggy.
19264 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
19265 that Ravi put here.
19267 * class.cs (Constructor::Emit): Only emit if block is not null.
19268 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
19269 deal with this by semantically definining it as if the user had
19272 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
19273 constructors as we now "emit" them at a higher level.
19275 (TypeContainer::DefineDefaultConstructor): Used to define the
19276 default constructors if none was provided.
19278 (ConstructorInitializer): Add methods Resolve and Emit.
19280 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
19282 2001-09-17 Ravi Pratap <ravi@ximian.com>
19284 * class.cs (TypeContainer::EmitDefaultConstructor): Register
19285 the default constructor builder with our hashtable for methodbuilders
19288 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
19289 and argument_count is 0 in which case we have a match.
19290 (Binary::ResolveOperator): More null checking and miscellaneous coding
19293 2001-09-17 Ravi Pratap <ravi@ximian.com>
19295 * rootcontext.cs (IsNameSpace): Compare against null.
19297 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
19299 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
19300 and Unary::Operator.
19302 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
19305 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
19306 we have overloaded operators.
19307 (Binary::ResolveOperator): Implement the part which does the operator overload
19310 * class.cs (Operator::Emit): Implement.
19311 (TypeContainer::Emit): Emit the operators we have too.
19313 * expression.cs (Binary::Emit): Update to emit the appropriate code for
19314 the case when we have a user-defined operator.
19316 2001-09-17 Miguel de Icaza <miguel@ximian.com>
19318 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
19320 2001-09-16 Ravi Pratap <ravi@ximian.com>
19322 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
19323 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
19324 (Constructor::Emit): Implement.
19325 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
19326 if we have no work to do.
19327 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
19330 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
19331 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
19333 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
19336 2001-09-15 Ravi Pratap <ravi@ximian.com>
19338 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
19340 (Tree::RecordNamespace): Method to do what the name says ;-)
19341 (Tree::Namespaces): Property to get at the namespaces hashtable.
19343 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
19346 * rootcontext.cs (IsNamespace): Fixed it :-)
19348 2001-09-14 Miguel de Icaza <miguel@ximian.com>
19350 * class.cs (TypeContainer::FindMembers): Add support for
19352 (MethodCore): New class that encapsulates both the shared aspects
19353 of a Constructor and a Method.
19354 (Method, Constructor): Factored pieces into MethodCore.
19356 * driver.cs: Added --fatal which makes errors throw exceptions.
19357 Load System assembly as well as part of the standard library.
19359 * report.cs: Allow throwing exceptions on errors for debugging.
19361 * modifiers.cs: Do not use `parent', instead use the real type
19362 container to evaluate permission settings.
19364 * class.cs: Put Ravi's patch back in. He is right, and we will
19365 have to cope with the
19367 2001-09-14 Ravi Pratap <ravi@ximian.com>
19369 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
19370 FamORAssem, not FamANDAssem.
19372 2001-09-14 Miguel de Icaza <miguel@ximian.com>
19374 * driver.cs: Added --parse option that only parses its input files
19377 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
19378 incorrect. IsTopLevel is not used to tell whether an object is
19379 root_types or not (that can be achieved by testing this ==
19380 root_types). But to see if this is a top-level *class* (not
19381 necessarly our "toplevel" container).
19383 2001-09-14 Ravi Pratap <ravi@ximian.com>
19385 * enum.cs (Enum::Define): Modify to call the Lookup method on the
19386 parent instead of a direct call to GetType.
19388 2001-09-14 Ravi Pratap <ravi@ximian.com>
19390 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
19391 Modifiers.TypeAttr. This should just be a call to that method.
19393 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
19394 object so that we can determine if we are top-level or not.
19396 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
19399 * enum.cs (Enum::Define): Ditto.
19401 * modifiers.cs (FieldAttr): Re-write.
19403 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
19404 (TypeContainer::HaveStaticConstructor): New property to provide access
19405 to precisely that info.
19407 * modifiers.cs (MethodAttr): Re-write.
19408 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
19410 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
19411 of top-level types as claimed.
19413 2001-09-13 Miguel de Icaza <miguel@ximian.com>
19415 * expression.cs (MemberLookup): Fruitless attempt to lookup
19416 constructors. Maybe I need to emit default constructors? That
19417 might be it (currently .NET emits this for me automatically).
19418 (Invocation::OverloadResolve): Cope with Arguments == null.
19419 (Invocation::EmitArguments): new function, shared by the new
19420 constructor and us.
19421 (Invocation::Emit): Handle static and instance methods. Emit
19422 proper call instruction for virtual or non-virtual invocations.
19423 (New::Emit): Implement.
19424 (New::Resolve): Implement.
19425 (MemberAccess:Resolve): Implement.
19426 (MethodGroupExpr::InstanceExpression): used conforming to the spec
19427 to track instances.
19428 (FieldExpr::Resolve): Set type.
19430 * support.cs: Handle empty arguments.
19432 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
19433 SimpleLookup): Auxiliary routines to help parse a qualifier
19436 Update qualifier_identifier rule.
19438 * codegen.cs: Removed debugging messages.
19440 * class.cs: Make this a global thing, this acts just as a "key" to
19441 objects that we might have around.
19443 (Populate): Only initialize method_builders_to_methods once.
19445 * expression.cs (PropertyExpr): Initialize type from the
19448 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
19449 Resolve pattern. Attempt to implicitly convert value to boolean.
19452 * expression.cs: Set the type for the int32/int32 argument case.
19453 (Binary::ResolveOperator): Set the return type to boolean for
19454 comparission operators
19456 * typemanager.cs: Remove debugging print code.
19458 (Invocation::Resolve): resolve type.
19460 * class.cs: Allocate a MemberInfo of the correct size, as the code
19461 elsewhere depends on the test to reflect the correct contents.
19463 (Method::) Keep track of parameters, due to System.Reflection holes
19465 (TypeContainer::Populate): Keep track of MethodBuilders to Method
19468 (TypeContainer::FindMembers): Use ArrayList and then copy an array
19469 of the exact size and return that.
19471 (Class::LookupMethodByBuilder): New function that maps
19472 MethodBuilders to its methods. Required to locate the information
19473 on methods because System.Reflection bit us again.
19475 * support.cs: New file, contains an interface ParameterData and
19476 two implementations: ReflectionParameters and InternalParameters
19477 used to access Parameter information. We will need to grow this
19480 * expression.cs (Invocation::GetParameterData): implement a cache
19481 and a wrapper around the ParameterData creation for methods.
19482 (Invocation::OverloadResolve): Use new code.
19484 2001-09-13 Ravi Pratap <ravi@ximian.com>
19486 * class.cs (TypeContainer::EmitField): Remove and move into
19487 (Field::Define): here and modify accordingly.
19488 (Field.FieldBuilder): New member.
19489 (TypeContainer::Populate): Update accordingly.
19490 (TypeContainer::FindMembers): Implement.
19492 2001-09-13 Miguel de Icaza <miguel@ximian.com>
19494 * statement.cs: (VariableInfo::VariableType): New field to be
19495 initialized with the full type once it is resolved.
19497 2001-09-12 Miguel de Icaza <miguel@ximian.com>
19499 * parameter.cs (GetParameterInfo): Use a type cache to compute
19500 things only once, and to reuse this information
19502 * expression.cs (LocalVariableReference::Emit): Implement.
19503 (OpcodeCast::Emit): fix.
19505 (ParameterReference::Resolve): Implement.
19506 (ParameterReference::Emit): Implement.
19508 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
19509 that are expressions need to stay as Expressions.
19511 * typemanager.cs (CSharpName): Returns the C# name of a type if
19514 * expression.cs (Expression::ConvertImplicit): New function that
19515 implements implicit type conversions.
19517 (Expression::ImplicitReferenceConversion): Implements implicit
19518 reference conversions.
19520 (EmptyCast): New type for transparent casts.
19522 (OpcodeCast): New type for casts of types that are performed with
19523 a sequence of bytecodes.
19525 (BoxedCast): New type used for casting value types into reference
19526 types. Emits a box opcode.
19528 (Binary::DoNumericPromotions): Implements numeric promotions of
19529 and computation of the Binary::Type.
19531 (Binary::EmitBranchable): Optimization.
19533 (Binary::Emit): Implement code emission for expressions.
19535 * typemanager.cs (TypeManager): Added two new core types: sbyte
19538 2001-09-12 Ravi Pratap <ravi@ximian.com>
19540 * class.cs (TypeContainer::FindMembers): Method which does exactly
19541 what Type.FindMembers does, only we don't have to use reflection. No
19542 implementation yet.
19544 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
19545 typecontainer objects as we need to get at them.
19546 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
19548 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
19549 typecontainer object.
19551 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
19552 of just a Report object.
19554 2001-09-11 Ravi Pratap <ravi@ximian.com>
19556 * class.cs (Event::Define): Go back to using the prefixes "add_" and
19558 (TypeContainer::Populate): Now define the delegates of the type too.
19559 (TypeContainer.Delegates): Property to access the list of delegates defined
19562 * delegates.cs (Delegate::Define): Implement partially.
19564 * modifiers.cs (TypeAttr): Handle more flags.
19566 2001-09-11 Ravi Pratap <ravi@ximian.com>
19568 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
19570 (Operator::Define): Re-write logic to get types by using the LookupType method
19571 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
19572 (Indexer::Define): Ditto.
19573 (Event::Define): Ditto.
19574 (Property::Define): Ditto.
19576 2001-09-10 Ravi Pratap <ravi@ximian.com>
19578 * class.cs (TypeContainer::Populate): Now define operators too.
19579 (TypeContainer.Operators): New property to access the list of operators
19581 (Operator.OperatorMethodBuilder): New member to hold the method builder
19582 for the operator we are defining.
19583 (Operator::Define): Implement.
19585 2001-09-10 Ravi Pratap <ravi@ximian.com>
19587 * class.cs (Event::Define): Make the prefixes of the accessor methods
19588 addOn_ and removeOn_
19590 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
19591 of the location being passed in too. Ideally, this should go later since all
19592 error reporting should be done through the Report object.
19594 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
19595 (Populate): Iterate thru the indexers we have and define them too.
19596 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
19597 for the get and set accessors.
19598 (Indexer::Define): Implement.
19600 2001-09-09 Miguel de Icaza <miguel@ximian.com>
19602 * expression.cs (Binary::Resolve): Beginning of it. I scratched
19603 my previous implementation, did not work.
19605 * typemanager.cs: Add a couple of missing types (the longs).
19607 * literal.cs: Use TypeManager.bool_type instead of getting it.
19609 * expression.cs (EventExpr): New kind of expressions.
19610 (Expressio::ExprClassFromMemberInfo): finish
19612 2001-09-08 Miguel de Icaza <miguel@ximian.com>
19614 * assign.cs: Emit stores to static fields differently.
19616 2001-09-08 Ravi Pratap <ravi@ximian.com>
19618 * Merge in changes and adjust code to tackle conflicts. Backed out my
19619 code in Assign::Resolve ;-)
19621 2001-09-08 Ravi Pratap <ravi@ximian.com>
19623 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
19624 instead Report.Error and also pass in the location.
19625 (CSharpParser::Lexer): New readonly property to return the reference
19626 to the Tokenizer object.
19627 (declare_local_variables): Use Report.Error with location instead of plain
19631 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
19632 (Operator.CheckBinaryOperator): Ditto.
19634 * cs-parser.jay (operator_declarator): Update accordingly.
19636 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
19637 (CheckBinaryOperator): Same here.
19639 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
19640 on the name without any prefixes of namespace names etc. This is because we
19641 already might have something already fully qualified like
19642 'System.Console.WriteLine'
19644 * assign.cs (Resolve): Begin implementation. Stuck ;-)
19646 2001-09-07 Ravi Pratap <ravi@ximian.com>
19648 * cs-tokenizer.cs (location): Return a string which also contains
19651 * expression.cs (ElementAccess): New class for expressions of the
19652 type 'element access.'
19653 (BaseAccess): New class for expressions of the type 'base access.'
19654 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
19657 * cs-parser.jay (element_access): Implement action.
19658 (base_access): Implement actions.
19659 (checked_expression, unchecked_expression): Implement.
19661 * cs-parser.jay (local_variable_type): Correct and implement.
19662 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
19664 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
19666 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
19667 name and the specifiers.
19669 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
19671 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
19672 making them all public ;-)
19674 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
19677 2001-09-07 Miguel de Icaza <miguel@ximian.com>
19679 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
19681 (FieldExpr, PropertyExprs): New resolved expressions.
19682 (SimpleName::MemberStaticCheck): Perform static checks for access
19683 to non-static fields on static methods. Maybe this should be
19684 generalized for MemberAccesses.
19685 (SimpleName::ResolveSimpleName): More work on simple name
19688 * cs-parser.jay (primary_expression/qualified_identifier): track
19689 the parameter index.
19691 * codegen.cs (CodeGen::Save): Catch save exception, report error.
19692 (EmitContext::EmitBoolExpression): Chain to expression generation
19693 instead of temporary hack.
19694 (::EmitStatementExpression): Put generic expression code generation.
19696 * assign.cs (Assign::Emit): Implement variable assignments to
19697 local variables, parameters and fields.
19699 2001-09-06 Miguel de Icaza <miguel@ximian.com>
19701 * statement.cs (Block::GetVariableInfo): New method, returns the
19702 VariableInfo for a variable name in a block.
19703 (Block::GetVariableType): Implement in terms of GetVariableInfo
19705 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
19706 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
19708 2001-09-06 Ravi Pratap <ravi@ximian.com>
19710 * cs-parser.jay (operator_declaration): Continue on my quest : update
19711 to take attributes argument.
19712 (event_declaration): Ditto.
19713 (enum_declaration): Ditto.
19714 (indexer_declaration): Ditto.
19716 * class.cs (Operator::Operator): Update constructor accordingly.
19717 (Event::Event): Ditto.
19719 * delegate.cs (Delegate::Delegate): Same here.
19721 * enum.cs (Enum::Enum): Same here.
19723 2001-09-05 Ravi Pratap <ravi@ximian.com>
19725 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
19727 * ../tests/cs0658.cs : New file to demonstrate error 0658.
19729 * attribute.cs (Attributes): New class to encapsulate all attributes which were
19730 being passed around as an arraylist.
19731 (Attributes::AddAttribute): Method to add attribute sections.
19733 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
19734 (struct_declaration): Update accordingly.
19735 (constant_declaration): Update.
19736 (field_declaration): Update.
19737 (method_header): Update.
19738 (fixed_parameter): Update.
19739 (parameter_array): Ditto.
19740 (property_declaration): Ditto.
19741 (destructor_declaration): Ditto.
19743 * class.cs (Struct::Struct): Update constructors accordingly.
19744 (Class::Class): Ditto.
19745 (Field::Field): Ditto.
19746 (Method::Method): Ditto.
19747 (Property::Property): Ditto.
19748 (TypeContainer::OptAttribute): update property's return type.
19750 * interface.cs (Interface.opt_attributes): New member.
19751 (Interface::Interface): Update to take the extra Attributes argument.
19753 * parameter.cs (Parameter::Parameter): Ditto.
19755 * constant.cs (Constant::Constant): Ditto.
19757 * interface.cs (InterfaceMemberBase): New OptAttributes field.
19758 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
19759 the attributes as a parameter.
19760 (InterfaceProperty): Update constructor call.
19761 (InterfaceEvent): Ditto.
19762 (InterfaceMethod): Ditto.
19763 (InterfaceIndexer): Ditto.
19765 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
19766 pass the attributes too.
19767 (interface_event_declaration): Ditto.
19768 (interface_property_declaration): Ditto.
19769 (interface_method_declaration): Ditto.
19770 (interface_declaration): Ditto.
19772 2001-09-05 Miguel de Icaza <miguel@ximian.com>
19774 * class.cs (Method::Define): Track the "static Main" definition to
19775 create an entry point.
19777 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
19778 EntryPoint if we find it.
19780 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
19781 (EmitContext::ig): Make this variable public.
19783 * driver.cs: Make the default output file be the first file name
19784 with the .exe extension.
19786 Detect empty compilations
19788 Handle various kinds of output targets. Handle --target and
19789 rename -t to --dumper.
19791 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
19792 methods inherited from Expression return now an Expression. This
19793 will is used during the tree rewriting as we resolve them during
19796 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
19797 the spec. Missing entirely is the information about
19798 accessability of elements of it.
19800 (Expression::ExprClassFromMemberInfo): New constructor for
19801 Expressions that creates a fully initialized Expression based on
19802 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
19805 (Invocation::Resolve): Begin implementing resolution of invocations.
19807 * literal.cs (StringLiteral): Implement Emit.
19809 2001-09-05 Ravi Pratap <ravi@ximian.com>
19811 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
19814 2001-09-04 Ravi Pratap <ravi@ximian.com>
19816 * cs-parser.jay (attribute_arguments): Implement actions.
19817 (attribute): Fix bug in production. Implement action.
19818 (attribute_list): Implement.
19819 (attribute_target): Implement.
19820 (attribute_target_specifier, opt_target_specifier): Implement
19821 (CheckAttributeTarget): New method to check if the attribute target
19823 (attribute_section): Implement.
19824 (opt_attributes): Implement.
19826 * attribute.cs : New file to handle attributes.
19827 (Attribute): Class to hold attribute info.
19829 * cs-parser.jay (opt_attribute_target_specifier): Remove production
19830 (attribute_section): Modify production to use 2 different rules to
19831 achieve the same thing. 1 s/r conflict down !
19832 Clean out commented, useless, non-reducing dimension_separator rules.
19834 * class.cs (TypeContainer.attributes): New member to hold list
19835 of attributes for a type.
19836 (Struct::Struct): Modify to take one more argument, the attribute list.
19837 (Class::Class): Ditto.
19838 (Field::Field): Ditto.
19839 (Method::Method): Ditto.
19840 (Property::Property): Ditto.
19842 * cs-parser.jay (struct_declaration): Update constructor call to
19843 pass in the attributes too.
19844 (class_declaration): Ditto.
19845 (constant_declaration): Ditto.
19846 (field_declaration): Ditto.
19847 (method_header): Ditto.
19848 (fixed_parameter): Ditto.
19849 (parameter_array): Ditto.
19850 (property_declaration): Ditto.
19852 * constant.cs (Constant::Constant): Update constructor similarly.
19853 Use System.Collections.
19855 * parameter.cs (Parameter::Parameter): Update as above.
19857 2001-09-02 Ravi Pratap <ravi@ximian.com>
19859 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
19860 (TypeContainer.delegates): New member to hold list of delegates.
19862 * cs-parser.jay (delegate_declaration): Implement the action correctly
19863 this time as I seem to be on crack ;-)
19865 2001-09-02 Miguel de Icaza <miguel@ximian.com>
19867 * rootcontext.cs (RootContext::IsNamespace): new function, used to
19868 tell whether an identifier represents a namespace.
19870 * expression.cs (NamespaceExpr): A namespace expression, used only
19871 temporarly during expression resolution.
19872 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
19873 utility functions to resolve names on expressions.
19875 2001-09-01 Miguel de Icaza <miguel@ximian.com>
19877 * codegen.cs: Add hook for StatementExpressions.
19879 * class.cs: Fix inverted test for static flag in methods.
19881 2001-09-02 Ravi Pratap <ravi@ximian.com>
19883 * class.cs (Operator::CheckUnaryOperator): Correct error number used
19884 to make it coincide with MS' number.
19885 (Operator::CheckBinaryOperator): Ditto.
19887 * ../errors/errors.txt : Remove error numbers added earlier.
19889 * ../errors/cs1019.cs : Test case for error # 1019
19891 * ../errros/cs1020.cs : Test case for error # 1020
19893 * cs-parser.jay : Clean out commented cruft.
19894 (dimension_separators, dimension_separator): Comment out. Ostensibly not
19895 used anywhere - non-reducing rule.
19896 (namespace_declarations): Non-reducing rule - comment out.
19898 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
19899 with TypeContainer::AddEnum.
19901 * delegate.cs : New file for delegate handling classes.
19902 (Delegate): Class for declaring delegates.
19904 * makefile : Update.
19906 * cs-parser.jay (delegate_declaration): Implement.
19908 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
19910 * class.cs (Event::Define): Implement.
19911 (Event.EventBuilder): New member.
19913 * class.cs (TypeContainer::Populate): Update to define all enums and events
19915 (Events): New property for the events arraylist we hold. Shouldn't we move to using
19916 readonly fields for all these cases ?
19918 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
19920 * class.cs (Property): Revamp to use the convention of making fields readonly.
19921 Accordingly modify code elsewhere.
19923 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
19924 the Define method of the Property class.
19926 * class.cs : Clean up applied patch and update references to variables etc. Fix
19928 (TypeContainer::Populate): Update to define all the properties we have. Also
19929 define all enumerations.
19931 * enum.cs (Define): Implement.
19933 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
19935 * cs-parser.jay (overloadable_operator): The semantic value is an
19936 enum of the Operator class.
19937 (operator_declarator): Implement actions.
19938 (operator_declaration): Implement.
19940 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
19941 validity of definitions.
19942 (Operator::CheckBinaryOperator): Static method to check for binary operators
19943 (TypeContainer::AddOperator): New method to add an operator to a type.
19945 * cs-parser.jay (indexer_declaration): Added line to actually call the
19946 AddIndexer method so it gets added ;-)
19948 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
19949 already taken care of by the MS compiler ?
19951 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
19953 * class.cs (Operator): New class for operator declarations.
19954 (Operator::OpType): Enum for the various operators.
19956 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
19958 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
19959 ostensibly handle this in semantic analysis.
19961 * cs-parser.jay (general_catch_clause): Comment out
19962 (specific_catch_clauses, specific_catch_clause): Ditto.
19963 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
19964 (catch_args, opt_catch_args): New productions.
19965 (catch_clause): Rewrite to use the new productions above
19966 (catch_clauses): Modify accordingly.
19967 (opt_catch_clauses): New production to use in try_statement
19968 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
19969 and re-write the code in the actions to extract the specific and
19970 general catch clauses by being a little smart ;-)
19972 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
19973 Hooray, try and catch statements parse fine !
19975 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
19977 * statement.cs (Block::GetVariableType): Fix logic to extract the type
19978 string from the hashtable of variables.
19980 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
19981 I end up making that mistake ;-)
19982 (catch_clauses): Fixed gross error which made Key and Value of the
19983 DictionaryEntry the same : $1 !!
19985 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
19987 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
19989 * cs-parser.jay (event_declaration): Correct to remove the semicolon
19990 when the add and remove accessors are specified.
19992 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
19994 * cs-parser.jay (IndexerDeclaration): New helper class to hold
19995 information about indexer_declarator.
19996 (indexer_declarator): Implement actions.
19997 (parsing_indexer): New local boolean used to keep track of whether
19998 we are parsing indexers or properties. This is necessary because
19999 implicit_parameters come into picture even for the get accessor in the
20000 case of an indexer.
20001 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
20003 * class.cs (Indexer): New class for indexer declarations.
20004 (TypeContainer::AddIndexer): New method to add an indexer to a type.
20005 (TypeContainer::indexers): New member to hold list of indexers for the
20008 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
20010 * cs-parser.jay (add_accessor_declaration): Implement action.
20011 (remove_accessor_declaration): Implement action.
20012 (event_accessors_declaration): Implement
20013 (variable_declarators): swap statements for first rule - trivial.
20015 * class.cs (Event): New class to hold information about event
20017 (TypeContainer::AddEvent): New method to add an event to a type
20018 (TypeContainer::events): New member to hold list of events.
20020 * cs-parser.jay (event_declaration): Implement actions.
20022 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
20024 * cs-parser.jay (dim_separators): Implement. Make it a string
20025 concatenating all the commas together, just as they appear.
20026 (opt_dim_separators): Modify accordingly
20027 (rank_specifiers): Update accordingly. Basically do the same
20028 thing - instead, collect the brackets here.
20029 (opt_rank_sepcifiers): Modify accordingly.
20030 (array_type): Modify to actually return the complete type string
20031 instead of ignoring the rank_specifiers.
20032 (expression_list): Implement to collect the expressions
20033 (variable_initializer): Implement. We make it a list of expressions
20034 essentially so that we can handle the array_initializer case neatly too.
20035 (variable_initializer_list): Implement.
20036 (array_initializer): Make it a list of variable_initializers
20037 (opt_array_initializer): Modify accordingly.
20039 * expression.cs (New::NType): Add enumeration to help us
20040 keep track of whether we have an object/delegate creation
20041 or an array creation.
20042 (New:NewType, New::Rank, New::Indices, New::Initializers): New
20043 members to hold data about array creation.
20044 (New:New): Modify to update NewType
20045 (New:New): New Overloaded contructor for the array creation
20048 * cs-parser.jay (array_creation_expression): Implement to call
20049 the overloaded New constructor.
20051 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
20053 * class.cs (TypeContainer::Constructors): Return member
20054 constructors instead of returning null.
20056 2001-08-26 Miguel de Icaza <miguel@ximian.com>
20058 * typemanager.cs (InitCoreTypes): Initialize the various core
20059 types after we have populated the type manager with the user
20060 defined types (this distinction will be important later while
20061 compiling corlib.dll)
20063 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
20064 on Expression Classification. Now all expressions have a method
20065 `Resolve' and a method `Emit'.
20067 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
20068 generation from working. Also add some temporary debugging
20071 2001-08-24 Miguel de Icaza <miguel@ximian.com>
20073 * codegen.cs: Lots of code generation pieces. This is only the
20074 beginning, will continue tomorrow with more touches of polish. We
20075 handle the fundamentals of if, while, do, for, return. Others are
20076 trickier and I need to start working on invocations soon.
20078 * gen-treedump.cs: Bug fix, use s.Increment here instead of
20081 * codegen.cs (EmitContext): New struct, used during code
20082 emission to keep a context. Most of the code generation will be
20085 * cs-parser.jay: Add embedded blocks to the list of statements of
20086 this block. So code generation proceeds in a top down fashion.
20088 2001-08-23 Miguel de Icaza <miguel@ximian.com>
20090 * statement.cs: Add support for multiple child blocks.
20092 2001-08-22 Miguel de Icaza <miguel@ximian.com>
20094 * codegen.cs (EmitCode): New function, will emit the code for a
20095 Block of code given a TypeContainer and its ILGenerator.
20097 * statement.cs (Block): Standard public readonly optimization.
20098 (Block::Block constructors): Link children.
20099 (Block::Child): Child Linker.
20100 (Block::EmitVariables): Emits IL variable declarations.
20102 * class.cs: Drop support for MethodGroups here, delay until
20104 (Method::): Applied the same simplification that I did before, and
20105 move from Properties to public readonly fields.
20106 (Method::ParameterTypes): Returns the parameter types for the
20107 function, and implements a cache that will be useful later when I
20108 do error checking and the semantic analysis on the methods is
20110 (Constructor::GetCallingConvention): Renamed from CallingConvetion
20111 and made a method, optional argument tells whether this is a class
20112 or a structure to apply the `has-this' bit.
20113 (Method::GetCallingConvention): Implement, returns the calling
20115 (Method::Define): Defines the type, a second pass is performed
20116 later to populate the methods.
20118 (Constructor::ParameterTypes): implement a cache similar to the
20119 one on Method::ParameterTypes, useful later when we do semantic
20122 (TypeContainer::EmitMethod): New method. Emits methods.
20124 * expression.cs: Removed MethodGroup class from here.
20126 * parameter.cs (Parameters::GetCallingConvention): new method.
20128 2001-08-21 Miguel de Icaza <miguel@ximian.com>
20130 * class.cs (TypeContainer::Populate): Drop RootContext from the
20133 (Constructor::CallingConvention): Returns the calling convention.
20134 (Constructor::ParameterTypes): Returns the constructor parameter
20137 (TypeContainer::AddConstructor): Keep track of default constructor
20138 and the default static constructor.
20140 (Constructor::) Another class that starts using `public readonly'
20141 instead of properties.
20143 (Constructor::IsDefault): Whether this is a default constructor.
20145 (Field::) use readonly public fields instead of properties also.
20147 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
20148 track of static constructors; If none is used, turn on
20149 BeforeFieldInit in the TypeAttributes.
20151 * cs-parser.jay (opt_argument_list): now the return can be null
20152 for the cases where there are no arguments.
20154 (constructor_declarator): If there is no implicit `base' or
20155 `this', then invoke the default parent constructor.
20157 * modifiers.cs (MethodAttr): New static function maps a set of
20158 modifiers flags into a MethodAttributes enum
20159 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
20160 MethodAttr, TypeAttr to represent the various mappings where the
20161 modifiers are used.
20162 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
20164 2001-08-19 Miguel de Icaza <miguel@ximian.com>
20166 * parameter.cs (GetParameterInfo): Fix bug where there would be no
20169 * interface.cs (PopulateIndexer): Implemented the code generator
20170 for interface indexers.
20172 2001-08-17 Miguel de Icaza <miguel@ximian.com>
20174 * interface.cs (InterfaceMemberBase): Now we track the new status
20177 (PopulateProperty): Implement property population. Woohoo! Got
20178 Methods and Properties going today.
20180 Removed all the properties for interfaces, and replaced them with
20181 `public readonly' fields.
20183 2001-08-16 Miguel de Icaza <miguel@ximian.com>
20185 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
20186 initialize their hashtables/arraylists only when they are needed
20187 instead of doing this always.
20189 * parameter.cs: Handle refs and out parameters.
20191 * cs-parser.jay: Use an ArrayList to construct the arguments
20192 instead of the ParameterCollection, and then cast that to a
20195 * parameter.cs: Drop the use of ParameterCollection and use
20196 instead arrays of Parameters.
20198 (GetParameterInfo): Use the Type, not the Name when resolving
20201 2001-08-13 Miguel de Icaza <miguel@ximian.com>
20203 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
20204 and instead use public readonly fields.
20206 * class.cs: Put back walking code for type containers.
20208 2001-08-11 Miguel de Icaza <miguel@ximian.com>
20210 * class.cs (MakeConstant): Code to define constants.
20212 * rootcontext.cs (LookupType): New function. Used to locate types
20215 2001-08-08 Miguel de Icaza <miguel@ximian.com>
20217 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
20218 this System.Reflection code is. Kudos to Microsoft
20220 * typemanager.cs: Implement a type cache and avoid loading all
20221 types at boot time. Wrap in LookupType the internals. This made
20222 the compiler so much faster. Wow. I rule!
20224 * driver.cs: Make sure we always load mscorlib first (for
20225 debugging purposes, nothing really important).
20227 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
20228 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
20230 * rootcontext.cs: Lookup types on their namespace; Lookup types
20231 on namespaces that have been imported using the `using' keyword.
20233 * class.cs (TypeContainer::TypeAttr): Virtualize.
20234 (Class::TypeAttr): Return attributes suitable for this bad boy.
20235 (Struct::TypeAttr): ditto.
20236 Handle nested classes.
20237 (TypeContainer::) Remove all the type visiting code, it is now
20238 replaced with the rootcontext.cs code
20240 * rootcontext.cs (GetClassBases): Added support for structs.
20242 2001-08-06 Miguel de Icaza <miguel@ximian.com>
20244 * interface.cs, statement.cs, class.cs, parameter.cs,
20245 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
20246 Drop use of TypeRefs, and use strings instead.
20248 2001-08-04 Miguel de Icaza <miguel@ximian.com>
20252 * class.cs (Struct::Struct): set the SEALED flags after
20253 checking the modifiers.
20254 (TypeContainer::TypeAttr): new property, returns the
20255 TypeAttributes for a class.
20257 * cs-parser.jay (type_list): Oops, list production was creating a
20258 new list of base types.
20260 * rootcontext.cs (StdLib): New property.
20261 (GetInterfaceTypeByName): returns an interface by type name, and
20262 encapsulates error handling here.
20263 (GetInterfaces): simplified.
20264 (ResolveTree): Encapsulated all the tree resolution here.
20265 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
20268 * driver.cs: Add support for --nostdlib, to avoid loading the
20269 default assemblies.
20270 (Main): Do not put tree resolution here.
20272 * rootcontext.cs: Beginning of the class resolution.
20274 2001-08-03 Miguel de Icaza <miguel@ximian.com>
20276 * rootcontext.cs: Provide better error reporting.
20278 * cs-parser.jay (interface_base): set our $$ to be interfaces.
20280 * rootcontext.cs (CreateInterface): Handle the case where there
20281 are no parent interfaces.
20283 (CloseTypes): Routine to flush types at the end.
20284 (CreateInterface): Track types.
20285 (GetInterfaces): Returns an array of Types from the list of
20286 defined interfaces.
20288 * typemanager.c (AddUserType): Mechanism to track user types (puts
20289 the type on the global type hash, and allows us to close it at the
20292 2001-08-02 Miguel de Icaza <miguel@ximian.com>
20294 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
20295 RecordInterface instead.
20297 * cs-parser.jay: Updated to reflect changes above.
20299 * decl.cs (Definition): Keep track of the TypeBuilder type that
20300 represents this type here. Not sure we will use it in the long
20301 run, but wont hurt for now.
20303 * driver.cs: Smaller changes to accomodate the new code.
20305 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
20308 * rootcontext.cs (CreateInterface): New method, used to create
20309 the System.TypeBuilder type for interfaces.
20310 (ResolveInterfaces): new entry point to resolve the interface
20312 (CodeGen): Property, used to keep track of the code generator.
20314 2001-07-26 Miguel de Icaza <miguel@ximian.com>
20316 * cs-parser.jay: Add a second production for delegate_declaration
20319 (enum_body): Put an opt_comma here instead of putting it on
20320 enum_body or enum_member_declarations so we can handle trailing
20321 commas on enumeration members. Gets rid of a shift/reduce.
20323 (type_list): Need a COMMA in the middle.
20325 (indexer_declaration): Tell tokenizer to recognize get/set
20327 * Remove old targets.
20329 * Re-add the parser target.
20331 2001-07-13 Simon Cozens <simon@simon-cozens.org>
20333 * cs-parser.jay: Add precendence rules for a number of operators
20334 ot reduce the number of shift/reduce conflicts in the grammar.
20336 2001-07-17 Miguel de Icaza <miguel@ximian.com>
20338 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
20341 Get rid of old crufty code.
20343 * rootcontext.cs: Use this to keep track of the parsed
20344 representation and the defined types available to the program.
20346 * gen-treedump.cs: adjust for new convention.
20348 * type.cs: Split out the type manager, and the assembly builder
20351 * typemanager.cs: the type manager will live here now.
20353 * cil-codegen.cs: And the code generator here.
20355 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
20357 * makefile: Fixed up for easy making.
20359 2001-07-13 Simon Cozens <simon@simon-cozens.org>
20361 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
20364 (unary_expression): Expand pre_increment_expression and
20365 post_decrement_expression to reduce a shift/reduce.
20367 2001-07-11 Simon Cozens
20369 * cs-tokenizer.cs: Hex numbers should begin with a 0.
20371 Improve allow_keyword_as_indent name.
20373 2001-06-19 Miguel de Icaza <miguel@ximian.com>
20375 * Adjustments for Beta2.
20377 2001-06-13 Miguel de Icaza <miguel@ximian.com>
20379 * decl.cs: Added `Define' abstract method.
20380 (InTransit): new property, used to catch recursive definitions.
20382 * interface.cs: Implement `Define'.
20384 * modifiers.cs: Map Modifiers.constants to
20385 System.Reflection.TypeAttribute flags.
20387 * class.cs: Keep track of types and user-defined types.
20388 (BuilderInit): New method for creating an assembly
20389 (ResolveType): New function to launch the resolution process, only
20390 used by interfaces for now.
20392 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
20393 that are inserted into the name space.
20395 2001-06-08 Miguel de Icaza <miguel@ximian.com>
20397 * ARGH. I have screwed up my tree so many times due to the use of
20398 rsync rather than using CVS. Going to fix this at once.
20400 * driver.cs: Objetify driver. Load assemblies, use assemblies to
20403 2001-06-07 Miguel de Icaza <miguel@ximian.com>
20405 * Experiment successful: Use System.Type rather that our own
20408 2001-05-25 Miguel de Icaza <miguel@ximian.com>
20410 * cs-parser.jay: Removed nsAliases from here.
20412 Use new namespaces, handle `using XXX;'
20414 * namespace.cs: Reimplemented namespace handling, use a recursive
20415 definition of the class. Now we can keep track of using clauses
20416 and catch invalid using clauses.
20418 2001-05-24 Miguel de Icaza <miguel@ximian.com>
20420 * gen-treedump.cs: Adapted for all the renaming.
20422 * expression.cs (Expression): this class now has a Type property
20423 which returns an expression Type.
20425 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
20426 `Type', as this has a different meaning now in the base
20428 2001-05-22 Miguel de Icaza <miguel@ximian.com>
20430 * interface.cs, class.cs: Removed from all the sources the
20431 references to signature computation, as we can not do method
20432 signature computation during the parsing time, as we are not
20433 trying to solve at that point distinguishing:
20437 void a (NS.Blah x) {}
20440 Which depending on the context might be valid or not, as we do not
20441 know if Blah is the same thing as NS.Blah at that point.
20443 * Redid everything so the code uses TypeRefs now instead of
20444 Types. TypeRefs are just temporary type placeholders, that need
20445 to be resolved. They initially have a pointer to a string and the
20446 current scope in which they are used. This is used later by the
20447 compiler to resolve the reference to an actual Type.
20449 * DeclSpace is no longer a CIR.Type, and neither are
20450 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
20451 are all DeclSpaces, but no Types.
20453 * type.cs (TypeRefManager): This implements the TypeRef manager,
20454 which keeps track of all the types that need to be resolved after
20455 the parsing has finished.
20457 2001-05-13 Miguel de Icaza <miguel@ximian.com>
20459 * ARGH. We are going to have to store `foreach' as a class rather
20460 than resolving it, as we need to verify error 1579 after name
20461 resolution. *OR* we could keep a flag that says `This request to
20462 IEnumerator comes from a foreach statement' which we can then use
20463 to generate the error.
20465 2001-05-10 Miguel de Icaza <miguel@ximian.com>
20467 * class.cs (TypeContainer.AddMethod): we now add methods to the
20468 MethodGroup instead of the method hashtable.
20470 * expression.cs: Add MethodGroup abstraction, which gets us one
20471 step closer to the specification in the way we handle method
20474 * cs-parser.jay (primary_expression): qualified_identifier now
20475 tried to match up an identifier to a local variable reference or
20476 to a parameter reference.
20478 current_local_parameters is now a parser global variable that
20479 points to the current parameters for the block, used during name
20482 (property_declaration): Now creates an implicit `value' argument to
20485 2001-05-09 Miguel de Icaza <miguel@ximian.com>
20487 * parameter.cs: Do not use `param' arguments as part of the
20488 signature, per the spec.
20490 2001-05-08 Miguel de Icaza <miguel@ximian.com>
20492 * decl.cs: Base class for classes, structs and interfaces. This
20493 is the "Declaration Space"
20495 * cs-parser.jay: Use CheckDef for checking declaration errors
20496 instead of having one on each function.
20498 * class.cs: Factor out some code for handling error handling in
20499 accordance to the "Declarations" section in the "Basic Concepts"
20500 chapter in the ECMA C# spec.
20502 * interface.cs: Make all interface member classes derive from
20503 InterfaceMemberBase.
20505 2001-05-07 Miguel de Icaza <miguel@ximian.com>
20507 * Many things: all interfaces are parsed and generated in
20508 gen-treedump. Support for member variables, constructors,
20509 destructors, properties, constants is there.
20511 Beginning of the IL backend, but very little done, just there for
20514 2001-04-29 Miguel de Icaza <miguel@ximian.com>
20516 * cs-parser.jay: Fix labeled statement.
20518 * cs-tokenizer.cs (escape): Escape " and ' always.
20519 ref_line, ref_name: keep track of the line/filename as instructed
20520 by #line by the compiler.
20523 2001-04-27 Miguel de Icaza <miguel@ximian.com>
20525 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
20526 to match the values in System.CodeDOM.
20528 Divid renamed to Divide.
20530 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
20532 (Statements.set): remove.
20534 * System.CodeDOM/CodeCatchClause.cs: always have a valid
20537 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
20538 falseStatements always have valid values.
20540 * cs-parser.jay: Use System.CodeDOM now.