1 2005-06-10 Ben Maurer <bmaurer@ximian.com>
3 * FileTest.cs: Fix gonz's typo. Also, clean stuff up by using the
4 temp file api, rather than our own hack.
6 2005-06-05 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8 * FileTest.cs: yet more invalid array accesses removed.
10 2005-06-05 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12 * FileTest.cs: on unix there are no invalid chars and we were trying
13 to index beyond the end of the array.
15 2005-06-05 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17 * FileTest.cs: removed duplicate test. The same thing is done in
20 2005-05-18 Sebastien Pouliot <sebastien@ximian.com>
22 * StreamCas.cs: New. CAS unit tests to test stack propagation for
23 BeginRead and BeginWrite.
24 * FileStreamCas.cs: Added tests to test stack propagation for
25 BeginRead and BeginWrite.
27 2005-05-09 Sebastien Pouliot <sebastien@ximian.com>
29 * DirectoryCas.cs: Fixed IsRunningOnWindows (inversed logic). That
30 didn't change the tests as the SecurityException occurs before the
31 parameters are checked (when all goes well ;-). Fixed for NET_2_0 too.
32 * DirectoryInfoTest.cs: Fixed PlatformID.Unix for NET_2_0.
34 2005-05-06 Ben Maurer <bmaurer@ximian.com>
36 * FileTest.cs (OpenAppend): Test for #71088.
38 2005-04-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
40 * DirectoryInfoTest.cs: added test for bug #53173.
42 2005-04-09 Miguel de Icaza <miguel@novell.com>
44 * StreamWriterTest.cs: New test for bug #74513.
46 2005-03-24 Sebastien Pouliot <sebastien@ximian.com>
48 * DirectoryCas.cs: Added partial trust unit tests.
49 * DirectoryTest.cs: Added missing [Test] attribute to
50 SetCreationTimeException1.
51 * FileStreamCas.cs: New. CAS unit tests for FileStream.
52 * PathCas.cs: New. CAS unit tests for Path.
53 * PathTest.cs: Splitted TestGetPathRoot test in two so the second part
54 could be re-used in partial trust tests.
56 2005-03-15 Sebastien Pouliot <sebastien@ximian.com>
58 * FileStreamTest.cs: Added tests for all FileMode when a directory
59 doesn't exists. Added a test for UnauthorizedAccessException when a
60 directory is opened as a file.
62 2005-01-28 Sebastien Pouliot <sebastien@ximian.com>
64 * FileLoadExceptionCas.cs: Fixed failures under MS for NET_1_1.
65 * FileNotFoundExceptionCas.cs: Fixed failures under MS for NET_1_1.
67 2005-03-02 Raja R Harinath <rharinath@novell.com>
69 * FileStreamTest.cs (Constructor_InvalidFileHandle): Fix to work
72 2005-02-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
74 * FileTest.cs: test for invalid characters in file names.
76 2005-01-28 Sebastien Pouliot <sebastien@ximian.com>
78 * DirectoryCas.cs: New. Very limited permission tests for Directory.
79 Actually it's only there to support tests for System.Environment.
80 * FileLoadExceptionCas.cs: New. Permission tests for FileLoadException
81 * FileNotFoundExceptionCas.cs: New. Permission tests for
82 FileNotFoundException.
84 2005-01-19 Nick Drochak <ndrochak@gol.com>
86 * FileStreamTest.cs: Fix test regression on .NET. Need to close
87 stream so other tests don't fail.
89 2004-12-06 Atsushi Enomoto <atsushi@ximian.com>
91 * TextWriterTest.cs : added.
93 2004-12-04 Ben Maurer <bmaurer@ximian.com>
95 * DirectoryInfoTest.cs: Check for CreateSubdirectory with empty string.
97 2004-08-31 Nick Drochak <ndrochak@gol.com>
99 * StringWriterTest.cs: Eliminate ambiguity so csc can compile.
101 2004-06-21 Atsushi Enomoto <atsushi@ximian.com>
103 * FileStreamTest.cs : Added some tests on .ctor() without FileShare.
105 2004-06-21 Atsushi Enomoto <atsushi@ximian.com>
107 FileInfoTest.cs : more '/' and Path.DirectorySeparatorChar fixes
109 2004-06-21 Atsushi Enomoto <atsushi@ximian.com>
111 * DirectoryInfoTest.cs,
114 FileSystemInfoTest.cs:
115 Replace all '/' in path with Path.DirectorySeparatorChar.
117 2004-06-08 Duncan Mak <duncan@ximian.com>
119 * DirectoryTest.cs (GetParentOfRootDirectory): Add test for
120 GetParent from the root directory.
122 2004-06-07 Duncan Mak <duncan@ximian.com>
124 * FileStreamTest.cs (SetLengthWithClosedBaseStream): New test for
125 checking that the correct exception is thrown when the base stream
128 2004-06-03 Sebastien Pouliot <sebastien@ximian.com>
130 * BufferedStreamTest.cs: Modified two tests (using newer helper
131 classes) to be more specific and avoid regressions of bugs like
133 * StreamHelperTest.cs: New. Helper classes that provides read-only,
134 write-only or non-seekable stream.
136 2004-05-31 Sebastien Pouliot <sebastien@ximian.com>
138 * FileTest.cs: Added tests to confirm that Exists never throws
139 exceptions even for invalid filenames or for unexisting directories.
140 * PathTest.cs: Added windows-specific tests that shows that
141 ChangeExtension validate the input patch but doesn't validate the
144 2004-05-30 Sebastien Pouliot <sebastien@ximian.com>
146 * BufferedStreamTest.cs: Added tests for Position after SetLength,
147 SetLength after Close and Seek logic exception handling.
148 * FileStream.cs: Added test for invalid SeekOrigin in Seek. Lots of
149 new tests for exception handling (negatives, disposed) and test
150 reading a byte ast the end of the stream.
151 * MemoryStream.cs: Added test for Seek after Close.
153 2004-05-29 Sebastien Pouliot <sebastien@ximian.com>
155 * BinaryReader.cs: Added new cases to check exceptions thrown by Read
158 2004-05-26 Atsushi Enomoto <atsushi@ximian.com>
160 * FileInfoTest.cs : more incorrect \ fix.
162 2004-05-26 Sebastien Pouliot <sebastien@ximian.com>
164 * BufferedStreamTest.cs: Added new unit tests for exceptions.
165 * FileStreamTest.cs: Added new tests for integer overflow checks.
166 * StringReaderTest.cs: Added new tests for integer overflow checks.
168 2003-05-26 Atsushi Enomoto <atsushi@ximian.com>
170 * FileInfoTest.cs : incorrect \ fix. added more cases.
172 2003-05-26 Atsushi Enomoto <atsushi@ximian.com>
174 * FileInfoTest.cs : added tests for ToString().
176 2004-05-25 Gonzalo Paniagua Javier <gonzalo@ximian.com>
178 * DirectoryTest.cs: added test from bug 58875.
180 2004-05-24 Sebastien Pouliot <sebastien@ximian.com>
182 * MemoryStreamTest.cs: Test that we zeroize old data when we manipulate
183 the length of the stream. Verify that we throw the same exceptions as
185 * StreamReaderTest.cs: New tests for integer overflow and null handling
186 * StreamWriterTest.cs: New tests for integer overflow, disposed
187 exceptions and null handling.
188 * StringWriterTest.cs: New tests for integer overflow and disposed
191 2004-05-20 Sebastien Pouliot <sebastien@ximian.com>
193 * MemoryStream.cs: SetUp is now public (required for new nunit).
195 2004-05-20 Jackson Harper <jackson@ximian.com>
197 * DirectoryInfoTest.cs: Add test for CreateSubdirectory.
199 2004-04-12 David Sheldon <dave-mono@earth.li>
201 * BinaryReaderTest.cs: Changed series of bytes in
202 ReadDecimal to be a cleaner representation of a real
203 decimal, as was not a technically correct decimal.
205 2004-04-01 Lluis Sanchez Gual <lluis@ximian.com>
207 * BufferedStreamTest.cs: Added test for Position.
209 2003-04-03 Atsushi Enomoto <atsushi@ximian.com>
211 * PathTest.cs : Added more patterns on TestChangeExtension().
213 2004-02-16 Jackson Harper <jackson@ximian.com>
215 * FileTest.cs: We do not need to convert to local time because we
216 are getting creation time, not utc time.
218 2004-01-31 David Sheldon <dave-mono@earth.li>
220 * FileSystemInfoTest.cs: Added code to skip CreationTime tests
221 on Unix, as it doesn't support them.
223 2004-01-31 David Sheldon <dave-mono@earth.li>
225 * FileSystemInfoTest.cs: Change tests for default times to
226 be TimeZone agnostic by conversion to universal time before
229 2004-01-22 David Sheldon <dave-mono@earth.li>
231 * FileStreamTest.cs: CtorArgumentOutOfRangeException4, we were
232 testing for this ecveption, but the other parameters were also
233 invalid. Made them correct. We don't care that MS throw
234 exceptions in a different order do we?
236 2004-01-22 David Sheldon <dave-mono@earth.li>
238 * DirectoryTest.cs: Added Ignore to the CreationTime tests,
239 as Unix filesystems don't support them. Should we only ignore
242 2004-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
244 * PathTest.cs: added some unix-only tests for GetFullPath.
246 2004-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
248 * PathTest.cs: a couple of tests for bugs.
250 2003-01-06 Atsushi Enomoto <atsushi@ximian.com>
252 * DirectoryTest.cs : remoed incorrect args.
254 2003-12-25 Atsushi Enomoto <atsushi@ximian.com>
256 * PathTest.cs : On Unix, "Z:" can be valid local file.
257 And cosmetic character case fix.
259 2003-12-19 Nick Drochak <ndrochak@gol.com>
261 * PathTest.cs: Make tests pass on .NET 1.1. Probably still
262 need to handle different directory and volume separators for
265 2003-12-17 Atsushi Enomoto <atsushi@ximian.com>
268 Added more GetPathRoot and GetFullPath tests for windows.
269 Fixed incorrectly specified arguments in the previous patch.
271 2003-12-17 Atsushi Enomoto <atsushi@ximian.com>
273 * PathTest.cs : Added more tests for IsPathRooted, HasExtension
276 2003-12-17 Atsushi Enomoto <atsushi@ximian.com>
278 * DirectoryTests.cs : Added some SetCurrentDirectory tests.
280 2003-12-17 Nick Drochak <ndrochak@gol.com>
282 * FileStreamTest.cs: Ok, it wasn't a 1.1 thing. The test simply would
283 fail randomly because location 12 was sometimes a file handle.
285 2003-12-16 Nick Drochak <ndrochak@gol.com>
287 * FileStreamTest.cs: Exception not thrown in .NET 1.1.
288 And Happy Birthday to Me!
290 2003-11-15 Gonzalo Paniagua Javier <gonzalo@ximian.com>
292 * StringReaderTest.cs: added test from bug #51020.
294 2003-10-21 Nick Drochak <ndrochak@gol.com>
296 * BufferedSTreamTest.cs: Make TearDown smarter about possible
299 2003-07-10 Gonzalo Paniagua Javier <gonzalo@ximian.com>
301 * MemoryStreamTest.cs: added a couple of tests for WriteByte.
303 2003-06-30 Zoltan Varga <vargaz@freemail.hu>
305 * FileStreamTest.cs: New tests for flushing when disposed and zero
308 2003-06-18 Nick Drochak <ndrochak@gol.com>
310 * FileSystemInfoTest.cs: Simplify a bit.
312 2003-06-18 Nick Drochak <ndrochak@gol.com>
314 * FileSystemInfoTest.cs: Works on .NET 1.1 now. If these values are
315 different on 1.0 then we need to wrap with a #if NET_1_1.
317 2003-06-12 Zoltan Varga <vargaz@freemail.hu>
319 * FileStreamTest.cs: New tests for recently fixed bugs.
321 2003-06-08 Ville Palo <vi64pa@kolumbus.fi>
323 * BinaryWriterTest.cs:
324 * BinaryReaderTest.cs:
326 * FileTest.cs: now works with ms.net, clean ups, nunit2, ...
328 2003-05-29 Nick Drochak <ndrochak@gol.com>
330 * ms_run_test.sh: added .NET verion of helper script
331 * BinaryReaderTest.cs: fix my oversight
332 * BinaryWriterTest.cs: cleanups
333 * BufferedStreamTest.cs: cleanups
334 * DirectoryInfoTest.cs: cleanups
335 * DirectoryTest.cs: cleanups
336 * FileStreamTest.cs: cleanups
338 2003-05-29 Nick Drochak <ndrochak@gol.com>
340 * BinaryReaderTest.cs:
341 * BinaryWriterTest.cs:
342 * DirectoryInfoTest.cs:
346 * FileSystemInfoTest.cs: Stop throwing exceptions on windows, and sub-
347 class from Assertion for brevity.
349 2003-05-22 Ben Maurer <bmaurer@users.sourceforge.net>
350 StringWriterTest.cs: Added tests from bug #43431 (by Ian MacLean).
352 2003-05-22 Nick Drochak <ndrochak@gol.com>
354 * StreamReaderTest.cs:
355 * StreamWriterTest.cs: Forgot nunit v2 TestFixture attribute
357 2003-05-22 Zoltan Varga <vargaz@freemail.hu>
359 * FileTest.cs: Added tests for moving directories.
361 2003-05-20 Nick Drochak <ndrochak@gol.com>
364 * StreamReaderTest.cs:
365 * StreamWriterTest.cs: Workaround for process holding on to directory
366 that prevented cleanup and deletion.
368 2003-05-19 Ville Palo <vi64pa@kolumbus.fi>
370 * DirectoryTest.cs: Added tests for GetDirectories() and
373 2003-05-18 Ben Maurer <bmaurer@users.sourceforge.net>
374 * *.cs Cleaned up tests to work around bug that prevented
375 System.IO from seeing directories starting with '.'
377 2003-05-15 Ville Palo <vi64pa@kolumbus.fi>
379 * FileStreamTest.cs: more cleaning
381 2003-05-15 Ville Palo <vi64pa@kolumbus.fi>
383 * StreamReaderTest.cs:
384 * StreamWriterTest.cs: now use temp-dir
386 2003-05-15 Ville Palo <vi64pa@kolumbus.fi>
388 * BinaryReaderTest.cs:
389 * BinaryWriterTest.cs:
390 * BufferedStreamTest.cs:
391 * DirectoryInfoTest.cs:
394 * FileSystemInfoTest.cs: clean up, now use temp-dir
396 2003-05-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
398 * PathTest.cs: added test for GetFullPath (".") and ".."
400 2003-05-13 Ville Palo <vi64pa@kolumbus.fi>
403 * FileTest.cs: Clean up. Now use temp directory. also some nunit2
406 2003-05-98 Ville Palo <vi64pa@kolumbus.fi>
408 * FileSystemInfoTest.cs; new file
410 2003-05-07 Ben Maurer <bmaurer@users.sourceforge.net>
412 Even more GetFullPath () tests. Includes UNC tests.
414 2003-05-06 Ville Palo <vi64pa@kolumbus.fi>
416 * DirectoryInfoTest.cs: Removed OS-specific test
418 2003-05-06 Ville Palo <vi64pa@kolumbus.fi>
420 * DirectoryTest: Fixed Utc errors
421 * FileTest: Fixes Utc errors. Now these tests works in other
424 2003-05-04 Ben Maurer <bmaurer@users.sourceforge.net>
426 Added new tests for GetFullPath () that include a path with
429 2003-05-05 Ville Palo <vi64pa@kolumbus.fi>
431 * DirectoryInfoTest.cs: new file.
433 2003-05-04 Ville Palo <vi64pa@kolumbus.fi>
435 * FileInfoTest.cs: new file.
436 * FileStreamTest.cs: new tests for Seek ()
438 2003-04-29 Ville Palo <vi64pa@kolumbus.fi>
440 * FileStreamTest.cs: Tests for Flush() adn one one more test for
443 2003-04-25 Ville Palo <vi64pa@kolumbus.fi>
445 * FileTest.cs: more tests..
447 2003-04-24 Ville Palo <vi64pa@kolumbus.fi>
449 * FileTest.cs: Fixed tests and added some.
451 2003-04-22 Ville Palo <vi64pa@kolumbus.fi>
453 * FileTest.cs: More tests.
455 2003-04-21 Ville Palo <vi64pa@kolumbus.fi>
457 * DirectoryTest.cs: lots of new tests. and some fixes and clean ups
459 2003-04-20 Miguel de Icaza <miguel@ximian.com>
461 * StringReaderTest.cs: Update test to include read-past-the-end
463 2003-04-20 Ville Palo <vi64pa@kolumbus.fi>
465 * DirectoryTest.cs: new file
467 2003-04-16 Ville Palo <vi64pa@kolumbus.fi>
469 * BufferedStreamTest.cs: new file
471 2003-04-14 Ville Palo <vi64pa@kolumbus.fi>
473 * BinaryWriterTest.cs: Added new file.
475 2003-04-13 Ville Palo <vi64pa@kolumbus.fi>
477 * BinaryReaderTest.cs: Added lots of tests. Somehow I missed that
478 there are already testcases for BinaryStreamReader :/
480 2003-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
482 * FileStreamTest.cs: added more tests by Gert Driesen
483 (gert.driesen@ardatis.com).
485 2003-04-12 Ville Palo <vi64pa@kolumbus.fi>
487 * FileStreamTest.cs More tests.
489 2003-04-11 Ville Palo <vi64pa@kolumbus.fi>
491 * FileStreamTest.cs: File Added and some tests in it.
493 2003-04-11 Ville Palo <vi64pa@kolumbus.fi>
495 * StringReaderTest.cs: Tests for close and some exceptions
497 2003-04-11 Ville Palo <vi64pa@kolumbus.fi>
499 * StringWriterTest.cs: Added some Exception tests.
501 2003-04-10 Ville Palo <vi64pa@kolumbus.fi>
503 * StringWriterTest.cs: Added couple of tests.
505 2003-04-05 Nick Drochak <ndrochak@gol.com>
507 * PathTest.cs: Use nunit2 convention for exception test.
509 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
511 * StreamReaderTest.cs: added test for exception when the nase stream is
512 closed. Make the reader.CurrentEncoding test work.
514 2003-03-05 Dick Porter <dick@ximian.com>
516 * MemoryStreamTest.cs: Some more tests
518 2003-03-05 Gonzalo Paniagua Javier <gonzalo@ximian.com>
520 * MemoryStreamTest.cs: some nunit2 love. Added a bunch of new tests.
522 2003-02-05 Nick Drochak <ndrochak@gol.com>
524 * FileTest.cs: Have setup remove files before testing as well in case
525 tests were interrupted before TearDown could be called in a previous
526 run. Also test for specific exception in TestGetCreationTime ().
528 2003-01-28 Zoltan Varga <vargaz@freemail.hu>
530 * FileTest.cs: Added tests for GetCreationTime.
532 2002-12-21 Nick Drochak <ndrochak@gol.com>
534 * all: make tests build and run under nunit2
536 2002-09-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
538 * PathTest.cs: added test for null argument in IsPathRooted.
540 2002-09-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
542 * BinaryReaderTest.cs: added more tests.
544 Patch from Eduardo GarcĂa Cebollero (kiwnix@yahoo.es).
546 2002-09-19 Nick Drochak <ndrochak@gol.com>
548 * StreamReaderTest.cs: Pinpoint error closing streams
550 2002-09-10 Gonzalo Paniagua Javier <gonzalo@ximian.com>
552 * FileTest.cs: don't leave AFile.txt open.
554 2002-09-08 Nick Drochak <ndrochak@gol.com>
556 * PathTest.cs (TestCombine): XP puts it's system root in WINDOWS not
559 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
561 * PathTest.cs: some fixes to make it work also on unix.
563 2002-08-30 Nick Drochak <ndrochak@gol.com>
565 * PathTest.cs (TestGetPathRoot): Don't assume current directory will
566 be on the C: drive (mine wasn't).
568 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
570 * PathTest.cs: improved.
572 2002-08-26 Nick Drochak <ndrochak@gol.com>
574 * BinaryReaderTest.cs: Closing the stream twice doesn not throw any
577 2002-08-17 Eduardo Garcia Cebollero <kiwnix@yahoo.es>
579 * AllTests.cs: added BinaryReaderTest.Suite.
580 * BinaryReaderTest.cs: New file.
582 2002-06-12 Nick Drochak <ndrochak@gol.com>
584 * StringReaderTest.cs: Regression test for a bug that we had were
585 ReadLine() was not returning null when the string ended with newline.
587 2002-05-15 Nick Drochak <ndrochak@gol.com>
589 * StreamReaderTest.cs:
590 * StreamWriterTest.cs:
591 Make sure invalid file name has invalid characters in it. These are
594 2002-05-14 Nick Drochak <ndrochak@gol.com>
596 * FileTest.cs: Delete temporary files after each test method; Catch
597 unexpected exceptions and report them; Make some Assert messages
598 unique; Make sure temp files exist before trying Move and Delete, etc.
600 2002-05-13 Mike Gray <mike@mikegray.org>
602 * FileTest.cs: Adding better tests for File.Delete, File.Move
604 2002-05-12 Mike Gray <mike@mikegray.org>
606 * FileTest.cs: Adding better tests for File.Exists, File.Create,
609 2002-05-12 Nick Drochak <ndrochak@gol.com>
611 * StringTest.cs: Add a couple more tests.
612 * PathTest.cs: Make tests work a bit better on W32 and Linux.
614 2002/05/10 Nick Drochak <ndrochak@gol.com>
616 * StreamWriterTest.cs: Use "resources" directory and use OS friendly
617 directory separator characters. This makes the tests run correctly
618 against MS.NET, but not yet in mono on Linux.
620 2002/05/08 Nick Drochak <ndrochak@gol.com>
622 * FileTest.cs: Use "resources" directory and use OS friendly
623 directory separator characters. This makes the tests run correctly
624 against MS.NET, but not yet in mono on Linux.
626 2002-05-08 Nick Drochak <ndrochak@gol.com>
628 * StreamWriter.cs: Wrap a try-catch around block of code to find out
629 what exception is being thrown when it shouldn't.
631 2002-05-07 Nick Drochak <ndrochak@gol.com>
633 * FileTest.cs: Added TestOpen() from Mike Gray.
634 * AllTests.cs: Added missing FileTest.Suite as pointed out by Mike
637 2002-05-05 Nick Drochak <ndrochak@gol.com>
639 * StreamReaderTest.cs: Change location of sample file. In some places,
640 use memory stream instead of file stream to eliminate reliance on file
641 io for now. That area is still a bit immature. Added a bunch of
642 markers to tell where errors were occuring.
644 * resources: New directory to hold files open/read, etc. by unit
647 2002-05-01 Nick Drochak <ndrochak@gol.com>
649 * StreamReaderTest.cs:
650 * StreamWriterTest.cs: Catch and display exception info where it wasn't
653 2002-03-02 Jason Diamond <jason@injektilo.org>
655 * StringReader.cs: Added test for peeking and reading at the end of
658 2002-02-28 Nick Drochak <ndrochak@gol.com>
660 * MemoryStreamTest.cs
661 * StreamWriterTest.cs
662 * StringReaderTest.cs: Fix test bugs found by running against mscorlib.
663 AssertEquals() requires the expected and atual values to be the same
664 type if they are to be considered equal.
666 2002-02-05 Duncan Mak <duncan@ximian.com>
668 * FileTest.cs: Added to CVS. However, this portion of the code
669 can't be tested right now.
671 2002-01-20 Nick Drochak <ndrochak@gol.com>
673 * AllTests.cs: removed duplicate MemoryStream test
674 * MemoryStreamTest.cs: wrapped try-catch blocks around read/write/seek
675 tests. These were throwing exceptions that NUnit wasn't catching. I
676 don't think it used to behave this way before .NET.1.0.
677 2003-05-04 Ben Maurer <bmaurer@users.sourceforge.net>
679 (CanonicalizePath) Added optimizations per Miguel's requests.