Add comments to make it clear why these two lines are written like that:

[coreboot.git] / src / cpu / intel / model_106cx / cache_as_ram.inc

diff --git a/src/cpu/intel/model_106cx/cache_as_ram.inc b/src/cpu/intel/model_106cx/cache_as_ram.inc
index 03e0c2671c17cb9cd3c33f86a19436434ba9ed4b..9b7cad0cf9150f7ed3b4c8efdac99875a011eaa1 100644 (file)
--- a/src/cpu/intel/model_106cx/cache_as_ram.inc
+++ b/src/cpu/intel/model_106cx/cache_as_ram.inc
@@ -97,6 +97,11 @@ clear_mtrrs:
 #else
 #define REAL_XIP_ROM_BASE CONFIG_XIP_ROM_BASE
 #endif
+       /*
+        * IMPORTANT: The two lines below can _not_ be written like this:
+        *   movl $(REAL_XIP_ROM_BASE | MTRR_TYPE_WRBACK), %eax
+        * http://www.coreboot.org/pipermail/coreboot/2010-October/060855.html
+        */
        movl    $REAL_XIP_ROM_BASE, %eax
        orl     $MTRR_TYPE_WRBACK, %eax
        wrmsr